- tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.5.0esr-14.0-1-build2
by ma1 (＠ma1) 25 Nov '24

25 Nov '24

ma1 pushed new tag mullvad-browser-128.5.0esr-14.0-1-build2 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.5.0esr-14.0-1] 4 commits: Bug 1836921 - Improve dialogs a=dmeehan
by ma1 (＠ma1) 25 Nov '24

25 Nov '24

ma1 pushed to branch mullvad-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 437543c6 by Arturo Mejia at 2024-11-25T15:21:36+01:00 Bug 1836921 - Improve dialogs a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D226961 Differential Revision: https://phabricator.services.mozilla.com/D228842 - - - - - 33f6b33b by Malte Juergens at 2024-11-25T15:21:38+01:00 Bug 1909396 - Remove HTTPS-Only exception button in iframes r=freddyb,fluent-reviewers Rationale for this can be read in Bug 1909396, but the main reason is that the iframe will get blocked regardless by mixed content blocking. Differential Revision: https://phabricator.services.mozilla.com/D220257 - - - - - 412bde12 by Makoto Kato at 2024-11-25T15:21:40+01:00 Bug 1776646 - Support EXTRA_IS_SENSITIVE for clipboard. r=geckoview-reviewers,owlish When nsITransferable.isPrivateData is true, such as coping password or private mode, we should set EXTRA_IS_SENSITIVE to ClipData. AndroidJunit test runner doesn't often get `ClipDescription.extras` from clipboard service in test runner. So we cannot write a unit test using AndroidJUnit test runner. Differential Revision: https://phabricator.services.mozilla.com/D225326 - - - - - 866130a7 by Cathy Lu at 2024-11-25T15:21:41+01:00 Bug 1914797 - Part 1 + 2 + partial backout (details below) Bug 1914797 - Part 1 - Revert bug 1868469 r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226431 Bug 1914797 - Part 2 - Add url change during onPageStart for slow loading sites r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226432 Backed out 1 changesets (bug 1914797) for causing Bug 1929028 Backed out changeset a79554879d7b (bug 1914797) - - - - - 16 changed files: - dom/ipc/WindowGlobalParent.cpp - dom/security/test/https-only/browser.toml - + dom/security/test/https-only/browser_iframe_buttons.js - + dom/security/test/https-only/file_iframe_buttons.html - mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragment.kt - mobile/android/android-components/components/feature/app-links/src/test/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragmentTest.kt - mobile/android/android-components/components/feature/session/src/main/java/mozilla/components/feature/session/SessionUseCases.kt - mobile/android/android-components/components/feature/session/src/test/java/mozilla/components/feature/session/SessionUseCasesTest.kt - mobile/android/android-components/docs/changelog.md - mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CrashReportingTest.kt - mobile/android/geckoview/src/main/java/org/mozilla/gecko/Clipboard.java - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoInputConnection.java - toolkit/components/httpsonlyerror/content/errorpage.html - toolkit/components/httpsonlyerror/content/errorpage.js - toolkit/locales/en-US/toolkit/about/aboutHttpsOnlyError.ftl - widget/android/nsClipboard.cpp Changes: ===================================== dom/ipc/WindowGlobalParent.cpp ===================================== @@ -1378,18 +1378,11 @@ mozilla::ipc::IPCResult WindowGlobalParent::RecvReloadWithHttpsOnlyException() { return IPC_FAIL(this, "HTTPS-only mode: Illegal state"); } - // If the error page is within an iFrame, we create an exception for whatever - // scheme the top-level site is currently on, because the user wants to - // unbreak the iFrame and not the top-level page. When the error page shows up - // on a top-level request, then we replace the scheme with http, because the - // user wants to unbreak the whole page. + // We replace the scheme with http, because the user wants to unbreak the + // whole page. nsCOMPtr<nsIURI> newURI; - if (!BrowsingContext()->IsTop()) { - newURI = innerURI; - } else { - Unused << NS_MutateURI(innerURI).SetScheme("http"_ns).Finalize( - getter_AddRefs(newURI)); - } + Unused << NS_MutateURI(innerURI).SetScheme("http"_ns).Finalize( + getter_AddRefs(newURI)); OriginAttributes originAttributes = TopWindowContext()->DocumentPrincipal()->OriginAttributesRef(); ===================================== dom/security/test/https-only/browser.toml ===================================== @@ -29,6 +29,9 @@ support-files = [ ["browser_httpsonly_speculative_connect.js"] support-files = ["file_httpsonly_speculative_connect.html"] +["browser_iframe_buttons.js"] +support-files = ["file_iframe_buttons.html"] + ["browser_iframe_test.js"] skip-if = [ "os == 'linux' && bits == 64", # Bug 1735565 ===================================== dom/security/test/https-only/browser_iframe_buttons.js ===================================== @@ -0,0 +1,50 @@ +/* Any copyright is dedicated to the Public Domain. + https://creativecommons.org/publicdomain/zero/1.0/ */ + +"use strict"; + +// Ensure the buttons at the buttom of the HTTPS-Only error page do not get +// displayed in an iframe (Bug 1909396). + +add_task(async function test_iframe_buttons() { + await BrowserTestUtils.withNewTab( + "https://example.com/browser/dom/security/test/https-only/file_iframe_button…", + async function (browser) { + await SpecialPowers.pushPrefEnv({ + set: [["dom.security.https_only_mode", true]], + }); + + await SpecialPowers.spawn(browser, [], async function () { + const iframe = content.document.getElementById("iframe"); + // eslint-disable-next-line @microsoft/sdl/no-insecure-url + iframe.src = "http://nocert.example.com"; + + await ContentTaskUtils.waitForCondition( + () => iframe.contentWindow.document.readyState === "interactive", + "Iframe error page should have loaded" + ); + + ok( + !!iframe.contentWindow.document.getElementById("explanation-iframe"), + "#explanation-iframe should exist" + ); + + is( + iframe.contentWindow.document + .getElementById("explanation-iframe") + .getAttribute("hidden"), + null, + "#explanation-iframe should not be hidden" + ); + + for (const id of ["explanation-continue", "goBack", "openInsecure"]) { + is( + iframe.contentWindow.document.getElementById(id), + null, + `#${id} should have been removed` + ); + } + }); + } + ); +}); ===================================== dom/security/test/https-only/file_iframe_buttons.html ===================================== @@ -0,0 +1,9 @@ +<!DOCTYPE html> +<html lang="en"> +<head> + <meta charset="UTF-8"> +</head> +<body> + <iframe id="iframe" frameborder="0"></iframe> +</body> +</html> ===================================== mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragment.kt ===================================== @@ -11,6 +11,7 @@ import androidx.annotation.StringRes import androidx.annotation.StyleRes import androidx.annotation.VisibleForTesting import androidx.appcompat.app.AlertDialog +import mozilla.components.support.ktx.util.PromptAbuserDetector import mozilla.components.ui.widgets.withCenterAlignedButtons /** @@ -23,6 +24,10 @@ import mozilla.components.ui.widgets.withCenterAlignedButtons */ class SimpleRedirectDialogFragment : RedirectDialogFragment() { + @VisibleForTesting + internal var promptAbuserDetector = + PromptAbuserDetector(maxSuccessiveDialogSecondsLimit = TIME_SHOWN_OFFSET_SECONDS) + @VisibleForTesting internal var testingContext: Context? = null @@ -32,6 +37,8 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { return if (themeID == 0) AlertDialog.Builder(context) else AlertDialog.Builder(context, themeID) } + promptAbuserDetector.updateJSDialogAbusedState() + return with(requireBundle()) { val dialogTitleText = getInt(KEY_TITLE_TEXT, R.string.mozac_feature_applinks_normal_confirm_dialog_title) val dialogMessageString = getString(KEY_MESSAGE_STRING, "") @@ -40,18 +47,29 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { val themeResId = getInt(KEY_THEME_ID, 0) val cancelable = getBoolean(KEY_CANCELABLE, false) - getBuilder(themeResId) + val dialog = getBuilder(themeResId) .setTitle(dialogTitleText) .setMessage(dialogMessageString) - .setPositiveButton(positiveButtonText) { _, _ -> - onConfirmRedirect() - } + .setPositiveButton(positiveButtonText) { _, _ -> } .setNegativeButton(negativeButtonText) { _, _ -> onCancelRedirect() } .setCancelable(cancelable) .create() - .withCenterAlignedButtons() + + dialog.withCenterAlignedButtons() + dialog.setOnShowListener { + val okButton = dialog.getButton(AlertDialog.BUTTON_POSITIVE) + okButton.setOnClickListener { + if (promptAbuserDetector.areDialogsBeingAbused()) { + promptAbuserDetector.updateJSDialogAbusedState() + } else { + onConfirmRedirect() + dialog.dismiss() + } + } + } + dialog } } @@ -101,6 +119,7 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { const val KEY_THEME_ID = "KEY_THEME_ID" const val KEY_CANCELABLE = "KEY_CANCELABLE" + private const val TIME_SHOWN_OFFSET_SECONDS = 1 } private fun requireBundle(): Bundle { ===================================== mobile/android/android-components/components/feature/app-links/src/test/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragmentTest.kt ===================================== @@ -13,6 +13,7 @@ import mozilla.components.support.test.mock import mozilla.components.support.test.robolectric.testContext import org.junit.Assert.assertFalse import org.junit.Assert.assertTrue +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith import org.mockito.Mockito.doNothing @@ -27,6 +28,7 @@ class SimpleRedirectDialogFragmentTest { private val themeResId = appcompatR.style.Theme_AppCompat_Light @Test + @Ignore("This will be addressed in another follow up ticket") fun `Dialog confirmed callback is called correctly`() { var onConfirmCalled = false var onCancelCalled = false @@ -104,6 +106,7 @@ class SimpleRedirectDialogFragmentTest { assertFalse(onCancelCalled) } + @Suppress("unused") private fun mockFragmentManager(): FragmentManager { val fragmentManager: FragmentManager = mock() val transaction: FragmentTransaction = mock() ===================================== mobile/android/android-components/components/feature/session/src/main/java/mozilla/components/feature/session/SessionUseCases.kt ===================================== @@ -4,7 +4,6 @@ package mozilla.components.feature.session -import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.action.CrashAction import mozilla.components.browser.state.action.EngineAction import mozilla.components.browser.state.action.LastAccessAction @@ -94,13 +93,6 @@ class SessionUseCases( flags = flags, additionalHeaders = additionalHeaders, ) - // Update the url in content immediately until the engine updates with any new changes to the state. - store.dispatch( - ContentAction.UpdateUrlAction( - loadSessionId, - url, - ), - ) store.dispatch( EngineAction.OptimizedLoadUrlTriggeredAction( loadSessionId, ===================================== mobile/android/android-components/components/feature/session/src/test/java/mozilla/components/feature/session/SessionUseCasesTest.kt ===================================== @@ -11,7 +11,6 @@ import mozilla.components.browser.state.action.EngineAction import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.engine.EngineMiddleware import mozilla.components.browser.state.selector.findTab -import mozilla.components.browser.state.selector.selectedTab import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.TabSessionState import mozilla.components.browser.state.state.createCustomTab @@ -81,7 +80,6 @@ class SessionUseCasesTest { assertEquals("mozilla", action.tabId) assertEquals("https://getpocket.com", action.url) } - assertEquals("https://getpocket.com", store.state.selectedTab?.content?.url) useCases.loadUrl("https://www.mozilla.org", LoadUrlFlags.select(LoadUrlFlags.EXTERNAL)) store.waitUntilIdle() @@ -95,7 +93,6 @@ class SessionUseCasesTest { assertEquals("https://www.mozilla.org", action.url) assertEquals(LoadUrlFlags.select(LoadUrlFlags.EXTERNAL), action.flags) } - assertEquals("https://www.mozilla.org", store.state.selectedTab?.content?.url) useCases.loadUrl("https://firefox.com", store.state.selectedTabId) store.waitUntilIdle() @@ -105,7 +102,6 @@ class SessionUseCasesTest { assertEquals("mozilla", action.tabId) assertEquals("https://firefox.com", action.url) } - assertEquals("https://firefox.com", store.state.selectedTab?.content?.url) useCases.loadUrl.invoke( "https://developer.mozilla.org", ===================================== mobile/android/android-components/docs/changelog.md ===================================== @@ -109,9 +109,6 @@ permalink: /changelog/ * **feature-customtabs** * Fallback behaviour when failing to open a new window in custom tab will now be loading the URL directly in the same custom tab. [Bug 1832357](https://bugzilla.mozilla.org/show_bug.cgi?id=1832357) -* **feature-session** - * Update URL in the store immediately when using the optimized load URL code path. - * **tooling-lint** * Added a lint rule to detect when `Response#close` may not have been called. Note: Currently, this rule only runs on Android Components. ===================================== mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CrashReportingTest.kt ===================================== @@ -83,7 +83,7 @@ class CrashReportingTest : TestSetup() { verifyPageContent(tabCrashMessage) }.openTabDrawer(activityTestRule) { verifyExistingOpenTabs(firstWebPage.title) - verifyExistingOpenTabs("about:crashcontent") + verifyExistingOpenTabs(secondWebPage.title) }.closeTabDrawer { }.goToHomescreen { verifyExistingTopSitesList() ===================================== mobile/android/geckoview/src/main/java/org/mozilla/gecko/Clipboard.java ===================================== @@ -11,6 +11,7 @@ import android.content.ClipboardManager.OnPrimaryClipChangedListener; import android.content.Context; import android.content.res.AssetFileDescriptor; import android.os.Build; +import android.os.PersistableBundle; import android.text.TextUtils; import android.util.Log; import java.io.ByteArrayOutputStream; @@ -133,8 +134,9 @@ public final class Clipboard { * @return true if copy is successful. */ @WrapForJNI(calledFrom = "gecko") - public static boolean setText(final Context context, final CharSequence text) { - return setData(context, ClipData.newPlainText("text", text)); + public static boolean setText( + final Context context, final CharSequence text, final boolean isPrivateData) { + return setData(context, ClipData.newPlainText("text", text), isPrivateData); } /** @@ -147,8 +149,11 @@ public final class Clipboard { */ @WrapForJNI(calledFrom = "gecko") private static boolean setHTML( - final Context context, final CharSequence text, final String htmlText) { - return setData(context, ClipData.newHtmlText("html", text, htmlText)); + final Context context, + final CharSequence text, + final String htmlText, + final boolean isPrivateData) { + return setData(context, ClipData.newHtmlText("html", text, htmlText), isPrivateData); } /** @@ -158,11 +163,17 @@ public final class Clipboard { * @param clipData a {@link android.content.ClipData} to set to clipboard * @return true if copy is successful. */ - private static boolean setData(final Context context, final ClipData clipData) { + private static boolean setData( + final Context context, final ClipData clipData, final boolean isPrivateData) { // In API Level 11 and above, CLIPBOARD_SERVICE returns android.content.ClipboardManager, // which is a subclass of android.text.ClipboardManager. final ClipboardManager cm = (ClipboardManager) context.getSystemService(Context.CLIPBOARD_SERVICE); + if (isPrivateData && Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { + final PersistableBundle extras = new PersistableBundle(); + extras.putBoolean(ClipDescription.EXTRA_IS_SENSITIVE, true); + clipData.getDescription().setExtras(extras); + } try { cm.setPrimaryClip(clipData); } catch (final NullPointerException e) { @@ -228,7 +239,7 @@ public final class Clipboard { @WrapForJNI(calledFrom = "gecko") private static void clear(final Context context) { if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) { - setText(context, null); + setText(context, null, false); return; } // Although we don't know more details of https://crbug.com/1203377, Blink doesn't use ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoInputConnection.java ===================================== @@ -70,6 +70,7 @@ import org.mozilla.gecko.util.ThreadUtils; private ExtractedTextRequest mUpdateRequest; private final InputConnection mKeyInputConnection; private CursorAnchorInfo.Builder mCursorAnchorInfoBuilder; + private boolean mIsPrivateBrowsing; public static SessionTextInput.InputConnectionClient create( final GeckoSession session, @@ -208,12 +209,13 @@ import org.mozilla.gecko.util.ThreadUtils; // If selection is empty, we'll select everything if (selStart == selEnd) { // Fill the clipboard - Clipboard.setText(view.getContext(), editable); + Clipboard.setText(view.getContext(), editable, mIsPrivateBrowsing); editable.clear(); } else { Clipboard.setText( view.getContext(), - editable.subSequence(Math.min(selStart, selEnd), Math.max(selStart, selEnd))); + editable.subSequence(Math.min(selStart, selEnd), Math.max(selStart, selEnd)), + mIsPrivateBrowsing); editable.delete(selStart, selEnd); } break; @@ -231,7 +233,7 @@ import org.mozilla.gecko.util.ThreadUtils; : editable .toString() .substring(Math.min(selStart, selEnd), Math.max(selStart, selEnd)); - Clipboard.setText(view.getContext(), copiedText); + Clipboard.setText(view.getContext(), copiedText, mIsPrivateBrowsing); break; } return true; @@ -603,6 +605,9 @@ import org.mozilla.gecko.util.ThreadUtils; outAttrs.imeOptions |= EditorInfo.IME_FLAG_NO_EXTRACT_UI | EditorInfo.IME_FLAG_NO_FULLSCREEN; } + mIsPrivateBrowsing = + ((outAttrs.imeOptions & InputMethods.IME_FLAG_NO_PERSONALIZED_LEARNING) != 0); + if (DEBUG) { Log.d( LOGTAG, ===================================== toolkit/components/httpsonlyerror/content/errorpage.html ===================================== @@ -70,6 +70,16 @@ inert ></button> </div> + + <p id="explanation-iframe" hidden> + <span data-l10n-id="about-httpsonly-explanation-iframe"></span> + <a + id="mixedContentLearnMoreLink" + target="_blank" + data-l10n-id="about-httpsonly-link-learn-more" + ></a> + </p> + <div class="suggestion-box" hidden> <h2 data-l10n-id="about-httpsonly-suggestion-box-header"></h2> </div> ===================================== toolkit/components/httpsonlyerror/content/errorpage.js ===================================== @@ -29,28 +29,35 @@ function initPage() { document .getElementById("learnMoreLink") .setAttribute("href", baseSupportURL + "https-only-prefs"); + document + .getElementById("mixedContentLearnMoreLink") + .setAttribute("href", baseSupportURL + "mixed-content"); + + const isTopLevel = window.top == window; + if (!isTopLevel) { + for (const id of ["explanation-continue", "goBack", "openInsecure"]) { + document.getElementById(id).remove(); + } + document.getElementById("explanation-iframe").removeAttribute("hidden"); + return; + } document .getElementById("openInsecure") .addEventListener("click", onOpenInsecureButtonClick); + document + .getElementById("goBack") + .addEventListener("click", onReturnButtonClick); const delay = RPMGetIntPref("security.dialog_enable_delay", 1000); setTimeout(() => { document.getElementById("openInsecure").removeAttribute("inert"); }, delay); - if (window.top == window) { - document - .getElementById("goBack") - .addEventListener("click", onReturnButtonClick); - addAutofocus("#goBack", "beforeend"); - } else { - document.getElementById("goBack").remove(); - } + addAutofocus("#goBack", "beforeend"); - const isTopLevel = window.top == window; const hasWWWPrefix = pageUrl.href.startsWith("https://www."); - if (isTopLevel && !hasWWWPrefix) { + if (!hasWWWPrefix) { // HTTPS-Only generally simply replaces http: with https:; // here we additionally try to add www and see if that allows to upgrade the connection if it is top level ===================================== toolkit/locales/en-US/toolkit/about/aboutHttpsOnlyError.ftl ===================================== @@ -12,6 +12,7 @@ about-httpsonly-explanation-question = What could be causing this? about-httpsonly-explanation-nosupport = Most likely, the website simply does not support HTTPS. about-httpsonly-explanation-risk = It’s also possible that an attacker is involved. If you decide to visit the website, you should not enter any sensitive information like passwords, emails, or credit card details. about-httpsonly-explanation-continue = If you continue, HTTPS-Only Mode will be turned off temporarily for this site. +about-httpsonly-explanation-iframe = Due to mixed content blocking, it is not possible to manually allow this frame to load. about-httpsonly-button-continue-to-site = Continue to HTTP Site about-httpsonly-button-go-back = Go Back ===================================== widget/android/nsClipboard.cpp ===================================== @@ -92,14 +92,16 @@ nsClipboard::SetNativeClipboardData(nsITransferable* aTransferable, return rv; } + bool isPrivate = aTransferable->GetIsPrivateData(); + if (!html.IsEmpty() && java::Clipboard::SetHTML(java::GeckoAppShell::GetApplicationContext(), - text, html)) { + text, html, isPrivate)) { return NS_OK; } if (!text.IsEmpty() && java::Clipboard::SetText(java::GeckoAppShell::GetApplicationContext(), - text)) { + text, isPrivate)) { return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/f2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/f2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.5.0esr-14.0-1-build2
by ma1 (＠ma1) 25 Nov '24

25 Nov '24

ma1 pushed new tag tor-browser-128.5.0esr-14.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.5.0esr-14.0-1] 4 commits: Bug 1836921 - Improve dialogs a=dmeehan
by ma1 (＠ma1) 25 Nov '24

25 Nov '24

ma1 pushed to branch tor-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: c262ab56 by Arturo Mejia at 2024-11-20T13:10:39+01:00 Bug 1836921 - Improve dialogs a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D226961 Differential Revision: https://phabricator.services.mozilla.com/D228842 - - - - - cdd6f724 by Malte Juergens at 2024-11-22T17:17:19+01:00 Bug 1909396 - Remove HTTPS-Only exception button in iframes r=freddyb,fluent-reviewers Rationale for this can be read in Bug 1909396, but the main reason is that the iframe will get blocked regardless by mixed content blocking. Differential Revision: https://phabricator.services.mozilla.com/D220257 - - - - - 7ba8318e by Makoto Kato at 2024-11-25T11:15:10+01:00 Bug 1776646 - Support EXTRA_IS_SENSITIVE for clipboard. r=geckoview-reviewers,owlish When nsITransferable.isPrivateData is true, such as coping password or private mode, we should set EXTRA_IS_SENSITIVE to ClipData. AndroidJunit test runner doesn't often get `ClipDescription.extras` from clipboard service in test runner. So we cannot write a unit test using AndroidJUnit test runner. Differential Revision: https://phabricator.services.mozilla.com/D225326 - - - - - 0ad899bf by Cathy Lu at 2024-11-25T14:56:28+01:00 Bug 1914797 - Part 1 + 2 + partial backout (details below) Bug 1914797 - Part 1 - Revert bug 1868469 r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226431 Bug 1914797 - Part 2 - Add url change during onPageStart for slow loading sites r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226432 Backed out 1 changesets (bug 1914797) for causing Bug 1929028 Backed out changeset a79554879d7b (bug 1914797) - - - - - 16 changed files: - dom/ipc/WindowGlobalParent.cpp - dom/security/test/https-only/browser.toml - + dom/security/test/https-only/browser_iframe_buttons.js - + dom/security/test/https-only/file_iframe_buttons.html - mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragment.kt - mobile/android/android-components/components/feature/app-links/src/test/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragmentTest.kt - mobile/android/android-components/components/feature/session/src/main/java/mozilla/components/feature/session/SessionUseCases.kt - mobile/android/android-components/components/feature/session/src/test/java/mozilla/components/feature/session/SessionUseCasesTest.kt - mobile/android/android-components/docs/changelog.md - mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CrashReportingTest.kt - mobile/android/geckoview/src/main/java/org/mozilla/gecko/Clipboard.java - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoInputConnection.java - toolkit/components/httpsonlyerror/content/errorpage.html - toolkit/components/httpsonlyerror/content/errorpage.js - toolkit/locales/en-US/toolkit/about/aboutHttpsOnlyError.ftl - widget/android/nsClipboard.cpp Changes: ===================================== dom/ipc/WindowGlobalParent.cpp ===================================== @@ -1378,18 +1378,11 @@ mozilla::ipc::IPCResult WindowGlobalParent::RecvReloadWithHttpsOnlyException() { return IPC_FAIL(this, "HTTPS-only mode: Illegal state"); } - // If the error page is within an iFrame, we create an exception for whatever - // scheme the top-level site is currently on, because the user wants to - // unbreak the iFrame and not the top-level page. When the error page shows up - // on a top-level request, then we replace the scheme with http, because the - // user wants to unbreak the whole page. + // We replace the scheme with http, because the user wants to unbreak the + // whole page. nsCOMPtr<nsIURI> newURI; - if (!BrowsingContext()->IsTop()) { - newURI = innerURI; - } else { - Unused << NS_MutateURI(innerURI).SetScheme("http"_ns).Finalize( - getter_AddRefs(newURI)); - } + Unused << NS_MutateURI(innerURI).SetScheme("http"_ns).Finalize( + getter_AddRefs(newURI)); OriginAttributes originAttributes = TopWindowContext()->DocumentPrincipal()->OriginAttributesRef(); ===================================== dom/security/test/https-only/browser.toml ===================================== @@ -29,6 +29,9 @@ support-files = [ ["browser_httpsonly_speculative_connect.js"] support-files = ["file_httpsonly_speculative_connect.html"] +["browser_iframe_buttons.js"] +support-files = ["file_iframe_buttons.html"] + ["browser_iframe_test.js"] skip-if = [ "os == 'linux' && bits == 64", # Bug 1735565 ===================================== dom/security/test/https-only/browser_iframe_buttons.js ===================================== @@ -0,0 +1,50 @@ +/* Any copyright is dedicated to the Public Domain. + https://creativecommons.org/publicdomain/zero/1.0/ */ + +"use strict"; + +// Ensure the buttons at the buttom of the HTTPS-Only error page do not get +// displayed in an iframe (Bug 1909396). + +add_task(async function test_iframe_buttons() { + await BrowserTestUtils.withNewTab( + "https://example.com/browser/dom/security/test/https-only/file_iframe_button…", + async function (browser) { + await SpecialPowers.pushPrefEnv({ + set: [["dom.security.https_only_mode", true]], + }); + + await SpecialPowers.spawn(browser, [], async function () { + const iframe = content.document.getElementById("iframe"); + // eslint-disable-next-line @microsoft/sdl/no-insecure-url + iframe.src = "http://nocert.example.com"; + + await ContentTaskUtils.waitForCondition( + () => iframe.contentWindow.document.readyState === "interactive", + "Iframe error page should have loaded" + ); + + ok( + !!iframe.contentWindow.document.getElementById("explanation-iframe"), + "#explanation-iframe should exist" + ); + + is( + iframe.contentWindow.document + .getElementById("explanation-iframe") + .getAttribute("hidden"), + null, + "#explanation-iframe should not be hidden" + ); + + for (const id of ["explanation-continue", "goBack", "openInsecure"]) { + is( + iframe.contentWindow.document.getElementById(id), + null, + `#${id} should have been removed` + ); + } + }); + } + ); +}); ===================================== dom/security/test/https-only/file_iframe_buttons.html ===================================== @@ -0,0 +1,9 @@ +<!DOCTYPE html> +<html lang="en"> +<head> + <meta charset="UTF-8"> +</head> +<body> + <iframe id="iframe" frameborder="0"></iframe> +</body> +</html> ===================================== mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragment.kt ===================================== @@ -11,6 +11,7 @@ import androidx.annotation.StringRes import androidx.annotation.StyleRes import androidx.annotation.VisibleForTesting import androidx.appcompat.app.AlertDialog +import mozilla.components.support.ktx.util.PromptAbuserDetector import mozilla.components.ui.widgets.withCenterAlignedButtons /** @@ -23,6 +24,10 @@ import mozilla.components.ui.widgets.withCenterAlignedButtons */ class SimpleRedirectDialogFragment : RedirectDialogFragment() { + @VisibleForTesting + internal var promptAbuserDetector = + PromptAbuserDetector(maxSuccessiveDialogSecondsLimit = TIME_SHOWN_OFFSET_SECONDS) + @VisibleForTesting internal var testingContext: Context? = null @@ -32,6 +37,8 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { return if (themeID == 0) AlertDialog.Builder(context) else AlertDialog.Builder(context, themeID) } + promptAbuserDetector.updateJSDialogAbusedState() + return with(requireBundle()) { val dialogTitleText = getInt(KEY_TITLE_TEXT, R.string.mozac_feature_applinks_normal_confirm_dialog_title) val dialogMessageString = getString(KEY_MESSAGE_STRING, "") @@ -40,18 +47,29 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { val themeResId = getInt(KEY_THEME_ID, 0) val cancelable = getBoolean(KEY_CANCELABLE, false) - getBuilder(themeResId) + val dialog = getBuilder(themeResId) .setTitle(dialogTitleText) .setMessage(dialogMessageString) - .setPositiveButton(positiveButtonText) { _, _ -> - onConfirmRedirect() - } + .setPositiveButton(positiveButtonText) { _, _ -> } .setNegativeButton(negativeButtonText) { _, _ -> onCancelRedirect() } .setCancelable(cancelable) .create() - .withCenterAlignedButtons() + + dialog.withCenterAlignedButtons() + dialog.setOnShowListener { + val okButton = dialog.getButton(AlertDialog.BUTTON_POSITIVE) + okButton.setOnClickListener { + if (promptAbuserDetector.areDialogsBeingAbused()) { + promptAbuserDetector.updateJSDialogAbusedState() + } else { + onConfirmRedirect() + dialog.dismiss() + } + } + } + dialog } } @@ -101,6 +119,7 @@ class SimpleRedirectDialogFragment : RedirectDialogFragment() { const val KEY_THEME_ID = "KEY_THEME_ID" const val KEY_CANCELABLE = "KEY_CANCELABLE" + private const val TIME_SHOWN_OFFSET_SECONDS = 1 } private fun requireBundle(): Bundle { ===================================== mobile/android/android-components/components/feature/app-links/src/test/java/mozilla/components/feature/app/links/SimpleRedirectDialogFragmentTest.kt ===================================== @@ -13,6 +13,7 @@ import mozilla.components.support.test.mock import mozilla.components.support.test.robolectric.testContext import org.junit.Assert.assertFalse import org.junit.Assert.assertTrue +import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith import org.mockito.Mockito.doNothing @@ -27,6 +28,7 @@ class SimpleRedirectDialogFragmentTest { private val themeResId = appcompatR.style.Theme_AppCompat_Light @Test + @Ignore("This will be addressed in another follow up ticket") fun `Dialog confirmed callback is called correctly`() { var onConfirmCalled = false var onCancelCalled = false @@ -104,6 +106,7 @@ class SimpleRedirectDialogFragmentTest { assertFalse(onCancelCalled) } + @Suppress("unused") private fun mockFragmentManager(): FragmentManager { val fragmentManager: FragmentManager = mock() val transaction: FragmentTransaction = mock() ===================================== mobile/android/android-components/components/feature/session/src/main/java/mozilla/components/feature/session/SessionUseCases.kt ===================================== @@ -4,7 +4,6 @@ package mozilla.components.feature.session -import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.action.CrashAction import mozilla.components.browser.state.action.EngineAction import mozilla.components.browser.state.action.LastAccessAction @@ -94,13 +93,6 @@ class SessionUseCases( flags = flags, additionalHeaders = additionalHeaders, ) - // Update the url in content immediately until the engine updates with any new changes to the state. - store.dispatch( - ContentAction.UpdateUrlAction( - loadSessionId, - url, - ), - ) store.dispatch( EngineAction.OptimizedLoadUrlTriggeredAction( loadSessionId, ===================================== mobile/android/android-components/components/feature/session/src/test/java/mozilla/components/feature/session/SessionUseCasesTest.kt ===================================== @@ -11,7 +11,6 @@ import mozilla.components.browser.state.action.EngineAction import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.engine.EngineMiddleware import mozilla.components.browser.state.selector.findTab -import mozilla.components.browser.state.selector.selectedTab import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.TabSessionState import mozilla.components.browser.state.state.createCustomTab @@ -81,7 +80,6 @@ class SessionUseCasesTest { assertEquals("mozilla", action.tabId) assertEquals("https://getpocket.com", action.url) } - assertEquals("https://getpocket.com", store.state.selectedTab?.content?.url) useCases.loadUrl("https://www.mozilla.org", LoadUrlFlags.select(LoadUrlFlags.EXTERNAL)) store.waitUntilIdle() @@ -95,7 +93,6 @@ class SessionUseCasesTest { assertEquals("https://www.mozilla.org", action.url) assertEquals(LoadUrlFlags.select(LoadUrlFlags.EXTERNAL), action.flags) } - assertEquals("https://www.mozilla.org", store.state.selectedTab?.content?.url) useCases.loadUrl("https://firefox.com", store.state.selectedTabId) store.waitUntilIdle() @@ -105,7 +102,6 @@ class SessionUseCasesTest { assertEquals("mozilla", action.tabId) assertEquals("https://firefox.com", action.url) } - assertEquals("https://firefox.com", store.state.selectedTab?.content?.url) useCases.loadUrl.invoke( "https://developer.mozilla.org", ===================================== mobile/android/android-components/docs/changelog.md ===================================== @@ -109,9 +109,6 @@ permalink: /changelog/ * **feature-customtabs** * Fallback behaviour when failing to open a new window in custom tab will now be loading the URL directly in the same custom tab. [Bug 1832357](https://bugzilla.mozilla.org/show_bug.cgi?id=1832357) -* **feature-session** - * Update URL in the store immediately when using the optimized load URL code path. - * **tooling-lint** * Added a lint rule to detect when `Response#close` may not have been called. Note: Currently, this rule only runs on Android Components. ===================================== mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CrashReportingTest.kt ===================================== @@ -83,7 +83,7 @@ class CrashReportingTest : TestSetup() { verifyPageContent(tabCrashMessage) }.openTabDrawer(activityTestRule) { verifyExistingOpenTabs(firstWebPage.title) - verifyExistingOpenTabs("about:crashcontent") + verifyExistingOpenTabs(secondWebPage.title) }.closeTabDrawer { }.goToHomescreen { verifyExistingTopSitesList() ===================================== mobile/android/geckoview/src/main/java/org/mozilla/gecko/Clipboard.java ===================================== @@ -11,6 +11,7 @@ import android.content.ClipboardManager.OnPrimaryClipChangedListener; import android.content.Context; import android.content.res.AssetFileDescriptor; import android.os.Build; +import android.os.PersistableBundle; import android.text.TextUtils; import android.util.Log; import java.io.ByteArrayOutputStream; @@ -133,8 +134,9 @@ public final class Clipboard { * @return true if copy is successful. */ @WrapForJNI(calledFrom = "gecko") - public static boolean setText(final Context context, final CharSequence text) { - return setData(context, ClipData.newPlainText("text", text)); + public static boolean setText( + final Context context, final CharSequence text, final boolean isPrivateData) { + return setData(context, ClipData.newPlainText("text", text), isPrivateData); } /** @@ -147,8 +149,11 @@ public final class Clipboard { */ @WrapForJNI(calledFrom = "gecko") private static boolean setHTML( - final Context context, final CharSequence text, final String htmlText) { - return setData(context, ClipData.newHtmlText("html", text, htmlText)); + final Context context, + final CharSequence text, + final String htmlText, + final boolean isPrivateData) { + return setData(context, ClipData.newHtmlText("html", text, htmlText), isPrivateData); } /** @@ -158,11 +163,17 @@ public final class Clipboard { * @param clipData a {@link android.content.ClipData} to set to clipboard * @return true if copy is successful. */ - private static boolean setData(final Context context, final ClipData clipData) { + private static boolean setData( + final Context context, final ClipData clipData, final boolean isPrivateData) { // In API Level 11 and above, CLIPBOARD_SERVICE returns android.content.ClipboardManager, // which is a subclass of android.text.ClipboardManager. final ClipboardManager cm = (ClipboardManager) context.getSystemService(Context.CLIPBOARD_SERVICE); + if (isPrivateData && Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { + final PersistableBundle extras = new PersistableBundle(); + extras.putBoolean(ClipDescription.EXTRA_IS_SENSITIVE, true); + clipData.getDescription().setExtras(extras); + } try { cm.setPrimaryClip(clipData); } catch (final NullPointerException e) { @@ -228,7 +239,7 @@ public final class Clipboard { @WrapForJNI(calledFrom = "gecko") private static void clear(final Context context) { if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) { - setText(context, null); + setText(context, null, false); return; } // Although we don't know more details of https://crbug.com/1203377, Blink doesn't use ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoInputConnection.java ===================================== @@ -70,6 +70,7 @@ import org.mozilla.gecko.util.ThreadUtils; private ExtractedTextRequest mUpdateRequest; private final InputConnection mKeyInputConnection; private CursorAnchorInfo.Builder mCursorAnchorInfoBuilder; + private boolean mIsPrivateBrowsing; public static SessionTextInput.InputConnectionClient create( final GeckoSession session, @@ -208,12 +209,13 @@ import org.mozilla.gecko.util.ThreadUtils; // If selection is empty, we'll select everything if (selStart == selEnd) { // Fill the clipboard - Clipboard.setText(view.getContext(), editable); + Clipboard.setText(view.getContext(), editable, mIsPrivateBrowsing); editable.clear(); } else { Clipboard.setText( view.getContext(), - editable.subSequence(Math.min(selStart, selEnd), Math.max(selStart, selEnd))); + editable.subSequence(Math.min(selStart, selEnd), Math.max(selStart, selEnd)), + mIsPrivateBrowsing); editable.delete(selStart, selEnd); } break; @@ -231,7 +233,7 @@ import org.mozilla.gecko.util.ThreadUtils; : editable .toString() .substring(Math.min(selStart, selEnd), Math.max(selStart, selEnd)); - Clipboard.setText(view.getContext(), copiedText); + Clipboard.setText(view.getContext(), copiedText, mIsPrivateBrowsing); break; } return true; @@ -603,6 +605,9 @@ import org.mozilla.gecko.util.ThreadUtils; outAttrs.imeOptions |= EditorInfo.IME_FLAG_NO_EXTRACT_UI | EditorInfo.IME_FLAG_NO_FULLSCREEN; } + mIsPrivateBrowsing = + ((outAttrs.imeOptions & InputMethods.IME_FLAG_NO_PERSONALIZED_LEARNING) != 0); + if (DEBUG) { Log.d( LOGTAG, ===================================== toolkit/components/httpsonlyerror/content/errorpage.html ===================================== @@ -70,6 +70,16 @@ inert ></button> </div> + + <p id="explanation-iframe" hidden> + <span data-l10n-id="about-httpsonly-explanation-iframe"></span> + <a + id="mixedContentLearnMoreLink" + target="_blank" + data-l10n-id="about-httpsonly-link-learn-more" + ></a> + </p> + <div class="suggestion-box" hidden> <h2 data-l10n-id="about-httpsonly-suggestion-box-header"></h2> </div> ===================================== toolkit/components/httpsonlyerror/content/errorpage.js ===================================== @@ -29,28 +29,35 @@ function initPage() { document .getElementById("learnMoreLink") .setAttribute("href", baseSupportURL + "https-only-prefs"); + document + .getElementById("mixedContentLearnMoreLink") + .setAttribute("href", baseSupportURL + "mixed-content"); + + const isTopLevel = window.top == window; + if (!isTopLevel) { + for (const id of ["explanation-continue", "goBack", "openInsecure"]) { + document.getElementById(id).remove(); + } + document.getElementById("explanation-iframe").removeAttribute("hidden"); + return; + } document .getElementById("openInsecure") .addEventListener("click", onOpenInsecureButtonClick); + document + .getElementById("goBack") + .addEventListener("click", onReturnButtonClick); const delay = RPMGetIntPref("security.dialog_enable_delay", 1000); setTimeout(() => { document.getElementById("openInsecure").removeAttribute("inert"); }, delay); - if (window.top == window) { - document - .getElementById("goBack") - .addEventListener("click", onReturnButtonClick); - addAutofocus("#goBack", "beforeend"); - } else { - document.getElementById("goBack").remove(); - } + addAutofocus("#goBack", "beforeend"); - const isTopLevel = window.top == window; const hasWWWPrefix = pageUrl.href.startsWith("https://www."); - if (isTopLevel && !hasWWWPrefix) { + if (!hasWWWPrefix) { // HTTPS-Only generally simply replaces http: with https:; // here we additionally try to add www and see if that allows to upgrade the connection if it is top level ===================================== toolkit/locales/en-US/toolkit/about/aboutHttpsOnlyError.ftl ===================================== @@ -12,6 +12,7 @@ about-httpsonly-explanation-question = What could be causing this? about-httpsonly-explanation-nosupport = Most likely, the website simply does not support HTTPS. about-httpsonly-explanation-risk = It’s also possible that an attacker is involved. If you decide to visit the website, you should not enter any sensitive information like passwords, emails, or credit card details. about-httpsonly-explanation-continue = If you continue, HTTPS-Only Mode will be turned off temporarily for this site. +about-httpsonly-explanation-iframe = Due to mixed content blocking, it is not possible to manually allow this frame to load. about-httpsonly-button-continue-to-site = Continue to HTTP Site about-httpsonly-button-go-back = Go Back ===================================== widget/android/nsClipboard.cpp ===================================== @@ -92,14 +92,16 @@ nsClipboard::SetNativeClipboardData(nsITransferable* aTransferable, return rv; } + bool isPrivate = aTransferable->GetIsPrivateData(); + if (!html.IsEmpty() && java::Clipboard::SetHTML(java::GeckoAppShell::GetApplicationContext(), - text, html)) { + text, html, isPrivate)) { return NS_OK; } if (!text.IsEmpty() && java::Clipboard::SetText(java::GeckoAppShell::GetApplicationContext(), - text)) { + text, isPrivate)) { return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2e8439… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2e8439… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.0] Add .gitignore to tools/browser
by morgan (＠morgan) 23 Nov '24

23 Nov '24

morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: 2477a638 by Morgan at 2024-11-23T01:34:58+00:00 Add .gitignore to tools/browser - - - - - 1 changed file: - + tools/browser/.gitignore Changes: ===================================== tools/browser/.gitignore ===================================== @@ -0,0 +1,3 @@ +basebrowser +mullvadbrowser +torbrowser View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.0] Bug 41304: Backport tools/browser/.gitignore to hide main branch's symlinks
by morgan (＠morgan) 23 Nov '24

23 Nov '24

morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: 8ccad839 by Morgan at 2024-11-23T01:32:47+00:00 Bug 41304: Backport tools/browser/.gitignore to hide main branch's symlinks - - - - - 1 changed file: - + tools/browser/.gitignore Changes: ===================================== tools/browser/.gitignore ===================================== @@ -0,0 +1,3 @@ +basebrowser +mullvadbrowser +torbrowser View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] 3 commits: Bug 41284: Stop sync'ing changelogs between channels.
by morgan (＠morgan) 23 Nov '24

23 Nov '24

morgan pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 72f49dc1 by Pier Angelo Vendrame at 2024-11-21T17:35:24+01:00 Bug 41284: Stop sync'ing changelogs between channels. - - - - - bf089520 by Pier Angelo Vendrame at 2024-11-21T17:45:32+01:00 Bug 41200: Remove the tools for allowed_addons.json. For tor-browser#42618 and tor-browser#42619, we stopped using the allowed_addons.json, but initially we kept the tools to update it. However, the file creates some confusion, because it is used only for Andorid, but should be updated also when doing desktop-only releases when they update NoScript, or Android nightly builds might fail. So, since as a matter of fact we do not use that file anymore, we decided to stop updating it and remove the related tools. - - - - - 84e2ad6a by Pier Angelo Vendrame at 2024-11-21T18:10:39+01:00 Bug 41310: 13.5-specific fixes for relprep.py. When I wrote relprep.py, I did not think about a legacy channel, as we never had one before. Our approach was to keep everything to build releases as stable, so we decided to comment or remove the undesired functionalities rather than implementing a legacy channel in the script. - - - - - 11 changed files: - − .gitattributes - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md - − projects/browser/allowed_addons.json - projects/browser/build.android - projects/browser/config - − projects/browser/verify_allowed_addons.py - projects/manual/config - − tools/fetch_allowed_addons.py - tools/fetch_changelogs.py - tools/relprep.py Changes: ===================================== .gitattributes deleted ===================================== @@ -1 +0,0 @@ -projects/browser/allowed_addons.json -diff ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -59,8 +59,6 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] `fenix_version` : update to match alpha `firefox-android` build tag - [ ] `browser_branch` : update to match alpha `firefox-android` build tag - [ ] `browser_build` : update to match alpha `firefox-android` build tag - - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-alpha` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -60,8 +60,6 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] `browser_branch` : update to match stable `firefox-android` build tag - [ ] `browser_build` : update to match stable `firefox-android` build tag variant: Beta - - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-release` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch ===================================== projects/browser/allowed_addons.json deleted ===================================== The diff for this file was not included because it is too large. ===================================== projects/browser/build.android ===================================== @@ -39,15 +39,6 @@ unzip ../omni.ja }) %] popd - -[% IF c("var/verify_allowed_addons") %] - # Check that allowed_addons.json contains the right versions of our bundled extension(s). - # If so, replace the default allowed_addons.json by ours in the apk assets folder. - $rootdir/verify_allowed_addons.py "$rootdir/allowed_addons.json" "$noscript_path" -[% END %] - -mv $rootdir/allowed_addons.json $assets_dir/allowed_addons.json - mkdir apk pushd apk 7zz x "$apk" ===================================== projects/browser/config ===================================== @@ -49,7 +49,6 @@ targets: android: build: '[% INCLUDE build.android %]' var: - verify_allowed_addons: 1 arch_deps: - 7zip - openjdk-17-jdk-headless @@ -159,10 +158,6 @@ input_files: enable: '[% c("var/namecoin") %]' - filename: namecoin.patch enable: '[% c("var/namecoin") %]' - - filename: allowed_addons.json - enable: '[% c("var/android") %]' - - filename: verify_allowed_addons.py - enable: '[% c("var/android") && c("var/verify_allowed_addons") %]' - project: manual name: manual enable: '[% ! c("var/android") && c("var/tor-browser") %]' ===================================== projects/browser/verify_allowed_addons.py deleted ===================================== @@ -1,49 +0,0 @@ -#!/usr/bin/env python3 - -import json -import sys -import hashlib -import zipfile - -def find_addon(addons, addon_id): - results = addons['results'] - for x in results: - addon = x['addon'] - if addon['guid'] == addon_id: - return addon - sys.exit("Error: cannot find addon " + addon_id) - -def verify_extension_version(addons, addon_id, version): - addon = find_addon(addons, addon_id) - expected_version = addon['current_version']['version'] - if version != expected_version: - sys.exit("Error: version " + version + " != " + expected_version) - -def verify_extension_hash(addons, addon_id, hash): - addon = find_addon(addons, addon_id) - expected_hash = addon["current_version"]["files"][0]["hash"] - if hash != expected_hash: - sys.exit("Error: hash " + hash + " != " + expected_hash) - -def read_extension_manifest(path): - return json.loads(zipfile.ZipFile(path, 'r').read('manifest.json')) - -def main(argv): - allowed_addons_path = argv[0] - noscript_path = argv[1] - - addons = None - with open(allowed_addons_path, 'r') as file: - addons = json.loads(file.read()) - - noscript_hash = None - with open(noscript_path, 'rb') as file: - noscript_hash = "sha256:" + hashlib.sha256(file.read()).hexdigest() - - noscript_version = read_extension_manifest(noscript_path)["version"] - - verify_extension_hash(addons, '{73a6fe31-595d-460b-a920-fcc0f8843232}', noscript_hash) - verify_extension_version(addons, '{73a6fe31-595d-460b-a920-fcc0f8843232}', noscript_version) - -if __name__ == "__main__": - main(sys.argv[1:]) ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 222718 +version: 210938 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -23,6 +23,6 @@ input_files: - project: container-image - URL: 'https://build-sources.tbb.torproject.org/manual_[% c("version") %].zip' name: manual - sha256sum: 051174ba012fa2241e865cc604658a0af116d3bbf9d02474025277fff1b34636 + sha256sum: eb83259f0525a14dae1a1c3944e1e5ac3a2f8111a42834ab0f401628c8a38791 - filename: packagemanual.py name: package_script ===================================== tools/fetch_allowed_addons.py deleted ===================================== @@ -1,53 +0,0 @@ -#!/usr/bin/env python3 - -import urllib.request -import json -import base64 -import sys - -NOSCRIPT = "{73a6fe31-595d-460b-a920-fcc0f8843232}" - - -def fetch(x): - with urllib.request.urlopen(x) as response: - return response.read() - - -def find_addon(addons, addon_id): - results = addons["results"] - for x in results: - addon = x["addon"] - if addon["guid"] == addon_id: - return addon - - -def fetch_and_embed_icons(addons): - results = addons["results"] - for x in results: - addon = x["addon"] - icon_data = fetch(addon["icon_url"]) - addon["icon_url"] = "data:image/png;base64," + str( - base64.b64encode(icon_data), "utf8" - ) - - -def fetch_allowed_addons(amo_collection=None): - if amo_collection is None: - amo_collection = "83a9cccfe6e24a34bd7b155ff9ee32" - url = f"https://services.addons.mozilla.org/api/v4/accounts/account/mozilla/collect…" - data = json.loads(fetch(url)) - fetch_and_embed_icons(data) - data["results"].sort(key=lambda x: x["addon"]["guid"]) - return data - - -def main(argv): - data = fetch_allowed_addons(argv[0] if len(argv) > 1 else None) - # Check that NoScript is present - if find_addon(data, NOSCRIPT) is None: - sys.exit("Error: cannot find NoScript.") - print(json.dumps(data, indent=2, ensure_ascii=False)) - - -if __name__ == "__main__": - main(sys.argv[1:]) ===================================== tools/fetch_changelogs.py ===================================== @@ -21,12 +21,10 @@ class EntryType(enum.IntFlag): class Platform(enum.IntFlag): - WINDOWS = 8 - MACOS = 4 - LINUX = 2 - ANDROID = 1 - DESKTOP = 8 | 4 | 2 - ALL_PLATFORMS = 8 | 4 | 2 | 1 + WINDOWS = 2 + MACOS = 1 + DESKTOP = 2 | 1 + ALL_PLATFORMS = 2 | 1 class ChangelogEntry: @@ -52,10 +50,6 @@ class ChangelogEntry: platforms.append("Windows") if self.platform & Platform.MACOS: platforms.append("macOS") - if self.platform & Platform.LINUX: - platforms.append("Linux") - if self.platform & Platform.ANDROID: - platforms.append("Android") return " + ".join(platforms) def __lt__(self, other): @@ -78,15 +72,8 @@ class ChangelogEntry: class UpdateEntry(ChangelogEntry): def __init__(self, name, version, is_mb): - if name == "Firefox" and not is_mb: - platform = Platform.DESKTOP - num_platforms = 3 - elif name == "GeckoView" or name == "Zstandard": - platform = Platform.ANDROID - num_platforms = 1 - else: - platform = Platform.ALL_PLATFORMS - num_platforms = 4 + platform = Platform.ALL_PLATFORMS + num_platforms = 2 super().__init__( EntryType.UPDATE, platform, num_platforms, name == "Go", is_mb ) @@ -107,8 +94,8 @@ class Issue(ChangelogEntry): platform = 0 num_platforms = 0 if "Desktop" in j["labels"]: - platform = Platform.DESKTOP - num_platforms += 3 + platform = Platform.ALL_PLATFORMS + num_platforms += 2 else: if "Windows" in j["labels"]: platform |= Platform.WINDOWS @@ -116,20 +103,13 @@ class Issue(ChangelogEntry): if "MacOS" in j["labels"]: platform |= Platform.MACOS num_platforms += 1 - if "Linux" in j["labels"]: - platform |= Platform.LINUX - num_platforms += 1 - if "Android" in j["labels"]: - if is_mb and num_platforms == 0: + if not platform: + if "Android" in j["labels"] or "Linux" in j["labels"]: raise Exception( - f"Android-only issue on Mullvad Browser: {j['references']['full']}!" + f"The legacy channel should include only fixes for macOS and/or Windows, please check {self.project}#{self.number}." ) - elif not is_mb: - platform |= Platform.ANDROID - num_platforms += 1 - if not platform or (is_mb and platform == Platform.DESKTOP): platform = Platform.ALL_PLATFORMS - num_platforms = 4 + num_platforms = 2 is_build = "Build System" in j["labels"] super().__init__( EntryType.ISSUE, platform, num_platforms, is_build, is_mb ===================================== tools/relprep.py ===================================== @@ -4,7 +4,6 @@ from collections import namedtuple import configparser from datetime import datetime, timezone from hashlib import sha256 -import json import locale import logging from pathlib import Path @@ -16,7 +15,6 @@ from git import Repo import requests import ruamel.yaml -from fetch_allowed_addons import NOSCRIPT, fetch_allowed_addons, find_addon import fetch_changelogs from update_manual import update_manual @@ -93,13 +91,10 @@ class ReleasePreparation: self.base_path = Path(repo_path) self.repo = Repo(self.base_path) - self.tor_browser = bool(kwargs.get("tor_browser", True)) - self.mullvad_browser = bool(kwargs.get("mullvad_browser", True)) - if not self.tor_browser and not self.mullvad_browser: - raise ValueError("Nothing to do") - self.android = kwargs.get("android", self.tor_browser) - if not self.tor_browser and self.android: - raise ValueError("Only Tor Browser supports Android") + # Legacy channel, always do Tor Browser desktop only. + self.tor_browser = True + self.mullvad_browser = False + self.android = False logger.debug( "Tor Browser: %s; Mullvad Browser: %s; Android: %s", @@ -142,7 +137,8 @@ class ReleasePreparation: # Do not update Go anymore: 1.21.x is not listed anymore in # the download page as it is EOL as of August 13, 2024. # self.update_go() - self.update_manual() + # Freeze the manual to before 14.0. + # self.update_manual() self.update_changelogs() self.update_rbm_conf() @@ -304,7 +300,6 @@ class ReleasePreparation: targets = ["base-browser"] if self.tor_browser: targets.append("tor-browser") - targets.append("fenix") if self.mullvad_browser: targets.append("mullvad-browser") for i in targets: @@ -319,28 +314,27 @@ class ReleasePreparation: logger.info("Updating addons") config = self.load_config("browser") - amo_data = fetch_allowed_addons() - logger.debug("Fetched AMO data") - if self.android: - with ( - self.base_path / "projects/browser/allowed_addons.json" - ).open("w") as f: - json.dump(amo_data, f, indent=2) - - noscript = find_addon(amo_data, NOSCRIPT) logger.debug("Updating NoScript") - self.update_addon_amo(config, "noscript", noscript) + self.update_addon_amo( + config, "noscript", "{73a6fe31-595d-460b-a920-fcc0f8843232}" + ) if self.mullvad_browser: logger.debug("Updating uBlock Origin") - ublock = find_addon(amo_data, "uBlock0(a)raymondhill.net") - self.update_addon_amo(config, "ublock-origin", ublock) + self.update_addon_amo( + config, "ublock-origin", "uBlock0(a)raymondhill.net" + ) logger.debug("Updating the Mullvad Browser extension") self.update_mullvad_addon(config) self.save_config("browser", config) - def update_addon_amo(self, config, name, addon): - addon = addon["current_version"]["files"][0] + def update_addon_amo(self, config, name, addon_id): + r = requests.get( + f"https://services.addons.mozilla.org/api/v4/addons/addon/{addon_id}" + ) + r.raise_for_status() + amo_data = r.json() + addon = amo_data["current_version"]["files"][0] assert addon["hash"].startswith("sha256:") addon_input = self.find_input(config, name) addon_input["URL"] = addon["url"] @@ -523,6 +517,10 @@ class ReleasePreparation: self.build_number, ) continue + if version.major > self.version.major: + # Ignore more recent version. + # E.g., for the legacy channel. + continue key = (project, version.channel) if key not in self.last_releases: self.last_releases[key] = [] @@ -590,14 +588,9 @@ class ReleasePreparation: changelogs = cb.create(**kwargs) path = f"projects/browser/Bundle-Data/Docs-{tag_prefix.upper()}/ChangeLog.txt" - stable_tag = self.last_releases[(tag_prefix, "release")][0].tag - alpha_tag = self.last_releases[(tag_prefix, "alpha")][0].tag - if stable_tag.tagged_date > alpha_tag.tagged_date: - last_tag = stable_tag - else: - last_tag = alpha_tag - logger.debug("Using %s to add the new changelogs to.", last_tag.tag) - last_changelogs = self.repo.git.show(f"{last_tag.tag}:{path}") + # Take HEAD to reset any changes we might already have from a + # previous run. + last_changelogs = self.repo.git.show(f"HEAD:{path}") with (self.base_path / path).open("w") as f: f.write(changelogs + "\n" + last_changelogs + "\n") @@ -705,8 +698,6 @@ if __name__ == "__main__": default=Path(__file__).parent.parent, help="Path to a tor-browser-build.git clone", ) - parser.add_argument("--tor-browser", action="store_true") - parser.add_argument("--mullvad-browser", action="store_true") parser.add_argument( "--date", help="Release date and optionally time for changelog purposes. " @@ -747,12 +738,7 @@ if __name__ == "__main__": ) logger.addHandler(ch) - tbb = bool(args.tor_browser) - mb = bool(args.mullvad_browser) kwargs = {} - if tbb or mb: - kwargs["tor_browser"] = tbb - kwargs["mullvad_browser"] = mb if args.date: try: kwargs["changelog_date"] = datetime.fromisoformat(args.date) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.0] 2 commits: Bug 41315: Fix the Mullvad Extension update in relprep.py.
by morgan (＠morgan) 23 Nov '24

23 Nov '24

morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: dfc023e6 by Pier Angelo Vendrame at 2024-11-23T01:01:15+00:00 Bug 41315: Fix the Mullvad Extension update in relprep.py. - - - - - 5b395008 by Pier Angelo Vendrame at 2024-11-23T01:01:20+00:00 Bug 41284: Stop sync'ing changelogs between channels. - - - - - 1 changed file: - tools/relprep.py Changes: ===================================== tools/relprep.py ===================================== @@ -306,6 +306,7 @@ class ReleasePreparation: self.save_config("browser", config) def update_addon_amo(self, config, name, addon_id): + logger.debug("Checking updates for %s", name) r = requests.get( f"https://services.addons.mozilla.org/api/v4/addons/addon/{addon_id}" ) @@ -318,6 +319,7 @@ class ReleasePreparation: addon_input["sha256sum"] = addon["hash"][7:] def update_mullvad_addon(self, config): + logger.debug("Checking updates for the Mullvad addon") input_ = self.find_input(config, "mullvad-extension") r = requests.get( "https://cdn.mullvad.net/browser-extension/updates.json" @@ -336,11 +338,11 @@ class ReleasePreparation: path = self.base_path / "out/browser" / url.split("/")[-1] # The extension should be small enough to easily fit in memory :) - if not path.exists: + if not path.exists(): r = requests.get(url) r.raise_for_status() with path.open("wb") as f: - f.write(r.bytes) + f.write(r.content) with path.open("rb") as f: input_["sha256sum"] = sha256(f.read()).hexdigest() logger.debug("Mullvad extension downloaded and updated") @@ -546,14 +548,9 @@ class ReleasePreparation: changelogs = cb.create(**kwargs) path = f"projects/browser/Bundle-Data/Docs-{tag_prefix.upper()}/ChangeLog.txt" - stable_tag = self.last_releases[(tag_prefix, "release")][0].tag - alpha_tag = self.last_releases[(tag_prefix, "alpha")][0].tag - if stable_tag.tagged_date > alpha_tag.tagged_date: - last_tag = stable_tag - else: - last_tag = alpha_tag - logger.debug("Using %s to add the new changelogs to.", last_tag.tag) - last_changelogs = self.repo.git.show(f"{last_tag.tag}:{path}") + # Take HEAD to reset any changes we might already have from a + # previous run. + last_changelogs = self.repo.git.show(f"HEAD:{path}") with (self.base_path / path).open("w") as f: f.write(changelogs + "\n" + last_changelogs + "\n") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41315: Fix the Mullvad Extension update in relprep.py.
by morgan (＠morgan) 23 Nov '24

23 Nov '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 992a7009 by Pier Angelo Vendrame at 2024-11-21T17:23:09+01:00 Bug 41315: Fix the Mullvad Extension update in relprep.py. - - - - - 900f9f91 by Pier Angelo Vendrame at 2024-11-21T17:28:46+01:00 Bug 41284: Stop sync'ing changelogs between channels. - - - - - 1 changed file: - tools/relprep.py Changes: ===================================== tools/relprep.py ===================================== @@ -306,6 +306,7 @@ class ReleasePreparation: self.save_config("browser", config) def update_addon_amo(self, config, name, addon_id): + logger.debug("Checking updates for %s", name) r = requests.get( f"https://services.addons.mozilla.org/api/v4/addons/addon/{addon_id}" ) @@ -318,6 +319,7 @@ class ReleasePreparation: addon_input["sha256sum"] = addon["hash"][7:] def update_mullvad_addon(self, config): + logger.debug("Checking updates for the Mullvad addon") input_ = self.find_input(config, "mullvad-extension") r = requests.get( "https://cdn.mullvad.net/browser-extension/updates.json" @@ -336,11 +338,11 @@ class ReleasePreparation: path = self.base_path / "out/browser" / url.split("/")[-1] # The extension should be small enough to easily fit in memory :) - if not path.exists: + if not path.exists(): r = requests.get(url) r.raise_for_status() with path.open("wb") as f: - f.write(r.bytes) + f.write(r.content) with path.open("rb") as f: input_["sha256sum"] = sha256(f.read()).hexdigest() logger.debug("Mullvad extension downloaded and updated") @@ -546,14 +548,9 @@ class ReleasePreparation: changelogs = cb.create(**kwargs) path = f"projects/browser/Bundle-Data/Docs-{tag_prefix.upper()}/ChangeLog.txt" - stable_tag = self.last_releases[(tag_prefix, "release")][0].tag - alpha_tag = self.last_releases[(tag_prefix, "alpha")][0].tag - if stable_tag.tagged_date > alpha_tag.tagged_date: - last_tag = stable_tag - else: - last_tag = alpha_tag - logger.debug("Using %s to add the new changelogs to.", last_tag.tag) - last_changelogs = self.repo.git.show(f"{last_tag.tag}:{path}") + # Take HEAD to reset any changes we might already have from a + # previous run. + last_changelogs = self.repo.git.show(f"HEAD:{path}") with (self.base_path / path).open("w") as f: f.write(changelogs + "\n" + last_changelogs + "\n") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 40996: Move .nobackup to the root of the repository.
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 85f57f9b by Pier Angelo Vendrame at 2024-11-21T17:21:01+01:00 Bug 40996: Move .nobackup to the root of the repository. The .nobackup files prevent from creating symlinks between clones, which is useful for several use cases (multiple clones, directories in different drives, etc...). A .nobackup in the root will not interfere with symlinks anymore, and we think it is acceptable, as a repo will probably be in sync with GitLab or something similar. git update-index --assume-unchanged can help if someone wants to remove the .nobackup. - - - - - 7 changed files: - git_clones/.nobackup → .nobackup - − hg_clones/.nobackup - − mullvadbrowser/.nobackup - − out/.nobackup - − testbuild/.nobackup - − tmp/.nobackup - − torbrowser/.nobackup Changes: ===================================== git_clones/.nobackup → .nobackup ===================================== ===================================== hg_clones/.nobackup deleted ===================================== ===================================== mullvadbrowser/.nobackup deleted ===================================== ===================================== out/.nobackup deleted ===================================== ===================================== testbuild/.nobackup deleted ===================================== ===================================== tmp/.nobackup deleted ===================================== ===================================== torbrowser/.nobackup deleted ===================================== View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.0] Bug 40996: Move .nobackup to the root of the repository.
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: 81e3a2f4 by Pier Angelo Vendrame at 2024-11-21T17:20:46+01:00 Bug 40996: Move .nobackup to the root of the repository. The .nobackup files prevent from creating symlinks between clones, which is useful for several use cases (multiple clones, directories in different drives, etc...). A .nobackup in the root will not interfere with symlinks anymore, and we think it is acceptable, as a repo will probably be in sync with GitLab or something similar. git update-index --assume-unchanged can help if someone wants to remove the .nobackup. - - - - - 7 changed files: - git_clones/.nobackup → .nobackup - − hg_clones/.nobackup - − mullvadbrowser/.nobackup - − out/.nobackup - − testbuild/.nobackup - − tmp/.nobackup - − torbrowser/.nobackup Changes: ===================================== git_clones/.nobackup → .nobackup ===================================== ===================================== hg_clones/.nobackup deleted ===================================== ===================================== mullvadbrowser/.nobackup deleted ===================================== ===================================== out/.nobackup deleted ===================================== ===================================== testbuild/.nobackup deleted ===================================== ===================================== tmp/.nobackup deleted ===================================== ===================================== torbrowser/.nobackup deleted ===================================== View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40996: Move .nobackup to the root of the repository.
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: aab75f14 by Pier Angelo Vendrame at 2024-11-21T16:49:22+01:00 Bug 40996: Move .nobackup to the root of the repository. The .nobackup files prevent from creating symlinks between clones, which is useful for several use cases (multiple clones, directories in different drives, etc...). A .nobackup in the root will not interfere with symlinks anymore, and we think it is acceptable, as a repo will probably be in sync with GitLab or something similar. git update-index --assume-unchanged can help if someone wants to remove the .nobackup. - - - - - 7 changed files: - git_clones/.nobackup → .nobackup - − hg_clones/.nobackup - − mullvadbrowser/.nobackup - − out/.nobackup - − testbuild/.nobackup - − tmp/.nobackup - − torbrowser/.nobackup Changes: ===================================== git_clones/.nobackup → .nobackup ===================================== ===================================== hg_clones/.nobackup deleted ===================================== ===================================== mullvadbrowser/.nobackup deleted ===================================== ===================================== out/.nobackup deleted ===================================== ===================================== testbuild/.nobackup deleted ===================================== ===================================== tmp/.nobackup deleted ===================================== ===================================== torbrowser/.nobackup deleted ===================================== View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.5.0esr-14.0-1-build1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new tag mullvad-browser-128.5.0esr-14.0-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.5.0esr-14.0-1] 22 commits: MB 38: Mullvad Browser configuration
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 67c46c20 by Pier Angelo Vendrame at 2024-11-19T22:06:01+01:00 MB 38: Mullvad Browser configuration - - - - - 1c365f12 by Pier Angelo Vendrame at 2024-11-19T22:06:03+01:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - a4d96e33 by Henry Wilkes at 2024-11-19T22:06:03+01:00 Mullvad Browser strings This commit adds strings needed by the following Mullvad Browser patches. - - - - - a1ca4ea2 by Pier Angelo Vendrame at 2024-11-19T22:06:03+01:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - 3255cfc3 by Pier Angelo Vendrame at 2024-11-19T22:06:04+01:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - 11bdbec7 by Pier Angelo Vendrame at 2024-11-19T22:06:04+01:00 MB 37: Customization for the about dialog - - - - - 607dd31a by Henry Wilkes at 2024-11-19T22:06:05+01:00 MB 39: Add home page about:mullvad-browser - - - - - a48aa06e by hackademix at 2024-11-19T22:06:05+01:00 MB 97: Remove UI cues to install new extensions. - - - - - 8924ec38 by hackademix at 2024-11-19T22:06:05+01:00 MB 47: uBlock Origin customization - - - - - 1e44ee0c by Pier Angelo Vendrame at 2024-11-19T22:06:06+01:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - c0ccdda8 by Pier Angelo Vendrame at 2024-11-19T22:06:06+01:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - 583aa28c by Nicolas Vigier at 2024-11-19T22:06:06+01:00 MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - 64bc42c1 by Pier Angelo Vendrame at 2024-11-19T22:06:07+01:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - b9795bfb by Pier Angelo Vendrame at 2024-11-19T22:06:07+01:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - 2790ce4b by hackademix at 2024-11-19T22:06:07+01:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - 35d3cab7 by Richard Pospesel at 2024-11-19T22:06:08+01:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - edf4716e by rui hildt at 2024-11-19T22:06:08+01:00 MB 213: Customize the search engines list MB 328: Refactor the search engine patch. Upstream switched to a completely different search engine configuration between ESR 115 and ESR 128. We moved our configuration to a couple of JSON files that do not follow upstream's schemas, as they are overcomplicated for our needs. Also, we keep the old search engine extensions for now, as upstream also kept them, and planned of removing them with Bug 1885953. - - - - - c60a08b0 by hackademix at 2024-11-19T22:06:08+01:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - 84e44389 by Pier Angelo Vendrame at 2024-11-19T22:06:09+01:00 MB 80: Enable Mullvad Browser as a default browser - - - - - 833ce291 by Pier Angelo Vendrame at 2024-11-19T22:06:09+01:00 MB 320: Temporarily disable WebRTC and WDBA on Windows. WebRTC should be re-enabled when tor-browser#42758 is resolved, and and the default browser agent when in general we make this feature work again. - - - - - 3a9b1e1c by june wilde at 2024-11-19T22:06:09+01:00 fixup! MB 320: Temporarily disable WebRTC and WDBA on Windows. - - - - - f2822db5 by Henry Wilkes at 2024-11-19T22:06:10+01:00 MB 329: Customize toolbar for mullvad-browser. - - - - - 30 changed files: - .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png - + browser/branding/mb-alpha/content/aboutDialog.css The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41313: Add StartupNotify=true to .desktop files
by boklm (＠boklm) 21 Nov '24

21 Nov '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0a5a94a6 by Nicolas Vigier at 2024-11-21T11:18:21+01:00 Bug 41313: Add StartupNotify=true to .desktop files - - - - - 2 changed files: - projects/browser/RelativeLink/start-browser.desktop - projects/linux-packages/browser.desktop.in Changes: ===================================== projects/browser/RelativeLink/start-browser.desktop ===================================== @@ -31,4 +31,5 @@ Categories=Network;WebBrowser;Security; Exec=sh -c '"$(dirname "$*")"/Browser/start-[% c("var/project-name") %] || ([ ! -x "$(dirname "$*")"/Browser/start-[% c("var/project-name") %] ] && "$(dirname "$*")"/start-[% c("var/project-name") %])' dummy %k X-[% c("var/ProjectName") %]-ExecShell=./Browser/start-[% c("var/project-name") %] --detach Icon=web-browser +StartupNotify=true StartupWMClass=[% c("var/display_name") %] ===================================== projects/linux-packages/browser.desktop.in ===================================== @@ -7,6 +7,7 @@ Comment=[% c("var/system_pkg/pkg_description") %] Categories=Network;WebBrowser; Exec=/[% c("var/system_pkg/install_path") %]/start-[% c("var/project-name") %] %u Icon=[% c("var/system_pkg/pkg_name") %] +StartupNotify=true StartupWMClass=[% c("var/display_name") %] [% IF ! c("var/tor-browser") -%] MimeType=text/html;text/xml;application/xhtml_xml;x-scheme-handler/http;x-scheme-handler/https; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41312: Remove comment in start-browser about --class and --name parameters
by boklm (＠boklm) 21 Nov '24

21 Nov '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: f0396f1f by Nicolas Vigier at 2024-11-21T11:15:58+01:00 Bug 41312: Remove comment in start-browser about --class and --name parameters Since 1e151f802295c33b6ecd3859d8e079fc5c36e1d0 those parameters are no longer used. - - - - - 1 changed file: - projects/browser/RelativeLink/start-browser Changes: ===================================== projects/browser/RelativeLink/start-browser ===================================== @@ -387,14 +387,6 @@ export __GL_SHADER_DISK_CACHE=0 cd "$browser_dir" -# We pass all additional command-line arguments we get to Firefox. -# -# The --class parameter was added to fix bug trac#11102 (X11). -# The --name parameter was added to fix bug tor-browser-build#40517 (Wayland). -# --class and --name parameters are used to make sure WM_CLASS is set -# up correctly, to identify itself from plain Firefox windows (and -# prevent from mixing up with them). - if [ "$show_usage" -eq 1 ]; then # Display Firefox help, then our help [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] --help 2>/dev/null View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-128.5.0esr-14.5-1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new branch mullvad-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-128.5.0esr-14.5-1-build1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new tag base-browser-128.5.0esr-14.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-128.5.0esr-14.5-1-build1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new tag base-browser-128.5.0esr-14.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-128.5.0esr-14.5-1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new branch base-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 4 commits: Bug 41266: Add the linux-aarch64 target to Firefox
by boklm (＠boklm) 21 Nov '24

21 Nov '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 3a0f6937 by NoisyCoil at 2024-11-21T11:04:34+01:00 Bug 41266: Add the linux-aarch64 target to Firefox - - - - - 2def046d by NoisyCoil at 2024-11-21T11:04:40+01:00 Bug 41266: Do not require SSE2 support on non-x86 targets in start-browser - - - - - 32a0ef3c by NoisyCoil at 2024-11-21T11:04:42+01:00 Bug 41266: Add the linux-aarch64 target to release and Makefile - - - - - 860ce1a5 by NoisyCoil at 2024-11-21T11:04:43+01:00 Bug 41266: Add linux-aarch64 to browser-all{,-desktop} if testbuild or nightly Also, add a 'browser-all-target' target to make this possible. Co-authored-by: Nicolas Vigier <boklm(a)torproject.org> - - - - - 7 changed files: - Makefile - projects/browser/RelativeLink/start-browser - projects/firefox/build - projects/firefox/config - projects/firefox/mozconfig - projects/release/build - projects/release/config Changes: ===================================== Makefile ===================================== @@ -36,6 +36,9 @@ torbrowser-release-linux-x86_64-asan: submodule-update torbrowser-release-linux-i686: submodule-update $(rbm) build release --target release --target browser-linux-i686 --target torbrowser +torbrowser-release-linux-aarch64: submodule-update + $(rbm) build release --target release --target browser-linux-aarch64 --target torbrowser + torbrowser-release-windows-i686: submodule-update $(rbm) build release --target release --target browser-windows-i686 --target torbrowser @@ -75,6 +78,9 @@ torbrowser-alpha-linux-x86_64: submodule-update torbrowser-alpha-linux-x86_64-asan: submodule-update $(rbm) build release --target alpha --target browser-linux-x86_64-asan --target torbrowser +torbrowser-alpha-linux-aarch64: submodule-update + $(rbm) build release --target alpha --target browser-linux-aarch64 --target torbrowser + torbrowser-alpha-linux-i686: submodule-update $(rbm) build release --target alpha --target browser-linux-i686 --target torbrowser @@ -117,6 +123,9 @@ torbrowser-nightly-linux-x86_64: submodule-update torbrowser-nightly-linux-x86_64-asan: submodule-update $(rbm) build release --target nightly --target browser-linux-x86_64-asan --target torbrowser +torbrowser-nightly-linux-aarch64: submodule-update + $(rbm) build release --target nightly --target browser-linux-aarch64 --target torbrowser + torbrowser-nightly-linux-i686: submodule-update $(rbm) build release --target nightly --target browser-linux-i686 --target torbrowser @@ -162,6 +171,9 @@ torbrowser-testbuild-linux-x86_64-asan: submodule-update torbrowser-testbuild-linux-i686: submodule-update $(rbm) build release --target testbuild --target browser-linux-i686 --target torbrowser +torbrowser-testbuild-linux-aarch64: submodule-update + $(rbm) build release --target testbuild --target browser-linux-aarch64 --target torbrowser + torbrowser-testbuild-windows-x86_64: submodule-update $(rbm) build release --target testbuild --target browser-windows-x86_64 --target torbrowser @@ -274,6 +286,9 @@ basebrowser-release-linux-x86_64-asan: submodule-update basebrowser-release-linux-i686: submodule-update $(rbm) build release --target release --target browser-linux-i686 --target basebrowser +basebrowser-release-linux-aarch64: submodule-update + $(rbm) build release --target release --target browser-linux-aarch64 --target basebrowser + basebrowser-release-windows-i686: submodule-update $(rbm) build release --target release --target browser-windows-i686 --target basebrowser @@ -316,6 +331,9 @@ basebrowser-alpha-linux-x86_64-asan: submodule-update basebrowser-alpha-linux-i686: submodule-update $(rbm) build release --target alpha --target browser-linux-i686 --target basebrowser +basebrowser-alpha-linux-aarch64: submodule-update + $(rbm) build release --target alpha --target browser-linux-aarch64 --target basebrowser + basebrowser-alpha-windows-i686: submodule-update $(rbm) build release --target alpha --target browser-windows-i686 --target basebrowser @@ -358,6 +376,9 @@ basebrowser-nightly-linux-x86_64-asan: submodule-update basebrowser-nightly-linux-i686: submodule-update $(rbm) build release --target nightly --target browser-linux-i686 --target basebrowser +basebrowser-nightly-linux-aarch64: submodule-update + $(rbm) build release --target nightly --target browser-linux-aarch64 --target basebrowser + basebrowser-nightly-windows-i686: submodule-update $(rbm) build release --target nightly --target browser-windows-i686 --target basebrowser @@ -400,6 +421,9 @@ basebrowser-testbuild-linux-x86_64-asan: submodule-update basebrowser-testbuild-linux-i686: submodule-update $(rbm) build release --target testbuild --target browser-linux-i686 --target basebrowser +basebrowser-testbuild-linux-aarch64: submodule-update + $(rbm) build release --target testbuild --target browser-linux-aarch64 --target basebrowser + basebrowser-testbuild-windows-x86_64: submodule-update $(rbm) build release --target testbuild --target browser-windows-x86_64 --target basebrowser @@ -440,6 +464,9 @@ mullvadbrowser-release-linux-x86_64: submodule-update mullvadbrowser-release-linux-x86_64-asan: submodule-update $(rbm) build release --target release --target browser-linux-x86_64-asan --target mullvadbrowser +mullvadbrowser-release-linux-aarch64: submodule-update + $(rbm) build release --target release --target browser-linux-aarch64 --target mullvadbrowser + mullvadbrowser-release-windows-x86_64: submodule-update $(rbm) build release --target release --target browser-windows-x86_64 --target mullvadbrowser @@ -461,6 +488,9 @@ mullvadbrowser-alpha-linux-x86_64: submodule-update mullvadbrowser-alpha-linux-x86_64-asan: submodule-update $(rbm) build release --target alpha --target browser-linux-x86_64-asan --target mullvadbrowser +mullvadbrowser-alpha-linux-aarch64: submodule-update + $(rbm) build release --target alpha --target browser-linux-aarch64 --target mullvadbrowser + mullvadbrowser-alpha-windows-x86_64: submodule-update $(rbm) build release --target alpha --target browser-windows-x86_64 --target mullvadbrowser @@ -482,6 +512,9 @@ mullvadbrowser-nightly-linux-x86_64: submodule-update mullvadbrowser-nightly-linux-x86_64-asan: submodule-update $(rbm) build release --target nightly --target browser-linux-x86_64-asan --target mullvadbrowser +mullvadbrowser-nightly-linux-aarch64: submodule-update + $(rbm) build release --target nightly --target browser-linux-aarch64 --target mullvadbrowser + mullvadbrowser-nightly-windows-x86_64: submodule-update $(rbm) build release --target nightly --target browser-windows-x86_64 --target mullvadbrowser @@ -503,6 +536,9 @@ mullvadbrowser-testbuild-linux-x86_64: submodule-update mullvadbrowser-testbuild-linux-x86_64-asan: submodule-update $(rbm) build release --target testbuild --target browser-linux-x86_64-asan --target mullvadbrowser +mullvadbrowser-testbuild-linux-aarch64: submodule-update + $(rbm) build release --target testbuild --target browser-linux-aarch64 --target mullvadbrowser + mullvadbrowser-testbuild-windows-x86_64: submodule-update $(rbm) build release --target testbuild --target browser-windows-x86_64 --target mullvadbrowser ===================================== projects/browser/RelativeLink/start-browser ===================================== @@ -87,10 +87,12 @@ if [ "`id -u`" -eq 0 ]; then exit 1 fi +[% IF c('var/linux-i686') || c('var/linux-x86_64') -%] if test -r /proc/cpuinfo && ! grep -q '^flags\s*:.* sse2' /proc/cpuinfo; then complain "[% c('var/Project_Name') %] requires a CPU with SSE2 support. Exiting." exit 1 fi +[% END -%] print_usage () { printf "\n[% c('var/Project_Name') %] Script Options\n" ===================================== projects/firefox/build ===================================== @@ -20,16 +20,21 @@ mkdir -p [% out_dir %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/rust') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/cbindgen') %] -tar -C /var/tmp/dist -xf [% c('input_files_by_name/nasm') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/node') %] -export PATH="/var/tmp/dist/rust/bin:/var/tmp/dist/cbindgen:/var/tmp/dist/nasm/bin:/var/tmp/dist/node/bin:$PATH" +[% IF ! c("var/linux-aarch64") -%] + tar -C /var/tmp/dist -xf [% c('input_files_by_name/nasm') %] + export PATH="/var/tmp/dist/nasm/bin:$PATH" +[% END -%] +export PATH="/var/tmp/dist/rust/bin:/var/tmp/dist/cbindgen:/var/tmp/dist/node/bin:$PATH" [% IF c("var/linux") -%] tar -C /var/tmp/dist -xf [% c('input_files_by_name/clang') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/python') %] export PATH="/var/tmp/dist/python/bin:$PATH" - tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/binutils') %] - export PATH="/var/tmp/dist/binutils/bin:$PATH" + [% IF ! c("var/linux-cross") -%] + tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/binutils') %] + export PATH="/var/tmp/dist/binutils/bin:$PATH" + [% END -%] # Use clang for everything on Linux now if we don't build with ASan. [% IF ! c("var/asan") -%] export PATH="/var/tmp/dist/clang/bin:$PATH" @@ -39,6 +44,8 @@ export PATH="/var/tmp/dist/rust/bin:/var/tmp/dist/cbindgen:/var/tmp/dist/nasm/bi # breakage in Rust code. It seems that environment variable is not passed # down properly in that case. Thus, we set it here in the build script. export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:/usr/lib/i386-linux-gnu/pkgconfig" + [% ELSIF c("var/linux-cross") -%] + export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:/usr/lib/[% c("var/crosstarget") %]/pkgconfig" [% END -%] [% END -%] @@ -296,14 +303,21 @@ cp -L obj-*/dist/bin/geckodriver* $distdir cd $distdir [% IF c("var/linux") -%] + [% IF c("var/linux-cross") -%] + CROSS_PREFIX=[% c("var/crosstarget") %]- + [% END -%] + + OBJCOPY="${CROSS_PREFIX}objcopy" + STRIP="${CROSS_PREFIX}strip" + mkdir -p $distdir/Debug/Browser # Strip and generate debuginfo for the firefox binary that we keep, all *.so # files, and the updater (see ticket #10126) for LIB in Browser/*.so "Browser/[% c('var/exe_name') %].real" [% IF c("var/updater_enabled") -%]Browser/updater[% END %] do - objcopy --only-keep-debug $LIB Debug/$LIB - strip $LIB - objcopy --add-gnu-debuglink=./Debug/$LIB $LIB + "$OBJCOPY" --only-keep-debug $LIB Debug/$LIB + "$STRIP" $LIB + "$OBJCOPY" --add-gnu-debuglink=./Debug/$LIB $LIB done [% END -%] @@ -328,15 +342,19 @@ END; %] [% IF c("var/linux") -%] - /var/tmp/dist/gcc/bin/g++ $rootdir/abicheck.cc -o Browser/abicheck -std=c++17 + /var/tmp/dist/gcc/bin/"${CROSS_PREFIX}g++" $rootdir/abicheck.cc -o Browser/abicheck -std=c++17 [% IF !c("var/tor-browser") -%] libdest=Browser/libstdc++ mkdir -p "$libdest" + libdir=[% c("var/libdir") %] + [% IF c("var/linux-cross") -%] + libdir="[% c("var/crosstarget") %]/$libdir" + [% END -%] # FIXME: tor-browser-build#40749 - cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libstdc++.so.* "$libdest" + cp "/var/tmp/dist/gcc/$libdir/libstdc++.so."* "$libdest" [% IF c("var/asan") -%] - cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libasan.so.* "$libdest" - cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libubsan.so.* "$libdest" + cp "/var/tmp/dist/gcc/$libdir/libasan.so."* "$libdest" + cp "/var/tmp/dist/gcc/$libdir/libubsan.so."* "$libdest" [% END -%] [% END -%] [% END -%] ===================================== projects/firefox/config ===================================== @@ -143,6 +143,23 @@ targets: - libdrm-dev:i386 libdir: lib32 + linux-aarch64: + var: + arch_deps: + - libgtk2.0-dev:arm64 + - libgtk-3-dev:arm64 + - libdbus-glib-1-dev:arm64 + - libxt-dev:arm64 + # To pass configure since ESR 31 + - libpulse-dev:arm64 + # To pass configure since ESR 52 + - libx11-xcb-dev:arm64 + # To pass configure since ESR 102 + - libasound2-dev:arm64 + # To support Wayland mode + - libdrm-dev:arm64 + libdir: lib64 + macos: var: nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-macos' @@ -162,9 +179,10 @@ input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' + # Cross-binutils are already included in the cross-compiler - project: binutils name: binutils - enable: '[% c("var/linux") %]' + enable: '[% c("var/linux") && ! c("var/linux-cross") %]' - filename: fix-info-plist.py enable: '[% c("var/macos") %]' - filename: nsis-uninstall.patch @@ -183,6 +201,7 @@ input_files: name: node - project: nasm name: nasm + enable: '[% ! c("var/linux-aarch64") %]' - project: python name: python enable: '[% c("var/linux") %]' ===================================== projects/firefox/mozconfig ===================================== @@ -13,6 +13,10 @@ # set LDFLAGS for Full RELRO export LDFLAGS="-Wl,-z,relro -Wl,-z,now" + + [% IF c("var/linux-cross") -%] + export LDFLAGS="-L/var/tmp/dist/gcc/[% c("var/crosstarget") %]/lib $LDFLAGS" + [% END -%] [% END -%] [% IF c("var/windows") -%] ===================================== projects/release/build ===================================== @@ -37,6 +37,9 @@ mkdir -p "$destdir" [% IF c("var/browser-linux-x86_64") -%] mv [% c('input_files_by_name/linux-x86_64') %]/* "$destdir"/ [% END -%] +[% IF c("var/browser-linux-aarch64") -%] + mv [% c('input_files_by_name/linux-aarch64') %]/* "$destdir"/ +[% END -%] [% IF c("var/linux-packages") -%] mv [% c('input_files_by_name/deb-packages') %]/* "$destdir"/ mv [% c('input_files_by_name/rpm-packages') %]/* "$destdir"/ ===================================== projects/release/config ===================================== @@ -12,6 +12,7 @@ targets: browser-all: - browser-linux-x86_64 - browser-linux-i686 + - browser-linux-aarch64 - browser-windows-i686 - browser-windows-x86_64 - browser-macos @@ -20,13 +21,16 @@ targets: - browser-android-x86_64 - browser-android-aarch64 - browser-src + - browser-all-target browser-all-desktop: - browser-linux-x86_64 - browser-linux-i686 + - browser-linux-aarch64 - browser-windows-i686 - browser-windows-x86_64 - browser-macos - browser-src + - browser-all-target browser-all-android: - browser-android-armv7 - browser-android-x86 @@ -56,6 +60,10 @@ targets: var: browser-linux-i686: '[% c("var/browser_type") != "mullvadbrowser" %]' linux-packages: '[% c("var/mullvad-browser") || c("var/tor-browser-linux-packages") %]' + browser-linux-aarch64: + var: + browser-linux-aarch64: '[% ! c("var/browser-all-target") || c("var/testbuild") || c("var/nightly") %]' + linux-packages: 0 browser-windows-i686: var: browser-windows-i686: '[% c("var/browser_type") != "mullvadbrowser" %]' @@ -77,6 +85,9 @@ targets: browser-src-testbuild: var: browser-src: 1 + browser-all-target: + var: + browser-all-target: 1 notarget: - torbrowser @@ -189,6 +200,13 @@ input_files: - '[% c("var/build_target") %]' - '[% c("var/browser_type") %]-linux-i686' + - name: linux-aarch64 + project: browser + enable: '[% c("var/browser-linux-aarch64") %]' + target: + - '[% c("var/build_target") %]' + - '[% c("var/browser_type") %]-linux-aarch64' + - name: deb-packages project: linux-packages enable: '[% c("var/linux-packages") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.5.0esr-14.5-1-build1
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed new tag tor-browser-128.5.0esr-14.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.5.0esr-14.5-1] 279 commits: Bug 1436226: Ignore user prefs and hardware support for media capabilities...
by Pier Angelo Vendrame (＠pierov) 21 Nov '24

21 Nov '24

Pier Angelo Vendrame pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: c1861f53 by Fatih at 2024-11-19T17:22:04+01:00 Bug 1436226: Ignore user prefs and hardware support for media capabilities when RFPTarget::MediaCapabilities is enabled. r=tjr,media-playback-reviewers,padenot This patch mostly targeted Android, as media.mediasource.vp9.enabled is disabled on only Android and HW support takes precedence over pref, hence leaking HW support for VP9. However, we ended up modifying the patch to ignore prefs or HW support, fixing both possible user pref leak and HW support leak. Differential Revision: https://phabricator.services.mozilla.com/D221338 - - - - - a3e15ddf by stransky at 2024-11-19T17:22:05+01:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 18015192 by hackademix at 2024-11-19T17:53:28+01:00 Bug 1556002 - Update initial window size and letterboxing stepping. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D226598 - - - - - ed5c7eb2 by Fatih at 2024-11-19T17:53:29+01:00 Bug 1607032: Spoof screen orientation and angle to primary values. r=tjr,geckoview-reviewers,owlish Differential Revision: https://phabricator.services.mozilla.com/D220904 - - - - - 9e61bfe6 by Henry Wilkes at 2024-11-19T17:53:29+01:00 Bug 1436462 - Use "Open in new private window" for bookmarks when in PBM. r=places-reviewers,mak This makes the bookmark menu consistent with the "File" and context menu when using private browsing mode. We also share the same hide item logic for these "open" items in one place in PlacesUIUtils so that they can be shared between the two consumers (regular bookmarks and managed bookmarks). This ensures that the "Open in container" item if hidden for managed bookmarks in a private window. Differential Revision: https://phabricator.services.mozilla.com/D220120 - - - - - ca5164a1 by Fatih at 2024-11-19T17:53:30+01:00 Bug 1834307: Change StaticPrefs::general_smoothScroll() calls with nsLayoutUtils::IsSmoothScrollingEnabled. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221363 - - - - - 2f3dd2ed by Fatih at 2024-11-19T17:53:30+01:00 Bug 1834307: Check RFPTarget::CSSPrefersReducedMotion in nsLayoutUtils::IsSmoothScrollingEnabled. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221364 - - - - - 3e97f3a7 by Roger Yang at 2024-11-19T17:53:30+01:00 Bug 1862537 - Do not try to go back when it's a initial load r=android-reviewers,harrisono, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D219782 - - - - - 95ef294a by Timothy Nikkel at 2024-11-19T17:53:31+01:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - 9f58ef1a by pollymce at 2024-11-19T17:53:31+01:00 Bug 1902996 - Improve messaging for fullscreen notifications. r=android-reviewers,gl Instead of explaining to users that they are in fullscreen mode, which may be obvious, we explain how to get out of it :) Also use a Toast rather than a custom Dialog. Update Focus too. Fix lint errors. Differential Revision: https://phabricator.services.mozilla.com/D215782 - - - - - d8b96812 by Jon Coppeard at 2024-11-19T17:53:31+01:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 3b9faaf0 by rahulsainani at 2024-11-19T17:53:32+01:00 Bug 1906024 - Format download file names better a=diannaS Original Revision: https://phabricator.services.mozilla.com/D220559 Differential Revision: https://phabricator.services.mozilla.com/D222254 - - - - - cffb7356 by rahulsainani at 2024-11-19T17:53:32+01:00 Bug 1906024 - Format download file names a=diannaS Original Revision: https://phabricator.services.mozilla.com/D221771 Differential Revision: https://phabricator.services.mozilla.com/D222259 - - - - - c9b4b5ec by Arturo Mejia at 2024-11-19T17:53:33+01:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Original Revision: https://phabricator.services.mozilla.com/D216996 Differential Revision: https://phabricator.services.mozilla.com/D217718 - - - - - c543ea70 by Sam Foster at 2024-11-19T17:53:33+01:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - 38ef9aa8 by Nika Layzell at 2024-11-19T17:53:33+01:00 Bug 1911745 - Unify BrowsingContext flag coherency checks, r=mccr8 Previously these checks were largely diagnostic tools for finding bugs in other code as it evolves. This unifies the checks a bit more and makes them stronger for BrowsingContexts created over IPC, providing a place for more coherency checks to be added in the future. Differential Revision: https://phabricator.services.mozilla.com/D218860 - - - - - 1c694454 by Pier Angelo Vendrame at 2024-11-19T17:53:34+01:00 Bug 1918009 - Fix the RFP-spoofed User-Agent header. r=tjr The spoofed value of the HTTP user-agent header is not consistent with the value of navigator.userAgent on Windows, and this can lead to compatibility issues. Differential Revision: https://phabricator.services.mozilla.com/D223745 - - - - - 4eb6d5bb by Fatih at 2024-11-19T17:53:34+01:00 Bug 1918202: Spoof orientation based on screen size. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221863 - - - - - bc7ebde1 by Henry Wilkes at 2024-11-19T17:53:34+01:00 Bug 1919363 - Only show one app menu "new window" item in permanent private browsing. r=mconley We also update the browser_private_browsing_window.js test. The previous test was limited because it was referring to non-existent "appmenu_newNavigator" and "appmenu_newPrivateWindow". Differential Revision: https://phabricator.services.mozilla.com/D222507 - - - - - f817861e by Fatih at 2024-11-19T17:53:35+01:00 Bug 1922204: fixup square spoofed orientation. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D224312 - - - - - 0d2dd437 by Pier Angelo Vendrame at 2024-11-19T17:53:35+01:00 Bug 1923264 - Discard unsupported updates in selectUpdate. r=bytesized,nalexander UpdateService.#selectUpdate currently chooses always the most recent update even when unsupported and an older but supported one is available. This commit makes #selectUpdate discard the unsupported update if a supported alternative is found. Differential Revision: https://phabricator.services.mozilla.com/D224905 - - - - - d3fcf352 by Henry Wilkes at 2024-11-19T17:53:36+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - e93211ca by Henry Wilkes at 2024-11-19T17:53:36+01:00 Bug 43072: Add aria label and description to moz-message-bar. Ensures that moz-message-bar, including notifications, are announced on Orca. This addresses upstream bugzilla bug 1895857 and should likely be replaced when it is fixed. - - - - - 30c7ed8d by Henry Wilkes at 2024-11-19T17:53:36+01:00 Bug 42739: Use the brand name for profile error messages. Some messages in profileSelection.properties use gAppData->name as variable inputs. However, gAppData->name is still "Firefox" for our base-browser builds, rather than the user-facing browser name. We swap these instances with the displayed brand name instead. - - - - - e045026a by hackademix at 2024-11-19T17:53:37+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 078390d9 by Henry Wilkes at 2024-11-19T17:53:37+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 89433847 by hackademix at 2024-11-19T17:53:37+01:00 Bug 43101: Deep link to the startup security warning explanation. - - - - - 57b060ca by Marco Simonelli at 2024-11-19T17:53:38+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 4e767947 by Marco Simonelli at 2024-11-19T17:53:38+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - b667f2aa by Marco Simonelli at 2024-11-19T17:53:38+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 4fb7b9b1 by Marco Simonelli at 2024-11-19T17:53:39+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 636ba155 by Marco Simonelli at 2024-11-19T17:53:39+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 042fd42f by Marco Simonelli at 2024-11-19T17:53:40+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 5d1e3b05 by june wilde at 2024-11-19T17:53:40+01:00 Bug 42758: Fix WebRTC build errors. - - - - - d1cdc4c1 by hackademix at 2024-11-19T17:53:40+01:00 Bug 41854: Allow overriding download spam protection. - - - - - f926fd0e by hackademix at 2024-11-19T17:53:41+01:00 Bug 42832: Download spam prevention exemption for browser extensions. - - - - - f77269e3 by Pier Angelo Vendrame at 2024-11-19T17:53:41+01:00 Bug 42220: Allow for more file types to be forced-inline. Firefox allows to open some files in the browser without any confirmation, but this will result in a disk leak, because the file will be downloaded to the temporary directory first (and not deleted, in some cases). A preference allows PDFs to be opened without being downloaded to disk. So, we introduce a similar one to do the same for all the files that are set to be opened automatically in the browser. - - - - - 99c035e8 by hackademix at 2024-11-19T17:53:41+01:00 Bug 42835: Create an actor to filter file data transfers - - - - - 482e1388 by Beatriz Rizental at 2024-11-19T17:53:42+01:00 Bug 42728: Modify ./mach lint to skip unused linters - - - - - 8dbd457f by Gaba at 2024-11-19T17:53:42+01:00 Adding issue and merge request templates - - - - - aaaa0a99 by Henry Wilkes at 2024-11-19T17:53:42+01:00 fixup! Adding issue and merge request templates Bug 43262: Update QA desktop checklist to include testing saved keys and their preferences. - - - - - 18aa8efe by Morgan at 2024-11-19T17:53:43+01:00 fixup! Adding issue and merge request templates Bug 43295: Update MR templates - - - - - dde993ab by Richard Pospesel at 2024-11-19T17:53:43+01:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 4c48cf6c by Beatriz Rizental at 2024-11-19T17:53:45+01:00 Add CI for Base Browser - - - - - fa4cc763 by Beatriz Rizental at 2024-11-19T17:53:46+01:00 fixup! Add CI for Base Browser Always use tor-browser repository as base for CI clones. This is fine, because both tor-browser and mullvad-browser repositories share most of their history. - - - - - 6556c8f2 by Beatriz Rizental at 2024-11-19T17:53:46+01:00 fixup! Add CI for Base Browser - - - - - af43db1b by Pier Angelo Vendrame at 2024-11-19T17:53:46+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 4413ee64 by Pier Angelo Vendrame at 2024-11-19T17:53:47+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - a9389b67 by Pier Angelo Vendrame at 2024-11-19T17:53:47+01:00 Bug 29320: Replace the gnu target with gnullvm for Rust. - - - - - 8029ad35 by Pier Angelo Vendrame at 2024-11-19T17:53:47+01:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - 6486c2d7 by Pier Angelo Vendrame at 2024-11-19T17:53:48+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 09c0cc88 by Dan Ballard at 2024-11-19T17:53:48+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 078dcba4 by Henry Wilkes at 2024-11-19T17:53:48+01:00 Bug 43092: Disable wayland by default in Base Browser. - - - - - 5846d0d8 by Matthew Finkel at 2024-11-19T17:53:49+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - f873140e by Matthew Finkel at 2024-11-19T17:53:49+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 00105983 by Mike Perry at 2024-11-19T17:53:50+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 5f55f17d by cypherpunks1 at 2024-11-19T17:53:50+01:00 Bug 40717: Hide Windows SSO in settings - - - - - af6c3891 by Georg Koppen at 2024-11-19T17:53:50+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - ec28adef by Kathy Brade at 2024-11-19T17:53:51+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - d01bcaae by Henry Wilkes at 2024-11-19T17:53:51+01:00 Bug 42831: Remove the shopping components. - - - - - df78f29c by Kathy Brade at 2024-11-19T17:53:51+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - f974da0d by Alex Catarineu at 2024-11-19T17:53:52+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 776ab6d3 by Kathy Brade at 2024-11-19T17:53:52+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 7e6f06d2 by Morgan at 2024-11-19T17:53:53+01:00 Bug 42716: Disable unwanted about: pages - - - - - d42d6450 by Arthur Edelstein at 2024-11-19T17:53:53+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - dd4e6ed2 by Alex Catarineu at 2024-11-19T17:53:53+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 520a0fc8 by cypherpunks1 at 2024-11-19T17:53:54+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - bd279c9d by cypherpunks1 at 2024-11-19T17:53:54+01:00 Bug 42730: Patch RemoteSettings to use only local dumps as a data source - - - - - 0678e2b6 by Pier Angelo Vendrame at 2024-11-19T17:53:54+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - cd697f2d by Georg Koppen at 2024-11-19T17:53:55+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 627cf6c2 by Alex Catarineu at 2024-11-19T17:53:55+01:00 Bug 28369: Stop shipping pingsender executable - - - - - 377d2346 by Henry Wilkes at 2024-11-19T17:53:55+01:00 Bug 42630: Disable LaterRun module. - - - - - a80883e8 by Pier Angelo Vendrame at 2024-11-19T17:53:56+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 4b57f93d by Pier Angelo Vendrame at 2024-11-19T17:53:56+01:00 Bug 42647: Make OS HTTP User-Agent OS spoofing configurable by pref This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - 71f53de7 by Richard Pospesel at 2024-11-19T17:53:57+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 18569a80 by Richard Pospesel at 2024-11-19T17:53:57+01:00 Bug 42037: Disable about:firefoxview page - - - - - 5585ebc5 by Mike Perry at 2024-11-19T17:53:57+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 7a6b8a27 by Pier Angelo Vendrame at 2024-11-19T17:53:58+01:00 fixup! Firefox preference overrides. Bug 42125: Set and lock privacy.resistFingerprinting.exemptedDomains. The rationale for locking this is consistency with RFP. Also, set privacy.resistFingerprinting.randomDataOnCanvasExtract as a countermesure to some wrong guides. - - - - - da7eaec3 by Pier Angelo Vendrame at 2024-11-19T17:53:58+01:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 9f09a69c by Pier Angelo Vendrame at 2024-11-19T17:54:44+01:00 fixup! Firefox preference overrides. Remove our custom letterboxing size, since they are going to be also Firefox's default one after MozBug 1556002. - - - - - c74c934c by Pier Angelo Vendrame at 2024-11-19T17:54:49+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). Bug 43141: Hardcode system-ui to Arimo. - - - - - f70259bb by Pier Angelo Vendrame at 2024-11-19T17:54:49+01:00 amend! Bug 41043: Hardcode the UI font on Linux Bug 43140: Tighten up fonts on Linux. We ship a fontconfig configuration to esnure all Linux users have the same defaults and reduce the chances of fingerprinting. We used to add this file in tor-browser-build, but some users might skip it by using the browser executable without the wrapper script. Therefore, we decided to activate the file with the FontConfig API instead of the environment variables. Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). Bug 43141: Hardcode system-ui to Arimo. - - - - - 2e4d21d3 by Pier Angelo Vendrame at 2024-11-19T17:54:50+01:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - d12e7723 by Alex Catarineu at 2024-11-19T17:54:50+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 4bcb6e2d by Pier Angelo Vendrame at 2024-11-19T17:54:50+01:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 9ade38a5 by Alex Catarineu at 2024-11-19T17:54:51+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - a9552521 by Pier Angelo Vendrame at 2024-11-19T17:54:51+01:00 fixup! Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware Lint with android-format. - - - - - 1ce49a1f by Alex Catarineu at 2024-11-19T17:54:51+01:00 Bug 26345: Hide tracking protection UI - - - - - 88d549f2 by Henry Wilkes at 2024-11-19T17:54:52+01:00 Bug 43109: Hide Firefox Relay from settings. This should remain disabled, see tor-browser#42814. - - - - - c1a0de17 by Henry Wilkes at 2024-11-19T17:54:52+01:00 Bug 42777: Hide Website Privacy Preferences. We hide the Website Privacy Preferences section, which controls the "global privacy control" (GPC) and "do not track" (DNT) settings. - - - - - 75cfa93e by Morgan at 2024-11-19T17:54:52+01:00 Bug 42070: Hide "Use smooth scrolling" from settings - - - - - 1fbf0ce9 by Arthur Edelstein at 2024-11-19T17:54:53+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - a434d22f by Pier Angelo Vendrame at 2024-11-19T17:54:53+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - e5d237ba by Henry Wilkes at 2024-11-19T17:54:53+01:00 Bug 43117: Hide "Always underline links" from settings. - - - - - a7dd1215 by Pier Angelo Vendrame at 2024-11-19T17:54:54+01:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 416e0c9e by Henry Wilkes at 2024-11-19T17:54:54+01:00 Bug 43118: Hide feature recommendation (CFR) settings. - - - - - dbdae505 by Pier Angelo Vendrame at 2024-11-19T17:54:54+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 361dc5d3 by Pier Angelo Vendrame at 2024-11-19T17:54:55+01:00 Bug 42773: Replace ~ with the original home. In Bug 93141, Mozilla started sending users to their home when they type ~ in the URL bar. On Linux, we change $HOME for various reason, therefore you would be redirected to the spoofed home directory when typing ~. So, we check if the original home directory is known, and use that, instead. - - - - - 84999c19 by Alex Catarineu at 2024-11-19T17:54:55+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - e30d5450 by Mike Perry at 2024-11-19T17:54:56+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 7de7f22f by Pier Angelo Vendrame at 2024-11-19T17:54:56+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 39f99f69 by Matthew Finkel at 2024-11-19T17:54:56+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - e8711e88 by cypherpunks1 at 2024-11-19T17:54:57+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - bab407ff by cypherpunks1 at 2024-11-19T17:54:57+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - d052d514 by hackademix at 2024-11-19T17:54:57+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - 70b19528 by Pier Angelo Vendrame at 2024-11-19T17:54:58+01:00 Bug 43196: Remove the vendor name from media notifications on Linux. Firefox shows "vendor remoteName" as a title of the "... is playing media" notification on Linux. However, for our browser the remote name is enough, and prepending the vendor to it creates a string users usually never see. - - - - - d8643a5a by Pier Angelo Vendrame at 2024-11-19T17:54:58+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 977627d0 by Pier Angelo Vendrame at 2024-11-19T17:54:58+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - a449031d by p13dz at 2024-11-19T17:54:59+01:00 Bug 40283: Workaround for the file upload bug - - - - - b6758e6a by Pier Angelo Vendrame at 2024-11-19T17:54:59+01:00 fixup! Bug 40283: Workaround for the file upload bug Lint with android-format. - - - - - d64ecb5c by hackademix at 2024-11-19T17:54:59+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 11f9b227 by hackademix at 2024-11-19T17:55:00+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 205864f1 by Pier Angelo Vendrame at 2024-11-19T17:55:00+01:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - c0a6c1f0 by hackademix at 2024-11-19T17:55:00+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 90340c51 by hackademix at 2024-11-19T17:55:01+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 77e001e9 by hackademix at 2024-11-19T17:55:03+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 37fca51f by hackademix at 2024-11-19T17:55:03+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - e3532482 by hackademix at 2024-11-19T17:55:04+01:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - e6debe3c by hackademix at 2024-11-19T17:56:38+01:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 342f955a by Pier Angelo Vendrame at 2024-11-19T17:59:11+01:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Restore our changes after backporting MozBug 1556002. - - - - - 55cad064 by hackademix at 2024-11-19T17:59:15+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 7816958e by hackademix at 2024-11-19T18:00:10+01:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - 5863c026 by hackademix at 2024-11-19T18:00:11+01:00 Bug 41916: Letterboxing preferences UI - - - - - 4bb363b9 by hackademix at 2024-11-19T18:00:53+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 68b227e0 by hackademix at 2024-11-19T18:00:56+01:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - c991e95e by Henry Wilkes at 2024-11-19T18:00:56+01:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 1e4342dc by Henry Wilkes at 2024-11-19T18:00:56+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 35ca6262 by Kathy Brade at 2024-11-19T18:00:57+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 2017190b by Pier Angelo Vendrame at 2024-11-19T18:00:57+01:00 Bug 42061: Create an alpha update channel. - - - - - 5ed9db4e by Nicolas Vigier at 2024-11-19T18:00:58+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 637fffe2 by Pier Angelo Vendrame at 2024-11-19T18:00:58+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 9914b81c by Pier Angelo Vendrame at 2024-11-19T18:00:58+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 6ded2255 by Pier Angelo Vendrame at 2024-11-19T18:00:59+01:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 84af2ab6 by Alex Catarineu at 2024-11-19T18:00:59+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - e7b9438a by Matthew Finkel at 2024-11-19T18:00:59+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 097e97e3 by Henry Wilkes at 2024-11-19T18:01:00+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 8bbb8aeb by hackademix at 2024-11-19T18:01:00+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 5f7a5e2e by Pier Angelo Vendrame at 2024-11-19T18:01:00+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 8af3cab5 by Pier Angelo Vendrame at 2024-11-19T18:01:01+01:00 Bug 40926: Implemented the New Identity feature - - - - - 065db1ac by Henry Wilkes at 2024-11-19T18:01:01+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - e76305ad by Pier Angelo Vendrame at 2024-11-19T18:01:01+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 370280dd by Henry Wilkes at 2024-11-19T18:01:02+01:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - bdb6606a by Henry Wilkes at 2024-11-19T18:01:02+01:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - c0f06c75 by Richard Pospesel at 2024-11-19T18:01:02+01:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 945856bc by Beatriz Rizental at 2024-11-19T18:01:03+01:00 Add CI for Tor Browser - - - - - eaa4a40a by Henry Wilkes at 2024-11-19T18:01:03+01:00 fixup! Add CI for Tor Browser Bug 43272: Run translation CI whenever CI script changes. - - - - - e481302b by Beatriz Rizental at 2024-11-19T18:01:04+01:00 fixup! Add CI for Tor Browser Build and publish CI container images whenever they change. - - - - - c192927d by Beatriz Rizental at 2024-11-19T19:06:12+01:00 fixup! Add CI for Tor Browser Add missing dependency to CI base container. - - - - - c1202296 by Beatriz Rizental at 2024-11-19T19:24:48+01:00 fixup! Add CI for Tor Browser - - - - - f8dbf3cc by Richard Pospesel at 2024-11-19T19:24:49+01:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 68175688 by Henry Wilkes at 2024-11-19T19:24:49+01:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 3303dde5 by Kathy Brade at 2024-11-19T19:24:50+01:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - f3461921 by Alex Catarineu at 2024-11-19T19:24:50+01:00 Add TorStrings module for localization - - - - - 407d459b by Henry Wilkes at 2024-11-19T19:24:50+01:00 fixup! Add TorStrings module for localization Bug 42739: Drop profile access error strings. - - - - - c42b579d by Henry Wilkes at 2024-11-19T19:24:51+01:00 fixup! Add TorStrings module for localization Bug 42186: Drop about:tbupdate. - - - - - 06f64599 by Henry Wilkes at 2024-11-19T19:24:51+01:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 4114951e by Henry Wilkes at 2024-11-19T19:24:52+01:00 Tor Browser localization migration scripts. - - - - - c95a121e by Henry Wilkes at 2024-11-19T19:24:52+01:00 Bug 42305: Add script to combine translation files across versions. - - - - - 729a4f0d by Henry Wilkes at 2024-11-19T19:24:52+01:00 fixup! Bug 42305: Add script to combine translation files across versions. Bug 43272: Fix git fetch in translation CI script. - - - - - 7696e53d by Mike Perry at 2024-11-19T19:24:53+01:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - d1ae9633 by Henry Wilkes at 2024-11-19T19:24:53+01:00 Bug 43087: Add onion-pattern to be used on Tor pages. - - - - - fb2640f1 by hackademix at 2024-11-19T19:24:53+01:00 Bug 41917: Tor brand-specific styles. - - - - - 051839fb by Henry Wilkes at 2024-11-19T19:24:54+01:00 Bug 41817: tor-browser semantic colors. - - - - - 7c451413 by Henry Wilkes at 2024-11-19T19:24:54+01:00 Add purple tor version of the loading APNG. - - - - - 77911010 by Henry Wilkes at 2024-11-19T19:24:55+01:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 8cb9ee9c by sanketh at 2024-11-19T19:24:55+01:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 56e4fa7f by Mike Perry at 2024-11-19T19:24:55+01:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 5f2b9eb3 by Henry Wilkes at 2024-11-19T19:24:56+01:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 37d4d18a by Pier Angelo Vendrame at 2024-11-19T19:24:56+01:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - a2271087 by Pier Angelo Vendrame at 2024-11-19T19:24:56+01:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - f01b40a5 by Pier Angelo Vendrame at 2024-11-19T19:24:57+01:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - d59923b4 by Pier Angelo Vendrame at 2024-11-19T19:24:57+01:00 fixup! Bug 40933: Add tor-launcher functionality Make optional members in JSDoc comments more consistent with Firefox's codebase. - - - - - 8403e4f4 by Pier Angelo Vendrame at 2024-11-19T19:24:57+01:00 fixup! Bug 40933: Add tor-launcher functionality Bug 10439: Ask the the SOCKS port to the tor process. Allow specifying a negative port as TOR_SOCKS_PORT to let the tor process choose one for us. This does not play too well with DisableNetwork, which we use to start and stop the bootstrap, so we have to query the port every time we change this setting. Also, currently we use Firefox's preferences for SOCKS port. This prevents us from keeping a negative number saved in them. See also tor-browser#42062. - - - - - 69473a20 by Pier Angelo Vendrame at 2024-11-19T19:24:58+01:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42714: Allow to optionally use a TCP listener on Android. - - - - - 4fa61f14 by Cecylia Bocovich at 2024-11-19T19:24:58+01:00 Lox integration - - - - - e373ca33 by Henry Wilkes at 2024-11-19T19:24:59+01:00 fixup! Lox integration Bug 42597: Fix `#updatePubkeys`. - - - - - ad5886ed by Henry Wilkes at 2024-11-19T19:24:59+01:00 fixup! Lox integration Bug 42597: Fix generateInvite. We make sure to call handle_issue_invite to convert the response from "issueinvite" into credentials. We also stop stringifying the lox credentials, which are already a string. - - - - - 9c5fcaa3 by Henry Wilkes at 2024-11-19T19:24:59+01:00 fixup! Lox integration Bug 42597: Made sure we're always using `JSON.parse(request).request` where `request` is generated by lox_wasm. - - - - - 26faf7b0 by Henry Wilkes at 2024-11-19T19:25:00+01:00 fixup! Lox integration Bug 42597: Move duplicate logic into `#makeRequest`. Moreover, we pass in the common fetch arguments into buildPostRequest and treat the return value as a string instead of a JSON object. - - - - - 09063635 by Henry Wilkes at 2024-11-19T19:25:00+01:00 fixup! Lox integration Bug 42597: Refactor error handling. A lot of the errors can be propagated to the caller. - - - - - c253c8c8 by Henry Wilkes at 2024-11-19T19:25:00+01:00 fixup! Lox integration Bug 42597: Add note for missing trusted invites. - - - - - 5686dd36 by Henry Wilkes at 2024-11-19T19:25:01+01:00 fixup! Lox integration Bug 42492: Ensure operations that change lox credentials do not overlap. Not linted to improve readability. - - - - - 43113cc4 by Henry Wilkes at 2024-11-19T19:25:01+01:00 fixup! Lox integration Bug 42492: Lint Lox.sys.mjs - - - - - 4cfffdb0 by Henry Wilkes at 2024-11-19T19:25:01+01:00 fixup! Lox integration Bug 41710: Switch from TorConnectState to TorConnectStage. - - - - - 02d02c30 by Richard Pospesel at 2024-11-19T19:25:02+01:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - c3f48b32 by Pier Angelo Vendrame at 2024-11-19T19:25:02+01:00 fixup! Bug 40597: Implement TorSettings module Fix a couple of references to Moat in the generic DomainFrontedRequests module. - - - - - 342c3019 by Pier Angelo Vendrame at 2024-11-19T19:25:02+01:00 fixup! Bug 40597: Implement TorSettings module ch.asyncOpen is not a JS async function, so no need to await it. The async in the name means that the channel will call methods from a listener object that it takes as an argument when it receives data. - - - - - 0ef35f54 by Henry Wilkes at 2024-11-19T19:25:03+01:00 fixup! Bug 40597: Implement TorSettings module Bug 42597: Make buildPostRequest accept fetch arguments. This allows the request to buildPostRequest in the Lox module use the same arguments that would be passed to `fetch`. Also, return the text stream, rather than JSON. - - - - - 85c7a9f2 by Henry Wilkes at 2024-11-19T19:25:03+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Move bootstrapping attempts into a new class. We copy the logic from "BootstrappingState" and "AutoBootstrappingState" into "BootstrappingAttempt" and "AutoBootstrappingAttempt". The main difference is that we can do the following: ``` bootstrapAttempt = new BootstrapAttempt(); bootstrapResult = await bootstrapAttempt.run(); // ... bootstrapAttempt.cancel(); ``` rather than using the "StateCallback" class, which requires some complicated state management. Moreover, "AutoBootstrappingAttempt" will use "BootstrappingAttempt" for each of its attempts. So the logic for bootstrapping can be kept in one place. Some other changes: 1. Censorship simulation will no longer necessarily avoid the Moat calls, so these can be tested. 2. It would be possible to perform the internet test when auto-bootstrapping as well. 3. When auto-bootstrapping, if "Bootstrapping" produces an error other than a "BootstrapError", we can end it early. 4. No longer set TorConnect internals. 5. More fine-grained control over censorship simulation and offline simulation. - - - - - e5f61f87 by Henry Wilkes at 2024-11-19T19:25:08+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Remove StateCallback. - - - - - ae7f3218 by Henry Wilkes at 2024-11-19T19:25:09+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Return early from TorConnect.init if not enabled. - - - - - d8c5bca9 by Henry Wilkes at 2024-11-19T19:25:09+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Replace StateCallback in TorConnect. Instead of managing the abstract "State" we directly manager the user "Stage". We provide backward compatibility with the "State" for android and about:torconnect. Eventually this logic can be dropped from these endpoints and they can listen for changes in the "Stage" instead. The behaviour for about:torconnect is mostly the same as before, with some exceptions: 1. If the user sees the "Offline" state, and starts and cancels the bootstrap, they should return the to the "Offline" state, rather than "ConnectToTor". 2. Trying to start a bootstrap via the UI before the settings have loaded will do nothing. 3. Pressing a breadcrumb whilst bootstrapping will now also cancel the bootstrap. - - - - - cd38bbc8 by Henry Wilkes at 2024-11-19T19:25:10+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Switch TorConnect.openTorConnect to use new methods. - - - - - 85a770f8 by Henry Wilkes at 2024-11-19T19:25:10+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Remove unused TorConnect properties. - - - - - 4cb202b2 by Henry Wilkes at 2024-11-19T19:25:10+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Move viewTorLogs to TorConnectParent. - - - - - 9e53974e by Henry Wilkes at 2024-11-19T19:25:11+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41710: Remove the beginBootstrap, beginAutoBootstrap, and cancelBootstrap methods. - - - - - 12a0e8c4 by Arthur Edelstein at 2024-11-19T19:25:11+01:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - d47ea9d8 by Henry Wilkes at 2024-11-19T19:25:11+01:00 Bug 41600: Add a tor circuit display panel. - - - - - 3080ad1a by Henry Wilkes at 2024-11-19T19:25:12+01:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43237: Tweak Tor circuit display panel for screen readers. - - - - - 28b9a966 by Pier Angelo Vendrame at 2024-11-19T19:25:12+01:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 2ad9456f by Pier Angelo Vendrame at 2024-11-19T19:25:12+01:00 fixup! Bug 42247: Android helpers for the TorProvider Lint with android-format. - - - - - 34e48d53 by Pier Angelo Vendrame at 2024-11-19T19:25:13+01:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 43232: Make the Android Meek transport easier to debug. - - - - - 50c56d7a by Pier Angelo Vendrame at 2024-11-19T19:25:13+01:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42714: Allow to optionally use a TCP listener on Android. - - - - - 0132c62e by Henry Wilkes at 2024-11-19T19:25:14+01:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 41710: Switch Android to new TorConnect methods and add TODOs. - - - - - 2ba55dfe by hackademix at 2024-11-19T19:25:14+01:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 644a2e72 by Matthew Finkel at 2024-11-19T19:25:14+01:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 759a9a54 by Pier Angelo Vendrame at 2024-11-19T19:25:15+01:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 137db331 by Richard Pospesel at 2024-11-19T19:25:15+01:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - e21d0d5a by Henry Wilkes at 2024-11-19T19:25:15+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41710: Switch from TorConnect.state to TorConnect.stage. - - - - - 9156ef99 by Henry Wilkes at 2024-11-19T19:25:16+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43263: Update `spoof-button-disabled` buttons to use tabIndex=-1. Also remove aria-live="assertive" from role="alert" since it should already be implied by default. - - - - - 1d116fc3 by Richard Pospesel at 2024-11-19T19:25:16+01:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - ebb89172 by Henry Wilkes at 2024-11-19T19:25:17+01:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42550 - Switch about:torconnect to use TorConnect.stage to control the shown stage and sync pages. Now TorConnect entirely controls which stage should be shown to the user, and "about:torconnect" simply relays the user actions up to TorConnect to handle. In particular, we stop sending out "torconnect:broadcast-user-action" to sync pages. We also show "Try Again" if the user cancels the first bootstrap attempt without an error. We also do not try and sync the selected region between pages. However all pages should still show the *actually* submitted region after a bootstrap fails. E.g. to confirm their location. We also allow the user to re-select "Automatic" when they use breadcrumbs to go back a stage. Also change gTorConnectTitlebarStatus and gTorConnectUrlbarButton to use TorConnectStage. - - - - - ac431edf by Henry Wilkes at 2024-11-19T19:25:17+01:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41710: Move viewTorLogs and openTorPreferences to TorConnectParent. - - - - - bb1358b6 by Henry Wilkes at 2024-11-19T19:25:17+01:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 43294: Replace willDestroy with didDestroy. - - - - - 30f07f8d by Pier Angelo Vendrame at 2024-11-19T19:25:18+01:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - e872eac8 by Henry Wilkes at 2024-11-19T19:25:18+01:00 fixup! Temporary changes to about:torconnect for Android. Bug 41710: Remove onSettingsRequested. TorConnect.openTorPreferences was removed. - - - - - 38c921db by Henry Wilkes at 2024-11-19T19:25:18+01:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 837a9d0e by Henry Wilkes at 2024-11-19T19:25:19+01:00 fixup! Bug 7494: Create local home page for TBB. Bug 42186: Move override page logic to about:tor commit. - - - - - 4525f10c by Henry Wilkes at 2024-11-19T19:25:19+01:00 fixup! Bug 7494: Create local home page for TBB. Bug 42802: Use :has selector to move the focus-visible styling for the search-input to its parent. No longer need to monitor the focus-visible condition using javascript. - - - - - a9fe8e98 by Pier Angelo Vendrame at 2024-11-19T19:25:20+01:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - d9b03b10 by Pier Angelo Vendrame at 2024-11-19T19:25:20+01:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 41786: Remove the add_if command we added for fontconfig. We do not need it anymore, as we had the watershed update and, in any case, we are movign the fonts.conf in tor-browser.git. - - - - - 8fd561e2 by Kathy Brade at 2024-11-19T19:25:20+01:00 Bug 12647: Support symlinks in the updater. - - - - - 19167a57 by Georg Koppen at 2024-11-19T19:25:21+01:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 4a1f12af by Pier Angelo Vendrame at 2024-11-19T19:25:21+01:00 Bug 42891: Set the bundled search engine for Tor Browser. After upstream changes between Firefox 115 and 128, we had to completely rework the way in which we define our search engines. This commit replaces the old "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing". With that commit, we customized a list of addons IDs to ship as built-in search engines, but then upsteam moved to using only RemoteSettings. The configuration has many more fields, and it would be quite long to include it in the source code. Therefore, we use some local JSON files and load the settings from them. - - - - - 1b28170e by Alex Catarineu at 2024-11-19T19:25:21+01:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - a5619fe2 by Henry Wilkes at 2024-11-19T19:25:22+01:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 6acc199d by Richard Pospesel at 2024-11-19T19:25:22+01:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 79e77426 by Kathy Brade at 2024-11-19T19:25:22+01:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - cf217cfb by Henry Wilkes at 2024-11-19T19:25:23+01:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 43262: The deleteAll command was attached to the wrong button. - - - - - 3dd52d87 by Henry Wilkes at 2024-11-19T19:25:25+01:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 43263: Add some alert semantics for onion site keys. Also use `spoof-button-disabled` to better manage focus for temporarily disabled buttons. - - - - - f3968986 by Alex Catarineu at 2024-11-19T19:25:25+01:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 26c82672 by Pier Angelo Vendrame at 2024-11-19T19:25:26+01:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - dafaa47c by Henry Wilkes at 2024-11-19T19:25:26+01:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 43294: Replace willDestroy with didDestroy. - - - - - ac6afb69 by Pier Angelo Vendrame at 2024-11-19T19:25:26+01:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - d604b69c by Pier Angelo Vendrame at 2024-11-19T19:25:27+01:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 9cb0fe68 by Henry Wilkes at 2024-11-19T19:25:27+01:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - f0b6b513 by Dan Ballard at 2024-11-19T19:25:27+01:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 1378ba21 by Henry Wilkes at 2024-11-19T19:25:28+01:00 Bug 41736: Customize toolbar for tor-browser. - - - - - d6d44efa by hackademix at 2024-11-19T19:25:28+01:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 1a129356 by Henry Wilkes at 2024-11-19T19:25:29+01:00 Customize moz-toggle for tor-browser. - - - - - 648741db by Richard Pospesel at 2024-11-19T19:25:29+01:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - dab2cff8 by Cecylia Bocovich at 2024-11-19T19:25:29+01:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - 3b96a00e by Matthew Finkel at 2024-11-19T19:25:30+01:00 Bug 40005: [android] Modify Default toolbar menu - - - - - 92a536dc by Alex Catarineu at 2024-11-19T19:25:30+01:00 Bug 40007: [android] Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - c0680823 by Alex Catarineu at 2024-11-19T19:25:30+01:00 Bug 40002: [android] Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 698e8993 by Alex Catarineu at 2024-11-19T19:25:31+01:00 Bug 40009: [android] Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - 59ab2485 by Alex Catarineu at 2024-11-19T19:25:31+01:00 [android] Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - e1f246d3 by Georg Koppen at 2024-11-19T19:25:31+01:00 Bug 40013: [android] Add option do overwrite timestamp in extension version - - - - - aa557897 by Alex Catarineu at 2024-11-19T19:25:32+01:00 Bug 40015: [android] Port padlock states for .onion services - - - - - ead1c835 by Matthew Finkel at 2024-11-19T19:25:32+01:00 [android] Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - d419843f by Matthew Finkel at 2024-11-19T19:25:33+01:00 Bug 40023: [android] Stop PrivateNotificationService - - - - - d58d68c3 by Matthew Finkel at 2024-11-19T19:25:33+01:00 [android] Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - 83bb585e by Matthew Finkel at 2024-11-19T19:25:33+01:00 [android] Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - 420face4 by Matthew Finkel at 2024-11-19T19:25:34+01:00 [android] Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - 949a5eaa by Georg Koppen at 2024-11-19T19:25:34+01:00 [android] Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 86e1d0b2 by Matthew Finkel at 2024-11-19T19:25:35+01:00 Bug 40185: [android] Use NimbusDisabled - - - - - b83d8404 by Matthew Finkel at 2024-11-19T19:25:35+01:00 [android] Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - 28ed7415 by Henry Wilkes at 2024-11-19T19:25:35+01:00 fixup! [android] Add Tor integration and UI Bug 41710: Remove onSettingsRequested. - - - - - 666815bd by Henry Wilkes at 2024-11-19T19:25:36+01:00 fixup! [android] Add Tor integration and UI Bug 41710: Fix onBootstrapProgress for new TorConnect. The bootstrap progress signal is now released every time the stage changes. - - - - - 10d069b4 by Alex Catarineu at 2024-11-19T19:25:36+01:00 [android] Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - 43f8f6e6 by cypherpunks1 at 2024-11-19T19:25:36+01:00 fixup! [android] Modify UI/UX Bug 43241: Improve hiding non-private tab features on Android - - - - - 1bfc86e0 by cypherpunks1 at 2024-11-19T19:25:37+01:00 fixup! [android] Modify UI/UX Bug 43251: Enable tab suggestions and autocomplete for private tabs on Android - - - - - dc60c66d by hackademix at 2024-11-19T19:25:37+01:00 [android] Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 95bc1441 by Dan Ballard at 2024-11-19T19:25:37+01:00 [android] Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - 23ca18d2 by Dan Ballard at 2024-11-19T19:25:38+01:00 Bug 41972: [android] Disable mozilla onboarding - - - - - afb8540e by Dan Ballard at 2024-11-19T19:25:38+01:00 Bug 41878: [android] Add standalone Tor Bootstrap - - - - - 968c7231 by clairehurst at 2024-11-19T19:25:39+01:00 Bug 42089: [android] Remove ability to submit site support requests - - - - - 54a1e672 by clairehurst at 2024-11-19T19:25:39+01:00 [android] fixup! Modify UI/UX and Remove ability to submit site support requests - - - - - d1c759a1 by clairehurst at 2024-11-19T19:25:41+01:00 [android] Enable the connect assist experiments on alpha - - - - - d32f90c5 by Henry Wilkes at 2024-11-19T19:25:41+01:00 fixup! [android] Enable the connect assist experiments on alpha Bug 41710: Remove onSettingsRequested. - - - - - 9511236e by hackademix at 2024-11-19T19:25:41+01:00 Bug 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache. - - - - - 6e092339 by clairehurst at 2024-11-19T19:25:42+01:00 [android] Delete unused media - - - - - b3dd0f98 by clairehurst at 2024-11-19T19:25:42+01:00 Bug 42195: [android] Fix "Whats new URL" - - - - - 78f7257f by clairehurst at 2024-11-19T19:25:43+01:00 [android] Implement Android-native Connection Assist UI - - - - - 7583c3e7 by Pier Angelo Vendrame at 2024-11-19T19:25:43+01:00 Bug 42652: [android] Pass the list of supported languages to GeckoView. It will be used to prevent leaks about regional preferences. - - - - - 0aac2934 by Dan Ballard at 2024-11-19T19:25:43+01:00 Bug 42660: Disable ProxySelector.openConnectionWithProxy and NOPify CrashReporter.sendCrashReport - - - - - 5af953cb by Dan Ballard at 2024-11-19T19:25:44+01:00 Bug 43006: Disable RFP for Font Visibility on Android - - - - - 31d3d5e6 by Henry Wilkes at 2024-11-19T19:25:44+01:00 Bug 43098: Year End Campaign 2024. Implements YEC 2024 for about:tor. - - - - - 245cd26b by clairehurst at 2024-11-19T19:25:44+01:00 Bug 43099: 2024 YEC - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/containers/base/Containerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/helpers.py - + .gitlab/ci/update-containers.yml - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - + README.md - − README.txt - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0fd07c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0fd07c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-128.5.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 19 Nov '24

19 Nov '24

Pier Angelo Vendrame pushed new branch mullvad-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-128.5.0esr-14.0-1-build1
by Pier Angelo Vendrame (＠pierov) 19 Nov '24

19 Nov '24

Pier Angelo Vendrame pushed new tag base-browser-128.5.0esr-14.0-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0