- tbb-commits - lists.torproject.org

[tor-browser-bundle/master] Bug 13375: Launcher --help improvements.
by mikeperry＠torproject.org 26 Mar '15

26 Mar '15

commit 6dec1263132c2ed24ff08df0c121289d0a0f7e08 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Mar 18 12:48:25 2015 -0700 Bug 13375: Launcher --help improvements. Display the firefox message, reduce output, and simplify paths. --- RelativeLink/start-tor-browser | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/RelativeLink/start-tor-browser b/RelativeLink/start-tor-browser index 31ccb83..aac5a6e 100755 --- a/RelativeLink/start-tor-browser +++ b/RelativeLink/start-tor-browser @@ -99,23 +99,20 @@ if [ "`id -u`" -eq 0 ]; then fi debug=0 -usage_message="usage: $0 [--debug]" +show_usage=0 # !!! We may have more than one argument, changed -eq to -ge in if & elif clauses below if [ "$#" -ge 1 -a $ "x$1" = "x--debug" -o "x$1" = "x-debug" $ ]; then debug=1 shift # pop the debug argument printf "\nDebug enabled.\n\n" elif [ "$#" -ge 1 -a $ "x$1" = "x--help" -o "x$1" = "x-help" $ ]; then - echo "$usage_message" - exit 0 -fi - -# If the user hasn't requested 'debug mode', close stdout and stderr, -# to keep Firefox and the stuff loaded by/for it (including the -# system's shared-library loader) from printing messages to -# $HOME/.xsession-errors or other files. (Users wouldn't have seen -# messages there anyway.) -if [ "$debug" -ne 1 ]; then + show_usage=1 +else + # If the user hasn't requested 'debug mode' or --help, close stdout and stderr, + # to keep Firefox and the stuff loaded by/for it (including the + # system's shared-library loader) from printing messages to + # $HOME/.xsession-errors or other files. (Users wouldn't have seen + # messages there anyway.) exec >/dev/null exec 2>/dev/null fi @@ -268,7 +265,6 @@ EOF # your password in the following line where the word “secret” is: setControlPortPasswd ${TOR_CONTROL_PASSWD:='"secret"'} -printf "Launching Tor Browser for Linux in ${HOME}...\n" cd "${HOME}" # We pass all command-line arguments we got (except --debug) to Firefox. Use @@ -279,12 +275,19 @@ cd "${HOME}" # When passed the --debug option, we log all the output that goes to the # parent terminal stdout and stderr to a file ('tor-browser-debug.log' in Tor # Browser's $HOME directory). -if [ "$debug" -ne 1 ] ; then +if [ "$show_usage" -eq 1 ]; then + TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ + -profile TorBrowser/Data/Browser/profile.default "${@}" 2>/dev/null + printf "\nTor Browser Script Options\n" + printf " --debug Display Tor and Firefox output and record in tor-browser-debug.log\n" +elif [ "$debug" -ne 1 ] ; then TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ -profile TorBrowser/Data/Browser/profile.default "${@}" > /dev/null 2>&1 </dev/null & disown "$!" else - logfile=$(dirname ${HOME} )/tor-browser-debug.log + # Place logfile in the tbb root dir. + logfile=../tor-browser-debug.log + printf "Launching Tor Browser for Linux in ${HOME}...\n" printf "Logging Tor Browser debug information to file: %s\n" "$logfile" TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ -profile TorBrowser/Data/Browser/profile.default "${@}" -jsconsole 2>&1 </dev/null | \

1 0

[tor-browser-bundle/master] Send all output to /dev/null and disown, unless using --debug.
by mikeperry＠torproject.org 26 Mar '15

26 Mar '15

commit f9c0f074b2a29087f8bcc9b3072902d093d28fac Author: Isis Lovecruft <isis(a)torproject.org> Date: Wed Mar 18 08:16:10 2015 +0000 Send all output to /dev/null and disown, unless using --debug. If the start-tor-browser script is called normally, this will send all output to /dev/null and disown the firefox process. If --debug is passed to the start-tor-browser script, then output will go to the terminal it was called from, as well as the logfile, 'tor-browser-debug.log', in the top level of Tor Browser's $HOME directory. In this case, we don't disown the child firefox process, and we also pass the -jsconsole parameter to firefox. * FIXES part of #13375: https://bugs.torproject.org/13375 --- RelativeLink/start-tor-browser | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/RelativeLink/start-tor-browser b/RelativeLink/start-tor-browser index 071c80d..d28c759 100755 --- a/RelativeLink/start-tor-browser +++ b/RelativeLink/start-tor-browser @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # GNU/Linux does not really require something like RelativeLink.c # However, we do want to have the same look and feel with similar features. @@ -302,22 +302,27 @@ EOF # your password in the following line where the word “secret” is: setControlPortPasswd ${TOR_CONTROL_PASSWD:='"secret"'} -# XXX: Debug mode for Firefox?? - -# not in debug mode, run proceed normally printf "Launching Tor Browser for Linux in ${HOME}...\n" cd "${HOME}" -# XXX Someday we should pass whatever command-line arguments we got -# (probably filenames or URLs) to Firefox. -# !!! Dash above comment! Now we pass command-line arguments we got (except --debug) to Firefox. -# !!! Use at your own risk! -# Adding --class for fixing bug 11102. -TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ - -profile TorBrowser/Data/Browser/profile.default "${@}" -exitcode="$?" -if [ "$exitcode" -ne 0 ]; then - complain "Tor Browser exited abnormally. Exit code: $exitcode" - exit "$exitcode" + +# We pass all command-line arguments we got (except --debug) to Firefox. Use +# at your own risk! +# +# The --class parameter was added to fix bug 11102. +# +# When passed the --debug option, we log all the output that goes to the +# parent terminal stdout and stderr to a file ('tor-browser-debug.log' in Tor +# Browser's $HOME directory). +if [ "$debug" -ne 1 ] ; then + TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ + -profile TorBrowser/Data/Browser/profile.default "${@}" > /dev/null 2>&1 </dev/null & + disown "$!" else - printf '\nTor Browser exited cleanly.\n' + logfile=$(dirname ${HOME} )/tor-browser-debug.log + printf "Logging Tor Browser debug information to file: %s\n" "$logfile" + TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \ + -profile TorBrowser/Data/Browser/profile.default "${@}" -jsconsole 2>&1 </dev/null | \ + tee $logfile fi + +exit $?

1 0

[tor-browser-bundle/master] Add latest stable changelogs
by gk＠torproject.org 26 Mar '15

26 Mar '15

commit 12664825bebd9b12cada5e279845f8e70ecae463 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Mar 26 20:30:51 2015 +0000 Add latest stable changelogs --- Bundle-Data/Docs/ChangeLog.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Bundle-Data/Docs/ChangeLog.txt b/Bundle-Data/Docs/ChangeLog.txt index 0734bc9..e7464cf 100644 --- a/Bundle-Data/Docs/ChangeLog.txt +++ b/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,15 @@ +Tor Browser 4.0.6 -- Mar 31 2015 + * All Platforms + * Update Firefox to 31.6.0esr + * Update OpenSSL to 1.0.1m + * Update meek to 0.16 + +Tor Browser 4.0.5 -- Mar 23 2015 + * All Platforms + * Update Firefox to 31.5.3esr + * Update Tor to 0.2.5.11 + * Update NoScript to 2.6.9.19 + Tor Browser 4.5a4 -- Feb 24 2015 * All Platforms * Update Firefox to 31.5.0esr

1 0

[tor-browser/tor-browser-31.5.0esr-4.5-1] fixup! Bug #5926: Allow customization of content JS locale.
by mikeperry＠torproject.org 26 Mar '15

26 Mar '15

commit cc614e00508c5750741919a3a3890461ee0edbf2 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Mar 25 12:07:56 2015 -0700 fixup! Bug #5926: Allow customization of content JS locale. --- xpcom/build/nsXPComInit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xpcom/build/nsXPComInit.cpp b/xpcom/build/nsXPComInit.cpp index 12e46d4..ebc3ff7 100644 --- a/xpcom/build/nsXPComInit.cpp +++ b/xpcom/build/nsXPComInit.cpp @@ -478,7 +478,7 @@ void UseUSEnglishLocalePrefChangedCallback(const char* /* pref */, void* /* clos // Read the pref to see if we will use US English locale. bool useUSEnglishLocale = mozilla::Preferences::GetBool(USE_US_ENGLISH_LOCALE_PREF, false); // Set the application-wide C-locale. Needed for Date.toLocaleFormat(). - setlocale(LC_ALL, useUSEnglishLocale ? "en_US" : sSystemLocale); + setlocale(LC_ALL, useUSEnglishLocale ? "C" : sSystemLocale); // Now override the JavaScript Runtime Locale that is used by the Intl API // as well as Date.toLocaleString, Number.toLocaleString, and String.localeCompare. JS_SetDefaultLocale(rt, useUSEnglishLocale ? "en-US" : sJSLocale);

1 0

[tor-browser-bundle/maint-4.0] Update changelog and OpenSSL sha256 sum
by gk＠torproject.org 26 Mar '15

26 Mar '15

commit 85ff14d79d9ccc8ab35fad52f0dd10f03090449a Author: Georg Koppen <gk(a)torproject.org> Date: Thu Mar 26 07:07:50 2015 +0000 Update changelog and OpenSSL sha256 sum --- Bundle-Data/Docs/ChangeLog.txt | 1 + gitian/versions | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Bundle-Data/Docs/ChangeLog.txt b/Bundle-Data/Docs/ChangeLog.txt index fa4b45d..e7707cb 100644 --- a/Bundle-Data/Docs/ChangeLog.txt +++ b/Bundle-Data/Docs/ChangeLog.txt @@ -2,6 +2,7 @@ Tor Browser 4.0.6 -- Mar 31 2015 * All Platforms * Update Firefox to 31.6.0esr * Update OpenSSL to 1.0.1m + * Update meek to 0.16 Tor Browser 4.0.5 -- Mar 23 2015 * All Platforms diff --git a/gitian/versions b/gitian/versions index d27d77c..5d41491 100755 --- a/gitian/versions +++ b/gitian/versions @@ -76,7 +76,7 @@ PARSLEY_PACKAGE=Parsley-${PARSLEY_VER}.tar.gz GO_PACKAGE=go${GO_VER}.src.tar.gz # Hashes for packages with weak sigs or no sigs -OPENSSL_HASH=b2cf4d48fe5d49f240c61c9e624193a6f232b5ed0baf010681e725963c40d1d4 +OPENSSL_HASH=095f0b7b09116c0c5526422088058dc7e6e000aa14d22acca6a4e2babcdfef74 GMP_HASH=752079520b4690531171d0f4532e40f08600215feefede70b24fabdc6f1ab160 OSXSDK_HASH=6602d8d5ddb371fbc02e2a5967d9bd0cd7358d46f9417753c8234b923f2ea6fc TOOLCHAIN4_HASH=7b71bfe02820409b994c5c33a7eab81a81c72550f5da85ff7af70da3da244645

1 0

[tor-browser-bundle/maint-4.0] TBB 4.0.6: Update changelog, versions, and update manifest.
by mikeperry＠torproject.org 26 Mar '15

26 Mar '15

commit a3798c52a08555e61782bc80d0e8935f4a8a7a0b Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Mar 25 21:48:24 2015 -0700 TBB 4.0.6: Update changelog, versions, and update manifest. Because 4.0.5 and 4.0.6 were so close together, let's make incrementals from both 4.0.4 and 4.0.5. --- Bundle-Data/Docs/ChangeLog.txt | 5 +++++ gitian/versions | 8 ++++---- tools/update-responses/config.yml | 9 +++++---- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/Bundle-Data/Docs/ChangeLog.txt b/Bundle-Data/Docs/ChangeLog.txt index c8a2b5a..fa4b45d 100644 --- a/Bundle-Data/Docs/ChangeLog.txt +++ b/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,8 @@ +Tor Browser 4.0.6 -- Mar 31 2015 + * All Platforms + * Update Firefox to 31.6.0esr + * Update OpenSSL to 1.0.1m + Tor Browser 4.0.5 -- Mar 23 2015 * All Platforms * Update Firefox to 31.5.3esr diff --git a/gitian/versions b/gitian/versions index 14354af..d27d77c 100755 --- a/gitian/versions +++ b/gitian/versions @@ -1,10 +1,10 @@ -TORBROWSER_VERSION=4.0.5 +TORBROWSER_VERSION=4.0.6 BUNDLE_LOCALES="ar de es-ES fa fr it ko nl pl pt-PT ru tr vi zh-CN" BUILD_PT_BUNDLES=1 VERIFY_TAGS=1 -FIREFOX_VERSION=31.5.3esr +FIREFOX_VERSION=31.6.0esr TORBROWSER_UPDATE_CHANNEL=release @@ -30,10 +30,10 @@ FAKETIME_TAG=70aa6b394d9341522dffe8a5a5cf5929e82cc6b9 # unsigned v0.9.6 GITIAN_TAG=tor-browser-builder-3.x-7 -OPENSSL_VER=1.0.1l +OPENSSL_VER=1.0.1m GMP_VER=5.1.3 FIREFOX_LANG_VER=$FIREFOX_VERSION -FIREFOX_LANG_BUILD=build1 +FIREFOX_LANG_BUILD=build2 BINUTILS_VER=2.24 GCC_VER=4.9.1 PYTHON_VER=2.7.5 diff --git a/tools/update-responses/config.yml b/tools/update-responses/config.yml index 93a372f..682f5cc 100644 --- a/tools/update-responses/config.yml +++ b/tools/update-responses/config.yml @@ -6,15 +6,16 @@ build_targets: osx32: Darwin_x86-gcc3 osx64: Darwin_x86_64-gcc3 channels: - release: 4.0.5 + release: 4.0.6 alpha: 4.5-alpha-2 versions: - 4.0.5: - platformVersion: 31.5.3 + 4.0.6: + platformVersion: 31.6.0 detailsURL: https://www.torproject.org/projects/torbrowser.html.en - download_url: https://www.torproject.org/dist/torbrowser/4.0.5 + download_url: https://www.torproject.org/dist/torbrowser/4.0.6 incremental_from: - 4.0.4 + - 4.0.5 4.5-alpha-2: platformVersion: 31.3.0 detailsURL: https://www.torproject.org/projects/torbrowser.html.en

1 0

[torbutton/master] Bug 7255: Address Pearl Crescent's review comments
by gk＠torproject.org 25 Mar '15

25 Mar '15

commit d2c3f9e7dae61b5f18b83398d234ab75186a3e99 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Mar 25 20:14:37 2015 +0000 Bug 7255: Address Pearl Crescent's review comments --- src/chrome/content/torbutton.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index 3158c04..83ea395 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -22,6 +22,9 @@ const k_tb_last_browser_version_pref = "extensions.torbutton.lastBrowserVersion" const k_tb_browser_update_needed_pref = "extensions.torbutton.updateNeeded"; const k_tb_last_update_check_pref = "extensions.torbutton.lastUpdateCheck"; const k_tb_tor_check_failed_topic = "Torbutton:TorCheckFailed"; +const k_tb_tor_resize_warn_pref = + "extensions.torbutton.startup_resize_period" + // status var m_tb_wasinited = false; var m_tb_prefs = false; @@ -1074,7 +1077,7 @@ function torbutton_on_abouttor_load(aDoc) { // OS-specific window maximization on start-up should be done by now. Disable // the respective preference to make sure the user is seeing our notification. - m_tb_prefs.setBoolPref("extensions.torbutton.startup_resize_period", false); + m_tb_prefs.setBoolPref(k_tb_tor_resize_warn_pref, false); } function torbutton_is_abouttor_doc(aDoc) { @@ -3427,9 +3430,9 @@ var torbutton_resizelistener = if (m_tb_resize_date === null) { m_tb_resize_date = Date.now(); } else { - // We at least another second before we show a new notification. - // Should be enough to rule out OSes that call our handler rapidly - // due to internal workings. + // We wait at least another second before we show a new + // notification. Should be enough to rule out OSes that call our + // handler rapidly due to internal workings. if (Date.now() - m_tb_resize_date < 1000) { return; } @@ -3471,7 +3474,7 @@ var torbutton_resizelistener = // maximize the window. We don't want to do that AND don't want to // show the user our notification in this case. if (m_tb_prefs. - getBoolPref("extensions.torbutton.startup_resize_period")) { + getBoolPref(k_tb_tor_resize_warn_pref)) { window.addEventListener("resize", function() { win.resizeBy(width - win.innerWidth, height - win.innerHeight); @@ -3506,8 +3509,7 @@ var torbutton_resizelistener = // the window triggers more than one resize event the first being not the // one we need. Thus we can't remove the listener after the first resize // event got fired. Thus, we have the rather klunky setTimeout() call. - m_tb_prefs.setBoolPref("extensions.torbutton.startup_resize_period", - true); + m_tb_prefs.setBoolPref(k_tb_tor_resize_warn_pref, true); window.addEventListener("sizemodechange", m_tb_resize_handler, false); // This is fun. any attempt to directly set the inner window actually

1 0

[torbutton/master] Bug 7255: Make maximize counter count down to 0.
by mikeperry＠torproject.org 25 Mar '15

25 Mar '15

commit 7d130aafe1f7c25e737173282b57511b8e8eba08 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Mar 25 10:52:24 2015 -0700 Bug 7255: Make maximize counter count down to 0. --- src/chrome/content/torbutton.js | 6 +++--- src/defaults/preferences/preferences.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index 77a388e..3158c04 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -3421,7 +3421,7 @@ var torbutton_resizelistener = m_tb_resize_handler = function() { if (window.windowState === 1) { if (m_tb_prefs. - getIntPref("extensions.torbutton.maximize_warning_counter") < 3) { + getIntPref("extensions.torbutton.maximize_warnings_remaining") > 0) { // Rate-limit showing our notification if needed. if (m_tb_resize_date === null) { @@ -3452,8 +3452,8 @@ var torbutton_resizelistener = popup: null, callback: function() { - m_tb_prefs.setIntPref("extensions.torbutton.maximize_warning_counter", - m_tb_prefs.getIntPref("extensions.torbutton.maximize_warning_counter") + 1); + m_tb_prefs.setIntPref("extensions.torbutton.maximize_warnings_remaining", + m_tb_prefs.getIntPref("extensions.torbutton.maximize_warnings_remaining") - 1); } }]; diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js index c85c7f4..2c109ee 100644 --- a/src/defaults/preferences/preferences.js +++ b/src/defaults/preferences/preferences.js @@ -118,7 +118,7 @@ pref("extensions.torbutton.prompted_language",false); // TODO: This is just part of a stopgap until #14429 gets properly implemented. // See #7255 for details. We display the warning three times to make sure the // user did not click on it by accident. -pref("extensions.torbutton.maximize_warning_counter", 0); +pref("extensions.torbutton.maximize_warnings_remaining", 3); pref("extensions.torbutton.startup_resize_period", true); // Security prefs:

1 0

[torbutton/master] Bug 7255: Shorten and improve grammar of maximize message.
by mikeperry＠torproject.org 25 Mar '15

25 Mar '15

commit aa74b99ee309108cbc82e53ff4ec5004cde91a9b Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Mar 25 10:51:45 2015 -0700 Bug 7255: Shorten and improve grammar of maximize message. --- src/chrome/locale/en/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chrome/locale/en/torbutton.properties b/src/chrome/locale/en/torbutton.properties index a3be7e0..ef1723e 100644 --- a/src/chrome/locale/en/torbutton.properties +++ b/src/chrome/locale/en/torbutton.properties @@ -58,7 +58,7 @@ torbutton.popup.confirm_newnym = Tor Browser will close all windows and tabs. Al torbutton.slider_notification = The green onion menu has now a security slider which lets you adjust your security level. Check it out! torbutton.slider_notification_button = Open security settings -torbutton.maximize_warning = Maximizing Tor Browser can allow websites to determine information about your monitor size, which can be used to track you. We recommend you leave Tor Browser windows in their original default size. +torbutton.maximize_warning = Maximizing Tor Browser can allow websites to determine your monitor size, which can be used to track you. We recommend that you leave Tor Browser windows in their original default size. # Canvas permission prompt. Strings are kept here for ease of translation. canvas.siteprompt=This website (%S) attempted to extract HTML5 canvas image data, which may be used to uniquely identify your computer.\n\nShould Tor Browser allow this website to extract HTML5 canvas image data?

1 0

[torbutton/master] Merge remote-tracking branch 'gk/bug_7255_v2' into 1.9-next
by mikeperry＠torproject.org 25 Mar '15

25 Mar '15

commit 9a1a82e2ee6f7536bbc8fe91333e52157f61d219 Merge: ab5010d 52ab447 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Mar 25 10:24:50 2015 -0700 Merge remote-tracking branch 'gk/bug_7255_v2' into 1.9-next src/chrome/content/torbutton.js | 109 ++++++++++++++++++++++------- src/chrome/locale/en/torbutton.properties | 2 + src/defaults/preferences/preferences.js | 6 ++ 3 files changed, 93 insertions(+), 24 deletions(-)

1 0