- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
by richard (＠richard) 07 Sep '23

07 Sep '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 9b73a337 by Pier Angelo Vendrame at 2023-09-06T22:20:01+00:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Allow customizing the updater URL with config options. With this, we will not need sed hacks on tor-browser-build anymore. - - - - - 3 changed files: - build/application.ini.in - build/moz.build - build/moz.configure/update-programs.configure Changes: ===================================== build/application.ini.in ===================================== @@ -52,5 +52,5 @@ ServerURL=@MOZ_CRASHREPORTER_URL@/submit?id=@MOZ_APP_ID@&version=@MOZ_APP_VERSIO #if MOZ_UPDATER [AppUpdate] -URL=https://aus1.torproject.org/torbrowser/update_3/%CHANNEL%/%BUILD_TARGET%/%VERSION%/ALL +URL=@BB_UPDATER_URL@/%CHANNEL%/%BUILD_TARGET%/%VERSION%/ALL #endif ===================================== build/moz.build ===================================== @@ -75,6 +75,7 @@ if CONFIG["MOZ_APP_BASENAME"]: "MAR_CHANNEL_ID", "MOZ_APP_REMOTINGNAME", "MOZ_CRASHREPORTER_URL", + "BB_UPDATER_URL", ): appini_defines[var] = CONFIG[var] ===================================== build/moz.configure/update-programs.configure ===================================== @@ -204,3 +204,19 @@ option( set_config("BASE_BROWSER_UPDATE", True, when="--enable-base-browser-update") set_define("BASE_BROWSER_UPDATE", True, when="--enable-base-browser-update") + + +# Updater URL +# ============================================================== + +option( + "--with-updater-url", + default="https://aus1.torproject.org/torbrowser/update_3/", + nargs=1, + help="Set the updater URL", +) + +set_config( + "BB_UPDATER_URL", + depends("--with-updater-url")(lambda x: x[0].rstrip("/")), +) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9b73a33… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9b73a33… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 06 Sep '23

06 Sep '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: bb9daa6d by Richard Pospesel at 2023-09-06T20:50:30+00:00 fixup! Firefox preference overrides. Bug 42057: Disable GetIsTextRecognitionSupported by default - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -539,6 +539,9 @@ pref("privacy.query_stripping.enabled", true); pref("privacy.query_stripping.enabled.pbmode", true); pref("privacy.query_stripping.strip_on_share.enabled", true); +// Disable platform text recogniition functionality (tor-browser#42057) +pref("dom.text-recognition.enabled", false); + #ifdef XP_WIN // prefs to disable jump-list entries in the taskbar on Windows (see bug #12885) // this pref changes the app's set AUMID to be dependent on the profile path, rather than View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bb9daa6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bb9daa6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 06 Sep '23

06 Sep '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f60ab8ba by Richard Pospesel at 2023-09-05T21:04:40+00:00 fixup! Firefox preference overrides. Bug 42057: Disable GetIsTextRecognitionSupported by default - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -539,6 +539,9 @@ pref("privacy.query_stripping.enabled", true); pref("privacy.query_stripping.enabled.pbmode", true); pref("privacy.query_stripping.strip_on_share.enabled", true); +// Disable platform text recogniition functionality (tor-browser#42057) +pref("dom.text-recognition.enabled", false); + #ifdef XP_WIN // prefs to disable jump-list entries in the taskbar on Windows (see bug #12885) // this pref changes the app's set AUMID to be dependent on the profile path, rather than View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f60ab8b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f60ab8b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Add Tor integration and UI
by Dan Ballard (＠dan) 06 Sep '23

06 Sep '23

Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: cd1efeff by Dan Ballard at 2023-08-29T11:46:45-07:00 fixup! Add Tor integration and UI Bug 42038: Remove firefox branding overlap on homescreen - - - - - 2 changed files: - fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt - fenix/app/src/main/res/layout/fragment_home.xml Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -1100,7 +1100,7 @@ class HomeFragment : Fragment() { else -> ColorStateList.valueOf(color) } - binding.wordmarkText.imageTintList = tintColor + //binding.wordmarkText.imageTintList = tintColor binding.privateBrowsingButton.imageTintList = tintColor } ===================================== fenix/app/src/main/res/layout/fragment_home.xml ===================================== @@ -70,9 +70,10 @@ android:layout_marginEnd="10.dp" android:adjustViewBounds="true" android:contentDescription="@null" - app:srcCompat="?fenixWordmarkLogo" + app:srcCompat="@mipmap/ic_launcher" tools:ignore="ImageContrastCheck" /> +  + + <TextView + android:id="@+id/app_name" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="9dp" + android:width="130dp" + android:height="60dp" + android:clickable="false" + android:focusable="false" + android:importantForAccessibility="no" + android:lines="2" + android:text="@string/app_name" + android:fontFamily="Roboto-Medium" + android:textColor="#DEFFFFFF" + android:textSize="20sp" + android:lineSpacingMultiplier="1.2" /> + </LinearLayout> - <TextView - android:id="@+id/app_name" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginStart="80dp" - android:layout_marginTop="9dp" - android:gravity="center_vertical" - android:width="130dp" - android:height="60dp" - android:clickable="false" - android:focusable="false" - android:importantForAccessibility="no" - android:lines="2" - android:text="@string/app_name" - android:fontFamily="Roboto-Medium" - android:textColor="#DEFFFFFF" - android:textSize="20sp" - android:lineSpacingMultiplier="1.2" /> + </com.google.android.material.appbar.CollapsingToolbarLayout> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/cd1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/cd1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 3 commits: Bug 40944: Avoid parsing .incremental.mar files as non-incremental mars
by richard (＠richard) 06 Sep '23

06 Sep '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 486e1ea1 by Nicolas Vigier at 2023-09-06T18:38:34+00:00 Bug 40944: Avoid parsing .incremental.mar files as non-incremental mars - - - - - 20b24282 by Nicolas Vigier at 2023-09-06T18:38:34+00:00 Bug 40944: In update_responses, make an error if we see an unkwown OS If a mar file is found with an OS name that doesn't have a corresponding `build_targets` entry in the config, the OS name was being used as build target to generate the `.htaccess` file. This is not supposed to happen, except when something is wrong, so instead we should make an error in that case. - - - - - f6da50f9 by Nicolas Vigier at 2023-09-06T18:38:34+00:00 Bug 40947: Remove migrate_langs from tools/signing/nightly/update-responses-base-config.yml - - - - - 2 changed files: - tools/signing/nightly/update-responses-base-config.yml - tools/update-responses/update_responses Changes: ===================================== tools/signing/nightly/update-responses-base-config.yml ===================================== @@ -18,8 +18,6 @@ versions: nightly_version: platformVersion: 115.1.0 detailsURL: http://umj4zbqdfcyevlkgqgpq6foxk3z75zzxsbgt5jqmfxofrbrjh3crbnad.onion/ - migrate_langs: - pt-PT: pt-BR macos: minSupportedOSVersion: 16.0.0 windows-i686: ===================================== tools/update-responses/update_responses ===================================== @@ -50,7 +50,7 @@ sub get_tmpdir { } sub build_targets_by_os { - return ($_[0]) unless $config->{build_targets}{$_[0]}; + exit_error "Unknown build target for OS $_[0]" unless $config->{build_targets}{$_[0]}; my $r = $config->{build_targets}{$_[0]}; return ref $r eq 'ARRAY' ? @$r : ($r); } @@ -98,7 +98,8 @@ sub get_version_files { opendir(my $d, $vdir) or exit_error "Error opening directory $vdir"; foreach my $file (readdir $d) { next unless -f "$vdir/$file"; - if ($file =~ m/^$appname-(.+)-${version}_(.+)\.mar$/) { + if ($file !~ m/incremental\.mar$/ && + $file =~ m/^$appname-(.+)-${version}_(.+)\.mar$/) { my ($os, $lang) = ($1, $2); $files->{$os}{$lang}{complete} = { type => 'complete', View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40948: Don't check lyrebird-vendor sha256sum in nightly
by richard (＠richard) 06 Sep '23

06 Sep '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 639e1671 by Nicolas Vigier at 2023-09-06T18:30:37+00:00 Bug 40948: Don't check lyrebird-vendor sha256sum in nightly Also update rbm for rbm#40059. - - - - - 2 changed files: - projects/lyrebird/config - rbm Changes: ===================================== projects/lyrebird/config ===================================== @@ -17,7 +17,7 @@ targets: version: '[% c("abbrev") %]' tag_gpg_id: 0 var: - go_vendor_sha256sum: 028c4536c10266331d680c0618b859d8f4ea8d630cd8588f13cfcc5b2d4272a1 + go_vendor_sha256sum: '' steps: build: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit 6a20418284d94edad88986eaa4f01fc4e4476854 +Subproject commit c4c1716dcbffa58c102daa8a5f3e188acdaf823a View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40059: Make it possible to have empty sha256sum value to disable sha256sum check
by richard (＠richard) 06 Sep '23

06 Sep '23

richard pushed to branch main at The Tor Project / Applications / RBM Commits: c4c1716d by Nicolas Vigier at 2023-09-06T15:30:45+02:00 Bug 40059: Make it possible to have empty sha256sum value to disable sha256sum check - - - - - 2 changed files: - doc/rbm_input_files.asc - lib/RBM.pm Changes: ===================================== doc/rbm_input_files.asc ===================================== @@ -113,6 +113,7 @@ refresh_input:: sha256sum:: The sha256 checksum of the file. The build will fail with an error if the file does not match the expected sha256 checksum. + If the value is empty, the checksum is not checked. file_gpg_id:: If this option is set to 1, the file is checked for a gpg ===================================== lib/RBM.pm ===================================== @@ -782,14 +782,17 @@ sub input_file_need_dl { return undef if $action eq 'getfpaths'; if ($fname && ($input_file->{sha256sum} || $input_file->{norec}{sha256sum}) + && $t->('sha256sum') && $t->('sha256sum') ne sha256file($fname)) { sha256file($fname, { remove_cache => 1 }); $fname = undef; } if ($action eq 'input_files_id') { return undef if $input_file->{input_file_id}; - return undef if $input_file->{sha256sum}; - return undef if $input_file->{norec}{sha256sum}; + if ( ($input_file->{sha256sum} || $input_file->{norec}{sha256sum}) + && $t->('sha256sum') ) { + return undef; + } return undef if $input_file->{exec}; return undef if $fname; return 1 if $input_file->{URL}; @@ -814,7 +817,8 @@ sub input_file_id { my ($input_file, $t, $fname, $filename) = @_; return $t->('input_file_id') if $input_file->{input_file_id}; return $input_file->{project} . ':' . $filename if $input_file->{project}; - if ($input_file->{sha256sum} || $input_file->{norec}{sha256sum}) { + if ( ($input_file->{sha256sum} || $input_file->{norec}{sha256sum}) + && $t->('sha256sum') ) { return $filename . ':' . $t->('sha256sum'); } my $opts = { norec => { output_dir => '/out', getting_id => 1, }}; View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/c4c1716dcbffa58… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/c4c1716dcbffa58… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Updated Lyrebird dependencies hash.
by Pier Angelo Vendrame (＠pierov) 06 Sep '23

06 Sep '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 1215282c by Pier Angelo Vendrame at 2023-09-06T16:09:37+00:00 Updated Lyrebird dependencies hash. utls has been updated to v1.5.3 and crypto to v0.13.0. - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -17,7 +17,7 @@ targets: version: '[% c("abbrev") %]' tag_gpg_id: 0 var: - go_vendor_sha256sum: 8e9a5fd52f5a3a2b2b891389a224fcfc83b6c081658161bf40882b23fb58834c + go_vendor_sha256sum: 028c4536c10266331d680c0618b859d8f4ea8d630cd8588f13cfcc5b2d4272a1 steps: build: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40943: Update libdmg-hfs to drop our patch
by Pier Angelo Vendrame (＠pierov) 06 Sep '23

06 Sep '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 2941c888 by Pier Angelo Vendrame at 2023-09-05T16:56:42+02:00 Bug 40943: Update libdmg-hfs to drop our patch We have uplifted one of our libdmg-hfs patches, so we can update our git_hash to the upstream commit that includes it. Also, deleted the OpenSSL 1.0.2 project in favor of a patch to optionally completely disable OpenSSL, since we do not need the functionalities it provides. - - - - - 7 changed files: - projects/libdmg-hfsplus/build - projects/libdmg-hfsplus/config - − projects/libdmg-hfsplus/libdmg.patch - + projects/libdmg-hfsplus/no-openssl.diff - − projects/openssl-1.0.2/build - − projects/openssl-1.0.2/config - tools/signing/gatekeeper-bundling.sh Changes: ===================================== projects/libdmg-hfsplus/build ===================================== @@ -4,15 +4,14 @@ distdir=/var/tmp/dist/[% project %] mkdir -p /var/tmp/dist tar -C /var/tmp/dist -xf [% c('input_files_by_name/cmake') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/ninja') %] -[% IF c("container/global_disable") -%] - tar -C /var/tmp/dist -xf [% c('input_files_by_name/openssl-1.0.2') %] -[% END -%] export PATH="/var/tmp/dist/ninja:/var/tmp/dist/cmake/bin:$PATH" mkdir /var/tmp/build tar -C /var/tmp/build -xf [% project %]-[% c('version') %].tar.[% c('compress_tar') %] cd /var/tmp/build/[% project %]-[% c('version') %] -patch -p1 < "$rootdir/libdmg.patch" +[% IF c("container/global_disable") -%] + patch -p1 < "$rootdir/no-openssl.diff" +[% END -%] cmake . -GNinja -DCMAKE_BUILD_TYPE=Release [% c("var/cmake_opts") %] ninja -j[% c("num_procs") %] -v ===================================== projects/libdmg-hfsplus/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://github.com/mozilla/libdmg-hfsplus -git_hash: 2ee327795680101d36f9700bd0fb618362237718 +git_hash: 2cb30de5b277bf2bc1fc129899bb9382bb56ccca filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -13,16 +13,12 @@ var: targets: no_containers: var: - cmake_opts: | - -DOPENSSL_USE_STATIC_LIBS=1 \ - -DOPENSSL_ROOT_DIR=/var/tmp/dist/openssl + cmake_opts: '-DUSE_OPENSSL=OFF' input_files: - project: container-image - name: cmake project: cmake - name: ninja project: ninja - - filename: libdmg.patch - - name: openssl-1.0.2 - project: openssl-1.0.2 + - filename: no-openssl.diff enable: '[% c("container/global_disable") %]' ===================================== projects/libdmg-hfsplus/libdmg.patch deleted ===================================== @@ -1,39 +0,0 @@ -From d1a5eca891f32103ccda80ee75e158dfc7ece70d Mon Sep 17 00:00:00 2001 -From: Mike Perry <mikeperry-git(a)torproject.org> -Date: Thu, 6 Mar 2014 19:47:05 -0800 -Subject: [PATCH] Memset a UDIF header to ensure archive reproducibility. - -Some of the struct padding and fields contained unitialized memory, which -caused two successive invocations to produce archives that differed in some -bytes. ---- - dmg/dmglib.c | 6 ++++-- - 1 file changed, 4 insertions(+), 2 deletions(-) - -diff --git a/dmg/dmglib.c b/dmg/dmglib.c -index f481b1f..b74e50b 100644 ---- a/dmg/dmglib.c -+++ b/dmg/dmglib.c -@@ -108,7 +108,8 @@ int buildDmg(AbstractFile* abstractIn, AbstractFile* abstractOut) { - ChecksumToken dataForkToken; - - UDIFResourceFile koly; -- -+ memset(&koly, 0, sizeof(koly)); -+ - off_t plistOffset; - uint32_t plistSize; - uint32_t dataForkChecksum; -@@ -284,7 +285,8 @@ int convertToDMG(AbstractFile* abstractIn, AbstractFile* abstractOut) { - uint64_t numSectors; - - UDIFResourceFile koly; -- -+ memset(&koly, 0, sizeof(koly)); -+ - char partitionName[512]; - - off_t fileLength; --- -1.8.1.2 - ===================================== projects/libdmg-hfsplus/no-openssl.diff ===================================== @@ -0,0 +1,34 @@ +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 79d4302..b54e81d 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 2.6) + + project (libdmg-hfsplus) + ++option(USE_OPENSSL "Enable or disable OpenSSL (1.0.x is currently required)" ON) ++ + # We want win32 executables to build staticly by default, since it's more difficult to keep the shared libraries straight on Windows + IF(WIN32) + SET(BUILD_STATIC ON CACHE BOOL "Force compilation with static libraries") +diff --git a/dmg/CMakeLists.txt b/dmg/CMakeLists.txt +index 36f6bb6..ffdac77 100644 +--- a/dmg/CMakeLists.txt ++++ b/dmg/CMakeLists.txt +@@ -18,14 +18,14 @@ link_directories(${PROJECT_BINARY_DIR}/common ${PROJECT_BINARY_DIR}/hfs) + + add_library(dmg adc.c checksum.c dmgfile.c dmglib.c filevault.c io.c partition.c resources.c udif.c ../includes/dmg/adc.h ../includes/dmg/dmg.h ../includes/dmg/dmgfile.h ../includes/dmg/dmglib.h ../includes/dmg/filevault.h) + +-IF(OPENSSL_FOUND) ++IF(OPENSSL_FOUND AND USE_OPENSSL) + add_definitions(-DHAVE_CRYPT) + include_directories(${OPENSSL_INCLUDE_DIR}) + target_link_libraries(dmg ${OPENSSL_CRYPTO_LIBRARY} $<$<BOOL:${OPENSSL_USE_STATIC_LIBS}>:${CMAKE_DL_LIBS}>) + IF(WIN32) + TARGET_LINK_LIBRARIES(dmg gdi32) + ENDIF(WIN32) +-ENDIF(OPENSSL_FOUND) ++ENDIF(OPENSSL_FOUND AND USE_OPENSSL) + + target_link_libraries(dmg common hfs z bz2) + ===================================== projects/openssl-1.0.2/build deleted ===================================== @@ -1,15 +0,0 @@ -#!/bin/bash -[% c("var/set_default_env") -%] -distdir=/var/tmp/dist/openssl -mkdir -p /var/tmp/build -tar -C /var/tmp/build -xf openssl-[% c('version') %].tar.[% c('compress_tar') %] -cd /var/tmp/build/openssl-[% c('version') %] -export SOURCE_DATE_EPOCH='[% c("timestamp") %]' -./Configure --prefix="$distdir" -shared enable-ec_nistp_64_gcc_128 linux-x86_64 -make -j[% c("num_procs") %] -make -j[% c("num_procs") %] install -cd /var/tmp/dist -[% c('tar', { - tar_src => [ 'openssl' ], - tar_args => '-caf ' _ dest_dir _ '/' _ c('filename'), - }) %] ===================================== projects/openssl-1.0.2/config deleted ===================================== @@ -1,11 +0,0 @@ -# vim: filetype=yaml sw=2 -# -# We need openssl-1.0.2 for building libdmg-hfsplus: -# https://github.com/planetbeing/libdmg-hfsplus/issues/14 -# -version: 1.0.2u -filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' - -input_files: - - URL: 'https://www.openssl.org/source/openssl-[% c("version") %].tar.gz' - sha256sum: ecd0c6ffb493dd06707d38b14bb4d8c2288bb7033735606569d8f90f89669d16 ===================================== tools/signing/gatekeeper-bundling.sh ===================================== @@ -39,7 +39,7 @@ test -f $faketime_path || \ exit_error "$faketime_path is missing" test -d $macos_stapled_dir || \ exit_error "The stapled macos zip files should be placed in directory $macos_stapled_dir" -libdmg_file="$script_dir/../../out/libdmg-hfsplus/libdmg-hfsplus-2ee327795680-555a7e.tar.gz" +libdmg_file="$script_dir/../../out/libdmg-hfsplus/libdmg-hfsplus-2cb30de5b277-68b0fc.tar.zst" test -f "$libdmg_file" || \ exit_error "$libdmg_file is missing." \ "You can build it with:" \ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 05 Sep '23

05 Sep '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 7263a6fd by Richard Pospesel at 2023-09-05T20:56:49+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41974: De-emphasized text in custom components is no longer gray in 13.0 alpha - - - - - 182afa03 by Richard Pospesel at 2023-09-05T20:56:49+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 41974: De-emphasized text in custom components is no longer gray in 13.0 alpha - - - - - 2 changed files: - browser/components/rulesets/content/aboutRulesets.css - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/rulesets/content/aboutRulesets.css ===================================== @@ -43,7 +43,7 @@ select, option { dt { margin: var(--ruleset-vmargin) 0 0 0; padding: 0; - color: var(--in-content-deemphasized-text); + color: var(--text-color-deemphasized); font-size: 85%; } @@ -220,7 +220,7 @@ aside { #ruleset-list .description { font-size: 85%; - color: var(--in-content-deemphasized-text); + color: var(--text-color-deemphasized); } #ruleset-list .selected { @@ -280,7 +280,7 @@ aside { #ruleset-updated { margin-top: 24px; - color: var(--in-content-deemphasized-text); + color: var(--text-color-deemphasized); font-size: 85%; } @@ -291,7 +291,7 @@ aside { } #edit-ruleset label { - color: var(--in-content-deemphasized-text); + color: var(--text-color-deemphasized); display: block; } ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -164,7 +164,7 @@ flex: 1; margin: 0 8px; overflow: hidden; - color: var(--in-content-deemphasized-text); + color: var(--text-color-deemphasized); white-space: nowrap; text-overflow: ellipsis; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fc3260… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fc3260… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 05 Sep '23

05 Sep '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 9491fec6 by Pier Angelo Vendrame at 2023-09-05T18:51:58+00:00 fixup! Firefox preference overrides. Bug 41675: Remove javascript.options.large_arraybuffers. It has been removed with MozBug 1703508 in Firefox 110. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -330,7 +330,6 @@ pref("dom.textMetrics.emHeight.enabled", false); pref("dom.textMetrics.fontBoundingBox.enabled", false); // tor-browser#40424 pref("pdfjs.enableScripting", false); -pref("javascript.options.large_arraybuffers", false); // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9491fec… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9491fec… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 05 Sep '23

05 Sep '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: fc3260a1 by Pier Angelo Vendrame at 2023-09-05T18:50:43+00:00 fixup! Firefox preference overrides. Bug 41675: Remove javascript.options.large_arraybuffers. It has been removed with MozBug 1703508 in Firefox 110. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -330,7 +330,6 @@ pref("dom.textMetrics.emHeight.enabled", false); pref("dom.textMetrics.fontBoundingBox.enabled", false); // tor-browser#40424 pref("pdfjs.enableScripting", false); -pref("javascript.options.large_arraybuffers", false); // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fc3260a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fc3260a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 3 commits: fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
by Pier Angelo Vendrame (＠pierov) 05 Sep '23

05 Sep '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 3fe30891 by clairehurst at 2023-08-31T03:24:27+00:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Bug 42035: Update tools/torbrowser/ scripts to support macOS dev environment - - - - - a3e812a8 by clairehurst at 2023-08-31T03:24:27+00:00 fixup! Base Browser's .mozconfigs. Bug 42035: Update mozconfig for macos development - - - - - ee028c84 by clairehurst at 2023-08-31T03:24:27+00:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 42035: update mozconfig for macos development - - - - - 5 changed files: - + mozconfig-macos-dev - tools/torbrowser/Makefile - + tools/torbrowser/browser-self-sign-macos.sh - tools/torbrowser/deploy.sh - tools/torbrowser/fetch.sh Changes: ===================================== mozconfig-macos-dev ===================================== @@ -0,0 +1,24 @@ +. $topsrcdir/browser/config/mozconfigs/tor-browser + +# This mozconfig file is not used in official builds. +# It is only intended to be used when doing incremental macOS builds +# during development. + +ac_add_options --disable-strip +ac_add_options --disable-install-strip + +# See bug #13379 +ac_add_options --enable-nss-mar + +# See bug #41131 +ac_add_options --disable-update-agent + +ac_add_options --with-relative-data-dir=../TorBrowser-Data/Browser + +#copied from the diff between mozconfig-linux-x86_64 and mozconfig-linux-x86_64-dev +export MOZILLA_OFFICIAL= +export MOZ_APP_REMOTINGNAME="Tor Browser Dev" + +ac_add_options --with-branding=browser/branding/tb-nightly +ac_add_options --with-base-browser-version=dev-build +ac_add_options --disable-base-browser-update ===================================== tools/torbrowser/Makefile ===================================== @@ -1,11 +1,30 @@ .DEFAULT_GOAL := all # https://stackoverflow.com/questions/18136918/how-to-get-current-relative-di… -mkfile_path := $(shell dirname $(realpath $(firstword $(MAKEFILE_LIST)))) - -DEV_ROOT = $(mkfile_path)/../.. -BINARIES = $(DEV_ROOT)/.binaries -BUILD_OUTPUT = $(DEV_ROOT)/obj-x86_64-pc-linux-gnu +mkfile_path := "$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))" + +DEV_ROOT = "$(mkfile_path)/../.." +BINARIES = "$(DEV_ROOT)/.binaries" +ARCHITECTURE = "$(shell uname -m)" + +# Correct the architecture naming for ARM to match what mozilla has +ifeq ($(ARCHITECTURE), "arm64") + ARCHITECTURE = "aarch64" +endif + +# Define build output path based on the platform. +ifeq ("$(shell uname)", "Darwin") + BUILD_OUTPUT = "$(DEV_ROOT)/obj-$(ARCHITECTURE)-apple-darwin$(shell uname -r)" +else + BUILD_OUTPUT = "$(DEV_ROOT)/obj-$(ARCHITECTURE)-pc-linux-gnu" +endif + +# Define the run command based on the platform. +ifeq ("$(shell uname)", "Darwin") + RUN_CMD := cd "$(BINARIES)/Tor Browser.app/Contents/MacOS/" && ./firefox +else + RUN_CMD := "$(BINARIES)/dev/Browser/start-tor-browser" -v $(ARGS) +endif config: ./config.sh $(DEV_ROOT) @@ -34,7 +53,7 @@ fat-aar: all: build deploy run: - $(BINARIES)/dev/Browser/start-tor-browser -v $(ARGS) + $(RUN_CMD) jslint: ./jslint.sh $(DEV_ROOT) $(JS) ===================================== tools/torbrowser/browser-self-sign-macos.sh ===================================== @@ -0,0 +1,110 @@ +#!/bin/bash + +CERTNAME=my-codesign-cert-tor +BROWSERPATH=. + +if [ $# -ge 1 ] +then + BROWSERPATH=$1 +fi + + +security find-certificate -c $CERTNAME > /dev/null + +if [ $? -ne 0 ] +then + echo "" + echo "ERROR: Self Signing Certificate not found, please create:" + echo " 1. In the Keychain Access app on your Mac, choose Keychain Access > Certificate Assistant > Create a Certificate." + echo " 2. Enter the name '$CERTNAME' for the certificate" + echo " 3. Choose an identity type: Self Signed Root" + echo " 4. Certificate Type > Code Signing" + echo " 5. Check 'Let me override defaults' & click Continue." + echo " 6. Enter a unique Serial Number. (123 is fine)" + echo " 7. Enter a big Validity Period (days), like 3560 & click Continue." + echo " 8. Fill in your personal information & click Continue." + echo " 9. Accept defaults for the rest of the dialog boxes. (Continue several times)" + echo " 10. Certificate Created! Click Done." + echo "" + echo "For additional help see:" + echo " https://support.apple.com/en-ca/guide/keychain-access/kyca8916/mac" + echo " https://stackoverflow.com/questions/58356844/what-are-the-ways-or-technolog…" + + echo "" + read -n 1 -r -s -p $'Press enter to launch "Keychain Access"...\n' + open /System/Applications/Utilities/Keychain\ Access.app + + exit -1 +fi + +echo "Found $CERTNAME, looking for browser to sign..." + +if [ ! -f "$BROWSERPATH/XUL" ] +then + TESTPATH="$BROWSERPATH/Contents/MacOS" + if [ -f "$TESTPATH/XUL" ] + then + BROWSERPATH=$TESTPATH + else + echo "Error: browser files not detected in $BROWSERPATH!" + echo " This script needs to be run in the 'Contents/MacOS' directory of a SomeBrowser.app directory" + exit -1 + fi +fi + +echo "Mozilla based browser found, signing..." +echo ' Will be asked for password to certificate for all the things that need to be signed. Click "Always Allow" to automate' + +cd "$BROWSERPATH" + +codesign -s $CERTNAME *.dylib +codesign -s $CERTNAME plugin-container.app + +if [ -d Tor ] +then + codesign -s $CERTNAME Tor/PluggableTransports/* + codesign -s $CERTNAME Tor/libevent-2.1.7.dylib + if [ -f Tor/tor.real ] + then + codesign -s $CERTNAME Tor/tor.real + fi + if [ -f Tor/tor ] + then + codesign -s $CERTNAME Tor/tor + fi +fi + +codesign -s $CERTNAME XUL + +if [ -d updater.app ] +then + codesign -s $CERTNAME updater.app +fi + +# mullvadbrowser +if [ -f mullvadbrowser ] +then + codesign -s $CERTNAME mullvadbrowser +fi + +# BB or TB +if [ -f firefox ] +then + codesign -s $CERTNAME firefox +fi + +echo "" +echo "Browser signing step done!" +echo "" + +echo "App still needs one more override to be easily opened with double click in Finder" +echo "Alternatively you can right click it, select 'Open' and then select 'Open' from the override popup" +echo "Or to enable it to be double clicked to open perform the following" +echo "" +echo "Double click the app and select either 'Ok' or 'Cancel' from the warning popup depending on which you get (Do Not 'Move to Trash')" +echo 'Go to Preferences -> Security & Privacy and click on padlock to allow changes. ' +echo ' Then in "Allow appications downloaded from" select either:' +echo ' - App Store and identified developers' +echo ' - Anywhere' +echo ' Below that may be a notice about your specific app saying it was blocked because it was not from an identified developer. Click "Open Anyways" and "Open"' + ===================================== tools/torbrowser/deploy.sh ===================================== @@ -1,30 +1,50 @@ #!/bin/bash set -e -BINARIES=$1 -BUILD_OUTPUT=$2 -SCRIPT_DIR=$(realpath "$(dirname "$0")") +BINARIES="$1" +BUILD_OUTPUT="$2" +SCRIPT_DIR="$(realpath "$(dirname "$0")")" + +RESDIR="$BUILD_OUTPUT/dist/firefox" +if [ "$(uname)" = "Darwin" ]; then + RESDIR="$RESDIR/Tor Browser.app/Contents/Resources" +fi # Add built-in bridges -mkdir -p $BUILD_OUTPUT/_omni/defaults/preferences -cat $BUILD_OUTPUT/dist/bin/browser/defaults/preferences/000-tor-browser.js $SCRIPT_DIR/bridges.js >> $BUILD_OUTPUT/_omni/defaults/preferences/000-tor-browser.js -cd $BUILD_OUTPUT/_omni && zip -Xmr $BUILD_OUTPUT/dist/firefox/browser/omni.ja defaults/preferences/000-tor-browser.js -rm -rf $BUILD_OUTPUT/_omni +mkdir -p "$BUILD_OUTPUT/_omni/defaults/preferences" +cat "$BUILD_OUTPUT/dist/bin/browser/defaults/preferences/000-tor-browser.js" "$SCRIPT_DIR/bridges.js" >> "$BUILD_OUTPUT/_omni/defaults/preferences/000-tor-browser.js" +cd "$BUILD_OUTPUT/_omni" +zip -Xmr "$RESDIR/browser/omni.ja" "defaults/preferences/000-tor-browser.js" +rm -rf "$BUILD_OUTPUT/_omni" # Repackage the manual # rm -rf $BUILD_OUTPUT/_omni # mkdir $BUILD_OUTPUT/_omni # unzip $BINARIES/dev/Browser/browser/omni.ja -d $BUILD_OUTPUT/_omni -# cd $BUILD_OUTPUT/_omni && zip -Xmr $BUILD_OUTPUT/dist/firefox/browser/omni.ja chrome/browser/content/browser/manual +# cd $BUILD_OUTPUT/_omni && zip -Xmr $RESDIR/browser/omni.ja chrome/browser/content/browser/manual # rm -rf $BUILD_OUTPUT/_omni -# backup the startup script -mv $BINARIES/dev/Browser/firefox $BINARIES/dev/Browser/firefox.bak +if [ "$(uname)" = "Darwin" ]; then + + # copy binaries + cp -r "$BUILD_OUTPUT/dist/firefox/Tor Browser.app/Contents/"* "$BINARIES/Tor Browser.app/Contents/" + rm -rf "$BINARIES/TorBrowser-Data/Browser/Caches/*.default/startupCache" + + # Self sign the Binaries + cd "$BINARIES/Tor Browser.app/Contents/MacOS" + "$SCRIPT_DIR/browser-self-sign-macos.sh" + + else + + # backup the startup script + mv "$BINARIES/dev/Browser/firefox" "$BINARIES/dev/Browser/firefox.bak" + + # copy binaries + cp -r "$RESDIR/"* "$BINARIES/dev/Browser" + rm -rf "$BINARIES/dev/Browser/TorBrowser/Data/Browser/profile.default/startupCache" -# copy binaries -cp -r $BUILD_OUTPUT/dist/firefox/* $BINARIES/dev/Browser -rm -rf $BINARIES/dev/Browser/TorBrowser/Data/Browser/profile.default/startupCache + # shuffle firefox bin around and restore script to match a real deployment + mv "$BINARIES/dev/Browser/firefox" "$BINARIES/dev/Browser/firefox.real" + mv "$BINARIES/dev/Browser/firefox.bak" "$BINARIES/dev/Browser/firefox" -# shuffle firefox bin around and restore script to match a real deployment -mv $BINARIES/dev/Browser/firefox $BINARIES/dev/Browser/firefox.real -mv $BINARIES/dev/Browser/firefox.bak $BINARIES/dev/Browser/firefox +fi ===================================== tools/torbrowser/fetch.sh ===================================== @@ -1,30 +1,40 @@ #!/bin/sh set -e -BINARIES_DIR=$1 +BINARIES_DIR="$1" # download the current downloads.json wget https://aus1.torproject.org/torbrowser/update_3/alpha/downloads.json -# get url for latest alpha linux en_US package +# get url for latest alpha linux package TOR_BROWSER_VERSION=$(grep -Eo "\"version\":\"[0-9.a]+\"" downloads.json | grep -Eo "[0-9.a]+") -TOR_BROWSER_PACKAGE="tor-browser-linux64-${TOR_BROWSER_VERSION}_ALL.tar.xz" +if [ "$(uname)" = "Darwin" ]; then + TOR_BROWSER_PACKAGE="tor-browser-macos-${TOR_BROWSER_VERSION}.dmg" + else + TOR_BROWSER_PACKAGE="tor-browser-linux-x86_64-${TOR_BROWSER_VERSION}.tar.xz" +fi TOR_BROWSER_PACKAGE_URL="https://dist.torproject.org/torbrowser/${TOR_BROWSER_VERSION}/${TOR_BROWSER…" # remove download manifest rm downloads.json # clear out previous tor-browser and previous package -rm -rf "${BINARIES_DIR}/dev" +rm -rf "${BINARIES_DIR}" rm -f "${TOR_BROWSER_PACKAGE}" # download -rm -f "${TOR_BROWSER_PACKAGE}" wget "${TOR_BROWSER_PACKAGE_URL}" mkdir -p "${BINARIES_DIR}" # and extract -tar -xf ${TOR_BROWSER_PACKAGE} -C "${BINARIES_DIR}" -mv "${BINARIES_DIR}/tor-browser" "${BINARIES_DIR}/dev" +if [ "$(uname)" = "Darwin" ] + then + hdiutil attach "${TOR_BROWSER_PACKAGE}" + cp -R "/Volumes/Tor Browser/Tor Browser.app" "${BINARIES_DIR}" + hdiutil detach "/Volumes/Tor Browser" + else + tar -xf "${TOR_BROWSER_PACKAGE}" -C "${BINARIES_DIR}" + mv "${BINARIES_DIR}/tor-browser" "${BINARIES_DIR}/dev" +fi -# cleanup +# Final cleanup rm -f "${TOR_BROWSER_PACKAGE}" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7eaa9c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7eaa9c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40942: Do not customize git_hash for Base Browser
by Pier Angelo Vendrame (＠pierov) 05 Sep '23

05 Sep '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cb4f1150 by Pier Angelo Vendrame at 2023-09-05T08:57:10+02:00 Bug 40942: Do not customize git_hash for Base Browser - - - - - 1 changed file: - projects/firefox/config Changes: ===================================== projects/firefox/config ===================================== @@ -72,8 +72,6 @@ steps: targets: basebrowser: - # basebrowser tag always has a -build1 suffix - git_hash: '[% c("var/project-name") %]-[% c("var/firefox_version") %]-[% c("var/browser_branch") %]-build1' var: nightly_updates_publish_dir_prefix: basebrowser- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40938: Copy tor-browser.ftl to the right place.
by boklm (＠boklm) 31 Aug '23

31 Aug '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 642eefd4 by Pier Angelo Vendrame at 2023-08-30T12:48:55+02:00 Bug 40938: Copy tor-browser.ftl to the right place. We started migrating to Fluent. Therefore, we have a new tor-browser.ftl file that we need to place in the right directory during the build. - - - - - 2 changed files: - projects/firefox/build - projects/translation/config Changes: ===================================== projects/firefox/build ===================================== @@ -138,6 +138,7 @@ mkdir "$HOME/.mozbuild" lang="ja" fi [% END -%] + mv "$transl_tor_browser/$lang/tor-browser.ftl" "$l10ncentral/$lang/browser/browser/" mv "$transl_tor_browser/$lang/cryptoSafetyPrompt.properties" "$l10ncentral/$central_lang/browser/chrome/browser/" mv "$transl_tor_browser/$lang" "$torbutton_locales/" echo "% locale torbutton $lang %locale/$lang/" >> "$torbutton_jar" ===================================== projects/translation/config ===================================== @@ -18,7 +18,7 @@ steps: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 976a9c609d09666b67e5a7f530a5df7bad8b35ea + git_hash: 20f254a961574996496db5897aa06723bb79bce7 targets: nightly: git_hash: 'tor-browser' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] 2 commits: fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
by Pier Angelo Vendrame (＠pierov) 30 Aug '23

30 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 0548dd50 by Pier Angelo Vendrame at 2023-08-30T14:43:07+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Move the alpha channel creation to a commit on its own - - - - - cd2ab905 by Pier Angelo Vendrame at 2023-08-30T14:46:26+02:00 Bug 42061: Create an alpha update channel. - - - - - 0 changed files: Changes: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/22073e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/22073e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
by Pier Angelo Vendrame (＠pierov) 30 Aug '23

30 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 625640a1 by Pier Angelo Vendrame at 2023-08-30T19:00:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Move the alpha channel creation to a commit on its own - - - - - 7eaa9c28 by Pier Angelo Vendrame at 2023-08-30T19:00:01+02:00 Bug 42061: Create an alpha update channel. - - - - - 0 changed files: Changes: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e2cb4a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e2cb4a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by richard (＠richard) 30 Aug '23

30 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e2cb4a22 by Henry Wilkes at 2023-08-30T16:57:07+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41980: Center-align the circuit heading. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.css Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.css ===================================== @@ -39,14 +39,26 @@ } #tor-circuit-panel .panel-header { - /* .panel-header already has display: flex from panelUI-shared.css, but the - * direction is the default "row". */ + /* .panel-header already inherits these same rules from panelUI-shared.css and + * xul.css. But .panel-header is normally "flex-direction: row", but we are + * using a vbox (i.e flex-direction: column) so that the heading is placed + * vertically above the #tor-circuit-alias when it is shown. We want to + * ensure the layout rules we need for our different case so we are less + * vulnerable to changes in panelUI-shared.css. */ display: flex; flex-direction: column; align-items: center; + justify-content: center; text-align: center; } +.panel-header > h1#tor-circuit-heading { + /* Overwrite rule from panelUI-shared.css which gives this "flex: auto". + * Otherwise the heading will be stretched vertically and not be + * center-aligned. */ + flex: 0 0 auto; +} + #tor-circuit-alias:not([hidden]) { /* Same margin as .panel-header > h1 */ margin: 4px 0; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e2cb4a2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e2cb4a2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 30 Aug '23

30 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f7b33748 by Henry Wilkes at 2023-08-30T16:55:18+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41651: Use moz-toggle for enable-bridges switch. - - - - - 3507dd2c by Henry Wilkes at 2023-08-30T16:55:18+00:00 fixup! Customize moz-toggle for tor-browser. Bug 41651: Use moz-toggle for enable-bridges switch. - - - - - 4 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/torPreferences.css - toolkit/content/widgets/moz-toggle/moz-toggle.mjs Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -99,7 +99,6 @@ const gConnectionPane = (function () { currentHeader: "#torPreferences-currentBridges-header", currentDescription: "#torPreferences-currentBridges-description", currentDescriptionText: "#torPreferences-currentBridges-descriptionText", - switchLabel: "#torPreferences-currentBridges-enableAll-label", switch: "#torPreferences-currentBridges-switch", cards: "#torPreferences-currentBridges-cards", cardTemplate: "#torPreferences-bridgeCard-template", @@ -391,11 +390,10 @@ const gConnectionPane = (function () { selectors.bridges.currentHeader ); bridgeHeader.textContent = TorStrings.settings.bridgeCurrent; - prefpane.querySelector(selectors.bridges.switchLabel).textContent = - TorStrings.settings.allBridgesEnabled; const bridgeSwitch = prefpane.querySelector(selectors.bridges.switch); - bridgeSwitch.addEventListener("change", () => { - TorSettings.bridges.enabled = bridgeSwitch.checked; + bridgeSwitch.setAttribute("label", TorStrings.settings.allBridgesEnabled); + bridgeSwitch.addEventListener("toggle", () => { + TorSettings.bridges.enabled = bridgeSwitch.pressed; TorSettings.saveToPrefs(); TorSettings.applySettings().then(result => { this._populateBridgeCards(); @@ -525,7 +523,7 @@ const gConnectionPane = (function () { strings.splice(index, 1); } TorSettings.bridges.enabled = - bridgeSwitch.checked && !!strings.length; + bridgeSwitch.pressed && !!strings.length; TorSettings.bridges.bridge_strings = strings.join("\n"); TorSettings.saveToPrefs(); TorSettings.applySettings().then(result => { @@ -642,7 +640,9 @@ const gConnectionPane = (function () { bridgeHeader.hidden = false; bridgeDescription.hidden = false; bridgeCards.hidden = false; - bridgeSwitch.checked = TorSettings.bridges.enabled; + // Changing the pressed property on moz-toggle should not trigger its + // "toggle" event. + bridgeSwitch.pressed = TorSettings.bridges.enabled; bridgeCards.classList.toggle("disabled", !TorSettings.bridges.enabled); bridgeCards.classList.toggle("single-card", numBridges === 1); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -108,16 +108,10 @@ <html:span id="torPreferences-currentBridges-descriptionText" /> </description> <hbox align="center"> - <html:input - type="checkbox" + <html:moz-toggle id="torPreferences-currentBridges-switch" - class="toggle-button" + label-align-after="" /> - <html:label - id="torPreferences-currentBridges-enableAll-label" - for="torPreferences-currentBridges-switch" - > - </html:label> <spacer flex="1" /> <button id="torPreferences-currentBridges-removeAll" /> </hbox> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -5,11 +5,6 @@ list-style-image: url("chrome://browser/content/torconnect/tor-connect.svg"); } -html:dir(rtl) input[type="checkbox"].toggle-button::before { - /* For some reason, the rule from toggle-button.css is not applied... */ - scale: -1; -} - /* Status */ #torPreferences-status-box { @@ -83,12 +78,6 @@ html:dir(rtl) input[type="checkbox"].toggle-button::before { font-weight: 700; } -#torPreferences-currentBridges-enableAll-label { - /* Block display to work with parent's xul box layout. */ - display: block; - margin-inline: 6px; -} - /* Bridge cards */ :root { --bridgeCard-animation-time: 0.25s; ===================================== toolkit/content/widgets/moz-toggle/moz-toggle.mjs ===================================== @@ -36,6 +36,8 @@ export default class MozToggle extends MozLitElement { accessKey: { type: String, attribute: "accesskey" }, // Extension for tor-browser. Used for tor-browser#41333. title: { type: String, attribute: "title" }, + // Extension for tor-browser. Used for tor-browser#40837. + labelAlignAfter: { type: Boolean, attribute: "label-align-after" }, }; static get queries() { @@ -119,9 +121,13 @@ export default class MozToggle extends MozLitElement { // accessible name derived from the label. const label = ariaLabel || this.label; const ariaDescription = label === this.title ? undefined : this.title; + // For tor-browser, we want to be able to place the label after the toggle + // as well. + // Used for the enable-bridges switch tor-browser#40837. + const labelAlignAfter = this.labelAlignAfter; return html` <link rel="stylesheet" href=${this.constructor.stylesheetUrl} /> - ${this.labelTemplate()} + ${labelAlignAfter ? "" : this.labelTemplate()} <button id="moz-toggle-button" part="button" @@ -136,6 +142,7 @@ export default class MozToggle extends MozLitElement { )} @click=${handleClick} ></button> + ${labelAlignAfter ? this.labelTemplate() : ""} ${this.descriptionTemplate()} `; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/db6f2f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/db6f2f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] 2 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 30 Aug '23

30 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 36d58583 by Pier Angelo Vendrame at 2023-08-30T11:56:14+02:00 fixup! Base Browser strings Bug 41528: Added the version string for the about dialog - - - - - 22073ee8 by Pier Angelo Vendrame at 2023-08-30T11:56:20+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41528: Localized the version string in the about dialog - - - - - 3 changed files: - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/locales/en-US/browser/base-browser.ftl Changes: ===================================== browser/base/content/aboutDialog.js ===================================== @@ -43,19 +43,12 @@ function init() { } // Include the build ID and display warning if this is an "a#" (nightly or aurora) build - let versionId = "aboutDialog-version"; + let versionId = "basebrowser-about-dialog-version"; let versionAttributes = { - version: AppConstants.MOZ_APP_VERSION_DISPLAY, - bits: Services.appinfo.is64Bit ? 64 : 32, + version: AppConstants.BASE_BROWSER_VERSION, + firefoxVersion: AppConstants.MOZ_APP_VERSION_DISPLAY, }; - // Adjust version text to show the fork version - versionAttributes.version = - AppConstants.BASE_BROWSER_VERSION + - " (based on Mozilla Firefox " + - AppConstants.MOZ_APP_VERSION_DISPLAY + - ")"; - let version = Services.appinfo.version; if (/a\d+$/.test(version)) { document.getElementById("experimental").hidden = false; ===================================== browser/base/content/aboutDialog.xhtml ===================================== @@ -30,6 +30,7 @@ <linkset> <html:link rel="localization" href="branding/brand.ftl"/> <html:link rel="localization" href="browser/aboutDialog.ftl"/> + <html:link rel="localization" href="browser/base-browser.ftl"/> </linkset> <html:div id="aboutDialogContainer"> ===================================== browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -23,3 +23,10 @@ basebrowser-rfp-restore-window-size-button-ak = R basebrowser-addon-badge-recommended = Mozilla only recommends extensions that meet their standards for security and performance basebrowser-addon-badge-verified = Mozilla has reviewed this extension to meet their standards for security and performance + +## About dialog + +# "Mozilla Firefox" should be treated like a brand and it should be neither translated nor transliterated. +# $version (String) - The current browser version. E.g. "12.5.3". +# $firefoxVersion (String) - The version number of Firefox the current browser is based on. E.g. "102.15.0esr". +basebrowser-about-dialog-version = { $version } (based on Mozilla Firefox { $firefoxVersion }) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bcbb28… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bcbb28… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 30 Aug '23

30 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 28d06463 by Pier Angelo Vendrame at 2023-08-30T11:39:48+02:00 fixup! Base Browser strings Bug 41528: Added the version string for the about dialog - - - - - db6f2f8f by Pier Angelo Vendrame at 2023-08-30T11:39:49+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 41528: Localized the version string in the about dialog - - - - - 3 changed files: - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/locales/en-US/browser/base-browser.ftl Changes: ===================================== browser/base/content/aboutDialog.js ===================================== @@ -43,19 +43,12 @@ function init() { } // Include the build ID and display warning if this is an "a#" (nightly or aurora) build - let versionId = "aboutDialog-version"; + let versionId = "basebrowser-about-dialog-version"; let versionAttributes = { - version: AppConstants.MOZ_APP_VERSION_DISPLAY, - bits: Services.appinfo.is64Bit ? 64 : 32, + version: AppConstants.BASE_BROWSER_VERSION, + firefoxVersion: AppConstants.MOZ_APP_VERSION_DISPLAY, }; - // Adjust version text to show the fork version - versionAttributes.version = - AppConstants.BASE_BROWSER_VERSION + - " (based on Mozilla Firefox " + - AppConstants.MOZ_APP_VERSION_DISPLAY + - ")"; - let version = Services.appinfo.version; if (/a\d+$/.test(version)) { document.getElementById("experimental").hidden = false; ===================================== browser/base/content/aboutDialog.xhtml ===================================== @@ -36,6 +36,7 @@ <linkset> <html:link rel="localization" href="branding/brand.ftl"/> <html:link rel="localization" href="browser/aboutDialog.ftl"/> + <html:link rel="localization" href="browser/base-browser.ftl"/> </linkset> <html:div id="aboutDialogContainer"> ===================================== browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -23,3 +23,10 @@ basebrowser-rfp-restore-window-size-button-ak = R basebrowser-addon-badge-recommended = Mozilla only recommends extensions that meet their standards for security and performance basebrowser-addon-badge-verified = Mozilla has reviewed this extension to meet their standards for security and performance + +## About dialog + +# "Mozilla Firefox" should be treated like a brand and it should be neither translated nor transliterated. +# $version (String) - The current browser version. E.g. "12.5.3". +# $firefoxVersion (String) - The version number of Firefox the current browser is based on. E.g. "102.15.0esr". +basebrowser-about-dialog-version = { $version } (based on Mozilla Firefox { $firefoxVersion }) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e54d56… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e54d56… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 29 Aug '23

29 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e54d560b by Richard Pospesel at 2023-08-29T20:33:07+00:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -50,8 +50,7 @@ pref("permissions.memory_only", true); pref("network.cookie.lifetimePolicy", 2); pref("security.nocertdb", true); -// Disk Activity Disable auto-downloaing to ~/Downloads and other download -// tweaks to minimize disk leaks (tor-browser#42050) +// Disk activity: download tweaks to minimize disk leaks (tor-browser#42050) pref("browser.download.useDownloadDir", false); pref("browser.download.always_ask_before_handling_new_types", true); pref("browser.download.manager.addToRecentDocs", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e54d560… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e54d560… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 29 Aug '23

29 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: bcbb28ea by Richard Pospesel at 2023-08-29T20:32:16+00:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -50,8 +50,7 @@ pref("permissions.memory_only", true); pref("network.cookie.lifetimePolicy", 2); pref("security.nocertdb", true); -// Disk Activity Disable auto-downloaing to ~/Downloads and other download -// tweaks to minimize disk leaks (tor-browser#42050) +// Disk activity: download tweaks to minimize disk leaks (tor-browser#42050) pref("browser.download.useDownloadDir", false); pref("browser.download.always_ask_before_handling_new_types", true); pref("browser.download.manager.addToRecentDocs", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bcbb28e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bcbb28e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 29 Aug '23

29 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 200f0ef8 by Richard Pospesel at 2023-08-29T20:29:40+00:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -50,9 +50,12 @@ pref("permissions.memory_only", true); pref("network.cookie.lifetimePolicy", 2); pref("security.nocertdb", true); -// Disk activity: TBB Directory Isolation +// Disk Activity Disable auto-downloaing to ~/Downloads and other download +// tweaks to minimize disk leaks (tor-browser#42050) pref("browser.download.useDownloadDir", false); +pref("browser.download.always_ask_before_handling_new_types", true); pref("browser.download.manager.addToRecentDocs", false); +pref("browser.download.start_downloads_in_tmp_dir", true); // Prevent download stuffing / DOS (tor-browser#41764) pref("browser.download.enable_spam_prevention", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/200f0ef… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/200f0ef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: fixup! Firefox preference overrides.
by richard (＠richard) 29 Aug '23

29 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 21e22bb1 by Richard Pospesel at 2023-08-29T20:18:43+00:00 fixup! Firefox preference overrides. - - - - - f3e8eab7 by Richard Pospesel at 2023-08-29T20:18:44+00:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js - - - - - 2 changed files: - browser/app/profile/000-tor-browser.js - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -51,9 +51,7 @@ pref("extensions.torbutton.use_nontor_proxy", false); // Browser home page: pref("browser.startup.homepage", "about:tor"); -// tor-browser#40701: Add new download warning and flipping prefs to match Firefox -pref("browser.download.useDownloadDir", true); -pref("browser.download.always_ask_before_handling_new_types", false); +// tor-browser#40701: Add new download warning pref("browser.download.showTorWarning", true); // This pref specifies an ad-hoc "version" for various pref update hacks we need to do ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -50,9 +50,12 @@ pref("permissions.memory_only", true); pref("network.cookie.lifetimePolicy", 2); pref("security.nocertdb", true); -// Disk activity: TBB Directory Isolation +// Disk Activity Disable auto-downloaing to ~/Downloads and other download +// tweaks to minimize disk leaks (tor-browser#42050) pref("browser.download.useDownloadDir", false); +pref("browser.download.always_ask_before_handling_new_types", true); pref("browser.download.manager.addToRecentDocs", false); +pref("browser.download.start_downloads_in_tmp_dir", true); // Prevent download stuffing / DOS (tor-browser#41764) pref("browser.download.enable_spam_prevention", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3fbd71… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3fbd71… You're receiving this email because of your account on gitlab.torproject.org.

1 0