July 2025 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_NIGHTLY_141_END
by brizental (＠brizental) 17 Jul '25

17 Jul '25

brizental pushed new tag FIREFOX_NIGHTLY_141_END at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_N… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_NIGHTLY_141_END
by brizental (＠brizental) 17 Jul '25

17 Jul '25

brizental pushed new tag FIREFOX_NIGHTLY_141_END at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-141.0a1-16.0-1
by brizental (＠brizental) 17 Jul '25

17 Jul '25

brizental pushed new branch mullvad-browser-141.0a1-16.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-141.0a1-16.0-1
by brizental (＠brizental) 17 Jul '25

17 Jul '25

brizental pushed new branch base-browser-141.0a1-16.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-141.0a1-16.0-1
by brizental (＠brizental) 17 Jul '25

17 Jul '25

brizental pushed new branch tor-browser-141.0a1-16.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41227: Add binutils to the toolchain update script.
by Pier Angelo Vendrame (＠pierov) 17 Jul '25

17 Jul '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 290ea887 by Pier Angelo Vendrame at 2025-07-17T12:15:30+02:00 Bug 41227: Add binutils to the toolchain update script. - - - - - 1 changed file: - projects/common/list_toolchain_updates-common-firefox-geckoview Changes: ===================================== projects/common/list_toolchain_updates-common-firefox-geckoview ===================================== @@ -153,3 +153,18 @@ EOF needed=$(cat python/mozboot/bin/bootstrap.py | perl -ne "$p") current="3.8+" # 3.11.x on Debian bookworm, 3.9.20 on our python project check_update_needed python "$needed" "$current" + + +# binutils +read -d '' p << 'EOF' || true + +my $d = YAML::XS::LoadFile('taskcluster/kinds/toolchain/misc.yml'); +my $f = $d->{'linux64-binutils'}{fetches}{fetch}[0]; +my ($version) = $f =~ m|^binutils-([0-9\\.]+)|; +exit 1 unless $version; +print "$version\\n"; +EOF + +needed=$(perl -MYAML::XS -e "$p") +current='[% pc("binutils", "version") %]' +check_update_needed node "$needed" "$current" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.0esr-15.0-1] TB 43987 [Android]: disable optimization for org.mozilla.experiments.nimbus.Nimbus
by boklm (＠boklm) 17 Jul '25

17 Jul '25

boklm pushed to branch tor-browser-140.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: d4d0ff81 by Nicolas Vigier at 2025-07-17T08:31:12+02:00 TB 43987 [Android]: disable optimization for org.mozilla.experiments.nimbus.Nimbus Fixing a reproducibility issue. - - - - - 1 changed file: - mobile/android/fenix/app/proguard-rules.pro Changes: ===================================== mobile/android/fenix/app/proguard-rules.pro ===================================== @@ -133,3 +133,7 @@ # Workaround for 'already has mapping' r8 issue (https://issuetracker.google.com/issues/140851070) -keep class com.google.android.gms.common.internal.BaseGmsClient { *; } + +# tor-browser#43987 - Keep org.mozilla.experiments.nimbus.Nimbus to fix +# reproducibility issue +-keep class org.mozilla.experiments.nimbus.Nimbus { *; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d4d0ff8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d4d0ff8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.0esr-15.0-1] 3 commits: fixup! TB 40597: Implement TorSettings module
by henry (＠henry) 16 Jul '25

16 Jul '25

henry pushed to branch tor-browser-140.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: da315c55 by Henry Wilkes at 2025-07-16T18:30:55+01:00 fixup! TB 40597: Implement TorSettings module TB 43766: Save TorSettings to preferences in separate groups. - - - - - bfe6d078 by Henry Wilkes at 2025-07-16T18:30:56+01:00 fixup! TB 40597: Implement TorSettings module TB 43766: Update a FIXME comment to point to a newer issue. - - - - - 3f8590fc by Henry Wilkes at 2025-07-16T18:30:56+01:00 fixup! Lox integration TB 43765: Disable lox on alpha channel. - - - - - 2 changed files: - toolkit/components/lox/Lox.sys.mjs - toolkit/modules/TorSettings.sys.mjs Changes: ===================================== toolkit/components/lox/Lox.sys.mjs ===================================== @@ -1,5 +1,4 @@ /* eslint-disable mozilla/valid-lazy */ -import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs"; import { clearInterval, setInterval, @@ -121,7 +120,7 @@ class LoxImpl { * * @type {boolean} */ - #enabled = AppConstants.MOZ_UPDATE_CHANNEL !== "release"; + #enabled = false; get enabled() { return this.#enabled; ===================================== toolkit/modules/TorSettings.sys.mjs ===================================== @@ -612,8 +612,7 @@ class TorSettingsImpl { this.#settings.bridges.source === TorBridgeSource.Lox ) { // Re-trigger the call to lazy.Lox.getBridges. - // FIXME: This can compete with TorConnect to reach TorProvider. - // tor-browser#42316 + // FIXME: This can cancel a bootstrap. tor-browser#43991. this.changeSettings({ bridges: { source: TorBridgeSource.Lox, @@ -767,14 +766,11 @@ class TorSettingsImpl { } /** - * Save our settings to prefs. + * Save our bridge settings. */ - #saveToPrefs() { - lazy.logger.debug("saveToPrefs()"); + #saveBridgeSettings() { + lazy.logger.debug("Saving bridge settings"); - this.#checkIfInitialized(); - - /* Bridges */ Services.prefs.setBoolPref( TorSettingsPrefs.bridges.enabled, this.#settings.bridges.enabled @@ -812,7 +808,14 @@ class TorSettingsImpl { ); }); } - /* Proxy */ + } + + /** + * Save our proxy settings. + */ + #saveProxySettings() { + lazy.logger.debug("Saving proxy settings"); + Services.prefs.setBoolPref( TorSettingsPrefs.proxy.enabled, this.#settings.proxy.enabled @@ -845,7 +848,14 @@ class TorSettingsImpl { Services.prefs.clearUserPref(TorSettingsPrefs.proxy.username); Services.prefs.clearUserPref(TorSettingsPrefs.proxy.password); } - /* Firewall */ + } + + /** + * Save our firewall settings. + */ + #saveFirewallSettings() { + lazy.logger.debug("Saving firewall settings"); + Services.prefs.setBoolPref( TorSettingsPrefs.firewall.enabled, this.#settings.firewall.enabled @@ -1403,7 +1413,32 @@ class TorSettingsImpl { // No errors so far, so save and commit. this.#settings = completeSettings; - this.#saveToPrefs(); + // NOTE: We want to avoid overwriting saved preference values unless the + // user actually makes a change in their settings. + // In particular, if we fail to load a setting at startup due to a bug, the + // #settings object for that group will point to the #defaultSettings value + // instead. We do not want to write these #defaultSettings to the user's + // settings unless the user actually makes a change in one of the groups. + // E.g. we do not want a change in the proxy settings to overwrite the + // saved bridge settings. Hence, we only save the groups that have changes. + // See tor-browser#43766. + // NOTE: We could go more fine-grained and only save the preference values + // that actually change. E.g. only save the bridges.enabled pref when the + // user switches the toggle, and leave the bridges.bridge_strings as they + // are. However, at the time of implementation there is no known benefit to + // doing this, since the #defaultSettings will not allow for any changes + // that don't require changing the group entirely. E.g. to change + // bridges.enabled when starting with the #defaultSettings.bridges, + // bridges.bridge_strings must necessarily be set. + if (apply.bridges) { + this.#saveBridgeSettings(); + } + if (apply.proxy) { + this.#saveProxySettings(); + } + if (apply.firewall) { + this.#saveFirewallSettings(); + } if (changes.length) { Services.obs.notifyObservers( View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0a4f89… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0a4f89… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.0esr-15.0-1] 2 commits: fixup! MB 112: Updater customization for Mullvad Browser
by henry (＠henry) 16 Jul '25

16 Jul '25

henry pushed to branch mullvad-browser-140.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 97229a59 by Henry Wilkes at 2025-07-16T18:10:58+01:00 fixup! MB 112: Updater customization for Mullvad Browser TB 42738: Move override logic to the about:mullvad-browser commit. - - - - - 2909cc84 by Henry Wilkes at 2025-07-16T18:10:59+01:00 fixup! MB 39: Add home page about:mullvad-browser TB 43929: Update about:mullvad-browser override page logic for ESR 140. TB 42738: Move these changes to the about:mullvad-browser commit. - - - - - 1 changed file: - browser/components/BrowserContentHandler.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -781,6 +781,7 @@ nsBrowserContentHandler.prototype = { var overridePage = ""; var additionalPage = ""; var willRestoreSession = false; + let openAboutMullvadBrowser = false; try { // Read the old value of homepage_override.mstone before // needHomepageOverride updates it, so that we can later add it to the @@ -986,13 +987,8 @@ nsBrowserContentHandler.prototype = { "mullvadbrowser.post_update.shouldNotify", true ); - // If the user's homepage is about:mullvad-browser, we will inform - // them about the update on that page; otherwise, we arrange to - // open about:mullvad-browser in a secondary tab. - overridePage = - startPage === "about:mullvad-browser" - ? "" - : "about:mullvad-browser"; + openAboutMullvadBrowser = true; + overridePage = "about:mullvad-browser"; } break; } @@ -1093,6 +1089,16 @@ nsBrowserContentHandler.prototype = { startPage = ""; } + // If the user's homepage is about:mullvad-browser, we do not want to open + // it twice with the override. + if ( + openAboutMullvadBrowser && + startPage === "about:mullvad-browser" && + overridePage?.split("|").includes("about:mullvad-browser") + ) { + startPage = ""; + } + // Only show the startPage if we're not restoring an update session and are // not set to skip the start page on this profile if (overridePage && startPage && !willRestoreSession && !skipStartPage) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/4e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/4e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.0esr-15.0-1] 3 commits: fixup! TB 41668: Tweaks to the Base Browser updater for Tor Browser
by henry (＠henry) 16 Jul '25

16 Jul '25

henry pushed to branch tor-browser-140.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 7ed4b70d by Henry Wilkes at 2025-07-16T18:08:29+01:00 fixup! TB 41668: Tweaks to the Base Browser updater for Tor Browser TB 42738: Move override logic to the about:tor commit. - - - - - 84a5fe09 by Henry Wilkes at 2025-07-16T18:08:30+01:00 fixup! TB 7494: Create local home page for TBB. TB 42738: Temporarily revert the about:tor changes to BrowserContentHandler.sys.mjs. - - - - - 0a4f89ea by Henry Wilkes at 2025-07-16T18:08:31+01:00 fixup! TB 7494: Create local home page for TBB. TB 43929: Update about:tor override page logic for ESR 140. Unlike ESR 128, we do not try and move the startPage logic to earlier in the method since it would complicate the patch and upstream's logic. Instead, we delay out duplicate about:tor logic until the end of the method. - - - - - 1 changed file: - browser/components/BrowserContentHandler.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -781,6 +781,7 @@ nsBrowserContentHandler.prototype = { var overridePage = ""; var additionalPage = ""; var willRestoreSession = false; + let openAboutTor = false; try { // Read the old value of homepage_override.mstone before // needHomepageOverride updates it, so that we can later add it to the @@ -980,16 +981,14 @@ nsBrowserContentHandler.prototype = { // Tor Browser: Instead of opening the post-update "override page" // directly, we ensure that about:tor will be opened, which should // notify the user that their browser was updated. - // NOTE: We ignore any overridePage value, which can come from the - // openURL attribute within the updates.xml file. + // NOTE: We ignore any existing overridePage value, which can come + // from the openURL attribute within the updates.xml file. Services.prefs.setBoolPref( "torbrowser.post_update.shouldNotify", true ); - // If the user's homepage is about:tor, we will inform them - // about the update on that page; otherwise, we arrange to - // open about:tor in a secondary tab. - overridePage = startPage === "about:tor" ? "" : "about:tor"; + openAboutTor = true; + overridePage = "about:tor"; } break; } @@ -1090,6 +1089,16 @@ nsBrowserContentHandler.prototype = { startPage = ""; } + // If the user's homepage is about:tor, we do not want to open it twice with + // the override. + if ( + openAboutTor && + startPage === "about:tor" && + overridePage?.split("|").includes("about:tor") + ) { + startPage = ""; + } + // Only show the startPage if we're not restoring an update session and are // not set to skip the start page on this profile if (overridePage && startPage && !willRestoreSession && !skipStartPage) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ac068d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ac068d… You're receiving this email because of your account on gitlab.torproject.org.

1 0