December 2020 - tbb-commits - lists.torproject.org

[tor-browser-spec/master] Add rust symbols in audit script
by gk＠torproject.org 01 Dec '20

01 Dec '20

commit 033222ab1543cd4dae20fc8c40f5a1449cd3dd17 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Wed Nov 25 17:20:39 2020 +0000 Add rust symbols in audit script --- audits/java_audit.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/audits/java_audit.sh b/audits/java_audit.sh index 3e94fa3..51c9bf4 100644 --- a/audits/java_audit.sh +++ b/audits/java_audit.sh @@ -53,6 +53,13 @@ KEYWORDS+=(ActivityHandlerHelper.startIntentAndCatch) KEYWORDS+=(AppLinksInterceptor) KEYWORDS+=(AppLinksUseCases) +# Rust symbols +KEYWORDS+=("connect\(") +KEYWORDS+=("recvmsg\(") +KEYWORDS+=("sendmsg\(") +KEYWORDS+=("::post\(") +KEYWORDS+=("::get\(") + cd $REPO_DIR #function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/ $d}"; } #GREP_LINE="$(join_by \-G ${KEYWORDS[@]})"

1 0

[tor-browser-spec/master] Use correct word in network audit template
by gk＠torproject.org 01 Dec '20

01 Dec '20

commit 7be360991f5614cfbfa75913d0e367013dba921a Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Dec 1 16:39:06 2020 +0000 Use correct word in network audit template --- audits/NETWORK_AUDIT_RUBRIC | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audits/NETWORK_AUDIT_RUBRIC b/audits/NETWORK_AUDIT_RUBRIC index 89ec61c..b58bb49 100644 --- a/audits/NETWORK_AUDIT_RUBRIC +++ b/audits/NETWORK_AUDIT_RUBRIC @@ -1,5 +1,5 @@ `git diff esrA esrB` and then go over all the changes containing the -above mentioned potentially dangerous calls and features. Grep the diff for +below mentioned potentially dangerous calls and features. Grep the diff for the following strings and examine surrounding usage. =============== Native DNS Portion =============

1 0

[tor-browser-spec/master] Bug 40008: Add Fenix84 net audit
by gk＠torproject.org 01 Dec '20

01 Dec '20

commit b5ae80caf42ac4ef1a09441e65d2feca51e9217e Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Wed Nov 25 17:21:54 2020 +0000 Bug 40008: Add Fenix84 net audit --- audits/FF84_NETWORK_AUDIT | 158 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 158 insertions(+) diff --git a/audits/FF84_NETWORK_AUDIT b/audits/FF84_NETWORK_AUDIT new file mode 100644 index 0000000..039dd96 --- /dev/null +++ b/audits/FF84_NETWORK_AUDIT @@ -0,0 +1,158 @@ +`git diff 1cb2c4893850a5b0a246f821a6390c07064c1227 9e429e392ec8446ff0f078f991d6332a307bc98f` +and then go over all the changes containing the +below mentioned potentially dangerous calls and features. Grep the diff for +the following strings and examine surrounding usage. + +=============== Native DNS Portion ============= + +PR_GetHostByName +PR_GetIPNodeByName +PR_GetAddrInfoByName +PR_StringToNetAddr (itself is good as it passes AI_NUMERICHOST to getaddrinfo. No resolution.) + +# FF84: +# Bug 1220810: +# - When |network.proxy.allow_hijacking_localhost| is false, then localhost == loopback +# - Tor Browser set |network.proxy.allow_hijacking_localhost| as true in #31065 +# Proxy-safe when pref is true + +# Bug 1667579: +# - New pref |network.connectivity-service.nat64-prefix| for specifying a NAT64 prefix +# for use if IPv4 is not available (default "") +# Proxy-safe, only affects order of internal DNS records + + +MDNS + +# FF84: Nothing new + + +TRR (DNS Trusted Recursive Resolver) + +# FF84: +# Bug 1673590: +# - Still protected by https://bugzil.la/1636411 + + +Direct Paths to DNS resolution: +nsDNSService::Resolve +nsDNSService::AsyncResolve +nsHostResolver::ResolveHost + +# FF84: +# Bug 1667356 +# - Protected by Mozilla's proxy-bypass protection for https://bugzil.la/1618271 + +# Bug 1671939: +# - Protected by Mozilla's proxy-bypass protection for https://bugzil.la/1618271 + +# Bug 1220810: +# - Protected by Mozilla's proxy-bypass protection for https://bugzil.la/1636411 + +============ Misc Socket Portion ============== + +SOCK_ +SOCKET_ +_SOCKET + +# FF84: Nothing of interest (mostly reformatting) + + +UDPSocket +TCPSocket + PR_NewTCPSocket + AsyncTCPSocket + +# FF84: Nothing of interest (mostly reformatting) + + +Misc PR_Socket + +# FF84: Nothing new + +=========== Misc XPCOM Portion ================ + +Misc XPCOM (including commands for pre-diff review approach) + *SocketProvider + grep -R udp-socket . + grep -R tcp-socket . + grep for tcpsocket + grep -R "NS_" | grep SOCKET | grep "_C" + grep -R "@mozilla.org/network/" . | grep socket | grep -v udp-socket + +# FF84: Zero instances outside of tests and moved code + +============ Rust Portion ================ + +Rust + - XXX: What do we grep for here? Or do we rely on Ritter's compile-time tool? + - Check for new sendmsg and recvmsg usage + +# FF84: Nothing of interest (mostly reformatting and new web audio behavior for 1346880, and Pipewire for 1672945) + + + +============ Android Portion ============= + +Android Java calls + - URLConnection + - XXX: getInputStream? other methods? + - HttpURLConnection + - UrlConnectionDownloader + - ch.boye.httpclientandroidlib.impl.client.* (look for execute() calls) + - grep -n openConnection\( mobile/android/thirdparty/ + - java.net.URL -- has SEVERAL proxy bypass URL fetching methods :/ + - java.net + - javax.net + - ch.boye.httpclientandroidlib.conn.* (esp ssl) + - ch.boye.httpclientandroidlib.impl.conn.* (esp ssl) + - Sudden appearance of thirdparty libs: + - OkHttp + - Retrofit + - Glide + - com.amitshekhar.android + - IntentHelper + - openUriExternal (can come from GeckoAppShell too) + - getHandlersForMimeType + - getHandlersForURL + - getHandlersForIntent + - android.content.Intent - too common; instead find launch methods: + - startActivity + - startActivities + - sendBroadcast + - sendOrderedBroadcast + - startService + - bindService + - android.app.PendingIntent + - android.app.DownloadManager + - ActivityHandlerHelper.startIntentAndCatch + +# FF84: Nothing new (using `java_audit.sh`) + +============ Application Services Portion ============= + +Start: 8e63363359c3d20385ed55f5308d19e321816898 # v63.0.0 +End: 6a234c2b1e1972f11e585551d4cf2e40e84bf16f # v67.0.0 + +# FF84: Nothing related to networking in Java/Koltlin/Rust code (using `java_audit.sh`) + +============ Android Components Portion ============= + +Start: 0a2993d44aae3d877bb97cee925096f83af01b3a # v63.0.8 +End: 614386935ec94cac531eb8cb061409e9a8410d09 # v67.0.3 + +# FF84: Zero new usage found of known proxy-bypass APIs (using `java_audit.sh`) + +============ Fenix Portion ============= + +Start: 5441935698f4d9e3606f3d6baf892f6e0106a2f6 # v83.1.0-rc.1 +End: 670e61b2b97d4f8066497e79178729c5802fe428 # v84.0.0-beta.2 + +# FF84: Zero new usage found of known proxy-bypass APIs (using `java_audit.sh`) + +============ Regression/Prior Vuln Review ========= + +Review proxy bypass bugs; check for new vectors to look for: + - https://trac.torproject.org/projects/tor/query?keywords=~tbb-proxy + - Look for new features like these. Especially external app launch vectors +

1 0

[tor-browser-build/master] Bug 40081: Build Mozilla code with --enable-rust-simd
by sysrqb＠torproject.org 01 Dec '20

01 Dec '20

commit 1f62decb1be130639412774a06b358eca06a4faf Author: Georg Koppen <gk(a)torproject.org> Date: Sun Nov 8 10:25:00 2020 +0000 Bug 40081: Build Mozilla code with --enable-rust-simd Mozilla builds their CI and shipped code with Rust SIMD enabled (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1578677#c4) We should therefore do the same. Thanks to a cypherpunk for pointing that out. --- projects/firefox/mozconfig-linux-i686 | 1 + projects/firefox/mozconfig-linux-x86_64 | 1 + projects/firefox/mozconfig-linux-x86_64-asan | 1 + projects/firefox/mozconfig-osx-x86_64 | 1 + projects/firefox/mozconfig-windows-i686 | 1 + projects/firefox/mozconfig-windows-x86_64 | 1 + projects/geckoview/mozconfig-android-aarch64 | 1 + projects/geckoview/mozconfig-android-armv7 | 1 + projects/geckoview/mozconfig-android-x86 | 1 + projects/geckoview/mozconfig-android-x86_64 | 1 + 10 files changed, 10 insertions(+) diff --git a/projects/firefox/mozconfig-linux-i686 b/projects/firefox/mozconfig-linux-i686 index 76c3ba3..2d0e08f 100755 --- a/projects/firefox/mozconfig-linux-i686 +++ b/projects/firefox/mozconfig-linux-i686 @@ -17,6 +17,7 @@ export BINDGEN_CFLAGS='--gcc-toolchain=/var/tmp/dist/gcc' ac_add_options --target=i686-linux-gnu ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/projects/firefox/mozconfig-linux-x86_64 b/projects/firefox/mozconfig-linux-x86_64 index 251cdc0..47c23e9 100755 --- a/projects/firefox/mozconfig-linux-x86_64 +++ b/projects/firefox/mozconfig-linux-x86_64 @@ -15,6 +15,7 @@ HOST_CXX=$CXX export BINDGEN_CFLAGS='--gcc-toolchain=/var/tmp/dist/gcc' ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/projects/firefox/mozconfig-linux-x86_64-asan b/projects/firefox/mozconfig-linux-x86_64-asan index a1c4e46..8bee813 100644 --- a/projects/firefox/mozconfig-linux-x86_64-asan +++ b/projects/firefox/mozconfig-linux-x86_64-asan @@ -23,6 +23,7 @@ ac_add_options --disable-elf-hack ac_add_options --with-clang-path=/var/tmp/dist/clang/bin/clang ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/projects/firefox/mozconfig-osx-x86_64 b/projects/firefox/mozconfig-osx-x86_64 index 09c53fc..4609839 100644 --- a/projects/firefox/mozconfig-osx-x86_64 +++ b/projects/firefox/mozconfig-osx-x86_64 @@ -33,6 +33,7 @@ ac_add_options --enable-application=browser ac_add_options --enable-strip ac_add_options --enable-official-branding ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --disable-debug ac_add_options --enable-tor-browser-data-outside-app-dir diff --git a/projects/firefox/mozconfig-windows-i686 b/projects/firefox/mozconfig-windows-i686 index 3708dd7..0f267a5 100644 --- a/projects/firefox/mozconfig-windows-i686 +++ b/projects/firefox/mozconfig-windows-i686 @@ -23,6 +23,7 @@ export MOZILLA_OFFICIAL=1 ac_add_options --disable-debug ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-strip ac_add_options --enable-official-branding diff --git a/projects/firefox/mozconfig-windows-x86_64 b/projects/firefox/mozconfig-windows-x86_64 index 52956e2..d1b0793 100644 --- a/projects/firefox/mozconfig-windows-x86_64 +++ b/projects/firefox/mozconfig-windows-x86_64 @@ -23,6 +23,7 @@ export MOZILLA_OFFICIAL=1 ac_add_options --disable-debug ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-strip ac_add_options --enable-official-branding diff --git a/projects/geckoview/mozconfig-android-aarch64 b/projects/geckoview/mozconfig-android-aarch64 index 5839477..4084714 100644 --- a/projects/geckoview/mozconfig-android-aarch64 +++ b/projects/geckoview/mozconfig-android-aarch64 @@ -7,6 +7,7 @@ CXX="clang++" ac_add_options --with-android-min-sdk=21 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android diff --git a/projects/geckoview/mozconfig-android-armv7 b/projects/geckoview/mozconfig-android-armv7 index 2530049..1ac85f7 100644 --- a/projects/geckoview/mozconfig-android-armv7 +++ b/projects/geckoview/mozconfig-android-armv7 @@ -7,6 +7,7 @@ CXX="clang++" ac_add_options --with-android-min-sdk=16 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android diff --git a/projects/geckoview/mozconfig-android-x86 b/projects/geckoview/mozconfig-android-x86 index 160f95f..03de28b 100644 --- a/projects/geckoview/mozconfig-android-x86 +++ b/projects/geckoview/mozconfig-android-x86 @@ -7,6 +7,7 @@ CXX="clang++" ac_add_options --with-android-min-sdk=16 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android diff --git a/projects/geckoview/mozconfig-android-x86_64 b/projects/geckoview/mozconfig-android-x86_64 index 5ca74e3..5ba86cf 100644 --- a/projects/geckoview/mozconfig-android-x86_64 +++ b/projects/geckoview/mozconfig-android-x86_64 @@ -7,6 +7,7 @@ CXX="clang++" ac_add_options --with-android-min-sdk=21 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android

1 0

[tor-browser/tor-browser-83.0-10.5-1] squash! TB3: Tor Browser's official .mozconfigs.
by gk＠torproject.org 01 Dec '20

01 Dec '20

commit cc3f3dc643124975e0c298363542d26a52e45cba Author: Georg Koppen <gk(a)torproject.org> Date: Mon Nov 30 07:54:38 2020 +0000 squash! TB3: Tor Browser's official .mozconfigs. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files --- .mozconfig | 1 + .mozconfig-android | 1 + .mozconfig-asan | 1 + .mozconfig-mac | 1 + .mozconfig-mingw | 1 + 5 files changed, 5 insertions(+) diff --git a/.mozconfig b/.mozconfig index d71c858844e3..c50c57d410de 100755 --- a/.mozconfig +++ b/.mozconfig @@ -14,6 +14,7 @@ mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/.mozconfig-android b/.mozconfig-android index 1b5e3f3178b7..50015ec615ef 100755 --- a/.mozconfig-android +++ b/.mozconfig-android @@ -3,6 +3,7 @@ mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Android diff --git a/.mozconfig-asan b/.mozconfig-asan index ca05fb12eedb..e42ff6c86bc5 100644 --- a/.mozconfig-asan +++ b/.mozconfig-asan @@ -22,6 +22,7 @@ ac_add_options --disable-jemalloc ac_add_options --disable-elf-hack ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/.mozconfig-mac b/.mozconfig-mac index 9be7751f8241..5b4624ef1f67 100644 --- a/.mozconfig-mac +++ b/.mozconfig-mac @@ -38,6 +38,7 @@ ac_add_options --enable-application=browser ac_add_options --enable-strip ac_add_options --enable-official-branding ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --disable-debug ac_add_options --enable-tor-browser-data-outside-app-dir diff --git a/.mozconfig-mingw b/.mozconfig-mingw index 29c58d8fdab2..ce6ace1dad67 100644 --- a/.mozconfig-mingw +++ b/.mozconfig-mingw @@ -10,6 +10,7 @@ export MOZILLA_OFFICIAL=1 ac_add_options --disable-debug ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-strip ac_add_options --enable-official-branding

1 0

[tor-browser/tor-browser-78.5.0esr-10.5-1] squash! TB3: Tor Browser's official .mozconfigs.
by sysrqb＠torproject.org 01 Dec '20

01 Dec '20

commit 7a73628afb1c48d48e1b272382f4a51728ef00aa Author: Georg Koppen <gk(a)torproject.org> Date: Mon Nov 30 07:54:38 2020 +0000 squash! TB3: Tor Browser's official .mozconfigs. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files --- .mozconfig | 1 + .mozconfig-android | 1 + .mozconfig-asan | 1 + .mozconfig-mac | 1 + .mozconfig-mingw | 1 + 5 files changed, 5 insertions(+) diff --git a/.mozconfig b/.mozconfig index d71c858844e3..c50c57d410de 100755 --- a/.mozconfig +++ b/.mozconfig @@ -14,6 +14,7 @@ mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/.mozconfig-android b/.mozconfig-android index 1b5e3f3178b7..50015ec615ef 100755 --- a/.mozconfig-android +++ b/.mozconfig-android @@ -3,6 +3,7 @@ mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Android diff --git a/.mozconfig-asan b/.mozconfig-asan index a1c4e467cf1a..8bee813bfee8 100644 --- a/.mozconfig-asan +++ b/.mozconfig-asan @@ -23,6 +23,7 @@ ac_add_options --disable-elf-hack ac_add_options --with-clang-path=/var/tmp/dist/clang/bin/clang ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-official-branding # Let's support GTK3 for ESR60 diff --git a/.mozconfig-mac b/.mozconfig-mac index 9be7751f8241..5b4624ef1f67 100644 --- a/.mozconfig-mac +++ b/.mozconfig-mac @@ -38,6 +38,7 @@ ac_add_options --enable-application=browser ac_add_options --enable-strip ac_add_options --enable-official-branding ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --disable-debug ac_add_options --enable-tor-browser-data-outside-app-dir diff --git a/.mozconfig-mingw b/.mozconfig-mingw index 29c58d8fdab2..ce6ace1dad67 100644 --- a/.mozconfig-mingw +++ b/.mozconfig-mingw @@ -10,6 +10,7 @@ export MOZILLA_OFFICIAL=1 ac_add_options --disable-debug ac_add_options --enable-optimize +ac_add_options --enable-rust-simd ac_add_options --enable-strip ac_add_options --enable-official-branding

1 0