tbb-commits

tbb-commits@lists.torproject.org

September 2018

2 participants
92 discussions

[tor-browser/tor-browser-60.2.0esr-8.0-1] fixup! squash! Bug 26961: New user onboarding.
by gk＠torproject.org 02 Sep '18

02 Sep '18

commit 839cc4bd054821fe7e4c093f0a05986b83491985 Author: Georg Koppen <gk(a)torproject.org> Date: Sat Sep 1 20:20:51 2018 +0000 fixup! squash! Bug 26961: New user onboarding. Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead. --- browser/extensions/onboarding/content/onboarding.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/extensions/onboarding/content/onboarding.js b/browser/extensions/onboarding/content/onboarding.js index dd776b3edf93..9d03a6fc82d8 100644 --- a/browser/extensions/onboarding/content/onboarding.js +++ b/browser/extensions/onboarding/content/onboarding.js @@ -23,8 +23,8 @@ const BRAND_SHORT_NAME = Services.strings const PROMPT_COUNT_PREF = "browser.onboarding.notification.prompt-count"; const NOTIFICATION_FINISHED_PREF = "browser.onboarding.notification.finished"; const ONBOARDING_DIALOG_ID = "onboarding-overlay-dialog"; -const ONBOARDING_MIN_WIDTH_PX = 960; -const SPEECH_BUBBLE_MIN_WIDTH_PX = 960; +const ONBOARDING_MIN_WIDTH_PX = 200; +const SPEECH_BUBBLE_MIN_WIDTH_PX = 200; const SPEECH_BUBBLE_NEWTOUR_STRING_ID = "onboarding.overlay-icon-tooltip2"; const SPEECH_BUBBLE_UPDATETOUR_STRING_ID = "onboarding.overlay-icon-tooltip-updated2"; const ICON_STATE_WATERMARK = "watermark";

1 0

[tor-browser/tor-browser-60.2.0esr-8.0-1] fixup! Bug 26961: New user onboarding.
by gk＠torproject.org 02 Sep '18

02 Sep '18

commit 8b50d3f2f1bb5ce04ebf3a91ff701059fedb2da2 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Sat Sep 1 12:00:35 2018 -0700 fixup! Bug 26961: New user onboarding. --- browser/extensions/onboarding/content/onboarding.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/browser/extensions/onboarding/content/onboarding.js b/browser/extensions/onboarding/content/onboarding.js index 1f46abdb722d..4212e305a505 100644 --- a/browser/extensions/onboarding/content/onboarding.js +++ b/browser/extensions/onboarding/content/onboarding.js @@ -23,8 +23,8 @@ const BRAND_SHORT_NAME = Services.strings const PROMPT_COUNT_PREF = "browser.onboarding.notification.prompt-count"; const NOTIFICATION_FINISHED_PREF = "browser.onboarding.notification.finished"; const ONBOARDING_DIALOG_ID = "onboarding-overlay-dialog"; -const ONBOARDING_MIN_WIDTH_PX = 960; -const SPEECH_BUBBLE_MIN_WIDTH_PX = 960; +const ONBOARDING_MIN_WIDTH_PX = 200; +const SPEECH_BUBBLE_MIN_WIDTH_PX = 200; const SPEECH_BUBBLE_NEWTOUR_STRING_ID = "onboarding.overlay-icon-tooltip2"; const SPEECH_BUBBLE_UPDATETOUR_STRING_ID = "onboarding.overlay-icon-tooltip-updated2"; const ICON_STATE_WATERMARK = "watermark"; @@ -629,6 +629,7 @@ class Onboarding { tour_type: this._tourType, }); + this._resizeUI(); this._window.addEventListener("beforeunload", this); this._window.addEventListener("unload", this); this._window.addEventListener("resize", this); @@ -642,7 +643,7 @@ class Onboarding { } _resizeUI() { - this._windowWidth = this._window.document.body.getBoundingClientRect().width; + this._windowWidth = this._window.innerWidth; if (this._windowWidth < ONBOARDING_MIN_WIDTH_PX) { // Don't show the overlay UI before we get to a better, responsive design. this.destroy();

1 0