- tbb-commits - lists.torproject.org

[tor-browser-build/master] Use whitespace-safe loops over filenames in the webrtc build.
by gk＠torproject.org 07 Dec '18

07 Dec '18

commit d8db312e4527c694e8f906a5e8926d0dc0c37179 Author: David Fifield <david(a)bamsoftware.com> Date: Thu Dec 6 07:55:25 2018 +0000 Use whitespace-safe loops over filenames in the webrtc build. --- projects/webrtc/build | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/projects/webrtc/build b/projects/webrtc/build index 5a6cece..a1abd92 100644 --- a/projects/webrtc/build +++ b/projects/webrtc/build @@ -138,7 +138,8 @@ ninja -C out/Release webrtc field_trial metrics_default pc_test_utils # like that, not necessarily of the target architecture, and anyway are not # needed. # https://bugs.torproject.org/22832 -[% IF c("var/osx") %]ZERO_AR_DATE=1 [% END %]"$AR" crs libwebrtc-magic.a $(find out/Release/obj -name '*.o' | sort) +find out/Release/obj -name '*.o' -print0 | sort -z \ + | [% IF c("var/osx") %]ZERO_AR_DATE=1 [% END %] xargs -0 -- "$AR" crs libwebrtc-magic.a mkdir -p $distdir cd $distdir @@ -146,9 +147,9 @@ mkdir -p include lib cp -f $builddir/libwebrtc-magic.a [% c("var/webrtc/lib_path") %] INCLUDE_DIR="$PWD/include" cd $builddir -for h in $(find webrtc/ -type f -name '*.h'); +find webrtc/ -type f -name '*.h' -print0 | while IFS= read -r -d '' h; do - mkdir -p "$INCLUDE_DIR/$(dirname $h)" + mkdir -p "$INCLUDE_DIR/$(dirname "$h")" cp -f "$h" "$INCLUDE_DIR/$h" done

1 0

[tor-browser-build/master] Bug 28775: Add mercurial in tbb-build ansible role
by gk＠torproject.org 07 Dec '18

07 Dec '18

commit ea1fc73e70e73d6b930c99fdfe5a729579613002 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri Dec 7 11:41:25 2018 +0100 Bug 28775: Add mercurial in tbb-build ansible role With #26843 we now require mercurial to be installed, so it should be installed by the tbb-build ansible role. --- tools/ansible/roles/tbb-builder/tasks/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ansible/roles/tbb-builder/tasks/main.yml b/tools/ansible/roles/tbb-builder/tasks/main.yml index f27c6cf..4e84709 100644 --- a/tools/ansible/roles/tbb-builder/tasks/main.yml +++ b/tools/ansible/roles/tbb-builder/tasks/main.yml @@ -22,6 +22,7 @@ - libgtk2.0-dev - curl - runc + - mercurial - name: Install dependencies for update_responses script apt:

1 0

[tor-browser-build/master] Release preparations for 8.5a6
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit 76243271b0f02b0a965a0294ef8242c787bfc668 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Dec 6 22:31:40 2018 +0000 Release preparations for 8.5a6 Changelog update and versions bump --- projects/firefox-langpacks/config | 2 +- projects/firefox/config | 4 ++-- .../tor-browser/Bundle-Data/Docs/ChangeLog.txt | 24 ++++++++++++++++++++++ projects/torbutton/config | 2 +- rbm.conf | 5 +++-- 5 files changed, 31 insertions(+), 6 deletions(-) diff --git a/projects/firefox-langpacks/config b/projects/firefox-langpacks/config index 4e42939..04cd7dd 100644 --- a/projects/firefox-langpacks/config +++ b/projects/firefox-langpacks/config @@ -4,7 +4,7 @@ filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/buil var: ff_version: '[% pc("firefox", "var/firefox_version") %]' - ff_build: build1 + ff_build: build2 ff_arch: linux-i686 input_filename: 'dl-langpack-[% c("var/ff_arch") %]-[% c("version") %]' diff --git a/projects/firefox/config b/projects/firefox/config index 7ffaf43..639d504 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -1,14 +1,14 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'firefox-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build2' +git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build1' tag_gpg_id: 1 git_url: https://git.torproject.org/tor-browser.git git_submodule: 1 gpg_keyring: torbutton.gpg var: - firefox_platform_version: 60.3.0 + firefox_platform_version: 60.4.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' torbrowser_branch: 8.5 torbrowser_update_channel: alpha diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 5c3732b..54645e8 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,27 @@ +Tor Browser 8.5a6 -- December 11 2018 + * All Platforms + * Update Firefox to 60.4.0esr + * Update OpenSSL to 1.0.2q + * Update Torbutton to 2.1.3 + * Bug 28540: Use new text for 2018 donation banner + * Bug 27290: Remove WebGL pref for min capability mode + * Bug 28075: Tone down missing SOCKS credential warning + * Bug 28747: Remove NoScript (XPCOM) related unused code + * Translations update + * Bug 28608: Disable background HTTP response throttling + * Bug 28695: Set default security.pki.name_matching_mode to enforce (3) + * Bug 27290: Remove WebGL pref for min capability mode + * Bug 27919: Backport SSL status API + * Windows + * Bug 28740: Adapt Windows navigator.platform value on 64-bit systems + * Android + * Bug 26843: Multi-locale support for Tor Browser on Android + * Build System + * Android + * Bug 25164: Add .apk to our sha256sums unsigned build file + * Bug 28696: Make path to Gradle dependencies reproducible + * Bug 28697: Use pregenerated keystore and fix timestamp issues + Tor Browser 8.5a5 -- December 3 2018 * All Platforms * Update Torbutton to 2.1.2 diff --git a/projects/torbutton/config b/projects/torbutton/config index 2e48f31..0fff877 100644 --- a/projects/torbutton/config +++ b/projects/torbutton/config @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 2.1.2 +version: 2.1.3 git_url: https://git.torproject.org/torbutton.git git_hash: '[% c("version") %]' gpg_keyring: torbutton.gpg diff --git a/rbm.conf b/rbm.conf index f64a80b..a397752 100644 --- a/rbm.conf +++ b/rbm.conf @@ -15,10 +15,11 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '8.5a5' - torbrowser_build: 'build2' + torbrowser_version: '8.5a6' + torbrowser_build: 'build1' torbrowser_incremental_from: - 8.5a4 + - 8.5a5 project_name: tor-browser multi_lingual: 0 build_mar: 1

1 0

[tor-browser-build/master] Bug 28697: No need to specify the architecture for using Buster
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit 0a2cc62f08063cc0c91b1db57e87505c954349a9 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Dec 6 22:06:03 2018 +0000 Bug 28697: No need to specify the architecture for using Buster --- projects/tor-browser/config | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/tor-browser/config b/projects/tor-browser/config index 3a7f035..6199954 100644 --- a/projects/tor-browser/config +++ b/projects/tor-browser/config @@ -51,7 +51,6 @@ targets: # leads to a stalled build. Work around this by switching to Buster. container: suite: buster - arch: amd64 input_files: - project: container-image

1 0

[tor-browser/tor-browser-60.3.0esr-8.5-1] Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit a3cbc068df86e03a6420bc863be2793e35078fa3 Author: Chris Peterson <cpeterson(a)mozilla.com> Date: Mon Jul 2 11:02:23 2018 -0700 Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv navigator.platform returns "Win64" in 64-bit Firefox and IE, but "Win32" in 64-bit Chrome and Edge. "Win32" appears to be the de facto platform value for Windows. This change doesn't hide the OS architecture from web content because navigator.userAgent still mentions "Win64; x64" in 64-bit Firefox, Chrome, Edge, and IE. MozReview-Commit-ID: CplYnGDQgTe --HG-- extra : rebase_source : c00a1a7462ea91d44700dd0581c88c1c4cad2346 extra : source : 1976c327f251702be255a9d0769121c6bc5303a1 This fixes our bug 28740. --- .../components/resistfingerprinting/test/browser/browser_navigator.js | 2 +- dom/base/Navigator.cpp | 4 +--- toolkit/components/resistfingerprinting/nsRFPService.h | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/browser/components/resistfingerprinting/test/browser/browser_navigator.js b/browser/components/resistfingerprinting/test/browser/browser_navigator.js index e0aaf6fb27fe..3736fcd33ce5 100644 --- a/browser/components/resistfingerprinting/test/browser/browser_navigator.js +++ b/browser/components/resistfingerprinting/test/browser/browser_navigator.js @@ -24,7 +24,7 @@ const SPOOFED_APPVERSION = { }; const SPOOFED_PLATFORM = { linux: "Linux x86_64", - win: "Win64", + win: "Win32", macosx: "MacIntel", android: "Linux armv7l", other: "Linux x86_64", diff --git a/dom/base/Navigator.cpp b/dom/base/Navigator.cpp index 33563ad65ccb..55d1f7a0474b 100644 --- a/dom/base/Navigator.cpp +++ b/dom/base/Navigator.cpp @@ -1653,9 +1653,7 @@ Navigator::GetPlatform(nsAString& aPlatform, bool aUsePrefOverriddenValue) // Sorry for the #if platform ugliness, but Communicator is likewise // hardcoded and we are seeking backward compatibility here (bug 47080). -#if defined(_WIN64) - aPlatform.AssignLiteral("Win64"); -#elif defined(WIN32) +#if defined(WIN32) aPlatform.AssignLiteral("Win32"); #elif defined(XP_MACOSX) && defined(__ppc__) aPlatform.AssignLiteral("MacPPC"); diff --git a/toolkit/components/resistfingerprinting/nsRFPService.h b/toolkit/components/resistfingerprinting/nsRFPService.h index da79da8de948..4ed0c1d4cfaf 100644 --- a/toolkit/components/resistfingerprinting/nsRFPService.h +++ b/toolkit/components/resistfingerprinting/nsRFPService.h @@ -25,7 +25,7 @@ #define SPOOFED_UA_OS "Windows NT 6.1; Win64; x64" #define SPOOFED_APPVERSION "5.0 (Windows)" #define SPOOFED_OSCPU "Windows NT 6.1; Win64; x64" -#define SPOOFED_PLATFORM "Win64" +#define SPOOFED_PLATFORM "Win32" #elif defined(XP_MACOSX) #define SPOOFED_UA_OS "Macintosh; Intel Mac OS X 10.13" #define SPOOFED_APPVERSION "5.0 (Macintosh)"

1 0

[tor-browser-build/master] Bug 25164: Add .apk to our unsigned sha256sums file
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit 3d7c32b67b25d869d94ec8f23da82e7558fb9993 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Dec 6 19:16:16 2018 +0000 Bug 25164: Add .apk to our unsigned sha256sums file --- projects/release/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/release/build b/projects/release/build index e7c7410..cf190a6 100644 --- a/projects/release/build +++ b/projects/release/build @@ -32,7 +32,7 @@ RewriteRule ^sha256sums.txt.asc$ sha256sums-unsigned-build.txt.asc RewriteRule ^sha256sums.incrementals.txt$ sha256sums-unsigned-build.incrementals.txt RewriteRule ^sha256sums.incrementals.txt.asc$ sha256sums-unsigned-build.incrementals.txt.asc EOF -sha256sum $(ls -1 *.exe *.tar.xz *.dmg *.mar *.zip *.tar.gz | grep -v '\.incremental\.mar$' | sort) > sha256sums-unsigned-build.txt +sha256sum $(ls -1 *.exe *.tar.xz *.dmg *.mar *.zip *.tar.gz *.apk | grep -v '\.incremental\.mar$' | sort) > sha256sums-unsigned-build.txt [% IF c("var/sign_build") -%] gpg -abs [% c("var/sign_build_gpg_opts") %] sha256sums-unsigned-build.txt [% END -%]

1 0

[tor-browser-build/master] Bug 28697: Use pre-generated android keystore and fix timestamps on zipped archives
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit ea1d0b24448f0365b9c8ff60a6ab2c4a130ec279 Author: sisbell <shane.isbell(a)gmail.com> Date: Tue Dec 4 12:20:40 2018 -0800 Bug 28697: Use pre-generated android keystore and fix timestamps on zipped archives --- projects/tor-browser/android-qa.keystore | Bin 0 -> 2138 bytes projects/tor-browser/build.android | 6 +++--- projects/tor-browser/config | 4 ++++ projects/tor-browser/how-to-generate-keystore.txt | 3 +++ 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/projects/tor-browser/android-qa.keystore b/projects/tor-browser/android-qa.keystore new file mode 100644 index 0000000..90cfaed Binary files /dev/null and b/projects/tor-browser/android-qa.keystore differ diff --git a/projects/tor-browser/build.android b/projects/tor-browser/build.android index b623466..d56d4b5 100644 --- a/projects/tor-browser/build.android +++ b/projects/tor-browser/build.android @@ -9,10 +9,10 @@ cd /var/tmp/build mv $rootdir/[% c('input_files_by_name/https-everywhere') %] $ext_dir/https-everywhere-eff(a)eff.org.xpi mv $rootdir/[% c('input_files_by_name/noscript') %] $ext_dir/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi +[% c("var/touch") %] $ext_dir $ext_dir/* zip -d $apk META-INF/\* -zip -r $apk $ext_dir +zip -r -X $apk $ext_dir # Sign a QA build. This apk is not a debug version and doesn't contain a debug flag in the manifest -keytool -genkey -v -keystore qa.keystore -storepass android -alias androidqakey -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=Android Tor QA,O=Tor,C=US" -jarsigner -verbose -digestalg SHA1 -sigalg MD5withRSA -keystore qa.keystore -signedjar $qa_apk $apk androidqakey -storepass android -keypass android +[% c("var/faketime") %] jarsigner -verbose -digestalg SHA1 -sigalg MD5withRSA -keystore $rootdir/android-qa.keystore -signedjar $qa_apk $apk androidqakey -storepass android -keypass android diff --git a/projects/tor-browser/config b/projects/tor-browser/config index 43db189..2b937bd 100644 --- a/projects/tor-browser/config +++ b/projects/tor-browser/config @@ -46,6 +46,7 @@ targets: var: arch_deps: - openjdk-8-jdk + - faketime input_files: - project: container-image @@ -108,3 +109,6 @@ input_files: URL: https://files.pythonhosted.org/packages/7e/9b/f99171190f04cd23768547dd34533… sha256sum: 675c35ee0e1677db9e80d2f48d8a7ff2cf38e6207e8cd5e2a2c6d126db025854 enable: '[% c("var/windows") %]' + # To generate a new keystore, see how-to-generate-keystore.txt + - filename: android-qa.keystore + enable: '[% c("var/android") %]' diff --git a/projects/tor-browser/how-to-generate-keystore.txt b/projects/tor-browser/how-to-generate-keystore.txt new file mode 100644 index 0000000..3dbe443 --- /dev/null +++ b/projects/tor-browser/how-to-generate-keystore.txt @@ -0,0 +1,3 @@ +To generate a new keystore, type the following command: + +keytool -genkey -v -keystore android-qa.keystore -storepass android -alias androidqakey -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=Android Tor QA,O=Tor,C=US"

1 0

[tor-browser-build/master] Bug 28750: Switch to Buster for avoiding faketime issues
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit 60163914e4f9418709bfe5b8fdc946fb56ca6e07 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Dec 6 19:13:53 2018 +0000 Bug 28750: Switch to Buster for avoiding faketime issues If we are using faketime on Stretch when signing our debug .apk the build freezes for unknown reasons on some machines. Switching to Buster avoids that. --- projects/tor-browser/config | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/projects/tor-browser/config b/projects/tor-browser/config index 2b937bd..3a7f035 100644 --- a/projects/tor-browser/config +++ b/projects/tor-browser/config @@ -47,6 +47,11 @@ targets: arch_deps: - openjdk-8-jdk - faketime + # On some machines using faketime with Stretch to make the debug signature + # leads to a stalled build. Work around this by switching to Buster. + container: + suite: buster + arch: amd64 input_files: - project: container-image

1 0

[tor-browser-build/master] Bug 26843: Get l10n-changesets.json from tor-browser.git
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit bad46e532fa614ffdd3ed0e21f4b8fae3ba7793d Author: Nicolas Vigier <boklm(a)torproject.org> Date: Thu Dec 6 14:34:41 2018 +0000 Bug 26843: Get l10n-changesets.json from tor-browser.git The json file used by projects/firefox-locale-bundle is only available from https://product-details.mozilla.org/ after a build has been shipped, which is too late for us. However, it is also available from the firefox sources tree, so we can get it from our tor-browser.git clone instead. The format of this json file is a little different, so we also need to adapt the get_hg_hash script. --- projects/firefox-locale-bundle/build | 6 +++++- projects/firefox-locale-bundle/config | 4 ---- projects/firefox-locale-bundle/get_hg_hash | 2 +- projects/firefox/config | 2 ++ 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/projects/firefox-locale-bundle/build b/projects/firefox-locale-bundle/build index 3fec48e..7000300 100644 --- a/projects/firefox-locale-bundle/build +++ b/projects/firefox-locale-bundle/build @@ -2,6 +2,10 @@ [% c("var/set_default_env") -%] +cat > l10n-changesets.json << 'EOF_CHANGESETS' +[% pc('firefox', 'var/l10n-changesets.json') %] +EOF_CHANGESETS + clone_dir='[% c("basedir") %]/hg_clones/[% project %]' mkdir -p "$clone_dir" cd "$clone_dir" @@ -19,7 +23,7 @@ tmpdir=$(mktemp -d) cd [% lang %] fi hg_hash=$([% c("basedir") %]/projects/firefox-locale-bundle/get_hg_hash \ - $rootdir/[% c('input_files_by_name/firefox_json') %] \ + $rootdir/l10n-changesets.json \ [% lang %]) [% c("hg") %] archive -r "$hg_hash" -t files "$tmpdir"/[% lang %] cd .. diff --git a/projects/firefox-locale-bundle/config b/projects/firefox-locale-bundle/config index 13c5fb8..2f4997f 100644 --- a/projects/firefox-locale-bundle/config +++ b/projects/firefox-locale-bundle/config @@ -6,7 +6,3 @@ var: use_container: 0 ff_version: '[% pc("firefox", "var/firefox_version") %]' ff_build: build1 - -input_files: - - name: firefox_json - URL: 'https://product-details.mozilla.org/1.0/l10n/Firefox-[% c("var/ff_version") %]-[% c("var/ff_build") %].json' diff --git a/projects/firefox-locale-bundle/get_hg_hash b/projects/firefox-locale-bundle/get_hg_hash index 0531113..9b2b5bd 100755 --- a/projects/firefox-locale-bundle/get_hg_hash +++ b/projects/firefox-locale-bundle/get_hg_hash @@ -16,6 +16,6 @@ exit_error("Error reading $file", 2) unless defined $json_text; my $data = decode_json($json_text); -my $changeset = $data->{locales}{$locale}{changeset}; +my $changeset = $data->{$locale}{revision}; exit_error("Can't find locale $locale in $file", 3) unless $changeset; print "$changeset\n"; diff --git a/projects/firefox/config b/projects/firefox/config index 314326f..7ffaf43 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -24,6 +24,8 @@ var: use_container: 1 # this should be updated when the list of gradle dependencies is changed gradle_dependencies_version: 3 + # used by projects/firefox-locale-bundle + l10n-changesets.json: '[% exec("cat mobile/locales/l10n-changesets.json") %]' targets: release:

1 0

[torbutton/master] Fold in maint-2.0 CHANGELOG
by gk＠torproject.org 06 Dec '18

06 Dec '18

commit 7f3f89164b409736f4eb70019005f5f8960e906c Author: Georg Koppen <gk(a)torproject.org> Date: Thu Dec 6 14:51:17 2018 +0000 Fold in maint-2.0 CHANGELOG --- src/CHANGELOG | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/CHANGELOG b/src/CHANGELOG index 0db59514..0abd10b5 100644 --- a/src/CHANGELOG +++ b/src/CHANGELOG @@ -15,6 +15,12 @@ * Bug 28082: Add locales cs, el, hu, ka * Translations update +2.0.8 + * Bug 23925+27959: Donation banner for year end 2018 campaign + * Bug 24172: Donation banner clobbers Tor Browser version string + * Bug 27760: Use new NoScript API for IPC and fix about:blank issue + * Translations update + 2.1 * Bug 27175: Add pref to allow users to persist custom noscript settings * Bug 27760: Use new NoScript API for IPC and fix about:blank issue

1 0