- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
by Pier Angelo Vendrame (＠pierov) 21 Aug '23

21 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 44b0ceba by Pier Angelo Vendrame at 2023-08-21T14:47:47+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42031: Fixed some requests failing because of a type error Some requests (e.g., uBlock Origin filter updates) failed because they the TorDomainIsolator tried to access the browser from their channels. - - - - - 1 changed file: - toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs Changes: ===================================== toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs ===================================== @@ -453,7 +453,7 @@ class TorDomainIsolatorImpl { */ #getBrowserForChannel(channel) { const browsers = - channel.loadInfo.browsingContext?.topChromeWindow?.gBrowser.browsers; + channel.loadInfo.browsingContext?.topChromeWindow?.gBrowser?.browsers; if (!browsers || !channel.loadInfo.browsingContext?.browserId) { return null; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44b0ceb… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44b0ceb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] 3 commits: fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 29c0222b by hackademix at 2023-08-21T14:48:07+02:00 fixup! Bug 40926: Implemented the New Identity feature Remove useless and confusing EXPORTED_SYMBOLS usage in ScriptLoader inclusion. - - - - - a2098747 by hackademix at 2023-08-21T14:48:08+02:00 fixup! Bug 40926: Implemented the New Identity feature Remove redundant "Closing tabs" logging. - - - - - 0537009f by hackademix at 2023-08-21T14:48:08+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 41833: Reload extensions on new identity - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -1,7 +1,5 @@ "use strict"; -var EXPORTED_SYMBOLS = ["NewIdentityButton"]; - /* globals CustomizableUI Services gFindBarInitialized gFindBar OpenBrowserWindow PrivateBrowsingUtils XPCOMUtils */ @@ -144,6 +142,7 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { this.clearStorage(); this.clearPreferencesAndPermissions(); await this.clearData(); + await this.reloadAddons(); this.clearConnections(); this.clearPrivateSession(); } @@ -160,7 +159,6 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { } closeTabs() { - logger.info("Closing tabs"); if ( !Services.prefs.getBoolPref("browser.new_identity.close_newnym", true) ) { @@ -414,6 +412,15 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { Services.obs.notifyObservers(null, "last-pb-context-exited"); } + async reloadAddons() { + logger.info("Reloading add-ons to clear their temporary state."); + // Reload all active extensions except search engines, which would throw. + const addons = ( + await AddonManager.getAddonsByTypes(["extension"]) + ).filter(a => a.isActive && !a.id.endsWith("@search.mozilla.org")); + await Promise.all(addons.map(a => a.reload())); + } + // Broadcast as a hook to clear other data broadcast() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/64c5d9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/64c5d9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Deleted branch mullvad-browser-115.1.0esr-13.0-1
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 deleted branch mullvad-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch mullvad-browser-115.1.0esr-13.0-1
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 pushed new branch mullvad-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/mullvad-b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 64c5d915 by hackademix at 2023-08-21T14:30:10+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 41833: Reload extensions on new identity - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -144,6 +144,7 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { this.clearStorage(); this.clearPreferencesAndPermissions(); await this.clearData(); + await this.reloadAddons(); this.clearConnections(); this.clearPrivateSession(); } @@ -414,6 +415,15 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { Services.obs.notifyObservers(null, "last-pb-context-exited"); } + async reloadAddons() { + logger.info("Reloading add-ons to clear their temporary state."); + // Reload all active extensions except search engines, which would throw. + const addons = ( + await AddonManager.getAddonsByTypes(["extension"]) + ).filter(a => a.isActive && !a.id.endsWith("@search.mozilla.org")); + await Promise.all(addons.map(a => a.reload())); + } + // Broadcast as a hook to clear other data broadcast() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/64c5d91… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/64c5d91… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] 3 commits: fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 4459daa5 by hackademix at 2023-08-21T11:07:43+02:00 fixup! Bug 40926: Implemented the New Identity feature Remove useless and confusing EXPORTED_SYMBOLS usage in ScriptLoader inclusion. - - - - - b6f6eb79 by hackademix at 2023-08-21T11:07:44+02:00 fixup! Bug 40926: Implemented the New Identity feature Remove redundant "Closing tabs" logging. - - - - - 80c57ed8 by hackademix at 2023-08-21T11:08:16+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 41833: Reload extensions on new identity - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -1,7 +1,5 @@ "use strict"; -var EXPORTED_SYMBOLS = ["NewIdentityButton"]; - /* globals CustomizableUI Services gFindBarInitialized gFindBar OpenBrowserWindow PrivateBrowsingUtils XPCOMUtils */ @@ -144,6 +142,7 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { this.clearStorage(); this.clearPreferencesAndPermissions(); await this.clearData(); + await this.reloadAddons(); this.clearConnections(); this.clearPrivateSession(); } @@ -160,7 +159,6 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { } closeTabs() { - logger.info("Closing tabs"); if ( !Services.prefs.getBoolPref("browser.new_identity.close_newnym", true) ) { @@ -414,6 +412,15 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { Services.obs.notifyObservers(null, "last-pb-context-exited"); } + async reloadAddons() { + logger.info("Reloading add-ons to clear their temporary state."); + // Reload all active extensions except search engines, which would throw. + const addons = ( + await AddonManager.getAddonsByTypes(["extension"]) + ).filter(a => a.isActive && !a.id.endsWith("@search.mozilla.org")); + await Promise.all(addons.map(a => a.reload())); + } + // Broadcast as a hook to clear other data broadcast() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/39d95c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/39d95c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40921: staticiforme-prepare-cdn-dist-upload uses hardcoded torbrowser path...
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 914a95c5 by Richard Pospesel at 2023-08-17T20:16:28+00:00 Bug 40921: staticiforme-prepare-cdn-dist-upload uses hardcoded torbrowser path for .htacess file generation - - - - - 1 changed file: - tools/signing/staticiforme-prepare-cdn-dist-upload Changes: ===================================== tools/signing/staticiforme-prepare-cdn-dist-upload ===================================== @@ -3,7 +3,7 @@ set -e script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) source "$script_dir/functions" -dist_dir="/srv/dist-master.torproject.org/htdocs/torbrowser/$tbb_version" +dist_dir="/srv/dist-master.torproject.org/htdocs/$SIGNING_PROJECTNAME/$tbb_version" cat > "$dist_dir/.htaccess" << 'EOF' RewriteEngine On RewriteRule ^sha256sums.txt$ sha256sums-unsigned-build.txt View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40576: Remove blanks from fonts.conf.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 305a78c3 by Pier Angelo Vendrame at 2023-08-17T19:52:10+00:00 Bug 40576: Remove blanks from fonts.conf. FontConfig removed the possibility to configure blanks in its configuration in 2015, but we kept it, which caused runtime warnings for years. In 2017, FontConfig removed the support for this feature altogether, so it should be safe to remove this part of the configuration. - - - - - 1 changed file: - projects/browser/Bundle-Data/linux/Data/fontconfig/fonts.conf Changes: ===================================== projects/browser/Bundle-Data/linux/Data/fontconfig/fonts.conf ===================================== @@ -110,72 +110,6 @@ PERFORMANCE OF THIS SOFTWARE. <cachedir prefix="xdg">fontconfig</cachedir> <config> - - <blank> - <int>0x0020</int>  - <int>0x00A0</int>  - <int>0x00AD</int>  - <int>0x034F</int>  - <int>0x0600</int>  - <int>0x0601</int>  - <int>0x0602</int>  - <int>0x0603</int>  - <int>0x06DD</int>  - <int>0x070F</int>  - <int>0x115F</int>  - <int>0x1160</int>  - <int>0x1680</int>  - <int>0x17B4</int>  - <int>0x17B5</int>  - <int>0x180E</int>  - <int>0x2000</int>  - <int>0x2001</int>  - <int>0x2002</int>  - <int>0x2003</int>  - <int>0x2004</int>  - <int>0x2005</int>  - <int>0x2006</int>  - <int>0x2007</int>  - <int>0x2008</int>  - <int>0x2009</int>  - <int>0x200A</int>  - <int>0x200B</int>  - <int>0x200C</int>  - <int>0x200D</int>  - <int>0x200E</int>  - <int>0x200F</int>  - <int>0x2028</int>  - <int>0x2029</int>  - <int>0x202A</int>  - <int>0x202B</int>  - <int>0x202C</int>  - <int>0x202D</int>  - <int>0x202E</int>  - <int>0x202F</int>  - <int>0x205F</int>  - <int>0x2060</int>  - <int>0x2061</int>  - <int>0x2062</int>  - <int>0x2063</int>  - <int>0x206A</int>  - <int>0x206B</int>  - <int>0x206C</int>  - <int>0x206D</int>  - <int>0x206E</int>  - <int>0x206F</int>  - <int>0x2800</int>  - <int>0x3000</int>  - <int>0x3164</int>  - <int>0xFEFF</int>  - <int>0xFFA0</int>  - <int>0xFFF9</int>  - <int>0xFFFA</int>  - <int>0xFFFB</int>  - </blank>  View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40922: Use base-browser.ftl instead of languageNotification.ftl.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: be45d31e by Pier Angelo Vendrame at 2023-08-17T19:39:26+00:00 Bug 40922: Use base-browser.ftl instead of languageNotification.ftl. We have finally renamed the file for Base Browser strings, and moved it to the same branch as other Base Browser string files. So, we needed to change the references to the Fluent file (we have one in Firefox's build file), and then we could drop the references to the basebrowser-newidentity branch, since it is not used anymore. - - - - - 5 changed files: - .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - projects/firefox/build - projects/firefox/config - projects/translation/config Changes: ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md ===================================== @@ -46,7 +46,6 @@ Mullvad Browser Alpha (and Nightly) are on the `main` branch - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-alpha` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/base-browser-fluent/git_hash` : update with `HEAD` commit of project's `basebrowser-newidentityftl` branch - [ ] `steps/mullvad-browser/git_hash` : update with `HEAD` commit of project's `mullvad-browser` branch - [ ] Update common build configs - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -46,7 +46,6 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-alpha` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/base-browser-fluent/git_hash` : update with `HEAD` commit of project's `basebrowser-newidentityftl` branch - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - [ ] Update Android-specific build configs ===================================== projects/firefox/build ===================================== @@ -116,24 +116,13 @@ mkdir "$HOME/.mozbuild" pushd "$rootdir/translation-base-browser" ln -s ja ja-JP-mac for lang in $supported_locales; do - # Please notice that Fluent and DTDs use different directories in - # l10n-central! This is something we have to keep in mind when we will join - # the two branches! + # Fluent + mv $lang/base-browser.ftl "$l10ncentral/$lang/browser/browser/" + # Properties (they use a different directory) mv $lang/* "$l10ncentral/$lang/browser/chrome/browser/" done popd - tar -C "$rootdir" -xf "$rootdir/[% c('input_files_by_name/translation-base-browser-fluent') %]" - pushd "$rootdir/translation-base-browser-fluent" - ln -s ja ja-JP-mac - # TODO: These two sources will be unified eventually; at that point, this link - # will go away, too. - ln -s es es-ES - for lang in $supported_locales; do - mv $lang/languageNotification.ftl "$l10ncentral/$lang/browser/browser/" - done - popd - [% IF c("var/tor-browser") -%] # We will have to keep the torbutton.jar until we stop using dtds, because # if we move them to the browser locale directory, browser.xhtml is not ===================================== projects/firefox/config ===================================== @@ -191,10 +191,6 @@ input_files: name: translation-base-browser pkg_type: base-browser enable: '[% c("var/has_l10n") %]' - - project: translation - name: translation-base-browser-fluent - pkg_type: base-browser-fluent - enable: '[% c("var/has_l10n") %]' - project: translation name: translation-tor-browser pkg_type: tor-browser ===================================== projects/translation/config ===================================== @@ -16,12 +16,6 @@ steps: targets: nightly: git_hash: 'base-browser' - base-browser-fluent: - base-browser-fluent: '[% INCLUDE build %]' - git_hash: 72c0d47f55994b6d68e0239d9edd02d7ae7708ab - targets: - nightly: - git_hash: 'basebrowser-newidentityftl' tor-browser: tor-browser: '[% INCLUDE build %]' git_hash: 2b885b2a6dfeaa046678133755639d6e26485754 @@ -46,7 +40,7 @@ steps: list_updates: list_updates: | [% - FOREACH component = [ 'base-browser', 'base-browser-fluent', 'tor-browser', 'mullvad-browser', 'fenix' ]; + FOREACH component = [ 'base-browser', 'tor-browser', 'mullvad-browser', 'fenix' ]; branch = pc(project, 'git_hash', { step => component, target => [ 'nightly' ] }); commit_hash = exec('git rev-parse ' _ branch, { git_hash => branch }); IF commit_hash == pc(project, "git_hash", { step => component }); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bump the firefox-android version to 115.2.1.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 1ee1b1b5 by Pier Angelo Vendrame at 2023-08-17T18:49:25+00:00 Bump the firefox-android version to 115.2.1. - - - - - 1 changed file: - projects/firefox-android/config Changes: ===================================== projects/firefox-android/config ===================================== @@ -14,9 +14,9 @@ container: use_container: 1 var: - fenix_version: 115.2.0 + fenix_version: 115.2.1 browser_branch: 13.0-1 - browser_build: 5 + browser_build: 1 platform_version: 115.0 variant: Beta # This should be updated when the list of gradle dependencies is changed. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40924: Customize the remoting name.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 1e151f80 by Pier Angelo Vendrame at 2023-08-17T18:15:47+00:00 Bug 40924: Customize the remoting name. Firefox uses the remote name also as GTK's prgname, which is then shown in some UI elements like GNOME's Alt-Tab. We used to customize it with --class and --name on Linux, but these options are lost when restarting the browser after an update. On other platforms it should not have evident consequences. - - - - - 4 changed files: - projects/browser/RelativeLink/start-browser - projects/browser/RelativeLink/start-browser.desktop - projects/firefox/mozconfig - rbm.conf Changes: ===================================== projects/browser/RelativeLink/start-browser ===================================== @@ -365,23 +365,18 @@ cd "${HOME}" if [ "$show_usage" -eq 1 ]; then # Display Firefox help, then our help - [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] \ - --class "[% c('var/Project_Name') %]" --name "[% c('var/Project_Name') %]" --help 2>/dev/null + [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] --help 2>/dev/null print_usage elif [ "$detach" -eq 1 ] ; then - [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] \ - --class "[% c('var/Project_Name') %]" --name "[% c('var/Project_Name') %]" "${@}" > "$logfile" 2>&1 </dev/null & - disown "$!" + [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] "${@}" > "$logfile" 2>&1 </dev/null & + disown "$!" elif [ "$log_output" -eq 1 -a "$show_output" -eq 1 ]; then - [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] \ - --class "[% c('var/Project_Name') %]" --name "[% c('var/Project_Name') %]" "${@}" 2>&1 </dev/null | \ + [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] "${@}" 2>&1 </dev/null | \ tee "$logfile" elif [ "$show_output" -eq 1 ]; then - [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] \ - --class "[% c('var/Project_Name') %]" --name "[% c('var/Project_Name') %]" "${@}" < /dev/null + [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] "${@}" < /dev/null else - [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] \ - --class "[% c('var/Project_Name') %]" --name "[% c('var/Project_Name') %]" "${@}" > "$logfile" 2>&1 </dev/null + [% IF c("var/tor-browser") %]TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD}[% END %] ./[% c('var/exe_name') %] "${@}" > "$logfile" 2>&1 </dev/null fi exit $? ===================================== projects/browser/RelativeLink/start-browser.desktop ===================================== @@ -31,4 +31,4 @@ Categories=Network;WebBrowser;Security; Exec=sh -c '"$(dirname "$*")"/Browser/start-[% c("var/project-name") %] --detach || ([ ! -x "$(dirname "$*")"/Browser/start-[% c("var/project-name") %] ] && "$(dirname "$*")"/start-[% c("var/project-name") %] --detach)' dummy %k X-[% c("var/ProjectName") %]-ExecShell=./Browser/start-[% c("var/project-name") %] --detach Icon=web-browser -StartupWMClass=[% c("var/Project_Name") %] +StartupWMClass=[% c("var/Project_Name_Channel") %] ===================================== projects/firefox/mozconfig ===================================== @@ -74,6 +74,8 @@ ac_add_options --[% IF c("var/updater_enabled") %]enable[% ELSE %]disable[% END mk_add_options MOZ_PARALLEL_BUILD=[% c("num_procs") %] +export MOZ_APP_REMOTINGNAME="[% c('var/Project_Name_Channel') %]" + export MOZ_INCLUDE_SOURCE_INFO=1 export MOZ_SOURCE_REPO="[% c('var/gitlab_project') %]" export MOZ_SOURCE_CHANGESET=[% c("var/git_commit") %] ===================================== rbm.conf ===================================== @@ -107,6 +107,7 @@ var: [% SET step = c("step") -%] [% c(step, { filename => 'f', output_dir => '/out', norec => {} }) %] + Project_Name_Channel: '[% c("var/Project_Name") %] [% c("var/channel") FILTER ucfirst %]' exe_name: firefox locale_ja: ja locales: @@ -230,6 +231,7 @@ targets: var: release: 1 channel: release + Project_Name_Channel: '[% c("var/Project_Name") %]' alpha: var: alpha: 1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! TB3: Tor Browser's official .mozconfigs.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 39d95c67 by Pier Angelo Vendrame at 2023-08-17T16:58:28+00:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 41509: Set the remoting name for dev builds, and add a comment to tell downstream builders that do not use tor-browser-build that they might want to customize it as well. - - - - - 2 changed files: - browser/config/mozconfigs/tor-browser - mozconfig-linux-x86_64-dev Changes: ===================================== browser/config/mozconfigs/tor-browser ===================================== @@ -1,6 +1,12 @@ . $topsrcdir/browser/config/mozconfigs/base-browser mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" +# If building outside tor-browser-build, you might want to customize this value. +# On Linux, it influences the WM_CLASS value, which is shown on GNOME's ALT-TAB, +# for example. +# We customize it in tor-browser-build because we include the channel name, just +# like Firefox does. +# export MOZ_APP_REMOTINGNAME="Tor Browser" ac_add_options --with-relative-data-dir=TorBrowser/Data/Browser # This is not needed with the relative data directory, but it is when you ===================================== mozconfig-linux-x86_64-dev ===================================== @@ -5,6 +5,7 @@ # during development. export MOZILLA_OFFICIAL= +export MOZ_APP_REMOTINGNAME="Tor Browser Dev" ac_add_options --with-branding=browser/branding/tb-nightly ac_add_options --enable-default-toolkit=cairo-gtk3 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/39d95c6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/39d95c6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 4d5efc7c by hackademix at 2023-08-17T16:46:22+00:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -316,6 +316,9 @@ pref("javascript.options.large_arraybuffers", false); // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#41943: lock and revisit after it gets flipped to true in stable Firefox +pref("javascript.options.spectre.disable_for_isolated_content", false, locked); + // Third party stuff pref("privacy.firstparty.isolate", true); // Always enforce first party isolation // tor-browser#40123 and #40308: Disable for now until audit View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d5efc7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d5efc7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40921: staticiforme-prepare-cdn-dist-upload uses hardcoded torbrowser path...
by richard (＠richard) 17 Aug '23

17 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 418eae60 by Richard Pospesel at 2023-08-15T02:28:49+00:00 Bug 40921: staticiforme-prepare-cdn-dist-upload uses hardcoded torbrowser path for .htacess file generation - - - - - 1 changed file: - tools/signing/staticiforme-prepare-cdn-dist-upload Changes: ===================================== tools/signing/staticiforme-prepare-cdn-dist-upload ===================================== @@ -3,7 +3,7 @@ set -e script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) source "$script_dir/functions" -dist_dir="/srv/dist-master.torproject.org/htdocs/torbrowser/$tbb_version" +dist_dir="/srv/dist-master.torproject.org/htdocs/$SIGNING_PROJECTNAME/$tbb_version" cat > "$dist_dir/.htaccess" << 'EOF' RewriteEngine On RewriteRule ^sha256sums.txt$ sha256sums-unsigned-build.txt View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed new tag firefox-android-115.2.1-13.0-1-build1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] 19 commits: Bug 40005: Modify Default toolbar menu
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 6b71815b by Matthew Finkel at 2023-08-16T10:15:20+02:00 Bug 40005: Modify Default toolbar menu - - - - - d9b7ced0 by Alex Catarineu at 2023-08-16T10:20:43+02:00 Bug 40007: Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - 1264670d by Alex Catarineu at 2023-08-16T10:20:44+02:00 Bug 40002: Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 036b857a by Alex Catarineu at 2023-08-16T10:20:45+02:00 Bug 40009: Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - 2607938a by Alex Catarineu at 2023-08-16T10:20:45+02:00 Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 2b037874 by Georg Koppen at 2023-08-16T10:20:45+02:00 Bug 40013: Add option do overwrite timestamp in extension version - - - - - 5e27821b by Alex Catarineu at 2023-08-16T10:22:04+02:00 Bug 40015: Port padlock states for .onion services - - - - - 5c822821 by Matthew Finkel at 2023-08-16T10:27:11+02:00 Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - e1ea75a0 by Matthew Finkel at 2023-08-16T10:27:15+02:00 Bug 40023: Stop PrivateNotificationService - - - - - a52d3674 by Matthew Finkel at 2023-08-16T10:27:15+02:00 Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - d25cf7f7 by Matthew Finkel at 2023-08-16T10:31:34+02:00 Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - bc8a8489 by Matthew Finkel at 2023-08-16T10:31:34+02:00 Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - a7a5dc1e by Georg Koppen at 2023-08-16T10:31:35+02:00 Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 231696a5 by Matthew Finkel at 2023-08-16T10:31:35+02:00 Bug 40185: Use NimbusDisabled - - - - - ea40407c by Matthew Finkel at 2023-08-16T10:31:35+02:00 Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - eaad8b2f by Alex Catarineu at 2023-08-16T10:31:35+02:00 Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - 95ad3c55 by hackademix at 2023-08-16T10:31:35+02:00 Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 8b6b9122 by Dan Ballard at 2023-08-16T10:31:35+02:00 Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - 4868781f by Dan Ballard at 2023-08-16T10:31:36+02:00 Bug 41972: Disable mozilla onboarding - - - - - 30 changed files: - .gitignore - android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt - android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt - android-components/components/browser/icons/src/main/java/mozilla/components/browser/icons/loader/HttpIconLoader.kt - android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt - android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt - android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/SiteSecurityIconView.kt - android-components/components/browser/toolbar/src/main/res/drawable/mozac_ic_site_security.xml - android-components/components/browser/toolbar/src/main/res/values/attrs_browser_toolbar.xml - android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt - android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/Settings.kt - android-components/components/concept/fetch/src/main/java/mozilla/components/concept/fetch/Request.kt - android-components/components/concept/toolbar/src/main/java/mozilla/components/concept/toolbar/Toolbar.kt - android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt - android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/amo/AddonCollectionProvider.kt - android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_installed.xml - android-components/components/feature/app-links/build.gradle - android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt - android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksUseCases.kt - android-components/components/feature/contextmenu/src/main/java/mozilla/components/feature/contextmenu/ContextMenuCandidate.kt - android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt - android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadsFeature.kt - android-components/components/feature/privatemode/src/main/java/mozilla/components/feature/privatemode/notification/PrivateNotificationFeature.kt - android-components/components/feature/search/src/main/assets/search/list.json - + android-components/components/feature/search/src/main/assets/searchplugins/ddg-onion.xml - android-components/components/feature/search/src/main/assets/searchplugins/ddg.xml - + android-components/components/feature/search/src/main/assets/searchplugins/startpage.xml - + android-components/components/feature/search/src/main/assets/searchplugins/yahoo.xml - android-components/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarPresenter.kt - android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/android/content/Context.kt The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/04… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/04… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 2ea13924 by Pier Angelo Vendrame at 2023-08-17T13:16:41+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Bug 41967: Add a Makefile recipe to create multi-lingual dev builds - - - - - 1 changed file: - tools/torbrowser/build.sh Changes: ===================================== tools/torbrowser/build.sh ===================================== @@ -4,4 +4,12 @@ DEV_ROOT=$1 cd $DEV_ROOT ./mach build -./mach build stage-package + +if [ -z "$LOCALES" ]; then + ./mach build stage-package +else + export MOZ_CHROME_MULTILOCALE=$LOCALES + # No quotes on purpose + ./mach package-multi-locale --locales en-US $MOZ_CHROME_MULTILOCALE + AB_CD=multi ./mach build stage-package +fi View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2ea1392… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2ea1392… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 90d44f70 by ruihildt at 2023-08-17T11:01:57+02:00 fixup! Firefox preference overrides. Bug 41691: Hide "Firefox Suggest" label in URL suggest menu. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -118,6 +118,7 @@ pref("browser.search.suggest.enabled", false); pref("browser.urlbar.suggest.searches", false); pref("browser.urlbar.suggest.quicksuggest.nonsponsored", false); pref("browser.urlbar.suggest.quicksuggest.sponsored", false); +pref("browser.urlbar.groupLabels.enabled", false); pref("browser.safebrowsing.malware.enabled", false); pref("browser.safebrowsing.phishing.enabled", false); pref("browser.safebrowsing.downloads.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/90d44f7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/90d44f7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: b3b01c00 by ruihildt at 2023-08-17T11:02:12+02:00 fixup! Firefox preference overrides. Bug 41691: Hide "Firefox Suggest" label in URL suggest menu. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -118,6 +118,7 @@ pref("browser.search.suggest.enabled", false); pref("browser.urlbar.suggest.searches", false); pref("browser.urlbar.suggest.quicksuggest.nonsponsored", false); pref("browser.urlbar.suggest.quicksuggest.sponsored", false); +pref("browser.urlbar.groupLabels.enabled", false); pref("browser.safebrowsing.malware.enabled", false); pref("browser.safebrowsing.phishing.enabled", false); pref("browser.safebrowsing.downloads.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b3b01c0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b3b01c0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] Bug 42022: Prevent extension search engines from breaking the whole search system
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 76d4d68d by Pier Angelo Vendrame at 2023-08-16T19:44:37+02:00 Bug 42022: Prevent extension search engines from breaking the whole search system We found that if an extension tries to add a search engine that is already bundled the whole search system breaks because an exception is thrown and it reaches the initialization function, whose catch undoes the initialization. With this commit, we handle this kind of exceptions when trying to install the extension's engines, and contain it there. - - - - - 1 changed file: - toolkit/components/search/SearchService.sys.mjs Changes: ===================================== toolkit/components/search/SearchService.sys.mjs ===================================== @@ -2704,6 +2704,7 @@ export class SearchService { }; let engines = []; + let revert = false; for (let locale of locales) { lazy.logConsole.debug( "addEnginesFromExtension: installing:", @@ -2711,7 +2712,28 @@ export class SearchService { ":", locale ); - engines.push(await installLocale(locale)); + try { + engines.push(await installLocale(locale)); + } catch (err) { + lazy.logConsole.error( + `Could not install the search engine of ${extension.id}`, + err + ); + revert = true; + break; + } + } + if (revert) { + for (let engine of engines) { + try { + this.removeEngine(engine); + } catch (err) { + lazy.logConsole.warn( + "Failed to revert the addition of a search engine", + err + ); + } + } } return engines; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76d4d68… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76d4d68… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] Bug 42022: Prevent extension search engines from breaking the whole search system
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d11b0294 by Pier Angelo Vendrame at 2023-08-16T19:44:09+02:00 Bug 42022: Prevent extension search engines from breaking the whole search system We found that if an extension tries to add a search engine that is already bundled the whole search system breaks because an exception is thrown and it reaches the initialization function, whose catch undoes the initialization. With this commit, we handle this kind of exceptions when trying to install the extension's engines, and contain it there. - - - - - 1 changed file: - toolkit/components/search/SearchService.sys.mjs Changes: ===================================== toolkit/components/search/SearchService.sys.mjs ===================================== @@ -2706,6 +2706,7 @@ export class SearchService { }; let engines = []; + let revert = false; for (let locale of locales) { lazy.logConsole.debug( "addEnginesFromExtension: installing:", @@ -2713,7 +2714,28 @@ export class SearchService { ":", locale ); - engines.push(await installLocale(locale)); + try { + engines.push(await installLocale(locale)); + } catch (err) { + lazy.logConsole.error( + `Could not install the search engine of ${extension.id}`, + err + ); + revert = true; + break; + } + } + if (revert) { + for (let engine of engines) { + try { + this.removeEngine(engine); + } catch (err) { + lazy.logConsole.warn( + "Failed to revert the addition of a search engine", + err + ); + } + } } return engines; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new branch firefox-android-115.2.1-13.0-1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag fenix-v115.2.1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new tag fenix-v115.2.1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/fenix… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: a992e3dd by Henry Wilkes at 2023-08-16T10:02:44+02:00 fixup! Base Browser strings Bug 41984: Rename languageNotification.ftl to base-browser.ftl. - - - - - cdbb2876 by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Base Browser strings Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 456bd08b by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 3 changed files: - browser/base/content/browser.xhtml - browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl - toolkit/mozapps/extensions/content/aboutaddons.html Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -88,7 +88,7 @@ <link rel="localization" href="toolkit/branding/brandings.ftl"/> <link rel="localization" href="toolkit/global/textActions.ftl"/> <link rel="localization" href="toolkit/printing/printUI.ftl"/> - <link rel="localization" href="browser/languageNotification.ftl"/> + <link rel="localization" href="browser/base-browser.ftl"/>  <link rel="localization" href="preview/firefoxSuggest.ftl" /> <link rel="localization" href="preview/identityCredentialNotification.ftl" /> ===================================== browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -2,17 +2,12 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -# These strings are used by the Base Browser part of the changeset, not only for -# the language notification. -# TODO: Rename this file to make this clearer - - ## Language notification -# $language is the language Tor Browser is displayed in (already translated) +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label-system = { -brand-short-name } has set your display language to { $language } based on your system’s language. # This is shown when the system language is not supported, so we fall back to another language instead. -# $language is the language Tor Browser is displayed in (already translated). +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label = { -brand-short-name } has set your display language to { $language }. language-notification-button = Change Language… ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -35,7 +35,7 @@ <link rel="localization" href="toolkit/about/aboutAddons.ftl" /> <link rel="localization" href="toolkit/about/abuseReports.ftl" /> - <link rel="localization" href="browser/languageNotification.ftl" /> + <link rel="localization" href="browser/base-browser.ftl" />  <script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: c2bff07e by Henry Wilkes at 2023-08-09T09:44:53+01:00 fixup! Base Browser strings Bug 41984: Rename languageNotification.ftl to base-browser.ftl. - - - - - 72724735 by Henry Wilkes at 2023-08-09T09:45:00+01:00 fixup! Base Browser strings Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 6de7d3e8 by Henry Wilkes at 2023-08-09T09:45:05+01:00 fixup! Bug 41698: Reword the recommendation badges in about:addons Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 3 changed files: - browser/base/content/browser.xhtml - browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl - toolkit/mozapps/extensions/content/aboutaddons.html Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -95,7 +95,7 @@ <link rel="localization" href="toolkit/branding/brandings.ftl"/> <link rel="localization" href="toolkit/global/textActions.ftl"/> <link rel="localization" href="toolkit/printing/printUI.ftl"/> - <link rel="localization" href="browser/languageNotification.ftl"/> + <link rel="localization" href="browser/base-browser.ftl"/>  <link rel="localization" href="preview/firefoxSuggest.ftl" /> <link rel="localization" href="preview/identityCredentialNotification.ftl" /> ===================================== browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -2,17 +2,12 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -# These strings are used by the Base Browser part of the changeset, not only for -# the language notification. -# TODO: Rename this file to make this clearer - - ## Language notification -# $language is the language Tor Browser is displayed in (already translated) +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label-system = { -brand-short-name } has set your display language to { $language } based on your system’s language. # This is shown when the system language is not supported, so we fall back to another language instead. -# $language is the language Tor Browser is displayed in (already translated). +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label = { -brand-short-name } has set your display language to { $language }. language-notification-button = Change Language… ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -35,7 +35,7 @@ <link rel="localization" href="toolkit/about/aboutAddons.ftl" /> <link rel="localization" href="toolkit/about/abuseReports.ftl" /> - <link rel="localization" href="browser/languageNotification.ftl" /> + <link rel="localization" href="browser/base-browser.ftl" />  <script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e0e763… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e0e763… You're receiving this email because of your account on gitlab.torproject.org.

1 0