April 2025 - tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.9.0esr-14.5-1] fixup! BB 41919: Letterboxing, add temporarily visible web content-size...
by morgan (＠morgan) 14 Apr '25

14 Apr '25

morgan pushed to branch mullvad-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: f222b21b by hackademix at 2025-04-14T18:51:21+00:00 fixup! BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing. BB 43632: Letterboxing, always show the correct size for the active tab on resizing. BB 43642: New tab shows letterboxing size indicator. - - - - - 2 changed files: - browser/themes/shared/tabbrowser/content-area.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/themes/shared/tabbrowser/content-area.css ===================================== @@ -124,6 +124,7 @@ direction: ltr; } + .browserStack:not(.letterboxingStatus) &[type=letterboxingStatus], .exclude-letterboxing &[type=letterboxingStatus], &[inactive], :root[inDOMFullscreen] &:not([type=overLink]) { ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -717,13 +717,7 @@ class _RFPHelper { borderRadius === 0 ? "hidden" : "", "--letterboxing-border-radius": borderRadius, }); - - if ( - isResize && - this.letterboxingEnabled && - (parentWidth > lastRoundedSize.width || - parentHeight > lastRoundedSize.height) - ) { + if (win.gBrowser.selectedBrowser == aBrowser) { const updateStatus = async args => { win.XULBrowserWindow.letterboxingStatus = args ? await win.document.l10n.formatValue( @@ -733,9 +727,24 @@ class _RFPHelper { : ""; win.StatusPanel.update(); }; - updateStatus(lastRoundedSize); - win.clearTimeout(win._letterboxingStatusTimeout); - win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + if ( + isResize && + this.letterboxingEnabled && + (parentWidth > lastRoundedSize.width || + parentHeight > lastRoundedSize.height) + ) { + const clazz = "letterboxingStatus"; + const currentParent = win.document.getElementsByClassName(clazz)[0]; + if (currentParent != browserParent) { + currentParent?.classList.remove(clazz); + browserParent.classList.add(clazz); + } + updateStatus(lastRoundedSize); + win.clearTimeout(win._letterboxingStatusTimeout); + win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + } else { + updateStatus(""); + } } } @@ -840,9 +849,23 @@ class _RFPHelper { const resizeObserver = (aWindow._rfpResizeObserver = new aWindow.ResizeObserver(entries => { const context = { isResize: true }; - for (let { target } of entries) { + if (entries.length == 1) { + const { target } = entries[0]; + if (!("_letterboxingNew" in target)) { + target._letterboxingNew = !entries[0].contentRect.width; + if (target._letterboxingNew) { + return; + } + context.isResize = false; + } else if (target._letterboxingNew) { + target._letterboxingNew = false; + context.isResize = false; + } + } + + for (const { target } of entries) { this._roundOrResetContentSize( - target.querySelector("browser"), + target.getElementsByTagName("browser")[0], context ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f22… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f22… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.9.0esr-14.5-1] fixup! BB 41919: Letterboxing, add temporarily visible web content-size...
by morgan (＠morgan) 14 Apr '25

14 Apr '25

morgan pushed to branch base-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 044c9df4 by hackademix at 2025-04-14T18:46:15+00:00 fixup! BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing. BB 43632: Letterboxing, always show the correct size for the active tab on resizing. BB 43642: New tab shows letterboxing size indicator. - - - - - 2 changed files: - browser/themes/shared/tabbrowser/content-area.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/themes/shared/tabbrowser/content-area.css ===================================== @@ -124,6 +124,7 @@ direction: ltr; } + .browserStack:not(.letterboxingStatus) &[type=letterboxingStatus], .exclude-letterboxing &[type=letterboxingStatus], &[inactive], :root[inDOMFullscreen] &:not([type=overLink]) { ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -717,13 +717,7 @@ class _RFPHelper { borderRadius === 0 ? "hidden" : "", "--letterboxing-border-radius": borderRadius, }); - - if ( - isResize && - this.letterboxingEnabled && - (parentWidth > lastRoundedSize.width || - parentHeight > lastRoundedSize.height) - ) { + if (win.gBrowser.selectedBrowser == aBrowser) { const updateStatus = async args => { win.XULBrowserWindow.letterboxingStatus = args ? await win.document.l10n.formatValue( @@ -733,9 +727,24 @@ class _RFPHelper { : ""; win.StatusPanel.update(); }; - updateStatus(lastRoundedSize); - win.clearTimeout(win._letterboxingStatusTimeout); - win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + if ( + isResize && + this.letterboxingEnabled && + (parentWidth > lastRoundedSize.width || + parentHeight > lastRoundedSize.height) + ) { + const clazz = "letterboxingStatus"; + const currentParent = win.document.getElementsByClassName(clazz)[0]; + if (currentParent != browserParent) { + currentParent?.classList.remove(clazz); + browserParent.classList.add(clazz); + } + updateStatus(lastRoundedSize); + win.clearTimeout(win._letterboxingStatusTimeout); + win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + } else { + updateStatus(""); + } } } @@ -840,9 +849,23 @@ class _RFPHelper { const resizeObserver = (aWindow._rfpResizeObserver = new aWindow.ResizeObserver(entries => { const context = { isResize: true }; - for (let { target } of entries) { + if (entries.length == 1) { + const { target } = entries[0]; + if (!("_letterboxingNew" in target)) { + target._letterboxingNew = !entries[0].contentRect.width; + if (target._letterboxingNew) { + return; + } + context.isResize = false; + } else if (target._letterboxingNew) { + target._letterboxingNew = false; + context.isResize = false; + } + } + + for (const { target } of entries) { this._roundOrResetContentSize( - target.querySelector("browser"), + target.getElementsByTagName("browser")[0], context ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/044c9df… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/044c9df… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.9.0esr-14.5-1] fixup! BB 41919: Letterboxing, add temporarily visible web content-size...
by morgan (＠morgan) 14 Apr '25

14 Apr '25

morgan pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 41fd3b34 by hackademix at 2025-04-14T18:21:08+02:00 fixup! BB 41919: Letterboxing, add temporarily visible web content-size indicator on window resizing. BB 43632: Letterboxing, always show the correct size for the active tab on resizing. BB 43642: New tab shows letterboxing size indicator. - - - - - 2 changed files: - browser/themes/shared/tabbrowser/content-area.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/themes/shared/tabbrowser/content-area.css ===================================== @@ -124,6 +124,7 @@ direction: ltr; } + .browserStack:not(.letterboxingStatus) &[type=letterboxingStatus], .exclude-letterboxing &[type=letterboxingStatus], &[inactive], :root[inDOMFullscreen] &:not([type=overLink]) { ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -717,13 +717,7 @@ class _RFPHelper { borderRadius === 0 ? "hidden" : "", "--letterboxing-border-radius": borderRadius, }); - - if ( - isResize && - this.letterboxingEnabled && - (parentWidth > lastRoundedSize.width || - parentHeight > lastRoundedSize.height) - ) { + if (win.gBrowser.selectedBrowser == aBrowser) { const updateStatus = async args => { win.XULBrowserWindow.letterboxingStatus = args ? await win.document.l10n.formatValue( @@ -733,9 +727,24 @@ class _RFPHelper { : ""; win.StatusPanel.update(); }; - updateStatus(lastRoundedSize); - win.clearTimeout(win._letterboxingStatusTimeout); - win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + if ( + isResize && + this.letterboxingEnabled && + (parentWidth > lastRoundedSize.width || + parentHeight > lastRoundedSize.height) + ) { + const clazz = "letterboxingStatus"; + const currentParent = win.document.getElementsByClassName(clazz)[0]; + if (currentParent != browserParent) { + currentParent?.classList.remove(clazz); + browserParent.classList.add(clazz); + } + updateStatus(lastRoundedSize); + win.clearTimeout(win._letterboxingStatusTimeout); + win._letterboxingStatusTimeout = win.setTimeout(updateStatus, 1000); + } else { + updateStatus(""); + } } } @@ -840,9 +849,23 @@ class _RFPHelper { const resizeObserver = (aWindow._rfpResizeObserver = new aWindow.ResizeObserver(entries => { const context = { isResize: true }; - for (let { target } of entries) { + if (entries.length == 1) { + const { target } = entries[0]; + if (!("_letterboxingNew" in target)) { + target._letterboxingNew = !entries[0].contentRect.width; + if (target._letterboxingNew) { + return; + } + context.isResize = false; + } else if (target._letterboxingNew) { + target._letterboxingNew = false; + context.isResize = false; + } + } + + for (const { target } of entries) { this._roundOrResetContentSize( - target.querySelector("browser"), + target.getElementsByTagName("browser")[0], context ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/41fd3b3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/41fd3b3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.9.0esr-14.5-1] fixup! TB 43505 [android]: Add 2025 UX Survey Campaign
by Dan Ballard (＠dan) 14 Apr '25

14 Apr '25

Dan Ballard pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: a97a4df4 by Pier Angelo Vendrame at 2025-04-14T14:59:47+02:00 fixup! TB 43505 [android]: Add 2025 UX Survey Campaign TB 43648: Survey fixes for Android. Display the survey for all languages, but display it only in the release channel. - - - - - 2 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/CampaignStrings.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -557,9 +557,6 @@ class HomeFragment : Fragment(), UserInteractionHandler { } private fun tryShowUX2025Survey() { - val allowedLocales = arrayListOf("en", "es", "ru", "fr", "pt") - val locale = CampaignStrings.getLocale() - val dateFormat = SimpleDateFormat("yyyy-MM-dd-hh-zzz") val startDate = dateFormat.parse("2025-04-14-12-UTC") @@ -570,7 +567,7 @@ class HomeFragment : Fragment(), UserInteractionHandler { return // comment out to test } - if (allowedLocales.contains(locale) && !requireContext().settings().hideCampaign) { + if (BuildConfig.BUILD_TYPE == "release" && !requireContext().settings().hideCampaign) { binding.onionPatternImage.visibility = View.GONE binding.campaignBox.apply { setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed) ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/CampaignStrings.kt ===================================== @@ -49,8 +49,11 @@ object CampaignStrings { ) fun getLocale(): String { - // TODO: do we care about spoofEnglish setting? - return Locale.getDefault().getLanguage(); + val locale = Locale.getDefault().getLanguage() + if (translations.containsKey(locale)) { + return locale + } + return "en" } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a97a4df… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a97a4df… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher] Deleted branch asciiwolf-rdns-desktop-files
by asciiwolf (＠asciiwolf) 14 Apr '25

14 Apr '25

asciiwolf deleted branch asciiwolf-rdns-desktop-files at The Tor Project / Applications / torbrowser-launcher -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher][main] 2 commits: Rename desktop files to rDNS format
by asciiwolf (＠asciiwolf) 14 Apr '25

14 Apr '25

asciiwolf pushed to branch main at The Tor Project / Applications / torbrowser-launcher Commits: ab97d7f9 by AsciiWolf at 2025-03-20T22:36:16+01:00 Rename desktop files to rDNS format As recommended by the Desktop Entry Specification and already used on Flathub. Also fix the icon path in torbrowser_launcher/common.py - - - - - 3a2f757b by asciiwolf at 2025-04-14T12:58:17+00:00 Merge branch 'asciiwolf-rdns-desktop-files' into 'main' Rename desktop files to rDNS format See merge request tpo/applications/torbrowser-launcher!25 - - - - - 6 changed files: - share/applications/torbrowser.desktop → share/applications/org.torproject.torbrowser-launcher.desktop - share/applications/torbrowser-settings.desktop → share/applications/org.torproject.torbrowser-launcher.settings.desktop - share/icons/hicolor/128x128/apps/torbrowser.png → share/icons/hicolor/128x128/apps/org.torproject.torbrowser-launcher.png - share/metainfo/org.torproject.torbrowser-launcher.metainfo.xml - torbrowser_launcher/__init__.py - torbrowser_launcher/common.py Changes: ===================================== share/applications/torbrowser.desktop → share/applications/org.torproject.torbrowser-launcher.desktop ===================================== @@ -26,6 +26,6 @@ Comment[tr]=Tor Browser Başlat Exec=torbrowser-launcher %u Terminal=false Type=Application -Icon=torbrowser +Icon=org.torproject.torbrowser-launcher Categories=Network;WebBrowser; StartupWMClass=Tor Browser ===================================== share/applications/torbrowser-settings.desktop → share/applications/org.torproject.torbrowser-launcher.settings.desktop ===================================== @@ -32,5 +32,5 @@ Comment[tr]=Tor Browser Başlatıcı Ayarları Exec=torbrowser-launcher --settings Terminal=false Type=Application -Icon=torbrowser +Icon=org.torproject.torbrowser-launcher Categories=Network;WebBrowser; ===================================== share/icons/hicolor/128x128/apps/torbrowser.png → share/icons/hicolor/128x128/apps/org.torproject.torbrowser-launcher.png ===================================== ===================================== share/metainfo/org.torproject.torbrowser-launcher.metainfo.xml ===================================== @@ -3,7 +3,7 @@  <component type="desktop-application"> <id>org.torproject.torbrowser-launcher</id> - <launchable type="desktop-id">torbrowser.desktop</launchable> + <launchable type="desktop-id">org.torproject.torbrowser-launcher.desktop</launchable> <metadata_license>CC0-1.0</metadata_license> <project_license>MIT</project_license> <name>Tor Browser Launcher</name> ===================================== torbrowser_launcher/__init__.py ===================================== @@ -82,7 +82,7 @@ def main(): app = Application() if "WAYLAND_DISPLAY" in os.environ: - app.setDesktopFileName("torbrowser") + app.setDesktopFileName("org.torproject.torbrowser-launcher") # Open the window gui = None ===================================== torbrowser_launcher/common.py ===================================== @@ -126,7 +126,7 @@ class Common(object): "old_data_dir": old_tbb_data, "tbl_bin": sys.argv[0], "icon_file": os.path.join( - os.path.dirname(SHARE), "pixmaps/torbrowser.png" + os.path.dirname(SHARE), "icons/hicolor/128x128/apps/org.torproject.torbrowser-launcher.png" ), "torproject_pem": os.path.join(SHARE, "torproject.pem"), "signing_keys": { View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/compar… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/compar… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.9.0esr-14.5-1] fixup! [android] Implement Android-native Connection Assist UI
by Dan Ballard (＠dan) 10 Apr '25

10 Apr '25

Dan Ballard pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 7dd436ed by clairehurst at 2025-04-10T15:10:23-06:00 fixup! [android] Implement Android-native Connection Assist UI Bug 43576: Connection Assist on Android Fast Follows (Bug 41188) Remove unnecessary locale change listener - - - - - 1 changed file: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt ===================================== @@ -4,8 +4,6 @@ package org.mozilla.fenix.tor -import android.content.BroadcastReceiver -import android.content.Context import android.content.Intent import android.graphics.Color import android.os.Build @@ -58,15 +56,6 @@ class TorConnectionAssistFragment : Fragment(), UserInteractionHandler { inflater, container, false, ) - object : BroadcastReceiver() { - override fun onReceive(context: Context, intent: Intent) { - if (intent.action === Intent.ACTION_LOCALE_CHANGED) { - Log.v("LocaleReceiver", "received ACTION_LOCALE_CHANGED") - torConnectionAssistViewModel.fetchRegionNames() - } - } - } - viewLifecycleOwner.lifecycleScope.launch { repeatOnLifecycle(Lifecycle.State.STARTED) { torConnectionAssistViewModel.collectTorConnectStage() View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7dd436e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7dd436e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_128_9_0esr_BUILD2
by ma1 (＠ma1) 09 Apr '25

09 Apr '25

ma1 pushed new tag FIREFOX_128_9_0esr_BUILD2 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag 14.5a6
by ma1 (＠ma1) 09 Apr '25

09 Apr '25

ma1 pushed new tag 14.5a6 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/14.5a6 You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser-update-responses][main] 4 commits: alpha: new version, 14.5a6 (linux-x86_64)
by ma1 (＠ma1) 09 Apr '25

09 Apr '25

ma1 pushed to branch main at The Tor Project / Applications / mullvad-browser-update-responses Commits: 13689a13 by hackademix at 2025-04-09T13:32:31+02:00 alpha: new version, 14.5a6 (linux-x86_64) - - - - - 40be429c by hackademix at 2025-04-09T13:32:31+02:00 alpha: new version, 14.5a6 (macos) - - - - - 6d8fb71e by hackademix at 2025-04-09T13:32:32+02:00 alpha: new version, 14.5a6 (windows-x86_64) - - - - - 0152fe77 by hackademix at 2025-04-09T13:32:32+02:00 alpha: new version, 14.5a6 - - - - - 31 changed files: - update_1/alpha/download-linux-x86_64.json - update_1/alpha/download-macos.json - update_1/alpha/download-windows-x86_64.json - update_1/alpha/downloads.json - update_1/alpha/linux-x86_64/.htaccess - − update_1/alpha/linux-x86_64/14.5a2-14.5a5-linux-x86_64.xml - − update_1/alpha/linux-x86_64/14.5a3-14.5a5-linux-x86_64.xml - + update_1/alpha/linux-x86_64/14.5a3-14.5a6-linux-x86_64.xml - − update_1/alpha/linux-x86_64/14.5a4-14.5a5-linux-x86_64.xml - + update_1/alpha/linux-x86_64/14.5a4-14.5a6-linux-x86_64.xml - + update_1/alpha/linux-x86_64/14.5a5-14.5a6-linux-x86_64.xml - − update_1/alpha/linux-x86_64/14.5a5-linux-x86_64.xml - + update_1/alpha/linux-x86_64/14.5a6-linux-x86_64.xml - update_1/alpha/macos/.htaccess - − update_1/alpha/macos/14.5a2-14.5a5-macos.xml - − update_1/alpha/macos/14.5a3-14.5a5-macos.xml - + update_1/alpha/macos/14.5a3-14.5a6-macos.xml - − update_1/alpha/macos/14.5a4-14.5a5-macos.xml - + update_1/alpha/macos/14.5a4-14.5a6-macos.xml - + update_1/alpha/macos/14.5a5-14.5a6-macos.xml - − update_1/alpha/macos/14.5a5-macos.xml - + update_1/alpha/macos/14.5a6-macos.xml - update_1/alpha/windows-x86_64/.htaccess - − update_1/alpha/windows-x86_64/14.5a2-14.5a5-windows-x86_64.xml - − update_1/alpha/windows-x86_64/14.5a3-14.5a5-windows-x86_64.xml - + update_1/alpha/windows-x86_64/14.5a3-14.5a6-windows-x86_64.xml - − update_1/alpha/windows-x86_64/14.5a4-14.5a5-windows-x86_64.xml - + update_1/alpha/windows-x86_64/14.5a4-14.5a6-windows-x86_64.xml - + update_1/alpha/windows-x86_64/14.5a5-14.5a6-windows-x86_64.xml - − update_1/alpha/windows-x86_64/14.5a5-windows-x86_64.xml - + update_1/alpha/windows-x86_64/14.5a6-windows-x86_64.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… You're receiving this email because of your account on gitlab.torproject.org.

1 0