August 2023 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] Bug 41740: Change the RFP value of devicePixelRatio to 2
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: a7f0a2c3 by cypherpunks1 at 2023-08-24T20:28:49+00:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 1 changed file: - dom/base/nsGlobalWindowInner.cpp Changes: ===================================== dom/base/nsGlobalWindowInner.cpp ===================================== @@ -3616,7 +3616,7 @@ double nsGlobalWindowInner::GetDevicePixelRatio(CallerType aCallerType, nsAutoCString origin; nsresult rv = this->GetPrincipal()->GetOrigin(origin); if (NS_FAILED(rv) || origin != "resource://pdf.js"_ns) { - return 1.0; + return 2.0; } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f0a2c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f0a2c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] Bug 41740: Change the RFP value of devicePixelRatio to 2
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 1431b193 by cypherpunks1 at 2023-08-24T20:26:49+00:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 1 changed file: - dom/base/nsGlobalWindowInner.cpp Changes: ===================================== dom/base/nsGlobalWindowInner.cpp ===================================== @@ -3616,7 +3616,7 @@ double nsGlobalWindowInner::GetDevicePixelRatio(CallerType aCallerType, nsAutoCString origin; nsresult rv = this->GetPrincipal()->GetOrigin(origin); if (NS_FAILED(rv) || origin != "resource://pdf.js"_ns) { - return 1.0; + return 2.0; } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1431b19… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1431b19… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e35aaaa8 by Henry Wilkes at 2023-08-24T20:21:48+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42047: Remove sizing hacks for tor dialogs. We can just wait until DOMContentLoaded to call _populateXUL. Then the subDialog code will take care of the sizing for us. - - - - - 13 changed files: - browser/components/torpreferences/content/bridgeQrDialog.jsm - browser/components/torpreferences/content/bridgeQrDialog.xhtml - browser/components/torpreferences/content/builtinBridgeDialog.jsm - browser/components/torpreferences/content/builtinBridgeDialog.xhtml - browser/components/torpreferences/content/connectionSettingsDialog.jsm - browser/components/torpreferences/content/connectionSettingsDialog.xhtml - browser/components/torpreferences/content/provideBridgeDialog.jsm - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/requestBridgeDialog.jsm - browser/components/torpreferences/content/requestBridgeDialog.xhtml - browser/components/torpreferences/content/torLogDialog.jsm - browser/components/torpreferences/content/torLogDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/bridgeQrDialog.jsm ===================================== @@ -34,10 +34,7 @@ class BridgeQrDialog { } init(window, dialog) { - // Defer to later until Firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(window, dialog); - }, 0); + this._populateXUL(window, dialog); } openDialog(gSubDialog, bridgeString) { ===================================== browser/components/torpreferences/content/bridgeQrDialog.xhtml ===================================== @@ -21,8 +21,10 @@ "use strict"; let dialogObject = window.arguments[0]; - let dialogElement = document.getElementById("bridgeQr-dialog"); - dialogObject.init(window, dialogElement); + document.addEventListener("DOMContentLoaded", () => { + let dialogElement = document.getElementById("bridgeQr-dialog"); + dialogObject.init(window, dialogElement); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/builtinBridgeDialog.jsm ===================================== @@ -95,10 +95,6 @@ class BuiltinBridgeDialog { ); }); - // Hack: see the CSS - dialog.style.minWidth = "0"; - dialog.style.minHeight = "0"; - this._acceptButton = dialog.getButton("accept"); Services.obs.addObserver(this, TorConnectTopics.StateChange); @@ -129,10 +125,7 @@ class BuiltinBridgeDialog { } init(window, aDialog) { - // defer to later until firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(window, aDialog); - }, 0); + this._populateXUL(window, aDialog); } close() { ===================================== browser/components/torpreferences/content/builtinBridgeDialog.xhtml ===================================== @@ -83,8 +83,10 @@ "use strict"; let builtinBridgeDialog = window.arguments[0]; - let dialog = document.getElementById("torPreferences-builtinBridge-dialog"); - builtinBridgeDialog.init(window, dialog); + document.addEventListener("DOMContentLoaded", () => { + let dialog = document.getElementById("torPreferences-builtinBridge-dialog"); + builtinBridgeDialog.init(window, dialog); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/connectionSettingsDialog.jsm ===================================== @@ -213,10 +213,6 @@ class ConnectionSettingsDialog { this._dialog.addEventListener("dialogaccept", e => { this._applySettings(); }); - - // Hack: see the CSS - this._dialog.style.minWidth = "0"; - this._dialog.style.minHeight = "0"; } // callback when proxy is toggled @@ -380,10 +376,7 @@ class ConnectionSettingsDialog { } init(window, aDialog) { - // defer to later until firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(window, aDialog); - }, 0); + this._populateXUL(window, aDialog); } openDialog(gSubDialog) { ===================================== browser/components/torpreferences/content/connectionSettingsDialog.xhtml ===================================== @@ -83,8 +83,10 @@ "use strict"; let connectionSettingsDialog = window.arguments[0]; - let dialog = document.getElementById("torPreferences-connection-dialog"); - connectionSettingsDialog.init(window, dialog); + document.addEventListener("DOMContentLoaded", () => { + let dialog = document.getElementById("torPreferences-connection-dialog"); + connectionSettingsDialog.init(window, dialog); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/provideBridgeDialog.jsm ===================================== @@ -99,10 +99,7 @@ class ProvideBridgeDialog { } init(window, aDialog) { - // defer to later until firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(window, aDialog); - }, 0); + this._populateXUL(window, aDialog); } close() { ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -24,8 +24,10 @@ "use strict"; let provideBridgeDialog = window.arguments[0]; - let dialog = document.getElementById("torPreferences-provideBridge-dialog"); - provideBridgeDialog.init(window, dialog); + document.addEventListener("DOMContentLoaded", () => { + let dialog = document.getElementById("torPreferences-provideBridge-dialog"); + provideBridgeDialog.init(window, dialog); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/requestBridgeDialog.jsm ===================================== @@ -157,10 +157,7 @@ class RequestBridgeDialog { } init(window, dialog) { - // defer to later until firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(window, dialog); - }, 0); + this._populateXUL(window, dialog); } close() { ===================================== browser/components/torpreferences/content/requestBridgeDialog.xhtml ===================================== @@ -35,8 +35,10 @@ "use strict"; let requestBridgeDialog = window.arguments[0]; - let dialog = document.getElementById("torPreferences-requestBridge-dialog"); - requestBridgeDialog.init(window, dialog); + document.addEventListener("DOMContentLoaded", () => { + let dialog = document.getElementById("torPreferences-requestBridge-dialog"); + requestBridgeDialog.init(window, dialog); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/torLogDialog.jsm ===================================== @@ -60,10 +60,7 @@ class TorLogDialog { } init(window, aDialog) { - // defer to later until firefox has populated the dialog with all our elements - window.setTimeout(() => { - this._populateXUL(aDialog); - }, 0); + this._populateXUL(aDialog); } copyTorLog() { ===================================== browser/components/torpreferences/content/torLogDialog.xhtml ===================================== @@ -19,8 +19,10 @@ "use strict"; let torLogDialog = window.arguments[0]; - let dialog = document.getElementById("torPreferences-torLog-dialog"); - torLogDialog.init(window, dialog); + document.addEventListener("DOMContentLoaded", () => { + let dialog = document.getElementById("torPreferences-torLog-dialog"); + torLogDialog.init(window, dialog); + }); ]]> </script> </dialog> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -441,22 +441,6 @@ dialog#torPreferences-requestBridge-dialog > hbox { } /* Builtin bridge dialog */ -#torPreferences-builtinBridge-dialog { - /* Hack: ask XUL to load with a lot of space, then we will remove the minimum - sizes after we populate the string. Users with high resolutions should see a - big dialog, but with all the needed buttons, users with small resolutions - should see scrollbars. - Known problems: - 1) the hack works only if a window is *already* small: if it is big, and then - it is resized, the dialog will not shrink; - 2) horizontal scrollbars are never added. - The proper solution for this will be loading the localized string with - Mozilla's way. - See also https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41044 */ - min-width: 700px; - min-height: 550px; -} - #torPreferences-builtinBridge-header { margin: 8px 0 10px 0; } @@ -504,12 +488,6 @@ groupbox#torPreferences-bridges-group textarea { } /* Connection settings dialog */ -#torPreferences-connection-dialog { - /* Hack: like the built-in dialog */ - min-width: 700px; - min-height: 550px; -} - #torPreferences-connection-header { margin: 4px 0 14px 0; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e35aaaa… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e35aaaa… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Bug 40925: Implemented the Security Level component
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f92d4107 by Henry Wilkes at 2023-08-24T20:08:12+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42046: Clean up XUL layout hack in security level panel. - - - - - 1 changed file: - browser/components/securitylevel/content/securityLevelPanel.css Changes: ===================================== browser/components/securitylevel/content/securityLevelPanel.css ===================================== @@ -1,12 +1,10 @@ /* Security Level CSS */ #securityLevel-background { - /* xul:vbox with display: block will be correctly measured in size by the - * parent xul:panel, with line-wrapping taken into account, and allocated the - * required space. */ - display: block; min-height: 10em; padding-inline: 16px; + padding-block: 1em 0; + gap: 1em; background-repeat: no-repeat; background-position-y: top 0.4em; /* Icon center should be in-line with end padding. @@ -37,6 +35,10 @@ background-image: url("chrome://browser/content/securitylevel/securityLevelIcon.svg#safest"); } +#securityLevel-background p { + margin: 0; +} + /* Override margin in panelUI-shared.css */ #securityLevel-panel toolbarseparator#securityLevel-separator { margin-inline: 16px; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f92d410… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f92d410… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 40925: Implemented the Security Level component
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 50e86985 by Henry Wilkes at 2023-08-24T20:01:28+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42046: Clean up XUL layout hack in security level panel. - - - - - 1 changed file: - browser/components/securitylevel/content/securityLevelPanel.css Changes: ===================================== browser/components/securitylevel/content/securityLevelPanel.css ===================================== @@ -1,12 +1,10 @@ /* Security Level CSS */ #securityLevel-background { - /* xul:vbox with display: block will be correctly measured in size by the - * parent xul:panel, with line-wrapping taken into account, and allocated the - * required space. */ - display: block; min-height: 10em; padding-inline: 16px; + padding-block: 1em 0; + gap: 1em; background-repeat: no-repeat; background-position-y: top 0.4em; /* Icon center should be in-line with end padding. @@ -37,6 +35,10 @@ background-image: url("chrome://browser/content/securitylevel/securityLevelIcon.svg#safest"); } +#securityLevel-background p { + margin: 0; +} + /* Override margin in panelUI-shared.css */ #securityLevel-panel toolbarseparator#securityLevel-separator { margin-inline: 16px; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/50e8698… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/50e8698… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 13fedeae by Henry Wilkes at 2023-08-24T19:59:36+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42045: Allow circuit panel to grow in width for long addresses. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.css Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.css ===================================== @@ -69,16 +69,15 @@ } #tor-circuit-panel-body { - /* xul:vbox with display: block will be correctly measured in size by the - * parent xul:panel, and allocated the required space. */ - display: block; /* May grow larger than 480px if we have a long domain name or ip address. */ - width: 480px; + min-width: 480px; + padding: 1em; + gap: 1em; } #tor-circuit-node-list-name, #tor-circuit-node-list { - margin: 1em; + margin: 0; } #tor-circuit-node-list { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/13fedea… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/13fedea… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 73d562ff by Henry Wilkes at 2023-08-24T19:55:48+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41812: Stop using -moz-box-flex Fixes: Bug 41904: Connection settings now inputs at full width. Bug 41821: Tor logs now expand with dialog. - - - - - 2 changed files: - browser/components/torpreferences/content/requestBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/requestBridgeDialog.xhtml ===================================== @@ -19,7 +19,6 @@ <html:input id="torPreferences-requestBridge-captchaTextbox" type="text" - style="-moz-box-flex: 1" /> <button id="torPreferences-requestBridge-refreshCaptchaButton" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -378,6 +378,10 @@ button#torPreferences-requestBridge-refreshCaptchaButton { fill: currentColor; } +#torPreferences-requestBridge-captchaTextbox { + flex: 1 0 auto; +} + dialog#torPreferences-requestBridge-dialog > hbox { margin-bottom: 1em; } @@ -519,7 +523,7 @@ groupbox#torPreferences-bridges-group textarea { #torPreferences-localProxy-textboxUsername, #torPreferences-localProxy-textboxPassword, #torPreferences-connection-textboxAllowedPorts { - -moz-box-flex: 1; + flex: 1 0 auto; } #torPreferences-connection-firewall { @@ -532,7 +536,7 @@ groupbox#torPreferences-bridges-group textarea { /* Tor logs dialog */ textarea#torPreferences-torDialog-textarea { - -moz-box-flex: 1; + flex: 1 0 auto; font-family: monospace; font-size: 0.8em; white-space: pre; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/73d562f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/73d562f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 40701: Add security warning when downloading a file
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 4738c954 by Henry Wilkes at 2023-08-24T19:51:01+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 41886: Fix downloads panel warning size. - - - - - 1 changed file: - browser/components/downloads/content/downloads.css Changes: ===================================== browser/components/downloads/content/downloads.css ===================================== @@ -93,6 +93,9 @@ font: caption; min-width: 37em; padding: 0.62em; + /* If we don't set a width, #downloadsPanelTorWarningDescription will request + * its max-content width. */ + width: 37em; } #downloadsPanel-mainView { @@ -149,12 +152,6 @@ margin-block-end: 0; } -#downloadsPanelTorWarningDescription { - /* Make sure we wrap the text rather than request the default max-content - * width from the parent XUL -moz-box. */ - width: 0; -} - #downloadsHistory, #downloadsFooterButtons { margin: 0; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4738c95… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4738c95… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.15.0esr-12.5-1-build1
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed new tag tor-browser-102.15.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-102.15.0esr-12.5-1-build1
by richard (＠richard) 24 Aug '23

24 Aug '23

richard pushed new tag base-browser-102.15.0esr-12.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0