August 2023 - tbb-commits - lists.torproject.org

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed new tag firefox-android-115.2.1-13.0-1-build1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] 19 commits: Bug 40005: Modify Default toolbar menu
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 6b71815b by Matthew Finkel at 2023-08-16T10:15:20+02:00 Bug 40005: Modify Default toolbar menu - - - - - d9b7ced0 by Alex Catarineu at 2023-08-16T10:20:43+02:00 Bug 40007: Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - 1264670d by Alex Catarineu at 2023-08-16T10:20:44+02:00 Bug 40002: Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 036b857a by Alex Catarineu at 2023-08-16T10:20:45+02:00 Bug 40009: Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - 2607938a by Alex Catarineu at 2023-08-16T10:20:45+02:00 Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 2b037874 by Georg Koppen at 2023-08-16T10:20:45+02:00 Bug 40013: Add option do overwrite timestamp in extension version - - - - - 5e27821b by Alex Catarineu at 2023-08-16T10:22:04+02:00 Bug 40015: Port padlock states for .onion services - - - - - 5c822821 by Matthew Finkel at 2023-08-16T10:27:11+02:00 Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - e1ea75a0 by Matthew Finkel at 2023-08-16T10:27:15+02:00 Bug 40023: Stop PrivateNotificationService - - - - - a52d3674 by Matthew Finkel at 2023-08-16T10:27:15+02:00 Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - d25cf7f7 by Matthew Finkel at 2023-08-16T10:31:34+02:00 Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - bc8a8489 by Matthew Finkel at 2023-08-16T10:31:34+02:00 Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - a7a5dc1e by Georg Koppen at 2023-08-16T10:31:35+02:00 Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 231696a5 by Matthew Finkel at 2023-08-16T10:31:35+02:00 Bug 40185: Use NimbusDisabled - - - - - ea40407c by Matthew Finkel at 2023-08-16T10:31:35+02:00 Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - eaad8b2f by Alex Catarineu at 2023-08-16T10:31:35+02:00 Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - 95ad3c55 by hackademix at 2023-08-16T10:31:35+02:00 Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 8b6b9122 by Dan Ballard at 2023-08-16T10:31:35+02:00 Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - 4868781f by Dan Ballard at 2023-08-16T10:31:36+02:00 Bug 41972: Disable mozilla onboarding - - - - - 30 changed files: - .gitignore - android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt - android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt - android-components/components/browser/icons/src/main/java/mozilla/components/browser/icons/loader/HttpIconLoader.kt - android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt - android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt - android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/SiteSecurityIconView.kt - android-components/components/browser/toolbar/src/main/res/drawable/mozac_ic_site_security.xml - android-components/components/browser/toolbar/src/main/res/values/attrs_browser_toolbar.xml - android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt - android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/Settings.kt - android-components/components/concept/fetch/src/main/java/mozilla/components/concept/fetch/Request.kt - android-components/components/concept/toolbar/src/main/java/mozilla/components/concept/toolbar/Toolbar.kt - android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt - android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/amo/AddonCollectionProvider.kt - android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_installed.xml - android-components/components/feature/app-links/build.gradle - android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt - android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksUseCases.kt - android-components/components/feature/contextmenu/src/main/java/mozilla/components/feature/contextmenu/ContextMenuCandidate.kt - android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt - android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadsFeature.kt - android-components/components/feature/privatemode/src/main/java/mozilla/components/feature/privatemode/notification/PrivateNotificationFeature.kt - android-components/components/feature/search/src/main/assets/search/list.json - + android-components/components/feature/search/src/main/assets/searchplugins/ddg-onion.xml - android-components/components/feature/search/src/main/assets/searchplugins/ddg.xml - + android-components/components/feature/search/src/main/assets/searchplugins/startpage.xml - + android-components/components/feature/search/src/main/assets/searchplugins/yahoo.xml - android-components/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarPresenter.kt - android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/android/content/Context.kt The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/04… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/04… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 2ea13924 by Pier Angelo Vendrame at 2023-08-17T13:16:41+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Bug 41967: Add a Makefile recipe to create multi-lingual dev builds - - - - - 1 changed file: - tools/torbrowser/build.sh Changes: ===================================== tools/torbrowser/build.sh ===================================== @@ -4,4 +4,12 @@ DEV_ROOT=$1 cd $DEV_ROOT ./mach build -./mach build stage-package + +if [ -z "$LOCALES" ]; then + ./mach build stage-package +else + export MOZ_CHROME_MULTILOCALE=$LOCALES + # No quotes on purpose + ./mach package-multi-locale --locales en-US $MOZ_CHROME_MULTILOCALE + AB_CD=multi ./mach build stage-package +fi View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2ea1392… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2ea1392… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 90d44f70 by ruihildt at 2023-08-17T11:01:57+02:00 fixup! Firefox preference overrides. Bug 41691: Hide "Firefox Suggest" label in URL suggest menu. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -118,6 +118,7 @@ pref("browser.search.suggest.enabled", false); pref("browser.urlbar.suggest.searches", false); pref("browser.urlbar.suggest.quicksuggest.nonsponsored", false); pref("browser.urlbar.suggest.quicksuggest.sponsored", false); +pref("browser.urlbar.groupLabels.enabled", false); pref("browser.safebrowsing.malware.enabled", false); pref("browser.safebrowsing.phishing.enabled", false); pref("browser.safebrowsing.downloads.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/90d44f7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/90d44f7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 17 Aug '23

17 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: b3b01c00 by ruihildt at 2023-08-17T11:02:12+02:00 fixup! Firefox preference overrides. Bug 41691: Hide "Firefox Suggest" label in URL suggest menu. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -118,6 +118,7 @@ pref("browser.search.suggest.enabled", false); pref("browser.urlbar.suggest.searches", false); pref("browser.urlbar.suggest.quicksuggest.nonsponsored", false); pref("browser.urlbar.suggest.quicksuggest.sponsored", false); +pref("browser.urlbar.groupLabels.enabled", false); pref("browser.safebrowsing.malware.enabled", false); pref("browser.safebrowsing.phishing.enabled", false); pref("browser.safebrowsing.downloads.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b3b01c0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b3b01c0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] Bug 42022: Prevent extension search engines from breaking the whole search system
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 76d4d68d by Pier Angelo Vendrame at 2023-08-16T19:44:37+02:00 Bug 42022: Prevent extension search engines from breaking the whole search system We found that if an extension tries to add a search engine that is already bundled the whole search system breaks because an exception is thrown and it reaches the initialization function, whose catch undoes the initialization. With this commit, we handle this kind of exceptions when trying to install the extension's engines, and contain it there. - - - - - 1 changed file: - toolkit/components/search/SearchService.sys.mjs Changes: ===================================== toolkit/components/search/SearchService.sys.mjs ===================================== @@ -2704,6 +2704,7 @@ export class SearchService { }; let engines = []; + let revert = false; for (let locale of locales) { lazy.logConsole.debug( "addEnginesFromExtension: installing:", @@ -2711,7 +2712,28 @@ export class SearchService { ":", locale ); - engines.push(await installLocale(locale)); + try { + engines.push(await installLocale(locale)); + } catch (err) { + lazy.logConsole.error( + `Could not install the search engine of ${extension.id}`, + err + ); + revert = true; + break; + } + } + if (revert) { + for (let engine of engines) { + try { + this.removeEngine(engine); + } catch (err) { + lazy.logConsole.warn( + "Failed to revert the addition of a search engine", + err + ); + } + } } return engines; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76d4d68… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76d4d68… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] Bug 42022: Prevent extension search engines from breaking the whole search system
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d11b0294 by Pier Angelo Vendrame at 2023-08-16T19:44:09+02:00 Bug 42022: Prevent extension search engines from breaking the whole search system We found that if an extension tries to add a search engine that is already bundled the whole search system breaks because an exception is thrown and it reaches the initialization function, whose catch undoes the initialization. With this commit, we handle this kind of exceptions when trying to install the extension's engines, and contain it there. - - - - - 1 changed file: - toolkit/components/search/SearchService.sys.mjs Changes: ===================================== toolkit/components/search/SearchService.sys.mjs ===================================== @@ -2706,6 +2706,7 @@ export class SearchService { }; let engines = []; + let revert = false; for (let locale of locales) { lazy.logConsole.debug( "addEnginesFromExtension: installing:", @@ -2713,7 +2714,28 @@ export class SearchService { ":", locale ); - engines.push(await installLocale(locale)); + try { + engines.push(await installLocale(locale)); + } catch (err) { + lazy.logConsole.error( + `Could not install the search engine of ${extension.id}`, + err + ); + revert = true; + break; + } + } + if (revert) { + for (let engine of engines) { + try { + this.removeEngine(engine); + } catch (err) { + lazy.logConsole.warn( + "Failed to revert the addition of a search engine", + err + ); + } + } } return engines; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new branch firefox-android-115.2.1-13.0-1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag fenix-v115.2.1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new tag fenix-v115.2.1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/fenix… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: a992e3dd by Henry Wilkes at 2023-08-16T10:02:44+02:00 fixup! Base Browser strings Bug 41984: Rename languageNotification.ftl to base-browser.ftl. - - - - - cdbb2876 by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Base Browser strings Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 456bd08b by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 3 changed files: - browser/base/content/browser.xhtml - browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl - toolkit/mozapps/extensions/content/aboutaddons.html Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -88,7 +88,7 @@ <link rel="localization" href="toolkit/branding/brandings.ftl"/> <link rel="localization" href="toolkit/global/textActions.ftl"/> <link rel="localization" href="toolkit/printing/printUI.ftl"/> - <link rel="localization" href="browser/languageNotification.ftl"/> + <link rel="localization" href="browser/base-browser.ftl"/>  <link rel="localization" href="preview/firefoxSuggest.ftl" /> <link rel="localization" href="preview/identityCredentialNotification.ftl" /> ===================================== browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -2,17 +2,12 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -# These strings are used by the Base Browser part of the changeset, not only for -# the language notification. -# TODO: Rename this file to make this clearer - - ## Language notification -# $language is the language Tor Browser is displayed in (already translated) +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label-system = { -brand-short-name } has set your display language to { $language } based on your system’s language. # This is shown when the system language is not supported, so we fall back to another language instead. -# $language is the language Tor Browser is displayed in (already translated). +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label = { -brand-short-name } has set your display language to { $language }. language-notification-button = Change Language… ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -35,7 +35,7 @@ <link rel="localization" href="toolkit/about/aboutAddons.ftl" /> <link rel="localization" href="toolkit/about/abuseReports.ftl" /> - <link rel="localization" href="browser/languageNotification.ftl" /> + <link rel="localization" href="browser/base-browser.ftl" />  <script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… You're receiving this email because of your account on gitlab.torproject.org.

1 0