commit 9906e7e26e1dcbf313121dbf46e5a22aa185fd05
Author: Kathy Brade <brade(a)pearlcrescent.com>
Date: Wed Sep 3 13:56:57 2014 -0400
Bug 13049: updater fails (self.update is undefined).
Replace "self.update" with "this.update" in two add-on compatibility check
functions. Using self.update (which is undefined) caused the updater to
silently fail if one or more installed add-ons were marked in their
install.rdf file as not compatible with the new platformVersion.
We also replaced "TBB" with "Tor Browser" in the about box text.
---
browser/base/content/aboutDialog.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/browser/base/content/aboutDialog.js b/browser/base/content/aboutDialog.js
index c72c828..431d520 100644
--- a/browser/base/content/aboutDialog.js
+++ b/browser/base/content/aboutDialog.js
@@ -49,7 +49,7 @@ function init(aEvent)
#ifdef TOR_BROWSER_VERSION
let versionElem = document.getElementById("version");
if (versionElem)
- versionElem.textContent += " (TBB " + TOR_BROWSER_VERSION + ")";
+ versionElem.textContent += " (Tor Browser " + TOR_BROWSER_VERSION + ")";
#endif
#ifdef MOZ_UPDATER
@@ -444,9 +444,9 @@ appUpdater.prototype =
checkAddonsForUpdates: function() {
this.addons.forEach(function(aAddon) {
#ifdef TOR_BROWSER_UPDATE
- let compatVersion = self.update.platformVersion;
+ let compatVersion = this.update.platformVersion;
#else
- let compatVersion = self.update.appVersion;
+ let compatVersion = this.update.appVersion;
#endif
aAddon.findUpdates(this, AddonManager.UPDATE_WHEN_NEW_APP_DETECTED,
compatVersion,
@@ -471,9 +471,9 @@ appUpdater.prototype =
*/
onUpdateAvailable: function(aAddon, aInstall) {
#ifdef TOR_BROWSER_UPDATE
- let compatVersion = self.update.platformVersion;
+ let compatVersion = this.update.platformVersion;
#else
- let compatVersion = self.update.appVersion;
+ let compatVersion = this.update.appVersion;
#endif
if (!Services.blocklist.isAddonBlocklisted(aAddon.id, aInstall.version,
compatVersion,