- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-bundle-testsuite][main] Bug 40075: Use /tmp for nightly builds on tb-build-06
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: 8924181a by Nicolas Vigier at 2023-07-05T18:23:39+02:00 Bug 40075: Use /tmp for nightly builds on tb-build-06 - - - - - 1 changed file: - rbm-config/tb-build-06.torproject.org.rbm.local.conf Changes: ===================================== rbm-config/tb-build-06.torproject.org.rbm.local.conf ===================================== @@ -10,7 +10,7 @@ ### builds are made from this directory, so using a directory on a fast ### disk can improve build time. By default we are using a tmp directory ### under the tor-browser-build directory. -#tmp_dir: /tmp +tmp_dir: /tmp ### The debug option defines whether a debugging shell should be opened ### automatically in the build directory/container in case of build View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] 2 commits: Bug 42027: Base Browser migration procedures.
by Pier Angelo Vendrame (＠pierov) 22 Aug '23

22 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f96d5aae by Pier Angelo Vendrame at 2023-08-22T18:51:06+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - fc9ab629 by Pier Angelo Vendrame at 2023-08-22T18:51:09+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 2 changed files: - browser/components/BrowserGlue.sys.mjs - browser/components/preferences/main.inc.xhtml Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -1211,6 +1211,9 @@ BrowserGlue.prototype = { // handle any UI migration this._migrateUI(); + // Base Browser-specific version of _migrateUI. + this._migrateUIBB(); + // Clear possibly auto enabled enterprise_roots prefs (see bug 40166) if ( !Services.prefs.getBoolPref( @@ -4283,6 +4286,25 @@ BrowserGlue.prototype = { Services.prefs.setIntPref("browser.migration.version", UI_VERSION); }, + _migrateUIBB() { + // Version 1: 13.0a3. Reset layout.css.prefers-color-scheme.content-override + // for tor-browser#41739. + const MIGRATION_VERSION = 1; + const MIGRATION_PREF = "basebrowser.migration.version"; + // We do not care whether this is a new or old profile, since in version 1 + // we just quickly clear a user preference, which should not do anything to + // new profiles. + // Shall we ever raise the version number and have a watershed, we can add + // a check easily (any version > 0 will be an old profile). + const currentVersion = Services.prefs.getIntPref(MIGRATION_PREF, 0); + if (currentVersion < 1) { + Services.prefs.clearUserPref( + "layout.css.prefers-color-scheme.content-override" + ); + } + Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION); + }, + async _showUpgradeDialog() { const data = await lazy.OnboardingMessageProvider.getUpgradeMessage(); const { gBrowser } = lazy.BrowserWindowTracker.getTopWindow(); ===================================== browser/components/preferences/main.inc.xhtml ===================================== @@ -138,7 +138,7 @@ </hbox>  -<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true"> +<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true" data-hidden-from-search="true"> <html:h2 data-l10n-id="preferences-web-appearance-header"/> <html:div id="webAppearanceSettings"> <description data-l10n-id="preferences-web-appearance-description"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ed4858… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ed4858… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 2 commits: Bug 42027: Base Browser migration procedures.
by Pier Angelo Vendrame (＠pierov) 22 Aug '23

22 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ff3177a by Pier Angelo Vendrame at 2023-08-22T18:44:59+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - f268423e by Pier Angelo Vendrame at 2023-08-22T18:45:00+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 2 changed files: - browser/components/BrowserGlue.sys.mjs - browser/components/preferences/main.inc.xhtml Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -1300,6 +1300,9 @@ BrowserGlue.prototype = { // handle any UI migration this._migrateUI(); + // Base Browser-specific version of _migrateUI. + this._migrateUIBB(); + // Handle any TBB-specific migration before showing the UI. Keep after // _migrateUI to make sure this._isNewProfile has been defined. this._migrateUITBB(); @@ -4404,6 +4407,25 @@ BrowserGlue.prototype = { Services.prefs.setIntPref("browser.migration.version", UI_VERSION); }, + _migrateUIBB() { + // Version 1: 13.0a3. Reset layout.css.prefers-color-scheme.content-override + // for tor-browser#41739. + const MIGRATION_VERSION = 1; + const MIGRATION_PREF = "basebrowser.migration.version"; + // We do not care whether this is a new or old profile, since in version 1 + // we just quickly clear a user preference, which should not do anything to + // new profiles. + // Shall we ever raise the version number and have a watershed, we can add + // a check easily (any version > 0 will be an old profile). + const currentVersion = Services.prefs.getIntPref(MIGRATION_PREF, 0); + if (currentVersion < 1) { + Services.prefs.clearUserPref( + "layout.css.prefers-color-scheme.content-override" + ); + } + Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION); + }, + // Use this method for any TBB migration that can be run just before showing // the UI. // Anything that critically needs to be migrated earlier should not use this. ===================================== browser/components/preferences/main.inc.xhtml ===================================== @@ -138,7 +138,7 @@ </hbox>  -<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true"> +<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true" data-hidden-from-search="true"> <html:h2 data-l10n-id="preferences-web-appearance-header"/> <html:div id="webAppearanceSettings"> <description data-l10n-id="preferences-web-appearance-description"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d17f31… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d17f31… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] 2 commits: Bug 42019: Empty browser's clipboard on browser shutdown
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: cde79442 by hackademix at 2023-08-22T15:53:12+00:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ed48588b by cypherpunks1 at 2023-08-22T15:53:31+00:00 fixup! Firefox preference overrides. Bug 41876: Disable the Firefox View tab - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - browser/components/BrowserGlue.sys.mjs Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -17,6 +17,9 @@ pref("startup.homepage_welcome_url.additional", ""); // Disable Firefox Welcome Dialog pref("browser.aboutwelcome.enabled", false); +// Disable the Firefox View tab (tor-browser#41876) +pref("browser.tabs.firefox-view", false); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -1909,6 +1909,7 @@ BrowserGlue.prototype = { lazy.UpdateListener.reset(); } }, + () => Services.clipboard.emptyClipboard(Ci.nsIClipboard.kGlobalClipboard) // tor-browser#42019 ]; for (let task of tasks) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/225930… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/225930… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 16940: After update, load local change notes.
by Pier Angelo Vendrame (＠pierov) 22 Aug '23

22 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d17f3162 by Pier Angelo Vendrame at 2023-08-22T17:53:33+02:00 fixup! Bug 16940: After update, load local change notes. Remove the doubled and unused aboutTBUpdate.dtd - - - - - 2 changed files: - − browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd - browser/locales/jar.mn Changes: ===================================== browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd deleted ===================================== @@ -1,14 +0,0 @@ -<!ENTITY aboutTBUpdate.changelogTitle "Tor Browser Changelog"> -<!ENTITY aboutTBUpdate.updated "Tor Browser has been updated."> - -<!ENTITY aboutTBUpdate.linkPrefix "For the most up-to-date information about this release, "> -<!ENTITY aboutTBUpdate.linkLabel "visit our website"> -<!ENTITY aboutTBUpdate.linkSuffix "."> -<!ENTITY aboutTBUpdate.version "Version"> -<!ENTITY aboutTBUpdate.releaseDate "Release Date"> -<!ENTITY aboutTBUpdate.releaseNotes "Release Notes"> ===================================== browser/locales/jar.mn ===================================== @@ -18,9 +18,6 @@ @AB_CD@.jar: % locale browser @AB_CD@ %locale/browser/ -#ifdef BASE_BROWSER_UPDATE - locale/browser/aboutTBUpdate.dtd (%chrome/browser/aboutTBUpdate.dtd) -#endif locale/browser/browser.properties (%chrome/browser/browser.properties) locale/browser/customizableui/customizableWidgets.properties (%chrome/browser/customizableui/customizableWidgets.properties) locale/browser/uiDensity.properties (%chrome/browser/uiDensity.properties) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d17f316… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d17f316… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 68e4526d by cypherpunks1 at 2023-08-22T03:48:36-08:00 fixup! Firefox preference overrides. Bug 41876: Disable the Firefox View tab - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -17,6 +17,9 @@ pref("startup.homepage_welcome_url.additional", ""); // Disable Firefox Welcome Dialog pref("browser.aboutwelcome.enabled", false); +// Disable the Firefox View tab (tor-browser#41876) +pref("browser.tabs.firefox-view", false); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/68e4526… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/68e4526… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.2.0esr-13.0-1-build2
by richard (＠richard) 21 Aug '23

21 Aug '23

richard pushed new tag tor-browser-115.2.0esr-13.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 3 commits: fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
by ma1 (＠ma1) 21 Aug '23

21 Aug '23

ma1 pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 255203a3 by cypherpunks1 at 2023-08-21T19:11:56+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 40175: Use first-party isolation on reader view - - - - - 3f596978 by cypherpunks1 at 2023-08-21T19:11:56+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 40175: Support circuit display on about:reader - - - - - 5073f134 by cypherpunks1 at 2023-08-21T19:11:56+00:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - 4 changed files: - browser/components/torcircuit/content/torCircuitPanel.js - toolkit/components/reader/AboutReader.sys.mjs - toolkit/components/reader/ReaderMode.sys.mjs - toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -276,7 +276,18 @@ var gTorCircuitPanel = { // will match up with the domain. // In contrast, documentURI corresponds to the shown page. E.g. it could // point to "about:certerror". - const scheme = browser.currentURI?.scheme; + let scheme = browser.currentURI?.scheme; + if (scheme === "about" && browser.currentURI?.filePath === "reader") { + const searchParams = new URLSearchParams(browser.currentURI.query); + if (searchParams.has("url")) { + try { + const uri = Services.io.newURI(searchParams.get("url")); + scheme = uri.scheme; + } catch (err) { + this._log.error(err); + } + } + } if ( this._currentBrowserData && ===================================== toolkit/components/reader/AboutReader.sys.mjs ===================================== @@ -788,6 +788,7 @@ AboutReader.prototype = { try { article = await ReaderMode.downloadAndParseDocument( url, + { ...this._doc.nodePrincipal?.originAttributes }, docContentType ); } catch (e) { ===================================== toolkit/components/reader/ReaderMode.sys.mjs ===================================== @@ -231,11 +231,12 @@ export var ReaderMode = { * Downloads and parses a document from a URL. * * @param url URL to download and parse. + * @param attrs OriginAttributes to use for the request. * @return {Promise} * @resolves JS object representing the article, or null if no article is found. */ - async downloadAndParseDocument(url, docContentType = "document") { - let result = await this._downloadDocument(url, docContentType); + async downloadAndParseDocument(url, attrs = {}, docContentType = "document") { + let result = await this._downloadDocument(url, attrs, docContentType); if (!result?.doc) { return null; } @@ -258,9 +259,11 @@ export var ReaderMode = { return article; }, - _downloadDocument(url, docContentType = "document") { + _downloadDocument(url, attrs = {}, docContentType = "document") { + let uri; try { - if (!lazy.Readerable.shouldCheckUri(Services.io.newURI(url))) { + uri = Services.io.newURI(url); + if (!lazy.Readerable.shouldCheckUri(uri)) { return null; } } catch (ex) { @@ -272,9 +275,15 @@ export var ReaderMode = { let histogram = Services.telemetry.getHistogramById( "READER_MODE_DOWNLOAD_RESULT" ); + try { + attrs.firstPartyDomain = Services.eTLD.getSchemelessSite(uri); + } catch (e) { + console.error("Failed to get first party domain for about:reader", e); + } return new Promise((resolve, reject) => { let xhr = new XMLHttpRequest(); xhr.open("GET", url, true); + xhr.setOriginAttributes(attrs); xhr.onerror = evt => reject(evt.error); xhr.responseType = docContentType === "text/plain" ? "text" : "document"; xhr.onload = evt => { ===================================== toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs ===================================== @@ -300,6 +300,17 @@ class TorDomainIsolatorImpl { const channel = aChannel.QueryInterface(Ci.nsIChannel); let firstPartyDomain = channel.loadInfo.originAttributes.firstPartyDomain; const userContextId = channel.loadInfo.originAttributes.userContextId; + const loadingPrincipalURI = channel.loadInfo.loadingPrincipal?.URI; + if (loadingPrincipalURI?.spec.startsWith("about:reader")) { + try { + const searchParams = new URLSearchParams(loadingPrincipalURI.query); + if (searchParams.has("url")) { + firstPartyDomain = Services.eTLD.getSchemelessSite(Services.io.newURI(searchParams.get("url"))); + } + } catch (e) { + logger.error("Failed to get first party domain for about:reader", e); + } + } if (!firstPartyDomain) { firstPartyDomain = CATCHALL_DOMAIN; if (Date.now() - this.#catchallDirtySince > CATCHALL_MAX_LIFETIME) { @@ -629,36 +640,43 @@ class TorDomainIsolatorImpl { function getDomainForBrowser(browser) { let fpd = browser.contentPrincipal.originAttributes.firstPartyDomain; - // Bug 31562: For neterror or certerror, get the original URL from - // browser.currentURI and use it to calculate the firstPartyDomain. - const knownErrors = [ - "about:neterror", - "about:certerror", - "about:httpsonlyerror", - ]; const { documentURI } = browser; - if ( - documentURI && - documentURI.schemeIs("about") && - knownErrors.some(x => documentURI.spec.startsWith(x)) - ) { - const knownSchemes = ["http", "https"]; - const currentURI = browser.currentURI; - if (currentURI && knownSchemes.some(x => currentURI.schemeIs(x))) { + if (documentURI && documentURI.schemeIs("about")) { + // Bug 31562: For neterror or certerror, get the original URL from + // browser.currentURI and use it to calculate the firstPartyDomain. + const knownErrors = [ + "about:neterror", + "about:certerror", + "about:httpsonlyerror", + ]; + if (knownErrors.some(x => documentURI.spec.startsWith(x))) { + const knownSchemes = ["http", "https"]; + const currentURI = browser.currentURI; + if (currentURI && knownSchemes.some(x => currentURI.schemeIs(x))) { + try { + fpd = Services.eTLD.getBaseDomainFromHost(currentURI.host); + } catch (e) { + if ( + e.result === Cr.NS_ERROR_HOST_IS_IP_ADDRESS || + e.result === Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS + ) { + fpd = currentURI.host; + } else { + logger.error( + `Failed to get first party domain for host ${currentURI.host}`, + e + ); + } + } + } + } else if (documentURI.spec.startsWith("about:reader")) { try { - fpd = Services.eTLD.getBaseDomainFromHost(currentURI.host); - } catch (e) { - if ( - e.result === Cr.NS_ERROR_HOST_IS_IP_ADDRESS || - e.result === Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS - ) { - fpd = currentURI.host; - } else { - logger.error( - `Failed to get first party domain for host ${currentURI.host}`, - e - ); + const searchParams = new URLSearchParams(documentURI.query); + if (searchParams.has("url")) { + fpd = Services.eTLD.getSchemelessSite(Services.io.newURI(searchParams.get("url"))); } + } catch (e) { + logger.error("Failed to get first party domain for about:reader", e); } } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/968d39… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/968d39… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] Bug 42019: Empty browser's clipboard on browser shutdown
by richard (＠richard) 21 Aug '23

21 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 968d3923 by hackademix at 2023-08-21T19:08:38+00:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 1 changed file: - browser/components/BrowserGlue.sys.mjs Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -2007,6 +2007,7 @@ BrowserGlue.prototype = { } }, () => lazy.OnionAliasStore.uninit(), + () => Services.clipboard.emptyClipboard(Ci.nsIClipboard.kGlobalClipboard) // tor-browser#42019 ]; for (let task of tasks) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/968d392… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/968d392… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Bug 18905: Hide unwanted items from help menu
by richard (＠richard) 21 Aug '23

21 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 225930cb by cypherpunks1 at 2023-08-21T18:55:53+00:00 fixup! Bug 18905: Hide unwanted items from help menu Bug 41642: Hide the new private window option only when autostart of PBM is enabled - - - - - 2 changed files: - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser.js Changes: ===================================== browser/base/content/appmenu-viewcache.inc.xhtml ===================================== @@ -53,8 +53,7 @@ class="subviewbutton" data-l10n-id="appmenuitem-new-private-window" key="key_privatebrowsing" - command="Tools:PrivateBrowsing" - hidden="true"/> + command="Tools:PrivateBrowsing"/> <toolbarseparator/> <toolbarbutton id="appMenu-new-identity" class="subviewbutton" ===================================== browser/base/content/browser.js ===================================== @@ -1762,7 +1762,7 @@ var gBrowserInit = { this._boundDelayedStartup = this._delayedStartup.bind(this); window.addEventListener("MozAfterPaint", this._boundDelayedStartup); - if (!PrivateBrowsingUtils.enabled) { + if (PrivateBrowsingUtils.permanentPrivateBrowsing || !PrivateBrowsingUtils.enabled) { document.getElementById("Tools:PrivateBrowsing").hidden = true; // Setting disabled doesn't disable the shortcut, so we just remove // the keybinding. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/225930c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/225930c… You're receiving this email because of your account on gitlab.torproject.org.

1 0