- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][maint-13.5] Bump lyrebird version to 0.3.0
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: aa66852e by meskio at 2024-08-07T23:24:04+00:00 Bump lyrebird version to 0.3.0 - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 0.2.0 +version: 0.3.0 git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyre… git_hash: 'lyrebird-[% c("version") %]' tag_gpg_id: 1 @@ -9,7 +9,7 @@ container: use_container: 1 var: - go_vendor_sha256sum: dc6b2671250f4ffd0caff3ef020bd60f99207f519f6f5f1be47243677a13c695 + go_vendor_sha256sum: 71abc8063f2913e74e87a2a5c9262c4fad6ce4ed98b28b7603b50382724baba4 targets: nightly: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bump lyrebird version to 0.3.0
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 00062f02 by meskio at 2024-08-07T23:03:10+00:00 Bump lyrebird version to 0.3.0 - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 0.2.0 +version: 0.3.0 git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyre… git_hash: 'lyrebird-[% c("version") %]' tag_gpg_id: 1 @@ -9,7 +9,7 @@ container: use_container: 1 var: - go_vendor_sha256sum: dc6b2671250f4ffd0caff3ef020bd60f99207f519f6f5f1be47243677a13c695 + go_vendor_sha256sum: 71abc8063f2913e74e87a2a5c9262c4fad6ce4ed98b28b7603b50382724baba4 targets: nightly: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 4f0cf02d by Beatriz Rizental at 2024-08-07T23:07:38+00:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 1 changed file: - tools/torbrowser/generate-bugzilla-triage-csv.sh Changes: ===================================== tools/torbrowser/generate-bugzilla-triage-csv.sh ===================================== @@ -158,7 +158,7 @@ printf "\n]\n" >> "${git_json}" query_tail="&f1=product&n1=1&o1=anyexact&v1=Thunderbird%2CCalendar%2CChat%20Core%2CMailNews%20Core&f2=target_milestone&o2=substring&v2=${firefox_version}&limit=0" bugzilla_query="https://bugzilla.mozilla.org/buglist.cgi?${query_tail}" -bugzilla_json_query="https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary${query_tail}" +bugzilla_json_query="https://bugzilla.mozilla.org/rest/bug?include_fields=id,component,summary${…" wget "${bugzilla_json_query}" -O ${bugzilla_json} @@ -174,13 +174,14 @@ jq -s '[ (.[0].bugs)[], (.[1])[] ] | group_by(.id) | map(.[0])' "${bugzilla_json # Generate Triage CSV # -echo "\"Review\",,\"Bugzilla Bug\"" +echo "\"Review\",,\"Bugzilla Component\",\"Bugzilla Bug\"" -jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ -| while IFS='|' read -r id summary; do +jq '. | sort_by([.component, .id])[] | "\(.id)|\(.component)|\(.summary)"' ${union_json} \ +| while IFS='|' read -r id component summary; do # bugzilla info id="${id:1}" + component="${component:0}" summary="${summary:0:-1}" summary=$(jq_unescape "${summary}") # short summary for gitlab issue title @@ -207,6 +208,7 @@ jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ echoerr "Skipped Bugzilla ${id}: ${summary_short}" else csv_summary=$(csv_escape "${summary}") + csv_component=$(csv_escape "${component}") # parent issue bugzilla_url="https://bugzilla.mozilla.org/show_bug.cgi?id=${id}" @@ -221,7 +223,7 @@ jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ create_issue=$(csv_escape "=HYPERLINK(\"${new_issue_url}\", \"New Issue\")") bugzilla_link=$(csv_escape "=HYPERLINK(\"${bugzilla_url}\", \"Bugzilla ${id}: ${csv_summary}\")") - echo "FALSE,\"${create_issue}\",\"${bugzilla_link}\"," + echo "FALSE,\"${create_issue}\",\"${csv_component}\",\"${bugzilla_link}\"," fi done View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4f0cf02… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4f0cf02… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 3 commits: fixup! Bug 7494: Create local home page for TBB.
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 732e4181 by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42713: Use `--link-color` rather than `--in-content-link-color`. - - - - - fbf19afe by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - da08e423 by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - 3 changed files: - browser/components/abouttor/content/aboutTor.css - browser/components/torpreferences/content/torPreferences.css - toolkit/components/torconnect/content/aboutTorConnect.css Changes: ===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -194,14 +194,14 @@ body:not(.show-tor-check) #tor-check { --in-content-page-color: #fbfbfe; --in-content-text-color: #fbfbfe; color: var(--in-content-text-color); - --in-content-link-color: var(--purple-30); + --link-color: var(--purple-30); /* FIXME: Since we have a dark background, the color should get lighter on * hover, but --purple-40 and --pruple-50 are darker than --purple-30. * However, we do not have a standard lighter purple in our current set of * Photon colors. * See tor-browser#42025 */ - --in-content-link-color-hover: var(--purple-40); - --in-content-link-color-active: var(--purple-50); + --link-color-hover: var(--purple-40); + --link-color-active: var(--purple-50); } #search-form { ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -913,7 +913,7 @@ dialog#torPreferences-requestBridge-dialog > hbox { } #lox-invite-dialog-error-message { - color: var(--in-content-error-text-color); + color: var(--text-color-error); } #lox-invite-dialog-generate-area:not(.show-error) #lox-invite-dialog-error-message { @@ -1049,7 +1049,7 @@ groupbox#torPreferences-bridges-group textarea { } #user-provide-bridge-error-message { - color: var(--in-content-error-text-color); + color: var(--text-color-error); } #user-provide-bridge-dialog:not(.show-error) #user-provide-bridge-error-message { ===================================== toolkit/components/torconnect/content/aboutTorConnect.css ===================================== @@ -154,7 +154,7 @@ button { } #locationDropdownLabel.error { - color: var(--in-content-error-text-color) + color: var(--text-color-error) } #tryBridgeButton.danger-button { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fdad7c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fdad7c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 656fcdfc by Henry Wilkes at 2024-08-07T22:53:49+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/656… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/656… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a67e4520 by Henry Wilkes at 2024-08-07T22:50:45+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e452… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e452… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 08 Aug '24

08 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: fdad7c54 by Henry Wilkes at 2024-08-07T22:46:23+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdad7c5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdad7c5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41202: Remove restricted entitlements
by morgan (＠morgan) 07 Aug '24

07 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 4d4e1380 by Nicolas Vigier at 2024-08-06T15:43:19+02:00 Bug 41202: Remove restricted entitlements Remove the following restricted entitlements: * com.apple.application-identifier * com.apple.developer.web-browser.public-key-credential https://searchfox.org/mozilla-central/source/tools/signing/macos/mach_comma… - - - - - 1 changed file: - tools/signing/macos-entitlements/firefox.browser.xml Changes: ===================================== tools/signing/macos-entitlements/firefox.browser.xml ===================================== @@ -23,12 +23,5 @@  <key>com.apple.security.smartcard</key><true/> - -  - <key>com.apple.application-identifier</key> - <string>43AQ936H96.org.mozilla.firefox</string> - -  - <key>com.apple.developer.web-browser.public-key-credential</key><true/> </dict> </plist> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by morgan (＠morgan) 07 Aug '24

07 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 95ec0dcc by Henry Wilkes at 2024-08-07T21:39:39+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42488: Remove redundant role="code" from ip address <code> element. After ESR 128, the <code> element has an implicit "code" accessible role. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.js Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -617,19 +617,10 @@ var gTorCircuitPanel = { } else { addressesEl.append(", "); } + // Use semantic <code> block for the ip addresses, so the content + // (especially punctuation) can be better interpreted by screen readers, + // if they support this. const ipEl = document.createElement("code"); - // TODO: Current HTML-aam 1.0 specs map the <code> element to the "code" - // role. - // However, mozilla-central commented out this mapping in - // accessible/base/HTMLMarkupMap.h because the HTML-aam specs at the - // time did not do this. - // See hg.mozilla.org/mozilla-central/rev/51eebe7d6199#l2.12 - // - // This was updated in mozilla bug 1834931, for ESR 128 - // - // For now we explicitly add the role="code", but once this is fixed - // from mozilla-central we should remove this. - ipEl.setAttribute("role", "code"); ipEl.classList.add("tor-circuit-ip-address"); ipEl.textContent = ip; addressesEl.append(ipEl); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95ec0dc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95ec0dc… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Customize moz-toggle for tor-browser.
by morgan (＠morgan) 07 Aug '24

07 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ab241f69 by Henry Wilkes at 2024-08-07T21:22:16+00:00 fixup! Customize moz-toggle for tor-browser. Bug 42612: Reimplement the moz-toggle customization for 128 ESR. - - - - - 1 changed file: - toolkit/content/widgets/moz-toggle/moz-toggle.mjs Changes: ===================================== toolkit/content/widgets/moz-toggle/moz-toggle.mjs ===================================== @@ -34,6 +34,10 @@ export default class MozToggle extends MozLitElement { description: { type: String }, ariaLabel: { type: String, attribute: "aria-label" }, accessKey: { type: String, attribute: "accesskey" }, + // Extension for tor-browser. Used for tor-browser#41333. + title: { type: String, attribute: "title" }, + // Extension for tor-browser. Used for tor-browser#40837. + labelAlignAfter: { type: Boolean, attribute: "label-align-after" }, }; static get queries() { @@ -111,7 +115,11 @@ export default class MozToggle extends MozLitElement { } render() { - // TODO: Reimplement labelAlignAfter! + // For tor-browser, we want to be able to place the label after the toggle + // as well. + // Used for the enable-bridges switch tor-browser#40837. + const labelAlignAfter = this.labelAlignAfter; + return html` <link rel="stylesheet" @@ -126,11 +134,12 @@ export default class MozToggle extends MozLitElement { for="moz-toggle-button" accesskey=${ifDefined(this.accessKey)} > + ${labelAlignAfter ? this.buttonTemplate() : ""} <span> ${this.label} ${!this.description ? this.supportLinkTemplate() : ""} </span> - ${this.buttonTemplate()} + ${labelAlignAfter ? "" : this.buttonTemplate()} </label> ` : this.buttonTemplate()} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ab241f6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ab241f6… You're receiving this email because of your account on gitlab.torproject.org.

1 0