- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! BB 43322: Customize the font visibility lists.
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: e4ee090b by Pier Angelo Vendrame at 2025-07-30T10:59:35+02:00 fixup! BB 43322: Customize the font visibility lists. BB 44046: Replace the macro we use in StandardFonts-win10.inc. For consistency with other changes in the same commit, we should use BASE_BROWSER_VERSION rather than BASE_BROWSER_UPDATE. - - - - - 1 changed file: - gfx/thebes/StandardFonts-win10.inc Changes: ===================================== gfx/thebes/StandardFonts-win10.inc ===================================== @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifndef BASE_BROWSER_UPDATE +#ifndef BASE_BROWSER_VERSION // List of standard font families installed as part of Windows 10 // from https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list // TODO: check whether we need to list legacy styled family names like "... Light". View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4ee090… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4ee090… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser
by henry (＠henry) 29 Jul '25

29 Jul '25

henry pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 44539ee4 by Henry Wilkes at 2025-07-29T16:01:24+00:00 fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser TB 43832: Drop eslint-env - - - - - 1 changed file: - toolkit/components/torconnect/content/torConnectUrlbarButton.js Changes: ===================================== toolkit/components/torconnect/content/torConnectUrlbarButton.js ===================================== @@ -1,5 +1,3 @@ -/* eslint-env mozilla/browser-window */ - /** * A "Connect" button shown in the urlbar when not connected to tor and in tabs * other than about:torconnect. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44539ee… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44539ee… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] TB 43817: Add tests for Tor Browser
by brizental (＠brizental) 29 Jul '25

29 Jul '25

brizental pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 692f39dc by Beatriz Rizental at 2025-07-29T17:03:46+02:00 TB 43817: Add tests for Tor Browser This is a catch all commits for adding any tests or testing infrastructure that doesn't obviously fit any other commit. - - - - - 3 changed files: - testing/moz.build - + testing/tor/marionette.toml - + testing/tor/test_network_check.py Changes: ===================================== testing/moz.build ===================================== @@ -17,3 +17,5 @@ DIRS += ["mozbase", "mozharness"] PERFTESTS_MANIFESTS += [ "performance/perftest.toml", ] + +MARIONETTE_MANIFESTS += ["tor/marionette.toml"] ===================================== testing/tor/marionette.toml ===================================== @@ -0,0 +1,3 @@ +[DEFAULT] + +["test_network_check.py"] ===================================== testing/tor/test_network_check.py ===================================== @@ -0,0 +1,68 @@ +from marionette_driver import By, Wait, errors +from marionette_driver.localization import L10n +from marionette_harness import MarionetteTestCase + +NETWORK_CHECK_URL = "https://check.torproject.org/" +TOR_BOOTSTRAP_TIMEOUT = 30 # 30s + +STRINGS_LOCATION = "chrome://torbutton/locale/torConnect.properties" + + +class TestNetworkCheck(MarionetteTestCase): + def setUp(self): + MarionetteTestCase.setUp(self) + + self.l10n = L10n(self.marionette) + + def attemptConnection(self, tries=1): + if tries > 3: + self.assertTrue(False, "Failed to connect to Tor after 3 attempts") + + connectBtn = self.marionette.find_element(By.ID, "connectButton") + Wait(self.marionette, timeout=10).until( + lambda _: connectBtn.is_displayed(), + message="Timed out waiting for tor connect button to show up.", + ) + connectBtn.click() + + try: + + def check(m): + if not m.get_url().startswith("about:torconnect"): + # We have finished connecting and have been redirected. + return True + + try: + heading = self.marionette.find_element(By.ID, "tor-connect-heading") + except errors.NoSuchElementException: + # Page is probably redirecting. + return False + + if heading.text not in [ + self.l10n.localize_property( + [STRINGS_LOCATION], "torConnect.torConnecting" + ), + self.l10n.localize_property( + [STRINGS_LOCATION], "torConnect.torConnected" + ), + ]: + raise ValueError("Tor connect page is not connecting or connected") + + return False + + Wait(self.marionette, timeout=TOR_BOOTSTRAP_TIMEOUT).until(check) + except (errors.TimeoutException, ValueError): + cancelBtn = self.marionette.find_element(By.ID, "cancelButton") + if cancelBtn.is_displayed(): + cancelBtn.click() + + self.attemptConnection(tries + 1) + + def test_network_check(self): + self.attemptConnection() + self.marionette.navigate(NETWORK_CHECK_URL) + self.assertRegex( + self.marionette.title, + r"^Congratulations\.", + f"{NETWORK_CHECK_URL} should have the expected title.", + ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/692f39d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/692f39d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! BB 41581: Hide NoScript extension's toolbar button by default.
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 1168363d by Henry Wilkes at 2025-07-29T13:02:04+00:00 fixup! BB 41581: Hide NoScript extension's toolbar button by default. TB 43874: Incorporate our unified extension button hiding logic into mozilla's changes for ESR 140. - - - - - 2 changed files: - browser/base/content/browser-addons.js - browser/themes/shared/addons/unified-extensions.css Changes: ===================================== browser/base/content/browser-addons.js ===================================== @@ -2026,13 +2026,13 @@ var gUnifiedExtensions = { // extension.hideUnifiedWhenEmpty, which can effect the visibility of the // unified-extensions-button. // See tor-browser#41581. - this._hideNoScriptObserver = () => this._updateVisibility(); + this._hideNoScriptObserver = () => this._updateHideEmpty(); Services.prefs.addObserver(HIDE_NO_SCRIPT_PREF, this._hideNoScriptObserver); Services.prefs.addObserver( HIDE_UNIFIED_WHEN_EMPTY_PREF, this._hideNoScriptObserver ); - this._updateVisibility(); + this._updateHideEmpty(); // Will trigger updateButtonVisibility; this._initialized = true; }, @@ -2071,10 +2071,14 @@ var gUnifiedExtensions = { }, onAppMenuShowing() { + // Only show the extension menu item if the extension button is not pinned + // and the extension popup is not empty. + // NOTE: This condition is different than _shouldShowButton. + const hideExtensionItem = this.buttonAlwaysVisible || this._hideEmpty; document.getElementById("appMenu-extensions-themes-button").hidden = - !this.buttonAlwaysVisible; + !hideExtensionItem; document.getElementById("appMenu-unified-extensions-button").hidden = - this.buttonAlwaysVisible; + hideExtensionItem; }, onLocationChange(browser, webProgress, _request, _uri, flags) { @@ -2089,9 +2093,14 @@ var gUnifiedExtensions = { }, updateButtonVisibility() { + if (this._hideEmpty === null) { + return; + } // TODO: Bug 1778684 - Auto-hide button when there is no active extension. + // Hide the extension button when it is empty. See tor-browser#41581. + // Likely will conflict with mozilla's Bug 1778684. See tor-browser#42635. let shouldShowButton = - this.buttonAlwaysVisible || + this._shouldShowButton || // If anything is anchored to the button, keep it visible. this._button.open || // Button will be open soon - see ensureButtonShownBeforeAttachingPanel. @@ -2117,7 +2126,7 @@ var gUnifiedExtensions = { }, ensureButtonShownBeforeAttachingPanel(panel) { - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { // When the panel is anchored to the button, its "open" attribute will be // set, which visually renders as a "button pressed". Until we get there, // we need to make sure that the button is visible so that it can serve @@ -2131,7 +2140,7 @@ var gUnifiedExtensions = { if (this._button.open) { this._buttonShownBeforeButtonOpen = false; } - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { this.updateButtonVisibility(); } }, @@ -2261,18 +2270,35 @@ var gUnifiedExtensions = { }, /** - * Potentially hide the unified-extensions-button if it would be empty. + * Whether the extension button should be hidden because it is empty. Or + * `null` when uninitialised. + * + * @type {?boolean} */ - // See tor-browser#41581. - // The behaviour overlaps with a proposal in mozilla Bug 1778684, which has - // not yet been implemented as of June 2024 (start of ESR 128). - // See tor-browser#42635 - _updateVisibility() { - this.button.classList.toggle( - "hide-empty", + _hideEmpty: null, + + /** + * Update the _hideEmpty attribute when the preference or hasExtensionsInPanel + * value may have changed. + */ + _updateHideEmpty() { + const prevHideEmpty = this._hideEmpty; + this._hideEmpty = Services.prefs.getBoolPref(HIDE_UNIFIED_WHEN_EMPTY_PREF, true) && - !this.hasExtensionsInPanel() - ); + !this.hasExtensionsInPanel(); + if (this._hideEmpty !== prevHideEmpty) { + this.updateButtonVisibility(); + } + }, + + /** + * Whether we should show the extension button, regardless of whether it is + * needed as a popup anchor, etc. + * + * @type {boolean} + */ + get _shouldShowButton() { + return this.buttonAlwaysVisible && !this._hideEmpty; }, /** @@ -2860,15 +2886,18 @@ var gUnifiedExtensions = { }, onWidgetRemoved() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetDestroyed() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetAdded(aWidgetId, aArea) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // When we pin a widget to the toolbar from a narrow window, the widget // will be overflowed directly. In this case, we do not want to change the @@ -2885,7 +2914,8 @@ var gUnifiedExtensions = { }, onWidgetOverflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. @@ -2897,7 +2927,8 @@ var gUnifiedExtensions = { }, onWidgetUnderflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. ===================================== browser/themes/shared/addons/unified-extensions.css ===================================== @@ -294,21 +294,3 @@ unified-extensions-item.unified-extensions-item { } } } - -/* Extra rule for tor-browser. See tor-browser#41581. - * We want to hide the unified-extensions-button when it is empty. - * However, this button is needed as an anchor for addon notifications. E.g. - * when installing another addon and permissions pop up. - * If we simply marked it as "hidden" then it would not be used as an anchor, so - * the popup would fall back to using the identity button as an anchor instead. - * So instead, we use "visibility: collapse" whilst it is empty *and* it is not - * being used as an anchor (the open attribute is missing). */ -#unified-extensions-button.hide-empty:not([open]) { - visibility: collapse; - /* Ensure getBoundingClientRect().width returns 0. - * Even though this button is collapsed, and therefore should not take up any - * layout space, getBoundingClientRect will still measure the padding. - * If this was not zero, OverflowableToolbar#getOverflowInfo would - * over-measure the children width and would always overflow. */ - padding-inline: 0; -} View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/116… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/116… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] fixup! BB 41581: Hide NoScript extension's toolbar button by default.
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: e4587c0b by Henry Wilkes at 2025-07-29T13:00:05+00:00 fixup! BB 41581: Hide NoScript extension's toolbar button by default. TB 43874: Incorporate our unified extension button hiding logic into mozilla's changes for ESR 140. - - - - - 2 changed files: - browser/base/content/browser-addons.js - browser/themes/shared/addons/unified-extensions.css Changes: ===================================== browser/base/content/browser-addons.js ===================================== @@ -2026,13 +2026,13 @@ var gUnifiedExtensions = { // extension.hideUnifiedWhenEmpty, which can effect the visibility of the // unified-extensions-button. // See tor-browser#41581. - this._hideNoScriptObserver = () => this._updateVisibility(); + this._hideNoScriptObserver = () => this._updateHideEmpty(); Services.prefs.addObserver(HIDE_NO_SCRIPT_PREF, this._hideNoScriptObserver); Services.prefs.addObserver( HIDE_UNIFIED_WHEN_EMPTY_PREF, this._hideNoScriptObserver ); - this._updateVisibility(); + this._updateHideEmpty(); // Will trigger updateButtonVisibility; this._initialized = true; }, @@ -2071,10 +2071,14 @@ var gUnifiedExtensions = { }, onAppMenuShowing() { + // Only show the extension menu item if the extension button is not pinned + // and the extension popup is not empty. + // NOTE: This condition is different than _shouldShowButton. + const hideExtensionItem = this.buttonAlwaysVisible || this._hideEmpty; document.getElementById("appMenu-extensions-themes-button").hidden = - !this.buttonAlwaysVisible; + !hideExtensionItem; document.getElementById("appMenu-unified-extensions-button").hidden = - this.buttonAlwaysVisible; + hideExtensionItem; }, onLocationChange(browser, webProgress, _request, _uri, flags) { @@ -2089,9 +2093,14 @@ var gUnifiedExtensions = { }, updateButtonVisibility() { + if (this._hideEmpty === null) { + return; + } // TODO: Bug 1778684 - Auto-hide button when there is no active extension. + // Hide the extension button when it is empty. See tor-browser#41581. + // Likely will conflict with mozilla's Bug 1778684. See tor-browser#42635. let shouldShowButton = - this.buttonAlwaysVisible || + this._shouldShowButton || // If anything is anchored to the button, keep it visible. this._button.open || // Button will be open soon - see ensureButtonShownBeforeAttachingPanel. @@ -2117,7 +2126,7 @@ var gUnifiedExtensions = { }, ensureButtonShownBeforeAttachingPanel(panel) { - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { // When the panel is anchored to the button, its "open" attribute will be // set, which visually renders as a "button pressed". Until we get there, // we need to make sure that the button is visible so that it can serve @@ -2131,7 +2140,7 @@ var gUnifiedExtensions = { if (this._button.open) { this._buttonShownBeforeButtonOpen = false; } - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { this.updateButtonVisibility(); } }, @@ -2261,18 +2270,35 @@ var gUnifiedExtensions = { }, /** - * Potentially hide the unified-extensions-button if it would be empty. + * Whether the extension button should be hidden because it is empty. Or + * `null` when uninitialised. + * + * @type {?boolean} */ - // See tor-browser#41581. - // The behaviour overlaps with a proposal in mozilla Bug 1778684, which has - // not yet been implemented as of June 2024 (start of ESR 128). - // See tor-browser#42635 - _updateVisibility() { - this.button.classList.toggle( - "hide-empty", + _hideEmpty: null, + + /** + * Update the _hideEmpty attribute when the preference or hasExtensionsInPanel + * value may have changed. + */ + _updateHideEmpty() { + const prevHideEmpty = this._hideEmpty; + this._hideEmpty = Services.prefs.getBoolPref(HIDE_UNIFIED_WHEN_EMPTY_PREF, true) && - !this.hasExtensionsInPanel() - ); + !this.hasExtensionsInPanel(); + if (this._hideEmpty !== prevHideEmpty) { + this.updateButtonVisibility(); + } + }, + + /** + * Whether we should show the extension button, regardless of whether it is + * needed as a popup anchor, etc. + * + * @type {boolean} + */ + get _shouldShowButton() { + return this.buttonAlwaysVisible && !this._hideEmpty; }, /** @@ -2860,15 +2886,18 @@ var gUnifiedExtensions = { }, onWidgetRemoved() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetDestroyed() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetAdded(aWidgetId, aArea) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // When we pin a widget to the toolbar from a narrow window, the widget // will be overflowed directly. In this case, we do not want to change the @@ -2885,7 +2914,8 @@ var gUnifiedExtensions = { }, onWidgetOverflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. @@ -2897,7 +2927,8 @@ var gUnifiedExtensions = { }, onWidgetUnderflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. ===================================== browser/themes/shared/addons/unified-extensions.css ===================================== @@ -294,21 +294,3 @@ unified-extensions-item.unified-extensions-item { } } } - -/* Extra rule for tor-browser. See tor-browser#41581. - * We want to hide the unified-extensions-button when it is empty. - * However, this button is needed as an anchor for addon notifications. E.g. - * when installing another addon and permissions pop up. - * If we simply marked it as "hidden" then it would not be used as an anchor, so - * the popup would fall back to using the identity button as an anchor instead. - * So instead, we use "visibility: collapse" whilst it is empty *and* it is not - * being used as an anchor (the open attribute is missing). */ -#unified-extensions-button.hide-empty:not([open]) { - visibility: collapse; - /* Ensure getBoundingClientRect().width returns 0. - * Even though this button is collapsed, and therefore should not take up any - * layout space, getBoundingClientRect will still measure the padding. - * If this was not zero, OverflowableToolbar#getOverflowInfo would - * over-measure the children width and would always overflow. */ - padding-inline: 0; -} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4587c0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4587c0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! BB 41581: Hide NoScript extension's toolbar button by default.
by henry (＠henry) 29 Jul '25

29 Jul '25

henry pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: cf9b46aa by Henry Wilkes at 2025-07-29T12:33:19+01:00 fixup! BB 41581: Hide NoScript extension's toolbar button by default. TB 43874: Incorporate our unified extension button hiding logic into mozilla's changes for ESR 140. - - - - - 2 changed files: - browser/base/content/browser-addons.js - browser/themes/shared/addons/unified-extensions.css Changes: ===================================== browser/base/content/browser-addons.js ===================================== @@ -2026,13 +2026,13 @@ var gUnifiedExtensions = { // extension.hideUnifiedWhenEmpty, which can effect the visibility of the // unified-extensions-button. // See tor-browser#41581. - this._hideNoScriptObserver = () => this._updateVisibility(); + this._hideNoScriptObserver = () => this._updateHideEmpty(); Services.prefs.addObserver(HIDE_NO_SCRIPT_PREF, this._hideNoScriptObserver); Services.prefs.addObserver( HIDE_UNIFIED_WHEN_EMPTY_PREF, this._hideNoScriptObserver ); - this._updateVisibility(); + this._updateHideEmpty(); // Will trigger updateButtonVisibility; this._initialized = true; }, @@ -2071,10 +2071,14 @@ var gUnifiedExtensions = { }, onAppMenuShowing() { + // Only show the extension menu item if the extension button is not pinned + // and the extension popup is not empty. + // NOTE: This condition is different than _shouldShowButton. + const hideExtensionItem = this.buttonAlwaysVisible || this._hideEmpty; document.getElementById("appMenu-extensions-themes-button").hidden = - !this.buttonAlwaysVisible; + !hideExtensionItem; document.getElementById("appMenu-unified-extensions-button").hidden = - this.buttonAlwaysVisible; + hideExtensionItem; }, onLocationChange(browser, webProgress, _request, _uri, flags) { @@ -2089,9 +2093,14 @@ var gUnifiedExtensions = { }, updateButtonVisibility() { + if (this._hideEmpty === null) { + return; + } // TODO: Bug 1778684 - Auto-hide button when there is no active extension. + // Hide the extension button when it is empty. See tor-browser#41581. + // Likely will conflict with mozilla's Bug 1778684. See tor-browser#42635. let shouldShowButton = - this.buttonAlwaysVisible || + this._shouldShowButton || // If anything is anchored to the button, keep it visible. this._button.open || // Button will be open soon - see ensureButtonShownBeforeAttachingPanel. @@ -2117,7 +2126,7 @@ var gUnifiedExtensions = { }, ensureButtonShownBeforeAttachingPanel(panel) { - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { // When the panel is anchored to the button, its "open" attribute will be // set, which visually renders as a "button pressed". Until we get there, // we need to make sure that the button is visible so that it can serve @@ -2131,7 +2140,7 @@ var gUnifiedExtensions = { if (this._button.open) { this._buttonShownBeforeButtonOpen = false; } - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { this.updateButtonVisibility(); } }, @@ -2261,18 +2270,35 @@ var gUnifiedExtensions = { }, /** - * Potentially hide the unified-extensions-button if it would be empty. + * Whether the extension button should be hidden because it is empty. Or + * `null` when uninitialised. + * + * @type {?boolean} */ - // See tor-browser#41581. - // The behaviour overlaps with a proposal in mozilla Bug 1778684, which has - // not yet been implemented as of June 2024 (start of ESR 128). - // See tor-browser#42635 - _updateVisibility() { - this.button.classList.toggle( - "hide-empty", + _hideEmpty: null, + + /** + * Update the _hideEmpty attribute when the preference or hasExtensionsInPanel + * value may have changed. + */ + _updateHideEmpty() { + const prevHideEmpty = this._hideEmpty; + this._hideEmpty = Services.prefs.getBoolPref(HIDE_UNIFIED_WHEN_EMPTY_PREF, true) && - !this.hasExtensionsInPanel() - ); + !this.hasExtensionsInPanel(); + if (this._hideEmpty !== prevHideEmpty) { + this.updateButtonVisibility(); + } + }, + + /** + * Whether we should show the extension button, regardless of whether it is + * needed as a popup anchor, etc. + * + * @type {boolean} + */ + get _shouldShowButton() { + return this.buttonAlwaysVisible && !this._hideEmpty; }, /** @@ -2860,15 +2886,18 @@ var gUnifiedExtensions = { }, onWidgetRemoved() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetDestroyed() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetAdded(aWidgetId, aArea) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // When we pin a widget to the toolbar from a narrow window, the widget // will be overflowed directly. In this case, we do not want to change the @@ -2885,7 +2914,8 @@ var gUnifiedExtensions = { }, onWidgetOverflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. @@ -2897,7 +2927,8 @@ var gUnifiedExtensions = { }, onWidgetUnderflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. ===================================== browser/themes/shared/addons/unified-extensions.css ===================================== @@ -294,21 +294,3 @@ unified-extensions-item.unified-extensions-item { } } } - -/* Extra rule for tor-browser. See tor-browser#41581. - * We want to hide the unified-extensions-button when it is empty. - * However, this button is needed as an anchor for addon notifications. E.g. - * when installing another addon and permissions pop up. - * If we simply marked it as "hidden" then it would not be used as an anchor, so - * the popup would fall back to using the identity button as an anchor instead. - * So instead, we use "visibility: collapse" whilst it is empty *and* it is not - * being used as an anchor (the open attribute is missing). */ -#unified-extensions-button.hide-empty:not([open]) { - visibility: collapse; - /* Ensure getBoundingClientRect().width returns 0. - * Even though this button is collapsed, and therefore should not take up any - * layout space, getBoundingClientRect will still measure the padding. - * If this was not zero, OverflowableToolbar#getOverflowInfo would - * over-measure the children width and would always overflow. */ - padding-inline: 0; -} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cf9b46a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cf9b46a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-15.0a1-build1
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed new tag mb-15.0a1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-15.0a1-build1
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed new tag tbb-15.0a1-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41439,41440: Release Prep Tor,Mullvad Browser 15.0a1
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 47f95213 by Morgan at 2025-07-29T10:54:45+00:00 Bug 41439,41440: Release Prep Tor,Mullvad Browser 15.0a1 - - - - - 11 changed files: - projects/application-services/config - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/config - projects/firefox/config - projects/geckoview/config - projects/go/config - projects/manual/config - projects/openssl/config - projects/translation/config - rbm.conf Changes: ===================================== projects/application-services/config ===================================== @@ -16,7 +16,7 @@ container: use_container: 1 var: - build_number: 2 + build_number: 3 # This should be updated when the list of gradle dependencies is changed. gradle_dependencies_version: 12 gradle_version: 8.13 ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -1,3 +1,57 @@ +Mullvad Browser 15.0a1 - July 29 2025 + * All Platforms + * Updated Firefox to 140.1.0esr + * Updated NoScript to 13.0.8 + * Updated uBlock Origin to 1.65.0 + * Bug 457: Rebase Mullvad Browser Alpha onto 140.1esr [mullvad-browser] + * Bug 42738: Tidy up the commit structure for browser updates UI [tor-browser] + * Bug 43397: Click to play should override "Any capability blocked in the top document must be blocked in its subdocuments too" [tor-browser] + * Bug 43590: Move letterboxing rules out of browser/base/content/browser.css [tor-browser] + * Bug 43610: Use newer CSS variable names for ESR 140 [tor-browser] + * Bug 43629: All migrations in _migrateUIBB are run for new profiles [tor-browser] + * Bug 43635: Console noise due to the x-load capability not being localized [tor-browser] + * Bug 43638: Fix up our `<command>` elements [tor-browser] + * Bug 43772: Do not use official branding for BB/TB/MB [tor-browser] + * Bug 43776: Set branding files for l10n merging [tor-browser] + * Bug 43886: Fix new tab for ESR 140 [tor-browser] + * Bug 43905: base-browser.ftl missing from about:addons [tor-browser] + * Bug 43906: Extension.sys.mjs change in the wrong commit [tor-browser] + * Bug 43929: two about:tor pages opened after update [tor-browser] + * Bug 43947: Console error from ContentBlockingPrefs.init [tor-browser] + * Bug 43989: Switch off AI chatbot preference [tor-browser] + * Bug 43993: Backport Security Fixes from Firefox 141 [tor-browser] + * Windows + * Bug 440: Make abseil use win32 thread model on mingw [mullvad-browser] + * Build System + * All Platforms + * Bug 43777: Disable ./mach telemetry [tor-browser] + * Bug 43891: Update the translation CI to use the new mozilla versions [tor-browser] + * Bug 34434: Remove unused variables from rbm.conf [tor-browser-build] + * Bug 40994: Add support in do-all-signing to sign release for some archs only [tor-browser-build] + * Bug 41227: Update projects/common/list_toolchain_updates-common-firefox-geckoview to include check for binutils [tor-browser-build] + * Bug 41435: Skip update-responses update entries for versions without incremental or full update mar [tor-browser-build] + * Bug 41444: Build artifacts to support artifact builds of Tor/Muillvad/Base Browser [tor-browser-build] + * Bug 41448: Update toolchains for Firefox ESR 140 [tor-browser-build] + * Bug 41449: Add prefix to update-responses xml files [tor-browser-build] + * Bug 41451: When update-responses contains multiple versions, .htaccess only has one no-update.xml redirect [tor-browser-build] + * Bug 41452: Skip update-responses xml files for versions which don't have incrementals [tor-browser-build] + * Bug 41457: Set mar IDs as env variables in tor-browser-build [tor-browser-build] + * Bug 41459: Update taskcluster/ci paths in README and comments [tor-browser-build] + * Bug 41460: Add brizental to the list of people who can sign Tor Browser and Mullvad Browser tags [tor-browser-build] + * Bug 41465: Disable development artifacts generation by default, keep it enabled for nightly builds [tor-browser-build] + * Bug 41467: Remove list_toolchain_updates-firefox-android from Makefile [tor-browser-build] + * Bug 41477: Update keyring/boklm.gpg for new subkeys (2025) [tor-browser-build] + * Bug 41478: Add vim and others missing basic tools to base container image [tor-browser-build] + * Bug 41496: Clean up unused projects [tor-browser-build] + * Bug 41498: Update keyring/morgan.gpg with updated public key [tor-browser-build] + * Bug 41501: cargo_vendor generated archive maintains timestamps [tor-browser-build] + * Bug 40084: Always use bash for the debug terminal [rbm] + * macOS + * Bug 41503: Error 403 when downloading macOS SDK [tor-browser-build] + * Linux + * Bug 41458: Ship geckodriver only on Linux [tor-browser-build] + * Bug 41488: Disable sys/random.h for Node.js [tor-browser-build] + Mullvad Browser 14.5a6 - April 08 2025 * All Platforms * Updated Firefox to 128.9.0esr ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,99 @@ +Tor Browser 15.0a1 - July 29 2025 + * All Platforms + * Updated NoScript to 13.0.8 + * Updated OpenSSL to 3.5.1 + * Bug 43397: Click to play should override "Any capability blocked in the top document must be blocked in its subdocuments too" [tor-browser] + * Bug 43772: Do not use official branding for BB/TB/MB [tor-browser] + * Bug 43783: Tighten up the SecurityLevel module to enforce new UX flow [tor-browser] + * Bug 43784: Get confirmation from NoScript that settings are applied [tor-browser] + * Bug 43853: DomainFrontedRequests: setData is no longer a function [tor-browser] + * Bug 43880: Update moat's domain front url [tor-browser] + * Bug 43993: Backport Security Fixes from Firefox 141 [tor-browser] + * Bug 44000: Rebase Tor Browse Alpha onto 140.1.0esr [tor-browser] + * Bug 41502: Application services build is failing on isNetworkAllowed() [tor-browser-build] + * Bug 41508: Switch built-in meek bridge to meek-unredacted [tor-browser-build] + * Bug 41515: Bump version of Conjure to include P173 improvements [tor-browser-build] + * Windows + macOS + Linux + * Updated Firefox to 140.1.0esr + * Bug 42738: Tidy up the commit structure for browser updates UI [tor-browser] + * Bug 43590: Move letterboxing rules out of browser/base/content/browser.css [tor-browser] + * Bug 43610: Use newer CSS variable names for ESR 140 [tor-browser] + * Bug 43629: All migrations in _migrateUIBB are run for new profiles [tor-browser] + * Bug 43635: Console noise due to the x-load capability not being localized [tor-browser] + * Bug 43638: Fix up our `<command>` elements [tor-browser] + * Bug 43765: Temporarily disable Lox [tor-browser] + * Bug 43766: Only save the relevant TorSettings changes to preferences. [tor-browser] + * Bug 43776: Set branding files for l10n merging [tor-browser] + * Bug 43782: Add new UX flow for changing security level (Desktop) [tor-browser] + * Bug 43879: tor-branding.css declarations are overwritten [tor-browser] + * Bug 43886: Fix new tab for ESR 140 [tor-browser] + * Bug 43905: base-browser.ftl missing from about:addons [tor-browser] + * Bug 43906: Extension.sys.mjs change in the wrong commit [tor-browser] + * Bug 43913: Bizarre right-clicking issues: menu items blanked out and/or not working; too many items in the right-click menu; different right-clicking menu displayed initially for links [tor-browser] + * Bug 43929: two about:tor pages opened after update [tor-browser] + * Bug 43930: Onionize toggle not centre aligned in about:tor [tor-browser] + * Bug 43947: Console error from ContentBlockingPrefs.init [tor-browser] + * Bug 43989: Switch off AI chatbot preference [tor-browser] + * Android + * Updated GeckoView to 140.1.0esr + * Bug 43577: Flush settings fails on Android [tor-browser] + * Bug 43786: Add new UX flow for changing security level (Android) [tor-browser] + * Bug 43855: brand.properties merging on Android is broken in 140 [tor-browser] + * Bug 44029: Search/url bar doesn't work on android after ESR 140 [tor-browser] + * Bug 44036: Crash on opening "Search Settings" on android [tor-browser] + * Bug 41494: Update GeckoView build scripts for ESR140 [tor-browser-build] + * Build System + * All Platforms + * Bug 43615: Add Gitlab Issue and Merge request templates [tor-browser] + * Bug 43616: Customize Gitlab Issue and Merge templates [tor-browser] + * Bug 43777: Disable ./mach telemetry [tor-browser] + * Bug 43891: Update the translation CI to use the new mozilla versions [tor-browser] + * Bug 43954: Update tb-dev to handle lightweight tags [tor-browser] + * Bug 43962: update tb-dev auto-fixup for git 2.50 [tor-browser] + * Bug 34434: Remove unused variables from rbm.conf [tor-browser-build] + * Bug 40994: Add support in do-all-signing to sign release for some archs only [tor-browser-build] + * Bug 41227: Update projects/common/list_toolchain_updates-common-firefox-geckoview to include check for binutils [tor-browser-build] + * Bug 41432: Bump OpenSSL to >= 3.5.0 [tor-browser-build] + * Bug 41434: Go updates shouldn't target all platforms until macOS is on legacy in the changelogs [tor-browser-build] + * Bug 41435: Skip update-responses update entries for versions without incremental or full update mar [tor-browser-build] + * Bug 41444: Build artifacts to support artifact builds of Tor/Muillvad/Base Browser [tor-browser-build] + * Bug 41448: Update toolchains for Firefox ESR 140 [tor-browser-build] + * Bug 41449: Add prefix to update-responses xml files [tor-browser-build] + * Bug 41451: When update-responses contains multiple versions, .htaccess only has one no-update.xml redirect [tor-browser-build] + * Bug 41459: Update taskcluster/ci paths in README and comments [tor-browser-build] + * Bug 41460: Add brizental to the list of people who can sign Tor Browser and Mullvad Browser tags [tor-browser-build] + * Bug 41465: Disable development artifacts generation by default, keep it enabled for nightly builds [tor-browser-build] + * Bug 41467: Remove list_toolchain_updates-firefox-android from Makefile [tor-browser-build] + * Bug 41477: Update keyring/boklm.gpg for new subkeys (2025) [tor-browser-build] + * Bug 41478: Add vim and others missing basic tools to base container image [tor-browser-build] + * Bug 41486: Track bundletool and osslicenses-plugin versions in list_toolchain_updates_checks [tor-browser-build] + * Bug 41496: Clean up unused projects [tor-browser-build] + * Bug 41498: Update keyring/morgan.gpg with updated public key [tor-browser-build] + * Bug 41501: cargo_vendor generated archive maintains timestamps [tor-browser-build] + * Bug 41514: Remove var/build_go_lib from projects/go/config [tor-browser-build] + * Bug 40084: Always use bash for the debug terminal [rbm] + * Windows + macOS + Linux + * Bug 41452: Skip update-responses xml files for versions which don't have incrementals [tor-browser-build] + * Bug 41457: Set mar IDs as env variables in tor-browser-build [tor-browser-build] + * Windows + Linux + Android + * Updated Go to 1.23.11 + * macOS + * Bug 41503: Error 403 when downloading macOS SDK [tor-browser-build] + * Linux + * Bug 41458: Ship geckodriver only on Linux [tor-browser-build] + * Bug 41488: Disable sys/random.h for Node.js [tor-browser-build] + * Android + * Bug 43984: Update android build scripts and docs for ESR 140 [tor-browser] + * Bug 43987: 140 Android is not reproducible [tor-browser] + * Bug 41280: download-android-<arch>.json does not get updated for android-only releases [tor-browser-build] + * Bug 41453: Update application-services and uniffi-rs for ESR140 [tor-browser-build] + * Bug 41483: geckoview_example-withGeckoBinaries-....apk doesn't exist anymore in Firefox 140 [tor-browser-build] + * Bug 41484: Create a fork of application-services [tor-browser-build] + * Bug 41499: Android nightly builds are broken [tor-browser-build] + * Bug 41500: Optimize tor and its dependencies for size on Android [tor-browser-build] + * Bug 41506: Use appilcation-services branch for nightlies builds [tor-browser-build] + * Bug 41507: Single-arch build fails because artifacts don't have arch subdirectories [tor-browser-build] + Tor Browser 14.5a6 - April 08 2025 * All Platforms * Updated Tor to 0.4.9.2-alpha ===================================== projects/browser/config ===================================== @@ -113,12 +113,12 @@ input_files: enable: '[% ! c("var/android") %]' - filename: dmg-root enable: '[% ! c("var/android") %]' - - URL: https://addons.mozilla.org/firefox/downloads/file/4411102/noscript-12.1.1.x… + - URL: https://addons.mozilla.org/firefox/downloads/file/4497468/noscript-13.0.8.x… name: noscript - sha256sum: f9639e63ffcfc352036de00e4ff6694bb0ca65a0bb8fbd103bd08f32dc1ff31a - - URL: https://addons.mozilla.org/firefox/downloads/file/4458450/ublock_origin-1.6… + sha256sum: 9d978cfe083cb9cce120b5ee41e8933d752d7ab4680bf517c5ec4b29c4cfd2dc + - URL: https://addons.mozilla.org/firefox/downloads/file/4531307/ublock_origin-1.6… name: ublock-origin - sha256sum: d93176cef4dc042e41ba500aa2a90e5d57b5be77449cbd522111585e3a0cd158 + sha256sum: 3e73c96a29a933866065f0756fe032984bf5b254af8dd1afd7a7f7e0668a33cf enable: '[% c("var/mullvad-browser") %]' - URL: https://cdn.mullvad.net/browser-extension/0.9.4/mullvad-browser-extension-0… name: mullvad-extension ===================================== projects/firefox/config ===================================== @@ -21,7 +21,7 @@ var: browser_series: '15.0' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 1 + browser_build: 3 copyright_year: '[% exec("git show -s --format=%ci " _ c("git_hash") _ "^{commit}", { exec_noco => 1 }).remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser @@ -115,6 +115,7 @@ targets: mar_id_prefix: 'mullvadbrowser-mullvad' nightly_updates_publish_dir_prefix: mullvadbrowser- + browser_build: 1 linux-x86_64: var: arch_deps: ===================================== projects/geckoview/config ===================================== @@ -23,7 +23,7 @@ var: browser_series: '15.0' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 1 + browser_build: 3 gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser git_commit: '[% exec("git rev-parse " _ c("git_hash") _ "^{commit}", { exec_noco => 1 }) %]' deps: ===================================== projects/go/config ===================================== @@ -1,11 +1,11 @@ # vim: filetype=yaml sw=2 -version: '1.23.8' +version: '1.23.11' filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 var: - source_sha256: 0ca1f1e37ea255e3ce283af3f4e628502fb444587da987a5bb96d6c6f15930d4 + source_sha256: 296381607a483a8a8667d7695331752f94a1f231c204e2527d2f22e1e3d1247d no_crosscompile: 1 setup: | mkdir -p /var/tmp/dist ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 263551 +version: 295391 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -23,6 +23,6 @@ input_files: - project: container-image - URL: 'https://build-sources.tbb.torproject.org/manual_[% c("version") %].zip' name: manual - sha256sum: f8d312081457b1cab3e8fcafda1d0e534852b5d3c3cb1bd32100f13298cb7839 + sha256sum: feff63a5611438ae31c8237c9ce5cb463ec96cab07bd71f51a80ac5020d4e465 - filename: packagemanual.py name: package_script ===================================== projects/openssl/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 3.5.0 +version: 3.5.1 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -33,5 +33,5 @@ input_files: - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - URL: 'https://github.com/openssl/openssl/releases/download/openssl-[% c("version") %]/openssl-[% c("version") %].tar.gz' - sha256sum: 344d0a79f1a9b08029b0744e2cc401a43f9c90acd1044d09a530b4885a8e9fc0 + sha256sum: 529043b15cffa5f36077a4d0af83f3de399807181d607441d734196d889b641f name: openssl ===================================== projects/translation/config ===================================== @@ -12,19 +12,19 @@ compress_tar: 'gz' steps: base-browser: base-browser: '[% INCLUDE build %]' - git_hash: b54e21b36db35ad390c4f385b76cbd293a58cbc6 + git_hash: 96a559c7c1f7b9231db2b5cece7ecae980ae835d targets: nightly: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 94aae5dcdfa2e99b516acb6a834a54f7de76e54f + git_hash: 3becb908fbf68aa77accc1f2e03e2c29f4fe40e2 targets: nightly: git_hash: 'tor-browser' mullvad-browser: mullvad-browser: '[% INCLUDE build %]' - git_hash: 34b45a7417145b1f26784825ef6c873497cbda0a + git_hash: bf09d9c070f72ad3aee24c54cb154bab2570247b targets: nightly: git_hash: 'mullvad-browser' @@ -32,7 +32,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: b5bc0929fbfff8343a8c57e26ffa70ea4d38c2ce + git_hash: 674a3f4d2d75b9688a54e5f1a0139feb617339d3 compress_tar: 'zst' targets: nightly: ===================================== rbm.conf ===================================== @@ -78,7 +78,7 @@ var: torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2025/04/08 17:53:31' + browser_release_date: '2025/07/29 10:33:44' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' browser_default_channel: alpha browser_platforms: @@ -128,9 +128,9 @@ var: updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + - 14.5a6 - 14.5a5 - 14.5a4 - - 14.5a3 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-140.1.0esr-15.0-1-build3
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed new tag tor-browser-140.1.0esr-15.0-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0