- tbb-commits - lists.torproject.org

[torbutton/master] Bug 19459: Remove code that sizes new windows (moved to tor-browser.git)
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit 105b155787944799a38ad2c48f0bd015b1fa032e Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Aug 31 21:09:05 2016 -0700 Bug 19459: Remove code that sizes new windows (moved to tor-browser.git) --- src/chrome/content/content-sizer.js | 8 +- src/chrome/content/torbutton.js | 158 +------------------------------- src/defaults/preferences/preferences.js | 1 - src/modules/utils.js | 20 +++- 4 files changed, 31 insertions(+), 156 deletions(-) diff --git a/src/chrome/content/content-sizer.js b/src/chrome/content/content-sizer.js index e627c3c..ded06d7 100644 --- a/src/chrome/content/content-sizer.js +++ b/src/chrome/content/content-sizer.js @@ -501,7 +501,13 @@ let quantizeBrowserSizeMain = function (window, xStep, yStep) { window.addEventListener("unload", unbind, true); }; -quantizeBrowserSizeMain(window, xStep, yStep); +// Only start quantizing once the window has become visible. +var stopObserving = observe("xul-window-visible", function () { + if (Services.wm.getMostRecentWindow("navigator:browser") === window) { + quantizeBrowserSizeMain(window, xStep, yStep); + stopObserving(); + } +}); // end of quantizeBrowserSize definition }; diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index 60f12d6..53e5479 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -17,8 +17,6 @@ const k_tb_last_browser_version_pref = "extensions.torbutton.lastBrowserVersion" const k_tb_browser_update_needed_pref = "extensions.torbutton.updateNeeded"; const k_tb_last_update_check_pref = "extensions.torbutton.lastUpdateCheck"; const k_tb_tor_check_failed_topic = "Torbutton:TorCheckFailed"; -const k_tb_tor_resize_warn_pref = - "extensions.torbutton.startup_resize_period" var m_tb_prefs = Services.prefs; @@ -399,6 +397,8 @@ function torbutton_init() { m_tb_control_port, m_tb_control_pass, "extensions.torbutton.display_circuit"); + quantizeBrowserSize(window, 100, 100); + torbutton_log(3, 'init completed'); } @@ -2210,105 +2210,13 @@ var torbutton_resizelistener = var progress = Components.classes["@mozilla.org/docloaderservice;1"]. getService(Components.interfaces.nsIWebProgress); - var win = getBrowser().contentWindow, - container = getBrowser().parentElement; + var win = getBrowser().contentWindow; if (!win || typeof(win) == "undefined") { torbutton_log(5, "No initial browser content window?"); progress.removeProgressListener(this); return; } - // We need to set the inner width to an initial value because it has none - // at this point... Choosing "300" as this works even on Windows - // reliably. - win.innerWidth = 300; - win.innerHeight = 300; - - var screenMan = Components.classes["@mozilla.org/gfx/screenmanager;1"]. - getService(Components.interfaces.nsIScreenManager); - var junk = {}, availWidth = {}, availHeight = {}; - screenMan.primaryScreen.GetAvailRect(junk, junk, availWidth, availHeight); - - torbutton_log(3, "About to resize window: " + - window.outerWidth + "x" + window.outerHeight + - " inner: " + win.innerWidth + "x" + win.innerHeight + - " in state " + window.windowState + - " Available: " + availWidth.value + "x" + - availHeight.value); - - var diff_width = window.outerWidth - win.innerWidth; - var diff_height = window.outerHeight - win.innerHeight; - var delta_fix = 0; - - // The following block tries to cope with funny corner cases where the - // title bar is not included in window.outerHeight. What could happen in - // this case? Well, assume the difference between window.outerHeight and - // win.innerHeight is 39. And lets further assume the available height is - // 725x539. If we resize the window in this case we get 600x500 for the - // inner window. And the outer window has a height of 539 *plus* the - // height of the titlebar (as it occupies some screen space at least - // after resizing) which probably leads to parts of the browser being not - // visible. - if (window.outerHeight == window.innerHeight) { - // XXX: Let's assume a reasonable safety margin. - // |delta_fix = Math.floor(window.mozInnerScreenY) - window.screenY;| - // is not working at this stage of the browser start-up. Although it - // would give us slightly better values. But calling it later makes - // the resizing visible even on fast computers which is bad for UX. - delta_fix = Math.floor(diff_height / 2); - } - - // Check the DPI value and take it into acctount later when calculating - // the max* values. - var dpi = m_tb_domWindowUtils.screenPixelsPerCSSPixel; - - // We can't use screen resolution here as it does not account for e.g. - // taskbars. We can't use window.screen.avail* either as it does not - // report correct values on some platforms when used at this stage in the - // startup process. Therefore, we resort to nsIScreenManager. - // XXX: Note though, there are probably still some OS/window manager - // configurations where this approach is not working. E.g. on a Debian - // with XFCE the available height is the same as the screen height. - // This is said to happen as well on Windows with Aero: - // https://stackoverflow.com/questions/3044230/ - // difference-between-screen-availheight-and-window-height - var maxHeight = Math.floor(availHeight.value / dpi) - - (diff_height + delta_fix); - var maxWidth = Math.floor(availWidth.value / dpi) - diff_width ; - - var width; - var height; - - // Allow the user to overwrite the Torbutton logic in case it is still - // wrong when resizing the window. - try { - width = m_tb_prefs.getIntPref("extensions.torbutton.window.innerWidth"); - } catch(e) { - let cappedWidth = m_tb_prefs.getIntPref("extensions.torbutton.window.maxWidth"); - if (maxWidth > cappedWidth) { - maxWidth = cappedWidth; - } - width = Math.floor(maxWidth/200.0)*200; - } - - try { - height = m_tb_prefs.getIntPref("extensions.torbutton.window.innerHeight"); - } catch(e) { - let cappedHeight = m_tb_prefs.getIntPref("extensions.torbutton.window.maxHeight"); - if (maxHeight > cappedHeight) { - maxHeight = cappedHeight; - } - height = Math.floor(maxHeight/100.0)*100; - } - - let resizeInnerWindowTo = function (width, height) { - window.resizeBy(width - win.innerWidth, - height - win.innerHeight); - torbutton_log(3, "Resized new window from: " + container.clientWidth + "x" + - container.clientHeight + " to " + width + "x" + height + - " in state " + window.windowState); - } - m_tb_resize_handler = function() { if (window.windowState === 1) { if (m_tb_prefs. @@ -2361,25 +2269,8 @@ var torbutton_resizelistener = priority, buttons); return; } - // This is for some weird OS-specific behavior on start-up where, - // depending on the available screen size, the OS thinks it has to - // maximize the window. We don't want to do that AND don't want to - // show the user our notification in this case. - if (m_tb_prefs. - getBoolPref(k_tb_tor_resize_warn_pref)) { - window.addEventListener("resize", - function() { - resizeInnerWindowTo(width, height); - var calling_function = arguments.callee; - setTimeout(function() { - torbutton_log(3, "Removing resize listener.."); - window.removeEventListener("resize", - calling_function, false); - }, 1000); - }, false); - } } - }; + }; // m_tb_resize_handler // We need to handle OSes that auto-maximize windows depending on user // settings and/or screen resolution in the start-up phase and users that @@ -2401,50 +2292,11 @@ var torbutton_resizelistener = // the window triggers more than one resize event the first being not the // one we need. Thus we can't remove the listener after the first resize // event got fired. Thus, we have the rather klunky setTimeout() call. - m_tb_prefs.setBoolPref(k_tb_tor_resize_warn_pref, true); window.addEventListener("sizemodechange", m_tb_resize_handler, false); - // This is fun. any attempt to directly set the inner window actually - // resizes the outer width to that value instead. Must use resizeBy() - // instead of assignment or resizeTo() - resizeInnerWindowTo(width, height); - - // Resizing within this progress listener does not always work as overlays - // of other extensions might still influence the height/width of the - // chrome and therefore the height/width of the content window. Doing a - // fallback resize with setTimeout(0) from this progess listener does not - // work on some machines (probably due to race conditions which are all - // over the place). Thus we need a point later in the start-up process - // where we can do this... Please welcome the mutation observer. - let mut_target = document.getElementById("main-window"); - let mut_observer = new MutationObserver( - function(mutations) { - mutations.forEach( - function(mutation) { - setTimeout(function() { - resizeInnerWindowTo(width, height); - quantizeBrowserSize(window, 100, 100); - // OS-specific window maximization on start-up should - // be done by now. Disable the respective preference - // to make sure the user is seeing our notification. - m_tb_prefs.setBoolPref(k_tb_tor_resize_warn_pref, - false); - }, 0); - mut_observer.disconnect(); - } - ); - } - ); - // Configuration of the observer. Looking at added nodes is enough as - // DevTools related code is manipulating the DOM which we can capture. - // From that on we can start our fallback resizing. - let mut_config = { attributes: false, childList: true, - characterData: false }; - mut_observer.observe(mut_target, mut_config); - progress.removeProgressListener(this); } - }, + }, // onStateChange onProgressChange: function(aProgress, aRequest, curSelfProgress, maxSelfProgress, curTotalProgress, diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js index 3284bde..ec2cdbc 100644 --- a/src/defaults/preferences/preferences.js +++ b/src/defaults/preferences/preferences.js @@ -26,7 +26,6 @@ pref("extensions.torbutton.prompted_language",false); // See #7255 for details. We display the warning three times to make sure the // user did not click on it by accident. pref("extensions.torbutton.maximize_warnings_remaining", 0); -pref("extensions.torbutton.startup_resize_period", true); // Security prefs: pref("extensions.torbutton.cookie_protections",true); diff --git a/src/modules/utils.js b/src/modules/utils.js index 507f008..fa4405e 100644 --- a/src/modules/utils.js +++ b/src/modules/utils.js @@ -48,6 +48,24 @@ var bindPref = function (prefName, prefHandler, init = false) { var bindPrefAndInit = (prefName, prefHandler) => bindPref(prefName, prefHandler, true); +// ## Observers + +// __observe(topic, callback)__. +// Observe the given topic. When notification of that topic +// occurs, calls callback(subject, data). Returns a zero-arg +// function that stops observing. +var observe = function (topic, callback) { + let observer = { + observe: function (aSubject, aTopic, aData) { + if (topic === aTopic) { + callback(aSubject, aData); + } + }, + }; + Services.obs.addObserver(observer, topic, false); + return () => Services.obs.removeObserver(observer, topic); +}; + // ## Environment variables // __env__. @@ -183,4 +201,4 @@ var unescapeTorString = function(str) { // Export utility functions for external use. let EXPORTED_SYMBOLS = ["bindPref", "bindPrefAndInit", "getEnv", "getPrefValue", - "showDialog", "unescapeTorString"]; + "observe", "showDialog", "unescapeTorString"];

1 0

[tor-browser/tor-browser-45.5.0esr-6.5-1] fixup! Bug 19459: Size new windows to 1000x1000 or nearest 200x100
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit 9d8658aed5e5cf6a1ed4b8cdbf1fcaa96bb875c7 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Thu Nov 3 13:41:34 2016 -0700 fixup! Bug 19459: Size new windows to 1000x1000 or nearest 200x100 --- xpfe/appshell/nsXULWindow.cpp | 50 +++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/xpfe/appshell/nsXULWindow.cpp b/xpfe/appshell/nsXULWindow.cpp index c523e31..b0b1f52 100644 --- a/xpfe/appshell/nsXULWindow.cpp +++ b/xpfe/appshell/nsXULWindow.cpp @@ -1028,46 +1028,44 @@ NS_IMETHODIMP nsXULWindow::ResizeToRoundedDimensions() int32_t availHeight = NSToIntRound(devicePerCSSPixels * availHeightCSS); // device pixels shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels - // Useful for debugging: - //printf("\nscaling factor: %f\n", devicePerCSSPixels); - //printf("window size: %d x %d\n", windowWidth, windowHeight); - //printf("avail screen size: %d x %d\n", availWidth, availHeight); - //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + /* Useful for debugging: + printf("\nscaling factor: %f\n", devicePerCSSPixels); + printf("window size: %d x %d\n", windowWidth, windowHeight); + printf("avail screen size: %d x %d\n", availWidth, availHeight); + printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + */ int32_t chromeWidth = windowWidth - contentWidth; int32_t chromeHeight = windowHeight - contentHeight; int maxInnerWidth = Preferences::GetInt("privacy.window.maxInnerWidth", - INT_MAX); + 1000); int maxInnerHeight = Preferences::GetInt("privacy.window.maxInnerHeight", - INT_MAX); + 1000); int32_t availForContentWidthCSS = - std::min(maxInnerWidth, - NSToIntRound((0.95 * availWidth - chromeWidth) / - devicePerCSSPixels)); + std::min(maxInnerWidth, NSToIntRound((0.95 * availWidth - chromeWidth) / + devicePerCSSPixels)); int32_t availForContentHeightCSS = - std::min(maxInnerHeight, - NSToIntRound((0.95 * availHeight - chromeHeight) / - devicePerCSSPixels)); + std::min(maxInnerHeight, NSToIntRound((0.95 * availHeight - chromeHeight) / + devicePerCSSPixels)); int32_t targetContentWidth = NSToIntRound(devicePerCSSPixels * - std::min(1000, availForContentWidthCSS - - (availForContentWidthCSS % 200))); + (availForContentWidthCSS - (availForContentWidthCSS % 200))); int32_t targetContentHeight = NSToIntRound(devicePerCSSPixels * - std::min(1000, availForContentHeightCSS - - (availForContentHeightCSS % 100))); + (availForContentHeightCSS - (availForContentHeightCSS % 100))); SizeShellTo(mPrimaryContentShell, targetContentWidth, targetContentHeight); mIgnoreXULSize = true; mIgnoreXULSizeMode = true; - // Useful for debugging: - //printf("target content size: %d, %d\n", - // targetContentWidth, targetContentHeight); - //GetSize(&windowWidth, &windowHeight); - //GetAvailScreenSize(&availWidth, &availHeight); - //shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels - //printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); - //printf("avail screen size: %d x %d\n", availWidth, availHeight); - //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + /* Useful for debugging: + printf("target content size: %d, %d\n", + targetContentWidth, targetContentHeight); + GetSize(&windowWidth, &windowHeight); + GetAvailScreenSize(&availWidth, &availHeight); + shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); + printf("avail screen size: %d x %d\n", availWidth, availHeight); + printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + */ return NS_OK; }

1 0

[tor-browser/tor-browser-45.5.0esr-6.5-1] Bug 19459: Size new windows to 1000x1000 or nearest 200x100
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit c8724d473603d63af82b1cf01d22dd5f7e4a8279 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Oct 12 02:28:31 2016 +0000 Bug 19459: Size new windows to 1000x1000 or nearest 200x100 --- browser/base/content/browser.js | 10 +++- xpfe/appshell/nsXULWindow.cpp | 108 ++++++++++++++++++++++++++++++++++------ xpfe/appshell/nsXULWindow.h | 2 + 3 files changed, 102 insertions(+), 18 deletions(-) diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 41d72ae..e5fb01c 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -999,8 +999,14 @@ var gBrowserInit = { // have been initialized. Services.obs.notifyObservers(window, "browser-window-before-show", ""); - // Set a sane starting width/height for all resolutions on new profiles. - if (!document.documentElement.hasAttribute("width")) { + if (gPrefService.getBoolPref("privacy.resistFingerprinting")) { + // With fingerprinting resistance enabled, code elsewhere + // is going to generate rounded window dimensions. Make sure + // we don't have a maximized window that can interfere with + // that, as observed in http://trac.torproject.org/18175 + document.documentElement.setAttribute("sizemode", "normal"); + } else if (!document.documentElement.hasAttribute("width")) { + // Set a sane starting width/height for all resolutions on new profiles. let defaultWidth; let defaultHeight; diff --git a/xpfe/appshell/nsXULWindow.cpp b/xpfe/appshell/nsXULWindow.cpp index 99289a0..c523e31 100644 --- a/xpfe/appshell/nsXULWindow.cpp +++ b/xpfe/appshell/nsXULWindow.cpp @@ -1007,7 +1007,70 @@ NS_IMETHODIMP nsXULWindow::EnsureAuthPrompter() } return mAuthPrompter ? NS_OK : NS_ERROR_FAILURE; } - + +// Rounds window size to 1000x1000, or, if there isn't enough available +// screen space, to a multiple of 200x100. +NS_IMETHODIMP nsXULWindow::ResizeToRoundedDimensions() +{ + NS_ENSURE_STATE(mPrimaryContentShell); + nsCOMPtr<nsIBaseWindow> shellWindow(do_QueryInterface(mPrimaryContentShell)); + NS_ENSURE_STATE(shellWindow); + int32_t windowWidth, windowHeight; + int32_t availWidthCSS, availHeightCSS; + int32_t contentWidth, contentHeight; + double devicePerCSSPixels = 1.0; + shellWindow->GetUnscaledDevicePixelsPerCSSPixel(&devicePerCSSPixels); + GetSize(&windowWidth, &windowHeight); // device pixels + NS_ENSURE_TRUE(GetAvailScreenSize(&availWidthCSS, &availHeightCSS), + NS_ERROR_FAILURE); + int32_t availWidth = NSToIntRound(devicePerCSSPixels * + availWidthCSS); // device pixels + int32_t availHeight = NSToIntRound(devicePerCSSPixels * + availHeightCSS); // device pixels + shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + // Useful for debugging: + //printf("\nscaling factor: %f\n", devicePerCSSPixels); + //printf("window size: %d x %d\n", windowWidth, windowHeight); + //printf("avail screen size: %d x %d\n", availWidth, availHeight); + //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + int32_t chromeWidth = windowWidth - contentWidth; + int32_t chromeHeight = windowHeight - contentHeight; + int maxInnerWidth = Preferences::GetInt("privacy.window.maxInnerWidth", + INT_MAX); + int maxInnerHeight = Preferences::GetInt("privacy.window.maxInnerHeight", + INT_MAX); + int32_t availForContentWidthCSS = + std::min(maxInnerWidth, + NSToIntRound((0.95 * availWidth - chromeWidth) / + devicePerCSSPixels)); + int32_t availForContentHeightCSS = + std::min(maxInnerHeight, + NSToIntRound((0.95 * availHeight - chromeHeight) / + devicePerCSSPixels)); + int32_t targetContentWidth = + NSToIntRound(devicePerCSSPixels * + std::min(1000, availForContentWidthCSS - + (availForContentWidthCSS % 200))); + int32_t targetContentHeight = + NSToIntRound(devicePerCSSPixels * + std::min(1000, availForContentHeightCSS - + (availForContentHeightCSS % 100))); + SizeShellTo(mPrimaryContentShell, + targetContentWidth, targetContentHeight); + mIgnoreXULSize = true; + mIgnoreXULSizeMode = true; + // Useful for debugging: + //printf("target content size: %d, %d\n", + // targetContentWidth, targetContentHeight); + //GetSize(&windowWidth, &windowHeight); + //GetAvailScreenSize(&availWidth, &availHeight); + //shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + //printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); + //printf("avail screen size: %d x %d\n", availWidth, availHeight); + //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + return NS_OK; +} + void nsXULWindow::OnChromeLoaded() { nsresult rv = EnsureContentTreeOwner(); @@ -1037,6 +1100,13 @@ void nsXULWindow::OnChromeLoaded() } } + // If we have a content browser object, and fingerprinting resistance + // is active, then set to a rounded size. + if (mPrimaryContentShell && + Preferences::GetBool("privacy.resistFingerprinting", false)) { + ResizeToRoundedDimensions(); + } + bool positionSet = !mIgnoreXULPosition; nsCOMPtr<nsIXULWindow> parentWindow(do_QueryReferent(mParentWindow)); #if defined(XP_UNIX) && !defined(XP_MACOSX) @@ -1137,6 +1207,21 @@ bool nsXULWindow::LoadPositionFromXUL() return gotPosition; } +bool nsXULWindow::GetAvailScreenSize(int32_t* availWidth, int32_t* availHeight) +{ + nsCOMPtr<nsIDOMWindow> domWindow; + GetWindowDOMWindow(getter_AddRefs(domWindow)); + if (nsCOMPtr<nsPIDOMWindow> window = do_QueryInterface(domWindow)) { + nsCOMPtr<nsIDOMScreen> screen = window->GetScreen(); + if (screen) { + screen->GetAvailWidth(availWidth); + screen->GetAvailHeight(availHeight); + return true; + } + } + return false; +} + bool nsXULWindow::LoadSizeFromXUL() { bool gotSize = false; @@ -1181,21 +1266,12 @@ bool nsXULWindow::LoadSizeFromXUL() } if (gotSize) { - // constrain to screen size - nsCOMPtr<nsIDOMWindow> domWindow; - GetWindowDOMWindow(getter_AddRefs(domWindow)); - if (nsCOMPtr<nsPIDOMWindow> window = do_QueryInterface(domWindow)) { - nsCOMPtr<nsIDOMScreen> screen = window->GetScreen(); - if (screen) { - int32_t screenWidth; - int32_t screenHeight; - screen->GetAvailWidth(&screenWidth); - screen->GetAvailHeight(&screenHeight); - if (specWidth > screenWidth) - specWidth = screenWidth; - if (specHeight > screenHeight) - specHeight = screenHeight; - } + int32_t screenWidth, screenHeight; + if (GetAvailScreenSize(&screenWidth, &screenHeight)) { + if (specWidth > screenWidth) + specWidth = screenWidth; + if (specHeight > screenHeight) + specHeight = screenHeight; } mIntrinsicallySized = false; diff --git a/xpfe/appshell/nsXULWindow.h b/xpfe/appshell/nsXULWindow.h index 882e614..f959e11 100644 --- a/xpfe/appshell/nsXULWindow.h +++ b/xpfe/appshell/nsXULWindow.h @@ -88,6 +88,7 @@ protected: NS_IMETHOD EnsurePrimaryContentTreeOwner(); NS_IMETHOD EnsurePrompter(); NS_IMETHOD EnsureAuthPrompter(); + NS_IMETHOD ResizeToRoundedDimensions(); void OnChromeLoaded(); void StaggerPosition(int32_t &aRequestedX, int32_t &aRequestedY, @@ -120,6 +121,7 @@ protected: void SetContentScrollbarVisibility(bool aVisible); bool GetContentScrollbarVisibility(); void PersistentAttributesDirty(uint32_t aDirtyFlags); + bool GetAvailScreenSize(int32_t* availWidth, int32_t* availHeight); nsChromeTreeOwner* mChromeTreeOwner; nsContentTreeOwner* mContentTreeOwner;

1 0

[tor-browser/tor-browser-45.4.0esr-6.5-1] fixup! Bug 19459: Size new windows to 1000x1000 or nearest 200x100
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit f768cdd414cd3900f6927550c1a6eccb42cad05a Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Thu Nov 3 13:41:34 2016 -0700 fixup! Bug 19459: Size new windows to 1000x1000 or nearest 200x100 --- xpfe/appshell/nsXULWindow.cpp | 50 +++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/xpfe/appshell/nsXULWindow.cpp b/xpfe/appshell/nsXULWindow.cpp index c523e31..b0b1f52 100644 --- a/xpfe/appshell/nsXULWindow.cpp +++ b/xpfe/appshell/nsXULWindow.cpp @@ -1028,46 +1028,44 @@ NS_IMETHODIMP nsXULWindow::ResizeToRoundedDimensions() int32_t availHeight = NSToIntRound(devicePerCSSPixels * availHeightCSS); // device pixels shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels - // Useful for debugging: - //printf("\nscaling factor: %f\n", devicePerCSSPixels); - //printf("window size: %d x %d\n", windowWidth, windowHeight); - //printf("avail screen size: %d x %d\n", availWidth, availHeight); - //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + /* Useful for debugging: + printf("\nscaling factor: %f\n", devicePerCSSPixels); + printf("window size: %d x %d\n", windowWidth, windowHeight); + printf("avail screen size: %d x %d\n", availWidth, availHeight); + printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + */ int32_t chromeWidth = windowWidth - contentWidth; int32_t chromeHeight = windowHeight - contentHeight; int maxInnerWidth = Preferences::GetInt("privacy.window.maxInnerWidth", - INT_MAX); + 1000); int maxInnerHeight = Preferences::GetInt("privacy.window.maxInnerHeight", - INT_MAX); + 1000); int32_t availForContentWidthCSS = - std::min(maxInnerWidth, - NSToIntRound((0.95 * availWidth - chromeWidth) / - devicePerCSSPixels)); + std::min(maxInnerWidth, NSToIntRound((0.95 * availWidth - chromeWidth) / + devicePerCSSPixels)); int32_t availForContentHeightCSS = - std::min(maxInnerHeight, - NSToIntRound((0.95 * availHeight - chromeHeight) / - devicePerCSSPixels)); + std::min(maxInnerHeight, NSToIntRound((0.95 * availHeight - chromeHeight) / + devicePerCSSPixels)); int32_t targetContentWidth = NSToIntRound(devicePerCSSPixels * - std::min(1000, availForContentWidthCSS - - (availForContentWidthCSS % 200))); + (availForContentWidthCSS - (availForContentWidthCSS % 200))); int32_t targetContentHeight = NSToIntRound(devicePerCSSPixels * - std::min(1000, availForContentHeightCSS - - (availForContentHeightCSS % 100))); + (availForContentHeightCSS - (availForContentHeightCSS % 100))); SizeShellTo(mPrimaryContentShell, targetContentWidth, targetContentHeight); mIgnoreXULSize = true; mIgnoreXULSizeMode = true; - // Useful for debugging: - //printf("target content size: %d, %d\n", - // targetContentWidth, targetContentHeight); - //GetSize(&windowWidth, &windowHeight); - //GetAvailScreenSize(&availWidth, &availHeight); - //shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels - //printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); - //printf("avail screen size: %d x %d\n", availWidth, availHeight); - //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + /* Useful for debugging: + printf("target content size: %d, %d\n", + targetContentWidth, targetContentHeight); + GetSize(&windowWidth, &windowHeight); + GetAvailScreenSize(&availWidth, &availHeight); + shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); + printf("avail screen size: %d x %d\n", availWidth, availHeight); + printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + */ return NS_OK; }

1 0

[tor-browser/tor-browser-45.4.0esr-6.5-1] Bug 19459: Size new windows to 1000x1000 or nearest 200x100
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit fa996469071a1442386f0313b278cf07ccb4d14c Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Oct 12 02:28:31 2016 +0000 Bug 19459: Size new windows to 1000x1000 or nearest 200x100 --- browser/base/content/browser.js | 10 +++- xpfe/appshell/nsXULWindow.cpp | 108 ++++++++++++++++++++++++++++++++++------ xpfe/appshell/nsXULWindow.h | 2 + 3 files changed, 102 insertions(+), 18 deletions(-) diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 41d72ae..e5fb01c 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -999,8 +999,14 @@ var gBrowserInit = { // have been initialized. Services.obs.notifyObservers(window, "browser-window-before-show", ""); - // Set a sane starting width/height for all resolutions on new profiles. - if (!document.documentElement.hasAttribute("width")) { + if (gPrefService.getBoolPref("privacy.resistFingerprinting")) { + // With fingerprinting resistance enabled, code elsewhere + // is going to generate rounded window dimensions. Make sure + // we don't have a maximized window that can interfere with + // that, as observed in http://trac.torproject.org/18175 + document.documentElement.setAttribute("sizemode", "normal"); + } else if (!document.documentElement.hasAttribute("width")) { + // Set a sane starting width/height for all resolutions on new profiles. let defaultWidth; let defaultHeight; diff --git a/xpfe/appshell/nsXULWindow.cpp b/xpfe/appshell/nsXULWindow.cpp index 99289a0..c523e31 100644 --- a/xpfe/appshell/nsXULWindow.cpp +++ b/xpfe/appshell/nsXULWindow.cpp @@ -1007,7 +1007,70 @@ NS_IMETHODIMP nsXULWindow::EnsureAuthPrompter() } return mAuthPrompter ? NS_OK : NS_ERROR_FAILURE; } - + +// Rounds window size to 1000x1000, or, if there isn't enough available +// screen space, to a multiple of 200x100. +NS_IMETHODIMP nsXULWindow::ResizeToRoundedDimensions() +{ + NS_ENSURE_STATE(mPrimaryContentShell); + nsCOMPtr<nsIBaseWindow> shellWindow(do_QueryInterface(mPrimaryContentShell)); + NS_ENSURE_STATE(shellWindow); + int32_t windowWidth, windowHeight; + int32_t availWidthCSS, availHeightCSS; + int32_t contentWidth, contentHeight; + double devicePerCSSPixels = 1.0; + shellWindow->GetUnscaledDevicePixelsPerCSSPixel(&devicePerCSSPixels); + GetSize(&windowWidth, &windowHeight); // device pixels + NS_ENSURE_TRUE(GetAvailScreenSize(&availWidthCSS, &availHeightCSS), + NS_ERROR_FAILURE); + int32_t availWidth = NSToIntRound(devicePerCSSPixels * + availWidthCSS); // device pixels + int32_t availHeight = NSToIntRound(devicePerCSSPixels * + availHeightCSS); // device pixels + shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + // Useful for debugging: + //printf("\nscaling factor: %f\n", devicePerCSSPixels); + //printf("window size: %d x %d\n", windowWidth, windowHeight); + //printf("avail screen size: %d x %d\n", availWidth, availHeight); + //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + int32_t chromeWidth = windowWidth - contentWidth; + int32_t chromeHeight = windowHeight - contentHeight; + int maxInnerWidth = Preferences::GetInt("privacy.window.maxInnerWidth", + INT_MAX); + int maxInnerHeight = Preferences::GetInt("privacy.window.maxInnerHeight", + INT_MAX); + int32_t availForContentWidthCSS = + std::min(maxInnerWidth, + NSToIntRound((0.95 * availWidth - chromeWidth) / + devicePerCSSPixels)); + int32_t availForContentHeightCSS = + std::min(maxInnerHeight, + NSToIntRound((0.95 * availHeight - chromeHeight) / + devicePerCSSPixels)); + int32_t targetContentWidth = + NSToIntRound(devicePerCSSPixels * + std::min(1000, availForContentWidthCSS - + (availForContentWidthCSS % 200))); + int32_t targetContentHeight = + NSToIntRound(devicePerCSSPixels * + std::min(1000, availForContentHeightCSS - + (availForContentHeightCSS % 100))); + SizeShellTo(mPrimaryContentShell, + targetContentWidth, targetContentHeight); + mIgnoreXULSize = true; + mIgnoreXULSizeMode = true; + // Useful for debugging: + //printf("target content size: %d, %d\n", + // targetContentWidth, targetContentHeight); + //GetSize(&windowWidth, &windowHeight); + //GetAvailScreenSize(&availWidth, &availHeight); + //shellWindow->GetSize(&contentWidth, &contentHeight); // device pixels + //printf("\nwindow size: %d x %d\n", windowWidth, windowHeight); + //printf("avail screen size: %d x %d\n", availWidth, availHeight); + //printf("primary content shell: %d x %d\n", contentWidth, contentHeight); + return NS_OK; +} + void nsXULWindow::OnChromeLoaded() { nsresult rv = EnsureContentTreeOwner(); @@ -1037,6 +1100,13 @@ void nsXULWindow::OnChromeLoaded() } } + // If we have a content browser object, and fingerprinting resistance + // is active, then set to a rounded size. + if (mPrimaryContentShell && + Preferences::GetBool("privacy.resistFingerprinting", false)) { + ResizeToRoundedDimensions(); + } + bool positionSet = !mIgnoreXULPosition; nsCOMPtr<nsIXULWindow> parentWindow(do_QueryReferent(mParentWindow)); #if defined(XP_UNIX) && !defined(XP_MACOSX) @@ -1137,6 +1207,21 @@ bool nsXULWindow::LoadPositionFromXUL() return gotPosition; } +bool nsXULWindow::GetAvailScreenSize(int32_t* availWidth, int32_t* availHeight) +{ + nsCOMPtr<nsIDOMWindow> domWindow; + GetWindowDOMWindow(getter_AddRefs(domWindow)); + if (nsCOMPtr<nsPIDOMWindow> window = do_QueryInterface(domWindow)) { + nsCOMPtr<nsIDOMScreen> screen = window->GetScreen(); + if (screen) { + screen->GetAvailWidth(availWidth); + screen->GetAvailHeight(availHeight); + return true; + } + } + return false; +} + bool nsXULWindow::LoadSizeFromXUL() { bool gotSize = false; @@ -1181,21 +1266,12 @@ bool nsXULWindow::LoadSizeFromXUL() } if (gotSize) { - // constrain to screen size - nsCOMPtr<nsIDOMWindow> domWindow; - GetWindowDOMWindow(getter_AddRefs(domWindow)); - if (nsCOMPtr<nsPIDOMWindow> window = do_QueryInterface(domWindow)) { - nsCOMPtr<nsIDOMScreen> screen = window->GetScreen(); - if (screen) { - int32_t screenWidth; - int32_t screenHeight; - screen->GetAvailWidth(&screenWidth); - screen->GetAvailHeight(&screenHeight); - if (specWidth > screenWidth) - specWidth = screenWidth; - if (specHeight > screenHeight) - specHeight = screenHeight; - } + int32_t screenWidth, screenHeight; + if (GetAvailScreenSize(&screenWidth, &screenHeight)) { + if (specWidth > screenWidth) + specWidth = screenWidth; + if (specHeight > screenHeight) + specHeight = screenHeight; } mIntrinsicallySized = false; diff --git a/xpfe/appshell/nsXULWindow.h b/xpfe/appshell/nsXULWindow.h index 882e614..f959e11 100644 --- a/xpfe/appshell/nsXULWindow.h +++ b/xpfe/appshell/nsXULWindow.h @@ -88,6 +88,7 @@ protected: NS_IMETHOD EnsurePrimaryContentTreeOwner(); NS_IMETHOD EnsurePrompter(); NS_IMETHOD EnsureAuthPrompter(); + NS_IMETHOD ResizeToRoundedDimensions(); void OnChromeLoaded(); void StaggerPosition(int32_t &aRequestedX, int32_t &aRequestedY, @@ -120,6 +121,7 @@ protected: void SetContentScrollbarVisibility(bool aVisible); bool GetContentScrollbarVisibility(); void PersistentAttributesDirty(uint32_t aDirtyFlags); + bool GetAvailScreenSize(int32_t* availWidth, int32_t* availHeight); nsChromeTreeOwner* mChromeTreeOwner; nsContentTreeOwner* mContentTreeOwner;

1 0

[torbutton/master] Adding fr, ru, and tr to the banner locales
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit c7798457fac62e77b0da9efac69296c0966325ca Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 10 13:07:50 2016 +0000 Adding fr, ru, and tr to the banner locales --- src/chrome/content/aboutTor/donation_banner.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/chrome/content/aboutTor/donation_banner.js b/src/chrome/content/aboutTor/donation_banner.js index 1087815..04f8db9 100644 --- a/src/chrome/content/aboutTor/donation_banner.js +++ b/src/chrome/content/aboutTor/donation_banner.js @@ -6,8 +6,11 @@ let kBannerLocales = [ "en", "es", "fa", + "fr", "it", "nl", + "ru", + "tr", "vi", "zh", ];

1 0

[tor-browser-bundle/hardened-builds] Update tor signing key
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit 07c917f0aa87ec7e4b3b668fd868bca58fac27be Author: Georg Koppen <gk(a)torproject.org> Date: Wed Nov 9 11:10:02 2016 +0000 Update tor signing key --- gitian/gpg/tor.gpg | Bin 14432 -> 21817 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/gitian/gpg/tor.gpg b/gitian/gpg/tor.gpg index 319a9a6..51eeb40 100644 Binary files a/gitian/gpg/tor.gpg and b/gitian/gpg/tor.gpg differ

1 0

[tor-browser-bundle/master] Update tor signing key
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit 2c2690fb3a2c76ae916fdb9d37b2f9f2a362de7f Author: Georg Koppen <gk(a)torproject.org> Date: Wed Nov 9 11:10:02 2016 +0000 Update tor signing key --- gitian/gpg/tor.gpg | Bin 14432 -> 21817 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/gitian/gpg/tor.gpg b/gitian/gpg/tor.gpg index 319a9a6..51eeb40 100644 Binary files a/gitian/gpg/tor.gpg and b/gitian/gpg/tor.gpg differ

1 0

[tor-browser/tor-browser-45.4.0esr-6.5-1] fixup! Bug #4234: Use the Firefox Update Process for Tor Browser.
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit 74af032f2b07b8106b216a240c175d163634d89d Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Thu Jun 23 10:09:15 2016 -0400 fixup! Bug #4234: Use the Firefox Update Process for Tor Browser. Change app.update.url to point to aus1.tpo (bug 19481). --- browser/app/profile/firefox.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js index 6e424cb..64ab700 100644 --- a/browser/app/profile/firefox.js +++ b/browser/app/profile/firefox.js @@ -147,7 +147,7 @@ pref("app.update.badge", false); pref("app.update.staging.enabled", true); // Update service URL: -pref("app.update.url", "https://www.torproject.org/dist/torbrowser/update_2/%CHANNEL%/%BUILD_TARGET…"); +pref("app.update.url", "https://aus1.torproject.org/dist/torbrowser/update_2/%CHANNEL%/%BUILD_TARGE…"); // app.update.url.manual is in branding section // app.update.url.details is in branding section

1 0

[tor-browser-bundle/maint-6.0] Revert "Remove the Go update from Changelog"
by gk＠torproject.org 10 Nov '16

10 Nov '16

commit df5a2277a97f78a4384eeb0b5238d9d303756fb4 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 10 08:24:29 2016 +0000 Revert "Remove the Go update from Changelog" This reverts commit fe44fa5dc3e1eb5889f64114d0a8a03d144e7891. --- Bundle-Data/Docs/ChangeLog.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Bundle-Data/Docs/ChangeLog.txt b/Bundle-Data/Docs/ChangeLog.txt index 0758477..b2a0719 100644 --- a/Bundle-Data/Docs/ChangeLog.txt +++ b/Bundle-Data/Docs/ChangeLog.txt @@ -21,6 +21,10 @@ Tor Browser 6.0.6 -- November 15 * Bug 20342: Add tor-gencert.exe to expert bundle * OS X * Bug 20204: Windows don't drag on macOS Sierra anymore + * Bug 20250: Meek fails on macOS Sierra if built with Go < 1.7 + * Build system + * All platforms + * Bug 20023: Upgrade Go to 1.7.3 Tor Browser 6.0.5 -- September 16 * All Platforms

1 0