- tbb-commits - lists.torproject.org

[tor-browser-build/master] Bug 23384: Add user gk on build-sunet-a.torproject.net
by boklm＠torproject.org 04 Sep '17

04 Sep '17

commit 87f10c820a02889791770821f9192f1eabe5538e Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Sep 4 20:29:51 2017 +0200 Bug 23384: Add user gk on build-sunet-a.torproject.net --- tools/ansible/roles/tbb-team/defaults/main.yml | 1 + tools/ansible/roles/tbb-team/files/gk.pub | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/ansible/roles/tbb-team/defaults/main.yml b/tools/ansible/roles/tbb-team/defaults/main.yml index b76fc26..475acca 100644 --- a/tools/ansible/roles/tbb-team/defaults/main.yml +++ b/tools/ansible/roles/tbb-team/defaults/main.yml @@ -1,3 +1,4 @@ --- tbb_team_members: - boklm + - gk diff --git a/tools/ansible/roles/tbb-team/files/gk.pub b/tools/ansible/roles/tbb-team/files/gk.pub new file mode 100644 index 0000000..a0985d9 --- /dev/null +++ b/tools/ansible/roles/tbb-team/files/gk.pub @@ -0,0 +1 @@ +ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDGAn0mJnf4IUiASnXgOHE6zsCtO0P+TFS6YauchrC2knH+kJXyHswHibNO/R16JayyPkgX5c00Z3QAO2gkvYODLO37/lwWyy7/58Zqa6XRz5VnwvJ1eCzHJrBa+ll57GEsBaU9+tSXVnk6mF2d4+/mzAxdBco1N2mAd7KxjRgJFX+UV2aDDWalLiHzqj1ZQIt/4P/z4pLU1fPISy1EygA7pZ/gOGV3T0hpH/yxrOc5cspJb4APA6fWzsFBE2SFWx/+4cvtorIUi55UWbWqen3BDrQxFaGEovWGYsa0ykMbA3TZ/cTGqkneJjFzJuFYwu+x/XMUEUYo7TqXzInz1kOMLep/1MQWX0n3NCUoUMxBlg93YaEnkff0D7pAQsi2Km+6PQXYiHSve61IBVaq6J2deZnrsriI+u3OR5/5OuUnrpbQI4QyDojAF/ZFtKeaLsWQGgjzChogckdttplESO+Sa8/YVepPd3ukpNLuDgIIimwkJkwniZYtkPZxC7WmDFRYswB5zKnmOwFwa9qjZ0i//DeehHCADqorjXQeEt8sxt1qzjk5SddgJEcIgnlimhRr4pFRVOy/oCCGLNuBQvmTKqqED3hZJB8c+g1SzW2MyGdKELJne3S300W2b3nGQvhv+vSr+2lOWtNFA7oz0oqfX3E/7oNp3Sqad8PPO/ImXQ== thomas@debian

1 0

[tor-browser-build/master] Bug 23384: Add user boklm on build-sunet-a.torproject.net
by boklm＠torproject.org 04 Sep '17

04 Sep '17

commit 1f108e3d3ddcfeff88c613f99983afc2e41cc273 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Sep 4 15:39:14 2017 +0200 Bug 23384: Add user boklm on build-sunet-a.torproject.net --- tools/ansible/roles/tbb-team/defaults/main.yml | 3 +++ tools/ansible/roles/tbb-team/files/boklm.pub | 1 + tools/ansible/roles/tbb-team/tasks/main.yml | 15 +++++++++++++++ tools/ansible/tbb-build.yml | 1 + 4 files changed, 20 insertions(+) diff --git a/tools/ansible/roles/tbb-team/defaults/main.yml b/tools/ansible/roles/tbb-team/defaults/main.yml new file mode 100644 index 0000000..b76fc26 --- /dev/null +++ b/tools/ansible/roles/tbb-team/defaults/main.yml @@ -0,0 +1,3 @@ +--- +tbb_team_members: + - boklm diff --git a/tools/ansible/roles/tbb-team/files/boklm.pub b/tools/ansible/roles/tbb-team/files/boklm.pub new file mode 100644 index 0000000..471f271 --- /dev/null +++ b/tools/ansible/roles/tbb-team/files/boklm.pub @@ -0,0 +1 @@ +ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCuY6Clt4tqljhnQAfIAq2RcuB3UgQ1odLtYc+AlnwcgWgYoqByGXT52YnYd44MQ0rPpXGh6M5MeXGF33OOLkBm8QeFHiev4njq/14A5qMIH+xV4T/ft1vEE3PTuarzyhv/Qp1s0dt4/XibzMPND5zFQJUFsTON6WYix0cwBOa80W46P56jPca56kTnL045N8MJNFA4ELby68QaMMK0lEzupgLtzRnqc123paZr3FAgCOxNlYC83ftAsDuVNCzbp0+i3W0ZWBbqVo+wWbty7WJK4TjuQszS2oP+d5xxktXUVyVXu2xm0BV0kXgh6lV4ixDPKQsZrlUYalFN5QIQWwzb q-wo diff --git a/tools/ansible/roles/tbb-team/tasks/main.yml b/tools/ansible/roles/tbb-team/tasks/main.yml new file mode 100644 index 0000000..9beaf0b --- /dev/null +++ b/tools/ansible/roles/tbb-team/tasks/main.yml @@ -0,0 +1,15 @@ +--- +- name: Add tbb-team users + user: + name: "{{ item }}" + state: present + groups: tbb-build + shell: /bin/bash + with_items: tbb_team_members + +- name: Add ssh keys to authorized_keys + authorized_key: + user: "{{ item }}" + state: present + key: "{{ lookup('file', item + '.pub') }}" + with_items: tbb_team_members diff --git a/tools/ansible/tbb-build.yml b/tools/ansible/tbb-build.yml index dc5dfe5..e74e665 100644 --- a/tools/ansible/tbb-build.yml +++ b/tools/ansible/tbb-build.yml @@ -4,3 +4,4 @@ roles: - role: tbb-builder - role: useful-packages + - role: tbb-team

1 0

[tor-browser-build/master] Bug 23384: install packages needed for building Tor Browser on build-sunet-a.torproject.net
by boklm＠torproject.org 04 Sep '17

04 Sep '17

commit 093a213a2940e5c005e5044bc89b4fbedc46d461 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Sep 4 15:37:01 2017 +0200 Bug 23384: install packages needed for building Tor Browser on build-sunet-a.torproject.net --- tools/ansible/Makefile | 2 ++ tools/ansible/README | 13 +++++++++ tools/ansible/inventory | 5 ++++ .../roles/tbb-builder/files/sudoers-tbb-build | 1 + tools/ansible/roles/tbb-builder/tasks/main.yml | 32 ++++++++++++++++++++++ tools/ansible/roles/useful-packages/tasks/main.yml | 10 +++++++ tools/ansible/tbb-build.yml | 6 ++++ 7 files changed, 69 insertions(+) diff --git a/tools/ansible/Makefile b/tools/ansible/Makefile new file mode 100644 index 0000000..eae73b5 --- /dev/null +++ b/tools/ansible/Makefile @@ -0,0 +1,2 @@ +ansible-tbb-build: + ansible-playbook -i inventory tbb-build.yml diff --git a/tools/ansible/README b/tools/ansible/README new file mode 100644 index 0000000..f631b08 --- /dev/null +++ b/tools/ansible/README @@ -0,0 +1,13 @@ +This directory contains some ansible script that we use to setup some +machines that we use for Tor Browser development. + +To deploy some changes you need the ansible package to be installed on +your machine, and be able to log in with ssh as root on the machine(s) +where the changes need to be deployed. + +You can then use one of the following makefile targets: + +ansible-tbb-build: + Deploy changes to the machine used by Tor Browser team members to do + some Tor Browser builds. + diff --git a/tools/ansible/inventory b/tools/ansible/inventory new file mode 100644 index 0000000..e2597a0 --- /dev/null +++ b/tools/ansible/inventory @@ -0,0 +1,5 @@ +build-sunet-a ansible_ssh_user=root ansible_ssh_host=build-sunet-a.torproject.net + +[tbb-build] +build-sunet-a + diff --git a/tools/ansible/roles/tbb-builder/files/sudoers-tbb-build b/tools/ansible/roles/tbb-builder/files/sudoers-tbb-build new file mode 100644 index 0000000..5f2e48d --- /dev/null +++ b/tools/ansible/roles/tbb-builder/files/sudoers-tbb-build @@ -0,0 +1 @@ +%tbb-build ALL=(ALL) NOPASSWD: ALL diff --git a/tools/ansible/roles/tbb-builder/tasks/main.yml b/tools/ansible/roles/tbb-builder/tasks/main.yml new file mode 100644 index 0000000..2edfc18 --- /dev/null +++ b/tools/ansible/roles/tbb-builder/tasks/main.yml @@ -0,0 +1,32 @@ +--- + +- name: Install dependencies for Tor Browser build + apt: + name: "{{ item }}" + state: present + with_items: + - git + - sudo + - libyaml-libyaml-perl + - libtemplate-perl + - libio-handle-util-perl + - libio-all-perl + - libio-captureoutput-perl + - libfile-slurp-perl + - libstring-shellquote-perl + - libsort-versions-perl + - libdigest-sha-perl + - libdata-uuid-perl + - libdata-dump-perl + - libfile-copy-recursive-perl + - libgtk2.0-dev + - curl + - runc + +- name: Create the tbb-build group + group: + name: tbb-build + state: present + +- name: Give sudo access to tbb-build group members + copy: src=sudoers-tbb-build dest=/etc/sudoers.d/tbb-build owner=root group=root mode=0440 diff --git a/tools/ansible/roles/useful-packages/tasks/main.yml b/tools/ansible/roles/useful-packages/tasks/main.yml new file mode 100644 index 0000000..a15fc28 --- /dev/null +++ b/tools/ansible/roles/useful-packages/tasks/main.yml @@ -0,0 +1,10 @@ +--- + +- name: Install some useful packages + apt: + name: "{{ item }}" + state: present + with_items: + - locales + - vim-nox + - tmux diff --git a/tools/ansible/tbb-build.yml b/tools/ansible/tbb-build.yml new file mode 100644 index 0000000..dc5dfe5 --- /dev/null +++ b/tools/ansible/tbb-build.yml @@ -0,0 +1,6 @@ +--- + +- hosts: tbb-build + roles: + - role: tbb-builder + - role: useful-packages

1 0

[tor-browser-bundle/maint-7.0] Let's pick up a new HTTPS-E version and do a build2
by gk＠torproject.org 01 Sep '17

01 Sep '17

commit af77e037638b93853a15653772cc973846055c9e Author: Georg Koppen <gk(a)torproject.org> Date: Fri Sep 1 08:57:54 2017 +0000 Let's pick up a new HTTPS-E version and do a build2 --- Bundle-Data/Docs/ChangeLog.txt | 4 ++-- gitian/versions | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Bundle-Data/Docs/ChangeLog.txt b/Bundle-Data/Docs/ChangeLog.txt index 6c541ef..53c52b7 100644 --- a/Bundle-Data/Docs/ChangeLog.txt +++ b/Bundle-Data/Docs/ChangeLog.txt @@ -1,9 +1,9 @@ -Tor Browser 7.0.5 -- August 30 2017 +Tor Browser 7.0.5 -- September 2 2017 * All Platforms * Update Torbutton to 1.9.7.6 * Bug 22989: Fix dimensions of new windows on macOS * Translations update - * Update HTTPS-Everywhere to 2017.8.19 + * Update HTTPS-Everywhere to 2017.8.31 * Update NoScript to 5.0.9 * Bug 23166: Add new obfs4 bridge to the built-in ones * Bug 23258: Fix broken HTTPS-Everywhere on higher security levels diff --git a/gitian/versions b/gitian/versions index 56ff0db..d6e1dd4 100755 --- a/gitian/versions +++ b/gitian/versions @@ -18,7 +18,7 @@ TORBROWSER_TAG=tor-browser-${FIREFOX_VERSION}-7.0-1-build1 TOR_TAG=tor-0.3.0.10 TORLAUNCHER_TAG=0.2.12.3 TORBUTTON_TAG=1.9.7.6 -HTTPSE_TAG=2017.8.19 +HTTPSE_TAG=2017.8.31 NSIS_TAG=v0.3.1 ZLIB_TAG=v1.2.8 LIBEVENT_TAG=release-2.0.22-stable

1 0

[tor-browser/tor-browser-52.3.0esr-7.5-2] squash! Bug 19273: Avoid JavaScript patching of the external app helper dialog.
by gk＠torproject.org 31 Aug '17

31 Aug '17

commit 9ecbfca98dc5488527495e3bfde0fabf75a8529a Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Aug 30 16:58:52 2017 -0400 squash! Bug 19273: Avoid JavaScript patching of the external app helper dialog. When handling an external URI or downloading a file, invoke Torbutton's external app blocker component (which will present a download warning dialog unless the user has checked the "Automatically download files from now on" box). For e10s compatibility, avoid using a modal dialog and instead use a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton to indicate the user's desire to cancel or continue each request. Other bugs fixed: Bug 21766: Crash with e10s enabled while trying to download a file Bug 21886: Download is stalled in non-e10s mode Bug 22471: Downloading files via the PDF viewer download button is broken Bug 22472: Fix FTP downloads when external helper app dialog is shown Bug 22610: Avoid crashes when canceling external helper app downloads Bug 22618: Downloading pdf file via file:/// is stalling --- uriloader/exthandler/nsExternalHelperAppService.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uriloader/exthandler/nsExternalHelperAppService.cpp b/uriloader/exthandler/nsExternalHelperAppService.cpp index df08905304fb..1c0dd8ee66f7 100644 --- a/uriloader/exthandler/nsExternalHelperAppService.cpp +++ b/uriloader/exthandler/nsExternalHelperAppService.cpp @@ -606,7 +606,7 @@ public: NS_DECL_THREADSAFE_ISUPPORTS NS_DECL_NSIHELPERAPPWARNINGLAUNCHER - nsExternalLoadURIHandler(nsIInterfaceRequestor * aWindowContext, + nsExternalLoadURIHandler(nsIInterfaceRequestor *aWindowContext, nsIURI *aURI, nsIHandlerInfo *aHandlerInfo); @@ -669,7 +669,7 @@ NS_IMETHODIMP nsExternalLoadURIHandler::ContinueRequest() bool alwaysAsk = true; mHandlerInfo->GetAlwaysAskBeforeHandling(&alwaysAsk); - // if we are not supposed to ask, and the preferred action is to use + // If we are not supposed to ask, and the preferred action is to use // a helper app or the system default, we just launch the URI. if (!alwaysAsk && (preferredAction == nsIHandlerInfo::useHelperApp || preferredAction == nsIHandlerInfo::useSystemDefault)) @@ -1786,7 +1786,7 @@ NS_IMETHODIMP nsExternalAppHandler::OnStartRequest(nsIRequest *request, nsISuppo NS_IMETHODIMP nsExternalAppHandler::ContinueRequest() { // Break our reference cycle with the download warning dialog (set up in - // OnStartRequest) + // OnStartRequest). mWarningDialog = nullptr; // now that the temp file is set up, find out if we need to invoke a dialog @@ -1908,7 +1908,7 @@ NS_IMETHODIMP nsExternalAppHandler::ContinueRequest() NS_IMETHODIMP nsExternalAppHandler::CancelRequest(nsresult aReason) { // Break our reference cycle with the download warning dialog (set up in - // OnStartRequest) + // OnStartRequest). mWarningDialog = nullptr; return Cancel(aReason);

1 0

[torbutton/master] fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog.
by gk＠torproject.org 31 Aug '17

31 Aug '17

commit 8e5e391c71d6c5f3ae80c88e45d1e8522f981214 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Aug 30 12:06:24 2017 -0400 fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog. Improve the overview/summary comment in external-app-blocker.js. --- src/components/external-app-blocker.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/components/external-app-blocker.js b/src/components/external-app-blocker.js index ca86580..1f88fc7 100644 --- a/src/components/external-app-blocker.js +++ b/src/components/external-app-blocker.js @@ -8,9 +8,8 @@ * due to Firefox Bug https://bugzilla.mozilla.org/show_bug.cgi?id=440892 * * An instance of this module is created each time the browser starts to - * download a file that may be opened by another or application and when - * an external application may be invoked to handle an URL (e.g., when the - * user clicks on a mailto: URL). + * download a file and when an external application may be invoked to + * handle an URL (e.g., when the user clicks on a mailto: URL). *************************************************************************/ const Cc = Components.classes;

1 0

[tor-launcher/master] Bug 22232: fix typo in README-BOOTSTRAP.
by brade＠torproject.org 30 Aug '17

30 Aug '17

commit a120bb02f4dbcb3e26fe0c031d383a9a8681678a Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Aug 30 10:43:34 2017 -0400 Bug 22232: fix typo in README-BOOTSTRAP. --- README-BOOTSTRAP | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README-BOOTSTRAP b/README-BOOTSTRAP index 8bc2a76..a5354e7 100644 --- a/README-BOOTSTRAP +++ b/README-BOOTSTRAP @@ -35,7 +35,7 @@ mBootstrapErrorOccurred (Boolean) This is set to true when a mIsBootstrapDone is set to true as well as after the user makes changes to their settings (after a SAVECONF is done). -The PROGRESS field of the STATUS_CLIENT messages are used directly +The PROGRESS field within each STATUS_CLIENT message is used directly to display the completion percentage (progress bar). The TAG= keywords within the STATUS_CLIENT messages are used for

1 0

[tor-browser-build/master] README: mention that rbm is included as a git submodule
by boklm＠torproject.org 30 Aug '17

30 Aug '17

commit da7485a0b8f89b9ee2278d6132fc7bb53d5220e8 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Wed Aug 30 14:45:07 2017 +0200 README: mention that rbm is included as a git submodule --- README | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README b/README index 4381074..10cadec 100644 --- a/README +++ b/README @@ -46,6 +46,10 @@ If you are running Debian or Ubuntu, you can install them with: libdigest-sha-perl libdata-uuid-perl libdata-dump-perl \ libfile-copy-recursive-perl git libgtk2.0-dev curl runc +The build system is based on rbm, which is included as a git submodule +in the rbm/ directory. You can fetch the rbm git submodule by running +'make submodule-update'. + Starting a build ----------------

1 0

[tor-launcher/master] Bug 23240: retrieve current bootstrap progress before showing progress bar
by gk＠torproject.org 29 Aug '17

29 Aug '17

commit 26d284e3835ddd5b283b732278b7b5b740bace6e Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Mon Aug 14 16:09:47 2017 -0400 Bug 23240: retrieve current bootstrap progress before showing progress bar To avoid showing an incorrect progress value, keep the progress bar hidden until after we have retrieved the current bootstrap progress value. --- src/chrome/content/progress.js | 28 +++++++++++++++++++++++++++- src/chrome/content/progress.xul | 5 +++-- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/src/chrome/content/progress.js b/src/chrome/content/progress.js index 48362e7..f7bcaff 100644 --- a/src/chrome/content/progress.js +++ b/src/chrome/content/progress.js @@ -1,4 +1,4 @@ -// Copyright (c) 2015, The Tor Project, Inc. +// Copyright (c) 2017, The Tor Project, Inc. // See LICENSE for licensing information. // // vim: set sw=2 sts=2 ts=8 et syntax=javascript: @@ -81,6 +81,16 @@ function initDialog() if (pleaseWait) pleaseWait.removeAttribute("hidden"); } + + // To avoid showing an incorrect progress value, we keep the progress bar + // hidden until a TorBootstrapStatus notification is received. We request + // the most recent bootstrap status info (which should cause such a + // notification to be generated) and also start a fail-safe timer to ensure + // that the progress bar is displayed within 2 seconds in all cases. + let protocolSvc = Cc["@torproject.org/torlauncher-protocol-service;1"] + .getService(Ci.nsISupports).wrappedJSObject; + protocolSvc.TorRetrieveBootstrapStatus(); + window.setTimeout(function() { showProgressMeterIfNoError(); }, 2000); } @@ -158,6 +168,17 @@ function stopTorBootstrap() } +function showProgressMeterIfNoError() +{ + let meter = document.getElementById("progressMeter"); + if (meter && + !document.documentElement.hasAttribute("bootstrapErrorOccurred")) + { + meter.style.visibility = "visible"; + } +} + + var gObserver = { // nsIObserver implementation. observe: function(aSubject, aTopic, aParam) @@ -184,7 +205,10 @@ var gObserver = { var meter = document.getElementById("progressMeter"); if (meter) + { meter.value = percentComplete; + showProgressMeterIfNoError(); + } var bootstrapDidComplete = (percentComplete >= 100); if (percentComplete >= 100) @@ -199,6 +223,8 @@ var gObserver = { if (s) labelText = s; + document.documentElement.setAttribute("bootstrapErrorOccurred", true); + if (meter) meter.setAttribute("hidden", true); diff --git a/src/chrome/content/progress.xul b/src/chrome/content/progress.xul index 473dab9..5b26110 100644 --- a/src/chrome/content/progress.xul +++ b/src/chrome/content/progress.xul @@ -1,6 +1,6 @@ <?xml version="1.0"?>  @@ -37,7 +37,8 @@ <description id="progressDesc" /> </vbox> </hbox> - <progressmeter id="progressMeter" mode="determined" value="0" /> + <progressmeter id="progressMeter" mode="determined" value="0" + style="visibility:hidden" /> <description id="progressPleaseWait" hidden="true">&torprogress.pleaseWait;</description> </vbox>

1 0

[tor-launcher/master] Bug 22232: gather info on use of bootstrap status messages
by brade＠torproject.org 29 Aug '17

29 Aug '17

commit ab8e081f3007f45e98171e163f080fea8caad964 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue Aug 29 15:55:21 2017 -0400 Bug 22232: gather info on use of bootstrap status messages --- README-BOOTSTRAP | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/README-BOOTSTRAP b/README-BOOTSTRAP new file mode 100644 index 0000000..8bc2a76 --- /dev/null +++ b/README-BOOTSTRAP @@ -0,0 +1,68 @@ +HOW TOR LAUNCHER USES BOOTSTRAP STATUS MESSAGES + +(This information was originally recorded in +https://trac.torproject.org/projects/tor/ticket/22232) + +To start monitoring events, Tor Launcher issues the following Tor +control port command: + SETEVENTS STATUS_CLIENT NOTICE WARN ERR +Tor Launcher then looks for 650 responses. + +When one of the following responses is received, it is logged to +the browser console and added to an in-memory log buffer (which is +used to implement "Copy Tor Log To Clipboard"): + WARN, ERR, DEBUG, INFO, NOTICE + +Tor Launcher also issues a GETINFO status/bootstrap-phase command +soon after the control port connection has been established. + +When a STATUS_CLIENT message is received, Tor Launcher uses the +info contained within the message to detect bootstrap errors and +to show progress. The GETINFO status/bootstrap-phase response is +used for this same purpose (both kinds of response messages are +parsed and processed by the same code). + +Tor Launcher maintains two important pieces of internal state +information about the bootstrap process: + +mIsBootstrapDone (Boolean) This is set to true when a STATUS_CLIENT + BOOTSTRAP event with PROGRESS=100 is received. It is set to false + when any other STATUS_CLIENT BOOTSTRAP event is received. + +mBootstrapErrorOccurred (Boolean) This is set to true when a + STATUS_CLIENT BOOTSTRAP event with a severity of WARN or ERR, and + RECOMMENDATION of warn is received. It is set to false when + mIsBootstrapDone is set to true as well as after the user makes + changes to their settings (after a SAVECONF is done). + +The PROGRESS field of the STATUS_CLIENT messages are used directly +to display the completion percentage (progress bar). + +The TAG= keywords within the STATUS_CLIENT messages are used for +two purposes: + +1. The values are mapped to localized strings and displayed in the +progress window. If Tor Launcher cannot map the TAG to a localized +string, it displays the SUMMARY text instead (otherwise, the SUMMARY +field is not used). + +2. The TAG value along with REASON is used to suppress repeated +errors. When Tor Launcher sets mBootstrapErrorOccurred to true (see +above), an error is shown to the user unless the previous error +displayed had the same TAG and REASON values. + +The "Copy Tor Log To Clipboard" button is displayed with the warning +icon when Tor Launcher detects a bootstrap error (see +mBootstrapErrorOccurred above) or when it receives a log message +event with severity of WARN or ERR. + +The severity value within a STATUS_CLIENT BOOTSTRAP event is used +to detect bootstrap errors (as described above) and also to determine +the level for local logging. + +When displaying errors, Tor Launcher tries to map the REASON values +to localized strings. If this fails, the WARNING text is displayed +instead. HOSTADDR is appended to the error text when it is present. + +RECOMMENDATION is part of the information that is used to determine +if a bootstrap error has occurred (as described above).

1 0