- tbb-commits - lists.torproject.org

[tor-browser-build/master] Merge remote-tracking branch 'sukhe/bug-26153'
by gk＠torproject.org 06 Jun '18

06 Jun '18

commit 4074cbc2a727daf51ff9fdab29e0a0da3ec078aa Merge: e76952c d161cb7 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jun 6 19:02:02 2018 +0000 Merge remote-tracking branch 'sukhe/bug-26153' projects/firefox/build | 14 +++++++------- projects/firefox/config | 6 +++--- projects/selfrando/config | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --cc projects/firefox/build index 8278c14,cbd9250..83a7691 --- a/projects/firefox/build +++ b/projects/firefox/build @@@ -40,15 -40,15 +40,15 @@@ EO export PATH="/var/tmp/dist/binutils/bin:$PATH" [% END -%] - #[% IF c("var/linux") && ! c("var/release") -%] - # tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/selfrando') %] - # # Selfrando wrapper - # export PATH="/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/:$PATH" - # # We need to avoid the shuffling while building as this breaks compilation - # export SELFRANDO_skip_shuffle= - #[% END -%] + [% IF c("var/linux") && ! c("var/release") -%] + tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/selfrando') %] + # Selfrando wrapper + export PATH="/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/:$PATH" + # We need to avoid the shuffling while building as this breaks compilation + export SELFRANDO_skip_shuffle= + [% END -%] -[% IF c("var/linux") %] +[% IF ! c("var/windows") %] mkdir -p /var/tmp/dist tar -C /var/tmp/dist -xf [% c('input_files_by_name/rust') %] export PATH="/var/tmp/dist/rust/bin:$PATH" diff --cc projects/firefox/config index 927fb0b,418daa3..97efc7b --- a/projects/firefox/config +++ b/projects/firefox/config @@@ -81,13 -81,11 +81,13 @@@ input_files - project: binutils name: binutils enable: '[% c("var/linux") %]' - # - project: selfrando - # name: selfrando - # enable: '[% c("var/linux") && ! c("var/release") %]' + - project: selfrando + name: selfrando + enable: '[% c("var/linux") && ! c("var/release") %]' - filename: fix-info-plist.py enable: '[% c("var/osx") %]' + - filename: no-dmg.patch + enable: '[% c("var/osx") %]' - URL: https://people.torproject.org/~gk/mirrors/sources/msvcr100.dll sha256sum: 8793353461826fbd48f25ea8b835be204b758ce7510db2af631b28850355bd18 enable: '[% c("var/windows-i686") %]'

1 0

[tor-browser-build/master] Bug 26153: Selfrando builds broken for Firefox 60 ESR
by gk＠torproject.org 06 Jun '18

06 Jun '18

commit d161cb720ea36ccd547acd385752fe353279761f Author: Sukhbir Singh <sukhbir(a)torproject.org> Date: Wed Jun 6 11:01:19 2018 -0400 Bug 26153: Selfrando builds broken for Firefox 60 ESR This commit fixes #26153 by bumping the selfrando version to 0.4.2 --- projects/firefox/build | 14 +++++++------- projects/firefox/config | 6 +++--- projects/selfrando/config | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/projects/firefox/build b/projects/firefox/build index 62186d1..cbd9250 100644 --- a/projects/firefox/build +++ b/projects/firefox/build @@ -40,13 +40,13 @@ EOF export PATH="/var/tmp/dist/binutils/bin:$PATH" [% END -%] -#[% IF c("var/linux") && ! c("var/release") -%] -# tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/selfrando') %] -# # Selfrando wrapper -# export PATH="/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/:$PATH" -# # We need to avoid the shuffling while building as this breaks compilation -# export SELFRANDO_skip_shuffle= -#[% END -%] +[% IF c("var/linux") && ! c("var/release") -%] + tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/selfrando') %] + # Selfrando wrapper + export PATH="/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/:$PATH" + # We need to avoid the shuffling while building as this breaks compilation + export SELFRANDO_skip_shuffle= +[% END -%] [% IF c("var/linux") %] mkdir -p /var/tmp/dist diff --git a/projects/firefox/config b/projects/firefox/config index d6b8313..418daa3 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -81,9 +81,9 @@ input_files: - project: binutils name: binutils enable: '[% c("var/linux") %]' -# - project: selfrando -# name: selfrando -# enable: '[% c("var/linux") && ! c("var/release") %]' + - project: selfrando + name: selfrando + enable: '[% c("var/linux") && ! c("var/release") %]' - filename: fix-info-plist.py enable: '[% c("var/osx") %]' - URL: https://people.torproject.org/~gk/mirrors/sources/msvcr100.dll diff --git a/projects/selfrando/config b/projects/selfrando/config index 07195f7..82acc23 100644 --- a/projects/selfrando/config +++ b/projects/selfrando/config @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' -version: 0.4.1 +version: 0.4.2 git_hash: 'tb-v[% c("version") %]' git_url: https://github.com/immunant/selfrando.git gpg_keyring: selfrando.gpg

1 0

[tor-browser-build/master] Bug 24632: Adapt firefox and tor-browser to new macOS toolchain
by gk＠torproject.org 06 Jun '18

06 Jun '18

commit e76952c389487d657c3f52fede5e9ca56ec02397 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jun 6 18:22:41 2018 +0000 Bug 24632: Adapt firefox and tor-browser to new macOS toolchain After building Firefox we now get a 'Tor Browser.app' instead of a 'TorBrowser.app'. This patch makes sure the additional whitespace in the app name is correctly handled by the build script and the one that deals with packaging the final bundle. We need to ship a fix for the Firefox packaging step as well as |./mach package| wants to build the final .dmg in that step, too, which breaks: there is no .dmg creation tool available. Setting `INNER_MAKE_PACKAGE` to `true` does not seem to work anymore. That part of this patch is currently only a workaround to get the nightly builds going. We should come up with a better solution that allows us to skip that part of the Firefox packaging step on all supported platforms. --- projects/firefox/build | 25 ++++++++++------ projects/firefox/config | 4 ++- projects/firefox/no-dmg.patch | 29 ++++++++++++++++++ projects/tor-browser/build | 70 +++++++++++++++++++++---------------------- 4 files changed, 83 insertions(+), 45 deletions(-) diff --git a/projects/firefox/build b/projects/firefox/build index 62186d1..8278c14 100644 --- a/projects/firefox/build +++ b/projects/firefox/build @@ -48,10 +48,13 @@ EOF # export SELFRANDO_skip_shuffle= #[% END -%] -[% IF c("var/linux") %] +[% IF ! c("var/windows") %] mkdir -p /var/tmp/dist tar -C /var/tmp/dist -xf [% c('input_files_by_name/rust') %] export PATH="/var/tmp/dist/rust/bin:$PATH" +[% END -%] + +[% IF c("var/linux") %] # Add llvm so stylo can build tar -C /var/tmp/dist -xf [% c('input_files_by_name/llvm') %] export LLVM_CONFIG="/var/tmp/dist/llvm/bin/llvm-config" @@ -60,7 +63,7 @@ EOF tar -C /var/tmp/build -xf [% project %]-[% c('version') %].tar.gz [% IF c("var/osx") %] - mkdir -p $distdir/TorBrowser.app/Contents/MacOS + mkdir -p "$distdir/Tor Browser.app/Contents/MacOS" [% ELSE %] mkdir -p $distdir/Browser [% END %] @@ -118,6 +121,10 @@ fi patch -p1 < $rootdir/STL_win64.patch [% END -%] +[% IF c("var/osx") %] + patch -p1 < $rootdir/no-dmg.patch +[% END -%] + rm -f configure rm -f js/src/configure @@ -128,12 +135,12 @@ rm -f js/src/configure [% IF c("var/osx") %] cp -a obj-macos/dist/firefox/* $distdir # Remove firefox-bin (we don't use it, see ticket #10126) - rm -f $distdir/TorBrowser.app/Contents/MacOS/firefox-bin + rm -f "$distdir/Tor Browser.app/Contents/MacOS/firefox-bin" # Adjust the Info.plist file - INFO_PLIST=$distdir/TorBrowser.app/Contents/Info.plist - mv $INFO_PLIST tmp.plist - python $rootdir/fix-info-plist.py '[% c("var/torbrowser_version") %]' '[% c("var/copyright_year") %]' < tmp.plist > $INFO_PLIST + INFO_PLIST="$distdir/Tor Browser.app/Contents/Info.plist" + mv "$INFO_PLIST" tmp.plist + python $rootdir/fix-info-plist.py '[% c("var/torbrowser_version") %]' '[% c("var/copyright_year") %]' < tmp.plist > "$INFO_PLIST" rm -f tmp.plist [% END %] @@ -198,8 +205,8 @@ cd $distdir [% c("var/rezip", { rezip_file => 'Browser/omni.ja' }) %] [% c("var/rezip", { rezip_file => 'Browser/browser/omni.ja' }) %] [% ELSIF c("var/osx") %] - [% c("var/rezip", { rezip_file => 'TorBrowser.app/Contents/Resources/omni.ja' }) %] - [% c("var/rezip", { rezip_file => 'TorBrowser.app/Contents/Resources/browser/omni.ja' }) %] + [% c("var/rezip", { rezip_file => '"Tor Browser.app/Contents/Resources/omni.ja"' }) %] + [% c("var/rezip", { rezip_file => '"Tor Browser.app/Contents/Resources/browser/omni.ja"' }) %] [% END %] [% IF c("var/windows") %] @@ -211,7 +218,7 @@ mkdir -p [% dest_dir _ '/' _ c('filename') %] [% IF c("var/osx"); - SET browserdir='TorBrowser.app/Contents'; + SET browserdir='"Tor Browser.app/Contents"'; ELSE; SET browserdir='Browser'; END; diff --git a/projects/firefox/config b/projects/firefox/config index d6b8313..927fb0b 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -86,6 +86,8 @@ input_files: # enable: '[% c("var/linux") && ! c("var/release") %]' - filename: fix-info-plist.py enable: '[% c("var/osx") %]' + - filename: no-dmg.patch + enable: '[% c("var/osx") %]' - URL: https://people.torproject.org/~gk/mirrors/sources/msvcr100.dll sha256sum: 8793353461826fbd48f25ea8b835be204b758ce7510db2af631b28850355bd18 enable: '[% c("var/windows-i686") %]' @@ -99,7 +101,7 @@ input_files: enable: '[% c("var/windows-x86_64") %]' - project: rust name: rust - enable: '[% c("var/linux") %]' + enable: '[% ! c("var/windows") %]' - project: llvm name: llvm enable: '[% c("var/linux") %]' diff --git a/projects/firefox/no-dmg.patch b/projects/firefox/no-dmg.patch new file mode 100644 index 0000000..1e722af --- /dev/null +++ b/projects/firefox/no-dmg.patch @@ -0,0 +1,29 @@ +From 7204fc9191a55dbbd3b94ee2d64ece8d9910cf23 Mon Sep 17 00:00:00 2001 +From: Georg Koppen <gk(a)torproject.org> +Date: Thu, 31 May 2018 19:15:18 +0000 +Subject: [PATCH] Don't create a .dmg yet + + +diff --git a/toolkit/mozapps/installer/upload-files.mk b/toolkit/mozapps/installer/upload-files.mk +index 8ace9703a160..82df89d1f431 100644 +--- a/toolkit/mozapps/installer/upload-files.mk ++++ b/toolkit/mozapps/installer/upload-files.mk +@@ -216,14 +216,7 @@ ifeq ($(MOZ_PKG_FORMAT),DMG) + + _ABS_MOZSRCDIR = $(shell cd $(MOZILLA_DIR) && pwd) + PKG_DMG_SOURCE = $(MOZ_PKG_DIR) +- INNER_MAKE_PACKAGE = \ +- $(call py_action,make_dmg, \ +- $(if $(MOZ_PKG_MAC_DSSTORE),--dsstore '$(MOZ_PKG_MAC_DSSTORE)') \ +- $(if $(MOZ_PKG_MAC_BACKGROUND),--background '$(MOZ_PKG_MAC_BACKGROUND)') \ +- $(if $(MOZ_PKG_MAC_ICON),--icon '$(MOZ_PKG_MAC_ICON)') \ +- --volume-name '$(MOZ_APP_DISPLAYNAME)' \ +- '$(PKG_DMG_SOURCE)' '$(PACKAGE)' \ +- ) ++ INNER_MAKE_PACKAGE = true + INNER_UNMAKE_PACKAGE = \ + $(call py_action,unpack_dmg, \ + $(if $(MOZ_PKG_MAC_DSSTORE),--dsstore '$(MOZ_PKG_MAC_DSSTORE)') \ +-- +2.17.0 + diff --git a/projects/tor-browser/build b/projects/tor-browser/build index 4d1be00..d807633 100644 --- a/projects/tor-browser/build +++ b/projects/tor-browser/build @@ -14,7 +14,7 @@ mkdir -p $OUTDIR TB_STAGE_DIR=$distdir/tor-browser-stage [% IF c("var/osx") %] - TBDIR=$TB_STAGE_DIR/TorBrowser.app + TBDIR="$TB_STAGE_DIR/Tor Browser.app" DOCSPATH=Contents/Resources/TorBrowser/Docs EXTSPATH=Contents/Resources/distribution/extensions @@ -34,11 +34,11 @@ TB_STAGE_DIR=$distdir/tor-browser-stage EXTOVERRIDESPATH=TorBrowser/Data/Browser/profile.default/preferences/extension-overrides.js MEEKPROFILEPATH=TorBrowser/Data/Browser/profile.meek-http-helper - mkdir -p $TBDIR/TorBrowser/Data/Browser/Caches + mkdir -p "$TBDIR/TorBrowser/Data/Browser/Caches" [% END %] -mkdir -p $TBDIR/$EXTSPATH -mkdir -p $TBDIR/$MEEKPROFILEPATH/extensions +mkdir -p "$TBDIR/$EXTSPATH" +mkdir -p "$TBDIR/$MEEKPROFILEPATH/extensions" # Extract the MAR tools. unzip -d $rootdir $rootdir/[% c('input_files_by_name/firefox') %]/mar-tools-*.zip @@ -49,23 +49,23 @@ MARTOOLS=$rootdir/mar-tools unzip -d $rootdir $rootdir/mar-tools-linux32.zip [% END -%] -mv [% c('input_files_by_name/tor-launcher') %] $TBDIR/$EXTSPATH/tor-launcher(a)torproject.org.xpi -mv [% c('input_files_by_name/torbutton') %] $TBDIR/$EXTSPATH/torbutton(a)torproject.org.xpi -mv [% c('input_files_by_name/https-everywhere') %] $TBDIR/$EXTSPATH/https-everywhere-eff(a)eff.org.xpi -mv [% c('input_files_by_name/noscript') %] $TBDIR/$EXTSPATH/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi +mv [% c('input_files_by_name/tor-launcher') %] "$TBDIR/$EXTSPATH/tor-launcher(a)torproject.org.xpi" +mv [% c('input_files_by_name/torbutton') %] "$TBDIR/$EXTSPATH/torbutton(a)torproject.org.xpi" +mv [% c('input_files_by_name/https-everywhere') %] "$TBDIR/$EXTSPATH/https-everywhere-eff(a)eff.org.xpi" +mv [% c('input_files_by_name/noscript') %] "$TBDIR/$EXTSPATH/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi" -tar -C $TBDIR -xf [% c('input_files_by_name/obfs4') %] -tar -C $TBDIR -xf [% c('input_files_by_name/meek') %] -mv $TBDIR/meek-http-helper(a)bamsoftware.com.xpi $TBDIR/$MEEKPROFILEPATH/extensions/ +tar -C "$TBDIR" -xf [% c('input_files_by_name/obfs4') %] +tar -C "$TBDIR" -xf [% c('input_files_by_name/meek') %] +mv "$TBDIR/meek-http-helper(a)bamsoftware.com.xpi" "$TBDIR/$MEEKPROFILEPATH/extensions/" [% IF c("var/snowflake") %] - tar -C $TBDIR -xf [% c('input_files_by_name/snowflake') -%] + tar -C "$TBDIR" -xf [% c('input_files_by_name/snowflake') -%] [% END -%] [% IF c("var/fteproxy") -%] - tar -C $TBDIR -xf [% c('input_files_by_name/fteproxy') %] + tar -C "$TBDIR" -xf [% c('input_files_by_name/fteproxy') %] [% END -%] -tar -C $TBDIR[% IF c("var/osx") %]/Contents/Resources[% END %] -xf [% c('input_files_by_name/fonts') %] +tar -C "$TBDIR[% IF c("var/osx") %]/Contents/Resources[% END %]" -xf [% c('input_files_by_name/fonts') %] [% IF c("var/linux") %] cp RelativeLink/* ${TB_STAGE_DIR}/Browser/ @@ -77,7 +77,7 @@ RBM_TB_EOF [% END %] tar -C ${TB_STAGE_DIR} -xf [% c('input_files_by_name/firefox') %]/tor-browser.tar.gz -tar -C $TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %] -xf [% c('input_files_by_name/tor') %]/tor.tar.gz +tar -C "$TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %]" -xf [% c('input_files_by_name/tor') %]/tor.tar.gz [% IF c("var/linux"); SET bundledata_osname = 'linux'; @@ -107,8 +107,8 @@ tar -C $TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %] -xf [% c('input_files_b mv $SKELETON_TMP Bundle-Data/mac # Install a "tor" shim that sets the working directory. See #10030. - mv $TBDIR/$TORBINPATH/tor $TBDIR/$TORBINPATH/tor.real - cp Bundle-Data/mac-tor.sh $TBDIR/$TORCONFIGPATH/tor + mv "$TBDIR/$TORBINPATH/tor" "$TBDIR/$TORBINPATH/tor.real" + cp Bundle-Data/mac-tor.sh "$TBDIR/$TORCONFIGPATH/tor" [% IF ! c("var/release") -%] SANDBOX_FOLDER="$TB_STAGE_DIR/Sandboxed Tor Browser" @@ -118,17 +118,17 @@ tar -C $TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %] -xf [% c('input_files_b tar -C Bundle-Data/mac-applications.dmg -c . | tar -C $TB_STAGE_DIR -x [% END %] -mkdir -p $TBDIR/$DOCSPATH -cp -a Bundle-Data/Docs/* $TBDIR/$DOCSPATH -tar -C Bundle-Data/[% bundledata_osname %] -c . | tar -C $TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %] -x +mkdir -p "$TBDIR/$DOCSPATH" +cp -a Bundle-Data/Docs/* "$TBDIR/$DOCSPATH" +tar -C Bundle-Data/[% bundledata_osname %] -c . | tar -C "$TBDIR[% IF ! c("var/osx") %]/TorBrowser[% END %]" -x -cat Bundle-Data/PTConfigs/[% bundledata_osname %]/torrc-defaults-appendix >> $TBDIR/$TORCONFIGPATH/torrc-defaults +cat Bundle-Data/PTConfigs/[% bundledata_osname %]/torrc-defaults-appendix >> "$TBDIR/$TORCONFIGPATH/torrc-defaults" [% IF c("var/linux") -%] [% IF ! c("var/snowflake") %] grep -v 'default_bridge\.snowflake' Bundle-Data/PTConfigs/bridge_prefs.js \ - >> $TBDIR/$EXTOVERRIDESPATH + >> "$TBDIR/$EXTOVERRIDESPATH" [% ELSE %] - cat Bundle-Data/PTConfigs/bridge_prefs.js >> $TBDIR/$EXTOVERRIDESPATH + cat Bundle-Data/PTConfigs/bridge_prefs.js >> "$TBDIR/$EXTOVERRIDESPATH" [% END %] [% END -%] [% IF c("var/windows") -%] @@ -136,18 +136,18 @@ cat Bundle-Data/PTConfigs/[% bundledata_osname %]/torrc-defaults-appendix >> $TB # We don't have fte available on Windows x86_64 yet grep -v 'default_bridge\.snowflake' Bundle-Data/PTConfigs/bridge_prefs.js \ [% IF c("var/windows-x86_64") %]| grep -v 'default_bridge\.fte' [% END %] \ - >> $TBDIR/$EXTOVERRIDESPATH + >> "$TBDIR/$EXTOVERRIDESPATH" [% END -%] [% IF c("var/osx") -%] # FTE is temporarily removed due to bug 18495. grep -Ev 'default_bridge\.fte' Bundle-Data/PTConfigs/bridge_prefs.js \ [% IF ! c("var/snowflake") %]| grep -v 'default_bridge\.snowflake' [% END %] \ - >> $TBDIR/$EXTOVERRIDESPATH + >> "$TBDIR/$EXTOVERRIDESPATH" [% END -%] -cat Bundle-Data/PTConfigs/meek-http-helper-user.js >> $TBDIR/$MEEKPROFILEPATH/user.js +cat Bundle-Data/PTConfigs/meek-http-helper-user.js >> "$TBDIR/$MEEKPROFILEPATH/user.js" [% IF c("var/osx") %] - pushd $TBDIR + pushd "$TBDIR" # Create the meek-template-sha256sum.txt file by generating a list # of hashes (one for each file within the meek-http-helper profile) and # and then generating one final hash from the contents of the list. @@ -156,8 +156,8 @@ cat Bundle-Data/PTConfigs/meek-http-helper-user.js >> $TBDIR/$MEEKPROFILEPATH/us [% END %] [% IF ! c("var/multi_lingual") %] - echo 'pref("extensions.torlauncher.prompt_for_locale", false);' >> $TBDIR/$EXTOVERRIDESPATH - echo 'pref("intl.locale.matchOS", false);' >> $TBDIR/$EXTOVERRIDESPATH + echo 'pref("extensions.torlauncher.prompt_for_locale", false);' >> "$TBDIR/$EXTOVERRIDESPATH" + echo 'pref("intl.locale.matchOS", false);' >> "$TBDIR/$EXTOVERRIDESPATH" [% END %] [% IF c("var/linux") %] @@ -178,7 +178,7 @@ cat Bundle-Data/PTConfigs/meek-http-helper-user.js >> $TBDIR/$MEEKPROFILEPATH/us [% END %] -pushd $TBDIR[% IF c("var/osx") %]/Contents/Resources[% END %]/browser/ +pushd "$TBDIR[% IF c("var/osx") %]/Contents/Resources[% END %]/browser/" # For the proper search engines in our language packs unzip omni.ja chrome/en-US/locale/browser/searchplugins* || [ $? -lt 3 ] mv chrome/en-US/locale/browser/searchplugins $rootdir @@ -223,7 +223,7 @@ popd }) %] # If we are building a multi-lingual package, add all of the language packs. [% IF c("var/multi_lingual") %] - cp [% xpi %] $TBDIR/$EXTSPATH/langpack-[% lang %](a)firefox.mozilla.org.xpi + cp [% xpi %] "$TBDIR/$EXTSPATH/langpack-[% lang %](a)firefox.mozilla.org.xpi" [% END %] cd .. rm -rf prep_[% lang %] @@ -232,7 +232,7 @@ popd [% IF c("var/multi_lingual") %] # Set the update.locale (it is used to replace %LOCALE% within # app.update.url). - pushd $TBDIR[% IF c("var/osx") %]/Contents/Resources/[% END %] + pushd "$TBDIR[% IF c("var/osx") %]/Contents/Resources/[% END %]" echo ${PKG_LOCALE} > update.locale [% c("var/touch") %] update.locale zip -Xm omni.ja update.locale @@ -253,11 +253,11 @@ popd cp -a ${TB_STAGE_DIR} $distdir/$PKG_DIR [% IF c("var/windows") %] - TBDIR=$distdir/$PKG_DIR/"Tor Browser"/Browser + TBDIR="$distdir/$PKG_DIR/Tor Browser/Browser" [% ELSIF c("var/osx") %] - TBDIR=$distdir/$PKG_DIR/TorBrowser.app + TBDIR="$distdir/$PKG_DIR/Tor Browser.app" [% ELSE %] - TBDIR=$distdir/$PKG_DIR/Browser + TBDIR="$distdir/$PKG_DIR/Browser" [% END %] pushd "$TBDIR[% IF c("var/osx") %]/Contents/Resources/[% END %]"

1 0

[tor-browser-build/master] Bug 24632: Bump clang version in go build script comment
by boklm＠torproject.org 06 Jun '18

06 Jun '18

commit a0130c9a178ae919a400ad014d7f855a282c72b4 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Jun 4 06:13:36 2018 +0000 Bug 24632: Bump clang version in go build script comment --- projects/go/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/go/build b/projects/go/build index 5ab4c0c..b9057a5 100644 --- a/projects/go/build +++ b/projects/go/build @@ -52,7 +52,7 @@ cd /var/tmp/dist/go/src # http://golang.org/doc/install/source#environment export GOOS=darwin export GOARCH=amd64 - # faketime is needed because clang 3.8.0 on Darwin embeds the timestamps of + # faketime is needed because clang 3.9.1 on Darwin embeds the timestamps of # certain intermediate object files (including those that arise here while # compiling the Go runtime itself). Without this, variable timestamps would # end up in snowflake-client.

1 0

[tor-browser-build/master] Bug 24632: Adapt tor and OpenSSL for new macOS toolchain
by boklm＠torproject.org 06 Jun '18

06 Jun '18

commit 3b5038d90cac5cfcf6856cc0786cfa99adbc775a Author: Georg Koppen <gk(a)torproject.org> Date: Mon Jun 4 06:03:09 2018 +0000 Bug 24632: Adapt tor and OpenSSL for new macOS toolchain --- projects/openssl/build | 2 +- projects/openssl/config | 2 +- projects/tor/build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/openssl/build b/projects/openssl/build index 3851346..a3ff092 100644 --- a/projects/openssl/build +++ b/projects/openssl/build @@ -10,7 +10,7 @@ export CC='gcc -m32' [% END %] [% IF c("var/osx") -%] # Tricking OpenSSL into using our clang as cross-compiler - ln -s $clangdir/bin/clang $clangdir/bin/x86_64-apple-darwin10-cc + ln -s $clangdir/bin/clang $clangdir/bin/x86_64-apple-darwin11-cc export CC="cc [% c("var/FLAGS") %]" [% END -%] ./Configure --prefix=$distdir [% c('var/configure_opts') %] diff --git a/projects/openssl/config b/projects/openssl/config index 3489d42..fe1c5fa 100644 --- a/projects/openssl/config +++ b/projects/openssl/config @@ -19,7 +19,7 @@ targets: configure_opts: '-shared --cross-compile-prefix=[% c("arch") %]-w64-mingw32- mingw[% IF c("var/windows-x86_64") %]64[% END %] "[% c("var/CFLAGS") %] [% c("var/LDFLAGS") %]"' osx-x86_64: var: - configure_opts: --cross-compile-prefix=x86_64-apple-darwin10- darwin64-x86_64-cc enable-ec_nistp_64_gcc_128 + configure_opts: --cross-compile-prefix=x86_64-apple-darwin11- darwin64-x86_64-cc enable-ec_nistp_64_gcc_128 input_files: - project: container-image diff --git a/projects/tor/build b/projects/tor/build index c6d9895..3f845ea 100644 --- a/projects/tor/build +++ b/projects/tor/build @@ -88,7 +88,7 @@ cp $distdir/share/tor/geoip6 $TORCONFIGDIR cd $distdir cp bin/tor $TORBINDIR/ cd $TORBINDIR/ - x86_64-apple-darwin10-install_name_tool -change $libeventdir/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor + x86_64-apple-darwin11-install_name_tool -change $libeventdir/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor [% END %] cd $distdir

1 0

[tor-browser-build/master] Bug 24632: Disable snowflake for macOS for now
by boklm＠torproject.org 06 Jun '18

06 Jun '18

commit 3db16b9c473ec950452126700fc1e22f71ed8190 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Jun 4 06:15:20 2018 +0000 Bug 24632: Disable snowflake for macOS for now The snowflake build system is pretty complicated. We disable this pluggable transport for now to get time to adapt it to the new macOS toolchain while not blocking our nightly builds. See bug 26251 for work on that. --- rbm.conf | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/rbm.conf b/rbm.conf index 9a30353..28ce6f9 100644 --- a/rbm.conf +++ b/rbm.conf @@ -162,8 +162,7 @@ targets: var: linux: 1 compiler: gcc - # We only build snowflake for linux and osx on the alpha and nightly - # channels for now. + # We only build snowflake for linux on the alpha and nightly channels for now. snowflake: '[% c("var/alpha") || c("var/nightly") %]' fteproxy: 1 container: @@ -244,9 +243,8 @@ targets: FLAGS: "-target x86_64-apple-darwin11 -B $cctoolsdir -isysroot $sysrootdir" LDFLAGS: "-Wl,-syslibroot,$sysrootdir -Wl,-dead_strip -Wl,-pie" locale_ja: ja-JP-mac - # We only build snowflake for linux and osx on the alpha and nightly - # channels for now. - snowflake: '[% c("var/alpha") || c("var/nightly") %]' + # We only build snowflake for linux on the alpha and nightly channels for now. + snowflake: 0 #'[% c("var/alpha") || c("var/nightly") %]' deps: - build-essential - python

1 0

[tor-browser-build/master] Bug 24632: Use our new toolchain for rustc compilation
by boklm＠torproject.org 06 Jun '18

06 Jun '18

commit 7997d2322347f742e7f4ede47379119faeb03bdd Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 1 06:54:29 2018 +0000 Bug 24632: Use our new toolchain for rustc compilation --- projects/rust/build | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/projects/rust/build b/projects/rust/build index 69bc3a7..74ce74a 100644 --- a/projects/rust/build +++ b/projects/rust/build @@ -17,21 +17,21 @@ export PATH="$distdir-rust-old/bin:$PATH" # (i.e. Linux). unset CC unset LDFLAGS - # Target 10.6 as our toolchain does. Without this explicit declaration Bad + # Target 10.7 as our toolchain does. Without this explicit declaration Bad # Things will happen, as a lot of dependent code then assumes that the # official macOS target, x86_64-apple-darwin, essentially means 10.4. - export MACOSX_DEPLOYMENT_TARGET=10.6 + export MACOSX_DEPLOYMENT_TARGET=10.7 # The Rust target for macOS is x86_64-apple-darwin, yet our toolchain is built - # for x86_64-apple-darwin10. We can't mix those targets as clang gets confused - # that way. Changing the Rust target to x86_64-apple-darwin10 would require a - # fair amount of patching, thus we create symlinks to prvoide Rust with the - # necessary tools while using our toolchain underneath, targeting 10.6. + # for x86_64-apple-darwin11. We can't mix those targets as clang gets confused + # that way. Changing the Rust target to x86_64-apple-darwin11 would require a + # fair amount of patching, thus we create symlinks to provide Rust with the + # necessary tools while using our toolchain underneath, targeting 10.7. cd $cctoolsdir - for f in `ls x86_64-apple-darwin10-*`; do - ln -s $f ${f//x86_64-apple-darwin10/x86_64-apple-darwin} + for f in `ls x86_64-apple-darwin11-*`; do + ln -s $f ${f//x86_64-apple-darwin11/x86_64-apple-darwin} done cd .. - ln -s x86_64-apple-darwin10 x86_64-apple-darwin + ln -s x86_64-apple-darwin11 x86_64-apple-darwin mkdir -p $distdir/helper # We need to adapt our CFLAGS and make sure our flags are passed down to all @@ -40,7 +40,7 @@ export PATH="$distdir-rust-old/bin:$PATH" cat > $distdir/helper/x86_64-apple-darwin-clang << 'EOF' #!/bin/sh BASEDIR=/var/tmp/dist/macosx-toolchain -$BASEDIR/cctools/bin/x86_64-apple-darwin-clang -target x86_64-apple-darwin -mlinker-version=136 -B $BASEDIR/cctools/bin -isysroot $BASEDIR/SDK/ -Wl,-syslibroot,$BASEDIR/SDK/ -Wl,-dead_strip -Wl,-pie "$@" +$BASEDIR/cctools/bin/x86_64-apple-darwin-clang -target x86_64-apple-darwin -B $BASEDIR/cctools/bin -isysroot $BASEDIR/SDK/ -Wl,-syslibroot,$BASEDIR/SDK/ -Wl,-dead_strip -Wl,-pie "$@" EOF chmod +x $distdir/helper/x86_64-apple-darwin-clang

1 0

[tor-browser-build/master] Bug 26003: Clean up our mozconfig-osx-x86_64 file
by boklm＠torproject.org 04 Jun '18

04 Jun '18

commit 92aa4276c02c1619a9cf70d317c46092ef3ba7c0 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 1 20:18:12 2018 +0000 Bug 26003: Clean up our mozconfig-osx-x86_64 file --- projects/firefox/mozconfig-osx-x86_64 | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/projects/firefox/mozconfig-osx-x86_64 b/projects/firefox/mozconfig-osx-x86_64 index 9ac3ac8..1e30084 100644 --- a/projects/firefox/mozconfig-osx-x86_64 +++ b/projects/firefox/mozconfig-osx-x86_64 @@ -1,24 +1,21 @@ +TOOLCHAIN_DIR=/var/tmp/dist/macosx-toolchain + # ld needs libLTO.so from llvm -mk_add_options "export LD_LIBRARY_PATH=/var/tmp/dist/macosx-toolchain/clang/lib" +mk_add_options "export LD_LIBRARY_PATH=$TOOLCHAIN_DIR/clang/lib" -TOOLCHAIN_DIR=/var/tmp/dist/macosx-toolchain CROSS_CCTOOLS_PATH=$TOOLCHAIN_DIR/cctools CROSS_SYSROOT=$TOOLCHAIN_DIR/SDK CROSS_PRIVATE_FRAMEWORKS=$CROSS_SYSROOT/System/Library/PrivateFrameworks HARDENING_FLAGS="-Werror=format -Werror=format-security -fstack-protector-strong -D_FORTIFY_SOURCE=2" -FLAGS="-target x86_64-apple-darwin10 -mlinker-version=136 -B $CROSS_CCTOOLS_PATH/bin -isysroot $CROSS_SYSROOT $HARDENING_FLAGS" +FLAGS="-target x86_64-apple-darwin11 -B $CROSS_CCTOOLS_PATH/bin -isysroot $CROSS_SYSROOT $HARDENING_FLAGS" export CC="$TOOLCHAIN_DIR/clang/bin/clang $FLAGS" export CXX="$TOOLCHAIN_DIR/clang/bin/clang++ $FLAGS" export CPP="$TOOLCHAIN_DIR/clang/bin/clang $FLAGS -E" export LLVMCONFIG=$TOOLCHAIN_DIR/clang/bin/llvm-config export LDFLAGS="-Wl,-syslibroot,$CROSS_SYSROOT -Wl,-dead_strip -Wl,-pie" -export TOOLCHAIN_PREFIX=$CROSS_CCTOOLS_PATH/bin/x86_64-apple-darwin10- -#TODO: bug 1184202 - would be nice if these could be detected with TOOLCHAIN_PREFIX automatically -export AR=${TOOLCHAIN_PREFIX}ar -export RANLIB=${TOOLCHAIN_PREFIX}ranlib -export STRIP=${TOOLCHAIN_PREFIX}strip -export OTOOL=${TOOLCHAIN_PREFIX}otool +export BINDGEN_CFLAGS="$FLAGS" +export TOOLCHAIN_PREFIX=$CROSS_CCTOOLS_PATH/bin/x86_64-apple-darwin11- export DSYMUTIL="$TOOLCHAIN_DIR/clang/bin/llvm-dsymutil" export HOST_CC="$TOOLCHAIN_DIR/clang/bin/clang"

1 0

[tor-browser-build/master] Merge remote-tracking branch 'gk/bug_26003'
by boklm＠torproject.org 04 Jun '18

04 Jun '18

commit f3e479d86a4ef945279b6a2df4e997ad8a935b0a Merge: 5cf384c 92aa427 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Jun 4 14:21:09 2018 +0200 Merge remote-tracking branch 'gk/bug_26003' projects/firefox/mozconfig-osx-x86_64 | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)

1 0

[tor-browser-build/master] Bug 26195: Use new cctools for macOS toolchain
by boklm＠torproject.org 04 Jun '18

04 Jun '18

commit 5cf384c54a0dfd3edd44373bb9370e549fcf64f8 Author: Georg Koppen <gk(a)torproject.org> Date: Thu May 31 16:10:53 2018 +0000 Bug 26195: Use new cctools for macOS toolchain --- projects/macosx-toolchain/build | 9 +++++---- projects/macosx-toolchain/config | 5 ++--- rbm.conf | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/projects/macosx-toolchain/build b/projects/macosx-toolchain/build index 94954c5..d1d8c34 100644 --- a/projects/macosx-toolchain/build +++ b/projects/macosx-toolchain/build @@ -8,10 +8,11 @@ tar xf [% c('input_files_by_name/llvm') %] mv llvm "$distdir/clang" tar -C $distdir -xf [% c('input_files_by_name/cctools') %] cd $distdir/cctools/bin -ln -s ../../clang/bin/clang x86_64-apple-darwin10-clang -ln -s ../../clang/bin/clang++ x86_64-apple-darwin10-clang++ -# "go link" expects to find a program called "dsymutil" exactly. -ln -sf x86_64-apple-darwin10-dsymutil dsymutil +ln -s ../../clang/bin/clang x86_64-apple-darwin11-clang +ln -s ../../clang/bin/clang++ x86_64-apple-darwin11-clang++ +# "go link", libevent, and the jemalloc cross-compilation during the Rust build +# expect to find a program called "dsymutil" exactly. +ln -s ../../clang/bin/llvm-dsymutil dsymutil cd "/var/tmp/dist" [% c('tar', { diff --git a/projects/macosx-toolchain/config b/projects/macosx-toolchain/config index ff31abf..8502f57 100644 --- a/projects/macosx-toolchain/config +++ b/projects/macosx-toolchain/config @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz' -version: 10.7-1 +version: 10.11-1 var: container: use_container: 1 @@ -20,8 +20,7 @@ input_files: - name: llvm project: llvm - name: cctools - URL: https://people.torproject.org/~gk/mirrors/sources/cctools.tar.gz - sha256sum: e908fdebc2886ee5491ebfc7e7950af451b3c4e2439c2d7a923ed06ad05113e4 + project: cctools - name: SDK URL: https://people.torproject.org/~gk/mirrors/sources/MacOSX10.11.sdk.tar.bz2 sha256sum: d11e410d757d023be66d2fe7eaa85a1d232da3ac04f177eff3d8b8275cd9ffca diff --git a/rbm.conf b/rbm.conf index 19bee8e..9a30353 100644 --- a/rbm.conf +++ b/rbm.conf @@ -240,8 +240,8 @@ targets: suite: jessie arch: amd64 compiler: 'macosx-toolchain' - configure_opt: '--host=x86_64-apple-darwin10 CC="x86_64-apple-darwin10-clang [% c("var/FLAGS") %]" CXX="x86_64-apple-darwin10-clang++ [% c("var/FLAGS") %]"' - FLAGS: "-target x86_64-apple-darwin10 -mlinker-version=136 -B $cctoolsdir -isysroot $sysrootdir" + configure_opt: '--host=x86_64-apple-darwin11 CC="x86_64-apple-darwin11-clang [% c("var/FLAGS") %]" CXX="x86_64-apple-darwin11-clang++ [% c("var/FLAGS") %]"' + FLAGS: "-target x86_64-apple-darwin11 -B $cctoolsdir -isysroot $sysrootdir" LDFLAGS: "-Wl,-syslibroot,$sysrootdir -Wl,-dead_strip -Wl,-pie" locale_ja: ja-JP-mac # We only build snowflake for linux and osx on the alpha and nightly

1 0