- tbb-commits - lists.torproject.org

[tor-browser-build/master] Merge remote-tracking branch 'gk/bug_27210_v3'
by boklm＠torproject.org 05 Mar '19

05 Mar '19

commit ba9064e4b5a369b9c70201e335ef706db25f2815 Merge: 799ccf0 f4b5f7b Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Mar 5 21:45:55 2019 +0100 Merge remote-tracking branch 'gk/bug_27210_v3' Conflicts: projects/orbot/build Makefile | 15 +++++++++++ projects/android-toolchain/build | 10 +++++-- projects/firefox/config | 2 +- projects/firefox/mozconfig-android-x86 | 48 ++++++++++++++++++++++++++++++++++ projects/orbot/config | 2 +- projects/release/build | 3 +++ projects/release/config | 11 ++++++++ projects/rust/build | 5 +++- projects/rust/config | 12 ++++++--- projects/tor-browser/config | 2 +- rbm.conf | 15 ++++++++++- 11 files changed, 115 insertions(+), 10 deletions(-)

1 0

[tor-browser/tor-browser-60.5.1esr-8.5-1] Bug 27486 Avoid about:blank tabs when opening onboarding pages.
by gk＠torproject.org 05 Mar '19

05 Mar '19

commit 3a69f6697799d7c6d0ed408df8aa28239b430556 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Feb 13 11:32:13 2019 -0500 Bug 27486 Avoid about:blank tabs when opening onboarding pages. Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion". --- browser/extensions/onboarding/bootstrap.js | 17 +++++++------- .../extensions/onboarding/content/onboarding.js | 26 +++++++++++++--------- 2 files changed, 24 insertions(+), 19 deletions(-) diff --git a/browser/extensions/onboarding/bootstrap.js b/browser/extensions/onboarding/bootstrap.js index 0762249ba1e9..a90bef0faaa2 100644 --- a/browser/extensions/onboarding/bootstrap.js +++ b/browser/extensions/onboarding/bootstrap.js @@ -91,16 +91,17 @@ function setPrefs(prefs) { }); } -function openTorCircuitDisplayPage() { - let kFrameScript = "resource://onboarding/onboarding-tor-circuit-display.js"; - const kOnionURL = "https://3g2upl4pq6kufc4m.onion/"; // DuckDuckGo +function openTorTab(aURL, aFrameScript) { let win = Services.wm.getMostRecentWindow('navigator:browser'); if (win) { let tabBrowser = win.gBrowser; - let tab = tabBrowser.addTab(kOnionURL); + let tab = tabBrowser.addTab(aURL); tabBrowser.selectedTab = tab; - let b = tabBrowser.getBrowserForTab(tab); - b.messageManager.loadFrameScript(kFrameScript, true); + + if (aFrameScript) { + let b = tabBrowser.getBrowserForTab(tab); + b.messageManager.loadFrameScript(aFrameScript, true); + } } } @@ -177,8 +178,8 @@ function initContentMessageListener() { isLoggedIn: syncTourChecker.isLoggedIn() }); break; - case "tor-open-circuit-display-page": - openTorCircuitDisplayPage(); + case "tor-open-tab": + openTorTab(msg.data.params.url, msg.data.params.frameScriptURL); break; #if 0 // No telemetry in Tor Browser. diff --git a/browser/extensions/onboarding/content/onboarding.js b/browser/extensions/onboarding/content/onboarding.js index 9d03a6fc82d8..5cb81852bb73 100644 --- a/browser/extensions/onboarding/content/onboarding.js +++ b/browser/extensions/onboarding/content/onboarding.js @@ -195,12 +195,9 @@ var onboardingTourset = { createOnboardingTourDescription(div, "onboarding.tour-tor-expect-differences.title", "onboarding.tour-tor-expect-differences.description"); createOnboardingTourContent(div, "resource://onboarding/img/figure_tor-expect-differences.png"); - let button = createOnboardingTourButton(div, + createOnboardingTourButton(div, "onboarding-tour-tor-expect-differences-button", - "onboarding.tour-tor-expect-differences.button", "a"); - let anchor = button.querySelector("a"); - anchor.setAttribute("href", "https://support.torproject.org/#faq"); - anchor.setAttribute("target", "_blank"); + "onboarding.tour-tor-expect-differences.button"); return div; }, @@ -214,12 +211,9 @@ var onboardingTourset = { createOnboardingTourDescription(div, "onboarding.tour-tor-onion-services.title", "onboarding.tour-tor-onion-services.description"); createOnboardingTourContent(div, "resource://onboarding/img/figure_tor-onion-services.png"); - let button = createOnboardingTourButton(div, + createOnboardingTourButton(div, "onboarding-tour-tor-onion-services-button", - "onboarding.tour-tor-onion-services.button", "a"); - let anchor = button.querySelector("a"); - anchor.setAttribute("href", "https://3g2upl4pq6kufc4m.onion/"); - anchor.setAttribute("target", "_blank"); + "onboarding.tour-tor-onion-services.button"); return div; }, @@ -836,6 +830,7 @@ class Onboarding { ({ id, classList } = target.firstChild); } + const kOnionURL = "https://3g2upl4pq6kufc4m.onion/"; // DuckDuckGo let handledTourActionClick = false; switch (id) { case "onboarding-overlay-button": @@ -918,7 +913,16 @@ class Onboarding { handledTourActionClick = true; break; case "onboarding-tour-tor-circuit-display-button": - sendMessageToChrome("tor-open-circuit-display-page"); + let kFrameScript = "resource://onboarding/onboarding-tor-circuit-display.js"; + sendMessageToChrome("tor-open-tab", + {url: kOnionURL, frameScriptURL: kFrameScript}); + break; + case "onboarding-tour-tor-expect-differences-button": + const kFAQURL = "https://support.torproject.org/#faq"; + sendMessageToChrome("tor-open-tab", {url: kFAQURL}); + break; + case "onboarding-tour-tor-onion-services-button": + sendMessageToChrome("tor-open-tab", {url: kOnionURL}); break; } if (classList.contains("onboarding-tour-item")) {

1 0

[tor-browser-build/master] Merge remote-tracking branch 'boklm/bug_29194_v2'
by gk＠torproject.org 05 Mar '19

05 Mar '19

commit 799ccf053e78b385fbd2900e092113849d73c94b Merge: e39c1db a4689ee Author: Georg Koppen <gk(a)torproject.org> Date: Tue Mar 5 08:56:37 2019 +0000 Merge remote-tracking branch 'boklm/bug_29194_v2' projects/container-image/config | 5 +++-- projects/debootstrap-image/config | 5 +++-- rbm | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-)

1 0

[tor-browser-build/master] Bug 29194: Set DEBIAN_FRONTEND=noninteractive
by gk＠torproject.org 05 Mar '19

05 Mar '19

commit a4689ee18278443aaf10f72da623efba657a970a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Jan 29 16:17:15 2019 +0100 Bug 29194: Set DEBIAN_FRONTEND=noninteractive Update rbm to set DEBIAN_FRONTEND=noninteractive when using apt-get in install_package. Also set DEBIAN_FRONTEND=noninteractive for the other apt-get commands we use in debootstrap-image and container-image. We now also use the -q (quiet) argument. --- projects/container-image/config | 5 +++-- projects/debootstrap-image/config | 5 +++-- rbm | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/projects/container-image/config b/projects/container-image/config index 95d7557..68c401a 100644 --- a/projects/container-image/config +++ b/projects/container-image/config @@ -17,11 +17,12 @@ pre: | #!/bin/sh # [% c('var/container/suite') %] set -e + export DEBIAN_FRONTEND=noninteractive [% IF pc(c('origin_project'), 'var/pre_pkginst') -%] [% pc(c('origin_project'), 'var/pre_pkginst') %] [% END -%] - apt-get update -y - apt-get upgrade -y + apt-get update -y -q + apt-get upgrade -y -q [% deps = []; IF pc(c('origin_project'), 'var/deps'); diff --git a/projects/debootstrap-image/config b/projects/debootstrap-image/config index ba34032..4dbbfef 100644 --- a/projects/debootstrap-image/config +++ b/projects/debootstrap-image/config @@ -14,10 +14,11 @@ var: pre: | #!/bin/sh set -e + export DEBIAN_FRONTEND=noninteractive # Bug 29158: install fixed packages for apt vulnerability (CVE-2019-3462) dpkg -i ./apt_1.6.6ubuntu0.1_amd64.deb ./libapt-pkg5.0_1.6.6ubuntu0.1_amd64.deb - apt-get update -y - apt-get install -y debian-archive-keyring ubuntu-keyring debootstrap + apt-get update -y -q + apt-get install -y -q debian-archive-keyring ubuntu-keyring debootstrap debootstrap --arch=[% c("var/container/arch") %] [% c("var/container/debootstrap_opt") %] [% c("var/container/suite") %] base-image [% c("var/container/debootstrap_mirror") %] [% IF c("var/apt_package_filename") || c("var/apt_utils_package_filename") || c("var/libapt_inst_package_filename") || c("var/libapt_pkg_package_filename") -%] mkdir ./base-image/apt-update diff --git a/rbm b/rbm index eb500fa..c61e694 160000 --- a/rbm +++ b/rbm @@ -1 +1 @@ -Subproject commit eb500fa9467fb4d7229c9ca87f202ef18603d023 +Subproject commit c61e6940a1824462648064898be0759dd1600414

1 0

[rbm/master] Bug 29194: Set DEBIAN_FRONTEND=noninteractive
by gk＠torproject.org 05 Mar '19

05 Mar '19

commit c61e6940a1824462648064898be0759dd1600414 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Jan 29 16:08:03 2019 +0100 Bug 29194: Set DEBIAN_FRONTEND=noninteractive Set DEBIAN_FRONTEND=noninteractive when using apt-get in install_package. Also use the -q (quiet) argument. --- lib/RBM/DefaultConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/RBM/DefaultConfig.pm b/lib/RBM/DefaultConfig.pm index d758b8e..f8165c3 100644 --- a/lib/RBM/DefaultConfig.pm +++ b/lib/RBM/DefaultConfig.pm @@ -540,7 +540,7 @@ OPT_END my $dnf = 'rpm -q [% c("pkg_name") %] > /dev/null || dnf install -y [% c("pkg_name") %]'; my $zypper = 'rpm -q [% c("pkg_name") %] > /dev/null || zypper install [% c("pkg_name") %]'; my $urpmi = 'rpm -q [% c("pkg_name") %] > /dev/null || urpmi [% c("pkg_name") %]'; - my $apt = 'dpkg -s [% c("pkg_name") %] 2> /dev/null | grep -q "^Status: install ok installed\$" || apt-get install -y [% c("pkg_name") %]'; + my $apt = 'dpkg -s [% c("pkg_name") %] 2> /dev/null | grep -q "^Status: install ok installed\$" || DEBIAN_FRONTEND=noninteractive apt-get install -q -y [% c("pkg_name") %]'; my %install = ( Fedora => $dnf, 'Fedora-20' => $yum,

1 0

[tor-browser-build/master] Bug 29633: Don't ship pdnsd anymore
by boklm＠torproject.org 04 Mar '19

04 Mar '19

commit e39c1dbe69a48274c5e806efc0ef2d407085b255 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Mar 1 19:16:56 2019 +0000 Bug 29633: Don't ship pdnsd anymore We don't use Orbot's VPN mode and therefore don't need pdnsd bundled. Thanks, Nathan, for noticing. --- projects/orbot/build | 6 ------ 1 file changed, 6 deletions(-) diff --git a/projects/orbot/build b/projects/orbot/build index 4e222a9..840df3e 100644 --- a/projects/orbot/build +++ b/projects/orbot/build @@ -20,12 +20,6 @@ for p in $rootdir/*.patch do patch -p1 < $p done -# Build OrbotService Native Libraries -pushd /var/tmp/build/[% project %]-[% c('version') %]/orbotservice/src/main -/var/tmp/dist/android-toolchain/android-ndk/ndk-build -mv libs/armeabi-v7a/pdnsd libs/armeabi-v7a/pdnsd.so -popd - # Build Android Libraries and Apps $GRADLE_HOME/gradle-4.1/bin/gradle --offline assembleRelease -x lint

1 0

[tor-browser/tor-browser-60.5.1esr-8.5-1] Bug 29120: Enable media cache in memory
by gk＠torproject.org 04 Mar '19

04 Mar '19

commit b7c1e2820087e60d019b57d25042a27dc83adc4a Author: Georg Koppen <gk(a)torproject.org> Date: Mon Mar 4 08:38:22 2019 +0000 Bug 29120: Enable media cache in memory Back then in bug 10237 we set `media.cache_size` to `0` in the attempt to block disk caching if we are in Private Browsing Mode. However, it turns out that is not enough to prevent writing to disk in that case and, moreover, is the reason for poor video performance in some cases. The patch in this commit addresses both issues by enabling the media cache again and making sure it stays memory-only in Private Browsing Mode. Big thanks to a cypherpunk for analyzing the bug and providing the patch. --- browser/app/profile/000-tor-browser.js | 3 ++- dom/media/MediaCache.cpp | 45 +++++++++++++++++++++++++++------- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 9f1e727ce724..a0b370c73279 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -60,7 +60,8 @@ pref("signon.rememberSignons", false); pref("browser.formfill.enable", false); pref("signon.autofillForms", false); pref("browser.sessionstore.privacy_level", 2); -pref("media.cache_size", 0); +// Increase the maximum memory-backed cache size (#29120) +pref("media.memory_cache_max_size", 16384); // Misc privacy: Remote pref("browser.send_pings", false); diff --git a/dom/media/MediaCache.cpp b/dom/media/MediaCache.cpp index 38197de3e4a6..056527e7926c 100644 --- a/dom/media/MediaCache.cpp +++ b/dom/media/MediaCache.cpp @@ -154,7 +154,9 @@ class MediaCache { // If the length is known and considered small enough, a discrete MediaCache // with memory backing will be given. Otherwise the one MediaCache with // file backing will be provided. - static RefPtr<MediaCache> GetMediaCache(int64_t aContentLength); + // If aIsPrivateBrowsing is true, only initialization of a memory backed + // MediaCache will be attempted, returning nullptr if that fails. + static RefPtr<MediaCache> GetMediaCache(int64_t aContentLength, bool aIsPrivateBrowsing); nsIEventTarget* OwnerThread() const { return sThread; } @@ -706,7 +708,7 @@ void MediaCache::CloseStreamsForPrivateBrowsing() { } /* static */ RefPtr<MediaCache> MediaCache::GetMediaCache( - int64_t aContentLength) { + int64_t aContentLength, bool aIsPrivateBrowsing) { NS_ASSERTION(NS_IsMainThread(), "Only call on main thread"); if (!sThreadInit) { @@ -734,10 +736,30 @@ void MediaCache::CloseStreamsForPrivateBrowsing() { return nullptr; } - if (aContentLength > 0 && - aContentLength <= int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024) { - // Small-enough resource, use a new memory-backed MediaCache. - RefPtr<MediaBlockCacheBase> bc = new MemoryBlockCache(aContentLength); + if (aIsPrivateBrowsing || + (aContentLength > 0 && + aContentLength <= int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024)) { + // We're either in private browsing mode or we have a + // small-enough resource, use a new memory-backed MediaCache. + + int64_t cacheSize = 0; + if (!aIsPrivateBrowsing) { + cacheSize = aContentLength; + } else { + // We're in private browsing mode, we'll have to figure out a + // cache size since we can't fallback to a file backed MediaCache. + if (aContentLength < 0) { + // Unknown content length, we'll give the maximum allowed + // cache size just to be sure. + cacheSize = int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024; + } else { + // If the content length is less than the maximum allowed cache size, + // use that, otherwise we cap it. + cacheSize = std::min(aContentLength, int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024); + } + } + + RefPtr<MediaBlockCacheBase> bc = new MemoryBlockCache(cacheSize); nsresult rv = bc->Init(); if (NS_SUCCEEDED(rv)) { RefPtr<MediaCache> mc = new MediaCache(bc); @@ -745,8 +767,13 @@ void MediaCache::CloseStreamsForPrivateBrowsing() { mc.get()); return mc; } - // MemoryBlockCache initialization failed, clean up and try for a - // file-backed MediaCache below. + + // MemoryBlockCache initialization failed. + // If we're in private browsing mode, we will bail here. + // Otherwise, clean up and try for a file-backed MediaCache below. + if (aIsPrivateBrowsing) { + return nullptr; + } } if (gMediaCache) { @@ -2600,7 +2627,7 @@ nsresult MediaCacheStream::Init(int64_t aContentLength) { mStreamLength = aContentLength; } - mMediaCache = MediaCache::GetMediaCache(aContentLength); + mMediaCache = MediaCache::GetMediaCache(aContentLength, mIsPrivateBrowsing); if (!mMediaCache) { return NS_ERROR_FAILURE; }

1 0

[tor-browser-build/master] Bug 29632: Use HTTPS for downloading Gradle
by boklm＠torproject.org 03 Mar '19

03 Mar '19

commit 1e09514cd1bfdeba863a84929edfc21ede3f8b9d Author: Georg Koppen <gk(a)torproject.org> Date: Fri Mar 1 19:08:03 2019 +0000 Bug 29632: Use HTTPS for downloading Gradle There should be no excuse anymore to use plan HTTP (even though, we check the SHA-256 sum). Use HTTPS where possible. --- projects/android-toolchain/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/android-toolchain/config b/projects/android-toolchain/config index c14f90e..8a4c413 100644 --- a/projects/android-toolchain/config +++ b/projects/android-toolchain/config @@ -33,6 +33,6 @@ input_files: - URL: '[% c("var/google_repo") %]/android-ndk-r15c-linux-x86_64.zip' name: android_ndk_compiler sha256sum: f01788946733bf6294a36727b99366a18369904eb068a599dde8cca2c1d2ba3c - - URL: http://services.gradle.org/distributions/gradle-4.1-bin.zip + - URL: https://services.gradle.org/distributions/gradle-4.1-bin.zip name: gradle_bin sha256sum: d55dfa9cfb5a3da86a1c9e75bb0b9507f9a8c8c100793ccec7beb6e259f9ed43

1 0

[tor-browser-build/master] Add missing parenthesis
by gk＠torproject.org 01 Mar '19

01 Mar '19

commit 95f303b383fabb0904545a2c5b8150476270e2d0 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Mar 1 07:05:02 2019 +0000 Add missing parenthesis --- projects/firefox/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/firefox/build b/projects/firefox/build index aa0a34f..f3d3c27 100644 --- a/projects/firefox/build +++ b/projects/firefox/build @@ -113,7 +113,7 @@ mv -f $rootdir/[% c('input_files_by_name/mozconfig') %] .mozconfig tar -C /var/tmp/dist/locales -xf $rootdir/[% c('input_files_by_name/firefox-locale-bundle') %] [% END %] -eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %] +eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %]) if [ -z $MOZ_BUILD_DATE ] then echo "MOZ_BUILD_DATE is not set"

1 0

[tor-browser-build/master] Bug 28685: Set Build ID based on Tor Browser version
by gk＠torproject.org 28 Feb '19

28 Feb '19

commit d11f03f7c10c2cf5a942a353d0961249ceee9644 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Wed Feb 20 20:15:19 2019 +0100 Bug 28685: Set Build ID based on Tor Browser version --- projects/firefox/build | 2 +- projects/firefox/get-moz-build-date | 26 +++++++++++++++++--------- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/projects/firefox/build b/projects/firefox/build index 1544c11..aa0a34f 100644 --- a/projects/firefox/build +++ b/projects/firefox/build @@ -113,7 +113,7 @@ mv -f $rootdir/[% c('input_files_by_name/mozconfig') %] .mozconfig tar -C /var/tmp/dist/locales -xf $rootdir/[% c('input_files_by_name/firefox-locale-bundle') %] [% END %] -eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] $(cat browser/config/version.txt)) +eval $(perl $rootdir/get-moz-build-date [% c("var/copyright_year") %] [% c("var/torbrowser_version") %] if [ -z $MOZ_BUILD_DATE ] then echo "MOZ_BUILD_DATE is not set" diff --git a/projects/firefox/get-moz-build-date b/projects/firefox/get-moz-build-date index fb7298a..4e55c92 100755 --- a/projects/firefox/get-moz-build-date +++ b/projects/firefox/get-moz-build-date @@ -1,16 +1,24 @@ #!/usr/bin/perl -w -# Generate a MOZ_BUILD_DATE based on firefox version number +# Generate a MOZ_BUILD_DATE based on Tor Browser version number use strict; die "wrong number of arguments" unless @ARGV == 2; my ($year, $version) = @ARGV; -$version =~ s/\D+$//; -my @v = split(/[\.ab]/, $version); -push @v, '0' if @v < 4; -push @v, '0' if @v < 4; -my $day_of_month = int(($v[0] - 45) / 5); -my $date = 101010101 + $year * 10000000000 + $day_of_month * 1000000 - + $v[1] * 10000 + $v[2] * 100 + $v[3]; -$date += 100000000 unless $version =~ m/[ab]/; +my $date; +if ($version eq 'tbb-nightly') { + my (undef, undef, undef, $day, $mon, $y) = localtime; + $date = sprintf("%d%02d%02d010101", $y + 1900, $mon + 1, $day); +} else { + my @v = split(/[\.ab]/, $version); + push @v, '0' if @v < 4; + push @v, '0' if @v < 4; + # When MOZ_BUILD_DATE was based on the firefox version, with + # Tor Browser 8.0.6 and firefox 60.5.1 it was 20190204060201 + # We can remove 5 from the month, while keeping it increasing. + my $month = $v[0] - 5; + $date = 1010101 + $year * 10000000000 + $month * 100000000 + + $v[1] * 1000000 + $v[2] * 10000 + $v[3]; + $date += 1000000 unless $version =~ m/[ab]/; +} print "export MOZ_BUILD_DATE=$date\n";

1 0