- tbb-commits - lists.torproject.org

[tor-browser/tor-browser-60.5.0esr-8.5-1] Bug 29180: MAR download stalls when about dialog is opened
by gk＠torproject.org 05 Feb '19

05 Feb '19

commit ffda294141584fdf69257e2a04fbcc7d4705ca3f Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Thu Jan 31 10:01:14 2019 -0500 Bug 29180: MAR download stalls when about dialog is opened Avoid stopping and restarting the download when the about dialog or update dialog is opened. This avoids a race between canceling the MAR download and trying to start a new download. --- browser/base/content/aboutDialog-appUpdater.js | 17 +++++++++++----- toolkit/mozapps/update/content/updates.js | 27 ++++++++++++++------------ 2 files changed, 27 insertions(+), 17 deletions(-) diff --git a/browser/base/content/aboutDialog-appUpdater.js b/browser/base/content/aboutDialog-appUpdater.js index e81098a1e898..b732db6bee6b 100644 --- a/browser/base/content/aboutDialog-appUpdater.js +++ b/browser/base/content/aboutDialog-appUpdater.js @@ -318,11 +318,18 @@ appUpdater.prototype = this.update.QueryInterface(Ci.nsIWritablePropertyBag); this.update.setProperty("foregroundDownload", "true"); - this.aus.pauseDownload(); - let state = this.aus.downloadUpdate(this.update, false); - if (state == "failed") { - this.selectPanel("downloadFailed"); - return; + // If one is not already in progress, start a download. Previously, + // we would pause and restart an existing download in case there was + // a need to transition from a background download to a foreground one, + // but that caused Tor bug 29180. There is no difference between a + // foreground and background download unless the update manifest + // includes a backgroundInterval attribute. + if (!this.isDownloading) { + let state = this.aus.downloadUpdate(this.update, false); + if (state == "failed") { + this.selectPanel("downloadFailed"); + return; + } } this.setupDownloadingUI(); diff --git a/toolkit/mozapps/update/content/updates.js b/toolkit/mozapps/update/content/updates.js index 5b6ae7cc6ba1..195265ff81f9 100644 --- a/toolkit/mozapps/update/content/updates.js +++ b/toolkit/mozapps/update/content/updates.js @@ -751,19 +751,22 @@ var gDownloadingPage = { gUpdates.update.QueryInterface(Ci.nsIWritablePropertyBag); gUpdates.update.setProperty("foregroundDownload", "true"); - // Pause any active background download and restart it as a foreground - // download. - aus.pauseDownload(); - var state = aus.downloadUpdate(gUpdates.update, false); - if (state == "failed") { - // We've tried as hard as we could to download a valid update - - // we fell back from a partial patch to a complete patch and even - // then we couldn't validate. Show a validation error with instructions - // on how to manually update. - this.cleanUp(); - gUpdates.wiz.goTo("errors"); - return; + // If it is not already in progress, start the download. See + // Tor bug 29180 as well as the longer comment in the startDownload() + // function within browser/base/content/aboutDialog-appUpdater.js. + if (!aus.isDownloading) { + var state = aus.downloadUpdate(gUpdates.update, false); + if (state == "failed") { + // We've tried as hard as we could to download a valid update - + // we fell back from a partial patch to a complete patch and even + // then we couldn't validate. Show a validation error with + // instructions on how to manually update. + this.cleanUp(); + gUpdates.wiz.goTo("errors"); + return; + } } + // Add this UI as a listener for active downloads aus.addDownloadListener(this);

1 0

[tor-browser/tor-browser-60.5.0esr-8.5-1] fixup! Bug 23247: Communicating security expectations for .onion
by gk＠torproject.org 04 Feb '19

04 Feb '19

commit 71eb1c774844d5662184914f4defd76110fe0ef7 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Feb 4 09:09:10 2019 +0000 fixup! Bug 23247: Communicating security expectations for .onion This commit fixes #29327. --- browser/base/content/pageinfo/security.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/browser/base/content/pageinfo/security.js b/browser/base/content/pageinfo/security.js index 5a827488ccad..ef12ddb0099f 100644 --- a/browser/base/content/pageinfo/security.js +++ b/browser/base/content/pageinfo/security.js @@ -52,7 +52,10 @@ var security = { (ui.state & Ci.nsIWebProgressListener.STATE_IS_INSECURE); var isEV = (ui.state & Ci.nsIWebProgressListener.STATE_IDENTITY_EV_TOPLEVEL); - var isOnion = hostName.endsWith(".onion"); + var isOnion = false; + if (hostName && hostName.endsWith(".onion")) { + isOnion = true; + } ui.QueryInterface(nsISSLStatusProvider); var status = ui.SSLStatus;

1 0

[tor-browser-build/master] Bug 29235: Build our own version of python3.6
by gk＠torproject.org 01 Feb '19

01 Feb '19

commit 66a0ab022c3c539a3756771cf72e793fa2e861e7 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Wed Jan 30 20:54:51 2019 +0100 Bug 29235: Build our own version of python3.6 The build of HTTPS-Everywhere requires python3.6, however the python3.6 package which we were using has now been removed from Debian Unstable. We now build python 3.6 ourselves. As the different platforms use a different suite by default, we add the common-stretch target to rbm.conf, which we use to avoid building a different python for each platform. --- keyring/python.gpg | Bin 0 -> 4302 bytes projects/debootstrap-image/config | 7 ------- projects/https-everywhere/build | 1 + projects/https-everywhere/config | 9 ++++++--- projects/python/build | 14 ++++++++++++++ projects/python/config | 25 +++++++++++++++++++++++++ rbm.conf | 17 +++++++++++++++++ 7 files changed, 63 insertions(+), 10 deletions(-) diff --git a/keyring/python.gpg b/keyring/python.gpg new file mode 100644 index 0000000..66711fd Binary files /dev/null and b/keyring/python.gpg differ diff --git a/projects/debootstrap-image/config b/projects/debootstrap-image/config index c916e9f..7e8b280 100644 --- a/projects/debootstrap-image/config +++ b/projects/debootstrap-image/config @@ -100,13 +100,6 @@ targets: suite: jessie arch: i386 - buster-amd64: - var: - minimal_apt_version: '1.8.0~alpha3.1' - container: - suite: buster - arch: amd64 - stretch-amd64: var: minimal_apt_version: 1.4.9 diff --git a/projects/https-everywhere/build b/projects/https-everywhere/build index 10dd4bf..88431e0 100644 --- a/projects/https-everywhere/build +++ b/projects/https-everywhere/build @@ -1,5 +1,6 @@ #!/bin/bash [% c("var/set_default_env") -%] +[% pc('python', 'var/setup', { python_tarfile => c('input_files_by_name/python') }) %] tar xf [% project %]-[% c('version') %].tar.gz cd [% project %]-[% c('version') %] ./make.sh diff --git a/projects/https-everywhere/config b/projects/https-everywhere/config index 59eb463..1be120b 100644 --- a/projects/https-everywhere/config +++ b/projects/https-everywhere/config @@ -10,18 +10,17 @@ var: # HTTPS Everywhere is expected to be the same on all platforms. To avoid # building the same thing 4 times, using 4 different container images # (each one with a different suite or architecture), we set the container - # to buster/amd64 for all platforms. This allows us to create only one + # to stretch/amd64 for all platforms. This allows us to create only one # container image, and also build the extension only one time as the # filename does not contain the platform, and var/build_id should be # the same since there is now nothing platform specific in the build # inputs. This allows us to save a little time and disk space. container: use_container: 1 - suite: buster + suite: stretch arch: amd64 deps: - git - - python3.6 - libxslt1.1 - libxml2-utils - sqlite3 @@ -31,3 +30,7 @@ var: input_files: - project: container-image + - project: python + name: python + target: + - common-stretch diff --git a/projects/python/build b/projects/python/build new file mode 100644 index 0000000..1fff7ce --- /dev/null +++ b/projects/python/build @@ -0,0 +1,14 @@ +#!/bin/bash +[% c("var/set_default_env") -%] +distdir=/var/tmp/dist/[% project %] +mkdir -p $distdir +tar xf [% c('input_files_by_name/python') %] +cd Python-[% c('version') %] +./configure --prefix=$distdir +make -j[% c("buildconf/num_procs") %] +make prefix=$distdir install +cd /var/tmp/dist +[% c('tar', { + tar_src => 'python', + tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), + }) %] diff --git a/projects/python/config b/projects/python/config new file mode 100644 index 0000000..10c79cc --- /dev/null +++ b/projects/python/config @@ -0,0 +1,25 @@ +# vim: filetype=yaml sw=2 +version: 3.6.8 +filename: 'python-[% c("lsb_release/id") %]-[% c("lsb_release/release") %]-[% c("var/build_id") %].tar.gz' +var: + container: + use_container: 1 + deps: + - xz-utils + - build-essential + - python-all + - zlib1g-dev + - libssl-dev + + setup: | + mkdir -p /var/tmp/dist + tar -C /var/tmp/dist -xf $rootdir/[% c("python_tarfile") %] + export PATH=/var/tmp/dist/python/bin:"$PATH" + +input_files: + - project: container-image + - name: python + URL: 'https://www.python.org/ftp/python/[% c("version") %]/Python-[% c("version") %].tar.xz' + gpg_keyring: python.gpg + sig_ext: asc + file_gpg_id: 1 diff --git a/rbm.conf b/rbm.conf index 810eae8..381eab6 100644 --- a/rbm.conf +++ b/rbm.conf @@ -140,6 +140,23 @@ targets: # Don't create mar files to save time build_mar: 0 + # The common-stretch target is used to build components that are common to all + # platforms, using Debian stretch. + common-stretch: + var: + common: 1 + container: + suite: stretch + arch: amd64 + deps: + - build-essential + - python + - bison + - automake + - libtool + - zip + - unzip + torbrowser-android-armv7: - android-armv7 android-armv7:

1 0

[torbutton/master] Bug 29239: Don't ship the Torbutton .xpi on mobile
by gk＠torproject.org 31 Jan '19

31 Jan '19

commit 70035640b586301baa4eebff868460c1e939b8e3 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Jan 31 12:42:50 2019 +0000 Bug 29239: Don't ship the Torbutton .xpi on mobile We include Torbutton directly into the browser on Android. The features .xpi we bundle is not used. Patch idea by sysrqb(a)torproject.org. --- moz.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/moz.build b/moz.build index 5e067c98..28f592f8 100644 --- a/moz.build +++ b/moz.build @@ -7,6 +7,3 @@ JAR_MANIFESTS += ['src/jar.mn'] JS_PREFERENCE_FILES += [ 'src/defaults/preferences/preferences.js', ] -FINAL_TARGET_FILES.features['torbutton(a)torproject.org'] += [ - 'src/install.rdf' -]

1 0

[tor-browser-build/master] Merge remote-tracking branch 'boklm/bug_29181_v2'
by gk＠torproject.org 30 Jan '19

30 Jan '19

commit 929c3f8d6fe4d6182d4dfce2472581ccc45824f0 Merge: 9bac5b8 592aced Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jan 30 19:51:34 2019 +0000 Merge remote-tracking branch 'boklm/bug_29181_v2' projects/debootstrap-image/config | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

1 0

[tor-browser-build/master] Bug 29181: Add a version number in debootstrap-image filename
by gk＠torproject.org 30 Jan '19

30 Jan '19

commit 592acedeb13ec0d08087b4cd2fb414b04431fb13 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri Jan 25 17:37:43 2019 +0100 Bug 29181: Add a version number in debootstrap-image filename Updating this version number will cause the old images created by debootstrap-image to be discarded when a new image is built by container-image. However existing images from container-image will not be discarded as container-image's filename doesn't depend on debootstrap-image's filename. --- projects/debootstrap-image/config | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/projects/debootstrap-image/config b/projects/debootstrap-image/config index a1d26cb..c916e9f 100644 --- a/projects/debootstrap-image/config +++ b/projects/debootstrap-image/config @@ -1,5 +1,6 @@ # vim: filetype=yaml sw=2 -filename: 'container-image_[% c("var/container/suite") %]-[% c("var/container/arch") %].tar.gz' +filename: 'container-image_[% c("var/container/suite") %]-[% c("var/container/arch") %]-[% c("version") %].tar.gz' +version: 1 pkg_type: build var:

1 0

[tor-browser-build/master] Bug 29167: Upgrade go to 1.11.5.
by gk＠torproject.org 30 Jan '19

30 Jan '19

commit 9bac5b8ddc129cc0349f1c6350f819f8ba29af94 Author: David Fifield <david(a)bamsoftware.com> Date: Thu Jan 24 21:00:34 2019 +0000 Bug 29167: Upgrade go to 1.11.5. --- projects/go/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/go/config b/projects/go/config index 1841705..be9f84d 100644 --- a/projects/go/config +++ b/projects/go/config @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 1.11.1 +version: 1.11.5 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz' var: @@ -84,7 +84,7 @@ input_files: enable: '[% c("var/windows") || c("var/osx") %]' - URL: 'https://golang.org/dl/go[% c("version") %].src.tar.gz' name: go - sha256sum: 558f8c169ae215e25b81421596e8de7572bd3ba824b79add22fba6e284db1117 + sha256sum: bc1ef02bb1668835db1390a2e478dcbccb5dd16911691af9d75184bbe5aa943e - URL: 'https://golang.org/dl/go[% c("var/go14_version") %].src.tar.gz' name: go14 sha256sum: 9947fc705b0b841b5938c48b22dc33e9647ec0752bae66e50278df4f23f64959

1 0

[tor-browser-build/master] Bug 29193: Update goxnet commit in nightly
by gk＠torproject.org 29 Jan '19

29 Jan '19

commit 23f8101525288ccdd6ccef2035a698c4e9f1b232 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Jan 29 15:26:50 2019 +0100 Bug 29193: Update goxnet commit in nightly --- projects/goxnet/config | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/projects/goxnet/config b/projects/goxnet/config index f33cb32..6aa5a0e 100644 --- a/projects/goxnet/config +++ b/projects/goxnet/config @@ -13,6 +13,12 @@ var: go_lib_install: - golang.org/x/net/proxy +targets: + nightly: + # Nightly version of obfs4 requires a more recent version of goxnet + # See bug 29193 + git_hash: ed066c81e75eba56dd9bd2139ade88125b855585 + input_files: - project: container-image - name: go

1 0

[tor-browser-build/master] Bug 29178: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc
by gk＠torproject.org 28 Jan '19

28 Jan '19

commit 5bad67e4f31d984702c530cbd423d83d009e699a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Jan 28 12:11:24 2019 +0100 Bug 29178: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc --- projects/go-webrtc/config | 2 -- projects/goxcrypto/config | 4 ---- projects/goxnet/config | 4 ---- projects/uniuri/config | 4 ---- 4 files changed, 14 deletions(-) diff --git a/projects/go-webrtc/config b/projects/go-webrtc/config index 8b171f9..8136122 100644 --- a/projects/go-webrtc/config +++ b/projects/go-webrtc/config @@ -35,8 +35,6 @@ var: [% END -%] targets: - master: - git_hash: master linux: var: arch_deps: diff --git a/projects/goxcrypto/config b/projects/goxcrypto/config index fe73f93..698f94b 100644 --- a/projects/goxcrypto/config +++ b/projects/goxcrypto/config @@ -19,10 +19,6 @@ var: go_lib_deps: - goxsys -targets: - nightly: - git_hash: master - input_files: - project: container-image - name: go diff --git a/projects/goxnet/config b/projects/goxnet/config index ec368a2..f33cb32 100644 --- a/projects/goxnet/config +++ b/projects/goxnet/config @@ -13,10 +13,6 @@ var: go_lib_install: - golang.org/x/net/proxy -targets: - nightly: - git_hash: master - input_files: - project: container-image - name: go diff --git a/projects/uniuri/config b/projects/uniuri/config index e4c7294..5eea6e2 100644 --- a/projects/uniuri/config +++ b/projects/uniuri/config @@ -11,10 +11,6 @@ var: use_container: 1 go_lib: github.com/dchest/uniuri -targets: - nightly: - git_hash: master - input_files: - project: container-image - name: go

1 0

[tor-browser-build/master] Tagging build4 to fix Windows reproducibility issues
by gk＠torproject.org 28 Jan '19

28 Jan '19

commit c027caa95d205ec3761215e8b671c999866435b1 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Jan 28 09:33:24 2019 +0000 Tagging build4 to fix Windows reproducibility issues --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 1 - rbm.conf | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index c0e2a38..5a9feb7 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -24,7 +24,6 @@ Tor Browser 8.5a7 -- January 29 2019 * Bug 22654: Firefox icon is shown for Tor Browser on Windows 10 start menu * Bug 27503: Compile with accessibility support * Bug 28874: Bump mingw-w64 commit to fix WebGL crash - * Bug 28546: Rebrand Tor Browser's Window's Installer * Bug 12885: Windows Jump Lists fail for Tor Browser * Bug 28618: Set MOZILLA_OFFICIAL for Windows build * OS X diff --git a/rbm.conf b/rbm.conf index 74d922b..810eae8 100644 --- a/rbm.conf +++ b/rbm.conf @@ -16,7 +16,7 @@ buildconf: var: torbrowser_version: '8.5a7' - torbrowser_build: 'build3' + torbrowser_build: 'build4' torbrowser_incremental_from: - 8.5a6 project_name: tor-browser

1 0