- tbb-commits - lists.torproject.org

[tor-browser-build/master] Bug 25876: Generate source tarballs during build
by gk＠torproject.org 12 Mar '19

12 Mar '19

commit 1b79a12ecc1b918c379c29b58954d2680672e201 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Wed Apr 25 15:10:30 2018 +0200 Bug 25876: Generate source tarballs during build We now generate source tarballs for firefox, torbutton and tor-launcher during stable, alpha and nightly builds. We don't generate them with |make testbuild|, but they can be generated with |make testbuild-src|. --- Makefile | 15 +++++++++++++++ README.MAKEFILE | 11 ++++++++--- projects/firefox/config | 12 ++++++++++++ projects/release/build | 6 ++++++ projects/release/config | 32 ++++++++++++++++++++++++++++++++ projects/tor-launcher/config | 8 ++++++++ projects/torbutton/config | 8 ++++++++ rbm.conf | 9 +++++++++ 8 files changed, 98 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index d419422..285b49d 100644 --- a/Makefile +++ b/Makefile @@ -29,6 +29,9 @@ release-windows-x86_64: submodule-update release-osx-x86_64: submodule-update $(rbm) build release --target release --target torbrowser-osx-x86_64 +release-src: submodule-update + $(rbm) build release --target release --target torbrowser-src + alpha: submodule-update $(rbm) build release --target alpha --target torbrowser-all @@ -56,6 +59,9 @@ alpha-windows-x86_64: submodule-update alpha-osx-x86_64: submodule-update $(rbm) build release --target alpha --target torbrowser-osx-x86_64 +alpha-src: submodule-update + $(rbm) build release --target alpha --target torbrowser-src + nightly: submodule-update $(rbm) build release --target nightly --target torbrowser-all @@ -83,6 +89,9 @@ nightly-windows-x86_64: submodule-update nightly-osx-x86_64: submodule-update $(rbm) build release --target nightly --target torbrowser-osx-x86_64 +nightly-src: submodule-update + $(rbm) build release --target nightly --target torbrowser-src + alpha_nightly: submodule-update $(rbm) build release --target alpha_nightly --target torbrowser-all @@ -107,6 +116,9 @@ alpha_nightly-windows-x86_64: submodule-update alpha_nightly-osx-x86_64: submodule-update $(rbm) build release --target alpha_nightly --target torbrowser-osx-x86_64 +alpha_nightly-src: submodule-update + $(rbm) build release --target alpha_nightly --target torbrowser-src + testbuild: submodule-update $(rbm) build release --target testbuild --target torbrowser-all @@ -134,6 +146,9 @@ testbuild-windows-i686: submodule-update testbuild-osx-x86_64: submodule-update $(rbm) build release --target testbuild --target torbrowser-osx-x86_64 +testbuild-src: submodule-update + $(rbm) build release --target testbuild --target torbrowser-src-testbuild + signtag-release: submodule-update $(rbm) build release --step signtag --target release diff --git a/README.MAKEFILE b/README.MAKEFILE index 1514780..7351c5f 100644 --- a/README.MAKEFILE +++ b/README.MAKEFILE @@ -46,14 +46,19 @@ The same as alpha_nightly, for the selected platform only. testbuild --------- Build a Tor Browser test build. To make the build faster, only the en-US -locale is created, without mar files. By default it is based on the -alpha channel, but you can change that by editing rbm.local.conf. -The resulting build can be found in directory testbuild. +locale is created, without mar files, and without the source tarballs. +By default it is based on the alpha channel, but you can change that by +editing rbm.local.conf. The resulting build can be found in directory +testbuild. {release,alpha,nightly,testbuild}-linux-x86_64-debug ---------------------------------------------------- Create a debug build for Linux x86_64 with debug features such as ASan. +{release,alpha,nightly,testbuild}-src +------------------------------------- +Create source tarballs for firefox, torbutton and tor-launcher. + fetch ----- Fetch new commits from all components. This is useful when you want to diff --git a/projects/firefox/config b/projects/firefox/config index 4d68969..2f40fe2 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -28,6 +28,18 @@ var: # used by projects/firefox-locale-bundle l10n-changesets.json: '[% exec("cat mobile/locales/l10n-changesets.json") %]' +steps: + src-tarballs: + filename: 'src-[% project %]-[% c("version") %].tar.xz' + version: '[% c("git_hash") %]' + input_files: [] + var: + container: + use_container: 0 + targets: + nightly: + version: '[% c("abbrev") %]' + targets: release: var: diff --git a/projects/release/build b/projects/release/build index ca7b26d..af9d673 100644 --- a/projects/release/build +++ b/projects/release/build @@ -27,6 +27,12 @@ mkdir -p "$destdir" [% IF c("var/torbrowser-linux-x86_64") -%] mv [% c('input_files_by_name/linux-x86_64') %]/* "$destdir"/ [% END -%] +[% IF c("var/torbrowser-src") -%] + mv [% c('input_files_by_name/src-firefox') %] \ + [% c('input_files_by_name/src-torbutton') %] \ + [% c('input_files_by_name/src-tor-launcher') %] \ + "$destdir"/ +[% END -%] cd "$destdir" cat > .htaccess <<EOF RewriteEngine On diff --git a/projects/release/config b/projects/release/config index 1a742ac..52a416a 100644 --- a/projects/release/config +++ b/projects/release/config @@ -16,6 +16,7 @@ targets: - torbrowser-osx-x86_64 - torbrowser-android-armv7 - torbrowser-android-x86 + - torbrowser-src torbrowser-android-armv7: var: torbrowser-android-armv7: 1 @@ -41,6 +42,12 @@ targets: torbrowser-osx-x86_64: var: torbrowser-osx-x86_64: 1 + torbrowser-src: + var: + torbrowser-src: '[% ! c("var/testbuild") %]' + torbrowser-src-testbuild: + var: + torbrowser-src: 1 notarget: - release @@ -74,6 +81,7 @@ targets: testbuild: output_dir: 'testbuild' var: + testbuild: 1 build_target: torbrowser-testbuild publish_dir: '' @@ -153,6 +161,30 @@ input_files: - torbrowser-windows-x86_64 - expert-bundle + - name: src-firefox + project: firefox + enable: '[% c("var/torbrowser-src") %]' + pkg_type: src-tarballs + target: + - '[% c("var/build_target") %]' + - torbrowser-src + + - name: src-torbutton + project: torbutton + enable: '[% c("var/torbrowser-src") %]' + pkg_type: src-tarballs + target: + - '[% c("var/build_target") %]' + - torbrowser-src + + - name: src-tor-launcher + project: tor-launcher + enable: '[% c("var/torbrowser-src") %]' + pkg_type: src-tarballs + target: + - '[% c("var/build_target") %]' + - torbrowser-src + steps: signtag: build_log: '-' diff --git a/projects/tor-launcher/config b/projects/tor-launcher/config index 4f2d2b7..8087727 100644 --- a/projects/tor-launcher/config +++ b/projects/tor-launcher/config @@ -11,6 +11,14 @@ var: input_files: - project: container-image +steps: + src-tarballs: + filename: 'src-[% project %]-[% c("version") %].tar.xz' + input_files: [] + var: + container: + use_container: 0 + targets: nightly: version: '[% c("abbrev") %]' diff --git a/projects/torbutton/config b/projects/torbutton/config index 5d42fc5..369d7e4 100644 --- a/projects/torbutton/config +++ b/projects/torbutton/config @@ -11,6 +11,14 @@ var: input_files: - project: container-image +steps: + src-tarballs: + filename: 'src-[% project %]-[% c("version") %].tar.xz' + input_files: [] + var: + container: + use_container: 0 + targets: nightly: version: '[% c("abbrev") %]' diff --git a/rbm.conf b/rbm.conf index 1b82e60..df31741 100644 --- a/rbm.conf +++ b/rbm.conf @@ -7,6 +7,15 @@ build_log: '[% GET ENV.RBM_LOGS_DIR ? ENV.RBM_LOGS_DIR : "logs" %]/[% project %] pkg_type: build +steps: + src-tarballs: + compress_tar: xz + src-tarballs: | + #!/bin/bash + set -e + mkdir -p '[% dest_dir %]' + mv -vf '[% project %]-[% c("version") %].tar.xz' '[% dest_dir %]/[% c("filename") %]' + # buildconf contains build options that the user can change in rbm.local.conf # When adding a new option to buildconf, a default value should be defined # in var/build_id, so that changing this option does not affect the build_id.

1 0

[tor-browser-build/master] Merge remote-tracking branch 'boklm/bug_25876_v9'
by gk＠torproject.org 12 Mar '19

12 Mar '19

commit f44c5d73cfe8d47a6394939e9c237cfbd45a0c5f Merge: 93a114b 1b79a12 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Mar 12 14:05:21 2019 +0000 Merge remote-tracking branch 'boklm/bug_25876_v9' Makefile | 15 +++++++++++++++ README.MAKEFILE | 11 ++++++++--- projects/firefox/config | 12 ++++++++++++ projects/release/build | 6 ++++++ projects/release/config | 32 ++++++++++++++++++++++++++++++++ projects/tor-launcher/config | 8 ++++++++ projects/torbutton/config | 8 ++++++++ rbm.conf | 9 +++++++++ 8 files changed, 98 insertions(+), 3 deletions(-)

1 0

[tor-browser-build/master] Update testsuite_git_commit for bug 29667 and bug 29675
by boklm＠torproject.org 11 Mar '19

11 Mar '19

commit 93a114bcb49f72c7131344cc67e47ce90bd81c77 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Mar 11 18:42:30 2019 +0100 Update testsuite_git_commit for bug 29667 and bug 29675 --- tools/ansible/roles/tbb-nightly-build/defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ansible/roles/tbb-nightly-build/defaults/main.yml b/tools/ansible/roles/tbb-nightly-build/defaults/main.yml index 26820a9..2a4cc6e 100644 --- a/tools/ansible/roles/tbb-nightly-build/defaults/main.yml +++ b/tools/ansible/roles/tbb-nightly-build/defaults/main.yml @@ -5,7 +5,7 @@ nightly_build_cron_minute: 20 nightly_build_keep_builds: 2 testsuite_dir: "/home/{{ nightly_build_user }}/tbb-testsuite" testsuite_git_url: https://git.torproject.org/user/boklm/tor-browser-bundle-testsuite.git -testsuite_git_commit: 7b1e23e06761c7336795d2b2a6fa40f5914b0aef +testsuite_git_commit: 9283635ace22c3a7f629b5bc60e8fec0af4dc13c nightly_build_wwwdir: "/home/{{ nightly_build_user }}/www" nightly_build_nginx_enable: true nightly_build_nginx_listen: 127.0.0.1:80

1 0

[tor-browser-build/master] Pick up fix for bug 29572
by gk＠torproject.org 11 Mar '19

11 Mar '19

commit 5a4f0853b634daa93e099ad613257f069635bb93 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Mar 11 10:53:59 2019 +0000 Pick up fix for bug 29572 --- rbm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rbm b/rbm index c61e694..70d1ff3 160000 --- a/rbm +++ b/rbm @@ -1 +1 @@ -Subproject commit c61e6940a1824462648064898be0759dd1600414 +Subproject commit 70d1ff3e7c1c5c69a1b4cdb61ee1b6b9e2a9bc4a

1 0

[rbm/master] Bug 29572: Update the test before running git checkout --detach
by gk＠torproject.org 11 Mar '19

11 Mar '19

commit 70d1ff3e7c1c5c69a1b4cdb61ee1b6b9e2a9bc4a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Mar 11 11:26:48 2019 +0100 Bug 29572: Update the test before running git checkout --detach The reason we don't run |git checkout --detach| in all cases is that it fails when we cloned a repository without a master branch. To avoid running it in this case, we were checking if HEAD is pointing to a branch which has a corresponding file in the .git directory. However it seems there are other cases where HEAD is pointing to a branch which does not have a corresponding file in the .git directory. Instead we now check that |git rev-parse --verify HEAD| does not return an error, in which case we assume that |git checkout --detach| will not produce an error too. --- lib/RBM.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/RBM.pm b/lib/RBM.pm index 3ef20ae..1400700 100644 --- a/lib/RBM.pm +++ b/lib/RBM.pm @@ -397,9 +397,8 @@ sub git_clone_fetch_chdir { if (git_need_fetch($project, $options)) { system('git', 'remote', 'set-url', 'origin', $git_url) == 0 || exit_error "Error setting git remote"; - my ($ref, undef, $success) = capture_exec('git', 'symbolic-ref', 'HEAD'); - chomp $ref; - if ($success && -e ".git/$ref") { + my (undef, undef, $success) = capture_exec('git', 'rev-parse', '--verify', 'HEAD'); + if ($success) { system('git', 'checkout', '-q', '--detach') == 0 || exit_error "Error running git checkout --detach"; }

1 0

[tor-launcher/master] Bug 22402: Improve "For assistance" link.
by gk＠torproject.org 07 Mar '19

07 Mar '19

commit e4c4622a8e443a36480dacae3eee18d55a55a7ac Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Thu Mar 7 09:34:00 2019 -0500 Bug 22402: Improve "For assistance" link. Instead of pointing users to the Tor Project contact page, point them to support.torproject.org/#connectingtotor. --- src/chrome/content/network-settings.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/chrome/content/network-settings.js b/src/chrome/content/network-settings.js index 1599c28..ef7571e 100644 --- a/src/chrome/content/network-settings.js +++ b/src/chrome/content/network-settings.js @@ -1,4 +1,4 @@ -// Copyright (c) 2018, The Tor Project, Inc. +// Copyright (c) 2019, The Tor Project, Inc. // See LICENSE for licensing information. // // vim: set sw=2 sts=2 ts=8 et syntax=javascript: @@ -35,9 +35,7 @@ const kPrefBridgeDBType = "extensions.torlauncher.bridgedb_bridge_type"; // extensions.torlauncher.bridgedb_bridge.1, and so on. const kPrefBranchBridgeDBBridge = "extensions.torlauncher.bridgedb_bridge."; -// As of April 2016, no one is responding to help desk email. Hopefully this will change soon. -//const kSupportAddr = "help(a)rt.torproject.org"; -const kSupportURL = "torproject.org/about/contact.html#support"; +const kSupportURL = "support.torproject.org/#connectingtotor"; const kTorProcessReadyTopic = "TorProcessIsReady"; const kTorProcessExitedTopic = "TorProcessExited";

1 0

[tor-browser-build/master] Fold in stable Changelog
by gk＠torproject.org 06 Mar '19

06 Mar '19

commit f160a7e0c63758e6e90ba3ece59c7130a603f2e0 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Mar 6 07:41:09 2019 +0000 Fold in stable Changelog --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 83d0f4b..a68ff69 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -11,6 +11,15 @@ Tor Browser 8.5a8 -- February 13 2019 * Linux * Bug 29183: Use linux-x86_64 langpacks on linux-x86_64 +Tor Browser 8.0.6 -- February 12 2019 + * All platforms + * Update Firefox to 60.5.1esr + * Update HTTPS Everywhere to 2019.1.31 + * Bug 29378: Remove 83.212.101.3 from default bridges + * Build System + * All Platforms + * Bug 29235: Build our own version of python3.6 for HTTPS Everywhere + Tor Browser 8.5a7 -- January 29 2019 * All Platforms * Update Firefox to 60.5.0esr

1 0

[tor-browser-build/maint-8.0] Bump tor version to 0.3.5.8
by gk＠torproject.org 06 Mar '19

06 Mar '19

commit fbd366f2f0a0b1b58642cf5f860d98ba768ebe78 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Mar 6 07:32:59 2019 +0000 Bump tor version to 0.3.5.8 Fixes #29660 and similar bugs where tor mishandled empty SOCKS auth. See #29175 for more details. --- projects/tor/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/tor/config b/projects/tor/config index f5e2515..9301818 100644 --- a/projects/tor/config +++ b/projects/tor/config @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -version: 0.3.5.7 +version: 0.3.5.8 git_hash: 'tor-[% c("version") %]' git_url: https://git.torproject.org/tor.git git_submodule: 1

1 0

[tor-browser-build/master] Bump tor version to 0.4.0.2-alpha
by gk＠torproject.org 06 Mar '19

06 Mar '19

commit 864a167a1cdef48560b52c5f3ba559f343eddae0 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Mar 6 07:30:53 2019 +0000 Bump tor version to 0.4.0.2-alpha Fixes #29660 and similar bugs where tor mishandled empty SOCKS auth. See #29175 for more details. --- projects/tor/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/tor/config b/projects/tor/config index af90885..ffdb200 100644 --- a/projects/tor/config +++ b/projects/tor/config @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -version: 0.4.0.1-alpha +version: 0.4.0.2-alpha git_hash: 'tor-[% c("version") %]' git_url: https://git.torproject.org/tor.git git_submodule: 1

1 0

[tor-browser/tor-browser-60.5.1esr-8.5-1] Bug 29445: Enable support for enterprise policies
by gk＠torproject.org 06 Mar '19

06 Mar '19

commit 7ce43156780e3b91f35481cce1eb4afed56a4b0f Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue Mar 5 13:58:52 2019 -0500 Bug 29445: Enable support for enterprise policies Enable enterprise policies for all update channels, including "release" (which Tor Browser uses instead of "esr"). --- browser/components/enterprisepolicies/EnterprisePolicies.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/browser/components/enterprisepolicies/EnterprisePolicies.js b/browser/components/enterprisepolicies/EnterprisePolicies.js index 7c864f5fbc43..1380c0c228a4 100644 --- a/browser/components/enterprisepolicies/EnterprisePolicies.js +++ b/browser/components/enterprisepolicies/EnterprisePolicies.js @@ -126,7 +126,7 @@ EnterprisePoliciesManager.prototype = { } if (policySchema.enterprise_only && !areEnterpriseOnlyPoliciesAllowed()) { - log.error(`Policy ${policyName} is only allowed on ESR`); + log.error(`Enterprise policy ${policyName} is not allowed`); continue; } @@ -314,10 +314,6 @@ let DisallowedFeatures = {}; * Checks whether the policies marked as enterprise_only in the * schema are allowed to run on this browser. * - * This is meant to only allow policies to run on ESR, but in practice - * we allow it to run on channels different than release, to allow - * these policies to be tested on pre-release channels. - * * @returns {Bool} Whether the policy can run. */ function areEnterpriseOnlyPoliciesAllowed() { @@ -328,12 +324,7 @@ function areEnterpriseOnlyPoliciesAllowed() { return false; } - if (AppConstants.MOZ_UPDATE_CHANNEL != "release" || - Cu.isInAutomation) { - return true; - } - - return false; + return true; } /*

1 0