- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-115.26.0esr-13.5-1] Bug 43912: Make xslt:sort obey spoof English.
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-115.26.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 5e052e8c by Pier Angelo Vendrame at 2025-08-05T16:32:16+02:00 Bug 43912: Make xslt:sort obey spoof English. - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -76,6 +76,9 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); } + if (lang.IsEmpty() && nsContentUtils::SpoofLocaleEnglish()) { + lang.AssignLiteral("en-US"); + } // Case-order bool upperFirst = false; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e052e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e052e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 3f58a973 by Pier Angelo Vendrame at 2025-08-05T16:57:44+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3f5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3f5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 19f74a4d by Pier Angelo Vendrame at 2025-08-05T16:57:22+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/19f74a4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/19f74a4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 749092a5 by Pier Angelo Vendrame at 2025-08-05T16:56:46+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/749092a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/749092a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 6ed66bd3 by Pier Angelo Vendrame at 2025-08-05T16:55:44+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/6ed… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/6ed… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ff48f30 by Pier Angelo Vendrame at 2025-08-05T16:55:01+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ff48f3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ff48f3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41517: Add morgan's key to the setup account on the signing machines
by morgan (＠morgan) 05 Aug '25

05 Aug '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: ca3c9880 by Nicolas Vigier at 2025-08-05T14:52:22+00:00 Bug 41517: Add morgan's key to the setup account on the signing machines - - - - - 1 changed file: - tools/signing/machines-setup/setup-signing-machine Changes: ===================================== tools/signing/machines-setup/setup-signing-machine ===================================== @@ -70,6 +70,7 @@ install_packages sudo vim tmux gnupg create_user setup authorized_keys setup boklm-yk1.pub +authorized_keys setup morgan.pub mkdir -p /signing chmod 0755 /signing chown setup /signing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 17f8c468 by Pier Angelo Vendrame at 2025-08-05T16:48:25+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/17f8c46… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/17f8c46… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.13.0esr-14.5-1] 2 commits: fixup! [android] Implement Android-native Connection Assist UI
by morgan (＠morgan) 05 Aug '25

05 Aug '25

morgan pushed to branch tor-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: a7a52bcf by clairehurst at 2025-08-05T14:47:25+00:00 fixup! [android] Implement Android-native Connection Assist UI Bug 43645: Swiping away doesn't always disconnect from tor - - - - - 295c151d by Dan Ballard at 2025-08-05T14:47:31+00:00 fixup! TB 40023: [android] Stop PrivateNotificationService Bug 43346: revert patch, not needed anymore - - - - - 2 changed files: - mobile/android/android-components/components/feature/privatemode/src/main/java/mozilla/components/feature/privatemode/notification/PrivateNotificationFeature.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt Changes: ===================================== mobile/android/android-components/components/feature/privatemode/src/main/java/mozilla/components/feature/privatemode/notification/PrivateNotificationFeature.kt ===================================== @@ -44,7 +44,6 @@ class PrivateNotificationFeature<T : AbstractPrivateNotificationService>( } override fun stop() { - applicationContext.stopService(Intent(applicationContext, notificationServiceClass.java)) scope?.cancel() } } ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -635,6 +635,10 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorAn override fun onDestroy() { super.onDestroy() + if (isFinishing) { + exitProcess(0) + } + // Diagnostic breadcrumb for "Display already aquired" crash: // https://github.com/mozilla-mobile/android-components/issues/7960 breadcrumb( View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1dab3d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1dab3d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! TB 42669: [android] Use custom no-op app-services
by brizental (＠brizental) 05 Aug '25

05 Aug '25

brizental pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 8e3b160d by Beatriz Rizental at 2025-08-05T16:11:19+02:00 fixup! TB 42669: [android] Use custom no-op app-services - - - - - 1 changed file: - mobile/android/autopublish-settings.gradle Changes: ===================================== mobile/android/autopublish-settings.gradle ===================================== @@ -30,6 +30,7 @@ def rootLocalProperties = new File(gradle.mozconfig.topsrcdir, "local.properties [ "autoPublish.application-services.dir", "autoPublish.glean.dir", + "uniffiBindgenNoop.dir", ].each { key -> def relativeOrAbsolutePath = rootLocalProperties."$key" if (relativeOrAbsolutePath != null) { @@ -40,6 +41,10 @@ def rootLocalProperties = new File(gradle.mozconfig.topsrcdir, "local.properties gradle.settingsEvaluated { if (gradle.hasProperty("localProperties.autoPublish.application-services.dir")) { + if (!gradle.hasProperty("localProperties.uniffiBindgenNoop.dir")) { + throw new GradleException("Set uniffiBindgenNoop.dir to your local.properties in order to auto publish application-services.") + } + def appServicesLocalPath = gradle."localProperties.autoPublish.application-services.dir" logger.lifecycle("settings.gradle> Enabling automatic publication of application-services from: $appServicesLocalPath") // Windows can't execute .py files directly, so we assume a "manually installed" python, @@ -48,13 +53,17 @@ gradle.settingsEvaluated { if (System.properties["os.name"].toLowerCase().contains("windows")) { publishAppServicesCmd << "py"; } - publishAppServicesCmd << "./automation/publish_to_maven_local_if_modified.py"; + publishAppServicesCmd << "./automation/publish_to_maven_local_if_modified.py" << gradle."localProperties.uniffiBindgenNoop.dir"; runCmd(publishAppServicesCmd, appServicesLocalPath, "Published application-services for local development.", false) } else { logger.lifecycle("settings.gradle> Disabled auto-publication of application-services. Enable it by settings 'autoPublish.application-services.dir' in local.properties") } if (gradle.hasProperty("localProperties.autoPublish.glean.dir")) { + if (!gradle.hasProperty("localProperties.uniffiBindgenNoop.dir")) { + throw new GradleException("Set uniffiBindgenNoop.dir to your local.properties in order to auto publish glean.") + } + def gleanLocalPath = gradle."localProperties.autoPublish.glean.dir" logger.lifecycle("settings.gradle> Enabling automatic publication of Glean from: $gleanLocalPath") // As above, hacks to execute .py files on Windows. @@ -62,7 +71,10 @@ gradle.settingsEvaluated { if (System.properties["os.name"].toLowerCase().contains("windows")) { publishGleanCmd << "py"; } - publishGleanCmd << "./build-scripts/publish_to_maven_local_if_modified.py"; + + // We do not have a fork of Glean. In order for this to work, on your local + // copy of the Glean repo, modify this python script to accept and use the uniffi-bindgen path. + publishGleanCmd << "./build-scripts/publish_to_maven_local_if_modified.py" << gradle."localProperties.uniffiBindgenNoop.dir"; runCmd(publishGleanCmd, gleanLocalPath, "Published Glean for local development.", false) } else { logger.lifecycle("settings.gradle> Disabled auto-publication of Glean. Enable it by settings 'autoPublish.glean.dir' in local.properties") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8e3b160… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8e3b160… You're receiving this email because of your account on gitlab.torproject.org.

1 0