- tbb-commits - lists.torproject.org

[tor-browser/tor-browser-85.0b1-10.5-1] Bug 40198: Expose privacy.spoof_english pref in GeckoView
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 81b772d7a0a051fe25109cf439fd805a9276b120 Author: Alex Catarineu <acat(a)torproject.org> Date: Sun Oct 18 17:06:04 2020 +0200 Bug 40198: Expose privacy.spoof_english pref in GeckoView --- mobile/android/geckoview/api.txt | 3 ++ .../mozilla/geckoview/GeckoRuntimeSettings.java | 33 ++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/mobile/android/geckoview/api.txt b/mobile/android/geckoview/api.txt index afab7a2ea9f3..65529f18cf46 100644 --- a/mobile/android/geckoview/api.txt +++ b/mobile/android/geckoview/api.txt @@ -632,6 +632,7 @@ package org.mozilla.geckoview { method public boolean getRemoteDebuggingEnabled(); method @Nullable public GeckoRuntime getRuntime(); method @Nullable public Rect getScreenSizeOverride(); + method public boolean getSpoofEnglish(); method @Nullable public RuntimeTelemetry.Delegate getTelemetryDelegate(); method public int getTorSecurityLevel(); method public boolean getUseMaxScreenDepth(); @@ -651,6 +652,7 @@ package org.mozilla.geckoview { method @NonNull public GeckoRuntimeSettings setLoginAutofillEnabled(boolean); method @NonNull public GeckoRuntimeSettings setPreferredColorScheme(int); method @NonNull public GeckoRuntimeSettings setRemoteDebuggingEnabled(boolean); + method @NonNull public GeckoRuntimeSettings setSpoofEnglish(boolean); method @NonNull public GeckoRuntimeSettings setTorSecurityLevel(int); method @NonNull public GeckoRuntimeSettings setWebFontsEnabled(boolean); method @NonNull public GeckoRuntimeSettings setWebManifestEnabled(boolean); @@ -686,6 +688,7 @@ package org.mozilla.geckoview { method @NonNull public GeckoRuntimeSettings.Builder preferredColorScheme(int); method @NonNull public GeckoRuntimeSettings.Builder remoteDebuggingEnabled(boolean); method @NonNull public GeckoRuntimeSettings.Builder screenSizeOverride(int, int); + method @NonNull public GeckoRuntimeSettings.Builder spoofEnglish(boolean); method @NonNull public GeckoRuntimeSettings.Builder telemetryDelegate(@NonNull RuntimeTelemetry.Delegate); method @NonNull public GeckoRuntimeSettings.Builder torSecurityLevel(int); method @NonNull public GeckoRuntimeSettings.Builder useMaxScreenDepth(boolean); diff --git a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java index bb992733937e..e6493f8cddb3 100644 --- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java +++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java @@ -457,6 +457,17 @@ public final class GeckoRuntimeSettings extends RuntimeSettings { getSettings().mTorSecurityLevel.set(level); return this; } + + /** + * Sets whether we should spoof locale to English for webpages. + * + * @param flag True if we should spoof locale to English for webpages, false otherwise. + * @return This Builder instance. + */ + public @NonNull Builder spoofEnglish(final boolean flag) { + getSettings().mSpoofEnglish.set(flag ? 2 : 1); + return this; + } } private GeckoRuntime mRuntime; @@ -507,6 +518,8 @@ public final class GeckoRuntimeSettings extends RuntimeSettings { "signon.autofillForms", true); /* package */ final Pref<Integer> mTorSecurityLevel = new Pref<>( "extensions.torbutton.security_slider", 4); + /* package */ final Pref<Integer> mSpoofEnglish = new Pref<>( + "privacy.spoof_english", 0); /* package */ int mPreferredColorScheme = COLOR_SCHEME_SYSTEM; @@ -1171,6 +1184,26 @@ public final class GeckoRuntimeSettings extends RuntimeSettings { return this; } + /** + * Get whether we should spoof locale to English for webpages. + * + * @return Whether we should spoof locale to English for webpages. + */ + public boolean getSpoofEnglish() { + return mSpoofEnglish.get() == 2; + } + + /** + * Set whether we should spoof locale to English for webpages. + * + * @param flag A flag determining whether we should locale to English for webpages. + * @return This GeckoRuntimeSettings instance. + */ + public @NonNull GeckoRuntimeSettings setSpoofEnglish(final boolean flag) { + mSpoofEnglish.commit(flag ? 2 : 1); + return this; + } + @Override // Parcelable public void writeToParcel(final Parcel out, final int flags) { super.writeToParcel(out, flags);

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit c2c42f94e29914ce74808dcbf96a86e44a83d92e Author: Peter Story <pstory(a)andrew.cmu.edu> Date: Fri Jan 8 12:07:24 2021 -0500 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40287: Switch DDG search from POST to GET --- browser/components/search/extensions/ddg-onion/manifest.json | 4 ++-- browser/components/search/extensions/ddg/manifest.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/browser/components/search/extensions/ddg-onion/manifest.json b/browser/components/search/extensions/ddg-onion/manifest.json index 294496b78368..4aa79e4abea0 100644 --- a/browser/components/search/extensions/ddg-onion/manifest.json +++ b/browser/components/search/extensions/ddg-onion/manifest.json @@ -19,8 +19,8 @@ "search_provider": { "name": "DuckDuckGoOnion", "search_url": "https://3g2upl4pq6kufc4m.onion", - "search_form": "https://3g2upl4pq6kufc4m.onion", - "search_url_post_params": "q={searchTerms}" + "search_form": "https://3g2upl4pq6kufc4m.onion/?q={searchTerms}", + "search_url_get_params": "q={searchTerms}" } } } \ No newline at end of file diff --git a/browser/components/search/extensions/ddg/manifest.json b/browser/components/search/extensions/ddg/manifest.json index f6aacc3dd069..4a3b0ad20fe9 100644 --- a/browser/components/search/extensions/ddg/manifest.json +++ b/browser/components/search/extensions/ddg/manifest.json @@ -20,8 +20,8 @@ "keyword": ["@duckduckgo", "@ddg"], "name": "DuckDuckGo", "search_url": "https://duckduckgo.com", - "search_form": "https://duckduckgo.com", - "search_url_post_params": "q={searchTerms}", + "search_form": "https://duckduckgo.com/?q={searchTerms}", + "search_url_get_params": "q={searchTerms}", "suggest_url": "https://ac.duckduckgo.com/ac/", "suggest_url_get_params": "q={searchTerms}&type=list" }

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 6e252283143ac8896f3ad8a3dc91f82e9c88e5ef Author: Alex Catarineu <acat(a)torproject.org> Date: Wed Nov 4 15:58:22 2020 +0100 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware --- .../main/java/org/mozilla/geckoview/WebRequest.java | 18 ++++++++++++++++++ widget/android/WebExecutorSupport.cpp | 10 ++++++++++ 2 files changed, 28 insertions(+) diff --git a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebRequest.java b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebRequest.java index 7e3aa285c5be..18f56abeec43 100644 --- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebRequest.java +++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebRequest.java @@ -49,6 +49,11 @@ public class WebRequest extends WebMessage { */ public final @Nullable String referrer; + /** + * The value of the origin of this request. + */ + public final @Nullable String origin; + @Retention(RetentionPolicy.SOURCE) @IntDef({CACHE_MODE_DEFAULT, CACHE_MODE_NO_STORE, CACHE_MODE_RELOAD, CACHE_MODE_NO_CACHE, @@ -110,6 +115,7 @@ public class WebRequest extends WebMessage { method = builder.mMethod; cacheMode = builder.mCacheMode; referrer = builder.mReferrer; + origin = builder.mOrigin; if (builder.mBody != null) { body = builder.mBody.asReadOnlyBuffer(); @@ -126,6 +132,7 @@ public class WebRequest extends WebMessage { /* package */ String mMethod = "GET"; /* package */ int mCacheMode = CACHE_MODE_DEFAULT; /* package */ String mReferrer; + /* package */ String mOrigin; /** * Construct a Builder instance with the specified URI. @@ -205,6 +212,17 @@ public class WebRequest extends WebMessage { return this; } + /** + * Set the origin URI. + * + * @param origin A URI String + * @return This Builder instance. + */ + public @NonNull Builder origin(final @Nullable String origin) { + mOrigin = origin; + return this; + } + /** * @return A {@link WebRequest} constructed with the values from this Builder instance. */ diff --git a/widget/android/WebExecutorSupport.cpp b/widget/android/WebExecutorSupport.cpp index ac498da4fd74..fab717730846 100644 --- a/widget/android/WebExecutorSupport.cpp +++ b/widget/android/WebExecutorSupport.cpp @@ -392,6 +392,16 @@ nsresult WebExecutorSupport::CreateStreamLoader( MOZ_ASSERT(cookieJarSettings); nsCOMPtr<nsILoadInfo> loadInfo = channel->LoadInfo(); + + RefPtr<nsIURI> originUri; + const auto origin = req->Origin(); + if (origin) { + rv = NS_NewURI(getter_AddRefs(originUri), origin->ToString()); + NS_ENSURE_SUCCESS(rv, NS_ERROR_MALFORMED_URI); + OriginAttributes attrs = loadInfo->GetOriginAttributes(); + attrs.SetFirstPartyDomain(true, originUri); + loadInfo->SetOriginAttributes(attrs); + } loadInfo->SetCookieJarSettings(cookieJarSettings); // setup http/https specific things

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 12620: TorBrowser regression tests
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 2cc266366b66aa1052b5bb288db78ad466023a2f Author: Alex Catarineu <acat(a)torproject.org> Date: Wed Nov 4 20:49:51 2020 +0100 fixup! Bug 12620: TorBrowser regression tests --- run-tbb-tests | 10 +++++++--- tbb-tests-ignore.txt | 14 ++++++++++++++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/run-tbb-tests b/run-tbb-tests index 5e266f9ba4cd..b12e62d942c9 100755 --- a/run-tbb-tests +++ b/run-tbb-tests @@ -18,8 +18,8 @@ then echo "Using tests list from file tbb-tests-list.txt" tests=($(cat tbb-tests-list.txt)) else - ffxbld_commit=$(git log -500 --format='%an %H' | grep '^ffxbld ' \ - | head -1 | cut -d ' ' -f 2) + ffxbld_commit=$(git log -500 --format='oneline' | grep "TB3: Tor Browser's official .mozconfigs." \ + | head -1 | cut -d ' ' -f 1) tests=($(git diff --name-status "$ffxbld_commit" HEAD | \ grep -e '^[AM].*/test_[^/]\+\.$html\|xul$$' \ @@ -51,7 +51,11 @@ fi rm -f tbb-tests.log echo $'\n''Starting tests' -./mach mochitest --log-tbpl tbb-tests.log --setpref security.nocertdb=false \ +./mach mochitest --log-tbpl tbb-tests.log \ + --setpref network.file.path_blacklist='' \ + --setpref extensions.torbutton.use_nontor_proxy=true \ + --setpref browser.privatebrowsing.autostart=false \ + --setpref security.nocertdb=false \ "${tests[@]}" echo "*************************" diff --git a/tbb-tests-ignore.txt b/tbb-tests-ignore.txt new file mode 100644 index 000000000000..f965010a7cd4 --- /dev/null +++ b/tbb-tests-ignore.txt @@ -0,0 +1,14 @@ +browser/extensions/onboarding/test/browser/browser_onboarding_accessibility.js +browser/extensions/onboarding/test/browser/browser_onboarding_keyboard.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification_2.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification_3.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification_4.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js +browser/extensions/onboarding/test/browser/browser_onboarding_notification_click_auto_complete_tour.js +browser/extensions/onboarding/test/browser/browser_onboarding_select_default_tour.js +browser/extensions/onboarding/test/browser/browser_onboarding_skip_tour.js +browser/extensions/onboarding/test/browser/browser_onboarding_tours.js +browser/extensions/onboarding/test/browser/browser_onboarding_tourset.js +browser/extensions/onboarding/test/browser/browser_onboarding_uitour.js +

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 32658: Create a new MAR signing key
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit af86953812484a744c8dbe2d6b7a19b3ebbc668d Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jan 8 07:57:34 2021 +0000 fixup! Bug 32658: Create a new MAR signing key Closes #40274. --- .../update/updater/nightly_aurora_level3_primary.der | Bin 1245 -> 1245 bytes .../updater/nightly_aurora_level3_secondary.der | Bin 1245 -> 1245 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der b/toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der index a3a3077cc574..d579cf801e1a 100644 Binary files a/toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der and b/toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der differ diff --git a/toolkit/mozapps/update/updater/nightly_aurora_level3_secondary.der b/toolkit/mozapps/update/updater/nightly_aurora_level3_secondary.der index d579cf801e1a..7cbfa77d06e7 100644 Binary files a/toolkit/mozapps/update/updater/nightly_aurora_level3_secondary.der and b/toolkit/mozapps/update/updater/nightly_aurora_level3_secondary.der differ

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 16620: Clear window.name when no referrer sent
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 7d9caa0c9885ccad847adc065c0bcdb2e418df8d Author: Alex Catarineu <acat(a)torproject.org> Date: Fri Apr 3 21:23:10 2020 +0200 fixup! Bug 16620: Clear window.name when no referrer sent --- docshell/test/mochitest/test_tor_bug16620.html | 5 ++--- docshell/test/mochitest/tor_bug16620.html | 2 +- docshell/test/mochitest/tor_bug16620_form.html | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docshell/test/mochitest/test_tor_bug16620.html b/docshell/test/mochitest/test_tor_bug16620.html index f60a06711c17..46fff5a04711 100644 --- a/docshell/test/mochitest/test_tor_bug16620.html +++ b/docshell/test/mochitest/test_tor_bug16620.html @@ -13,8 +13,7 @@ </head> <body> <a target="_blank" href="https://trac.torproject.org/projects/tor/ticket/16620">Tor Bug 16620</a> -<script type="application/javascript;version=1.7"> - +<script> // ## Test constants const kTestPath = "/tests/docshell/test/mochitest/"; const kLinkFile = "tor_bug16620.html"; @@ -156,7 +155,7 @@ window.addEventListener("message", function(aEvent) { noReferrerOnLink: noReferrerOnLink, noReferrerInMetaTag: noReferrerInMetaTag, resetInUnload: resetInUnload }, - aEvent.origin); + "*"); } else if ("secondDocLoaded" == state) { // Process response from step two of the link-based tests. if (curTest.expectIsolation) { diff --git a/docshell/test/mochitest/tor_bug16620.html b/docshell/test/mochitest/tor_bug16620.html index a8e90502f1d1..26b8e406bbff 100644 --- a/docshell/test/mochitest/tor_bug16620.html +++ b/docshell/test/mochitest/tor_bug16620.html @@ -11,7 +11,7 @@ <body> <a id="link" href="">secondDoc</a> -<script type="application/javascript;version=1.7"> +<script> // Extract test state from our query string, defaulting to // "secondDocLoaded" to support use of this HTML content within // a data URI (where query strings are not supported). diff --git a/docshell/test/mochitest/tor_bug16620_form.html b/docshell/test/mochitest/tor_bug16620_form.html index 3b6e6c72cfc9..279f62e63fab 100644 --- a/docshell/test/mochitest/tor_bug16620_form.html +++ b/docshell/test/mochitest/tor_bug16620_form.html @@ -12,7 +12,7 @@ </head> <body> -<script type="application/javascript;version=1.7"> +<script> document.addEventListener("DOMContentLoaded", function () { addPostTarget(); }, false);

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 12620: TorBrowser regression tests
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 0b8a7fa9ab300d4790584a2492f652f8a5c0abb2 Author: Alex Catarineu <acat(a)torproject.org> Date: Fri Jan 8 21:03:51 2021 +0100 fixup! Bug 12620: TorBrowser regression tests --- tbb-tests/browser_tor_TB4.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tbb-tests/browser_tor_TB4.js b/tbb-tests/browser_tor_TB4.js index f08d086e3815..8bb12f360e5e 100644 --- a/tbb-tests/browser_tor_TB4.js +++ b/tbb-tests/browser_tor_TB4.js @@ -1,9 +1,7 @@ // # Test for TB4: Tor Browser's Firefox preference overrides -// Simple regression tests to check the value of each pref and -// decides if it is set as expected. - -// TODO: Write unit tests to check that each pref setting here -// causes the browser to have the desired behavior (a big task). +// This is a minimal test to check whether the 000-tor-browser.js +// pref overrides are being used at all or not. More comprehensive +// pref tests are maintained in the tor-browser-bundle-testsuite project. function test() {

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 23104: Add a default line height compensation
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 7ff72b429066ffa0dff343f6fd1d4aad44d8866d Author: Alex Catarineu <acat(a)torproject.org> Date: Fri Apr 3 21:34:55 2020 +0200 fixup! Bug 23104: Add a default line height compensation --- layout/generic/test/test_tor_bug23104.html | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/layout/generic/test/test_tor_bug23104.html b/layout/generic/test/test_tor_bug23104.html index ae73a3446037..8ff1d2190c45 100644 --- a/layout/generic/test/test_tor_bug23104.html +++ b/layout/generic/test/test_tor_bug23104.html @@ -17,12 +17,10 @@ <span id="test1">Test1</span> <span id="test2">كلمة</span> <span id="test3">ação</span> -<script type="application/javascript;version=1.7"> +<script> -let setPref = function* (key, value) { - return new Promise(function(resolve, reject) { - SpecialPowers.pushPrefEnv({"set": [[key, value]]}, resolve); - }); +let setPref = async function (key, value) { + await SpecialPowers.pushPrefEnv({"set": [[key, value]]}); } function getStyle(el, styleprop) { @@ -34,12 +32,13 @@ function validateElement(elementName, isFingerprintResistent) { var fontSize = getStyle(elementName, 'font-size'); var lineHeight = getStyle(elementName, 'line-height'); var validationCb = isFingerprintResistent ? is : isnot; - validationCb(parseFloat(lineHeight), parseFloat(fontSize) * 1.2, 'Line Height validation'); + validationCb(parseFloat(lineHeight), Math.round(parseFloat(fontSize)) * 1.2, 'Line Height validation'); } -add_task(function* () { +add_task(async function() { + await setPref("layout.css.line-height.normal-as-resolved-value.enabled", false); for (let resistFingerprintingValue of [true, false]) { - yield setPref("privacy.resistFingerprinting", resistFingerprintingValue); + await setPref("privacy.resistFingerprinting", resistFingerprintingValue); for (let elementId of ['test1', 'test2', 'test3']) { validateElement(elementId, resistFingerprintingValue); }

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 12620: TorBrowser regression tests
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 127f980e72fa200be9e88d887ebb8921d2f09c88 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Jan 11 15:25:38 2021 +0100 fixup! Bug 12620: TorBrowser regression tests --- run-tbb-tests | 3 +++ 1 file changed, 3 insertions(+) diff --git a/run-tbb-tests b/run-tbb-tests index 1566c37c43cb..bc09839f9f05 100755 --- a/run-tbb-tests +++ b/run-tbb-tests @@ -51,6 +51,9 @@ fi rm -f tbb-tests.log echo $'\n''Starting tests' +# We need `security.nocertdb = false` because of #18087. That pref is +# forced to have the same value as `browser.privatebrowsing.autostart` in +# torbutton, so we just set `browser.privatebrowsing.autostart=false` here. ./mach mochitest --log-tbpl tbb-tests.log \ --setpref network.file.path_blacklist='' \ --setpref extensions.torbutton.use_nontor_proxy=true \

1 0

[tor-browser/tor-browser-85.0b1-10.5-1] fixup! Bug 10760: Integrate TorButton to TorBrowser core
by gk＠torproject.org 12 Jan '21

12 Jan '21

commit 2f1ce111ad6e8ee6b189f501576f38ab2d259894 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Jan 12 08:36:12 2021 +0000 fixup! Bug 10760: Integrate TorButton to TorBrowser core --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index 968c2565ceb8..ba38a0f51e25 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit 968c2565ceb8417ef026cf639cd5c2e80f6057a4 +Subproject commit ba38a0f51e2556a896feb0baf1fb4fd7f3970c3b

1 0