- tbb-commits - lists.torproject.org

[tor-browser-build/master] Pick up latest mobile translation changes
by gk＠torproject.org 20 Nov '19

20 Nov '19

commit 52bcd79d6578315f3f5ef84ca5025fb0420e7a6e Author: Georg Koppen <gk(a)torproject.org> Date: Wed Nov 20 13:23:58 2019 +0000 Pick up latest mobile translation changes --- projects/tba-translation/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/tba-translation/config b/projects/tba-translation/config index 1b3274a..4056a6f 100644 --- a/projects/tba-translation/config +++ b/projects/tba-translation/config @@ -3,5 +3,5 @@ filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz' git_url: https://git.torproject.org/translation.git # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. -git_hash: 21677307d87d3216eede51a6ad36bf26e7937667 +git_hash: b31ac83a63ba8f0b63de07052c3e66ddff16c8aa version: '[% c("abbrev") %]'

1 0

[torbutton/master] Bug 28745: Remove torbutton.js unused code
by gk＠torproject.org 20 Nov '19

20 Nov '19

commit 65e1e8ba67ba865e7b3ded74b7e4bbc5b86c721c Author: Alex Catarineu <acat(a)torproject.org> Date: Tue Jun 11 15:54:08 2019 +0200 Bug 28745: Remove torbutton.js unused code --- chrome/content/torbutton.js | 114 -------------------------------------------- 1 file changed, 114 deletions(-) diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index b9642a89..e75584cf 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -537,26 +537,6 @@ function torbutton_notify_if_update_needed() { setOrClearAttribute(item, "tbUpdateNeeded", updateNeeded); } -function torbutton_check_for_update() { - // Open the update prompt in the correct mode. The update state - // checks used here were adapted from isPending() and isApplied() in - // Mozilla's browser/base/content/aboutDialog.js code. - let updateMgr = Cc["@mozilla.org/updates/update-manager;1"] - .getService(Ci.nsIUpdateManager); - let update = updateMgr.activeUpdate; - let updateState = (update) ? update.state : undefined; - let pendingStates = [ "pending", "pending-service", - "applied", "applied-service" ]; - let isPending = (updateState && (pendingStates.indexOf(updateState) >= 0)); - - let prompter = Cc["@mozilla.org/updates/update-prompt;1"] - .createInstance(Ci.nsIUpdatePrompt); - if (isPending) - prompter.showUpdateDownloaded(update, false); - else - prompter.checkForUpdates(); -} - // Bug 1506 P4: Checking for Tor Browser updates is pretty important, // probably even as a fallback if we ever do get a working updater. function torbutton_do_async_versioncheck() { @@ -1482,39 +1462,6 @@ function torbutton_close_tabs_on_new_identity() { torbutton_log(3, "Closed all tabs"); } -// Bug 1506 P2: This code is only important for disabling -// New Identity where it is not supported (ie no control port). -function torbutton_check_protections() -{ - var env = Cc["@mozilla.org/process/environment;1"] - .getService(Ci.nsIEnvironment); - - // Bug 14100: check for the existence of an environment variable - // in order to toggle the visibility of networksettings menuitem - if (env.exists("TOR_NO_DISPLAY_NETWORK_SETTINGS")) - document.getElementById("torbutton-networksettings").hidden = true; - else - document.getElementById("torbutton-networksettings").hidden = false; - - // Bug 21091: check for the existence of an environment variable - // in order to toggle the visibility of the torbutton-checkForUpdate - // menuitem and its separator. - if (env.exists("TOR_HIDE_UPDATE_CHECK_UI")) { - document.getElementById("torbutton-checkForUpdateSeparator").hidden = true; - document.getElementById("torbutton-checkForUpdate").hidden = true; - } else { - document.getElementById("torbutton-checkForUpdateSeparator").hidden = false; - document.getElementById("torbutton-checkForUpdate").hidden = false; - } - - if (!m_tb_control_pass || (!m_tb_control_ipc_file && !m_tb_control_port)) { - // TODO: Remove the Torbutton menu entry again once we have done our - // security control redesign. - document.getElementById("menu_newIdentity").disabled = true; - document.getElementById("appMenuNewIdentity").disabled = true; - } -} - // -------------- HISTORY & COOKIES --------------------- // Bug 1506 P4: Used by New Identity if cookie protections are @@ -1843,13 +1790,6 @@ function torbutton_close_window(event) { } } - -function torbutton_open_network_settings() { - var obsSvc = Services.obs; - obsSvc.notifyObservers(this, "TorOpenNetworkSettings"); -} - - window.addEventListener('load',torbutton_new_window,false); window.addEventListener('unload', torbutton_close_window, false); @@ -1956,60 +1896,6 @@ var torbutton_resizelistener = onSecurityChange: function() {} }; -// aURI should be an http or https nsIURI object. -function torbutton_get_current_accept_language_value(aURI) -{ - try { - let ioService = Services.io; - let channel = ioService.newChannelFromURI(aURI); - let httpChannel = channel.QueryInterface(Ci.nsIHttpChannel); - return httpChannel.getRequestHeader("Accept-Language"); - } catch (e) {} - - return null; -} - -// Take URL strings the user has specified for a homepage -// and normalize it so it looks like a real URL. -function torbutton_normalize_homepage_url_string(aURLString) -{ - if (!aURLString) return null; - if (typeof aURLString !== "string") return null; - let url; - try { - url = new URL(aURLString); - } catch (e) { - try { - url = new URL("http://" + aURLString); - } catch (e) { - return null; - } - } - return url.href; -} - -function torbutton_is_homepage_url(aURI) -{ - if (!aURI) - return false; - - let homePageURLs; - let choice = m_tb_prefs.getIntPref("browser.startup.page"); - if ((1 == choice) || (3 == choice)) try { - // A homepage may be used at startup. Get the values and check against - // aURI.spec. - homePageURLs = m_tb_prefs.getComplexValue("browser.startup.homepage", - Ci.nsIPrefLocalizedString).data; - } catch (e) {} - - if (!homePageURLs) - return false; - - let urls = homePageURLs.split('|') - .map(torbutton_normalize_homepage_url_string); - return (urls.indexOf(aURI.spec) >= 0); -} - // Makes sure the item in the Help Menu and the link in about:tor // for the Tor Browser User Manual are only visible when // show_torbrowser_manual() returns true.

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor
by gk＠torproject.org 20 Nov '19

20 Nov '19

commit e847b87fda117ebf06459755b5dbd037eb1d349a Author: Richard Pospesel <richard(a)torproject.org> Date: Fri Nov 15 13:48:46 2019 -0800 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor Fixes bug 32508. --- browser/components/torpreferences/content/torPane.xul | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/browser/components/torpreferences/content/torPane.xul b/browser/components/torpreferences/content/torPane.xul index 5d8451554eb9..d158b7e4676a 100644 --- a/browser/components/torpreferences/content/torPane.xul +++ b/browser/components/torpreferences/content/torPane.xul @@ -5,12 +5,13 @@ <html:template id="template-paneTor"> <hbox id="torPreferencesCategory" class="subcategory" - hidden="true" - data-category="paneTor"> + data-category="paneTor" + hidden="true"> <html:h1 id="torPreferences-header"/> </hbox> -<groupbox data-category="paneTor" > +<groupbox data-category="paneTor" + hidden="true"> <description flex="1"> <html:span id="torPreferences-description" class="tail-with-learn-more"/> <label id="torPreferences-learnMore" class="learnMore text-link" is="text-link"/> @@ -18,7 +19,9 @@ </groupbox>  -<groupbox id="torPreferences-bridges-group" data-category="paneTor" > +<groupbox id="torPreferences-bridges-group" + data-category="paneTor" + hidden="true"> <html:h2 id="torPreferences-bridges-header"/> <description flex="1"> <html:span id="torPreferences-bridges-description" class="tail-with-learn-more"/> @@ -63,7 +66,9 @@ </groupbox>  -<groupbox id="torPreferences-advanced-group" data-category="paneTor"> +<groupbox id="torPreferences-advanced-group" + data-category="paneTor" + hidden="true"> <html:h2 id="torPreferences-advanced-header"/> <description flex="1"> <html:span id="torPreferences-advanced-description" class="tail-with-learn-more"/>

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! Pick up latest Torbutton code
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 94d8be288b1177ec4fe71a719ca6b6cccfbff5f4 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Nov 19 15:08:50 2019 +0000 fixup! Pick up latest Torbutton code --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index 73a43f2f4d84..fa05e61cac49 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit 73a43f2f4d846b2870757d7aa18a1b33643ba2b5 +Subproject commit fa05e61cac497a7fbe3050ee8a9f4f6ec39be3a4

1 0

[torbutton/master] Bug 30237: Add strings for v3 onion services client authentication
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit fa05e61cac497a7fbe3050ee8a9f4f6ec39be3a4 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue Nov 12 15:39:19 2019 -0500 Bug 30237: Add strings for v3 onion services client authentication --- chrome/locale/en-US/torbutton.dtd | 3 +++ chrome/locale/en-US/torbutton.properties | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/chrome/locale/en-US/torbutton.dtd b/chrome/locale/en-US/torbutton.dtd index d14bd1da..ed3cb1a6 100644 --- a/chrome/locale/en-US/torbutton.dtd +++ b/chrome/locale/en-US/torbutton.dtd @@ -47,3 +47,6 @@ <!ENTITY torbutton.prefs.sec_advanced_security_settings "Advanced Security Settings…"> <!ENTITY torbutton.circuit_display.title "Tor Circuit"> <!ENTITY torbutton.circuit_display.new_circuit "New Circuit for this Site"> + + +<!ENTITY torbutton.onionServices.authPrompt.tooltip "Open onion service client authentication prompt"> diff --git a/chrome/locale/en-US/torbutton.properties b/chrome/locale/en-US/torbutton.properties index ea7a7d63..1020e57a 100644 --- a/chrome/locale/en-US/torbutton.properties +++ b/chrome/locale/en-US/torbutton.properties @@ -58,3 +58,13 @@ updateDownloadingPanelUILabel=Downloading %S update # .Onion Page Info prompt. Strings are kept here for ease of translation. pageInfo_OnionEncryptionWithBitsAndProtocol=Connection Encrypted (Onion Service, %1$S, %2$S bit keys, %3$S) pageInfo_OnionEncryption=Connection Encrypted (Onion Service) + +# Onion services strings. Strings are kept here for ease of translation. +# LOCALIZATION NOTE: %S will be replaced with the .onion address. +onionServices.clientAuthMissing=Tor onion service missing client authorization +onionServices.authPrompt.description=%S is requesting your private key. +onionServices.authPrompt.keyPlaceholder=Enter your private key for this onion service +onionServices.authPrompt.done=Done +onionServices.authPrompt.doneAccessKey=d +onionServices.authPrompt.invalidKey=Please enter a valid key (52 base32 characters or 44 base64 characters) +onionServices.authPrompt.failedToSetKey=Unable to configure Tor with your key

1 0

[torbutton/master] Bug 30237: Control port module improvements for v3 client authentication
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 46efc92348dbed06fc31ddfb0a5ac2e4e8554de2 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue Nov 12 15:38:10 2019 -0500 Bug 30237: Control port module improvements for v3 client authentication Split the configuration portion of the controller() function into a new configureControlPortModule() function. This allows the Torbutton code to continue to own the configuration (with help from Tor Launcher) while making it possible for the v3 client authentication prompt to use Torbutton's control port module. Also, include error information returned by Tor within error objects generated by the control port module and add support for Tor's new ONION_CLIENT_AUTH_ADD control port command. --- chrome/content/tor-circuit-display.js | 21 ++++---- chrome/content/torbutton.js | 8 +-- modules/tor-control-port.js | 95 ++++++++++++++++++++++++++++------- 3 files changed, 92 insertions(+), 32 deletions(-) diff --git a/chrome/content/tor-circuit-display.js b/chrome/content/tor-circuit-display.js index 21bcc57b..1e58b2b4 100644 --- a/chrome/content/tor-circuit-display.js +++ b/chrome/content/tor-circuit-display.js @@ -6,9 +6,8 @@ // with docco.js to produce pretty documentation. // // This script is to be embedded in torbutton.xul. It defines a single global -// function, createTorCircuitDisplay(ipcFile, host, port, password), which -// activates the automatic Tor circuit display for the current tab and any -// future tabs. +// function, createTorCircuitDisplay(), which activates the automatic Tor +// circuit display for the current tab and any future tabs. // // See https://trac.torproject.org/8641 @@ -16,11 +15,12 @@ /* global document, gBrowser, Components */ // ### Main function -// __createTorCircuitDisplay(ipcFile, host, port, password, enablePrefName)__. +// __createTorCircuitDisplay(enablePrefName)__. // The single function that prepares tor circuit display. Connects to a tor -// control port with the given ipcFile or host plus port, and password, and -// binds to a named bool pref whose value determines whether the circuit display -// is enabled or disabled. +// control port using information provided to the control port module via +// a previous call to configureControlPortModule(), and binds to a named +// bool pref whose value determines whether the circuit display is enabled +// or disabled. let createTorCircuitDisplay = (function () { "use strict"; @@ -415,11 +415,11 @@ let ensureCorrectPopupDimensions = function () { // ## Main function -// __setupDisplay(ipcFile, host, port, password, enablePrefName)__. +// __setupDisplay(enablePrefName)__. // Once called, the Tor circuit display will be started whenever // the "enablePref" is set to true, and stopped when it is set to false. // A reference to this function (called createTorCircuitDisplay) is exported as a global. -let setupDisplay = function (ipcFile, host, port, password, enablePrefName) { +let setupDisplay = function (enablePrefName) { setupGuardNote(); let myController = null, stopCollectingIsolationData = null, @@ -442,8 +442,7 @@ let setupDisplay = function (ipcFile, host, port, password, enablePrefName) { }, start = function () { if (!myController) { - myController = controller(ipcFile, host, port || 9151, password, - function (err) { + myController = controller(function (err) { // An error has occurred. logger.eclog(5, err); logger.eclog(5, "Disabling tor display circuit because of an error."); diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index aacae042..b9642a89 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -21,6 +21,7 @@ let { getDomainForBrowser, } = ChromeUtils.import("resource://torbutton/modules/utils.js", {}); let SecurityPrefs = ChromeUtils.import("resource://torbutton/modules/security-prefs.js", {}); +let { configureControlPortModule } = Cu.import("resource://torbutton/modules/tor-control-port.js", {}); const k_tb_last_browser_version_pref = "extensions.torbutton.lastBrowserVersion"; const k_tb_browser_update_needed_pref = "extensions.torbutton.updateNeeded"; @@ -334,6 +335,9 @@ function torbutton_init() { } } + configureControlPortModule(m_tb_control_ipc_file, m_tb_control_host, + m_tb_control_port, m_tb_control_pass); + // Add about:tor IPC message listener. window.messageManager.addMessageListener("AboutTor:Loaded", torbutton_abouttor_message_handler); @@ -353,9 +357,7 @@ function torbutton_init() { torbutton_notify_if_update_needed(); try { - createTorCircuitDisplay(m_tb_control_ipc_file, m_tb_control_host, - m_tb_control_port, m_tb_control_pass, - "extensions.torbutton.display_circuit"); + createTorCircuitDisplay("extensions.torbutton.display_circuit"); } catch(e) { torbutton_log(4, "Error creating the tor circuit display " + e); } diff --git a/modules/tor-control-port.js b/modules/tor-control-port.js index 9f6dbeb6..1b0a79ad 100644 --- a/modules/tor-control-port.js +++ b/modules/tor-control-port.js @@ -7,10 +7,15 @@ // // To import the module, use // -// let { controller } = Components.utils.import("path/to/tor-control-port.js", {}); +// let { configureControlPortModule, controller } = +// Components.utils.import("path/to/tor-control-port.js", {}); +// +// See the second-to-last function defined in this file: +// configureControlPortModule(ipcFile, host, port, password) +// for usage of the configureControlPortModule function. // // See the last function defined in this file: -// controller(ipcFile, host, port, password, onError) +// controller(onError) // for usage of the controller function. /* jshint esnext: true */ @@ -229,7 +234,16 @@ io.matchRepliesToCommands = function (asyncSend, dispatcher) { let [command, replyCallback, errorCallback] = commandQueue.shift(); if (message.match(/^2/) && replyCallback) replyCallback(message); if (message.match(/^[45]/) && errorCallback) { - errorCallback(new Error(command + " -> " + message)); + let myErr = new Error(command + " -> " + message); + // Add Tor-specific information to the Error object. + let idx = message.indexOf(' '); + if (idx > 0) { + myErr.torStatusCode = message.substring(0, idx); + myErr.torMessage = message.substring(idx); + } else { + myErr.torStatusCode = message; + } + errorCallback(myErr); } }); // Create and return a version of sendCommand that returns a Promise. @@ -562,6 +576,24 @@ info.getConf = function (aControlSocket, key) { .then(info.getMultipleResponseValues); }; +// ## onionAuth +// A namespace for functions related to tor's ONION_CLIENT_AUTH_* commands. +let onionAuth = {}; + +// __onionAuth.add(controlSocket, hsAddress, b64PrivateKey, nickname, isPermanent)__. +// Sends a ONION_CLIENT_AUTH_ADD command to add a private key to the +// Tor configuration. +onionAuth.add = function (aControlSocket, hsAddress, b64PrivateKey, + nickname, isPermanent) { + const keyType = "x25519"; + let cmd = `onion_client_auth_add ${hsAddress} ${keyType}:${b64PrivateKey}`; + if (nickname) + cmd += ` ClientName=${nickname}`; + if (isPermanent) + cmd += " Flags=Permanent"; + return aControlSocket.sendCommand(cmd); +}; + // ## event // Handlers for events @@ -617,6 +649,9 @@ tor.controller = function (ipcFile, host, port, password, onError) { isOpen = true; return { getInfo : key => info.getInfo(socket, key), getConf : key => info.getConf(socket, key), + onionAuthAdd : (hsAddress, b64PrivateKey, nickname, isPermanent) => + onionAuth.add(socket, hsAddress, b64PrivateKey, + nickname, isPermanent), watchEvent : (type, filter, onData) => event.watchEvent(socket, type, filter, onData), isOpen : () => isOpen, @@ -626,29 +661,53 @@ tor.controller = function (ipcFile, host, port, password, onError) { // ## Export -// __controller(ipcFile, host, port, password, onError)__. -// Instantiates and returns a controller object connected to a tor ControlPort -// on ipcFile or at host:port, authenticating with the given password, if -// the controller doesn't yet exist. Otherwise returns the existing controller -// to the given ipcFile or host:port. +let controlPortInfo = {}; + +// __configureControlPortModule(ipcFile, host, port, password)__. +// Sets Tor control port connection parameters to be used in future calls to +// the controller() function. Example: +// configureControlPortModule(undefined, "127.0.0.1", 9151, "MyPassw0rd"); +var configureControlPortModule = function (ipcFile, host, port, password) { + controlPortInfo.ipcFile = ipcFile; + controlPortInfo.host = host; + controlPortInfo.port = port || 9151; + controlPortInfo.password = password; +}; + +// __controller(onError)__. +// Instantiates and returns a controller object that is connected and +// authenticated to a Tor ControlPort using the connection parameters +// provided in the most recent call to configureControlPortModule(), if +// the controller doesn't yet exist. Otherwise returns the existing +// controller to the given ipcFile or host:port. // onError is called with an error object as its single argument whenever // an error occurs. Example: // // // Get the controller -// let c = controller(undefined, "127.0.0.1", 9151, "MyPassw0rd", +// let c = controller( // function (error) { console.log(error.message || error); }); // // Send command and receive `250` reply or error message in a promise: // let replyPromise = c.getInfo("ip-to-country/16.16.16.16"); // // Close the controller permanently // c.close(); -var controller = function (ipcFile, host, port, password, onError) { - let dest = (ipcFile) ? "unix:" + ipcFile.path : host + ":" + port, - maybeController = tor.controllerCache[dest]; - return (tor.controllerCache[dest] = - (maybeController && maybeController.isOpen()) ? - maybeController : - tor.controller(ipcFile, host, port, password, onError)); +var controller = function (onError) { + if (!controlPortInfo.ipcFile && !controlPortInfo.host) + throw new Error("Please call configureControlPortModule first"); + + const dest = (controlPortInfo.ipcFile) + ? `unix:${controlPortInfo.ipcFile.path}` + : `${controlPortInfo.host}:${controlPortInfo.port}`; + const maybeController = tor.controllerCache[dest]; + if (maybeController && maybeController.isOpen()) + return maybeController; + + tor.controllerCache[dest] = tor.controller(controlPortInfo.ipcFile, + controlPortInfo.host, + controlPortInfo.port, + controlPortInfo.password, + onError); + return tor.controllerCache[dest]; }; -// Export the controller function for external use. -var EXPORTED_SYMBOLS = ["controller"]; +// Export functions for external use. +var EXPORTED_SYMBOLS = ["configureControlPortModule", "controller"];

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 548177579c14a34a72f374ec783005f04cfde100 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Oct 21 18:20:42 2019 +0200 fixup! TB4: Tor Browser's Firefox preference overrides. --- browser/app/profile/000-tor-browser.js | 58 ++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 9f2537df5557..d02b4e13a2d9 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -347,6 +347,64 @@ pref("browser.download.forward_oma_android_download_manager", false); #expand pref("torbrowser.version", __TOR_BROWSER_VERSION_QUOTED__); +// Old torbutton prefs + +// debug prefs +pref("extensions.torbutton.loglevel",4); +pref("extensions.torbutton.logmethod",1); // 0=stdout, 1=errorconsole, 2=debuglog + +// Display prefs +pref("extensions.torbutton.display_circuit", true); +pref("extensions.torbutton(a)torproject.org.description", "chrome://torbutton/locale/torbutton.properties"); +pref("extensions.torbutton.updateNeeded", false); + +// Tor check and proxy prefs +pref("extensions.torbutton.test_enabled",true); +pref("extensions.torbutton.test_url","https://check.torproject.org/?TorButton=true"); +pref("extensions.torbutton.local_tor_check",true); +pref("extensions.torbutton.versioncheck_url","https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions"); +pref("extensions.torbutton.versioncheck_enabled",true); +pref("extensions.torbutton.use_nontor_proxy",false); + +// State prefs: +pref("extensions.torbutton.startup",false); +pref("extensions.torbutton.inserted_button",false); +pref("extensions.torbutton.inserted_security_level",false); + +// This is only used when letterboxing is disabled. +// See #7255 for details. We display the warning three times to make sure the +// user did not click on it by accident. +pref("extensions.torbutton.maximize_warnings_remaining", 3); + +// Security prefs: +pref("extensions.torbutton.clear_http_auth",true); +pref("extensions.torbutton.close_newnym",true); +pref("extensions.torbutton.resize_new_windows",false); +pref("extensions.torbutton.startup_state", 2); // 0=non-tor, 1=tor, 2=last +pref("extensions.torbutton.tor_memory_jar",false); +pref("extensions.torbutton.nontor_memory_jar",false); +pref("extensions.torbutton.launch_warning",true); + +// Opt out of Firefox addon pings: +// https://developer.mozilla.org/en/Addons/Working_with_AMO +pref("extensions.torbutton(a)torproject.org.getAddons.cache.enabled", false); + +// Security Slider +pref("extensions.torbutton.security_slider", 4); +pref("extensions.torbutton.security_custom", false); + +pref("extensions.torbutton.confirm_plugins", true); +pref("extensions.torbutton.confirm_newnym", true); + +pref("extensions.torbutton.noscript_inited", false); +pref("extensions.torbutton.noscript_persist", false); + +// Browser home page: +pref("browser.startup.homepage", "about:tor"); + +// This pref specifies an ad-hoc "version" for various pref update hacks we need to do +pref("extensions.torbutton.pref_fixup_version", 0); + // If we are bundling fonts, whitelist those bundled fonts, and restrict system fonts to a selection. #ifdef MOZ_BUNDLED_FONTS

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! Bug 25741 - TBA: Add mozconfig for Android and pertinent branding files.
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit c2fafa4a2f8fa3ec005bafaab748861ecee49946 Author: Alex Catarineu <acat(a)torproject.org> Date: Wed Nov 13 12:47:29 2019 +0100 fixup! Bug 25741 - TBA: Add mozconfig for Android and pertinent branding files. --- mobile/android/app/000-tor-browser-android.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mobile/android/app/000-tor-browser-android.js b/mobile/android/app/000-tor-browser-android.js index 0017cb2d058a..db9e23063738 100644 --- a/mobile/android/app/000-tor-browser-android.js +++ b/mobile/android/app/000-tor-browser-android.js @@ -49,3 +49,6 @@ pref("intl.locale.requested", ""); // Disable WebAuthn. It requires Google Play Services, so it isn't // available, but avoid any potential problems. pref("security.webauth.webauthn_enable_android_fido2", false); + +// Disable the External App Blocker on Android +pref("extensions.torbutton.launch_warning", false);

1 0

[torbutton/master] Bug 30851: Move default preferences to 000-tor-browser.js
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 59cabca7ade54fa4f5fec2a398456dbc3891009a Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Jun 10 17:49:38 2019 +0200 Bug 30851: Move default preferences to 000-tor-browser.js --- chrome/content/locale/non-localized.properties | 6 --- components/domain-isolator.js | 3 -- components/dragDropFilter.js | 2 - components/startup-observer.js | 1 - components/torbutton-logger.js | 2 - defaults/preferences/preferences.js | 55 -------------------------- jar.mn | 1 - modules/default-prefs.js | 36 ----------------- moz.build | 3 -- 9 files changed, 109 deletions(-) diff --git a/chrome/content/locale/non-localized.properties b/chrome/content/locale/non-localized.properties deleted file mode 100644 index dca78639..00000000 --- a/chrome/content/locale/non-localized.properties +++ /dev/null @@ -1,6 +0,0 @@ -# This file must be located in a subdirectory named "locale" so that -# about:config will display the correct value for browser.startup.homepage. -# See fetchPref() inside toolkit/components/viewconfig/content/config.js - -# Default home page -browser.startup.homepage=about:tor diff --git a/components/domain-isolator.js b/components/domain-isolator.js index f6a6d598..3ed6e58f 100644 --- a/components/domain-isolator.js +++ b/components/domain-isolator.js @@ -15,9 +15,6 @@ const { XPCOMUtils } = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm let logger = Cc["@torproject.org/torbutton-logger;1"] .getService(Ci.nsISupports).wrappedJSObject; -let { ensureDefaultPrefs } = ChromeUtils.import("resource://torbutton/modules/default-prefs.js", {}); -ensureDefaultPrefs(); - // Import crypto object (FF 37+). Cu.importGlobalProperties(["crypto"]); diff --git a/components/dragDropFilter.js b/components/dragDropFilter.js index 9d6f74c8..f48d1b38 100644 --- a/components/dragDropFilter.js +++ b/components/dragDropFilter.js @@ -6,8 +6,6 @@ *************************************************************************/ -ChromeUtils.import("resource://torbutton/modules/default-prefs.js", {}).ensureDefaultPrefs(); - const { XPCOMUtils } = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm"); const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); diff --git a/components/startup-observer.js b/components/startup-observer.js index 008134f8..d2d1d610 100644 --- a/components/startup-observer.js +++ b/components/startup-observer.js @@ -21,7 +21,6 @@ XPCOMUtils.defineLazyModuleGetters(this, { L10nRegistry: "resource://gre/modules/L10nRegistry.jsm", }); -ChromeUtils.import("resource://torbutton/modules/default-prefs.js", {}).ensureDefaultPrefs(); let NoScriptControl = ChromeUtils.import("resource://torbutton/modules/noscript-control.js", {}); // Module specific constants diff --git a/components/torbutton-logger.js b/components/torbutton-logger.js index 52fdfc23..1c946fa7 100644 --- a/components/torbutton-logger.js +++ b/components/torbutton-logger.js @@ -13,8 +13,6 @@ const kMODULE_NAME = "Torbutton Logger"; const kMODULE_CONTRACTID = "@torproject.org/torbutton-logger;1"; const kMODULE_CID = Components.ID("f36d72c9-9718-4134-b550-e109638331d7"); -ChromeUtils.import("resource://torbutton/modules/default-prefs.js", {}).ensureDefaultPrefs(); - const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); const { XPCOMUtils } = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm"); diff --git a/defaults/preferences/preferences.js b/defaults/preferences/preferences.js deleted file mode 100644 index 100302b7..00000000 --- a/defaults/preferences/preferences.js +++ /dev/null @@ -1,55 +0,0 @@ -// debug prefs -pref("extensions.torbutton.loglevel",4); -pref("extensions.torbutton.logmethod",1); // 0=stdout, 1=errorconsole, 2=debuglog - -// Display prefs -pref("extensions.torbutton.display_circuit", true); -pref("extensions.torbutton(a)torproject.org.description", "chrome://torbutton/locale/torbutton.properties"); -pref("extensions.torbutton.updateNeeded", false); - -// Tor check and proxy prefs -pref("extensions.torbutton.test_enabled",true); -pref("extensions.torbutton.test_url","https://check.torproject.org/?TorButton=true"); -pref("extensions.torbutton.local_tor_check",true); -pref("extensions.torbutton.versioncheck_url","https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions"); -pref("extensions.torbutton.versioncheck_enabled",true); -pref("extensions.torbutton.use_nontor_proxy",false); - -// State prefs: -pref("extensions.torbutton.startup",false); -pref("extensions.torbutton.inserted_button",false); -pref("extensions.torbutton.inserted_security_level",false); - -// TODO: This is just part of a stopgap until #14429 gets properly implemented. -// See #7255 for details. We display the warning three times to make sure the -// user did not click on it by accident. -pref("extensions.torbutton.maximize_warnings_remaining", 3); - -// Security prefs: -pref("extensions.torbutton.clear_http_auth",true); -pref("extensions.torbutton.close_newnym",true); -pref("extensions.torbutton.resize_new_windows",false); -pref("extensions.torbutton.startup_state", 2); // 0=non-tor, 1=tor, 2=last -pref("extensions.torbutton.tor_memory_jar",false); -pref("extensions.torbutton.nontor_memory_jar",false); -pref("extensions.torbutton.launch_warning",true); - -// Opt out of Firefox addon pings: -// https://developer.mozilla.org/en/Addons/Working_with_AMO -pref("extensions.torbutton(a)torproject.org.getAddons.cache.enabled", false); - -// Security Slider -pref("extensions.torbutton.security_slider", 4); -pref("extensions.torbutton.security_custom", false); - -pref("extensions.torbutton.confirm_plugins", true); -pref("extensions.torbutton.confirm_newnym", true); - -pref("extensions.torbutton.noscript_inited", false); -pref("extensions.torbutton.noscript_persist", false); - -// Browser home page: -pref("browser.startup.homepage", "chrome://torbutton/content/locale/non-localized.properties"); - -// This pref specifies an ad-hoc "version" for various pref update hacks we need to do -pref("extensions.torbutton.pref_fixup_version", 0); diff --git a/jar.mn b/jar.mn index 8b6cbcf7..2c6d186b 100644 --- a/jar.mn +++ b/jar.mn @@ -6,7 +6,6 @@ torbutton.jar: content/ (chrome/content/*) components/ (components/*) - defaults/ (defaults/*) modules/ (modules/*) skin/ (chrome/skin/*) diff --git a/modules/default-prefs.js b/modules/default-prefs.js deleted file mode 100644 index 5ea549f4..00000000 --- a/modules/default-prefs.js +++ /dev/null @@ -1,36 +0,0 @@ -let loaded = false; - -function ensureDefaultPrefs () { - if (loaded) { - return; - } - const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); - const kDefaultPreferences = "resource://torbutton/defaults/preferences/preferences.js"; - const defaultPrefBranch = Services.prefs.getDefaultBranch(null); - - const context = { - pref: function (aPrefName, aValue) { - const aValueType = typeof aValue; - if (aValueType === "boolean") { - defaultPrefBranch.setBoolPref(aPrefName, aValue); - } else if (aValueType === "number") { - defaultPrefBranch.setIntPref(aPrefName, aValue); - } else if (aValueType === "string") { - defaultPrefBranch.setCharPref(aPrefName, aValue); - } else { - Services.console.logStringMessage( - `Preference ${aPrefName} with value ${aValue} has an invalid value type`); - } - - // Disable the External App Blocker on Android - if ((aPrefName === "extensions.torbutton.launch_warning") && - (Services.appinfo.OS === "Android")) { - defaultPrefBranch.setBoolPref(aPrefName, false); - } - } - }; - Services.scriptloader.loadSubScript(kDefaultPreferences, context); - loaded = true; -} - -let EXPORTED_SYMBOLS = ["ensureDefaultPrefs"]; diff --git a/moz.build b/moz.build index 843cee0d..376c9976 100644 --- a/moz.build +++ b/moz.build @@ -4,6 +4,3 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. JAR_MANIFESTS += ['jar.mn'] -JS_PREFERENCE_FILES += [ - 'defaults/preferences/preferences.js', -]

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! Bug 25658: Replace security slider with security level UI
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 39861885e9837439fab9e3bf7aece4a21271e64b Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Nov 18 12:13:00 2019 -0800 fixup! Bug 25658: Replace security slider with security level UI Fixes bug 32539. --- browser/components/securitylevel/content/securityLevel.js | 2 +- .../components/securitylevel/content/securityLevelPreferences.inc.xul | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/components/securitylevel/content/securityLevel.js b/browser/components/securitylevel/content/securityLevel.js index 7b3e7e4f92f9..2081eabb4176 100644 --- a/browser/components/securitylevel/content/securityLevel.js +++ b/browser/components/securitylevel/content/securityLevel.js @@ -334,7 +334,7 @@ const SecurityLevelPreferences = let groupbox = document.getElementById("securityLevel-groupbox"); let labelHeader = groupbox.querySelector("#securityLevel-header"); - labelHeader.setAttribute("value", TorStrings.securityLevel.securityLevel); + labelHeader.textContent = TorStrings.securityLevel.securityLevel; let spanOverview = groupbox.querySelector("#securityLevel-overview"); spanOverview.textContent = TorStrings.securityLevel.overview; diff --git a/browser/components/securitylevel/content/securityLevelPreferences.inc.xul b/browser/components/securitylevel/content/securityLevelPreferences.inc.xul index 0e68800e2766..a81b8d299789 100644 --- a/browser/components/securitylevel/content/securityLevelPreferences.inc.xul +++ b/browser/components/securitylevel/content/securityLevelPreferences.inc.xul @@ -1,5 +1,5 @@ <groupbox id="securityLevel-groupbox" data-category="panePrivacy" hidden="true"> - <caption><label id="securityLevel-header"/></caption> + <label><html:h2 id="securityLevel-header"/></label> <vbox data-subcategory="securitylevel" flex="1"> <description flex="1"> <html:span id="securityLevel-overview" class="tail-with-learn-more"/>

1 0

[torbutton/master] Bug 28745: Assume always running in Tor Browser
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 6b1a5ded2cab7e51aeb504483fa0d8fbf0cae957 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Jun 10 17:08:25 2019 +0200 Bug 28745: Assume always running in Tor Browser --- chrome/content/torbutton.js | 75 ++++++++----------------------------- defaults/preferences/preferences.js | 1 - 2 files changed, 15 insertions(+), 61 deletions(-) diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index 1537c54d..aacae042 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -40,8 +40,6 @@ var m_tb_confirming_plugins = false; var m_tb_window_height = window.outerHeight; var m_tb_window_width = window.outerWidth; -var m_tb_tbb = false; - var m_tb_control_ipc_file = null; // Set if using IPC (UNIX domain socket). var m_tb_control_port = null; // Set if using TCP. var m_tb_control_host = null; // Set if using TCP. @@ -247,7 +245,6 @@ function torbutton_init() { var cur_version; try { cur_version = m_tb_prefs.getCharPref("torbrowser.version"); - m_tb_tbb = true; torbutton_log(3, "This is a Tor Browser"); } catch(e) { torbutton_log(3, "This is not a Tor Browser: "+e); @@ -488,25 +485,6 @@ function torbutton_confirm_plugins() { } } -function torbutton_inform_about_tbb() { - var prompts = Services.prompt; - - var message = torbutton_get_property_string("torbutton.popup.prompt_torbrowser"); - var title = torbutton_get_property_string("torbutton.title.prompt_torbrowser"); - var checkbox = {value: false}; - - var sb = Services.strings; - var browserstrings = sb.createBundle("chrome://browser/locale/browser.properties"); - - var askagain = browserstrings.GetStringFromName("privateBrowsingNeverAsk"); - - var response = prompts.alertCheck(null, title, message, askagain, checkbox); - - // Update preferences to reflect their response and to prevent the prompt from - // being displayed again. - m_tb_prefs.setBoolPref("extensions.torbutton.prompt_torbrowser", !checkbox.value); -} - // Bug 1506 P2: It might be nice to let people move the button around, I guess? function torbutton_get_toolbutton() { var o_toolbutton = false; @@ -580,7 +558,7 @@ function torbutton_check_for_update() { // Bug 1506 P4: Checking for Tor Browser updates is pretty important, // probably even as a fallback if we ever do get a working updater. function torbutton_do_async_versioncheck() { - if (!m_tb_tbb || !m_tb_prefs.getBoolPref("extensions.torbutton.versioncheck_enabled")) { + if (!m_tb_prefs.getBoolPref("extensions.torbutton.versioncheck_enabled")) { return; } @@ -1405,21 +1383,19 @@ function torbutton_tor_check_ok() // // toggles plugins: true for disabled, false for enabled function torbutton_toggle_plugins(disable_plugins) { - if (m_tb_tbb) { - var PH=Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost); - var P=PH.getPluginTags({}); - for(var i=0; i<P.length; i++) { - if ("enabledState" in P[i]) { // FF24 - // FIXME: DOCDOC the reasoning for the isDisabled check, or remove it. - var isDisabled = (P[i].enabledState == Ci.nsIPluginTag.STATE_DISABLED); - if (!isDisabled && disable_plugins) - P[i].enabledState = Ci.nsIPluginTag.STATE_DISABLED; - else if (isDisabled && !disable_plugins) - P[i].enabledState = Ci.nsIPluginTag.STATE_CLICKTOPLAY; - } else if (P[i].disabled != disable_plugins) { // FF17 - P[i].disabled=disable_plugins; - } - } + var PH=Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost); + var P=PH.getPluginTags({}); + for(var i=0; i<P.length; i++) { + if ("enabledState" in P[i]) { // FF24 + // FIXME: DOCDOC the reasoning for the isDisabled check, or remove it. + var isDisabled = (P[i].enabledState == Ci.nsIPluginTag.STATE_DISABLED); + if (!isDisabled && disable_plugins) + P[i].enabledState = Ci.nsIPluginTag.STATE_DISABLED; + else if (isDisabled && !disable_plugins) + P[i].enabledState = Ci.nsIPluginTag.STATE_CLICKTOPLAY; + } else if (P[i].disabled != disable_plugins) { // FF17 + P[i].disabled=disable_plugins; + } } } @@ -1434,7 +1410,7 @@ function torbutton_update_disk_prefs() { // No way to clear this beast during New Identity. Leave it off. //m_tb_prefs.setBoolPref("dom.indexedDB.enabled", !mode); - if (m_tb_tbb) m_tb_prefs.setBoolPref("permissions.memory_only", mode); + m_tb_prefs.setBoolPref("permissions.memory_only", mode); // Third party abuse. Leave it off for now. //m_tb_prefs.setBoolPref("browser.cache.offline.enable", !mode); @@ -1535,10 +1511,6 @@ function torbutton_check_protections() document.getElementById("menu_newIdentity").disabled = true; document.getElementById("appMenuNewIdentity").disabled = true; } - - if (!m_tb_tbb && m_tb_prefs.getBoolPref("extensions.torbutton.prompt_torbrowser")) { - torbutton_inform_about_tbb(); - } } // -------------- HISTORY & COOKIES --------------------- @@ -1699,23 +1671,6 @@ function torbutton_do_startup() // Bug 30565: sync browser.privatebrowsing.autostart with security.nocertdb torbutton_update_disk_prefs(); - // #5758: Last ditch effort to keep Vanilla Torbutton users from totally - // being pwnt. This is a pretty darn ugly hack, too. But because of #5863, - // we really don't care about preserving the user's values for this. - if (!m_tb_tbb) { - // Bug 1506 P5: You have to set these two for non-TBB Firefoxen - m_tb_prefs.setBoolPref("network.websocket.enabled", false); - m_tb_prefs.setBoolPref("dom.indexedDB.enabled", false); - } - - // Still need this in case people shove this thing back into FF - if (!m_tb_tbb && m_tb_prefs.getBoolPref("extensions.torbutton.prompt_torbrowser")) { - var warning = torbutton_get_property_string("torbutton.popup.short_torbrowser"); - var title = torbutton_get_property_string("torbutton.title.prompt_torbrowser"); - var prompts = Services.prompt; - prompts.alert(null, title, warning); - } - // For general pref fixups to handle pref damage in older versions torbutton_fixup_old_prefs(); diff --git a/defaults/preferences/preferences.js b/defaults/preferences/preferences.js index 2d1bd99f..100302b7 100644 --- a/defaults/preferences/preferences.js +++ b/defaults/preferences/preferences.js @@ -42,7 +42,6 @@ pref("extensions.torbutton(a)torproject.org.getAddons.cache.enabled", false); pref("extensions.torbutton.security_slider", 4); pref("extensions.torbutton.security_custom", false); -pref("extensions.torbutton.prompt_torbrowser", true); pref("extensions.torbutton.confirm_plugins", true); pref("extensions.torbutton.confirm_newnym", true);

1 0

[tor-browser-build/master] Bug 25099: Set nightly version to tbb-nightly.$year.$month.$day
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 0f019cf3aa17c6b77bb8126a9c4bdf47886238cb Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Oct 7 18:16:06 2019 +0200 Bug 25099: Set nightly version to tbb-nightly.$year.$month.$day Include the current day in the nightly version number, so that each build gets a different version number. We get this version number using a perl function, and a "state" variable, so that the day when the build was started is used. This avoids issues when a build is started on a day but finishs on a different day. In the nightly directory, the builds are now stored using the version instead of just the date. We also allow overriding this version number by using the TORBROWSER_NIGHTLY_VERSION environment variable. This could be useful for example if you need to generate incremental mars for the version from the previous day. --- README | 2 +- projects/firefox/get-moz-build-date | 5 ++--- projects/release/config | 3 +-- rbm.conf | 9 ++++++++- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/README b/README index 6dc5112..d77a460 100644 --- a/README +++ b/README @@ -62,7 +62,7 @@ channel you want to build: You can find the build result in the directory release/unsigned/$version or alpha/unsigned/$version for release or alpha builds. The result of -nightly can be found in the nightly/$date directory. +nightly can be found in the nightly/$version directory. If you want to build for a specific platform only, append the platform name to the makefile target: diff --git a/projects/firefox/get-moz-build-date b/projects/firefox/get-moz-build-date index 4e55c92..e6989ff 100755 --- a/projects/firefox/get-moz-build-date +++ b/projects/firefox/get-moz-build-date @@ -6,9 +6,8 @@ use strict; die "wrong number of arguments" unless @ARGV == 2; my ($year, $version) = @ARGV; my $date; -if ($version eq 'tbb-nightly') { - my (undef, undef, undef, $day, $mon, $y) = localtime; - $date = sprintf("%d%02d%02d010101", $y + 1900, $mon + 1, $day); +if ($version =~ m/^tbb-nightly\.([^\.]+)\.([^\.]+)\.([^\.]+)$/) { + $date = sprintf("%d%02d%02d010101", $1, $2, $3); } else { my @v = split(/[\.ab]/, $version); push @v, '0' if @v < 4; diff --git a/projects/release/config b/projects/release/config index c705a6f..17db3d0 100644 --- a/projects/release/config +++ b/projects/release/config @@ -4,7 +4,6 @@ output_dir: release var: signed_status: unsigned - today: '[% USE date; date.format(format = "%Y-%m-%d") %]' publish_dir: '[% c("var/signed_status") %]/[% c("version") %]-[% c("var/torbrowser_build") %]' containers_target: with_containers @@ -74,7 +73,7 @@ targets: output_dir: 'nightly' var: build_target: nightly - publish_dir: '[% c("var/today") %]' + publish_dir: '[% c("version") %]' alpha: output_dir: alpha diff --git a/rbm.conf b/rbm.conf index 4a90ccc..f0ae4f9 100644 --- a/rbm.conf +++ b/rbm.conf @@ -147,7 +147,7 @@ targets: var: nightly: 1 channel: nightly - torbrowser_version: tbb-nightly + torbrowser_version: '[% ENV.TORBROWSER_NIGHTLY_VERSION ? ENV.TORBROWSER_NIGHTLY_VERSION : c("var_p/nightly_torbrowser_version") %]' torbrowser-testbuild: - testbuild @@ -508,5 +508,12 @@ ENV: my ($out) = capture_exec('sudo', 'runc', '--version'); return $out =~ m/^.*spec: 1\.[0-9]+\.[0-9]+(?:-dev)?$/m; }, + nightly_torbrowser_version => sub { + state $version = ''; + return $version if $version; + my (undef, undef, undef, $day, $mon, $year) = gmtime; + $version = sprintf("tbb-nightly.%u.%02u.%02u", $year + 1900, $mon + 1, $day); + return $version; + }, }, )

1 0

[tor-browser-build/master] Bug 25099: Remove the alpha_nightly target
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit 07ffaa91443f12ed53b0bbe9645c1f2666e9f39e Author: Nicolas Vigier <boklm(a)torproject.org> Date: Thu Nov 14 23:43:50 2019 +0100 Bug 25099: Remove the alpha_nightly target --- .gitignore | 1 - Makefile | 33 --------------------------------- README | 9 +-------- README.MAKEFILE | 11 ----------- projects/release/config | 6 ------ 5 files changed, 1 insertion(+), 59 deletions(-) diff --git a/.gitignore b/.gitignore index efd3840..8239960 100644 --- a/.gitignore +++ b/.gitignore @@ -4,7 +4,6 @@ /out /release /alpha -/alpha_nightly /nightly /testbuild /rbm.local.conf diff --git a/Makefile b/Makefile index 9f61bfb..6edb7e3 100644 --- a/Makefile +++ b/Makefile @@ -110,39 +110,6 @@ nightly-osx-x86_64: submodule-update nightly-src: submodule-update $(rbm) build release --target nightly --target torbrowser-src -alpha_nightly: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-all - -alpha_nightly-android-armv7: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-android-armv7 - -alpha_nightly-android-x86: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-android-x86 - -alpha_nightly-android-x86_64: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-android-x86_64 - -alpha_nightly-android-aarch64: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-android-aarch64 - -alpha_nightly-linux-x86_64: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-linux-x86_64 - -alpha_nightly-linux-i686: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-linux-i686 - -alpha_nightly-windows-i686: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-windows-i686 - -alpha_nightly-windows-x86_64: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-windows-x86_64 - -alpha_nightly-osx-x86_64: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-osx-x86_64 - -alpha_nightly-src: submodule-update - $(rbm) build release --target alpha_nightly --target torbrowser-src - testbuild: submodule-update $(rbm) build release --target testbuild --target torbrowser-all diff --git a/README b/README index 481db2e..6dc5112 100644 --- a/README +++ b/README @@ -59,17 +59,10 @@ channel you want to build: $ make release $ make alpha $ make nightly - $ make alpha_nightly You can find the build result in the directory release/unsigned/$version or alpha/unsigned/$version for release or alpha builds. The result of -nightly or alpha_nightly can be found in the nightly/$date or -alpha_nightly/$date directory. - -The alpha and alpha_nightly make target will build the same thing. The -only difference is the output directory. The alpha_nightly target can be -useful if you want to do a test build without polluting your alpha -directory. +nightly can be found in the nightly/$date directory. If you want to build for a specific platform only, append the platform name to the makefile target: diff --git a/README.MAKEFILE b/README.MAKEFILE index e106ca4..e07224e 100644 --- a/README.MAKEFILE +++ b/README.MAKEFILE @@ -36,17 +36,6 @@ nightly-{linux-x86_64,linux-i686,windows-i686,osx-x86_64,android-armv7, ----------------------------------------------------------------------- Same as nightly, for the selected platform only. -alpha_nightly -------------- -Build Tor Browser for the alpha channel, for all supported platforms. -This is the same as 'make alpha', but the output directory is different. -The resulting build can be found in directory alpha_nightly/$date - -alpha_nightly-{linux-x86_64,linux-i686,windows-i686,osx-x86_64,android-armv7, - android-x86,android-x86_64,android-aarch64} ------------------------------------------------------------------------------ -The same as alpha_nightly, for the selected platform only. - testbuild --------- Build a Tor Browser test build. To make the build faster, only the en-US diff --git a/projects/release/config b/projects/release/config index d1aee8c..c705a6f 100644 --- a/projects/release/config +++ b/projects/release/config @@ -76,12 +76,6 @@ targets: build_target: nightly publish_dir: '[% c("var/today") %]' - alpha_nightly: - output_dir: 'alpha_nightly' - var: - build_target: alpha - publish_dir: '[% c("var/today") %]' - alpha: output_dir: alpha var:

1 0

[tor-browser-build/master] Merge remote-tracking branch 'boklm/bug_25099_v10'
by gk＠torproject.org 19 Nov '19

19 Nov '19

commit da23c8cd79dab16f1848cacde60be0588c0d59a5 Merge: a750c93 0f019cf Author: Georg Koppen <gk(a)torproject.org> Date: Tue Nov 19 10:03:21 2019 +0000 Merge remote-tracking branch 'boklm/bug_25099_v10' .gitignore | 1 - Makefile | 33 --------------------------------- README | 9 +-------- README.MAKEFILE | 11 ----------- projects/firefox/get-moz-build-date | 5 ++--- projects/release/config | 9 +-------- rbm.conf | 9 ++++++++- 7 files changed, 12 insertions(+), 65 deletions(-)

1 0

[tor-browser-build/maint-9.0] Bump NoScript to 11.0.8
by gk＠torproject.org 18 Nov '19

18 Nov '19

commit a8066f0972088860ac44ebb66da5b3c036f47135 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Nov 18 08:43:36 2019 +0000 Bump NoScript to 11.0.8 Fixes #32362 and #32429 on our side --- projects/tor-browser/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/tor-browser/config b/projects/tor-browser/config index f78b4f8..908a6a1 100644 --- a/projects/tor-browser/config +++ b/projects/tor-browser/config @@ -73,9 +73,9 @@ input_files: enable: '[% c("var/snowflake") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.cdn.mozilla.net/user-media/addons/722/noscript_security_suit… + - URL: https://addons.cdn.mozilla.net/user-media/addons/722/noscript_security_suit… name: noscript - sha256sum: b068f8e1bd7d53e7a2d6959e5449621d0ae073c5f12271e027aad13a1e837961 + sha256sum: 0e3f0cfbf3563f0f6d6153d47833101b53e593ebcf6feee2e881d2516a4ce0c0 - filename: 'RelativeLink/start-tor-browser.desktop' enable: '[% c("var/linux") %]' - filename: 'RelativeLink/execdesktop'

1 0

[tor-browser-build/master] Bump NoScript to 11.0.8
by gk＠torproject.org 18 Nov '19

18 Nov '19

commit a750c9303469cd524c9091bbebca95a7905de912 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Nov 18 08:43:36 2019 +0000 Bump NoScript to 11.0.8 Fixes #32362 and #32429 on our side --- projects/tor-browser/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/tor-browser/config b/projects/tor-browser/config index 56c13bc..908a6a1 100644 --- a/projects/tor-browser/config +++ b/projects/tor-browser/config @@ -73,9 +73,9 @@ input_files: enable: '[% c("var/snowflake") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.cdn.mozilla.net/user-media/addons/722/noscript_security_suit… + - URL: https://addons.cdn.mozilla.net/user-media/addons/722/noscript_security_suit… name: noscript - sha256sum: bc7063510c201cdb32d4569ebed7cdac95e565dbe50dcae0a92a0233f80f747a + sha256sum: 0e3f0cfbf3563f0f6d6153d47833101b53e593ebcf6feee2e881d2516a4ce0c0 - filename: 'RelativeLink/start-tor-browser.desktop' enable: '[% c("var/linux") %]' - filename: 'RelativeLink/execdesktop'

1 0

[tor-browser-build/master] Bug 32509: Add comment explaining cbindgen vendoring
by boklm＠torproject.org 15 Nov '19

15 Nov '19

commit ead3b276006b68a7eecac3f29f09c1d4df76350c Author: Georg Koppen <gk(a)torproject.org> Date: Fri Nov 15 15:03:45 2019 +0000 Bug 32509: Add comment explaining cbindgen vendoring --- projects/cbindgen/config | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/cbindgen/config b/projects/cbindgen/config index 69014bf..ddfb9f9 100644 --- a/projects/cbindgen/config +++ b/projects/cbindgen/config @@ -11,5 +11,6 @@ input_files: - project: container-image - name: rust project: rust + # `cargo vendor vendor` in the `cbindgen` directory has vendored the sources. - URL: https://people.torproject.org/~boklm/mirrors/sources/cbindgen-vendor.tar.bz2 sha256sum: f4cde3d56df893b543b35b7e4a6e295a275dbb3cee8e8eae549efe679db50ab9

1 0

[tor-browser-build/master] Fold in stable changelog
by gk＠torproject.org 09 Nov '19

09 Nov '19

commit b27585dfd29b08977cc4dc7b9d27103b995466d6 Author: Georg Koppen <gk(a)torproject.org> Date: Sat Nov 9 07:20:29 2019 +0000 Fold in stable changelog --- .../tor-browser/Bundle-Data/Docs/ChangeLog.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index dda1936..d010aa3 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -33,6 +33,28 @@ Tor Browser 9.5a2 -- November 11 2019 * Android * Bug 28803: Integrate building Pluggable Transports for Android +Tor Browser 9.0.1 -- November 4 2019 + * All Platforms + * Update NoScript to 11.0.4 + * Bug 21004: Don't block JavaScript on onion services on medium security + * Bug 27307: NoScript marks HTTP onions as not secure + * Bug 30783: Fundraising banner for EOY 2019 campain + * Bug 32321: Don't ping Mozilla for Man-in-the-Middle-detection + * Bug 27268: Preferences clean-up + * Windows + OS X + Linux + * Update Tor Launcher to 0.2.20.2 + * Bug 32164: Trim each received log line from tor + * Translations update + * Bug 31803: Replaced about:debugging logo with flat version + * Bug 31764: Fix for error when navigating via 'Paste and go' + * Bug 32169: Fix TB9 Wikipedia address bar search + * Bug 32210: Hide the tor pane when using a system tor + * Bug 31658: Use builtin --panel-disabled-color for security level text + * Bug 32188: Fix localization on about:preferences#tor + * Bug 32184: Red dot is shown while downloading an update + * Android + * Bug 32342: Crash when changing the browser locale + Tor Browser 9.5a1 -- October 23 2019 * All Platforms * Update Firefox to 68.2.0esr

1 0

[tor-browser-build/master] Pick up changes for build6
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit 95bc7fde8230aab8fdb3cc87a1d8143f400c25e4 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 7 22:13:05 2019 +0000 Pick up changes for build6 --- projects/firefox/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 4 ++-- rbm.conf | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/firefox/config b/projects/firefox/config index 8c26eb9..3c57c71 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'firefox-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build4' +git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build5' tag_gpg_id: 1 git_url: https://git.torproject.org/tor-browser.git git_submodule: 1 diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index f8caf37..dda1936 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,4 +1,4 @@ -Tor Browser 9.5a2 -- November 8 2019 +Tor Browser 9.5a2 -- November 11 2019 * All Platforms * Update NoScript to 11.0.7 * Bug 21004: Don't block JavaScript on onion services on medium security @@ -7,6 +7,7 @@ Tor Browser 9.5a2 -- November 8 2019 * Bug 32321: Don't ping Mozilla for Man-in-the-Middle-detection * Bug 32318: Backport Mozilla's fix for bug 1534339 * Bug 32250: Backport enhanced letterboxing support (bug 1546832 and 1556017) + * Bug 31573: Catch SessionStore.jsm exception * Bug 27268: Preferences clean-up * Windows + OS X + Linux * Update Tor to 0.4.2.3-alpha @@ -29,7 +30,6 @@ Tor Browser 9.5a2 -- November 8 2019 * Build System * All Platforms * Bug 32413: Bump Go version to 1.12.13 - * Bug 32053: Compile Rust code with -O1 to avoid reproducibility issues * Android * Bug 28803: Integrate building Pluggable Transports for Android diff --git a/rbm.conf b/rbm.conf index c6da42c..4a90ccc 100644 --- a/rbm.conf +++ b/rbm.conf @@ -25,7 +25,7 @@ buildconf: var: torbrowser_version: '9.5a2' - torbrowser_build: 'build5' + torbrowser_build: 'build6' torbrowser_incremental_from: - 9.5a1 project_name: tor-browser

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Revert "Bug 32053: Work around Rust related reproducibility issues"
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit b223504c86b01d2e8d80daad4efe8f009e6b8879 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 7 22:07:02 2019 +0000 Revert "Bug 32053: Work around Rust related reproducibility issues" This reverts commit f1f9fa0286982d1fa486880ad6037e1e7a46457d as it would otherwise cause build bustage on Linux (see: #32426) --- Cargo.toml | 2 +- build/moz.configure/toolchain.configure | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index cb317e882847..7a0ba6d7abad 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -50,7 +50,7 @@ debug-assertions = true panic = "abort" [profile.release] -opt-level = 1 +opt-level = 2 rpath = false debug-assertions = false panic = "abort" diff --git a/build/moz.configure/toolchain.configure b/build/moz.configure/toolchain.configure index f5a6ea7b3bc3..3bcf403bceec 100755 --- a/build/moz.configure/toolchain.configure +++ b/build/moz.configure/toolchain.configure @@ -1876,8 +1876,8 @@ js_option(env='RUSTC_OPT_LEVEL', nargs=1, help='Rust compiler optimization level (-C opt-level=%s)') -# Use -O1 as a workaround for reproducibility issues for now, see #32053. -imply_option('RUSTC_OPT_LEVEL', '1', when='--enable-release') +# --enable-release kicks in full optimizations. +imply_option('RUSTC_OPT_LEVEL', '2', when='--enable-release') @depends('RUSTC_OPT_LEVEL', moz_optimize)

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Bug 31573: Catch SessionStore.jsm exception
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit 739c353b91d30238977a20b31b7ecf624c17006b Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 7 14:27:14 2019 +0000 Bug 31573: Catch SessionStore.jsm exception This is a backport of the fix for Mozilla's bug 1591259. --- dom/push/PushComponents.jsm | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dom/push/PushComponents.jsm b/dom/push/PushComponents.jsm index 99b1d2baffac..fb2a601bc88d 100644 --- a/dom/push/PushComponents.jsm +++ b/dom/push/PushComponents.jsm @@ -88,12 +88,28 @@ PushServiceBase.prototype = { } if (topic === "sessionstore-windows-restored") { Services.obs.removeObserver(this, "sessionstore-windows-restored"); - this._handleReady(); + try { + this._handleReady(); + } catch (ex) { + // NS_ERROR_NOT_AVAILABLE will get thrown for the PushService getter + // if the PushService is disabled. + if (ex.result != Cr.NS_ERROR_NOT_AVAILABLE) { + throw ex; + } + } return; } if (topic === "android-push-service") { // Load PushService immediately. - this._handleReady(); + try { + this._handleReady(); + } catch (ex) { + // NS_ERROR_NOT_AVAILABLE will get thrown for the PushService getter + // if the PushService is disabled. + if (ex.result != Cr.NS_ERROR_NOT_AVAILABLE) { + throw ex; + } + } } },

1 0

[tor-browser-build/master] Pick up changes for build5
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit cc4d8a1a74c1def3c0921e59763d09864d72bc77 Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 7 10:27:20 2019 +0000 Pick up changes for build5 --- projects/firefox/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 13 +++++++++++-- rbm.conf | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/projects/firefox/config b/projects/firefox/config index 1af3014..8c26eb9 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'firefox-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build3' +git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build4' tag_gpg_id: 1 git_url: https://git.torproject.org/tor-browser.git git_submodule: 1 diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 6240fdc..f8caf37 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,6 +1,6 @@ -Tor Browser 9.5a2 -- November 6 2019 +Tor Browser 9.5a2 -- November 8 2019 * All Platforms - * Update NoScript to 11.0.4 + * Update NoScript to 11.0.7 * Bug 21004: Don't block JavaScript on onion services on medium security * Bug 27307: NoScript marks HTTP onions as not secure * Bug 30783: Fundraising banner for EOY 2019 campain @@ -21,8 +21,17 @@ Tor Browser 9.5a2 -- November 6 2019 * Bug 32188: Fix localization on about:preferences#tor * Bug 32184: Red dot is shown while downloading an update * Bug 27604: Fix broken Tor Browser after moving it to a different directory + * Bug 32220: Improve the letterboxing experience + * Bug 30683: Backport upstreamed fix from Mozilla (bug 1581537) * Android * Bug 32342: Crash when changing the browser locale + * Bug 32303: Obfs4 is broken on Android Q + * Build System + * All Platforms + * Bug 32413: Bump Go version to 1.12.13 + * Bug 32053: Compile Rust code with -O1 to avoid reproducibility issues + * Android + * Bug 28803: Integrate building Pluggable Transports for Android Tor Browser 9.5a1 -- October 23 2019 * All Platforms diff --git a/rbm.conf b/rbm.conf index aaa6e3a..c6da42c 100644 --- a/rbm.conf +++ b/rbm.conf @@ -25,7 +25,7 @@ buildconf: var: torbrowser_version: '9.5a2' - torbrowser_build: 'build4' + torbrowser_build: 'build5' torbrowser_incremental_from: - 9.5a1 project_name: tor-browser

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Bug 32053: Work around Rust related reproducibility issues
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit f1f9fa0286982d1fa486880ad6037e1e7a46457d Author: Georg Koppen <gk(a)torproject.org> Date: Thu Nov 7 07:53:53 2019 +0000 Bug 32053: Work around Rust related reproducibility issues --- Cargo.toml | 2 +- build/moz.configure/toolchain.configure | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 7a0ba6d7abad..cb317e882847 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -50,7 +50,7 @@ debug-assertions = true panic = "abort" [profile.release] -opt-level = 2 +opt-level = 1 rpath = false debug-assertions = false panic = "abort" diff --git a/build/moz.configure/toolchain.configure b/build/moz.configure/toolchain.configure index 3bcf403bceec..f5a6ea7b3bc3 100755 --- a/build/moz.configure/toolchain.configure +++ b/build/moz.configure/toolchain.configure @@ -1876,8 +1876,8 @@ js_option(env='RUSTC_OPT_LEVEL', nargs=1, help='Rust compiler optimization level (-C opt-level=%s)') -# --enable-release kicks in full optimizations. -imply_option('RUSTC_OPT_LEVEL', '2', when='--enable-release') +# Use -O1 as a workaround for reproducibility issues for now, see #32053. +imply_option('RUSTC_OPT_LEVEL', '1', when='--enable-release') @depends('RUSTC_OPT_LEVEL', moz_optimize)

1 0

[tor-browser-build/master] Bug 28803: Integrate building Pluggable Transports for Android
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit eee5d30a9ab1d727caac262cb62f72aaab75e0a0 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Thu Oct 31 01:52:21 2019 +0000 Bug 28803: Integrate building Pluggable Transports for Android We integrate building Pluggable Transports for Android to solve #32303 in particular later on but it is important for providing snowflake support as well at some point (see: #28672) The bulk of the patch got written by boklm when trying to provide snowflake support for Android (#28672). --- .../go/0001-Use-fixed-go-build-tmp-directory.patch | 33 ++++++++++++++++++++ projects/go/build | 12 ++++---- projects/go/config | 30 +++++++++++++++++-- projects/gobsaes/config | 9 ++++++ ...BILE_TMPDIR-env-variable-is-defined-use-t.patch | 35 ++++++++++++++++++++++ projects/gomobile/config | 33 ++++++++++++++++++++ projects/goptlib/config | 8 +++++ projects/goutls/config | 9 ++++++ projects/goxexp/config | 19 ++++++++++++ projects/goximage/config | 28 +++++++++++++++++ projects/goxnet/config | 9 ++++++ projects/obfs4/build | 4 +++ projects/obfs4/config | 3 ++ projects/tor-onion-proxy-library/build | 10 +++++++ projects/tor-onion-proxy-library/config | 2 ++ rbm.conf | 6 ++++ 16 files changed, 241 insertions(+), 9 deletions(-) diff --git a/projects/go/0001-Use-fixed-go-build-tmp-directory.patch b/projects/go/0001-Use-fixed-go-build-tmp-directory.patch new file mode 100644 index 0000000..a10e059 --- /dev/null +++ b/projects/go/0001-Use-fixed-go-build-tmp-directory.patch @@ -0,0 +1,33 @@ +From 44e3391a5a3d9a2c4b57f78e43414465ab84681e Mon Sep 17 00:00:00 2001 +From: Nicolas Vigier <boklm(a)torproject.org> +Date: Thu, 27 Jun 2019 19:21:05 +0200 +Subject: [PATCH] Use fixed go-build tmp directory + +Use fixed go-build tmp directory, when the directory does not exist, in +order to avoid some reproducibility issues where build directory gets +embedded in generated binaries. +--- + src/cmd/go/internal/work/action.go | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go +index 1f91046eb1..ba74b26a38 100644 +--- a/src/cmd/go/internal/work/action.go ++++ b/src/cmd/go/internal/work/action.go +@@ -224,9 +224,13 @@ func (b *Builder) Init() { + if cfg.BuildN { + b.WorkDir = "$WORK" + } else { +- tmp, err := ioutil.TempDir(os.Getenv("GOTMPDIR"), "go-build") +- if err != nil { +- base.Fatalf("go: creating work dir: %v", err) ++ tmp := filepath.Join(os.Getenv("GOTMPDIR"), "go-build-workdir") ++ _, err := os.Stat(tmp) ++ if !os.IsNotExist(err) { ++ tmp, err = ioutil.TempDir(os.Getenv("GOTMPDIR"), "go-build") ++ if err != nil { ++ base.Fatalf("go: creating work dir: %v", err) ++ } + } + if !filepath.IsAbs(tmp) { + abs, err := filepath.Abs(tmp) diff --git a/projects/go/build b/projects/go/build index 4945c88..aa092d6 100644 --- a/projects/go/build +++ b/projects/go/build @@ -28,6 +28,9 @@ export GOROOT_BOOTSTRAP="/var/tmp/build/go1.4" cd $rootdir [% IF ! c("var/linux") %] [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + # http://golang.org/doc/install/source#environment + export GOOS=[% c("var/GOOS") %] + export GOARCH=[% c("var/GOARCH") %] [% END %] # Building go @@ -48,9 +51,6 @@ cd /var/tmp/dist/go/src echo "#!/bin/sh" > "$CC_FOR_TARGET" echo "exec $CC $CFLAGS $LDFLAGS \"\$@\"" >> "$CC_FOR_TARGET" chmod +x "$CC_FOR_TARGET" - # http://golang.org/doc/install/source#environment - export GOOS=darwin - export GOARCH=amd64 # faketime is needed because clang 3.9.1 on Darwin embeds the timestamps of # certain intermediate object files (including those that arise here while # compiling the Go runtime itself). Without this, variable timestamps would @@ -65,10 +65,10 @@ cd /var/tmp/dist/go/src echo "#!/bin/sh" > "$CC_FOR_TARGET" echo "exec [% c("arch") %]-w64-mingw32-gcc [% c("var/CFLAGS") %] [% c("var/LDFLAGS") %] \"\$@\"" >> "$CC_FOR_TARGET" chmod +x "$CC_FOR_TARGET" - # http://golang.org/doc/install/source#environment - export GOOS=windows - export GOARCH=[% c("var/GOARCH") %] CGO_ENABLED=1 CC_FOR_TARGET="$CC_FOR_TARGET" CC= CFLAGS= LDFLAGS= ./make.bash +[% ELSIF c("var/android") -%] + patch -p2 < $rootdir/0001-Use-fixed-go-build-tmp-directory.patch + CGO_ENABLED=1 CC_FOR_TARGET=[% c("var/CC") %] CGO_CFLAGS='-D__ANDROID_API__=[% c("var/android_min_api") %]' CC= CFLAGS= LDFLAGS= ./make.bash [% END -%] cd /var/tmp/dist diff --git a/projects/go/config b/projects/go/config index ffe07ea..31c510a 100644 --- a/projects/go/config +++ b/projects/go/config @@ -10,8 +10,13 @@ var: setup: | mkdir -p /var/tmp/dist tar -C /var/tmp/dist -xf $rootdir/[% c("go_tarfile") %] - export GOOS=[% c("var/GOOS") %] - export GOARCH=[% c("var/GOARCH") %] + [% IF pc(c("origin_project"), "var/no_crosscompile") -%] + export GOOS=linux + export GOARCH=amd64 + [% ELSE -%] + export GOOS=[% c("var/GOOS") %] + export GOARCH=[% c("var/GOARCH") %] + [% END -%] export GOPATH=/var/tmp/dist/gopath export PATH=/var/tmp/dist/go/bin:/var/tmp/dist/gopath/bin:"$PATH" [% IF c("var/linux") -%] @@ -21,6 +26,8 @@ var: [% IF c("var/linux-i686") -%] export CGO_ENABLED=1 [% END -%] + export GOTMPDIR=/var/tmp/build/go-tmp + mkdir -p "$GOTMPDIR" # Template build script for building a go library. # This can be called as projects/go/var/build_go_lib. @@ -82,15 +89,32 @@ targets: linux-i686: var: GOARCH: 386 + android: + var: + GOOS: android + android-x86: + var: + GOARCH: 386 + android-x86_64: + var: + GOARCH: amd64 + android-armv7: + var: + GOARCH: arm + android-aarch64: + var: + GOARCH: arm64 input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - enable: '[% c("var/windows") || c("var/osx") %]' + enable: '[% ! c("var/linux") %]' - URL: 'https://golang.org/dl/go[% c("version") %].src.tar.gz' name: go sha256sum: ab0e56ed9c4732a653ed22e232652709afbf573e710f56a07f7fdeca578d62fc - URL: 'https://golang.org/dl/go[% c("var/go14_version") %].src.tar.gz' name: go14 sha256sum: 9947fc705b0b841b5938c48b22dc33e9647ec0752bae66e50278df4f23f64959 + - filename: 0001-Use-fixed-go-build-tmp-directory.patch + enable: '[% c("var/android") %]' diff --git a/projects/gobsaes/config b/projects/gobsaes/config index 4da5828..0ced258 100644 --- a/projects/gobsaes/config +++ b/projects/gobsaes/config @@ -11,7 +11,16 @@ var: use_container: 1 go_lib: git.schwanenlied.me/yawning/bsaes.git +targets: + android: + var: + build_go_lib_pre: | + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + input_files: - project: container-image - name: go project: go + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + enable: '[% c("var/android") %]' diff --git a/projects/gomobile/0001-If-the-GOMOBILE_TMPDIR-env-variable-is-defined-use-t.patch b/projects/gomobile/0001-If-the-GOMOBILE_TMPDIR-env-variable-is-defined-use-t.patch new file mode 100644 index 0000000..770b22a --- /dev/null +++ b/projects/gomobile/0001-If-the-GOMOBILE_TMPDIR-env-variable-is-defined-use-t.patch @@ -0,0 +1,35 @@ +From 188307b6acd5003e82cb68872da9463f5f707515 Mon Sep 17 00:00:00 2001 +From: Nicolas Vigier <boklm(a)torproject.org> +Date: Thu, 27 Jun 2019 12:46:38 +0200 +Subject: [PATCH] If the GOMOBILE_TMPDIR env variable is defined, use that as + tmpdir + +Having the option to select a fixed tmpdir makes it possible to have +reproducible builds, as the build directory is embedded in the generated +executables. +--- + cmd/gomobile/env.go | 11 ++++++++--- + 1 file changed, 8 insertions(+), 3 deletions(-) + +diff --git a/cmd/gomobile/env.go b/cmd/gomobile/env.go +index 471b009..b97141b 100644 +--- a/cmd/gomobile/env.go ++++ b/cmd/gomobile/env.go +@@ -61,9 +61,14 @@ func buildEnvInit() (cleanup func(), err error) { + tmpdir = "$WORK" + cleanupFn = func() {} + } else { +- tmpdir, err = ioutil.TempDir("", "gomobile-work-") +- if err != nil { +- return nil, err ++ gomobile_tmpdir := os.Getenv("GOMOBILE_TMPDIR") ++ if gomobile_tmpdir != "" { ++ tmpdir = gomobile_tmpdir ++ } else { ++ tmpdir, err = ioutil.TempDir("", "gomobile-work-") ++ if err != nil { ++ return nil, err ++ } + } + } + if buildX { diff --git a/projects/gomobile/config b/projects/gomobile/config new file mode 100644 index 0000000..9dbfc29 --- /dev/null +++ b/projects/gomobile/config @@ -0,0 +1,33 @@ +# vim: filetype=yaml sw=2 +version: '[% c("abbrev") %]' +git_url: https://github.com/golang/mobile +git_hash: 92f3b9caf7ba8f4f9c10074225afcba0cba47a62 +filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' + +build: '[% c("projects/go/var/build_go_lib") %]' + +var: + container: + use_container: 1 + no_crosscompile: 1 + go_lib: golang.org/x/mobile + go_lib_deps: + - goximage + - goxexp + go_lib_install: + - golang.org/x/mobile/cmd/gobind + - golang.org/x/mobile/cmd/gomobile + build_go_lib_pre: | + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + +input_files: + - project: container-image + - name: go + project: go + - name: goximage + project: goximage + - name: goxexp + project: goxexp + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + - filename: 0001-If-the-GOMOBILE_TMPDIR-env-variable-is-defined-use-t.patch diff --git a/projects/goptlib/config b/projects/goptlib/config index 8c2a95d..4dfc6ff 100644 --- a/projects/goptlib/config +++ b/projects/goptlib/config @@ -18,7 +18,15 @@ targets: version: master tag_gpg_id: 0 + android: + var: + build_go_lib_pre: | + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + input_files: - project: container-image - name: go project: go + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + enable: '[% c("var/android") %]' diff --git a/projects/goutls/config b/projects/goutls/config index fa4b5d8..7a46517 100644 --- a/projects/goutls/config +++ b/projects/goutls/config @@ -17,6 +17,12 @@ var: - gocompress - gobsaes +targets: + android: + var: + build_go_lib_pre: | + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + input_files: - project: container-image - name: go @@ -28,3 +34,6 @@ input_files: - name: gobsaes project: gobsaes - filename: sessionid.patch + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + enable: '[% c("var/android") %]' diff --git a/projects/goxexp/config b/projects/goxexp/config new file mode 100644 index 0000000..c81a65f --- /dev/null +++ b/projects/goxexp/config @@ -0,0 +1,19 @@ +# vim: filetype=yaml sw=2 +version: '[% c("abbrev") %]' +git_url: https://github.com/golang/exp +git_hash: a1d7652674e8f269b17d9be90d3c4c1d0e8830e8 +filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' + +build: '[% c("projects/go/var/build_go_lib") %]' + +var: + container: + use_container: 1 + no_crosscompile: 1 + go_lib: golang.org/x/exp + go_lib_install: [] + +input_files: + - project: container-image + - name: go + project: go diff --git a/projects/goximage/config b/projects/goximage/config new file mode 100644 index 0000000..308a1ba --- /dev/null +++ b/projects/goximage/config @@ -0,0 +1,28 @@ +# vim: filetype=yaml sw=2 +version: '[% c("abbrev") %]' +git_url: https://github.com/golang/image +git_hash: 0694c2d4d067f97ebef574d63a763ee8ab559da7 +filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' + +build: '[% c("projects/go/var/build_go_lib") %]' + +var: + container: + use_container: 1 + no_crosscompile: 1 + go_lib: golang.org/x/image + go_lib_install: + - golang.org/x/image/webp + - golang.org/x/image/bmp + - golang.org/x/image/draw + - golang.org/x/image/font + - golang.org/x/image/math/fixed + - golang.org/x/image/math/f32 + - golang.org/x/image/math/f64 + - golang.org/x/image/vp8 + - golang.org/x/image/vp8l + +input_files: + - project: container-image + - name: go + project: go diff --git a/projects/goxnet/config b/projects/goxnet/config index f6a2c29..5394875 100644 --- a/projects/goxnet/config +++ b/projects/goxnet/config @@ -16,9 +16,18 @@ var: go_lib_deps: - goxsys +targets: + android: + var: + build_go_lib_pre: | + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] + input_files: - project: container-image - name: go project: go - name: goxsys project: goxsys + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + enable: '[% c("var/android") %]' diff --git a/projects/obfs4/build b/projects/obfs4/build index 33b0add..53b83df 100644 --- a/projects/obfs4/build +++ b/projects/obfs4/build @@ -5,6 +5,10 @@ distdir=/var/tmp/dist/[% project %] [% c("var/set_PTDIR_DOCSDIR") -%] mkdir -p $PTDIR +[% IF c("var/android") -%] + [% pc(c('var/compiler'), 'var/setup', { compiler_tarfile => c('input_files_by_name/' _ c('var/compiler')) }) %] +[% END -%] + tar -C /var/tmp/dist -xf [% c('input_files_by_name/goptlib') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/ed25519') %] tar -C /var/tmp/dist -xf [% c('input_files_by_name/siphash') %] diff --git a/projects/obfs4/config b/projects/obfs4/config index d9357bb..21bdab6 100644 --- a/projects/obfs4/config +++ b/projects/obfs4/config @@ -36,3 +36,6 @@ input_files: project: goutls - name: goxtext project: goxtext + - name: '[% c("var/compiler") %]' + project: '[% c("var/compiler") %]' + enable: '[% c("var/android") %]' diff --git a/projects/tor-onion-proxy-library/build b/projects/tor-onion-proxy-library/build index 0b949a3..0f2d976 100644 --- a/projects/tor-onion-proxy-library/build +++ b/projects/tor-onion-proxy-library/build @@ -22,6 +22,16 @@ cd /var/tmp/build/[% project %]-[% c('version') %] patch -p1 < $rootdir/gradle.patch patch -p1 < $rootdir/canceldormant.patch +# Extract obfs4proxy from TorBrowser/Tor/PluggableTransports/obfs4proxy +tar --strip-components=4 -xf $rootdir/[% c('input_files_by_name/obfs4') %] + +# Overwrite the obfs4proxy binary provided by Pluto +for d in external/pluto/bin/*; do + cp obfs4proxy $d/ +done + +rm obfs4proxy + # Build Android Libraries and Apps $GRADLE_HOME/gradle-4.10.2/bin/gradle --offline --no-daemon -P androidplugin=3.1.0 -Dmaven.repo.local=$gradle_repo assembleRelease -x lint diff --git a/projects/tor-onion-proxy-library/config b/projects/tor-onion-proxy-library/config index c2bd1a4..ff3432c 100644 --- a/projects/tor-onion-proxy-library/config +++ b/projects/tor-onion-proxy-library/config @@ -25,6 +25,8 @@ input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' + - project: obfs4 + name: obfs4 - filename: 'gradle-dependencies-[% c("var/gradle_dependencies_version") %]' name: gradle-dependencies exec: '[% INCLUDE "fetch-gradle-dependencies" %]' diff --git a/rbm.conf b/rbm.conf index 727c09f..aaa6e3a 100644 --- a/rbm.conf +++ b/rbm.conf @@ -183,6 +183,7 @@ targets: var: android-armv7: 1 osname: android-armv7 + toolchain_arch: arm torbrowser-android-x86: - android-x86 - android @@ -191,6 +192,7 @@ targets: var: android-x86: 1 osname: android-x86 + toolchain_arch: x86 torbrowser-android-x86_64: - android-x86_64 - android @@ -199,6 +201,7 @@ targets: var: android-x86_64: 1 osname: android-x86_64 + toolchain_arch: x86_64 torbrowser-android-aarch64: - android-aarch64 - android @@ -207,6 +210,7 @@ targets: var: android-aarch64: 1 osname: android-aarch64 + toolchain_arch: arm64 android: var: android: 1 @@ -219,6 +223,8 @@ targets: android_min_api_x86: 16 android_min_api_x86_64: 21 snowflake: 0 + CC: '$ANDROID_NDK_HOME/[% c("var/toolchain_arch") %]/bin/clang' + CXX: '$ANDROID_NDK_HOME/[% c("var/toolchain_arch") %]/bin/clang++' container: suite: stretch arch: amd64

1 0

[tor-browser-build/master] Bug 32303: Fix broken obfs4 on Android Q
by gk＠torproject.org 07 Nov '19

07 Nov '19

commit 878a3855c2b7fc5146cd8c38d2b25a7ed427c7e9 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Sat Oct 26 17:15:20 2019 +0000 Bug 32303: Fix broken obfs4 on Android Q Backport go patch #29674 that drops the TLS section on Android. --- .../90a3ce02dc25adcf1598faf11a66b151ada3f637.patch | 57 ++++++++++++++++++++++ projects/go/build | 2 + projects/go/config | 2 + 3 files changed, 61 insertions(+) diff --git a/projects/go/90a3ce02dc25adcf1598faf11a66b151ada3f637.patch b/projects/go/90a3ce02dc25adcf1598faf11a66b151ada3f637.patch new file mode 100644 index 0000000..dc66809 --- /dev/null +++ b/projects/go/90a3ce02dc25adcf1598faf11a66b151ada3f637.patch @@ -0,0 +1,57 @@ +From 90a3ce02dc25adcf1598faf11a66b151ada3f637 Mon Sep 17 00:00:00 2001 +From: Elias Naur <mail(a)eliasnaur.com> +Date: Wed, 27 Mar 2019 14:25:24 +0100 +Subject: [PATCH] cmd/link/internal/ld: skip TLS section on Android + +We don't use the TLS section on android, and dropping it avoids +complaints about underalignment from the Android Q linker. + +Updates #29674 + +Change-Id: I91dabf2a58e6eb1783872639a6a144858db09cef +Reviewed-on: https://go-review.googlesource.com/c/go/+/169618 +Reviewed-by: Ian Lance Taylor <iant(a)golang.org> +--- + src/cmd/link/internal/ld/lib.go | 29 +++++++++++++++++------------ + 1 file changed, 17 insertions(+), 12 deletions(-) + +diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go +index 1d44c0eb18b..b331e39fe3e 100644 +--- a/src/cmd/link/internal/ld/lib.go ++++ b/src/cmd/link/internal/ld/lib.go +@@ -453,18 +453,23 @@ func (ctxt *Link) loadlib() { + } + } + +- tlsg := ctxt.Syms.Lookup("runtime.tlsg", 0) +- +- // runtime.tlsg is used for external linking on platforms that do not define +- // a variable to hold g in assembly (currently only intel). +- if tlsg.Type == 0 { +- tlsg.Type = sym.STLSBSS +- tlsg.Size = int64(ctxt.Arch.PtrSize) +- } else if tlsg.Type != sym.SDYNIMPORT { +- Errorf(nil, "runtime declared tlsg variable %v", tlsg.Type) +- } +- tlsg.Attr |= sym.AttrReachable +- ctxt.Tlsg = tlsg ++ // The Android Q linker started to complain about underalignment of the our TLS ++ // section. We don't actually use the section on android, so dont't ++ // generate it. ++ if objabi.GOOS != "android" { ++ tlsg := ctxt.Syms.Lookup("runtime.tlsg", 0) ++ ++ // runtime.tlsg is used for external linking on platforms that do not define ++ // a variable to hold g in assembly (currently only intel). ++ if tlsg.Type == 0 { ++ tlsg.Type = sym.STLSBSS ++ tlsg.Size = int64(ctxt.Arch.PtrSize) ++ } else if tlsg.Type != sym.SDYNIMPORT { ++ Errorf(nil, "runtime declared tlsg variable %v", tlsg.Type) ++ } ++ tlsg.Attr |= sym.AttrReachable ++ ctxt.Tlsg = tlsg ++ } + + var moduledata *sym.Symbol + if ctxt.BuildMode == BuildModePlugin { diff --git a/projects/go/build b/projects/go/build index aa092d6..2ebfd58 100644 --- a/projects/go/build +++ b/projects/go/build @@ -68,6 +68,8 @@ cd /var/tmp/dist/go/src CGO_ENABLED=1 CC_FOR_TARGET="$CC_FOR_TARGET" CC= CFLAGS= LDFLAGS= ./make.bash [% ELSIF c("var/android") -%] patch -p2 < $rootdir/0001-Use-fixed-go-build-tmp-directory.patch + # Obfs4 breaks on Android Q without this patch, see: #32303 + patch -p2 < $rootdir/90a3ce02dc25adcf1598faf11a66b151ada3f637.patch CGO_ENABLED=1 CC_FOR_TARGET=[% c("var/CC") %] CGO_CFLAGS='-D__ANDROID_API__=[% c("var/android_min_api") %]' CC= CFLAGS= LDFLAGS= ./make.bash [% END -%] diff --git a/projects/go/config b/projects/go/config index 31c510a..cf95b90 100644 --- a/projects/go/config +++ b/projects/go/config @@ -118,3 +118,5 @@ input_files: sha256sum: 9947fc705b0b841b5938c48b22dc33e9647ec0752bae66e50278df4f23f64959 - filename: 0001-Use-fixed-go-build-tmp-directory.patch enable: '[% c("var/android") %]' + - filename: 90a3ce02dc25adcf1598faf11a66b151ada3f637.patch + enable: '[% c("var/android") %]'

1 0