- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][maint-14.0] 2 commits: Bug 41142: Add no_crosscompile to linux-cross host tools and clang
by Pier Angelo Vendrame (＠pierov) 17 Oct '24

17 Oct '24

Pier Angelo Vendrame pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: cb3ba59c by NoisyCoil at 2024-10-17T13:37:29+02:00 Bug 41142: Add no_crosscompile to linux-cross host tools and clang - - - - - c10878fd by NoisyCoil at 2024-10-17T13:37:29+02:00 Bug 41142: Add the linux-aarch64 target to Rust - - - - - 7 changed files: - projects/clang/config - projects/cmake/config - projects/ninja/config - projects/node/config - projects/python/config - … [View More]projects/rust/config - projects/wasi-sysroot/config Changes: ===================================== projects/clang/config ===================================== @@ -6,15 +6,20 @@ container: var: llvm_version: '[% pc("llvm-project", "version") %]' + no_crosscompile: 1 input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' enable: '[% c("var/linux") %]' + # Override the target to make sure we don't have linux-cross - name: binutils project: binutils enable: '[% c("var/linux") %]' + target: + - '[% c("var/channel") %]' + - '[% c("var/projectname") %]-linux-x86_64' - project: cmake name: cmake - project: llvm-project ===================================== projects/cmake/config ===================================== @@ -7,6 +7,8 @@ gpg_keyring: cmake.gpg filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 +var: + no_crosscompile: 1 input_files: - project: container-image ===================================== projects/ninja/config ===================================== @@ -5,6 +5,8 @@ git_hash: a524bf3f6bacd1b4ad85d719eed2737d8562f27a #v1.11.1 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 +var: + no_crosscompile: 1 input_files: - project: container-image ===================================== projects/node/config ===================================== @@ -6,15 +6,20 @@ container: var: node_version: 18.19.0 node_sha256: f52b41af20596a9abd8ed75241837ec43945468221448bbf841361e2091819b6 + no_crosscompile: 1 input_files: - URL: 'https://nodejs.org/dist/v[% c("var/node_version") %]/node-v[% c("var/node_version") %].tar.xz' sha256sum: '[% c("var/node_sha256") %]' name: node - project: container-image + # Override the target to make sure we don't have linux-cross - project: binutils name: binutils enable: '[% c("var/linux") %]' + target: + - '[% c("var/channel") %]' + - '[% c("var/projectname") %]-linux-x86_64' - project: '[% c("var/compiler") %]' name: '[% c("var/compiler") %]' enable: '[% c("var/linux") %]' ===================================== projects/python/config ===================================== @@ -4,6 +4,7 @@ filename: 'python-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 var: + no_crosscompile: 1 deps: - build-essential - python-all ===================================== projects/rust/config ===================================== @@ -19,6 +19,11 @@ targets: target: i686-unknown-linux-gnu target_flags: --set target.i686-unknown-linux-gnu.linker=clang --set target.i686-unknown-linux-gnu.ar=llvm-ar --set target.i686-unknown-linux-gnu.ranlib=llvm-ranlib + linux-aarch64: + var: + target: aarch64-unknown-linux-gnu + target_flags: --set target.aarch64-unknown-linux-gnu.linker=aarch64-linux-gnu-gcc --set target.aarch64-unknown-linux-gnu.ar=llvm-ar --set target.aarch64-unknown-linux-gnu.ranlib=llvm-ranlib + macos: var: target: '[% c("var/build_target") %]' ===================================== projects/wasi-sysroot/config ===================================== @@ -12,6 +12,9 @@ git_submodule: 0 container: use_container: 1 +var: + no_crosscompile: 1 + input_files: - project: container-image # We do not use GCC, but we need its libsdc++ to run Clang View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41142: Add no_crosscompile to linux-cross host tools and clang
by boklm (＠boklm) 17 Oct '24

17 Oct '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cb3ba59c by NoisyCoil at 2024-10-17T13:37:29+02:00 Bug 41142: Add no_crosscompile to linux-cross host tools and clang - - - - - c10878fd by NoisyCoil at 2024-10-17T13:37:29+02:00 Bug 41142: Add the linux-aarch64 target to Rust - - - - - 7 changed files: - projects/clang/config - projects/cmake/config - projects/ninja/config - projects/node/config - projects/python/config - projects/rust/config - … [View More]projects/wasi-sysroot/config Changes: ===================================== projects/clang/config ===================================== @@ -6,15 +6,20 @@ container: var: llvm_version: '[% pc("llvm-project", "version") %]' + no_crosscompile: 1 input_files: - project: container-image - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' enable: '[% c("var/linux") %]' + # Override the target to make sure we don't have linux-cross - name: binutils project: binutils enable: '[% c("var/linux") %]' + target: + - '[% c("var/channel") %]' + - '[% c("var/projectname") %]-linux-x86_64' - project: cmake name: cmake - project: llvm-project ===================================== projects/cmake/config ===================================== @@ -7,6 +7,8 @@ gpg_keyring: cmake.gpg filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 +var: + no_crosscompile: 1 input_files: - project: container-image ===================================== projects/ninja/config ===================================== @@ -5,6 +5,8 @@ git_hash: a524bf3f6bacd1b4ad85d719eed2737d8562f27a #v1.11.1 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 +var: + no_crosscompile: 1 input_files: - project: container-image ===================================== projects/node/config ===================================== @@ -6,15 +6,20 @@ container: var: node_version: 18.19.0 node_sha256: f52b41af20596a9abd8ed75241837ec43945468221448bbf841361e2091819b6 + no_crosscompile: 1 input_files: - URL: 'https://nodejs.org/dist/v[% c("var/node_version") %]/node-v[% c("var/node_version") %].tar.xz' sha256sum: '[% c("var/node_sha256") %]' name: node - project: container-image + # Override the target to make sure we don't have linux-cross - project: binutils name: binutils enable: '[% c("var/linux") %]' + target: + - '[% c("var/channel") %]' + - '[% c("var/projectname") %]-linux-x86_64' - project: '[% c("var/compiler") %]' name: '[% c("var/compiler") %]' enable: '[% c("var/linux") %]' ===================================== projects/python/config ===================================== @@ -4,6 +4,7 @@ filename: 'python-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 var: + no_crosscompile: 1 deps: - build-essential - python-all ===================================== projects/rust/config ===================================== @@ -19,6 +19,11 @@ targets: target: i686-unknown-linux-gnu target_flags: --set target.i686-unknown-linux-gnu.linker=clang --set target.i686-unknown-linux-gnu.ar=llvm-ar --set target.i686-unknown-linux-gnu.ranlib=llvm-ranlib + linux-aarch64: + var: + target: aarch64-unknown-linux-gnu + target_flags: --set target.aarch64-unknown-linux-gnu.linker=aarch64-linux-gnu-gcc --set target.aarch64-unknown-linux-gnu.ar=llvm-ar --set target.aarch64-unknown-linux-gnu.ranlib=llvm-ranlib + macos: var: target: '[% c("var/build_target") %]' ===================================== projects/wasi-sysroot/config ===================================== @@ -12,6 +12,9 @@ git_submodule: 0 container: use_container: 1 +var: + no_crosscompile: 1 + input_files: - project: container-image # We do not use GCC, but we need its libsdc++ to run Clang View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][base-browser-115.16.0esr-13.5-1] Bug 42467: Make OS HTTP User-Agent OS spoofing configurable by pref
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch base-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: bd216fff by Pier Angelo Vendrame at 2024-10-16T22:27:14+00:00 Bug 42467: Make OS HTTP User-Agent OS spoofing configurable by pref This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - 2 changed files: - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/… [View More]resistfingerprinting/nsRFPService.cpp Changes: ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -497,6 +497,9 @@ nsresult nsHttpHandler::Init() { // obsService->AddObserver(this, "net:failed-to-process-uri-content", true); } + Preferences::AddWeakObserver( + this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); + MakeNewRequestTokenBucket(); mWifiTickler = new Tickler(); if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr; @@ -2064,6 +2067,9 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, // Inform nsIOService that network is tearing down. gIOService->SetHttpHandlerAlreadyShutingDown(); + Preferences::RemoveObserver( + this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); + ShutdownConnectionManager(); // need to reset the session start time since cache validation may @@ -2189,6 +2195,11 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, ShutdownConnectionManager(); mConnMgr = nullptr; Unused << InitConnectionMgr(); + } else if (!strcmp(topic, "nsPref:changed") && + !NS_strcmp( + data, + u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) { + nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); } return NS_OK; ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -939,12 +939,17 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent + const bool spoofOs = + isForHTTPHeader && + Preferences::GetBool( + "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); + // These magic numbers are the lengths of the UA string literals below. // Assume three-digit Firefox version numbers so we have room to grow. size_t preallocatedLength = 13 + - (isForHTTPHeader ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) - : mozilla::ArrayLength(SPOOFED_UA_OS)) - + (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) + : mozilla::ArrayLength(SPOOFED_UA_OS)) - 1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + 2; userAgent.SetCapacity(preallocatedLength); @@ -954,7 +959,7 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0" userAgent.AssignLiteral("Mozilla/5.0 ("); - if (isForHTTPHeader) { + if (spoofOs) { userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS); } else { userAgent.AppendLiteral(SPOOFED_UA_OS); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bd216ff… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bd216ff… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.16.0esr-13.5-1] 2 commits: Bug 42467: Make OS HTTP User-Agent OS spoofing configurable by pref
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch tor-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 8ae4a172 by Pier Angelo Vendrame at 2024-10-16T22:24:59+00:00 Bug 42467: Make OS HTTP User-Agent OS spoofing configurable by pref This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - 39263a40 by Morgan at 2024-10-16T22:25:12+00:00 fixup! Bug 40562: Added Tor Browser preferences … [View More]to 000-tor-browser.js Bug 43170: Disable user-agent spoofing in HTTP header - - - - - 3 changed files: - browser/app/profile/000-tor-browser.js - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -52,6 +52,8 @@ pref("network.http.connection-retry-timeout", 0); // be reduced to the strictly required time). pref("extensions.torbutton.use_nontor_proxy", false); +// tor-browser#42647: Make OS HTTP User-Agent OS spoofing configurable by pref +pref("privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); // Browser home page: pref("browser.startup.homepage", "about:tor"); ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -497,6 +497,9 @@ nsresult nsHttpHandler::Init() { // obsService->AddObserver(this, "net:failed-to-process-uri-content", true); } + Preferences::AddWeakObserver( + this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); + MakeNewRequestTokenBucket(); mWifiTickler = new Tickler(); if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr; @@ -2064,6 +2067,9 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, // Inform nsIOService that network is tearing down. gIOService->SetHttpHandlerAlreadyShutingDown(); + Preferences::RemoveObserver( + this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); + ShutdownConnectionManager(); // need to reset the session start time since cache validation may @@ -2189,6 +2195,11 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, ShutdownConnectionManager(); mConnMgr = nullptr; Unused << InitConnectionMgr(); + } else if (!strcmp(topic, "nsPref:changed") && + !NS_strcmp( + data, + u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) { + nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); } return NS_OK; ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -939,12 +939,17 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent + const bool spoofOs = + isForHTTPHeader && + Preferences::GetBool( + "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); + // These magic numbers are the lengths of the UA string literals below. // Assume three-digit Firefox version numbers so we have room to grow. size_t preallocatedLength = 13 + - (isForHTTPHeader ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) - : mozilla::ArrayLength(SPOOFED_UA_OS)) - + (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) + : mozilla::ArrayLength(SPOOFED_UA_OS)) - 1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + 2; userAgent.SetCapacity(preallocatedLength); @@ -954,7 +959,7 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0" userAgent.AssignLiteral("Mozilla/5.0 ("); - if (isForHTTPHeader) { + if (spoofOs) { userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS); } else { userAgent.AppendLiteral(SPOOFED_UA_OS); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/10897e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/10897e… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] Bug 43101: Deep link to the startup security warning explanation.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 5d608b10 by hackademix at 2024-10-16T22:11:51+00:00 Bug 43101: Deep link to the startup security warning explanation. - - - - - 1 changed file: - security/sandbox/common/SandboxUtils.sys.mjs Changes: ===================================== security/sandbox/common/SandboxUtils.sys.mjs ===================================== @@ -37,7 +37,7 @@ export var SandboxUtils = { … [View More]

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] Bug 43101: Deep link to the startup security warning explanation.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 7a7678d2 by hackademix at 2024-10-16T22:11:05+00:00 Bug 43101: Deep link to the startup security warning explanation. - - - - - 1 changed file: - security/sandbox/common/SandboxUtils.sys.mjs Changes: ===================================== security/sandbox/common/SandboxUtils.sys.mjs ===================================== @@ -37,7 +37,7 @@ export var SandboxUtils = { … [View More]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] Bug 43101: Deep link to the startup security warning explanation.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 91952ef5 by hackademix at 2024-10-16T23:58:58+02:00 Bug 43101: Deep link to the startup security warning explanation. - - - - - 1 changed file: - security/sandbox/common/SandboxUtils.sys.mjs Changes: ===================================== security/sandbox/common/SandboxUtils.sys.mjs ===================================== @@ -37,7 +37,7 @@ export var SandboxUtils = { let … [View More]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: e231e8a4 by hackademix at 2024-10-16T21:54:08+00:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 43217: Do not round letterboxing corners in fullscreen. - - - - - 1 changed file: - browser/base/content/browser.css Changes: ===================================== browser/base/content/browser.css ===================================== @@ -113,6 +113,11 … [View More]

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: b5bb3a75 by hackademix at 2024-10-16T21:53:32+00:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 43217: Do not round letterboxing corners in fullscreen. - - - - - 1 changed file: - browser/base/content/browser.css Changes: ===================================== browser/base/content/browser.css ===================================== @@ -113,6 +113,11 @@ … [View More]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e17547a9 by hackademix at 2024-10-16T23:28:06+02:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 43217: Do not round letterboxing corners in fullscreen. - - - - - 1 changed file: - browser/base/content/browser.css Changes: ===================================== browser/base/content/browser.css ===================================== @@ -113,6 +113,11 @@ … [View More]

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.3.0esr-14.0-1-build5
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed new tag tor-browser-128.3.0esr-14.0-1-build5 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new branch maint-14.0
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed new branch maint-14.0 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mai… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 16 Oct '24

16 Oct '24

ma1 pushed to branch mullvad-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: c893bf36 by Andreas Farre at 2024-10-16T14:46:55+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/… [View More]nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3509,17 +3509,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3531,13 +3543,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/c89… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/c89… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][base-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 16 Oct '24

16 Oct '24

ma1 pushed to branch base-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: d2d5566b by Andreas Farre at 2024-10-16T14:46:47+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/… [View More]nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3507,17 +3507,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3529,13 +3541,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d2d5566… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d2d5566… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 666891c7 by stransky at 2024-10-15T22:24:49+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/… [View More]nsWindow.cpp ===================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/666… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/666… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e9810c42 by stransky at 2024-10-15T22:22:35+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/nsWindow.cpp … [View More]===================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9810c4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9810c4… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 15 Oct '24

15 Oct '24

ma1 pushed to branch tor-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 10897e71 by Andreas Farre at 2024-10-15T22:08:54+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/… [View More]nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3571,17 +3571,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3593,13 +3605,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/10897e7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/10897e7… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 53e645fe by stransky at 2024-10-15T21:56:36+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/nsWindow.cpp =… [View More]==================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53e645f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53e645f… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5.8-build1
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed new tag tbb-13.5.8-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41271: Prepare Tor Browser 13.5.8
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 329a359c by Pier Angelo Vendrame at 2024-10-14T19:40:11+02:00 Bug 41271: Prepare Tor Browser 13.5.8 - - - - - 6 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/allowed_addons.json - projects/browser/config - projects/firefox-android/config - projects/translation/config - rbm.conf Changes: ===================================== projects/… [View More]

1 0

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.5-1-build16
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed new tag firefox-android-115.2.1-13.5-1-build16 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41267: Downgrade go to 1.22 series due to upstream dropping support for macOS 10.15 in 1.23
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: b152b726 by Morgan at 2024-10-10T23:26:31+00:00 Bug 41267: Downgrade go to 1.22 series due to upstream dropping support for macOS 10.15 in 1.23 - - - - - 1 changed file: - projects/go/config Changes: ===================================== projects/go/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: '1.23.2' +version: '1.22.8' … [View More]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] fixup! [android] Disable features and functionality
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: c06f972b by cypherpunks1 at 2024-10-14T14:16:47+00:00 fixup! [android] Disable features and functionality Bug 43202: Do not fetch featured addons on Android - - - - - 2 changed files: - mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt - mobile/android/android-components/components/feature/… [View More]addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt Changes: ===================================== mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt ===================================== @@ -78,7 +78,7 @@ class AddonManager( * the [addonsProvider] or querying web extension state from the engine / store. */ @Throws(AddonManagerException::class) - @Suppress("TooGenericExceptionCaught") + @Suppress("TooGenericExceptionCaught", "UNUSED_PARAMETER") suspend fun getAddons(waitForPendingActions: Boolean = true, allowCache: Boolean = true): List<Addon> { try { // Make sure extension support is initialized, i.e. the state of all installed extensions is known. @@ -92,6 +92,7 @@ class AddonManager( // Get all the featured add-ons not installed from provider. // NB: We're keeping translations only for the default locale. var featuredAddons = emptyList<Addon>() + /* tor-browser#40502: Do not recommend addons on Tor Browser try { val userLanguage = Locale.getDefault().language val locales = listOf(userLanguage) @@ -103,6 +104,7 @@ class AddonManager( // Do not throw when we fail to fetch the featured add-ons since there can be installed add-ons. logger.warn("Failed to get the featured add-ons", throwable) } + */ // Build a list of installed extensions that are not built-in extensions. val installedAddons = installedExtensions ===================================== mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt ===================================== @@ -410,7 +410,7 @@ class AddonsManagerAdapter( } // Add recommended section and addons if available - if (false) { // recommendedAddons.isNotEmpty() tor-browser#40502: Do not recommend addons on Tor Browser + if (recommendedAddons.isNotEmpty()) { itemsWithSections.add(Section(R.string.mozac_feature_addons_recommended_section, true)) val filteredRecommendedAddons = recommendedAddons.filter { it.id !in excludedAddonIDs View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c06f972… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c06f972… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] 3 commits: Bug 1906024 - Format download file names better a=diannaS
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: a21f2f46 by rahulsainani at 2024-10-14T16:09:10+02:00 Bug 1906024 - Format download file names better a=diannaS Original Revision: https://phabricator.services.mozilla.com/D220559 Differential Revision: https://phabricator.services.mozilla.com/D222254 - - - - - f5ad7ff5 by rahulsainani at 2024-10-14T16:09:12+02:00 Bug 1906024 - Format download file names a=… [View More]diannaS Original Revision: https://phabricator.services.mozilla.com/D221771 Differential Revision: https://phabricator.services.mozilla.com/D222259 - - - - - 24a0b664 by Pier Angelo Vendrame at 2024-10-14T16:09:12+02:00 Bug 43196: Remove the vendor name from media notifications on Linux. Firefox shows "vendor remoteName" as a title of the "... is playing media" notification on Linux. However, for our browser the remote name is enough, and prepending the vendor to it creates a string users usually never see. - - - - - 3 changed files: - mobile/android/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt - mobile/android/android-components/components/support/ktx/src/test/java/mozilla/components/support/ktx/kotlin/StringTest.kt - widget/gtk/MPRISServiceHandler.cpp Changes: ===================================== mobile/android/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt ===================================== @@ -53,6 +53,8 @@ const val MAX_URI_LENGTH = 25000 private const val FILE_PREFIX = "file://" private const val MAX_VALID_PORT = 65_535 +private const val SPACE = " " +private const val UNDERSCORE = "_" /** * Shortens URLs to be more user friendly. @@ -307,7 +309,9 @@ fun String.sanitizeFileName(): String { file.name.replace("\\.\\.+".toRegex(), ".") } else { file.name.replace(".", "") - }.replaceEscapedCharacters() + }.replaceContinuousSpaces() + .replaceEscapedCharacters() + .trim() } /** @@ -315,8 +319,16 @@ fun String.sanitizeFileName(): String { * and is correctly displayed. */ private fun String.replaceEscapedCharacters(): String { - val controlCharactersRegex = "[\\x00-\\x13/*\"?<>:|\\\\]".toRegex() - return replace(controlCharactersRegex, "_") + val escapedCharactersRegex = "[\\x00-\\x13*\"?<>:|\\\\]".toRegex() + return replace(escapedCharactersRegex, UNDERSCORE) +} + +/** + * Replaces continuous spaces with a single space. + */ +private fun String.replaceContinuousSpaces(): String { + val escapedCharactersRegex = "[\\p{Z}\\s]+".toRegex() + return replace(escapedCharactersRegex, SPACE) } /** ===================================== mobile/android/android-components/components/support/ktx/src/test/java/mozilla/components/support/ktx/kotlin/StringTest.kt ===================================== @@ -199,11 +199,11 @@ class StringTest { "acknowledge\u0006signal" to "acknowledge_signal", "bell\u0007sound" to "bell_sound", "back\u0008space" to "back_space", - "horizontal\u0009tab" to "horizontal_tab", - "new\u000Aline" to "new_line", - "vertical\u000Btab" to "vertical_tab", - "form\u000Cfeed" to "form_feed", - "return\u000Dcarriage" to "return_carriage", + "horizontal\u0009tab" to "horizontal tab", + "new\u000Aline" to "new line", + "vertical\u000Btab" to "vertical tab", + "form\u000Cfeed" to "form feed", + "return\u000Dcarriage" to "return carriage", "shift\u000Eout" to "shift_out", "shift\u000Fin" to "shift_in", "escape\u0010data" to "escape_data", ===================================== widget/gtk/MPRISServiceHandler.cpp ===================================== @@ -414,8 +414,10 @@ void MPRISServiceHandler::InitIdentity() { do_GetService("@mozilla.org/xre/app-info;1", &rv); MOZ_ASSERT(NS_SUCCEEDED(rv)); +#ifndef BASE_BROWSER_VERSION rv = appInfo->GetVendor(mIdentity); MOZ_ASSERT(NS_SUCCEEDED(rv)); +#endif if (gAppData) { mDesktopEntry = gAppData->remotingName; @@ -424,7 +426,9 @@ void MPRISServiceHandler::InitIdentity() { MOZ_ASSERT(NS_SUCCEEDED(rv)); } +#ifndef BASE_BROWSER_VERSION mIdentity.Append(' '); +#endif mIdentity.Append(mDesktopEntry); // Compute the desktop entry name like nsAppRunner does for g_set_prgname View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2a… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] 3 commits: Bug 1906024 - Format download file names better a=diannaS
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: febfa1bf by rahulsainani at 2024-10-14T16:07:55+02:00 Bug 1906024 - Format download file names better a=diannaS Original Revision: https://phabricator.services.mozilla.com/D220559 Differential Revision: https://phabricator.services.mozilla.com/D222254 - - - - - 0caad63c by rahulsainani at 2024-10-14T16:08:09+02:00 Bug 1906024 - Format download file names a=… [View More]diannaS Original Revision: https://phabricator.services.mozilla.com/D221771 Differential Revision: https://phabricator.services.mozilla.com/D222259 - - - - - 796fd9d6 by Pier Angelo Vendrame at 2024-10-14T16:08:30+02:00 Bug 43196: Remove the vendor name from media notifications on Linux. Firefox shows "vendor remoteName" as a title of the "... is playing media" notification on Linux. However, for our browser the remote name is enough, and prepending the vendor to it creates a string users usually never see. - - - - - 3 changed files: - mobile/android/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt - mobile/android/android-components/components/support/ktx/src/test/java/mozilla/components/support/ktx/kotlin/StringTest.kt - widget/gtk/MPRISServiceHandler.cpp Changes: ===================================== mobile/android/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt ===================================== @@ -53,6 +53,8 @@ const val MAX_URI_LENGTH = 25000 private const val FILE_PREFIX = "file://" private const val MAX_VALID_PORT = 65_535 +private const val SPACE = " " +private const val UNDERSCORE = "_" /** * Shortens URLs to be more user friendly. @@ -307,7 +309,9 @@ fun String.sanitizeFileName(): String { file.name.replace("\\.\\.+".toRegex(), ".") } else { file.name.replace(".", "") - }.replaceEscapedCharacters() + }.replaceContinuousSpaces() + .replaceEscapedCharacters() + .trim() } /** @@ -315,8 +319,16 @@ fun String.sanitizeFileName(): String { * and is correctly displayed. */ private fun String.replaceEscapedCharacters(): String { - val controlCharactersRegex = "[\\x00-\\x13/*\"?<>:|\\\\]".toRegex() - return replace(controlCharactersRegex, "_") + val escapedCharactersRegex = "[\\x00-\\x13*\"?<>:|\\\\]".toRegex() + return replace(escapedCharactersRegex, UNDERSCORE) +} + +/** + * Replaces continuous spaces with a single space. + */ +private fun String.replaceContinuousSpaces(): String { + val escapedCharactersRegex = "[\\p{Z}\\s]+".toRegex() + return replace(escapedCharactersRegex, SPACE) } /** ===================================== mobile/android/android-components/components/support/ktx/src/test/java/mozilla/components/support/ktx/kotlin/StringTest.kt ===================================== @@ -199,11 +199,11 @@ class StringTest { "acknowledge\u0006signal" to "acknowledge_signal", "bell\u0007sound" to "bell_sound", "back\u0008space" to "back_space", - "horizontal\u0009tab" to "horizontal_tab", - "new\u000Aline" to "new_line", - "vertical\u000Btab" to "vertical_tab", - "form\u000Cfeed" to "form_feed", - "return\u000Dcarriage" to "return_carriage", + "horizontal\u0009tab" to "horizontal tab", + "new\u000Aline" to "new line", + "vertical\u000Btab" to "vertical tab", + "form\u000Cfeed" to "form feed", + "return\u000Dcarriage" to "return carriage", "shift\u000Eout" to "shift_out", "shift\u000Fin" to "shift_in", "escape\u0010data" to "escape_data", ===================================== widget/gtk/MPRISServiceHandler.cpp ===================================== @@ -414,8 +414,10 @@ void MPRISServiceHandler::InitIdentity() { do_GetService("@mozilla.org/xre/app-info;1", &rv); MOZ_ASSERT(NS_SUCCEEDED(rv)); +#ifndef BASE_BROWSER_VERSION rv = appInfo->GetVendor(mIdentity); MOZ_ASSERT(NS_SUCCEEDED(rv)); +#endif if (gAppData) { mDesktopEntry = gAppData->remotingName; @@ -424,7 +426,9 @@ void MPRISServiceHandler::InitIdentity() { MOZ_ASSERT(NS_SUCCEEDED(rv)); } +#ifndef BASE_BROWSER_VERSION mIdentity.Append(' '); +#endif mIdentity.Append(mDesktopEntry); // Compute the desktop entry name like nsAppRunner does for g_set_prgname View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bdea24… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bdea24… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0