boklm pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
516907ba by Nicolas Vigier at 2024-11-27T13:48:56+01:00
Bug 41325: Exclude Applications symlink when extracting dmg file in dmg2mar
Recent versions of 7z fail to extract our dmg files since the
`Applications` symlink points outside the archive:
https://sourceforge.net/p/sevenzip/discussion/45797/thread/9f5b067368/?page…
We exclude the `Applications` symlink to avoid the issue. We don't need
it since it is not included in the mar file.
- - - - -
1 changed file:
- tools/dmg2mar
Changes:
=====================================
tools/dmg2mar
=====================================
@@ -132,6 +132,7 @@ sub convert_files {
$pm->start($step_name) and next;
my $tmpdir = File::Temp->newdir();
my (undef, $err, $success) = capture_exec('7z', 'x', "-o$tmpdir",
+ '-x!*/Applications',
$file->{filename});
exit_error "Error extracting $file->{filename}: $err" unless $success;
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch mullvad-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
baa314e0 by Morgan at 2024-11-26T20:42:18+00:00
fixup! MB 188: Customize Gitlab Issue and Merge templates
update Sign and Tag step to use the sign-tag script in tor-browser-build
- - - - -
2 changed files:
- .gitlab/issue_templates/Rebase Browser - Alpha.md
- .gitlab/issue_templates/Rebase Browser - Stable.md
Changes:
=====================================
.gitlab/issue_templates/Rebase Browser - Alpha.md
=====================================
@@ -78,6 +78,9 @@
### **Sign and Tag**
- [ ] Sign/Tag `HEAD` of the merged `mullvad-browser` branch:
- - **Tag**: `mullvad-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based stable`
- - [ ] Push tag to `upstream`
+ - In **mullvad-browser.git**, checkout the new alpha `mullvad-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.mullvadbrowser alpha build1
+ ```
+ - [ ] Push tag to `upstream`
\ No newline at end of file
=====================================
.gitlab/issue_templates/Rebase Browser - Stable.md
=====================================
@@ -79,6 +79,9 @@
### **Sign and Tag**
- [ ] Sign/Tag `HEAD` of the merged `mullvad-browser` branch:
- - **Tag**: `mullvad-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based stable`
+ - In **mullvad-browser.git**, checkout the new stable `mullvad-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.mullvadbrowser stable build1
+ ```
- [ ] Push tag to `upstream`
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/baa…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/baa…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
e4c970bb by Morgan at 2024-11-26T20:39:29+00:00
fixup! Bug 41649: Create rebase and security backport gitlab issue templates
Add legacy rebase template and replace signing step with sign-tag script invocation in tor-browser-buildl
- - - - -
3 changed files:
- .gitlab/issue_templates/Rebase Browser - Alpha.md
- + .gitlab/issue_templates/Rebase Browser - Legacy.md
- .gitlab/issue_templates/Rebase Browser - Stable.md
Changes:
=====================================
.gitlab/issue_templates/Rebase Browser - Alpha.md
=====================================
@@ -131,17 +131,23 @@
### **Sign and Tag**
- [ ] Sign/Tag `HEAD` of the merged `tor-browser` branch:
- - **Tag**: `tor-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based alpha`
+ - In **tor-browser.git**, checkout the new alpha `tor-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.torbrowser alpha build1
+ ```
- [ ] Push tag to `upstream`
- [ ] Sign/Tag HEAD of the merged `base-browser` branch:
- - **Tag**: `base-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based alpha`
+ - In **tor-browser.git**, checkout the new alpha `base-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.basebrowser alpha build1
+ ```
- [ ] Push tag to `upstream`
-- [ ] Update tor-browser-build's main (no MR required, you can just push it if you have the permissions)
+- [ ] Update tor-browser-build's `main` branch (no MR required, you can just push it if you have the permissions)
- [ ] Update `projects/firefox/config`
- [ ] Update `firefox_platform_version`
- [ ] Set `browser_build` to 1 (to prevent failures in alpha testbuilds)
- [ ] Update `projects/geckoview/config`
- - [ ] Update `geckoview_version`
- - [ ] Set `browser_build` to 1
+ - [ ] Update `firefox_platform_version`
+ - [ ] Set `browser_build` to 1 (to prevent failures in alpha testbuilds)
=====================================
.gitlab/issue_templates/Rebase Browser - Legacy.md
=====================================
@@ -0,0 +1,111 @@
+**NOTE:** All examples in this template reference the rebase from 115.17.0esr to 115.18.0esr
+
+<details>
+ <summary>Explanation of Variables</summary>
+
+- `$(ESR_VERSION)`: the Mozilla defined ESR version, used in various places for building tor-browser tags, labels, etc
+ - **Example**: `115.18.0`
+- `$(ESR_TAG)`: the Mozilla defined hg (Mercurial) tag associated with `$(ESR_VERSION)`
+ - **Example**: `FIREFOX_115_18_0esr_BUILD1`
+- `$(ESR_TAG_PREV)`: the Mozilla defined hg (Mercurial) tag associated with the previous ESR version when rebasing (ie, the ESR version we are rebasing from)
+ - **Example**: `FIREFOX_115_17_0esr_BUILD1`
+- `$(BASE_BROWSER_BRANCH)`: the full name of the current `base-browser` branch
+ - **Example**: `base-browser-115.18.0esr-13.5-1`
+- `$(BASE_BROWSER_BRANCH_PREV)`: the full name of the previous `base-browser` branch
+ - **Example**: `base-browser-115.17.0esr-13.5-1`
+- `$(TOR_BROWSER_BRANCH)`: the full name of the current `tor-browser` branch
+ - **Example**: `tor-browser-115.18.0esr-13.5-1`
+- `$(TOR_BROWSER_BRANCH_PREV)`: the full name of the previous `tor-browser` branch
+ - **Example**: `tor-browser-115.17.0esr-13.5-1`
+</details>
+
+### **Bookkeeping**
+
+- [ ] Link this issue to the appropriate [Release Prep](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/is… issue.
+
+### Update Branch Protection Rules
+
+- [ ] In [Repository Settings](https://gitlab.torproject.org/tpo/applications/tor-browser/-/sett…:
+ - [ ] Remove previous legacy `base-browser` and `tor-browser` branch protection rules (this will prevent pushing new changes to the branches being rebased)
+ - [ ] Create new `base-browser` and `tor-browser` branch protection rule:
+ - **Branch**: `*-$(ESR_VERSION)esr-13.5-1*`
+ - **Example**: `*-115.18.0esr-13.5-1*`
+ - **Allowed to merge**: `Maintainers`
+ - **Allowed to push and merge**: `Maintainers`
+ - **Allowed to force push**: `false`
+
+### **Identify the Firefox Tagged Commit and Create New Branches**
+
+- [ ] Find the Firefox mercurial tag here: https://hg.mozilla.org/releases/mozilla-esr102/tags
+ - **Example**: `FIREFOX_115_18_0esr_BUILD1`
+- [ ] Find the analogous `gecko-dev` commit: https://github.com/mozilla/gecko-dev
+ - **Tip**: Search for unique string (like the Differential Revision ID) found in the mercurial commit in the `gecko-dev/esr115` branch to find the equivalent commit
+ - **Example**: `293d490d2e8d9fbb91c76336288f1287cbe285fb`
+- [ ] Sign and Tag `gecko-dev` commit
+ - Sign/Tag `gecko-dev` commit :
+ - **Tag**: `$(ESR_TAG)`
+ - **Message**: `Hg tag $(ESR_TAG)`
+- [ ] Create new legacy `base-browser` branch from tag
+ - Branch name in the form: `base-browser-$(ESR_VERSION)esr-13.5-1`
+ - **Example**: `base-browser-115.18.0esr-13.5-1`
+- [ ] Create new legacy `tor-browser` branch from
+ - Branch name in the form: `tor-browser-$(ESR_VERSION)esr-13.5-1`
+ - **Example**: `tor-browser-115.18.0esr-13.5-1`
+- [ ] Push new `base-browser` branch to `upstream`
+- [ ] Push new `tor-browser` branch to `upstream`
+- [ ] Push new `$(ESR_TAG)` to `upstream`
+
+### **Rebase tor-browser**
+
+- [ ] Checkout a new local branch for the `tor-browser` rebase
+ - **Example**: `git branch tor-browser-rebase FIREFOX_115_18_0esr_BUILD1`
+- [ ] **(Optional)** `base-browser` rebase
+ - **NOTE** This step may be skipped if the `HEAD` of the previous `base-browser` branch is a `-buildN` tag
+ - [ ] Cherry-pick the previous `base-browser` commits up to `base-browser`'s `buildN` tag onto new `base-browser` rebase branch
+ - **Example**: `git cherry-pick FIREFOX_115_17_0esr_BUILD1..base-browser-115.17.0esr-13.5-1-build2`
+ - [ ] Rebase and autosquash these cherry-picked commits
+ - **Example**: `git rebase --autosquash --interactive FIREFOX_115_18_0esr_BUILD1 HEAD`
+ - [ ] Cherry-pick remainder of patches after the `buildN` tag
+ - **Example**: `git cherry-pick base-browser-115.17.0esr-13.5-1-build21..upstream/base-browser-115.17.0esr-13.5-1`
+- [ ] `tor-browser` rebase
+ - [ ] Note the current git hash of `HEAD` for `tor-browser` rebase+autosquash step: `git rev-parse HEAD`
+ - [ ] Cherry-pick the appropriate previous `tor-browser` branch's commit range up to the last `tor-browser` `buildN` tag
+ - **Example**: `git cherry-pick base-browser-115.17.0esr-13.5-1-build1..tor-browser-115.17.0esr-13.5-1-build2
+ - **Example (if separate base-browser rebase was skipped)**: `git cherry-pick FIREFOX_115_17_0esr_BUILD1..tor-browser-115.17.0esr-13.5-1-build2`
+ - [ ] Rebase and autosquash these newly cherry-picked commits: `git rebase --autosquash --interactive $(PREV_HEAD)`
+ - **Example**: `git rebase --autosquash --interactive FIREFOX_115_18_0esr_BUILD1`
+ - [ ] Cherry-pick remainder of patches after the last `tor-browser` `buildN` tag
+ - **Example**: `git cherry-pick tor-browser-115.17.0esr-13.5-1-build1..upstream/tor-browser-115.17.0esr-13.5-1`
+ - [ ] Rebase and autosquash again, this time replacing all `fixup` and `squash` commands with `pick`. The goal here is to have all of the `fixup` and `squash` commits beside the commit which they modify, but kept un-squashed for easy debugging/bisecting.
+ - **Example**: `git rebase --autosquash --interactive FIREFOX_115_18_0esr_BUILD1`
+- [ ] Compare patch sets to ensure nothing *weird* happened during conflict resolution:
+ - [ ] diff of diffs:
+ - Do the diff between `current_patchset.diff` and `rebased_patchset.diff` with your preferred difftool and look at differences on lines that starts with + or -
+ - `git diff $(ESR_TAG_PREV)..$(BROWSER_BRANCH_PREV) > current_patchset.diff`
+ - `git diff $(ESR_TAG)..$(BROWSER_BRANCH) > rebased_patchset.diff`
+ - diff `current_patchset.diff` and `rebased_patchset.diff`
+ - If everything went correctly, the only lines which should differ should be the lines starting with `index abc123...def456` (unless the previous `base-browser` branch includes changes not included in the previous `tor-browser` branch)
+ - [ ] rangediff: `git range-diff $(ESR_TAG_PREV)..$(TOR_BROWSER_BRANCH_PREV) $(ESR_TAG)..HEAD`
+ - **Example**: `git range-dif FIREFOX_115_17_0esr_BUILD1..upstream/tor-browser-115.17.0esr-13.5-1 FIREFOX_115_18_0esr_BUILD1..HEAD`
+- [ ] Open MR for the `tor-browser` rebase
+- [ ] Merge
+- Update and push `base-browser` branch
+ - [ ] Reset the new `base-browser` branch to the appropriate commit in this new `tor-browser` branch
+ - [ ] Push these commits to `upstream`
+
+### **Sign and Tag**
+
+- [ ] Sign/Tag `HEAD` of the merged `tor-browser` branch:
+ - In **tor-browser.git**, checkout the new legacy `tor-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.torbrowser legacy build1
+ ```
+ - [ ] Push tag to `upstream`
+- [ ] Sign/Tag HEAD of the merged `base-browser` branch:
+ - In **tor-browser.git**, checkout the new legacy `base-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.basebrowser legacy build1
+ ```
+ - [ ] Push tag to `upstream`
=====================================
.gitlab/issue_templates/Rebase Browser - Stable.md
=====================================
@@ -100,10 +100,16 @@
### **Sign and Tag**
- [ ] Sign/Tag `HEAD` of the merged `tor-browser` branch:
- - **Tag**: `tor-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based stable`
+ - In **tor-browser.git**, checkout the new stable `tor-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.torbrowser stable build1
+ ```
- [ ] Push tag to `upstream`
- [ ] Sign/Tag HEAD of the merged `base-browser` branch:
- - **Tag**: `base-browser-$(ESR_VERSION)esr-$(BROWSER_MAJOR).$(BROWSER_MINOR)-1-build1`
- - **Message**: `Tagging build1 for $(ESR_VERSION)esr-based stable`
+ - In **tor-browser.git**, checkout the new stable `base-browser` branch
+ - In **tor-browser-build.git**, run signing script:
+ ```bash
+ ./tools/browser/sign-tag.basebrowser stable build1
+ ```
- [ ] Push tag to `upstream`
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4c970b…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4c970b…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
309b6ccb by Morgan at 2024-11-26T19:56:45+00:00
Update release prep merge request template
No longer syncing chnagelogs between channels
- - - - -
1 changed file:
- .gitlab/merge_request_templates/relprep.md
Changes:
=====================================
.gitlab/merge_request_templates/relprep.md
=====================================
@@ -39,7 +39,6 @@
- [ ] [Go](https://go.dev/dl): avoid major updates, unless planned
- [ ] Manual version update (Tor Browser only, optional)
- [ ] Changelogs
- - [ ] Changelogs must be in sync between stable and alpha
- [ ] Check the browser name
- [ ] Check the version
- [ ] Check the release date
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch mullvad-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
60b4fd16 by Morgan at 2024-11-26T19:48:56+00:00
fixup! Adding issue and merge request templates
add rebase MR template
- - - - -
1 changed file:
- + .gitlab/merge_request_templates/Rebase.md
Changes:
=====================================
.gitlab/merge_request_templates/Rebase.md
=====================================
@@ -0,0 +1,23 @@
+## Merge Info
+
+<!-- Bookkeeping information for release management -->
+
+### Rebase Issue
+- tor-browser#xxxxx
+- mullvad-browser#xxxxx
+
+### Release Prep Issue
+- tor-browser-build#xxxxx
+
+### Issue Tracking
+- [ ] Link rebase issue with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation
+
+### Review
+
+#### Request Reviewer
+
+- [ ] Request review from a release engineer: boklm, dan, ma1, morgan, pierov
+
+#### Change Description
+
+<!-- Any interesting notes about the rebase and an overview of what the reviewer should expect from the diff of diffs and range-diff -->
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/60b…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/60b…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
54b3f039 by Morgan at 2024-11-26T19:47:44+00:00
fixup! Adding issue and merge request templates
add rebase MR template
- - - - -
1 changed file:
- + .gitlab/merge_request_templates/Rebase.md
Changes:
=====================================
.gitlab/merge_request_templates/Rebase.md
=====================================
@@ -0,0 +1,23 @@
+## Merge Info
+
+<!-- Bookkeeping information for release management -->
+
+### Rebase Issue
+- tor-browser#xxxxx
+- mullvad-browser#xxxxx
+
+### Release Prep Issue
+- tor-browser-build#xxxxx
+
+### Issue Tracking
+- [ ] Link rebase issue with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation
+
+### Review
+
+#### Request Reviewer
+
+- [ ] Request review from a release engineer: boklm, dan, ma1, morgan, pierov
+
+#### Change Description
+
+<!-- Any interesting notes about the rebase and an overview of what the reviewer should expect from the diff of diffs and range-diff -->
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/54b3f03…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/54b3f03…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
4d3e22cd by Beatriz Rizental at 2024-11-26T10:03:34+00:00
fixup! Add CI for Tor Browser
- - - - -
1 changed file:
- .gitlab/ci/containers/base/Containerfile
Changes:
=====================================
.gitlab/ci/containers/base/Containerfile
=====================================
@@ -29,6 +29,8 @@ RUN apt-get update && apt-get install -y \
nasm \
pkgconf \
unzip \
+ x11-utils \
+ xvfb \
xz-utils \
wget && \
apt-get clean && \
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d3e22c…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d3e22c…
You're receiving this email because of your account on gitlab.torproject.org.
ma1 deleted tag mullvad-browser-128.5.0esr-14.0-1-build3 at The Tor Project / Applications / Mullvad Browser
--
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch mullvad-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser
Commits:
53f181cb by Pier Angelo Vendrame at 2024-11-26T09:07:09+01:00
fixup! Firefox preference overrides.
Bug 42125: Set and lock privacy.resistFingerprinting.exemptedDomains.
The rationale for locking this is consistency with RFP.
Also, set privacy.resistFingerprinting.randomDataOnCanvasExtract as a
countermesure to some wrong guides.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -385,10 +385,18 @@ pref("dom.push.serverURL", "");
// Fingerprinting
// tor-browser#41797: For release builds, lock RFP
+// tor-browser#42125: Set (and lock in release) also exempted domains.
#if MOZ_UPDATE_CHANNEL == release
pref("privacy.resistFingerprinting", true, locked);
+pref("privacy.resistFingerprinting.exemptedDomains", "", locked);
+// tor-browser#42125: Some misleading guides suggest to set this to false, but
+// the result would be that the canvas is completely white
+// (see StaticPrefList.yaml), so lock it to true.
+// Might be removed (MozBug 1670447).
+pref("privacy.resistFingerprinting.randomDataOnCanvasExtract", true, locked);
#else
pref("privacy.resistFingerprinting", true);
+pref("privacy.resistFingerprinting.exemptedDomains", "");
#endif
// tor-browser#18603: failIfMajorPerformanceCaveat is an optional attribute that
// can be used when creating a WebGL context if the browser detects that the
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/53f…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/53f…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch base-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
f230a2e9 by Pier Angelo Vendrame at 2024-11-26T09:06:36+01:00
fixup! Firefox preference overrides.
Bug 42125: Set and lock privacy.resistFingerprinting.exemptedDomains.
The rationale for locking this is consistency with RFP.
Also, set privacy.resistFingerprinting.randomDataOnCanvasExtract as a
countermesure to some wrong guides.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -385,10 +385,18 @@ pref("dom.push.serverURL", "");
// Fingerprinting
// tor-browser#41797: For release builds, lock RFP
+// tor-browser#42125: Set (and lock in release) also exempted domains.
#if MOZ_UPDATE_CHANNEL == release
pref("privacy.resistFingerprinting", true, locked);
+pref("privacy.resistFingerprinting.exemptedDomains", "", locked);
+// tor-browser#42125: Some misleading guides suggest to set this to false, but
+// the result would be that the canvas is completely white
+// (see StaticPrefList.yaml), so lock it to true.
+// Might be removed (MozBug 1670447).
+pref("privacy.resistFingerprinting.randomDataOnCanvasExtract", true, locked);
#else
pref("privacy.resistFingerprinting", true);
+pref("privacy.resistFingerprinting.exemptedDomains", "");
#endif
// tor-browser#18603: failIfMajorPerformanceCaveat is an optional attribute that
// can be used when creating a WebGL context if the browser detects that the
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f230a2e…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f230a2e…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch tor-browser-128.5.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
8cad63f9 by Pier Angelo Vendrame at 2024-11-26T08:43:38+01:00
fixup! Firefox preference overrides.
Bug 42125: Set and lock privacy.resistFingerprinting.exemptedDomains.
The rationale for locking this is consistency with RFP.
Also, set privacy.resistFingerprinting.randomDataOnCanvasExtract as a
countermesure to some wrong guides.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -385,10 +385,18 @@ pref("dom.push.serverURL", "");
// Fingerprinting
// tor-browser#41797: For release builds, lock RFP
+// tor-browser#42125: Set (and lock in release) also exempted domains.
#if MOZ_UPDATE_CHANNEL == release
pref("privacy.resistFingerprinting", true, locked);
+pref("privacy.resistFingerprinting.exemptedDomains", "", locked);
+// tor-browser#42125: Some misleading guides suggest to set this to false, but
+// the result would be that the canvas is completely white
+// (see StaticPrefList.yaml), so lock it to true.
+// Might be removed (MozBug 1670447).
+pref("privacy.resistFingerprinting.randomDataOnCanvasExtract", true, locked);
#else
pref("privacy.resistFingerprinting", true);
+pref("privacy.resistFingerprinting.exemptedDomains", "");
#endif
// tor-browser#18603: failIfMajorPerformanceCaveat is an optional attribute that
// can be used when creating a WebGL context if the browser detects that the
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8cad63f…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8cad63f…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
0f3965af by Morgan at 2024-11-26T02:47:41+00:00
Update Tor Browser Stable's Release-Prep template to include missing legacy params in rbm.conf
- - - - -
1 changed file:
- .gitlab/issue_templates/Release Prep - Tor Browser Stable.md
Changes:
=====================================
.gitlab/issue_templates/Release Prep - Tor Browser Stable.md
=====================================
@@ -68,6 +68,8 @@ Tor Browser Stable is on the `maint-${TOR_BROWSER_MAJOR}.${TOR_BROWSER_MINOR}` b
- [ ] ***(Desktop Only)*** `var/torbrowser_incremental_from`: updated to previous Desktop version
- **NOTE**: We try to build incrementals for the previous 3 desktop versions
- **⚠️ WARNING**: Really *actually* make sure this is the previous Desktop version or else the `make torbrowser-incrementals-*` step will fail
+ - [ ] `var/torbrowser_legacy_version`: updated to latest legacy Tor Browser version
+ - [ ] `var/torbrowser_legacy_platform_version`: updated to latest legacy Tor Browser ESR version
- [ ] `projects/firefox/config`
- [ ] `browser_build`: updated to match `tor-browser` tag
- [ ] ***(Optional)*** `var/firefox_platform_version`: updated to latest `${ESR_VERSION}` if rebased
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build
Commits:
f605e288 by Morgan at 2024-11-26T02:24:45+00:00
Bug 41301: Prepare Tor Browser 14.0.3 part 2
- fix legacy torbrowser mar generation
- - - - -
1 changed file:
- rbm.conf
Changes:
=====================================
rbm.conf
=====================================
@@ -74,7 +74,7 @@ buildconf:
var:
torbrowser_version: '14.0.3'
- torbrowser_build: 'build1'
+ torbrowser_build: 'build2'
# This should be the date of when the build is started. For the build
# to be reproducible, browser_release_date should always be in the past.
browser_release_date: '2024/11/25 15:42:04'
@@ -89,8 +89,8 @@ var:
- '[% IF c("var/mullvad-browser") %]13.5.7[% END %]'
mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]'
- torbrowser_legacy_version: 13.5.9
- torbrowser_legacy_platform_version: 115.17.0
+ torbrowser_legacy_version: 13.5.10
+ torbrowser_legacy_platform_version: 115.18.0
# By default, we sort the list of installed packages. This allows sharing
# containers with identical list of packages, even if they are not listed
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
e4243a7f by Henry Wilkes at 2024-11-25T22:15:46+00:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 43314: Show initial focus for the connection settings dialog.
- - - - -
76241a15 by Henry Wilkes at 2024-11-25T22:15:46+00:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 43314: Use <description> instead of <h3> for dialog introduction
text.
This keeps the style and semantics consistent with other dialogs.
- - - - -
535b9be0 by Henry Wilkes at 2024-11-25T22:15:46+00:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 43314: Add control attributes to the xul:label elements in the
connection settings.
These associate the form controls with their labels, giving them an
accessible name and an additional click target.
- - - - -
5 changed files:
- browser/components/torpreferences/content/connectionSettingsDialog.js
- browser/components/torpreferences/content/connectionSettingsDialog.xhtml
- browser/components/torpreferences/content/requestBridgeDialog.js
- browser/components/torpreferences/content/requestBridgeDialog.xhtml
- browser/components/torpreferences/content/torPreferences.css
Changes:
=====================================
browser/components/torpreferences/content/connectionSettingsDialog.js
=====================================
@@ -317,6 +317,16 @@ const gConnectionSettingsDialog = {
},
};
+// Initial focus is not visible, even if opened with a keyboard. We avoid the
+// default handler and manage the focus ourselves, which will paint the focus
+// ring by default.
+// NOTE: A side effect is that the focus ring will show even if the user opened
+// with a mouse event.
+// TODO: Remove this once bugzilla bug 1708261 is resolved.
+document.subDialogSetDefaultFocus = () => {
+ document.getElementById("torPreferences-connection-toggleProxy").focus();
+};
+
window.addEventListener(
"DOMContentLoaded",
() => {
=====================================
browser/components/torpreferences/content/connectionSettingsDialog.xhtml
=====================================
@@ -24,10 +24,10 @@
<script src="chrome://browser/content/torpreferences/connectionSettingsDialog.js" />
- <html:h3
+ <description
id="torPreferences-connection-header"
data-l10n-id="tor-advanced-dialog-introduction"
- ></html:h3>
+ ></description>
<!-- Local Proxy -->
<checkbox
id="torPreferences-connection-toggleProxy"
@@ -38,6 +38,7 @@
<label
id="torPreferences-localProxy-type"
data-l10n-id="tor-advanced-dialog-proxy-type-selector-label"
+ control="torPreferences-localProxy-builtinList"
/>
</hbox>
<hbox align="center">
@@ -53,6 +54,7 @@
<label
id="torPreferences-localProxy-address"
data-l10n-id="tor-advanced-dialog-proxy-address-input-label"
+ control="torPreferences-localProxy-textboxAddress"
/>
</hbox>
<hbox align="center">
@@ -65,6 +67,7 @@
<label
id="torPreferences-localProxy-port"
data-l10n-id="tor-advanced-dialog-proxy-port-input-label"
+ control="torPreferences-localProxy-textboxPort"
/>
<!-- proxy-port-input class style pulled from preferences.css and used in the vanilla proxy setup menu -->
<html:input
@@ -81,6 +84,7 @@
<label
id="torPreferences-localProxy-username"
data-l10n-id="tor-advanced-dialog-proxy-username-input-label"
+ control="torPreferences-localProxy-textboxUsername"
/>
</hbox>
<hbox align="center">
@@ -93,6 +97,7 @@
<label
id="torPreferences-localProxy-password"
data-l10n-id="tor-advanced-dialog-proxy-password-input-label"
+ control="torPreferences-localProxy-textboxPassword"
/>
<html:input
id="torPreferences-localProxy-textboxPassword"
@@ -112,6 +117,7 @@
<label
id="torPreferences-connection-allowedPorts"
data-l10n-id="tor-advanced-dialog-firewall-ports-input-label"
+ control="torPreferences-connection-textboxAllowedPorts"
/>
</hbox>
<hbox id="torPreferences-connection-hboxAllowedPorts" align="center">
=====================================
browser/components/torpreferences/content/requestBridgeDialog.js
=====================================
@@ -15,7 +15,7 @@ const log = console.createInstance({
const gRequestBridgeDialog = {
selectors: {
- dialogHeader: "h3#torPreferences-requestBridge-header",
+ dialogHeader: "#torPreferences-requestBridge-header",
captchaImage: "image#torPreferences-requestBridge-captchaImage",
captchaEntryTextbox: "input#torPreferences-requestBridge-captchaTextbox",
refreshCaptchaButton:
=====================================
browser/components/torpreferences/content/requestBridgeDialog.xhtml
=====================================
@@ -23,10 +23,10 @@
<script src="chrome://browser/content/torpreferences/requestBridgeDialog.js" />
- <html:h3
+ <description
id="torPreferences-requestBridge-header"
data-l10n-id="request-bridge-dialog-top-solve"
- ></html:h3>
+ ></description>
<!-- init to transparent 400x125 png -->
<image id="torPreferences-requestBridge-captchaImage" flex="1" />
<hbox id="torPreferences-requestBridge-inputHbox">
=====================================
browser/components/torpreferences/content/torPreferences.css
=====================================
@@ -793,11 +793,7 @@ button.spoof-button-disabled {
font-weight: 700;
}
-/* Advanced Settings */
-
-h3#torPreferences-requestBridge-header {
- margin: 0;
-}
+/* Request bridges */
image#torPreferences-requestBridge-captchaImage {
margin: 16px 0 8px 0;
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/38bb69…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/38bb69…
You're receiving this email because of your account on gitlab.torproject.org.