- tbb-commits - lists.torproject.org

[torbutton] branch main updated: Bug 41352: Always show the link to the manual in about:tor
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository torbutton. The following commit(s) were added to refs/heads/main by this push: new fb381b64 Bug 41352: Always show the link to the manual in about:tor fb381b64 is described below commit fb381b649b92116d3f03a13313c5a051b792604c Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Tue Oct 11 19:13:21 2022 +0200 Bug 41352: Always show the link to the manual in about:tor --- chrome/content/aboutTor/aboutTor-content.js | 8 +------- chrome/content/preferences-mobile.js | 26 -------------------------- chrome/content/torbutton.js | 18 ------------------ chrome/skin/aboutTor.css | 3 +-- modules/utils.js | 7 ------- 5 files changed, 2 insertions(+), 60 deletions(-) diff --git a/chrome/content/aboutTor/aboutTor-content.js b/chrome/content/aboutTor/aboutTor-content.js index 55bf4413..a35d95b5 100644 --- a/chrome/content/aboutTor/aboutTor-content.js +++ b/chrome/content/aboutTor/aboutTor-content.js @@ -19,7 +19,7 @@ const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); -const { bindPrefAndInit, show_torbrowser_manual } = ChromeUtils.import( +const { bindPrefAndInit } = ChromeUtils.import( "resource://torbutton/modules/utils.js" ); @@ -95,12 +95,6 @@ var AboutTorListener = { body.removeAttribute("toron"); } - if (show_torbrowser_manual()) { - body.setAttribute("showmanual", "yes"); - } else { - body.removeAttribute("showmanual"); - } - if (aData.updateChannel) { body.setAttribute("updatechannel", aData.updateChannel); } else { diff --git a/chrome/content/preferences-mobile.js b/chrome/content/preferences-mobile.js index 92564e90..50cbfccd 100644 --- a/chrome/content/preferences-mobile.js +++ b/chrome/content/preferences-mobile.js @@ -10,10 +10,6 @@ const { getCharPref, } = Services.prefs; -let { getLocale, show_torbrowser_manual } = ChromeUtils.import( - "resource://torbutton/modules/utils.js" -); - // Description elements have the follow names. const descNames = ["", "desc_standard", "desc_safer", "desc_safest"]; // "Learn-more"-elements have the follow names. @@ -51,7 +47,6 @@ function torbutton_init_security_ui() { getIntPref("extensions.torbutton.security_slider") ) ); - torbutton_set_learn_more_links(); } // Write the two prefs from the current settings. @@ -62,24 +57,3 @@ function torbutton_save_security_settings() { ); setBoolPref("extensions.torbutton.security_custom", state.custom); } - -// We follow the way we treat the links to the Tor Browser User Manual on the -// Help Menu and on about:tor: if we have the manual available for a locale, -// let's show the "Learn more"-link, otherwise hide it. -function torbutton_set_learn_more_links() { - let show_manual = show_torbrowser_manual(); - let locale = ""; - if (show_manual) { - locale = getLocale(); - } - let links = linkNames.map(name => document.getElementById(name)); - links.forEach(link => { - if (show_manual && locale != "") { - link.href = - "https:/tb-manual.torproject.org/" + locale + "/security-slider.html"; - link.hidden = false; - } else { - link.hidden = true; - } - }); -} diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index d89e5d55..3400a32a 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -19,7 +19,6 @@ var torbutton_new_circuit; */ let { - show_torbrowser_manual, unescapeTorString, bindPrefAndInit, getDomainForBrowser, @@ -275,12 +274,6 @@ var torbutton_new_circuit; torbutton_log(1, "registering Tor check observer"); torbutton_tor_check_observer.register(); - try { - torbutton_init_user_manual_links(); - } catch (e) { - torbutton_log(4, "Error loading the user manual " + e); - } - // Arrange for our about:tor content script to be loaded in each frame. window.messageManager.loadFrameScript( "chrome://torbutton/content/aboutTor/aboutTor-content.js", @@ -1042,16 +1035,5 @@ var torbutton_new_circuit; onStatusChange(aProgress, aRequest, stat, message) {}, onSecurityChange() {}, }; - - // Makes sure the item in the Help Menu and the link in about:tor - // for the Tor Browser User Manual are only visible when - // show_torbrowser_manual() returns true. - function torbutton_init_user_manual_links() { - let menuitem = document.getElementById("torBrowserUserManual"); - bindPrefAndInit("intl.locale.requested", val => { - menuitem.hidden = !show_torbrowser_manual(); - torbutton_abouttor_message_handler.updateAllOpenPages(); - }); - } })(); //vim:set ts=4 diff --git a/chrome/skin/aboutTor.css b/chrome/skin/aboutTor.css index da02130b..007c46d3 100644 --- a/chrome/skin/aboutTor.css +++ b/chrome/skin/aboutTor.css @@ -112,8 +112,7 @@ body:not([toron]) .hideIfTorOff { display: none; } -body:not([hasbeenupdated]) .showIfHasBeenUpdated, -body:not([showmanual]) .showForManual { +body:not([hasbeenupdated]) .showIfHasBeenUpdated { display: none; } diff --git a/modules/utils.js b/modules/utils.js index 7ccd2da1..49f7c0dc 100644 --- a/modules/utils.js +++ b/modules/utils.js @@ -208,13 +208,6 @@ var unescapeTorString = function(str) { return _torControl._strUnescape(str); }; -// Returns true if we should show the tor browser manual. -var show_torbrowser_manual = () => { - let availableLocales = ["de", "en", "es", "fr", "nl", "pt", "tr", "vi", "zh"]; - let shortLocale = getLocale().substring(0, 2); - return availableLocales.includes(shortLocale); -}; - var getFPDFromHost = hostname => { try { return Services.eTLD.getBaseDomainFromHost(hostname); -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch main updated: Bug 41366: Remove the article before Tor Browser when not needed
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository torbutton. The following commit(s) were added to refs/heads/main by this push: new 88803b52 Bug 41366: Remove the article before Tor Browser when not needed 88803b52 is described below commit 88803b5271954eb0985f130cc4488ca948ea1c07 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Mon Oct 17 09:48:42 2022 +0200 Bug 41366: Remove the article before Tor Browser when not needed --- chrome/locale/en-US/torlauncher.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/locale/en-US/torlauncher.properties b/chrome/locale/en-US/torlauncher.properties index 2e34c6e1..bc9eb5df 100644 --- a/chrome/locale/en-US/torlauncher.properties +++ b/chrome/locale/en-US/torlauncher.properties @@ -4,7 +4,7 @@ torlauncher.error_title=Tor Launcher torlauncher.tor_exited_during_startup=Tor exited during startup. This might be due to an error in your torrc file, a bug in Tor or another program on your system, or faulty hardware. Until you fix the underlying problem and restart Tor, Tor Browser will not start. -torlauncher.tor_exited=Tor unexpectedly exited. This might be due to a bug in Tor itself, another program on your system, or faulty hardware. Until you restart Tor, the Tor Browser will not be able to reach any websites. If the problem persists, please send a copy of your Tor Log to the support team. +torlauncher.tor_exited=Tor unexpectedly exited. This might be due to a bug in Tor itself, another program on your system, or faulty hardware. Until you restart Tor, Tor Browser will not be able to reach any websites. If the problem persists, please send a copy of your Tor Log to the support team. torlauncher.tor_exited2=Restarting Tor will not close your browser tabs. torlauncher.tor_controlconn_failed=Could not connect to Tor control port. torlauncher.tor_failed_to_start=Tor failed to start. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated: fixup! Bug 40587: Migrate tor-browser-build configs from gitolite to gitlab repos
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/main by this push: new 823383c fixup! Bug 40587: Migrate tor-browser-build configs from gitolite to gitlab repos 823383c is described below commit 823383cd749307aa49c5625c1f9a0019575a4049 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Fri Oct 14 18:19:58 2022 +0200 fixup! Bug 40587: Migrate tor-browser-build configs from gitolite to gitlab repos Changed remaining URLs in GitLab issue templates. --- .gitlab/issue_templates/Release Prep - Alpha.md | 12 ++++++------ .gitlab/issue_templates/Release Prep - Stable.md | 14 +++++++------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.gitlab/issue_templates/Release Prep - Alpha.md b/.gitlab/issue_templates/Release Prep - Alpha.md index eb9a3f7..1735c6b 100644 --- a/.gitlab/issue_templates/Release Prep - Alpha.md +++ b/.gitlab/issue_templates/Release Prep - Alpha.md @@ -33,7 +33,7 @@ <details> <summary>Desktop</summary> -### **torbutton** : https://git.torproject.org/torbutton.git +### **torbutton** : https://gitlab.torproject.org/tpo/applications/torbutton.git - [ ] Update translations : - [ ] `./import-translations.sh` - **NOTE** : if there are no new strings imported then we are done here @@ -42,7 +42,7 @@ - [ ] ***(Optional)*** Backport to maintenance branch if present and necessary - [ ] fixup! `tor-browser`'s `Bug 10760 : Integrate TorButton to TorBrowser core` issue to point to updated `torbutton` commit -### **tor-launcher** : https://git.torproject.org/tor-launcher.git +### **tor-launcher** : https://gitlab.torproject.org/tpo/applications/tor-launcher.git - [ ] Update translations: - [ ] ./localization/import-translations.sh - **NOTE** : if there are no new strings imported then we are done here @@ -57,11 +57,11 @@ <details> <summary>Android</summary> -### **tba-translation** : https://git.torproject.org/translation.git +### **tba-translation** : https://gitlab.torproject.org/tpo/translation.git - [ ] Fetch latest and identify new `HEAD` of `fenix-torbrowserstringsxml` branch - [ ] `origin/fenix-torbrowserstringsxml` : `<INSERT COMMIT HASH HERE>` -### **tor-android-service** ***(Optional)***: https://git.torproject.org/tor-android-service.git +### **tor-android-service** ***(Optional)***: https://gitlab.torproject.org/tpo/applications/tor-android-service.git - [ ] Fetch latest and identify new `HEAD` of `main` branch - [ ] `origin/main` : `<INSERT COMMIT HASH HERE>` @@ -101,7 +101,7 @@ <details> <summary>Shared</summary> -### tor-browser: https://git.torproject.org/tor-browser.git +### tor-browser: https://gitlab.torproject.org/tpo/applications/tor-browser.git - [ ] ***(Optional)*** Backport any Android-specific security fixes from Firefox rapid-release - [ ] ***(Optional)*** Rebase to `$(ESR_VERSION)` - [ ] Find the Firefox hg tag here : https://hg.mozilla.org/releases/mozilla-esr102/tags @@ -138,7 +138,7 @@ <details> <summary>Build/Signing/Publishing</summary> -### tor-browser-build: https://git.torproject.org/builders/tor-browser-build.git +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git Tor Browser Alpha (and Nightly) are on the `main` branch, while Stable lives in the various `$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-maint` (and possibly more specific) branches - [ ] Update `rbm.conf` diff --git a/.gitlab/issue_templates/Release Prep - Stable.md b/.gitlab/issue_templates/Release Prep - Stable.md index a93f472..6c36008 100644 --- a/.gitlab/issue_templates/Release Prep - Stable.md +++ b/.gitlab/issue_templates/Release Prep - Stable.md @@ -39,7 +39,7 @@ <details> <summary>Desktop</summary> -### **torbutton** ***(Optional)***: https://git.torproject.org/torbutton.git +### **torbutton** ***(Optional)***: https://gitlab.torproject.org/tpo/applications/torbutton.git - [ ] ***(Optional)*** Update translations : - **NOTE** We only update strings in stable if a backported feature depends on new strings - [ ] `./import-translations.sh` @@ -48,7 +48,7 @@ - **NOTE** : only add files which are already being tracked - [ ] fixup! `tor-browser`'s `Bug 10760 : Integrate TorButton to TorBrowser core` issue to point to updated `torbutton` commit -### **tor-launcher** ***(Optional)***: https://git.torproject.org/tor-launcher.git +### **tor-launcher** ***(Optional)***: https://gitlab.torproject.org/tpo/applications/tor-launcher.git - [ ] ***(Optional)*** Update translations: - **NOTE** We only update strings in stable if a backported feature depends on new strings - [ ] ./localization/import-translations.sh @@ -59,7 +59,7 @@ - Message `Tagging $(TOR_LAUNCHER_VERSION)` - [ ] Push `main` and tag to origin -### tor-browser: https://git.torproject.org/tor-browser.git +### tor-browser: https://gitlab.torproject.org/tpo/applications/tor-browser.git - [ ] ***(Optional)*** Rebase to `$(ESR_VERSION)` - [ ] Find the Firefox hg tag here : https://hg.mozilla.org/releases/mozilla-esr91/tags - [ ] `$(ESR_TAG)` : `<INSERT_TAG_HERE>` @@ -93,7 +93,7 @@ <details> <summary>Android</summary> -### **geckoview**: https://git.torproject.org/tor-browser.git +### **geckoview**: https://gitlab.torproject.org/tpo/applications/tor-browser.git - [ ] ***(Optional)*** Rebase to `$(RR_VERSION)` - [ ] Find the Firefox hg tag here : https://hg.mozilla.org/releases/mozilla-release/tags - [ ] `$(RR_TAG)` : `<INSERT_TAG_HERE>` @@ -123,12 +123,12 @@ - Message : `Tagging $(FIREFOX_BUILD_N) for $(RR_VERSION)-based (alpha|stable)` - [ ] Push tag to `origin` -### **tba-translation** ***(Optional)***: https://git.torproject.org/translation.git +### **tba-translation** ***(Optional)***: https://gitlab.torproject.org/tpo/translation.git - **NOTE** We only update strings in stable if a backported feature depends on new strings - [ ] Fetch latest and identify new `HEAD` of `fenix-torbrowserstringsxml` branch - [ ] `origin/fenix-torbrowserstringsxml` : `<INSERT COMMIT HASH HERE>` -### **tor-android-service** ***(Optional)***: https://git.torproject.org/tor-android-service.git +### **tor-android-service** ***(Optional)***: https://gitlab.torproject.org/tpo/applications/tor-android-service.git - [ ] Fetch latest and identify new `HEAD` of `main` branch - [ ] `origin/main` : `<INSERT COMMIT HASH HERE>` @@ -185,7 +185,7 @@ <details> <summary>Build/Signing/Publishing</summary> -### tor-browser-build: https://git.torproject.org/builders/tor-browser-build.git +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git Tor Browser Alpha (and Nightly) are on the `main` branch, while Stable lives in the various `$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-maint` (and possibly more specific) branches - [ ] Update `rbm.conf` -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated: Bug 17400: Enable multi-lingual builds
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/main by this push: new a3f4912 Bug 17400: Enable multi-lingual builds a3f4912 is described below commit a3f49129c0c697eb7e951c871b8bfa8dd2e1fe27 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Fri Oct 7 18:16:58 2022 +0200 Bug 17400: Enable multi-lingual builds --- projects/browser/build | 10 ++++++---- projects/browser/config | 2 +- rbm.conf | 2 +- tools/update-responses/update_responses | 2 +- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/projects/browser/build b/projects/browser/build index 6a7ef9a..2e037d6 100644 --- a/projects/browser/build +++ b/projects/browser/build @@ -223,7 +223,7 @@ tar -C Bundle-Data/[% bundledata_osname %] [% IF ! c("var/namecoin") %]--exclude pushd "$TBDIR[% IF c("var/osx") %]/Contents/Resources[% END %]/browser/" unzip omni.ja defaults/preferences/[% c("var/prefs_file") %] || [ $? -lt 3 ] -# Append our built extension-overrides.js to 000-tor-browser.js +# Append our built extension-overrides.js to the preferences file cat "$GENERATEDPREFSPATH" >> defaults/preferences/[% c("var/prefs_file") %] cp defaults/preferences/[% c("var/prefs_file") %] $rootdir [% IF c("var/osx") %] @@ -235,8 +235,6 @@ cp defaults/preferences/[% c("var/prefs_file") %] $rootdir zip -Xm omni.ja chrome/en-US/locale/browser/bookmarks.html rm -rf chrome [% END %] -# Set the locale of the bundle. -echo "pref(\"intl.locale.requested\", \"en-US\");" >> defaults/preferences/[% c("var/prefs_file") %] [% c("touch") %] defaults/preferences/[% c("var/prefs_file") %] zip -Xm omni.ja defaults/preferences/[% c("var/prefs_file") %] rm -rf defaults @@ -247,7 +245,11 @@ popd [% IF c("var/osx") || c("var/multi_lingual") -%] # Prepare our language packs to embed our default bookmarks. # See bug 21879 for more details. - [% SET locales = c("var/testbuild") ? [] : c("var/locales") -%] + [% IF c("var/multi_lingual") -%] + [% SET locales = c("var/locales") -%] + [% ELSE -%] + [% SET locales = c("var/testbuild") ? [] : c("var/locales") -%] + [% END -%] [% FOREACH lang = locales %] [% SET lang = tmpl(lang); SET xpi = '$rootdir/' _ c('input_files_by_name/firefox-langpacks') _ '/' _ lang _ '.xpi'; diff --git a/projects/browser/config b/projects/browser/config index 10b7eb9..4ae3e4f 100644 --- a/projects/browser/config +++ b/projects/browser/config @@ -75,7 +75,7 @@ input_files: enable: '[% c("var/tor-browser") %]' - project: firefox-langpacks name: firefox-langpacks - enable: '[% ! c("var/testbuild") && ! c("var/android") %]' + enable: '[% (!c("var/testbuild") || c("var/multi_lingual")) && ! c("var/android") %]' - project: fonts name: fonts enable: '[% ! c("var/android") %]' diff --git a/rbm.conf b/rbm.conf index 97baa32..02c8074 100644 --- a/rbm.conf +++ b/rbm.conf @@ -75,7 +75,7 @@ var: torbrowser_build: 'build1' torbrowser_incremental_from: - 12.0a2 - multi_lingual: 0 + multi_lingual: 1 build_mar: 1 # By default, we sort the list of installed packages. This allows sharing # containers with identical list of packages, even if they are not listed diff --git a/tools/update-responses/update_responses b/tools/update-responses/update_responses index 7881205..af81875 100755 --- a/tools/update-responses/update_responses +++ b/tools/update-responses/update_responses @@ -411,7 +411,7 @@ sub write_htaccess { $htaccess .= "RewriteRule ^$bt/[^\/]+/$lang " . "$version-$os-$migrate_langs->{$lang}.xml $flags\n"; } - $htaccess .= "RewriteRule ^$bt/ $version-$os-en-US.xml $flags\n"; + $htaccess .= "RewriteRule ^$bt/ $version-$os-ALL.xml $flags\n"; } } write_htdocs($channel, '.htaccess', $htaccess); -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated (bf61fa9 -> b321f2a)
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a change to branch main in repository builders/tor-browser-build. from bf61fa9 Bug 40638: Update the update link of nightly builds new 9f5c55f Bug 40640: Extract Gradle in the toolchain setup new b321f2a Bug 23656: Use mozconfigs from tor-browser.git (Geckoview) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: projects/android-components/build | 7 +++-- projects/android-toolchain/config | 11 +++++--- projects/application-services/build | 6 ++-- projects/fenix/build | 13 +++++---- projects/geckoview/build | 14 ++++++---- projects/geckoview/config | 13 ++++----- projects/geckoview/mozconfig-android-aarch64 | 42 ---------------------------- projects/geckoview/mozconfig-android-all | 13 --------- projects/geckoview/mozconfig-android-armv7 | 42 ---------------------------- projects/geckoview/mozconfig-android-x86 | 42 ---------------------------- projects/geckoview/mozconfig-android-x86_64 | 42 ---------------------------- projects/tor-android-service/build | 6 ++-- projects/tor-onion-proxy-library/build | 6 ++-- 13 files changed, 44 insertions(+), 213 deletions(-) delete mode 100644 projects/geckoview/mozconfig-android-aarch64 delete mode 100644 projects/geckoview/mozconfig-android-all delete mode 100644 projects/geckoview/mozconfig-android-armv7 delete mode 100644 projects/geckoview/mozconfig-android-x86 delete mode 100644 projects/geckoview/mozconfig-android-x86_64 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated (54e941e99e2b -> fbe4ac7178a0)
by gitolite role 17 Oct '22

17 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a change to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. from 54e941e99e2b squash! Firefox preference overrides. new 800f5d762fa2 fixup! Base Browser's .mozconfigs. new 72ede633585d fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser new fbe4ac7178a0 fixup! TB3: Tor Browser's official .mozconfigs. The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: browser/config/mozconfigs/base-browser-android | 4 ++++ mozconfig-android-all | 22 ++++++++++++++++++++++ mozconfig-android-all-dev | 16 ---------------- tools/torbrowser/fataar.sh | 4 ++-- 4 files changed, 28 insertions(+), 18 deletions(-) create mode 100644 mozconfig-android-all delete mode 100644 mozconfig-android-all-dev -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: squash! Firefox preference overrides.
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 54e941e99e2b squash! Firefox preference overrides. 54e941e99e2b is described below commit 54e941e99e2b5841edf10cb05b1b4b71bcb81f19 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Oct 11 21:45:59 2022 +0000 squash! Firefox preference overrides. Bug 24686: Set network.http.tailing.enabled to true --- browser/app/profile/001-base-profile.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/browser/app/profile/001-base-profile.js b/browser/app/profile/001-base-profile.js index 6489ac3c5076..c6b088434b79 100644 --- a/browser/app/profile/001-base-profile.js +++ b/browser/app/profile/001-base-profile.js @@ -253,6 +253,11 @@ pref("network.protocol-handler.warn-external.news", true); pref("network.protocol-handler.warn-external.nntp", true); pref("network.protocol-handler.warn-external.snews", true); pref("network.proxy.allow_bypass", false); // #40682 +// Lock to 'true', which is already the firefox default, to prevent users +// from making themselves fingerprintable by disabling. This pref +// alters content load order in a page. See tor-browser#24686 +pref("network.http.tailing.enabled", true, locked); + // Make sure we don't have any GIO supported protocols (defense in depth // measure) pref("network.gio.supported-protocols", ""); -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch maint-11.5 updated: Bug 41364: Amend YEC 2022 styling
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch maint-11.5 in repository torbutton. The following commit(s) were added to refs/heads/maint-11.5 by this push: new 17569fee Bug 41364: Amend YEC 2022 styling 17569fee is described below commit 17569feebb570762ab92f9a6031609f012197b04 Author: Henry Wilkes <henry(a)torproject.org> AuthorDate: Fri Oct 14 12:36:40 2022 +0100 Bug 41364: Amend YEC 2022 styling --- chrome/skin/aboutTor.css | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/chrome/skin/aboutTor.css b/chrome/skin/aboutTor.css index 5c75c1f0..b9f0d76f 100644 --- a/chrome/skin/aboutTor.css +++ b/chrome/skin/aboutTor.css @@ -11,7 +11,7 @@ --abouttor-bg-toroff-color: #A4000F; --abouttor-yec-page-bg-color: #0E0625; --abouttor-yec-heading-color: #C0FF00; - --abouttor-yec-heading-alt-color: #FF8AFF; + --abouttor-yec-heading-alt-color: #FF60FF; --abouttor-yec-button-color: #000000; --abouttor-yec-button-bg-color: #C0FF00; --abouttor-yec-button-hover-bg-color: #A8DF00; @@ -76,6 +76,10 @@ body:not([initialized]) { } } +body[toron]:not([hasbeenupdated]).isYEC .torcontent-container { + margin-block-end: calc(28px + 4rem); +} + #torbrowser-info { position: absolute; top: 16px; @@ -172,6 +176,7 @@ body:not([showmanual]) .showForManual { grid-area: image-start / image-start / image-end / sub-headings-end; margin-inline: -25px; margin-top: 45px; + opacity: 0.8; } .yec-foreground-image { @@ -180,6 +185,7 @@ body:not([showmanual]) .showForManual { align-self: end; margin-inline: -55px 25px; margin-block: 15px 10px; + mix-blend-mode: hard-light; } .yec-foreground-image:dir(rtl) { @@ -193,7 +199,7 @@ body:not([showmanual]) .showForManual { color: var(--abouttor-yec-heading-color); line-height: 1.1; font-family: 'Space Mono', monospace; - font-weight: 700; + font-weight: 400; letter-spacing: -0.05em; } @@ -210,6 +216,7 @@ body:not([showmanual]) .showForManual { font-family: 'Space Grotesk', sans-serif; font-size: 60px; letter-spacing: -0.05em; + mix-blend-mode: hard-light; } .yec-sub-heading-2 { -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch main updated: Bug 40619: Take translation from gitlab.tpo and not git.tpo
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository torbutton. The following commit(s) were added to refs/heads/main by this push: new 55e518c9 Bug 40619: Take translation from gitlab.tpo and not git.tpo 55e518c9 is described below commit 55e518c9a8c988db31eba9db324c348a0336567b Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Fri Oct 14 16:41:50 2022 +0200 Bug 40619: Take translation from gitlab.tpo and not git.tpo --- import-translations.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/import-translations.sh b/import-translations.sh index e0b8c3ed..736dc2b2 100755 --- a/import-translations.sh +++ b/import-translations.sh @@ -62,7 +62,7 @@ then git fetch origin cd .. else - git clone https://git.torproject.org/translation.git + git clone https://gitlab.torproject.org/tpo/translation.git fi # Update each translated file for each locale. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch main updated: Bug 41306: Typo "will not able" in "Tor unexpectedly exited" dialog
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository torbutton. The following commit(s) were added to refs/heads/main by this push: new e5e1c5ec Bug 41306: Typo "will not able" in "Tor unexpectedly exited" dialog e5e1c5ec is described below commit e5e1c5ec8e6dd7285e382827789230dec70774ab Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Fri Oct 14 16:53:15 2022 +0200 Bug 41306: Typo "will not able" in "Tor unexpectedly exited" dialog --- chrome/locale/en-US/torlauncher.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/locale/en-US/torlauncher.properties b/chrome/locale/en-US/torlauncher.properties index e0b07f03..2e34c6e1 100644 --- a/chrome/locale/en-US/torlauncher.properties +++ b/chrome/locale/en-US/torlauncher.properties @@ -4,7 +4,7 @@ torlauncher.error_title=Tor Launcher torlauncher.tor_exited_during_startup=Tor exited during startup. This might be due to an error in your torrc file, a bug in Tor or another program on your system, or faulty hardware. Until you fix the underlying problem and restart Tor, Tor Browser will not start. -torlauncher.tor_exited=Tor unexpectedly exited. This might be due to a bug in Tor itself, another program on your system, or faulty hardware. Until you restart Tor, the Tor Browser will not able to reach any websites. If the problem persists, please send a copy of your Tor Log to the support team. +torlauncher.tor_exited=Tor unexpectedly exited. This might be due to a bug in Tor itself, another program on your system, or faulty hardware. Until you restart Tor, the Tor Browser will not be able to reach any websites. If the problem persists, please send a copy of your Tor Log to the support team. torlauncher.tor_exited2=Restarting Tor will not close your browser tabs. torlauncher.tor_controlconn_failed=Could not connect to Tor control port. torlauncher.tor_failed_to_start=Tor failed to start. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated (7be57d563a83 -> af6e4a55210f)
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a change to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. from 7be57d563a83 fixup! Bug 30237: Add v3 onion services client authentication prompt new 63c477f9c5b8 fixup! Add TorStrings module for localization new af6e4a55210f fixup! Firefox preference overrides. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: browser/app/profile/001-base-profile.js | 3 + browser/modules/TorStrings.jsm | 116 +++++++++++++++++++++----------- 2 files changed, 81 insertions(+), 38 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Bug 30237: Add v3 onion services client authentication prompt
by gitolite role 14 Oct '22

14 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 7be57d563a83 fixup! Bug 30237: Add v3 onion services client authentication prompt 7be57d563a83 is described below commit 7be57d563a8374c10cfd79d163af04f803f1bfa3 Author: hackademix <giorgio(a)maone.net> AuthorDate: Fri Oct 14 16:12:58 2022 +0100 fixup! Bug 30237: Add v3 onion services client authentication prompt --- .../components/onionservices/content/authPrompt.js | 27 ++++++++++++++-------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/browser/components/onionservices/content/authPrompt.js b/browser/components/onionservices/content/authPrompt.js index f9b92608ed65..889acc2c6f67 100644 --- a/browser/components/onionservices/content/authPrompt.js +++ b/browser/components/onionservices/content/authPrompt.js @@ -228,18 +228,27 @@ const OnionAuthPrompt = (function() { }, _onCancel() { - // Arrange for an error page to be displayed. + // Arrange for an error page to be displayed: + // we build a short script calling docShell.displayError() + // and we pass it as a data: URI to loadFrameScript(), + // which runs it in the content frame which triggered + // this authentication prompt. const failedURI = this._failedURI.spec; const errorCode = - this._reasonForPrompt === OnionAuthUtil.topic.clientAuthMissing - ? Cr.NS_ERROR_TOR_ONION_SVC_MISSING_CLIENT_AUTH - : Cr.NS_ERROR_TOR_ONION_SVC_BAD_CLIENT_AUTH; - - const io = `ChromeUtils.import("resource://gre/modules/Services.jsm").Services.io`; - this._browser.messageManager.loadFrameScript(`data:,${encodeURIComponent( - `docShell.displayLoadError(${errorCode}, ${io}.newURI(${JSON.stringify(failedURI)}), undefined, undefined);` + this._reasonForPrompt === OnionAuthUtil.topic.clientAuthMissing + ? Cr.NS_ERROR_TOR_ONION_SVC_MISSING_CLIENT_AUTH + : Cr.NS_ERROR_TOR_ONION_SVC_BAD_CLIENT_AUTH; + const io = + 'ChromeUtils.import("resource://gre/modules/Services.jsm").Services.io'; + + this._browser.messageManager.loadFrameScript( + `data:application/javascript,${encodeURIComponent( + `docShell.displayLoadError(${errorCode}, ${io}.newURI(${JSON.stringify( + failedURI + )}), undefined, undefined);` )}`, - false); + false + ); }, _getKeyElement() { -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated: Bug 40638: Update the update link of nightly builds
by gitolite role 13 Oct '22

13 Oct '22

This is an automated email from the git hooks/post-receive script. boklm pushed a commit to branch main in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/main by this push: new bf61fa9 Bug 40638: Update the update link of nightly builds bf61fa9 is described below commit bf61fa94cb3584537cfa01d4aca361f33f0faf0b Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Wed Oct 12 12:48:22 2022 +0200 Bug 40638: Update the update link of nightly builds --- tools/signing/nightly/update-responses-base-config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/signing/nightly/update-responses-base-config.yml b/tools/signing/nightly/update-responses-base-config.yml index 4d60565..2f18cd1 100644 --- a/tools/signing/nightly/update-responses-base-config.yml +++ b/tools/signing/nightly/update-responses-base-config.yml @@ -17,7 +17,7 @@ channels: versions: nightly_version: platformVersion: 68.2.0 - detailsURL: http://f4amtbsowhix7rrf.onion/ + detailsURL: http://umj4zbqdfcyevlkgqgpq6foxk3z75zzxsbgt5jqmfxofrbrjh3crbnad.onion/ migrate_langs: pt-PT: pt-BR minSupportedInstructionSet: SSE2 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.4.0esr-12.0-1 created (now df868fe98ed5)
by gitolite role 13 Oct '22

13 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a change to branch tor-browser-102.4.0esr-12.0-1 in repository tor-browser. at df868fe98ed5 Bug 1791520: Add some keep alive annotations. r=jandem a=pascalc No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] annotated tag FIREFOX_102_4_0esr_BUILD1 created (now 409c65cdec46)
by gitolite role 13 Oct '22

13 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a change to annotated tag FIREFOX_102_4_0esr_BUILD1 in repository tor-browser. at 409c65cdec46 (tag) tagging df868fe98ed5d25b9d6c2994d77f74929c938e78 (commit) replaces FIREFOX_102_3_0esr_RELEASE by Pier Angelo Vendrame on Thu Oct 13 09:50:35 2022 +0200 - Log ----------------------------------------------------------------- Hg tag FIREFOX_102_4_0esr_BUILD1 -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQCHOE9KLO2f598e8HwdW0XkBKIkQUCY0fDSwAKCRDwdW0XkBKI kZEmAP9gTX8gI5ceJ9AptjSbSTtllVq9zuPQtnJJyjnE+LslRAEAuX8RUtWTzNCp NFt9DPafLPaIpNSH4nFf3CB69OcVGQY= =FoLb -----END PGP SIGNATURE----- ----------------------------------------------------------------------- This annotated tag includes the following new commits: new 038f0a5b9e65 No bug - Tagging c2dd0f1c0adfb1fa1c5d9319fbe023d324c34db6 with FIREFOX_102_3_0esr_BUILD1 a=release CLOSED TREE DONTBUILD new b2d57aa8d7e0 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release new 3bad715d2155 No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM new 0520b32a8ad5 No bug - Tagging c2dd0f1c0adfb1fa1c5d9319fbe023d324c34db6 with FIREFOX_102_3_0esr_RELEASE a=release CLOSED TREE DONTBUILD new 6898d15b6cb6 Bug 1786292 - part 2: Switch cron-bouncer-check away from esr91 r=jcristau a=release new a86c6fca966f Bug 1788684 - exclude asus.com from HSTS preload list. r=dveditz, a=RyanVM new d36b48c834eb Bug 1786619 - Use fallback atomic operations on ARM < v7. r=jandem, a=RyanVM new 56dd7073d59e No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM new b3ec8115892a Bug 1791519 - use really non-resolving domain for bug529119 tests. r=MasterWayZ a=test-only DONTBUILD new 6e0190b97e38 No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM new e0fe7669b684 Bug 1789500 - filename sanitization may cut surrogate pairs when truncating. r=NeilDeakin, a=RyanVM new 2e252b3fae09 Bug 1791744 - stop updating esr-next bouncer aliases from esr102. r=jlorenzo a=RyanVM new d558f4a1c67a Bug 1789128 - Always call LoadInfo::GetPerformanceStorage(). r=smaug, a=RyanVM new 7c72e5abd9ac No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM new 02caa482963a Bug 1782523 - Update NodeJS to latest versions for the branches on ESR. r=nalexander, a=RyanVM new 6dfb82daf955 Bug 1792227 - Update node to v16.17.1. r=firefox-build-system-reviewers,ahochheiden a=RyanVM new f1fd4e6b8661 Bug 1792882 - test_interfaces.js should not check pref values. r=smaug, a=test-only new 80d14313ffc9 No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings - a=repo-update new 3e6532cd0aac Bug 1786521 - Fix AppearanceValueAffectsFrames. r=TYLin, a=RyanVM new e2a1f537e938 Bug 1791363 - Process newly added marking work after performing delayed marking r=sfink a=RyanVM new aa76591919e4 Bug 1791363 - Rename GCMarker::color to avoid confusion with local variables r=sfink a=RyanVM new 26b0c88bd2a3 Bug 1771125 - Don't bother trying to start the font-info loader if we're already shutting down. r=lsalzman, a=RyanVM new f0440910d05c Bug 1786259 - Avoid potential deadlock via AddWithLegacyFamilyName when shared-fontlist is disabled (incl. safe mode). r=gfx-reviewers,aosmond a=RyanVM new 4d1d82153e09 Bug 1786910: Ignore 'align-content' when determining the aligned static position of abspos flex children. r=TYLin a=RyanVM new 41a59ed1ffa0 Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=sgalich, a=RyanVM new 913a8d6871eb Bug 1789874 - Fix colors used by nsListControlFrame::PaintFocus. r=mstange a=pascalc new 7b585baebb2c Bug 1789439 - Don't allow reentrant programmatic print calls. r=smaug,peterv a=pascalc new 6d5378a68f99 Bug 1789439 - Throw rather than logging an error when tab-modal print is already open. r=mstriemer a=pascalc new 31bcb9ab3723 Bug 1789439 - Fix browser_modal_print.js after previous patch. a=pascalc new 548cefc6653f No Bug, mozilla-esr102 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=pascalc new 70f4241cddc2 Bug 1792076 - add new hg.mozilla.org certificate fingerprint to run-task. r=dhouse, a=release new 4bc6e9abbce9 Bug 1794064 - Block older crash-prone versions of Avast Antivirus. r=gcp, a=RyanVM new 48a0b7d3e99c Bug 1792041 - Add a value for DEL to kBase64URLDecodeTable and have static asserts for lookup tables' length. r=xpcom-reviewers,nika a=RyanVM new 0fa01d6241a0 Bug 1789729 - Implement webgl.max-size-per-texture-mib r=jgilbert a=RyanVM new e5de4757b46f Bug 1792008 - Check size when mNotLost->mCanvasRenderer is re-used r=lsalzman,gfx-reviewers a=RyanVM new df868fe98ed5 Bug 1791520: Add some keep alive annotations. r=jandem a=pascalc The 36 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 35

[tor-browser] branch tor-browser-91.13.0esr-11.5-1 updated: fixup! Bug 30237: Add v3 onion services client authentication prompt
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-91.13.0esr-11.5-1 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-91.13.0esr-11.5-1 by this push: new 12b66ca40d05 fixup! Bug 30237: Add v3 onion services client authentication prompt 12b66ca40d05 is described below commit 12b66ca40d059552825714fd7cfb7563bb59ae45 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Sat Oct 8 04:00:00 2022 +0000 fixup! Bug 30237: Add v3 onion services client authentication prompt - strip subdomain off of onion hostname when extracting the onion service id for use with the ONION_CLIENT_AUTH_ADD command --- browser/components/onionservices/content/authPrompt.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/browser/components/onionservices/content/authPrompt.js b/browser/components/onionservices/content/authPrompt.js index df609df44e49..1cc298a89a02 100644 --- a/browser/components/onionservices/content/authPrompt.js +++ b/browser/components/onionservices/content/authPrompt.js @@ -16,7 +16,7 @@ const OnionAuthPrompt = (function() { this._browser = aBrowser; this._failedURI = aFailedURI; this._reasonForPrompt = aReason; - this._onionName = aOnionName; + this._onionHostname = aOnionName; } OnionServicesAuthPrompt.prototype = { @@ -93,7 +93,7 @@ const OnionAuthPrompt = (function() { descElem.appendChild(span); span = xulDoc.createElementNS(kHTMLNS, "span"); span.id = OnionAuthUtil.domid.onionNameSpan; - span.textContent = this._onionName; + span.textContent = this._onionHostname; descElem.appendChild(span); span = xulDoc.createElementNS(kHTMLNS, "span"); span.textContent = suffix; @@ -177,10 +177,14 @@ const OnionAuthPrompt = (function() { console.error(controllerFailureMsg, aError); this.show(controllerFailureMsg); }); - let onionAddr = this._onionName.toLowerCase().replace(/\.onion$/, ""); + // ^(subdomain.)*onionserviceid.onion$ (case-insensitive) + const onionServiceIdRegExp = /^(.*\.)*(?<onionServiceId>[a-z2-7]{56})\.onion$/i; + // match() will return null on bad match, causing throw + const onionServiceId = this._onionHostname.match(onionServiceIdRegExp).groups.onionServiceId.toLowerCase(); + let checkboxElem = this._getCheckboxElement(); - let isPermanent = (checkboxElem && checkboxElem.checked); - torController.onionAuthAdd(onionAddr, base64key, isPermanent) + let isPermanent = checkboxElem && checkboxElem.checked; + torController.onionAuthAdd(onionServiceId, base64key, isPermanent) .then(aResponse => { // Success! Reload the page. this._browser.sendMessageToActor( -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Bug 30237: Add v3 onion services client authentication prompt
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 400276c6eba4 fixup! Bug 30237: Add v3 onion services client authentication prompt 400276c6eba4 is described below commit 400276c6eba41ada1c93acd7f24a3412e1077961 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Sat Oct 8 04:00:00 2022 +0000 fixup! Bug 30237: Add v3 onion services client authentication prompt - strip subdomain off of onion hostname when extracting the onion service id for use with the ONION_CLIENT_AUTH_ADD command --- browser/components/onionservices/content/authPrompt.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/browser/components/onionservices/content/authPrompt.js b/browser/components/onionservices/content/authPrompt.js index ba40e9fd464c..f9b92608ed65 100644 --- a/browser/components/onionservices/content/authPrompt.js +++ b/browser/components/onionservices/content/authPrompt.js @@ -18,7 +18,7 @@ const OnionAuthPrompt = (function() { this._browser = aBrowser; this._failedURI = aFailedURI; this._reasonForPrompt = aReason; - this._onionName = aOnionName; + this._onionHostname = aOnionName; } OnionServicesAuthPrompt.prototype = { @@ -103,7 +103,7 @@ const OnionAuthPrompt = (function() { descElem.appendChild(span); span = xulDoc.createElementNS(kHTMLNS, "span"); span.id = OnionAuthUtil.domid.onionNameSpan; - span.textContent = this._onionName; + span.textContent = this._onionHostname; descElem.appendChild(span); span = xulDoc.createElementNS(kHTMLNS, "span"); span.textContent = suffix; @@ -196,11 +196,15 @@ const OnionAuthPrompt = (function() { console.error(controllerFailureMsg, aError); this.show(controllerFailureMsg); }); - let onionAddr = this._onionName.toLowerCase().replace(/\.onion$/, ""); + // ^(subdomain.)*onionserviceid.onion$ (case-insensitive) + const onionServiceIdRegExp = /^(.*\.)*(?<onionServiceId>[a-z2-7]{56})\.onion$/i; + // match() will return null on bad match, causing throw + const onionServiceId = this._onionHostname.match(onionServiceIdRegExp).groups.onionServiceId.toLowerCase(); + let checkboxElem = this._getCheckboxElement(); let isPermanent = checkboxElem && checkboxElem.checked; torController - .onionAuthAdd(onionAddr, base64key, isPermanent) + .onionAuthAdd(onionServiceId, base64key, isPermanent) .then(aResponse => { // Success! Reload the page. this._browser.sendMessageToActor( -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Bug 30237: Add v3 onion services client authentication prompt
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new caa5988884a3 fixup! Bug 30237: Add v3 onion services client authentication prompt caa5988884a3 is described below commit caa5988884a3dc6e60047ad246abd56d84fa11ad Author: hackademix <giorgio(a)maone.net> AuthorDate: Wed Oct 12 19:17:53 2022 +0200 fixup! Bug 30237: Add v3 onion services client authentication prompt --- .../components/onionservices/content/authPrompt.js | 18 +++++++++++------- browser/components/onionservices/content/authUtil.jsm | 19 ------------------- browser/components/sessionstore/SessionStore.jsm | 5 ----- browser/themes/shared/aboutNetError.css | 7 +++++++ docshell/base/nsDocShell.cpp | 6 ++++-- 5 files changed, 22 insertions(+), 33 deletions(-) diff --git a/browser/components/onionservices/content/authPrompt.js b/browser/components/onionservices/content/authPrompt.js index 14fb334a6206..ba40e9fd464c 100644 --- a/browser/components/onionservices/content/authPrompt.js +++ b/browser/components/onionservices/content/authPrompt.js @@ -225,13 +225,17 @@ const OnionAuthPrompt = (function() { _onCancel() { // Arrange for an error page to be displayed. - this._browser.messageManager.sendAsyncMessage( - OnionAuthUtil.message.authPromptCanceled, - { - failedURI: this._failedURI.spec, - reasonForPrompt: this._reasonForPrompt, - } - ); + const failedURI = this._failedURI.spec; + const errorCode = + this._reasonForPrompt === OnionAuthUtil.topic.clientAuthMissing + ? Cr.NS_ERROR_TOR_ONION_SVC_MISSING_CLIENT_AUTH + : Cr.NS_ERROR_TOR_ONION_SVC_BAD_CLIENT_AUTH; + + const io = `ChromeUtils.import("resource://gre/modules/Services.jsm").Services.io`; + this._browser.messageManager.loadFrameScript(`data:,${encodeURIComponent( + `docShell.displayLoadError(${errorCode}, ${io}.newURI(${JSON.stringify(failedURI)}), undefined, undefined);` + )}`, + false); }, _getKeyElement() { diff --git a/browser/components/onionservices/content/authUtil.jsm b/browser/components/onionservices/content/authUtil.jsm index 82a835359b3e..7157acf2e11d 100644 --- a/browser/components/onionservices/content/authUtil.jsm +++ b/browser/components/onionservices/content/authUtil.jsm @@ -24,23 +24,4 @@ const OnionAuthUtil = { warningElement: "tor-clientauth-warning", checkboxElement: "tor-clientauth-persistkey-checkbox", }, - - addCancelMessageListener(aMessageManager, aDocShell) { - aMessageManager.addMessageListener(this.message.authPromptCanceled, { - receiveMessage(aMessage) { - // Upon cancellation of the client authentication prompt, display - // the appropriate error page. When calling the docShell - // displayLoadError() function, we pass undefined for the failed - // channel so that displayLoadError() can determine that it should - // not display the client authentication prompt a second time. - const failedURI = Services.io.newURI(aMessage.data.failedURI); - const reasonForPrompt = aMessage.data.reasonForPrompt; - const errorCode = - reasonForPrompt === this.topic.clientAuthMissing - ? Cr.NS_ERROR_TOR_ONION_SVC_MISSING_CLIENT_AUTH - : Cr.NS_ERROR_TOR_ONION_SVC_BAD_CLIENT_AUTH; - aDocShell.displayLoadError(errorCode, failedURI, undefined, undefined); - }, - }); - }, }; diff --git a/browser/components/sessionstore/SessionStore.jsm b/browser/components/sessionstore/SessionStore.jsm index 58c5a4fed6ca..4611737ca918 100644 --- a/browser/components/sessionstore/SessionStore.jsm +++ b/browser/components/sessionstore/SessionStore.jsm @@ -234,10 +234,6 @@ ChromeUtils.defineModuleGetter( "resource://gre/modules/sessionstore/SessionHistory.jsm" ); -const { OnionAuthUtil } = ChromeUtils.import( - "chrome://browser/content/onionservices/authUtil.jsm" -); - XPCOMUtils.defineLazyServiceGetters(this, { gScreenManager: ["@mozilla.org/gfx/screenmanager;1", "nsIScreenManager"], }); @@ -1514,7 +1510,6 @@ var SessionStoreInternal = { let listenWhenClosed = CLOSED_MESSAGES.has(msg); mm.addMessageListener(msg, this, listenWhenClosed); }); - OnionAuthUtil.addCancelMessageListener(mm, aWindow.docShell); // Load the frame script after registering listeners. if (!Services.appinfo.sessionHistoryInParent) { diff --git a/browser/themes/shared/aboutNetError.css b/browser/themes/shared/aboutNetError.css index 73f9d2760a15..438cc5782291 100644 --- a/browser/themes/shared/aboutNetError.css +++ b/browser/themes/shared/aboutNetError.css @@ -8,6 +8,13 @@ body { --warning-color: #ffa436; } +body.onionAuthPrompt { + background: white; +} +.onionAuthPrompt > * { + display: none; +} + @media (prefers-color-scheme: dark) { body { --warning-color: #ffbd4f; diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp index 95c68c34fd7f..22577e45643a 100644 --- a/docshell/base/nsDocShell.cpp +++ b/docshell/base/nsDocShell.cpp @@ -3902,8 +3902,10 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI* aURI, // if the user cancels the Tor client auth prompt, but in that case we // will not have a failed channel and therefore we will not prompt again. if (isOnionAuthError && aFailedChannel) { - // Display about:blank while the Tor client auth prompt is open. - errorPage.AssignLiteral("blank"); + // Display about:neterror with a style emulating about:blank while the + // Tor client auth prompt is open. Do not use about:blank directly: it + // will mess with the failed channel information persistence! + cssClass.AssignLiteral("onionAuthPrompt"); } } -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated (5293cbaea3eb -> cbb8519e4368)
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. from 5293cbaea3eb fixup! Base Browser's .mozconfigs. new 04a76db04926 fixup! Base Browser's .mozconfigs. new cbb8519e4368 fixup! Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: modules/libpref/init/all.js | 2 +- mozconfig-linux-x86_64-dev | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser-spec] branch main updated: Bug 40023: FF94 Audit
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch main in repository tor-browser-spec. The following commit(s) were added to refs/heads/main by this push: new 07a365b Bug 40023: FF94 Audit 07a365b is described below commit 07a365bf04def6941ecbcd288b6c8d9fad4e40bf Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Oct 11 19:58:15 2022 +0000 Bug 40023: FF94 Audit --- audits/FF94_AUDIT | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/audits/FF94_AUDIT b/audits/FF94_AUDIT new file mode 100644 index 0000000..b3a48fb --- /dev/null +++ b/audits/FF94_AUDIT @@ -0,0 +1,83 @@ +Tracking Issue: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40… + +# General + +The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript). + +The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation. + +code_audit.sh contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit. + +## Firefox + +### Repo: https://github.com/mozilla/gecko-dev.git + +- Start: `5f4358c1c5bc2ca87d60eadebeab439562c90495` ( `FIREFOX_RELEASE_94_BASE` ) +- End: `6c9b6e1483551f220cd409e4e584349bc74a8231` ( `FIREFOX_RELEASE_95_BASE` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +(mostly) only tests triggered matches or false positives + +--- + +## Application Services + +### Repo: https://github.com/mozilla/application-services.git + +- Start: `b1f371719ca20db642b64a0e860b4ecb0aaf316f` ( v86.1.0 ) +- End: `df1a47fde89f49201b1e839f960e8f16eb95a55d` ( v87.1.0 ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +## Android Components + +### Repo: https://github.com/mozilla-mobile/android-components.git + +- Start: `fce7eb5cff2d56acd3195bf1d9a89386c63dc3d5` ( `v94.0.0` ) +- End: `28c1b7db40105dcaea09caa0b5108554a83959cd` ( `v94.0.15` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Fenix + +### Repo: https://github.com/mozilla-mobile/fenix.git + +- Start: 54d80751bfc9a4aa4341e78221060940a36e3d17 ( v94.0.0-beta.1 ) +- End: cb5708f88847601426833067f93d16d25d36451f ( v94.1.2 ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Ticket Review ## + +### Review List + +#### 94 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=F… + +- https://bugzilla.mozilla.org/show_bug.cgi?id=1730418 : @ma1 https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41123 + - Nothing to do here +- https://bugzilla.mozilla.org/show_bug.cgi?id=1732388: @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41124 + - Disabled by network.proxy.allow_bypass = false + -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated: Bug 40585: Prune the manual more
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/main by this push: new 2fd9760 Bug 40585: Prune the manual more 2fd9760 is described below commit 2fd9760aa3982e58a2b8c6881cea9046bac49326 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Mon Oct 10 18:45:02 2022 +0200 Bug 40585: Prune the manual more --- projects/manual/build | 14 +++++++++++--- projects/manual/config | 2 +- projects/manual/packagemanual.py | 21 ++++++++++++++++++++- 3 files changed, 32 insertions(+), 5 deletions(-) diff --git a/projects/manual/build b/projects/manual/build index d569632..d6d5c74 100644 --- a/projects/manual/build +++ b/projects/manual/build @@ -5,7 +5,15 @@ mkdir -p chrome/browser/content/browser/manual unzip $rootdir/[% c('input_files_by_name/manual') %] python3 $rootdir/[% c('input_files_by_name/package_script') %] public chrome/browser/content/browser/manual +pushd chrome/browser/content/browser/manual/static +find -name '*.map' -delete +rm -rf fonts +rm -rf css/digital-climate-strike css/images +# We prune unused images in the Python script, but empty directories remain +find images -type d -empty -delete +popd + [% c('tar', { - tar_src => [ 'chrome' ], - tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), - }) %] + tar_src => [ 'chrome' ], + tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), + }) %] diff --git a/projects/manual/config b/projects/manual/config index 4fe9356..9112864 100644 --- a/projects/manual/config +++ b/projects/manual/config @@ -2,7 +2,7 @@ # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! version: 50953 -filename: 'manual-[% c("version") %].tar.gz' +filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 diff --git a/projects/manual/packagemanual.py b/projects/manual/packagemanual.py index f4a3b98..7af5104 100755 --- a/projects/manual/packagemanual.py +++ b/projects/manual/packagemanual.py @@ -31,10 +31,20 @@ def clean_urls(match): return f'href="#{slug}{anchor}"' +remove_images = [] +for p in (source / 'static/images').glob('**/*'): + if p.is_file(): + rel = p.relative_to(source) + remove_images.append(rel) + htmls = source.rglob(f'{PAGE_NAME}/index.html') for page in htmls: with page.open(encoding='utf8') as f: contents = f.read() + + remove_images = list(filter( + lambda im: contents.find(str(im)) == -1, remove_images)) + contents = static_re.sub(f'"{STATIC_PATH}/\\1"', contents) contents = link_re.sub(clean_urls, contents) @@ -46,5 +56,14 @@ for page in htmls: with (target / dest_name).open('w', encoding='utf8') as f: f.write(contents) + +def ignore_images(path, names): + return [ + n + for n in names + if Path(path, n).relative_to(source) in remove_images + ] + + shutil.rmtree(target / 'static', ignore_errors=True) -shutil.copytree(source / 'static', target / 'static') +shutil.copytree(source / 'static', target / 'static', ignore=ignore_images) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch maint-11.5 updated: Bug 41355: Adjust line spacing in YEC 2022 heading
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch maint-11.5 in repository torbutton. The following commit(s) were added to refs/heads/maint-11.5 by this push: new 042f1687 Bug 41355: Adjust line spacing in YEC 2022 heading 042f1687 is described below commit 042f1687e38915803b1e25bb19b28af2256ca2d2 Author: Henry Wilkes <henry(a)torproject.org> AuthorDate: Wed Oct 12 09:58:44 2022 +0100 Bug 41355: Adjust line spacing in YEC 2022 heading --- chrome/skin/aboutTor.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/skin/aboutTor.css b/chrome/skin/aboutTor.css index 2ea6807e..5c75c1f0 100644 --- a/chrome/skin/aboutTor.css +++ b/chrome/skin/aboutTor.css @@ -206,7 +206,7 @@ body:not([showmanual]) .showForManual { * yec-background-image, even if one of the sub-heading elements has long text * content that would normally grow the size of the grid. */ width: 1px; - line-height: 1; + line-height: 1.05; font-family: 'Space Grotesk', sans-serif; font-size: 60px; letter-spacing: -0.05em; -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Base Browser's .mozconfigs.
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 5293cbaea3eb fixup! Base Browser's .mozconfigs. 5293cbaea3eb is described below commit 5293cbaea3eb835ce8173513b4fd862101ad58a5 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Tue Oct 11 19:23:07 2022 +0200 fixup! Base Browser's .mozconfigs. Bug 41131: Disable background tasks in all platforms, and the update agent in Windows and macOS. --- browser/config/mozconfigs/base-browser | 3 +++ mozconfig-macos-x86_64 | 3 +++ mozconfig-windows-i686 | 3 +++ mozconfig-windows-x86_64 | 3 +++ 4 files changed, 12 insertions(+) diff --git a/browser/config/mozconfigs/base-browser b/browser/config/mozconfigs/base-browser index 285f43fec4ef..82b224f43ed1 100644 --- a/browser/config/mozconfigs/base-browser +++ b/browser/config/mozconfigs/base-browser @@ -30,6 +30,9 @@ ac_add_options --enable-proxy-bypass-protection # could allow proxy bypass, and override a number of other preferences we set ac_add_options --disable-system-policies +# See bug #41131 +ac_add_options --disable-backgroundtasks + ac_add_options --enable-base-browser # Disable telemetry diff --git a/mozconfig-macos-x86_64 b/mozconfig-macos-x86_64 index e2286f972e62..b81001df5633 100644 --- a/mozconfig-macos-x86_64 +++ b/mozconfig-macos-x86_64 @@ -2,4 +2,7 @@ ac_add_options --enable-strip +# See bug #41131 +ac_add_options --disable-update-agent + ac_add_options --enable-tor-browser-data-outside-app-dir diff --git a/mozconfig-windows-i686 b/mozconfig-windows-i686 index 78ff05ecc810..afe083885bfc 100644 --- a/mozconfig-windows-i686 +++ b/mozconfig-windows-i686 @@ -9,3 +9,6 @@ ac_add_options --enable-strip ac_add_options --disable-bits-download ac_add_options --disable-maintenance-service ac_add_options --disable-default-browser-agent + +# See bug #41131 +ac_add_options --disable-update-agent diff --git a/mozconfig-windows-x86_64 b/mozconfig-windows-x86_64 index 93b7a28fd361..67bc37c4e5ff 100644 --- a/mozconfig-windows-x86_64 +++ b/mozconfig-windows-x86_64 @@ -9,3 +9,6 @@ ac_add_options --enable-strip ac_add_options --disable-bits-download ac_add_options --disable-maintenance-service ac_add_options --disable-default-browser-agent + +# See bug #41131 +ac_add_options --disable-update-agent -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Bug 40926: Implemented the New Identity feature
by gitolite role 11 Oct '22

11 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 63cfb5cfbc2b fixup! Bug 40926: Implemented the New Identity feature 63cfb5cfbc2b is described below commit 63cfb5cfbc2b770413a7a03d5dd906ef5de1ccbd Author: Henry Wilkes <henry(a)torproject.org> AuthorDate: Tue Oct 11 10:57:47 2022 +0100 fixup! Bug 40926: Implemented the New Identity feature --- browser/components/newidentity/content/newidentity.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/newidentity/content/newidentity.js b/browser/components/newidentity/content/newidentity.js index 67a00dbc6f75..466cf437d90a 100644 --- a/browser/components/newidentity/content/newidentity.js +++ b/browser/components/newidentity/content/newidentity.js @@ -527,7 +527,7 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { const askAgain = { value: false }; const confirmed = Services.prompt.confirmEx( - null, + window, "", NewIdentityStrings.new_identity_prompt, flags, -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
by gitolite role 11 Oct '22

11 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 7151a4d466bc fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing 7151a4d466bc is described below commit 7151a4d466bc3e40aae96831dad5e2cfd0281205 Author: cypherpunks1 <2478-cypherpunks1(a)gitlab.torproject.org> AuthorDate: Fri Sep 30 09:02:51 2022 +0300 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing --- browser/components/search/extensions/startpage/manifest.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/browser/components/search/extensions/startpage/manifest.json b/browser/components/search/extensions/startpage/manifest.json index 18041d3a2f83..497373ec17a2 100644 --- a/browser/components/search/extensions/startpage/manifest.json +++ b/browser/components/search/extensions/startpage/manifest.json @@ -1,6 +1,6 @@ { "name": "Startpage", - "description": "Start Page", + "description": "Startpage", "manifest_version": 2, "version": "1.0", "applications": { @@ -18,9 +18,9 @@ "chrome_settings_overrides": { "search_provider": { "name": "Startpage", - "search_url": "https://startpage.com/sp/search", - "search_form": "https://startpage.com/sp/search/", - "search_url_post_params": "q={searchTerms}&segment=startpage.tor" + "search_url": "https://www.startpage.com/sp/search", + "search_form": "https://www.startpage.com/sp/search/", + "search_url_post_params": "q={searchTerms}" } } } -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0