tbb-commits
Threads by month
- ----- 2025 -----
- July
- June
- May
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- 1 participants
- 18632 discussions

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-12.0.7-build1
by richard (@richard) 01 Jun '23
by richard (@richard) 01 Jun '23
01 Jun '23
richard pushed new tag mb-12.0.7-build1 at The Tor Project / Applications / tor-browser-build
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][maint-12.0-mullvad] Bug 40862: Prepare Mullvad Browser Release 12.0.7
by richard (@richard) 01 Jun '23
by richard (@richard) 01 Jun '23
01 Jun '23
richard pushed to branch maint-12.0-mullvad at The Tor Project / Applications / tor-browser-build
Commits:
3b86eb93 by Richard Pospesel at 2023-06-01T18:27:26+00:00
Bug 40862: Prepare Mullvad Browser Release 12.0.7
- - - - -
3 changed files:
- projects/browser/config
- projects/firefox/config
- rbm.conf
Changes:
=====================================
projects/browser/config
=====================================
@@ -103,9 +103,9 @@ input_files:
enable: '[% ! c("var/android") %]'
- filename: Bundle-Data
enable: '[% ! c("var/android") %]'
- - URL: https://addons.mozilla.org/firefox/downloads/file/4090970/noscript-11.4.21.…
+ - URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.…
name: noscript
- sha256sum: 0fd3b66a2780d03a5b3cd460216105f3df2b27c6d3a552c1769c5de48c9e2338
+ sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e
- URL: https://addons.mozilla.org/firefox/downloads/file/4103048/ublock_origin-1.4…
name: ublock-origin
sha256sum: 39266486f720cd31d291d2fdad78625b079782a05517e1936eec7e780bc2a84d
=====================================
projects/firefox/config
=====================================
@@ -11,7 +11,7 @@ container:
use_container: 1
var:
- firefox_platform_version: 102.11.0
+ firefox_platform_version: 102.12.0
firefox_version: '[% c("var/firefox_platform_version") %]esr'
browser_series: '12.0'
browser_branch: '[% c("var/browser_series") %]-1'
=====================================
rbm.conf
=====================================
@@ -71,13 +71,14 @@ buildconf:
git_signtag_opt: '-s'
var:
- torbrowser_version: '12.0.6'
+ torbrowser_version: '12.0.7'
torbrowser_build: 'build1'
torbrowser_incremental_from:
# Build incrementals also from 12.0.4 until we have a new certificate for
# Windows installers.
- 12.0.4
- 12.0.5
+ - 12.0.6
updater_enabled: 1
build_mar: 1
mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]'
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][maint-12.0-mullvad] Bug 40870: Remove URL without browser name from...
by boklm (@boklm) 01 Jun '23
by boklm (@boklm) 01 Jun '23
01 Jun '23
boklm pushed to branch maint-12.0-mullvad at The Tor Project / Applications / tor-browser-build
Commits:
c44f6462 by Nicolas Vigier at 2023-06-01T17:58:37+02:00
Bug 40870: Remove URL without browser name from signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
- - - - -
1 changed file:
- tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
Changes:
=====================================
tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
=====================================
@@ -10,7 +10,6 @@ do
tmpfile=$(mktemp)
chmod 644 "$tmpfile"
for url in \
- "https://people.torproject.org/~$builder/builds/$tbb_version-build$tbb_versi…" \
"https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \
"https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \
"https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…"
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40869: Temporarily set obfs4 to a fixed commit
by richard (@richard) 01 Jun '23
by richard (@richard) 01 Jun '23
01 Jun '23
richard pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
40298e79 by Nicolas Vigier at 2023-06-01T15:56:56+00:00
Bug 40869: Temporarily set obfs4 to a fixed commit
To avoid broken nightly builds, we set obfs4 nightly to a fixed commit,
until the changes required by the renaming from obfs4 to lyrebird are
done.
- - - - -
1 changed file:
- projects/obfs4/config
Changes:
=====================================
projects/obfs4/config
=====================================
@@ -13,7 +13,8 @@ var:
targets:
nightly:
- git_hash: main
+ # Set fixed commit until tor-browser-build#40869 is done
+ git_hash: a34b4cad6d3c20f4abdec357e01101751a583f88
version: '[% c("abbrev") %]'
tag_gpg_id: 0
var:
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40870: Remove URL without browser name from...
by boklm (@boklm) 01 Jun '23
by boklm (@boklm) 01 Jun '23
01 Jun '23
boklm pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
96b1718f by Nicolas Vigier at 2023-05-31T12:58:55+02:00
Bug 40870: Remove URL without browser name from signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
- - - - -
1 changed file:
- tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
Changes:
=====================================
tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo
=====================================
@@ -10,7 +10,6 @@ do
tmpfile=$(mktemp)
chmod 644 "$tmpfile"
for url in \
- "https://people.torproject.org/~$builder/builds/$tbb_version-build$tbb_versi…" \
"https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \
"https://tb-build-04.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \
"https://tb-build-05.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…"
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-12.0.7-build1
by richard (@richard) 01 Jun '23
by richard (@richard) 01 Jun '23
01 Jun '23
richard pushed new tag tbb-12.0.7-build1 at The Tor Project / Applications / tor-browser-build
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][maint-12.0] Bug 40859: Prepare stable release 12.0.7
by richard (@richard) 01 Jun '23
by richard (@richard) 01 Jun '23
01 Jun '23
richard pushed to branch maint-12.0 at The Tor Project / Applications / tor-browser-build
Commits:
a4c88083 by Richard Pospesel at 2023-05-31T18:32:49+00:00
Bug 40859: Prepare stable release 12.0.7
- - - - -
9 changed files:
- projects/browser/Bundle-Data/Docs/ChangeLog.txt
- projects/browser/allowed_addons.json
- projects/browser/config
- projects/firefox/config
- projects/geckoview/config
- projects/manual/config
- projects/openssl/config
- projects/translation/config
- rbm.conf
Changes:
=====================================
projects/browser/Bundle-Data/Docs/ChangeLog.txt
=====================================
@@ -1,3 +1,52 @@
+Tor Browser 12.0.7 - May 31 2023
+ * All Platforms
+ * Updated Translations
+ * Updated NoScript to 11.4.22
+ * Updated OpenSSL to 1.1.1u
+ * Bug 41764: TTP-02-004 OOS: No user-activation required to download files (Low) [tor-browser]
+ * Bug 41794: Rebase Tor Browser and Base Browser stable to 102.12esr [tor-browser]
+ * Windows + macOS + Linux
+ * Updated Firefox to 102.12esr
+ * Bug 41777: Internally shippped manual does not adapt to RTL languages (it always align to the left) [tor-browser]
+ * Android
+ * Updated GeckoView to 102.12esr
+ * Bug 41805: Backport Android-specific security fixes from Firefox 114 to ESR 102.12-based Tor Browser [tor-browser]
+
+Tor Browser 12.5a6 - May 22 2023
+ * All Platforms
+ * Updated Translations
+ * Updated Go to 11.9.9
+ * Bug 40860: Improve the transition from the old fontconfig file to the new one [tor-browser-build]
+ * Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key [tor-browser]
+ * Bug 41738: Replace the patch to disable live reload with its preference [tor-browser]
+ * Bug 41757: Rebase Tor Browser Alpha to 102.11.0esr [tor-browser]
+ * Bug 41763: TTP-02-003 WP1: Data URI allows JS execution despite safest security level (Low) [tor-browser]
+ * Bug 41764: TTP-02-004 OOS: No user-activation required to download files (Low) [tor-browser]
+ * Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp [tor-browser]
+ * Windows + macOS + Linux
+ * Updated Firefox to 102.11esr
+ * Bug 41607: Update "New Circuit" icon [tor-browser]
+ * Bug 41736: Customize the default CustomizableUI toolbar using CustomizableUI.jsm [tor-browser]
+ * Bug 41770: Keyboard navigation broken leaving the toolbar tor circuit button [tor-browser]
+ * Bug 41777: Internally shippped manual does not adapt to RTL languages (it always align to the left) [tor-browser]
+ * Windows + Linux
+ * Bug 41654: UpdateInfo jumped into Data [tor-browser]
+ * Linux
+ * Bug 41732: implement linux font whitelist as defense-in-depth [tor-browser]
+ * Bug 41776: System fonts are temporarily leaked on Linux after the browser is updated from 12.5a4 or earlier [tor-browser]
+ * Android
+ * Updated GeckoView to 102.11esr
+ * Build System
+ * All Platforms
+ * Bug 33953: Provide a way for easily updating Go dependencies of projects [tor-browser-build]
+ * Bug 40673: Avoid building each go module separately [tor-browser-build]
+ * Bug 40818: Enable wasm target for rust compiler [tor-browser-build]
+ * Bug 40841: Adapt signing scripts to new signing machines [tor-browser-build]
+ * Bug 40849: Move Go dependencies to the projects dependent on them, not as a standalone projects [tor-browser-build]
+ * Bug 40856: Unblock nightly builds [tor-browser-build]
+ * Windows
+ * Bug 40846: Temporarily disable Windows signing [tor-browser-build]
+
Tor Browser 12.0.6 - May 09 2023
* All Platforms
* Updated Translations
=====================================
projects/browser/allowed_addons.json
=====================================
@@ -17,7 +17,7 @@
"picture_url": "https://addons.mozilla.org/user-media/userpics/34/9734/13299734/13299734.pn…"
}
],
- "average_daily_users": 976883,
+ "average_daily_users": 973594,
"categories": {
"android": [
"experimental",
@@ -221,10 +221,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.5607,
- "bayesian_average": 4.559531365183289,
- "count": 4987,
- "text_count": 1578
+ "average": 4.5606,
+ "bayesian_average": 4.559432842250225,
+ "count": 5014,
+ "text_count": 1582
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/reviews/",
"requires_payment": false,
@@ -321,7 +321,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/versions/",
- "weekly_downloads": 24385
+ "weekly_downloads": 24071
},
"notes": null
},
@@ -337,7 +337,7 @@
"picture_url": "https://addons.mozilla.org/user-media/userpics/56/7656/6937656/6937656.png?…"
}
],
- "average_daily_users": 258784,
+ "average_daily_users": 254357,
"categories": {
"android": [
"security-privacy"
@@ -553,10 +553,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.8166,
- "bayesian_average": 4.811948101281903,
- "count": 1336,
- "text_count": 237
+ "average": 4.8142,
+ "bayesian_average": 4.809547541054201,
+ "count": 1340,
+ "text_count": 238
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/reviews/",
"requires_payment": false,
@@ -641,7 +641,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/versions/",
- "weekly_downloads": 3623
+ "weekly_downloads": 3420
},
"notes": null
},
@@ -657,7 +657,7 @@
"picture_url": "https://addons.mozilla.org/user-media/userpics/73/4073/5474073/5474073.png?…"
}
],
- "average_daily_users": 1128787,
+ "average_daily_users": 1107746,
"categories": {
"android": [
"security-privacy"
@@ -669,7 +669,7 @@
"contributions_url": "https://paypal.me/SupportEFF?utm_content=product-page-contribute&utm_medium…",
"created": "2014-05-01T18:23:16Z",
"current_version": {
- "id": 5520250,
+ "id": 5564707,
"compatibility": {
"firefox": {
"min": "60.0",
@@ -680,7 +680,7 @@
"max": "*"
}
},
- "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…",
+ "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…",
"is_strict_compatibility_enabled": false,
"license": {
"id": 6,
@@ -691,22 +691,22 @@
"url": "http://www.gnu.org/licenses/gpl-3.0.html"
},
"release_notes": {
- "en-US": "<ul><li>Added a note to the popup to explain that if you would like to log into websites with your Google account, you need to fully allow <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/361ac6552f690217a6c9f0…" rel=\"nofollow\">accounts.google.com</a></li><li>Added dark theme support to widget replacement placeholders</li><li>Fixed blocking service worker-initiated requests in Chrome</li><li>Fixed various site breakages</li><li>Added Hindi translations</li><li>Improved Traditional Chinese translations</li></ul>"
+ "en-US": "<ul><li>Expanded protection for \"cookieblocked\" (slider set to yellow) domains. These domains are allowed to load without access to cookies, as a compromise to avoid breaking websites. However, sometimes the same domain is used to serve both unobjectionable content as well as obnoxious fingerprinters that do not need cookies to track your browsing. Privacy Badger will now fully block these fingerprinters.</li><li>Disabled Google's Topics API by default. The Topics API replaces Federated Learning of Cohorts (FLoC).</li><li>You can now see where Privacy Badger observed tracking by a given domain by clicking on the domain name in the list of tracking domains on the options page</li><li>Fixed various site breakages</li><li>Added Vietnamese translations</li><li>Improved translations (Finnish, French, Hebrew, Persian, European Portuguese, Russian, Spanish)</li></ul>"
},
- "reviewed": "2023-02-02T18:47:37Z",
- "version": "2023.1.31",
+ "reviewed": "2023-05-16T10:58:52Z",
+ "version": "2023.5.10",
"files": [
{
- "id": 4064595,
- "created": "2023-01-31T16:05:01Z",
- "hash": "sha256:0082d8ffe7b25f370a313d9b899b0c1ba1669b21b3a11791fe5ecf031aeb6a6c",
+ "id": 4109050,
+ "created": "2023-05-10T19:28:15Z",
+ "hash": "sha256:8ff7650d1ce133894293d1a3e268bb24d300e77a1c25488ed17846e71d8b33e8",
"is_restart_required": false,
"is_webextension": true,
"is_mozilla_signed_extension": false,
"platform": "all",
- "size": 1834581,
+ "size": 1975567,
"status": "public",
- "url": "https://addons.mozilla.org/firefox/downloads/file/4064595/privacy_badger17-…",
+ "url": "https://addons.mozilla.org/firefox/downloads/file/4109050/privacy_badger17-…",
"permissions": [
"tabs",
"http://*/*",
@@ -1134,7 +1134,7 @@
},
"is_disabled": false,
"is_experimental": false,
- "last_updated": "2023-02-02T18:47:37Z",
+ "last_updated": "2023-05-16T10:58:52Z",
"name": {
"en-US": "Privacy Badger"
},
@@ -1180,10 +1180,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.8012,
- "bayesian_average": 4.79841359051625,
- "count": 2223,
- "text_count": 426
+ "average": 4.8019,
+ "bayesian_average": 4.7991176799749775,
+ "count": 2236,
+ "text_count": 428
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/reviews/",
"requires_payment": false,
@@ -1207,7 +1207,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/versions/",
- "weekly_downloads": 18076
+ "weekly_downloads": 16871
},
"notes": null
},
@@ -1223,7 +1223,7 @@
"picture_url": null
}
],
- "average_daily_users": 6319454,
+ "average_daily_users": 6290605,
"categories": {
"android": [
"security-privacy"
@@ -1388,7 +1388,7 @@
},
"is_disabled": false,
"is_experimental": false,
- "last_updated": "2023-05-08T12:35:48Z",
+ "last_updated": "2023-05-30T13:20:46Z",
"name": {
"ar": "uBlock Origin",
"bg": "uBlock Origin",
@@ -1533,10 +1533,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.7808,
- "bayesian_average": 4.780398687268275,
- "count": 15366,
- "text_count": 3994
+ "average": 4.7807,
+ "bayesian_average": 4.78029998149622,
+ "count": 15480,
+ "text_count": 4023
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/reviews/",
"requires_payment": false,
@@ -1598,7 +1598,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/",
- "weekly_downloads": 131497
+ "weekly_downloads": 129742
},
"notes": null
},
@@ -1614,7 +1614,7 @@
"picture_url": null
}
],
- "average_daily_users": 167016,
+ "average_daily_users": 168553,
"categories": {
"android": [
"photos-media"
@@ -1713,10 +1713,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.4874,
- "bayesian_average": 4.4822747330216925,
- "count": 1114,
- "text_count": 416
+ "average": 4.4853,
+ "bayesian_average": 4.4801851669083215,
+ "count": 1119,
+ "text_count": 419
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/re…",
"requires_payment": false,
@@ -1738,7 +1738,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/ve…",
- "weekly_downloads": 411
+ "weekly_downloads": 369
},
"notes": null
},
@@ -1754,7 +1754,7 @@
"picture_url": null
}
],
- "average_daily_users": 88255,
+ "average_daily_users": 87582,
"categories": {
"android": [
"experimental",
@@ -1867,9 +1867,9 @@
],
"promoted": null,
"ratings": {
- "average": 4.3684,
- "bayesian_average": 4.354580970236878,
- "count": 399,
+ "average": 4.37,
+ "bayesian_average": 4.356186612333998,
+ "count": 400,
"text_count": 112
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/reviews/",
@@ -1892,7 +1892,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/versions/",
- "weekly_downloads": 900
+ "weekly_downloads": 1654
},
"notes": null
},
@@ -1908,7 +1908,7 @@
"picture_url": "https://addons.mozilla.org/user-media/userpics/64/9064/12929064/12929064.pn…"
}
],
- "average_daily_users": 259842,
+ "average_daily_users": 259693,
"categories": {
"android": [
"photos-media",
@@ -2127,10 +2127,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.6521,
- "bayesian_average": 4.647356516825427,
- "count": 1256,
- "text_count": 241
+ "average": 4.6514,
+ "bayesian_average": 4.646681076783187,
+ "count": 1268,
+ "text_count": 244
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/reviews/",
"requires_payment": false,
@@ -2151,7 +2151,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/versions/",
- "weekly_downloads": 4089
+ "weekly_downloads": 4107
},
"notes": null
},
@@ -2174,7 +2174,7 @@
"picture_url": null
}
],
- "average_daily_users": 110772,
+ "average_daily_users": 111400,
"categories": {
"android": [
"other"
@@ -2457,10 +2457,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.443,
- "bayesian_average": 4.438340772354168,
- "count": 1210,
- "text_count": 322
+ "average": 4.4415,
+ "bayesian_average": 4.436837247090715,
+ "count": 1214,
+ "text_count": 323
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/reviews/",
"requires_payment": false,
@@ -2480,7 +2480,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/versions/",
- "weekly_downloads": 40
+ "weekly_downloads": 50
},
"notes": null
},
@@ -2496,7 +2496,7 @@
"picture_url": "https://addons.mozilla.org/user-media/userpics/43/0143/143/143.png?modified…"
}
],
- "average_daily_users": 313446,
+ "average_daily_users": 307454,
"categories": {
"android": [
"performance",
@@ -2510,7 +2510,7 @@
"contributions_url": "https://www.paypal.com/donate/?hosted_button_id=9ERKTU5MBH4EW&utm_content=p…",
"created": "2005-05-13T10:51:32Z",
"current_version": {
- "id": 5546627,
+ "id": 5566736,
"compatibility": {
"firefox": {
"min": "59.0",
@@ -2521,7 +2521,7 @@
"max": "*"
}
},
- "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5546627",
+ "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5566736",
"is_strict_compatibility_enabled": false,
"license": {
"id": 13,
@@ -2532,22 +2532,22 @@
"url": "http://www.gnu.org/licenses/gpl-2.0.html"
},
"release_notes": {
- "en-US": "v 11.4.21\n============================================================\nx Fixed mislabeled Tor Browser settings override option\nx [L10n] Updated mk"
+ "en-US": "v 11.4.22\n============================================================\nx [L10n] Updated uk\nx Consistently apply DEFAULT policy to top-level data: URLs"
},
- "reviewed": "2023-04-04T12:01:03Z",
- "version": "11.4.21",
+ "reviewed": "2023-05-18T09:07:59Z",
+ "version": "11.4.22",
"files": [
{
- "id": 4090970,
- "created": "2023-03-30T09:39:24Z",
- "hash": "sha256:0fd3b66a2780d03a5b3cd460216105f3df2b27c6d3a552c1769c5de48c9e2338",
+ "id": 4111078,
+ "created": "2023-05-15T08:32:54Z",
+ "hash": "sha256:46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e",
"is_restart_required": false,
"is_webextension": true,
"is_mozilla_signed_extension": false,
"platform": "all",
- "size": 951542,
+ "size": 948900,
"status": "public",
- "url": "https://addons.mozilla.org/firefox/downloads/file/4090970/noscript-11.4.21.…",
+ "url": "https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.…",
"permissions": [
"contextMenus",
"storage",
@@ -2614,7 +2614,7 @@
},
"is_disabled": false,
"is_experimental": false,
- "last_updated": "2023-04-04T12:01:03Z",
+ "last_updated": "2023-05-21T21:36:00Z",
"name": {
"de": "NoScript",
"el": "NoScript",
@@ -2686,10 +2686,10 @@
"category": "recommended"
},
"ratings": {
- "average": 4.4106,
- "bayesian_average": 4.407881097196251,
- "count": 2058,
- "text_count": 799
+ "average": 4.4061,
+ "bayesian_average": 4.403390290765897,
+ "count": 2071,
+ "text_count": 804
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/reviews/",
"requires_payment": false,
@@ -2733,7 +2733,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/",
- "weekly_downloads": 7698
+ "weekly_downloads": 7195
},
"notes": null
},
@@ -2749,7 +2749,7 @@
"picture_url": null
}
],
- "average_daily_users": 150188,
+ "average_daily_users": 150677,
"categories": {
"android": [
"performance",
@@ -2864,10 +2864,10 @@
"category": "recommended"
},
"ratings": {
- "average": 3.9071,
- "bayesian_average": 3.902833394829747,
- "count": 1130,
- "text_count": 402
+ "average": 3.9026,
+ "bayesian_average": 3.898323122758472,
+ "count": 1129,
+ "text_count": 401
},
"ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/revi…",
"requires_payment": false,
@@ -2886,7 +2886,7 @@
"type": "extension",
"url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/",
"versions_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/vers…",
- "weekly_downloads": 2266
+ "weekly_downloads": 1722
},
"notes": null
}
=====================================
projects/browser/config
=====================================
@@ -100,9 +100,9 @@ input_files:
enable: '[% ! c("var/android") %]'
- filename: Bundle-Data
enable: '[% ! c("var/android") %]'
- - URL: https://addons.mozilla.org/firefox/downloads/file/4090970/noscript-11.4.21.…
+ - URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.…
name: noscript
- sha256sum: 0fd3b66a2780d03a5b3cd460216105f3df2b27c6d3a552c1769c5de48c9e2338
+ sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e
- filename: 'gtk3-settings.ini'
enable: '[% c("var/linux") %]'
- project: hfsplus-tools
=====================================
projects/firefox/config
=====================================
@@ -12,7 +12,7 @@ container:
use_container: 1
var:
- firefox_platform_version: 102.11.0
+ firefox_platform_version: 102.12.0
firefox_version: '[% c("var/firefox_platform_version") %]esr'
browser_branch: '12.0-1'
browser_build: 1
=====================================
projects/geckoview/config
=====================================
@@ -12,7 +12,7 @@ container:
use_container: 1
var:
- geckoview_version: 102.11.0esr
+ geckoview_version: 102.12.0esr
torbrowser_branch: 12.0-1
browser_build: 1
copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]'
=====================================
projects/manual/config
=====================================
@@ -1,7 +1,7 @@
# vim: filetype=yaml sw=2
# To update, see doc/how-to-update-the-manual.txt
# Remember to update also the package's hash, with the version!
-version: 74065
+version: 79869
filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.gz'
container:
use_container: 1
@@ -17,8 +17,8 @@ var:
input_files:
- project: container-image
- - URL: 'https://people.torproject.org/~pierov/tbb_files/manual_[% c("version") %].zip'
+ - URL: 'https://people.torproject.org/~richard/tbb_files/manual_[% c("version") %].zip'
name: manual
- sha256sum: 788c2dc2bfacbc6961ce443c5639706cc23fbb7b7730ed7f71a26396511305be
+ sha256sum: ee4c6e4ce4998736ae44dc3e6f92875a481b9e03860517764ea9af6c2bba24e0
- filename: packagemanual.py
name: package_script
=====================================
projects/openssl/config
=====================================
@@ -1,5 +1,5 @@
# vim: filetype=yaml sw=2
-version: 1.1.1t
+version: 1.1.1u
filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz'
container:
use_container: 1
@@ -31,4 +31,4 @@ input_files:
- name: '[% c("var/compiler") %]'
project: '[% c("var/compiler") %]'
- URL: 'https://www.openssl.org/source/openssl-[% c("version") %].tar.gz'
- sha256sum: 8dee9b24bdb1dcbf0c3d1e9b02fb8f6bf22165e807f45adeb7c9677536859d3b
+ sha256sum: e2f8d84b523eecd06c7be7626830370300fbcc15386bf5142d72758f6963ebc6
=====================================
projects/translation/config
=====================================
@@ -6,19 +6,19 @@ version: '[% c("abbrev") %]'
steps:
base-browser:
base-browser: '[% INCLUDE build %]'
- git_hash: 97c76d5183b16b069e66feaaf10e00c1d2c7d9e0
+ git_hash: 12b7ac4074f64be4d62c4a7e134244988941ca88
targets:
nightly:
git_hash: 'base-browser'
base-browser-fluent:
base-browser-fluent: '[% INCLUDE build %]'
- git_hash: d473c4dd005325d1be40bae0f816974e195a972d
+ git_hash: 7a5fa6b283ac0a983250dfb3870fb1ed9d9ec1ad
targets:
nightly:
git_hash: 'basebrowser-newidentityftl'
tor-browser:
tor-browser: '[% INCLUDE build %]'
- git_hash: 267f3c208a323df636ed11e7143164956d3d9d9b
+ git_hash: 96ce5976d1c1752ee1d920df58e1755464b9d575
targets:
nightly:
git_hash: 'tor-browser'
@@ -26,7 +26,7 @@ steps:
fenix: '[% INCLUDE build %]'
# We need to bump the commit before releasing but just pointing to a branch
# might cause too much rebuidling of the Firefox part.
- git_hash: 0deec2a78dea0013e8c4eaec1d40ef5aac4e43b0
+ git_hash: 12c25e54e3a80c22c3c5fd6ccbc00effd37fc538
targets:
nightly:
git_hash: 'fenix-torbrowserstringsxml'
=====================================
rbm.conf
=====================================
@@ -71,13 +71,14 @@ buildconf:
git_signtag_opt: '-s'
var:
- torbrowser_version: '12.0.6'
+ torbrowser_version: '12.0.7'
torbrowser_build: 'build1'
torbrowser_incremental_from:
# Build incrementals also from 12.0.4 until we have a new certificate for
# Windows installers.
- 12.0.4
- 12.0.5
+ - 12.0.6
build_mar: 1
# By default, we sort the list of installed packages. This allows sharing
# containers with identical list of packages, even if they are not listed
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-102.12.0esr-12.0-1
by richard (@richard) 30 May '23
by richard (@richard) 30 May '23
30 May '23
richard pushed new branch base-browser-102.12.0esr-12.0-1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.12.0esr-12.0-1-build1
by richard (@richard) 30 May '23
by richard (@richard) 30 May '23
30 May '23
richard pushed new tag tor-browser-102.12.0esr-12.0-1-build1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-102.12.0esr-12.0-1-build1
by richard (@richard) 30 May '23
by richard (@richard) 30 May '23
30 May '23
richard pushed new tag base-browser-102.12.0esr-12.0-1-build1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.0-1] 109 commits: Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers, valentin
by richard (@richard) 30 May '23
by richard (@richard) 30 May '23
30 May '23
richard pushed to branch tor-browser-102.12.0esr-12.0-1 at The Tor Project / Applications / Tor Browser
Commits:
af1744ba by Kershaw Chang at 2023-05-29T21:45:46+02:00
Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D164656
- - - - -
acdd519c by Pier Angelo Vendrame at 2023-05-29T21:45:47+02:00
Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
Bundled fonts were not picked up because also child processes need to
register them.
Also, they were assigned User visibility, instead of Base, which was
not coherent with other platforms.
Differential Revision: https://phabricator.services.mozilla.com/D150400
- - - - -
73f8c710 by Pier Angelo Vendrame at 2023-05-29T21:45:47+02:00
Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium
Add a configuration flag to make Enterprise Policies mechanism only
consult a policies.json file (avoiding the Windows Registry, macOS's
file system attributes, and /etc/firefox/policies/policies.json on
other OS).
Differential Revision: https://phabricator.services.mozilla.com/D146300
- - - - -
e16f0c76 by Jamie Nicol at 2023-05-29T21:45:48+02:00
Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D154897
- - - - -
95495145 by Pier Angelo Vendrame at 2023-05-29T21:45:48+02:00
Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157843
- - - - -
8c3a074e by Neill Miller at 2023-05-29T21:45:48+02:00
Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman
nsTransferable was modified to prevent disk leakings when copying data
in private browsing mode with Bug 1123480.
However, the context is nullptr when it is initialized, so it still
leaks if PBM is enabled by default.
Our solution is to check the browser.privatebrowsing.autostart in this
condition.
Differential Revision: https://phabricator.services.mozilla.com/D157800
- - - - -
7feb3637 by Gabriele Svelto at 2023-05-29T21:45:49+02:00
Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium
macOS unfair locks enforce that a lock can only be released by the thread which locked it.
On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.
Differential Revision: https://phabricator.services.mozilla.com/D148287
- - - - -
5185cb45 by Gabriele Svelto at 2023-05-29T21:45:49+02:00
Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium
Depends on D148287
Differential Revision: https://phabricator.services.mozilla.com/D99280
- - - - -
9f934967 by Kathy Brade at 2023-05-29T21:45:50+02:00
Bug 1769028: Disable DNS lookup in nsProfileLock when the proxy bypass protection is enabled r=mossop
Instead of using the local computer's IP address within
symlink-based profile lock signatures, always use 127.0.0.1 when the
proxy bypass protection is enabled.
Differential Revision: https://phabricator.services.mozilla.com/D161264
- - - - -
45c41c00 by Gabriele Svelto at 2023-05-29T21:45:50+02:00
Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone
Differential Revision: https://phabricator.services.mozilla.com/D149599
- - - - -
d1d35195 by Gabriele Svelto at 2023-05-29T21:45:50+02:00
Bug 1784018 - Remove deprecated OSSpinLocks r=glandium
On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space
which degrades performance significantly. To obviate for this we spin in
user-space like OSSpinLock does, for the same number of times and invoking
x86-specific pause instructions in-between the locking attempts to avoid
starving a thread that might be running on the same physical core.
Differential Revision: https://phabricator.services.mozilla.com/D154205
- - - - -
3e89a0f7 by Hubert Boma Manilla at 2023-05-29T21:45:51+02:00
Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers
- Block redirects on sourceMappingUrl
- Add debugger test
Differential Revision: https://phabricator.services.mozilla.com/D168648
- - - - -
d5384aec by Hubert Boma Manilla at 2023-05-29T21:45:51+02:00
Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers
.sjs files depend on redirects to load static files.
In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js
fails because we use .sjs to serve the content.
This patch refactors to no longer use .sjs files
Differential Revision: https://phabricator.services.mozilla.com/D169739
- - - - -
fc93493d by Rob Wu at 2023-05-29T21:45:52+02:00
Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin
Depends on D164656
Differential Revision: https://phabricator.services.mozilla.com/D166108
- - - - -
37a8d0de by Kash Shampur at 2023-05-29T21:45:52+02:00
Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova
Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk.
Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.
Differential Revision: https://phabricator.services.mozilla.com/D167167
- - - - -
a85a85e0 by Pier Angelo Vendrame at 2023-05-29T21:45:52+02:00
Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden
Now it displays app display name, instead of having Firefox hardcoded.
Differential Revision: https://phabricator.services.mozilla.com/D168562
- - - - -
74b96b49 by Jon Coppeard at 2023-05-29T21:45:53+02:00
Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink
GC can mutate this vector so don't allow that while we are iterating. I think
it would be safe to use index-based iteration but it's safer to just ban it
entirely.
This fixes the crash produced by the testcase.
Differential Revision: https://phabricator.services.mozilla.com/D169701
- - - - -
887e2f5a by Jon Coppeard at 2023-05-29T21:45:53+02:00
Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink
To prevent any other instances of this problme we can update the getDebuggers()
methods on the global and the realm to require no GC.
Depends on D169701
Differential Revision: https://phabricator.services.mozilla.com/D169702
- - - - -
371becbd by Georg Koppen at 2023-05-29T21:45:54+02:00
Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"
This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.
This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706.
However, it is a temporary workaround, that we should revert once
https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.
- - - - -
33d2e63d by Richard Pospesel at 2023-05-29T21:45:54+02:00
fixup! Bug 1761389 - Add and use new PDF-specific document icon on Windows. r=bhearsum
- - - - -
66b93b7e by Henry Wilkes at 2023-05-29T21:45:54+02:00
Bug 41454: Move focus after calling openPreferences for a sub-category.
Temporary fix until mozilla bug 1799153 gets a patch upstream.
- - - - -
d3b88f8a by Pier Angelo Vendrame at 2023-05-29T21:45:55+02:00
Bug 41116: Normalize system fonts.
System fonts are an enormous fingerprinting vector.
Even with font allow lists and with our custom configuration on Linux,
which counter metrics measurements, getComputedStyle leaks several
details.
This patch counters both these kinds of attacks.
- - - - -
16e637c0 by Pier Angelo Vendrame at 2023-05-29T21:45:55+02:00
Tweaks to the build system
Bug 40857: Modified the fat .aar creation file
This is a workaround to build fat .aars with the compiling enviornment
disabled.
Mozilla does not use a similar configuration, but either runs a Firefox
build and discards its output, or uses artifacts build.
We might switch to artifact builds too, and drop this patch, or write a
better one to upstream. But until then we need this patch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.
Bug 41458: Prevent `mach package-multi-locale` from actually creating a package
macOS builds need some files to be moved around with
./mach package-multi-locale to create multi-locale packages.
The required command isn't exposed through any other mach command.
So, we patch package-multi-locale both to prevent it from failing when
doing official builds and to detect any future changes on it.
- - - - -
f5287c17 by Dan Ballard at 2023-05-29T21:45:56+02:00
Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac
- - - - -
5067d5c6 by Gaba at 2023-05-29T21:45:56+02:00
Adding issue template for bugs.
- - - - -
af79c660 by Pier Angelo Vendrame at 2023-05-29T21:45:57+02:00
Base Browser's .mozconfigs.
- - - - -
e5dc5d3b by Pier Angelo Vendrame at 2023-05-29T21:45:57+02:00
Bug 41108: Remove privileged macOS installation from 102
- - - - -
25873ee4 by Dan Ballard at 2023-05-29T21:45:57+02:00
Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
- - - - -
93967115 by Matthew Finkel at 2023-05-29T21:45:58+02:00
Bug 24796: Comment out excess permissions from GeckoView
The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
manifest, so we can't use the ifdef preprocessor guards around the
permissions we do not want. Commenting the permissions is the
next-best-thing.
- - - - -
94fa497c by Matthew Finkel at 2023-05-29T21:45:58+02:00
Bug 25741: TBA: Disable GeckoNetworkManager
The browser should not need information related to the network
interface or network state, tor should take care of that.
- - - - -
f8073bbe by Matthew Finkel at 2023-05-29T21:45:59+02:00
Bug 28125: Prevent non-Necko network connections
- - - - -
2614d340 by Mike Perry at 2023-05-29T21:45:59+02:00
Bug 12974: Disable NTLM and Negotiate HTTP Auth
The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602
- - - - -
4289c282 by Alex Catarineu at 2023-05-29T21:45:59+02:00
Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899
- - - - -
615e786a by Georg Koppen at 2023-05-29T21:46:00+02:00
Bug 16285: Exclude ClearKey system for now
In the past the ClearKey system had not been compiled when specifying
--disable-eme. But that changed and it is even bundled nowadays (see:
Mozilla's bug 1300654). We don't want to ship it right now as the use
case for it is not really visible while the code had security
vulnerabilities in the past.
- - - - -
5de48deb by Kathy Brade at 2023-05-29T21:46:00+02:00
Bug 21431: Clean-up system extensions shipped in Firefox
Only ship the pdfjs extension.
- - - - -
2492c8e3 by Kathy Brade at 2023-05-29T21:46:01+02:00
Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.
Disable the "Create New Login" button when security.nocertdb is true.
- - - - -
1a3e6516 by Alex Catarineu at 2023-05-29T21:46:01+02:00
Bug 41457: Remove Mozilla permissions
Bug 40025: Remove Mozilla add-on install permissions
- - - - -
a5931ca0 by Kathy Brade at 2023-05-29T21:46:07+02:00
Bug 40002: Remove about:ion
Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people
volunteer to participate in studies that collect detailed, sensitive data about
how they use their browser.
- - - - -
457fd06e by Arthur Edelstein at 2023-05-29T21:46:07+02:00
Bug 26353: Prevent speculative connect that violated FPI.
Connections were observed in the catch-all circuit when
the user entered an https or http URL in the URL bar, or
typed a search term.
- - - - -
84911d79 by Alex Catarineu at 2023-05-29T21:46:07+02:00
Bug 31740: Remove some unnecessary RemoteSettings instances
More concretely, SearchService.jsm 'hijack-blocklists' and
url-classifier-skip-urls.
Avoid creating instance for 'anti-tracking-url-decoration'.
If prefs are disabling their usage, avoid creating instances for
'cert-revocations' and 'intermediates'.
Do not ship JSON dumps for collections we do not expect to need. For
the ones in the 'main' bucket, this prevents them from being synced
unnecessarily (the code in remote-settings does so for collections
in the main bucket for which a dump or local data exists). For the
collections in the other buckets, we just save some size by not
shipping their dumps.
We also clear the collections database on the v2 -> v3 migration.
- - - - -
854c4634 by Georg Koppen at 2023-05-29T21:46:08+02:00
Bug 30541: Disable WebGL readPixel() for web content
Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034
- - - - -
8b693beb by Alex Catarineu at 2023-05-29T21:46:08+02:00
Bug 28369: Stop shipping pingsender executable
- - - - -
935fe113 by Alex Catarineu at 2023-05-29T21:46:09+02:00
Bug 40073: Disable remote Public Suffix List fetching
In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
fetching the Public Suffix List via RemoteSettings and replacing the default
one at runtime, which we do not want.
- - - - -
a0648596 by Mike Perry at 2023-05-29T21:46:09+02:00
Firefox preference overrides.
This hack directly includes our preference changes in omni.ja.
Bug 18292: Staged updates fail on Windows
Temporarily disable staged updates on Windows.
Bug 18297: Use separate Noto JP,KR,SC,TC fonts
Bug 23404: Add Noto Sans Buginese to the macOS whitelist
Bug 23745: Set dom.indexedDB.enabled = true
Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
(Fernando Fernandez Mancera <ffmancera(a)riseup.net>)
Bug 17252: Enable session identifiers with FPI
Session tickets and session identifiers were isolated
by OriginAttributes, so we can re-enable them by
allowing the default value (true) of
"security.ssl.disable_session_identifiers".
The pref "security.enable_tls_session_tickets" is obsolete
(removed in https://bugzilla.mozilla.org/917049)
Bug 14952: Enable http/2 and AltSvc
In Firefox, SPDY/HTTP2 now uses Origin Attributes for
isolation of connections, push streams, origin frames, etc.
That means we get first-party isolation provided
"privacy.firstparty.isolate" is true. So in this patch, we
stop overriding "network.http.spdy.enabled" and
"network.http.spdy.enabled.http2".
Alternate Services also use Origin Attributes for isolation.
So we stop overriding
"network.http.altsvc.enabled" and "network.http.altsvc.oe"
as well.
(All 4 of the abovementioned "network.http.*" prefs adopt
Firefox 60ESR's default value of true.)
However, we want to disable HTTP/2 push for now, so we
set "network.http.spdy.allow-push" to false.
"network.http.spdy.enabled.http2draft" was removed in Bug 1132357.
"network.http.sped.enabled.v2" was removed in Bug 912550.
"network.http.sped.enabled.v3" was removed in Bug 1097944.
"network.http.sped.enabled.v3-1" was removed in Bug 1248197.
Bug 26114: addons.mozilla.org is not special
* Don't expose navigator.mozAddonManager on any site
* Don't block NoScript from modifying addons.mozilla.org or other sites
Enable ReaderView mode again (#27281).
Bug 29916: Make sure enterprise policies are disabled
Bug 2874: Block Components.interfaces from content
Bug 26146: Spoof HTTP User-Agent header for desktop platforms
In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent
header and to JavaScript code via navigator.userAgent. To avoid
leaking the OS inside each HTTP request (which many web servers
log), always use the Windows 7 OS value in the desktop User-Agent
header. We continue to allow access to the actual OS via JavaScript,
since doing so improves compatibility with web applications such
as GitHub and Google Docs.
Bug 12885: Windows Jump Lists fail for Tor Browser
Jumplist entries are stored in a binary file in:
%APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\
and has a name in the form
[a-f0-9]+.customDestinations-ms
The hex at the front is unique per app, and is ultimately derived from
something called the 'App User Model ID' (AUMID) via some unknown
hashing method. The AUMID is provided as a key when programmatically
creating, updating, and deleting a jumplist. The default behaviour in
firefox is for the installer to define an AUMID for an app, and save it
in the registry so that the jumplist data can be removed by the
uninstaller.
However, the Tor Browser does not set this (or any other) regkey during
installation, so this codepath fails and the app's AUMID is left
undefined. As a result the app's AUMID ends up being defined by
windows, but unknowable by Tor Browser. This unknown AUMID is used to
create and modify the jumplist, but the delete API requires that we
provide the app's AUMID explicitly. Since we don't know what the AUMID
is (since the expected regkey where it is normally stored does not
exist) jumplist deletion will fail and we will leave behind a mostly
empty customDestinations-ms file. The name of the file is derived from
the binary path, so an enterprising person could reverse engineer how
that hex name is calculated, and generate the name for Tor Browser's
default Desktop installation path to determine whether a person had
used Tor Browser in the past.
The 'taskbar.grouping.useprofile' option that is enabled by this patch
works around this AUMID problem by having firefox.exe create it's own
AUMID based on the profile path (rather than looking for a regkey). This
way, if a user goes in and enables and disables jumplist entries, the
backing store is properly deleted.
Unfortunately, all windows users currently have this file lurking in
the above mentioned directory and this patch will not remove it since it
was created with an unknown AUMID. However, another patch could be
written which goes to that directory and deletes any item containing the
'Tor Browser' string. See bug 28996.
Bug 30845: Make sure default themes and other internal extensions are enabled
Bug 28896: Enable extensions in private browsing by default
Bug 31065: Explicitly allow proxying localhost
Bug 31598: Enable letterboxing
Disable Presentation API everywhere
Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer
security levels.
Bug 32321: Disable Mozilla's MitM pings
Bug 19890: Disable installation of system addons
By setting the URL to "" we make sure that already installed system
addons get deleted as well.
Bug 22548: Firefox downgrades VP9 videos to VP8.
On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor
Browser 7.0 all youtube videos are degraded to VP8.
This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0.
All clients will get better experience and lower traffic, beause TBB doesn't
use "Use hardware acceleration when available".
Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
Bug 16441: Suppress "Reset Tor Browser" prompt.
Bug 29120: Use the in-memory media cache and increase its maximum size.
Bug 33697: use old search config based on list.json
Bug 33855: Ensure that site-specific browser mode is disabled.
Bug 30682: Disable Intermediate CA Preloading.
Bug 40061: Omit the Windows default browser agent from the build
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40408: Disallow SVG Context Paint in all web content
Bug 40308: Disable network partitioning until we evaluate dFPI
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40383: Disable dom.enable_event_timing
Bug 40423: Disable http/3
Bug 40177: Update prefs for Fx91esr
Bug 40700: Disable addons and features recommendations
Bug 40682: Disable network.proxy.allow_bypass
Bug 40736: Disable third-party cookies in PBM
Bug 19850: Enabled HTTPS-Only by default
Bug 40912: Hide the screenshot menu
Bug 41292: Disable moreFromMozilla in preferences page
Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector
Bug 24686: Set network.http.tailing.enabled to true
Bug 40183: Disable TLS ciphersuites using SHA-1
Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102
We reviewed all the preferences we set for 102, and remove a few old
ones. See the description of that issue to see all the preferences we
believed were still valid for 102, and some brief description for the
reasons to keep them.
- - - - -
c39686a8 by hackademix at 2023-05-29T21:46:10+02:00
fixup! Firefox preference overrides.
tor-browser#41764, prevent automatic download stuffing / DOS
- - - - -
971ff897 by Richard Pospesel at 2023-05-29T21:46:10+02:00
Bug 41659: Add canonical color definitions to base-browser
- - - - -
d1c03022 by Pier Angelo Vendrame at 2023-05-29T21:46:10+02:00
Bug 41043: Hardcode the UI font on Linux
The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.
Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).
- - - - -
fe8eb079 by Alex Catarineu at 2023-05-29T21:46:11+02:00
Bug 30605: Honor privacy.spoof_english in Android
This checks `privacy.spoof_english` whenever `setLocales` is
called from Fenix side and sets `intl.accept_languages`
accordingly.
Bug 40198: Expose privacy.spoof_english pref in GeckoView
- - - - -
e699abc5 by Alex Catarineu at 2023-05-29T21:46:11+02:00
Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView
- - - - -
b11b2636 by Alex Catarineu at 2023-05-29T21:46:12+02:00
Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
- - - - -
fc077d55 by Alex Catarineu at 2023-05-29T21:46:12+02:00
Bug 26345: Hide tracking protection UI
- - - - -
eef54b99 by Kathy Brade at 2023-05-29T21:46:12+02:00
Bug 9173: Change the default Firefox profile directory to be relative.
This should eliminate our need to rely on a wrapper script that
sets /Users/arthur and launches Firefox with -profile.
- - - - -
b54f568d by Alex Catarineu at 2023-05-29T21:46:13+02:00
Bug 27604: Fix addon issues when moving the profile directory
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838
- - - - -
ca5e4ab7 by Mike Perry at 2023-05-29T21:46:13+02:00
Bug 13028: Prevent potential proxy bypass cases.
It looks like these cases should only be invoked in the NSS command line
tools, and not the browser, but I decided to patch them anyway because there
literally is a maze of network function pointers being passed around, and it's
very hard to tell if some random code might not pass in the proper proxied
versions of the networking code here by accident.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509
- - - - -
1388e4a9 by Kathy Brade at 2023-05-29T21:46:14+02:00
Bug 11641: Disable remoting by default.
Unless the -osint command line flag is used, the browser now defaults
to the equivalent of -no-remote. There is a new -allow-remote flag that
may be used to restore the original (Firefox-like) default behavior.
- - - - -
9d90c1d6 by Igor Oliveira at 2023-05-29T21:46:14+02:00
Bug 23104: Add a default line height compensation
Many fonts have issues with their vertical metrics. they
are used to influence the height of ascenders and depth
of descenders. Gecko uses it to calculate the line height
(font height + ascender + descender), however because of
that idiosyncratic behavior across multiple operating
systems, it can be used to identify the user's OS.
The solution proposed in the patch uses a default factor
to be multiplied with the font size, simulating the concept
of ascender and descender. This way all operating
systems will have the same line height only and only if the
frame is outside the chrome.
- - - - -
a7b78c94 by Pier Angelo Vendrame at 2023-05-29T21:46:14+02:00
Bug 40309: Avoid using regional OS locales
Avoid regional OS locales if the pref
`intl.regional_prefs.use_os_locales` is false but RFP is enabled.
- - - - -
8deb4c4b by Matthew Finkel at 2023-05-29T21:46:15+02:00
Bug 40432: Prevent probing installed applications
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084
- - - - -
87fbab52 by hackademix at 2023-05-29T21:46:15+02:00
Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
- - - - -
f862cf38 by hackademix at 2023-05-29T21:46:16+02:00
Bug 41434: Letterboxing, improve logging.
- - - - -
d621a155 by hackademix at 2023-05-29T21:46:16+02:00
Bug 31064: Letterboxing, exempt browser extensions.
- - - - -
7116762e by hackademix at 2023-05-29T21:46:17+02:00
Bug 32411: Letterboxing, exempt view-source: URIs.
- - - - -
d0c72e33 by Richard Pospesel at 2023-05-29T21:46:17+02:00
Bug 32220: Improve the letterboxing experience
CSS and JS changes to alter the UX surrounding letterboxing. The
browser element containing page content is now anchored to the bottom
of the toolbar, and the remaining letterbox margin is the same color
as the firefox chrome. The letterbox margin and outline are tied to
the currently selected theme.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1594455
- - - - -
0e789435 by Alex Catarineu at 2023-05-29T21:46:17+02:00
Bug 40069: Add helpers for message passing with extensions
- - - - -
99aab4dd by Matthew Finkel at 2023-05-29T21:46:18+02:00
Bug 40253: Explicitly allow NoScript in Private Browsing mode.
- - - - -
c8da704d by Pier Angelo Vendrame at 2023-05-29T21:46:18+02:00
Bug 41369: Improve Firefox language settings for multi-lingual packages
Change the language selector to be sorted by language code, rather than
name, and to display the language code to the user.
Bug 41372: Handle Japanese as a special case in preferences on macOS
Japanese is treated in a special way on macOS. However, seeing the
Japanese language tag could be confusing for users, and moreover the
language name is not localized correctly like other langs.
Bug 41378: Tell users that they can change their language at the first start
With multi-lingual builds, Tor Browser matches the user's system
language, but some users might want to change it.
So, we tell them that it is possible, but only once.
- - - - -
f46918d6 by Henry Wilkes at 2023-05-29T21:46:19+02:00
Bug 41371: Temporary hack to fix language selector popup position
- - - - -
3949b7e1 by Pier Angelo Vendrame at 2023-05-29T21:46:19+02:00
Bug 41417: Always prompt users to restart after changing language
This is a temporary patch that we need until we switch our strings to
Fluent. The reason is that we currently set strings when we populate
our XUL content.
We could rework the whole mechanism, but it is not worth it because we
want to switch to Fluent, which will handle everything automatically.
- - - - -
7f98b5cb by Pier Angelo Vendrame at 2023-05-29T21:46:19+02:00
Bug 40925: Implemented the Security Level component
This component adds a new Security Level toolbar button which visually
indicates the current global security level via icon (as defined by the
extensions.torbutton.security_slider pref), a drop-down hanger with a
short description of the current security level, and a new section in
the about:preferences#privacy page where users can change their current
security level. In addition, the hanger and the preferences page will
show a visual warning when the user has modified prefs associated with
the security level and provide a one-click 'Restore Defaults' button to
get the user back on recommended settings.
Bug 40125: Expose Security Level pref in GeckoView
- - - - -
50ef6887 by Pier Angelo Vendrame at 2023-05-29T21:46:20+02:00
Bug 40926: Implemented the New Identity feature
- - - - -
4dfb9ee1 by cypherpunks1 at 2023-05-29T21:46:20+02:00
Bug 40717: Hide Windows SSO in settings
(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d)
- - - - -
8f89a4b5 by cypherpunks1 at 2023-05-29T21:46:21+02:00
Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING
(cherry picked from commit 47eb7d305746bd1a9e328b1fb7fef40d56769d5b)
- - - - -
f08354ab by Pier Angelo Vendrame at 2023-05-29T21:46:23+02:00
Bug 41603: Customize the creation of MOZ_SOURCE_URL
MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.
- - - - -
6a4e3273 by Pier Angelo Vendrame at 2023-05-29T21:46:24+02:00
Bug 41542: Disable the creation of a default profile
Firefox creates a profile as a fallback for old versions.
However, we do not need this, so we want to prevent Firefox from
creating the related directories.
We comment out the code, but should Mozilla be interested in a
compile-time flag, we could rewrite the patch to add one.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.
- - - - -
abd4aebd by Arthur Edelstein at 2023-05-29T21:46:24+02:00
Bug 18905: Hide unwanted items from help menu
Bug 25660: Remove the "New Private Window" option
(cherry picked from commit 5ff98c20700d45b9bc57d970ff45c1e6519cd64d)
- - - - -
f20b3c09 by Richard Pospesel at 2023-05-29T21:46:25+02:00
Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
- - - - -
7340b189 by Mike Perry at 2023-05-29T21:46:25+02:00
Bug 2176: Rebrand Firefox to TorBrowser
See also Bugs #5194, #7187, #8115, #8219.
This patch does some basic renaming of Firefox to TorBrowser. The rest of the
branding is done by images and icons.
Also fix bug 27905.
Bug 25702: Update Tor Browser icon to follow design guidelines
- Updated all of the branding in /browser/branding/official with new 'stable'
icon series.
- Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
add the source svg in the same directory
- Copied /browser/branding/official over /browser/branding/nightly and the new
/browser/branding/alpha directories. Replaced content with 'nightly' and
'alpha' icon series.
Updated VisualElements_70.png and VisualElements_150.png with updated icons in
each branding directory (fixes #22654)
- Updated firefox.VisualElementsManfiest.xml with updated colors in each
branding directory
- Added firefox.svg to each branding directory from which all the other icons
are derived (apart from document.icns and document.ico)
- Added default256.png and default512.png icons
- Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
original icon
- Use the Tor Browser icon within devtools/client/themes/images/.
Bug 30631: Blurry Tor Browser icon on macOS app switcher
It would seem the png2icns tool does not generate correct icns files and
so on macOS the larger icons were missing resulting in blurry icons in
the OS chrome. Regenerated the padded icons in a macOS VM using
iconutil.
Bug 28196: preparations for using torbutton tor-browser-brand.ftl
A small change to Fluent FileSource class is required so that we
can register a new source without its supported locales being
counted as available locales for the browser.
Bug 31803: Replaced about:debugging logo with flat version
Bug 21724: Make Firefox and Tor Browser distinct macOS apps
When macOS opens a document or selects a default browser, it sometimes
uses the CFBundleSignature. Changing from the Firefox MOZB signature to
a different signature TORB allows macOS to distinguish between Firefox
and Tor Browser.
Bug 32092: Fix Tor Browser Support link in preferences
For bug 40562, we moved onionPattern* from bug 27476 to here, as
about:tor needs these files but it is included earlier.
Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one
- - - - -
e1c024b7 by Alex Catarineu at 2023-05-29T21:46:25+02:00
Bring back old Firefox onboarding
Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.
Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.
Bug 28822: Convert onboarding to webextension
Partially revert 1564367 (controlCenter in UITour.jsm)
- - - - -
491c9784 by Kathy Brade at 2023-05-29T21:46:26+02:00
Bug 26961: New user onboarding.
Reuse the Firefox onboarding mechanism with minimal changes.
Localizable strings are pulled in from Torbutton (if Torbutton is
not installed, we lack about:tor and no tour will be shown).
Replace SVG images with PNGs (see bug 27002),
For defense in depth, omit include OnboardingTelemetry.jsm entirely.
Added support for the following UITour page event:
torBrowserOpenSecuritySettings
Also fix bug 27403: the onboarding bubble is not always displayed.
Arthur suggested to make the onboarding bubble visible on displays with
less than 960px width available, so we choose 200px instead.
Also fix bug 28628: Change onboarding Security panel to open new
Security Level panel.
Also fix bug 27484: Improve navigation within onboarding.
Bug 27082: enable a limited UITour
Disallow access to UITour functionality from all pages other than
about:home, about:newtab, and about:tor.
Implement a whitelist mechanism for page actions.
Bug 26962 - implement new features onboarding (part 1).
Add an "Explore" button to the "Circuit Display" panel within new user
onboarding which opens the DuckDuckGo .onion and then guides users through
a short circuit display tutorial.
Allow a few additional UITour actions while limiting as much as possible
how it can be used.
Tweak the UITour styles to match the Tor Browser branding.
All user interface strings are retrieved from Torbutton's
browserOnboarding.properties file.
Bug 27486 Avoid about:blank tabs when opening onboarding pages.
Instead of using a simple <a href>, programmatically open onboarding
web pages by using tabBrowser.addTab(). The same technique is now
used for "See My Path", "See FAQs", and "Visit an Onion".
Bug 29768: Introduce new features to users
Add an "update" tour for the Tor Browser 8.5 release that contains two
panels: Toolbar and Security (with appropriate description text and
images).
Display an attention-grabbing dot on the onboarding text bubble when
the update tour is active. The animation lasts for 14 seconds.
Bug 31768: Introduce toolbar and network settings changes in onboarding
Update the "Tor Network" onboarding page to include a note that
settings can now be accessed via the application preferences and
add an "Adjust Your Tor Network Settings" action button which opens
about:preferences#tor.
Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one
that includes the revised "Tor Network" page and a revised "Toolbar"
page. The latter explains that Torbutton's toolbar item has been
removed ("Goodbye Onion Button") and explains how to access the
New Identity feature using the hamburger menu and new toolbar item.
Bug 34321 - Add Learn More onboarding item
Bug 40429: Update Onboarding for 10.5
- - - - -
0029aee5 by Mike Perry at 2023-05-29T21:46:26+02:00
TB3: Tor Browser's official .mozconfigs.
Also:
Bug #9829.1: new .mozconfig file for the new cross-compiler and ESR24
Changes needed to build Mac in 64bit
Bug 10715: Enable Webgl for mingw-w64 again.
Disable ICU when cross-compiling; clean-up.
Bug 15773: Enable ICU on OS X
Bug 15990: Don't build the sandbox with mingw-w64
Bug 12761: Switch to ESR 38 for OS X
Updating .mozconfig-asan
Bug 12516: Compile hardenend Tor Browser with -fwrapv
Bug 18331: Switch to Mozilla's toolchain for building Tor Browser for OS X
Bug 17858: Cannot create incremental MARs for hardened builds.
Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
(which is part of mar-tools and is not distributed to end-users) with
ASan.
Bug 13419: Add back ICU for Windows
Bug 21239: Use GTK2 for ESR52 Linux builds
Bug 23025: Add hardening flags for macOS
Bug 24478: Enable debug assertions and tests in our ASan builds
--enable-proxy-bypass-protection
Bug 27597: ASan build option in tor-browser-build is broken
Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
This fixes a problem where some preferences had the wrong default value.
Also see bug 27472 where we made a similar fix for Android.
Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
Bug 31450: Set proper BINDGEN_CFLAGS for ASan builds
Add an --enable-tor-browser-data-outside-app-dir configure option
Add --with-tor-browser-version configure option
Bug 21849: Don't allow SSL key logging.
Bug 31457: disable per-installation profiles
The dedicated profiles (per-installation) feature does not interact
well with our bundled profiles on Linux and Windows, and it also causes
multiple profiles to be created on macOS under TorBrowser-Data.
Bug 31935: Disable profile downgrade protection.
Since Tor Browser does not support more than one profile, disable
the prompt and associated code that offers to create one when a
version downgrade situation is detected.
Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
Bug 25741 - TBA: Disable features at compile-time
MOZ_NATIVE_DEVICES for casting and the media player
MOZ_TELEMETRY_REPORTING for telemetry
MOZ_DATA_REPORTING for all data reporting preferences (crashreport, telemetry, geo)
Bug 25741 - TBA: Add default configure options in dedicated file
Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
Bug 29859: Disable HLS support for now
Add --disable-tor-launcher build option
Add --enable-tor-browser-update build option
Bug 33734: Set MOZ_NORMANDY to False
Bug 33851: Omit Parental Controls.
Bug 40061: Omit the Windows default browser agent from the build
Bug 40107: Adapt .mozconfig-asan for ESR 78
Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files
Bug 40793: moved Tor configuration options from old-configure.in to moz.configure
- - - - -
34314d9e by Henry Wilkes at 2023-05-29T21:46:27+02:00
Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds
tor-browser#41285: Enable fluent warnings.
- - - - -
128a50dc by Pier Angelo Vendrame at 2023-05-29T21:46:27+02:00
Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Before reordering patches, we used to keep the Tor-related patches
(torbutton and tor-launcher) at the beginning.
After that issue, we decided to move them towards the end.
In addition to that, we have decided to move Tor Browser-only
preferences there, too, to make Base Browser-only fixups easier to
apply.
- - - - -
1746fd01 by Kathy Brade at 2023-05-29T21:46:28+02:00
Bug 13252: Do not store data in the app bundle
When --enable-tor-browser-data-outside-app-dir is enabled,
all user data is stored in a directory named
TorBrowser-Data which is located next to the application directory.
Display an informative error message if the TorBrowser-Data
directory cannot be created due to an "access denied" or a
"read only volume" error.
On Mac OS, add support for the --invisible command line option which
is used by the meek-http-helper to avoid showing an icon for the
helper browser on the dock.
- - - - -
83bbda92 by Pier Angelo Vendrame at 2023-05-29T21:46:28+02:00
Bug 40933: Add tor-launcher functionality
- - - - -
6305f01f by Richard Pospesel at 2023-05-29T21:46:28+02:00
Bug 40597: Implement TorSettings module
- migrated in-page settings read/write implementation from about:preferences#tor
to the TorSettings module
- TorSettings initially loads settings from the tor daemon, and saves them to
firefox prefs
- TorSettings notifies observers when a setting has changed; currently only
QuickStart notification is implemented for parity with previous preference
notify logic in about:torconnect and about:preferences#tor
- about:preferences#tor, and about:torconnect now read and write settings
thorugh the TorSettings module
- all tor settings live in the torbrowser.settings.* preference branch
- removed unused pref modify permission for about:torconnect content page from
AsyncPrefs.jsm
Bug 40645: Migrate Moat APIs to Moat.jsm module
- - - - -
56e328ab by Alex Catarineu at 2023-05-29T21:46:29+02:00
Bug 10760: Integrate TorButton to TorBrowser core
Because of the non-restartless nature of Torbutton, it required
a two-stage installation process. On mobile, it was a problem,
because it was not loading when the user opened the browser for
the first time.
Moving it to tor-browser and making it a system extension allows it
to load when the user opens the browser for first time.
Additionally, this patch also fixes Bug 27611.
Bug 26321: New Circuit and New Identity menu items
Bug 14392: Make about:tor behave like other initial pages.
Bug 25013: Add torbutton as a tor-browser submodule
Bug 31575: Replace Firefox Home (newtab) with about:tor
Avoid loading AboutNewTab in BrowserGlue.jsm in order
to avoid several network requests that we do not need. Besides,
about:newtab will now point to about:blank or about:tor (depending
on browser.newtabpage.enabled) and about:home will point to
about:tor.
- - - - -
86119c3e by hackademix at 2023-05-29T21:46:29+02:00
Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs
- - - - -
d99e1f67 by Amogh Pradeep at 2023-05-29T21:46:30+02:00
Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.
See Bug 1357997 for partial uplift.
Also:
Bug 28051 - Use our Orbot for proxying our connections
Bug 31144 - ESR68 Network Code Review
- - - - -
d3ff90db by Alex Catarineu at 2023-05-29T21:46:30+02:00
Add TorStrings module for localization
- - - - -
fca792d4 by Kathy Brade at 2023-05-29T21:46:30+02:00
Bug 14631: Improve profile access error messages.
Instead of always reporting that the profile is locked, display specific
messages for "access denied" and "read-only file system".
To allow for localization, get profile-related error strings from Torbutton.
Use app display name ("Tor Browser") in profile-related error alerts.
- - - - -
d2797210 by sanketh at 2023-05-29T21:46:31+02:00
Bug 40209: Implement Basic Crypto Safety
Adds a CryptoSafety actor which detects when you've copied a crypto
address from a HTTP webpage and shows a warning.
Closes #40209.
Bug 40428: Fix string attribute names
- - - - -
4f3ccc71 by Kathy Brade at 2023-05-29T21:46:31+02:00
Bug 19273: Avoid JavaScript patching of the external app helper dialog.
When handling an external URI or downloading a file, invoke Torbutton's
external app blocker component (which will present a download warning
dialog unless the user has checked the "Automatically download files
from now on" box).
For e10s compatibility, avoid using a modal dialog and instead use
a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton
to indicate the user's desire to cancel or continue each request.
Other bugs fixed:
Bug 21766: Crash with e10s enabled while trying to download a file
Bug 21886: Download is stalled in non-e10s mode
Bug 22471: Downloading files via the PDF viewer download button is broken
Bug 22472: Fix FTP downloads when external helper app dialog is shown
Bug 22610: Avoid crashes when canceling external helper app downloads
Bug 22618: Downloading pdf file via file:/// is stalling
- - - - -
c24c33d5 by Pier Angelo Vendrame at 2023-05-29T21:46:32+02:00
Bug 40807: Added QRCode.js to toolkit/modules
- - - - -
179f078d by Richard Pospesel at 2023-05-29T21:46:32+02:00
Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
This patch adds a new about:preferences#connection page which allows
modifying bridge, proxy, and firewall settings from within Tor Browser.
All of the functionality present in tor-launcher's Network
Configuration panel is present:
- Setting built-in bridges
- Requesting bridges from BridgeDB via moat
- Using user-provided bridges
- Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
- Setting firewall ports
- Viewing and Copying Tor's logs
- The Networking Settings in General preferences has been removed
Bug 40774: Update about:preferences page to match new UI designs
- - - - -
dce0dd6d by Richard Pospesel at 2023-05-29T21:46:33+02:00
Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement
- adds tor connection status to url bar and tweaks UX when not online
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor
- explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP)
- various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
Bug 40773: Update the about:torconnect frontend page to match additional UI flows
- - - - -
fcf70a22 by Arthur Edelstein at 2023-05-29T21:46:33+02:00
Bug 12620: TorBrowser regression tests
Regression tests for Bug #2950: Make Permissions Manager memory-only
Regression tests for TB4: Tor Browser's Firefox preference overrides.
Note: many more functional tests could be made here
Regression tests for #2874: Block Components.interfaces from content
Bug 18923: Add a script to run all Tor Browser specific tests
Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
- - - - -
9bbaf69b by Kathy Brade at 2023-05-29T21:46:33+02:00
Bug 4234: Use the Firefox Update Process for Tor Browser.
The following files are never updated:
TorBrowser/Data/Browser/profiles.ini
TorBrowser/Data/Browser/profile.default/bookmarks.html
TorBrowser/Data/Tor/torrc
Mac OS: Store update metadata under TorBrowser/UpdateInfo.
Removed the %OS_VERSION% component from the update URL (13047) and
added support for minSupportedOSVersion, an attribute of the
<update> element that may be used to trigger Firefox's
"unsupported platform" behavior.
Hide the "What's new" links (set app.releaseNotesURL value to about:blank).
Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
16014, 16909, 24476, and 25909.
Also fix Bug 26049: reduce the delay before the update prompt is displayed.
Instead of Firefox's 2 days, we use 1 hour (after which time the update
doorhanger will be displayed).
Also fix bug 27221: purge the startup cache if the Tor Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Tor Browser update.
Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
Bug 26048: potentially confusing "restart to update" message
Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.
Bug 28885: notify users that update is downloading
Add a "Downloading Tor Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.
As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.
Removed #28885 parts of this patch which have been uplifted to Firefox.
- - - - -
66b2b788 by Kathy Brade at 2023-05-29T21:46:34+02:00
Bug 13379: Sign our MAR files.
Configure with --enable-verify-mar (when updating, require a valid
signature on the MAR file before it is applied).
Use the Tor Browser version instead of the Firefox version inside the
MAR file info block (necessary to prevent downgrade attacks).
Use NSS on all platforms for checking MAR signatures (instead of using
OS-native APIs, which Mozilla does on Mac OS and Windows). So that the
NSS and NSPR libraries the updater depends on can be found at runtime,
we add the firefox directory to the shared library search path on macOS.
On Linux, rpath is used by Mozilla to solve that problem, but that
approach won't work on macOS because the updater executable is copied
during the update process to a location that is under TorBrowser-Data,
and the location of TorBrowser-Data varies.
Also includes the fix for bug 18900.
Bug 19121: reinstate the update.xml hash check
Revert most changes from Mozilla Bug 1373267 "Remove hashFunction and
hashValue attributes from nsIUpdatePatch and code related to these
attributes." Changes to the tests were not reverted; the tests have
been changed significantly and we do not run automated updater tests
for Tor Browser at this time.
Also partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.
Revert the nsUpdateService.js changes from Mozilla Bug 862173 "don't
verify mar file hash when using mar signing to verify the mar file
(lessens main thread I/O)."
Changes to the tests were not reverted; the tests have been changed
significantly and we do not run automated updater tests for
Tor Browser at this time.
We kept the addition to the AppConstants API in case other JS code
references it in the future.
- - - - -
f87cd2d3 by Kathy Brade at 2023-05-29T21:46:34+02:00
Bug 16940: After update, load local change notes.
Add an about:tbupdate page that displays the first section from
TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
post-update page (typically our blog entry for the release).
Always load about:tbupdate in a content process, but implement the
code that reads the file system (changelog) in the chrome process
for compatibility with future sandboxing efforts.
Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
changelog page that is designed to be displayed via a link that is on
about:tor.
- - - - -
e46d4798 by Georg Koppen at 2023-05-29T21:46:35+02:00
Bug 32658: Create a new MAR signing key
It's time for our rotation again: Move the backup key in the front
position and add a new backup key.
Bug 33803: Move our primary nightly MAR signing key to tor-browser
Bug 33803: Add a secondary nightly MAR signing key
- - - - -
8c04eb3a by Mike Perry at 2023-05-29T21:46:35+02:00
Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
eBay and Amazon don't treat Tor users very well. Accounts often get locked and
payments reversed.
Also:
Bug 16322: Update DuckDuckGo search engine
We are replacing the clearnet URL with an onion service one (thanks to a
patch by a cypherpunk) and are removing the duplicated DDG search
engine. Duplicating DDG happend due to bug 1061736 where Mozilla
included DDG itself into Firefox. Interestingly, this caused breaking
the DDG search if JavaScript is disabled as the Mozilla engine, which
gets loaded earlier, does not use the html version of the search page.
Moreover, the Mozilla engine tracked where the users were searching from
by adding a respective parameter to the search query. We got rid of that
feature as well.
Also:
This fixes bug 20809: the DuckDuckGo team has changed its server-side
code in a way that lets users with JavaScript enabled use the default
landing page while those without JavaScript available get redirected
directly to the non-JS page. We adapt the search engine URLs
accordingly.
Also fixes bug 29798 by making sure we only specify the Google search
engine we actually ship an .xml file for.
Also regression tests.
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40494: Update Startpage search provider
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40438: Add Blockchair as a search engine
Bug 33342: Avoid disconnect search addon error after removal.
We removed the addon in #32767, but it was still being loaded
from addonStartup.json.lz4 and throwing an error on startup
because its resource: location is not available anymore.
- - - - -
fd289749 by Richard Pospesel at 2023-05-29T21:46:35+02:00
Bug 23247: Communicating security expectations for .onion
Encrypting pages hosted on Onion Services with SSL/TLS is redundant
(in terms of hiding content) as all traffic within the Tor network is
already fully encrypted. Therefore, serving HTTP pages from an Onion
Service is more or less fine.
Prior to this patch, Tor Browser would mostly treat pages delivered
via Onion Services as well as pages delivered in the ordinary fashion
over the internet in the same way. This created some inconsistencies
in behaviour and misinformation presented to the user relating to the
security of pages delivered via Onion Services:
- HTTP Onion Service pages did not have any 'lock' icon indicating
the site was secure
- HTTP Onion Service pages would be marked as unencrypted in the Page
Info screen
- Mixed-mode content restrictions did not apply to HTTP Onion Service
pages embedding Non-Onion HTTP content
This patch fixes the above issues, and also adds several new 'Onion'
icons to the mix to indicate all of the various permutations of Onion
Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
Strings for Onion Service Page Info page are pulled from Torbutton's
localization strings.
- - - - -
32b2cfed by Kathy Brade at 2023-05-29T21:46:36+02:00
Bug 30237: Add v3 onion services client authentication prompt
When Tor informs the browser that client authentication is needed,
temporarily load about:blank instead of about:neterror and prompt
for the user's key.
If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
control port command to add the key (via Torbutton's control port
module) and reload the page.
If the user cancels the prompt, display the standard about:neterror
"Unable to connect" page. This requires a small change to
browser/actors/NetErrorChild.jsm to account for the fact that the
docShell no longer has the failedChannel information. The failedChannel
is used to extract TLS-related error info, which is not applicable
in the case of a canceled .onion authentication prompt.
Add a leaveOpen option to PopupNotifications.show so we can display
error messages within the popup notification doorhanger without
closing the prompt.
Add support for onion services strings to the TorStrings module.
Add support for Tor extended SOCKS errors (Tor proposal 304) to the
socket transport and SOCKS layers. Improved display of all of these
errors will be implemented as part of bug 30025.
Also fixes bug 19757:
Add a "Remember this key" checkbox to the client auth prompt.
Add an "Onion Services Authentication" section within the
about:preferences "Privacy & Security section" to allow
viewing and removal of v3 onion client auth keys that have
been stored on disk.
Also fixes bug 19251: use enhanced error pages for onion service errors.
- - - - -
95f95339 by Alex Catarineu at 2023-05-29T21:46:36+02:00
Bug 21952: Implement Onion-Location
Whenever a valid Onion-Location HTTP header (or corresponding HTML
<meta> http-equiv attribute) is found in a document load, we either
redirect to it (if the user opted-in via preference) or notify the
presence of an onionsite alternative with a badge in the urlbar.
- - - - -
5d1ddbea by Pier Angelo Vendrame at 2023-05-29T21:46:37+02:00
Bug 40458: Implement .tor.onion aliases
We have enabled HTTPS-Only mode, therefore we do not need
HTTPS-Everywhere anymore.
However, we want to keep supporting .tor.onion aliases (especially for
securedrop).
Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
rulesets, and the redirect of .tor.onion domains.
Actually, Tor Browser believes they are actual domains. We change them
on the fly on the SOCKS proxy requests to resolve the domain, and on
the code that verifies HTTPS certificates.
- - - - -
e55b17b6 by Pier Angelo Vendrame at 2023-05-29T21:46:37+02:00
Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser
This patch associates the about:manual page to a translated page that
must be injected to browser/omni.ja after the build.
The content must be placed in chrome/browser/content/browser/manual/, so
that is then available at chrome://browser/content/manual/.
We preferred giving absolute freedom to the web team, rather than having
to change the patch in case of changes on the documentation.
- - - - -
39833b8f by Pier Angelo Vendrame at 2023-05-29T21:46:37+02:00
Bug 41435: Add a Tor Browser migration function
For now this function only deletes old language packs for which we are
already packaging the strings with the application.
- - - - -
88306421 by p13dz at 2023-05-29T21:46:40+02:00
Bug 40283: Workaround for the file upload bug
(cherry picked from commit c23f2f397327ee46a1a4de57acf206fd83e8e170)
- - - - -
e8d02fc5 by hackademix at 2023-05-29T21:46:41+02:00
Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key
- - - - -
30 changed files:
- .eslintignore
- .gitignore
- + .gitlab/issue_templates/UXBug.md
- + .gitlab/issue_templates/bug.md
- + .gitmodules
- + browser/actors/AboutTBUpdateChild.jsm
- + browser/actors/AboutTBUpdateParent.jsm
- + browser/actors/CryptoSafetyChild.jsm
- + browser/actors/CryptoSafetyParent.jsm
- browser/actors/NetErrorChild.jsm
- browser/actors/NetErrorParent.jsm
- browser/actors/moz.build
- browser/app/Makefile.in
- browser/app/macbuild/Contents/Info.plist.in
- browser/app/macbuild/Contents/MacOS-files.in
- browser/app/permissions
- + browser/app/profile/000-tor-browser.js
- + browser/app/profile/001-base-profile.js
- browser/app/profile/firefox.js
- browser/base/content/aboutDialog-appUpdater.js
- browser/base/content/aboutDialog.js
- browser/base/content/aboutDialog.xhtml
- + browser/base/content/abouttbupdate/aboutTBUpdate.css
- + browser/base/content/abouttbupdate/aboutTBUpdate.js
- + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml
- browser/base/content/appmenu-viewcache.inc.xhtml
- + browser/base/content/browser-doctype.inc
- browser/base/content/browser-menubar.inc
- browser/base/content/browser-safebrowsing.js
- browser/base/content/browser-sets.inc
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/26cfbf…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/26cfbf…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-12.5a6-build1
by Pier Angelo Vendrame (@pierov) 30 May '23
by Pier Angelo Vendrame (@pierov) 30 May '23
30 May '23
Pier Angelo Vendrame pushed new tag mb-12.5a6-build1 at The Tor Project / Applications / tor-browser-build
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40840: Mullvad Browser 12.5a6
by Pier Angelo Vendrame (@pierov) 30 May '23
by Pier Angelo Vendrame (@pierov) 30 May '23
30 May '23
Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
73e3fc07 by Pier Angelo Vendrame at 2023-05-30T17:12:21+00:00
Bug 40840: Mullvad Browser 12.5a6
This is the first alpha of the 12.5 series.
- - - - -
4 changed files:
- .gitignore
- projects/browser/config
- projects/firefox/config
- rbm.conf
Changes:
=====================================
.gitignore
=====================================
@@ -4,7 +4,7 @@
/out
/torbrowser
/basebrowser
-/privacybrowser
+/mullvadbrowser
/testbuild
/rbm.local.conf
/logs
=====================================
projects/browser/config
=====================================
@@ -106,13 +106,13 @@ input_files:
- URL: https://addons.mozilla.org/firefox/downloads/file/4111078/noscript-11.4.22.…
name: noscript
sha256sum: 46a84c85df4c6be11905388ad2b66aeb5a010ed615484112c8c1710ad13bc36e
- - URL: https://addons.mozilla.org/firefox/downloads/file/4079064/ublock_origin-1.4…
+ - URL: https://addons.mozilla.org/firefox/downloads/file/4103048/ublock_origin-1.4…
name: ublock-origin
- sha256sum: a35a6c8758ba74616afc09648c96d74ec2e7d27fe30f311d1db6e9a4966e7858
+ sha256sum: 39266486f720cd31d291d2fdad78625b079782a05517e1936eec7e780bc2a84d
enable: '[% c("var/mullvad-browser") %]'
- - URL: https://github.com/mullvad/browser-extension/releases/download/v0.7.7-firef…
+ - URL: https://github.com/mullvad/browser-extension/releases/download/v0.7.9-firef…
name: mullvad-extension
- sha256sum: dee0e2c089b40fb1a2a8ab5d69eefd382961f695fa4dc76def400aae79b81ecf
+ sha256sum: 17ce31b32e8be0f0db86a5a5ed93607cc84d5e2092341aee0b8eaba1c0746390
enable: '[% c("var/mullvad-browser") %]'
- filename: 'gtk3-settings.ini'
enable: '[% c("var/linux") %]'
=====================================
projects/firefox/config
=====================================
@@ -85,10 +85,7 @@ targets:
git_url: https://gitlab.torproject.org/tpo/applications/mullvad-browser.git
var:
branding_directory_prefix: 'mb'
- firefox_platform_version: 102.9.0
- browser_series: '12.0'
- browser_branch: '[% c("var/browser_series") %]-1'
- browser_build: 5
+ browser_build: 1
gitlab_project: https://gitlab.torproject.org/tpo/applications/mullvad-browser
linux-x86_64:
=====================================
rbm.conf
=====================================
@@ -276,10 +276,8 @@ targets:
exe_name: mullvadbrowser
mar_channel_id: '[% c("var/projectname") %]-mullvad-[% c("var/channel") %]'
locales: []
- torbrowser_version: '12.0a10'
- torbrowser_build: 'build1'
torbrowser_incremental_from:
- - 12.0a9
+ - 12.0a10
torbrowser-testbuild:
- testbuild
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40864: Add a script to download the latest manual
by Pier Angelo Vendrame (@pierov) 30 May '23
by Pier Angelo Vendrame (@pierov) 30 May '23
30 May '23
Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
11636bd7 by Pier Angelo Vendrame at 2023-05-30T19:10:29+02:00
Bug 40864: Add a script to download the latest manual
We can use the same GitLab token we use to create the changelogs also
to download the list of jobs in the manual project, and a new CI
artifact if needed.
- - - - -
1 changed file:
- + tools/fetch-manual.py
Changes:
=====================================
tools/fetch-manual.py
=====================================
@@ -0,0 +1,83 @@
+#!/usr/bin/env python3
+import hashlib
+from pathlib import Path
+import sys
+
+import requests
+import yaml
+
+
+GITLAB = "https://gitlab.torproject.org"
+API_URL = f"{GITLAB}/api/v4"
+PROJECT_ID = 23
+REF_NAME = "main"
+
+
+token_file = Path(__file__).parent / ".changelogs_token"
+if not token_file.exists():
+ print("This scripts uses the same access token as fetch-changelog.py.")
+ print("However, the file has not been found.")
+ print(
+ "Please run fetch-changelog.py to get the instructions on how to "
+ "generate it."
+ )
+ sys.exit(1)
+with token_file.open() as f:
+ headers = {"PRIVATE-TOKEN": f.read().strip()}
+
+r = requests.get(f"{API_URL}/projects/{PROJECT_ID}/jobs", headers=headers)
+if r.status_code == 401:
+ print("Unauthorized! Maybe the token has expired.")
+ sys.exit(2)
+found = False
+for job in r.json():
+ if job["ref"] != REF_NAME:
+ continue
+ for art in job["artifacts"]:
+ if art["filename"] == "artifacts.zip":
+ found = True
+ break
+ if found:
+ break
+if not found:
+ print("Cannot find a usable job.")
+ sys.exit(3)
+
+pipeline_id = job["pipeline"]["id"]
+conf_file = Path(__file__).parent.parent / "projects/manual/config"
+with conf_file.open() as f:
+ config = yaml.load(f, yaml.SafeLoader)
+if int(config["version"]) == int(pipeline_id):
+ print(
+ "projects/manual/config is already using the latest pipeline. Nothing to do."
+ )
+ sys.exit(0)
+
+manual_dir = Path(__file__).parent.parent / "out/manual"
+manual_dir.mkdir(0o755, parents=True, exist_ok=True)
+manual_file = manual_dir / f"manual_{pipeline_id}.zip"
+sha256 = hashlib.sha256()
+if manual_file.exists():
+ with manual_file.open("rb") as f:
+ while chunk := f.read(8192):
+ sha256.update(chunk)
+ print("You already have the latest manual version in your out directory.")
+ print("Please update projects/manual/config to:")
+else:
+ print("Downloading the new version of the manual...")
+ url = f"{API_URL}/projects/{PROJECT_ID}/jobs/artifacts/{REF_NAME}/download?job={job['name']}"
+ r = requests.get(url, headers=headers, stream=True)
+ # https://stackoverflow.com/a/16696317
+ r.raise_for_status()
+ with manual_file.open("wb") as f:
+ for chunk in r.iter_content(chunk_size=8192):
+ f.write(chunk)
+ sha256.update(chunk)
+ print(f"File downloaded as {manual_file}.")
+ print(
+ "Please upload it to people.torproject.org and then update projects/manual/config:"
+ )
+sha256 = sha256.hexdigest()
+
+print(f"\tversion: {pipeline_id}")
+print(f"\tSHA256: {sha256}")
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_102_12_0esr_BUILD1
by Pier Angelo Vendrame (@pierov) 29 May '23
by Pier Angelo Vendrame (@pierov) 29 May '23
29 May '23
Pier Angelo Vendrame pushed new tag FIREFOX_102_12_0esr_BUILD1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-102.12.0esr-12.5-1
by ma1 (@ma1) 29 May '23
by ma1 (@ma1) 29 May '23
29 May '23
ma1 pushed new branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-102.12.0esr-12.0-1
by ma1 (@ma1) 29 May '23
by ma1 (@ma1) 29 May '23
29 May '23
ma1 pushed new branch tor-browser-102.12.0esr-12.0-1 at The Tor Project / Applications / Tor Browser
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser][tor-browser-102.11.0esr-13.0-1] 13 commits: fixup! Firefox preference overrides.
by Pier Angelo Vendrame (@pierov) 29 May '23
by Pier Angelo Vendrame (@pierov) 29 May '23
29 May '23
Pier Angelo Vendrame pushed to branch tor-browser-102.11.0esr-13.0-1 at The Tor Project / Applications / Tor Browser
Commits:
16c0f67a by hackademix at 2023-05-29T10:30:14+02:00
fixup! Firefox preference overrides.
- - - - -
073b7c85 by Pier Angelo Vendrame at 2023-05-29T10:30:31+02:00
fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
Bug 41776: Keep shipping the old fontconfig file until users have one
- - - - -
2ce0dfb9 by Pier Angelo Vendrame at 2023-05-29T10:30:31+02:00
fixup! Firefox preference overrides.
Bug 41732: Use font.system.whitelist also on Linux as a defense-in-depth
- - - - -
c3a40e82 by Pier Angelo Vendrame at 2023-05-29T10:30:32+02:00
fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
Bug 41776 (fix): Added some missing lines to the previous patch
- - - - -
d3a2bcd2 by cypherpunks1 at 2023-05-29T10:30:32+02:00
fixup! Bug 23247: Communicating security expectations for .onion
Bug 33298: Warn when submitting form data from http onion sites over an insecure connection
- - - - -
c8e4ee0b by cypherpunks1 at 2023-05-29T10:30:33+02:00
fixup! Bug 23247: Communicating security expectations for .onion
Bug 41785: Show http onion resources as secure in network monitor
- - - - -
02ad5977 by Henry Wilkes at 2023-05-29T10:30:33+02:00
fixup! Bug 40597: Implement TorSettings module
Bug 41608 - Ignore tor connection errors when tor connection is
cancelled by the user. This can happen if the bootstrap process is
cancelled late in the process.
Also remove unused cancelAutoBootstrapping.
- - - - -
6e08e478 by Henry Wilkes at 2023-05-29T10:30:33+02:00
fixup! Add TorStrings module for localization
Bug 41608 - Add new connection status strings.
- - - - -
df852978 by Henry Wilkes at 2023-05-29T10:30:34+02:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41608 - Use the torconnect icon for the onion slash.
- - - - -
a71c563a by Henry Wilkes at 2023-05-29T10:30:34+02:00
fixup! Bug 21952: Implement Onion-Location
Bug 41608 - Use the same styling for ".onion available" urlbar button as
the tor-connect-urlbar-button. This also stops the button from
overflowing its container like before. Also move to after the bookmark
button.
- - - - -
b70efa00 by Henry Wilkes at 2023-05-29T10:33:17+02:00
amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor
Bug 40773: Update the about:torconnect frontend page to match additional UI flows.
Bug 41608: Add a toolbar status button and a urlbar "Connect" button.
- - - - -
8c2886c8 by Henry Wilkes at 2023-05-29T10:33:19+02:00
fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly
focused buttons in about:torconnect. The approach in tor-browser!607
prevented this by waiting for keyup, but keyup could still be triggered
by a key event initialized elsewhere. E.g. when pressing Enter to close
a modal dialog, the Enter's keyup event would be sent to the
about:torconnect page and trigger the focused button.
- - - - -
6c66708f by Dan Ballard at 2023-05-29T10:33:19+02:00
Bug 41749: Replace the onion-glyph with dedicated icon for onion services
- - - - -
30 changed files:
- browser/app/profile/001-base-profile.js
- browser/base/content/browser.js
- browser/base/content/browser.xhtml
- browser/base/content/navigator-toolbox.inc.xhtml
- browser/components/onionservices/content/onionlocation-urlbar.inc.xhtml
- browser/components/onionservices/content/onionlocation.css
- browser/components/torconnect/content/aboutTorConnect.js
- − browser/components/torconnect/content/onion-slash.svg
- − browser/components/torconnect/content/torBootstrapUrlbar.js
- + browser/components/torconnect/content/torConnectTitlebarStatus.css
- + browser/components/torconnect/content/torConnectTitlebarStatus.js
- + browser/components/torconnect/content/torConnectUrlbarButton.js
- − browser/components/torconnect/content/torconnect-urlbar.css
- − browser/components/torconnect/content/torconnect-urlbar.inc.xhtml
- browser/components/torconnect/jar.mn
- browser/components/torpreferences/content/torPreferences.css
- browser/modules/TorConnect.jsm
- browser/modules/TorStrings.jsm
- browser/themes/shared/browser-shared.css
- browser/themes/shared/identity-block/onion-slash.svg
- browser/themes/shared/identity-block/onion-warning.svg
- browser/themes/shared/identity-block/onion.svg
- browser/themes/shared/jar.inc.mn
- + browser/themes/shared/tor-urlbar-button.css
- devtools/shared/webconsole/network-helper.js
- dom/html/HTMLFormElement.cpp
- toolkit/torbutton/chrome/locale/en-US/torConnect.properties
- tools/update-packaging/common.sh
- tools/update-packaging/make_full_update.sh
- tools/update-packaging/make_incremental_update.sh
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -48,6 +48,9 @@ pref("security.nocertdb", true);
pref("browser.download.useDownloadDir", false);
pref("browser.download.manager.addToRecentDocs", false);
+// Prevent download stuffing / DOS (tor-browser#41764)
+pref("browser.download.enable_spam_prevention", true);
+
// Misc privacy: Disk
pref("signon.rememberSignons", false);
pref("browser.formfill.enable", false);
@@ -697,6 +700,8 @@ pref("font.name-list.monospace.x-unicode", "Consolas, Noto Sans Balinese, Noto S
#endif
#ifdef XP_LINUX
+pref("font.system.whitelist", "Arimo, Cousine, Noto Naskh Arabic, Noto Sans Adlam, Noto Sans Armenian, Noto Sans Balinese, Noto Sans Bamum, Noto Sans Bassa Vah, Noto Sans Batak, Noto Sans Bengali, Noto Sans Buginese, Noto Sans Buhid, Noto Sans Canadian Aboriginal, Noto Sans Chakma, Noto Sans Cham, Noto Sans Cherokee, Noto Sans Coptic, Noto Sans Deseret, Noto Sans Devanagari, Noto Sans Elbasan, Noto Sans Ethiopic, Noto Sans Georgian, Noto Sans Grantha, Noto Sans Gujarati, Noto Sans Gunjala Gondi, Noto Sans Gurmukhi, Noto Sans Hanifi Rohingya, Noto Sans Hanunoo, Noto Sans Hebrew, Noto Sans JP, Noto Sans Javanese, Noto Sans KR, Noto Sans Kannada, Noto Sans Kayah Li, Noto Sans Khmer, Noto Sans Khojki, Noto Sans Khudawadi, Noto Sans Lao, Noto Sans Lepcha, Noto Sans Limbu, Noto Sans Lisu, Noto Sans Mahajani, Noto Sans Malayalam, Noto Sans Mandaic, Noto Sans Masaram Gondi, Noto Sans Medefaidrin, Noto Sans Meetei Mayek, Noto Sans Mende Kikakui, Noto Sans Miao, Noto Sans Modi, Noto Sans Mongolian, Noto Sans Mro, Noto Sans Multani, Noto Sans Myanmar, Noto Sans NKo, Noto Sans New Tai Lue, Noto Sans Newa, Noto Sans Ol Chiki, Noto Sans Oriya, Noto Sans Osage, Noto Sans Osmanya, Noto Sans Pahawh Hmong, Noto Sans Pau Cin Hau, Noto Sans Rejang, Noto Sans Runic, Noto Sans SC, Noto Sans Samaritan, Noto Sans Saurashtra, Noto Sans Sharada, Noto Sans Shavian, Noto Sans Sinhala, Noto Sans Sora Sompeng, Noto Sans Soyombo, Noto Sans Sundanese, Noto Sans Syloti Nagri, Noto Sans Symbols, Noto Sans Symbols2, Noto Sans Syriac, Noto Sans TC, Noto Sans Tagalog, Noto Sans Tagbanwa, Noto Sans Tai Le, Noto Sans Tai Tham, Noto Sans Tai Viet, Noto Sans Takri, Noto Sans Tamil, Noto Sans Telugu, Noto Sans Thaana, Noto Sans Thai, Noto Sans Tifinagh, Noto Sans Tifinagh APT, Noto Sans Tifinagh Adrar, Noto Sans Tifinagh Agraw Imazighen, Noto Sans Tifinagh Ahaggar, Noto Sans Tifinagh Air, Noto Sans Tifinagh Azawagh, Noto Sans Tifinagh Ghat, Noto Sans Tifinagh Hawad, Noto Sans Tifinagh Rhissa Ixa, Noto Sans Tifinagh SIL, Noto Sans Tifinagh Tawellemmet, Noto Sans Tirhuta, Noto Sans Vai, Noto Sans Wancho, Noto Sans Warang Citi, Noto Sans Yi, Noto Sans Zanabazar Square, Noto Serif Armenian, Noto Serif Balinese, Noto Serif Bengali, Noto Serif Devanagari, Noto Serif Dogra, Noto Serif Ethiopic, Noto Serif Georgian, Noto Serif Grantha, Noto Serif Gujarati, Noto Serif Gurmukhi, Noto Serif Hebrew, Noto Serif Hmong Nyiakeng, Noto Serif Kannada, Noto Serif Khmer, Noto Serif Khojki, Noto Serif Lao, Noto Serif Malayalam, Noto Serif Myanmar, Noto Serif Sinhala, Noto Serif Tamil, Noto Serif Telugu, Noto Serif Thai, Noto Serif Tibetan, Noto Serif Yezidi, STIX Math, Tinos, Twemoji Mozilla");
+
// Arabic
pref("font.name-list.serif.ar", "Noto Naskh Arabic, Tinos");
pref("font.name-list.sans-serif.ar", "Noto Naskh Arabic, Arimo");
=====================================
browser/base/content/browser.js
=====================================
@@ -80,6 +80,8 @@ XPCOMUtils.defineLazyModuleGetters(this, {
TabCrashHandler: "resource:///modules/ContentCrashHandlers.jsm",
TelemetryEnvironment: "resource://gre/modules/TelemetryEnvironment.jsm",
TorConnect: "resource:///modules/TorConnect.jsm",
+ TorConnectState: "resource:///modules/TorConnect.jsm",
+ TorConnectTopics: "resource:///modules/TorConnect.jsm",
TorDomainIsolator: "resource://gre/modules/TorDomainIsolator.jsm",
Translation: "resource:///modules/translation/TranslationParent.jsm",
UITour: "resource:///modules/UITour.jsm",
@@ -270,6 +272,16 @@ XPCOMUtils.defineLazyScriptGetter(
"gSharedTabWarning",
"chrome://browser/content/browser-webrtc.js"
);
+XPCOMUtils.defineLazyScriptGetter(
+ this,
+ ["gTorConnectUrlbarButton"],
+ "chrome://browser/content/torconnect/torConnectUrlbarButton.js"
+);
+XPCOMUtils.defineLazyScriptGetter(
+ this,
+ ["gTorConnectTitlebarStatus"],
+ "chrome://browser/content/torconnect/torConnectTitlebarStatus.js"
+);
XPCOMUtils.defineLazyScriptGetter(
this,
["gTorCircuitPanel"],
@@ -1809,6 +1821,9 @@ var gBrowserInit = {
// Init the OnionAuthPrompt
OnionAuthPrompt.init();
+ gTorConnectUrlbarButton.init();
+ gTorConnectTitlebarStatus.init();
+
gTorCircuitPanel.init();
// Certain kinds of automigration rely on this notification to complete
@@ -1896,8 +1911,6 @@ var gBrowserInit = {
}
this._loadHandled = true;
-
- TorBootstrapUrlbar.init();
},
_cancelDelayedStartup() {
@@ -2555,9 +2568,10 @@ var gBrowserInit = {
OnionAuthPrompt.uninit();
- gTorCircuitPanel.uninit();
+ gTorConnectUrlbarButton.uninit();
+ gTorConnectTitlebarStatus.uninit();
- TorBootstrapUrlbar.uninit();
+ gTorCircuitPanel.uninit();
gAccessibilityServiceIndicator.uninit();
=====================================
browser/base/content/browser.xhtml
=====================================
@@ -37,6 +37,7 @@
<?xml-stylesheet href="chrome://browser/skin/places/editBookmark.css" type="text/css"?>
<?xml-stylesheet href="chrome://browser/content/onionservices/onionservices.css" type="text/css"?>
<?xml-stylesheet href="chrome://browser/content/torCircuitPanel.css" type="text/css"?>
+<?xml-stylesheet href="chrome://browser/content/torconnect/torConnectTitlebarStatus.css" type="text/css"?>
<!DOCTYPE window [
#include browser-doctype.inc
@@ -123,7 +124,6 @@
Services.scriptloader.loadSubScript("chrome://browser/content/search/searchbar.js", this);
Services.scriptloader.loadSubScript("chrome://browser/content/languageNotification.js", this);
Services.scriptloader.loadSubScript("chrome://torbutton/content/torbutton.js", this);
- Services.scriptloader.loadSubScript("chrome://browser/content/torconnect/torBootstrapUrlbar.js", this);
window.onload = gBrowserInit.onLoad.bind(gBrowserInit);
window.onunload = gBrowserInit.onUnload.bind(gBrowserInit);
=====================================
browser/base/content/navigator-toolbox.inc.xhtml
=====================================
@@ -93,6 +93,11 @@
aria-live="polite"/>
<hbox class="private-browsing-indicator"/>
+ <html:div id="tor-connect-titlebar-status" role="status">
+ <html:img alt="" id="tor-connect-titlebar-status-icon" />
+ <html:span id="tor-connect-titlebar-status-label"></html:span>
+ </html:div>
+
#include titlebar-items.inc.xhtml
</toolbar>
@@ -335,7 +340,6 @@
data-l10n-id="urlbar-go-button"/>
<hbox id="page-action-buttons" context="pageActionContextMenu">
<toolbartabstop/>
-#include ../../components/torconnect/content/torconnect-urlbar.inc.xhtml
<hbox id="contextual-feature-recommendation" role="button" hidden="true">
<hbox id="cfr-label-container">
<label id="cfr-label"/>
@@ -363,9 +367,6 @@
onclick="FullZoom.reset(); FullZoom.resetScalingZoom();"
tooltip="dynamic-shortcut-tooltip"
hidden="true"/>
-
-#include ../../components/onionservices/content/onionlocation-urlbar.inc.xhtml
-
<hbox id="pageActionButton"
class="urlbar-page-action"
role="button"
@@ -383,6 +384,15 @@
class="urlbar-icon"/>
</hbox>
</hbox>
+
+ <hbox id="tor-connect-urlbar-button"
+ role="button"
+ class="tor-urlbar-button"
+ hidden="true">
+ <label id="tor-connect-urlbar-button-label"/>
+ </hbox>
+
+#include ../../components/onionservices/content/onionlocation-urlbar.inc.xhtml
</hbox>
</hbox>
<toolbartabstop/>
=====================================
browser/components/onionservices/content/onionlocation-urlbar.inc.xhtml
=====================================
@@ -1,10 +1,10 @@
# Copyright (c) 2020, The Tor Project, Inc.
<hbox id="onion-location-box"
- class="urlbar-icon-wrapper urlbar-page-action"
+ class="tor-urlbar-button"
role="button"
hidden="true"
onclick="OnionLocationParent.buttonClick(event);">
<image id="onion-location-button" role="presentation"/>
- <hbox id="onion-label-container"><label id="onion-label"/></hbox>
+ <label id="onion-label"/>
</hbox>
=====================================
browser/components/onionservices/content/onionlocation.css
=====================================
@@ -1,44 +1,9 @@
/* Copyright (c) 2020, The Tor Project, Inc. */
-#onion-location-box {
- background-color: var(--purple-60);
- -moz-context-properties: fill;
- fill: white;
-}
-
-#onion-location-box:hover {
- background-color: var(--purple-70);
-}
-
-#onion-location-box:active {
- background-color: var(--purple-80);
-}
-
-@media (prefers-color-scheme: dark) {
- #onion-location-box {
- background-color: var(--purple-50);
- }
-
- #onion-location-box:hover {
- background-color: var(--purple-60);
- }
-
- #onion-location-box:active {
- background-color: var(--purple-70);
- }
-}
-
#onion-location-button {
list-style-image: url(chrome://browser/content/onionservices/onionlocation.svg);
- padding-inline-start: 0.5em;
-}
-
-label#onion-label {
- margin: 0;
- padding-block: 0;
- padding-inline: 0.5em;
- color: white;
- font-weight: normal;
+ -moz-context-properties: fill;
+ fill: currentColor;
}
.onionlocation-notification-icon {
=====================================
browser/components/torconnect/content/aboutTorConnect.js
=====================================
@@ -769,26 +769,29 @@ class AboutTorConnect {
}
});
- // Delay the "Enter" activation of the given button from "keydown" to
- // "keyup".
+ // Prevent repeat triggering on keydown when the Enter key is held down.
//
- // Without this, holding down Enter will continue to trigger the button
- // until the user stops holding. This means that a user can accidentally
- // re-trigger a button several times. This is particularly bad when the
- // focus gets moved to a new button, and the new button can get triggered
- // immediately. E.g. when the "Connect" button is triggered it disappears
- // and focus moves to the "Cancel" button.
+ // Without this, holding down Enter will continue to trigger the button's
+ // click event until the user stops holding. This means that a user can
+ // accidentally re-trigger a button several times. And if focus moves to a
+ // new button it can also get triggered, despite not receiving the initial
+ // keydown event.
+ //
+ // E.g. If the user presses down Enter on the "Connect" button it will
+ // trigger and focus will move to the "Cancel" button. This should prevent
+ // the user accidentally triggering the "Cancel" button if they hold down
+ // Enter for a little bit too long.
for (const button of document.body.querySelectorAll("button")) {
button.addEventListener("keydown", event => {
- if (event.key === "Enter") {
+ // If the keydown is a repeating Enter event, ignore it.
+ // NOTE: If firefox uses wayland display (rather than xwayland), the
+ // "repeat" event is always "false" so this will not work.
+ // See bugzilla bug 1784438. Also see bugzilla bug 1594003.
+ // Currently tor browser uses xwayland by default on linux.
+ if (event.key === "Enter" && event.repeat) {
event.preventDefault();
}
});
- button.addEventListener("keyup", event => {
- if (event.key === "Enter") {
- button.click();
- }
- });
}
}
=====================================
browser/components/torconnect/content/onion-slash.svg deleted
=====================================
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="m14.1161 15.6245c-.0821.0001-.1634-.016-.2393-.0474-.0758-.0314-.1447-.0775-.2027-.1356l-12.749984-12.749c-.109266-.11882-.168406-.27526-.165071-.43666.003335-.16139.068886-.31525.182967-.42946.114078-.11421.267868-.17994.429258-.18345.16139-.00352.3179.05544.43685.16457l12.74998 12.75c.1168.1176.1824.2767.1824.4425s-.0656.3249-.1824.4425c-.058.058-.1269.1039-.2028.1352-.0759.0312-.1571.0471-.2392.0468z" fill-opacity="context-fill-opacity" fill="#ff0039" />
- <path d="m 8,0.5000002 c -1.61963,0 -3.1197431,0.5137987 -4.3457031,1.3867188 l 0.84375,0.8417968 0.7792969,0.78125 0.8613281,0.8613282 0.8164062,0.8164062 0.9863281,0.984375 h 0.058594 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.01968 6.2e-4,0.039074 0,0.058594 L 10.8125,9.0449221 C 10.9334,8.7195921 11,8.3674002 11,8.0000002 c 0,-1.65685 -1.34314,-3 -3,-3 v -1.078125 c 2.25231,0 4.078125,1.825845 4.078125,4.078125 0,0.67051 -0.162519,1.3033281 -0.449219,1.8613281 l 0.861328,0.8613277 C 12.972434,9.9290067 13.25,8.9965102 13.25,8.0000002 c 0,-2.89949 -2.35049,-5.25 -5.25,-5.25 v -1.078125 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,1.29533 -0.388841,2.4990528 -1.056641,3.5019528 l 0.841797,0.84375 C 14.986181,11.119703 15.5,9.6196302 15.5,8.0000002 c 0,-4.14214 -3.3579,-7.5 -7.5,-7.5 z m -6.1113281,3.15625 C 1.0154872,4.8821451 0.5,6.3803304 0.5,8.0000002 0.5,12.1421 3.85786,15.5 8,15.5 c 1.6198027,0 3.117896,-0.515441 4.34375,-1.388672 L 11.501953,13.269531 C 10.498787,13.937828 9.295838,14.328125 8,14.328125 V 13.25 c 0.9967306,0 1.9287093,-0.277621 2.722656,-0.759766 L 9.859375,11.626953 C 9.3016226,11.913918 8.6705338,12.078125 8,12.078125 V 11 C 8.3664751,11 8.716425,10.93088 9.0410156,10.810547 6.6639891,8.4300416 4.2743195,6.0418993 1.8886719,3.6562502 Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
-</svg>
=====================================
browser/components/torconnect/content/torBootstrapUrlbar.js deleted
=====================================
@@ -1,95 +0,0 @@
-// Copyright (c) 2021, The Tor Project, Inc.
-
-"use strict";
-
-const { TorConnect, TorConnectTopics, TorConnectState } = ChromeUtils.import(
- "resource:///modules/TorConnect.jsm"
-);
-const { TorStrings } = ChromeUtils.import("resource:///modules/TorStrings.jsm");
-
-/* globals browser, gURLBar, Services */
-
-var TorBootstrapUrlbar = {
- selectors: Object.freeze({
- torConnect: {
- box: "hbox#torconnect-box",
- label: "label#torconnect-label",
- },
- }),
-
- elements: null,
-
- updateTorConnectBox(state) {
- switch (state) {
- case TorConnectState.Initial:
- case TorConnectState.Configuring:
- case TorConnectState.AutoConfiguring:
- case TorConnectState.Error:
- case TorConnectState.FatalError: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torNotConnectedConcise;
- this.elements.inputContainer.setAttribute("torconnect", "offline");
- break;
- }
- case TorConnectState.Bootstrapping: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torConnectingConcise;
- this.elements.inputContainer.setAttribute("torconnect", "connecting");
- break;
- }
- case TorConnectState.Bootstrapped: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torConnectedConcise;
- this.elements.inputContainer.setAttribute("torconnect", "connected");
- // hide torconnect box after 5 seconds
- setTimeout(() => {
- this.elements.torConnectBox.setAttribute("hidden", "true");
- }, 5000);
- break;
- }
- case TorConnectState.Disabled: {
- this.elements.torConnectBox.setAttribute("hidden", "true");
- break;
- }
- default:
- break;
- }
- },
-
- observe(aSubject, aTopic, aData) {
- if (aTopic === TorConnectTopics.StateChange) {
- const obj = aSubject?.wrappedJSObject;
- this.updateTorConnectBox(obj?.state);
- }
- },
-
- init() {
- if (TorConnect.shouldShowTorConnect) {
- // browser isn't populated until init
- this.elements = Object.freeze({
- torConnectBox: browser.ownerGlobal.document.querySelector(
- this.selectors.torConnect.box
- ),
- torConnectLabel: browser.ownerGlobal.document.querySelector(
- this.selectors.torConnect.label
- ),
- inputContainer: gURLBar._inputContainer,
- });
- this.elements.torConnectBox.addEventListener("click", () => {
- TorConnect.openTorConnect();
- });
- Services.obs.addObserver(this, TorConnectTopics.StateChange);
- this.observing = true;
- this.updateTorConnectBox(TorConnect.state);
- }
- },
-
- uninit() {
- if (this.observing) {
- Services.obs.removeObserver(this, TorConnectTopics.StateChange);
- }
- },
-};
=====================================
browser/components/torconnect/content/torConnectTitlebarStatus.css
=====================================
@@ -0,0 +1,38 @@
+#tor-connect-titlebar-status:not([hidden]) {
+ display: flex;
+ align-items: center;
+ /* Want same as #private-browsing-indicator-with-label */
+ margin-inline: 7px;
+}
+
+#tor-connect-titlebar-status-label {
+ margin-inline: 6px;
+ white-space: nowrap;
+}
+
+#tor-connect-titlebar-status-icon {
+ -moz-context-properties: fill;
+ fill: currentColor;
+ width: 16px;
+ height: 16px;
+}
+
+#tor-connect-titlebar-status-icon.tor-connect-status-connected {
+ fill: var(--purple-60);
+}
+
+@media (prefers-color-scheme: dark) {
+ #tor-connect-titlebar-status-icon.tor-connect-status-connected {
+ fill: var(--purple-30);
+ }
+}
+
+#tor-connect-titlebar-status-icon.tor-connect-status-potentially-blocked {
+ fill: #c50042;
+}
+
+@media (prefers-color-scheme: dark) {
+ #tor-connect-titlebar-status-icon.tor-connect-status-potentially-blocked {
+ fill: #ff9aa2;
+ }
+}
=====================================
browser/components/torconnect/content/torConnectTitlebarStatus.js
=====================================
@@ -0,0 +1,115 @@
+/* eslint-env mozilla/browser-window */
+
+/**
+ * A TorConnect status shown in the application title bar.
+ */
+var gTorConnectTitlebarStatus = {
+ /**
+ * The status element in the title bar.
+ *
+ * @type {Element}
+ */
+ node: null,
+ /**
+ * The status label.
+ *
+ * @type {Element}
+ */
+ label: null,
+ /**
+ * The status icon.
+ *
+ * @type {Element}
+ */
+ icon: null,
+
+ /**
+ * Initialize the component.
+ */
+ init() {
+ const { TorStrings } = ChromeUtils.import(
+ "resource:///modules/TorStrings.jsm"
+ );
+
+ this._strings = TorStrings.torConnect;
+
+ this.node = document.getElementById("tor-connect-titlebar-status");
+ this.icon = document.getElementById("tor-connect-titlebar-status-icon");
+ this.label = document.getElementById("tor-connect-titlebar-status-label");
+ // The title also acts as an accessible name for the role="status".
+ this.node.setAttribute("title", this._strings.titlebarStatusName);
+
+ this._observeTopic = TorConnectTopics.StateChange;
+ this._stateListener = {
+ observe: (subject, topic, data) => {
+ if (topic !== this._observeTopic) {
+ return;
+ }
+ this._torConnectStateChanged();
+ },
+ };
+ Services.obs.addObserver(this._stateListener, this._observeTopic);
+
+ this._torConnectStateChanged();
+ },
+
+ /**
+ * De-initialize the component.
+ */
+ deinit() {
+ Services.obs.removeObserver(this._stateListener, this._observeTopic);
+ },
+
+ /**
+ * Callback for when the TorConnect state changes.
+ */
+ _torConnectStateChanged() {
+ let textId;
+ let connected = false;
+ let potentiallyBlocked = false;
+ switch (TorConnect.state) {
+ case TorConnectState.Disabled:
+ // Hide immediately.
+ this.node.hidden = true;
+ return;
+ case TorConnectState.Bootstrapped:
+ this._startHiding();
+ textId = "titlebarStatusConnected";
+ connected = true;
+ break;
+ case TorConnectState.Bootstrapping:
+ case TorConnectState.AutoBootstrapping:
+ textId = "titlebarStatusConnecting";
+ break;
+ default:
+ if (TorConnect.potentiallyBlocked) {
+ textId = "titlebarStatusPotentiallyBlocked";
+ potentiallyBlocked = true;
+ } else {
+ textId = "titlebarStatusNotConnected";
+ }
+ break;
+ }
+ this.label.textContent = this._strings[textId];
+ this.icon.setAttribute(
+ "src",
+ connected
+ ? "chrome://browser/content/torconnect/onion.svg"
+ : "chrome://browser/content/torconnect/onion-slash-fillable.svg"
+ );
+ this.icon.classList.toggle("tor-connect-status-connected", connected);
+ this.icon.classList.toggle(
+ "tor-connect-status-potentially-blocked",
+ potentiallyBlocked
+ );
+ },
+
+ /**
+ * Mark the component to be hidden after some delay.
+ */
+ _startHiding() {
+ setTimeout(() => {
+ this.node.hidden = true;
+ }, 5000);
+ },
+};
=====================================
browser/components/torconnect/content/torConnectUrlbarButton.js
=====================================
@@ -0,0 +1,155 @@
+/* eslint-env mozilla/browser-window */
+
+/**
+ * A "Connect" button shown in the urlbar when not connected to tor and in tabs
+ * other than about:torconnect.
+ */
+var gTorConnectUrlbarButton = {
+ /**
+ * The urlbar button node.
+ *
+ * @type {Element}
+ */
+ button: null,
+ /**
+ * Whether we are active.
+ *
+ * @type {boolean}
+ */
+ _isActive: false,
+ /**
+ * Whether we are in the "about:torconnect" tab.
+ *
+ * @type {boolean}
+ */
+ // We init to "true" so that the button can only appear after the first page
+ // load.
+ _inAboutTorConnectTab: true,
+
+ /**
+ * Initialize the button.
+ */
+ init() {
+ if (this._isActive) {
+ return;
+ }
+ this._isActive = true;
+
+ const { TorStrings } = ChromeUtils.import(
+ "resource:///modules/TorStrings.jsm"
+ );
+
+ this.button = document.getElementById("tor-connect-urlbar-button");
+ document.getElementById("tor-connect-urlbar-button-label").value =
+ TorStrings.torConnect.torConnectButton;
+ this.button.addEventListener("click", event => {
+ if (event.button !== 0) {
+ return;
+ }
+ this.connect();
+ });
+ this.button.addEventListener("keydown", event => {
+ if (event.key !== "Enter" && event.key !== " ") {
+ return;
+ }
+ this.connect();
+ });
+
+ this._observeTopic = TorConnectTopics.StateChange;
+ this._stateListener = {
+ observe: (subject, topic, data) => {
+ if (topic !== this._observeTopic) {
+ return;
+ }
+ this._torConnectStateChanged();
+ },
+ };
+ Services.obs.addObserver(this._stateListener, this._observeTopic);
+
+ this._locationListener = {
+ onLocationChange: (webProgress, request, locationURI, flags) => {
+ if (
+ webProgress.isTopLevel &&
+ !(flags & Ci.nsIWebProgressListener.LOCATION_CHANGE_SAME_DOCUMENT)
+ ) {
+ this._inAboutTorConnectTab = gBrowser.selectedBrowser.currentURI?.spec.startsWith(
+ "about:torconnect"
+ );
+ this._updateButtonVisibility();
+ }
+ },
+ };
+ // Notified of new locations for the currently selected browser (tab) *and*
+ // switching selected browser.
+ gBrowser.addProgressListener(this._locationListener);
+
+ this._torConnectStateChanged();
+ },
+
+ /**
+ * Deactivate and de-initialize the button.
+ */
+ deinit() {
+ if (!this._isActive) {
+ return;
+ }
+ this._isActive = false;
+
+ Services.obs.removeObserver(this._stateListener, this._observeTopic);
+ gBrowser.removeProgressListener(this._locationListener);
+ this._updateButtonVisibility();
+ },
+
+ /**
+ * Begin the tor connection bootstrapping process.
+ */
+ connect() {
+ TorConnect.openTorConnect({ beginBootstrap: true });
+ },
+
+ /**
+ * Callback for when the TorConnect state changes.
+ */
+ _torConnectStateChanged() {
+ if (
+ TorConnect.state === TorConnectState.Bootstrapped ||
+ TorConnect.state === TorConnectState.Disabled
+ ) {
+ this.deinit();
+ return;
+ }
+ this._updateButtonVisibility();
+ },
+
+ /**
+ * Callback when the TorConnect state, current browser location, or activation
+ * state changes.
+ */
+ _updateButtonVisibility() {
+ if (!this.button) {
+ return;
+ }
+ // NOTE: We do not manage focus when hiding the button. We only expect to
+ // move from "not hidden" to "hidden" when:
+ // + switching tabs to "about:torconnect", or
+ // + starting bootstrapping.
+ //
+ // When switching tabs, the normal tab switching logic will eventually move
+ // focus to the new tab or url bar, so whilst the focus may be lost
+ // temporarily when we hide the button, it will be re-established quickly on
+ // tab switch.
+ //
+ // And we don't expect bootstrapping to start whilst outside of the
+ // "about:torconnect", and the automatic bootstrapping should only trigger
+ // at the initial start.
+ this.button.hidden =
+ !this._isActive ||
+ this._inAboutTorConnectTab ||
+ !TorConnect.enabled ||
+ !TorConnect.canBeginBootstrap;
+ this.button.classList.toggle(
+ "tor-urlbar-button-plain",
+ TorConnect.potentiallyBlocked
+ );
+ },
+};
=====================================
browser/components/torconnect/content/torconnect-urlbar.css deleted
=====================================
@@ -1,37 +0,0 @@
-/*
- ensure our torconnect button is always visible (same rule as for the bookmark button)
-*/
-label#torconnect-label {
- margin: 0;
- opacity: 0.6;
- padding: 0 0.5em;
-}
-
-hbox.urlbar-page-action#torconnect-box {
- display: -moz-inline-box!important;
-}
-
-/* hide when hidden attribute is set */
-hbox.urlbar-page-action#torconnect-box[hidden="true"],
-/* hide when user is typing in URL bar */
-#urlbar[usertyping] > #urlbar-input-container > #page-action-buttons > #torconnect-box {
- display: none!important;
-}
-
-/* hide urlbar's placeholder text when not connectd to tor */
-hbox#urlbar-input-container[torconnect="offline"] input#urlbar-input::placeholder,
-hbox#urlbar-input-container[torconnect="connecting"] input#urlbar-input::placeholder {
- opacity: 0;
-}
-
-/* hide search suggestions when not connected to tor */
-hbox#urlbar-input-container[torconnect="offline"] + vbox.urlbarView,
-hbox#urlbar-input-container[torconnect="connecting"] + vbox.urlbarView {
- display: none!important;
-}
-
-/* hide search icon when we are not connected to tor */
-hbox#urlbar-input-container[torconnect="offline"] > #identity-box[pageproxystate="invalid"] > #identity-icon,
-hbox#urlbar-input-container[torconnect="connecting"] > #identity-box[pageproxystate="invalid"] > #identity-icon {
- display: none!important;
-}
=====================================
browser/components/torconnect/content/torconnect-urlbar.inc.xhtml deleted
=====================================
@@ -1,11 +0,0 @@
-# Copyright (c) 2021, The Tor Project, Inc.
-
-<hbox id="torconnect-box"
- class="urlbar-icon-wrapper urlbar-page-action"
- role="status"
- align="center"
- hidden="true">
- <hbox id="torconnect-container">
- <label id="torconnect-label"/>
- </hbox>
-</hbox>
\ No newline at end of file
=====================================
browser/components/torconnect/jar.mn
=====================================
@@ -1,5 +1,7 @@
browser.jar:
- content/browser/torconnect/torBootstrapUrlbar.js (content/torBootstrapUrlbar.js)
+ content/browser/torconnect/torConnectUrlbarButton.js (content/torConnectUrlbarButton.js)
+ content/browser/torconnect/torConnectTitlebarStatus.js (content/torConnectTitlebarStatus.js)
+ content/browser/torconnect/torConnectTitlebarStatus.css (content/torConnectTitlebarStatus.css)
content/browser/torconnect/aboutTorConnect.css (content/aboutTorConnect.css)
* content/browser/torconnect/aboutTorConnect.xhtml (content/aboutTorConnect.xhtml)
content/browser/torconnect/aboutTorConnect.js (content/aboutTorConnect.js)
@@ -8,6 +10,4 @@ browser.jar:
content/browser/torconnect/connection-failure.svg (content/connection-failure.svg)
content/browser/torconnect/connection-location.svg (content/connection-location.svg)
content/browser/torconnect/onion.svg (content/onion.svg)
- content/browser/torconnect/onion-slash.svg (content/onion-slash.svg)
content/browser/torconnect/onion-slash-fillable.svg (content/onion-slash-fillable.svg)
- skin/classic/browser/torconnect-urlbar.css (content/torconnect-urlbar.css)
=====================================
browser/components/torpreferences/content/torPreferences.css
=====================================
@@ -58,7 +58,7 @@ html:dir(rtl) input[type="checkbox"].toggle-button::before {
#torPreferences-connectMessageBox.error #torPreferences-connectMessageBox-icon
{
- mask: url("chrome://browser/skin/onion-slash.svg");
+ mask: url("chrome://browser/content/torconnect/onion-slash-fillable.svg");
background-color: white;
}
=====================================
browser/modules/TorConnect.jsm
=====================================
@@ -99,7 +99,7 @@ const TorConnectState = Object.freeze({
└─┼─────▶ │ │ │
│ └──────────────────────────────────────────────────────────┘ │
│ │ ▲ │
- │ │ beginAutoBootstrap() │ cancelAutoBootstrap() │
+ │ │ beginAutoBootstrap() │ cancelBootstrap() │
│ ▼ │ │
│ ┌───────────────────────┐ │ │
└────── │ AutoBootstrapping │ ─┘ │
@@ -464,6 +464,7 @@ const TorConnect = (() => {
const tbr = new TorBootstrapRequest();
const internetTest = new InternetTest();
+ let cancelled = false;
let bootstrapError = "";
let bootstrapErrorDetails = "";
@@ -506,6 +507,7 @@ const TorConnect = (() => {
this.on_transition = async nextState => {
if (nextState === TorConnectState.Configuring) {
// stop bootstrap process if user cancelled
+ cancelled = true;
internetTest.cancel();
await tbr.cancel();
}
@@ -520,6 +522,19 @@ const TorConnect = (() => {
TorConnect._changeState(TorConnectState.Bootstrapped);
};
tbr.onbootstraperror = (message, details) => {
+ if (cancelled) {
+ // We ignore this error since it occurred after cancelling (by
+ // the user). We assume the error is just a side effect of the
+ // cancelling.
+ // E.g. If the cancelling is triggered late in the process, we
+ // get "Building circuits: Establishing a Tor circuit failed".
+ // TODO: Maybe move this logic deeper in the process to know
+ // when to filter out such errors triggered by cancelling.
+ console.log(
+ `TorConnect: Post-cancel error => ${message}; ${details}`
+ );
+ return;
+ }
// We have to wait for the Internet test to finish before sending the bootstrap error
bootstrapError = message;
bootstrapErrorDetails = details;
@@ -1023,11 +1038,6 @@ const TorConnect = (() => {
this._changeState(TorConnectState.AutoBootstrapping, countryCode);
},
- cancelAutoBootstrap() {
- console.log("TorConnect: cancelAutoBootstrap()");
- this._changeState(TorConnectState.Configuring);
- },
-
/*
Further external commands and helper methods
*/
=====================================
browser/modules/TorStrings.jsm
=====================================
@@ -207,10 +207,6 @@ const Loader = {
torConnecting: "Establishing a Connection",
- torNotConnectedConcise: "Not Connected",
-
- torConnectingConcise: "Connecting…",
-
tryingAgain: "Trying again…",
noInternet: "Tor Browser couldn’t reach the Internet",
@@ -250,8 +246,6 @@ const Loader = {
torConnected: "Connected to the Tor network",
- torConnectedConcise: "Connected",
-
tryAgain: "Try Again",
// tor connect strings for message box in about:preferences#connection
@@ -275,6 +269,13 @@ const Loader = {
autoBootstrappingAllFailed: "None of the configurations we tried worked",
cannotDetermineCountry: "Unable to determine user country",
noSettingsForCountry: "No settings available for your location",
+
+ // Titlebar status.
+ titlebarStatusName: "Tor connection",
+ titlebarStatusNotConnected: "Not connected",
+ titlebarStatusConnecting: "Connecting…",
+ titlebarStatusPotentiallyBlocked: "Potentially blocked",
+ titlebarStatusConnected: "Connected",
};
const tsb = new TorPropertyStringBundle(
=====================================
browser/themes/shared/browser-shared.css
=====================================
@@ -23,8 +23,8 @@
@import url("chrome://browser/skin/UITour.css");
@import url("chrome://browser/skin/browser-colors.css");
@import url("chrome://branding/content/tor-styles.css");
-@import url("chrome://browser/skin/torconnect-urlbar.css");
@import url("chrome://browser/skin/onionlocation.css");
+@import url("chrome://browser/skin/tor-urlbar-button.css");
@namespace html url("http://www.w3.org/1999/xhtml");
=====================================
browser/themes/shared/identity-block/onion-slash.svg
=====================================
@@ -1,5 +1,16 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="m14.1161 15.6245c-.0821.0001-.1634-.016-.2393-.0474-.0758-.0314-.1447-.0775-.2027-.1356l-12.749984-12.749c-.109266-.11882-.168406-.27526-.165071-.43666.003335-.16139.068886-.31525.182967-.42946.114078-.11421.267868-.17994.429258-.18345.16139-.00352.3179.05544.43685.16457l12.74998 12.75c.1168.1176.1824.2767.1824.4425s-.0656.3249-.1824.4425c-.058.058-.1269.1039-.2028.1352-.0759.0312-.1571.0471-.2392.0468z" fill-opacity="context-fill-opacity" fill="#ff0039" />
- <path d="m 8,0.5000002 c -1.61963,0 -3.1197431,0.5137987 -4.3457031,1.3867188 l 0.84375,0.8417968 0.7792969,0.78125 0.8613281,0.8613282 0.8164062,0.8164062 0.9863281,0.984375 h 0.058594 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.01968 6.2e-4,0.039074 0,0.058594 L 10.8125,9.0449221 C 10.9334,8.7195921 11,8.3674002 11,8.0000002 c 0,-1.65685 -1.34314,-3 -3,-3 v -1.078125 c 2.25231,0 4.078125,1.825845 4.078125,4.078125 0,0.67051 -0.162519,1.3033281 -0.449219,1.8613281 l 0.861328,0.8613277 C 12.972434,9.9290067 13.25,8.9965102 13.25,8.0000002 c 0,-2.89949 -2.35049,-5.25 -5.25,-5.25 v -1.078125 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,1.29533 -0.388841,2.4990528 -1.056641,3.5019528 l 0.841797,0.84375 C 14.986181,11.119703 15.5,9.6196302 15.5,8.0000002 c 0,-4.14214 -3.3579,-7.5 -7.5,-7.5 z m -6.1113281,3.15625 C 1.0154872,4.8821451 0.5,6.3803304 0.5,8.0000002 0.5,12.1421 3.85786,15.5 8,15.5 c 1.6198027,0 3.117896,-0.515441 4.34375,-1.388672 L 11.501953,13.269531 C 10.498787,13.937828 9.295838,14.328125 8,14.328125 V 13.25 c 0.9967306,0 1.9287093,-0.277621 2.722656,-0.759766 L 9.859375,11.626953 C 9.3016226,11.913918 8.6705338,12.078125 8,12.078125 V 11 C 8.3664751,11 8.716425,10.93088 9.0410156,10.810547 6.6639891,8.4300416 4.2743195,6.0418993 1.8886719,3.6562502 Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_1827_6565)">
+<path d="M6.62435 8.54824C6.23983 8.91273 6 9.42836 6 10C6 11.1046 6.89543 12 8 12C8.57164 12 9.08727 11.7602 9.45176 11.3757L8.74414 10.668C8.56107 10.8718 8.29551 11 8 11C7.44772 11 7 10.5523 7 10C7 9.70449 7.12818 9.43893 7.33197 9.25586L6.62435 8.54824Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M9.99442 10.1505C9.99812 10.1008 10 10.0506 10 10C10 8.89543 9.10457 8 8 8C7.94936 8 7.89915 8.00188 7.84946 8.00558L9.99442 10.1505Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M5.20988 7.13377C4.46354 7.86041 4 8.87607 4 10C4 12.2091 5.79086 14 8 14C9.12393 14 10.1396 13.5365 10.8662 12.7901L10.159 12.0829C9.61343 12.6483 8.84778 13 8 13C6.34315 13 5 11.6569 5 10C5 9.15222 5.35166 8.38657 5.91707 7.84097L5.20988 7.13377Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M10.8331 10.9892C10.9412 10.6795 11 10.3466 11 10C11 8.34315 9.65685 7 8 7C7.65339 7 7.32052 7.05878 7.01079 7.16692L6.24731 6.40343C6.77658 6.14502 7.37135 6 8 6C10.2091 6 12 7.79086 12 10C12 10.6286 11.855 11.2234 11.5966 11.7527L10.8331 10.9892Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M14 10C14 8.223 13.2275 6.62643 12 5.52779V4C12 1.79086 10.2091 0 8 0C5.79086 0 4 1.79086 4 4V4.15613L5.50811 5.66423C6.2417 5.2417 7.09263 5 8 5C10.7614 5 13 7.23858 13 10C13 10.9074 12.7583 11.7583 12.3358 12.4919L13.0637 13.2199C13.6565 12.2896 14 11.1849 14 10ZM8 4C7.00883 4 6.0738 4.24033 5.25 4.66591V4C5.25 2.48122 6.48122 1.25 8 1.25C9.51878 1.25 10.75 2.48122 10.75 4V4.66591C9.9262 4.24033 8.99117 4 8 4Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M12.2805 14.2044C11.1919 15.3126 9.67621 16 8 16C4.68629 16 2 13.3137 2 10C2 8.32379 2.68736 6.80812 3.79558 5.71948L4.50272 6.42662C3.57545 7.33427 3 8.59993 3 10C3 12.7614 5.23858 15 8 15C9.40007 15 10.6657 14.4246 11.5734 13.4973L12.2805 14.2044Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M1.25801 3.93806C1.50209 3.69398 1.89782 3.69398 2.14189 3.93806L13.1419 14.9381C13.386 15.1821 13.386 15.5779 13.1419 15.8219C12.8978 16.066 12.5021 16.066 12.258 15.8219L1.25801 4.82194C1.01393 4.57787 1.01393 4.18214 1.25801 3.93806Z" fill="#F90D3F"/>
+</g>
+<defs>
+<clipPath id="clip0_1827_6565">
+<rect width="16" height="16" fill="white"/>
+</clipPath>
+</defs>
</svg>
=====================================
browser/themes/shared/identity-block/onion-warning.svg
=====================================
@@ -1,4 +1,13 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="M 7.5,0.5 C 3.35786,0.5 0,3.85786 0,8 c 0,3.7093 2.6930488,6.789278 6.2304688,7.392578 -0.032181,-0.0637 -0.060149,-0.128686 -0.085938,-0.195312 -0.00862,-0.02227 -0.01751,-0.04385 -0.025391,-0.06641 -0.023385,-0.0669 -0.043878,-0.135932 -0.060547,-0.205078 -0.00186,-0.0077 -0.00213,-0.01571 -0.00391,-0.02344 -0.017615,-0.07685 -0.032109,-0.153488 -0.041016,-0.232422 -7.27e-5,-6.44e-4 7.2e-5,-0.0013 0,-0.002 -0.0087,-0.07777 -0.011896,-0.157155 -0.011719,-0.236328 7.71e-5,-0.0337 2.127e-4,-0.06769 0.00195,-0.101563 3.337e-4,-0.0065 -3.955e-4,-0.01303 0,-0.01953 0.00318,-0.05219 0.0084,-0.10381 0.015625,-0.15625 0.03623,-0.263929 0.1235201,-0.529812 0.2714844,-0.787109 L 6.421875,13.138672 C 7.1130865,11.933878 7.8482649,10.654869 8.4882812,9.5390625 8.2033713,9.7224325 7.864,9.828125 7.5,9.828125 v -3.65625 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.02558 -9.131e-4,0.050842 -0.00195,0.076172 L 9.6015625,7.5957031 C 9.7779825,7.2883331 10.012797,7.0451975 10.279297,6.8671875 9.8324169,5.7717775 8.75611,5 7.5,5 V 3.921875 c 1.72627,0 3.201675,1.0728106 3.796875,2.5878906 0.4511,-0.0416 0.914353,0.052393 1.314453,0.2832032 C 12.066128,4.4750988 9.98426,2.75 7.5,2.75 V 1.671875 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,0.10641 -0.0026,0.2112863 -0.0078,0.3164062 L 14.74806,9.9355469 C 14.912447,9.3182669 15,8.66904 15,8 15,3.85786 11.6421,0.5 7.5,0.5 Z m 4,7 c -0.40375,0 -0.808156,0.19825 -1.035156,0.59375 l -3.3105471,5.771484 c -0.446,0.775 0.1271562,1.734375 1.0351562,1.734375 H 14.8125 c 0.907,0 1.478203,-0.959375 1.033203,-1.734375 L 12.535156,8.09375 C 12.308156,7.69825 11.90375,7.5 11.5,7.5 Z m 0,2.1015625 c 0.1658,0 0.324206,0.066384 0.441406,0.1835937 0.1172,0.1172101 0.183594,0.2757058 0.183594,0.4414058 v 1.748047 c 0,0.1658 -0.06639,0.324207 -0.183594,0.441407 -0.1172,0.1172 -0.275606,0.183593 -0.441406,0.183593 -0.1657,0 -0.324206,-0.06639 -0.441406,-0.183593 -0.1172,-0.1172 -0.183594,-0.275607 -0.183594,-0.441407 v -1.748047 c 0,-0.165699 0.06639,-0.3241957 0.183594,-0.4414058 C 11.175794,9.6679462 11.3343,9.6015625 11.5,9.6015625 Z m 0,3.7480465 c 0.1658,0 0.324206,0.06639 0.441406,0.183594 0.1172,0.1172 0.183594,0.275706 0.183594,0.441406 0,0.1658 -0.06639,0.32616 -0.183594,0.44336 -0.1172,0.1172 -0.275606,0.18164 -0.441406,0.18164 -0.1657,0 -0.324206,-0.06444 -0.441406,-0.18164 -0.1172,-0.1172 -0.183594,-0.27756 -0.183594,-0.44336 0,-0.1657 0.06639,-0.324206 0.183594,-0.441406 0.1172,-0.1172 0.275706,-0.183594 0.441406,-0.183594 z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_1827_6566)">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M7.92788 10.5342L7.42044 11.408C7.05803 11.7736 6.55546 12 6 12C4.89543 12 4 11.1046 4 10C4 8.89543 4.89543 8 6 8C7.10457 8 8 8.89543 8 10C8 10.185 7.97488 10.3641 7.92788 10.5342ZM7 10C7 10.5523 6.55228 11 6 11C5.44772 11 5 10.5523 5 10C5 9.44772 5.44772 9 6 9C6.55228 9 7 9.44772 7 10Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M6.52221 12.9547C6.35262 12.9845 6.17812 13 6 13C4.34315 13 3 11.6569 3 10C3 8.34315 4.34315 7 6 7C7.30202 7 8.41032 7.82945 8.8253 8.98878L9.35089 8.08372C9.37772 8.03755 9.40587 7.99285 9.43523 7.94962C8.73673 6.78186 7.45967 6 6 6C3.79086 6 2 7.79086 2 10C2 12.1857 3.75302 13.9619 5.92975 13.9994C5.96208 13.9274 5.99884 13.8558 6.0402 13.7847L6.52221 12.9547Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M11.1978 7.00088C10.8782 6.44807 10.4728 5.95098 10 5.52779V4C10 1.79086 8.20914 0 6 0C3.79086 0 2 1.79086 2 4V5.52779C0.772501 6.62643 0 8.223 0 10C0 13.3137 2.68629 16 6 16C6.03024 16 6.06043 15.9998 6.09057 15.9993C5.89561 15.7007 5.77424 15.3557 5.749 14.9938C3.10419 14.8631 1 12.6773 1 10C1 7.23858 3.23858 5 6 5C7.75288 5 9.29509 5.90201 10.1878 7.26719C10.5002 7.0977 10.8482 7.00893 11.1978 7.00088ZM6 4C5.00883 4 4.0738 4.24033 3.25 4.66591V4C3.25 2.48122 4.48122 1.25 6 1.25C7.51878 1.25 8.75 2.48122 8.75 4V4.66591C7.9262 4.24033 6.99117 4 6 4Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M15.5956 14.2875L12.2846 8.58591C11.8306 7.8047 10.6696 7.8047 10.2156 8.58591L6.90465 14.2875C6.45865 15.0529 7.03065 16 7.93865 16H14.5616C15.4686 16 16.0406 15.0529 15.5956 14.2875ZM11.8746 12.4189C11.8746 12.5826 11.8088 12.7396 11.6916 12.8553C11.5744 12.9711 11.4154 13.0361 11.2496 13.0361C11.0839 13.0361 10.9249 12.9711 10.8077 12.8553C10.6905 12.7396 10.6246 12.5826 10.6246 12.4189V10.6935C10.6246 10.5298 10.6905 10.3728 10.8077 10.257C10.9249 10.1413 11.0839 10.0762 11.2496 10.0762C11.4154 10.0762 11.5744 10.1413 11.6916 10.257C11.8088 10.3728 11.8746 10.5298 11.8746 10.6935V12.4189ZM11.2496 15.0124C11.0839 15.0124 10.9249 14.9473 10.8077 14.8316C10.6905 14.7158 10.6246 14.5588 10.6246 14.3951C10.6246 14.2314 10.6905 14.0744 10.8077 13.9586C10.9249 13.8429 11.0839 13.7778 11.2496 13.7778C11.4154 13.7778 11.5744 13.8429 11.6916 13.9586C11.8088 14.0744 11.8746 14.2314 11.8746 14.3951C11.8746 14.5588 11.8088 14.7158 11.6916 14.8316C11.5744 14.9473 11.4154 15.0124 11.2496 15.0124Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+</g>
+<defs>
+<clipPath id="clip0_1827_6566">
+<rect width="16" height="16" fill="white"/>
+</clipPath>
+</defs>
</svg>
=====================================
browser/themes/shared/identity-block/onion.svg
=====================================
@@ -1,4 +1,5 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="M 8 0.5 C 3.85786 0.5 0.5 3.85786 0.5 8 C 0.5 12.1421 3.85786 15.5 8 15.5 C 12.1421 15.5 15.5 12.1421 15.5 8 C 15.5 3.85786 12.1421 0.5 8 0.5 z M 8 1.671875 C 11.4949 1.671875 14.328125 4.50507 14.328125 8 C 14.328125 11.4949 11.4949 14.328125 8 14.328125 L 8 13.25 C 10.89951 13.25 13.25 10.89951 13.25 8 C 13.25 5.10051 10.89951 2.75 8 2.75 L 8 1.671875 z M 8 3.921875 C 10.25231 3.921875 12.078125 5.74772 12.078125 8 C 12.078125 10.25231 10.25231 12.078125 8 12.078125 L 8 11 C 9.65686 11 11 9.65686 11 8 C 11 6.34315 9.65686 5 8 5 L 8 3.921875 z M 8 6.171875 C 9.00965 6.171875 9.828125 6.99036 9.828125 8 C 9.828125 9.00965 9.00965 9.828125 8 9.828125 L 8 6.171875 z " clip-rule="evenodd" fill-rule="evenodd" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M8 13C9.65685 13 11 11.6569 11 10C11 8.34315 9.65685 7 8 7C6.34315 7 5 8.34315 5 10C5 11.6569 6.34315 13 8 13ZM8 14C10.2091 14 12 12.2091 12 10C12 7.79086 10.2091 6 8 6C5.79086 6 4 7.79086 4 10C4 12.2091 5.79086 14 8 14Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M8 11C8.55228 11 9 10.5523 9 10C9 9.44772 8.55228 9 8 9C7.44772 9 7 9.44772 7 10C7 10.5523 7.44772 11 8 11ZM8 12C9.10457 12 10 11.1046 10 10C10 8.89543 9.10457 8 8 8C6.89543 8 6 8.89543 6 10C6 11.1046 6.89543 12 8 12Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 5.52779C13.2275 6.62643 14 8.223 14 10C14 13.3137 11.3137 16 8 16C4.68629 16 2 13.3137 2 10C2 8.223 2.7725 6.62643 4 5.52779V4C4 1.79086 5.79086 0 8 0C10.2091 0 12 1.79086 12 4V5.52779ZM5.25 4.66591C6.0738 4.24033 7.00883 4 8 4C8.99117 4 9.9262 4.24033 10.75 4.66591V4C10.75 2.48122 9.51878 1.25 8 1.25C6.48122 1.25 5.25 2.48122 5.25 4V4.66591ZM13 10C13 12.7614 10.7614 15 8 15C5.23858 15 3 12.7614 3 10C3 7.23858 5.23858 5 8 5C10.7614 5 13 7.23858 13 10Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
</svg>
=====================================
browser/themes/shared/jar.inc.mn
=====================================
@@ -32,6 +32,7 @@
skin/classic/browser/tabs.css (../shared/tabs.css)
skin/classic/browser/toolbarbuttons.css (../shared/toolbarbuttons.css)
skin/classic/browser/toolbarbutton-icons.css (../shared/toolbarbutton-icons.css)
+ skin/classic/browser/tor-urlbar-button.css (../shared/tor-urlbar-button.css)
skin/classic/browser/urlbar-dynamic-results.css (../shared/urlbar-dynamic-results.css)
skin/classic/browser/urlbar-searchbar.css (../shared/urlbar-searchbar.css)
skin/classic/browser/urlbarView.css (../shared/urlbarView.css)
=====================================
browser/themes/shared/tor-urlbar-button.css
=====================================
@@ -0,0 +1,107 @@
+.tor-urlbar-button:not([hidden]) {
+ --tor-urlbar-button-background-color: var(--purple-60);
+ background-color: var(--tor-urlbar-button-background-color);
+ /* FIXME: Use different colors for light and dark theme, rather than "white".
+ * See tor-browser#41787 */
+ color: white;
+ display: flex;
+ align-items: center;
+ gap: 0.5em;
+ border-radius: var(--urlbar-icon-border-radius);
+ --tor-urlbar-button-inline-padding: 8px;
+ padding-inline: var(--tor-urlbar-button-inline-padding);
+ margin: 0;
+}
+
+.tor-urlbar-button > * {
+ flex: 0 0 auto;
+ margin: 0;
+}
+
+.tor-urlbar-button:focus-visible {
+ /* This button lies within the urlbar, so if the outline extends beyond the
+ * button's boundary, it will be clipped by the urlbar.
+ * Most button's in the urlbar get around this by using --focus-outline-inset,
+ * but our button has a purple background, which does not contrast well with
+ * the focus outline.
+ * Therefore, we use an offset outline rather than an inset outline, and
+ * compensate by shrinking the button's width and height so that the outline
+ * fits within the non-focused button boundary. Essentially, this has a
+ * similar effect to using an inset outline that matches the color of the
+ * urlbar background, but we keep the rounded corners. */
+ outline: var(--focus-outline);
+ outline-offset: var(--focus-outline-offset);
+ /* Use the background color for the outline, same as in-content buttons. */
+ outline-color: var(--tor-urlbar-button-background-color);
+ /* Calculate the difference between the button's border area and the outline
+ * area. */
+ --tor-urlbar-focus-outline-difference: calc(
+ var(--focus-outline-offset)
+ + var(--focus-outline-width)
+ );
+ /* For the inline direction, we shrink the padding by the difference, and
+ * increase the margin by the same amount so that the button text remains in
+ * the same position.
+ * For the block direction, the height of the button is flexibly sized with
+ * the urlbar height, so we should only need to increase the margin. */
+ padding-inline: calc(
+ var(--tor-urlbar-button-inline-padding)
+ - var(--tor-urlbar-focus-outline-difference)
+ );
+ margin: var(--tor-urlbar-focus-outline-difference);
+}
+
+.tor-urlbar-button:focus-visible > * {
+ /* Negate the margin that would be added on focus to ensure the button does
+ * not grow in height.
+ * Ideally, this should not change anything noticeable, otherwise the text
+ * could be clipped when focused. */
+ margin-block: calc(-1 * var(--tor-urlbar-focus-outline-difference));
+}
+
+#urlbar[usertyping] .tor-urlbar-button {
+ /* Hide whilst the user is typing in the url bar. */
+ display: none;
+}
+
+.tor-urlbar-button:hover {
+ --tor-urlbar-button-background-color: var(--purple-70);
+}
+
+.tor-urlbar-button:hover:active {
+ --tor-urlbar-button-background-color: var(--purple-80);
+}
+
+@media (prefers-color-scheme: dark) {
+ .tor-urlbar-button {
+ --tor-urlbar-button-background-color: var(--purple-50);
+ }
+
+ .tor-urlbar-button:hover {
+ --tor-urlbar-button-background-color: var(--purple-60);
+ }
+
+ .tor-urlbar-button:hover:active {
+ --tor-urlbar-button-background-color: var(--purple-70);
+ }
+}
+
+/* Make the button look plain like the identity #urlbar-label-box. */
+.tor-urlbar-button.tor-urlbar-button-plain {
+ --tor-urlbar-button-background-color: var(--urlbar-box-bgcolor);
+ color: var(--urlbar-box-text-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:focus-visible {
+ outline-color: var(--focus-outline-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:hover {
+ --tor-urlbar-button-background-color: var(--urlbar-box-hover-bgcolor);
+ color: var(--urlbar-box-hover-text-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:hover:active {
+ --tor-urlbar-button-background-color: var(--urlbar-box-active-bgcolor);
+ color: var(--urlbar-box-hover-text-color);
+}
=====================================
devtools/shared/webconsole/network-helper.js
=====================================
@@ -600,6 +600,9 @@ var NetworkHelper = {
// The request did not contain any security info.
if (!securityInfo) {
+ if (httpActivity.hostname && httpActivity.hostname.endsWith(".onion")) {
+ info.state = "secure";
+ }
return info;
}
@@ -651,7 +654,11 @@ var NetworkHelper = {
// schemes other than https and wss are subject to
// downgrade/etc at the scheme level and should always be
// considered insecure
- info.state = "insecure";
+ if (httpActivity.hostname && httpActivity.hostname.endsWith(".onion")) {
+ info.state = "secure";
+ } else {
+ info.state = "insecure";
+ }
} else if (state & wpl.STATE_IS_SECURE) {
// The connection is secure if the scheme is sufficient
info.state = "secure";
=====================================
dom/html/HTMLFormElement.cpp
=====================================
@@ -893,7 +893,10 @@ nsresult HTMLFormElement::DoSecureToInsecureSubmitCheck(nsIURI* aActionURL,
formIsHTTPS = OwnerDoc()->GetDocumentURI()->SchemeIs("https");
}
if (!formIsHTTPS) {
- return NS_OK;
+ bool formIsOnion = nsMixedContentBlocker::IsPotentiallyTrustworthyOnion(OwnerDoc()->GetDocumentURI());
+ if (!formIsOnion) {
+ return NS_OK;
+ }
}
if (nsMixedContentBlocker::IsPotentiallyTrustworthyLoopbackURL(aActionURL)) {
=====================================
toolkit/torbutton/chrome/locale/en-US/torConnect.properties
=====================================
@@ -3,10 +3,14 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+torConnect.titlebarStatusName=Tor connection
+torConnect.titlebarStatusNotConnected=Not connected
+torConnect.titlebarStatusConnecting=Connecting…
+torConnect.titlebarStatusPotentiallyBlocked=Potentially blocked
+torConnect.titlebarStatusConnected=Connected
+
torConnect.torConnect=Connect to Tor
torConnect.torConnecting=Establishing a Connection
-torConnect.torNotConnectedConcise=Not Connected
-torConnect.torConnectingConcise=Connecting…
torConnect.tryingAgain=Trying again…
torConnect.noInternet=Tor Browser couldn’t reach the Internet
torConnect.noInternetDescription=This could be due to a connection issue rather than Tor being blocked. Check your Internet connection, proxy and firewall settings before trying again.
@@ -35,7 +39,6 @@ torConnect.viewLog=View logs…
torConnect.torConnectButton=Connect
torConnect.cancel=Cancel
torConnect.torConnected=Connected to the Tor network!
-torConnect.torConnectedConcise=Connected
torConnect.tryAgain=Try Again
torConnect.connectMessage=Changes to Tor Settings will not take effect until you connect
torConnect.tryAgainMessage=Tor Browser has failed to establish a connection to the Tor Network
@@ -51,3 +54,8 @@ torConnect.autoBootstrappingFailed=Automatic configuration failed
torConnect.autoBootstrappingAllFailed=None of the configurations we tried worked
torConnect.cannotDetermineCountry=Unable to determine user country
torConnect.noSettingsForCountry=No settings available for your location
+
+# Urlbar strings used up to 12.0 - TODO: remove when 12.5 becomes stable:
+torConnect.torNotConnectedConcise=Not Connected
+torConnect.torConnectingConcise=Connecting…
+torConnect.torConnectedConcise=Connected
=====================================
tools/update-packaging/common.sh
=====================================
@@ -108,6 +108,28 @@ make_add_if_not_instruction() {
echo "add-if-not \"$f\" \"$f\"" >> "$filev3"
}
+check_for_add_if_update() {
+ add_if_file_chk="$1"
+
+ # tor-browser#41776: We will remove with the old fontconfig file manually
+ # outside the update process. So, let the updater add the file if there.
+ # TODO: Remove once we do a watershed release.
+ if [ "$add_if_file_chk" = "TorBrowser/Data/fontconfig/fonts.conf" ]; then
+ ## "true" *giggle*
+ return 0;
+ fi
+ ## 'false'... because this is bash. Oh yay!
+ return 1;
+}
+
+make_add_if_instruction() {
+ f="$1"
+ filev3="$2"
+
+ verbose_notice " add-if \"$f\" \"$f\""
+ echo "add-if \"$f\" \"$f\"" >> "$filev3"
+}
+
make_addsymlink_instruction() {
link="$1"
target="$2"
=====================================
tools/update-packaging/make_full_update.sh
=====================================
@@ -106,6 +106,9 @@ for ((i=0; $i<$num_files; i=$i+1)); do
if check_for_add_if_not_update "$f"; then
make_add_if_not_instruction "$f" "$updatemanifestv3"
+ elif check_for_add_if_update "$f"; then
+ # TODO: Remove once we do a watershed release
+ make_add_if_instruction "$f" "$updatemanifestv3"
else
make_add_instruction "$f" "$updatemanifestv3"
fi
=====================================
tools/update-packaging/make_incremental_update.sh
=====================================
@@ -220,6 +220,17 @@ for ((i=0; $i<$num_oldfiles; i=$i+1)); do
continue 1
fi
+ if check_for_add_if_update "$f"; then
+ # TODO: Remove once we do a watershed release
+ # The full workdir may not exist yet, so create it if necessary.
+ mkdir -p `dirname "$workdir/$f"`
+ $XZ $XZ_OPT --compress $BCJ_OPTIONS --lzma2 --format=xz --check=crc64 --force --stdout "$newdir/$f" > "$workdir/$f"
+ copy_perm "$newdir/$f" "$workdir/$f"
+ make_add_if_instruction "$f" "$updatemanifestv3"
+ archivefiles="$archivefiles \"$f\""
+ continue 1
+ fi
+
if check_for_forced_update "$requested_forced_updates" "$f"; then
# The full workdir may not exist yet, so create it if necessary.
mkdir -p `dirname "$workdir/$f"`
@@ -328,6 +339,9 @@ for ((i=0; $i<$num_newfiles; i=$i+1)); do
if check_for_add_if_not_update "$f"; then
make_add_if_not_instruction "$f" "$updatemanifestv3"
+ elif check_for_add_if_update "$f"; then
+ # TODO: Remove once we do a watershed release
+ make_add_if_instruction "$f" "$updatemanifestv3"
else
make_add_instruction "$f" "$updatemanifestv3"
fi
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5b547f…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5b547f…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser][tor-browser-102.11.0esr-12.5-1] Bug 41749: Replace the onion-glyph with dedicated icon for onion services
by Pier Angelo Vendrame (@pierov) 29 May '23
by Pier Angelo Vendrame (@pierov) 29 May '23
29 May '23
Pier Angelo Vendrame pushed to branch tor-browser-102.11.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
Commits:
d441f698 by Dan Ballard at 2023-05-29T07:59:44+00:00
Bug 41749: Replace the onion-glyph with dedicated icon for onion services
- - - - -
3 changed files:
- browser/themes/shared/identity-block/onion-slash.svg
- browser/themes/shared/identity-block/onion-warning.svg
- browser/themes/shared/identity-block/onion.svg
Changes:
=====================================
browser/themes/shared/identity-block/onion-slash.svg
=====================================
@@ -1,5 +1,16 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="m14.1161 15.6245c-.0821.0001-.1634-.016-.2393-.0474-.0758-.0314-.1447-.0775-.2027-.1356l-12.749984-12.749c-.109266-.11882-.168406-.27526-.165071-.43666.003335-.16139.068886-.31525.182967-.42946.114078-.11421.267868-.17994.429258-.18345.16139-.00352.3179.05544.43685.16457l12.74998 12.75c.1168.1176.1824.2767.1824.4425s-.0656.3249-.1824.4425c-.058.058-.1269.1039-.2028.1352-.0759.0312-.1571.0471-.2392.0468z" fill-opacity="context-fill-opacity" fill="#ff0039" />
- <path d="m 8,0.5000002 c -1.61963,0 -3.1197431,0.5137987 -4.3457031,1.3867188 l 0.84375,0.8417968 0.7792969,0.78125 0.8613281,0.8613282 0.8164062,0.8164062 0.9863281,0.984375 h 0.058594 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.01968 6.2e-4,0.039074 0,0.058594 L 10.8125,9.0449221 C 10.9334,8.7195921 11,8.3674002 11,8.0000002 c 0,-1.65685 -1.34314,-3 -3,-3 v -1.078125 c 2.25231,0 4.078125,1.825845 4.078125,4.078125 0,0.67051 -0.162519,1.3033281 -0.449219,1.8613281 l 0.861328,0.8613277 C 12.972434,9.9290067 13.25,8.9965102 13.25,8.0000002 c 0,-2.89949 -2.35049,-5.25 -5.25,-5.25 v -1.078125 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,1.29533 -0.388841,2.4990528 -1.056641,3.5019528 l 0.841797,0.84375 C 14.986181,11.119703 15.5,9.6196302 15.5,8.0000002 c 0,-4.14214 -3.3579,-7.5 -7.5,-7.5 z m -6.1113281,3.15625 C 1.0154872,4.8821451 0.5,6.3803304 0.5,8.0000002 0.5,12.1421 3.85786,15.5 8,15.5 c 1.6198027,0 3.117896,-0.515441 4.34375,-1.388672 L 11.501953,13.269531 C 10.498787,13.937828 9.295838,14.328125 8,14.328125 V 13.25 c 0.9967306,0 1.9287093,-0.277621 2.722656,-0.759766 L 9.859375,11.626953 C 9.3016226,11.913918 8.6705338,12.078125 8,12.078125 V 11 C 8.3664751,11 8.716425,10.93088 9.0410156,10.810547 6.6639891,8.4300416 4.2743195,6.0418993 1.8886719,3.6562502 Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_1827_6565)">
+<path d="M6.62435 8.54824C6.23983 8.91273 6 9.42836 6 10C6 11.1046 6.89543 12 8 12C8.57164 12 9.08727 11.7602 9.45176 11.3757L8.74414 10.668C8.56107 10.8718 8.29551 11 8 11C7.44772 11 7 10.5523 7 10C7 9.70449 7.12818 9.43893 7.33197 9.25586L6.62435 8.54824Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M9.99442 10.1505C9.99812 10.1008 10 10.0506 10 10C10 8.89543 9.10457 8 8 8C7.94936 8 7.89915 8.00188 7.84946 8.00558L9.99442 10.1505Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M5.20988 7.13377C4.46354 7.86041 4 8.87607 4 10C4 12.2091 5.79086 14 8 14C9.12393 14 10.1396 13.5365 10.8662 12.7901L10.159 12.0829C9.61343 12.6483 8.84778 13 8 13C6.34315 13 5 11.6569 5 10C5 9.15222 5.35166 8.38657 5.91707 7.84097L5.20988 7.13377Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M10.8331 10.9892C10.9412 10.6795 11 10.3466 11 10C11 8.34315 9.65685 7 8 7C7.65339 7 7.32052 7.05878 7.01079 7.16692L6.24731 6.40343C6.77658 6.14502 7.37135 6 8 6C10.2091 6 12 7.79086 12 10C12 10.6286 11.855 11.2234 11.5966 11.7527L10.8331 10.9892Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M14 10C14 8.223 13.2275 6.62643 12 5.52779V4C12 1.79086 10.2091 0 8 0C5.79086 0 4 1.79086 4 4V4.15613L5.50811 5.66423C6.2417 5.2417 7.09263 5 8 5C10.7614 5 13 7.23858 13 10C13 10.9074 12.7583 11.7583 12.3358 12.4919L13.0637 13.2199C13.6565 12.2896 14 11.1849 14 10ZM8 4C7.00883 4 6.0738 4.24033 5.25 4.66591V4C5.25 2.48122 6.48122 1.25 8 1.25C9.51878 1.25 10.75 2.48122 10.75 4V4.66591C9.9262 4.24033 8.99117 4 8 4Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M12.2805 14.2044C11.1919 15.3126 9.67621 16 8 16C4.68629 16 2 13.3137 2 10C2 8.32379 2.68736 6.80812 3.79558 5.71948L4.50272 6.42662C3.57545 7.33427 3 8.59993 3 10C3 12.7614 5.23858 15 8 15C9.40007 15 10.6657 14.4246 11.5734 13.4973L12.2805 14.2044Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M1.25801 3.93806C1.50209 3.69398 1.89782 3.69398 2.14189 3.93806L13.1419 14.9381C13.386 15.1821 13.386 15.5779 13.1419 15.8219C12.8978 16.066 12.5021 16.066 12.258 15.8219L1.25801 4.82194C1.01393 4.57787 1.01393 4.18214 1.25801 3.93806Z" fill="#F90D3F"/>
+</g>
+<defs>
+<clipPath id="clip0_1827_6565">
+<rect width="16" height="16" fill="white"/>
+</clipPath>
+</defs>
</svg>
=====================================
browser/themes/shared/identity-block/onion-warning.svg
=====================================
@@ -1,4 +1,13 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="M 7.5,0.5 C 3.35786,0.5 0,3.85786 0,8 c 0,3.7093 2.6930488,6.789278 6.2304688,7.392578 -0.032181,-0.0637 -0.060149,-0.128686 -0.085938,-0.195312 -0.00862,-0.02227 -0.01751,-0.04385 -0.025391,-0.06641 -0.023385,-0.0669 -0.043878,-0.135932 -0.060547,-0.205078 -0.00186,-0.0077 -0.00213,-0.01571 -0.00391,-0.02344 -0.017615,-0.07685 -0.032109,-0.153488 -0.041016,-0.232422 -7.27e-5,-6.44e-4 7.2e-5,-0.0013 0,-0.002 -0.0087,-0.07777 -0.011896,-0.157155 -0.011719,-0.236328 7.71e-5,-0.0337 2.127e-4,-0.06769 0.00195,-0.101563 3.337e-4,-0.0065 -3.955e-4,-0.01303 0,-0.01953 0.00318,-0.05219 0.0084,-0.10381 0.015625,-0.15625 0.03623,-0.263929 0.1235201,-0.529812 0.2714844,-0.787109 L 6.421875,13.138672 C 7.1130865,11.933878 7.8482649,10.654869 8.4882812,9.5390625 8.2033713,9.7224325 7.864,9.828125 7.5,9.828125 v -3.65625 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.02558 -9.131e-4,0.050842 -0.00195,0.076172 L 9.6015625,7.5957031 C 9.7779825,7.2883331 10.012797,7.0451975 10.279297,6.8671875 9.8324169,5.7717775 8.75611,5 7.5,5 V 3.921875 c 1.72627,0 3.201675,1.0728106 3.796875,2.5878906 0.4511,-0.0416 0.914353,0.052393 1.314453,0.2832032 C 12.066128,4.4750988 9.98426,2.75 7.5,2.75 V 1.671875 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,0.10641 -0.0026,0.2112863 -0.0078,0.3164062 L 14.74806,9.9355469 C 14.912447,9.3182669 15,8.66904 15,8 15,3.85786 11.6421,0.5 7.5,0.5 Z m 4,7 c -0.40375,0 -0.808156,0.19825 -1.035156,0.59375 l -3.3105471,5.771484 c -0.446,0.775 0.1271562,1.734375 1.0351562,1.734375 H 14.8125 c 0.907,0 1.478203,-0.959375 1.033203,-1.734375 L 12.535156,8.09375 C 12.308156,7.69825 11.90375,7.5 11.5,7.5 Z m 0,2.1015625 c 0.1658,0 0.324206,0.066384 0.441406,0.1835937 0.1172,0.1172101 0.183594,0.2757058 0.183594,0.4414058 v 1.748047 c 0,0.1658 -0.06639,0.324207 -0.183594,0.441407 -0.1172,0.1172 -0.275606,0.183593 -0.441406,0.183593 -0.1657,0 -0.324206,-0.06639 -0.441406,-0.183593 -0.1172,-0.1172 -0.183594,-0.275607 -0.183594,-0.441407 v -1.748047 c 0,-0.165699 0.06639,-0.3241957 0.183594,-0.4414058 C 11.175794,9.6679462 11.3343,9.6015625 11.5,9.6015625 Z m 0,3.7480465 c 0.1658,0 0.324206,0.06639 0.441406,0.183594 0.1172,0.1172 0.183594,0.275706 0.183594,0.441406 0,0.1658 -0.06639,0.32616 -0.183594,0.44336 -0.1172,0.1172 -0.275606,0.18164 -0.441406,0.18164 -0.1657,0 -0.324206,-0.06444 -0.441406,-0.18164 -0.1172,-0.1172 -0.183594,-0.27756 -0.183594,-0.44336 0,-0.1657 0.06639,-0.324206 0.183594,-0.441406 0.1172,-0.1172 0.275706,-0.183594 0.441406,-0.183594 z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_1827_6566)">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M7.92788 10.5342L7.42044 11.408C7.05803 11.7736 6.55546 12 6 12C4.89543 12 4 11.1046 4 10C4 8.89543 4.89543 8 6 8C7.10457 8 8 8.89543 8 10C8 10.185 7.97488 10.3641 7.92788 10.5342ZM7 10C7 10.5523 6.55228 11 6 11C5.44772 11 5 10.5523 5 10C5 9.44772 5.44772 9 6 9C6.55228 9 7 9.44772 7 10Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M6.52221 12.9547C6.35262 12.9845 6.17812 13 6 13C4.34315 13 3 11.6569 3 10C3 8.34315 4.34315 7 6 7C7.30202 7 8.41032 7.82945 8.8253 8.98878L9.35089 8.08372C9.37772 8.03755 9.40587 7.99285 9.43523 7.94962C8.73673 6.78186 7.45967 6 6 6C3.79086 6 2 7.79086 2 10C2 12.1857 3.75302 13.9619 5.92975 13.9994C5.96208 13.9274 5.99884 13.8558 6.0402 13.7847L6.52221 12.9547Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M11.1978 7.00088C10.8782 6.44807 10.4728 5.95098 10 5.52779V4C10 1.79086 8.20914 0 6 0C3.79086 0 2 1.79086 2 4V5.52779C0.772501 6.62643 0 8.223 0 10C0 13.3137 2.68629 16 6 16C6.03024 16 6.06043 15.9998 6.09057 15.9993C5.89561 15.7007 5.77424 15.3557 5.749 14.9938C3.10419 14.8631 1 12.6773 1 10C1 7.23858 3.23858 5 6 5C7.75288 5 9.29509 5.90201 10.1878 7.26719C10.5002 7.0977 10.8482 7.00893 11.1978 7.00088ZM6 4C5.00883 4 4.0738 4.24033 3.25 4.66591V4C3.25 2.48122 4.48122 1.25 6 1.25C7.51878 1.25 8.75 2.48122 8.75 4V4.66591C7.9262 4.24033 6.99117 4 6 4Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+<path d="M15.5956 14.2875L12.2846 8.58591C11.8306 7.8047 10.6696 7.8047 10.2156 8.58591L6.90465 14.2875C6.45865 15.0529 7.03065 16 7.93865 16H14.5616C15.4686 16 16.0406 15.0529 15.5956 14.2875ZM11.8746 12.4189C11.8746 12.5826 11.8088 12.7396 11.6916 12.8553C11.5744 12.9711 11.4154 13.0361 11.2496 13.0361C11.0839 13.0361 10.9249 12.9711 10.8077 12.8553C10.6905 12.7396 10.6246 12.5826 10.6246 12.4189V10.6935C10.6246 10.5298 10.6905 10.3728 10.8077 10.257C10.9249 10.1413 11.0839 10.0762 11.2496 10.0762C11.4154 10.0762 11.5744 10.1413 11.6916 10.257C11.8088 10.3728 11.8746 10.5298 11.8746 10.6935V12.4189ZM11.2496 15.0124C11.0839 15.0124 10.9249 14.9473 10.8077 14.8316C10.6905 14.7158 10.6246 14.5588 10.6246 14.3951C10.6246 14.2314 10.6905 14.0744 10.8077 13.9586C10.9249 13.8429 11.0839 13.7778 11.2496 13.7778C11.4154 13.7778 11.5744 13.8429 11.6916 13.9586C11.8088 14.0744 11.8746 14.2314 11.8746 14.3951C11.8746 14.5588 11.8088 14.7158 11.6916 14.8316C11.5744 14.9473 11.4154 15.0124 11.2496 15.0124Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
+</g>
+<defs>
+<clipPath id="clip0_1827_6566">
+<rect width="16" height="16" fill="white"/>
+</clipPath>
+</defs>
</svg>
=====================================
browser/themes/shared/identity-block/onion.svg
=====================================
@@ -1,4 +1,5 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="M 8 0.5 C 3.85786 0.5 0.5 3.85786 0.5 8 C 0.5 12.1421 3.85786 15.5 8 15.5 C 12.1421 15.5 15.5 12.1421 15.5 8 C 15.5 3.85786 12.1421 0.5 8 0.5 z M 8 1.671875 C 11.4949 1.671875 14.328125 4.50507 14.328125 8 C 14.328125 11.4949 11.4949 14.328125 8 14.328125 L 8 13.25 C 10.89951 13.25 13.25 10.89951 13.25 8 C 13.25 5.10051 10.89951 2.75 8 2.75 L 8 1.671875 z M 8 3.921875 C 10.25231 3.921875 12.078125 5.74772 12.078125 8 C 12.078125 10.25231 10.25231 12.078125 8 12.078125 L 8 11 C 9.65686 11 11 9.65686 11 8 C 11 6.34315 9.65686 5 8 5 L 8 3.921875 z M 8 6.171875 C 9.00965 6.171875 9.828125 6.99036 9.828125 8 C 9.828125 9.00965 9.00965 9.828125 8 9.828125 L 8 6.171875 z " clip-rule="evenodd" fill-rule="evenodd" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M8 13C9.65685 13 11 11.6569 11 10C11 8.34315 9.65685 7 8 7C6.34315 7 5 8.34315 5 10C5 11.6569 6.34315 13 8 13ZM8 14C10.2091 14 12 12.2091 12 10C12 7.79086 10.2091 6 8 6C5.79086 6 4 7.79086 4 10C4 12.2091 5.79086 14 8 14Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M8 11C8.55228 11 9 10.5523 9 10C9 9.44772 8.55228 9 8 9C7.44772 9 7 9.44772 7 10C7 10.5523 7.44772 11 8 11ZM8 12C9.10457 12 10 11.1046 10 10C10 8.89543 9.10457 8 8 8C6.89543 8 6 8.89543 6 10C6 11.1046 6.89543 12 8 12Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 5.52779C13.2275 6.62643 14 8.223 14 10C14 13.3137 11.3137 16 8 16C4.68629 16 2 13.3137 2 10C2 8.223 2.7725 6.62643 4 5.52779V4C4 1.79086 5.79086 0 8 0C10.2091 0 12 1.79086 12 4V5.52779ZM5.25 4.66591C6.0738 4.24033 7.00883 4 8 4C8.99117 4 9.9262 4.24033 10.75 4.66591V4C10.75 2.48122 9.51878 1.25 8 1.25C6.48122 1.25 5.25 2.48122 5.25 4V4.66591ZM13 10C13 12.7614 10.7614 15 8 15C5.23858 15 3 12.7614 3 10C3 7.23858 5.23858 5 8 5C10.7614 5 13 7.23858 13 10Z" fill="context-fill" fill-opacity="context-fill-opacity"/>
</svg>
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d441f69…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d441f69…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40858: Add a script for MacOS to selfsign an unsigned browser (so it can run on ARM Mx macs)
by Pier Angelo Vendrame (@pierov) 29 May '23
by Pier Angelo Vendrame (@pierov) 29 May '23
29 May '23
Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
96045df2 by Dan Ballard at 2023-05-29T08:02:10+00:00
Bug 40858: Add a script for MacOS to selfsign an unsigned browser (so it can run on ARM Mx macs)
- - - - -
1 changed file:
- + tools/browser-self-sign-macos.sh
Changes:
=====================================
tools/browser-self-sign-macos.sh
=====================================
@@ -0,0 +1,110 @@
+#!/bin/bash
+
+CERTNAME=my-codesign-cert-tor
+BROWSERPATH=.
+
+if [ $# -ge 1 ]
+then
+ BROWSERPATH=$1
+fi
+
+
+security find-certificate -c $CERTNAME > /dev/null
+
+if [ $? -ne 0 ]
+then
+ echo ""
+ echo "ERROR: Self Signing Certificate not found, please create:"
+ echo " 1. In the Keychain Access app on your Mac, choose Keychain Access > Certificate Assistant > Create a Certificate."
+ echo " 2. Enter the name '$CERTNAME' for the certificate"
+ echo " 3. Choose an identity type: Self Signed Root"
+ echo " 4. Certificate Type > Code Signing"
+ echo " 5. Check 'Let me override defaults' & click Continue."
+ echo " 6. Enter a unique Serial Number. (123 is fine)"
+ echo " 7. Enter a big Validity Period (days), like 3560 & click Continue."
+ echo " 8. Fill in your personal information & click Continue."
+ echo " 9. Accept defaults for the rest of the dialog boxes. (Continue several times)"
+ echo " 10. Certificate Created! Click Done."
+ echo ""
+ echo "For additional help see:"
+ echo " https://support.apple.com/en-ca/guide/keychain-access/kyca8916/mac"
+ echo " https://stackoverflow.com/questions/58356844/what-are-the-ways-or-technolog…"
+
+ echo ""
+ read -n 1 -r -s -p $'Press enter to launch "Keychain Access"...\n'
+ open /System/Applications/Utilities/Keychain\ Access.app
+
+ exit -1
+fi
+
+echo "Found $CERTNAME, looking for browser to sign..."
+
+if [ ! -f "$BROWSERPATH/XUL" ]
+then
+ TESTPATH="$BROWSERPATH/Contents/MacOS"
+ if [ -f "$TESTPATH/XUL" ]
+ then
+ BROWSERPATH=$TESTPATH
+ else
+ echo "Error: browser files not detected in $BROWSERPATH!"
+ echo " This script needs to be run in the 'Contents/MacOS' directory of a SomeBrowser.app directory"
+ exit -1
+ fi
+fi
+
+echo "Mozilla based browser found, signing..."
+echo ' Will be asked for password to certificate for all the things that need to be signed. Click "Always Allow" to automate'
+
+cd "$BROWSERPATH"
+
+codesign -s $CERTNAME *.dylib
+codesign -s $CERTNAME plugin-container.app
+
+if [ -d Tor ]
+then
+ codesign -s $CERTNAME Tor/PluggableTransports/*
+ codesign -s $CERTNAME Tor/libevent-2.1.7.dylib
+ if [ -f Tor/tor.real ]
+ then
+ codesign -s $CERTNAME Tor/tor.real
+ fi
+ if [ -f Tor/tor ]
+ then
+ codesign -s $CERTNAME Tor/tor
+ fi
+fi
+
+codesign -s $CERTNAME XUL
+
+if [ -d updater.app ]
+then
+ codesign -s $CERTNAME updater.app
+fi
+
+# mullvadbrowser
+if [ -f mullvadbrowser ]
+then
+ codesign -s $CERTNAME mullvadbrowser
+fi
+
+# BB or TB
+if [ -f firefox ]
+then
+ codesign -s $CERTNAME firefox
+fi
+
+echo ""
+echo "Browser signing step done!"
+echo ""
+
+echo "App still needs one more override to be easily opened with double click in Finder"
+echo "Alternatively you can right click it, select 'Open' and then select 'Open' from the override popup"
+echo "Or to enable it to be double clicked to open perform the following"
+echo ""
+echo "Double click the app and select either 'Ok' or 'Cancel' from the warning popup depending on which you get (Do Not 'Move to Trash')"
+echo 'Go to Preferences -> Security & Privacy and click on padlock to allow changes. '
+echo ' Then in "Allow appications downloaded from" select either:'
+echo ' - App Store and identified developers'
+echo ' - Anywhere'
+echo ' Below that may be a notice about your specific app saying it was blocked because it was not from an identified developer. Click "Open Anyways" and "Open"'
+
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40850: Use obfs4 main branch in nightly
by richard (@richard) 25 May '23
by richard (@richard) 25 May '23
25 May '23
richard pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
ee633476 by Nicolas Vigier at 2023-05-25T20:28:24+00:00
Bug 40850: Use obfs4 main branch in nightly
In 076ffcf14d8f51d1837889c25a0fddc0afc42796 we stopped using the main
branch, because the build of tpo/anti-censorship/pluggable-transports/obfs4#40011.
Since this is now fixed, we can use the main branch again.
- - - - -
1 changed file:
- projects/obfs4/config
Changes:
=====================================
projects/obfs4/config
=====================================
@@ -11,14 +11,13 @@ container:
var:
go_vendor_sha256sum: 5d2d82d00afc5fe044ee6df718ffe066b7d9e5446944c0ee0870e060e4e6bcc8
-# Stop using `main` on nightly, until tor-browser-build#40850 is fixed
-#targets:
-# nightly:
-# git_hash: main
-# version: '[% c("abbrev") %]'
-# tag_gpg_id: 0
-# var:
-# go_vendor_sha256sum: ad5cbcb09580c74b02b230b4fad7d2362c3b2f4537cdefd4abdeb0c3c4e97adb
+targets:
+ nightly:
+ git_hash: main
+ version: '[% c("abbrev") %]'
+ tag_gpg_id: 0
+ var:
+ go_vendor_sha256sum: 8b7e04a43bfbcdc829ea5093d8ee0a50eddefad543acd201b25424b33a7f882b
steps:
build:
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser][tor-browser-102.11.0esr-12.5-1] 6 commits: fixup! Bug 40597: Implement TorSettings module
by richard (@richard) 25 May '23
by richard (@richard) 25 May '23
25 May '23
richard pushed to branch tor-browser-102.11.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
Commits:
f89920b2 by Henry Wilkes at 2023-05-25T19:57:03+00:00
fixup! Bug 40597: Implement TorSettings module
Bug 41608 - Ignore tor connection errors when tor connection is
cancelled by the user. This can happen if the bootstrap process is
cancelled late in the process.
Also remove unused cancelAutoBootstrapping.
- - - - -
77d2560d by Henry Wilkes at 2023-05-25T19:57:03+00:00
fixup! Add TorStrings module for localization
Bug 41608 - Add new connection status strings.
- - - - -
efa05015 by Henry Wilkes at 2023-05-25T19:57:03+00:00
fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41608 - Use the torconnect icon for the onion slash.
- - - - -
a71b5035 by Henry Wilkes at 2023-05-25T19:57:03+00:00
fixup! Bug 21952: Implement Onion-Location
Bug 41608 - Use the same styling for ".onion available" urlbar button as
the tor-connect-urlbar-button. This also stops the button from
overflowing its container like before. Also move to after the bookmark
button.
- - - - -
ba98c304 by Henry Wilkes at 2023-05-25T19:57:03+00:00
amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor
Bug 40773: Update the about:torconnect frontend page to match additional UI flows.
Bug 41608: Add a toolbar status button and a urlbar "Connect" button.
- - - - -
702051f1 by Henry Wilkes at 2023-05-25T19:57:03+00:00
fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly
focused buttons in about:torconnect. The approach in tor-browser!607
prevented this by waiting for keyup, but keyup could still be triggered
by a key event initialized elsewhere. E.g. when pressing Enter to close
a modal dialog, the Enter's keyup event would be sent to the
about:torconnect page and trigger the focused button.
- - - - -
21 changed files:
- browser/base/content/browser.js
- browser/base/content/browser.xhtml
- browser/base/content/navigator-toolbox.inc.xhtml
- browser/components/onionservices/content/onionlocation-urlbar.inc.xhtml
- browser/components/onionservices/content/onionlocation.css
- browser/components/torconnect/content/aboutTorConnect.js
- − browser/components/torconnect/content/onion-slash.svg
- − browser/components/torconnect/content/torBootstrapUrlbar.js
- + browser/components/torconnect/content/torConnectTitlebarStatus.css
- + browser/components/torconnect/content/torConnectTitlebarStatus.js
- + browser/components/torconnect/content/torConnectUrlbarButton.js
- − browser/components/torconnect/content/torconnect-urlbar.css
- − browser/components/torconnect/content/torconnect-urlbar.inc.xhtml
- browser/components/torconnect/jar.mn
- browser/components/torpreferences/content/torPreferences.css
- browser/modules/TorConnect.jsm
- browser/modules/TorStrings.jsm
- browser/themes/shared/browser-shared.css
- browser/themes/shared/jar.inc.mn
- + browser/themes/shared/tor-urlbar-button.css
- toolkit/torbutton/chrome/locale/en-US/torConnect.properties
Changes:
=====================================
browser/base/content/browser.js
=====================================
@@ -80,6 +80,8 @@ XPCOMUtils.defineLazyModuleGetters(this, {
TabCrashHandler: "resource:///modules/ContentCrashHandlers.jsm",
TelemetryEnvironment: "resource://gre/modules/TelemetryEnvironment.jsm",
TorConnect: "resource:///modules/TorConnect.jsm",
+ TorConnectState: "resource:///modules/TorConnect.jsm",
+ TorConnectTopics: "resource:///modules/TorConnect.jsm",
Translation: "resource:///modules/translation/TranslationParent.jsm",
UITour: "resource:///modules/UITour.jsm",
UpdateUtils: "resource://gre/modules/UpdateUtils.jsm",
@@ -269,6 +271,16 @@ XPCOMUtils.defineLazyScriptGetter(
"gSharedTabWarning",
"chrome://browser/content/browser-webrtc.js"
);
+XPCOMUtils.defineLazyScriptGetter(
+ this,
+ ["gTorConnectUrlbarButton"],
+ "chrome://browser/content/torconnect/torConnectUrlbarButton.js"
+);
+XPCOMUtils.defineLazyScriptGetter(
+ this,
+ ["gTorConnectTitlebarStatus"],
+ "chrome://browser/content/torconnect/torConnectTitlebarStatus.js"
+);
XPCOMUtils.defineLazyScriptGetter(
this,
["gTorCircuitPanel"],
@@ -1808,6 +1820,9 @@ var gBrowserInit = {
// Init the OnionAuthPrompt
OnionAuthPrompt.init();
+ gTorConnectUrlbarButton.init();
+ gTorConnectTitlebarStatus.init();
+
gTorCircuitPanel.init();
// Certain kinds of automigration rely on this notification to complete
@@ -1895,8 +1910,6 @@ var gBrowserInit = {
}
this._loadHandled = true;
-
- TorBootstrapUrlbar.init();
},
_cancelDelayedStartup() {
@@ -2554,9 +2567,10 @@ var gBrowserInit = {
OnionAuthPrompt.uninit();
- gTorCircuitPanel.uninit();
+ gTorConnectUrlbarButton.uninit();
+ gTorConnectTitlebarStatus.uninit();
- TorBootstrapUrlbar.uninit();
+ gTorCircuitPanel.uninit();
gAccessibilityServiceIndicator.uninit();
=====================================
browser/base/content/browser.xhtml
=====================================
@@ -37,6 +37,7 @@
<?xml-stylesheet href="chrome://browser/skin/places/editBookmark.css" type="text/css"?>
<?xml-stylesheet href="chrome://browser/content/onionservices/onionservices.css" type="text/css"?>
<?xml-stylesheet href="chrome://browser/content/torCircuitPanel.css" type="text/css"?>
+<?xml-stylesheet href="chrome://browser/content/torconnect/torConnectTitlebarStatus.css" type="text/css"?>
<!DOCTYPE window [
#include browser-doctype.inc
@@ -123,7 +124,6 @@
Services.scriptloader.loadSubScript("chrome://browser/content/search/searchbar.js", this);
Services.scriptloader.loadSubScript("chrome://browser/content/languageNotification.js", this);
Services.scriptloader.loadSubScript("chrome://torbutton/content/torbutton.js", this);
- Services.scriptloader.loadSubScript("chrome://browser/content/torconnect/torBootstrapUrlbar.js", this);
window.onload = gBrowserInit.onLoad.bind(gBrowserInit);
window.onunload = gBrowserInit.onUnload.bind(gBrowserInit);
=====================================
browser/base/content/navigator-toolbox.inc.xhtml
=====================================
@@ -93,6 +93,11 @@
aria-live="polite"/>
<hbox class="private-browsing-indicator"/>
+ <html:div id="tor-connect-titlebar-status" role="status">
+ <html:img alt="" id="tor-connect-titlebar-status-icon" />
+ <html:span id="tor-connect-titlebar-status-label"></html:span>
+ </html:div>
+
#include titlebar-items.inc.xhtml
</toolbar>
@@ -335,7 +340,6 @@
data-l10n-id="urlbar-go-button"/>
<hbox id="page-action-buttons" context="pageActionContextMenu">
<toolbartabstop/>
-#include ../../components/torconnect/content/torconnect-urlbar.inc.xhtml
<hbox id="contextual-feature-recommendation" role="button" hidden="true">
<hbox id="cfr-label-container">
<label id="cfr-label"/>
@@ -363,9 +367,6 @@
onclick="FullZoom.reset(); FullZoom.resetScalingZoom();"
tooltip="dynamic-shortcut-tooltip"
hidden="true"/>
-
-#include ../../components/onionservices/content/onionlocation-urlbar.inc.xhtml
-
<hbox id="pageActionButton"
class="urlbar-page-action"
role="button"
@@ -383,6 +384,15 @@
class="urlbar-icon"/>
</hbox>
</hbox>
+
+ <hbox id="tor-connect-urlbar-button"
+ role="button"
+ class="tor-urlbar-button"
+ hidden="true">
+ <label id="tor-connect-urlbar-button-label"/>
+ </hbox>
+
+#include ../../components/onionservices/content/onionlocation-urlbar.inc.xhtml
</hbox>
</hbox>
<toolbartabstop/>
=====================================
browser/components/onionservices/content/onionlocation-urlbar.inc.xhtml
=====================================
@@ -1,10 +1,10 @@
# Copyright (c) 2020, The Tor Project, Inc.
<hbox id="onion-location-box"
- class="urlbar-icon-wrapper urlbar-page-action"
+ class="tor-urlbar-button"
role="button"
hidden="true"
onclick="OnionLocationParent.buttonClick(event);">
<image id="onion-location-button" role="presentation"/>
- <hbox id="onion-label-container"><label id="onion-label"/></hbox>
+ <label id="onion-label"/>
</hbox>
=====================================
browser/components/onionservices/content/onionlocation.css
=====================================
@@ -1,44 +1,9 @@
/* Copyright (c) 2020, The Tor Project, Inc. */
-#onion-location-box {
- background-color: var(--purple-60);
- -moz-context-properties: fill;
- fill: white;
-}
-
-#onion-location-box:hover {
- background-color: var(--purple-70);
-}
-
-#onion-location-box:active {
- background-color: var(--purple-80);
-}
-
-@media (prefers-color-scheme: dark) {
- #onion-location-box {
- background-color: var(--purple-50);
- }
-
- #onion-location-box:hover {
- background-color: var(--purple-60);
- }
-
- #onion-location-box:active {
- background-color: var(--purple-70);
- }
-}
-
#onion-location-button {
list-style-image: url(chrome://browser/content/onionservices/onionlocation.svg);
- padding-inline-start: 0.5em;
-}
-
-label#onion-label {
- margin: 0;
- padding-block: 0;
- padding-inline: 0.5em;
- color: white;
- font-weight: normal;
+ -moz-context-properties: fill;
+ fill: currentColor;
}
.onionlocation-notification-icon {
=====================================
browser/components/torconnect/content/aboutTorConnect.js
=====================================
@@ -769,26 +769,29 @@ class AboutTorConnect {
}
});
- // Delay the "Enter" activation of the given button from "keydown" to
- // "keyup".
+ // Prevent repeat triggering on keydown when the Enter key is held down.
//
- // Without this, holding down Enter will continue to trigger the button
- // until the user stops holding. This means that a user can accidentally
- // re-trigger a button several times. This is particularly bad when the
- // focus gets moved to a new button, and the new button can get triggered
- // immediately. E.g. when the "Connect" button is triggered it disappears
- // and focus moves to the "Cancel" button.
+ // Without this, holding down Enter will continue to trigger the button's
+ // click event until the user stops holding. This means that a user can
+ // accidentally re-trigger a button several times. And if focus moves to a
+ // new button it can also get triggered, despite not receiving the initial
+ // keydown event.
+ //
+ // E.g. If the user presses down Enter on the "Connect" button it will
+ // trigger and focus will move to the "Cancel" button. This should prevent
+ // the user accidentally triggering the "Cancel" button if they hold down
+ // Enter for a little bit too long.
for (const button of document.body.querySelectorAll("button")) {
button.addEventListener("keydown", event => {
- if (event.key === "Enter") {
+ // If the keydown is a repeating Enter event, ignore it.
+ // NOTE: If firefox uses wayland display (rather than xwayland), the
+ // "repeat" event is always "false" so this will not work.
+ // See bugzilla bug 1784438. Also see bugzilla bug 1594003.
+ // Currently tor browser uses xwayland by default on linux.
+ if (event.key === "Enter" && event.repeat) {
event.preventDefault();
}
});
- button.addEventListener("keyup", event => {
- if (event.key === "Enter") {
- button.click();
- }
- });
}
}
=====================================
browser/components/torconnect/content/onion-slash.svg deleted
=====================================
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg">
- <path d="m14.1161 15.6245c-.0821.0001-.1634-.016-.2393-.0474-.0758-.0314-.1447-.0775-.2027-.1356l-12.749984-12.749c-.109266-.11882-.168406-.27526-.165071-.43666.003335-.16139.068886-.31525.182967-.42946.114078-.11421.267868-.17994.429258-.18345.16139-.00352.3179.05544.43685.16457l12.74998 12.75c.1168.1176.1824.2767.1824.4425s-.0656.3249-.1824.4425c-.058.058-.1269.1039-.2028.1352-.0759.0312-.1571.0471-.2392.0468z" fill-opacity="context-fill-opacity" fill="#ff0039" />
- <path d="m 8,0.5000002 c -1.61963,0 -3.1197431,0.5137987 -4.3457031,1.3867188 l 0.84375,0.8417968 0.7792969,0.78125 0.8613281,0.8613282 0.8164062,0.8164062 0.9863281,0.984375 h 0.058594 c 1.00965,0 1.828125,0.818485 1.828125,1.828125 0,0.01968 6.2e-4,0.039074 0,0.058594 L 10.8125,9.0449221 C 10.9334,8.7195921 11,8.3674002 11,8.0000002 c 0,-1.65685 -1.34314,-3 -3,-3 v -1.078125 c 2.25231,0 4.078125,1.825845 4.078125,4.078125 0,0.67051 -0.162519,1.3033281 -0.449219,1.8613281 l 0.861328,0.8613277 C 12.972434,9.9290067 13.25,8.9965102 13.25,8.0000002 c 0,-2.89949 -2.35049,-5.25 -5.25,-5.25 v -1.078125 c 3.4949,0 6.328125,2.833195 6.328125,6.328125 0,1.29533 -0.388841,2.4990528 -1.056641,3.5019528 l 0.841797,0.84375 C 14.986181,11.119703 15.5,9.6196302 15.5,8.0000002 c 0,-4.14214 -3.3579,-7.5 -7.5,-7.5 z m -6.1113281,3.15625 C 1.0154872,4.8821451 0.5,6.3803304 0.5,8.0000002 0.5,12.1421 3.85786,15.5 8,15.5 c 1.6198027,0 3.117896,-0.515441 4.34375,-1.388672 L 11.501953,13.269531 C 10.498787,13.937828 9.295838,14.328125 8,14.328125 V 13.25 c 0.9967306,0 1.9287093,-0.277621 2.722656,-0.759766 L 9.859375,11.626953 C 9.3016226,11.913918 8.6705338,12.078125 8,12.078125 V 11 C 8.3664751,11 8.716425,10.93088 9.0410156,10.810547 6.6639891,8.4300416 4.2743195,6.0418993 1.8886719,3.6562502 Z" fill-opacity="context-fill-opacity" fill="context-fill"/>
-</svg>
=====================================
browser/components/torconnect/content/torBootstrapUrlbar.js deleted
=====================================
@@ -1,95 +0,0 @@
-// Copyright (c) 2021, The Tor Project, Inc.
-
-"use strict";
-
-const { TorConnect, TorConnectTopics, TorConnectState } = ChromeUtils.import(
- "resource:///modules/TorConnect.jsm"
-);
-const { TorStrings } = ChromeUtils.import("resource:///modules/TorStrings.jsm");
-
-/* globals browser, gURLBar, Services */
-
-var TorBootstrapUrlbar = {
- selectors: Object.freeze({
- torConnect: {
- box: "hbox#torconnect-box",
- label: "label#torconnect-label",
- },
- }),
-
- elements: null,
-
- updateTorConnectBox(state) {
- switch (state) {
- case TorConnectState.Initial:
- case TorConnectState.Configuring:
- case TorConnectState.AutoConfiguring:
- case TorConnectState.Error:
- case TorConnectState.FatalError: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torNotConnectedConcise;
- this.elements.inputContainer.setAttribute("torconnect", "offline");
- break;
- }
- case TorConnectState.Bootstrapping: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torConnectingConcise;
- this.elements.inputContainer.setAttribute("torconnect", "connecting");
- break;
- }
- case TorConnectState.Bootstrapped: {
- this.elements.torConnectBox.removeAttribute("hidden");
- this.elements.torConnectLabel.textContent =
- TorStrings.torConnect.torConnectedConcise;
- this.elements.inputContainer.setAttribute("torconnect", "connected");
- // hide torconnect box after 5 seconds
- setTimeout(() => {
- this.elements.torConnectBox.setAttribute("hidden", "true");
- }, 5000);
- break;
- }
- case TorConnectState.Disabled: {
- this.elements.torConnectBox.setAttribute("hidden", "true");
- break;
- }
- default:
- break;
- }
- },
-
- observe(aSubject, aTopic, aData) {
- if (aTopic === TorConnectTopics.StateChange) {
- const obj = aSubject?.wrappedJSObject;
- this.updateTorConnectBox(obj?.state);
- }
- },
-
- init() {
- if (TorConnect.shouldShowTorConnect) {
- // browser isn't populated until init
- this.elements = Object.freeze({
- torConnectBox: browser.ownerGlobal.document.querySelector(
- this.selectors.torConnect.box
- ),
- torConnectLabel: browser.ownerGlobal.document.querySelector(
- this.selectors.torConnect.label
- ),
- inputContainer: gURLBar._inputContainer,
- });
- this.elements.torConnectBox.addEventListener("click", () => {
- TorConnect.openTorConnect();
- });
- Services.obs.addObserver(this, TorConnectTopics.StateChange);
- this.observing = true;
- this.updateTorConnectBox(TorConnect.state);
- }
- },
-
- uninit() {
- if (this.observing) {
- Services.obs.removeObserver(this, TorConnectTopics.StateChange);
- }
- },
-};
=====================================
browser/components/torconnect/content/torConnectTitlebarStatus.css
=====================================
@@ -0,0 +1,38 @@
+#tor-connect-titlebar-status:not([hidden]) {
+ display: flex;
+ align-items: center;
+ /* Want same as #private-browsing-indicator-with-label */
+ margin-inline: 7px;
+}
+
+#tor-connect-titlebar-status-label {
+ margin-inline: 6px;
+ white-space: nowrap;
+}
+
+#tor-connect-titlebar-status-icon {
+ -moz-context-properties: fill;
+ fill: currentColor;
+ width: 16px;
+ height: 16px;
+}
+
+#tor-connect-titlebar-status-icon.tor-connect-status-connected {
+ fill: var(--purple-60);
+}
+
+@media (prefers-color-scheme: dark) {
+ #tor-connect-titlebar-status-icon.tor-connect-status-connected {
+ fill: var(--purple-30);
+ }
+}
+
+#tor-connect-titlebar-status-icon.tor-connect-status-potentially-blocked {
+ fill: #c50042;
+}
+
+@media (prefers-color-scheme: dark) {
+ #tor-connect-titlebar-status-icon.tor-connect-status-potentially-blocked {
+ fill: #ff9aa2;
+ }
+}
=====================================
browser/components/torconnect/content/torConnectTitlebarStatus.js
=====================================
@@ -0,0 +1,115 @@
+/* eslint-env mozilla/browser-window */
+
+/**
+ * A TorConnect status shown in the application title bar.
+ */
+var gTorConnectTitlebarStatus = {
+ /**
+ * The status element in the title bar.
+ *
+ * @type {Element}
+ */
+ node: null,
+ /**
+ * The status label.
+ *
+ * @type {Element}
+ */
+ label: null,
+ /**
+ * The status icon.
+ *
+ * @type {Element}
+ */
+ icon: null,
+
+ /**
+ * Initialize the component.
+ */
+ init() {
+ const { TorStrings } = ChromeUtils.import(
+ "resource:///modules/TorStrings.jsm"
+ );
+
+ this._strings = TorStrings.torConnect;
+
+ this.node = document.getElementById("tor-connect-titlebar-status");
+ this.icon = document.getElementById("tor-connect-titlebar-status-icon");
+ this.label = document.getElementById("tor-connect-titlebar-status-label");
+ // The title also acts as an accessible name for the role="status".
+ this.node.setAttribute("title", this._strings.titlebarStatusName);
+
+ this._observeTopic = TorConnectTopics.StateChange;
+ this._stateListener = {
+ observe: (subject, topic, data) => {
+ if (topic !== this._observeTopic) {
+ return;
+ }
+ this._torConnectStateChanged();
+ },
+ };
+ Services.obs.addObserver(this._stateListener, this._observeTopic);
+
+ this._torConnectStateChanged();
+ },
+
+ /**
+ * De-initialize the component.
+ */
+ deinit() {
+ Services.obs.removeObserver(this._stateListener, this._observeTopic);
+ },
+
+ /**
+ * Callback for when the TorConnect state changes.
+ */
+ _torConnectStateChanged() {
+ let textId;
+ let connected = false;
+ let potentiallyBlocked = false;
+ switch (TorConnect.state) {
+ case TorConnectState.Disabled:
+ // Hide immediately.
+ this.node.hidden = true;
+ return;
+ case TorConnectState.Bootstrapped:
+ this._startHiding();
+ textId = "titlebarStatusConnected";
+ connected = true;
+ break;
+ case TorConnectState.Bootstrapping:
+ case TorConnectState.AutoBootstrapping:
+ textId = "titlebarStatusConnecting";
+ break;
+ default:
+ if (TorConnect.potentiallyBlocked) {
+ textId = "titlebarStatusPotentiallyBlocked";
+ potentiallyBlocked = true;
+ } else {
+ textId = "titlebarStatusNotConnected";
+ }
+ break;
+ }
+ this.label.textContent = this._strings[textId];
+ this.icon.setAttribute(
+ "src",
+ connected
+ ? "chrome://browser/content/torconnect/onion.svg"
+ : "chrome://browser/content/torconnect/onion-slash-fillable.svg"
+ );
+ this.icon.classList.toggle("tor-connect-status-connected", connected);
+ this.icon.classList.toggle(
+ "tor-connect-status-potentially-blocked",
+ potentiallyBlocked
+ );
+ },
+
+ /**
+ * Mark the component to be hidden after some delay.
+ */
+ _startHiding() {
+ setTimeout(() => {
+ this.node.hidden = true;
+ }, 5000);
+ },
+};
=====================================
browser/components/torconnect/content/torConnectUrlbarButton.js
=====================================
@@ -0,0 +1,155 @@
+/* eslint-env mozilla/browser-window */
+
+/**
+ * A "Connect" button shown in the urlbar when not connected to tor and in tabs
+ * other than about:torconnect.
+ */
+var gTorConnectUrlbarButton = {
+ /**
+ * The urlbar button node.
+ *
+ * @type {Element}
+ */
+ button: null,
+ /**
+ * Whether we are active.
+ *
+ * @type {boolean}
+ */
+ _isActive: false,
+ /**
+ * Whether we are in the "about:torconnect" tab.
+ *
+ * @type {boolean}
+ */
+ // We init to "true" so that the button can only appear after the first page
+ // load.
+ _inAboutTorConnectTab: true,
+
+ /**
+ * Initialize the button.
+ */
+ init() {
+ if (this._isActive) {
+ return;
+ }
+ this._isActive = true;
+
+ const { TorStrings } = ChromeUtils.import(
+ "resource:///modules/TorStrings.jsm"
+ );
+
+ this.button = document.getElementById("tor-connect-urlbar-button");
+ document.getElementById("tor-connect-urlbar-button-label").value =
+ TorStrings.torConnect.torConnectButton;
+ this.button.addEventListener("click", event => {
+ if (event.button !== 0) {
+ return;
+ }
+ this.connect();
+ });
+ this.button.addEventListener("keydown", event => {
+ if (event.key !== "Enter" && event.key !== " ") {
+ return;
+ }
+ this.connect();
+ });
+
+ this._observeTopic = TorConnectTopics.StateChange;
+ this._stateListener = {
+ observe: (subject, topic, data) => {
+ if (topic !== this._observeTopic) {
+ return;
+ }
+ this._torConnectStateChanged();
+ },
+ };
+ Services.obs.addObserver(this._stateListener, this._observeTopic);
+
+ this._locationListener = {
+ onLocationChange: (webProgress, request, locationURI, flags) => {
+ if (
+ webProgress.isTopLevel &&
+ !(flags & Ci.nsIWebProgressListener.LOCATION_CHANGE_SAME_DOCUMENT)
+ ) {
+ this._inAboutTorConnectTab = gBrowser.selectedBrowser.currentURI?.spec.startsWith(
+ "about:torconnect"
+ );
+ this._updateButtonVisibility();
+ }
+ },
+ };
+ // Notified of new locations for the currently selected browser (tab) *and*
+ // switching selected browser.
+ gBrowser.addProgressListener(this._locationListener);
+
+ this._torConnectStateChanged();
+ },
+
+ /**
+ * Deactivate and de-initialize the button.
+ */
+ deinit() {
+ if (!this._isActive) {
+ return;
+ }
+ this._isActive = false;
+
+ Services.obs.removeObserver(this._stateListener, this._observeTopic);
+ gBrowser.removeProgressListener(this._locationListener);
+ this._updateButtonVisibility();
+ },
+
+ /**
+ * Begin the tor connection bootstrapping process.
+ */
+ connect() {
+ TorConnect.openTorConnect({ beginBootstrap: true });
+ },
+
+ /**
+ * Callback for when the TorConnect state changes.
+ */
+ _torConnectStateChanged() {
+ if (
+ TorConnect.state === TorConnectState.Bootstrapped ||
+ TorConnect.state === TorConnectState.Disabled
+ ) {
+ this.deinit();
+ return;
+ }
+ this._updateButtonVisibility();
+ },
+
+ /**
+ * Callback when the TorConnect state, current browser location, or activation
+ * state changes.
+ */
+ _updateButtonVisibility() {
+ if (!this.button) {
+ return;
+ }
+ // NOTE: We do not manage focus when hiding the button. We only expect to
+ // move from "not hidden" to "hidden" when:
+ // + switching tabs to "about:torconnect", or
+ // + starting bootstrapping.
+ //
+ // When switching tabs, the normal tab switching logic will eventually move
+ // focus to the new tab or url bar, so whilst the focus may be lost
+ // temporarily when we hide the button, it will be re-established quickly on
+ // tab switch.
+ //
+ // And we don't expect bootstrapping to start whilst outside of the
+ // "about:torconnect", and the automatic bootstrapping should only trigger
+ // at the initial start.
+ this.button.hidden =
+ !this._isActive ||
+ this._inAboutTorConnectTab ||
+ !TorConnect.enabled ||
+ !TorConnect.canBeginBootstrap;
+ this.button.classList.toggle(
+ "tor-urlbar-button-plain",
+ TorConnect.potentiallyBlocked
+ );
+ },
+};
=====================================
browser/components/torconnect/content/torconnect-urlbar.css deleted
=====================================
@@ -1,37 +0,0 @@
-/*
- ensure our torconnect button is always visible (same rule as for the bookmark button)
-*/
-label#torconnect-label {
- margin: 0;
- opacity: 0.6;
- padding: 0 0.5em;
-}
-
-hbox.urlbar-page-action#torconnect-box {
- display: -moz-inline-box!important;
-}
-
-/* hide when hidden attribute is set */
-hbox.urlbar-page-action#torconnect-box[hidden="true"],
-/* hide when user is typing in URL bar */
-#urlbar[usertyping] > #urlbar-input-container > #page-action-buttons > #torconnect-box {
- display: none!important;
-}
-
-/* hide urlbar's placeholder text when not connectd to tor */
-hbox#urlbar-input-container[torconnect="offline"] input#urlbar-input::placeholder,
-hbox#urlbar-input-container[torconnect="connecting"] input#urlbar-input::placeholder {
- opacity: 0;
-}
-
-/* hide search suggestions when not connected to tor */
-hbox#urlbar-input-container[torconnect="offline"] + vbox.urlbarView,
-hbox#urlbar-input-container[torconnect="connecting"] + vbox.urlbarView {
- display: none!important;
-}
-
-/* hide search icon when we are not connected to tor */
-hbox#urlbar-input-container[torconnect="offline"] > #identity-box[pageproxystate="invalid"] > #identity-icon,
-hbox#urlbar-input-container[torconnect="connecting"] > #identity-box[pageproxystate="invalid"] > #identity-icon {
- display: none!important;
-}
=====================================
browser/components/torconnect/content/torconnect-urlbar.inc.xhtml deleted
=====================================
@@ -1,11 +0,0 @@
-# Copyright (c) 2021, The Tor Project, Inc.
-
-<hbox id="torconnect-box"
- class="urlbar-icon-wrapper urlbar-page-action"
- role="status"
- align="center"
- hidden="true">
- <hbox id="torconnect-container">
- <label id="torconnect-label"/>
- </hbox>
-</hbox>
\ No newline at end of file
=====================================
browser/components/torconnect/jar.mn
=====================================
@@ -1,5 +1,7 @@
browser.jar:
- content/browser/torconnect/torBootstrapUrlbar.js (content/torBootstrapUrlbar.js)
+ content/browser/torconnect/torConnectUrlbarButton.js (content/torConnectUrlbarButton.js)
+ content/browser/torconnect/torConnectTitlebarStatus.js (content/torConnectTitlebarStatus.js)
+ content/browser/torconnect/torConnectTitlebarStatus.css (content/torConnectTitlebarStatus.css)
content/browser/torconnect/aboutTorConnect.css (content/aboutTorConnect.css)
* content/browser/torconnect/aboutTorConnect.xhtml (content/aboutTorConnect.xhtml)
content/browser/torconnect/aboutTorConnect.js (content/aboutTorConnect.js)
@@ -8,6 +10,4 @@ browser.jar:
content/browser/torconnect/connection-failure.svg (content/connection-failure.svg)
content/browser/torconnect/connection-location.svg (content/connection-location.svg)
content/browser/torconnect/onion.svg (content/onion.svg)
- content/browser/torconnect/onion-slash.svg (content/onion-slash.svg)
content/browser/torconnect/onion-slash-fillable.svg (content/onion-slash-fillable.svg)
- skin/classic/browser/torconnect-urlbar.css (content/torconnect-urlbar.css)
=====================================
browser/components/torpreferences/content/torPreferences.css
=====================================
@@ -58,7 +58,7 @@ html:dir(rtl) input[type="checkbox"].toggle-button::before {
#torPreferences-connectMessageBox.error #torPreferences-connectMessageBox-icon
{
- mask: url("chrome://browser/skin/onion-slash.svg");
+ mask: url("chrome://browser/content/torconnect/onion-slash-fillable.svg");
background-color: white;
}
=====================================
browser/modules/TorConnect.jsm
=====================================
@@ -99,7 +99,7 @@ const TorConnectState = Object.freeze({
└─┼─────▶ │ │ │
│ └──────────────────────────────────────────────────────────┘ │
│ │ ▲ │
- │ │ beginAutoBootstrap() │ cancelAutoBootstrap() │
+ │ │ beginAutoBootstrap() │ cancelBootstrap() │
│ ▼ │ │
│ ┌───────────────────────┐ │ │
└────── │ AutoBootstrapping │ ─┘ │
@@ -464,6 +464,7 @@ const TorConnect = (() => {
const tbr = new TorBootstrapRequest();
const internetTest = new InternetTest();
+ let cancelled = false;
let bootstrapError = "";
let bootstrapErrorDetails = "";
@@ -506,6 +507,7 @@ const TorConnect = (() => {
this.on_transition = async nextState => {
if (nextState === TorConnectState.Configuring) {
// stop bootstrap process if user cancelled
+ cancelled = true;
internetTest.cancel();
await tbr.cancel();
}
@@ -520,6 +522,19 @@ const TorConnect = (() => {
TorConnect._changeState(TorConnectState.Bootstrapped);
};
tbr.onbootstraperror = (message, details) => {
+ if (cancelled) {
+ // We ignore this error since it occurred after cancelling (by
+ // the user). We assume the error is just a side effect of the
+ // cancelling.
+ // E.g. If the cancelling is triggered late in the process, we
+ // get "Building circuits: Establishing a Tor circuit failed".
+ // TODO: Maybe move this logic deeper in the process to know
+ // when to filter out such errors triggered by cancelling.
+ console.log(
+ `TorConnect: Post-cancel error => ${message}; ${details}`
+ );
+ return;
+ }
// We have to wait for the Internet test to finish before sending the bootstrap error
bootstrapError = message;
bootstrapErrorDetails = details;
@@ -1023,11 +1038,6 @@ const TorConnect = (() => {
this._changeState(TorConnectState.AutoBootstrapping, countryCode);
},
- cancelAutoBootstrap() {
- console.log("TorConnect: cancelAutoBootstrap()");
- this._changeState(TorConnectState.Configuring);
- },
-
/*
Further external commands and helper methods
*/
=====================================
browser/modules/TorStrings.jsm
=====================================
@@ -207,10 +207,6 @@ const Loader = {
torConnecting: "Establishing a Connection",
- torNotConnectedConcise: "Not Connected",
-
- torConnectingConcise: "Connecting…",
-
tryingAgain: "Trying again…",
noInternet: "Tor Browser couldn’t reach the Internet",
@@ -250,8 +246,6 @@ const Loader = {
torConnected: "Connected to the Tor network",
- torConnectedConcise: "Connected",
-
tryAgain: "Try Again",
// tor connect strings for message box in about:preferences#connection
@@ -275,6 +269,13 @@ const Loader = {
autoBootstrappingAllFailed: "None of the configurations we tried worked",
cannotDetermineCountry: "Unable to determine user country",
noSettingsForCountry: "No settings available for your location",
+
+ // Titlebar status.
+ titlebarStatusName: "Tor connection",
+ titlebarStatusNotConnected: "Not connected",
+ titlebarStatusConnecting: "Connecting…",
+ titlebarStatusPotentiallyBlocked: "Potentially blocked",
+ titlebarStatusConnected: "Connected",
};
const tsb = new TorPropertyStringBundle(
=====================================
browser/themes/shared/browser-shared.css
=====================================
@@ -23,8 +23,8 @@
@import url("chrome://browser/skin/UITour.css");
@import url("chrome://browser/skin/browser-colors.css");
@import url("chrome://branding/content/tor-styles.css");
-@import url("chrome://browser/skin/torconnect-urlbar.css");
@import url("chrome://browser/skin/onionlocation.css");
+@import url("chrome://browser/skin/tor-urlbar-button.css");
@namespace html url("http://www.w3.org/1999/xhtml");
=====================================
browser/themes/shared/jar.inc.mn
=====================================
@@ -32,6 +32,7 @@
skin/classic/browser/tabs.css (../shared/tabs.css)
skin/classic/browser/toolbarbuttons.css (../shared/toolbarbuttons.css)
skin/classic/browser/toolbarbutton-icons.css (../shared/toolbarbutton-icons.css)
+ skin/classic/browser/tor-urlbar-button.css (../shared/tor-urlbar-button.css)
skin/classic/browser/urlbar-dynamic-results.css (../shared/urlbar-dynamic-results.css)
skin/classic/browser/urlbar-searchbar.css (../shared/urlbar-searchbar.css)
skin/classic/browser/urlbarView.css (../shared/urlbarView.css)
=====================================
browser/themes/shared/tor-urlbar-button.css
=====================================
@@ -0,0 +1,107 @@
+.tor-urlbar-button:not([hidden]) {
+ --tor-urlbar-button-background-color: var(--purple-60);
+ background-color: var(--tor-urlbar-button-background-color);
+ /* FIXME: Use different colors for light and dark theme, rather than "white".
+ * See tor-browser#41787 */
+ color: white;
+ display: flex;
+ align-items: center;
+ gap: 0.5em;
+ border-radius: var(--urlbar-icon-border-radius);
+ --tor-urlbar-button-inline-padding: 8px;
+ padding-inline: var(--tor-urlbar-button-inline-padding);
+ margin: 0;
+}
+
+.tor-urlbar-button > * {
+ flex: 0 0 auto;
+ margin: 0;
+}
+
+.tor-urlbar-button:focus-visible {
+ /* This button lies within the urlbar, so if the outline extends beyond the
+ * button's boundary, it will be clipped by the urlbar.
+ * Most button's in the urlbar get around this by using --focus-outline-inset,
+ * but our button has a purple background, which does not contrast well with
+ * the focus outline.
+ * Therefore, we use an offset outline rather than an inset outline, and
+ * compensate by shrinking the button's width and height so that the outline
+ * fits within the non-focused button boundary. Essentially, this has a
+ * similar effect to using an inset outline that matches the color of the
+ * urlbar background, but we keep the rounded corners. */
+ outline: var(--focus-outline);
+ outline-offset: var(--focus-outline-offset);
+ /* Use the background color for the outline, same as in-content buttons. */
+ outline-color: var(--tor-urlbar-button-background-color);
+ /* Calculate the difference between the button's border area and the outline
+ * area. */
+ --tor-urlbar-focus-outline-difference: calc(
+ var(--focus-outline-offset)
+ + var(--focus-outline-width)
+ );
+ /* For the inline direction, we shrink the padding by the difference, and
+ * increase the margin by the same amount so that the button text remains in
+ * the same position.
+ * For the block direction, the height of the button is flexibly sized with
+ * the urlbar height, so we should only need to increase the margin. */
+ padding-inline: calc(
+ var(--tor-urlbar-button-inline-padding)
+ - var(--tor-urlbar-focus-outline-difference)
+ );
+ margin: var(--tor-urlbar-focus-outline-difference);
+}
+
+.tor-urlbar-button:focus-visible > * {
+ /* Negate the margin that would be added on focus to ensure the button does
+ * not grow in height.
+ * Ideally, this should not change anything noticeable, otherwise the text
+ * could be clipped when focused. */
+ margin-block: calc(-1 * var(--tor-urlbar-focus-outline-difference));
+}
+
+#urlbar[usertyping] .tor-urlbar-button {
+ /* Hide whilst the user is typing in the url bar. */
+ display: none;
+}
+
+.tor-urlbar-button:hover {
+ --tor-urlbar-button-background-color: var(--purple-70);
+}
+
+.tor-urlbar-button:hover:active {
+ --tor-urlbar-button-background-color: var(--purple-80);
+}
+
+@media (prefers-color-scheme: dark) {
+ .tor-urlbar-button {
+ --tor-urlbar-button-background-color: var(--purple-50);
+ }
+
+ .tor-urlbar-button:hover {
+ --tor-urlbar-button-background-color: var(--purple-60);
+ }
+
+ .tor-urlbar-button:hover:active {
+ --tor-urlbar-button-background-color: var(--purple-70);
+ }
+}
+
+/* Make the button look plain like the identity #urlbar-label-box. */
+.tor-urlbar-button.tor-urlbar-button-plain {
+ --tor-urlbar-button-background-color: var(--urlbar-box-bgcolor);
+ color: var(--urlbar-box-text-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:focus-visible {
+ outline-color: var(--focus-outline-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:hover {
+ --tor-urlbar-button-background-color: var(--urlbar-box-hover-bgcolor);
+ color: var(--urlbar-box-hover-text-color);
+}
+
+.tor-urlbar-button.tor-urlbar-button-plain:hover:active {
+ --tor-urlbar-button-background-color: var(--urlbar-box-active-bgcolor);
+ color: var(--urlbar-box-hover-text-color);
+}
=====================================
toolkit/torbutton/chrome/locale/en-US/torConnect.properties
=====================================
@@ -3,10 +3,14 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+torConnect.titlebarStatusName=Tor connection
+torConnect.titlebarStatusNotConnected=Not connected
+torConnect.titlebarStatusConnecting=Connecting…
+torConnect.titlebarStatusPotentiallyBlocked=Potentially blocked
+torConnect.titlebarStatusConnected=Connected
+
torConnect.torConnect=Connect to Tor
torConnect.torConnecting=Establishing a Connection
-torConnect.torNotConnectedConcise=Not Connected
-torConnect.torConnectingConcise=Connecting…
torConnect.tryingAgain=Trying again…
torConnect.noInternet=Tor Browser couldn’t reach the Internet
torConnect.noInternetDescription=This could be due to a connection issue rather than Tor being blocked. Check your Internet connection, proxy and firewall settings before trying again.
@@ -35,7 +39,6 @@ torConnect.viewLog=View logs…
torConnect.torConnectButton=Connect
torConnect.cancel=Cancel
torConnect.torConnected=Connected to the Tor network!
-torConnect.torConnectedConcise=Connected
torConnect.tryAgain=Try Again
torConnect.connectMessage=Changes to Tor Settings will not take effect until you connect
torConnect.tryAgainMessage=Tor Browser has failed to establish a connection to the Tor Network
@@ -51,3 +54,8 @@ torConnect.autoBootstrappingFailed=Automatic configuration failed
torConnect.autoBootstrappingAllFailed=None of the configurations we tried worked
torConnect.cannotDetermineCountry=Unable to determine user country
torConnect.noSettingsForCountry=No settings available for your location
+
+# Urlbar strings used up to 12.0 - TODO: remove when 12.5 becomes stable:
+torConnect.torNotConnectedConcise=Not Connected
+torConnect.torConnectingConcise=Connecting…
+torConnect.torConnectedConcise=Connected
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dbec6c…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dbec6c…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-build][main] Bug 40777: Update Go to 1.20.4 and create a Go bootstrap project
by Pier Angelo Vendrame (@pierov) 25 May '23
by Pier Angelo Vendrame (@pierov) 25 May '23
25 May '23
Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
b37e2ebd by Pier Angelo Vendrame at 2023-05-25T18:28:35+02:00
Bug 40777: Update Go to 1.20.4 and create a Go bootstrap project
The Go compiler is written in Go, but it is possible to bootstrap it
from C wiht Go 1.4.
Before this commit, we used to build Go 1.4 for all our platforms,
so we built a compiler to throw it away several times.
Starting from Go 1.20, the team decided to require Go V-3 to bootstrap
(i.e., Go 1.17 to bootrastrap Go 1.20).
Bootstrapping is still feasible, but throwing away two compilers is
not a good idea. So, we decided to create a Go bootstrap project, and
build it only once (for Linux amd64) until it will be able to build
more recent Go compilers.
- - - - -
5 changed files:
- + projects/go-bootstrap/build
- + projects/go-bootstrap/config
- projects/go/0001-Use-fixed-go-build-tmp-directory.patch
- projects/go/build
- projects/go/config
Changes:
=====================================
projects/go-bootstrap/build
=====================================
@@ -0,0 +1,38 @@
+#!/bin/bash
+[% c("var/set_default_env") -%]
+
+# This project is expected to be built only on Linux.
+# Then the actual Go compiler will be built for each platform.
+
+distdir=/var/tmp/dist/[% project %]
+mkdir -p /var/tmp/build /var/tmp/dist
+
+# Building go 1.4.x
+# This is needed to bootstrap the go that we actually use
+# https://golang.org/doc/install/source#go14
+tar -C /var/tmp/build --transform='s,^go\>,go1.4,' -xf $rootdir/[% c('input_files_by_name/go14') %]
+cd /var/tmp/build/go1.4/src
+# Disable cgo to avoid conflicts with newer GCC. cgo is not needed for the bootstrap go.
+# https://github.com/golang/go/issues/13114#issuecomment-186922245
+# Disable CC etc. that are set up for cross builds.
+CGO_ENABLED=0 CC= CFLAGS= LDFLAGS= ./make.bash
+export GOROOT_BOOTSTRAP="/var/tmp/build/go1.4"
+
+cd $rootdir
+
+tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/go') %]
+export GOROOT="$distdir"
+mv /var/tmp/dist/go $distdir
+cd $distdir/src
+
+./make.bash
+
+# This directory is non-reproducible and doesn't exist in official Go releases,
+# so remove it to preserve reproducibility of the output.
+rm -rf $distdir/pkg/obj/go-build/
+
+cd /var/tmp/dist
+[% c('tar', {
+ tar_src => [ project ],
+ tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'),
+ }) %]
=====================================
projects/go-bootstrap/config
=====================================
@@ -0,0 +1,14 @@
+# vim: filetype=yaml sw=2
+version: 1.19.9
+filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz'
+container:
+ use_container: 1
+
+input_files:
+ - project: container-image
+ - URL: 'https://golang.org/dl/go[% c("version") %].src.tar.gz'
+ name: go
+ sha256sum: 131190a4697a70c5b1d232df5d3f55a3f9ec0e78e40516196ffb3f09ae6a5744
+ - URL: https://dl.google.com/go/go1.4-bootstrap-20171003.tar.gz
+ name: go14
+ sha256sum: f4ff5b5eb3a3cae1c993723f3eab519c5bae18866b5e5f96fe1102f0cb5c3e52
=====================================
projects/go/0001-Use-fixed-go-build-tmp-directory.patch
=====================================
@@ -1,4 +1,4 @@
-From 958f724b1b434702c3d44ceaca646791674d07b1 Mon Sep 17 00:00:00 2001
+From 2c1c98d6404284df744a194dd23bd3660f365387 Mon Sep 17 00:00:00 2001
From: Georg Koppen <gk(a)torproject.org>
Date: Fri, 17 Apr 2020 10:24:23 +0000
Subject: [PATCH] Use fixed go-build tmp directory
@@ -6,15 +6,18 @@ Subject: [PATCH] Use fixed go-build tmp directory
Use fixed go-build tmp directory, when the directory does not exist, in
order to avoid some reproducibility issues where build directory gets
embedded in generated binaries.
+---
+ src/cmd/go/internal/work/action.go | 10 +++++++---
+ 1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go
-index 33b7818fb2..5e369d0f53 100644
+index 8beb1345d0..dccf39c1c1 100644
--- a/src/cmd/go/internal/work/action.go
+++ b/src/cmd/go/internal/work/action.go
-@@ -252,9 +252,13 @@ func (b *Builder) Init() {
- if cfg.BuildN {
- b.WorkDir = "$WORK"
- } else {
+@@ -279,9 +279,13 @@ func NewBuilder(workDir string) *Builder {
+ if !buildInitStarted {
+ panic("internal error: NewBuilder called before BuildInit")
+ }
- tmp, err := os.MkdirTemp(cfg.Getenv("GOTMPDIR"), "go-build")
- if err != nil {
- base.Fatalf("go: creating work dir: %v", err)
@@ -29,5 +32,5 @@ index 33b7818fb2..5e369d0f53 100644
if !filepath.IsAbs(tmp) {
abs, err := filepath.Abs(tmp)
--
-2.26.1
+2.39.2
=====================================
projects/go/build
=====================================
@@ -3,27 +3,8 @@
distdir=/var/tmp/dist/[% project %]
mkdir -p /var/tmp/dist
-[% IF c("var/linux") %]
- # Config options for hardening-wrapper
- export DEB_BUILD_HARDENING=1
- export DEB_BUILD_HARDENING_STACKPROTECTOR=1
- export DEB_BUILD_HARDENING_FORTIFY=1
- export DEB_BUILD_HARDENING_FORMAT=1
- export DEB_BUILD_HARDENING_PIE=1
-[% END %]
-
-mkdir -p /var/tmp/build
-
-# Building go 1.4.x
-# This is needed to bootstrap the go that we actually use
-# https://golang.org/doc/install/source#go14
-tar -C /var/tmp/build --transform='s,^go\>,go1.4,' -xf $rootdir/[% c('input_files_by_name/go14') %]
-cd /var/tmp/build/go1.4/src
-# Disable cgo to avoid conflicts with newer GCC. cgo is not needed for the bootstrap go.
-# https://github.com/golang/go/issues/13114#issuecomment-186922245
-# Disable CC etc. that are set up for cross builds.
-CGO_ENABLED=0 CC= CFLAGS= LDFLAGS= ./make.bash
-export GOROOT_BOOTSTRAP="/var/tmp/build/go1.4"
+tar -C /var/tmp/dist -xf $rootdir/[% c('input_files_by_name/go-bootstrap') %]
+export GOROOT_BOOTSTRAP="/var/tmp/dist/go-bootstrap"
cd $rootdir
[% IF ! c("var/linux") %]
=====================================
projects/go/config
=====================================
@@ -1,12 +1,10 @@
# vim: filetype=yaml sw=2
-version: 1.19.9
-filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.gz'
+version: 1.20.4
+filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz'
container:
use_container: 1
var:
- go14_version: 1.4.3
-
setup: |
mkdir -p /var/tmp/dist
tar -C /var/tmp/dist -xf $rootdir/[% c("go_tarfile") %]
@@ -121,9 +119,10 @@ input_files:
enable: '[% ! c("var/linux") %]'
- URL: 'https://golang.org/dl/go[% c("version") %].src.tar.gz'
name: go
- sha256sum: 131190a4697a70c5b1d232df5d3f55a3f9ec0e78e40516196ffb3f09ae6a5744
- - URL: 'https://golang.org/dl/go[% c("var/go14_version") %].src.tar.gz'
- name: go14
- sha256sum: 9947fc705b0b841b5938c48b22dc33e9647ec0752bae66e50278df4f23f64959
+ sha256sum: 9f34ace128764b7a3a4b238b805856cc1b2184304df9e5690825b0710f4202d6
+ - project: go-bootstrap
+ name: go-bootstrap
+ target_replace:
+ '^.*browser-.*': 'basebrowser-linux-x86_64'
- filename: 0001-Use-fixed-go-build-tmp-directory.patch
enable: '[% c("var/android") %]'
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser][tor-browser-102.11.0esr-12.5-1] fixup! Bug 23247: Communicating security expectations for .onion
by ma1 (@ma1) 25 May '23
by ma1 (@ma1) 25 May '23
25 May '23
ma1 pushed to branch tor-browser-102.11.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
Commits:
dbec6cf6 by cypherpunks1 at 2023-05-24T09:21:07-08:00
fixup! Bug 23247: Communicating security expectations for .onion
Bug 41785: Show http onion resources as secure in network monitor
- - - - -
1 changed file:
- devtools/shared/webconsole/network-helper.js
Changes:
=====================================
devtools/shared/webconsole/network-helper.js
=====================================
@@ -600,6 +600,9 @@ var NetworkHelper = {
// The request did not contain any security info.
if (!securityInfo) {
+ if (httpActivity.hostname && httpActivity.hostname.endsWith(".onion")) {
+ info.state = "secure";
+ }
return info;
}
@@ -651,7 +654,11 @@ var NetworkHelper = {
// schemes other than https and wss are subject to
// downgrade/etc at the scheme level and should always be
// considered insecure
- info.state = "insecure";
+ if (httpActivity.hostname && httpActivity.hostname.endsWith(".onion")) {
+ info.state = "secure";
+ } else {
+ info.state = "insecure";
+ }
} else if (state & wpl.STATE_IS_SECURE) {
// The connection is secure if the scheme is sufficient
info.state = "secure";
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dbec6cf…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dbec6cf…
You're receiving this email because of your account on gitlab.torproject.org.
1
0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 12.5a6
by richard (@richard) 24 May '23
by richard (@richard) 24 May '23
24 May '23
richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses
Commits:
6dc9b712 by Richard Pospesel at 2023-05-24T20:20:54+00:00
alpha: new version, 12.5a6
- - - - -
30 changed files:
- update_3/alpha/.htaccess
- − update_3/alpha/12.5a4-12.5a5-linux32-ALL.xml
- − update_3/alpha/12.5a4-12.5a5-linux64-ALL.xml
- − update_3/alpha/12.5a4-12.5a5-macos-ALL.xml
- − update_3/alpha/12.5a4-12.5a5-win32-ALL.xml
- − update_3/alpha/12.5a4-12.5a5-win64-ALL.xml
- + update_3/alpha/12.5a4-12.5a6-linux32-ALL.xml
- + update_3/alpha/12.5a4-12.5a6-linux64-ALL.xml
- + update_3/alpha/12.5a4-12.5a6-macos-ALL.xml
- + update_3/alpha/12.5a4-12.5a6-win32-ALL.xml
- + update_3/alpha/12.5a4-12.5a6-win64-ALL.xml
- + update_3/alpha/12.5a5-12.5a6-linux32-ALL.xml
- + update_3/alpha/12.5a5-12.5a6-linux64-ALL.xml
- + update_3/alpha/12.5a5-12.5a6-macos-ALL.xml
- + update_3/alpha/12.5a5-12.5a6-win32-ALL.xml
- + update_3/alpha/12.5a5-12.5a6-win64-ALL.xml
- − update_3/alpha/12.5a5-linux32-ALL.xml
- − update_3/alpha/12.5a5-linux64-ALL.xml
- − update_3/alpha/12.5a5-macos-ALL.xml
- − update_3/alpha/12.5a5-win32-ALL.xml
- − update_3/alpha/12.5a5-win64-ALL.xml
- + update_3/alpha/12.5a6-linux32-ALL.xml
- + update_3/alpha/12.5a6-linux64-ALL.xml
- + update_3/alpha/12.5a6-macos-ALL.xml
- + update_3/alpha/12.5a6-win32-ALL.xml
- + update_3/alpha/12.5a6-win64-ALL.xml
- update_3/alpha/download-android-aarch64.json
- update_3/alpha/download-android-armv7.json
- update_3/alpha/download-android-x86.json
- update_3/alpha/download-android-x86_64.json
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses…
You're receiving this email because of your account on gitlab.torproject.org.
1
0