- tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.6.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.6.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: bcebcebd by Beatriz Rizental at 2025-01-28T10:30:06+01:00 fixup! Add CI for Base Browser - - - - - 7938e825 by Beatriz Rizental at 2025-01-28T10:30:07+01:00 fixup! Add CI for Base Browser - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/lint.yml - + .gitlab/ci/mixins.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -6,4 +6,5 @@ variables: LOCAL_REPO_PATH: /srv/apps-repos/tor-browser.git include: + - local: '.gitlab/ci/mixins.yml' - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,11 +1,10 @@ .base: + extends: .with-local-repo-bash stage: lint image: $IMAGE_PATH interruptible: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" - # A copy of the repository already is available in the runner. - GIT_STRATEGY: "none" cache: paths: - node_modules @@ -17,19 +16,6 @@ tags: # Run these jobs in the browser dedicated runners. - firefox - before_script: - - git init - - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local - - git remote add origin "$CI_REPOSITORY_URL" - - | - if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then - echo "No branch specified. Stopping the pipeline." - exit 1 - fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base ===================================== .gitlab/ci/mixins.yml ===================================== @@ -0,0 +1,47 @@ +.with-local-repo-bash: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - | + if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then + echo "No branch specified. Stopping the pipeline." + exit 1 + fi + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi + - git checkout FETCH_HEAD + +.with-local-repo-pwsh: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local $env:LOCAL_REPO_PATH + - git fetch --depth 500 local + - git remote add origin $env:CI_REPOSITORY_URL + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_SOURCE_BRANCH_NAME + } + if ([string]::IsNullOrEmpty($branchName)) { + Write-Output "No branch specified. Stopping the pipeline." + exit 1 + } + - Write-Output "Fetching from remote branch $branchName" + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/77… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/77… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.6.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.6.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: db3a0f8a by Beatriz Rizental at 2025-01-28T10:29:07+01:00 fixup! Add CI for Base Browser - - - - - 7fe488e0 by Beatriz Rizental at 2025-01-28T10:29:14+01:00 fixup! Add CI for Base Browser - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/lint.yml - + .gitlab/ci/mixins.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -6,4 +6,5 @@ variables: LOCAL_REPO_PATH: /srv/apps-repos/tor-browser.git include: + - local: '.gitlab/ci/mixins.yml' - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,11 +1,10 @@ .base: + extends: .with-local-repo-bash stage: lint image: $IMAGE_PATH interruptible: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" - # A copy of the repository already is available in the runner. - GIT_STRATEGY: "none" cache: paths: - node_modules @@ -17,19 +16,6 @@ tags: # Run these jobs in the browser dedicated runners. - firefox - before_script: - - git init - - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local - - git remote add origin "$CI_REPOSITORY_URL" - - | - if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then - echo "No branch specified. Stopping the pipeline." - exit 1 - fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base ===================================== .gitlab/ci/mixins.yml ===================================== @@ -0,0 +1,47 @@ +.with-local-repo-bash: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - | + if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then + echo "No branch specified. Stopping the pipeline." + exit 1 + fi + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi + - git checkout FETCH_HEAD + +.with-local-repo-pwsh: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local $env:LOCAL_REPO_PATH + - git fetch --depth 500 local + - git remote add origin $env:CI_REPOSITORY_URL + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_SOURCE_BRANCH_NAME + } + if ([string]::IsNullOrEmpty($branchName)) { + Write-Output "No branch specified. Stopping the pipeline." + exit 1 + } + - Write-Output "Fetching from remote branch $branchName" + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/37b7d0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/37b7d0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 80bd6af4 by Beatriz Rizental at 2025-01-28T10:20:41+01:00 fixup! Add CI for Base Browser - - - - - 9fb2aed6 by Beatriz Rizental at 2025-01-28T10:21:23+01:00 fixup! Add CI for Base Browser - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/lint.yml - + .gitlab/ci/mixins.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -7,5 +7,6 @@ variables: LOCAL_REPO_PATH: /srv/apps-repos/tor-browser.git include: + - local: '.gitlab/ci/mixins.yml' - local: '.gitlab/ci/lint.yml' - local: '.gitlab/ci/update-translations.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,11 +1,10 @@ .base: + extends: .with-local-repo-bash stage: lint image: $IMAGE_PATH interruptible: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" - # A copy of the repository already is available in the runner. - GIT_STRATEGY: "none" cache: paths: - node_modules @@ -17,19 +16,6 @@ tags: # Run these jobs in the browser dedicated runners. - firefox - before_script: - - git init - - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local - - git remote add origin "$CI_REPOSITORY_URL" - - | - if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then - echo "No branch specified. Stopping the pipeline." - exit 1 - fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base ===================================== .gitlab/ci/mixins.yml ===================================== @@ -0,0 +1,47 @@ +.with-local-repo-bash: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - | + if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then + echo "No branch specified. Stopping the pipeline." + exit 1 + fi + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi + - git checkout FETCH_HEAD + +.with-local-repo-pwsh: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local $env:LOCAL_REPO_PATH + - git fetch --depth 500 local + - git remote add origin $env:CI_REPOSITORY_URL + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_SOURCE_BRANCH_NAME + } + if ([string]::IsNullOrEmpty($branchName)) { + Write-Output "No branch specified. Stopping the pipeline." + exit 1 + } + - Write-Output "Fetching from remote branch $branchName" + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2ef0ee… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/2ef0ee… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.20.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new branch tor-browser-115.20.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.7.0esr-14.5-1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new branch tor-browser-128.7.0esr-14.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.7.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new branch tor-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_128_7_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new tag FIREFOX_128_7_0esr_BUILD1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_20_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new tag FIREFOX_115_20_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_128_7_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed new tag FIREFOX_128_7_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] 2 commits: TB 43243: [android] Implement Android launch test
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 10dd6fcb by Beatriz Rizental at 2025-01-27T19:10:37+01:00 TB 43243: [android] Implement Android launch test Also remove exit call from terminate function. It causes all espresso tests to crash on exit and otherwise doesn't do anything. - - - - - 4d3353ee by Beatriz Rizental at 2025-01-27T19:10:38+01:00 fixup! Add CI for Tor Browser Implement Nightly startup tests for Android - - - - - 4 changed files: - + .gitlab/ci/jobs/startup-test/startup-test-android.py - .gitlab/ci/jobs/startup-test/startup-test.yml - + mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AppStartupTest.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt Changes: ===================================== .gitlab/ci/jobs/startup-test/startup-test-android.py ===================================== @@ -0,0 +1,231 @@ +#!/usr/bin/env python3 +import argparse +import json +import os +import sys +import time +from datetime import datetime, timedelta +from enum import Enum + +import requests + +""" +This script runs Android tests on BrowserStack using the BrowserStack App Automate Espresso API. + +Usage: + startup-test-android.py --devices <devices> [--tests <tests>] [--app_file_path <app_file_path>] [--test_file_path <test_file_path>] + +Arguments: + --devices: Comma-separated list of devices to test on (required). + --tests: Comma-separated list of tests to run (optional). If not provided, all tests will run. + --app_file_path: Path to the app file (optional). If not provided, yesterday's nightly will be downloaded. + --test_file_path: Path to the test file (optional). If not provided, yesterday's nightly will be downloaded. + +Environment Variables: + BROWSERSTACK_USERNAME: BrowserStack username (required). + BROWSERSTACK_API_KEY: BrowserStack API key (required). + +Description: + - If app and test file paths are not provided, the script downloads the latest nightly build from the Tor Project. + - Uploads the app and test files to BrowserStack. + - Triggers the test run on the specified devices. + - Polls for the test status until completion or timeout. + - Prints the test results and exits with an appropriate status code. +""" + +parser = argparse.ArgumentParser( + description="Run Android startup tests on BrowserStack." +) +parser.add_argument( + "--devices", + type=str, + help="Comma-separated list of devices to test on", + required=True, +) +parser.add_argument("--tests", type=str, help="Comma-separated list of tests to run") +parser.add_argument("--app_file_path", type=str, help="Path to the app file") +parser.add_argument("--test_file_path", type=str, help="Path to the test file") + +args = parser.parse_args() + +if args.app_file_path: + app_file_path = args.app_file_path + test_file_path = args.test_file_path + if not test_file_path: + print( + "\033[1;31mIf either app or test file paths are provided, both must be provided.\033[0m" + ) +else: + + def download_file(url, dest_path): + try: + response = requests.get(url, stream=True) + response.raise_for_status() + with open(dest_path, "wb") as f: + for chunk in response.iter_content(chunk_size=8192): + f.write(chunk) + except Exception as e: + print(f"\033[1;31mFailed to download file from {url}.\033[0m") + print(e) + sys.exit(1) + + yesterday = (datetime.now() - timedelta(days=1)).strftime("%Y.%m.%d") + download_url_base = f"https://nightlies.tbb.torproject.org/nightly-builds/tor-browser-builds/tbb-…" + print( + f"No file paths provided, downloading yesterday's nightly from {download_url_base}" + ) + + app_file_url = f"{download_url_base}/tor-browser-noopt-android-aarch64-tbb-nightly.{yesterday}.apk" + test_file_url = ( + f"{download_url_base}/tor-browser-tbb-nightly.{yesterday}-androidTest.apk" + ) + + # BrowserStack will fail if there are `.` in the file name other than before the extension. + yesterday = yesterday.replace(".", "-") + app_file_path = f"/tmp/nightly-{yesterday}.apk" + test_file_path = f"/tmp/nightly-test-{yesterday}.apk" + + download_file(app_file_url, app_file_path) + download_file(test_file_url, test_file_path) + +devices = [device.strip() for device in args.devices.split(",")] +tests = args.tests.split(",") if args.tests else [] + +browserstack_username = os.getenv("BROWSERSTACK_USERNAME") +browserstack_api_key = os.getenv("BROWSERSTACK_API_KEY") +if not browserstack_username or not browserstack_api_key: + print( + "\033[1;31mEnvironment variables BROWSERSTACK_USERNAME and BROWSERSTACK_API_KEY must be set.\033[0m" + ) + sys.exit(1) + +# Upload app file +with open(app_file_path, "rb") as app_file: + response = requests.post( + "https://api-cloud.browserstack.com/app-automate/espresso/v2/app", + auth=(browserstack_username, browserstack_api_key), + files={"file": app_file}, + ) + +if response.status_code != 200: + print("\033[1;31mFailed to upload app file.\033[0m") + print(response.text) + sys.exit(1) + +bs_app_url = response.json().get("app_url") +print("\033[1;32mSuccessfully uploaded app file.\033[0m") +print(f"App URL: {bs_app_url}") + +# Upload test file +with open(test_file_path, "rb") as test_file: + response = requests.post( + "https://api-cloud.browserstack.com/app-automate/espresso/v2/test-suite", + auth=(browserstack_username, browserstack_api_key), + files={"file": test_file}, + ) + +if response.status_code != 200: + print("\033[1;31mFailed to upload test file.\033[0m") + print(response.text) + sys.exit(1) + +bs_test_url = response.json().get("test_suite_url") +print("\033[1;32mSuccessfully uploaded test file.\033[0m") +print(f"Test URL: {bs_test_url}") + +# Trigger tests +test_params = { + "app": bs_app_url, + "testSuite": bs_test_url, + "devices": devices, + "class": tests, +} + +response = requests.post( + "https://api-cloud.browserstack.com/app-automate/espresso/v2/build", + auth=(browserstack_username, browserstack_api_key), + headers={"Content-Type": "application/json"}, + data=json.dumps(test_params), +) + +if response.status_code != 200: + print("\033[1;31mFailed to trigger test run.\033[0m") + print(response.text) + sys.exit(1) + +build_id = response.json().get("build_id") +print("\033[1;32mSuccessfully triggered test run.\033[0m") +print( + f"Test status also available at: https://app-automate.browserstack.com/builds/{build_id}\n===" +) + +# Poll for status +POLLING_TIMEOUT = 30 * 60 # 30min +POLLING_INTERVAL = 30 # 30s + + +class TestStatus(Enum): + QUEUED = "queued" + RUNNING = "running" + ERROR = "error" + FAILED = "failed" + PASSED = "passed" + TIMED_OUT = "timed out" + SKIPPED = "skipped" + + @classmethod + def from_string(cls, s): + try: + return cls[s.upper().replace(" ", "_")] + except KeyError: + raise ValueError(f"\033[1;31m'{s}' is not a valid test status.\033[0m") + + def is_terminal(self): + return self not in {TestStatus.QUEUED, TestStatus.RUNNING} + + def is_success(self): + return self in {TestStatus.PASSED, TestStatus.SKIPPED} + + def color_print(self): + if self == TestStatus.PASSED: + return f"\033[1;32m{self.value}\033[0m" + + if self in {TestStatus.ERROR, TestStatus.FAILED, TestStatus.TIMED_OUT}: + return f"\033[1;31m{self.value}\033[0m" + + if self == TestStatus.SKIPPED: + return f"\033[1;33m{self.value}\033[0m" + + return self.value + + +start_time = time.time() +elapsed_time = 0 +test_status = None +while elapsed_time <= POLLING_TIMEOUT: + response = requests.get( + f"https://api-cloud.browserstack.com/app-automate/espresso/v2/builds/{build_i…", + auth=(browserstack_username, browserstack_api_key), + ) + + if response.status_code != 200: + print("\033[1;31mFailed to get test status.\033[0m") + print(response.text) + sys.exit(1) + + test_status = TestStatus.from_string(response.json().get("status")) + if test_status.is_terminal(): + print(f"===\nTest finished. Result: {test_status.color_print()}") + break + else: + elapsed_time = time.time() - start_time + print(f"Test status: {test_status.value} ({elapsed_time:.2f}s)") + + if elapsed_time > POLLING_TIMEOUT: + print("===\n\033[1;33mWaited for tests for too long.\033[0m") + break + + time.sleep(POLLING_INTERVAL) + +if test_status is None or not test_status.is_success(): + sys.exit(1) ===================================== .gitlab/ci/jobs/startup-test/startup-test.yml ===================================== @@ -49,3 +49,15 @@ startup-test-linux: - ./mach python .gitlab/ci/jobs/startup-test/startup-test.py --platform linux --arch x86_64 --browser $BROWSER rules: - if: $CI_PIPELINE_SOURCE == "schedule" + +startup-test-android: + extends: .with-local-repo-bash + image: $IMAGE_PATH + stage: startup-test + interruptible: true + tags: + - firefox + script: + - ./mach python .gitlab/ci/jobs/startup-test/startup-test-android.py --devices "Samsung Galaxy S23-13.0, Samsung Galaxy S8-7.0" --tests org.mozilla.fenix.LaunchTest + rules: + - if: $CI_PIPELINE_SOURCE == "schedule" ===================================== mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AppStartupTest.kt ===================================== @@ -0,0 +1,40 @@ +package org.mozilla.fenix + +import androidx.test.ext.junit.rules.ActivityScenarioRule +import androidx.test.ext.junit.runners.AndroidJUnit4 +import androidx.test.platform.app.InstrumentationRegistry +import androidx.test.uiautomator.UiDevice +import org.junit.Rule +import org.junit.Test +import org.junit.runner.RunWith +import java.util.concurrent.CountDownLatch +import java.util.concurrent.TimeUnit + + +@RunWith(AndroidJUnit4::class) +class LaunchTest { + + @get:Rule + var rule: ActivityScenarioRule<HomeActivity> = ActivityScenarioRule(HomeActivity::class.java) + + @Test + fun appLaunchesWithoutCrash() { + val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()) + device.waitForIdle() + + // Simulate a 30-second delay + val latch = CountDownLatch(1) + Thread { + try { + Thread.sleep(30_000) + latch.countDown() + } catch (e: InterruptedException) { + e.printStackTrace() + } + }.start() + + latch.await(30, TimeUnit.SECONDS) + + // If we got here, the app did not crash. Test passed. + } +} ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt ===================================== @@ -192,7 +192,6 @@ open class FenixApplication : LocaleAwareApplication(), Provider { fun terminate() { onTerminate() - System.exit(0) } override fun onTerminate() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cd21b7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cd21b7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 916dc515 by Beatriz Rizental at 2025-01-27T18:11:16+01:00 fixup! Add CI for Base Browser Fetch specific branch when prepopulating history from local repository. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -4,7 +4,7 @@ before_script: - git init - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local + - git fetch --depth 500 local ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_TARGET_BRANCH_NAME} - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then @@ -26,7 +26,12 @@ before_script: - git init - git remote add local $env:LOCAL_REPO_PATH - - git fetch --depth 500 local + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_TARGET_BRANCH_NAME + } + git fetch --depth 500 local $branchName - git remote add origin $env:CI_REPOSITORY_URL - | $branchName = $env:CI_COMMIT_BRANCH View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/916… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/916… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 2d391e80 by Beatriz Rizental at 2025-01-27T18:10:56+01:00 fixup! Add CI for Base Browser Fetch specific branch when prepopulating history from local repository. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -4,7 +4,7 @@ before_script: - git init - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local + - git fetch --depth 500 local ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_TARGET_BRANCH_NAME} - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then @@ -26,7 +26,12 @@ before_script: - git init - git remote add local $env:LOCAL_REPO_PATH - - git fetch --depth 500 local + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_TARGET_BRANCH_NAME + } + git fetch --depth 500 local $branchName - git remote add origin $env:CI_REPOSITORY_URL - | $branchName = $env:CI_COMMIT_BRANCH View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2d391e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2d391e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: cd21b741 by Beatriz Rizental at 2025-01-27T17:04:46+00:00 fixup! Add CI for Base Browser Fetch specific branch when prepopulating history from local repository. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -4,7 +4,7 @@ before_script: - git init - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local + - git fetch --depth 500 local ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_TARGET_BRANCH_NAME} - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then @@ -26,7 +26,12 @@ before_script: - git init - git remote add local $env:LOCAL_REPO_PATH - - git fetch --depth 500 local + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_TARGET_BRANCH_NAME + } + git fetch --depth 500 local $branchName - git remote add origin $env:CI_REPOSITORY_URL - | $branchName = $env:CI_COMMIT_BRANCH View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cd21b74… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cd21b74… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 4700859f by Beatriz Rizental at 2025-01-27T18:04:31+01:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -18,7 +18,7 @@ echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" fi - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout FETCH_HEAD .with-local-repo-pwsh: variables: @@ -44,4 +44,4 @@ Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" } - - git checkout origin/$branchName + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4700859… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4700859… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 188baa6f by Beatriz Rizental at 2025-01-27T18:03:56+01:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -18,7 +18,7 @@ echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" fi - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout FETCH_HEAD .with-local-repo-pwsh: variables: @@ -44,4 +44,4 @@ Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" } - - git checkout origin/$branchName + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/188… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/188… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 58c78829 by Beatriz Rizental at 2025-01-27T17:01:27+00:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -18,7 +18,7 @@ echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" fi - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout FETCH_HEAD .with-local-repo-pwsh: variables: @@ -44,4 +44,4 @@ Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" } - - git checkout origin/$branchName + - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/58c7882… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/58c7882… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: cc778f7c by Beatriz Rizental at 2025-01-27T17:42:14+01:00 fixup! Add CI for Base Browser - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/jobs/lint/lint.yml - + .gitlab/ci/mixins.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -7,5 +7,6 @@ variables: LOCAL_REPO_PATH: /srv/apps-repos/tor-browser.git include: + - local: '.gitlab/ci/mixins.yml' - local: '.gitlab/ci/jobs/lint/lint.yml' - local: '.gitlab/ci/jobs/update-translations.yml' ===================================== .gitlab/ci/jobs/lint/lint.yml ===================================== @@ -1,11 +1,10 @@ .base: + extends: .with-local-repo-bash stage: lint image: $IMAGE_PATH interruptible: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" - # A copy of the repository already is available in the runner. - GIT_STRATEGY: "none" cache: paths: - node_modules @@ -17,19 +16,6 @@ tags: # Run these jobs in the browser dedicated runners. - firefox - before_script: - - git init - - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local - - git remote add origin "$CI_REPOSITORY_URL" - - | - if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then - echo "No branch specified. Stopping the pipeline." - exit 1 - fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base ===================================== .gitlab/ci/mixins.yml ===================================== @@ -0,0 +1,47 @@ +.with-local-repo-bash: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - | + if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then + echo "No branch specified. Stopping the pipeline." + exit 1 + fi + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi + - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + +.with-local-repo-pwsh: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local $env:LOCAL_REPO_PATH + - git fetch --depth 500 local + - git remote add origin $env:CI_REPOSITORY_URL + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_SOURCE_BRANCH_NAME + } + if ([string]::IsNullOrEmpty($branchName)) { + Write-Output "No branch specified. Stopping the pipeline." + exit 1 + } + - Write-Output "Fetching from remote branch $branchName" + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } + - git checkout origin/$branchName View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/cc7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/cc7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 24b648b3 by Beatriz Rizental at 2025-01-27T17:41:31+01:00 fixup! Add CI for Base Browser - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/jobs/lint/lint.yml - + .gitlab/ci/mixins.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -7,5 +7,6 @@ variables: LOCAL_REPO_PATH: /srv/apps-repos/tor-browser.git include: + - local: '.gitlab/ci/mixins.yml' - local: '.gitlab/ci/jobs/lint/lint.yml' - local: '.gitlab/ci/jobs/update-translations.yml' ===================================== .gitlab/ci/jobs/lint/lint.yml ===================================== @@ -1,11 +1,10 @@ .base: + extends: .with-local-repo-bash stage: lint image: $IMAGE_PATH interruptible: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" - # A copy of the repository already is available in the runner. - GIT_STRATEGY: "none" cache: paths: - node_modules @@ -17,19 +16,6 @@ tags: # Run these jobs in the browser dedicated runners. - firefox - before_script: - - git init - - git remote add local "$LOCAL_REPO_PATH" - - git fetch --depth 500 local - - git remote add origin "$CI_REPOSITORY_URL" - - | - if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then - echo "No branch specified. Stopping the pipeline." - exit 1 - fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base ===================================== .gitlab/ci/mixins.yml ===================================== @@ -0,0 +1,47 @@ +.with-local-repo-bash: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - | + if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then + echo "No branch specified. Stopping the pipeline." + exit 1 + fi + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi + - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + +.with-local-repo-pwsh: + variables: + GIT_STRATEGY: "none" + before_script: + - git init + - git remote add local $env:LOCAL_REPO_PATH + - git fetch --depth 500 local + - git remote add origin $env:CI_REPOSITORY_URL + - | + $branchName = $env:CI_COMMIT_BRANCH + if ([string]::IsNullOrEmpty($branchName)) { + $branchName = $env:CI_MERGE_REQUEST_SOURCE_BRANCH_NAME + } + if ([string]::IsNullOrEmpty($branchName)) { + Write-Output "No branch specified. Stopping the pipeline." + exit 1 + } + - Write-Output "Fetching from remote branch $branchName" + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } + - git checkout origin/$branchName View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/24b648b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/24b648b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] 2 commits: fixup! Add CI for Tor Browser
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 2fc000c1 by Beatriz Rizental at 2025-01-27T16:52:37+01:00 fixup! Add CI for Tor Browser Revert changes that will not be part of the Base Browser commit - - - - - 99dc6926 by Beatriz Rizental at 2025-01-27T16:52:37+01:00 fixup! Add CI for Base Browser - - - - - 0 changed files: Changes: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c4d87… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c4d87… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] fixup! TB 40458: Implement .tor.onion aliases
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 6c4d876b by Henry Wilkes at 2025-01-27T15:41:07+00:00 fixup! TB 40458: Implement .tor.onion aliases TB 41831: Add additional effective TLD for abc.au.securedrop.tor.onion exception. - - - - - 1 changed file: - netwerk/dns/effective_tld_names.dat Changes: ===================================== netwerk/dns/effective_tld_names.dat ===================================== @@ -5061,6 +5061,10 @@ pro.om onion tor.onion securedrop.tor.onion +// An additional TLD for abc.au.securedrop.tor.onion only. +// See tor-browser#41831. +// TODO: Remove once abc.au has migrated. See tor-browser#43443. +au.securedrop.tor.onion // org : https://www.iana.org/domains/root/db/org.html org View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c4d876… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c4d876… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.6.0esr-14.5-1] 2 commits: Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref"
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 2bbd4c5b by Pier Angelo Vendrame at 2025-01-27T15:15:26+01:00 Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref" This reverts commit 57c94a79410783c564187a9496d7a5403accf15e. - - - - - ba0c37e9 by Pier Angelo Vendrame at 2025-01-27T15:15:28+01:00 Bug 1840385 - Do not spoof the OS in HTTP User Agent. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D234835 - - - - - 6 changed files: - browser/components/resistfingerprinting/test/browser/browser_navigator.js - browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js - dom/base/Navigator.cpp - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp - toolkit/components/resistfingerprinting/nsRFPService.h Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator.js ===================================== @@ -107,20 +107,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -169,7 +162,7 @@ async function testUserAgentHeader() { is( result, - expectedResults.userAgentHeader, + expectedResults.userAgent, `Checking ${expectedResults.testDesc} User Agent HTTP Header.` ); @@ -203,7 +196,7 @@ async function testNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( @@ -308,7 +301,7 @@ async function testWorkerNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -364,8 +357,7 @@ add_task(async function setupDefaultUserAgent() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -397,8 +389,7 @@ add_task(async function setupRFPExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -447,8 +438,7 @@ add_task(async function setupETPToggleExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -482,12 +472,8 @@ add_task(async function setupResistFingerprinting() { let spoofedGeckoTrail = SPOOFED_UA_GECKO_TRAIL[AppConstants.platform]; - let spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; - - let spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + let spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; expectedResults = { @@ -498,8 +484,7 @@ add_task(async function setupResistFingerprinting() { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, }; await testNavigator(); ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js ===================================== @@ -122,20 +122,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -186,12 +179,12 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( result.userAgentHTTPHeader, - expectedResults.userAgentHTTPHeader, + expectedResults.userAgent, `Checking ${testDesc} userAgentHTTPHeader.` ); is( @@ -268,7 +261,7 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.worker_userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -295,8 +288,7 @@ async function testNavigator(result, expectedResults, extraData) { } let defaultUserAgent; -let spoofedUserAgentNavigator; -let spoofedUserAgentHeader; +let spoofedUserAgent; let allNotSpoofed; let allSpoofed; @@ -308,14 +300,8 @@ add_setup(async () => { DEFAULT_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; - spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${ - SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] - } Firefox/${appVersion}.0`; - - spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${ SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; @@ -331,8 +317,7 @@ add_setup(async () => { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHTTPHeader: defaultUserAgent, + userAgent: defaultUserAgent, framer_crossOrigin_userAgentHTTPHeader: defaultUserAgent, framee_crossOrigin_userAgentHTTPHeader: defaultUserAgent, }; @@ -343,10 +328,9 @@ add_setup(async () => { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHTTPHeader: spoofedUserAgentHeader, - framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, - framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, + framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, + framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, }; }); @@ -385,8 +369,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testC(uri, testNavigator, expectedResults); }); @@ -394,8 +377,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testD(uri, testNavigator, expectedResults); }); ===================================== dom/base/Navigator.cpp ===================================== @@ -2118,7 +2118,7 @@ nsresult Navigator::GetUserAgent(nsPIDOMWindowInner* aWindow, // specific OS version, etc. if (shouldResistFingerprinting) { nsAutoCString spoofedUA; - nsRFPService::GetSpoofedUserAgent(spoofedUA, false); + nsRFPService::GetSpoofedUserAgent(spoofedUA); CopyASCIItoUTF16(spoofedUA, aUserAgent); return NS_OK; } ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -409,7 +409,7 @@ nsresult nsHttpHandler::Init() { mMisc.AssignLiteral("rv:" MOZILLA_UAVERSION); // Generate the spoofed User Agent for fingerprinting resistance. - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); + nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent); mSessionStartTime = NowInSeconds(); mHandlerActive = true; @@ -482,9 +482,6 @@ nsresult nsHttpHandler::Init() { // obsService->AddObserver(this, "net:failed-to-process-uri-content", true); } - Preferences::AddWeakObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - MakeNewRequestTokenBucket(); mWifiTickler = new Tickler(); if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr; @@ -2143,9 +2140,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, // Inform nsIOService that network is tearing down. gIOService->SetHttpHandlerAlreadyShutingDown(); - Preferences::RemoveObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - ShutdownConnectionManager(); // need to reset the session start time since cache validation may @@ -2268,11 +2262,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, ShutdownConnectionManager(); mConnMgr = nullptr; Unused << InitConnectionMgr(); - } else if (!strcmp(topic, "nsPref:changed") && - !NS_strcmp( - data, - u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) { - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); } return NS_OK; ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -895,8 +895,7 @@ uint32_t nsRFPService::GetSpoofedPresentedFrames(double aTime, uint32_t aWidth, // User-Agent/Version Stuff /* static */ -void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, - bool isForHTTPHeader) { +void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent) { // This function generates the spoofed value of User Agent. // We spoof the values of the platform and Firefox version, which could be // used as fingerprinting sources to identify individuals. @@ -904,38 +903,22 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent - const bool spoofOs = - isForHTTPHeader && - Preferences::GetBool( - "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); - // These magic numbers are the lengths of the UA string literals below. // Assume three-digit Firefox version numbers so we have room to grow. size_t preallocatedLength = - 13 + - (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) - : mozilla::ArrayLength(SPOOFED_UA_OS)) - - 1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + - 2; + 13 + mozilla::ArrayLength(SPOOFED_UA_OS) - 1 + 5 + 3 + 10 + + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + 2; userAgent.SetCapacity(preallocatedLength); // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0" userAgent.AssignLiteral("Mozilla/5.0 ("); - - if (spoofOs) { - userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS); - } else { - userAgent.AppendLiteral(SPOOFED_UA_OS); - } - + userAgent.AppendLiteral(SPOOFED_UA_OS); userAgent.AppendLiteral("; rv:" MOZILLA_UAVERSION ") Gecko/"); - #if defined(ANDROID) userAgent.AppendLiteral(MOZILLA_UAVERSION); #else userAgent.AppendLiteral(LEGACY_UA_GECKO_TRAIL); #endif - userAgent.AppendLiteral(" Firefox/" MOZILLA_UAVERSION); MOZ_ASSERT(userAgent.Length() <= preallocatedLength); ===================================== toolkit/components/resistfingerprinting/nsRFPService.h ===================================== @@ -59,14 +59,6 @@ #define SPOOFED_POINTER_INTERFACE MouseEvent_Binding::MOZ_SOURCE_MOUSE -// For the HTTP User-Agent header, we use a simpler set of spoofed values -// that do not reveal the specific desktop platform. -#if defined(MOZ_WIDGET_ANDROID) -# define SPOOFED_HTTP_UA_OS "Android 10; Mobile" -#else -# define SPOOFED_HTTP_UA_OS "Windows NT 10.0; Win64; x64" -#endif - struct JSContext; class nsIChannel; @@ -267,7 +259,7 @@ class nsRFPService final : public nsIObserver, public nsIRFPService { // -------------------------------------------------------------------------- // This method generates the spoofed value of User Agent. - static void GetSpoofedUserAgent(nsACString& userAgent, bool isForHTTPHeader); + static void GetSpoofedUserAgent(nsACString& userAgent); // -------------------------------------------------------------------------- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/69… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/69… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.6.0esr-14.5-1] 2 commits: Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref"
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: f9fb6744 by Pier Angelo Vendrame at 2025-01-27T15:15:03+01:00 Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref" This reverts commit 57c94a79410783c564187a9496d7a5403accf15e. - - - - - efbb8c60 by Pier Angelo Vendrame at 2025-01-27T15:15:05+01:00 Bug 1840385 - Do not spoof the OS in HTTP User Agent. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D234835 - - - - - 6 changed files: - browser/components/resistfingerprinting/test/browser/browser_navigator.js - browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js - dom/base/Navigator.cpp - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp - toolkit/components/resistfingerprinting/nsRFPService.h Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator.js ===================================== @@ -107,20 +107,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -169,7 +162,7 @@ async function testUserAgentHeader() { is( result, - expectedResults.userAgentHeader, + expectedResults.userAgent, `Checking ${expectedResults.testDesc} User Agent HTTP Header.` ); @@ -203,7 +196,7 @@ async function testNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( @@ -308,7 +301,7 @@ async function testWorkerNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -364,8 +357,7 @@ add_task(async function setupDefaultUserAgent() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -397,8 +389,7 @@ add_task(async function setupRFPExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -447,8 +438,7 @@ add_task(async function setupETPToggleExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -482,12 +472,8 @@ add_task(async function setupResistFingerprinting() { let spoofedGeckoTrail = SPOOFED_UA_GECKO_TRAIL[AppConstants.platform]; - let spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; - - let spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + let spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; expectedResults = { @@ -498,8 +484,7 @@ add_task(async function setupResistFingerprinting() { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, }; await testNavigator(); ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js ===================================== @@ -122,20 +122,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -186,12 +179,12 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( result.userAgentHTTPHeader, - expectedResults.userAgentHTTPHeader, + expectedResults.userAgent, `Checking ${testDesc} userAgentHTTPHeader.` ); is( @@ -268,7 +261,7 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.worker_userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -295,8 +288,7 @@ async function testNavigator(result, expectedResults, extraData) { } let defaultUserAgent; -let spoofedUserAgentNavigator; -let spoofedUserAgentHeader; +let spoofedUserAgent; let allNotSpoofed; let allSpoofed; @@ -308,14 +300,8 @@ add_setup(async () => { DEFAULT_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; - spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${ - SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] - } Firefox/${appVersion}.0`; - - spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${ SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; @@ -331,8 +317,7 @@ add_setup(async () => { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHTTPHeader: defaultUserAgent, + userAgent: defaultUserAgent, framer_crossOrigin_userAgentHTTPHeader: defaultUserAgent, framee_crossOrigin_userAgentHTTPHeader: defaultUserAgent, }; @@ -343,10 +328,9 @@ add_setup(async () => { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHTTPHeader: spoofedUserAgentHeader, - framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, - framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, + framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, + framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, }; }); @@ -385,8 +369,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testC(uri, testNavigator, expectedResults); }); @@ -394,8 +377,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testD(uri, testNavigator, expectedResults); }); ===================================== dom/base/Navigator.cpp ===================================== @@ -2118,7 +2118,7 @@ nsresult Navigator::GetUserAgent(nsPIDOMWindowInner* aWindow, // specific OS version, etc. if (shouldResistFingerprinting) { nsAutoCString spoofedUA; - nsRFPService::GetSpoofedUserAgent(spoofedUA, false); + nsRFPService::GetSpoofedUserAgent(spoofedUA); CopyASCIItoUTF16(spoofedUA, aUserAgent); return NS_OK; } ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -409,7 +409,7 @@ nsresult nsHttpHandler::Init() { mMisc.AssignLiteral("rv:" MOZILLA_UAVERSION); // Generate the spoofed User Agent for fingerprinting resistance. - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); + nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent); mSessionStartTime = NowInSeconds(); mHandlerActive = true; @@ -482,9 +482,6 @@ nsresult nsHttpHandler::Init() { // obsService->AddObserver(this, "net:failed-to-process-uri-content", true); } - Preferences::AddWeakObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - MakeNewRequestTokenBucket(); mWifiTickler = new Tickler(); if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr; @@ -2143,9 +2140,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, // Inform nsIOService that network is tearing down. gIOService->SetHttpHandlerAlreadyShutingDown(); - Preferences::RemoveObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - ShutdownConnectionManager(); // need to reset the session start time since cache validation may @@ -2268,11 +2262,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, ShutdownConnectionManager(); mConnMgr = nullptr; Unused << InitConnectionMgr(); - } else if (!strcmp(topic, "nsPref:changed") && - !NS_strcmp( - data, - u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) { - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); } return NS_OK; ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -895,8 +895,7 @@ uint32_t nsRFPService::GetSpoofedPresentedFrames(double aTime, uint32_t aWidth, // User-Agent/Version Stuff /* static */ -void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, - bool isForHTTPHeader) { +void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent) { // This function generates the spoofed value of User Agent. // We spoof the values of the platform and Firefox version, which could be // used as fingerprinting sources to identify individuals. @@ -904,38 +903,22 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent - const bool spoofOs = - isForHTTPHeader && - Preferences::GetBool( - "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); - // These magic numbers are the lengths of the UA string literals below. // Assume three-digit Firefox version numbers so we have room to grow. size_t preallocatedLength = - 13 + - (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) - : mozilla::ArrayLength(SPOOFED_UA_OS)) - - 1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + - 2; + 13 + mozilla::ArrayLength(SPOOFED_UA_OS) - 1 + 5 + 3 + 10 + + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + 2; userAgent.SetCapacity(preallocatedLength); // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0" userAgent.AssignLiteral("Mozilla/5.0 ("); - - if (spoofOs) { - userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS); - } else { - userAgent.AppendLiteral(SPOOFED_UA_OS); - } - + userAgent.AppendLiteral(SPOOFED_UA_OS); userAgent.AppendLiteral("; rv:" MOZILLA_UAVERSION ") Gecko/"); - #if defined(ANDROID) userAgent.AppendLiteral(MOZILLA_UAVERSION); #else userAgent.AppendLiteral(LEGACY_UA_GECKO_TRAIL); #endif - userAgent.AppendLiteral(" Firefox/" MOZILLA_UAVERSION); MOZ_ASSERT(userAgent.Length() <= preallocatedLength); ===================================== toolkit/components/resistfingerprinting/nsRFPService.h ===================================== @@ -59,14 +59,6 @@ #define SPOOFED_POINTER_INTERFACE MouseEvent_Binding::MOZ_SOURCE_MOUSE -// For the HTTP User-Agent header, we use a simpler set of spoofed values -// that do not reveal the specific desktop platform. -#if defined(MOZ_WIDGET_ANDROID) -# define SPOOFED_HTTP_UA_OS "Android 10; Mobile" -#else -# define SPOOFED_HTTP_UA_OS "Windows NT 10.0; Win64; x64" -#endif - struct JSContext; class nsIChannel; @@ -267,7 +259,7 @@ class nsRFPService final : public nsIObserver, public nsIRFPService { // -------------------------------------------------------------------------- // This method generates the spoofed value of User Agent. - static void GetSpoofedUserAgent(nsACString& userAgent, bool isForHTTPHeader); + static void GetSpoofedUserAgent(nsACString& userAgent); // -------------------------------------------------------------------------- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f1e706… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f1e706… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] 2 commits: Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref"
by Pier Angelo Vendrame (＠pierov) 27 Jan '25

27 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 31235564 by Pier Angelo Vendrame at 2025-01-27T14:33:37+01:00 Revert "BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref" This reverts commit 57c94a79410783c564187a9496d7a5403accf15e. - - - - - ee81cb96 by Pier Angelo Vendrame at 2025-01-27T15:05:09+01:00 Bug 1840385 - Do not spoof the OS in HTTP User Agent. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D234835 - - - - - 6 changed files: - browser/components/resistfingerprinting/test/browser/browser_navigator.js - browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js - dom/base/Navigator.cpp - netwerk/protocol/http/nsHttpHandler.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp - toolkit/components/resistfingerprinting/nsRFPService.h Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator.js ===================================== @@ -107,20 +107,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -169,7 +162,7 @@ async function testUserAgentHeader() { is( result, - expectedResults.userAgentHeader, + expectedResults.userAgent, `Checking ${expectedResults.testDesc} User Agent HTTP Header.` ); @@ -203,7 +196,7 @@ async function testNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( @@ -308,7 +301,7 @@ async function testWorkerNavigator() { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -364,8 +357,7 @@ add_task(async function setupDefaultUserAgent() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -397,8 +389,7 @@ add_task(async function setupRFPExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -447,8 +438,7 @@ add_task(async function setupETPToggleExemptions() { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHeader: defaultUserAgent, + userAgent: defaultUserAgent, }; await testNavigator(); @@ -482,12 +472,8 @@ add_task(async function setupResistFingerprinting() { let spoofedGeckoTrail = SPOOFED_UA_GECKO_TRAIL[AppConstants.platform]; - let spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; - - let spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + let spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${spoofedGeckoTrail} Firefox/${appVersion}.0`; expectedResults = { @@ -498,8 +484,7 @@ add_task(async function setupResistFingerprinting() { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, }; await testNavigator(); ===================================== browser/components/resistfingerprinting/test/browser/browser_navigator_iframes.js ===================================== @@ -122,20 +122,13 @@ const DEFAULT_UA_OS = { other: `X11; Linux ${defaultLinuxCpu}`, }; -const SPOOFED_UA_NAVIGATOR_OS = { +const SPOOFED_UA_OS = { linux: "X11; Linux x86_64", win: "Windows NT 10.0; Win64; x64", macosx: "Macintosh; Intel Mac OS X 10.15", android: "Android 10; Mobile", other: "X11; Linux x86_64", }; -const SPOOFED_UA_HTTPHEADER_OS = { - linux: "Windows NT 10.0; Win64; x64", - win: "Windows NT 10.0; Win64; x64", - macosx: "Windows NT 10.0; Win64; x64", - android: "Android 10; Mobile", - other: "Windows NT 10.0; Win64; x64", -}; const SPOOFED_HW_CONCURRENCY = 2; const CONST_APPCODENAME = "Mozilla"; @@ -186,12 +179,12 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} navigator.userAgent.` ); is( result.userAgentHTTPHeader, - expectedResults.userAgentHTTPHeader, + expectedResults.userAgent, `Checking ${testDesc} userAgentHTTPHeader.` ); is( @@ -268,7 +261,7 @@ async function testNavigator(result, expectedResults, extraData) { ); is( result.worker_userAgent, - expectedResults.userAgentNavigator, + expectedResults.userAgent, `Checking ${testDesc} worker navigator.userAgent.` ); is( @@ -295,8 +288,7 @@ async function testNavigator(result, expectedResults, extraData) { } let defaultUserAgent; -let spoofedUserAgentNavigator; -let spoofedUserAgentHeader; +let spoofedUserAgent; let allNotSpoofed; let allSpoofed; @@ -308,14 +300,8 @@ add_setup(async () => { DEFAULT_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; - spoofedUserAgentNavigator = `Mozilla/5.0 (${ - SPOOFED_UA_NAVIGATOR_OS[AppConstants.platform] - }; rv:${appVersion}.0) Gecko/${ - SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] - } Firefox/${appVersion}.0`; - - spoofedUserAgentHeader = `Mozilla/5.0 (${ - SPOOFED_UA_HTTPHEADER_OS[AppConstants.platform] + spoofedUserAgent = `Mozilla/5.0 (${ + SPOOFED_UA_OS[AppConstants.platform] }; rv:${appVersion}.0) Gecko/${ SPOOFED_UA_GECKO_TRAIL[AppConstants.platform] } Firefox/${appVersion}.0`; @@ -331,8 +317,7 @@ add_setup(async () => { oscpu: DEFAULT_OSCPU[AppConstants.platform], platform: DEFAULT_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: defaultUserAgent, - userAgentHTTPHeader: defaultUserAgent, + userAgent: defaultUserAgent, framer_crossOrigin_userAgentHTTPHeader: defaultUserAgent, framee_crossOrigin_userAgentHTTPHeader: defaultUserAgent, }; @@ -343,10 +328,9 @@ add_setup(async () => { oscpu: SPOOFED_OSCPU[AppConstants.platform], platform: SPOOFED_PLATFORM[AppConstants.platform], pluginsLength: 5, - userAgentNavigator: spoofedUserAgentNavigator, - userAgentHTTPHeader: spoofedUserAgentHeader, - framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, - framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgentHeader, + userAgent: spoofedUserAgent, + framer_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, + framee_crossOrigin_userAgentHTTPHeader: spoofedUserAgent, }; }); @@ -385,8 +369,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testC(uri, testNavigator, expectedResults); }); @@ -394,8 +377,7 @@ add_task(async () => { add_task(async () => { expectedResults = structuredClone(allSpoofed); expectedResults.framer_crossOrigin_userAgentHTTPHeader = defaultUserAgent; - expectedResults.framee_crossOrigin_userAgentHTTPHeader = - spoofedUserAgentHeader; + expectedResults.framee_crossOrigin_userAgentHTTPHeader = spoofedUserAgent; await testD(uri, testNavigator, expectedResults); }); ===================================== dom/base/Navigator.cpp ===================================== @@ -2118,7 +2118,7 @@ nsresult Navigator::GetUserAgent(nsPIDOMWindowInner* aWindow, // specific OS version, etc. if (shouldResistFingerprinting) { nsAutoCString spoofedUA; - nsRFPService::GetSpoofedUserAgent(spoofedUA, false); + nsRFPService::GetSpoofedUserAgent(spoofedUA); CopyASCIItoUTF16(spoofedUA, aUserAgent); return NS_OK; } ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -409,7 +409,7 @@ nsresult nsHttpHandler::Init() { mMisc.AssignLiteral("rv:" MOZILLA_UAVERSION); // Generate the spoofed User Agent for fingerprinting resistance. - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); + nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent); mSessionStartTime = NowInSeconds(); mHandlerActive = true; @@ -482,9 +482,6 @@ nsresult nsHttpHandler::Init() { // obsService->AddObserver(this, "net:failed-to-process-uri-content", true); } - Preferences::AddWeakObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - MakeNewRequestTokenBucket(); mWifiTickler = new Tickler(); if (NS_FAILED(mWifiTickler->Init())) mWifiTickler = nullptr; @@ -2143,9 +2140,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, // Inform nsIOService that network is tearing down. gIOService->SetHttpHandlerAlreadyShutingDown(); - Preferences::RemoveObserver( - this, "privacy.resistFingerprinting.spoofOsInUserAgentHeader"_ns); - ShutdownConnectionManager(); // need to reset the session start time since cache validation may @@ -2268,11 +2262,6 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, ShutdownConnectionManager(); mConnMgr = nullptr; Unused << InitConnectionMgr(); - } else if (!strcmp(topic, "nsPref:changed") && - !NS_strcmp( - data, - u"privacy.resistFingerprinting.spoofOsInUserAgentHeader")) { - nsRFPService::GetSpoofedUserAgent(mSpoofedUserAgent, true); } return NS_OK; ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -895,8 +895,7 @@ uint32_t nsRFPService::GetSpoofedPresentedFrames(double aTime, uint32_t aWidth, // User-Agent/Version Stuff /* static */ -void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, - bool isForHTTPHeader) { +void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent) { // This function generates the spoofed value of User Agent. // We spoof the values of the platform and Firefox version, which could be // used as fingerprinting sources to identify individuals. @@ -904,38 +903,22 @@ void nsRFPService::GetSpoofedUserAgent(nsACString& userAgent, // https://developer.mozilla.org/en-US/docs/Web/API/NavigatorID/userAgent // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent - const bool spoofOs = - isForHTTPHeader && - Preferences::GetBool( - "privacy.resistFingerprinting.spoofOsInUserAgentHeader", true); - // These magic numbers are the lengths of the UA string literals below. // Assume three-digit Firefox version numbers so we have room to grow. size_t preallocatedLength = - 13 + - (spoofOs ? mozilla::ArrayLength(SPOOFED_HTTP_UA_OS) - : mozilla::ArrayLength(SPOOFED_UA_OS)) - - 1 + 5 + 3 + 10 + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + - 2; + 13 + mozilla::ArrayLength(SPOOFED_UA_OS) - 1 + 5 + 3 + 10 + + mozilla::ArrayLength(LEGACY_UA_GECKO_TRAIL) - 1 + 9 + 3 + 2; userAgent.SetCapacity(preallocatedLength); // "Mozilla/5.0 (%s; rv:%d.0) Gecko/%d Firefox/%d.0" userAgent.AssignLiteral("Mozilla/5.0 ("); - - if (spoofOs) { - userAgent.AppendLiteral(SPOOFED_HTTP_UA_OS); - } else { - userAgent.AppendLiteral(SPOOFED_UA_OS); - } - + userAgent.AppendLiteral(SPOOFED_UA_OS); userAgent.AppendLiteral("; rv:" MOZILLA_UAVERSION ") Gecko/"); - #if defined(ANDROID) userAgent.AppendLiteral(MOZILLA_UAVERSION); #else userAgent.AppendLiteral(LEGACY_UA_GECKO_TRAIL); #endif - userAgent.AppendLiteral(" Firefox/" MOZILLA_UAVERSION); MOZ_ASSERT(userAgent.Length() <= preallocatedLength); ===================================== toolkit/components/resistfingerprinting/nsRFPService.h ===================================== @@ -59,14 +59,6 @@ #define SPOOFED_POINTER_INTERFACE MouseEvent_Binding::MOZ_SOURCE_MOUSE -// For the HTTP User-Agent header, we use a simpler set of spoofed values -// that do not reveal the specific desktop platform. -#if defined(MOZ_WIDGET_ANDROID) -# define SPOOFED_HTTP_UA_OS "Android 10; Mobile" -#else -# define SPOOFED_HTTP_UA_OS "Windows NT 10.0; Win64; x64" -#endif - struct JSContext; class nsIChannel; @@ -267,7 +259,7 @@ class nsRFPService final : public nsIObserver, public nsIRFPService { // -------------------------------------------------------------------------- // This method generates the spoofed value of User Agent. - static void GetSpoofedUserAgent(nsACString& userAgent, bool isForHTTPHeader); + static void GetSpoofedUserAgent(nsACString& userAgent); // -------------------------------------------------------------------------- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d8c660… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d8c660… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-bundle-testsuite][main] 2 commits: Bug 40080: Don't archive *.rpm and *.deb files
by morgan (＠morgan) 27 Jan '25

27 Jan '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: ece643c6 by Nicolas Vigier at 2025-01-25T10:18:10+01:00 Bug 40080: Don't archive *.rpm and *.deb files In order to save space, don't archive deb and rpm files. - - - - - abcf9a5a by Nicolas Vigier at 2025-01-25T10:22:25+01:00 Bug 40080: Reduce the number of archived nightly builds In order to avoid filling the disk (see tpo/tpa/team#41992), we reduce the number of days we keep builds from 100 to 30. We're still keeping one build from each of the last 30 weeks and last 12 months. - - - - - 1 changed file: - tools/tb-build-06-start-nightly-build Changes: ===================================== tools/tb-build-06-start-nightly-build ===================================== @@ -44,15 +44,13 @@ then -o -name '*-browser-windows*.exe' \ -o -name '*-browser-macos*.dmg' \ -o -name '*-browser-linux*.tar.xz' \ - -o -name '*-browser*.deb' \ - -o -name '*-browser*.rpm' \ -o -name '*-browser*.apk' \ -o -name '*-browser-debug-symbols-*.tar.xz' \ -o -name 'tor-expert-bundle*.tar.gz' \ \) \ -a -execdir cp -a {} "$dname" \; done - /home/tb-builder/tor-browser-bundle-testsuite/clones/tor-browser-build/tools/prune-old-builds --days 100 --weeks 30 --months 12 ~/tor-browser-builds-archive + /home/tb-builder/tor-browser-bundle-testsuite/clones/tor-browser-build/tools/prune-old-builds --days 30 --weeks 30 --months 12 ~/tor-browser-builds-archive fi # Only clean previous builds if we use more than 20GB View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.6.0esr-14.5-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 23 Jan '25

23 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.6.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: d8c660d5 by Beatriz Rizental at 2025-01-23T19:18:33+01:00 fixup! Add CI for Base Browser Attempt to download MR branch in case fetching fails due to the pipeline running in the parent project context. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -12,7 +12,12 @@ exit 1 fi - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" - - git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - | + if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fi - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} .with-local-repo-pwsh: @@ -33,5 +38,10 @@ exit 1 } - Write-Output "Fetching from remote branch $branchName" - - git fetch origin $branchName + - | + if (! git fetch origin $branchName) { + Write-Output "Fetching failed for branch $branchName from $env:CI_REPOSITORY_URL." + Write-Output "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + git fetch origin "merge-requests/$env:CI_MERGE_REQUEST_IID/head" + } - git checkout origin/$branchName View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d8c660d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d8c660d… You're receiving this email because of your account on gitlab.torproject.org.

1 0