- tbb-commits - lists.torproject.org

[torbutton/master] Bug 17568: Clean up tor-control-port.js
by gk＠torproject.org 07 Dec '15

07 Dec '15

commit 548c10907863257c636e9393babe707fe79a4f40 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Thu Nov 12 16:09:43 2015 -0800 Bug 17568: Clean up tor-control-port.js --- src/modules/tor-control-port.js | 113 ++++++++++++++------------------------- 1 file changed, 41 insertions(+), 72 deletions(-) diff --git a/src/modules/tor-control-port.js b/src/modules/tor-control-port.js index 2b41897..c5010de 100644 --- a/src/modules/tor-control-port.js +++ b/src/modules/tor-control-port.js @@ -209,7 +209,7 @@ io.callbackDispatcher = function () { // __io.matchRepliesToCommands(asyncSend, dispatcher)__. // Takes asyncSend(message), an asynchronous send function, and the callback -// displatcher, and returns a function Promise<response> sendCommand(command). +// dispatcher, and returns a function Promise<response> sendCommand(command). io.matchRepliesToCommands = function (asyncSend, dispatcher) { let commandQueue = [], sendCommand = function (command, replyCallback, errorCallback) { @@ -254,7 +254,7 @@ io.controlSocket = function (host, port, password, onError) { io.onDataFromOnLine( io.onLineFromOnMessage(mainDispatcher.pushMessage)), onError), - // Tor expects any commands to be terminated by CRLF. + // Controllers should send commands terminated by CRLF. writeLine = function (text) { socket.write(text + "\r\n"); }, // Create a sendCommand method from writeLine. sendCommand = io.matchRepliesToCommands(writeLine, mainDispatcher), @@ -371,6 +371,10 @@ utils.listMapData = function (parameterString, listNames) { return dataMap; }; +// __utils.rejectPromise(errorMessage)__. +// Returns a rejected promise with the given error message. +utils.rejectPromise = errorMessage => Promise.reject(new Error(errorMessage)); + // ## info // A namespace for functions related to tor's GETINFO and GETCONF command. let info = info || {}; @@ -387,7 +391,7 @@ let info = info || {}; // or single-line (with a `250-` or `250 ` prefix): // // 250-version=0.2.6.0-alpha-dev (git-b408125288ad6943) -info.keyValueStringsFromMessage = utils.extractor(/^(250\+[\s\S]+?^\.|250[-\ ].+?)$/gmi); +info.keyValueStringsFromMessage = utils.extractor(/^(250\+[\s\S]+?^\.|250[- ].+?)$/gmi); // __info.applyPerLine(transformFunction)__. // Returns a function that splits text into lines, @@ -400,7 +404,7 @@ info.applyPerLine = function (transformFunction) { // __info.routerStatusParser(valueString)__. // Parses a router status entry as, described in -// https://gitweb.torproject.org/torspec.git/blob/HEAD:/dir-spec.txt +// https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt // (search for "router status entry") info.routerStatusParser = function (valueString) { let lines = utils.splitLines(valueString), @@ -418,7 +422,6 @@ info.routerStatusParser = function (valueString) { "v" : data => ({ "version" : data }), "w" : data => utils.listMapData(data, []), "p" : data => ({ "portList" : data.split(",") }), - "m" : data => utils.listMapData(data, []) }[line.charAt(0)]; if (dataFun !== undefined) { objects.push(dataFun(myData)); @@ -448,21 +451,6 @@ info.streamStatusParser = function (text) { "CircuitID", "Target"]); }; -// __info.configTextParser(text)__. -// Parse the output of a `getinfo config-text`. -info.configTextParser = function(text) { - let result = {}; - utils.splitLines(text).map(function(line) { - let [name, value] = utils.splitAtFirst(line, /\s/); - if (name) { - if (!result.hasOwnProperty(name)) result[name] = []; - result[name].push(value); - } - }); - return result; -}; - - // __info.bridgeParser(bridgeLine)__. // Takes a single line from a `getconf bridge` result and returns // a map containing the bridge's type, address, and ID. @@ -488,16 +476,15 @@ info.bridgeParser = function(bridgeLine) { // A map of GETINFO and GETCONF keys to parsing function, which convert // result strings to JavaScript data. info.parsers = { - "version" : utils.identity, - "config-file" : utils.identity, - "config-defaults-file" : utils.identity, - "config-text" : info.configTextParser, "ns/id/" : info.routerStatusParser, - "ns/name/" : info.routerStatusParser, "ip-to-country/" : utils.identity, "circuit-status" : info.applyPerLine(info.circuitStatusParser), - "stream-status" : info.applyPerLine(info.streamStatusParser), - "bridge" : info.bridgeParser + "bridge" : info.bridgeParser, + // Currently unused parsers: + // "ns/name/" : info.routerStatusParser, + // "stream-status" : info.applyPerLine(info.streamStatusParser), + // "version" : utils.identity, + // "config-file" : utils.identity, }; // __info.getParser(key)__. @@ -512,13 +499,14 @@ info.getParser = function(key) { // Converts a key-value string as from GETINFO or GETCONF to a value. info.stringToValue = function (string) { // key should look something like `250+circuit-status=` or `250-circuit-status=...` - // or `250 circuit-status...` - let matchForKey = string.match(/^250[ +-](.+?)=/mi), + // or `250 circuit-status=...` + let matchForKey = string.match(/^250[ +-](.+?)=/), key = matchForKey ? matchForKey[1] : null; if (key === null) return null; - // matchResult finds a single-line result for `250-` or a multi-line one for `250+`. - let matchResult = string.match(/^250[ -].+?=(.*?)$/mi) || - string.match(/^250\+.+?=([\s\S]*?)^\.$/mi), + // matchResult finds a single-line result for `250-` or `250 `, + // or a multi-line one for `250+`. + let matchResult = string.match(/^250[ -].+?=(.*)$/) || + string.match(/^250\+.+?=([\s\S]*?)^\.$/m), // Retrieve the captured group (the text of the value in the key-value pair) valueString = matchResult ? matchResult[1] : null, // Get the parser function for the key found. @@ -538,48 +526,27 @@ info.getMultipleResponseValues = function (message) { .filter(utils.identity); }; -// __info.getInfoMultiple(aControlSocket, keys)__. -// Sends GETINFO for an array of keys. Returns a promise with an array of results. -info.getInfoMultiple = function (aControlSocket, keys) { - /* - if (!(keys instanceof Array)) { - throw new Error("keys argument should be an array"); - } - if (!(onData instanceof Function)) { - throw new Error("onData argument should be a function"); - } - let parsers = keys.map(info.getParser); - if (parsers.indexOf("unknown") !== -1) { - throw new Error("unknown key"); - } - if (parsers.indexOf("not supported") !== -1) { - throw new Error("unsupported key"); - } - */ - return aControlSocket.sendCommand("getinfo " + keys.join(" ")) - .then(info.getMultipleResponseValues); -}; - // __info.getInfo(controlSocket, key)__. // Sends GETINFO for a single key. Returns a promise with the result. info.getInfo = function (aControlSocket, key) { - /* if (!utils.isString(key)) { - throw new Error("key argument should be a string"); - } - if (!(onValue instanceof Function)) { - throw new Error("onValue argument should be a function"); + return utils.rejectPromise("key argument should be a string"); } - */ - return info.getInfoMultiple(aControlSocket, [key]).then(data => data[0]); + return aControlSocket + .sendCommand("getinfo " + key) + .then(response => info.getMultipleResponseValues(response)[0]); }; // __info.getConf(aControlSocket, key)__. // Sends GETCONF for a single key. Returns a promise with the result. info.getConf = function (aControlSocket, key) { - // GETCONF with a single argument returns results that look like - // results from GETINFO with multiple arguments. - // So we can use the same kind of parsing for + // GETCONF with a single argument returns results with + // one or more lines that look like `250[- ]key=value`. + // Any GETCONF lines that contain a single keyword only are currently dropped. + // So we can use similar parsing to that for getInfo. + if (!utils.isString(key)) { + return utils.rejectPromise("key argument should be a string"); + } return aControlSocket.sendCommand("getconf " + key) .then(info.getMultipleResponseValues); }; @@ -594,22 +561,25 @@ let event = event || {}; // data. event.parsers = { "stream" : info.streamStatusParser, - "circ" : info.circuitStatusParser + // Currently unused: + // "circ" : info.circuitStatusParser, }; // __event.messageToData(type, message)__. -// Extract the data from an event. +// Extract the data from an event. Note, at present +// we only extract streams that look like `"650" SP...` event.messageToData = function (type, message) { - let dataText = message.match(/^650 \S+?\s(.*?)$/mi)[1]; + let dataText = message.match(/^650 \S+?\s(.*)/m)[1]; return dataText ? event.parsers[type.toLowerCase()](dataText) : null; }; // __event.watchEvent(controlSocket, type, filter, onData)__. // Watches for a particular type of event. If filter(data) returns true, the event's // data is passed to the onData callback. Returns a zero arg function that -// stops watching the event. +// stops watching the event. Note: we only observe `"650" SP...` events +// currently (no `650+...` or `650-...` events). event.watchEvent = function (controlSocket, type, filter, onData) { - return controlSocket.addNotificationCallback(new RegExp("^650." + type, "i"), + return controlSocket.addNotificationCallback(new RegExp("^650 " + type), function (message) { let data = event.messageToData(type, message); if (filter === null || filter(data)) { @@ -634,7 +604,6 @@ tor.controller = function (host, port, password, onError) { let socket = io.controlSocket(host, port, password, onError), isOpen = true; return { getInfo : key => info.getInfo(socket, key), - getInfoMultiple : keys => info.getInfoMultiple(socket, keys), getConf : key => info.getConf(socket, key), watchEvent : (type, filter, onData) => event.watchEvent(socket, type, filter, onData), @@ -655,8 +624,8 @@ tor.controller = function (host, port, password, onError) { // // Get the controller // let c = controller("127.0.0.1", 9151, "MyPassw0rd", // function (error) { console.log(error.message || error); }); -// // Send command and receive `250` reply or error message -// c.getInfo("ip-to-country/16.16.16.16", console.log); +// // Send command and receive `250` reply or error message in a promise: +// let replyPromise = c.getInfo("ip-to-country/16.16.16.16"); // // Close the controller permanently // c.close(); let controller = function (host, port, password, onError) {

1 0

[tor-browser/tor-browser-38.4.0esr-5.0-1] fixup! Bug #6253: Add canvas image extraction prompt.
by gk＠torproject.org 07 Dec '15

07 Dec '15

commit 9a717351831505dff9b48b579353c043d8531fd6 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Fri Nov 6 16:41:29 2015 -0800 fixup! Bug #6253: Add canvas image extraction prompt. Ensure that third parties are never able to extract canvas image data, even if the same domain has been given permission previously as a first party. Also, refactor slightly to clarify logic of IsImageExtractionAllowed. --- dom/canvas/CanvasUtils.cpp | 179 +++++++++++++++++++++++--------------------- 1 file changed, 95 insertions(+), 84 deletions(-) diff --git a/dom/canvas/CanvasUtils.cpp b/dom/canvas/CanvasUtils.cpp index 9883a52..b3c83f6 100644 --- a/dom/canvas/CanvasUtils.cpp +++ b/dom/canvas/CanvasUtils.cpp @@ -46,99 +46,110 @@ namespace CanvasUtils { // Check site-specific permission and display prompt if appropriate. bool IsImageExtractionAllowed(nsIDocument *aDocument, JSContext *aCx) { - if (!aDocument || !aCx) - return false; + // Don't proceed if we don't have a document or JavaScript context. + if (!aDocument || !aCx) { + return false; + } - nsPIDOMWindow *win = aDocument->GetWindow(); - nsCOMPtr<nsIScriptObjectPrincipal> sop(do_QueryInterface(win)); - if (sop && nsContentUtils::IsSystemPrincipal(sop->GetPrincipal())) - return true; + // Documents with system principal can always extract canvas data. + nsPIDOMWindow *win = aDocument->GetWindow(); + nsCOMPtr<nsIScriptObjectPrincipal> sop(do_QueryInterface(win)); + if (sop && nsContentUtils::IsSystemPrincipal(sop->GetPrincipal())) { + return true; + } - // Don't show canvas prompt for chrome scripts (e.g. Page Inspector) - if (nsContentUtils::ThreadsafeIsCallerChrome()) - return true; + // Always give permission to chrome scripts (e.g. Page Inspector). + if (nsContentUtils::ThreadsafeIsCallerChrome()) { + return true; + } - JS::AutoFilename scriptFile; - unsigned scriptLine = 0; - bool isScriptKnown = false; - if (JS::DescribeScriptedCaller(aCx, &scriptFile, &scriptLine)) { - isScriptKnown = true; - // Don't show canvas prompt for PDF.js - if (scriptFile.get() && - strcmp(scriptFile.get(), "resource://pdf.js/build/pdf.js") == 0) - return true; - } - bool isAllowed = false; - nsCOMPtr<mozIThirdPartyUtil> thirdPartyUtil = - do_GetService(THIRDPARTYUTIL_CONTRACTID); - nsCOMPtr<nsIPermissionManager> permissionManager = - do_GetService(NS_PERMISSIONMANAGER_CONTRACTID); - if (thirdPartyUtil && permissionManager) { - nsCOMPtr<nsIURI> uri; - nsresult rv = thirdPartyUtil->GetFirstPartyURI(NULL, aDocument, - getter_AddRefs(uri)); - uint32_t permission = nsIPermissionManager::UNKNOWN_ACTION; - if (NS_SUCCEEDED(rv)) { - // Allow local files to access canvas data; check content permissions - // for remote pages. - bool isFileURL = false; - (void)uri->SchemeIs("file", &isFileURL); - if (isFileURL) - permission = nsIPermissionManager::ALLOW_ACTION; - else { - rv = permissionManager->TestPermission(uri, - PERMISSION_CANVAS_EXTRACT_DATA, &permission); - } + // Get the document URI and its spec. + nsIURI *docURI = aDocument->GetDocumentURI(); + nsCString docURISpec; + docURI->GetSpec(docURISpec); + + // Allow local files to extract canvas data. + bool isFileURL; + (void) docURI->SchemeIs("file", &isFileURL); + if (isFileURL) { + return true; } - if (NS_SUCCEEDED(rv)) { - isAllowed = (permission == nsIPermissionManager::ALLOW_ACTION); - - if (!isAllowed && (permission != nsIPermissionManager::DENY_ACTION)) { - // Log all attempted canvas access and block access by third parties. - bool isThirdParty = true; - nsIURI *docURI = aDocument->GetDocumentURI(); - rv = thirdPartyUtil->IsThirdPartyURI(uri, docURI, &isThirdParty); - NS_ENSURE_SUCCESS(rv, false); - - nsCString firstPartySpec; - rv = uri->GetSpec(firstPartySpec); - nsCString docSpec; - docURI->GetSpec(docSpec); - nsPrintfCString msg("On %s: blocked access to canvas image data" - " from document %s, ", // L10n - firstPartySpec.get(), docSpec.get()); - if (isScriptKnown && scriptFile.get()) { - msg += nsPrintfCString("script from %s:%u", // L10n - scriptFile.get(), scriptLine); - } else { - msg += nsPrintfCString("unknown script"); // L10n + // Get calling script file and line for logging. + JS::AutoFilename scriptFile; + unsigned scriptLine = 0; + bool isScriptKnown = false; + if (JS::DescribeScriptedCaller(aCx, &scriptFile, &scriptLine)) { + isScriptKnown = true; + // Don't show canvas prompt for PDF.js + if (scriptFile.get() && + strcmp(scriptFile.get(), "resource://pdf.js/build/pdf.js") == 0) { + return true; } - nsCOMPtr<nsIConsoleService> console - (do_GetService(NS_CONSOLESERVICE_CONTRACTID)); - if (console) - console->LogStringMessage(NS_ConvertUTF8toUTF16(msg).get()); - - // Log every canvas access attempt to stdout if debugging: -#ifdef DEBUG - printf("%s\n", msg.get()); -#endif - // Ensure URI is valid after logging, but before trying to notify the - // user: - NS_ENSURE_SUCCESS(rv, false); - - if (!isThirdParty) { - // Send notification so that a prompt is displayed. - nsCOMPtr<nsIObserverService> obs = - mozilla::services::GetObserverService(); - obs->NotifyObservers(win, TOPIC_CANVAS_PERMISSIONS_PROMPT, - NS_ConvertUTF8toUTF16(firstPartySpec).get()); + } + + // Load Third Party Util service. + nsresult rv; + nsCOMPtr<mozIThirdPartyUtil> thirdPartyUtil = + do_GetService(THIRDPARTYUTIL_CONTRACTID, &rv); + NS_ENSURE_SUCCESS(rv, false); + + // Get the First Party URI and its spec. + nsCOMPtr<nsIURI> firstPartyURI; + rv = thirdPartyUtil->GetFirstPartyURI(NULL, aDocument, + getter_AddRefs(firstPartyURI)); + NS_ENSURE_SUCCESS(rv, false); + nsCString firstPartySpec; + firstPartyURI->GetSpec(firstPartySpec); + + // Block all third-party attempts to extract canvas. + bool isThirdParty = true; + rv = thirdPartyUtil->IsThirdPartyURI(firstPartyURI, docURI, &isThirdParty); + NS_ENSURE_SUCCESS(rv, false); + if (isThirdParty) { + nsAutoCString message; + message.AppendPrintf("Blocked third party %s in page %s from extracting canvas data.", + docURISpec.get(), firstPartySpec.get()); + if (isScriptKnown) { + message.AppendPrintf(" %s:%u.", scriptFile.get(), scriptLine); } - } + nsContentUtils::LogMessageToConsole(message.get()); + return false; + } + + // Load Permission Manager service. + nsCOMPtr<nsIPermissionManager> permissionManager = + do_GetService(NS_PERMISSIONMANAGER_CONTRACTID); + NS_ENSURE_SUCCESS(rv, false); + + // Check if the site has permission to extract canvas data. + // Either permit or block extraction if a stored permission setting exists. + uint32_t permission; + rv = permissionManager->TestPermission(firstPartyURI, + PERMISSION_CANVAS_EXTRACT_DATA, &permission); + NS_ENSURE_SUCCESS(rv, false); + if (permission == nsIPermissionManager::ALLOW_ACTION) { + return true; + } else if (permission == nsIPermissionManager::DENY_ACTION) { + return false; } - } - return isAllowed; + // At this point, permission is unknown (nsIPermissionManager::UNKNOWN_ACTION). + nsAutoCString message; + message.AppendPrintf("Blocked %s in page %s from extracting canvas data.", + docURISpec.get(), firstPartySpec.get()); + if (isScriptKnown) { + message.AppendPrintf(" %s:%u.", scriptFile.get(), scriptLine); + } + nsContentUtils::LogMessageToConsole(message.get()); + + // Prompt the user (asynchronous). + nsCOMPtr<nsIObserverService> obs = mozilla::services::GetObserverService(); + obs->NotifyObservers(win, TOPIC_CANVAS_PERMISSIONS_PROMPT, + NS_ConvertUTF8toUTF16(firstPartySpec).get()); + + // We don't extract the image for now -- user may override at prompt. + return false; } void

1 0

[torbutton/master] Bug 17108: Polish about:tor appearance
by gk＠torproject.org 07 Dec '15

07 Dec '15

commit 05c8befab9446cdd6a0bfe7a60a75849a09321da Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Nov 11 13:14:08 2015 -0800 Bug 17108: Polish about:tor appearance Changes include: 0. Logo changed to prettier onion 1. Title changed to "Welcome to Tor Browser" (in purple). 2. Dropped "This browser is configured to use Tor." 3. Normal style for "You are now free to browse the Internet anonymously." 4. Border on input box set to light gray, rounded corners removed 5. Search button image replaced with non-pixellated one 6. Sans-serif text used everywhere 7. Borders on bubbles removed 8. Text color changed to be slightly less black 9. Some text increased a little in size --- src/chrome/content/aboutTor/aboutTor.xhtml | 6 +- src/chrome/content/aboutTor/search.png | Bin 3419 -> 934 bytes src/chrome/content/aboutTor/tor-on.png | Bin 2665 -> 17945 bytes src/chrome/locale/en/aboutTor.dtd | 6 +- src/chrome/skin/aboutTor.css | 88 ++++++++-------------------- 5 files changed, 29 insertions(+), 71 deletions(-) diff --git a/src/chrome/content/aboutTor/aboutTor.xhtml b/src/chrome/content/aboutTor/aboutTor.xhtml index dbfca72..6331997 100644 --- a/src/chrome/content/aboutTor/aboutTor.xhtml +++ b/src/chrome/content/aboutTor/aboutTor.xhtml @@ -249,11 +249,11 @@ function setupDonationBanner() { <div id="torstatus-on-container" class="hideIfTorOff torstatus-container"> <h1>&aboutTor.success.label;</h1> <br/> - <h2 id="success2">&aboutTor.success2.label;</h2> - <br/> <h3 class="hideIfTBBNeedsUpdate">&aboutTor.success3.label;</h3> <br/> - <a id="testTorSettings" href="about:blank">&aboutTor.check.label;</a> + <div style="margin-top: 20px;"> + <a id="testTorSettings" href="about:blank">&aboutTor.check.label;</a> + </div> </div> <div id="torstatus-off-container" class="hideIfTorOn torstatus-container"> <h1>&aboutTor.failure.label;</h1> diff --git a/src/chrome/content/aboutTor/search.png b/src/chrome/content/aboutTor/search.png index 379d094..698a77d 100644 Binary files a/src/chrome/content/aboutTor/search.png and b/src/chrome/content/aboutTor/search.png differ diff --git a/src/chrome/content/aboutTor/tor-on.png b/src/chrome/content/aboutTor/tor-on.png index aa938e1..186fcf1 100644 Binary files a/src/chrome/content/aboutTor/tor-on.png and b/src/chrome/content/aboutTor/tor-on.png differ diff --git a/src/chrome/locale/en/aboutTor.dtd b/src/chrome/locale/en/aboutTor.dtd index 69ef335..17af371 100644 --- a/src/chrome/locale/en/aboutTor.dtd +++ b/src/chrome/locale/en/aboutTor.dtd @@ -6,14 +6,14 @@ <!ENTITY aboutTor.title "About Tor"> -<!ENTITY aboutTor.outOfDateTorOn.label "HOWEVER, this browser is out of date."> +<!ENTITY aboutTor.outOfDateTorOn.label "WARNING: this browser is out of date."> <!ENTITY aboutTor.outOfDateTorOff.label "ALSO, this browser is out of date."> <!ENTITY aboutTor.outOfDate2.label "Click on the onion and then choose Check for Tor Browser Update."> <!ENTITY aboutTor.check.label "Test Tor Network Settings"> -<!ENTITY aboutTor.success.label "Congratulations!"> -<!ENTITY aboutTor.success2.label "This browser is configured to use Tor."> +<!ENTITY aboutTor.success.label "Welcome to Tor Browser"> +<!ENTITY aboutTor.success2.label "Connected to the Tor network."> <!ENTITY aboutTor.success3.label "You are now free to browse the Internet anonymously."> <!ENTITY aboutTor.failure.label "Something Went Wrong!"> <!ENTITY aboutTor.failure2.label "Tor is not working in this browser."> diff --git a/src/chrome/skin/aboutTor.css b/src/chrome/skin/aboutTor.css index 038d470..2776a0e 100644 --- a/src/chrome/skin/aboutTor.css +++ b/src/chrome/skin/aboutTor.css @@ -18,7 +18,7 @@ body { margin: 0px auto; padding: 0px 0px; font-size: 62.5%; - font-family: "Liberation Serif", "Times New Roman", Times, serif; + font-family: "Liberation Sans", Arial, Helvetica, sans-serif; font-weight: normal; color: #4d4d4d; background-color: #FFFFFF; @@ -40,7 +40,6 @@ body[toron] { right: 6px; height: 30px; width: 200px; - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; font-size: 1.4em; white-space: pre-wrap; text-align: right; @@ -56,6 +55,8 @@ body[toron] #torstatus-image { height: 128px; width: 128px; background-image: url('chrome://torbutton/content/aboutTor/tor-off.png'); + background-repeat: no-repeat; + background-position: center; z-index: -1; } @@ -127,8 +128,8 @@ body:not([toron]) .hideIfTorOff { display: none; } -body[toron] .top h1, body[toron] .top h2 { - color: #008000; +body[toron] .top h1 { + color: #600060; } div.hideIfTorIsUpToDate, @@ -151,7 +152,7 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { } .top h1 { - font-size: 4.14em; + font-size: 4.00em; font-weight: bold; margin-bottom: 5px; } @@ -162,14 +163,10 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { font-weight: normal; } -.top #success2 { - margin-bottom: 5px; -} - .top h3 { - font-size: 2.04em; - font-style: italic; + font-size: 1.8em; font-weight: normal; + color: #3B503C; } #middle { @@ -179,6 +176,7 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { border-spacing: 100px 0px; border-collapse: separate; text-align: center; + font-size: 1.6em; } .bubbleRow { @@ -189,61 +187,30 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { display: table-cell; width: 50%; height: 100%; - padding: 10px 10px; - color: #222222; + padding: 20px 30px; + color: #3B503C; background-color: #FFFFFF; - border: 1px solid #008000; + border: none; border-radius: 16px; - text-align: center; + text-align: start; vertical-align: top; } #middle h1 { - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; - font-size: 1.9em; + font-size: 1.2em; margin-bottom: 10px; } -#middle h2 { - font-size: 1.4em; - margin: 9px 0px 3px 0px; - font-weight: 500; -} - -#middle h6 { - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; - font-size: 1em; - line-height: 1em; - font-style: italic; - font-weight: normal; - padding-top: 10px; -} - -#middle p { - font-size: 1.35em; - text-align: left; -} - -#middle p:-moz-dir(rtl) { - text-align: right; -} - -#middle a { - font-size: 1.35em; -} - #middle a.tips { display: block; - margin-top: 1.35em; + margin-top: 1.6em; } #middle ul { - text-align: left; padding: 5px 0 0 22px; } #middle ul:-moz-dir(rtl) { - text-align: right; padding: 5px 22px 0 0; } @@ -252,14 +219,14 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { } #bottom { - margin: 0px auto; + margin: 30px 0px 0px 0px; padding-bottom: 40px; float: left; } #bottom p { - font-size: 1.8em; - text-align: justify; + font-size: 1.6em; + text-align: start; margin: 10px 125px 0px 125px; } @@ -276,7 +243,6 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { #bottom h4 { margin-top: 50px; line-height: 1em; - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; font-size: 1em; font-weight: normal; text-align: center; @@ -285,7 +251,6 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { #bottom p.lang { max-width: 620px; margin: 10px auto; - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; font-size: 1em; font-weight: normal; text-align: center; @@ -301,7 +266,6 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { padding-top: 5px; font-size: 12px; font-weight: normal; - font-family: "Liberation Sans", Arial, Helvetica, sans-serif; text-align: center; } @@ -312,7 +276,7 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { } #sbutton input { - height: 32px; + height: 34px; width: 33px; border: 0; background: url('chrome://torbutton/content/aboutTor/search.png') no-repeat top left; @@ -321,26 +285,20 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { /* #sxw is the container div for the search field and button */ #sxw { - border-top: rgb(31,119,45) solid 1px; - border-left: rgb(31,119,45) solid 1px; - border-bottom: rgb(94,213,99) solid 1px; - border-right: none; - border-radius: 3px 0 0 3px; - box-shadow: 0 1px 2px 0 rgba(0,0,0,0.2); - border-top-left-radius: 3px 3px; - border-bottom-left-radius: 3px 3px; + border: none; } /* #sx is the search input (text) field */ #sx { + border-color: lightgray; + border-style: solid; + border-width: 1px 0px 1px 1px; width: 350px; min-height: 23px; padding: 4px 6px 5px 6px; margin: 0; outline: none; color: #222; - border: none; - font-family: "Segoe UI","Arial",sans-serif; font-size: 18px; }

1 0

[torbutton/maint-1.9.3] Bug 17565: Tor fundraising campaign donation banner
by gk＠torproject.org 05 Dec '15

05 Dec '15

commit ddf8ea3503fc29a601baf4c77d0cbe96391e8fee Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Sat Nov 21 12:12:55 2015 -0800 Bug 17565: Tor fundraising campaign donation banner --- src/chrome/content/aboutTor/aboutTor.xhtml | 84 ++++++++++++++++++-- src/chrome/content/aboutTor/donation-banner-cd.jpg | Bin 0 -> 64622 bytes src/chrome/content/aboutTor/donation-banner-lp.jpg | Bin 0 -> 68990 bytes src/chrome/content/aboutTor/donation-banner-rd.jpg | Bin 0 -> 63095 bytes src/chrome/locale/en/aboutTor.dtd | 3 + src/chrome/locale/en/aboutTor.properties | 12 +++ src/chrome/skin/aboutTor.css | 75 +++++++++++++++++ 7 files changed, 169 insertions(+), 5 deletions(-) diff --git a/src/chrome/content/aboutTor/aboutTor.xhtml b/src/chrome/content/aboutTor/aboutTor.xhtml index 0991ebe..dbfca72 100644 --- a/src/chrome/content/aboutTor/aboutTor.xhtml +++ b/src/chrome/content/aboutTor/aboutTor.xhtml @@ -23,10 +23,16 @@ href="chrome://torbutton/skin/aboutTor.css"/> <script type="text/javascript;version=1.7"> <![CDATA[ +let kPropertiesURL = "chrome://torbutton/locale/aboutTor.properties"; +Components.utils.import("resource://gre/modules/Services.jsm"); +let gStringBundle = Services.strings.createBundle(kPropertiesURL); + function onLoad() { insertPropertyStrings(); + setupDonationBanner(); + document.addEventListener("AboutTorAdjustArrow", function() { adjustToolbarIconArrow(); }, false); @@ -144,10 +150,6 @@ function adjustToolbarIconArrow() function insertPropertyStrings() { try { - let kPropertiesURL = "chrome://torbutton/locale/aboutTor.properties"; - - Components.utils.import("resource://gre/modules/Services.jsm"); - let gStringBundle = Services.strings.createBundle(kPropertiesURL); let s1 = gStringBundle.GetStringFromName("aboutTor.searchDC.privacy.link"); let s2 = gStringBundle.GetStringFromName("aboutTor.searchDC.search.link"); let result = gStringBundle.formatStringFromName("aboutTor.searchDC.privacy", @@ -165,11 +167,83 @@ window.addEventListener("pageshow", function() { document.dispatchEvent(evt); }); +// Donation banner constants +let gBannerAlternates = ["lp", "cd", "rd"], + gBannerSuffixes = ["quote", "who", "speciality"], + populateBannerText = (suffix, alternate) => + document.getElementById("donation-banner-" + suffix).innerHTML + = gStringBundle.GetStringFromName("aboutTor.donationBanner." + + alternate + "." + suffix); + +// This function takes care of the donation banner. +function setupDonationBanner() { + try { + // Only show banner for US English + let browserLocale = Services.prefs.getCharPref("general.useragent.locale"); + if (browserLocale !== "en-US") { + return; + } + // Only show banner until 2016 Jan 25. + let now = new Date(); + let expiration = new Date(2016,0,26); + if (now > expiration) { + return; + } + // Only show banner 10 times. + let showCountPref = "extensions.torbutton.donation_banner.shown_count"; + if (Services.prefs.prefHasUserValue(showCountPref)) { + count = Services.prefs.getIntPref(showCountPref); + } else { + count = 0; + } + if (count >= 10) { + return; + } + Services.prefs.setIntPref(showCountPref, count+1); + + // Decide which champion we are using. + let alternate = gBannerAlternates[ + Math.floor(Math.random() * gBannerAlternates.length)]; + // Show the champion. + document.getElementById("donation-banner-image").src = + "chrome://torbutton/content/aboutTor/donation-banner-" + alternate + ".jpg"; + // Populate banner with associated text. + for (let suffix of gBannerSuffixes) { + populateBannerText(suffix, alternate); + } + } catch (e) { + // Something has gone wrong! Don't show the banner, and don't propagate + // any errors that will interfere with other code. + return; + } + // Now we can show the banner. + document.getElementById("donation-banner").style.display = "inline"; +} ]]> </script> </head> <body dir="&locale.dir;" onload="onLoad();"> -<div id="torstatus" class="top"> + + <div id="donation-banner" class="top"> + <a href="https://www.torproject.org/donate/donate-tbb"> + <div id="donation-banner-inner"> + <img id="donation-banner-image" width="700" /> + <div id="donation-banner-text"> + <div id="donation-banner-quote"></div> + <div id="donation-banner-credit"> + <div id="donation-banner-who"></div> + <div id="donation-banner-speciality"></div> + </div> + </div> + <div id="donation-banner-plea">&aboutTor.donate.supportTor;</div> + </div> + </a> + <a href="https://www.torproject.org/donate/donate-tbb"> + <div id="donate-button">&aboutTor.donate.donate;</div> + </a> + </div> + + <div id="torstatus" class="top"> <div id="torstatus-version"/> <div id="torstatus-image"/> <div id="torstatus-on-container" class="hideIfTorOff torstatus-container"> diff --git a/src/chrome/content/aboutTor/donation-banner-cd.jpg b/src/chrome/content/aboutTor/donation-banner-cd.jpg new file mode 100644 index 0000000..522f950 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-cd.jpg differ diff --git a/src/chrome/content/aboutTor/donation-banner-lp.jpg b/src/chrome/content/aboutTor/donation-banner-lp.jpg new file mode 100644 index 0000000..e807679 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-lp.jpg differ diff --git a/src/chrome/content/aboutTor/donation-banner-rd.jpg b/src/chrome/content/aboutTor/donation-banner-rd.jpg new file mode 100644 index 0000000..94e59c7 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-rd.jpg differ diff --git a/src/chrome/locale/en/aboutTor.dtd b/src/chrome/locale/en/aboutTor.dtd index b923233..69ef335 100644 --- a/src/chrome/locale/en/aboutTor.dtd +++ b/src/chrome/locale/en/aboutTor.dtd @@ -47,3 +47,6 @@ <!ENTITY aboutTor.footer.label "The Tor Project is a US 501(c)(3) non-profit dedicated to the research, development, and education of online anonymity and privacy."> <!ENTITY aboutTor.learnMore.label "Learn more about The Tor Project »"> <!ENTITY aboutTor.learnMore.link "https://www.torproject.org/about/overview.html.en"> + +<!ENTITY aboutTor.donate.donate "Donate"> +<!ENTITY aboutTor.donate.supportTor "Please support Tor!"> diff --git a/src/chrome/locale/en/aboutTor.properties b/src/chrome/locale/en/aboutTor.properties index d607324..10f09a1 100644 --- a/src/chrome/locale/en/aboutTor.properties +++ b/src/chrome/locale/en/aboutTor.properties @@ -19,3 +19,15 @@ aboutTor.searchDC.privacy=Search <a href="%1$S">securely</a> with <a href="%2$S" aboutTor.searchDC.privacy.link=https://disconnect.me/privacy # The following string is a link which replaces %2$S above. aboutTor.searchDC.search.link=https://search.disconnect.me/ + +aboutTor.donationBanner.lp.who=— Laura Poitras +aboutTor.donationBanner.lp.quote=Edward Snowden would not have been able to contact me without Tor and other free software encryption projects. Tor is an essential tool, and it needs our support. +aboutTor.donationBanner.lp.speciality=Oscar-Winning Documentary Filmmaker, <i>CitizenFour</i> + +aboutTor.donationBanner.cd.who=— Cory Doctorow +aboutTor.donationBanner.cd.quote=Privacy and anonymity matter to all of us. +aboutTor.donationBanner.cd.speciality= Novelist, technology activist, co-editor of Boing Boing + +aboutTor.donationBanner.rd.who=— Roger Dingledine +aboutTor.donationBanner.rd.quote=Please help the strongest privacy tool in the world become more sustainable! +aboutTor.donationBanner.rd.speciality=Founder, Acting Executive Director of the Tor Project diff --git a/src/chrome/skin/aboutTor.css b/src/chrome/skin/aboutTor.css index ab8dba8..038d470 100644 --- a/src/chrome/skin/aboutTor.css +++ b/src/chrome/skin/aboutTor.css @@ -344,3 +344,78 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { font-size: 18px; } +#donation-banner { + margin: 0px auto; + position: relative; + width: 700px; + display: none; +} + +#donation-banner-inner { + margin: 0px auto; + position: relative; + text-align: left; + width: 700px; + z-index: -1; +} + +#donation-banner-text { + height: 120px; + left: 245px; + position: absolute; + top: 23px; + width: 420px; +} + +#donation-banner-quote { + color: darkgreen; + font-size: 18px; + text-align: start; + white-space: normal; +} + +#donation-banner-credit { + color: rgb(17, 17, 17); + padding: 10px; + position: absolute; +} + +#donation-banner-who { + font-size: 19px; + font-style: bold; +} + +#donation-banner-speciality { + font-size: 13px; + text-transform: uppercase; +} + +#donation-banner-plea { + background-color: yellow; + font-family: sans-serif; + font-size: 20px; + color: darkgreen; + left: 250px; + padding: 10px; + position: absolute; + top: 144px; +} + +#donate-button { + background-color: green; + border-radius: 5px; + color: white; + font-family: sans-serif; + font-size: 20px; + left: 600px; + padding: 10px; + position: absolute; + text-align: center; + top: 153px; + vertical-align: middle; + width: 110px; +} + +#donate-button:hover { + filter: brightness(1.2); +}

1 0

[torbutton/master] Bug 17565: Tor fundraising campaign donation banner
by gk＠torproject.org 05 Dec '15

05 Dec '15

commit 5623a3f4ff415eff980b03998b3eff2caf433906 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Sat Nov 21 12:12:55 2015 -0800 Bug 17565: Tor fundraising campaign donation banner --- src/chrome/content/aboutTor/aboutTor.xhtml | 84 ++++++++++++++++++-- src/chrome/content/aboutTor/donation-banner-cd.jpg | Bin 0 -> 64622 bytes src/chrome/content/aboutTor/donation-banner-lp.jpg | Bin 0 -> 68990 bytes src/chrome/content/aboutTor/donation-banner-rd.jpg | Bin 0 -> 63095 bytes src/chrome/locale/en/aboutTor.dtd | 3 + src/chrome/locale/en/aboutTor.properties | 12 +++ src/chrome/skin/aboutTor.css | 75 +++++++++++++++++ 7 files changed, 169 insertions(+), 5 deletions(-) diff --git a/src/chrome/content/aboutTor/aboutTor.xhtml b/src/chrome/content/aboutTor/aboutTor.xhtml index 0991ebe..dbfca72 100644 --- a/src/chrome/content/aboutTor/aboutTor.xhtml +++ b/src/chrome/content/aboutTor/aboutTor.xhtml @@ -23,10 +23,16 @@ href="chrome://torbutton/skin/aboutTor.css"/> <script type="text/javascript;version=1.7"> <![CDATA[ +let kPropertiesURL = "chrome://torbutton/locale/aboutTor.properties"; +Components.utils.import("resource://gre/modules/Services.jsm"); +let gStringBundle = Services.strings.createBundle(kPropertiesURL); + function onLoad() { insertPropertyStrings(); + setupDonationBanner(); + document.addEventListener("AboutTorAdjustArrow", function() { adjustToolbarIconArrow(); }, false); @@ -144,10 +150,6 @@ function adjustToolbarIconArrow() function insertPropertyStrings() { try { - let kPropertiesURL = "chrome://torbutton/locale/aboutTor.properties"; - - Components.utils.import("resource://gre/modules/Services.jsm"); - let gStringBundle = Services.strings.createBundle(kPropertiesURL); let s1 = gStringBundle.GetStringFromName("aboutTor.searchDC.privacy.link"); let s2 = gStringBundle.GetStringFromName("aboutTor.searchDC.search.link"); let result = gStringBundle.formatStringFromName("aboutTor.searchDC.privacy", @@ -165,11 +167,83 @@ window.addEventListener("pageshow", function() { document.dispatchEvent(evt); }); +// Donation banner constants +let gBannerAlternates = ["lp", "cd", "rd"], + gBannerSuffixes = ["quote", "who", "speciality"], + populateBannerText = (suffix, alternate) => + document.getElementById("donation-banner-" + suffix).innerHTML + = gStringBundle.GetStringFromName("aboutTor.donationBanner." + + alternate + "." + suffix); + +// This function takes care of the donation banner. +function setupDonationBanner() { + try { + // Only show banner for US English + let browserLocale = Services.prefs.getCharPref("general.useragent.locale"); + if (browserLocale !== "en-US") { + return; + } + // Only show banner until 2016 Jan 25. + let now = new Date(); + let expiration = new Date(2016,0,26); + if (now > expiration) { + return; + } + // Only show banner 10 times. + let showCountPref = "extensions.torbutton.donation_banner.shown_count"; + if (Services.prefs.prefHasUserValue(showCountPref)) { + count = Services.prefs.getIntPref(showCountPref); + } else { + count = 0; + } + if (count >= 10) { + return; + } + Services.prefs.setIntPref(showCountPref, count+1); + + // Decide which champion we are using. + let alternate = gBannerAlternates[ + Math.floor(Math.random() * gBannerAlternates.length)]; + // Show the champion. + document.getElementById("donation-banner-image").src = + "chrome://torbutton/content/aboutTor/donation-banner-" + alternate + ".jpg"; + // Populate banner with associated text. + for (let suffix of gBannerSuffixes) { + populateBannerText(suffix, alternate); + } + } catch (e) { + // Something has gone wrong! Don't show the banner, and don't propagate + // any errors that will interfere with other code. + return; + } + // Now we can show the banner. + document.getElementById("donation-banner").style.display = "inline"; +} ]]> </script> </head> <body dir="&locale.dir;" onload="onLoad();"> -<div id="torstatus" class="top"> + + <div id="donation-banner" class="top"> + <a href="https://www.torproject.org/donate/donate-tbb"> + <div id="donation-banner-inner"> + <img id="donation-banner-image" width="700" /> + <div id="donation-banner-text"> + <div id="donation-banner-quote"></div> + <div id="donation-banner-credit"> + <div id="donation-banner-who"></div> + <div id="donation-banner-speciality"></div> + </div> + </div> + <div id="donation-banner-plea">&aboutTor.donate.supportTor;</div> + </div> + </a> + <a href="https://www.torproject.org/donate/donate-tbb"> + <div id="donate-button">&aboutTor.donate.donate;</div> + </a> + </div> + + <div id="torstatus" class="top"> <div id="torstatus-version"/> <div id="torstatus-image"/> <div id="torstatus-on-container" class="hideIfTorOff torstatus-container"> diff --git a/src/chrome/content/aboutTor/donation-banner-cd.jpg b/src/chrome/content/aboutTor/donation-banner-cd.jpg new file mode 100644 index 0000000..522f950 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-cd.jpg differ diff --git a/src/chrome/content/aboutTor/donation-banner-lp.jpg b/src/chrome/content/aboutTor/donation-banner-lp.jpg new file mode 100644 index 0000000..e807679 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-lp.jpg differ diff --git a/src/chrome/content/aboutTor/donation-banner-rd.jpg b/src/chrome/content/aboutTor/donation-banner-rd.jpg new file mode 100644 index 0000000..94e59c7 Binary files /dev/null and b/src/chrome/content/aboutTor/donation-banner-rd.jpg differ diff --git a/src/chrome/locale/en/aboutTor.dtd b/src/chrome/locale/en/aboutTor.dtd index b923233..69ef335 100644 --- a/src/chrome/locale/en/aboutTor.dtd +++ b/src/chrome/locale/en/aboutTor.dtd @@ -47,3 +47,6 @@ <!ENTITY aboutTor.footer.label "The Tor Project is a US 501(c)(3) non-profit dedicated to the research, development, and education of online anonymity and privacy."> <!ENTITY aboutTor.learnMore.label "Learn more about The Tor Project »"> <!ENTITY aboutTor.learnMore.link "https://www.torproject.org/about/overview.html.en"> + +<!ENTITY aboutTor.donate.donate "Donate"> +<!ENTITY aboutTor.donate.supportTor "Please support Tor!"> diff --git a/src/chrome/locale/en/aboutTor.properties b/src/chrome/locale/en/aboutTor.properties index d607324..10f09a1 100644 --- a/src/chrome/locale/en/aboutTor.properties +++ b/src/chrome/locale/en/aboutTor.properties @@ -19,3 +19,15 @@ aboutTor.searchDC.privacy=Search <a href="%1$S">securely</a> with <a href="%2$S" aboutTor.searchDC.privacy.link=https://disconnect.me/privacy # The following string is a link which replaces %2$S above. aboutTor.searchDC.search.link=https://search.disconnect.me/ + +aboutTor.donationBanner.lp.who=— Laura Poitras +aboutTor.donationBanner.lp.quote=Edward Snowden would not have been able to contact me without Tor and other free software encryption projects. Tor is an essential tool, and it needs our support. +aboutTor.donationBanner.lp.speciality=Oscar-Winning Documentary Filmmaker, <i>CitizenFour</i> + +aboutTor.donationBanner.cd.who=— Cory Doctorow +aboutTor.donationBanner.cd.quote=Privacy and anonymity matter to all of us. +aboutTor.donationBanner.cd.speciality= Novelist, technology activist, co-editor of Boing Boing + +aboutTor.donationBanner.rd.who=— Roger Dingledine +aboutTor.donationBanner.rd.quote=Please help the strongest privacy tool in the world become more sustainable! +aboutTor.donationBanner.rd.speciality=Founder, Acting Executive Director of the Tor Project diff --git a/src/chrome/skin/aboutTor.css b/src/chrome/skin/aboutTor.css index ab8dba8..038d470 100644 --- a/src/chrome/skin/aboutTor.css +++ b/src/chrome/skin/aboutTor.css @@ -344,3 +344,78 @@ body .top div.hideIfTorIsUpToDate h1.hideIfTorOff { font-size: 18px; } +#donation-banner { + margin: 0px auto; + position: relative; + width: 700px; + display: none; +} + +#donation-banner-inner { + margin: 0px auto; + position: relative; + text-align: left; + width: 700px; + z-index: -1; +} + +#donation-banner-text { + height: 120px; + left: 245px; + position: absolute; + top: 23px; + width: 420px; +} + +#donation-banner-quote { + color: darkgreen; + font-size: 18px; + text-align: start; + white-space: normal; +} + +#donation-banner-credit { + color: rgb(17, 17, 17); + padding: 10px; + position: absolute; +} + +#donation-banner-who { + font-size: 19px; + font-style: bold; +} + +#donation-banner-speciality { + font-size: 13px; + text-transform: uppercase; +} + +#donation-banner-plea { + background-color: yellow; + font-family: sans-serif; + font-size: 20px; + color: darkgreen; + left: 250px; + padding: 10px; + position: absolute; + top: 144px; +} + +#donate-button { + background-color: green; + border-radius: 5px; + color: white; + font-family: sans-serif; + font-size: 20px; + left: 600px; + padding: 10px; + position: absolute; + text-align: center; + top: 153px; + vertical-align: middle; + width: 110px; +} + +#donate-button:hover { + filter: brightness(1.2); +}

1 0

[torbutton/master] Bug 16940: After update, load local change notes.
by gk＠torproject.org 25 Nov '15

25 Nov '15

commit 9b800ffc669f7eb7dd6203a24aa85a39b5edd154 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Thu Nov 19 10:13:11 2015 -0500 Bug 16940: After update, load local change notes. Include the localizable strings for the about:tbupdate page in Torbutton. --- src/chrome.manifest | 3 +++ src/chrome/locale/en/aboutTBUpdate.dtd | 6 ++++++ trans_tools/import-translations.sh | 1 + 3 files changed, 10 insertions(+) diff --git a/src/chrome.manifest b/src/chrome.manifest index 1d3efb4..30aa2ff 100644 --- a/src/chrome.manifest +++ b/src/chrome.manifest @@ -12,6 +12,9 @@ override chrome://branding/locale/brand.dtd chrome://torbutton/locale/brand.dtd override chrome://branding/locale/brand.properties chrome://torbutton/locale/brand.properties overlay chrome://browser/content/aboutDialog.xul chrome://torbutton/content/aboutDialog.xul +# Strings for the about:tbupdate page +override chrome://browser/locale/aboutTBUpdate.dtd chrome://torbutton/locale/aboutTBUpdate.dtd + locale torbutton af chrome/locale/af/ locale torbutton ak chrome/locale/ak/ locale torbutton am chrome/locale/am/ diff --git a/src/chrome/locale/en/aboutTBUpdate.dtd b/src/chrome/locale/en/aboutTBUpdate.dtd new file mode 100644 index 0000000..37567bd --- /dev/null +++ b/src/chrome/locale/en/aboutTBUpdate.dtd @@ -0,0 +1,6 @@ +<!ENTITY aboutTBUpdate.title "Tor Browser Update"> +<!ENTITY aboutTBUpdate.updated "Tor Browser has been updated."> +<!ENTITY aboutTBUpdate.linkPrefix "For the most up-to-date information about this release, "> +<!ENTITY aboutTBUpdate.linkLabel "visit our website"> +<!ENTITY aboutTBUpdate.linkSuffix "."> +<!ENTITY aboutTBUpdate.changeLogHeading "Changelog:"> diff --git a/trans_tools/import-translations.sh b/trans_tools/import-translations.sh index 494e64f..cfaa05c 100755 --- a/trans_tools/import-translations.sh +++ b/trans_tools/import-translations.sh @@ -17,6 +17,7 @@ LOCALE_DIR=../src/chrome/locale FILEMAP=( "aboutDialog.dtd:torbutton-aboutdialogdtd" "aboutTor.dtd:abouttor-homepage" "aboutTor.properties:torbutton-abouttorproperties" + "aboutTBUpdate.dtd:torbutton-abouttbupdatedtd" "brand.dtd:torbutton-branddtd" "brand.properties:torbutton-brandproperties" "torbutton.dtd:torbutton-torbuttondtd"

1 0

[tor-browser/tor-browser-38.4.0esr-5.5-1] Bug 16940: After update, load local change notes.
by gk＠torproject.org 25 Nov '15

25 Nov '15

commit 4a726fc8a675c0882cbfba2514deb32b53ade2ab Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Nov 25 11:36:20 2015 -0500 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). --- .../base/content/abouttbupdate/aboutTBUpdate.css | 34 +++++++++++ .../base/content/abouttbupdate/aboutTBUpdate.js | 10 +++ .../base/content/abouttbupdate/aboutTBUpdate.xhtml | 34 +++++++++++ .../content/abouttbupdate/aboutTBUpdateLogo.png | Bin 0 -> 23266 bytes browser/base/content/browser.js | 14 ++++- browser/base/content/content.js | 64 ++++++++++++++++++++ browser/base/jar.mn | 8 ++- browser/components/about/AboutRedirector.cpp | 8 +++ browser/components/build/nsModule.cpp | 3 + browser/components/nsBrowserContentHandler.js | 12 ++++ .../locales/en-US/chrome/browser/aboutTBUpdate.dtd | 6 ++ browser/locales/jar.mn | 3 + 12 files changed, 194 insertions(+), 2 deletions(-) diff --git a/browser/base/content/abouttbupdate/aboutTBUpdate.css b/browser/base/content/abouttbupdate/aboutTBUpdate.css new file mode 100644 index 0000000..489c9d2 --- /dev/null +++ b/browser/base/content/abouttbupdate/aboutTBUpdate.css @@ -0,0 +1,34 @@ +body { + font-family: sans-serif; + font-size: 110%; + background-image: -moz-linear-gradient(top, #ffffff, #ffffff 10%, #d5ffd5 50%, #d5ffd5); + background-attachment: fixed; + background-size: 100% 100%; +} + +#logo { + background-image: url("chrome://browser/content/abouttbupdate/aboutTBUpdateLogo.png"); + height: 128px; + width: 128px; + margin: 20px; + float: left; +} + +#msg { + margin-top: 50px; + float: left; +} + +#msg-updated { + font-size: 120%; + margin-bottom: 20px; +} + +#changelog-container { + margin: 0px 20px 20px 20px; +} + +#changelog { + margin-left: 20px; + white-space: pre; +} diff --git a/browser/base/content/abouttbupdate/aboutTBUpdate.js b/browser/base/content/abouttbupdate/aboutTBUpdate.js new file mode 100644 index 0000000..8243647 --- /dev/null +++ b/browser/base/content/abouttbupdate/aboutTBUpdate.js @@ -0,0 +1,10 @@ +// Copyright (c) 2015, The Tor Project, Inc. +// See LICENSE for licensing information. +// +// vim: set sw=2 sts=2 ts=8 et syntax=javascript: + +function init() +{ + let event = new CustomEvent("AboutTBUpdateLoad", { bubbles: true }); + document.dispatchEvent(event); +} diff --git a/browser/base/content/abouttbupdate/aboutTBUpdate.xhtml b/browser/base/content/abouttbupdate/aboutTBUpdate.xhtml new file mode 100644 index 0000000..3a29e0c --- /dev/null +++ b/browser/base/content/abouttbupdate/aboutTBUpdate.xhtml @@ -0,0 +1,34 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<!DOCTYPE html [ + <!ENTITY % htmlDTD + PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" + "DTD/xhtml1-strict.dtd"> + %htmlDTD; + <!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd"> + %globalDTD; + <!ENTITY % tbUpdateDTD SYSTEM "chrome://browser/locale/aboutTBUpdate.dtd"> + %tbUpdateDTD; +]> + +<html xmlns="http://www.w3.org/1999/xhtml"> +<head> + <title>&aboutTBUpdate.title;</title> + <link rel="stylesheet" type="text/css" + href="chrome://browser/content/abouttbupdate/aboutTBUpdate.css"/> + <script src="chrome://browser/content/abouttbupdate/aboutTBUpdate.js" + type="text/javascript;version=1.7"/> +</head> +<body dir="&locale.dir;" onload="init()"> +<div id="logo"/> +<div id="msg"> +<div id="msg-updated">&aboutTBUpdate.updated;</div> +<div>&aboutTBUpdate.linkPrefix;<a id="infolink">&aboutTBUpdate.linkLabel;</a>&aboutTBUpdate.linkSuffix; +</div> +</div> +<br clear="all"/> +<div id="changelog-container">&aboutTBUpdate.changeLogHeading; +<div id="changelog"></div> +</div> +</body> +</html> diff --git a/browser/base/content/abouttbupdate/aboutTBUpdateLogo.png b/browser/base/content/abouttbupdate/aboutTBUpdateLogo.png new file mode 100644 index 0000000..be5cae9 Binary files /dev/null and b/browser/base/content/abouttbupdate/aboutTBUpdateLogo.png differ diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index baddc59..815f018 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -216,6 +216,9 @@ XPCOMUtils.defineLazyModuleGetter(this, "ReaderParent", let gInitialPages = [ "about:tor", +#ifdef TOR_BROWSER_UPDATE + "about:tbupdate", +#endif "about:blank", "about:newtab", "about:home", @@ -2354,7 +2357,11 @@ function URLBarSetURI(aURI) { // Replace initial page URIs with an empty string // only if there's no opener (bug 370555). // Bug 863515 - Make content.opener checks work in electrolysis. +#ifdef TOR_BROWSER_UPDATE + if (gInitialPages.indexOf(uri.spec.split('?')[0]) != -1) +#else if (gInitialPages.indexOf(uri.spec) != -1) +#endif value = !gMultiProcessBrowser && content.opener ? uri.spec : ""; else value = losslessDecodeURI(uri); @@ -6951,8 +6958,13 @@ var gIdentityHandler = { // Chrome URIs however get special treatment. Some chrome URIs are // whitelisted to provide a positive security signal to the user. - let whitelist = /^about:(accounts|addons|app-manager|config|crashes|customizing|downloads|healthreport|home|license|newaddon|permissions|preferences|privatebrowsing|rights|sessionrestore|support|welcomeback)/i; +#ifdef TOR_BROWSER_UPDATE + let whitelist = /^about:(accounts|addons|app-manager|config|crashes|customizing|downloads|healthreport|home|license|newaddon|permissions|preferences|privatebrowsing|rights|sessionrestore|support|welcomeback|tor|tbupdate)/i; + let isChromeUI = uri.schemeIs("about") && whitelist.test(uri.spec.split('?')[0]); +#else + let whitelist = /^about:(accounts|addons|app-manager|config|crashes|customizing|downloads|healthreport|home|license|newaddon|permissions|preferences|privatebrowsing|rights|sessionrestore|support|welcomeback|tor)/i; let isChromeUI = uri.schemeIs("about") && whitelist.test(uri.spec); +#endif if (isChromeUI) { this.setMode(this.IDENTITY_MODE_CHROMEUI); } else if (unknown) { diff --git a/browser/base/content/content.js b/browser/base/content/content.js index 14f21fc..fd87352 100644 --- a/browser/base/content/content.js +++ b/browser/base/content/content.js @@ -11,6 +11,9 @@ Cu.import("resource:///modules/ContentWebRTC.jsm"); Cu.import("resource:///modules/ContentObservers.jsm"); Cu.import("resource://gre/modules/InlineSpellChecker.jsm"); Cu.import("resource://gre/modules/InlineSpellCheckerContent.jsm"); +#ifdef TOR_BROWSER_UPDATE +Cu.import("resource://gre/modules/NetUtil.jsm"); +#endif XPCOMUtils.defineLazyModuleGetter(this, "E10SUtils", "resource:///modules/E10SUtils.jsm"); @@ -560,6 +563,67 @@ let AboutReaderListener = { }; AboutReaderListener.init(); +#ifdef TOR_BROWSER_UPDATE +let AboutTBUpdateListener = { + init: function(chromeGlobal) { + chromeGlobal.addEventListener('AboutTBUpdateLoad', this, false, true); + }, + + get isAboutTBUpdate() { + return content.document.documentURI.split('?')[0].toLowerCase() + == "about:tbupdate"; + }, + + handleEvent: function(aEvent) { + if (this.isAboutTBUpdate && (aEvent.type == "AboutTBUpdateLoad")) + this.onPageLoad(); + }, + + onPageLoad: function() { + let doc = content.document; + doc.getElementById("infolink").setAttribute("href", this.getPostUpdateURL()); + doc.getElementById("changelog").textContent = this.getChangeLogText(); + }, + + // Extract the post update URL from this page's query string. + getPostUpdateURL: function() { + let idx = content.document.documentURI.indexOf('?'); + if (idx > 0) + return decodeURIComponent(content.document.documentURI.substring(idx+1)); + + // No query string: use the default URL. + return Services.urlFormatter.formatURLPref("startup.homepage_override_url"); + }, + + // Read and return the text from the beginning of the changelog file that is + // located at TorBrowser/Docs/ChangeLog.txt. + // When electrolysis is enabled we will need to adopt an architecture that is + // more similar to the one that is used for about:home (see AboutHomeListener + // in this file and browser/modules/AboutHome.jsm). + getChangeLogText: function() { + try { + // "DefProfRt" is .../TorBrowser/Data/Browser + let f = Cc["@mozilla.org/file/directory_service;1"] + .getService(Ci.nsIProperties).get("DefProfRt", Ci.nsIFile); + f = f.parent.parent; // Remove "Data/Browser" + f.appendRelativePath("Docs/ChangeLog.txt"); + + let fs = Cc["@mozilla.org/network/file-input-stream;1"] + .createInstance(Ci.nsIFileInputStream); + fs.init(f, -1, 0, 0); + let s = NetUtil.readInputStreamToString(fs, fs.available()); + fs.close(); + + // Truncate at the first empty line. + return s.replace(/[\r\n][\r\n][\s\S]*$/m, ""); + } catch (e) {} + + return ""; + }, +}; +AboutTBUpdateListener.init(this); +#endif + // An event listener for custom "WebChannelMessageToChrome" events on pages addEventListener("WebChannelMessageToChrome", function (e) { // if target is window then we want the document principal, otherwise fallback to target itself. diff --git a/browser/base/jar.mn b/browser/base/jar.mn index 00f0c8a..73f370a 100644 --- a/browser/base/jar.mn +++ b/browser/base/jar.mn @@ -72,12 +72,18 @@ browser.jar: content/browser/aboutTabCrashed.css (content/aboutTabCrashed.css) content/browser/aboutTabCrashed.js (content/aboutTabCrashed.js) content/browser/aboutTabCrashed.xhtml (content/aboutTabCrashed.xhtml) +#ifdef TOR_BROWSER_UPDATE + content/browser/abouttbupdate/aboutTBUpdate.xhtml (content/abouttbupdate/aboutTBUpdate.xhtml) + content/browser/abouttbupdate/aboutTBUpdate.js (content/abouttbupdate/aboutTBUpdate.js) + content/browser/abouttbupdate/aboutTBUpdate.css (content/abouttbupdate/aboutTBUpdate.css) + content/browser/abouttbupdate/aboutTBUpdateLogo.png (content/abouttbupdate/aboutTBUpdateLogo.png) +#endif * content/browser/browser.css (content/browser.css) * content/browser/browser.js (content/browser.js) * content/browser/browser.xul (content/browser.xul) * content/browser/browser-tabPreviews.xml (content/browser-tabPreviews.xml) * content/browser/chatWindow.xul (content/chatWindow.xul) - content/browser/content.js (content/content.js) +* content/browser/content.js (content/content.js) content/browser/defaultthemes/1.footer.jpg (content/defaultthemes/1.footer.jpg) content/browser/defaultthemes/1.header.jpg (content/defaultthemes/1.header.jpg) content/browser/defaultthemes/1.icon.jpg (content/defaultthemes/1.icon.jpg) diff --git a/browser/components/about/AboutRedirector.cpp b/browser/components/about/AboutRedirector.cpp index 4805c2c..a4f1c4a 100644 --- a/browser/components/about/AboutRedirector.cpp +++ b/browser/components/about/AboutRedirector.cpp @@ -123,6 +123,14 @@ static RedirEntry kRedirMap[] = { nsIAboutModule::URI_MUST_LOAD_IN_CHILD | nsIAboutModule::MAKE_UNLINKABLE | nsIAboutModule::HIDE_FROM_ABOUTABOUT }, +#ifdef TOR_BROWSER_UPDATE + { "tbupdate", "chrome://browser/content/abouttbupdate/aboutTBUpdate.xhtml", + nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT | + nsIAboutModule::ALLOW_SCRIPT | + nsIAboutModule::MAKE_UNLINKABLE | + nsIAboutModule::HIDE_FROM_ABOUTABOUT + }, +#endif }; static const int kRedirTotal = ArrayLength(kRedirMap); diff --git a/browser/components/build/nsModule.cpp b/browser/components/build/nsModule.cpp index 553dfcf..8761b7d 100644 --- a/browser/components/build/nsModule.cpp +++ b/browser/components/build/nsModule.cpp @@ -116,6 +116,9 @@ static const mozilla::Module::ContractIDEntry kBrowserContracts[] = { { NS_ABOUT_MODULE_CONTRACTID_PREFIX "looppanel", &kNS_BROWSER_ABOUT_REDIRECTOR_CID }, { NS_ABOUT_MODULE_CONTRACTID_PREFIX "loopconversation", &kNS_BROWSER_ABOUT_REDIRECTOR_CID }, { NS_ABOUT_MODULE_CONTRACTID_PREFIX "reader", &kNS_BROWSER_ABOUT_REDIRECTOR_CID }, +#ifdef TOR_BROWSER_UPDATE + { NS_ABOUT_MODULE_CONTRACTID_PREFIX "tbupdate", &kNS_BROWSER_ABOUT_REDIRECTOR_CID }, +#endif #if defined(XP_WIN) { NS_IEHISTORYENUMERATOR_CONTRACTID, &kNS_WINIEHISTORYENUMERATOR_CID }, #elif defined(XP_MACOSX) diff --git a/browser/components/nsBrowserContentHandler.js b/browser/components/nsBrowserContentHandler.js index a3465a0..9d7d110 100644 --- a/browser/components/nsBrowserContentHandler.js +++ b/browser/components/nsBrowserContentHandler.js @@ -629,6 +629,13 @@ nsBrowserContentHandler.prototype = { // into account because that requires waiting for the session file // to be read. If a crash occurs after updating, before restarting, // we may open the startPage in addition to restoring the session. + // + // Tor Browser: Instead of opening the post-update "override page" + // directly, an about:tbupdate page is opened that includes a link + // to the override page as well as text from the first part of the + // local ChangeLog.txt file. The override page URL comes from the + // openURL attribute within the updates.xml file or, if no showURL + // action is present, from the startup.homepage_override_url pref. var ss = Components.classes["@mozilla.org/browser/sessionstartup;1"] .getService(Components.interfaces.nsISessionStartup); willRestoreSession = ss.isAutomaticRestoreEnabled(); @@ -642,6 +649,11 @@ nsBrowserContentHandler.prototype = { overridePage = overridePage.replace("%OLD_TOR_BROWSER_VERSION%", old_tbversion); #endif + +#ifdef TOR_BROWSER_UPDATE + if (overridePage) + overridePage = "about:tbupdate?" + encodeURIComponent(overridePage); +#endif break; } } diff --git a/browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd b/browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd new file mode 100644 index 0000000..37567bd --- /dev/null +++ b/browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd @@ -0,0 +1,6 @@ +<!ENTITY aboutTBUpdate.title "Tor Browser Update"> +<!ENTITY aboutTBUpdate.updated "Tor Browser has been updated."> +<!ENTITY aboutTBUpdate.linkPrefix "For the most up-to-date information about this release, "> +<!ENTITY aboutTBUpdate.linkLabel "visit our website"> +<!ENTITY aboutTBUpdate.linkSuffix "."> +<!ENTITY aboutTBUpdate.changeLogHeading "Changelog:"> diff --git a/browser/locales/jar.mn b/browser/locales/jar.mn index 03a8cdf..510ce40 100644 --- a/browser/locales/jar.mn +++ b/browser/locales/jar.mn @@ -24,6 +24,9 @@ locale/browser/syncCustomize.dtd (%chrome/browser/syncCustomize.dtd) locale/browser/aboutSyncTabs.dtd (%chrome/browser/aboutSyncTabs.dtd) #endif +#ifdef TOR_BROWSER_UPDATE + locale/browser/aboutTBUpdate.dtd (%chrome/browser/aboutTBUpdate.dtd) +#endif locale/browser/browser.dtd (%chrome/browser/browser.dtd) locale/browser/baseMenuOverlay.dtd (%chrome/browser/baseMenuOverlay.dtd) locale/browser/browser.properties (%chrome/browser/browser.properties)

1 0

[tor-browser-bundle/hardened-builds] Bug 13819: Ship expert bundles with console
by gk＠torproject.org 24 Nov '15

24 Nov '15

commit e4b449bef3f7d44f8533c7d1bdd54cdf0535887f Author: Georg Koppen <gk(a)torproject.org> Date: Mon Sep 21 08:47:47 2015 +0000 Bug 13819: Ship expert bundles with console Currently, the expert bundles are identical to the tor software we ship in Tor Browser. This means there is no console showing up displaying status messages while tor and the browser are running. This commit fixes this by compiling tor twice, once for Tor Browser without console showing up and the second time with the console enabled. The first goes into Tor Browser and the second one is used for the expert bundle. --- gitian/descriptors/windows/gitian-tor.yml | 50 ++++++++++++++++++++--------- gitian/mkbundle-windows.sh | 7 ++-- 2 files changed, 38 insertions(+), 19 deletions(-) diff --git a/gitian/descriptors/windows/gitian-tor.yml b/gitian/descriptors/windows/gitian-tor.yml index 9d6838c..601dc4e 100644 --- a/gitian/descriptors/windows/gitian-tor.yml +++ b/gitian/descriptors/windows/gitian-tor.yml @@ -65,20 +65,38 @@ script: | fi mkdir -p $OUTDIR/src #git archive HEAD | tar -x -C $OUTDIR/src - # Let's avoid the console window popping up. - export CFLAGS="-mwindows -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security" - export LDFLAGS="-mwindows -Wl,--dynamicbase -Wl,--nxcompat -Wl,--enable-reloc-section -lssp -L$INSTDIR/gcclibs" - ./autogen.sh - find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME" - ./configure --disable-asciidoc --host=i686-w64-mingw32 --with-libevent-dir=$INSTDIR/libevent --with-openssl-dir=$INSTDIR/openssl --prefix=$INSTDIR --with-zlib-dir=$INSTDIR/zlib/ - make $MAKEOPTS - make install - cd .. - install -s $INSTDIR/bin/tor.exe $INSTDIR/Tor/ - cp $INSTDIR/share/tor/geoip $INSTDIR/Data/Tor/ - cp $INSTDIR/share/tor/geoip6 $INSTDIR/Data/Tor/ + # We are building normal bundles without the console popping up and expert + # ones with. See bug 13819 for the request and details. + mkdir build + BUILDS="normal expert" + for BUILD in $BUILDS + do + if [ "$BUILD" == "expert" ] + then + FLAG="" + BUNDLE="expert-" + else + FLAG="-mwindows" + BUNDLE="" + fi + export CFLAGS="$FLAG -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security" + export LDFLAGS="$FLAG -Wl,--dynamicbase -Wl,--nxcompat -Wl,--enable-reloc-section -lssp -L$INSTDIR/gcclibs" + ./autogen.sh + find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME" + cd build + ../configure --disable-asciidoc --host=i686-w64-mingw32 --with-libevent-dir=$INSTDIR/libevent --with-openssl-dir=$INSTDIR/openssl --prefix=$INSTDIR --with-zlib-dir=$INSTDIR/zlib/ + make $MAKEOPTS + make install + cd ../.. + install -s $INSTDIR/bin/tor.exe $INSTDIR/Tor/ + cp $INSTDIR/share/tor/geoip $INSTDIR/Data/Tor/ + cp $INSTDIR/share/tor/geoip6 $INSTDIR/Data/Tor/ - # Grabbing the result - cd $INSTDIR - ~/build/dzip.sh tor-win32-gbuilt.zip Tor/ Data/ - cp tor-win32-gbuilt.zip $OUTDIR/ + # Grabbing the result + cd $INSTDIR + ~/build/dzip.sh tor-win32-${BUNDLE}gbuilt.zip Tor/ Data/ + cp tor-win32-${BUNDLE}gbuilt.zip $OUTDIR/ + cd ~/build/tor + # Remove artifacts of the previous build + rm -rf build/* + done diff --git a/gitian/mkbundle-windows.sh b/gitian/mkbundle-windows.sh index 8f89123..6aeec8a 100755 --- a/gitian/mkbundle-windows.sh +++ b/gitian/mkbundle-windows.sh @@ -148,7 +148,8 @@ else cd .. fi -if [ ! -f inputs/tor-win32-gbuilt.zip ]; +if [ ! -f inputs/tor-win32-gbuilt.zip -o \ + ! -f inputs/tor-win32-expert-gbuilt.zip ]; then echo echo "****** Starting Tor Component of Windows Bundle (2/5 for Windows) ******" @@ -161,7 +162,7 @@ then exit 1 fi - cp -a build/out/tor-win32-gbuilt.zip inputs/ + cp -a build/out/tor-win32-*gbuilt.zip inputs/ #cp -a result/tor-windows-res.yml inputs/ else echo @@ -230,7 +231,7 @@ then mkdir -p $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ cp -a build/out/*.exe $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ || exit 1 cp -a build/out/*.mar $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ || exit 1 - cp -a inputs/tor-win32-gbuilt.zip $WRAPPER_DIR/$TORBROWSER_BUILDDIR/tor-win32-${TOR_TAG_ORIG:4}.zip || exit 1 + cp -a inputs/tor-win32-expert-gbuilt.zip $WRAPPER_DIR/$TORBROWSER_BUILDDIR/tor-win32-${TOR_TAG_ORIG:4}.zip || exit 1 touch inputs/bundle-windows.gbuilt else echo

1 0

[tor-browser-bundle/master] Bug 13819: Ship expert bundles with console
by gk＠torproject.org 24 Nov '15

24 Nov '15

commit eaec9e80ac9a2a490456b4d6d3805f66dfa0a627 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Sep 21 08:47:47 2015 +0000 Bug 13819: Ship expert bundles with console Currently, the expert bundles are identical to the tor software we ship in Tor Browser. This means there is no console showing up displaying status messages while tor and the browser are running. This commit fixes this by compiling tor twice, once for Tor Browser without console showing up and the second time with the console enabled. The first goes into Tor Browser and the second one is used for the expert bundle. --- gitian/descriptors/windows/gitian-tor.yml | 50 ++++++++++++++++++++--------- gitian/mkbundle-windows.sh | 7 ++-- 2 files changed, 38 insertions(+), 19 deletions(-) diff --git a/gitian/descriptors/windows/gitian-tor.yml b/gitian/descriptors/windows/gitian-tor.yml index 9d6838c..601dc4e 100644 --- a/gitian/descriptors/windows/gitian-tor.yml +++ b/gitian/descriptors/windows/gitian-tor.yml @@ -65,20 +65,38 @@ script: | fi mkdir -p $OUTDIR/src #git archive HEAD | tar -x -C $OUTDIR/src - # Let's avoid the console window popping up. - export CFLAGS="-mwindows -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security" - export LDFLAGS="-mwindows -Wl,--dynamicbase -Wl,--nxcompat -Wl,--enable-reloc-section -lssp -L$INSTDIR/gcclibs" - ./autogen.sh - find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME" - ./configure --disable-asciidoc --host=i686-w64-mingw32 --with-libevent-dir=$INSTDIR/libevent --with-openssl-dir=$INSTDIR/openssl --prefix=$INSTDIR --with-zlib-dir=$INSTDIR/zlib/ - make $MAKEOPTS - make install - cd .. - install -s $INSTDIR/bin/tor.exe $INSTDIR/Tor/ - cp $INSTDIR/share/tor/geoip $INSTDIR/Data/Tor/ - cp $INSTDIR/share/tor/geoip6 $INSTDIR/Data/Tor/ + # We are building normal bundles without the console popping up and expert + # ones with. See bug 13819 for the request and details. + mkdir build + BUILDS="normal expert" + for BUILD in $BUILDS + do + if [ "$BUILD" == "expert" ] + then + FLAG="" + BUNDLE="expert-" + else + FLAG="-mwindows" + BUNDLE="" + fi + export CFLAGS="$FLAG -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security" + export LDFLAGS="$FLAG -Wl,--dynamicbase -Wl,--nxcompat -Wl,--enable-reloc-section -lssp -L$INSTDIR/gcclibs" + ./autogen.sh + find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME" + cd build + ../configure --disable-asciidoc --host=i686-w64-mingw32 --with-libevent-dir=$INSTDIR/libevent --with-openssl-dir=$INSTDIR/openssl --prefix=$INSTDIR --with-zlib-dir=$INSTDIR/zlib/ + make $MAKEOPTS + make install + cd ../.. + install -s $INSTDIR/bin/tor.exe $INSTDIR/Tor/ + cp $INSTDIR/share/tor/geoip $INSTDIR/Data/Tor/ + cp $INSTDIR/share/tor/geoip6 $INSTDIR/Data/Tor/ - # Grabbing the result - cd $INSTDIR - ~/build/dzip.sh tor-win32-gbuilt.zip Tor/ Data/ - cp tor-win32-gbuilt.zip $OUTDIR/ + # Grabbing the result + cd $INSTDIR + ~/build/dzip.sh tor-win32-${BUNDLE}gbuilt.zip Tor/ Data/ + cp tor-win32-${BUNDLE}gbuilt.zip $OUTDIR/ + cd ~/build/tor + # Remove artifacts of the previous build + rm -rf build/* + done diff --git a/gitian/mkbundle-windows.sh b/gitian/mkbundle-windows.sh index 8f89123..6aeec8a 100755 --- a/gitian/mkbundle-windows.sh +++ b/gitian/mkbundle-windows.sh @@ -148,7 +148,8 @@ else cd .. fi -if [ ! -f inputs/tor-win32-gbuilt.zip ]; +if [ ! -f inputs/tor-win32-gbuilt.zip -o \ + ! -f inputs/tor-win32-expert-gbuilt.zip ]; then echo echo "****** Starting Tor Component of Windows Bundle (2/5 for Windows) ******" @@ -161,7 +162,7 @@ then exit 1 fi - cp -a build/out/tor-win32-gbuilt.zip inputs/ + cp -a build/out/tor-win32-*gbuilt.zip inputs/ #cp -a result/tor-windows-res.yml inputs/ else echo @@ -230,7 +231,7 @@ then mkdir -p $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ cp -a build/out/*.exe $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ || exit 1 cp -a build/out/*.mar $WRAPPER_DIR/$TORBROWSER_BUILDDIR/ || exit 1 - cp -a inputs/tor-win32-gbuilt.zip $WRAPPER_DIR/$TORBROWSER_BUILDDIR/tor-win32-${TOR_TAG_ORIG:4}.zip || exit 1 + cp -a inputs/tor-win32-expert-gbuilt.zip $WRAPPER_DIR/$TORBROWSER_BUILDDIR/tor-win32-${TOR_TAG_ORIG:4}.zip || exit 1 touch inputs/bundle-windows.gbuilt else echo

1 0

[tor-launcher/master] Bug 17344: enumerate available langpacks for lang prompt
by brade＠torproject.org 20 Nov '15

20 Nov '15

commit 20f01697b19ce938b894634d3ca4e39218137ea4 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Fri Nov 20 15:26:56 2015 -0500 Bug 17344: enumerate available langpacks for lang prompt Remove the hard-coded list of languages and build the listbox items from the set of installed language packs. --- src/chrome/content/localePicker.xul | 19 +------ src/chrome/content/network-settings.js | 97 +++++++++++++++++++++++++++----- 2 files changed, 85 insertions(+), 31 deletions(-) diff --git a/src/chrome/content/localePicker.xul b/src/chrome/content/localePicker.xul index be82e14..5b93825 100644 --- a/src/chrome/content/localePicker.xul +++ b/src/chrome/content/localePicker.xul @@ -35,24 +35,7 @@ <vbox> <label class="question">&torlauncher.localePicker.prompt;</label> <separator/> - <listbox id="localeList" ondblclick="onLocaleListDoubleClick()"> - <listitem value="en-US" label="English" selected="true" /> - <listitem value="ar" label="العربية" /> - <listitem value="de" label="Deutsch" /> - <listitem value="es-ES" label="Español" /> - <listitem value="fa" label="فارسی" /> - <listitem value="fr" label="Français" /> - <listitem value="it" label="Italiano" /> - <listitem value="ja" label="日本語" /> - <listitem value="ko" label="한국어" /> - <listitem value="nl" label="Nederlands" /> - <listitem value="pl" label="Polski" /> - <listitem value="pt-PT" label="Português (Europeu)" /> - <listitem value="ru" label="Русский" /> - <listitem value="tr" label="Türkçe" /> - <listitem value="vi" label="Tiếng Việt" /> - <listitem value="zh-CN" label="简体字" /> - </listbox> + <listbox id="localeList" ondblclick="onLocaleListDoubleClick()"/> </vbox> </wizardpage> diff --git a/src/chrome/content/network-settings.js b/src/chrome/content/network-settings.js index 2382ea6..9d3cb60 100644 --- a/src/chrome/content/network-settings.js +++ b/src/chrome/content/network-settings.js @@ -247,27 +247,98 @@ function initLocaleDialog() if (nextBtn && doneBtn) doneBtn.label = nextBtn.label; - // Select the current language by default. + let { AddonManager } = Cu.import("resource://gre/modules/AddonManager.jsm"); + AddonManager.getAddonsByTypes(["locale"], function(aLangPackAddons) + { + populateLocaleList(aLangPackAddons); + resizeDialogToFitContent(); + TorLauncherLogger.log(2, "initLocaleDialog done"); + }); +} + + +function populateLocaleList(aLangPackAddons) +{ + let knownLanguages = { + "en-US" : "English", + "ar" : "\u0627\u0644\u0639\u0631\u0628\u064a\u0629", + "de" : "Deutsch", + "es-ES" : "Espa\u00f1ol", + "fa" : "\u0641\u0627\u0631\u0633\u06cc", + "fr" : "Fran\u00e7ais", + "it" : "Italiano", + "ja" : "\u65e5\u672c\u8a9e", + "ko" : "\ud55c\uad6d\uc5b4", + "nl" : "Nederlands", + "pl" : "Polski", + "pt-PT" : "Portugu\u00eas (Europeu)", + "ru" : "\u0420\u0443\u0441\u0441\u043a\u0438\u0439", + "tr" : "T\u00fcrk\u00e7e", + "vi" : "Ti\u1ebfng Vi\u1ec7t", + "zh-CN" : "\u7b80\u4f53\u5b57" + }; + + // Retrieve the current locale so we can select it within the list by default. + let curLocale; try { let chromeRegSvc = Cc["@mozilla.org/chrome/chrome-registry;1"] .getService(Ci.nsIXULChromeRegistry); - let curLocale = chromeRegSvc.getSelectedLocale("global").toLowerCase(); - let localeList = document.getElementById(kLocaleList); - for (let i = 0; i < localeList.itemCount; ++i) + curLocale = chromeRegSvc.getSelectedLocale("global").toLowerCase(); + } catch (e) {} + + // Build a list of language info objects (language code plus friendly name). + let foundCurLocale = false; + let langInfo = []; + for (let addon of aLangPackAddons) + { + let uri = addon.getResourceURI(""); + // The add-on IDs look like langpack-LANGCODE(a)firefox.mozilla.org + let matchResult = addon.id.match(/^langpack-(.*)@.*\.mozilla\.org/); + let code = (matchResult) ? matchResult[1] : addon.id; + if (code == "ja-JP-mac") + code = "ja"; + let name = knownLanguages[code]; + if (!name) { - let item = localeList.getItemAtIndex(i); - if (item.value.toLowerCase() == curLocale) - { - localeList.selectedIndex = i; - break; - } + // We do not have a name for this language pack. Use some heuristics. + name = addon.name; + let idx = name.lastIndexOf(" Language Pack"); + if (idx > 0) + name = name.substring(0, idx); } - } catch (e) {} + let isSelected = (curLocale && (code.toLowerCase() == curLocale)); + langInfo.push({ langCode: code, langName: name, isSelected: isSelected } ); + if (isSelected && !foundCurLocale) + foundCurLocale = true; + } - resizeDialogToFitContent(); + // Sort by language code. + langInfo.sort(function(aObj1, aObj2) { + if (aObj1.langCode == aObj2.langCode) + return 0; + + return (aObj1.langCode < aObj2.langCode) ? -1 : 1; + }); - TorLauncherLogger.log(2, "initLocaleDialog done"); + // Add en-US to the beginning of the list. + let code = "en-US"; + let name = knownLanguages[code]; + let isSelected = !foundCurLocale; // select English if nothing else matched + langInfo.splice(0, 0, + { langCode: code, langName: name, isSelected: isSelected }); + + // Populate the XUL listbox. + let localeList = document.getElementById(kLocaleList); + for (let infoObj of langInfo) + { + let listItem = document.createElement("listitem"); + listItem.setAttribute("value", infoObj.langCode); + listItem.setAttribute("label", infoObj.langName); + localeList.appendChild(listItem); + if (infoObj.isSelected) + localeList.selectedItem = listItem; + } }

1 0