tbb-commits

tbb-commits@lists.torproject.org

August 2026

1 participants
182 discussions

[Git][tpo/applications/mullvad-browser][mullvad-browser-153.0esr-16.0-1] 2 commits: fixup! BB 42027: Base Browser migration procedures.
by Pier Angelo Vendrame (＠pierov) 03 Aug '26

03 Aug '26

Pier Angelo Vendrame pushed to branch mullvad-browser-153.0esr-16.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 0c1e3184 by Henry Wilkes at 2026-08-03T15:53:58+02:00 fixup! BB 42027: Base Browser migration procedures. BB 44802: Hide safe browsing settings. - - - - - cc5c9e67 by Henry Wilkes at 2026-08-03T15:53:58+02:00 fixup! BB 44711: Hide unwanted setting controls in Base Browser. BB 44802: Hide safe browsing settings. - - - - - 2 changed files: - browser/components/ProfileDataUpgrader.sys.mjs - browser/components/preferences/config/privacy.mjs Changes: ===================================== browser/components/ProfileDataUpgrader.sys.mjs ===================================== @@ -1040,7 +1040,8 @@ export let ProfileDataUpgrader = { // Version 4: 15.0a2: Drop ML components. tor-browser#44045. // Version 5: 15.0a3: Disable LaterRun using prefs. tor-browser#42630. // Version 6: 15.0a4: Reset browser colors. tor-browser#43850. - const MIGRATION_VERSION = 6; + // Version 7: 16.0a10: Reset safe browsing preferences. tor-browser#44802. + const MIGRATION_VERSION = 7; const MIGRATION_PREF = "basebrowser.migration.version"; if (isNewProfile) { @@ -1138,6 +1139,21 @@ export let ProfileDataUpgrader = { } } } + if (currentVersion < 7) { + // Clear these preferences since: + // + They aren't expected to work. + // + We are hiding the UI to change these. tor-browser#44802. + for (const prefName of [ + "browser.safebrowsing.phishing.enabled", + "browser.safebrowsing.malware.enabled", + "browser.safebrowsing.downloads.enabled", + "browser.safebrowsing.downloads.remote.block_uncommon", + "browser.safebrowsing.downloads.remote.block_potentially_unwanted", + "urlclassifier.malwareTable", + ]) { + Services.prefs.clearUserPref(prefName); + } + } Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION); }, ===================================== browser/components/preferences/config/privacy.mjs ===================================== @@ -2424,6 +2424,8 @@ Preferences.addSetting({ Preferences.addSetting({ id: "enableSafeBrowsing", deps: ["enableSafeBrowsingPhishing", "enableSafeBrowsingMalware"], + // Does not work in Tor Browser. tor-browser#44802. + visible: () => false, get: (_value, deps) => { return ( deps.enableSafeBrowsingPhishing.value && @@ -2453,12 +2455,8 @@ Preferences.addSetting( uncommonDownloads: "browser.safebrowsing.downloads.remote.block_potentially_unwanted", }, - ({ malware, phishing, downloads, unwantedDownloads, uncommonDownloads }) => - (!malware.value && !malware.locked) || - (!phishing.value && !phishing.locked) || - (!downloads.value && !downloads.locked) || - (!unwantedDownloads.value && !unwantedDownloads.locked) || - (!uncommonDownloads.value && !uncommonDownloads.locked), + // Does not work in Tor Browser. tor-browser#44802. + () => false, true ) ); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/bd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/bd… You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help

1 0

[Git][tpo/applications/tor-browser][tor-browser-153.0esr-16.0-1] 2 commits: fixup! BB 42027: Base Browser migration procedures.
by henry (＠henry) 03 Aug '26

03 Aug '26

henry pushed to branch tor-browser-153.0esr-16.0-1 at The Tor Project / Applications / Tor Browser Commits: b08090cb by Henry Wilkes at 2026-08-03T13:14:55+01:00 fixup! BB 42027: Base Browser migration procedures. BB 44802: Hide safe browsing settings. - - - - - 7a387a89 by Henry Wilkes at 2026-08-03T13:15:53+01:00 fixup! BB 44711: Hide unwanted setting controls in Base Browser. BB 44802: Hide safe browsing settings. - - - - - 2 changed files: - browser/components/ProfileDataUpgrader.sys.mjs - browser/components/preferences/config/privacy.mjs Changes: ===================================== browser/components/ProfileDataUpgrader.sys.mjs ===================================== @@ -1040,7 +1040,8 @@ export let ProfileDataUpgrader = { // Version 4: 15.0a2: Drop ML components. tor-browser#44045. // Version 5: 15.0a3: Disable LaterRun using prefs. tor-browser#42630. // Version 6: 15.0a4: Reset browser colors. tor-browser#43850. - const MIGRATION_VERSION = 6; + // Version 7: 16.0a10: Reset safe browsing preferences. tor-browser#44802. + const MIGRATION_VERSION = 7; const MIGRATION_PREF = "basebrowser.migration.version"; if (isNewProfile) { @@ -1138,6 +1139,21 @@ export let ProfileDataUpgrader = { } } } + if (currentVersion < 7) { + // Clear these preferences since: + // + They aren't expected to work. + // + We are hiding the UI to change these. tor-browser#44802. + for (const prefName of [ + "browser.safebrowsing.phishing.enabled", + "browser.safebrowsing.malware.enabled", + "browser.safebrowsing.downloads.enabled", + "browser.safebrowsing.downloads.remote.block_uncommon", + "browser.safebrowsing.downloads.remote.block_potentially_unwanted", + "urlclassifier.malwareTable", + ]) { + Services.prefs.clearUserPref(prefName); + } + } Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION); }, ===================================== browser/components/preferences/config/privacy.mjs ===================================== @@ -2424,6 +2424,8 @@ Preferences.addSetting({ Preferences.addSetting({ id: "enableSafeBrowsing", deps: ["enableSafeBrowsingPhishing", "enableSafeBrowsingMalware"], + // Does not work in Tor Browser. tor-browser#44802. + visible: () => false, get: (_value, deps) => { return ( deps.enableSafeBrowsingPhishing.value && @@ -2453,12 +2455,8 @@ Preferences.addSetting( uncommonDownloads: "browser.safebrowsing.downloads.remote.block_potentially_unwanted", }, - ({ malware, phishing, downloads, unwantedDownloads, uncommonDownloads }) => - (!malware.value && !malware.locked) || - (!phishing.value && !phishing.locked) || - (!downloads.value && !downloads.locked) || - (!unwantedDownloads.value && !unwantedDownloads.locked) || - (!uncommonDownloads.value && !uncommonDownloads.locked), + // Does not work in Tor Browser. tor-browser#44802. + () => false, true ) ); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/becb4a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/becb4a… You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help

1 0

Jump to page: