September 2025 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.14.0esr-14.5-1-build5
by ma1 (＠ma1) 16 Sep '25

16 Sep '25

ma1 pushed new tag tor-browser-128.14.0esr-14.5-1-build5 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.14.0esr-14.5-1] fixup! Bug 1913773 - Ensure mCurrentShmem is valid. r=aosmond
by ma1 (＠ma1) 16 Sep '25

16 Sep '25

ma1 pushed to branch tor-browser-128.14.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: fdb40486 by hackademix at 2025-09-16T01:30:20+02:00 fixup! Bug 1913773 - Ensure mCurrentShmem is valid. r=aosmond Correct capitalization of "memory" for SharedMemoryBasic. - - - - - 1 changed file: - gfx/layers/ipc/CanvasTranslator.h Changes: ===================================== gfx/layers/ipc/CanvasTranslator.h ===================================== @@ -364,7 +364,7 @@ class CanvasTranslator final : public gfx::InlineTranslator, if (!shmem) { return {nullptr, 0}; } - return {static_cast<char*>(shmem->Memory()), Size()}; + return {static_cast<char*>(shmem->memory()), Size()}; } }; std::queue<CanvasShmem> mCanvasShmems; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdb4048… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdb4048… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.14.0esr-14.5-1-build4
by ma1 (＠ma1) 15 Sep '25

15 Sep '25

ma1 pushed new tag mullvad-browser-128.14.0esr-14.5-1-build4 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.14.0esr-14.5-1] 3 commits: Revert "Bug 1986185. r=aosmond a=RyanVM"
by ma1 (＠ma1) 15 Sep '25

15 Sep '25

ma1 pushed to branch mullvad-browser-128.14.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: fa6f4582 by hackademix at 2025-09-16T00:50:48+02:00 Revert "Bug 1986185. r=aosmond a=RyanVM" This reverts commit df081c6cbd02a1c25bf1582bff5295a17bcff49a. - - - - - b96034cc by Lee Salzman at 2025-09-16T00:50:49+02:00 Bug 1913773 - Ensure mCurrentShmem is valid. r=aosmond Adapted from esr140 to esr128 (tor-browser#44199) Differential Revision: https://phabricator.services.mozilla.com/D219832 - - - - - 51680c11 by Lee Salzman at 2025-09-16T00:50:51+02:00 Bug 1986185. r=aosmond a=RyanVM Backported manually to 128esr, see BB 44199 Differential Revision: https://phabricator.services.mozilla.com/D263287 - - - - - 2 changed files: - gfx/layers/ipc/CanvasTranslator.cpp - gfx/layers/ipc/CanvasTranslator.h Changes: ===================================== gfx/layers/ipc/CanvasTranslator.cpp ===================================== @@ -270,7 +270,7 @@ void CanvasTranslator::AddBuffer(ipc::SharedMemoryBasic::Handle&& aBufferHandle, CheckAndSignalWriter(); // Default sized buffers will have been queued for recycling. - if (mCurrentShmem.Size() == mDefaultBufferSize) { + if (mCurrentShmem.IsValid() && mCurrentShmem.Size() == mDefaultBufferSize) { mCanvasShmems.emplace(std::move(mCurrentShmem)); } ===================================== gfx/layers/ipc/CanvasTranslator.h ===================================== @@ -358,9 +358,13 @@ class CanvasTranslator final : public gfx::InlineTranslator, struct CanvasShmem { RefPtr<ipc::SharedMemoryBasic> shmem; - auto Size() { return shmem->Size(); } + bool IsValid() const { return !!shmem; } + auto Size() { return shmem ? shmem->Size() : 0; } gfx::MemReader CreateMemReader() { - return {static_cast<char*>(shmem->memory()), Size()}; + if (!shmem) { + return {nullptr, 0}; + } + return {static_cast<char*>(shmem->Memory()), Size()}; } }; std::queue<CanvasShmem> mCanvasShmems; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/65… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/65… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.14.0esr-14.5-1-build4
by ma1 (＠ma1) 15 Sep '25

15 Sep '25

ma1 pushed new tag tor-browser-128.14.0esr-14.5-1-build4 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.14.0esr-14.5-1] 3 commits: Revert "Bug 1986185. r=aosmond a=RyanVM"
by ma1 (＠ma1) 15 Sep '25

15 Sep '25

ma1 pushed to branch tor-browser-128.14.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: a9aed021 by hackademix at 2025-09-16T00:19:57+02:00 Revert "Bug 1986185. r=aosmond a=RyanVM" This reverts commit df081c6cbd02a1c25bf1582bff5295a17bcff49a. - - - - - 33f78ee9 by Lee Salzman at 2025-09-16T00:37:31+02:00 Bug 1913773 - Ensure mCurrentShmem is valid. r=aosmond Adapted from esr140 to esr128 (tor-browser#44199) Differential Revision: https://phabricator.services.mozilla.com/D219832 - - - - - a9dbcd0a by Lee Salzman at 2025-09-16T00:43:30+02:00 Bug 1986185. r=aosmond a=RyanVM Backported manually to 128esr, see BB 44199 Differential Revision: https://phabricator.services.mozilla.com/D263287 - - - - - 2 changed files: - gfx/layers/ipc/CanvasTranslator.cpp - gfx/layers/ipc/CanvasTranslator.h Changes: ===================================== gfx/layers/ipc/CanvasTranslator.cpp ===================================== @@ -270,7 +270,7 @@ void CanvasTranslator::AddBuffer(ipc::SharedMemoryBasic::Handle&& aBufferHandle, CheckAndSignalWriter(); // Default sized buffers will have been queued for recycling. - if (mCurrentShmem.Size() == mDefaultBufferSize) { + if (mCurrentShmem.IsValid() && mCurrentShmem.Size() == mDefaultBufferSize) { mCanvasShmems.emplace(std::move(mCurrentShmem)); } ===================================== gfx/layers/ipc/CanvasTranslator.h ===================================== @@ -358,9 +358,13 @@ class CanvasTranslator final : public gfx::InlineTranslator, struct CanvasShmem { RefPtr<ipc::SharedMemoryBasic> shmem; - auto Size() { return shmem->Size(); } + bool IsValid() const { return !!shmem; } + auto Size() { return shmem ? shmem->Size() : 0; } gfx::MemReader CreateMemReader() { - return {static_cast<char*>(shmem->memory()), Size()}; + if (!shmem) { + return {nullptr, 0}; + } + return {static_cast<char*>(shmem->Memory()), Size()}; } }; std::queue<CanvasShmem> mCanvasShmems; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/df081c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/df081c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Fix rbm.conf.
by Pier Angelo Vendrame (＠pierov) 15 Sep '25

15 Sep '25

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 0d927a93 by Pier Angelo Vendrame at 2025-09-16T00:16:58+02:00 Fix rbm.conf. - - - - - 1 changed file: - rbm.conf Changes: ===================================== rbm.conf ===================================== @@ -79,6 +79,7 @@ var: # to be reproducible, browser_release_date should always be in the past. browser_release_date: '2025/08/18 19:35:49' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' + browser_platforms: # is_android_release and is_desktop_release are used to quickly # enable/disable all android or desktop platforms. If you want to # check whether a release includes some android or desktop platforms View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 40994: Add support in signing scripts to sign release for some archs only
by Pier Angelo Vendrame (＠pierov) 15 Sep '25

15 Sep '25

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: b8e3ec96 by Nicolas Vigier at 2025-09-16T00:09:22+02:00 Bug 40994: Add support in signing scripts to sign release for some archs only - - - - - 3 changed files: - rbm.conf - tools/signing/do-all-signing - tools/signing/functions Changes: ===================================== rbm.conf ===================================== @@ -79,6 +79,38 @@ var: # to be reproducible, browser_release_date should always be in the past. browser_release_date: '2025/08/18 19:35:49' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' + # is_android_release and is_desktop_release are used to quickly + # enable/disable all android or desktop platforms. If you want to + # check whether a release includes some android or desktop platforms + # see signing_android and signing_desktop below. + is_android_release: '[% c("var/tor-browser") %]' + is_desktop_release: '1' + + # signing_android is used in signing scripts to check if at least + # one android platform is being signed/published + signing_android: | + [%- + c("var/browser_platforms/android-armv7") || + c("var/browser_platforms/android-x86") || + c("var/browser_platforms/android-x86_64") || + c("var/browser_platforms/android-aarch64") + -%] + # signing_desktop is used in signing scripts to check if at least + # one desktop platform is being signed/published + signing_desktop: | + [%- + c("var/browser_platforms/linux-x86_64") || + c("var/browser_platforms/linux-i686") || + c("var/browser_platforms/linux-aarch64") || + c("var/browser_platforms/windows-i686") || + c("var/browser_platforms/windows-x86_64") || + c("var/browser_platforms/macos") + -%] + signing_windows: | + [%- + c("var/browser_platforms/windows-i686") || + c("var/browser_platforms/windows-x86_64") + -%] updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: ===================================== tools/signing/do-all-signing ===================================== @@ -19,38 +19,66 @@ if [[ $1 = "-p" ]]; then shift fi +function is_legacy { + [[ "$tbb_version" = 13.* ]] +} + +if is_legacy; then + platform_android= + platform_desktop=1 + platform_macos=1 + platform_windows=1 +else + platform_android=$(rbm_showconf_boolean var/browser_platforms/signing_android) + platform_desktop=$(rbm_showconf_boolean var/browser_platforms/signing_desktop) + platform_macos=$(rbm_showconf_boolean var/browser_platforms/macos) + platform_windows=$(rbm_showconf_boolean var/browser_platforms/signing_windows) +fi + is_project torbrowser && nssdb=torbrowser-nssdb7 is_project mullvadbrowser && nssdb=mullvadbrowser-nssdb1 if [ -f "$passwords_gpg_file" ]; then echo "Reading passwords from $passwords_gpg_file" SEKRITS=$(gpg --decrypt "$passwords_gpg_file") - RCODESIGN_PW=$(get_sekrit 'rcodesign') - NSSPASS=$(get_sekrit "$nssdb (mar signing)") - KSPASS=$(get_sekrit "android apk ($tbb_version_type)") - YUBIPASS=$(get_sekrit "windows authenticode") + [ -n "$platform_macos" ] && \ + RCODESIGN_PW=$(get_sekrit 'rcodesign') + [ -n "$platform_desktop" ] && \ + NSSPASS=$(get_sekrit "$nssdb (mar signing)") + [ -n "$platform_android" ] && \ + KSPASS=$(get_sekrit "android apk ($tbb_version_type)") + [ -n "$platform_windows" ] && \ + YUBIPASS=$(get_sekrit "windows authenticode") GPG_PASS=$(get_sekrit "gpg") else echo "Rather than entering all the password manually, you may want to provide a gpg-encrypted file either on the command line (-p <filepath>) or in set-config.passwords." fi -test -f "$steps_dir/linux-signer-rcodesign-sign.done" || [ -n "$RCODESIGN_PW" ] || +[ -z "$platform_macos" ] || \ + [ -f "$steps_dir/linux-signer-rcodesign-sign.done" ] || \ + [ -n "$RCODESIGN_PW" ] || \ read -sp "Enter rcodesign passphrase for key-1: " RCODESIGN_PW echo -test -f "$steps_dir/linux-signer-signmars.done" || [ -n "$NSSPASS" ] || +[ -z "$platform_desktop" ] || \ + [ -f "$steps_dir/linux-signer-signmars.done" ] || \ + [ -n "$NSSPASS" ] || \ read -sp "Enter $nssdb (mar signing) passphrase: " NSSPASS echo -if is_project torbrowser; then - test -f "$steps_dir/linux-signer-sign-android-apks.done" || [ -n "$KSPASS" ] || - read -sp "Enter android apk signing password ($tbb_version_type): " KSPASS - echo -fi -test -f "$steps_dir/linux-signer-authenticode-signing.done" || [ -n "$YUBIPASS" ] || +[ -z "$platform_android" ] || \ + [ -f "$steps_dir/linux-signer-sign-android-apks.done" ] || \ + [ -n "$KSPASS" ] || \ + read -sp "Enter android apk signing password ($tbb_version_type): " KSPASS +echo + +[ -z "$platform_windows" ] || \ + [ -f "$steps_dir/linux-signer-authenticode-signing.done" ] || \ + [ -n "$YUBIPASS" ] || \ read -sp "Enter windows authenticode passphrase: " YUBIPASS echo -test -f "$steps_dir/linux-signer-gpg-sign.done" || [ -n "$GPG_PASS" ] || + +[ -f "$steps_dir/linux-signer-gpg-sign.done" ] || [ -n "$GPG_PASS" ] || \ read -sp "Enter gpg passphrase: " GPG_PASS echo @@ -199,10 +227,6 @@ function do_step { echo "$(date -Iseconds) - Finished step: $1" } -function is_legacy { - [[ "$tbb_version" = 13.* ]] -} - export SIGNING_PROJECTNAME do_step set-time-on-signing-machine @@ -210,23 +234,34 @@ do_step wait-for-finished-build do_step sync-builder-unsigned-to-local-signed do_step sync-scripts-to-linux-signer do_step sync-before-linux-signer-rcodesign-sign -do_step linux-signer-rcodesign-sign -do_step sync-linux-signer-macos-signed-tar-to-local -do_step rcodesign-notary-submit -do_step gatekeeper-bundling -do_step dmg2mar +[ -n "$platform_macos" ] && \ + do_step linux-signer-rcodesign-sign +[ -n "$platform_macos" ] && \ + do_step sync-linux-signer-macos-signed-tar-to-local +[ -n "$platform_macos" ] && \ + do_step rcodesign-notary-submit +[ -n "$platform_macos" ] && \ + do_step gatekeeper-bundling +[ -n "$platform_macos" ] && \ + do_step dmg2mar do_step sync-scripts-to-linux-signer do_step sync-before-linux-signer-signmars -do_step linux-signer-signmars -do_step sync-after-signmars -is_project torbrowser && ! is_legacy && \ +[ -n "$platform_desktop" ] && \ + do_step linux-signer-signmars +[ -n "$platform_desktop" ] && \ + do_step sync-after-signmars +[ -n "$platform_android" ] && \ do_step linux-signer-sign-android-apks -is_project torbrowser && ! is_legacy && \ +[ -n "$platform_android" ] && \ do_step sync-after-sign-android-apks -do_step linux-signer-authenticode-signing -do_step sync-after-authenticode-signing -do_step authenticode-timestamping -do_step sync-after-authenticode-timestamping +[ -n "$platform_windows" ] && \ + do_step linux-signer-authenticode-signing +[ -n "$platform_windows" ] && \ + do_step sync-after-authenticode-signing +[ -n "$platform_windows" ] && \ + do_step authenticode-timestamping +[ -n "$platform_windows" ] && \ + do_step sync-after-authenticode-timestamping do_step hash_signed_bundles do_step sync-after-hash do_step linux-signer-gpg-sign @@ -235,6 +270,6 @@ do_step download-unsigned-sha256sums-gpg-signatures-from-people-tpo do_step sync-local-to-staticiforme do_step sync-scripts-to-staticiforme do_step staticiforme-prepare-cdn-dist-upload -! is_legacy && +! is_legacy && [ -n "$platform_desktop" ] && \ do_step upload-update_responses-to-staticiforme do_step finished-signing-clean-linux-signer ===================================== tools/signing/functions ===================================== @@ -76,5 +76,17 @@ function display_name { fi } +function rbm_showconf { + "$rbm" showconf release "$1" --target "$SIGNING_PROJECTNAME" \ + --target "$tbb_version_type" +} + +function rbm_showconf_boolean { + local res=$(rbm_showconf "$1") + if [ -z "$res" ] || [ "a$res" = "a0" ]; then + return + fi + echo '1' +} . "$script_dir/set-config" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.3.0esr-15.0-1] TB 43976: [android] Remove default browser prompt
by Dan Ballard (＠dan) 15 Sep '25

15 Sep '25

Dan Ballard pushed to branch tor-browser-140.3.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 3010729e by clairehurst at 2025-09-15T13:25:21-07:00 TB 43976: [android] Remove default browser prompt tor-browser#43976 Remove default browser prompt - - - - - 1 changed file: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt ===================================== @@ -2351,11 +2351,7 @@ class Settings(private val appContext: Context) : PreferencesHolder { * Indicates if the Set as default Browser prompt should be displayed to the user. */ val shouldShowSetAsDefaultPrompt: Boolean - get() = - (System.currentTimeMillis() - lastSetAsDefaultPromptShownTimeInMillis) > - DAYS_BETWEEN_DEFAULT_BROWSER_PROMPTS * ONE_DAY_MS && - numberOfSetAsDefaultPromptShownTimes < MAX_NUMBER_OF_DEFAULT_BROWSER_PROMPTS && - coldStartsBetweenSetAsDefaultPrompts >= APP_COLD_STARTS_TO_SHOW_DEFAULT_PROMPT + get() = false // bug_43976 Remove default browser prompt /** * Updates the relevant settings when the "Set as Default Browser" prompt is shown. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3010729… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3010729… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-140.3.0esr-15.0-1-build2
by ma1 (＠ma1) 15 Sep '25

15 Sep '25

ma1 pushed new tag mullvad-browser-140.3.0esr-15.0-1-build2 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0