April 2025 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-128.10.0esr-14.5-1] 3 commits: fixup! Firefox preference overrides.
by ma1 (＠ma1) 24 Apr '25

24 Apr '25

ma1 pushed to branch tor-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: c8aeedd4 by hackademix at 2025-04-24T15:47:41+02:00 fixup! Firefox preference overrides. Disable the UITour API. - - - - - c553d6f5 by gela at 2025-04-24T16:16:49+02:00 Bug 1929478 - Update log statement r=skhan Differential Revision: https://phabricator.services.mozilla.com/D242094 - - - - - 93f5e1fd by Titouan Thibaud at 2025-04-24T16:18:21+02:00 Bug 1945705 - Fix malformed download filename extracted from contentDisposition r=android-reviewers,rsainani Differential Revision: https://phabricator.services.mozilla.com/D241072 - - - - - 4 changed files: - browser/app/profile/001-base-profile.js - mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt - mobile/android/android-components/components/support/utils/src/main/java/mozilla/components/support/utils/DownloadUtils.kt - mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -208,6 +208,11 @@ pref("datareporting.policy.dataSubmissionEnabled", false); pref("browser.urlbar.recentsearches.featureGate", false); pref("browser.urlbar.suggest.recentsearches", false); +// Disable the UITour API +// See tor-browser#41457 and +// https://bugzilla.mozilla.org/show_bug.cgi?id=1915280 +pref("browser.uitour.enabled", false); + // Make sure Unified Telemetry is really disabled, see: #18738. pref("toolkit.telemetry.unified", false); // This needs to be locked, or nightly builds will automatically lock it to true ===================================== mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt ===================================== @@ -57,7 +57,6 @@ import mozilla.components.support.base.facts.Action import mozilla.components.support.base.facts.Fact import mozilla.components.support.base.facts.collect import mozilla.components.support.base.log.logger.Logger -import mozilla.components.support.ktx.kotlin.decode import mozilla.components.support.ktx.kotlin.isEmail import mozilla.components.support.ktx.kotlin.isExtensionUrl import mozilla.components.support.ktx.kotlin.isGeoLocation @@ -1524,7 +1523,7 @@ class GeckoEngineSession( url = url, contentLength = contentLength, contentType = DownloadUtils.sanitizeMimeType(contentType), - fileName = fileName.sanitizeFileName().decode(), + fileName = fileName.sanitizeFileName(), response = response, isPrivate = privateMode, openInApp = webResponse.requestExternalApp, ===================================== mobile/android/android-components/components/support/utils/src/main/java/mozilla/components/support/utils/DownloadUtils.kt ===================================== @@ -274,8 +274,9 @@ object DownloadUtils { private fun parseContentDisposition(contentDisposition: String): String? { return try { - parseContentDispositionWithFileName(contentDisposition) + val fileName = parseContentDispositionWithFileName(contentDisposition) ?: parseContentDispositionWithFileNameAsterisk(contentDisposition) + Uri.decode(fileName) } catch (ex: IllegalStateException) { // This function is defined as returning null when it can't parse the header null ===================================== mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java ===================================== @@ -211,7 +211,7 @@ public final class GeckoLoader { throw new IllegalStateException("Invalid library path for libmozglue.so: " + mozglue); } final String base = mozglue.substring(0, lastSlash); - Log.i(LOGTAG, "Library base=" + base); + Log.d(LOGTAG, "Library base=" + base); return base; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4b801a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4b801a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.10.0esr-14.5-1] fixup! Add CI for Base Browser
by brizental (＠brizental) 23 Apr '25

23 Apr '25

brizental pushed to branch mullvad-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 384e5ccc by Beatriz Rizental at 2025-04-23T21:26:32+02:00 fixup! Add CI for Base Browser Timeout `git fetch` if takes longer than 3min. Long fetched are very expensive and due to the amount of parallel jobs our CI can execute at a time too many long fetches can cause significant slowness on our Gitlab instance. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -1,6 +1,7 @@ .with-local-repo-bash: variables: GIT_STRATEGY: "none" + FETCH_TIMEOUT: 180 # 3 minutes before_script: - git init - git remote add local "$LOCAL_REPO_PATH" @@ -19,18 +20,38 @@ exit 1 fi - git fetch --depth 500 local $TARGET_BRANCH + - git --no-pager log FETCH_HEAD --oneline -n 5 - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then echo "No branch specified. Stopping the pipeline." exit 1 fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} with a ${FETCH_TIMEOUT}s timeout." - | - if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then - echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" - echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." - git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fetch_with_timeout() { + local remote=$1 + local branch=$2 + + set +e + timeout ${FETCH_TIMEOUT} git fetch "$remote" "$branch" + local fetch_exit=$? + set -e + + if [ "$fetch_exit" -eq 124 ]; then + echo "Fetching failed for branch ${remote}/${branch} due to a timeout. Try again later." + echo "Gitlab may be experiencing slowness or the local copy of the repository on the CI server may be oudated." + return 1 + fi + + return $fetch_exit + } + + if ! fetch_with_timeout origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo "Fetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}." + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + + fetch_with_timeout origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" || exit 1 fi - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/384… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/384… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.10.0esr-14.5-1] fixup! Add CI for Base Browser
by brizental (＠brizental) 23 Apr '25

23 Apr '25

brizental pushed to branch base-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 5d7a4431 by Beatriz Rizental at 2025-04-23T21:19:00+02:00 fixup! Add CI for Base Browser Timeout `git fetch` if takes longer than 3min. Long fetched are very expensive and due to the amount of parallel jobs our CI can execute at a time too many long fetches can cause significant slowness on our Gitlab instance. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -1,6 +1,7 @@ .with-local-repo-bash: variables: GIT_STRATEGY: "none" + FETCH_TIMEOUT: 180 # 3 minutes before_script: - git init - git remote add local "$LOCAL_REPO_PATH" @@ -19,18 +20,38 @@ exit 1 fi - git fetch --depth 500 local $TARGET_BRANCH + - git --no-pager log FETCH_HEAD --oneline -n 5 - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then echo "No branch specified. Stopping the pipeline." exit 1 fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} with a ${FETCH_TIMEOUT}s timeout." - | - if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then - echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" - echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." - git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fetch_with_timeout() { + local remote=$1 + local branch=$2 + + set +e + timeout ${FETCH_TIMEOUT} git fetch "$remote" "$branch" + local fetch_exit=$? + set -e + + if [ "$fetch_exit" -eq 124 ]; then + echo "Fetching failed for branch ${remote}/${branch} due to a timeout. Try again later." + echo "Gitlab may be experiencing slowness or the local copy of the repository on the CI server may be oudated." + return 1 + fi + + return $fetch_exit + } + + if ! fetch_with_timeout origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo "Fetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}." + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + + fetch_with_timeout origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" || exit 1 fi - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5d7a443… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5d7a443… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.10.0esr-14.5-1] fixup! Add CI for Base Browser
by brizental (＠brizental) 23 Apr '25

23 Apr '25

brizental pushed to branch tor-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 4b801ad7 by Beatriz Rizental at 2025-04-23T18:31:53+02:00 fixup! Add CI for Base Browser Timeout `git fetch` if takes longer than 3min. Long fetched are very expensive and due to the amount of parallel jobs our CI can execute at a time too many long fetches can cause significant slowness on our Gitlab instance. - - - - - 1 changed file: - .gitlab/ci/mixins.yml Changes: ===================================== .gitlab/ci/mixins.yml ===================================== @@ -1,6 +1,7 @@ .with-local-repo-bash: variables: GIT_STRATEGY: "none" + FETCH_TIMEOUT: 180 # 3 minutes before_script: - git init - git remote add local "$LOCAL_REPO_PATH" @@ -19,18 +20,38 @@ exit 1 fi - git fetch --depth 500 local $TARGET_BRANCH + - git --no-pager log FETCH_HEAD --oneline -n 5 - git remote add origin "$CI_REPOSITORY_URL" - | if [ -z "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" ]; then echo "No branch specified. Stopping the pipeline." exit 1 fi - - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}" + - echo "Fetching from remote branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} with a ${FETCH_TIMEOUT}s timeout." - | - if ! git fetch origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then - echo -e "\e[31mFetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} from $CI_REPOSITORY_URL.\e[0m" - echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." - git fetch origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" + fetch_with_timeout() { + local remote=$1 + local branch=$2 + + set +e + timeout ${FETCH_TIMEOUT} git fetch "$remote" "$branch" + local fetch_exit=$? + set -e + + if [ "$fetch_exit" -eq 124 ]; then + echo "Fetching failed for branch ${remote}/${branch} due to a timeout. Try again later." + echo "Gitlab may be experiencing slowness or the local copy of the repository on the CI server may be oudated." + return 1 + fi + + return $fetch_exit + } + + if ! fetch_with_timeout origin "${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}"; then + echo "Fetching failed for branch ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME}." + echo "Attempting to fetch the merge request branch, assuming this pipeline is not running in a fork." + + fetch_with_timeout origin "merge-requests/${CI_MERGE_REQUEST_IID}/head" || exit 1 fi - git checkout FETCH_HEAD View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4b801ad… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4b801ad… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.10.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed to branch base-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 6bb0d464 by Pier Angelo Vendrame at 2025-04-23T17:20:56+02:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 43672: Compensate window.resizeTo truncating by ceiling newwin sizes. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -958,7 +958,8 @@ class _RFPHelper { if (x11Height < targetHeight) { targetHeight = x11Height + 2; } - aWindow.resizeTo(targetWidth, targetHeight); + // resizeTo truncates on X11, so we compensate. + aWindow.resizeTo(Math.ceil(targetWidth), Math.ceil(targetHeight)); } else { aWindow.resizeBy(deltaWidth, deltaHeight); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6bb0d46… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6bb0d46… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.10.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: da091fd9 by Pier Angelo Vendrame at 2025-04-23T17:13:18+02:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 43672: Compensate window.resizeTo truncating by ceiling newwin sizes. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -958,7 +958,8 @@ class _RFPHelper { if (x11Height < targetHeight) { targetHeight = x11Height + 2; } - aWindow.resizeTo(targetWidth, targetHeight); + // resizeTo truncates on X11, so we compensate. + aWindow.resizeTo(Math.ceil(targetWidth), Math.ceil(targetHeight)); } else { aWindow.resizeBy(deltaWidth, deltaHeight); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/da0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/da0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.10.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed to branch tor-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 7369c198 by Pier Angelo Vendrame at 2025-04-23T16:28:43+02:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 43672: Compensate window.resizeTo truncating by ceiling newwin sizes. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -958,7 +958,8 @@ class _RFPHelper { if (x11Height < targetHeight) { targetHeight = x11Height + 2; } - aWindow.resizeTo(targetWidth, targetHeight); + // resizeTo truncates on X11, so we compensate. + aWindow.resizeTo(Math.ceil(targetWidth), Math.ceil(targetHeight)); } else { aWindow.resizeBy(deltaWidth, deltaHeight); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7369c19… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7369c19… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bump Firefox version to 128.10.0esr for nightly builds.
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0a8331c2 by Pier Angelo Vendrame at 2025-04-23T16:13:08+02:00 Bump Firefox version to 128.10.0esr for nightly builds. - - - - - 2 changed files: - projects/firefox/config - projects/geckoview/config Changes: ===================================== projects/firefox/config ===================================== @@ -15,12 +15,12 @@ container: use_container: 1 var: - firefox_platform_version: '128.9.0' + firefox_platform_version: '128.10.0' firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '14.5' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 2 + browser_build: 1 copyright_year: '[% exec("git show -s --format=%ci " _ c("git_hash") _ "^{commit}", { exec_noco => 1 }).remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser ===================================== projects/geckoview/config ===================================== @@ -17,12 +17,12 @@ container: build_apk: 1 var: - firefox_platform_version: '128.9.0' + firefox_platform_version: '128.10.0' geckoview_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '14.5' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 2 + browser_build: 1 gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser git_commit: '[% exec("git rev-parse " _ c("git_hash") _ "^{commit}", { exec_noco => 1 }) %]' deps: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.23.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed new tag tor-browser-115.23.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.10.0esr-14.5-1-build1
by Pier Angelo Vendrame (＠pierov) 23 Apr '25

23 Apr '25

Pier Angelo Vendrame pushed new tag mullvad-browser-128.10.0esr-14.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0