lists.torproject.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

tbb-commits

Thread Start a new thread
Download
Threads by month
  • ----- 2025 -----
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2019 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2018 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2017 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2016 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2015 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2014 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
tbb-commits@lists.torproject.org

March 2025

  • 1 participants
  • 234 discussions
[Git][tpo/applications/tor-browser-update-responses][main] 3 commits: release: new version, 14.0.8 (windows-i686)
by ma1 (@ma1) 27 Mar '25

27 Mar '25
ma1 pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: edc693a4 by hackademix at 2025-03-27T09:45:04+01:00 release: new version, 14.0.8 (windows-i686) - - - - - ad6bcc87 by hackademix at 2025-03-27T09:45:04+01:00 release: new version, 14.0.8 (windows-x86_64) - - - - - 0a4ae050 by hackademix at 2025-03-27T09:45:05+01:00 release: new version, 14.0.8 - - - - - 57 changed files: - update_3/release/.htaccess - − update_3/release/13.5.10-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/13.5.10-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/13.5.10-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/13.5.10-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/13.5.10-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/13.5.11-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/13.5.11-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/13.5.11-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/13.5.11-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/13.5.11-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/13.5.12-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/13.5.12-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/13.5.12-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/13.5.12-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/13.5.12-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/14.0.4-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/14.0.4-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/14.0.4-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/14.0.4-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/14.0.4-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/14.0.5-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/14.0.5-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/14.0.5-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/14.0.5-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/14.0.5-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/14.0.6-14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/14.0.6-14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/14.0.6-14.0.7+13.5.13-macos-ALL.xml - − update_3/release/14.0.6-14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/14.0.6-14.0.7+13.5.13-windows-x86_64-ALL.xml - − update_3/release/14.0.7+13.5.13-linux-i686-ALL.xml - − update_3/release/14.0.7+13.5.13-linux-x86_64-ALL.xml - − update_3/release/14.0.7+13.5.13-macos-ALL.xml - − update_3/release/14.0.7+13.5.13-windows-i686-ALL.xml - − update_3/release/14.0.7+13.5.13-windows-x86_64-ALL.xml - update_3/release/download-windows-i686.json - update_3/release/download-windows-x86_64.json - update_3/release/downloads.json - + update_3/release/windows-i686/.htaccess - + update_3/release/windows-i686/13.5.11-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/13.5.12-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/13.5.13-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/14.0.5-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/14.0.6-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/14.0.7-14.0.8+13.5.14-windows-i686.xml - + update_3/release/windows-i686/14.0.8+13.5.14-windows-i686.xml - update_3/release/no-update.xml → update_3/release/windows-i686/no-update.xml - + update_3/release/windows-x86_64/.htaccess - + update_3/release/windows-x86_64/13.5.11-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/13.5.12-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/13.5.13-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/14.0.5-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/14.0.6-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/14.0.7-14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/14.0.8+13.5.14-windows-x86_64.xml - + update_3/release/windows-x86_64/no-update.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5.14-build1
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed new tag tbb-13.5.14-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41416: Prepare Tor Browser 13.5.14 (Windows)
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 6340e344 by Morgan at 2025-03-26T22:08:37+00:00 Bug 41416: Prepare Tor Browser 13.5.14 (Windows) - - - - - 3 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/firefox/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,10 @@ +Tor Browser 13.5.14 - March 27 2025 + * Windows + * Bug 43592: Backport security fixes from Firefox 128.8.1esr [tor-browser] + * Build System + * Windows + * Bug 41383: Add clairehurst to list of accepted firefox/geckoview signers [tor-browser-build] + Tor Browser 13.5.13 - March 04 2025 * All Platforms * Updated Firefox to 115.21.0esr ===================================== projects/firefox/config ===================================== @@ -20,7 +20,7 @@ var: browser_series: '13.5' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 2 + browser_build: 3 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' ===================================== rbm.conf ===================================== @@ -73,18 +73,18 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '13.5.13' + torbrowser_version: '13.5.14' torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2025/03/03 17:00:00' + browser_release_date: '2025/03/26 22:07:00' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + - 13.5.13 - 13.5.12 - 13.5.11 - - 13.5.10 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.8.0esr-14.5-1] fixup! TB 42247: Android helpers for the TorProvider
by Pier Angelo Vendrame (@pierov) 26 Mar '25

26 Mar '25
Pier Angelo Vendrame pushed to branch tor-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 375a8c31 by Pier Angelo Vendrame at 2025-03-26T18:21:29+01:00 fixup! TB 42247: Android helpers for the TorProvider Use libLyrebird.so also in TorAndroidIntegration. - - - - - 1 changed file: - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java Changes: ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java ===================================== @@ -496,7 +496,7 @@ public class TorAndroidIntegration implements BundleEventListener { MeekTransport(final EventCallback callback, int id, String[] args) { setName("meek-" + id); - final String command = mLibraryDir + "/libObfs4proxy.so"; + final String command = mLibraryDir + "/libLyrebird.so"; ArrayList<String> argList = new ArrayList<String>(); argList.add(command); if (args != null && args.length > 0) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/375a8c3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/375a8c3… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.21.0esr-13.5-1-build3
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed new tag tor-browser-115.21.0esr-13.5-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-115.21.0esr-13.5-1] Bug 1956398 - Avoid duplicating pseudo-handles in ipc_channel_win.cc.
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed to branch tor-browser-115.21.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 2299557b by Yannis Juglaret at 2025-03-26T21:53:05+00:00 Bug 1956398 - Avoid duplicating pseudo-handles in ipc_channel_win.cc. Differential Revision: https://phabricator.services.mozilla.com/D243189 - - - - - 1 changed file: - ipc/chromium/src/chrome/common/ipc_channel_win.cc Changes: ===================================== ipc/chromium/src/chrome/common/ipc_channel_win.cc ===================================== @@ -27,6 +27,34 @@ using namespace mozilla::ipc; +namespace { + +// This logic is borrowed from Chromium's `base/win/win_util.h`. It allows us +// to distinguish pseudo-handle values, such as returned by GetCurrentProcess() +// (-1), GetCurrentThread() (-2), and potentially more. The code there claims +// that fuzzers have found issues up until -12 with DuplicateHandle. +// +// https://source.chromium.org/chromium/chromium/src/+/36dbbf38697dd1e23ef8944… +inline bool IsPseudoHandle(HANDLE handle) { + auto handleValue = static_cast<int32_t>(reinterpret_cast<uintptr_t>(handle)); + return -12 <= handleValue && handleValue < 0; +} + +// A real handle is a handle that is not a pseudo-handle. Always preferably use +// this variant over ::DuplicateHandle. Only use stock ::DuplicateHandle if you +// explicitly need the ability to duplicate a pseudo-handle. +inline bool DuplicateRealHandle(HANDLE source_process, HANDLE source_handle, + HANDLE target_process, LPHANDLE target_handle, + DWORD desired_access, BOOL inherit_handle, + DWORD options) { + MOZ_RELEASE_ASSERT(!IsPseudoHandle(source_handle)); + return static_cast<bool>(::DuplicateHandle( + source_process, source_handle, target_process, target_handle, + desired_access, inherit_handle, options)); +} + +} // namespace + namespace IPC { //------------------------------------------------------------------------------ @@ -732,9 +760,9 @@ bool Channel::ChannelImpl::AcceptHandles(Message& msg) { CHROMIUM_LOG(ERROR) << "other_process_ is invalid in AcceptHandles"; return false; } - if (!::DuplicateHandle(other_process_, handle, GetCurrentProcess(), - &handle, 0, FALSE, - DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { + if (!::DuplicateRealHandle( + other_process_, handle, GetCurrentProcess(), &handle, 0, FALSE, + DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { CHROMIUM_LOG(ERROR) << "DuplicateHandle failed for handle " << handle << " in AcceptHandles"; return false; @@ -787,9 +815,9 @@ bool Channel::ChannelImpl::TransferHandles(Message& msg) { CHROMIUM_LOG(ERROR) << "other_process_ is invalid in TransferHandles"; return false; } - if (!::DuplicateHandle(GetCurrentProcess(), handle, other_process_, - &handle, 0, FALSE, - DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { + if (!::DuplicateRealHandle( + GetCurrentProcess(), handle, other_process_, &handle, 0, FALSE, + DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { CHROMIUM_LOG(ERROR) << "DuplicateHandle failed for handle " << handle << " in TransferHandles"; return false; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2299557… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2299557… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag mb-14.0.8-build1
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed new tag mb-14.0.8-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-14.0.8-build1
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed new tag tbb-14.0.8-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][maint-14.0] Prepare Tor,Mullvad Browser 14.0.8 (Windows only)
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: e6c2f5cd by Morgan at 2025-03-26T21:47:20+00:00 Prepare Tor,Mullvad Browser 14.0.8 (Windows only) - - - - - 4 changed files: - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/firefox/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -1,3 +1,13 @@ +Mullvad Browser 14.0.8 - March 27 2025 + * Windows + * Bug 404: Incorrect information in `about:rights` [mullvad-browser] + * Bug 43592: Backport security fixes from Firefox 128.8.1esr [tor-browser] + * Build System + * Windows + * Bug 41375: Backport Bug 41374+40799: Remove support for migrate_archs and migrate_langs in update_responses + Remove legacy locale iteration in update-responses and dmg2mar [tor-browser-build] + * Bug 41378: Backport Bug 41363: Make separate update_responses commit for each platform [tor-browser-build] + * Bug 41383: Add clairehurst to list of accepted firefox/geckoview signers [tor-browser-build] + Mullvad Browser 14.0.7 - March 04 2025 * All Platforms * Updated Firefox to 128.8.0esr ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,15 @@ +Tor Browser 14.0.8 - March 27 2025 + * Windows + * Bug 43553: Backport tor-browser#43504: Implement User Survey UX (Desktop) [tor-browser] + * Bug 43592: Backport security fixes from Firefox 128.8.1esr [tor-browser] + * Build System + * Windows + * Bug 41375: Backport Bug 41374+40799: Remove support for migrate_archs and migrate_langs in update_responses + Remove legacy locale iteration in update-responses and dmg2mar [tor-browser-build] + * Bug 41383: Add clairehurst to list of accepted firefox/geckoview signers [tor-browser-build] + * Bug 41384: OpenSSL hash files have changed format [tor-browser-build] + * Bug 41399: Update snowflake to 2.11.0 and lyrebird to 0.6.0 [tor-browser-build] + * Bug 41378: Backport Bug 41363: Make separate update_responses commit for each platform [tor-browser-build] + Tor Browser 14.0.7 - March 04 2025 * All Platforms * Updated OpenSSL to 3.0.16 ===================================== projects/firefox/config ===================================== @@ -20,7 +20,7 @@ var: browser_series: '14.0' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 2 + browser_build: 3 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' ===================================== rbm.conf ===================================== @@ -73,22 +73,22 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '14.0.7' - torbrowser_build: 'build2' + torbrowser_version: '14.0.8' + torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2025/03/03 09:37:02' + browser_release_date: '2025/03/26 21:32:35' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + - 14.0.7 - '[% IF c("var/tor-browser") %]14.0.6[% END %]' - 14.0.5 - - 14.0.4 - - '[% IF c("var/mullvad-browser") %]14.0.3[% END %]' + - '[% IF c("var/mullvad-browser") %]14.0.4[% END %]' mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' - torbrowser_legacy_version: 13.5.13 + torbrowser_legacy_version: 13.5.14 torbrowser_legacy_platform_version: 115.21.0 # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.8.0esr-14.0-1] Bug 1956398 - Avoid duplicating pseudo-handles in ipc_channel_win.cc. r=nika a=RyanVM
by morgan (@morgan) 26 Mar '25

26 Mar '25
morgan pushed to branch mullvad-browser-128.8.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: d922b3f0 by Yannis Juglaret at 2025-03-26T20:48:42+00:00 Bug 1956398 - Avoid duplicating pseudo-handles in ipc_channel_win.cc. r=nika a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D243135 - - - - - 1 changed file: - ipc/chromium/src/chrome/common/ipc_channel_win.cc Changes: ===================================== ipc/chromium/src/chrome/common/ipc_channel_win.cc ===================================== @@ -30,6 +30,34 @@ using namespace mozilla::ipc; +namespace { + +// This logic is borrowed from Chromium's `base/win/win_util.h`. It allows us +// to distinguish pseudo-handle values, such as returned by GetCurrentProcess() +// (-1), GetCurrentThread() (-2), and potentially more. The code there claims +// that fuzzers have found issues up until -12 with DuplicateHandle. +// +// https://source.chromium.org/chromium/chromium/src/+/36dbbf38697dd1e23ef8944… +inline bool IsPseudoHandle(HANDLE handle) { + auto handleValue = static_cast<int32_t>(reinterpret_cast<uintptr_t>(handle)); + return -12 <= handleValue && handleValue < 0; +} + +// A real handle is a handle that is not a pseudo-handle. Always preferably use +// this variant over ::DuplicateHandle. Only use stock ::DuplicateHandle if you +// explicitly need the ability to duplicate a pseudo-handle. +inline bool DuplicateRealHandle(HANDLE source_process, HANDLE source_handle, + HANDLE target_process, LPHANDLE target_handle, + DWORD desired_access, BOOL inherit_handle, + DWORD options) { + MOZ_RELEASE_ASSERT(!IsPseudoHandle(source_handle)); + return static_cast<bool>(::DuplicateHandle( + source_process, source_handle, target_process, target_handle, + desired_access, inherit_handle, options)); +} + +} // namespace + namespace IPC { //------------------------------------------------------------------------------ @@ -595,7 +623,7 @@ bool Channel::ChannelImpl::AcceptHandles(Message& msg) { nsTArray<mozilla::UniqueFileHandle> handles(num_handles); for (uint32_t handleValue : payload) { HANDLE ipc_handle = Uint32ToHandle(handleValue); - if (!ipc_handle || ipc_handle == INVALID_HANDLE_VALUE) { + if (!ipc_handle || IsPseudoHandle(ipc_handle)) { CHROMIUM_LOG(ERROR) << "Attempt to accept invalid or null handle from process " << other_pid_ << " for message " << msg.name() << " in AcceptHandles"; @@ -613,9 +641,10 @@ bool Channel::ChannelImpl::AcceptHandles(Message& msg) { CHROMIUM_LOG(ERROR) << "other_process_ is invalid in AcceptHandles"; return false; } - if (!::DuplicateHandle(other_process_, ipc_handle, GetCurrentProcess(), - getter_Transfers(local_handle), 0, FALSE, - DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { + if (!DuplicateRealHandle( + other_process_, ipc_handle, GetCurrentProcess(), + getter_Transfers(local_handle), 0, FALSE, + DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) { DWORD err = GetLastError(); // Don't log out a scary looking error if this failed due to the target // process terminating. @@ -688,9 +717,9 @@ bool Channel::ChannelImpl::TransferHandles(Message& msg) { CHROMIUM_LOG(ERROR) << "other_process_ is invalid in TransferHandles"; return false; } - if (!::DuplicateHandle(GetCurrentProcess(), local_handle.get(), - other_process_, &ipc_handle, 0, FALSE, - DUPLICATE_SAME_ACCESS)) { + if (!DuplicateRealHandle(GetCurrentProcess(), local_handle.get(), + other_process_, &ipc_handle, 0, FALSE, + DUPLICATE_SAME_ACCESS)) { DWORD err = GetLastError(); // Don't log out a scary looking error if this failed due to the target // process terminating. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/d92… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/d92… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
  • ← Newer
  • 1
  • 2
  • 3
  • 4
  • 5
  • 6
  • 7
  • 8
  • 9
  • ...
  • 24
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.