July 2024 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41195: Simplify the go update in relprep.py.
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 1fb6aaae by Pier Angelo Vendrame at 2024-07-30T11:10:15+02:00 Bug 41195: Simplify the go update in relprep.py. Since we do not support Windows 7 anymore, we can use only one version of Go, and simplify the function that looks for updates in relprep.py. - - - - - f51f78b2 by Pier Angelo Vendrame at 2024-07-30T11:10:28+02:00 Bug 41200: Remove the tools for allowed_addons.json. For tor-browser#42618 and tor-browser#42619, we stopped using the allowed_addons.json, but initially we kept the tools to update it. However, the file creates some confusion, because it is used only for Andorid, but should be updated also when doing desktop-only releases when they update NoScript, or Android nightly builds might fail. So, since as a matter of fact we do not use that file anymore, we decided to stop updating it and remove the related tools. - - - - - 9 changed files: - − .gitattributes - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md - − projects/browser/allowed_addons.json - projects/browser/build.android - projects/browser/config - − projects/browser/verify_allowed_addons.py - − tools/fetch_allowed_addons.py - tools/relprep.py Changes: ===================================== .gitattributes deleted ===================================== @@ -1 +0,0 @@ -projects/browser/allowed_addons.json -diff ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -59,8 +59,6 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] `fenix_version` : update to match alpha `firefox-android` build tag - [ ] `browser_branch` : update to match alpha `firefox-android` build tag - [ ] `browser_build` : update to match alpha `firefox-android` build tag - - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-alpha` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -60,8 +60,6 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] `browser_branch` : update to match stable `firefox-android` build tag - [ ] `browser_build` : update to match stable `firefox-android` build tag variant: Beta - - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-release` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch ===================================== projects/browser/allowed_addons.json deleted ===================================== The diff for this file was not included because it is too large. ===================================== projects/browser/build.android ===================================== @@ -39,15 +39,6 @@ unzip ../omni.ja }) %] popd - -[% IF c("var/verify_allowed_addons") %] - # Check that allowed_addons.json contains the right versions of our bundled extension(s). - # If so, replace the default allowed_addons.json by ours in the apk assets folder. - $rootdir/verify_allowed_addons.py "$rootdir/allowed_addons.json" "$noscript_path" -[% END %] - -mv $rootdir/allowed_addons.json $assets_dir/allowed_addons.json - mkdir apk pushd apk 7zz x "$apk" ===================================== projects/browser/config ===================================== @@ -49,7 +49,6 @@ targets: android: build: '[% INCLUDE build.android %]' var: - verify_allowed_addons: 1 arch_deps: - 7zip - openjdk-17-jdk-headless @@ -160,10 +159,6 @@ input_files: enable: '[% c("var/namecoin") %]' - filename: namecoin.patch enable: '[% c("var/namecoin") %]' - - filename: allowed_addons.json - enable: '[% c("var/android") %]' - - filename: verify_allowed_addons.py - enable: '[% c("var/android") && c("var/verify_allowed_addons") %]' - project: manual name: manual enable: '[% ! c("var/android") && c("var/tor-browser") %]' ===================================== projects/browser/verify_allowed_addons.py deleted ===================================== @@ -1,49 +0,0 @@ -#!/usr/bin/env python3 - -import json -import sys -import hashlib -import zipfile - -def find_addon(addons, addon_id): - results = addons['results'] - for x in results: - addon = x['addon'] - if addon['guid'] == addon_id: - return addon - sys.exit("Error: cannot find addon " + addon_id) - -def verify_extension_version(addons, addon_id, version): - addon = find_addon(addons, addon_id) - expected_version = addon['current_version']['version'] - if version != expected_version: - sys.exit("Error: version " + version + " != " + expected_version) - -def verify_extension_hash(addons, addon_id, hash): - addon = find_addon(addons, addon_id) - expected_hash = addon["current_version"]["files"][0]["hash"] - if hash != expected_hash: - sys.exit("Error: hash " + hash + " != " + expected_hash) - -def read_extension_manifest(path): - return json.loads(zipfile.ZipFile(path, 'r').read('manifest.json')) - -def main(argv): - allowed_addons_path = argv[0] - noscript_path = argv[1] - - addons = None - with open(allowed_addons_path, 'r') as file: - addons = json.loads(file.read()) - - noscript_hash = None - with open(noscript_path, 'rb') as file: - noscript_hash = "sha256:" + hashlib.sha256(file.read()).hexdigest() - - noscript_version = read_extension_manifest(noscript_path)["version"] - - verify_extension_hash(addons, '{73a6fe31-595d-460b-a920-fcc0f8843232}', noscript_hash) - verify_extension_version(addons, '{73a6fe31-595d-460b-a920-fcc0f8843232}', noscript_version) - -if __name__ == "__main__": - main(sys.argv[1:]) ===================================== tools/fetch_allowed_addons.py deleted ===================================== @@ -1,53 +0,0 @@ -#!/usr/bin/env python3 - -import urllib.request -import json -import base64 -import sys - -NOSCRIPT = "{73a6fe31-595d-460b-a920-fcc0f8843232}" - - -def fetch(x): - with urllib.request.urlopen(x) as response: - return response.read() - - -def find_addon(addons, addon_id): - results = addons["results"] - for x in results: - addon = x["addon"] - if addon["guid"] == addon_id: - return addon - - -def fetch_and_embed_icons(addons): - results = addons["results"] - for x in results: - addon = x["addon"] - icon_data = fetch(addon["icon_url"]) - addon["icon_url"] = "data:image/png;base64," + str( - base64.b64encode(icon_data), "utf8" - ) - - -def fetch_allowed_addons(amo_collection=None): - if amo_collection is None: - amo_collection = "83a9cccfe6e24a34bd7b155ff9ee32" - url = f"https://services.addons.mozilla.org/api/v4/accounts/account/mozilla/collect…" - data = json.loads(fetch(url)) - fetch_and_embed_icons(data) - data["results"].sort(key=lambda x: x["addon"]["guid"]) - return data - - -def main(argv): - data = fetch_allowed_addons(argv[0] if len(argv) > 1 else None) - # Check that NoScript is present - if find_addon(data, NOSCRIPT) is None: - sys.exit("Error: cannot find NoScript.") - print(json.dumps(data, indent=2, ensure_ascii=False)) - - -if __name__ == "__main__": - main(sys.argv[1:]) ===================================== tools/relprep.py ===================================== @@ -4,7 +4,6 @@ from collections import namedtuple import configparser from datetime import datetime, timezone from hashlib import sha256 -import json import locale import logging from pathlib import Path @@ -16,7 +15,6 @@ from git import Repo import requests import ruamel.yaml -from fetch_allowed_addons import NOSCRIPT, fetch_allowed_addons, find_addon import fetch_changelogs from update_manual import update_manual @@ -303,28 +301,27 @@ class ReleasePreparation: logger.info("Updating addons") config = self.load_config("browser") - amo_data = fetch_allowed_addons() - logger.debug("Fetched AMO data") - if self.android: - with ( - self.base_path / "projects/browser/allowed_addons.json" - ).open("w") as f: - json.dump(amo_data, f, indent=2) - - noscript = find_addon(amo_data, NOSCRIPT) logger.debug("Updating NoScript") - self.update_addon_amo(config, "noscript", noscript) + self.update_addon_amo( + config, "noscript", "{73a6fe31-595d-460b-a920-fcc0f8843232}" + ) if self.mullvad_browser: logger.debug("Updating uBlock Origin") - ublock = find_addon(amo_data, "uBlock0(a)raymondhill.net") - self.update_addon_amo(config, "ublock-origin", ublock) + self.update_addon_amo( + config, "ublock-origin", "uBlock0(a)raymondhill.net" + ) logger.debug("Updating the Mullvad Browser extension") self.update_mullvad_addon(config) self.save_config("browser", config) - def update_addon_amo(self, config, name, addon): - addon = addon["current_version"]["files"][0] + def update_addon_amo(self, config, name, addon_id): + r = requests.get( + f"https://services.addons.mozilla.org/api/v4/addons/addon/{addon_id}" + ) + r.raise_for_status() + amo_data = r.json() + addon = amo_data["current_version"]["files"][0] assert addon["hash"].startswith("sha256:") addon_input = self.find_input(config, name) addon_input["URL"] = addon["url"] @@ -448,9 +445,9 @@ class ReleasePreparation: major = major[2:] return major + logger.info("Updating Go") config = self.load_config("go") - # TODO: When Windows 7 goes EOL use config["version"] - major = get_major(config["var"]["go_1_21"]) + major = get_major(config["version"]) r = requests.get("https://go.dev/dl/?mode=json") r.raise_for_status() @@ -463,7 +460,7 @@ class ReleasePreparation: if not data: raise KeyError("Could not find information for our Go series.") # Skip the "go" prefix in the version. - config["var"]["go_1_21"] = data["version"][2:] + config["version"] = data["version"][2:] sha256sum = "" for f in data["files"]: @@ -472,15 +469,7 @@ class ReleasePreparation: break if not sha256sum: raise KeyError("Go source package not found.") - updated_hash = False - for input_ in config["input_files"]: - if "URL" in input_ and "var/go_1_21" in input_["URL"]: - input_["sha256sum"] = sha256sum - updated_hash = True - break - if not updated_hash: - raise KeyError("Could not find a matching entry in input_files.") - + self.find_input(config, "go")["sha256sum"] = sha256sum self.save_config("go", config) def update_manual(self): @@ -556,18 +545,11 @@ class ReleasePreparation: # Sometimes this might be incorrect for alphas, but let's # keep it for now. kwargs["firefox"] += "esr" - self.check_update_simple(kwargs, prev_tag, "tor") - self.check_update_simple(kwargs, prev_tag, "openssl") - self.check_update_simple(kwargs, prev_tag, "zlib") - self.check_update_simple(kwargs, prev_tag, "zstd") - try: - self.check_update(kwargs, prev_tag, "go", ["var", "go_1_21"]) - except KeyError as e: - logger.warning( - "Go: var/go_1_21 not found, marking Go as not updated.", - exc_info=e, - ) - pass + self.check_update(kwargs, prev_tag, "tor") + self.check_update(kwargs, prev_tag, "openssl") + self.check_update(kwargs, prev_tag, "zlib") + self.check_update(kwargs, prev_tag, "zstd") + self.check_update(kwargs, prev_tag, "go") self.check_update_extensions(kwargs, prev_tag) logger.debug("Changelog arguments for %s: %s", tag_prefix, kwargs) cb = fetch_changelogs.ChangelogBuilder( @@ -587,7 +569,7 @@ class ReleasePreparation: with (self.base_path / path).open("w") as f: f.write(changelogs + "\n" + last_changelogs + "\n") - def check_update(self, updates, prev_tag, project, key): + def check_update(self, updates, prev_tag, project, key=["version"]): old_val = self.load_old_config(prev_tag.tag, project) new_val = self.load_config(project) for k in key: @@ -596,9 +578,6 @@ class ReleasePreparation: if old_val != new_val: updates[project] = new_val - def check_update_simple(self, updates, prev_tag, project): - self.check_update(updates, prev_tag, project, ["version"]) - def check_update_extensions(self, updates, prev_tag): old_config = self.load_old_config(prev_tag, "browser") new_config = self.load_config("browser") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_128_0esr_RELEASE
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed new tag FIREFOX_128_0esr_RELEASE at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-2] 3 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.0esr-14.0-2 at The Tor Project / Applications / Mullvad Browser Commits: f0717dcb by Beatriz Rizental at 2024-07-29T17:00:34+02:00 fixup! Add CI for Base Browser - - - - - 9448012d by Pier Angelo Vendrame at 2024-07-30T09:06:25+02:00 fixup! Firefox preference overrides. Bug 42872: Disable translations. Currently, the UX is kinda bad in Tor Browser (RFP might be a reason). Also, we should audit it first, to make sure it is not a fingerprinting concern (or if it is, we should make sure it is an acceptable one). - - - - - b94825b7 by Beatriz Rizental at 2024-07-30T12:25:35+02:00 Revert "Bug 42725: Fix upstream lint issues" This reverts commit 0c49b3f6b7101e95e33f697234648eeaef070a46. - - - - - 5 changed files: - .gitlab/ci/lint.yml - browser/app/profile/001-base-profile.js - dom/base/nsGlobalWindowOuter.cpp - dom/security/nsContentSecurityUtils.cpp - modules/libpref/Preferences.cpp Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -39,9 +39,8 @@ eslint: # The plugin implementing custom checks. - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -59,9 +58,8 @@ stylelint: # Run when stylelint policies change. - '**/.stylelintignore' - '**/*stylelintrc*' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -80,9 +78,8 @@ py-black: - '**/*.mozbuild' - 'pyproject.toml' - 'tools/lint/black.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -101,9 +98,8 @@ py-ruff: - 'tools/lint/ruff.yml' - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -118,9 +114,8 @@ yaml: - '**/*.yml' - '**/*.yaml' - '**/.ymllint' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -134,9 +129,8 @@ shellcheck: # - '**/*.sh' - 'tools/lint/shellcheck.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -156,9 +150,8 @@ clang-format: - '**/*.m' - '**/*.mm' - 'tools/lint/clang-format.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -172,9 +165,8 @@ rustfmt: # - '**/*.rs' - 'tools/lint/rustfmt.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -189,9 +181,8 @@ fluent-lint: - '**/*.ftl' - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -208,9 +199,8 @@ localization: - 'third_party/python/compare-locales/**' - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -227,9 +217,8 @@ mingw-capitalization: - '**/*.c' - '**/*.h' - 'tools/lint/mingw-capitalization.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,9 +235,8 @@ mscom-init: - '**/*.c' - '**/*.h' - 'tools/lint/mscom-init.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -277,9 +265,8 @@ file-whitespace: - '**/*.webidl' - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -294,9 +281,8 @@ test-manifest: - '**/*.ini' - 'python/mozlint/**' - 'tools/lint/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -315,6 +301,5 @@ trojan-source: - '**/*.py' - '**/*.rs' - 'tools/lint/trojan-source.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -259,6 +259,11 @@ pref("browser.newtabpage.activity-stream.asrouter.providers.messaging-experiment // Disable fetching asrouter.ftl and related console errors (tor-browser#40763). pref("browser.newtabpage.activity-stream.asrouter.useRemoteL10n", false); +// tor-browser#42872, #42555: Disable translations. +// Translation have a bad UX in 128 (and with our config). Maybe we will +// re-enable after auditing and fixing the UX. +pref("browser.translations.enable", false); + // tor-browser#41945 - disable automatic cookie banners dismissal until // we're sure it does not causes fingerprinting risks or other issues. pref("cookiebanners.service.mode", 0); ===================================== dom/base/nsGlobalWindowOuter.cpp ===================================== @@ -7296,7 +7296,7 @@ void nsGlobalWindowOuter::InitWasOffline() { mWasOffline = NS_IsOffline(); } #if defined(_WINDOWS_) && !defined(MOZ_WRAPPED_WINDOWS_H) # pragma message( \ - "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) + "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) # error "Never include unwrapped windows.h in this file!" #endif ===================================== dom/security/nsContentSecurityUtils.cpp ===================================== @@ -1332,20 +1332,20 @@ void nsContentSecurityUtils::AssertAboutPageHasCSP(Document* aDocument) { // This allowlist contains about: pages that are permanently allowed to // render without a CSP applied. static nsLiteralCString sAllowedAboutPagesWithNoCSP[] = { - // about:blank is a special about page -> no CSP - "about:blank"_ns, - // about:srcdoc is a special about page -> no CSP - "about:srcdoc"_ns, - // about:sync-log displays plain text only -> no CSP - "about:sync-log"_ns, - // about:logo just displays the firefox logo -> no CSP - "about:logo"_ns, - // about:sync is a special mozilla-signed developer addon with low usage - // -> - // no CSP - "about:sync"_ns, + // about:blank is a special about page -> no CSP + "about:blank"_ns, + // about:srcdoc is a special about page -> no CSP + "about:srcdoc"_ns, + // about:sync-log displays plain text only -> no CSP + "about:sync-log"_ns, + // about:logo just displays the firefox logo -> no CSP + "about:logo"_ns, + // about:sync is a special mozilla-signed developer addon with low usage + // -> + // no CSP + "about:sync"_ns, # if defined(ANDROID) - "about:config"_ns, + "about:config"_ns, # endif }; ===================================== modules/libpref/Preferences.cpp ===================================== @@ -6100,8 +6100,7 @@ void UnloadPrefsModule() { Preferences::Shutdown(); } // Preference Sanitization Related Code --------------------------------------- -#define PREF_LIST_ENTRY(s) \ - { s, (sizeof(s) / sizeof(char)) - 1 } +#define PREF_LIST_ENTRY(s) {s, (sizeof(s) / sizeof(char)) - 1} struct PrefListEntry { const char* mPrefBranch; size_t mLen; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/d7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/d7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.0esr-14.0-2] Revert "Bug 42725: Fix upstream lint issues"
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch base-browser-128.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: b94825b7 by Beatriz Rizental at 2024-07-30T12:25:35+02:00 Revert "Bug 42725: Fix upstream lint issues" This reverts commit 0c49b3f6b7101e95e33f697234648eeaef070a46. - - - - - 3 changed files: - dom/base/nsGlobalWindowOuter.cpp - dom/security/nsContentSecurityUtils.cpp - modules/libpref/Preferences.cpp Changes: ===================================== dom/base/nsGlobalWindowOuter.cpp ===================================== @@ -7296,7 +7296,7 @@ void nsGlobalWindowOuter::InitWasOffline() { mWasOffline = NS_IsOffline(); } #if defined(_WINDOWS_) && !defined(MOZ_WRAPPED_WINDOWS_H) # pragma message( \ - "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) + "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) # error "Never include unwrapped windows.h in this file!" #endif ===================================== dom/security/nsContentSecurityUtils.cpp ===================================== @@ -1332,20 +1332,20 @@ void nsContentSecurityUtils::AssertAboutPageHasCSP(Document* aDocument) { // This allowlist contains about: pages that are permanently allowed to // render without a CSP applied. static nsLiteralCString sAllowedAboutPagesWithNoCSP[] = { - // about:blank is a special about page -> no CSP - "about:blank"_ns, - // about:srcdoc is a special about page -> no CSP - "about:srcdoc"_ns, - // about:sync-log displays plain text only -> no CSP - "about:sync-log"_ns, - // about:logo just displays the firefox logo -> no CSP - "about:logo"_ns, - // about:sync is a special mozilla-signed developer addon with low usage - // -> - // no CSP - "about:sync"_ns, + // about:blank is a special about page -> no CSP + "about:blank"_ns, + // about:srcdoc is a special about page -> no CSP + "about:srcdoc"_ns, + // about:sync-log displays plain text only -> no CSP + "about:sync-log"_ns, + // about:logo just displays the firefox logo -> no CSP + "about:logo"_ns, + // about:sync is a special mozilla-signed developer addon with low usage + // -> + // no CSP + "about:sync"_ns, # if defined(ANDROID) - "about:config"_ns, + "about:config"_ns, # endif }; ===================================== modules/libpref/Preferences.cpp ===================================== @@ -6100,8 +6100,7 @@ void UnloadPrefsModule() { Preferences::Shutdown(); } // Preference Sanitization Related Code --------------------------------------- -#define PREF_LIST_ENTRY(s) \ - { s, (sizeof(s) / sizeof(char)) - 1 } +#define PREF_LIST_ENTRY(s) {s, (sizeof(s) / sizeof(char)) - 1} struct PrefListEntry { const char* mPrefBranch; size_t mLen; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b94825b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b94825b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-2] Revert "Bug 42725: Fix upstream lint issues"
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch tor-browser-128.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: 3599a60b by Beatriz Rizental at 2024-07-30T11:15:51+02:00 Revert "Bug 42725: Fix upstream lint issues" This reverts commit 0c49b3f6b7101e95e33f697234648eeaef070a46. - - - - - 3 changed files: - dom/base/nsGlobalWindowOuter.cpp - dom/security/nsContentSecurityUtils.cpp - modules/libpref/Preferences.cpp Changes: ===================================== dom/base/nsGlobalWindowOuter.cpp ===================================== @@ -7300,7 +7300,7 @@ void nsGlobalWindowOuter::InitWasOffline() { mWasOffline = NS_IsOffline(); } #if defined(_WINDOWS_) && !defined(MOZ_WRAPPED_WINDOWS_H) # pragma message( \ - "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) + "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON) # error "Never include unwrapped windows.h in this file!" #endif ===================================== dom/security/nsContentSecurityUtils.cpp ===================================== @@ -1335,20 +1335,20 @@ void nsContentSecurityUtils::AssertAboutPageHasCSP(Document* aDocument) { // This allowlist contains about: pages that are permanently allowed to // render without a CSP applied. static nsLiteralCString sAllowedAboutPagesWithNoCSP[] = { - // about:blank is a special about page -> no CSP - "about:blank"_ns, - // about:srcdoc is a special about page -> no CSP - "about:srcdoc"_ns, - // about:sync-log displays plain text only -> no CSP - "about:sync-log"_ns, - // about:logo just displays the firefox logo -> no CSP - "about:logo"_ns, - // about:sync is a special mozilla-signed developer addon with low usage - // -> - // no CSP - "about:sync"_ns, + // about:blank is a special about page -> no CSP + "about:blank"_ns, + // about:srcdoc is a special about page -> no CSP + "about:srcdoc"_ns, + // about:sync-log displays plain text only -> no CSP + "about:sync-log"_ns, + // about:logo just displays the firefox logo -> no CSP + "about:logo"_ns, + // about:sync is a special mozilla-signed developer addon with low usage + // -> + // no CSP + "about:sync"_ns, # if defined(ANDROID) - "about:config"_ns, + "about:config"_ns, # endif }; ===================================== modules/libpref/Preferences.cpp ===================================== @@ -6100,8 +6100,7 @@ void UnloadPrefsModule() { Preferences::Shutdown(); } // Preference Sanitization Related Code --------------------------------------- -#define PREF_LIST_ENTRY(s) \ - { s, (sizeof(s) / sizeof(char)) - 1 } +#define PREF_LIST_ENTRY(s) {s, (sizeof(s) / sizeof(char)) - 1} struct PrefListEntry { const char* mPrefBranch; size_t mLen; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3599a60… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3599a60… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: f5246bd3 by Pier Angelo Vendrame at 2024-07-30T09:34:47+02:00 fixup! Firefox preference overrides. Bug 42872: Disable translations. Currently, the UX is kinda bad in Tor Browser (RFP might be a reason). Also, we should audit it first, to make sure it is not a fingerprinting concern (or if it is, we should make sure it is an acceptable one). - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -259,6 +259,11 @@ pref("browser.newtabpage.activity-stream.asrouter.providers.messaging-experiment // Disable fetching asrouter.ftl and related console errors (tor-browser#40763). pref("browser.newtabpage.activity-stream.asrouter.useRemoteL10n", false); +// tor-browser#42872, #42555: Disable translations. +// Translation have a bad UX in 128 (and with our config). Maybe we will +// re-enable after auditing and fixing the UX. +pref("browser.translations.enable", false); + // tor-browser#41945 - disable automatic cookie banners dismissal until // we're sure it does not causes fingerprinting risks or other issues. pref("cookiebanners.service.mode", 0); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f52… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f52… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-2] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 30 Jul '24

30 Jul '24

Pier Angelo Vendrame pushed to branch tor-browser-128.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: f5137417 by Pier Angelo Vendrame at 2024-07-29T18:45:42+02:00 fixup! Firefox preference overrides. Bug 42872: Disable translations. Currently, the UX is kinda bad in Tor Browser (RFP might be a reason). Also, we should audit it first, to make sure it is not a fingerprinting concern (or if it is, we should make sure it is an acceptable one). - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -259,6 +259,11 @@ pref("browser.newtabpage.activity-stream.asrouter.providers.messaging-experiment // Disable fetching asrouter.ftl and related console errors (tor-browser#40763). pref("browser.newtabpage.activity-stream.asrouter.useRemoteL10n", false); +// tor-browser#42872, #42555: Disable translations. +// Translation have a bad UX in 128 (and with our config). Maybe we will +// re-enable after auditing and fixing the UX. +pref("browser.translations.enable", false); + // tor-browser#41945 - disable automatic cookie banners dismissal until // we're sure it does not causes fingerprinting risks or other issues. pref("cookiebanners.service.mode", 0); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f513741… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f513741… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41194: Add user morgan on signing machines
by boklm (＠boklm) 30 Jul '24

30 Jul '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 92bd7662 by Nicolas Vigier at 2024-07-30T08:21:56+02:00 Bug 41194: Add user morgan on signing machines - - - - - 2 changed files: - tools/signing/machines-setup/setup-signing-machine - + tools/signing/machines-setup/ssh-keys/morgan.pub Changes: ===================================== tools/signing/machines-setup/setup-signing-machine ===================================== @@ -96,6 +96,8 @@ sudoers_file set-date authorized_keys boklm boklm-tb-release.pub boklm-yk1.pub create_user richard signing authorized_keys richard richard.pub +create_user morgan signing +authorized_keys morgan morgan.pub # Install rbm deps install_packages libyaml-libyaml-perl libtemplate-perl libdatetime-perl \ ===================================== tools/signing/machines-setup/ssh-keys/morgan.pub ===================================== @@ -0,0 +1 @@ +ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCxOZQLd6QSfBYAdGKeptwqrxcLiV6yHY6cEhMWIWMHQFY5sdhSqpg+T5+L9PYHr1Gl3f7+YXUqKXpGnqLY9fVUEas/zxa8D9//P2fG838uphqTk12wvlN2kuLzyo9s8sQmNZVEJ0w3ktc3e6CDv2wikKw5opmBaHXf2LKk/5HjawcjSLPdXVZVlEby8EprIHjb0a8Zn46WYRtUwUEIPrrFsbq97cEt0oMu1mVvdLR+G5nzSxQdKP0XnGu//PND5z7DvCIJA9bwaA3vV9R2uvmvyn9n5p1zxX6yiHwz2OVUoXyetemXtsMFGlHUZV4XAMcJPz00MZQFjAChsb8C4IyFMdWBiLng70PuFGGnIdx0ZX1TA3Gum2tNwdX9+pFT+0gxN0I4hFC0+PSxqGpmZtGZ1D1ZQeQuZwBMf4u5f/24kw/b9jkasuUGMTtLdD0wwmT8sSuOSyusroMmrHaofFX6Ciu7DnmFwyFqvemz7GNX9R1A2GzGYejBcvr4SuWonQ1mEy0mvhaDZn935IplwsF2aYNjGxH1Hpjo5362JfFpEaEfKvzkotQ9bNXoznseztQCzhEB8DielOYJ/ZDcKtFijHIzMNr9pj0qnLAdBjRarWpd8n+erF82GKoBmSi7BOXgck1i/R1meyvb494wl+lFZL+89FZZ5ZGSn1+j1RkMFw== openpgp:0xF65B11DA View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.0esr-14.0-2] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 29 Jul '24

29 Jul '24

Pier Angelo Vendrame pushed to branch base-browser-128.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: f0717dcb by Beatriz Rizental at 2024-07-29T17:00:34+02:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -39,9 +39,8 @@ eslint: # The plugin implementing custom checks. - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -59,9 +58,8 @@ stylelint: # Run when stylelint policies change. - '**/.stylelintignore' - '**/*stylelintrc*' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -80,9 +78,8 @@ py-black: - '**/*.mozbuild' - 'pyproject.toml' - 'tools/lint/black.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -101,9 +98,8 @@ py-ruff: - 'tools/lint/ruff.yml' - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -118,9 +114,8 @@ yaml: - '**/*.yml' - '**/*.yaml' - '**/.ymllint' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -134,9 +129,8 @@ shellcheck: # - '**/*.sh' - 'tools/lint/shellcheck.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -156,9 +150,8 @@ clang-format: - '**/*.m' - '**/*.mm' - 'tools/lint/clang-format.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -172,9 +165,8 @@ rustfmt: # - '**/*.rs' - 'tools/lint/rustfmt.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -189,9 +181,8 @@ fluent-lint: - '**/*.ftl' - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -208,9 +199,8 @@ localization: - 'third_party/python/compare-locales/**' - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -227,9 +217,8 @@ mingw-capitalization: - '**/*.c' - '**/*.h' - 'tools/lint/mingw-capitalization.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,9 +235,8 @@ mscom-init: - '**/*.c' - '**/*.h' - 'tools/lint/mscom-init.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -277,9 +265,8 @@ file-whitespace: - '**/*.webidl' - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -294,9 +281,8 @@ test-manifest: - '**/*.ini' - 'python/mozlint/**' - 'tools/lint/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -315,6 +301,5 @@ trojan-source: - '**/*.py' - '**/*.rs' - 'tools/lint/trojan-source.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f0717dc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f0717dc… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 29 Jul '24

29 Jul '24

Pier Angelo Vendrame pushed to branch base-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: d23b4d80 by Beatriz Rizental at 2024-07-29T16:53:19+02:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -39,9 +39,8 @@ eslint: # The plugin implementing custom checks. - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -59,9 +58,8 @@ stylelint: # Run when stylelint policies change. - '**/.stylelintignore' - '**/*stylelintrc*' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -80,9 +78,8 @@ py-black: - '**/*.mozbuild' - 'pyproject.toml' - 'tools/lint/black.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -101,9 +98,8 @@ py-ruff: - 'tools/lint/ruff.yml' - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -118,9 +114,8 @@ yaml: - '**/*.yml' - '**/*.yaml' - '**/.ymllint' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -134,9 +129,8 @@ shellcheck: # - '**/*.sh' - 'tools/lint/shellcheck.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -156,9 +150,8 @@ clang-format: - '**/*.m' - '**/*.mm' - 'tools/lint/clang-format.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -172,9 +165,8 @@ rustfmt: # - '**/*.rs' - 'tools/lint/rustfmt.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -189,9 +181,8 @@ fluent-lint: - '**/*.ftl' - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -208,9 +199,8 @@ localization: - 'third_party/python/compare-locales/**' - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -227,9 +217,8 @@ mingw-capitalization: - '**/*.c' - '**/*.h' - 'tools/lint/mingw-capitalization.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,9 +235,8 @@ mscom-init: - '**/*.c' - '**/*.h' - 'tools/lint/mscom-init.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -277,9 +265,8 @@ file-whitespace: - '**/*.webidl' - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -294,9 +281,8 @@ test-manifest: - '**/*.ini' - 'python/mozlint/**' - 'tools/lint/**' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -315,6 +301,5 @@ trojan-source: - '**/*.py' - '**/*.rs' - 'tools/lint/trojan-source.yml' - # Run job whenever a new tag is created - # or whenever a commit is merged to a protected branch - - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + # Run job whenever a commit is merged to a protected branch + - if: $CI_COMMIT_REF_PROTECTED == 'true' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d23b4d8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d23b4d8… You're receiving this email because of your account on gitlab.torproject.org.

1 0