tbb-commits February 2024

tbb-commits@lists.torproject.org

1 participants
119 discussions

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.0-1] 148 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 1ff573ba by Eitan Isaacson at 2024-02-13T15:35:55+01:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - ea6ec61f by Pier Angelo Vendrame at 2024-02-13T15:35:56+01:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - cd21687c by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 01db88e3 by Emilio Cobos Álvarez at 2024-02-13T15:35:57+01:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - 20caec70 by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - e76ec667 by Eden Chuang at 2024-02-13T15:35:58+01:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - db29a461 by edgul at 2024-02-13T15:35:58+01:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 9905a6e1 by Kelsey Gilbert at 2024-02-13T15:35:58+01:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 8ed23104 by Mark Banner at 2024-02-13T15:35:59+01:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 94e906d7 by Bob Owen at 2024-02-13T15:35:59+01:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - 55fe491e by Malte Juergens at 2024-02-13T15:35:59+01:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - b0b0a24d by Andreas Pehrson at 2024-02-13T15:36:00+01:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - feabaf38 by Pier Angelo Vendrame at 2024-02-13T15:36:00+01:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 258558af by Kagami Sascha Rosylight at 2024-02-13T15:36:00+01:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - 1cc25fc0 by hackademix at 2024-02-13T15:36:01+01:00 Bug 1867408 - NSS backport - - - - - 96bb18ba by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 38a8d1e5 by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - c6616f5c by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 983c7435 by hackademix at 2024-02-13T15:36:02+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - de24dc95 by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - d631563b by Pier Angelo Vendrame at 2024-02-13T15:36:03+01:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 7d181dcf by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 7212fe93 by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 8d847060 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 4f008554 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 2788c0b2 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 2d6d4513 by Marco Simonelli at 2024-02-13T15:36:05+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - dc1e5d0e by hackademix at 2024-02-13T15:36:05+01:00 Bug 41854: Allow overriding download spam protection. - - - - - 427b5d2a by Gaba at 2024-02-13T15:36:05+01:00 Adding issue and merge request templates - - - - - b65ea961 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 4d9f4c60 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 357b1daa by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 27f02b77 by Dan Ballard at 2024-02-13T15:36:07+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 7cf37922 by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - fd35fdae by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 82735a0b by Mike Perry at 2024-02-13T15:36:08+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - d53822d0 by Alex Catarineu at 2024-02-13T15:36:08+01:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 5063553b by Georg Koppen at 2024-02-13T15:36:08+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - fe24a482 by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 7986c3ef by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - cfd2af09 by Alex Catarineu at 2024-02-13T15:36:09+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 96e9cf00 by Kathy Brade at 2024-02-13T15:36:10+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 059c7544 by Arthur Edelstein at 2024-02-13T15:36:10+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 6d90bfa1 by Alex Catarineu at 2024-02-13T15:36:10+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 8f8de0cc by cypherpunks1 at 2024-02-13T15:36:11+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 53ec05d6 by Pier Angelo Vendrame at 2024-02-13T15:36:13+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - c6b505a2 by Georg Koppen at 2024-02-13T15:36:14+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - d800519b by Alex Catarineu at 2024-02-13T15:36:14+01:00 Bug 28369: Stop shipping pingsender executable - - - - - 886a80a4 by cypherpunks1 at 2024-02-13T15:36:14+01:00 Bug 41568: Disable LaterRun - - - - - de9129ee by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40717: Hide Windows SSO in settings - - - - - 6b1d5bdb by Pier Angelo Vendrame at 2024-02-13T15:36:15+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 00e78e01 by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - 462140d4 by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 2b55e39d by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 42037: Disable about:firefoxview page - - - - - ada81f7b by Mike Perry at 2024-02-13T15:36:16+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 9c5f7f1d by Richard Pospesel at 2024-02-13T15:36:17+01:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 5c3896f3 by Pier Angelo Vendrame at 2024-02-13T15:36:17+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 0c2baaea by Alex Catarineu at 2024-02-13T15:36:17+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 91e3c31f by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 575a2254 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 617aaaf7 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 26345: Hide tracking protection UI - - - - - ea88db06 by Pier Angelo Vendrame at 2024-02-13T15:36:19+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - aabeab37 by Alex Catarineu at 2024-02-13T15:36:19+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 78b3840a by Mike Perry at 2024-02-13T15:36:19+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - cbd37725 by Igor Oliveira at 2024-02-13T15:36:20+01:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - 7a3f5d85 by Pier Angelo Vendrame at 2024-02-13T15:36:20+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 5db07efa by Matthew Finkel at 2024-02-13T15:36:20+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - abd7957d by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 62d5526b by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 95810c87 by hackademix at 2024-02-13T15:36:21+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - a8817d3c by Pier Angelo Vendrame at 2024-02-13T15:36:22+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - de094c82 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 8aaafe35 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 36307532 by hackademix at 2024-02-13T15:36:23+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - a18bf959 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - b33e0367 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 84ab11e9 by hackademix at 2024-02-13T15:36:24+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - be50d348 by Pier Angelo Vendrame at 2024-02-13T15:36:24+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - f92ee37e by p13dz at 2024-02-13T15:36:24+01:00 Bug 40283: Workaround for the file upload bug - - - - - 5737f18d by Arthur Edelstein at 2024-02-13T15:36:25+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d29f9a84 by cypherpunks1 at 2024-02-13T15:36:25+01:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 0b646c54 by Pier Angelo Vendrame at 2024-02-13T15:36:25+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 49c20556 by cypherpunks1 at 2024-02-13T15:36:26+01:00 Bug 41881: Don't persist custom network requests on private windows - - - - - 099112ed by hackademix at 2024-02-13T15:36:26+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 84b6000b by hackademix at 2024-02-13T15:36:26+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - e3e3fcb3 by Pier Angelo Vendrame at 2024-02-13T15:36:27+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - f4dfff28 by Henry Wilkes at 2024-02-13T15:36:27+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 692451a7 by Kathy Brade at 2024-02-13T15:36:27+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 928a5aab by Pier Angelo Vendrame at 2024-02-13T15:36:28+01:00 Bug 42061: Create an alpha update channel. - - - - - 6d0eb8d0 by Nicolas Vigier at 2024-02-13T15:36:30+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 38e720ec by hackademix at 2024-02-13T15:36:30+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 0946a79a by Pier Angelo Vendrame at 2024-02-13T15:36:30+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - ca13cc77 by Alex Catarineu at 2024-02-13T15:36:31+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - 746f65d8 by Matthew Finkel at 2024-02-13T15:36:31+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 2dbae111 by Henry Wilkes at 2024-02-13T15:36:31+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 4ed98f58 by hackademix at 2024-02-13T15:36:32+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - b58ebedd by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 0b624e2c by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40926: Implemented the New Identity feature - - - - - 44562cdf by Henry Wilkes at 2024-02-13T15:36:33+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - 63c89ddb by Pier Angelo Vendrame at 2024-02-13T15:36:33+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 06096579 by Richard Pospesel at 2024-02-13T15:36:33+01:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 2cfc71d1 by Richard Pospesel at 2024-02-13T15:36:34+01:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 81c44726 by Henry Wilkes at 2024-02-13T15:36:34+01:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 1aaf0ad3 by Kathy Brade at 2024-02-13T15:36:34+01:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 72717475 by Alex Catarineu at 2024-02-13T15:36:35+01:00 Add TorStrings module for localization - - - - - b2c89b4b by Henry Wilkes at 2024-02-13T15:36:35+01:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 0f10f5bf by Henry Wilkes at 2024-02-13T15:36:35+01:00 Tor Browser localization migration scripts. - - - - - a4d43615 by Mike Perry at 2024-02-13T15:36:35+01:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - be86025b by sanketh at 2024-02-13T15:36:36+01:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - a8a2601f by Mike Perry at 2024-02-13T15:36:36+01:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 172d0f39 by Henry Wilkes at 2024-02-13T15:36:36+01:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - dbdb6f1e by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - bf736c38 by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 2cecd659 by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - b5d0467a by Richard Pospesel at 2024-02-13T15:36:38+01:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 87b29fb9 by Arthur Edelstein at 2024-02-13T15:36:38+01:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - f189310a by Pier Angelo Vendrame at 2024-02-13T17:59:22+01:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42338: Make TorDomainIsolator.newCircuitForDomain public again - - - - - 2f2331d4 by Henry Wilkes at 2024-02-13T17:59:22+01:00 Bug 41600: Add a tor circuit display panel. - - - - - 8f2007b7 by hackademix at 2024-02-13T17:59:22+01:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - e5920efb by Amogh Pradeep at 2024-02-13T17:59:22+01:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 1ff16251 by Matthew Finkel at 2024-02-13T17:59:22+01:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 30491081 by Kathy Brade at 2024-02-13T17:59:23+01:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - a09124a4 by Pier Angelo Vendrame at 2024-02-13T17:59:23+01:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - aafc8168 by Richard Pospesel at 2024-02-13T17:59:23+01:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - f203c6e0 by Richard Pospesel at 2024-02-13T17:59:23+01:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - b3f82123 by Henry Wilkes at 2024-02-13T17:59:23+01:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - bdd4c35d by Arthur Edelstein at 2024-02-13T17:59:24+01:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 9cf39f57 by Pier Angelo Vendrame at 2024-02-13T17:59:24+01:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - de9005ce by Nicolas Vigier at 2024-02-13T17:59:24+01:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 42293: Don't disable updater when run by torbrowser-launcher flatpak When the TORBROWSER_LAUNCHER environment variable is set (which is set by torbrowser-launcher since version 0.3.7) we assume that Tor Browser is not installed by a Flatkpak. Although torbrowser-launcher itself can be installed by a Flatpak, this should not prevent the updater from working. - - - - - 354c787e by Kathy Brade at 2024-02-13T17:59:24+01:00 Bug 12647: Support symlinks in the updater. - - - - - 8f708ebd by Kathy Brade at 2024-02-13T17:59:25+01:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 4bc6c157 by Kathy Brade at 2024-02-13T17:59:25+01:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - f2665165 by Georg Koppen at 2024-02-13T17:59:25+01:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 307520b3 by Mike Perry at 2024-02-13T17:59:25+01:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - b4721cca by Alex Catarineu at 2024-02-13T17:59:25+01:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - a31c3ac6 by Henry Wilkes at 2024-02-13T17:59:26+01:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 5f6febc4 by Richard Pospesel at 2024-02-13T17:59:26+01:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - b713c619 by Kathy Brade at 2024-02-13T17:59:26+01:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 2823a6f7 by Alex Catarineu at 2024-02-13T17:59:26+01:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 84397887 by Pier Angelo Vendrame at 2024-02-13T17:59:26+01:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 701ad8ca by Pier Angelo Vendrame at 2024-02-13T17:59:27+01:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 59b69a8f by Pier Angelo Vendrame at 2024-02-13T17:59:27+01:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - fa20074e by Henry Wilkes at 2024-02-13T17:59:27+01:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - a5dcc0f3 by Dan Ballard at 2024-02-13T17:59:27+01:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 53500621 by Henry Wilkes at 2024-02-13T17:59:28+01:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 200d19ec by hackademix at 2024-02-13T17:59:28+01:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 56254e66 by Henry Wilkes at 2024-02-13T17:59:28+01:00 Customize moz-toggle for tor-browser. - - - - - c436030e by Richard Pospesel at 2024-02-13T17:59:28+01:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_8_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_8_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41076: Include the ShellLink plugin in NSIS.
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: a382aeb7 by Pier Angelo Vendrame at 2024-02-13T19:09:27+01:00 Bug 41076: Include the ShellLink plugin in NSIS. We will need this plugin for the Mullvad Browser uninstaller. - - - - - 8deb68f2 by Pier Angelo Vendrame at 2024-02-13T19:09:29+01:00 Bug 41077: Draft the new installer for Mullvad Browser. The installer for Mullvad Browser is going to be different from Tor Browser's, because it will offer both a traditional installation (at the moment only for the current user, to avoid enabling privilege elevation code paths, but still with a control panel entry) and portable "installations". The traditional one will support also setting MB as the default browser and file associations. However, this is quite tricky, and having a base installer to start implementing the feature is helpful. Thus this commit, even though the final installer will be likely changed. - - - - - 15 changed files: - projects/browser/build - projects/browser/config - − projects/browser/windows-installer.nsi - + projects/browser/windows-installer/browser-install.nsi - + projects/browser/windows-installer/browser-portable.nsi - + projects/browser/windows-installer/common.nsh - + projects/browser/windows-installer/defines.nsh.in - + projects/browser/windows-installer/language-map.sh - + projects/browser/windows-installer/languages.nsh - + projects/browser/windows-installer/postupdate.nsi - + projects/browser/windows-installer/registry.nsh - + projects/nsis/ShellLink.cpp - projects/nsis/build - projects/nsis/config - rbm.conf Changes: ===================================== projects/browser/build ===================================== @@ -303,9 +303,27 @@ done export PATH="/var/tmp/dist/nsis/bin:$PATH" mv $rootdir/windows-installer $distdir/windows-installer - cat > $distdir/windows-installer/browser-portable.nsi << 'BROWSER_NSI' -[% INCLUDE 'windows-installer.nsi' %] -BROWSER_NSI + mv $rootdir/defines.nsh $distdir/windows-installer/ + [% IF !c('var/testbuild') -%] + source $distdir/windows-installer/language-map.sh + supported_locales="[% tmpl(c('var/locales').join(' ')) %]" + for code in $supported_locales; do + if [[ -n ${nsis_languages[$code]} ]]; then + echo '!insertmacro MUI_LANGUAGE "'${nsis_languages[$code]}'"' >> $distdir/windows-installer/languages.nsh + fi + done + [% END -%] + + [% IF c('var/mullvad-browser') -%] + pushd $distdir/windows-installer + # While Firefox re-uses the uninstaller for this, we cannot do it, because + # we write the uninstaller from the installer. + # Instead, we need to write an updated postupdate.exe also when updating. + makensis postupdate.nsi + mv postupdate.exe ${TB_STAGE_DIR}/Browser/ + popd + [% END -%] + mv ${TB_STAGE_DIR} $distdir/windows-installer/"[% c('var/Project_Name') %]" mv $distdir/windows-installer ${TB_STAGE_DIR} [% END %] @@ -383,8 +401,13 @@ cd $distdir pushd "$PKG_DIR" makensis browser-portable.nsi # Working around NSIS braindamage - python3 $rootdir/pe_checksum_fix.py browser-install.exe - mv browser-install.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-portable-[% c("var/torbrowser_version") %].exe + python3 $rootdir/pe_checksum_fix.py browser-portable.exe + mv browser-portable.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-portable-[% c("var/torbrowser_version") %].exe + [% IF c('var/mullvad-browser') -%] + makensis browser-install.nsi + python3 $rootdir/pe_checksum_fix.py browser-install.exe + mv browser-install.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-install-[% c("var/torbrowser_version") %].exe + [% END -%] popd [% END %] rm -rf $distdir/${PKG_DIR} ===================================== projects/browser/config ===================================== @@ -120,6 +120,9 @@ input_files: enable: '[% c("var/windows") %]' - filename: windows-installer enable: '[% c("var/windows") %]' + - filename: 'defines.nsh' + content: '[% INCLUDE "windows-installer/defines.nsh.in" %]' + refresh_input: 1 - filename: pe_checksum_fix.py enable: '[% c("var/windows") %]' # To generate a new keystore, see how-to-generate-keystore.txt ===================================== projects/browser/windows-installer.nsi deleted ===================================== @@ -1,169 +0,0 @@ -; NSIS Installer for Tor/Base/Mullvad Browser -; Based on NSIS examples by Joost Verburg. -; Originally adapted to Tor Browser by Moritz Bartl -; https://github.com/moba/tbb-windows-installer -; Released under the zlib/libpng license. - -;-------------------------------- - !include "FileFunc.nsh" - !include "LogicLib.nsh" - !include "MUI2.nsh" - !include "WinVer.nsh" - -;-------------------------------- -; General - ; Location of Tor/Base/Mullvad Browser to put into installer - !define PROGRAM_SOURCE ".\[% c('var/Project_Name') %]\" - -[% IF c("var/channel") == "release"; - SET display_name = c('var/Project_Name'); - ELSIF c("var/testbuild"); - SET display_name = c('var/Project_Name') _ " Testbuild"; - ELSE; - SET display_name = c('var/Project_Name_Channel'); - END --%] - Name "[% display_name %]" - OutFile "browser-install.exe" - - ; Default installation folder - InstallDir "$DESKTOP\[% display_name %]" - - ; Best (but slowest) compression - SetCompressor /SOLID lzma - SetCompressorDictSize 32 - - ; Do not require elevated privileges - RequestExecutionLevel user - - ; Support HiDPI displays - ManifestDPIAware true - -;-------------------------------- -; Metadata - VIProductVersion "[% pc('firefox', 'var/browser_series') %].0.0" - VIAddVersionKey "ProductName" "[% display_name %]" - VIAddVersionKey "ProductVersion" "[% c('var/torbrowser_version') %]" - VIAddVersionKey "FileDescription" "[% display_name %] Portable Installer" - VIAddVersionKey "LegalCopyright" "© [% pc('firefox', 'var/copyright_year') %] [% IF c('var/mullvad-browser') %]Mullvad, Tor Browser and Mozilla Developers[% ELSE %]The Tor Project[% END %]" - -;-------------------------------- -; Interface Configuration - !define MUI_ICON "[% c('var/projectname') %][% IF !c('var/base-browser') %]-[% c('var/channel') %][% END %].ico" - !define MUI_ABORTWARNING - -;-------------------------------- -; Modern UI settings - !define MUI_FINISHPAGE_NOREBOOTSUPPORT ; Reboot not required - !define MUI_FINISHPAGE_RUN - !define MUI_FINISHPAGE_RUN_FUNCTION "StartBrowser" - - ; Misuse the option to show the readme to create the shortcuts. - ; Less ugly than MUI_PAGE_COMPONENTS. - !define MUI_FINISHPAGE_SHOWREADME - !define MUI_FINISHPAGE_SHOWREADME_TEXT "&Add Start Menu && Desktop shortcuts" - !define MUI_FINISHPAGE_SHOWREADME_FUNCTION "CreateShortCuts" - -;-------------------------------- -; Pages - !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists - !insertmacro MUI_PAGE_DIRECTORY - !insertmacro MUI_PAGE_INSTFILES - !insertmacro MUI_PAGE_FINISH - -;-------------------------------- -; Languages - !insertmacro MUI_LANGUAGE "English" ; First language is the default language - !insertmacro MUI_LANGUAGE "Arabic" ; ar - !insertmacro MUI_LANGUAGE "Catalan" ; ca - !insertmacro MUI_LANGUAGE "Czech" ; cs - !insertmacro MUI_LANGUAGE "Danish" ; da - !insertmacro MUI_LANGUAGE "German" ; de - !insertmacro MUI_LANGUAGE "Greek" ; el - !insertmacro MUI_LANGUAGE "Spanish" ; es-ES - !insertmacro MUI_LANGUAGE "Farsi" ; fa - !insertmacro MUI_LANGUAGE "Finnish" ; fi - !insertmacro MUI_LANGUAGE "French" ; fr - !insertmacro MUI_LANGUAGE "ScotsGaelic" ; ga-IE - !insertmacro MUI_LANGUAGE "Hebrew" ; he - !insertmacro MUI_LANGUAGE "Hungarian" ; hu - !insertmacro MUI_LANGUAGE "Indonesian"; id - !insertmacro MUI_LANGUAGE "Icelandic" ; is - !insertmacro MUI_LANGUAGE "Italian" ; it - !insertmacro MUI_LANGUAGE "Japanese" ; ja - !insertmacro MUI_LANGUAGE "Georgian" ; ka - !insertmacro MUI_LANGUAGE "Korean" ; ko - !insertmacro MUI_LANGUAGE "Lithuanian" ; lt - !insertmacro MUI_LANGUAGE "Macedonian" ; mk - !insertmacro MUI_LANGUAGE "Malay" ; ms - ; Burmese - my: not available on NSIS - !insertmacro MUI_LANGUAGE "Norwegian" ; nb-NO - !insertmacro MUI_LANGUAGE "Dutch" ; nl - !insertmacro MUI_LANGUAGE "Polish" ; pl - !insertmacro MUI_LANGUAGE "PortugueseBR" ; pt-BR - !insertmacro MUI_LANGUAGE "Romanian" ; ro - !insertmacro MUI_LANGUAGE "Russian" ; ru - !insertmacro MUI_LANGUAGE "Albanian" ; sq - !insertmacro MUI_LANGUAGE "Swedish" ; sv-SE - !insertmacro MUI_LANGUAGE "Thai" ; th - !insertmacro MUI_LANGUAGE "Turkish" ; tr - !insertmacro MUI_LANGUAGE "Ukrainian" ; uk - !insertmacro MUI_LANGUAGE "Vietnamese" ; vi - !insertmacro MUI_LANGUAGE "SimpChinese" ; zh-hans, zh-cn - !insertmacro MUI_LANGUAGE "TradChinese" ; zh-hant, zh-tw - -;-------------------------------- -; Reserve Files - - ; If you are using solid compression, files that are required before - ; the actual installation should be stored first in the data block, - ; because this will make your installer start faster. - - !insertmacro MUI_RESERVEFILE_LANGDLL - -;-------------------------------- -; Installer Sections - -Section "Browser" SecBrowser - SetOutPath "$INSTDIR" - File /r "${PROGRAM_SOURCE}\*.*" - CreateShortCut "$INSTDIR\[% display_name %].lnk" "$INSTDIR\Browser\[% c('var/exe_name') %].exe" -SectionEnd - -;-------------------------------- -; Installer Functions - -Function .onInit - ${IfNot} ${AtLeastWin7} - MessageBox MB_USERICON|MB_OK "[% c('var/Project_Name') %] requires at least Windows 7" - SetErrorLevel 1 - Quit - ${EndIf} - - ; Don't install on systems that don't support SSE2. The parameter value of - ; 10 is for PF_XMMI64_INSTRUCTIONS_AVAILABLE which will check whether the - ; SSE2 instruction set is available. - System::Call "kernel32::IsProcessorFeaturePresent(i 10)i .R7" - ${If} "$R7" == "0" - MessageBox MB_OK|MB_ICONSTOP "Sorry, [% c('var/Project_Name') %] can't be installed. This version of [% c('var/Project_Name') %] requires a processor with SSE2 support." - Abort - ${EndIf} - - !insertmacro MUI_LANGDLL_DISPLAY -FunctionEnd - -Function CheckIfTargetDirectoryExists - ${If} ${FileExists} "$INSTDIR\*.*" - MessageBox MB_YESNO "The destination directory already exists. Do you want to continue anyway?" IDYES +2 - Abort - ${EndIf} -FunctionEnd - -Function CreateShortcuts - CreateShortCut "$SMPROGRAMS\[% display_name %].lnk" "$INSTDIR\[% IF !system_install_mode -%]Browser\[% END -%][% c('var/exe_name') %].exe" - CreateShortCut "$DESKTOP\[% display_name %].lnk" "$INSTDIR\[% IF !system_install_mode -%]Browser\[% END -%][% c('var/exe_name') %].exe" -FunctionEnd - -Function StartBrowser - ExecShell "open" "$INSTDIR/[% display_name %].lnk" -FunctionEnd ===================================== projects/browser/windows-installer/browser-install.nsi ===================================== @@ -0,0 +1,263 @@ + !include "common.nsh" + !include "registry.nsh" + +;-------------------------------- + OutFile "browser-install.exe" + VIAddVersionKey "FileDescription" "${DISPLAY_NAME} Installer" + + !define DEFAULT_INSTALL_DIR "$LocalAppdata\${APP_DIR}\${NAME_NO_SPACES}\${UPDATE_CHANNEL}" + InstallDir "${DEFAULT_INSTALL_DIR}" + +;-------------------------------- +; Pages + Page custom SetupType SetupTypeLeave + Page custom CustomSetup CustomSetupLeave + ; Disable the directory selection when updating + !define MUI_PAGE_CUSTOMFUNCTION_PRE CustomPageDirectory + !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists + !insertmacro MUI_PAGE_DIRECTORY + !insertmacro MUI_PAGE_INSTFILES + !insertmacro MUI_PAGE_FINISH + + !insertmacro MUI_UNPAGE_CONFIRM + !insertmacro MUI_UNPAGE_INSTFILES + !insertmacro MUI_UNPAGE_FINISH + + ; Languages must be defined after pages + !include "languages.nsh" + +;-------------------------------- +; Installer + +; Path to an existing install. If not empty we are in update mode. +var existingInstall + +; Installation settings +var isCustomMode +var isPortableMode +var createDesktopShortcut + +; Variable used by the setup type page +var typeRadioStandard +var typeRadioCustom +var typeRadioClicked +var typeNextButton + +; Variables used in the custom setup page +var customCheckboxPortable +var customCheckboxDesktop + +Function .onInit + Call CheckRequirements + + !insertmacro MUI_LANGDLL_DISPLAY + + ReadRegStr $existingInstall HKCU "${UNINST_KEY}" "InstallLocation" + StrCpy $createDesktopShortcut "true" +FunctionEnd + +Function SetupType + !insertmacro MUI_HEADER_TEXT "Setup Type" "Choose setup options" + nsDialogs::Create 1018 + Pop $0 + ${If} $0 == error + Abort + ${EndIf} + + ${NSD_CreateLabel} 0 0 100% 18% "Choose the type of setup you prefer." + ${If} $existingInstall == "" + ${NSD_CreateRadioButton} 0 18% 100% 6% "Standard" + Pop $typeRadioStandard + ${NSD_CreateRadioButton} 0 30% 100% 6% "Custom" + Pop $typeRadioCustom + ${Else} + ${NSD_CreateRadioButton} 0 18% 100% 6% "Update your existing installation" + Pop $typeRadioStandard + ${NSD_CreateRadioButton} 0 30% 100% 6% "Portable installation" + Pop $typeRadioCustom + ${EndIf} + ${NSD_OnClick} $typeRadioStandard SetupTypeRadioClick + ${NSD_OnClick} $typeRadioCustom SetupTypeRadioClick + + GetDlgItem $typeNextButton $HWNDPARENT 1 + + ; Re-check radios if the user presses back + ${If} $isCustomMode == "true" + StrCpy $typeRadioClicked $typeRadioCustom + ${Else} + StrCpy $typeRadioClicked $typeRadioStandard + ${EndIf} + ${NSD_Check} $typeRadioClicked + Call SetupTypeUpdate + + nsDialogs::Show +FunctionEnd + +Function SetupTypeRadioClick + Pop $typeRadioClicked + Call SetupTypeUpdate +FunctionEnd + +Function SetupTypeUpdate + ${If} $typeRadioClicked == $typeRadioCustom + StrCpy $isCustomMode "true" + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:$(^NextBtn)" + ${ElseIf} $typeRadioClicked == $typeRadioStandard + StrCpy $isCustomMode "false" + StrCpy $isPortableMode "false" + ${If} $existingInstall == "" + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:$(^InstallBtn)" + ${Else} + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:&Update" + ${EndIf} + ${EndIf} +FunctionEnd + +Function SetupTypeLeave + ${If} $typeRadioClicked == $typeRadioCustom + StrCpy $isCustomMode "true" + ${ElseIf} $typeRadioClicked == $typeRadioStandard + StrCpy $isCustomMode "false" + StrCpy $isPortableMode "false" + ${Else} + Abort + ${EndIf} +FunctionEnd + +Function CustomSetup + ${If} $isCustomMode != "true" + Return + ${EndIf} + + !insertmacro MUI_HEADER_TEXT "Custom Setup" "Customize your setup options" + nsDialogs::Create 1018 + Pop $0 + ${If} $0 == error + Abort + ${EndIf} + + ${NSD_CreateCheckbox} 0 18% 100% 6% "Portable installation" + Pop $customCheckboxPortable + ${NSD_CreateCheckbox} 0 30% 100% 6% "Create a desktop shortcut" + Pop $customCheckboxDesktop + ${NSD_OnClick} $customCheckboxPortable CustomSetupCheckboxClick + ${NSD_OnClick} $customCheckboxDesktop CustomSetupCheckboxClick + + ${If} $existingInstall != "" + ; If we already have an installation, this is already portable mode. + StrCpy $isPortableMode "true" + ${NSD_Check} $customCheckboxPortable + EnableWindow $customCheckboxPortable 0 + ${ElseIf} $isPortableMode == "true" + ${NSD_Check} $customCheckboxPortable + ${EndIf} + ${If} $createDesktopShortcut == "true" + ${NSD_Check} $customCheckboxDesktop + ${EndIf} + + nsDialogs::Show +FunctionEnd + +Function CustomSetupUpdate + ${NSD_GetState} $customCheckboxPortable $0 + ${If} $0 == "${BST_CHECKED}" + StrCpy $isPortableMode "true" + ${Else} + StrCpy $isPortableMode "false" + ${EndIf} + + ${NSD_GetState} $customCheckboxDesktop $0 + ${If} $0 == "${BST_CHECKED}" + StrCpy $createDesktopShortcut "true" + ${Else} + StrCpy $createDesktopShortcut "false" + ${EndIf} +FunctionEnd + +Function CustomSetupCheckboxClick + Pop $0 + Call CustomSetupUpdate +FunctionEnd + +Function CustomSetupLeave + Call CustomSetupUpdate +FunctionEnd + +Function CustomPageDirectory + ${If} $isPortableMode == "true" + StrCpy $INSTDIR "${DEFAULT_PORTABLE_DIR}" + ; Always go through this page in portable mode. + Return + ${ElseIf} $existingInstall != "" + ; When updating, force the old directory and skip the page. + StrCpy $INSTDIR $existingInstall + Abort + ${Else} + StrCpy $INSTDIR "${DEFAULT_INSTALL_DIR}" + ${EndIf} + + ${If} $isCustomMode != "true" + ; Standard install, use the default directory and skip the page. + Abort + ${EndIf} +FunctionEnd + +Section "Browser" SecBrowser + SetOutPath "$INSTDIR" + + ${If} $isPortableMode == "true" + File /r "${PROGRAM_SOURCE}\*.*" + CreateShortCut "$INSTDIR\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" + ${Else} + ; Do not use a Browser directory for installs. + File /r "${PROGRAM_SOURCE}\Browser\*.*" + + ; Tell the browser we are not in portable mode anymore. + FileOpen $0 "$INSTDIR\system-install" w + FileClose $0 + + ; Write the uninstaller + WriteUninstaller $INSTDIR\uninstall.exe + + !insertmacro UPDATE_REGISTRY + + CreateShortCut "$SMPROGRAMS\${DISPLAY_NAME}.lnk" "$INSTDIR\${EXE_NAME}" + ${If} $createDesktopShortcut == "true" + CreateShortCut "$DESKTOP\${DISPLAY_NAME}.lnk" "$INSTDIR\${EXE_NAME}" + ${EndIf} + ${EndIf} +SectionEnd + +Function StartBrowser + ${If} $isPortableMode == "true" + ExecShell "open" "$INSTDIR\${DISPLAY_NAME}.lnk" + ${Else} + ExecShell "open" "$INSTDIR\${EXE_NAME}" + ${EndIf} +FunctionEnd + +;-------------------------------- +; Uninstaller +Section "Uninstall" + RMDir /r "$INSTDIR" + DeleteRegKey HKCU "${UNINST_KEY}" + + StrCpy $0 "" + ShellLink::GetShortCutTarget "$SMPROGRAMS\${DISPLAY_NAME}.lnk" + Pop $0 + ${If} $0 == "$INSTDIR\${EXE_NAME}" + Delete "$SMPROGRAMS\${DISPLAY_NAME}.lnk" + ${EndIf} + + StrCpy $0 "" + ShellLink::GetShortCutTarget "$DESKTOP\${DISPLAY_NAME}.lnk" + Pop $0 + ${If} $0 == "$INSTDIR\${EXE_NAME}" + Delete "$DESKTOP\${DISPLAY_NAME}.lnk" + ${EndIf} + + ; TODO: Optionally remove profiles. + ; This operation is not trivial, because it involes finding our installation + ; hash, its associated default profile and making sure it is not shared with + ; another channel/installation. +SectionEnd ===================================== projects/browser/windows-installer/browser-portable.nsi ===================================== @@ -0,0 +1,45 @@ + !include "common.nsh" + +;-------------------------------- + OutFile "browser-portable.exe" + VIAddVersionKey "FileDescription" "${DISPLAY_NAME} Portable Installer" + InstallDir "$DESKTOP\${DISPLAY_NAME}" + +;-------------------------------- +; Pages + ; Misuse the option to show the readme to create the shortcuts. + ; Less ugly than MUI_PAGE_COMPONENTS. + !define MUI_FINISHPAGE_SHOWREADME + !define MUI_FINISHPAGE_SHOWREADME_TEXT "&Add Start Menu && Desktop shortcuts" + !define MUI_FINISHPAGE_SHOWREADME_FUNCTION "CreateShortcuts" + + !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists + !insertmacro MUI_PAGE_DIRECTORY + !insertmacro MUI_PAGE_INSTFILES + !insertmacro MUI_PAGE_FINISH + + ; Languages must be defined after pages + !include "languages.nsh" + +;-------------------------------- +; Installer +Function .onInit + Call CheckRequirements + + !insertmacro MUI_LANGDLL_DISPLAY +FunctionEnd + +Section "Browser" SecBrowser + SetOutPath "$INSTDIR" + File /r "${PROGRAM_SOURCE}\*.*" + CreateShortCut "$INSTDIR\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" +SectionEnd + +Function CreateShortcuts + CreateShortCut "$SMPROGRAMS\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" + CreateShortCut "$DESKTOP\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" +FunctionEnd + +Function StartBrowser + ExecShell "open" "$INSTDIR/${DISPLAY_NAME}.lnk" +FunctionEnd ===================================== projects/browser/windows-installer/common.nsh ===================================== @@ -0,0 +1,82 @@ +; Common code for the NSIS Installers for Tor/Base/Mullvad Browser. +; Based on NSIS examples by Joost Verburg. +; Originally adapted to Tor Browser by Moritz Bartl +; https://github.com/moba/tbb-windows-installer +; Released under the zlib/libpng license. + +;-------------------------------- + !include "FileFunc.nsh" + !include "LogicLib.nsh" + !include "MUI2.nsh" + !include "WinVer.nsh" + + !include "defines.nsh" + +;-------------------------------- +; General settings + Name "${DISPLAY_NAME}" + + ; Best (but slowest) compression + SetCompressor /SOLID lzma + SetCompressorDictSize 32 + + ; Do not require elevated privileges. + ; Even for the installer, we install only for the current user, so we do not + ; need high privileges. + RequestExecutionLevel user + + ; Support HiDPI displays + ManifestDPIAware true + +;-------------------------------- +; Version information + VIProductVersion "${VERSION_WINDOWS}" + VIAddVersionKey "ProductName" "${DISPLAY_NAME}" + VIAddVersionKey "ProductVersion" "${VERSION}" + VIAddVersionKey "FileVersion" "${VERSION}" + VIAddVersionKey "LegalCopyright" "${COPYRIGHT_STRING}" + +;-------------------------------- +; Interface Configuration + ; Installer icon + !define MUI_ICON "${ICON_NAME}" + !define MUI_ABORTWARNING + +;-------------------------------- +; Modern UI settings + !define MUI_FINISHPAGE_NOREBOOTSUPPORT ; Reboot not required + !define MUI_FINISHPAGE_RUN + !define MUI_FINISHPAGE_RUN_FUNCTION "StartBrowser" + +;-------------------------------- +; Reserve Files + ; If you are using solid compression, files that are required before + ; the actual installation should be stored first in the data block, + ; because this will make your installer start faster. + !insertmacro MUI_RESERVEFILE_LANGDLL + +;-------------------------------- +; Helper functions +Function CheckRequirements + ${IfNot} ${AtLeastWin7} + MessageBox MB_USERICON|MB_OK "${PROJECT_NAME} requires at least Windows 7" + SetErrorLevel 1 + Quit + ${EndIf} + + ; Don't install on systems that don't support SSE2. The parameter value of + ; 10 is for PF_XMMI64_INSTRUCTIONS_AVAILABLE which will check whether the + ; SSE2 instruction set is available. + System::Call "kernel32::IsProcessorFeaturePresent(i 10)i .R7" + ${If} "$R7" == "0" + MessageBox MB_OK|MB_ICONSTOP "${PROJECT_NAME} requires a processor with SSE2 support." + Quit + ${EndIf} +FunctionEnd + +Function CheckIfTargetDirectoryExists + ${If} ${FileExists} "$INSTDIR\*.*" + MessageBox MB_YESNO "The destination directory already exists. Do you want to continue anyway?" IDYES +2 + Abort + ${EndIf} +FunctionEnd ===================================== projects/browser/windows-installer/defines.nsh.in ===================================== @@ -0,0 +1,52 @@ +;-------------------------------- +; Defines + ; Location of Tor/Base/Mullvad Browser to put into installer + !define PROGRAM_SOURCE ".\[% c('var/Project_Name') %]\" + + ; Project and display name + !define PROJECT_NAME "[% c('var/Project_Name') %]" +[% IF c("var/channel") == "release" -%] + !define DISPLAY_NAME "[% c('var/Project_Name') %]" +[% ELSIF c("var/testbuild") -%] + !define DISPLAY_NAME "[% c('var/Project_Name') %] Testbuild" +[% ELSE -%] + !define DISPLAY_NAME "[% c('var/Project_Name_Channel') %]" +[% END -%] + !define NAME_NO_SPACES "[% c('var/ProjectName') %]" + !define UPDATE_CHANNEL "[% c('var/channel') FILTER ucfirst %]" + + ; Version + !define VERSION "[% c('var/torbrowser_version') %]" + ; String for use with Windows's Product Version. + ; It must be 4 integers separated by a dot. + !define VERSION_WINDOWS "[% pc('firefox', 'var/browser_series') %].0.0" + + !define DEFAULT_PORTABLE_DIR "$DESKTOP\${DISPLAY_NAME}" + !define EXE_NAME "[% c('var/exe_name') %].exe" +[% IF !c("var/base-browser") -%] + !define ICON_NAME "[% c('var/projectname') %]-[% c('var/channel') %].ico" +[% ELSE -%] + !define ICON_NAME "[% c('var/projectname') %].ico" +[% END -%] + +[% IF c('var/mullvad-browser') -%] + ; Firefox's --with-user-appdir + !define APP_DIR "Mullvad" + + !define PUBLISHER "Mullvad VPN" + !define COPYRIGHT_STRING "© [% pc('firefox', 'var/copyright_year') %] Mullvad, Tor Browser and Mozilla Developers" + + !define URL_ABOUT "https://mullvad.net/en/browser" + !define URL_UPDATE "https://github.com/mullvad/mullvad-browser/releases/[% c('var/torbrowser_version') %]" + !define URL_HELP "https://mullvad.net/help/tag/browser/" +[% ELSE -%] + ; Not defined for Tor Browser + !define APP_DIR "TorProject" + + !define PUBLISHER "The Tor Project" + !define COPYRIGHT_STRING "© [% pc('firefox', 'var/copyright_year') %] The Tor Project" + + !define URL_ABOUT "https://www.torproject.org/" + !define URL_UPDATE "https://blog.torproject.org/new[% IF c('var/alpha') %]-alpha[% END %]-release-tor-browser-[% c('var/torbrowser_version') FILTER remove('\.') %]" + !define URL_HELP "https://tb-manual.torproject.org/" +[% END -%] ===================================== projects/browser/windows-installer/language-map.sh ===================================== @@ -0,0 +1,39 @@ +#!/bin/bash +declare -A nsis_languages +nsis_languages[ar]="Arabic" +nsis_languages[ca]="Catalan" +nsis_languages[cs]="Czech" +nsis_languages[da]="Danish" +nsis_languages[de]="German" +nsis_languages[el]="Greek" +nsis_languages[es-ES]="Spanish" +nsis_languages[fa]="Farsi" +nsis_languages[fi]="Finnish" +nsis_languages[fr]="French" +nsis_languages[ga-IE]="ScotsGaelic" +nsis_languages[he]="Hebrew" +nsis_languages[hu]="Hungarian" +nsis_languages[d]="Indonesian" +nsis_languages[is]="Icelandic" +nsis_languages[it]="Italian" +nsis_languages[ja]="Japanese" +nsis_languages[ka]="Georgian" +nsis_languages[ko]="Korean" +nsis_languages[lt]="Lithuanian" +nsis_languages[mk]="Macedonian" +nsis_languages[ms]="Malay" +# nsis_languages[my]="Burmese" # Not available on NSIS +nsis_languages[nb-NO]="Norwegian" +nsis_languages[nl]="Dutch" +nsis_languages[pl]="Polish" +nsis_languages[pt-BR]="PortugueseBR" +nsis_languages[ro]="Romanian" +nsis_languages[ru]="Russian" +nsis_languages[sq]="Albanian" +nsis_languages[sv-SE]="Swedish" +nsis_languages[th]="Thai" +nsis_languages[tr]="Turkish" +nsis_languages[uk]="Ukrainian" +nsis_languages[vi]="Vietnamese" +nsis_languages[zh-CN]="SimpChinese" +nsis_languages[zh-TW]="TradChinese" ===================================== projects/browser/windows-installer/languages.nsh ===================================== @@ -0,0 +1,4 @@ +;-------------------------------- +; Additional languages + !insertmacro MUI_LANGUAGE "English" ; Always available + ; The rest of the languages will be added here during the build. ===================================== projects/browser/windows-installer/postupdate.nsi ===================================== @@ -0,0 +1,28 @@ +!include "FileFunc.nsh" +!include "LogicLib.nsh" + +!include "defines.nsh" +!include "registry.nsh" + +OutFile "postupdate.exe" +Icon "${ICON_NAME}" +RequestExecutionLevel user + +Function .onInit + ${GetOptions} $CMDLINE "/Visible" $0 + IfErrors 0 +2 + SetSilent silent +FunctionEnd + +Section PostUpdate "PostUpdate" + StrCpy $0 "false" + IfFileExists $EXEDIR\system-install 0 +2 + StrCpy $0 "true" + ${If} $0 == "true" + StrCpy $INSTDIR $EXEDIR + !insertmacro UPDATE_REGISTRY + RMDir /r /REBOOTOK $EXEDIR\tobedeleted + ${Else} + RMDir /r $EXEDIR\tobedeleted + ${EndIf} +SectionEnd ===================================== projects/browser/windows-installer/registry.nsh ===================================== @@ -0,0 +1,19 @@ +!define UNINST_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${NAME_NO_SPACES}${UPDATE_CHANNEL}" + +!macro UPDATE_REGISTRY + WriteRegStr HKCU "${UNINST_KEY}" "DisplayName" "${DISPLAY_NAME}" + WriteRegStr HKCU "${UNINST_KEY}" "DisplayIcon" "$\"$INSTDIR\${EXE_NAME}$\"" + WriteRegStr HKCU "${UNINST_KEY}" "DisplayVersion" "${VERSION}" + WriteRegStr HKCU "${UNINST_KEY}" "UninstallString" "$\"$INSTDIR\uninstall.exe$\"" + WriteRegStr HKCU "${UNINST_KEY}" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S" + WriteRegDWORD HKCU "${UNINST_KEY}" "NoModify" "1" + WriteRegDWORD HKCU "${UNINST_KEY}" "NoRepair" "1" + ${GetSize} "$INSTDIR" "/S=0K" $0 $1 $2 + IntFmt $0 "0x%08X" $0 + WriteRegDWORD HKCU "${UNINST_KEY}" "EstimatedSize" "$0" + WriteRegStr HKCU "${UNINST_KEY}" "InstallLocation" "$INSTDIR" + WriteRegStr HKCU "${UNINST_KEY}" "Publisher" "${PUBLISHER}" + WriteRegStr HKCU "${UNINST_KEY}" "URLInfoAbout" "${URL_ABOUT}" + WriteRegStr HKCU "${UNINST_KEY}" "URLUpdateInfo" "${URL_UPDATE}" + WriteRegStr HKCU "${UNINST_KEY}" "HelpLink" "${URL_HELP}" +!macroend ===================================== projects/nsis/ShellLink.cpp ===================================== @@ -0,0 +1,358 @@ +/* +Module : ShellLink.cpp +Purpose: NSIS Plug-in for retriving shell link information +Created: 12/16/2003 +Last Update: 01/14/2004 + +Copyright (c) 2004 Angelo Mandato. +See ShellLink.html for more information + + +Modified: 21/09/2005 +Author: Shengalts Aleksander aka Instructor (Shengalts(a)mail.ru) +Changes: -code has been rewritten + -added functions to change shell link information + -reduced dll size 44Kb -> 4Kb + +Modified by The Tor Project to remove the unneeded ConvFunc.h and updated the +include for pluginapi.h. +The original plugin is available at https://nsis.sourceforge.io/ShellLink_plug-in. + +© 2004 Angelo Mandato + +This software is provided 'as-is', without any express or implied warranty. In +no event will the authors be held liable for any damages arising from the use of +this software. + +Permission is granted to anyone to use this software for any purpose, including +commercial applications, and to alter it and redistribute it freely, subject to +the following restrictions: + +1. The origin of this software must not be misrepresented; you must not claim + that you wrote the original software. If you use this software in a product, + an acknowledgment in the product documentation would be appreciated but is + not required. +2. Altered versions must be plainly marked as such, and must not be + misrepresented as being the original software. +3. This notice may not be removed or altered from any distribution. + +*/ + +// Uncomment for debugging message boxes +//#define SHELLLINK_DEBUG + +#include <windows.h> +#include <shlobj.h> + +#define xatoi +#include "nsis/pluginapi.h" + +#define NSISFUNC(name) extern "C" void __declspec(dllexport) name(HWND hWndParent, int string_size, TCHAR* variables, stack_t** stacktop, extra_parameters* extra) + +#define SHELLLINKTYPE_GETARGS 1 +#define SHELLLINKTYPE_GETDESC 2 +#define SHELLLINKTYPE_GETHOTKEY 3 +#define SHELLLINKTYPE_GETICONLOC 4 +#define SHELLLINKTYPE_GETICONINDEX 5 +#define SHELLLINKTYPE_GETPATH 6 +#define SHELLLINKTYPE_GETSHOWMODE 7 +#define SHELLLINKTYPE_GETWORKINGDIR 8 +#define SHELLLINKTYPE_SETARGS 9 +#define SHELLLINKTYPE_SETDESC 10 +#define SHELLLINKTYPE_SETHOTKEY 11 +#define SHELLLINKTYPE_SETICONLOC 12 +#define SHELLLINKTYPE_SETICONINDEX 13 +#define SHELLLINKTYPE_SETPATH 14 +#define SHELLLINKTYPE_SETSHOWMODE 15 +#define SHELLLINKTYPE_SETWORKINGDIR 16 +#define SHELLLINKTYPE_SETRUNASADMIN 17 + +void ShortCutData(int nType); + +//Get +NSISFUNC(GetShortCutArgs) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETARGS); +} + +NSISFUNC(GetShortCutDescription) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETDESC); +} + +NSISFUNC(GetShortCutHotkey) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETHOTKEY); +} + +NSISFUNC(GetShortCutIconLocation) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETICONLOC); +} + +NSISFUNC(GetShortCutIconIndex) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETICONINDEX); +} + +NSISFUNC(GetShortCutTarget) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETPATH); +} + +NSISFUNC(GetShortCutShowMode) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETSHOWMODE); +} + +NSISFUNC(GetShortCutWorkingDirectory) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETWORKINGDIR); +} + +//Set +NSISFUNC(SetShortCutArgs) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETARGS); +} + +NSISFUNC(SetShortCutDescription) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETDESC); +} + +NSISFUNC(SetShortCutHotkey) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETHOTKEY); +} + +NSISFUNC(SetShortCutIconLocation) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETICONLOC); +} + +NSISFUNC(SetShortCutIconIndex) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETICONINDEX); +} + +NSISFUNC(SetShortCutTarget) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETPATH); +} + +NSISFUNC(SetShortCutShowMode) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETSHOWMODE); +} + +NSISFUNC(SetShortCutWorkingDirectory) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETWORKINGDIR); +} + +NSISFUNC(SetRunAsAdministrator) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETRUNASADMIN); +} + +void ShortCutData(int nType) +{ + HRESULT hRes; + IShellLink* psl; + IPersistFile* ppf; + + int nBuf; + WORD wHotkey; + TCHAR* szBuf = (TCHAR*)LocalAlloc(LPTR, sizeof(TCHAR)*MAX_PATH); + TCHAR* szBuf2 = (TCHAR*)LocalAlloc(LPTR, sizeof(TCHAR)*MAX_PATH); + + popstring(szBuf); + if (nType > SHELLLINKTYPE_GETWORKINGDIR) popstring(szBuf2); + + hRes=CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, IID_IShellLink, (LPVOID*) &psl); + if (hRes == S_OK) + { + hRes=psl->QueryInterface(IID_IPersistFile, (LPVOID*) &ppf); + if (hRes == S_OK) + { +#ifdef UNICODE + hRes=ppf->Load(szBuf, STGM_READWRITE); +#else + WCHAR* wszPath = (WCHAR*)LocalAlloc(LPTR, sizeof(WCHAR)*MAX_PATH); + MultiByteToWideChar(CP_ACP, 0, szBuf, -1, wszPath, MAX_PATH); + hRes=ppf->Load(wszPath, STGM_READWRITE); + LocalFree(wszPath); +#endif + if (hRes == S_OK) + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) + { + //Get + switch(nType) + { + case SHELLLINKTYPE_GETARGS: + { + hRes=psl->GetArguments(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETDESC: + { + hRes=psl->GetDescription(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETHOTKEY: + { + hRes=psl->GetHotkey(&wHotkey); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), wHotkey); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETICONLOC: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETICONINDEX: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), nBuf); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETPATH: + { + WIN32_FIND_DATA fd; + + hRes=psl->GetPath(szBuf, MAX_PATH, &fd, SLGP_UNCPRIORITY); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETSHOWMODE: + { + hRes=psl->GetShowCmd(&nBuf); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), nBuf); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETWORKINGDIR: + { + hRes=psl->GetWorkingDirectory(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + } + } + else + { + //Set + switch(nType) + { + case SHELLLINKTYPE_SETARGS: + { + hRes=psl->SetArguments(szBuf2); + }; break; + case SHELLLINKTYPE_SETDESC: + { + hRes=psl->SetDescription(szBuf2); + }; break; + case SHELLLINKTYPE_SETHOTKEY: + { + wHotkey=(unsigned short)myatoi(szBuf2); + hRes=psl->SetHotkey(wHotkey); + }; break; + case SHELLLINKTYPE_SETICONLOC: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes == S_OK) + hRes=psl->SetIconLocation(szBuf2, nBuf); + }; break; + case SHELLLINKTYPE_SETICONINDEX: + { + int nBuf2; + nBuf=myatoi(szBuf2); + + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf2); + if (hRes == S_OK) + hRes=psl->SetIconLocation(szBuf, nBuf); + }; break; + case SHELLLINKTYPE_SETPATH: + { + hRes=psl->SetPath(szBuf2); + }; break; + case SHELLLINKTYPE_SETSHOWMODE: + { + nBuf=myatoi(szBuf2); + hRes=psl->SetShowCmd(nBuf); + }; break; + case SHELLLINKTYPE_SETWORKINGDIR: + { + hRes=psl->SetWorkingDirectory(szBuf2); + }; break; + case SHELLLINKTYPE_SETRUNASADMIN: + { + IShellLinkDataList* pdl; + hRes=psl->QueryInterface(IID_IShellLinkDataList, (void**)&pdl); + if (hRes == S_OK) + { + DWORD dwFlags = 0; + hRes=pdl->GetFlags(&dwFlags); + if (hRes == S_OK && (dwFlags & SLDF_RUNAS_USER) != SLDF_RUNAS_USER) + hRes=pdl->SetFlags(dwFlags | SLDF_RUNAS_USER); + pdl->Release(); + } + }; break; + } + if (hRes == S_OK) hRes=ppf->Save(NULL, FALSE); + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: Save()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + } + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: Load()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("CShellLink::Initialise, Failed in call to QueryInterface for IPersistFile, HRESULT was %x\n"), TEXT("ShellLink plug-in"), MB_OK); + #endif + + // Cleanup: + if (ppf) ppf->Release(); + if (psl) psl->Release(); + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: CoCreateInstance()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + + if (hRes == S_OK) + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) pushstring(szBuf); + else pushstring(TEXT("0")); + } + else + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) pushstring(TEXT("")); + else pushstring(TEXT("-1")); + } + + LocalFree(szBuf); + LocalFree(szBuf2); +} + +BOOL WINAPI DllMain(HANDLE hInst, ULONG ul_reason_for_call, LPVOID lpReserved) +{ + return TRUE; +} ===================================== projects/nsis/build ===================================== @@ -30,7 +30,8 @@ EOF chmod +x "$compiler_prefix-gcc" ln -s "$compiler_prefix-clang++" "$compiler_prefix-g++" -cd /var/tmp/build/nsis-[% c('version') %]-src +builddir=/var/tmp/build/nsis-[% c('version') %]-src +cd "$builddir" # These two sed commands also come from build-mingw32-nsis.sh sed -i 's/-Wl,--exclude-libs,msvcrt.a/-Wl,-Xlink=-fixed/' SCons/Config/gnu @@ -60,6 +61,22 @@ patch -p1 < "$rootdir/resource-reproducible.diff" scons [% scons_args %] -j[% c("num_procs") %] || true scons [% scons_args %] scons [% scons_args %] install + +# Plugins +target="[% target %]-unicode" +plugins="/var/tmp/dist/nsis/share/nsis/Plugins/$target" +plugin_lib="$builddir/build/urelease/api/nsis/libpluginapi-$target.a" + +# This is not needed to build installers, but it makes easier to adapt plugins +# outside our build system. +mkdir /var/tmp/dist/nsis/share/nsis/Lib +cp $plugin_lib /var/tmp/dist/nsis/share/nsis/Lib/ + +$compiler_prefix-clang++ -I "$builddir/build/urelease/api" -O2 $plugin_lib \ + -DUNICODE "$rootdir/ShellLink.cpp" \ + -Wl,--no-insert-timestamp -lole32 -luuid -shared -o "$plugins/ShellLink.dll" +llvm-strip "$plugins/ShellLink.dll" + cd /var/tmp/dist [% c('tar', { tar_src => [ project ], ===================================== projects/nsis/config ===================================== @@ -24,3 +24,4 @@ input_files: - name: zlib project: zlib - filename: resource-reproducible.diff + - filename: ShellLink.cpp ===================================== rbm.conf ===================================== @@ -112,6 +112,8 @@ var: Project_Name_Channel: '[% c("var/Project_Name") %] [% c("var/channel") FILTER ucfirst %]' exe_name: firefox locale_ja: ja + # When adding new languages, add the equivalent NSIS name to + # projects/browser/windows-installer/language-map.sh. locales: - ar - ca View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 8475e6c0 by Henry Wilkes at 2024-02-13T18:02:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42415: Improve focus styling of bridge settings headings. We make sure the focus outline has a 2px offset from the text. Also make the "N days until you unlock:" text semantically a heading for its own section. - - - - - 3 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -1525,7 +1525,8 @@ const gLoxStatus = { } if (alertHadFocus && !showAlert) { - // Has become hidden. + // Alert has become hidden, move focus back up to the now revealed details + // area. this._nextUnlockCounterEl.focus(); } else if (detailsHadFocus && showAlert) { this._unlockAlertButton.focus(); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -67,7 +67,11 @@  <hbox class="subcategory" data-category="paneConnection" hidden="true"> - <html:h1 id="torPreferences-bridges-header" tabindex="-1" /> + <html:h1 + id="torPreferences-bridges-header" + class="tor-focusable-heading" + tabindex="-1" + ></html:h1> </hbox> <groupbox id="torPreferences-bridges-group" @@ -157,22 +161,26 @@ <html:div id="tor-bridges-current-header-bar"> <html:h2 id="tor-bridges-current-heading" + class="tor-focusable-heading" tabindex="-1" data-l10n-id="tor-bridges-your-bridges" ></html:h2> <html:span id="tor-bridges-user-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-user" ></html:span> <html:span id="tor-bridges-built-in-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-built-in" ></html:span> <html:span id="tor-bridges-requested-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-requested" ></html:span> - <html:span id="tor-bridges-lox-label"> + <html:span id="tor-bridges-lox-label" class="tor-bridges-source-label"> <html:img id="tor-bridges-lox-label-icon" alt="" /> <html:span data-l10n-id="tor-bridges-source-lox"></html:span> </html:span> @@ -307,11 +315,11 @@ > <html:img alt="" class="tor-bridges-lox-image-inner" /> <html:img alt="" class="tor-bridges-lox-image-outer" /> - <html:div + <html:h3 id="tor-bridges-lox-next-unlock-counter" - class="tor-bridges-lox-intro" + class="tor-bridges-lox-intro tor-focusable-heading" tabindex="-1" - ></html:div> + ></html:h3> <html:ul class="tor-bridges-lox-list"> <html:li id="tor-bridges-lox-next-unlock-gain-bridges" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -70,6 +70,10 @@ /* Bridge settings */ +.tor-focusable-heading:focus-visible { + outline-offset: var(--in-content-focus-outline-offset); +} + .bridge-status-badge { display: flex; min-width: max-content; @@ -210,16 +214,31 @@ } #tor-bridges-current-header-bar { - display: flex; + display: grid; min-width: max-content; + grid-template: "heading source button" min-content / max-content 1fr max-content; align-items: center; border-block-end: 1px solid var(--in-content-border-color); padding-block-end: 16px; margin-block-end: 16px; + white-space: nowrap; } -#tor-bridges-current-header-bar > * { - flex: 0 0 auto; +#tor-bridges-current-heading { + margin: 0; + font-size: inherit; + grid-area: heading; +} + +.tor-bridges-source-label { + margin-inline-start: 2em; + margin-inline-end: 8px; + grid-area: source; + justify-self: end; +} + +#tor-bridges-all-options-button { + grid-area: button; } #tor-bridges-lox-label { @@ -240,13 +259,6 @@ fill: var(--in-content-icon-color); } -#tor-bridges-current-heading { - margin: 0; - margin-inline-end: 2em; - font-size: inherit; - flex: 1 0 auto; -} - .tor-bridges-options-button { padding: 3px; margin: 0; @@ -264,10 +276,6 @@ fill: currentColor; } -#tor-bridges-all-options-button { - margin-inline-start: 8px; -} - #tor-bridges-built-in-display { display: grid; grid-template: @@ -552,7 +560,10 @@ .tor-bridges-lox-intro { grid-area: intro; font-weight: 700; + font-size: inherit; align-self: center; + justify-self: start; + margin: 0; } .tor-bridges-lox-list { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 94081cf4 by Henry Wilkes at 2024-02-13T17:46:34+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42414: Make address overflow ellipsis show in bridge grid. - - - - - 5 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -675,7 +675,7 @@ const gBridgeGrid = { }); } - row.element.querySelector(".tor-bridges-address-cell").textContent = + row.element.querySelector(".tor-bridges-address-cell-text").textContent = bridgeLine; row.statusEl = row.element.querySelector( ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -238,7 +238,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> <html:span class="tor-bridges-status-cell tor-bridges-grid-cell" role="gridcell" ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -487,7 +487,8 @@ const gProvideBridgeDialog = { }); } - rowEl.querySelector(".tor-bridges-address-cell").textContent = bridgeLine; + rowEl.querySelector(".tor-bridges-address-cell-text").textContent = + bridgeLine; this._bridgeGrid.append(rowEl); } ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -82,7 +82,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> </html:span> </html:div> </html:template> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -395,6 +395,9 @@ /* base size */ width: 10em; flex: 1 0 auto; +} + +.tor-bridges-address-cell-text { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 69328375 by Pier Angelo Vendrame at 2024-02-13T15:16:43+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… You're receiving this email because of your account on gitlab.torproject.org.

1 0

← Newer
1
...
5
6
7
8
9
10
11
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

tbb-commits February 2024