tbb-commits June 2022

tbb-commits@lists.torproject.org

1 participants
56 discussions

[builders/tor-browser-build] branch master updated (956803c -> cf3ebd9)
by gitolite role 30 Jun '22

30 Jun '22

This is an automated email from the git hooks/post-receive script. boklm pushed a change to branch master in repository builders/tor-browser-build. from 956803c Bug 40542: Move var/rezip from rbm.conf to projects/firefox/config new 71bb554 Bug: 40542: Remove unused faketime_patch for Windows new cf3ebd9 Bug 40542: Remove not needed faketime wrapper for macOS The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. … [View More]

1 2

[builders/tor-browser-build] branch master updated (0a89e14 -> 956803c)
by gitolite role 30 Jun '22

30 Jun '22

This is an automated email from the git hooks/post-receive script. gk pushed a change to branch master in repository builders/tor-browser-build. from 0a89e14 fixup! Bug 40506: Prepare alpha release 11.5a13 (Desktop+Android) new 88291b7 Bug 40542: Remove var/input_files_list from rbm.conf new 956803c Bug 40542: Move var/rezip from rbm.conf to projects/firefox/config The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate … [View More]

1 2

[tor-launcher] branch master updated: Tor Brower Bug 41039: set startHidden on tor process
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch master in repository tor-launcher. The following commit(s) were added to refs/heads/master by this push: new a9b3ea5 Tor Brower Bug 41039: set startHidden on tor process a9b3ea5 is described below commit a9b3ea54e298e891614907274069c2e400744c33 Author: Marco Simonelli <msimonelli(a)protonmail.com> AuthorDate: Mon Jun 27 08:48:28 2022 +0000 Tor Brower Bug 41039: set startHidden … [View More]

1 0

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 40458: Implement .tor.onion aliases
by gitolite role 24 Jun '22

24 Jun '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-91.10.0esr-11.5-1 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-91.10.0esr-11.5-1 by this push: new 9a5d862212abb fixup! Bug 40458: Implement .tor.onion aliases 9a5d862212abb is described below commit 9a5d862212abbade74b97e4e3dbe87e09ed9ac67 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Thu Jun 23 17:10:07 … [View More]2022 +0200 fixup! Bug 40458: Implement .tor.onion aliases Bug 41036: Add a preference to disable Onion Aliases --- .../components/onionservices/OnionAliasStore.jsm | 92 ++++++++++++++++------ modules/libpref/init/StaticPrefList.yaml | 5 ++ netwerk/dns/OnionAliasService.cpp | 5 +- 3 files changed, 79 insertions(+), 23 deletions(-) diff --git a/browser/components/onionservices/OnionAliasStore.jsm b/browser/components/onionservices/OnionAliasStore.jsm index 059bca8f5a2bf..d5849e4b94289 100644 --- a/browser/components/onionservices/OnionAliasStore.jsm +++ b/browser/components/onionservices/OnionAliasStore.jsm @@ -40,6 +40,8 @@ const SECURE_DROP = { currentTimestamp: 0, }; +const kPrefOnionAliasEnabled = "browser.urlbar.onionRewrites.enabled"; + // Logger adapted from CustomizableUI.jsm const kPrefOnionAliasDebug = "browser.onionalias.debug"; XPCOMUtils.defineLazyPreferenceGetter( @@ -299,29 +301,19 @@ class _OnionAliasStore { async init() { await this._loadSettings(); - const dt = Date.now() - this._lastCheck; - let force = false; - for (const ch of this._channels.values()) { - if (ch.enabled && !ch.currentTimestamp) { - // Edited while being offline or some other error happened - force = true; - break; - } - } - if (dt > _OnionAliasStore.RULESET_CHECK_INTERVAL || force) { - log.debug( - `Mappings are stale (${dt}), or force check requested (${force}), checking them immediately` - ); - await this._periodicRulesetCheck(); - } else { - this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL - dt); + if (this.enabled) { + await this._startUpdates(); } + Services.prefs.addObserver(kPrefOnionAliasEnabled, this); } uninit() { this._clear(); - clearTimeout(this._rulesetTimeout); + if (this._rulesetTimeout) { + clearTimeout(this._rulesetTimeout); + } this._rulesetTimeout = null; + Services.prefs.removeObserver(kPrefOnionAliasEnabled, this); } async getChannels() { @@ -362,13 +354,16 @@ class _OnionAliasStore { this._applyMappings(); this._saveSettings(); this._notifyChanges(); - if (enabled && !channel.currentTimestamp) { + if (this.enabled && enabled && !channel.currentTimestamp) { this.updateChannel(name); } } } async updateChannel(name) { + if (!this.enabled) { + throw Error("Onion Aliases are disabled"); + } const channel = this._channels.get(name); if (channel === null) { throw Error("Channel not found"); @@ -469,6 +464,10 @@ class _OnionAliasStore { } async _periodicRulesetCheck() { + if (!this.enabled) { + log.debug("Onion Aliases are disabled, not updating rulesets."); + return; + } log.debug("Begin scheduled ruleset update"); this._lastCheck = Date.now(); let anyUpdated = false; @@ -495,12 +494,46 @@ class _OnionAliasStore { this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL); } + async _startUpdates() { + // This is a "private" function, so we expect the callers to verify wheter + // onion aliases are enabled. + // Callees will also do, so we avoid an additional check here. + const dt = Date.now() - this._lastCheck; + let force = false; + for (const ch of this._channels.values()) { + if (ch.enabled && !ch.currentTimestamp) { + // Edited while being offline or some other error happened + force = true; + break; + } + } + if (dt > _OnionAliasStore.RULESET_CHECK_INTERVAL || force) { + log.debug( + `Mappings are stale (${dt}), or force check requested (${force}), checking them immediately` + ); + await this._periodicRulesetCheck(); + } else { + this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL - dt); + } + } + _scheduleCheck(dt) { + if (this._rulesetTimeout) { + log.warn("The previous update timeout was not null"); + clearTimeout(this._rulesetTimeout); + } + if (!this.enabled) { + log.warn( + "Ignoring the scheduling of a new check because the Onion Alias feature is currently disabled." + ); + this._rulesetTimeout = null; + return; + } log.debug(`Scheduling ruleset update in ${dt}`); - this._rulesetTimeout = setTimeout( - this._periodicRulesetCheck.bind(this), - dt - ); + this._rulesetTimeout = setTimeout(() => { + this._rulesetTimeout = null; + this._periodicRulesetCheck(); + }, dt); } _notifyChanges() { @@ -509,6 +542,21 @@ class _OnionAliasStore { OnionAliasStoreTopics.ChannelsChanged ); } + + get enabled() { + return Services.prefs.getBoolPref(kPrefOnionAliasEnabled, true); + } + + observe(aSubject, aTopic, aData) { + if (aTopic === "nsPref:changed") { + if (this.enabled) { + this._startUpdates(); + } else if (this._rulesetTimeout) { + clearTimeout(this._rulesetTimeout); + this._rulesetTimeout = null; + } + } + } } const OnionAliasStore = new _OnionAliasStore(); diff --git a/modules/libpref/init/StaticPrefList.yaml b/modules/libpref/init/StaticPrefList.yaml index b3e93c5443969..243585deecbf7 100644 --- a/modules/libpref/init/StaticPrefList.yaml +++ b/modules/libpref/init/StaticPrefList.yaml @@ -1338,6 +1338,11 @@ value: true mirror: always +- name: browser.urlbar.onionRewrites.enabled + type: RelaxedAtomicBool + value: true + mirror: always + - name: browser.viewport.desktopWidth type: RelaxedAtomicInt32 value: 980 diff --git a/netwerk/dns/OnionAliasService.cpp b/netwerk/dns/OnionAliasService.cpp index 5140f4fe0d833..a23bf93cee8b0 100644 --- a/netwerk/dns/OnionAliasService.cpp +++ b/netwerk/dns/OnionAliasService.cpp @@ -1,5 +1,7 @@ #include "torproject/OnionAliasService.h" +#include "mozilla/StaticPrefs_browser.h" + #include "nsUnicharUtils.h" /** @@ -74,7 +76,8 @@ NS_IMETHODIMP OnionAliasService::GetOnionAlias(const nsACString& aShortHostname, nsACString& aLongHostname) { aLongHostname = aShortHostname; - if (StringEndsWith(aShortHostname, ".tor.onion"_ns)) { + if (mozilla::StaticPrefs::browser_urlbar_onionRewrites_enabled() && + StringEndsWith(aShortHostname, ".tor.onion"_ns)) { nsAutoCString* alias = nullptr; // We want to keep the string stored in the map alive at least until we // finish to copy it to the output parameter. -- To stop receiving notification emails like this one, please contact the administrator of this repository. [View Less]

1 0

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 26961: New user onboarding.
by gitolite role 24 Jun '22

24 Jun '22

1 0

[tor-launcher] branch master updated: fixup! Bug 40774: Added new localized strings for about:preferences#connection
by gitolite role 23 Jun '22

23 Jun '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch master in repository tor-launcher. The following commit(s) were added to refs/heads/master by this push: new b0294bf fixup! Bug 40774: Added new localized strings for about:preferences#connection b0294bf is described below commit b0294bf3b4b7e09b7c2c94bb82c037af8e2e7f57 Author: emmapeel <emma.peel(a)riseup.net> AuthorDate: Thu Jun 9 17:23:32 2022 +0000 fixup! Bug 40774: Added … [View More]

1 0

[tor-browser] annotated tag FIREFOX_91_11_0esr_BUILD1 created (now 279b8ef34d59e)
by gitolite role 22 Jun '22

22 Jun '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to annotated tag FIREFOX_91_11_0esr_BUILD1 in repository tor-browser. at 279b8ef34d59e (tag) tagging 0516fde4797929eeb4032ea45766f02e43a7fb26 (commit) replaces FIREFOX_91_10_0esr_BUILD1 by Richard Pospesel on Wed Jun 22 18:13:38 2022 +0000 - Log ----------------------------------------------------------------- Hg tag FIREFOX_91_11_0esr_BUILD1 -----BEGIN PGP SIGNATURE----- … [View More]

1 0

[tor-browser] branch tor-browser-91.11.0esr-11.5-1 created (now 0516fde479792)
by gitolite role 22 Jun '22

22 Jun '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to branch tor-browser-91.11.0esr-11.5-1 in repository tor-browser. at 0516fde479792 Bug 1727653 - wait for resize event before testing restoration of persisted sizes. r=niklas, a=RyanVM This branch includes the following new commits: new bc52931fb79e6 No bug - Tagging 9cbe8ffa12101019dbe0da698f869ed3ef0b9370 with FIREFOX_91_10_0esr_BUILD1 a=release CLOSED TREE DONTBUILD new … [View More]8b0562996d3a0 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release new 7dcf573525c23 No bug - Tagging 9cbe8ffa12101019dbe0da698f869ed3ef0b9370 with FIREFOX_91_10_0esr_RELEASE a=release CLOSED TREE DONTBUILD new 4cd1f89548a1c No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings - a=repo-update new 07ae1d7ed4ce2 No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM new a2a894e75f7b9 Bug 1754752 - Use initializer lists in some swgl constructors. r=lsalzman, a=RyanVM new 7e3eb9cc77876 No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM new 02b4f39287c13 Bug 1692724: More don't spawn a second save thread if one already exists. r=mccr8, a=RyanVM new 5dd6888c8df52 Bug 1771026 - Remove some dead tagging code in Pocket panels. r=Gijs, a=RyanVM new af7eb0fb56526 Bug 1768537, r=smaug a=RyanVM new be2cfa3b75bfd Bug 1568275 - Disable deceptive content prefs when locked. r=Gijs, a=RyanVM new 7ab788b1ca3f8 Bug 1771932 - Use more initializer lists in glsl.h. r=gw a=RyanVM new 8de6de24409d2 No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings - a=repo-update new 060ab5af3c02c Bug 1771381 - Use entries in TabAttributesInternal.set(). r=Gijs, a=RyanVM new 5eefe627065da Bug 1770123 - Clear PAC loader when the load is failed, r=dragana a=RyanVM new 38d04993eea07 Bug 1765951 - Stop storing BC pointer in nsSHistory. r=smaug, a=RyanVM new 7c569ade2d33e No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM new e5894b0d64753 Bug 1757604 - Make content-type on JAR channels behave the same as HTTP channels. r=Gijs, a=RyanVM new 86f3114eae37b Bug 1770848, r=jaws,mccr8 a=RyanVM new e50bdabd6fc17 Bug 1763634 - part 1: Make `BrowserParent` handle test APIs only when it's in the automated mode. r=smaug, a=RyanVM new 930671a4e229c Bug 1763634 - part 2: Make `BrowserParent` verify whether replied keyboard events are what it sent. r=smaug, a=RyanVM new 3d507046bdfe1 Bug 1771523 - Add telemetry probe for app signature verification outcomes. r=keeler a=RyanVM new 52bb3c6c0f734 Bug 1730375 [wpt PR 30627] - Regenerate WPT certificates, a=testonly new f263760a1e8e2 Bug 1735252 [wpt PR 31197] - Regenerate WPT certificates, a=testonly new 383dcdcd84f88 No Bug, mozilla-esr91 repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM new 27842d5f78706 Bug 1497246 - Release-check aCount for underflow in ReplaceElementsAt, r=mccr8 a=RyanVM new 6e8c253e5c4c3 Bug 1772651 - Check if the actor is dead in GetOtherInProcessActor, r=mccr8 a=RyanVM new c5287a9e7a8fe Backed out changeset 1f239a458a10 (bug 1497246) for bustage. new 243ddbd52b791 Bug 1497246 - Release-check aCount for underflow in ReplaceElementsAt, r=mccr8 a=RyanVM new e8f8421e34d7d Bug 1771084 part 2 - Add Realm option to freeze builtins. r=tcampbell,nika a=RyanVM new 01a7a82f9d039 Bug 1771084 part 3 - Freeze builtins for the shared system global. r=mccr8,peterv a=RyanVM new 8eaccebe37208 Bug 1745595 - type ResizeInt() parameters to specify units. r=stransky, a=RyanVM new a376ae0dd8dd7 Bug 1745595 - wait for resize to complete before adding media query. r=daisuke, a=RyanVM new 5b767700fb728 Bug 1745595 - record window size changes from app-initiated resizes asynchronously after the first size-allocate. r=stransky, a=RyanVM new 0bf971823825c Bug 1745595 - wait for expected geometry after move or resize. r=whimboo, a=RyanVM new 489ac60e609d0 Bug 1745595 - wait for resize to complete before testing className. r=Mardak, a=RyanVM new 0516fde479792 Bug 1727653 - wait for resize event before testing restoration of persisted sizes. r=niklas, a=RyanVM The 37 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. -- To stop receiving notification emails like this one, please contact the administrator of this repository. [View Less]

1 37

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 40458: Implement .tor.onion aliases
by gitolite role 21 Jun '22

21 Jun '22

1 0

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
by gitolite role 21 Jun '22

21 Jun '22

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

tbb-commits June 2022