tbb-commits October 2022

tbb-commits@lists.torproject.org

2 participants
177 discussions

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated (5293cbaea3eb -> cbb8519e4368)
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. from 5293cbaea3eb fixup! Base Browser's .mozconfigs. new 04a76db04926 fixup! Base Browser's .mozconfigs. new cbb8519e4368 fixup! Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: modules/libpref/init/all.js | 2 +- mozconfig-linux-x86_64-dev | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser-spec] branch main updated: Bug 40023: FF94 Audit
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch main in repository tor-browser-spec. The following commit(s) were added to refs/heads/main by this push: new 07a365b Bug 40023: FF94 Audit 07a365b is described below commit 07a365bf04def6941ecbcd288b6c8d9fad4e40bf Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Oct 11 19:58:15 2022 +0000 Bug 40023: FF94 Audit --- audits/FF94_AUDIT | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/audits/FF94_AUDIT b/audits/FF94_AUDIT new file mode 100644 index 0000000..b3a48fb --- /dev/null +++ b/audits/FF94_AUDIT @@ -0,0 +1,83 @@ +Tracking Issue: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40… + +# General + +The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript). + +The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation. + +code_audit.sh contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit. + +## Firefox + +### Repo: https://github.com/mozilla/gecko-dev.git + +- Start: `5f4358c1c5bc2ca87d60eadebeab439562c90495` ( `FIREFOX_RELEASE_94_BASE` ) +- End: `6c9b6e1483551f220cd409e4e584349bc74a8231` ( `FIREFOX_RELEASE_95_BASE` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +(mostly) only tests triggered matches or false positives + +--- + +## Application Services + +### Repo: https://github.com/mozilla/application-services.git + +- Start: `b1f371719ca20db642b64a0e860b4ecb0aaf316f` ( v86.1.0 ) +- End: `df1a47fde89f49201b1e839f960e8f16eb95a55d` ( v87.1.0 ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +## Android Components + +### Repo: https://github.com/mozilla-mobile/android-components.git + +- Start: `fce7eb5cff2d56acd3195bf1d9a89386c63dc3d5` ( `v94.0.0` ) +- End: `28c1b7db40105dcaea09caa0b5108554a83959cd` ( `v94.0.15` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Fenix + +### Repo: https://github.com/mozilla-mobile/fenix.git + +- Start: 54d80751bfc9a4aa4341e78221060940a36e3d17 ( v94.0.0-beta.1 ) +- End: cb5708f88847601426833067f93d16d25d36451f ( v94.1.2 ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Ticket Review ## + +### Review List + +#### 94 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=F… + +- https://bugzilla.mozilla.org/show_bug.cgi?id=1730418 : @ma1 https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41123 + - Nothing to do here +- https://bugzilla.mozilla.org/show_bug.cgi?id=1732388: @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41124 + - Disabled by network.proxy.allow_bypass = false + -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch main updated: Bug 40585: Prune the manual more
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch main in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/main by this push: new 2fd9760 Bug 40585: Prune the manual more 2fd9760 is described below commit 2fd9760aa3982e58a2b8c6881cea9046bac49326 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Mon Oct 10 18:45:02 2022 +0200 Bug 40585: Prune the manual more --- projects/manual/build | 14 +++++++++++--- projects/manual/config | 2 +- projects/manual/packagemanual.py | 21 ++++++++++++++++++++- 3 files changed, 32 insertions(+), 5 deletions(-) diff --git a/projects/manual/build b/projects/manual/build index d569632..d6d5c74 100644 --- a/projects/manual/build +++ b/projects/manual/build @@ -5,7 +5,15 @@ mkdir -p chrome/browser/content/browser/manual unzip $rootdir/[% c('input_files_by_name/manual') %] python3 $rootdir/[% c('input_files_by_name/package_script') %] public chrome/browser/content/browser/manual +pushd chrome/browser/content/browser/manual/static +find -name '*.map' -delete +rm -rf fonts +rm -rf css/digital-climate-strike css/images +# We prune unused images in the Python script, but empty directories remain +find images -type d -empty -delete +popd + [% c('tar', { - tar_src => [ 'chrome' ], - tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), - }) %] + tar_src => [ 'chrome' ], + tar_args => '-czf ' _ dest_dir _ '/' _ c('filename'), + }) %] diff --git a/projects/manual/config b/projects/manual/config index 4fe9356..9112864 100644 --- a/projects/manual/config +++ b/projects/manual/config @@ -2,7 +2,7 @@ # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! version: 50953 -filename: 'manual-[% c("version") %].tar.gz' +filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.gz' container: use_container: 1 diff --git a/projects/manual/packagemanual.py b/projects/manual/packagemanual.py index f4a3b98..7af5104 100755 --- a/projects/manual/packagemanual.py +++ b/projects/manual/packagemanual.py @@ -31,10 +31,20 @@ def clean_urls(match): return f'href="#{slug}{anchor}"' +remove_images = [] +for p in (source / 'static/images').glob('**/*'): + if p.is_file(): + rel = p.relative_to(source) + remove_images.append(rel) + htmls = source.rglob(f'{PAGE_NAME}/index.html') for page in htmls: with page.open(encoding='utf8') as f: contents = f.read() + + remove_images = list(filter( + lambda im: contents.find(str(im)) == -1, remove_images)) + contents = static_re.sub(f'"{STATIC_PATH}/\\1"', contents) contents = link_re.sub(clean_urls, contents) @@ -46,5 +56,14 @@ for page in htmls: with (target / dest_name).open('w', encoding='utf8') as f: f.write(contents) + +def ignore_images(path, names): + return [ + n + for n in names + if Path(path, n).relative_to(source) in remove_images + ] + + shutil.rmtree(target / 'static', ignore_errors=True) -shutil.copytree(source / 'static', target / 'static') +shutil.copytree(source / 'static', target / 'static', ignore=ignore_images) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torbutton] branch maint-11.5 updated: Bug 41355: Adjust line spacing in YEC 2022 heading
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch maint-11.5 in repository torbutton. The following commit(s) were added to refs/heads/maint-11.5 by this push: new 042f1687 Bug 41355: Adjust line spacing in YEC 2022 heading 042f1687 is described below commit 042f1687e38915803b1e25bb19b28af2256ca2d2 Author: Henry Wilkes <henry(a)torproject.org> AuthorDate: Wed Oct 12 09:58:44 2022 +0100 Bug 41355: Adjust line spacing in YEC 2022 heading --- chrome/skin/aboutTor.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/skin/aboutTor.css b/chrome/skin/aboutTor.css index 2ea6807e..5c75c1f0 100644 --- a/chrome/skin/aboutTor.css +++ b/chrome/skin/aboutTor.css @@ -206,7 +206,7 @@ body:not([showmanual]) .showForManual { * yec-background-image, even if one of the sub-heading elements has long text * content that would normally grow the size of the grid. */ width: 1px; - line-height: 1; + line-height: 1.05; font-family: 'Space Grotesk', sans-serif; font-size: 60px; letter-spacing: -0.05em; -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Base Browser's .mozconfigs.
by gitolite role 12 Oct '22

12 Oct '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 5293cbaea3eb fixup! Base Browser's .mozconfigs. 5293cbaea3eb is described below commit 5293cbaea3eb835ce8173513b4fd862101ad58a5 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Tue Oct 11 19:23:07 2022 +0200 fixup! Base Browser's .mozconfigs. Bug 41131: Disable background tasks in all platforms, and the update agent in Windows and macOS. --- browser/config/mozconfigs/base-browser | 3 +++ mozconfig-macos-x86_64 | 3 +++ mozconfig-windows-i686 | 3 +++ mozconfig-windows-x86_64 | 3 +++ 4 files changed, 12 insertions(+) diff --git a/browser/config/mozconfigs/base-browser b/browser/config/mozconfigs/base-browser index 285f43fec4ef..82b224f43ed1 100644 --- a/browser/config/mozconfigs/base-browser +++ b/browser/config/mozconfigs/base-browser @@ -30,6 +30,9 @@ ac_add_options --enable-proxy-bypass-protection # could allow proxy bypass, and override a number of other preferences we set ac_add_options --disable-system-policies +# See bug #41131 +ac_add_options --disable-backgroundtasks + ac_add_options --enable-base-browser # Disable telemetry diff --git a/mozconfig-macos-x86_64 b/mozconfig-macos-x86_64 index e2286f972e62..b81001df5633 100644 --- a/mozconfig-macos-x86_64 +++ b/mozconfig-macos-x86_64 @@ -2,4 +2,7 @@ ac_add_options --enable-strip +# See bug #41131 +ac_add_options --disable-update-agent + ac_add_options --enable-tor-browser-data-outside-app-dir diff --git a/mozconfig-windows-i686 b/mozconfig-windows-i686 index 78ff05ecc810..afe083885bfc 100644 --- a/mozconfig-windows-i686 +++ b/mozconfig-windows-i686 @@ -9,3 +9,6 @@ ac_add_options --enable-strip ac_add_options --disable-bits-download ac_add_options --disable-maintenance-service ac_add_options --disable-default-browser-agent + +# See bug #41131 +ac_add_options --disable-update-agent diff --git a/mozconfig-windows-x86_64 b/mozconfig-windows-x86_64 index 93b7a28fd361..67bc37c4e5ff 100644 --- a/mozconfig-windows-x86_64 +++ b/mozconfig-windows-x86_64 @@ -9,3 +9,6 @@ ac_add_options --enable-strip ac_add_options --disable-bits-download ac_add_options --disable-maintenance-service ac_add_options --disable-default-browser-agent + +# See bug #41131 +ac_add_options --disable-update-agent -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Bug 40926: Implemented the New Identity feature
by gitolite role 11 Oct '22

11 Oct '22

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
by gitolite role 11 Oct '22

11 Oct '22

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated: fixup! Firefox preference overrides.
by gitolite role 10 Oct '22

10 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.3.0esr-12.0-2 by this push: new 1af611fd6b42 fixup! Firefox preference overrides. 1af611fd6b42 is described below commit 1af611fd6b42f9e72a211764e0f25df58ffb5cb7 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Mon Oct 10 14:54:13 2022 +0200 fixup! Firefox preference overrides. Bug 41345: fonts: windows whitelist contains supplemental fonts --- browser/app/profile/001-base-profile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/app/profile/001-base-profile.js b/browser/app/profile/001-base-profile.js index f4524718aa3f..48de619508db 100644 --- a/browser/app/profile/001-base-profile.js +++ b/browser/app/profile/001-base-profile.js @@ -477,7 +477,7 @@ pref("font.name-list.monospace.x-unicode", "Menlo, Courier New, Noto Sans Baline #endif #ifdef XP_WIN -pref("font.system.whitelist", "Arial, Cambria Math, Consolas, Courier New, Georgia, Lucida Console, MS Gothic, ＭＳゴシック, MS PGothic, ＭＳＰゴシック, MV Boli, Malgun Gothic, Mangal, Microsoft Himalaya, Microsoft JhengHei, Microsoft YaHei, 微软雅黑, MingLiU, 細明體, PMingLiU, 新細明體, Segoe UI, SimSun, 宋体, Sylfaen, Tahoma, Times New Roman, Verdana, Twemoji Mozilla, Noto Sans Adlam, Noto Sans Balinese, Noto Sans Bamum, Noto Sans Bassa Vah, Noto Sans Batak, Noto Sans Bengali, Noto Sans Buginese, Noto Sans Bu [...] +pref("font.system.whitelist", "Arial, Cambria Math, Consolas, Courier New, Georgia, Lucida Console, MS Gothic, ＭＳゴシック, MS PGothic, ＭＳＰゴシック, MV Boli, Malgun Gothic, Microsoft Himalaya, Microsoft JhengHei, Microsoft YaHei, 微软雅黑, Segoe UI, SimSun, 宋体, Sylfaen, Tahoma, Times New Roman, Verdana, Twemoji Mozilla, Noto Sans Adlam, Noto Sans Balinese, Noto Sans Bamum, Noto Sans Bassa Vah, Noto Sans Batak, Noto Sans Bengali, Noto Sans Buginese, Noto Sans Buhid, Noto Sans Canadian Aboriginal, No [...] // Arabic pref("font.name-list.serif.ar", "Times New Roman, Noto Naskh Arabic"); -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.3.0esr-12.0-2 updated (93c9881b2a05 -> 0a0945855cb7)
by gitolite role 10 Oct '22

10 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to branch tor-browser-102.3.0esr-12.0-2 in repository tor-browser. from 93c9881b2a05 fixup! Base Browser's .mozconfigs. new 6fc29f91fbe8 fixup! TB3: Tor Browser's official .mozconfigs. new d294beea175d Revert "Bug 28044: Integrate Tor Launcher into tor-browser" new ec870ce68851 Bug 40933: Add tor-launcher functionality new 1a64d858c5ab fixup! Bug 40933: Add tor-launcher functionality new 07710cca4425 fixup! Bug 40562: Added Tor-related preferences to 000-tor-browser.js new 2df6696ded66 fixup! Bug 40597: Implement TorSettings module new c3726ddc7c05 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser new eeb101368c6e fixup! Bug 4234: Use the Firefox Update Process for Tor Browser. new 91abcc7a6a7f fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection new 0a0945855cb7 fixup! Bug 10760: Integrate TorButton to TorBrowser core The 10 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: browser/app/profile/000-tor-browser.js | 69 ++ browser/components/sessionstore/SessionStore.jsm | 5 - .../torpreferences/content/connectionPane.js | 11 +- .../torpreferences/content/torLogDialog.jsm | 6 +- browser/config/mozconfigs/tor-browser-android | 3 - browser/extensions/moz.build | 3 - browser/installer/Makefile.in | 4 - browser/installer/package-manifest.in | 6 +- browser/modules/BridgeDB.jsm | 2 +- browser/modules/Moat.jsm | 4 +- browser/modules/TorConnect.jsm | 73 +- browser/modules/TorProcessService.jsm | 12 - browser/modules/TorProtocolService.jsm | 510 -------------- browser/modules/TorSettings.jsm | 25 +- browser/modules/moz.build | 2 - moz.configure | 18 - mozconfig-linux-x86_64-dev | 1 - toolkit/components/moz.build | 1 + .../processsingleton/MainProcessSingleton.jsm | 4 - .../tor-launcher/TorBootstrapRequest.jsm | 131 ++++ .../components/tor-launcher/TorLauncherUtil.jsm | 600 +++++++++++++++++ .../components/tor-launcher/TorMonitorService.jsm | 449 ++++++++++++ toolkit/components/tor-launcher/TorParsers.jsm | 275 ++++++++ toolkit/components/tor-launcher/TorProcess.jsm | 552 +++++++++++++++ .../components/tor-launcher/TorProtocolService.jsm | 749 +++++++++++++++++++++ .../components/tor-launcher/TorStartupService.jsm | 90 +++ toolkit/components/tor-launcher/components.conf | 10 + toolkit/components/tor-launcher/moz.build | 17 + .../components/tor-launcher/tor-launcher.manifest | 1 + toolkit/mozapps/update/UpdateService.jsm | 8 +- toolkit/torproject/torbutton | 2 +- 31 files changed, 3003 insertions(+), 640 deletions(-) delete mode 100644 browser/modules/TorProcessService.jsm delete mode 100644 browser/modules/TorProtocolService.jsm create mode 100644 toolkit/components/tor-launcher/TorBootstrapRequest.jsm create mode 100644 toolkit/components/tor-launcher/TorLauncherUtil.jsm create mode 100644 toolkit/components/tor-launcher/TorMonitorService.jsm create mode 100644 toolkit/components/tor-launcher/TorParsers.jsm create mode 100644 toolkit/components/tor-launcher/TorProcess.jsm create mode 100644 toolkit/components/tor-launcher/TorProtocolService.jsm create mode 100644 toolkit/components/tor-launcher/TorStartupService.jsm create mode 100644 toolkit/components/tor-launcher/components.conf create mode 100644 toolkit/components/tor-launcher/moz.build create mode 100644 toolkit/components/tor-launcher/tor-launcher.manifest -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 10

[torbutton] branch main updated (829fab42 -> d96a8864)
by gitolite role 10 Oct '22

10 Oct '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to branch main in repository torbutton. from 829fab42 Translation updates new 12c59736 Bug 40730: Do not register localizations in 102 new d96a8864 Bug 40933: Moved tor-launcher to tor-browser.git The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: chrome/content/torbutton.js | 26 ++++++-------- components/startup-observer.js | 78 ++++++++++++++++++++++++------------------ modules/tor-control-port.js | 12 +++---- 3 files changed, 61 insertions(+), 55 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

← Newer
1
...
10
11
12
13
14
15
16
17
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

tbb-commits October 2022