tbb-commits

Download

tbb-commits@lists.torproject.org

September 2020

4 participants
214 discussions

[tor-browser/tor-browser-81.0b9-10.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 26 Sep '20

26 Sep '20

commit 9e380b2e181813da457c2474ed6629c571131d6e Author: Alex Catarineu <acat(a)torproject.org> Date: Thu Sep 24 20:28:29 2020 +0200 fixup! TB4: Tor Browser's Firefox preference overrides. Fixes #40148. --- browser/app/profile/000-tor-browser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index bac98ce06540..278c368c823c 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -180,6 +180,7 @@ pref("privacy.resistFingerprinting.letterboxing", true); // not leak that difference if possible. pref("dom.netinfo.enabled", false); pref("network.http.referer.defaultPolicy", 2); // Bug 32948: Make referer behavior consistent regardless of private browing mode status +pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Third party stuff pref("privacy.firstparty.isolate", true); // Always enforce first party isolation

1 0

[tor-browser/tor-browser-78.3.0esr-10.0-2] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 26 Sep '20

26 Sep '20

commit 7061f07e6ef910fd35c3a67e378ed8ed979b3bc6 Author: Alex Catarineu <acat(a)torproject.org> Date: Thu Sep 24 20:28:29 2020 +0200 fixup! TB4: Tor Browser's Firefox preference overrides. Fixes #40148. --- browser/app/profile/000-tor-browser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 7e29c788b720..304443230cf0 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -180,6 +180,7 @@ pref("privacy.resistFingerprinting.letterboxing", true); // not leak that difference if possible. pref("dom.netinfo.enabled", false); pref("network.http.referer.defaultPolicy", 2); // Bug 32948: Make referer behavior consistent regardless of private browing mode status +pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Third party stuff pref("privacy.firstparty.isolate", true); // Always enforce first party isolation

1 0

[tor-browser/tor-browser-78.3.0esr-10.5-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 26 Sep '20

26 Sep '20

commit 94e52171a3390e100f71b4808b675fb61de6939c Author: Alex Catarineu <acat(a)torproject.org> Date: Thu Sep 24 20:28:29 2020 +0200 fixup! TB4: Tor Browser's Firefox preference overrides. Fixes #40148. --- browser/app/profile/000-tor-browser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index bac98ce06540..278c368c823c 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -180,6 +180,7 @@ pref("privacy.resistFingerprinting.letterboxing", true); // not leak that difference if possible. pref("dom.netinfo.enabled", false); pref("network.http.referer.defaultPolicy", 2); // Bug 32948: Make referer behavior consistent regardless of private browing mode status +pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Third party stuff pref("privacy.firstparty.isolate", true); // Always enforce first party isolation

1 0

[Git][tpo/applications/fenix][tor-browser-81.1.1-10.0-1] 2 commits: Bug 34378: Port external helper app prompting
by Matthew Finkel 25 Sep '20

25 Sep '20

Matthew Finkel pushed to branch tor-browser-81.1.1-10.0-1 at The Tor Project / Applications / fenix Commits: 67e28112 by Alex Catarineu at 2020-09-22T17:43:24+02:00 Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - 8b0f722f by Matthew Finkel at 2020-09-25T19:06:31+00:00 Merge remote-tracking branch 'acatgl/34378' into tor-browser-81.1.1-10.0-1 - - - - - 2 changed files: - app/src/main/java/org/mozilla/fenix/HomeActivity.kt - app/src/main/java/org/mozilla/fenix/share/ShareController.kt Changes: ===================================== app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -4,6 +4,7 @@ package org.mozilla.fenix +import android.app.PendingIntent import android.content.BroadcastReceiver import android.content.Context import android.content.Intent @@ -45,6 +46,8 @@ import mozilla.components.browser.state.state.SessionState import mozilla.components.browser.state.state.WebExtensionState import mozilla.components.concept.engine.EngineSession import mozilla.components.concept.engine.EngineView +import mozilla.components.feature.app.links.RedirectDialogFragment +import mozilla.components.feature.app.links.SimpleRedirectDialogFragment import mozilla.components.feature.contextmenu.DefaultSelectionActionDelegate import mozilla.components.feature.privatemode.notification.PrivateNotificationFeature import mozilla.components.feature.search.BrowserStoreSearchAdapter @@ -58,6 +61,7 @@ import mozilla.components.support.ktx.kotlin.isUrl import mozilla.components.support.ktx.kotlin.toNormalizedUrl import mozilla.components.support.locale.LocaleAwareAppCompatActivity import mozilla.components.support.utils.SafeIntent +import mozilla.components.support.utils.TorUtils import mozilla.components.support.utils.toSafeIntent import mozilla.components.support.webextensions.WebExtensionPopupFeature import org.mozilla.fenix.GleanMetrics.Metrics @@ -154,6 +158,8 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { private lateinit var navigationToolbar: Toolbar + private var dialog: RedirectDialogFragment? = null + final override fun onCreate(savedInstanceState: Bundle?) { // Give Orbot the base Context Prefs.setContext(applicationContext) @@ -387,6 +393,26 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { super.recreate() } + // Copied from mozac AppLinksFeature.kt + internal fun getOrCreateDialog(): RedirectDialogFragment { + val existingDialog = dialog + if (existingDialog != null) { + return existingDialog + } + + SimpleRedirectDialogFragment.newInstance().also { + dialog = it + return it + } + } + private fun isAlreadyADialogCreated(): Boolean { + return findPreviousDialogFragment() != null + } + + private fun findPreviousDialogFragment(): RedirectDialogFragment? { + return supportFragmentManager.findFragmentByTag(RedirectDialogFragment.FRAGMENT_TAG) as? RedirectDialogFragment + } + /** * Handles intents received when the activity is open. */ @@ -394,6 +420,25 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { super.onNewIntent(intent) intent ?: return + val startIntent = intent.getParcelableExtra<PendingIntent>(TorUtils.TORBROWSER_START_ACTIVITY_PROMPT) + if (startIntent != null) { + if (startIntent.creatorPackage == applicationContext.packageName) { + val dialog = getOrCreateDialog() + dialog.onConfirmRedirect = { + try { + startIntent.send() + } catch (error: PendingIntent.CanceledException) { + } + } + dialog.onCancelRedirect = {} + + if (!isAlreadyADialogCreated()) { + dialog.showNow(supportFragmentManager, RedirectDialogFragment.FRAGMENT_TAG) + } + } + return + } + // Diagnostic breadcrumb for "Display already aquired" crash: // https://github.com/mozilla-mobile/android-components/issues/7960 breadcrumb( ===================================== app/src/main/java/org/mozilla/fenix/share/ShareController.kt ===================================== @@ -25,6 +25,7 @@ import mozilla.components.concept.sync.TabData import mozilla.components.feature.accounts.push.SendTabUseCases import mozilla.components.feature.share.RecentAppsStorage import mozilla.components.support.ktx.kotlin.isExtensionUrl +import mozilla.components.support.utils.TorUtils import org.mozilla.fenix.R import org.mozilla.fenix.components.FenixSnackbar import org.mozilla.fenix.components.metrics.Event @@ -99,7 +100,7 @@ class DefaultShareController( } val result = try { - context.startActivity(intent) + TorUtils.startActivityPrompt(context, intent) ShareController.Result.SUCCESS } catch (e: SecurityException) { snackbar.setText(context.getString(R.string.share_error_snackbar)) View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/7b11da2715b7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/7b11da2715b7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/android-components][android-components-57.0.6-10.0-1] 2 commits: Bug 40007: Port external helper app prompting
by Matthew Finkel 25 Sep '20

25 Sep '20

Matthew Finkel pushed to branch android-components-57.0.6-10.0-1 at The Tor Project / Applications / android-components Commits: 282eda4d by Alex Catarineu at 2020-09-24T14:55:29+02:00 Bug 40007: Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - 288e6a1e by Matthew Finkel at 2020-09-25T19:01:43+00:00 Merge remote-tracking branch 'acatgl/40007+1' into android-components-57.0.6-10.0-1 - - - - - 7 changed files: - components/feature/app-links/build.gradle - components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt - components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksUseCases.kt - components/feature/contextmenu/src/main/java/mozilla/components/feature/contextmenu/ContextMenuCandidate.kt - components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt - components/support/ktx/src/main/java/mozilla/components/support/ktx/android/content/Context.kt - + components/support/utils/src/main/java/mozilla/components/support/utils/TorUtils.kt Changes: ===================================== components/feature/app-links/build.gradle ===================================== @@ -36,6 +36,7 @@ dependencies { implementation Dependencies.kotlin_stdlib implementation Dependencies.kotlin_coroutines + implementation project(path: ':support-utils') testImplementation project(':support-test') ===================================== components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt ===================================== @@ -67,7 +67,8 @@ class AppLinksFeature( loadUrlUseCase?.invoke(url, session, EngineSession.LoadUrlFlags.none()) } - if (!session.private || fragmentManager == null) { + // useCases.openAppLink will now prompt: calling it directly to avoid prompting twice + if (true || !session.private || fragmentManager == null) { doOpenApp() return } ===================================== components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksUseCases.kt ===================================== @@ -19,6 +19,7 @@ import mozilla.components.support.base.log.logger.Logger import mozilla.components.support.ktx.android.content.pm.isPackageInstalled import mozilla.components.support.ktx.android.net.isHttpOrHttps import java.net.URISyntaxException +import mozilla.components.support.utils.TorUtils private const val EXTRA_BROWSER_FALLBACK_URL = "browser_fallback_url" private const val MARKET_INTENT_URI_PACKAGE_PREFIX = "market://details?id=" @@ -200,7 +201,7 @@ class AppLinksUseCases( if (launchInNewTask) { it.flags = it.flags or Intent.FLAG_ACTIVITY_NEW_TASK } - context.startActivity(it) + TorUtils.startActivityPrompt(context, it) } catch (e: ActivityNotFoundException) { failedToLaunchAction() Logger.error("failed to start third party app activity", e) ===================================== components/feature/contextmenu/src/main/java/mozilla/components/feature/contextmenu/ContextMenuCandidate.kt ===================================== @@ -18,6 +18,7 @@ import mozilla.components.feature.app.links.AppLinksUseCases import mozilla.components.support.ktx.android.content.addContact import mozilla.components.support.ktx.android.content.share import mozilla.components.support.ktx.kotlin.stripMailToProtocol +import mozilla.components.support.utils.TorUtils /** * A candidate for an item to be displayed in the context menu. @@ -320,7 +321,7 @@ data class ContextMenuCandidate( context.getString(R.string.mozac_feature_contextmenu_share_link) ).addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) - context.startActivity(shareIntent) + TorUtils.startActivityPrompt(context, shareIntent) } ) ===================================== components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt ===================================== @@ -70,6 +70,7 @@ import mozilla.components.support.base.log.logger.Logger import mozilla.components.support.ktx.kotlin.sanitizeURL import mozilla.components.support.ktx.kotlinx.coroutines.throttleLatest import mozilla.components.support.utils.DownloadUtils +import mozilla.components.support.utils.TorUtils import java.io.File import java.io.FileOutputStream import java.io.IOException @@ -812,7 +813,7 @@ abstract class AbstractFetchDownloadService : Service() { } return try { - context.startActivity(newIntent) + TorUtils.startActivityPrompt(context, newIntent) true } catch (error: ActivityNotFoundException) { false ===================================== components/support/ktx/src/main/java/mozilla/components/support/ktx/android/content/Context.kt ===================================== @@ -35,6 +35,7 @@ import mozilla.components.support.base.log.Log import mozilla.components.support.base.log.logger.Logger import mozilla.components.support.ktx.R import mozilla.components.support.ktx.android.content.res.resolveAttribute +import mozilla.components.support.utils.TorUtils /** * The (visible) version name of the application, as specified by the <manifest> tag's versionName @@ -105,7 +106,7 @@ fun Context.share(text: String, subject: String = getString(R.string.mozac_suppo flags = FLAG_ACTIVITY_NEW_TASK } - startActivity(shareIntent) + TorUtils.startActivityPrompt(this, shareIntent) true } catch (e: ActivityNotFoundException) { Log.log(Log.Priority.WARN, message = "No activity to share to found", throwable = e, tag = "Reference-Browser") @@ -136,7 +137,7 @@ fun Context.email( flags = FLAG_ACTIVITY_NEW_TASK } - startActivity(emailIntent) + TorUtils.startActivityPrompt(this, emailIntent) true } catch (e: ActivityNotFoundException) { Logger.warn("No activity found to handle email intent", throwable = e) @@ -167,7 +168,7 @@ fun Context.call( flags = FLAG_ACTIVITY_NEW_TASK } - startActivity(callIntent) + TorUtils.startActivityPrompt(this, callIntent) true } catch (e: ActivityNotFoundException) { Logger.warn("No activity found to handle dial intent", throwable = e) @@ -195,7 +196,7 @@ fun Context.addContact( addFlags(FLAG_ACTIVITY_NEW_TASK) } - startActivity(intent) + TorUtils.startActivityPrompt(this, intent) true } catch (e: ActivityNotFoundException) { Logger.warn("No activity found to handle dial intent", throwable = e) ===================================== components/support/utils/src/main/java/mozilla/components/support/utils/TorUtils.kt ===================================== @@ -0,0 +1,26 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package mozilla.components.support.utils + +import android.app.PendingIntent +import android.content.Context +import android.content.Intent + +object TorUtils { + const val TORBROWSER_START_ACTIVITY_PROMPT = "torbrowser_start_activity_prompt" + + // Delegates showing prompt and possibly starting the activity to the main app activity. + // Highly dependant on Fenix/Tor Browser for Android. + // One downside of this implementation is that it does not throw exceptions like the + // direct context.startActivity, so the UI will behave as if the startActivity call was + // done successfully, which may not always be the case. + fun startActivityPrompt(context: Context, intent: Intent) { + val intentContainer = Intent() + intentContainer.setPackage(context.applicationContext.packageName) + intentContainer.putExtra(TORBROWSER_START_ACTIVITY_PROMPT, PendingIntent.getActivity(context, 0, intent, 0)) + intentContainer.flags = Intent.FLAG_ACTIVITY_NEW_TASK + context.startActivity(intentContainer) + } +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/android-components/-/compare… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/android-components/-/compare… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[tor-browser-build/master] Bug 40105: Enhance Gradle dependency script
by sysrqb＠torproject.org 23 Sep '20

23 Sep '20

commit 4f9ab234282887c8b0394da8ef9a5b8802afa863 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Sep 22 12:02:59 2020 +0000 Bug 40105: Enhance Gradle dependency script We sort now in a way that makes the output reproducible on different machines and exclude .module files, too, as we do not need them. --- tools/gen_gradle_deps_file.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/gen_gradle_deps_file.sh b/tools/gen_gradle_deps_file.sh index 377676f..99d0517 100755 --- a/tools/gen_gradle_deps_file.sh +++ b/tools/gen_gradle_deps_file.sh @@ -38,12 +38,13 @@ # having made a copy of `gradle-dependencies-list.txt` from 1) and comparing # the two .txt files. +export LC_ALL=C log="$1" # Step 1: Extract all the download attempts out of the log file, ignore the ones -# for maven-metadata.xml files. We don't need those. +# for maven-metadata.xml and module files. We don't need those. cat $log | grep "Performing HTTP" | grep -o "https://.*" | \ - grep -v "maven-metadata.xml" | sort | uniq > dl-attempts + grep -vE "\.module|maven-metadata\.xml" | sort | uniq > dl-attempts # Step 2: Fetch all the dependencies and calculate the SHA-256 sum while read line

1 0

[tor-browser-build/master] Bug 40101: Pick up 81.1.1 updates
by sysrqb＠torproject.org 23 Sep '20

23 Sep '20

1 0

[tor-browser-build/maint-10.0] Fixup changelog typos
by sysrqb＠torproject.org 22 Sep '20

22 Sep '20

commit 55a886cf6943bd7223834493020a82eeb499d6b5 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Sep 22 20:43:13 2020 +0000 Fixup changelog typos --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 0700ae9..ce725b3 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -68,8 +68,7 @@ Tor Browser 10.0 -- September 22 2020 * Bug 40102: Fix UI bugs in Tor Browser 10.0 alpha [tor-browser] * Bug 40106: Cannot install addons in full screen mode [tor-browser] * Bug 40109: Playing video breaks after reloading pages [tor-browser] - * Big 40119: Enable v3 extension blocklisting again [tor-browser] - * Translations update + * Bug 40119: Enable v3 extension blocklisting again [tor-browser] * Windows * Bug 33855: Don't use site's icon as window icon in Windows in private mode * Bug 40061: Omit the Windows default browser agent from the build [tor-browser]

1 0

[Git][tpo/applications/android-components] Deleted branch 40007
by Alex Catarineu 22 Sep '20

22 Sep '20

Alex Catarineu deleted branch 40007 at The Tor Project / Applications / android-components -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/android-components] Pushed new branch 40007
by Alex Catarineu 22 Sep '20

22 Sep '20

Alex Catarineu pushed new branch 40007 at The Tor Project / Applications / android-components -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/android-components/-/tree/40… You're receiving this email because of your account on gitlab.torproject.org.

1 0

Jump to page: