October 2019 - tbb-commits - lists.torproject.org

[tor-browser/tor-browser-68.2.0esr-9.5-1] fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit 9c6f36175099ac18740064b39aca1a3eb596741a Author: Rusty Bird <rustybird(a)net-c.com> Date: Mon Oct 21 02:22:34 2019 +0000 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 32169: Fix TB9 Wikipedia address bar search Bugfix on d093f0baea0b2b536b791d6613c384a7a4b1fe24, which accidentally renamed search_url_get_params to suggest_url_get_params. Apparently, until recently Firefox used to prefer search_form (which hardcodes the parameters for Wikipedia) to search_url (which does not), so this was hidden. --- browser/components/search/extensions/wikipedia/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/search/extensions/wikipedia/manifest.json b/browser/components/search/extensions/wikipedia/manifest.json index 25bfbcce3b58..1bdf45ee3acb 100644 --- a/browser/components/search/extensions/wikipedia/manifest.json +++ b/browser/components/search/extensions/wikipedia/manifest.json @@ -21,7 +21,7 @@ "search_url": "https://en.wikipedia.org/wiki/Special:Search", "search_form": "https://en.wikipedia.org/wiki/Special:Search?search={searchTerms}&sourceid=…", "suggest_url": "https://en.wikipedia.org/w/api.php?action=opensearch&search={searchTerms}", - "suggest_url_get_params": "search={searchTerms}&sourceid=Mozilla-search" + "search_url_get_params": "search={searchTerms}&sourceid=Mozilla-search" } } }

1 0

[tor-browser/tor-browser-68.2.0esr-9.0-1] Bug 31764: Fix for error when navigating via 'Paste and go'
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit 4c0b11d76d773c471f7d4884e7d0764f6ef00c7b Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Oct 21 17:02:31 2019 -0700 Bug 31764: Fix for error when navigating via 'Paste and go' The onURLBarUserStartNavigation callback expects an object from the UrlBarInput with information about how a URL was navigated to. This specifically helps to deal with the various buttons and links in the UrlBar dropdown (search engines, bookmarks, suggestions, etc). However, when using 'Paste and go' this data is not present nor relevant and an empty object {} is provided instead. This also happens if the user types the 'verbose url' (for example: https://www.example.com rather than www.example.com) navigates away from the urlbar thus dismissing the dropdown, then navigating back to the urlbar and hitting enter. Pasting the less 'verbose url' causes the code to go down another path which attempts to resolve the actual url before attempting to call _loadURL with a null result object, rather than an empty {} result object. In this scenario no exception is thrown. This patch explicitly passes null rather than implicitly passing {} to _loadURL when a resolved 'verbose' url is entered into the UrlBar via 'Paste and go' (as well as the previously described type -> dismiss popup -> enter flow). --- browser/components/urlbar/UrlbarInput.jsm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/urlbar/UrlbarInput.jsm b/browser/components/urlbar/UrlbarInput.jsm index f33b9b6a6d24..fe4a21832d54 100644 --- a/browser/components/urlbar/UrlbarInput.jsm +++ b/browser/components/urlbar/UrlbarInput.jsm @@ -443,7 +443,7 @@ class UrlbarInput { return; } - this._loadURL(url, where, openParams); + this._loadURL(url, where, openParams, null); } handleRevert() {

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Bug 31764: Fix for error when navigating via 'Paste and go'
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit 228fdd9e73df5a4286557134bebc2a189976fb99 Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Oct 21 17:02:31 2019 -0700 Bug 31764: Fix for error when navigating via 'Paste and go' The onURLBarUserStartNavigation callback expects an object from the UrlBarInput with information about how a URL was navigated to. This specifically helps to deal with the various buttons and links in the UrlBar dropdown (search engines, bookmarks, suggestions, etc). However, when using 'Paste and go' this data is not present nor relevant and an empty object {} is provided instead. This also happens if the user types the 'verbose url' (for example: https://www.example.com rather than www.example.com) navigates away from the urlbar thus dismissing the dropdown, then navigating back to the urlbar and hitting enter. Pasting the less 'verbose url' causes the code to go down another path which attempts to resolve the actual url before attempting to call _loadURL with a null result object, rather than an empty {} result object. In this scenario no exception is thrown. This patch explicitly passes null rather than implicitly passing {} to _loadURL when a resolved 'verbose' url is entered into the UrlBar via 'Paste and go' (as well as the previously described type -> dismiss popup -> enter flow). --- browser/components/urlbar/UrlbarInput.jsm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/urlbar/UrlbarInput.jsm b/browser/components/urlbar/UrlbarInput.jsm index f33b9b6a6d24..fe4a21832d54 100644 --- a/browser/components/urlbar/UrlbarInput.jsm +++ b/browser/components/urlbar/UrlbarInput.jsm @@ -443,7 +443,7 @@ class UrlbarInput { return; } - this._loadURL(url, where, openParams); + this._loadURL(url, where, openParams, null); } handleRevert() {

1 0

[tor-browser/tor-browser-68.2.0esr-9.0-1] Bug 31803: Replaced about:debugging logo with flat version
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit f049d363fcfc7ce38963308a99ede18879c963d5 Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Oct 21 14:23:59 2019 -0700 Bug 31803: Replaced about:debugging logo with flat version --- .../themes/images/aboutdebugging-firefox-logo.svg | 34 +++------------------- 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/devtools/client/themes/images/aboutdebugging-firefox-logo.svg b/devtools/client/themes/images/aboutdebugging-firefox-logo.svg index 9240dc6e84ca..d7895f1107c5 100644 --- a/devtools/client/themes/images/aboutdebugging-firefox-logo.svg +++ b/devtools/client/themes/images/aboutdebugging-firefox-logo.svg @@ -1,31 +1,5 @@ -<?xml version="1.0" encoding="UTF-8"?> -<svg width="512px" height="512px" viewBox="0 0 512 512" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> - <defs> - <linearGradient x1="50%" y1="100%" x2="50%" y2="0%" id="linearGradient-1"> - <stop stop-color="#420C5D" offset="0%"></stop> - <stop stop-color="#951AD1" offset="100%"></stop> - </linearGradient> - <path d="M25,29 C152.577777,29 256,131.974508 256,259 C256,386.025492 152.577777,489 25,489 L25,29 Z" id="path-2"></path> - <filter x="-18.2%" y="-7.4%" width="129.4%" height="114.8%" filterUnits="objectBoundingBox" id="filter-3"> - <feOffset dx="-8" dy="0" in="SourceAlpha" result="shadowOffsetOuter1"></feOffset> - <feGaussianBlur stdDeviation="10" in="shadowOffsetOuter1" result="shadowBlurOuter1"></feGaussianBlur> - <feColorMatrix values="0 0 0 0 0.250980392 0 0 0 0 0.250980392 0 0 0 0 0.250980392 0 0 0 0.2 0" type="matrix" in="shadowBlurOuter1"></feColorMatrix> - </filter> - </defs> - <g id="Assets" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> - <g id="icon_512x512"> - <g id="Group"> - <g id="tb_icon/Stable"> - <g id="Stable"> - <circle id="background" fill="#F2E4FF" fill-rule="nonzero" cx="256" cy="256" r="246"></circle> - <path d="M256.525143,465.439707 L256.525143,434.406609 C354.826191,434.122748 434.420802,354.364917 434.420802,255.992903 C434.420802,157.627987 354.826191,77.8701558 256.525143,77.5862948 L256.525143,46.5531962 C371.964296,46.8441537 465.446804,140.489882 465.446804,255.992903 C465.446804,371.503022 371.964296,465.155846 256.525143,465.439707 Z M256.525143,356.820314 C311.970283,356.529356 356.8487,311.516106 356.8487,255.992903 C356.8487,200.476798 311.970283,155.463547 256.525143,155.17259 L256.525143,124.146588 C329.115485,124.430449 387.881799,183.338693 387.881799,255.992903 C387.881799,328.654211 329.115485,387.562455 256.525143,387.846316 L256.525143,356.820314 Z M256.525143,201.718689 C286.266674,202.00255 310.3026,226.180407 310.3026,255.992903 C310.3026,285.812497 286.266674,309.990353 256.525143,310.274214 L256.525143,201.718689 Z M0,255.992903 C0,397.384044 114.60886,512 256,512 C397.384044,512 512,397.384044 512,255.992903 C512,114.60886 397.384 044,0 256,0 C114.60886,0 0,114.60886 0,255.992903 Z" id="center" fill="url(#linearGradient-1)"></path> - <g id="half" transform="translate(140.500000, 259.000000) scale(-1, 1) translate(-140.500000, -259.000000) "> - <use fill="black" fill-opacity="1" filter="url(#filter-3)" xlink:href="#path-2"></use> - <use fill="url(#linearGradient-1)" fill-rule="evenodd" xlink:href="#path-2"></use> - </g> - </g> - </g> - </g> - </g> - </g> +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> + <g fill="context-fill" fill-opacity="context-fill-opacity" fill-rule="nonzero"> + <path d="M12.0246161,21.8174863 L12.0246161,20.3628098 C16.6324777,20.3495038 20.3634751,16.6108555 20.3634751,11.9996673 C20.3634751,7.38881189 16.6324777,3.65016355 12.0246161,3.63685757 L12.0246161,2.18218107 C17.4358264,2.1958197 21.8178189,6.58546322 21.8178189,11.9996673 C21.8178189,17.4142042 17.4358264,21.8041803 12.0246161,21.8174863 L12.0246161,21.8174863 Z M12.0246161,16.7259522 C14.623607,16.7123136 16.7272828,14.6023175 16.7272828,11.9996673 C16.7272828,9.39734991 14.623607,7.28735377 12.0246161,7.27371516 L12.0246161,5.81937131 C15.4272884,5.8326773 18.1819593,8.59400123 18.1819593,11.9996673 C18.1819593,15.4056661 15.4272884,18.1669901 12.0246161,18.1802961 L12.0246161,16.7259522 Z M12.0246161,9.45556355 C13.4187503,9.46886953 14.5454344,10.6022066 14.5454344,11.9996673 C14.5454344,13.3974608 13.4187503,14.5307978 12.0246161,14.5441038 L12.0246161,9.45556355 Z M0,11.9996673 C0,18.6273771 5.37229031,24 12,24 C18.6273771,24 24,18.6273771 24,11.9996673 C24,5.37229031 18.6273771,0 12,0 C5.37229031,0 0,5.37229031 0,11.9996673 Z"/> + </g> </svg> \ No newline at end of file

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Bug 31803: Replaced about:debugging logo with flat version
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit 53298d61abe83f983730157c547b9993ebd6bdf3 Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Oct 21 14:23:59 2019 -0700 Bug 31803: Replaced about:debugging logo with flat version --- .../themes/images/aboutdebugging-firefox-logo.svg | 34 +++------------------- 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/devtools/client/themes/images/aboutdebugging-firefox-logo.svg b/devtools/client/themes/images/aboutdebugging-firefox-logo.svg index 9240dc6e84ca..d7895f1107c5 100644 --- a/devtools/client/themes/images/aboutdebugging-firefox-logo.svg +++ b/devtools/client/themes/images/aboutdebugging-firefox-logo.svg @@ -1,31 +1,5 @@ -<?xml version="1.0" encoding="UTF-8"?> -<svg width="512px" height="512px" viewBox="0 0 512 512" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> - <defs> - <linearGradient x1="50%" y1="100%" x2="50%" y2="0%" id="linearGradient-1"> - <stop stop-color="#420C5D" offset="0%"></stop> - <stop stop-color="#951AD1" offset="100%"></stop> - </linearGradient> - <path d="M25,29 C152.577777,29 256,131.974508 256,259 C256,386.025492 152.577777,489 25,489 L25,29 Z" id="path-2"></path> - <filter x="-18.2%" y="-7.4%" width="129.4%" height="114.8%" filterUnits="objectBoundingBox" id="filter-3"> - <feOffset dx="-8" dy="0" in="SourceAlpha" result="shadowOffsetOuter1"></feOffset> - <feGaussianBlur stdDeviation="10" in="shadowOffsetOuter1" result="shadowBlurOuter1"></feGaussianBlur> - <feColorMatrix values="0 0 0 0 0.250980392 0 0 0 0 0.250980392 0 0 0 0 0.250980392 0 0 0 0.2 0" type="matrix" in="shadowBlurOuter1"></feColorMatrix> - </filter> - </defs> - <g id="Assets" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> - <g id="icon_512x512"> - <g id="Group"> - <g id="tb_icon/Stable"> - <g id="Stable"> - <circle id="background" fill="#F2E4FF" fill-rule="nonzero" cx="256" cy="256" r="246"></circle> - <path d="M256.525143,465.439707 L256.525143,434.406609 C354.826191,434.122748 434.420802,354.364917 434.420802,255.992903 C434.420802,157.627987 354.826191,77.8701558 256.525143,77.5862948 L256.525143,46.5531962 C371.964296,46.8441537 465.446804,140.489882 465.446804,255.992903 C465.446804,371.503022 371.964296,465.155846 256.525143,465.439707 Z M256.525143,356.820314 C311.970283,356.529356 356.8487,311.516106 356.8487,255.992903 C356.8487,200.476798 311.970283,155.463547 256.525143,155.17259 L256.525143,124.146588 C329.115485,124.430449 387.881799,183.338693 387.881799,255.992903 C387.881799,328.654211 329.115485,387.562455 256.525143,387.846316 L256.525143,356.820314 Z M256.525143,201.718689 C286.266674,202.00255 310.3026,226.180407 310.3026,255.992903 C310.3026,285.812497 286.266674,309.990353 256.525143,310.274214 L256.525143,201.718689 Z M0,255.992903 C0,397.384044 114.60886,512 256,512 C397.384044,512 512,397.384044 512,255.992903 C512,114.60886 397.384 044,0 256,0 C114.60886,0 0,114.60886 0,255.992903 Z" id="center" fill="url(#linearGradient-1)"></path> - <g id="half" transform="translate(140.500000, 259.000000) scale(-1, 1) translate(-140.500000, -259.000000) "> - <use fill="black" fill-opacity="1" filter="url(#filter-3)" xlink:href="#path-2"></use> - <use fill="url(#linearGradient-1)" fill-rule="evenodd" xlink:href="#path-2"></use> - </g> - </g> - </g> - </g> - </g> - </g> +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> + <g fill="context-fill" fill-opacity="context-fill-opacity" fill-rule="nonzero"> + <path d="M12.0246161,21.8174863 L12.0246161,20.3628098 C16.6324777,20.3495038 20.3634751,16.6108555 20.3634751,11.9996673 C20.3634751,7.38881189 16.6324777,3.65016355 12.0246161,3.63685757 L12.0246161,2.18218107 C17.4358264,2.1958197 21.8178189,6.58546322 21.8178189,11.9996673 C21.8178189,17.4142042 17.4358264,21.8041803 12.0246161,21.8174863 L12.0246161,21.8174863 Z M12.0246161,16.7259522 C14.623607,16.7123136 16.7272828,14.6023175 16.7272828,11.9996673 C16.7272828,9.39734991 14.623607,7.28735377 12.0246161,7.27371516 L12.0246161,5.81937131 C15.4272884,5.8326773 18.1819593,8.59400123 18.1819593,11.9996673 C18.1819593,15.4056661 15.4272884,18.1669901 12.0246161,18.1802961 L12.0246161,16.7259522 Z M12.0246161,9.45556355 C13.4187503,9.46886953 14.5454344,10.6022066 14.5454344,11.9996673 C14.5454344,13.3974608 13.4187503,14.5307978 12.0246161,14.5441038 L12.0246161,9.45556355 Z M0,11.9996673 C0,18.6273771 5.37229031,24 12,24 C18.6273771,24 24,18.6273771 24,11.9996673 C24,5.37229031 18.6273771,0 12,0 C5.37229031,0 0,5.37229031 0,11.9996673 Z"/> + </g> </svg> \ No newline at end of file

1 0

[tor-launcher/master] Bug 32164: Now trimming each received log line from tor
by gk＠torproject.org 22 Oct '19

22 Oct '19

commit dd8147ceed102f93f246e67c91dcc36139451c8b Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Oct 21 14:47:40 2019 -0700 Bug 32164: Now trimming each received log line from tor --- src/components/tl-protocol.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/tl-protocol.js b/src/components/tl-protocol.js index a5fd1d9..d6df319 100644 --- a/src/components/tl-protocol.js +++ b/src/components/tl-protocol.js @@ -1487,7 +1487,7 @@ TorProtocolService.prototype = if ((idx > 0)) { let eventType = s.substring(0, idx); - let msg = s.substr(idx + 1); + let msg = s.substr(idx + 1).trim(); switch (eventType) { case "WARN":

1 0

[tor-browser-spec/master] Merge branch 'bug_32147'
by gk＠torproject.org 21 Oct '19

21 Oct '19

commit b11c935c4ef26a0a1317a2213b42e38186ba4970 Merge: d25eeb6 f8ce4db Author: Georg Koppen <gk(a)torproject.org> Date: Mon Oct 21 12:49:17 2019 +0000 Merge branch 'bug_32147' processes/ReleaseProcess | 6 ++++++ 1 file changed, 6 insertions(+)

1 0

[tor-browser-spec/master] Bug 32147: Update release instructions with Torbutton changes for 9.0
by gk＠torproject.org 21 Oct '19

21 Oct '19

commit f8ce4dbe63724b0af30ec2132174f19908d843f3 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Oct 21 12:47:15 2019 +0000 Bug 32147: Update release instructions with Torbutton changes for 9.0 --- processes/ReleaseProcess | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/processes/ReleaseProcess b/processes/ReleaseProcess index 2b772e5..f6256db 100644 --- a/processes/ReleaseProcess +++ b/processes/ReleaseProcess @@ -4,6 +4,10 @@ # #. Tag any relevant component versions. +# In particular: before tagging the tor-browser tag, the final code from +# Torbutton needs to get included and in order to avoid unnecessary commit +# inflation the commit for bumping the git submodule should be a fixup commit +# to the one with "Pick up latest Torbutton code" in its commit message. #. Update changelog and relevant config files in tor-browser-build. cd tor-browser-build @@ -45,6 +49,8 @@ # For stable releases put tails-dev(a)boum.org into Cc. #. Codesign the macOS dmg files. + # XXX: Update with Notarization bits once they are included in our signing + # setup torsocks ssh mac-signer "mkdir $TORBROWSER_VERSION" torsocks rsync -avP $TORBROWSER_BUILDDIR/*.dmg mac-signer:$TORBROWSER_VERSION/ torsocks ssh mac-signer

1 0

[tor-browser-build/master] Pick up tor-browser build2
by gk＠torproject.org 20 Oct '19

20 Oct '19

commit 599384e472b551f91bb38e3956dc8858fa2d43f4 Author: Georg Koppen <gk(a)torproject.org> Date: Sun Oct 20 08:23:37 2019 +0000 Pick up tor-browser build2 --- projects/firefox/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 1 - rbm.conf | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/projects/firefox/config b/projects/firefox/config index c30a71f..de83467 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'firefox-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build1' +git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build2' tag_gpg_id: 1 git_url: https://git.torproject.org/tor-browser.git git_submodule: 1 diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 4d52fd2..10f3682 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -5,7 +5,6 @@ Tor Browser 9.5a1 -- October 23 2019 * Bug 30681: Set security.enterprise_roots.enabled to false * Bug 31144: Review network code changes for Firefox 68 ESR * Bug 21549: Enable WASM on standard security level - * Bug 28709: Enable FuzzyFox * Windows + OS X + Linux * Update Tor Launcher to 0.2.20.1 * Bug 32154: Custom bridge field only allows one line of input diff --git a/rbm.conf b/rbm.conf index 45a5c64..6fe1010 100644 --- a/rbm.conf +++ b/rbm.conf @@ -25,7 +25,7 @@ buildconf: var: torbrowser_version: '9.5a1' - torbrowser_build: 'build1' + torbrowser_build: 'build2' torbrowser_incremental_from: - 9.0a8 project_name: tor-browser

1 0

[tor-browser/tor-browser-68.2.0esr-9.5-1] Revert "squash! TB4: Tor Browser's Firefox preference overrides."
by gk＠torproject.org 20 Oct '19

20 Oct '19

commit e14b7b74e92cba5cff63b6cd73bac67841907f0d Author: Georg Koppen <gk(a)torproject.org> Date: Sun Oct 20 08:13:10 2019 +0000 Revert "squash! TB4: Tor Browser's Firefox preference overrides." This reverts commit 81d2d351b4c93e139f13a6f21a9abadedc86ee6c. --- browser/app/profile/000-tor-browser.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 96d14314eb24..3d0de789205b 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -169,8 +169,6 @@ pref("browser.cache.frecency_experiment", -1); pref("dom.use_components_shim", false); // Enable letterboxing pref("privacy.resistFingerprinting.letterboxing", true); -// Enable FuzzyFox -pref("privacy.fuzzyfox.enabled", true); // Third party stuff pref("privacy.firstparty.isolate", true); // Always enforce first party isolation

1 0