lists.torproject.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

tbb-commits

Thread Start a new thread
Threads by month
  • ----- 2025 -----
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2019 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2018 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2017 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2016 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2015 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2014 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
tbb-commits@lists.torproject.org

  • 1 participants
  • 19030 discussions
[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (@morgan) 19 Aug '25

19 Aug '25
morgan pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 4f240699 by Henry Wilkes at 2025-08-19T12:09:22+00:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4f2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4f2… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (@morgan) 19 Aug '25

19 Aug '25
morgan pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 76412dec by Henry Wilkes at 2025-08-19T12:08:17+00:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76412de… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76412de… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (@morgan) 19 Aug '25

19 Aug '25
morgan pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 2c5430c0 by Henry Wilkes at 2025-08-18T14:04:47+01:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c5430c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c5430c… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-14.5.6-build1
by ma1 (@ma1) 19 Aug '25

19 Aug '25
ma1 pushed new tag tbb-14.5.6-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5.21-build1
by ma1 (@ma1) 18 Aug '25

18 Aug '25
ma1 pushed new tag tbb-13.5.21-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.27.0esr-13.5-1-build3
by ma1 (@ma1) 18 Aug '25

18 Aug '25
ma1 pushed new tag tor-browser-115.27.0esr-13.5-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41521: Prepare Tor Browser 13.5.21
by ma1 (@ma1) 18 Aug '25

18 Aug '25
ma1 pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 5f977a1f by hackademix at 2025-08-18T21:48:21+02:00 Bug 41521: Prepare Tor Browser 13.5.21 - - - - - 5 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/config - projects/firefox/config - projects/translation/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,12 @@ +Tor Browser 13.5.21 - August 19 2025 + * All Platforms + * Updated Firefox to 115.27.0esr + * Updated NoScript to 13.0.9 + * Bug 43168: Review ESR 115 expiry date for legacy OS message [tor-browser] + * Bug 44041: Letterboxing causes greyed out alert background to be mis-aligned [tor-browser] + * Bug 44048: Backport Bug 1979608 [tor-browser] + * Bug 44100: Backport Security Fixes from Firefox 142 [tor-browser] + Tor Browser 13.5.20 - July 22 2025 * All Platforms * Updated Firefox to 115.26.0esr ===================================== projects/browser/config ===================================== @@ -103,9 +103,9 @@ input_files: enable: '[% ! c("var/android") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.mozilla.org/firefox/downloads/file/4497468/noscript-13.0.8.x… + - URL: https://addons.mozilla.org/firefox/downloads/file/4551629/noscript-13.0.9.x… name: noscript - sha256sum: 9d978cfe083cb9cce120b5ee41e8933d752d7ab4680bf517c5ec4b29c4cfd2dc + sha256sum: 525ab61aff21f67d10c3e20965a86ed479631549908a658f54692adc47d771f5 - URL: https://addons.mozilla.org/firefox/downloads/file/4359936/ublock_origin-1.6… name: ublock-origin sha256sum: e2cda9b2a1b0a7f6e5ef0da9f87f28df52f8560587ba2e51a3003121cfb81600 ===================================== projects/firefox/config ===================================== @@ -16,7 +16,7 @@ container: use_container: 1 var: - firefox_platform_version: 115.26.0 + firefox_platform_version: 115.27.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '13.5' browser_rebase: 1 ===================================== projects/translation/config ===================================== @@ -12,13 +12,13 @@ compress_tar: 'gz' steps: base-browser: base-browser: '[% INCLUDE build %]' - git_hash: 8600afeb12fdae895c37618e1386c1a1ac2f5308 + git_hash: e3eb649b9b964e3e874969aae0bf51cfa35488f9 targets: nightly: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 9fe8a13ee4c69f91cd545dc3c575ca8f4851d58e + git_hash: e8471a5feca51868b261ecf3238f387269177427 targets: nightly: git_hash: 'tor-browser' ===================================== rbm.conf ===================================== @@ -73,18 +73,18 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '13.5.20' + torbrowser_version: '13.5.21' torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2025/07/22 13:07:32' + browser_release_date: '2025/08/18 19:35:49' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + - 13.5.20 - 13.5.19 - 13.5.18 - - 13.5.17 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-115.27.0esr-13.5-1] fixup! Bug 43125: Extend the 13.5 EOL expiry date for tor-browser.
by morgan (@morgan) 18 Aug '25

18 Aug '25
morgan pushed to branch tor-browser-115.27.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 6d7f63e9 by Henry Wilkes at 2025-08-18T18:16:27+01:00 fixup! Bug 43125: Extend the 13.5 EOL expiry date for tor-browser. TB 43168: Extend the 13.5 EOL to 14th October 2025. - - - - - 1 changed file: - browser/base/content/droppedSupportNotification.js Changes: ===================================== browser/base/content/droppedSupportNotification.js ===================================== @@ -3,8 +3,8 @@ // Show a prompt that a user's system will no longer be supported. window.addEventListener("load", () => { let labelId; - // Firefox moved ESR 115 EOL to 16th September 2025. - const isExpired = Date.now() > Date.UTC(2025, 8, 16); + // ESR 115 EOL pushed to 14th October 2025. + const isExpired = Date.now() > Date.UTC(2025, 9, 14); if ( AppConstants.platform === "macosx" && View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6d7f63e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6d7f63e… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser-update-responses][main] 4 commits: release: new version, 14.5.6 (linux-x86_64)
by ma1 (@ma1) 18 Aug '25

18 Aug '25
ma1 pushed to branch main at The Tor Project / Applications / mullvad-browser-update-responses Commits: a18955e5 by hackademix at 2025-08-18T18:30:44+02:00 release: new version, 14.5.6 (linux-x86_64) - - - - - 710c12ea by hackademix at 2025-08-18T18:30:45+02:00 release: new version, 14.5.6 (macos) - - - - - 269a05c4 by hackademix at 2025-08-18T18:30:45+02:00 release: new version, 14.5.6 (windows-x86_64) - - - - - 670215e8 by hackademix at 2025-08-18T18:30:46+02:00 release: new version, 14.5.6 - - - - - 31 changed files: - update_1/release/download-linux-x86_64.json - update_1/release/download-macos.json - update_1/release/download-windows-x86_64.json - update_1/release/downloads.json - update_1/release/linux-x86_64/.htaccess - − update_1/release/linux-x86_64/update-14.5.2-14.5.5-linux-x86_64.xml - − update_1/release/linux-x86_64/update-14.5.3-14.5.5-linux-x86_64.xml - + update_1/release/linux-x86_64/update-14.5.3-14.5.6-linux-x86_64.xml - − update_1/release/linux-x86_64/update-14.5.4-14.5.5-linux-x86_64.xml - + update_1/release/linux-x86_64/update-14.5.4-14.5.6-linux-x86_64.xml - + update_1/release/linux-x86_64/update-14.5.5-14.5.6-linux-x86_64.xml - − update_1/release/linux-x86_64/update-14.5.5-linux-x86_64.xml - + update_1/release/linux-x86_64/update-14.5.6-linux-x86_64.xml - update_1/release/macos/.htaccess - − update_1/release/macos/update-14.5.2-14.5.5-macos.xml - − update_1/release/macos/update-14.5.3-14.5.5-macos.xml - + update_1/release/macos/update-14.5.3-14.5.6-macos.xml - − update_1/release/macos/update-14.5.4-14.5.5-macos.xml - + update_1/release/macos/update-14.5.4-14.5.6-macos.xml - + update_1/release/macos/update-14.5.5-14.5.6-macos.xml - − update_1/release/macos/update-14.5.5-macos.xml - + update_1/release/macos/update-14.5.6-macos.xml - update_1/release/windows-x86_64/.htaccess - − update_1/release/windows-x86_64/update-14.5.2-14.5.5-windows-x86_64.xml - − update_1/release/windows-x86_64/update-14.5.3-14.5.5-windows-x86_64.xml - + update_1/release/windows-x86_64/update-14.5.3-14.5.6-windows-x86_64.xml - − update_1/release/windows-x86_64/update-14.5.4-14.5.5-windows-x86_64.xml - + update_1/release/windows-x86_64/update-14.5.4-14.5.6-windows-x86_64.xml - + update_1/release/windows-x86_64/update-14.5.5-14.5.6-windows-x86_64.xml - − update_1/release/windows-x86_64/update-14.5.5-windows-x86_64.xml - + update_1/release/windows-x86_64/update-14.5.6-windows-x86_64.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-115.27.0esr-13.5-1] 3 commits: Bug 672618 - Don't execute javascript: URLs on CTRL+click, middle-click etc. r=dao
by ma1 (@ma1) 18 Aug '25

18 Aug '25
ma1 pushed to branch tor-browser-115.27.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: f89188bd by Tom Schuster at 2025-08-18T17:22:37+02:00 Bug 672618 - Don't execute javascript: URLs on CTRL+click, middle-click etc. r=dao Differential Revision: https://phabricator.services.mozilla.com/D256648 BB 44100: cherry-picked except tests - - - - - 85feb19a by Steve Fink at 2025-08-18T17:22:42+02:00 Bug 1977130 - Error-check pthread_getattr_np. r=glandium,spidermonkey-reviewers,jandem, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D258648 - - - - - 3239846a by Kershaw Chang at 2025-08-18T17:22:43+02:00 Bug 1979955 - ensure transaction is alive (for ESR140), a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D260484 - - - - - 5 changed files: - browser/actors/ClickHandlerChild.sys.mjs - browser/app/profile/firefox.js - js/src/util/NativeStack.cpp - mozglue/misc/StackWalk.cpp - netwerk/protocol/http/nsHttpConnection.cpp Changes: ===================================== browser/actors/ClickHandlerChild.sys.mjs ===================================== @@ -12,12 +12,26 @@ ChromeUtils.defineESModuleGetters(lazy, { E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", }); +XPCOMUtils.defineLazyPreferenceGetter( + lazy, + "autoscrollEnabled", + "general.autoScroll", + true +); + +XPCOMUtils.defineLazyPreferenceGetter( + lazy, + "blockJavascript", + "browser.link.alternative_click.block_javascript", + true +); + export class MiddleMousePasteHandlerChild extends JSWindowActorChild { handleEvent(clickEvent) { if ( clickEvent.defaultPrevented || clickEvent.button != 1 || - MiddleMousePasteHandlerChild.autoscrollEnabled + lazy.autoscrollEnabled ) { return; } @@ -34,13 +48,6 @@ export class MiddleMousePasteHandlerChild extends JSWindowActorChild { } } -XPCOMUtils.defineLazyPreferenceGetter( - MiddleMousePasteHandlerChild, - "autoscrollEnabled", - "general.autoScroll", - true -); - export class ClickHandlerChild extends JSWindowActorChild { handleEvent(wrapperEvent) { this.handleClickEvent(wrapperEvent.sourceEvent); @@ -112,6 +119,14 @@ export class ClickHandlerChild extends JSWindowActorChild { }; if (href && !isFromMiddleMousePasteHandler) { + if ( + lazy.blockJavascript && + Services.io.extractScheme(href) == "javascript" + ) { + // We don't want to open new tabs or windows for javascript: links. + return; + } + try { Services.scriptSecurityManager.checkLoadURIStrWithPrincipal( principal, ===================================== browser/app/profile/firefox.js ===================================== @@ -759,6 +759,9 @@ pref("browser.link.open_newwindow.restriction", 2); pref("browser.link.open_newwindow.disabled_in_fullscreen", false); #endif +// If true, opening javscript: URLs using middle-click, CTRL+click etc. are blocked. +pref("browser.link.alternative_click.block_javascript", true); + // Tabbed browser pref("browser.tabs.closeTabByDblclick", false); pref("browser.tabs.closeWindowWithLastTab", true); ===================================== js/src/util/NativeStack.cpp ===================================== @@ -95,17 +95,16 @@ void* js::GetNativeStackBaseImpl() { pthread_t thread = pthread_self(); pthread_attr_t sattr; pthread_attr_init(&sattr); - pthread_getattr_np(thread, &sattr); + int rc = pthread_getattr_np(thread, &sattr); + MOZ_RELEASE_ASSERT(rc == 0, "pthread_getattr_np failed"); // stackBase will be the *lowest* address on all architectures. void* stackBase = nullptr; size_t stackSize = 0; - int rc = pthread_attr_getstack(&sattr, &stackBase, &stackSize); - if (rc) { - MOZ_CRASH( - "call to pthread_attr_getstack failed, unable to setup stack range for " - "JS"); - } + rc = pthread_attr_getstack(&sattr, &stackBase, &stackSize); + MOZ_RELEASE_ASSERT(rc == 0, + "call to pthread_attr_getstack failed, unable to setup " + "stack range for JS"); MOZ_RELEASE_ASSERT(stackBase, "invalid stack base, unable to setup stack range for JS"); pthread_attr_destroy(&sattr); @@ -148,7 +147,8 @@ void* js::GetNativeStackBaseImpl() { * FIXME: this function is non-portable; * other POSIX systems may have different np alternatives */ - pthread_getattr_np(thread, &sattr); + MOZ_RELEASE_ASSERT(pthread_getattr_np(thread, &sattr) == 0, + "pthread_getattr_np failed"); # endif void* stackBase = 0; ===================================== mozglue/misc/StackWalk.cpp ===================================== @@ -695,7 +695,8 @@ MFBT_API void MozStackWalk(MozWalkStackCallback aCallback, # elif defined(ANDROID) pthread_attr_t sattr; pthread_attr_init(&sattr); - pthread_getattr_np(pthread_self(), &sattr); + int rc = pthread_getattr_np(pthread_self(), &sattr); + MOZ_RELEASE_ASSERT(rc == 0, "pthread_getattr_np failed"); void* stackBase = stackEnd = nullptr; size_t stackSize = 0; if (gettid() != getpid()) { ===================================== netwerk/protocol/http/nsHttpConnection.cpp ===================================== @@ -1635,9 +1635,10 @@ nsresult nsHttpConnection::OnSocketWritable() { } LOG((" writing transaction request stream\n")); - rv = mTransaction->ReadSegmentsAgain(this, - nsIOService::gDefaultSegmentSize, - &transactionBytes, &again); + RefPtr<nsAHttpTransaction> transaction = mTransaction; + rv = transaction->ReadSegmentsAgain(this, + nsIOService::gDefaultSegmentSize, + &transactionBytes, &again); if (mTlsHandshaker->EarlyDataUsed()) { mContentBytesWritten0RTT += transactionBytes; if (NS_FAILED(rv) && rv != NS_BASE_STREAM_WOULD_BLOCK) { @@ -1660,7 +1661,8 @@ nsresult nsHttpConnection::OnSocketWritable() { static_cast<uint32_t>(mSocketOutCondition), again)); // XXX some streams return NS_BASE_STREAM_CLOSED to indicate EOF. - if (rv == NS_BASE_STREAM_CLOSED && !mTransaction->IsDone()) { + if (rv == NS_BASE_STREAM_CLOSED && + (mTransaction && !mTransaction->IsDone())) { rv = NS_OK; transactionBytes = 0; } @@ -1703,7 +1705,8 @@ nsresult nsHttpConnection::OnSocketWritable() { // When Spdy tunnel is used we need to explicitly set when a request is // done. if ((mState != HttpConnectionState::SETTING_UP_TUNNEL) && !mSpdySession) { - nsHttpTransaction* trans = mTransaction->QueryHttpTransaction(); + nsHttpTransaction* trans = + mTransaction ? mTransaction->QueryHttpTransaction() : nullptr; // needed for websocket over h2 (direct) if (!trans || !trans->IsWebsocketUpgrade()) { mRequestDone = true; @@ -1806,7 +1809,8 @@ nsresult nsHttpConnection::OnSocketReadable() { rv = NS_ERROR_FAILURE; LOG((" No Transaction In OnSocketWritable\n")); } else { - rv = mTransaction->WriteSegmentsAgain( + RefPtr<nsAHttpTransaction> transaction = mTransaction; + rv = transaction->WriteSegmentsAgain( this, nsIOService::gDefaultSegmentSize, &n, &again); } LOG(("nsHttpConnection::OnSocketReadable %p trans->ws rv=%" PRIx32 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/667d6d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/667d6d… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 8
  • 9
  • 10
  • 11
  • 12
  • 13
  • 14
  • ...
  • 1903
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.