lists.torproject.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

tbb-commits

Thread Start a new thread
Download
Threads by month
  • ----- 2025 -----
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2019 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2018 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2017 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2016 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2015 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2014 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
tbb-commits@lists.torproject.org

  • 18606 discussions
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f4d44bf6 by Beatriz Rizental at 2024-08-12T14:25:08+00:00 fixup! Add CI for Base Browser Bug 42997: Reduce the number of git fetches by fetching during a setup job and passing that initial fetch around as a git bundle to other jobs through the Gitlab artifacts. Further reduce the number of fetches by creating a list of changed files in the setup job and passing that around as well as an artifact. - - - - - 4 changed files: - .gitlab-ci.yml - .gitlab/ci/lint.yml - .gitlab/ci/scripts/run_linters.py → .gitlab/ci/scripts/helpers.py - + .gitlab/ci/setup.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,4 +1,5 @@ stages: + - setup - lint - update-translations @@ -6,5 +7,6 @@ variables: IMAGE_PATH: containers.torproject.org/tpo/applications/tor-browser/base:latest include: + - local: '.gitlab/ci/setup.yml' - local: '.gitlab/ci/lint.yml' - local: '.gitlab/ci/update-translations.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,8 +1,15 @@ .base: stage: lint + image: $IMAGE_PATH interruptible: true + needs: + - job: setup-env + artifacts: true + - job: create-bundle + artifacts: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" + GIT_STRATEGY: "none" cache: paths: - node_modules @@ -11,12 +18,26 @@ when: 'always' # Share the cache throughout all pipelines running for a given branch key: $CI_COMMIT_REF_SLUG + before_script: + # DEBUG: Are all artifacts here? + - ls -a + - mkdir app && cd app + # Initialize a fresh git repo + - git init + # Add app.bundle as the remote. All operations that communicate with the remote will be local. + - git remote add origin ../app.bundle + # shallow.txt contains the SHA of the base commit of the bundle. + # The bundle is shallow, therefore it's base commit will not have a parent. + # Adding the SHA of the base commit to .git/shallow tells git that it doesn't need + # to crash when it realizes said base commit doesn't have a parent. + - cp ../shallow.txt .git/shallow + # Finally, unpack the bundle. Time it for debugging purposes. + - time git pull origin $BRANCH_NAME eslint: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py eslint + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l eslint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -44,9 +65,8 @@ eslint: stylelint: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py stylelint + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l stylelint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -63,9 +83,8 @@ stylelint: py-black: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py black + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l black rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -83,9 +102,8 @@ py-black: py-ruff: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py ruff + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l ruff rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -103,9 +121,8 @@ py-ruff: yaml: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py yaml + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l yaml rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -119,9 +136,8 @@ yaml: shellcheck: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py shellcheck + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l shellcheck rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -134,10 +150,9 @@ shellcheck: clang-format: extends: .base - image: $IMAGE_PATH script: - ./mach configure --without-wasm-sandboxed-libraries --with-base-browser-version=0.0.0 - - .gitlab/ci/scripts/run_linters.py clang-format + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l clang-format rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -155,9 +170,8 @@ clang-format: rustfmt: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py rustfmt + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l rustfmt rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -170,9 +184,8 @@ rustfmt: fluent-lint: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py fluent-lint + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l fluent-lint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -186,9 +199,8 @@ fluent-lint: localization: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py l10n + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l l10n rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -204,9 +216,8 @@ localization: mingw-capitalization: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py mingw-capitalization + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l mingw-capitalization rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -222,9 +233,8 @@ mingw-capitalization: mscom-init: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py mscom-init + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l mscom-init rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -240,9 +250,8 @@ mscom-init: file-whitespace: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py file-whitespace + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l file-whitespace rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -270,9 +279,8 @@ file-whitespace: test-manifest: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py test-manifest-alpha test-manifest-disable test-manifest-skip-if + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l test-manifest-alpha -l test-manifest-disable -l test-manifest-skip-if rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -286,9 +294,8 @@ test-manifest: trojan-source: extends: .base - image: $IMAGE_PATH script: - - .gitlab/ci/scripts/run_linters.py trojan-source + - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l trojan-source rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: ===================================== .gitlab/ci/scripts/run_linters.py → .gitlab/ci/scripts/helpers.py ===================================== @@ -5,7 +5,6 @@ import os import re import shlex import subprocess -import sys def git(command): @@ -15,8 +14,8 @@ def git(command): return result.stdout.strip() -def get_firefox_tag_from_branch_name(branch_name): - """Extracts the Firefox tag associated with a branch name. +def get_firefox_tag(reference): + """Extracts the Firefox tag associated with a branch or tag name. The "firefox tag" is the tag that marks the end of the Mozilla commits and the start of the Tor Project commits. @@ -25,26 +24,26 @@ def get_firefox_tag_from_branch_name(branch_name): this function may return the incorrect reference number. Args: - branch_name: The branch name to extract the tag from. + reference: The branch or tag name to extract the Firefox tag from. Expected format is tor-browser-91.2.0esr-11.0-1, where 91.2.0esr is the Firefox version. Returns: The reference specifier of the matching Firefox tag. - An exception wil be raised if anything goes wrong. + An exception will be raised if anything goes wrong. """ - # Extracts the version number from a branch name. + # Extracts the version number from a branch or tag name. firefox_version = "" - match = re.search(r"(?<=browser-)([^-]+)", branch_name) + match = re.search(r"(?<=browser-)([^-]+)", reference) if match: # TODO: Validate that what we got is actually a valid semver string? firefox_version = match.group(1) else: - raise ValueError(f"Failed to extract version from branch name '{branch_name}'.") + raise ValueError(f"Failed to extract version from reference '{reference}'.") tag = f"FIREFOX_{firefox_version.replace('.', '_')}_" - remote_tags = git("ls-remote --tags") + remote_tags = git("ls-remote --tags origin") # Each line looks like: # 9edd658bfd03a6b4743ecb75fd4a9ad968603715 refs/tags/FIREFOX_91_9_0esr_BUILD1 @@ -54,7 +53,7 @@ def get_firefox_tag_from_branch_name(branch_name): return match.group(0).split()[0] else: raise ValueError( - f"Failed to find reference specifier for Firefox tag '{tag}' in branch '{branch_name}'." + f"Failed to find reference specifier for Firefox tag '{tag}' from '{reference}'." ) @@ -74,37 +73,42 @@ def get_list_of_changed_files(): base_reference = "" if os.getenv("CI_PIPELINE_SOURCE") == "merge_request_event": - # For merge requests, the base_reference is the common ancestor between the MR and the target branch. + # For merge requests, the base_reference is the common ancestor between the MR and the target branch base_reference = os.getenv("CI_MERGE_REQUEST_DIFF_BASE_SHA") else: # When not in merge requests, the base reference is the Firefox tag - base_reference = get_firefox_tag_from_branch_name(os.getenv("CI_COMMIT_BRANCH")) + base_reference = get_firefox_tag(os.getenv("CI_COMMIT_BRANCH")) if not base_reference: raise RuntimeError("No base reference found. There might be more errors above.") # Fetch the tag reference git(f"fetch origin {base_reference} --depth=1 --filter=blob:none") - # Return the list of changed files - return git(f"diff --diff-filter=d --name-only {base_reference} HEAD").split("\n") + # Return but filter the issue_templates files because those file names have spaces which can cause issues + return git("diff --diff-filter=d --name-only FETCH_HEAD HEAD").split("\n") if __name__ == "__main__": - parser = argparse.ArgumentParser( - description="Run ./mach linters in CI. Warning: if you run this in your local environment it might mess up your git history." + parser = argparse.ArgumentParser(description="") + + parser.add_argument( + "--get-firefox-tag", + help="Get the Firefox tag related to a given (tor-mullvad-base)-browser tag or branch name.", + type=str, ) parser.add_argument( - "linters", metavar="L", type=str, nargs="+", help="A list of linters to run." + "--get-changed-files", + help="Get list of changed files." + "When running from a merge request get sthe list of changed files since the merge-base of the current branch." + "When running from a protected branch i.e. any branch that starts with <something>-browser-, gets the list of files changed since the FIREFOX_ tag.", + action="store_true", ) + args = parser.parse_args() - changed_files = get_list_of_changed_files() - if changed_files: - command = ["./mach", "lint", "-v"] - for linter in args.linters: - command.extend(["-l", linter]) - command.extend(changed_files) - result = subprocess.run(command, text=True) - sys.exit(result.returncode) + if args.get_firefox_tag: + print(get_firefox_tag(args.get_firefox_tag)) + elif args.get_changed_files: + print("\n".join(get_list_of_changed_files())) else: - print("No files changed, skipping linting.") + print("No valid option provided.") ===================================== .gitlab/ci/setup.yml ===================================== @@ -0,0 +1,53 @@ +setup-env: + stage: setup + interruptible: true + variables: + GIT_STRATEGY: "none" + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' || $CI_COMMIT_REF_PROTECTED == 'true' + script: + - | + if [ -n "$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME" ]; then + echo "BRANCH_NAME=$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME" > build.env + else + echo "BRANCH_NAME=$CI_COMMIT_REF_NAME" > build.env + fi + artifacts: + reports: + dotenv: + - build.env + +create-bundle: + stage: setup + # TODO: Find a better suited image, this one just has git. + image: python + needs: + - job: setup-env + artifacts: true + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' || $CI_COMMIT_REF_PROTECTED == 'true' + variables: + GIT_DEPTH: "1" + interruptible: true + script: + # DEBUG: Check repository status. + - git status + # Switch to a named branch. + - git switch -c $BRANCH_NAME + # Create a git bundle -- this will generate the app.bundle file, + # which can be used as a git remote for offline fetching. + - git bundle create app.bundle --all + # Retain the SHA of the base of this shallow repository. + - cat .git/shallow > shallow.txt + # DEBUG: Check sizes. + - du -sh .git + - du -sh app.bundle + # Since this is the only job we have access to the Gitlab remote, + # let's get a list of changed files to use in the next jobs. + - .gitlab/ci/scripts/helpers.py --get-changed-files > changedfiles.txt + artifacts: + paths: + - app.bundle + - shallow.txt + - changedfiles.txt + expire_in: 1 hour View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f4d44bf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f4d44bf… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 94c62b42 by Henry Wilkes at 2024-08-12T14:35:51+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level=&quot;top&quot; attribute. - - - - - 1 changed file: - browser/components/securitylevel/content/securityLevelPanel.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevelPanel.inc.xhtml ===================================== @@ -4,7 +4,6 @@ aria-describedby="securityLevel-subheading securityLevel-summary" type="arrow" orient="vertical" - level="top" class="cui-widget-panel panel-no-padding"> <box class="panel-header"> <html:h1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/94c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/94c… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 234d4656 by Henry Wilkes at 2024-08-12T14:35:18+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level=&quot;top&quot; attribute. - - - - - 1 changed file: - browser/components/securitylevel/content/securityLevelPanel.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevelPanel.inc.xhtml ===================================== @@ -4,7 +4,6 @@ aria-describedby="securityLevel-subheading securityLevel-summary" type="arrow" orient="vertical" - level="top" class="cui-widget-panel panel-no-padding"> <box class="panel-header"> <html:h1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/234d465… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/234d465… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40925: Implemented the Security Level component
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: b44ee121 by Henry Wilkes at 2024-08-12T12:30:56+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level=&quot;top&quot; attribute. - - - - - 29560ecc by Henry Wilkes at 2024-08-12T12:30:56+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42699: Drop level=&quot;top&quot; attribute. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevelPanel.inc.xhtml - browser/components/torcircuit/content/torCircuitPanel.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevelPanel.inc.xhtml ===================================== @@ -4,7 +4,6 @@ aria-describedby="securityLevel-subheading securityLevel-summary" type="arrow" orient="vertical" - level="top" class="cui-widget-panel panel-no-padding"> <box class="panel-header"> <html:h1 ===================================== browser/components/torcircuit/content/torCircuitPanel.inc.xhtml ===================================== @@ -3,7 +3,6 @@ aria-labelledby="tor-circuit-heading" type="arrow" orient="vertical" - level="top" class="cui-widget-panel panel-no-padding" tabindex="0"> <!-- Use same semantic structure as #identity-popup and #protections-popup View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/402c32… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/402c32… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40309: Avoid using regional OS locales
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 94b53ebc by Pier Angelo Vendrame at 2024-08-12T11:51:21+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox&#39;s default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - 8904c0be by Pier Angelo Vendrame at 2024-08-12T11:51:22+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - intl/locale/LocaleService.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -622,6 +622,9 @@ pref("corroborator.enabled", false); // tor-browser#41417: do not allow live reload until we switch to Fluent and // stop using .textContent. +// Even after that, it might be a good idea to keep it off, as it is not handled +// very well, and it might give a window during which websites could fingerprint +// the change (see tor-browser#42349 and tor-browser#42771). pref("intl.multilingual.liveReload", false); // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092) ===================================== intl/locale/LocaleService.cpp ===================================== @@ -485,10 +485,12 @@ LocaleService::GetAppLocaleAsBCP47(nsACString& aRetVal) { NS_IMETHODIMP LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) { + // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof + // English. So, we use another target for now. if (nsContentUtils::ShouldResistFingerprinting( "This is probably a patch that should be refined. But to get the " "build going, we just keep applying this generic check.", - RFPTarget::JSLocale)) { + RFPTarget::JSDateTimeUTC)) { GetAppLocalesAsBCP47(aRetVal); return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cf… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40309: Avoid using regional OS locales
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 94b53ebc by Pier Angelo Vendrame at 2024-08-12T11:51:21+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox&#39;s default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - 8904c0be by Pier Angelo Vendrame at 2024-08-12T11:51:22+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - intl/locale/LocaleService.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -622,6 +622,9 @@ pref("corroborator.enabled", false); // tor-browser#41417: do not allow live reload until we switch to Fluent and // stop using .textContent. +// Even after that, it might be a good idea to keep it off, as it is not handled +// very well, and it might give a window during which websites could fingerprint +// the change (see tor-browser#42349 and tor-browser#42771). pref("intl.multilingual.liveReload", false); // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092) ===================================== intl/locale/LocaleService.cpp ===================================== @@ -485,10 +485,12 @@ LocaleService::GetAppLocaleAsBCP47(nsACString& aRetVal) { NS_IMETHODIMP LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) { + // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof + // English. So, we use another target for now. if (nsContentUtils::ShouldResistFingerprinting( "This is probably a patch that should be refined. But to get the " "build going, we just keep applying this generic check.", - RFPTarget::JSLocale)) { + RFPTarget::JSDateTimeUTC)) { GetAppLocalesAsBCP47(aRetVal); return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/cf… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40309: Avoid using regional OS locales
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: b841c294 by Pier Angelo Vendrame at 2024-08-12T11:48:58+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox&#39;s default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - 7d1059f5 by Pier Angelo Vendrame at 2024-08-12T11:48:59+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - intl/locale/LocaleService.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -624,6 +624,9 @@ pref("corroborator.enabled", false); // tor-browser#41417: do not allow live reload until we switch to Fluent and // stop using .textContent. +// Even after that, it might be a good idea to keep it off, as it is not handled +// very well, and it might give a window during which websites could fingerprint +// the change (see tor-browser#42349 and tor-browser#42771). pref("intl.multilingual.liveReload", false); // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092) ===================================== intl/locale/LocaleService.cpp ===================================== @@ -485,10 +485,12 @@ LocaleService::GetAppLocaleAsBCP47(nsACString& aRetVal) { NS_IMETHODIMP LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) { + // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof + // English. So, we use another target for now. if (nsContentUtils::ShouldResistFingerprinting( "This is probably a patch that should be refined. But to get the " "build going, we just keep applying this generic check.", - RFPTarget::JSLocale)) { + RFPTarget::JSDateTimeUTC)) { GetAppLocalesAsBCP47(aRetVal); return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/562aec… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/562aec… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40309: Avoid using regional OS locales
by Pier Angelo Vendrame (@pierov) 12 Aug '24

12 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 98b8bdd4 by Pier Angelo Vendrame at 2024-08-08T19:12:40+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox&#39;s default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - 402c32c1 by Pier Angelo Vendrame at 2024-08-08T19:12:56+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - intl/locale/LocaleService.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -624,6 +624,9 @@ pref("corroborator.enabled", false); // tor-browser#41417: do not allow live reload until we switch to Fluent and // stop using .textContent. +// Even after that, it might be a good idea to keep it off, as it is not handled +// very well, and it might give a window during which websites could fingerprint +// the change (see tor-browser#42349 and tor-browser#42771). pref("intl.multilingual.liveReload", false); // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092) ===================================== intl/locale/LocaleService.cpp ===================================== @@ -485,10 +485,12 @@ LocaleService::GetAppLocaleAsBCP47(nsACString& aRetVal) { NS_IMETHODIMP LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) { + // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof + // English. So, we use another target for now. if (nsContentUtils::ShouldResistFingerprinting( "This is probably a patch that should be refined. But to get the " "build going, we just keep applying this generic check.", - RFPTarget::JSLocale)) { + RFPTarget::JSDateTimeUTC)) { GetAppLocalesAsBCP47(aRetVal); return NS_OK; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/292271… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/292271… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by morgan (@morgan) 08 Aug '24

08 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 292271b7 by Henry Wilkes at 2024-08-08T17:52:46+01:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42695: Use --arrowpanel variables instead of em units in the tor circuit display. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.css Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.css ===================================== @@ -60,8 +60,8 @@ } #tor-circuit-alias:not([hidden]) { - /* Same margin as .panel-header > h1 */ - margin: 4px 0; + /* Same as padding for .panel-header */ + margin-block-start: var(--arrowpanel-menuitem-margin-inline); display: flex; align-items: center; } @@ -83,8 +83,10 @@ #tor-circuit-panel-body { /* May grow larger than 480px if we have a long domain name or ip address. */ min-width: 480px; - padding: 1em; - gap: 1em; + /* Line up with the button at the bottom of the panel. */ + margin: var(--arrowpanel-menuitem-margin); + padding: var(--arrowpanel-menuitem-padding); + gap: var(--arrowpanel-menuitem-padding-block); } #tor-circuit-node-list-name, @@ -95,7 +97,7 @@ #tor-circuit-node-list { line-height: 2; list-style: none; - padding-inline-start: 0.5em; + padding-inline-start: var(--arrowpanel-menuitem-margin-inline); /* Do not allow an item to wrap since this would break the circuit diagram. */ white-space: nowrap; } @@ -181,5 +183,5 @@ } .tor-circuit-button label.tor-circuit-button-description { - margin-block-start: 3px; + margin-block-start: var(--space-xsmall); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/292271b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/292271b… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by Pier Angelo Vendrame (@pierov) 08 Aug '24

08 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 786db184 by Henry Wilkes at 2024-08-08T15:24:27+01:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42700: Remove !nodes condition from circuit panel. Also updated comment. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.js Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -317,12 +317,11 @@ var gTorCircuitPanel = { this._currentBrowserData.domain === domain && this._currentBrowserData.scheme === scheme && this._currentBrowserData.nodes.length === nodes.length && - // If non-null, the fingerprints of the nodes match. - (!nodes || - nodes.every( - (n, index) => - n.fingerprint === this._currentBrowserData.nodes[index].fingerprint - )) + // The fingerprints of the nodes match. + nodes.every( + (n, index) => + n.fingerprint === this._currentBrowserData.nodes[index].fingerprint + ) ) { // No change. this._log.debug( View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/786db18… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/786db18… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (@pierov) 08 Aug '24

08 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 84eaa764 by Henry Wilkes at 2024-08-08T10:30:14+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42663: Add tooltip text to the &quot;Connection&quot; category. - - - - - 1208a39d by Henry Wilkes at 2024-08-08T10:35:05+01:00 fixup! Tor Browser strings Bug 42663: Add tooltip text to the &quot;Connection&quot; category. - - - - - 2 changed files: - browser/components/torpreferences/content/connectionCategory.inc.xhtml - toolkit/locales/en-US/toolkit/global/tor-browser.ftl Changes: ===================================== browser/components/torpreferences/content/connectionCategory.inc.xhtml ===================================== @@ -2,6 +2,8 @@ class="category" value="paneConnection" helpTopic="prefs-connection" + data-l10n-id="tor-connection-settings-category" + data-l10n-attrs="tooltiptext" align="center" hidden="true"> <image class="category-icon"/> ===================================== toolkit/locales/en-US/toolkit/global/tor-browser.ftl ===================================== @@ -49,6 +49,10 @@ home-mode-choice-tor = # "Connection" refers to the Tor Browser's connection to the Tor network. tor-connection-settings-heading = Connection +# The tooltip text for the "Connection" settings, shown in the preferences side bar. +# Likely should just be "{ tor-connection-settings-heading }", which will match the displayed text exactly. +tor-connection-settings-category = + .tooltiptext = { tor-connection-settings-heading } # -brand-short-name refers to 'Tor Browser', localized. tor-connection-overview = { -brand-short-name } routes your traffic over the Tor Network, run by thousands of volunteers around the world. tor-connection-browser-learn-more-link = Learn more View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5a97c2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5a97c2… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 42347: Add a notification for dropped OS version support.
by Pier Angelo Vendrame (@pierov) 08 Aug '24

08 Aug '24
Pier Angelo Vendrame pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 6da32b42 by Pier Angelo Vendrame at 2024-08-08T11:16:04+02:00 fixup! Bug 42347: Add a notification for dropped OS version support. Bug 43021: Revert &quot;Bug 42347: Add a notification for dropped OS version support.&quot; This reverts commit d92ee42bf0523425b33583006fc94c787dca55cb. - - - - - 562aeca5 by Pier Angelo Vendrame at 2024-08-08T11:16:05+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - 4 changed files: - browser/base/content/browser.xhtml - − browser/base/content/droppedSupportNotification.js - browser/base/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -129,7 +129,6 @@ Services.scriptloader.loadSubScript("chrome://browser/content/search/searchbar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/shopping/shopping-sidebar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/languageNotification.js", this); - Services.scriptloader.loadSubScript("chrome://browser/content/droppedSupportNotification.js", this); window.onload = gBrowserInit.onLoad.bind(gBrowserInit); window.onunload = gBrowserInit.onUnload.bind(gBrowserInit); ===================================== browser/base/content/droppedSupportNotification.js deleted ===================================== @@ -1,69 +0,0 @@ -"use strict"; - -// Show a prompt that a user's system will no longer be supported. -window.addEventListener("load", () => { - let labelId; - // Expire date is 2024-10-01 (1st October 2024). - const isExpired = Date.now() > Date.UTC(2024, 9, 1); - - if ( - AppConstants.platform === "macosx" && - Services.vc.compare( - Services.sysinfo.getProperty("version"), - "19.0" // MacOS 10.15 begins with Darwin 19.0 - ) < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-macos-version-less-than-10-15-expired" - : "dropped-support-notification-macos-version-less-than-10-15"; - } else if ( - AppConstants.platform === "win" && - Services.vc.compare(Services.sysinfo.getProperty("version"), "10.0") < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-win-os-version-less-than-10-expired" - : "dropped-support-notification-win-os-version-less-than-10"; - } - - const dismissedPref = - "browser.dropped_support_notification_v14.dismiss_version"; - - if (!labelId) { - // Avoid setting any preferences for supported versions, and clean up any - // old values if the user ported their profile. - Services.prefs.clearUserPref(dismissedPref); - return; - } - - if ( - !isExpired && - Services.prefs.getStringPref(dismissedPref, "") === - AppConstants.BASE_BROWSER_VERSION - ) { - // Already dismissed since the last update. - return; - } - - const buttons = isExpired - ? undefined - : [ - { - "l10n-id": "dropped-support-notification-dismiss-button", - callback: () => { - Services.prefs.setStringPref( - dismissedPref, - AppConstants.BASE_BROWSER_VERSION - ); - }, - }, - ]; - - gNotificationBox.appendNotification( - "dropped-support-notification", - { - label: { "l10n-id": labelId }, - priority: gNotificationBox.PRIORITY_WARNING_HIGH, - }, - buttons - ); -}); ===================================== browser/base/jar.mn ===================================== @@ -99,5 +99,4 @@ browser.jar: content/browser/spotlight.js (content/spotlight.js) * content/browser/default-bookmarks.html (content/default-bookmarks.html) - content/browser/droppedSupportNotification.js (content/droppedSupportNotification.js) content/browser/languageNotification.js (content/languageNotification.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -166,21 +166,3 @@ security-level-summary-custom = Your custom browser preferences have resulted in # Button to undo custom changes to the security level and place the user in one of the standard security levels. # Shown in the security level panel and settings. security-level-restore-defaults-button = Restore defaults - -## Notification for dropped operating system support. - -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15 = The next major version of { -brand-short-name } (14.0) will no longer support this version of macOS. Please upgrade to macOS 10.15 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15-expired = { -brand-short-name } no longer supports this version of macOS. Please upgrade to macOS 10.15 or later to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10 = The next major version of { -brand-short-name } (14.0) will no longer support this version of Windows. Please upgrade to Windows 10 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10-expired = { -brand-short-name } no longer supports this version of Windows. Please upgrade to Windows 10 or later to continue receiving important security updates. -dropped-support-notification-dismiss-button = Got it View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a67e45… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a67e45… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 42347: Add a notification for dropped OS version support.
by Pier Angelo Vendrame (@pierov) 08 Aug '24

08 Aug '24
Pier Angelo Vendrame pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 82a0c757 by Pier Angelo Vendrame at 2024-08-08T11:12:20+02:00 fixup! Bug 42347: Add a notification for dropped OS version support. Bug 43021: Revert &quot;Bug 42347: Add a notification for dropped OS version support.&quot; This reverts commit d92ee42bf0523425b33583006fc94c787dca55cb. - - - - - cf53e4fd by Pier Angelo Vendrame at 2024-08-08T11:12:22+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - 4 changed files: - browser/base/content/browser.xhtml - − browser/base/content/droppedSupportNotification.js - browser/base/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -129,7 +129,6 @@ Services.scriptloader.loadSubScript("chrome://browser/content/search/searchbar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/shopping/shopping-sidebar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/languageNotification.js", this); - Services.scriptloader.loadSubScript("chrome://browser/content/droppedSupportNotification.js", this); window.onload = gBrowserInit.onLoad.bind(gBrowserInit); window.onunload = gBrowserInit.onUnload.bind(gBrowserInit); ===================================== browser/base/content/droppedSupportNotification.js deleted ===================================== @@ -1,69 +0,0 @@ -"use strict"; - -// Show a prompt that a user's system will no longer be supported. -window.addEventListener("load", () => { - let labelId; - // Expire date is 2024-10-01 (1st October 2024). - const isExpired = Date.now() > Date.UTC(2024, 9, 1); - - if ( - AppConstants.platform === "macosx" && - Services.vc.compare( - Services.sysinfo.getProperty("version"), - "19.0" // MacOS 10.15 begins with Darwin 19.0 - ) < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-macos-version-less-than-10-15-expired" - : "dropped-support-notification-macos-version-less-than-10-15"; - } else if ( - AppConstants.platform === "win" && - Services.vc.compare(Services.sysinfo.getProperty("version"), "10.0") < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-win-os-version-less-than-10-expired" - : "dropped-support-notification-win-os-version-less-than-10"; - } - - const dismissedPref = - "browser.dropped_support_notification_v14.dismiss_version"; - - if (!labelId) { - // Avoid setting any preferences for supported versions, and clean up any - // old values if the user ported their profile. - Services.prefs.clearUserPref(dismissedPref); - return; - } - - if ( - !isExpired && - Services.prefs.getStringPref(dismissedPref, "") === - AppConstants.BASE_BROWSER_VERSION - ) { - // Already dismissed since the last update. - return; - } - - const buttons = isExpired - ? undefined - : [ - { - "l10n-id": "dropped-support-notification-dismiss-button", - callback: () => { - Services.prefs.setStringPref( - dismissedPref, - AppConstants.BASE_BROWSER_VERSION - ); - }, - }, - ]; - - gNotificationBox.appendNotification( - "dropped-support-notification", - { - label: { "l10n-id": labelId }, - priority: gNotificationBox.PRIORITY_WARNING_HIGH, - }, - buttons - ); -}); ===================================== browser/base/jar.mn ===================================== @@ -99,5 +99,4 @@ browser.jar: content/browser/spotlight.js (content/spotlight.js) * content/browser/default-bookmarks.html (content/default-bookmarks.html) - content/browser/droppedSupportNotification.js (content/droppedSupportNotification.js) content/browser/languageNotification.js (content/languageNotification.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -166,21 +166,3 @@ security-level-summary-custom = Your custom browser preferences have resulted in # Button to undo custom changes to the security level and place the user in one of the standard security levels. # Shown in the security level panel and settings. security-level-restore-defaults-button = Restore defaults - -## Notification for dropped operating system support. - -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15 = The next major version of { -brand-short-name } (14.0) will no longer support this version of macOS. Please upgrade to macOS 10.15 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15-expired = { -brand-short-name } no longer supports this version of macOS. Please upgrade to macOS 10.15 or later to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10 = The next major version of { -brand-short-name } (14.0) will no longer support this version of Windows. Please upgrade to Windows 10 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10-expired = { -brand-short-name } no longer supports this version of Windows. Please upgrade to Windows 10 or later to continue receiving important security updates. -dropped-support-notification-dismiss-button = Got it View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/65… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/65… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 42347: Add a notification for dropped OS version support.
by Pier Angelo Vendrame (@pierov) 08 Aug '24

08 Aug '24
Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: be034bda by Pier Angelo Vendrame at 2024-08-08T11:06:16+02:00 fixup! Bug 42347: Add a notification for dropped OS version support. Bug 43021: Revert &quot;Bug 42347: Add a notification for dropped OS version support.&quot; This reverts commit d92ee42bf0523425b33583006fc94c787dca55cb. - - - - - 5a97c2df by Pier Angelo Vendrame at 2024-08-08T11:06:19+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - 4 changed files: - browser/base/content/browser.xhtml - − browser/base/content/droppedSupportNotification.js - browser/base/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -138,7 +138,6 @@ Services.scriptloader.loadSubScript("chrome://browser/content/search/searchbar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/shopping/shopping-sidebar.js", this); Services.scriptloader.loadSubScript("chrome://browser/content/languageNotification.js", this); - Services.scriptloader.loadSubScript("chrome://browser/content/droppedSupportNotification.js", this); window.onload = gBrowserInit.onLoad.bind(gBrowserInit); window.onunload = gBrowserInit.onUnload.bind(gBrowserInit); ===================================== browser/base/content/droppedSupportNotification.js deleted ===================================== @@ -1,69 +0,0 @@ -"use strict"; - -// Show a prompt that a user's system will no longer be supported. -window.addEventListener("load", () => { - let labelId; - // Expire date is 2024-10-01 (1st October 2024). - const isExpired = Date.now() > Date.UTC(2024, 9, 1); - - if ( - AppConstants.platform === "macosx" && - Services.vc.compare( - Services.sysinfo.getProperty("version"), - "19.0" // MacOS 10.15 begins with Darwin 19.0 - ) < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-macos-version-less-than-10-15-expired" - : "dropped-support-notification-macos-version-less-than-10-15"; - } else if ( - AppConstants.platform === "win" && - Services.vc.compare(Services.sysinfo.getProperty("version"), "10.0") < 0 - ) { - labelId = isExpired - ? "dropped-support-notification-win-os-version-less-than-10-expired" - : "dropped-support-notification-win-os-version-less-than-10"; - } - - const dismissedPref = - "browser.dropped_support_notification_v14.dismiss_version"; - - if (!labelId) { - // Avoid setting any preferences for supported versions, and clean up any - // old values if the user ported their profile. - Services.prefs.clearUserPref(dismissedPref); - return; - } - - if ( - !isExpired && - Services.prefs.getStringPref(dismissedPref, "") === - AppConstants.BASE_BROWSER_VERSION - ) { - // Already dismissed since the last update. - return; - } - - const buttons = isExpired - ? undefined - : [ - { - "l10n-id": "dropped-support-notification-dismiss-button", - callback: () => { - Services.prefs.setStringPref( - dismissedPref, - AppConstants.BASE_BROWSER_VERSION - ); - }, - }, - ]; - - gNotificationBox.appendNotification( - "dropped-support-notification", - { - label: { "l10n-id": labelId }, - priority: gNotificationBox.PRIORITY_WARNING_HIGH, - }, - buttons - ); -}); ===================================== browser/base/jar.mn ===================================== @@ -105,5 +105,4 @@ browser.jar: content/browser/spotlight.js (content/spotlight.js) * content/browser/default-bookmarks.html (content/default-bookmarks.html) - content/browser/droppedSupportNotification.js (content/droppedSupportNotification.js) content/browser/languageNotification.js (content/languageNotification.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -166,21 +166,3 @@ security-level-summary-custom = Your custom browser preferences have resulted in # Button to undo custom changes to the security level and place the user in one of the standard security levels. # Shown in the security level panel and settings. security-level-restore-defaults-button = Restore defaults - -## Notification for dropped operating system support. - -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15 = The next major version of { -brand-short-name } (14.0) will no longer support this version of macOS. Please upgrade to macOS 10.15 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "macOS" is a brand name, and 10.15 is the macOS version number. -dropped-support-notification-macos-version-less-than-10-15-expired = { -brand-short-name } no longer supports this version of macOS. Please upgrade to macOS 10.15 or later to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "14.0" refers to the browser versions number: Tor Browser 14.0. -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10 = The next major version of { -brand-short-name } (14.0) will no longer support this version of Windows. Please upgrade to Windows 10 or later by October 1st 2024 to continue receiving important security updates. -# "{ -brand-short-name }" will be replaced with the localized name of the browser, e.g. "Tor Browser". -# "Windows" is a brand name, and "Windows 10" is the version. -dropped-support-notification-win-os-version-less-than-10-expired = { -brand-short-name } no longer supports this version of Windows. Please upgrade to Windows 10 or later to continue receiving important security updates. -dropped-support-notification-dismiss-button = Got it View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4f0cf0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4f0cf0… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][maint-13.5] Bump lyrebird version to 0.3.0
by morgan (@morgan) 08 Aug '24

08 Aug '24
morgan pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: aa66852e by meskio at 2024-08-07T23:24:04+00:00 Bump lyrebird version to 0.3.0 - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 0.2.0 +version: 0.3.0 git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyre… git_hash: 'lyrebird-[% c("version") %]' tag_gpg_id: 1 @@ -9,7 +9,7 @@ container: use_container: 1 var: - go_vendor_sha256sum: dc6b2671250f4ffd0caff3ef020bd60f99207f519f6f5f1be47243677a13c695 + go_vendor_sha256sum: 71abc8063f2913e74e87a2a5c9262c4fad6ce4ed98b28b7603b50382724baba4 targets: nightly: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][main] Bump lyrebird version to 0.3.0
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 00062f02 by meskio at 2024-08-07T23:03:10+00:00 Bump lyrebird version to 0.3.0 - - - - - 1 changed file: - projects/lyrebird/config Changes: ===================================== projects/lyrebird/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 0.2.0 +version: 0.3.0 git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyre… git_hash: 'lyrebird-[% c("version") %]' tag_gpg_id: 1 @@ -9,7 +9,7 @@ container: use_container: 1 var: - go_vendor_sha256sum: dc6b2671250f4ffd0caff3ef020bd60f99207f519f6f5f1be47243677a13c695 + go_vendor_sha256sum: 71abc8063f2913e74e87a2a5c9262c4fad6ce4ed98b28b7603b50382724baba4 targets: nightly: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 4f0cf02d by Beatriz Rizental at 2024-08-07T23:07:38+00:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 1 changed file: - tools/torbrowser/generate-bugzilla-triage-csv.sh Changes: ===================================== tools/torbrowser/generate-bugzilla-triage-csv.sh ===================================== @@ -158,7 +158,7 @@ printf "\n]\n" >> "${git_json}" query_tail="&f1=product&n1=1&o1=anyexact&v1=Thunderbird%2CCalendar%2CChat%20Core%2CMailNews%20Core&f2=target_milestone&o2=substring&v2=${firefox_version}&limit=0" bugzilla_query="https://bugzilla.mozilla.org/buglist.cgi?${query_tail}" -bugzilla_json_query="https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary${query_tail}" +bugzilla_json_query="https://bugzilla.mozilla.org/rest/bug?include_fields=id,component,summary${…" wget "${bugzilla_json_query}" -O ${bugzilla_json} @@ -174,13 +174,14 @@ jq -s '[ (.[0].bugs)[], (.[1])[] ] | group_by(.id) | map(.[0])' "${bugzilla_json # Generate Triage CSV # -echo "\"Review\",,\"Bugzilla Bug\"" +echo "\"Review\",,\"Bugzilla Component\",\"Bugzilla Bug\"" -jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ -| while IFS='|' read -r id summary; do +jq '. | sort_by([.component, .id])[] | "\(.id)|\(.component)|\(.summary)"' ${union_json} \ +| while IFS='|' read -r id component summary; do # bugzilla info id="${id:1}" + component="${component:0}" summary="${summary:0:-1}" summary=$(jq_unescape "${summary}") # short summary for gitlab issue title @@ -207,6 +208,7 @@ jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ echoerr "Skipped Bugzilla ${id}: ${summary_short}" else csv_summary=$(csv_escape "${summary}") + csv_component=$(csv_escape "${component}") # parent issue bugzilla_url="https://bugzilla.mozilla.org/show_bug.cgi?id=${id}" @@ -221,7 +223,7 @@ jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ create_issue=$(csv_escape "=HYPERLINK(\"${new_issue_url}\", \"New Issue\")") bugzilla_link=$(csv_escape "=HYPERLINK(\"${bugzilla_url}\", \"Bugzilla ${id}: ${csv_summary}\")") - echo "FALSE,\"${create_issue}\",\"${bugzilla_link}\"," + echo "FALSE,\"${create_issue}\",\"${csv_component}\",\"${bugzilla_link}\"," fi done View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4f0cf02… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4f0cf02… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 3 commits: fixup! Bug 7494: Create local home page for TBB.
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 732e4181 by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42713: Use `--link-color` rather than `--in-content-link-color`. - - - - - fbf19afe by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - da08e423 by Henry Wilkes at 2024-08-07T22:56:00+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - 3 changed files: - browser/components/abouttor/content/aboutTor.css - browser/components/torpreferences/content/torPreferences.css - toolkit/components/torconnect/content/aboutTorConnect.css Changes: ===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -194,14 +194,14 @@ body:not(.show-tor-check) #tor-check { --in-content-page-color: #fbfbfe; --in-content-text-color: #fbfbfe; color: var(--in-content-text-color); - --in-content-link-color: var(--purple-30); + --link-color: var(--purple-30); /* FIXME: Since we have a dark background, the color should get lighter on * hover, but --purple-40 and --pruple-50 are darker than --purple-30. * However, we do not have a standard lighter purple in our current set of * Photon colors. * See tor-browser#42025 */ - --in-content-link-color-hover: var(--purple-40); - --in-content-link-color-active: var(--purple-50); + --link-color-hover: var(--purple-40); + --link-color-active: var(--purple-50); } #search-form { ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -913,7 +913,7 @@ dialog#torPreferences-requestBridge-dialog > hbox { } #lox-invite-dialog-error-message { - color: var(--in-content-error-text-color); + color: var(--text-color-error); } #lox-invite-dialog-generate-area:not(.show-error) #lox-invite-dialog-error-message { @@ -1049,7 +1049,7 @@ groupbox#torPreferences-bridges-group textarea { } #user-provide-bridge-error-message { - color: var(--in-content-error-text-color); + color: var(--text-color-error); } #user-provide-bridge-dialog:not(.show-error) #user-provide-bridge-error-message { ===================================== toolkit/components/torconnect/content/aboutTorConnect.css ===================================== @@ -154,7 +154,7 @@ button { } #locationDropdownLabel.error { - color: var(--in-content-error-text-color) + color: var(--text-color-error) } #tryBridgeButton.danger-button { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fdad7c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fdad7c… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 656fcdfc by Henry Wilkes at 2024-08-07T22:53:49+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the &quot;badged&quot; attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/656… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/656… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a67e4520 by Henry Wilkes at 2024-08-07T22:50:45+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the &quot;badged&quot; attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e452… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a67e452… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: fdad7c54 by Henry Wilkes at 2024-08-07T22:46:23+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the &quot;badged&quot; attribute from the security level button. - - - - - 2 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelButton.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -69,7 +69,6 @@ var SecurityLevelButton = { * Open the panel popup for the button. */ openPopup() { - let anchorNode; const overflowPanel = document.getElementById("widget-overflow"); if (overflowPanel.contains(this._button)) { // We are in the overflow panel. @@ -84,10 +83,8 @@ var SecurityLevelButton = { // panel rather than our dialog-like panel. overflowPanel.hidePopup(); this._anchorButton = document.getElementById("nav-bar-overflow-button"); - anchorNode = this._anchorButton.icon; } else { this._anchorButton = this._button; - anchorNode = this._button.badgeStack; } const panel = SecurityLevelPanel.panel; @@ -103,7 +100,13 @@ var SecurityLevelButton = { }); } - panel.openPopup(anchorNode, "bottomright topright", 0, 0, false); + panel.openPopup( + this._anchorButton.icon, + "bottomright topright", + 0, + 0, + false + ); }, init() { ===================================== browser/components/securitylevel/content/securityLevelButton.inc.xhtml ===================================== @@ -1,5 +1,4 @@ <toolbarbutton id="security-level-button" class="toolbarbutton-1 chromeclass-toolbar-additional" - badged="true" removable="true" cui-areatype="toolbar"/> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdad7c5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fdad7c5… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][main] Bug 41202: Remove restricted entitlements
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 4d4e1380 by Nicolas Vigier at 2024-08-06T15:43:19+02:00 Bug 41202: Remove restricted entitlements Remove the following restricted entitlements: * com.apple.application-identifier * com.apple.developer.web-browser.public-key-credential https://searchfox.org/mozilla-central/source/tools/signing/macos/mach_comma… - - - - - 1 changed file: - tools/signing/macos-entitlements/firefox.browser.xml Changes: ===================================== tools/signing/macos-entitlements/firefox.browser.xml ===================================== @@ -23,12 +23,5 @@ <!-- For SmartCardServices(7) --> <key>com.apple.security.smartcard</key><true/> - - <!-- Required for com.apple.developer.web-browser.public-key-credential --> - <key>com.apple.application-identifier</key> - <string>43AQ936H96.org.mozilla.firefox</string> - - <!-- For platform passkey (webauthn) support --> - <key>com.apple.developer.web-browser.public-key-credential</key><true/> </dict> </plist> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 41600: Add a tor circuit display panel.
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 95ec0dcc by Henry Wilkes at 2024-08-07T21:39:39+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42488: Remove redundant role=&quot;code&quot; from ip address &lt;code&gt; element. After ESR 128, the &lt;code&gt; element has an implicit &quot;code&quot; accessible role. - - - - - 1 changed file: - browser/components/torcircuit/content/torCircuitPanel.js Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -617,19 +617,10 @@ var gTorCircuitPanel = { } else { addressesEl.append(", "); } + // Use semantic <code> block for the ip addresses, so the content + // (especially punctuation) can be better interpreted by screen readers, + // if they support this. const ipEl = document.createElement("code"); - // TODO: Current HTML-aam 1.0 specs map the <code> element to the "code" - // role. - // However, mozilla-central commented out this mapping in - // accessible/base/HTMLMarkupMap.h because the HTML-aam specs at the - // time did not do this. - // See hg.mozilla.org/mozilla-central/rev/51eebe7d6199#l2.12 - // - // This was updated in mozilla bug 1834931, for ESR 128 - // - // For now we explicitly add the role="code", but once this is fixed - // from mozilla-central we should remove this. - ipEl.setAttribute("role", "code"); ipEl.classList.add("tor-circuit-ip-address"); ipEl.textContent = ip; addressesEl.append(ipEl); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95ec0dc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/95ec0dc… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Customize moz-toggle for tor-browser.
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ab241f69 by Henry Wilkes at 2024-08-07T21:22:16+00:00 fixup! Customize moz-toggle for tor-browser. Bug 42612: Reimplement the moz-toggle customization for 128 ESR. - - - - - 1 changed file: - toolkit/content/widgets/moz-toggle/moz-toggle.mjs Changes: ===================================== toolkit/content/widgets/moz-toggle/moz-toggle.mjs ===================================== @@ -34,6 +34,10 @@ export default class MozToggle extends MozLitElement { description: { type: String }, ariaLabel: { type: String, attribute: "aria-label" }, accessKey: { type: String, attribute: "accesskey" }, + // Extension for tor-browser. Used for tor-browser#41333. + title: { type: String, attribute: "title" }, + // Extension for tor-browser. Used for tor-browser#40837. + labelAlignAfter: { type: Boolean, attribute: "label-align-after" }, }; static get queries() { @@ -111,7 +115,11 @@ export default class MozToggle extends MozLitElement { } render() { - // TODO: Reimplement labelAlignAfter! + // For tor-browser, we want to be able to place the label after the toggle + // as well. + // Used for the enable-bridges switch tor-browser#40837. + const labelAlignAfter = this.labelAlignAfter; + return html` <link rel="stylesheet" @@ -126,11 +134,12 @@ export default class MozToggle extends MozLitElement { for="moz-toggle-button" accesskey=${ifDefined(this.accessKey)} > + ${labelAlignAfter ? this.buttonTemplate() : ""} <span> ${this.label} ${!this.description ? this.supportLinkTemplate() : ""} </span> - ${this.buttonTemplate()} + ${labelAlignAfter ? "" : this.buttonTemplate()} </label> ` : this.buttonTemplate()} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ab241f6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ab241f6… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Adding issue and merge request templates
by morgan (@morgan) 07 Aug '24

07 Aug '24
morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5921a342 by Morgan at 2024-08-07T20:22:59+00:00 fixup! Adding issue and merge request templates add QA issue templates for tor browser desktop and android - - - - - 2 changed files: - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md Changes: ===================================== .gitlab/issue_templates/QA - Android.md ===================================== @@ -0,0 +1,71 @@ +Manual QA test check-list for major android releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! +<details> + <summary>Tor Browser Android QA Checklist</summary> +```markdown +# System Information + +- Version: Tor Browser XXX +- OS: Android YYY +- Device + CPU Architecture: ZZZ + +# Features + +## Base functionality +- [ ] Tor Browser launches successfully +- [ ] Connects to the Tor network +- [ ] Localisation (Browser chrome) + - [ ] Check especially the recently added strings +- [ ] Toolbars and menus work +- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html +- [ ] Security level (Standard, Safer, Safest) + - **TODO**: test pages verifying correct behaviour + +## Proxy safety +- [ ] Tor exit test: https://check.torproject.org +- [ ] Circuit isolation + - Following websites should all report different IP addresses + - https://ifconfig.io + - https://myip.wtf + - https://wtfismyip.com +- [ ] DNS leaks: https://dnsleaktest.com + +## Connectivity + Anti-Censorship +- [ ] Bridges: + - Bootstrap + - Browse: https://check.torproject.org + - [ ] Default bridges: + - [ ] obfs4 + - [ ] meek + - [ ] snowflake + - [ ] User provided bridges: + - [ ] obfs4 from https://bridges.torproject.org + - [ ] webtunnel from https://bridges.torproject.org + - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transpo… + +## Web Browsing +- [ ] HTTPS-Only: http://http.badssl.com +- [ ] .onion: + - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/ + - [ ] Onion service errors + - [ ] invalid onion: http://invalid.onion + - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/ + - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Inf… + - **TODO** all the identity block states + - **TODO** client auth +- [ ] **TODO**: .securedrop.tor.onion +- [ ] **TODO**: onion-service alt-svc +- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page + - [ ] MPEG4 + - [ ] WebM + - [ ] Ogg +- [ ] WebSocket Test: https://websocketking.com/ + +## External Components +- [ ] NoScript + - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/ + - [ ] Not removable from about:addons + - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/ + - **TODO**: fix test pages +``` + +</details> ===================================== .gitlab/issue_templates/QA - Desktop.md ===================================== @@ -0,0 +1,160 @@ +Manual QA test check-list for major desktop releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! + +<details> + <summary>Tor Browser Desktop QA Checklist</summary> + +```markdown +# System Information + +- Version: Tor Browser XXX +- OS: Windows|macOS|Linux YYY +- CPU Architecture: +- Profile: New|Old + +# Features + +## Base functionality +- [ ] Tor Browser launches successfully +- [ ] Connects to the Tor network + - [ ] Homepage loads: + - [ ] about:tor + - [ ] about:blank + - [ ] custom +- [ ] Tor Browser loads URLs passed by command-line after bootstrapped +- [ ] Localisation (Browser chrome) + - [ ] Language notification/message bar + - [ ] Spoof English + - [ ] Check especially the recently added strings +- [ ] UI Customisations: + - [ ] New Identity + - [ ] Toolbar icon + - [ ] Hamburger menu + - [ ] File menu + - [ ] New circuit for this site + - [ ] Circuit display + - [ ] Hamburger menu + - [ ] File menu + - [ ] No Firefox extras (Sync, Pocket, Report broken site, Tracking protection, etc) + - [ ] No unified extensions button (puzzle piece) + - [ ] NoScript button hidden + - [ ] Context Menu Populated +- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html +- [ ] Security level (Standard, Safer, Safest) + - Displays in: + - toolbar icon + - toolbar panel + - about:preferences#privacy + - [ ] On switch, each UI element is updated + - [ ] On custom config (toggle `svg.disabled`) + - [ ] each UI element displays warning + - [ ] `Restore defaults` reverts custom prefs + - **TODO**: test pages verifying correct behaviour +- [ ] New identity +- [ ] Betterboxing + - [ ] Reuse last window size + - [ ] Content alignment + - [ ] No letterboxing: + - [ ]empty tabs or privileged pages (eg: about:blank, about:about) + - [ ] full-screen video + - [ ] pdf viewer + - [ ] reader-mode +- [ ] Downloads Warning + - [ ] Downloads toolbar panel + - [ ] about:downloads + - [ ] Library window (<kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>o</kbd>) +- [ ] Drag and Drop protections: + - [ ] Dragging a link from a tab to another tab in the same window works + - [ ] Dragging a link from a tab to another tab in a separate window works + - [ ] Dragging a link into the library creates a bookmark + - [ ] Dragging a link from Tor Browser to Firefox doesn't work + - [ ] Dragging a link from Firefox to Tor Browser works + - [ ] Dragging a link from Tor Browser to another app (e.g., text editor) doesn't work + - [ ] Repeat with page favicon + +## Proxy safety +- [ ] Tor exit test: https://check.torproject.org +- [ ] Circuit isolation + - Following websites should all report different IP addresses + - https://ifconfig.io + - https://myip.wtf + - https://wtfismyip.com +- [ ] DNS leaks: https://dnsleaktest.com +- [ ] Circuit Display + - [ ] Website => circuit + - [ ] Remote PDF => circuit + - [ ] Remote image => circuit + - [ ] .onion Website => circuit with onion-service relays + - [ ] .tor.onion Website => circuit with onion-service relays, link to true onion address + - http://ft.securedrop.tor.onion + - [ ] Website in reader mode => circuit (same as w/o reader mode) + - [ ] Local image => no circuit + - [ ] Local SVG with remote content => catch-all circuit, but not shown + - [ ] Local PDF => no circuit + - [ ] Local HTML `file://` with local resources => no circuit + - [ ] Local HTML `file://` with remote resources => catch-all circuit, but not shown + +## Connectivity + Anti-Censorship +- [ ] Tor daemon config by environment variables + - https://gitlab.torproject.org/tpo/applications/team/-/wikis/Environment-var… +- [ ] Internet Test ( about:preferences#connection ) + - [ ] Fails when offline + - [ ] Succeeds when online +- [ ] Bridges: + - Bootstrap + - Browse: https://check.torproject.org + - Bridge node in circuit-display + - Bridge cards + - Disable + - Remove + - [ ] Default bridges: + - [ ] Removable as a group, not editable + - [ ] obfs4 + - [ ] meek + - [ ] snowflake + - [ ] User provided bridges: + - [ ] Removable and editable individually + - [ ] obfs4 from https://bridges.torproject.org + - [ ] webtunnel from https://bridges.torproject.org + - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transpo… + - [ ] Request bridges... + - [ ] Removable as a group, but not editable + - [ ] Succeeds when bootstrapped + - [ ] Succeeds when not bootstrapped + - **TODO**: Lox +- [ ] Connect Assist + - Useful pref: `torbrowser.debug.censorship_level` + - [ ] Auto-bootstrap updates Tor connection settings on success + - [ ] Auto-bootstrap restore previous Tor connection settings on failure + +## Web Browsing +- [ ] HTTPS-Only: http://http.badssl.com +- [ ] Crypto-currency warning on http website + - **TODO**: we should provide an example page +- [ ] .onion: + - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/ + - [ ] Onion-Location pill + - [ ] Client authentication + - You can create an ephemeral client-auth onion-service using [onion share](https://onionshare.org) + - [ ] Onion service errors + - [ ] invalid onion: http://invalid.onion + - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/ + - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Inf… + - **TODO** all the identity block states + - **TODO** client auth +- [ ] **TODO**: .securedrop.tor.onion +- [ ] **TODO**: onion-service alt-svc +- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page + - [ ] MPEG4 + - [ ] WebM + - [ ] Ogg +- [ ] WebSocket Test: https://websocketking.com/ + +## External Components +- [ ] NoScript + - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/ + - [ ] Not removable from about:addons + - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/ + - **TODO**: fix test pages +``` + +</details> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5921a34… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5921a34… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 78
  • 79
  • 80
  • 81
  • 82
  • 83
  • 84
  • ...
  • 745
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.