- tbb-commits - lists.torproject.org

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] 4 commits: fixup! Modify build system
by Pier Angelo Vendrame (＠pierov) 22 Feb '24

22 Feb '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 6c3669ee by clairehurst at 2024-02-21T18:55:49-07:00 fixup! Modify build system - - - - - cd3473f6 by clairehurst at 2024-02-21T20:41:44-07:00 fixup! Add Tor integration and UI Remove quick start - - - - - 5e60c209 by clairehurst at 2024-02-21T21:10:03-07:00 Implement Android-native Connection Assist UI - - - - - 7c1cc539 by clairehurst at 2024-02-21T21:10:03-07:00 fixup! Enable the connect assist experiments on alpha - - - - - 22 changed files: - fenix/app/src/main/java/org/mozilla/fenix/BrowserDirection.kt - fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt - fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorBetaConnectionFeaturesFragment.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapFragment.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapStatus.kt - + fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt - + fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerTAS.kt - − fenix/app/src/main/java/org/mozilla/fenix/tor/bootstrap/TorQuickStart.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapConnectViewHolder.kt - + fenix/app/src/main/res/drawable/connect.xml - fenix/app/src/main/res/drawable/progress_gradient.xml - + fenix/app/src/main/res/layout/fragment_tor_connection_assist.xml - fenix/app/src/main/res/layout/tor_bootstrap_connect.xml - fenix/app/src/main/res/layout/tor_network_settings_beta_connection_features.xml - fenix/app/src/main/res/navigation/nav_graph.xml - fenix/app/src/main/res/values/colors.xml - fenix/app/src/main/res/values/torbrowser_strings.xml - fenix/tools/tba-fetch-deps.sh Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/BrowserDirection.kt ===================================== @@ -41,4 +41,5 @@ enum class BrowserDirection(@IdRes val fragmentId: Int) { FromLoginDetailFragment(R.id.loginDetailFragment), FromTabsTray(R.id.tabsTrayFragment), FromRecentlyClosed(R.id.recentlyClosedFragment), + FromTorConnectionAssistFragment(R.id.torConnectionAssistFragment) } ===================================== fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -157,6 +157,7 @@ import org.mozilla.fenix.tabstray.TabsTrayFragment import org.mozilla.fenix.tabstray.TabsTrayFragmentDirections import org.mozilla.fenix.theme.DefaultThemeManager import org.mozilla.fenix.theme.ThemeManager +import org.mozilla.fenix.tor.TorConnectionAssistFragmentDirections import org.mozilla.fenix.tor.TorEvents import org.mozilla.fenix.trackingprotection.TrackingProtectionPanelDialogFragmentDirections import org.mozilla.fenix.utils.BrowsersCache @@ -1085,6 +1086,10 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorIn BrowserDirection.FromStudiesFragment -> StudiesFragmentDirections.actionGlobalBrowser( customTabSessionId, ) + BrowserDirection.FromTorConnectionAssistFragment, + -> TorConnectionAssistFragmentDirections.actionGlobalBrowser( + customTabSessionId, + ) } /** ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -115,7 +115,6 @@ import org.mozilla.fenix.search.toolbar.SearchSelectorMenu import org.mozilla.fenix.tabstray.TabsTrayAccessPoint import org.mozilla.fenix.tor.TorBootstrapFragmentDirections import org.mozilla.fenix.tor.TorBootstrapStatus -import org.mozilla.fenix.tor.bootstrap.TorQuickStart import org.mozilla.fenix.utils.Settings.Companion.TOP_SITES_PROVIDER_MAX_THRESHOLD import org.mozilla.fenix.utils.allowUndo import org.mozilla.fenix.wallpapers.Wallpaper @@ -202,7 +201,6 @@ class HomeFragment : Fragment() { private val recentBookmarksFeature = ViewBoundFeatureWrapper<RecentBookmarksFeature>() private val historyMetadataFeature = ViewBoundFeatureWrapper<RecentVisitsFeature>() private val searchSelectorBinding = ViewBoundFeatureWrapper<SearchSelectorBinding>() - private val torQuickStart by lazy { TorQuickStart(requireContext()) } private val searchSelectorMenuBinding = ViewBoundFeatureWrapper<SearchSelectorMenuBinding>() private lateinit var torBootstrapStatus: TorBootstrapStatus @@ -236,7 +234,6 @@ class HomeFragment : Fragment() { val components = requireComponents torBootstrapStatus = TorBootstrapStatus( - torQuickStart, !BuildConfig.DISABLE_TOR, components.torController, ::dispatchModeChanges ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorBetaConnectionFeaturesFragment.kt ===================================== @@ -54,10 +54,7 @@ class TorBetaConnectionFeaturesFragment : Fragment() { children.forEach { it.isEnabled = false } } } else { - // Do not enable the native UI until it is actually available. - // binding.enableBetaConnectionFeaturesModes.children.forEach { it.isEnabled = true } - binding.useNewBootstrapWithHtmlUiRadioButton.isEnabled = true - binding.useNewBootstrapWithNativeUiRadioButton.isEnabled = false + binding.enableBetaConnectionFeaturesModes.children.forEach { it.isEnabled = true } } } ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapFragment.kt ===================================== @@ -8,14 +8,12 @@ import android.os.Bundle import android.view.LayoutInflater import android.view.View import android.view.ViewGroup -import androidx.annotation.VisibleForTesting import androidx.core.view.children import androidx.fragment.app.Fragment import androidx.lifecycle.lifecycleScope import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.databinding.FragmentHomeBinding import org.mozilla.fenix.ext.requireComponents -import org.mozilla.fenix.tor.bootstrap.TorQuickStart import org.mozilla.fenix.tor.interactor.DefaultTorBootstrapInteractor import org.mozilla.fenix.tor.interactor.TorBootstrapInteractor import androidx.navigation.fragment.findNavController @@ -30,7 +28,6 @@ import org.mozilla.fenix.tor.view.TorBootstrapView @Suppress("TooManyFunctions", "LargeClass") class TorBootstrapFragment : Fragment() { - private val torQuickStart by lazy { TorQuickStart(requireContext()) } internal var _binding: FragmentHomeBinding? = null private val binding get() = _binding!! @@ -55,7 +52,6 @@ class TorBootstrapFragment : Fragment() { val components = requireComponents torBootstrapStatus = TorBootstrapStatus( - torQuickStart, !BuildConfig.DISABLE_TOR, components.torController, ::dispatchModeChanges ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapStatus.kt ===================================== @@ -4,11 +4,8 @@ package org.mozilla.fenix.tor -import org.mozilla.fenix.tor.bootstrap.TorQuickStart - @SuppressWarnings("LongParameterList", "TooManyFunctions") class TorBootstrapStatus( - private val torQuickStart: TorQuickStart, private val shouldStartTor: Boolean, private val torController: TorController, private val dispatchModeChanges: (isShouldBootstrap: Boolean) -> Unit @@ -18,7 +15,7 @@ class TorBootstrapStatus( torController.registerTorListener(this) } - fun isBootstrapping() = (shouldStartTor && (!torQuickStart.quickStartTor() && !torController.isBootstrapped)) + fun isBootstrapping() = (shouldStartTor && !torController.isBootstrapped) @SuppressWarnings("EmptyFunctionBlock") ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt ===================================== @@ -0,0 +1,131 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package org.mozilla.fenix.tor + +import android.os.Build +import android.os.Bundle +import android.view.LayoutInflater +import android.view.View +import android.view.ViewGroup +import androidx.fragment.app.Fragment +import androidx.fragment.app.viewModels +import androidx.lifecycle.Lifecycle +import androidx.lifecycle.lifecycleScope +import androidx.lifecycle.repeatOnLifecycle +import androidx.navigation.fragment.findNavController +import kotlinx.coroutines.launch +import org.mozilla.fenix.R +import org.mozilla.fenix.databinding.FragmentTorConnectionAssistBinding +import org.mozilla.fenix.ext.hideToolbar + +class TorConnectionAssistFragment : Fragment() { + + private var _binding: FragmentTorConnectionAssistBinding? = null + private val binding get() = _binding!! + + private val viewModel: TorConnectionAssistViewModel by viewModels() + + override fun onCreateView( + inflater: LayoutInflater, + container: ViewGroup?, + savedInstanceState: Bundle?, + ): View { + _binding = FragmentTorConnectionAssistBinding.inflate( + inflater, container, false, + ) + + return binding.root + } + + override fun onResume() { + super.onResume() + hideToolbar() + } + + override fun onViewCreated(view: View, savedInstanceState: Bundle?) { + super.onViewCreated(view, savedInstanceState) + + lifecycleScope.launch { + repeatOnLifecycle(Lifecycle.State.STARTED) { + viewModel.torConnectState.collect { + when (it) { + TorConnectState.Initial -> showConfiguring() + TorConnectState.Configuring -> showConfiguring() + TorConnectState.AutoBootstrapping -> showBootstrapping() + TorConnectState.Bootstrapping -> showBootstrapping() + TorConnectState.Error -> TODO() + TorConnectState.Bootstrapped -> openHome() + TorConnectState.Disabled -> openHome() + } + } + } + } + + viewModel.progress().observe( + viewLifecycleOwner, + ) { progress -> + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { + binding.torBootstrapProgressBar.setProgress(progress, true) + } else { + binding.torBootstrapProgressBar.progress = progress + } + } + + viewModel.quickconnectToggle().observe( + viewLifecycleOwner + ) { + binding.quickstartSwitch.isChecked = it + } + + binding.settingsButton.setOnClickListener { + viewModel.cancelTorBootstrap() + openSettings() + } + + binding.torBootstrapConnectButton.setOnClickListener { + viewModel.handleConnect(lifecycleScope = lifecycleScope) + } + + binding.quickstartSwitch.setOnCheckedChangeListener { _, isChecked -> + viewModel.handleQuickstartChecked(isChecked) + } + } + + private fun showConfiguring() { + binding.torBootstrapConnectButton.visibility = View.VISIBLE + binding.torBootstrapNetworkSettingsButton.text = + getString(R.string.connection_assist_configure_connection_button) + binding.torBootstrapNetworkSettingsButton.setOnClickListener { + openTorNetworkSettings() + } + } + + private fun showBootstrapping() { + binding.torBootstrapConnectButton.visibility = View.INVISIBLE + binding.torBootstrapNetworkSettingsButton.text = getString(R.string.btn_cancel) + binding.torBootstrapNetworkSettingsButton.setOnClickListener { + viewModel.cancelTorBootstrap() + } + } + + private fun openSettings(preferenceToScrollTo: String? = null) { + findNavController().navigate( + TorConnectionAssistFragmentDirections + .actionTorConnectionAssistFragmentToSettingsFragment(preferenceToScrollTo), + ) + } + + private fun openTorNetworkSettings() { + findNavController().navigate( + TorConnectionAssistFragmentDirections + .actionTorConnectionAssistFragmentToTorNetworkSettings(), + ) + } + + private fun openHome() { + findNavController().navigate(TorConnectionAssistFragmentDirections.actionStartupHome()) + } + +} ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt ===================================== @@ -0,0 +1,86 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package org.mozilla.fenix.tor + +import android.app.Application +import android.util.Log +import androidx.lifecycle.AndroidViewModel +import androidx.lifecycle.LifecycleCoroutineScope +import androidx.lifecycle.LiveData +import androidx.lifecycle.MutableLiveData +import kotlinx.coroutines.flow.MutableStateFlow +import kotlinx.coroutines.flow.StateFlow +import org.mozilla.fenix.ext.components + +class TorConnectionAssistViewModel( + application: Application, +) : AndroidViewModel(application), TorEvents { + + private val TAG = "torConnectionAssistVM" + private val components = getApplication<Application>().components + + private val _torController: TorControllerGV = components.torController as TorControllerGV + + private val _torConnectState = MutableStateFlow(TorConnectState.Initial) + internal val torConnectState: StateFlow<TorConnectState> = _torConnectState + + init { + _torController.registerTorListener(this) + } + + private val _progress = MutableLiveData(0) + fun progress(): LiveData<Int> { + return _progress + } + + private val _quickconnectToggle = MutableLiveData(_torController.quickstart) + fun quickconnectToggle(): LiveData<Boolean> { + return _quickconnectToggle + } + + fun handleConnect( + withDebugLogging: Boolean = false, + lifecycleScope: LifecycleCoroutineScope? = null, + ) { + _torController.initiateTorBootstrap( + withDebugLogging = withDebugLogging, + lifecycleScope = lifecycleScope, + ) + } + + fun handleQuickstartChecked(checked: Boolean) { + _torController.quickstart = checked + } + + fun cancelTorBootstrap() { + _torController.stopTor() + _torController.setTorStopped() + } + + override fun onTorConnecting() { + Log.d(TAG, "onTorConnecting()") + } + + override fun onTorConnected() { + Log.d(TAG, "onTorConnected()") + _torController.unregisterTorListener(this) + _torConnectState.value = _torController.lastKnownStatus + } + + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { + Log.d(TAG, "onTorStatusUpdate($entry, $status, $progress)") + if (progress != null) { + _progress.value = progress.toInt() + } + _torConnectState.value = _torController.lastKnownStatus + } + + override fun onTorStopped() { + Log.d(TAG, "onTorStopped()") + _progress.value = 0 + _torConnectState.value = _torController.lastKnownStatus + } + +} ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt ===================================== @@ -49,6 +49,7 @@ interface TorController: TorEvents { var bridgesEnabled: Boolean var bridgeTransport: TorBridgeTransportConfig var userProvidedBridges: String? + var quickstart: Boolean fun start() fun stop() ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -52,7 +52,7 @@ class TorControllerGV( private var torListeners = mutableListOf<TorEvents>() - private var lastKnownStatus = TorConnectState.Initial + internal var lastKnownStatus = TorConnectState.Initial private var wasTorBootstrapped = false private var isTorRestarting = false @@ -66,6 +66,17 @@ class TorControllerGV( override val isBootstrapped get() = isTorBootstrapped override val isConnected get() = (lastKnownStatus.isStarted() && !isTorRestarting) + override var quickstart: Boolean + get() { + return getTorSettings()?.quickstart ?: false + } + set(value) { + getTorSettings()?.let { + it.quickstart = value + getTorIntegration().setSettings(it, true, true) + } + } + private fun getTorIntegration(): TorIntegrationAndroid { return (context.components.core.engine as GeckoEngine).getTorIntegrationController() } @@ -198,7 +209,7 @@ class TorControllerGV( } override fun setTorStopped() { - lastKnownStatus = TorConnectState.Disabled + lastKnownStatus = TorConnectState.Configuring onTorStopped() } @@ -243,7 +254,7 @@ class TorControllerGV( if (isTorRestarting) { initiateTorBootstrap() } else { - onTorStopped() + setTorStopped() } } @@ -280,6 +291,7 @@ class TorControllerGV( // TorEventsBootstrapStateChangeListener override fun onBootstrapError(message: String?, details: String?) { lastKnownStatus = TorConnectState.Error + onBootstrapStateChange(TorConnectState.Error.state) } // TorEventsBootstrapStateChangeListener ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerTAS.kt ===================================== @@ -19,6 +19,7 @@ class TorControllerTAS (private val context: Context): TorController { private val lbm: LocalBroadcastManager = LocalBroadcastManager.getInstance(context) private val entries = mutableListOf<Pair<String?, String?>>() override val logEntries get() = entries + override var quickstart: Boolean = false // Stub, is never used private var torListeners = mutableListOf<TorEvents>() ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/bootstrap/TorQuickStart.kt deleted ===================================== @@ -1,54 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - -package org.mozilla.fenix.tor.bootstrap - -import android.content.Context -import android.content.SharedPreferences -import android.os.StrictMode -import androidx.annotation.VisibleForTesting -import mozilla.components.support.ktx.android.content.PreferencesHolder -import mozilla.components.support.ktx.android.content.booleanPreference -import org.mozilla.fenix.ext.components - -class TorQuickStart(val context: Context) : PreferencesHolder { - - override val preferences: SharedPreferences = - context.components.strictMode.resetAfter(StrictMode.allowThreadDiskReads()) { - context.getSharedPreferences( - PREF_NAME_TOR_BOOTSTRAP_KEY, - Context.MODE_PRIVATE - ) - } - - private var torQuickStart by booleanPreference(TOR_QUICK_START, default = false) - - fun quickStartTor() = - context.components.strictMode.resetAfter(StrictMode.allowThreadDiskReads()) { torQuickStart } - - fun enableQuickStartTor() { - torQuickStart = true - } - fun disableQuickStartTor() { - torQuickStart = false - } - fun setQuickStartTor(enabled: Boolean) = if (enabled) { - enableQuickStartTor() - } else { - disableQuickStartTor() - } - - companion object { - /** - * Name of the shared preferences file. - */ - private const val PREF_NAME_TOR_BOOTSTRAP_KEY = "tor.bootstrap" - - /** - * Key for [quickStartTor]. - */ - @VisibleForTesting - internal const val TOR_QUICK_START = "tor.bootstrap.quick_start_enabled" - } -} ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapConnectViewHolder.kt ===================================== @@ -10,7 +10,6 @@ import org.mozilla.fenix.R import org.mozilla.fenix.components.Components import org.mozilla.fenix.databinding.TorBootstrapConnectBinding import org.mozilla.fenix.tor.TorEvents -import org.mozilla.fenix.tor.bootstrap.TorQuickStart import org.mozilla.fenix.tor.interactor.TorBootstrapInteractor class TorBootstrapConnectViewHolder( @@ -23,17 +22,6 @@ class TorBootstrapConnectViewHolder( init { binding = TorBootstrapConnectBinding.bind(view) - val torQuickStart = TorQuickStart(view.context) - setQuickStartDescription(view, torQuickStart) - - with(binding.quickStartToggle) { - setOnCheckedChangeListener { _, isChecked -> - torQuickStart.setQuickStartTor(isChecked) - setQuickStartDescription(view, torQuickStart) - } - - isChecked = torQuickStart.quickStartTor() - } with(binding.torBootstrapNetworkSettingsButton) { setOnClickListener { @@ -66,20 +54,6 @@ class TorBootstrapConnectViewHolder( components.torController.registerTorListener(this) } - private fun setQuickStartDescription(view: View, torQuickStart: TorQuickStart) { - val resources = view.context.resources - val appName = resources.getString(R.string.app_name) - if (torQuickStart.quickStartTor()) { - binding.torBootstrapQuickStartDescription.text = resources.getString( - R.string.tor_bootstrap_quick_start_enabled, appName - ) - } else { - binding.torBootstrapQuickStartDescription.text = resources.getString( - R.string.tor_bootstrap_quick_start_disabled - ) - } - } - @SuppressWarnings("EmptyFunctionBlock") override fun onTorConnecting() { } ===================================== fenix/app/src/main/res/drawable/connect.xml ===================================== @@ -0,0 +1,17 @@ +<vector xmlns:android="http://schemas.android.com/apk/res/android" + android:width="40dp" + android:height="40dp" + android:viewportWidth="40" + android:viewportHeight="40"> + <path + android:pathData="M20,1.253C9.647,1.253 1.253,9.647 1.253,20C1.253,28.967 7.547,36.46 15.96,38.307C16.84,38.5 17.733,38.633 18.653,38.693V24.373C16.787,23.8 15.427,22.06 15.427,20C15.427,17.473 17.473,15.427 20,15.427C22.527,15.427 24.573,17.473 24.573,20C24.573,22.06 23.213,23.8 21.347,24.373V38.693C22.267,38.633 23.16,38.5 24.04,38.307C32.453,36.46 38.747,28.967 38.747,20C38.747,9.647 30.353,1.253 20,1.253ZM24.04,35.293V26.32C26.12,24.987 27.5,22.653 27.5,20C27.5,15.86 24.14,12.5 20,12.5C15.86,12.5 12.5,15.86 12.5,20C12.5,22.653 13.88,24.987 15.96,26.32V35.293C9.18,33.513 4.18,27.347 4.18,20C4.18,11.26 11.26,4.18 20,4.18C28.74,4.18 35.82,11.26 35.82,20C35.82,27.347 30.82,33.513 24.04,35.293Z" + android:fillColor="#FBFBFE" + android:fillType="evenOdd"/> + <path + android:pathData="M20,6.873C12.753,6.873 6.873,12.753 6.873,20C6.873,25.84 10.687,30.787 15.96,32.487V29.36C12.34,27.8 9.807,24.193 9.807,20C9.807,14.367 14.367,9.807 20,9.807C25.633,9.807 30.193,14.367 30.193,20C30.193,24.193 27.66,27.8 24.04,29.36V32.487C29.313,30.787 33.127,25.84 33.127,20C33.127,12.753 27.247,6.873 20,6.873Z" + android:fillColor="#FBFBFE" + android:fillType="evenOdd"/> + <path + android:pathData="M20,22.1C21.16,22.1 22.1,21.159 22.1,20C22.1,18.84 21.16,17.9 20,17.9C18.84,17.9 17.9,18.84 17.9,20C17.9,21.159 18.84,22.1 20,22.1Z" + android:fillColor="#FBFBFE"/> +</vector> ===================================== fenix/app/src/main/res/drawable/progress_gradient.xml ===================================== @@ -12,16 +12,10 @@ <item android:id="@android:id/progress"> <scale android:scaleWidth="100%"> <shape> - <corners - android:bottomLeftRadius="0dp" - android:bottomRightRadius="8dp" - android:topLeftRadius="0dp" - android:topRightRadius="8dp"/> <gradient - android:angle="45" - android:centerColor="#F10366" - android:endColor="#FF9100" - android:startColor="#6173FF" /> + android:angle="0" + android:endColor="#00DBDE" + android:startColor="#FC00FF"/> </shape> </scale> </item> ===================================== fenix/app/src/main/res/layout/fragment_tor_connection_assist.xml ===================================== @@ -0,0 +1,146 @@ +<?xml version="1.0" encoding="utf-8"?> +<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" + xmlns:app="http://schemas.android.com/apk/res-auto" + android:layout_width="match_parent" + android:layout_height="match_parent" + android:background="@drawable/tor_bootstrap_background_gradient"> + + <ProgressBar + android:id="@+id/tor_bootstrap_progress_bar" + style="?android:attr/progressBarStyleHorizontal" + android:layout_width="match_parent" + android:layout_height="6dp" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" /> + + <ImageView + android:id="@+id/settings_button" + android:layout_width="24dp" + android:layout_height="24dp" + android:layout_marginTop="26dp" + android:layout_marginEnd="20dp" + android:contentDescription="@string/settings" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintTop_toTopOf="parent" + app:srcCompat="@drawable/mozac_ic_settings" /> + + <ImageView + android:id="@+id/tor_connect_image" + android:layout_width="40dp" + android:layout_height="40dp" + android:layout_marginStart="24dp" + android:contentDescription="@string/tor_bootstrap_connect" + android:visibility="visible" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@+id/tor_bootstrap_progress_bar" + app:layout_constraintVertical_bias="0.075" + app:srcCompat="@drawable/connect" /> + + <TextView + android:id="@+id/title_large_text_view" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:layout_marginStart="24dp" + android:layout_marginTop="24dp" + android:layout_marginEnd="24dp" + android:text="@string/connection_assist_tor_connect_title" + android:textColor="#FBFBFE" + android:textFontWeight="400" + android:textSize="22sp" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@id/tor_connect_image" /> + + <TextView + android:id="@+id/connect_to_tor_description" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:layout_marginStart="24dp" + android:layout_marginTop="16dp" + android:layout_marginEnd="24dp" + android:text="@string/preferences_tor_network_settings_explanation" + android:textColor="#FBFBFE" + android:textFontWeight="400" + android:textSize="14sp" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintHorizontal_bias="0.0" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@id/title_large_text_view" /> + + <TextView + android:id="@+id/connect_automatically" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginStart="24dp" + android:layout_marginTop="24dp" + android:text="@string/connection_assist_always_connect_automatically_toggle_description" + android:textColor="#FBFBFE" + android:textSize="14sp" + app:layout_constraintBottom_toBottomOf="@+id/quickstart_switch" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="@+id/quickstart_switch" + app:layout_constraintVertical_bias="1.25" /> + + <com.google.android.material.switchmaterial.SwitchMaterial + android:id="@+id/quickstart_switch" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="24dp" + android:layout_marginEnd="24dp" + android:layout_marginBottom="24dp" + android:enabled="false" + android:gravity="center" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintTop_toBottomOf="@id/connect_to_tor_description" + app:layout_goneMarginEnd="6dp" + app:layout_goneMarginTop="9dp" /> + + <Button + android:id="@+id/tor_bootstrap_connect_button" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:layout_marginStart="24dp" + android:layout_marginEnd="24dp" + android:layout_marginBottom="8dp" + android:background="@drawable/rounded_corners" + android:backgroundTint="@color/connect_button_purple" + android:maxWidth="312dp" + android:text="@string/tor_bootstrap_connect" + android:textAllCaps="false" + android:textColor="#FBFBFE" + android:textFontWeight="500" + android:textSize="14sp" + android:textStyle="bold" + app:layout_constraintBottom_toTopOf="@id/tor_bootstrap_network_settings_button" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintHorizontal_bias="0.0" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@+id/quickstart_switch" + app:layout_constraintVertical_bias="1" /> + + + <Button + android:id="@+id/tor_bootstrap_network_settings_button" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:layout_marginStart="24dp" + android:layout_marginEnd="24dp" + android:layout_marginBottom="24dp" + android:background="@drawable/rounded_corners" + android:backgroundTint="@color/configure_connection_button_white" + android:maxWidth="312dp" + android:text="@string/connection_assist_configure_connection_button" + android:textAllCaps="false" + android:textColor="#15141A" + android:textFontWeight="500" + android:textSize="14sp" + android:textStyle="bold" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toStartOf="parent" /> + +</androidx.constraintlayout.widget.ConstraintLayout> ===================================== fenix/app/src/main/res/layout/tor_bootstrap_connect.xml ===================================== @@ -44,42 +44,6 @@ android:layout_height="wrap_content" android:layout_above="@id/tor_bootstrap_connect_button" /> - <TextView - android:id="@+id/quick_start_label" - android:visibility="gone" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginStart="@dimen/library_item_icon_margin_horizontal" - android:layout_marginEnd="@dimen/library_item_icon_margin_horizontal" - android:layout_above="@id/tor_bootstrap_quick_start_description" - android:layout_toEndOf="@id/quick_start_toggle" - android:paddingStart="8dp" - android:paddingEnd="8dp" - android:clickable="false" - android:textAppearance="@style/ListItemTextStyle" - android:textColor="#EEEEEE" - android:text="@string/tor_bootstrap_quick_start_label" - android:textSize="18sp" /> - - <TextView - android:id="@+id/tor_bootstrap_quick_start_description" - android:visibility="gone" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginStart="@dimen/library_item_icon_margin_horizontal" - android:layout_marginEnd="@dimen/library_item_icon_margin_horizontal" - android:paddingStart="8dp" - android:paddingEnd="8dp" - android:clickable="false" - android:layout_marginBottom="20dp" - android:textAppearance="@style/ListItemTextStyle" - android:layout_toEndOf="@id/quick_start_toggle" - android:layout_above="@id/tor_bootstrap_connect_button" - android:textColor="#FFBBBBBB" - android:text="@string/tor_bootstrap_quick_start_disabled" - android:lines="3" - android:textSize="18sp" /> - <Button android:id="@+id/tor_bootstrap_connect_button" android:layout_width="wrap_content" ===================================== fenix/app/src/main/res/layout/tor_network_settings_beta_connection_features.xml ===================================== @@ -84,7 +84,6 @@ android:background="?android:attr/selectableItemBackground" android:button="@null" android:drawablePadding="@dimen/radio_button_preference_drawable_padding" - android:enabled="false" android:paddingStart="@dimen/radio_button_preference_horizontal" android:paddingTop="@dimen/radio_button_preference_vertical" android:paddingEnd="@dimen/radio_button_preference_horizontal" ===================================== fenix/app/src/main/res/navigation/nav_graph.xml ===================================== @@ -277,6 +277,31 @@ app:popExitAnim="@anim/slide_out_right" /> </fragment> + <fragment + android:id="@+id/torConnectionAssistFragment" + android:name="org.mozilla.fenix.tor.TorConnectionAssistFragment" + tools:layout="@layout/fragment_home"> + <action + android:id="@+id/action_home" + app:destination="@id/homeFragment" + app:popUpTo="@id/torConnectionAssistFragment" + app:popUpToInclusive="true" /> + <action + android:id="@+id/action_torConnectionAssistFragment_to_SettingsFragment" + app:destination="@id/settingsFragment" + app:enterAnim="@anim/slide_in_right" + app:exitAnim="@anim/slide_out_left" + app:popEnterAnim="@anim/slide_in_left" + app:popExitAnim="@anim/slide_out_right" /> + <action + android:id="@+id/action_torConnectionAssistFragment_to_TorNetworkSettings" + app:destination="@id/torNetworkSettingsFragment" + app:enterAnim="@anim/slide_in_right" + app:exitAnim="@anim/slide_out_left" + app:popEnterAnim="@anim/slide_in_left" + app:popExitAnim="@anim/slide_out_right" /> + </fragment> + <dialog android:id="@+id/homeOnboardingDialogFragment" android:name="org.mozilla.fenix.onboarding.HomeOnboardingDialogFragment" /> @@ -769,6 +794,13 @@ app:exitAnim="@anim/slide_out_left" app:popEnterAnim="@anim/slide_in_left" app:popExitAnim="@anim/slide_out_right" /> + <action + android:id="@+id/action_settingsFragment_to_TorConnectionAssistFragment" + app:destination="@id/torConnectionAssistFragment" + app:enterAnim="@anim/slide_in_right" + app:exitAnim="@anim/slide_out_left" + app:popEnterAnim="@anim/slide_in_left" + app:popExitAnim="@anim/slide_out_right" /> </fragment> <dialog android:id="@+id/profilerStartDialogFragment" ===================================== fenix/app/src/main/res/values/colors.xml ===================================== @@ -340,4 +340,9 @@  <color name="material_scrim_color">#52000000</color> + +  + <color name="connect_button_purple">#9059FF</color> + <color name="configure_connection_button_white">#E1E0E7</color> + </resources> ===================================== fenix/app/src/main/res/values/torbrowser_strings.xml ===================================== @@ -75,4 +75,73 @@  <string name="preferences_tor_prioritize_onions">Prioritize .onion sites</string> +  + <string name="connection_assist_tor_connect_title">Connect to Tor</string> +  + <string name="connection_assist_always_connect_automatically_toggle_description">Always connect automatically</string> +  + <string name="connection_assist_configure_connection_button">Configure connection…</string> + +  + <string name="connection_assist_connecting_title">Establishing a connection…</string> + +  + <string name="connection_assist_internet_error_title">We can’t reach the internet</string> +  + <string name="connection_assist_internet_error_description">This could be due to a connection issue rather than Tor being blocked. Check your internet connection, proxy, and firewall settings before trying again. %1$s</string> +  + <string name="connection_assist_internet_error_learn_more">Learn more</string> +  + <string name="connection_assist_internet_error_try_again">Try again</string> + +  + <string name="connection_assist_trying_again_waiting_title">Trying again…</string> + +  + <string name="connection_assist_cant_connect_to_tor_title">We can’t connect to Tor directly</string> +  + <string name="connection_assist_try_a_bridge_description">Try connecting via a bridge instead. By providing your location, we can look up the bridge that’s most likely to unblock the internet in your country or region. %1$s</string> +  + <string name="connection_assist_unblock_the_internet_in_country_or_region">Unblock the internet in:</string> +  + <string name="connection_assist_share_my_location_country_or_region">Share my location</string> +  + <string name="connection_assist_try_a_bridge_button">Try a bridge</string> + +  + <string name="connection_assist_try_a_bridge_learn_more_description1">Tor Browser will need to establish a brief non-Tor connection to determine your location and look up a bridge. If you don’t want to do that, you can %1$s instead.</string> +  + <string name="connection_assist_choose_a_bridge_manually_link">choose a bridge manually</string> +  + <string name="connection_assist_try_a_bridge_learn_more_error_code">Error code: %s</string> + +  + <string name="connection_assist_trying_a_bridge_title">Trying a bridge…</string> + +  + <string name="connection_assist_location_error_title">We couldn’t find your location</string> +  + <string name="connection_assist_location_error_description" translatable="false">%1$s %2$s %3$s</string> + <string name="connection_assist_find_bridge_location_description">To find a bridge that can unblock your internet, we need to know where you’re connecting from.</string> + <string name="connection_assist_select_country_try_again">Select your country or region and try again.</string> +  + <string name="connection_assist_location_error_last_try_description">%1$s %2$s %3$s</string> + <string name="connection_assist_check_location_settings_try_again">Please check your location settings are correct and try again.</string> + + <string name="connection_assist_location_error_learn_more_link">Learn more</string> + +  + <string name="connection_assist_location_check_title">We’re still having trouble connecting</string> + +  + <string name="connection_assist_last_try_title">Trying one more time…</string> + +  + <string name="connection_assist_final_error_title">We weren’t able to connect automatically</string> +  + <string name="connection_assist_final_error_description1">Despite our best efforts, we weren’t able to connect to Tor. We recommend %1$s and adding a bridge manually instead. %2$s</string> +  + <string name="connection_assist_final_error_troubleshoot_connection_link">troubleshooting your connection</string> +  + <string name="connection_assist_final_error_learn_more_link">Learn more</string> </resources> ===================================== fenix/tools/tba-fetch-deps.sh ===================================== @@ -14,7 +14,7 @@ fi onion_proxy_library="$(ls -1td "$TOR_BROWSER_BUILD/out/tor-onion-proxy-library/"tor-onion-proxy-library-* | head -1)" if [ -z "$onion_proxy_library" ]; then - echo "Cannot find Tor Onoin Proxy library artifacts!" + echo "Cannot find Tor Onion Proxy library artifacts!" exit 2 fi View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/16… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/16… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.5-1] fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 21 Feb '24

21 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 11ce0365 by Henry Wilkes at 2024-02-21T18:56:18+01:00 fixup! Base Browser strings Bug 42423: Add a base-browser Fluent file that is not passed on to translators. - - - - - 2 changed files: - + browser/locales-preview/base-browser-no-translate.ftl - browser/locales/jar.mn Changes: ===================================== browser/locales-preview/base-browser-no-translate.ftl ===================================== @@ -0,0 +1 @@ +# base-browser strings that should *not* be sent to translators on Weblate. ===================================== browser/locales/jar.mn ===================================== @@ -14,6 +14,7 @@ preview/firefoxSuggest.ftl (../components/urlbar/content/firefoxSuggest.ftl) preview/identityCredentialNotification.ftl (../components/credentialmanager/identityCredentialNotification.ftl) preview/stripOnShare.ftl (../components/urlbar/content/stripOnShare.ftl) + preview/base-browser-no-translate.ftl (../locales-preview/base-browser-no-translate.ftl) browser (%browser/**/*.ftl) @AB_CD@.jar: View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/11c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/11c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.8.0esr-13.5-1] fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 21 Feb '24

21 Feb '24

Pier Angelo Vendrame pushed to branch base-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 158a87d9 by Henry Wilkes at 2024-02-21T18:55:55+01:00 fixup! Base Browser strings Bug 42423: Add a base-browser Fluent file that is not passed on to translators. - - - - - 2 changed files: - + browser/locales-preview/base-browser-no-translate.ftl - browser/locales/jar.mn Changes: ===================================== browser/locales-preview/base-browser-no-translate.ftl ===================================== @@ -0,0 +1 @@ +# base-browser strings that should *not* be sent to translators on Weblate. ===================================== browser/locales/jar.mn ===================================== @@ -14,6 +14,7 @@ preview/firefoxSuggest.ftl (../components/urlbar/content/firefoxSuggest.ftl) preview/identityCredentialNotification.ftl (../components/credentialmanager/identityCredentialNotification.ftl) preview/stripOnShare.ftl (../components/urlbar/content/stripOnShare.ftl) + preview/base-browser-no-translate.ftl (../locales-preview/base-browser-no-translate.ftl) browser (%browser/**/*.ftl) @AB_CD@.jar: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/158a87d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/158a87d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.5-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 21 Feb '24

21 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 4044ac1c by Henry Wilkes at 2024-02-21T16:32:16+00:00 fixup! Base Browser strings Bug 42423: Add a base-browser Fluent file that is not passed on to translators. - - - - - 73edce4c by Henry Wilkes at 2024-02-21T16:32:17+00:00 fixup! Tor Browser strings Bug 42423: Add a tor-browser Fluent file that is not passed on to translators. - - - - - 4b5aa8fa by Henry Wilkes at 2024-02-21T16:32:17+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42423: Move temporary Lox invite strings to new file. - - - - - 5 changed files: - browser/components/torpreferences/content/loxInviteDialog.xhtml - + browser/locales-preview/base-browser-no-translate.ftl - + browser/locales-preview/tor-browser-no-translate.ftl - browser/locales/en-US/browser/tor-browser.ftl - browser/locales/jar.mn Changes: ===================================== browser/components/torpreferences/content/loxInviteDialog.xhtml ===================================== @@ -20,6 +20,10 @@ <dialog id="lox-invite-dialog" buttons="accept"> <linkset> <html:link rel="localization" href="browser/tor-browser.ftl" /> + <html:link + rel="localization" + href="preview/tor-browser-no-translate.ftl" + /> </linkset> <script src="chrome://browser/content/torpreferences/loxInviteDialog.js" /> ===================================== browser/locales-preview/base-browser-no-translate.ftl ===================================== @@ -0,0 +1 @@ +# base-browser strings that should *not* be sent to translators on Weblate. ===================================== browser/locales-preview/tor-browser-no-translate.ftl ===================================== @@ -0,0 +1,16 @@ +# tor-browser strings that should *not* be sent to translators on Weblate. + +## Bridge pass invite dialog. +## Temporary until tor-browser#42385 + +lox-invite-dialog-title = + .title = Bridge pass invites +lox-invite-dialog-description = You can ask the bridge bot to create a new invite, which you can share with a trusted contact to give them their own bridge pass. Each invite can only be redeemed once, but you will unlock access to more invites over time. +lox-invite-dialog-request-button = Request new invite +lox-invite-dialog-connecting = Connecting to bridge pass server… +lox-invite-dialog-no-server-error = Unable to connect to bridge pass server. +lox-invite-dialog-generic-invite-error = Failed to create a new invite. +lox-invite-dialog-invites-label = Created invites: +lox-invite-dialog-menu-item-copy-invite = + .label = Copy invite + .accesskey = C ===================================== browser/locales/en-US/browser/tor-browser.ftl ===================================== @@ -298,17 +298,3 @@ user-provide-bridge-dialog-result-invite = The following bridges were shared wit user-provide-bridge-dialog-result-addresses = The following bridges were entered by you. user-provide-bridge-dialog-next-button = .label = Next - -## Bridge pass invite dialog. Temporary. - -lox-invite-dialog-title = - .title = Bridge pass invites -lox-invite-dialog-description = You can ask the bridge bot to create a new invite, which you can share with a trusted contact to give them their own bridge pass. Each invite can only be redeemed once, but you will unlock access to more invites over time. -lox-invite-dialog-request-button = Request new invite -lox-invite-dialog-connecting = Connecting to bridge pass server… -lox-invite-dialog-no-server-error = Unable to connect to bridge pass server. -lox-invite-dialog-generic-invite-error = Failed to create a new invite. -lox-invite-dialog-invites-label = Created invites: -lox-invite-dialog-menu-item-copy-invite = - .label = Copy invite - .accesskey = C ===================================== browser/locales/jar.mn ===================================== @@ -14,6 +14,8 @@ preview/firefoxSuggest.ftl (../components/urlbar/content/firefoxSuggest.ftl) preview/identityCredentialNotification.ftl (../components/credentialmanager/identityCredentialNotification.ftl) preview/stripOnShare.ftl (../components/urlbar/content/stripOnShare.ftl) + preview/base-browser-no-translate.ftl (../locales-preview/base-browser-no-translate.ftl) + preview/tor-browser-no-translate.ftl (../locales-preview/tor-browser-no-translate.ftl) browser (%browser/**/*.ftl) @AB_CD@.jar: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bdfc4f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/bdfc4f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Update Mullvad and Tor Browser Release Prep issue templates
by richard (＠richard) 21 Feb '24

21 Feb '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: f1811496 by Richard Pospesel at 2024-02-21T11:55:05+00:00 Update Mullvad and Tor Browser Release Prep issue templates - - - - - 4 changed files: - .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md - .gitlab/issue_templates/Release Prep - Mullvad Browser Stable.md - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md Changes: ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md ===================================== @@ -27,172 +27,178 @@ </details> **NOTE** It is assumed that the `tor-browser` alpha rebase and security backport tasks have been completed + **NOTE** This can/is often done in conjunction with the equivalent Tor Browser release prep issue <details> <summary>Building</summary> - ### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git - Mullvad Browser Alpha (and Nightly) are on the `main` branch - - - [ ] Update `rbm.conf` - - [ ] `var/torbrowser_version` : update to next version - - [ ] `var/torbrowser_build` : update to `$(MULLVAD_BROWSER_BUILD_N)` - - [ ] `var/torbrowser_incremental_from` : update to previous Desktop version - - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update - - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make mullvadbrowser-incrementals-*` step will fail - - [ ] Update build configs - - [ ] Update `projects/firefox/config` - - [ ] `browser_build` : update to match `mullvad-browser` tag - - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased - - [ ] Update `projects/translation/config`: - - [ ] run `make list_translation_updates-alpha` to get updated hashes - - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/mullvad-browser/git_hash` : update with `HEAD` commit of project's `mullvad-browser` branch - - [ ] Update common build configs - - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript - - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` - - [ ] `URL` - - [ ] `sha256sum` - - [ ] Check for uBlock-origin updates here : https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ - - [ ] ***(Optional)*** If new version available, update `ublock-origin` section of `input_files` in `projects/browser/config` - - [ ] `URL` - - [ ] `sha256sum` - - [ ] Check for Mullvad Privacy Companion updates here : https://github.com/mullvad/browser-extension/releases - - [ ] ***(Optional)*** If new version available, update `mullvad-extension` section of `input_files` in `projects/browser/config` - - [ ] `URL` - - [ ] `sha256sum` - - [ ] Update `ChangeLog-MB.txt` - - [ ] Ensure `ChangeLog-MB.txt` is sync'd between alpha and stable branches - - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones - - [ ] Run `tools/fetch-changelogs.py $(ISSUE_NUMBER) --date $date $updateArgs` - - Make sure you have `requests` installed (e.g., `apt install python3-requests`) - - The first time you run this script you will need to generate an access token; the script will guide you - - `$updateArgs` should be these arguments, depending on what you actually updated: - - [ ] `--firefox` - - [ ] `--no-script` - - [ ] `--ublock` - - E.g., `tools/fetch-changelogs.py 41029 --date 'December 19 2023' --firefox 115.6.0esr --no-script 11.4.29 --ublock 1.54.0` - - `--date $date` is optional, if omitted it will be the date on which you run the command - - [ ] Copy the output of the script to the beginning of `ChangeLog-MB.txt` and adjust its output - - [ ] Open MR with above changes, using the template for release preparations - - [ ] Merge - - [ ] Sign+Tag - - **NOTE** this must be done by one of: - - boklm - - dan - - ma1 - - pierov - - richard - - [ ] Run: `make mullvadbrowser-signtag-alpha` - - [ ] Push tag to `upstream` - - [ ] Build the tag on at least one of: - - Run `make mullvadbrowser-alpha && make mullvadbrowser-incrementals-alpha` +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git +Mullvad Browser Alpha (and Nightly) are on the `main` branch + +- [ ] Update `rbm.conf` + - [ ] `var/torbrowser_version` : update to next version + - [ ] `var/torbrowser_build` : update to `$(MULLVAD_BROWSER_BUILD_N)` + - [ ] `var/torbrowser_incremental_from` : update to previous Desktop version + - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update + - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make mullvadbrowser-incrementals-*` step will fail +- [ ] Update build configs + - [ ] Update `projects/firefox/config` + - [ ] `browser_build` : update to match `mullvad-browser` tag + - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased + - [ ] Update `projects/translation/config`: + - [ ] run `make list_translation_updates-alpha` to get updated hashes + - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch + - [ ] `steps/mullvad-browser/git_hash` : update with `HEAD` commit of project's `mullvad-browser` branch +- [ ] Update common build configs + - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript + - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` + - [ ] Check for uBlock-origin updates here : https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ + - [ ] ***(Optional)*** If new version available, update `ublock-origin` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` + - [ ] Check for Mullvad Browser Extension updates here : https://github.com/mullvad/browser-extension/releases + - [ ] ***(Optional)*** If new version available, update `mullvad-extension` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` +- [ ] Update `ChangeLog-MB.txt` + - [ ] Ensure `ChangeLog-MB.txt` is sync'd between alpha and stable branches + - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones + - [ ] Run `tools/fetch-changelogs.py $(ISSUE_NUMBER) --date $date $updateArgs` + - Make sure you have `requests` installed (e.g., `apt install python3-requests`) + - The first time you run this script you will need to generate an access token; the script will guide you + - `$updateArgs` should be these arguments, depending on what you actually updated: + - [ ] `--firefox` (be sure to include esr at the end if needed, which is usually the case) + - [ ] `--no-script` + - [ ] `--ublock` + - E.g., `tools/fetch-changelogs.py 41029 --date 'December 19 2023' --firefox 115.6.0esr --no-script 11.4.29 --ublock 1.54.0` + - `--date $date` is optional, if omitted it will be the date on which you run the command + - [ ] Copy the output of the script to the beginning of `ChangeLog-MB.txt` and adjust its output +- [ ] Open MR with above changes, using the template for release preparations +- [ ] Merge +- [ ] Sign+Tag + - **NOTE** this must be done by one of: + - boklm + - dan + - ma1 + - pierov + - richard + - [ ] Run: `make mullvadbrowser-signtag-alpha` + - [ ] Push tag to `upstream` +- [ ] Build the tag: + - Run `make mullvadbrowser-alpha && make mullvadbrowser-incrementals-alpha` on: - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - **NOTE** this requires a devmole authentication token - Run `make mullvadbrowser-kick-devmole-build` - - [ ] Ensure builders have matching builds +- [ ] Ensure builders have matching builds </details> <details> <summary>Signing</summary> - ### signing - - [ ] Assign this issue to the signer, one of: - - boklm - - richard - - [ ] On `$(STAGING_SERVER)`, ensure updated: - - [ ] `tor-browser-build/tools/signing/set-config.hosts` - - `ssh_host_builder` : ssh hostname of machine with unsigned builds - - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) - - `ssh_host_linux_signer` : ssh hostname of linux signing machine - - [ ] `tor-browser-build/tools/signing/set-config.rcodesign-appstoreconnect` - - `appstoreconnect_api_key_path` : path to json file containing appstoreconnect api key infos - - [ ] `set-config.update-responses` - - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/mullvad-browser-update-responses.git` - - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` - - `tbb_version` : mullvad browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) - - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) - - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases - - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 - - [ ] run do-all-signing script: - - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.mullvadbrowser` - - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - - [ ] Update `staticiforme.torproject.org`: - - From `screen` session on `staticiforme.torproject.org`: - - [ ] Static update components : `static-update-component dist.torproject.org` - - [ ] Remove old release data from `/srv/dist-master.torproject.org/htdocs/mullvadbrowser` - - [ ] Static update components (again) : `static-update-component dist.torproject.org` +### release signing +- [ ] Assign this issue to the signer, one of: + - boklm + - richard +- [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(MULLVAD_BROWSER_VERSION)-$(MULLVAD_BROWSER_BUILD_N) && git checkout tbb-$(MULLVAD_BROWSER_VERSION)-$(MULLVAD_BROWSER_BUILD_N)` + - [ ] `tor-browser-build/tools/signing/set-config.hosts` + - `ssh_host_builder` : ssh hostname of machine with unsigned builds + - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) + - `ssh_host_linux_signer` : ssh hostname of linux signing machine + - [ ] `tor-browser-build/tools/signing/set-config.rcodesign-appstoreconnect` + - `appstoreconnect_api_key_path` : path to json file containing appstoreconnect api key infos + - [ ] `set-config.update-responses` + - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/mullvad-browser-update-responses.git` + - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` + - `tbb_version` : mullvad browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) + - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) + - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, run do-all-signing script: + - `cd tor-browser-build/tools/signing/` + - `./do-all-signing.mullvadbrowser` +- **NOTE**: at this point the signed binaries should have been copied to `staticiforme` +- [ ] Update `staticiforme.torproject.org`: + - From `screen` session on `staticiforme.torproject.org`: + - [ ] Remove old release data from `/srv/dist-master.torproject.org/htdocs/mullvadbrowser` + - [ ] Static update components (again) : `static-update-component dist.torproject.org` </details> <details> <summary>Publishing</summary> - ### mullvad-browser (github): https://github.com/mullvad/mullvad-browser/ - - [ ] Assign this issue to someone with mullvad commit access, one of: +### mullvad-browser (GitHub): https://github.com/mullvad/mullvad-browser/ +- [ ] Assign this issue to someone with mullvad commit access, one of: - richard - - [ ] Push this release's associated `mullvad-browser.git` branch to github - - [ ] Push this release's associated tags to github: - - [ ] Firefox ESR tag - - **example** : `FIREFOX_102_12_0esr_BUILD1,` - - [ ] `base-browser` tag - - **example** : `base-browser-102.12.0esr-12.0-1-build1` - - [ ] `mullvad-browser` tag - - **example** : `mullvad-browser-102.12.0esr-12.0-1-build1` - - [ ] Sign+Tag additionally the `mullvad-browser.git` `firefox` commit used in build: - - **Tag**: `$(MULLVAD_BROWSER_VERSION)` - - **example** : `12.5a7` - - **Message**: `$(ESR_VERSION)esr-based $(MULLVAD_BROWSER_VERSION)` - - **example** : `102.12.0esr-based 12.5a7` - - [ ] Push tag to github - - ### email - - [ ] Email Mullvad with release information: support(a)mullvad.net, rui(a)mullvad.net - <details> - <summary>email template</summary> - - Subject: - New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) - - Body: - signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) - - update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) - - changelog: - ... - - </details> +- [ ] Push this release's associated `mullvad-browser.git` branch to github +- [ ] Push this release's associated tags to github: + - [ ] Firefox ESR tag + - **example** : `FIREFOX_102_12_0esr_BUILD1` + - [ ] `base-browser` tag + - **example** : `base-browser-102.12.0esr-12.0-1-build1` + - [ ] `mullvad-browser` tag + - **example** : `mullvad-browser-102.12.0esr-12.0-1-build1` +- [ ] Sign+Tag additionally the `mullvad-browser.git` `firefox` commit used in build: + - **Tag**: `$(MULLVAD_BROWSER_VERSION)` + - **example** : `12.5a7` + - **Message**: `$(ESR_VERSION)esr-based $(MULLVAD_BROWSER_VERSION)` + - **example** : `102.12.0esr-based 12.5a7` + - [ ] Push tag to github + +### email +- [ ] **(Once branch+tags pushed to GitHub)** Email Mullvad with release information: + - [ ] support alias: support(a)mullvadvpn.net + - [ ] Rui: rui(a)mullvad.net + - **Subject** + ``` + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) + ``` + - **Body** + ``` + Hello, + + Branch+Tags have been pushed to Mullvad's GitHub repo. + + - signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) + - update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) + + changelog: + ... + ``` + </details> <details> <summary>Downstream</summary> - ### notify packagers - - - [ ] **(Optional, Once Mullvad Updates their Github Releases Page)** Email downstream consumers: - - **NOTE**: This is an optional step and only necessary close a major release/transition from alpha to stable, or if there are major packing changes these developers need to be aware of - <details> - <summary>email template</summary> - - Hello! - - Mullvad-Browser $(MULLVAD_BROWSER_VERSION) packages are available, so you should all update your respective downstream packages. - - Release builds can be found here: - - - https://github.com/mullvad/mullvad-browser/releases/tag/$(MULLVAD_BROWSER_V… - - </details> - - - flathub package maintainer: proletarius101(a)protonmail.com - - arch package maintainer: bootctl(a)gmail.com - - nixOS package maintainer: dev(a)felschr.com +### notify packagers +These steps depend on Mullvad having updated their [GitHub Releases](https://github.com/mullvad/mullvad-browser/releases/) page with the latest release +- [ ] **(Optional)** Email downstream consumers: + - **NOTE**: This is an optional step and only necessary close a major release/transition from alpha to stable, or if there are major packing changes these developers need to be aware of + - [ ] flathub package maintainer: proletarius101(a)protonmail.com + - [ ] arch package maintainer: bootctl(a)gmail.com + - [ ] nixOS package maintainer: dev(a)felschr.com + - **Subject** + ``` + Mullvad Browser $(MULLVAD_BROWSER_VERSION) released + ``` + - **Body** + ``` + Hello! + + This is a major alpha release which may require changes in your respective downstream packages once it stabilises. + + The latest alpha builds can be found here: + + - https://github.com/mullvad/mullvad-browser/releases?q=prerelease%3Atrue + ``` </details> ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Stable.md ===================================== @@ -28,6 +28,8 @@ **NOTE** It is assumed that the `tor-browser` stable rebase and security backport tasks have been completed +**NOTE** This can/is often done in conjunction with the equivalent Tor Browser release prep issue + <details> <summary>Building</summary> @@ -38,6 +40,7 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - [ ] `var/torbrowser_version` : update to next version - [ ] `var/torbrowser_build` : update to `$(MULLVAD_BROWSER_BUILD_N)` - [ ] `var/torbrowser_incremental_from` : update to previous Desktop version + - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make mullvadbrowser-incrementals-*` step will fail - [ ] Update build configs - [ ] Update `projects/firefox/config` @@ -46,7 +49,7 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - [ ] Update `projects/translation/config`: - [ ] run `make list_translation_updates-release` to get updated hashes - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/base-browser-fluent/git_hash` : update with `HEAD` commit of project's `basebrowser-newidentityftl` branch + - [ ] `steps/mullvad-browser/git_hash` : update with `HEAD` commit of project's `mullvad-browser` branch - [ ] Update common build configs - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` @@ -56,7 +59,7 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - [ ] ***(Optional)*** If new version available, update `ublock-origin` section of `input_files` in `projects/browser/config` - [ ] `URL` - [ ] `sha256sum` - - [ ] Check for Mullvad Privacy Companion updates here : https://github.com/mullvad/browser-extension/releases + - [ ] Check for Mullvad Browser Extension updates here : https://github.com/mullvad/browser-extension/releases - [ ] ***(Optional)*** If new version available, update `mullvad-extension` section of `input_files` in `projects/browser/config` - [ ] `URL` - [ ] `sha256sum` @@ -67,39 +70,43 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - Make sure you have `requests` installed (e.g., `apt install python3-requests`) - The first time you run this script you will need to generate an access token; the script will guide you - `$updateArgs` should be these arguments, depending on what you actually updated: - - [ ] `--firefox` + - [ ] `--firefox` (be sure to include esr at the end if needed, which is usually the case) - [ ] `--no-script` - [ ] `--ublock` - E.g., `tools/fetch-changelogs.py 41029 --date 'December 19 2023' --firefox 115.6.0esr --no-script 11.4.29 --ublock 1.54.0` - `--date $date` is optional, if omitted it will be the date on which you run the command - [ ] Copy the output of the script to the beginning of `ChangeLog-MB.txt` and adjust its output - - [ ] Open MR with above changes, using the template for release preparations - - [ ] Merge - - [ ] Sign+Tag - - **NOTE** this must be done by one of: - - boklm - - dan - - ma1 - - pierov - - richard - - [ ] Run: `make mullvadbrowser-signtag-release` - - [ ] Push tag to `upstream` - - [ ] Build on at least one of: - - Run `make mullvadbrowser-release && make mullvadbrowser-incrementals-release` +- [ ] Open MR with above changes, using the template for release preparations +- [ ] Merge +- [ ] Sign+Tag + - **NOTE** this must be done by one of: + - boklm + - dan + - ma1 + - pierov + - richard + - [ ] Run: `make mullvadbrowser-signtag-release` + - [ ] Push tag to `upstream` +- [ ] Build the tag: + - Run `make mullvadbrowser-release && make mullvadbrowser-incrementals-release` - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - **NOTE** this requires a devmole authentication token - Run `make mullvadbrowser-kick-devmole-build` - - [ ] Ensure builders have matching builds +- [ ] Ensure builders have matching builds </details> <details> <summary>Signing</summary> -### signing +### release signing +- [ ] Assign this issue to the signer, one of: + - boklm + - richard - [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(MULLVAD_BROWSER_VERSION)-$(MULLVAD_BROWSER_BUILD_N) && git checkout tbb-$(MULLVAD_BROWSER_VERSION)-$(MULLVAD_BROWSER_BUILD_N)` - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) @@ -113,13 +120,12 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 -- [ ] run do-all-signing script: - - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.mullvadbrowser` +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, run do-all-signing script: + - `cd tor-browser-build/tools/signing/` + - `./do-all-signing.mullvadbrowser` - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - [ ] Update `staticiforme.torproject.org`: - From `screen` session on `staticiforme.torproject.org`: - - [ ] Static update components : `static-update-component dist.torproject.org` - [ ] Remove old release data from `/srv/dist-master.torproject.org/htdocs/mullvadbrowser` - [ ] Static update components (again) : `static-update-component dist.torproject.org` @@ -128,30 +134,13 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU <details> <summary>Publishing</summary> -### email - -- [ ] Email Mullvad with release information: support(a)mullvad.net, rui(a)mullvad.net - <details> - <summary>email template</summary> - - Subject: - New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) - - Body: - signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) - - update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) - - changelog: - ... - - </details> - -### mullvad-browser (github): https://github.com/mullvad/mullvad-browser/ +### mullvad-browser (GitHub): https://github.com/mullvad/mullvad-browser/ +- [ ] Assign this issue to someone with mullvad commit access, one of: + - richard - [ ] Push this release's associated `mullvad-browser.git` branch to github - [ ] Push this release's associated tags to github: - [ ] Firefox ESR tag - - **example** : `FIREFOX_102_12_0esr_BUILD1,` + - **example** : `FIREFOX_102_12_0esr_BUILD1` - [ ] `base-browser` tag - **example** : `base-browser-102.12.0esr-12.0-1-build1` - [ ] `mullvad-browser` tag @@ -163,32 +152,59 @@ Mullvad Browser Stable lives in the various `maint-$(MULLVAD_BROWSER_MAJOR).$(MU - **example** : `102.12.0esr-based 12.0.7` - [ ] Push tag to github +### email +- [ ] **(Once branch+tags pushed to GitHub)** Email Mullvad with release information: + - [ ] support alias: support(a)mullvadvpn.net + - [ ] Rui: rui(a)mullvad.net + - **Subject** + ``` + New build: Mullvad Browser $(MULLVAD_BROWSER_VERION) (signed) + ``` + - **Body** + ``` + Hello, + + Branch+Tags have been pushed to Mullvad's GitHub repo. + + - signed builds: https://dist.torproject.org/mullvadbrowser/$(MULLVAD_BROWSER_VERSION) + - update_response hashes: $(MULLVAD_UPDATE_RESPONSES_HASH) + + changelog: + ... + ``` + </details> <details> <summary>Downstream</summary> ### notify packagers - -- [ ] **(Once Mullvad Updates their Github Releases Page)** Email downstream consumers: - <details> - <summary>email template</summary> - - ... - - ... - - </details> - +These steps depend on Mullvad having updated their [GitHub Releases](https://github.com/mullvad/mullvad-browser/releases/) page with the latest release +- [ ] Email downstream consumers: - [ ] flathub package maintainer: proletarius101(a)protonmail.com - [ ] arch package maintainer: bootctl(a)gmail.com - [ ] nixOS package maintainer: dev(a)felschr.com + - **Subject** + ``` + Mullvad Browser $(MULLVAD_BROWSER_VERSION) released + ``` + - **Body** + ``` + Hello! -### merge requests + Mullvad-Browser packages are available, so you should update your respective downstream packages. + + The latest release builds can be found here: -- [ ] homebrew: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/mullvad-browser… - - **NOTE**: should just need to update the version to latest + - https://github.com/mullvad/mullvad-browser/releases?q=prerelease%3Afalse + ``` + +### merge requests +- [ ] homebrew: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/m/mullvad-brows… + - **NOTE**: should just need to update `version` and `sha256` to latest </details> -/label ~"Release Prep" ~"Sponsor 131" +/label ~"Release Prep" +/label ~"Sponsor 131" + ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -32,197 +32,176 @@ <details> <summary>Building</summary> - ### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git - Tor Browser Alpha (and Nightly) are on the `main` branch - - - [ ] Update `rbm.conf` - - [ ] `var/torbrowser_version` : update to next version - - [ ] `var/torbrowser_build` : update to `$(TOR_BROWSER_BUILD_N)` - - [ ] ***(Desktop Only)***`var/torbrowser_incremental_from` : update to previous Desktop version - - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update - - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make torbrowser-incrementals-*` step will fail - - [ ] Update Desktop-specific build configs - - [ ] Update `projects/firefox/config` - - [ ] `browser_build` : update to match `tor-browser` tag - - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased - - [ ] Update `projects/translation/config`: - - [ ] run `make list_translation_updates-alpha` to get updated hashes - - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch - - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - - [ ] Update Android-specific build configs - - [ ] Update `projects/geckoview/config` - - [ ] `browser_build` : update to match `tor-browser` tag - - [ ] ***(Optional)*** `var/geckoview_version` : update to latest `$(ESR_VERSION)` if rebased - - [ ] ***(Optional)*** Update `projects/tor-android-service/config` - - [ ] `git_hash` : update with `HEAD` commit of project's `main` branch - - [ ] ***(Optional)*** Update `projects/application-services/config`: - **NOTE** we don't currently have any of our own patches for this project - - [ ] `git_hash` : update to appropriate git commit associated with `$(ESR_VERSION)` - - [ ] ***(Optional)*** Update `projects/firefox-android/config`: - - [ ] `fenix_version` : update to match alpha `firefox-android` build tag - - [ ] `browser_branch` : update to match alpha `firefox-android` build tag - - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` - - [ ] Update common build configs - - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript - - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` - - [ ] `URL` - - [ ] `sha256sum` - - [ ] Check for OpenSSL updates here : https://www.openssl.org/source/ - - [ ] ***(Optional)*** If new 3.0.X version available, update `projects/openssl/config` - - [ ] `version` : update to next 3.0.X version - - [ ] `input_files/sha256sum` : update to sha256 sum of source tarball - - [ ] Check for zlib updates here: https://github.com/madler/zlib/releases - - [ ] **(Optional)** If new tag available, update `projects/zlib/config` - - [ ] `version` : update to next release tag - - [ ] Check for tor updates here : https://gitlab.torproject.org/tpo/core/tor/-/tags - - [ ] ***(Optional)*** Update `projects/tor/config` - - [ ] `version` : update to latest `-alpha` tag or release tag if newer (ping dgoulet or ahf if unsure) - - [ ] Check for go updates here : https://golang.org/dl - - **NOTE** : Tor Browser Alpha uses the latest Stable major series go version - - [ ] ***(Optional)*** Update `projects/go/config` - - [ ] `version` : update go version - - [ ] `input_files/sha256sum` for `go` : update sha256sum of archive (sha256 sums are displayed on the go download page) - - [ ] Check for manual updates by running (from `tor-browser-build` root): `./tools/fetch-manual.py` - - [ ] ***(Optional)*** If new version is available: - - [ ] Upload the downloaded `manual_$PIPELINEID.zip` file to `tb-build-02.torproject.org` - - [ ] Deploy to `tb-builder`'s `public_html` directory: - - `sudo -u tb-builder cp manual_$PIPELINEID.zip ~/../tb-builder/public_html/.` - - [ ] Update `projects/manual/config`: - - [ ] Change the `version` to `$PIPELINEID` - - [ ] Update `sha256sum` in the `input_files` section - - [ ] Update `ChangeLog-TBB.txt` - - [ ] Ensure `ChangeLog-TBB.txt` is sync'd between alpha and stable branches - - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones - - [ ] Run `tools/fetch-changelogs.py $(ISSUE_NUMBER) --date $date $updateArgs` - - Make sure you have `requests` installed (e.g., `apt install python3-requests`) - - The first time you run this script you will need to generate an access token; the script will guide you - - `$updateArgs` should be these arguments, depending on what you actually updated: - - [ ] `--firefox` (be sure to include esr at the end if needed, which is usually the case) - - [ ] `--tor` - - [ ] `--no-script` - - [ ] `--openssl` - - [ ] `--zlib` - - [ ] `--go` - - E.g., `tools/fetch-changelogs.py 41028 --date 'December 19 2023' --firefox 115.6.0esr --tor 0.4.8.10 --no-script 11.4.29 --zlib 1.3 --go 1.21.5 --openssl 3.0.12` - - `--date $date` is optional, if omitted it will be the date on which you run the command - - [ ] Copy the output of the script to the beginning of `ChangeLog-TBB.txt` and adjust its output - - [ ] Open MR with above changes, using the template for release preparations - - [ ] Merge - - [ ] Sign+Tag - - **NOTE** this must be done by one of: - - boklm - - dan - - ma1 - - pierov - - richard - - [ ] Run: `make torbrowser-signtag-alpha` - - [ ] Push tag to `upstream` - - [ ] Build on at least one of: - - Run `make torbrowser-alpha && make torbrowser-incrementals-alpha` +### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git +Tor Browser Alpha (and Nightly) are on the `main` branch + +- [ ] Update `rbm.conf` + - [ ] `var/torbrowser_version` : update to next version + - [ ] `var/torbrowser_build` : update to `$(TOR_BROWSER_BUILD_N)` + - [ ] ***(Desktop Only)***`var/torbrowser_incremental_from` : update to previous Desktop version + - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update + - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make torbrowser-incrementals-*` step will fail +- [ ] Update Desktop-specific build configs + - [ ] Update `projects/firefox/config` + - [ ] `browser_build` : update to match `tor-browser` tag + - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased +- [ ] Update Android-specific build configs + - [ ] Update `projects/geckoview/config` + - [ ] `browser_build` : update to match `tor-browser` tag + - [ ] ***(Optional)*** `var/geckoview_version` : update to latest `$(ESR_VERSION)` if rebased + - [ ] ***(Optional)*** Update `projects/tor-android-service/config` + - [ ] `git_hash` : update with `HEAD` commit of project's `main` branch + - [ ] ***(Optional)*** Update `projects/application-services/config`: + **NOTE** we don't currently have any of our own patches for this project + - [ ] `git_hash` : update to appropriate git commit associated with `$(ESR_VERSION)` + - [ ] ***(Optional)*** Update `projects/firefox-android/config`: + - [ ] `fenix_version` : update to match alpha `firefox-android` build tag + - [ ] `browser_branch` : update to match alpha `firefox-android` build tag + - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): + - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` +- [ ] Update `projects/translation/config`: + - [ ] run `make list_translation_updates-alpha` to get updated hashes + - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch + - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch + - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch +- [ ] Update common build configs + - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript + - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` + - [ ] `URL` + - [ ] `sha256sum` + - [ ] Check for OpenSSL updates here : https://www.openssl.org/source/ + - [ ] ***(Optional)*** If new 3.0.X version available, update `projects/openssl/config` + - [ ] `version` : update to next 3.0.X version + - [ ] `input_files/sha256sum` : update to sha256 sum of source tarball + - [ ] Check for zlib updates here: https://github.com/madler/zlib/releases + - [ ] **(Optional)** If new tag available, update `projects/zlib/config` + - [ ] `version` : update to next release tag + - [ ] Check for tor updates here : https://gitlab.torproject.org/tpo/core/tor/-/tags + - [ ] ***(Optional)*** Update `projects/tor/config` + - [ ] `version` : update to latest `-alpha` tag or release tag if newer (ping dgoulet or ahf if unsure) + - [ ] Check for go updates here : https://go.dev/dl + - **NOTE** : In general, Tor Browser Alpha uses the latest Stable major series Go version, but there are sometimes exceptions. Check with the anti-censorship team before doing a major version update in case there is incompatibilities. + - [ ] ***(Optional)*** Update `projects/go/config` + - [ ] `version` : update go version + - [ ] `input_files/sha256sum` for `go` : update sha256sum of archive (sha256 sums are displayed on the go download page) + - [ ] Check for manual updates by running (from `tor-browser-build` root): `./tools/fetch-manual.py` + - [ ] ***(Optional)*** If new version is available: + - [ ] Upload the downloaded `manual_$PIPELINEID.zip` file to `tb-build-02.torproject.org` + - [ ] Deploy to `tb-builder`'s `public_html` directory: + - `sudo -u tb-builder cp manual_$PIPELINEID.zip ~tb-builder/public_html/.` + - [ ] Update `projects/manual/config`: + - [ ] Change the `version` to `$PIPELINEID` + - [ ] Update `sha256sum` in the `input_files` section +- [ ] Update `ChangeLog-TBB.txt` + - [ ] Ensure `ChangeLog-TBB.txt` is sync'd between alpha and stable branches + - [ ] Check the linked issues: ask people to check if any are missing, remove the not fixed ones + - [ ] Run `tools/fetch-changelogs.py $(ISSUE_NUMBER) --date $date $updateArgs` + - Make sure you have `requests` installed (e.g., `apt install python3-requests`) + - The first time you run this script you will need to generate an access token; the script will guide you + - `$updateArgs` should be these arguments, depending on what you actually updated: + - [ ] `--firefox` (be sure to include esr at the end if needed, which is usually the case) + - [ ] `--tor` + - [ ] `--no-script` + - [ ] `--openssl` + - [ ] `--zlib` + - [ ] `--go` + - E.g., `tools/fetch-changelogs.py 41028 --date 'December 19 2023' --firefox 115.6.0esr --tor 0.4.8.10 --no-script 11.4.29 --zlib 1.3 --go 1.21.5 --openssl 3.0.12` + - `--date $date` is optional, if omitted it will be the date on which you run the command + - [ ] Copy the output of the script to the beginning of `ChangeLog-TBB.txt` and adjust its output +- [ ] Open MR with above changes, using the template for release preparations +- [ ] Merge +- [ ] Sign+Tag + - **NOTE** this must be done by one of: + - boklm + - dan + - ma1 + - pierov + - richard + - [ ] Run: `make torbrowser-signtag-alpha` + - [ ] Push tag to `upstream` +- [ ] Build the tag: + - Run `make torbrowser-alpha && make torbrowser-incrementals-alpha` - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - **NOTE** this requires a devmole authentication token - Run `make torbrowser-kick-devmole-build` - - [ ] Ensure builders have matching builds +- [ ] Ensure builders have matching builds </details> <details> <summary>Communications</summary> - ### notify stakeholders - - - [ ] Email tor-qa mailing list: tor-qa(a)lists.torproject.org - <details> - <summary>email template</summary> - - Subject: - Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) - - Body: - Hello All, - - Unsigned Tor Browser $(TOR_BROWSER_VERSION) alpha candidate builds are now available for testing: - - - https://tb-build-05.torproject.org/~$(BUILDER)/builds/alpha/unsigned/$(TOR_… - - The full changelog can be found here: - - - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$(TB… - - </details> - - - ***(Optional)*** Additional information: - - [ ] Note any new functionality which needs testing - - [ ] Link to any known issues - - [ ] ***(Optional, only around build/packaging changes)*** Email packagers: - - Recipients: - - Tails dev mailing list: tails-dev(a)boum.org - - Guardian Project: nathan(a)guardianproject.info - - torbrowser-launcher: micah(a)micahflee.com - - FreeBSD port: freebsd(a)sysctl.cz  - - OpenBSD port: caspar(a)schutijser.com  - - [ ] Note any changes which may affect packaging/downstream integration - - [ ] Email external partners: - - ***(Optional, after ESR migration)*** Cloudflare: ask-research(a)cloudflare.com - - **NOTE** : We need to provide them with updated user agent string so they can update their internal machinery to prevent Tor Browser users from getting so many CAPTCHAs - - ***(Optional, after ESR migration)*** Startpage: admin(a)startpage.com - - **NOTE** : Startpage also needs the updated user-agent string for better experience on their onion service sites. +### notify stakeholders +- [ ] **(Once builds confirmed matching)** Email tor-qa mailing list with release information + - [ ] tor-qa: tor-qa(a)lists.torproject.org + - **Subject** + ``` + Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) + ``` + - **Body** + ``` + Hello, + + Unsigned Tor Browser $(TOR_BROWSER_VERSION) alpha candidate builds are now available for testing: + + - https://tb-build-02.torproject.org/~$(BUILDER)/builds/alpha/unsigned/$(TOR_… + + The full changelog can be found here: + + - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$(TB… + ``` +- [ ] ***(Optional, only around build/packaging changes)*** Email packagers: + - [ ] Tails dev mailing list: tails-dev(a)boum.org + - [ ] Guardian Project: nathan(a)guardianproject.info + - [ ] FreeBSD port: freebsd(a)sysctl.cz  + - [ ] OpenBSD port: caspar(a)schutijser.com  + - [ ] Note any changes which may affect packaging/downstream integration +- [ ] ***(Optional, after ESR migration)*** Email external partners: + - [ ] Cloudflare: ask-research(a)cloudflare.com + - **NOTE** : We need to provide them with updated user agent string so they can update their internal machinery to prevent Tor Browser users from getting so many CAPTCHAs + - [ ] Startpage: admin(a)startpage.com + - **NOTE** : Startpage also needs the updated user-agent string for better experience on their onion service sites. </details> <details> <summary>Signing</summary> - ### signing - - **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long - - [ ] Assign this issue to the signer, one of: - - boklm - - richard - - [ ] On `$(STAGING_SERVER)`, ensure updated: - - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N) && git checkout tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N)` - - [ ] `tor-browser-build/tools/signing/set-config.hosts` - - `ssh_host_builder` : ssh hostname of machine with unsigned builds - - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) - - `ssh_host_linux_signer` : ssh hostname of linux signing machine - - [ ] `tor-browser-build/tools/signing/set-config.rcodesign-appstoreconnect` - - `appstoreconnect_api_key_path` : path to json file containing appstoreconnect api key infos - - [ ] `set-config.update-responses` - - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/tor-browser-update-responses.git` - - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` - - `tbb_version` : tor browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) - - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) - - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases - - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 - - [ ] run do-all-signing script: - - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.torbrowser` - - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - - [ ] Update `staticiforme.torproject.org`: - - From `screen` session on `staticiforme.torproject.org`: - - [ ] Static update components : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` - - [ ] Enable update responses : `sudo -u tb-release ./deploy_update_responses-alpha.sh` - - [ ] Remove old release data from following places: - - **NOTE** : Skip this step if we need to hold on to older versions for some reason (for example, this is an Andoid or Desktop-only release, or if we need to hold back installers in favor of build-to-build updates if there are signing issues, etc) - - [ ] `/srv/cdn-master.torproject.org/htdocs/aus1/torbrowser` - - [ ] `/srv/dist-master.torproject.org/htdocs/torbrowser` - - [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` - - [ ] Publish APKs to Google Play: - - Log into https://play.google.com/apps/publish - - Select `Tor Browser (Alpha)` app - - Navigate to `Release > Production` and click `Create new release` button: - - Upload the `tor-browser-android-*.apk` APKs - - Update Release Name to Tor Browser version number - - Update Release Notes - - Next to 'Release notes', click `Copy from a previous release` - - Edit blog post url to point to most recent blog post - - Save, review, and configure rollout percentage - - [ ] 25% rollout when publishing a scheduled update - - [ ] 100% rollout when publishing a security-driven release - - [ ] Update rollout percentage to 100% after confirmed no major issues +### release signing +- **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long +- [ ] Assign this issue to the signer, one of: + - boklm + - richard +- [ ] On `$(STAGING_SERVER)`, ensure updated: + - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N) && git checkout tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N)` + - [ ] `tor-browser-build/tools/signing/set-config.hosts` + - `ssh_host_builder` : ssh hostname of machine with unsigned builds + - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) + - `ssh_host_linux_signer` : ssh hostname of linux signing machine + - [ ] `tor-browser-build/tools/signing/set-config.rcodesign-appstoreconnect` + - `appstoreconnect_api_key_path` : path to json file containing appstoreconnect api key infos + - [ ] `set-config.update-responses` + - `update_responses_repository_dir` : directory where you cloned `git@gitlab.torproject.org:tpo/applications/tor-browser-update-responses.git` + - [ ] `tor-browser-build/tools/signing/set-config.tbb-version` + - `tbb_version` : tor browser version string, same as `var/torbrowser_version` in `rbm.conf` (examples: `11.5a12`, `11.0.13`) + - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) + - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, run do-all-signing script: + - `cd tor-browser-build/tools/signing/` + - `./do-all-signing.torbrowser` +- **NOTE**: at this point the signed binaries should have been copied to `staticiforme` +- [ ] Update `staticiforme.torproject.org`: + - From `screen` session on `staticiforme.torproject.org`: + - [ ] Static update components : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` + - [ ] Enable update responses : `sudo -u tb-release ./deploy_update_responses-alpha.sh` + - [ ] Remove old release data from following places: + - **NOTE** : Skip this step if we need to hold on to older versions for some reason (for example, this is an Andoid or Desktop-only release, or if we need to hold back installers in favor of build-to-build updates if there are signing issues, etc) + - [ ] `/srv/cdn-master.torproject.org/htdocs/aus1/torbrowser` + - [ ] `/srv/dist-master.torproject.org/htdocs/torbrowser` + - [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` </details> @@ -262,55 +241,58 @@ popd <details> <summary>Publishing</summary> - ### website: https://gitlab.torproject.org/tpo/web/tpo.git - - [ ] `databags/versions.ini` : Update the downloads versions - - `torbrowser-stable/version` : sort of a catch-all for latest stable version - - `torbrowser-alpha/version` : sort of a catch-all for latest stable version - - `torbrowser-*-stable/version` : platform-specific stable versions - - `torbrowser-*-alpha/version` : platform-specific alpha versions - - `tor-stable`,`tor-alpha` : set by tor devs, do not touch - - [ ] Push to origin as new branch, open 'Draft :' MR - - [ ] Remove `Draft:` from MR once signed-packages are uploaded - - [ ] Merge - - [ ] Publish after CI passes and builds are published - - ### blog: https://gitlab.torproject.org/tpo/web/blog.git - - [ ] Duplicate previous Stable or Alpha release blog post as appropriate to new directory under `content/blog/new-release-tor-browser-$(TOR_BROWSER_VERSION)` and update with info on release : - - [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) - - [ ] Update Tor Browser version numbers - - [ ] Note any ESR rebase - - [ ] Link to any Firefox security updates from ESR upgrade - - [ ] Link to any Android-specific security backports - - [ ] Note any updates to : - - tor - - OpenSSL - - NoScript - - [ ] Convert ChangeLog-TBB.txt to markdown format used here by : - - `tor-browser-build/tools/changelog-format-blog-post` - - [ ] Push to origin as new branch, open `Draft:` MR - - [ ] Remove `Draft:` from MR once signed-packages are uploaded - - [ ] Merge - - [ ] Publish after CI passes and website has been updated - - ### tor-announce mailing list - - [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org - <details> - <summary>email template</summary> - - Subject: - New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) - - Body: - Hi everyone, - - Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: - - - $(BLOG_POST_URL) - - </details> - - - **(Optional)** Additional information: - - [ ] Link to any known issues +### Google Play: https://play.google.com/apps/publish +- [ ] Publish APKs to Google Play: + - Select `Tor Browser (Alpha)` app + - Navigate to `Release > Production` and click `Create new release` button: + - Upload the `tor-browser-android-*.apk` APKs + - Update Release Name to Tor Browser version number + - Update Release Notes + - Next to 'Release notes', click `Copy from a previous release` + - Edit blog post url to point to most recent blog post + - Save, review, and configure rollout percentage + - [ ] 25% rollout when publishing a scheduled update + - [ ] 100% rollout when publishing a security-driven release + - [ ] Update rollout percentage to 100% after confirmed no major issues + +### website: https://gitlab.torproject.org/tpo/web/tpo.git +- [ ] `databags/versions.ini` : Update the downloads versions + - `torbrowser-stable/version` : sort of a catch-all for latest stable version + - `torbrowser-alpha/version` : sort of a catch-all for latest stable version + - `torbrowser-*-stable/version` : platform-specific stable versions + - `torbrowser-*-alpha/version` : platform-specific alpha versions + - `tor-stable`,`tor-alpha` : set by tor devs, do not touch +- [ ] Push to origin as new branch, open 'Draft :' MR +- [ ] Remove `Draft:` from MR once signed-packages are accessible on https://dist.torproject.org +- [ ] Merge +- [ ] Publish after CI passes and builds are published + +### blog: https://gitlab.torproject.org/tpo/web/blog.git +- [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) + - [ ] Note any ESR update + - [ ] Note any updates to dependencies (OpenSSL, zlib, NoScript, tor, etc) + - [ ] Thank any users which have contributed patches + - [ ] **(Optional)** Draft any additional sections for new features which need testing, known issues, etc +- [ ] Push to origin as new branch, open `Draft:` MR +- [ ] Merge once signed-packages are accessible on https://dist.torproject.org +- [ ] Publish after CI passes and website has been updated + +### tor-announce mailing list +- [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org + - **Subject** + ``` + New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) + ``` + - **Body** + ``` + Hi everyone, + + Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: + - $(BLOG_POST_URL) + + Changelog: + # paste changleog as quote here + ``` </details> ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -27,29 +27,24 @@ </details> **NOTE** It is assumed that the `tor-browser` stable rebase and security backport tasks have been completed +**NOTE** This can/is often done in conjunction with the equivalent Mullvad Browser release prep issue <details> <summary>Building</summary> ### tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build.git -Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)` (and possibly more specific) branches +Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)` (and possibly more specific) branches. - [ ] Update `rbm.conf` - [ ] `var/torbrowser_version` : update to next version - [ ] `var/torbrowser_build` : update to `$(TOR_BROWSER_BUILD_N)` - [ ] ***(Desktop Only)***`var/torbrowser_incremental_from` : update to previous Desktop version + - **NOTE**: We try to build incrementals for the previous 3 desktop versions except in the case of a watershed update - **IMPORTANT**: Really *actually* make sure this is the previous Desktop version or else the `make torbrowser-incrementals-*` step will fail - [ ] Update Desktop-specific build configs - [ ] Update `projects/firefox/config` - [ ] `browser_build` : update to match `tor-browser` tag - [ ] ***(Optional)*** `var/firefox_platform_version` : update to latest `$(ESR_VERSION)` if rebased - - [ ] Update `projects/translation/config`: - - [ ] run `make list_translation_updates-release` to get updated hashes - - [ ] Update `projects/translation/config`: - - [ ] run `make list_translation_updates-alpha` to get updated hashes - - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch - - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch - - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - [ ] Update Android-specific build configs - [ ] Update `projects/geckoview/config` - [ ] `browser_build` : update to match `tor-browser` tag @@ -60,27 +55,32 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE **NOTE** we don't currently have any of our own patches for this project - [ ] `git_hash` : update to appropriate git commit associated with `$(ESR_VERSION)` - [ ] ***(Optional)*** Update `projects/firefox-android/config`: - - [ ] `fenix_version` : update to match alpha `firefox-android` build tag - - [ ] `browser_branch` : update to match alpha `firefox-android` build tag + - [ ] `fenix_version` : update to match alpha `firefox-android` build tag + - [ ] `browser_branch` : update to match alpha `firefox-android` build tag - [ ] Update allowed_addons.json by running (from `tor-browser-build` root): - `./tools/fetch_allowed_addons.py > projects/browser/allowed_addons.json` +- [ ] Update `projects/translation/config`: + - [ ] run `make list_translation_updates-release` to get updated hashes + - [ ] `steps/base-browser/git_hash` : update with `HEAD` commit of project's `base-browser` branch + - [ ] `steps/tor-browser/git_hash` : update with `HEAD` commit of project's `tor-browser` branch + - [ ] `steps/fenix/git_hash` : update with `HEAD` commit of project's `fenix-torbrowserstringsxml` branch - [ ] Update common build configs - [ ] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript - [ ] ***(Optional)*** If new version available, update `noscript` section of `input_files` in `projects/browser/config` - [ ] `URL` - [ ] `sha256sum` - [ ] Check for OpenSSL updates here : https://www.openssl.org/source/ - - [ ] ***(Optional)*** If new 1.X.Y version available, update `projects/openssl/config` - - [ ] `version` : update to next 1.X.Y version + - [ ] ***(Optional)*** If new 3.0.X version available, update `projects/openssl/config` + - [ ] `version` : update to next 3.0.X version - [ ] `input_files/sha256sum` : update to sha256 sum of source tarball - [ ] Check for zlib updates here: https://github.com/madler/zlib/releases - [ ] **(Optional)** If new tag available, update `projects/zlib/config` - [ ] `version` : update to next release tag - [ ] Check for tor updates here : https://gitlab.torproject.org/tpo/core/tor/-/tags - - [ ] ***(Optional)*** Update `projects/tor/config` + - [ ] ***(Optional)*** Update `projects/tor/config` - [ ] `version` : update to latest non `-alpha` tag (ping dgoulet or ahf if unsure) - [ ] Check for go updates here : https://go.dev/dl - - **NOTE** : Tor Browser Stable uses the latest of the *previous* Stable major series go version (apart from the transition phase from Tor Browser Alpha to Stable, in which case Tor Browser Stable may use the latest major series go version) + - **NOTE** : In general, Tor Browser Stable uses the latest of the *previous* Stable major series Go version, but there are sometimes exceptions. Check with the anti-censorship team before doing a major version update in case there is incompatibilities. - [ ] ***(Optional)*** Update `projects/go/config` - [ ] `version` : update go version - [ ] `input_files/sha256sum` for `go` : update sha256sum of archive (sha256 sums are displayed on the go download page) @@ -88,7 +88,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - [ ] ***(Optional)*** If new version is available: - [ ] Upload the downloaded `manual_$PIPELINEID.zip` file to `tb-build-02.torproject.org` - [ ] Deploy to `tb-builder`'s `public_html` directory: - - `sudo -u tb-builder cp manual_$PIPELINEID.zip ~/../tb-builder/public_html/.` + - `sudo -u tb-builder cp manual_$PIPELINEID.zip ~tb-builder/public_html/.` - [ ] Update `projects/manual/config`: - [ ] Change the `version` to `$PIPELINEID` - [ ] Update `sha256sum` in the `input_files` section @@ -108,25 +108,25 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - E.g., `tools/fetch-changelogs.py 41028 --date 'December 19 2023' --firefox 115.6.0esr --tor 0.4.8.10 --no-script 11.4.29 --zlib 1.3 --go 1.21.5 --openssl 3.0.12` - `--date $date` is optional, if omitted it will be the date on which you run the command - [ ] Copy the output of the script to the beginning of `ChangeLog-TBB.txt` and adjust its output - - [ ] Open MR with above changes, using the template for release preparations - - [ ] Merge - - [ ] Sign+Tag - - **NOTE** this must be done by one of: - - boklm - - dan - - ma1 - - pierov - - richard - - [ ] Run: `make torbrowser-signtag-release` - - [ ] Push tag to `upstream` - - [ ] Build on at least one of: - - Run `make torbrowser-release && make torbrowser-incrementals-release` +- [ ] Open MR with above changes, using the template for release preparations +- [ ] Merge +- [ ] Sign+Tag + - **NOTE** this must be done by one of: + - boklm + - dan + - ma1 + - pierov + - richard + - [ ] Run: `make torbrowser-signtag-release` + - [ ] Push tag to `upstream` +- [ ] Build the tag: + - Run `make torbrowser-release && make torbrowser-incrementals-release` - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - **NOTE** this requires a devmole authentication token - Run `make torbrowser-kick-devmole-build` - - [ ] Ensure builders have matching builds +- [ ] Ensure builders have matching builds </details> @@ -134,49 +134,44 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE <summary>Communications</summary> ### notify stakeholders +- [ ] **(Once builds confirmed matching)** Email tor-qa mailing list with release information + - [ ] tor-qa: tor-qa(a)lists.torproject.org + - **Subject** + ``` + Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) + ``` + - **Body** + ``` + Hello, - <details> - <summary>email template</summary> - - Subject: - Tor Browser $(TOR_BROWSER_VERION) (Android, Windows, macOS, Linux) - - Body: - Hello All, - - Unsigned Tor Browser $(TOR_BROWSER_VERSION) release candidate builds are now available for testing: - - - https://tb-build-05.torproject.org/~$(BUILDER)/builds/release/unsigned/$(TO… - - The full changelog can be found here: + Unsigned Tor Browser $(TOR_BROWSER_VERSION) release candidate builds are now available for testing: - - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/$(T… + - https://tb-build-02.torproject.org/~$(BUILDER)/builds/release/unsigned/$(TO… - </details> + The full changelog can be found here: -- [ ] Email tor-qa mailing list: tor-qa(a)lists.torproject.org - - ***(Optional)*** Additional information: - - [ ] Note any new functionality which needs testing - - [ ] Link to any known issues + - https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/raw/$(TB… + ``` - [ ] Email packagers: - - Recipients: - - Tails dev mailing list: tails-dev(a)boum.org - - Guardian Project: nathan(a)guardianproject.info - - torbrowser-launcher: micah(a)micahflee.com - - FreeBSD port: freebsd(a)sysctl.cz  - - OpenBSD port: caspar(a)schutijser.com  - - [ ] ***(Optional)*** Note any changes which may affect packaging/downstream integration + - [ ] Tails dev mailing list: tails-dev(a)boum.org + - [ ] Guardian Project: nathan(a)guardianproject.info + - [ ] FreeBSD port: freebsd(a)sysctl.cz  + - [ ] OpenBSD port: caspar(a)schutijser.com  + - [ ] Note any changes which may affect packaging/downstream integration </details> <details> <summary>Signing</summary> -### signing +### release signing - **NOTE** : In practice, it's most efficient to have the blog post and website updates ready to merge, since signing doesn't take very long +- [ ] Assign this issue to the signer, one of: + - boklm + - richard - [ ] On `$(STAGING_SERVER)`, ensure updated: - [ ] `tor-browser-build` is on the right commit: `git tag -v tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N) && git checkout tbb-$(TOR_BROWSER_VERSION)-$(TOR_BROWSER_BUILD_N)` - - [ ] `tor-browser-build/tools/signing/set-config.hosts` + - [ ] `tor-browser-build/tools/signing/set-config.hosts` - `ssh_host_builder` : ssh hostname of machine with unsigned builds - **NOTE** : `tor-browser-build` is expected to be in the `$HOME` directory) - `ssh_host_linux_signer` : ssh hostname of linux signing machine @@ -189,9 +184,9 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - `tbb_version_build` : the tor-browser-build build number (if `var/torbrowser_build` in `rbm.conf` is `buildN` then this value is `N`) - `tbb_version_type` : either `alpha` for alpha releases or `release` for stable releases - [ ] On `$(STAGING_SERVER)` in a separate `screen` session, ensure tor daemon is running with SOCKS5 proxy on the default port 9050 -- [ ] run do-all-signing script: - - `cd tor-browser-build/tools/signing/` - - `./do-all-signing.torbrowser` +- [ ] On `$(STAGING_SERVER)` in a separate `screen` session, run do-all-signing script: + - `cd tor-browser-build/tools/signing/` + - `./do-all-signing.torbrowser` - **NOTE**: at this point the signed binaries should have been copied to `staticiforme` - [ ] Update `staticiforme.torproject.org`: - From `screen` session on `staticiforme.torproject.org`: @@ -201,20 +196,7 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - **NOTE** : Skip this step if we need to hold on to older versions for some reason (for example, this is an Andoid or Desktop-only release, or if we need to hold back installers in favor of build-to-build updates if there are signing issues, etc) - [ ] `/srv/cdn-master.torproject.org/htdocs/aus1/torbrowser` - [ ] `/srv/dist-master.torproject.org/htdocs/torbrowser` -- [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` -- [ ] Publish APKs to Google Play: - - Log into https://play.google.com/apps/publish - - Select `Tor Browser` app - - Navigate to `Release > Production` and click `Create new release` button: - - Upload the `tor-browser-android-*.apk` APKs - - Update Release Name to Tor Browser version number - - Update Release Notes - - Next to 'Release notes', click `Copy from a previous release` - - Edit blog post url to point to most recent blog post - - Save, review, and configure rollout percentage - - [ ] 25% rollout when publishing a scheduled update - - [ ] 100% rollout when publishing a security-driven release - - [ ] Update rollout percentage to 100% after confirmed no major issues + - [ ] Static update components (again) : `static-update-component cdn.torproject.org && static-update-component dist.torproject.org` </details> @@ -223,33 +205,51 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE <details> <summary>Check whether the .exe files got properly signed and timestamped</summary> - ``` - # Point OSSLSIGNCODE to your osslsigncode binary - pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION - OSSLSIGNCODE=/path/to/osslsigncode - ../../../tools/authenticode_check.sh - popd - ``` + +```bash +# Point OSSLSIGNCODE to your osslsigncode binary +pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION +OSSLSIGNCODE=/path/to/osslsigncode +../../../tools/authenticode_check.sh +popd +``` + </details> <details> <summary>Check whether the MAR files got properly signed</summary> - ``` - # Point NSSDB to your nssdb containing the mar signing certificate - # Point SIGNMAR to your signmar binary - # Point LD_LIBRARY_PATH to your mar-tools directory - pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION - NSSDB=/path/to/nssdb - SIGNMAR=/path/to/mar-tools/signmar - LD_LIBRARY_PATH=/path/to/mar-tools/ - ../../../tools/marsigning_check.sh - popd - ``` + +```bash +# Point NSSDB to your nssdb containing the mar signing certificate +# Point SIGNMAR to your signmar binary +# Point LD_LIBRARY_PATH to your mar-tools directory +pushd tor-browser-build/${channel}/signed/$TORBROWSER_VERSION +NSSDB=/path/to/nssdb +SIGNMAR=/path/to/mar-tools/signmar +LD_LIBRARY_PATH=/path/to/mar-tools/ +../../../tools/marsigning_check.sh +popd +``` + </details> </details> <details> <summary>Publishing</summary> +### Google Play: https://play.google.com/apps/publish +- [ ] Publish APKs to Google Play: + - Select `Tor Browser` app + - Navigate to `Release > Production` and click `Create new release` button: + - Upload the `tor-browser-android-*.apk` APKs + - Update Release Name to Tor Browser version number + - Update Release Notes + - Next to 'Release notes', click `Copy from a previous release` + - Edit blog post url to point to most recent blog post + - Save, review, and configure rollout percentage + - [ ] 25% rollout when publishing a scheduled update + - [ ] 100% rollout when publishing a security-driven release + - [ ] Update rollout percentage to 100% after confirmed no major issues + ### website: https://gitlab.torproject.org/tpo/web/tpo.git - [ ] `databags/versions.ini` : Update the downloads versions - `torbrowser-stable/version` : sort of a catch-all for latest stable version @@ -258,49 +258,37 @@ Tor Browser Stable lives in the various `maint-$(TOR_BROWSER_MAJOR).$(TOR_BROWSE - `torbrowser-*-alpha/version` : platform-specific alpha versions - `tor-stable`,`tor-alpha` : set by tor devs, do not touch - [ ] Push to origin as new branch, open 'Draft :' MR -- [ ] Remove `Draft:` from MR once signed-packages are uploaded +- [ ] Remove `Draft:` from MR once signed-packages are accessible on https://dist.torproject.org - [ ] Merge - [ ] Publish after CI passes and builds are published ### blog: https://gitlab.torproject.org/tpo/web/blog.git - -- [ ] Duplicate previous Stable or Alpha release blog post as appropriate to new directory under `content/blog/new-release-tor-browser-$(TOR_BROWSER_VERSION)` and update with info on release : - - [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) - - [ ] Update Tor Browser version numbers - - [ ] Note any ESR rebase - - [ ] Link to any Firefox security updates from ESR upgrade - - [ ] Link to any Android-specific security backports - - [ ] Note any updates to : - - tor - - OpenSSL - - NoScript - - [ ] Convert ChangeLog.txt to markdown format used here by : - - `tor-browser-build/tools/changelog-format-blog-post` +- [ ] Run `tools/signing/create-blog-post` which should create the new blog post from a template (edit set-config.blog to set you local blog directory) + - [ ] Note any ESR update + - [ ] Note any updates to dependencies (OpenSSL, zlib, NoScript, tor, etc) + - [ ] Thank any users which have contributed patches - [ ] Push to origin as new branch, open `Draft:` MR -- [ ] Remove `Draft:` from MR once signed-packages are uploaded -- [ ] Merge +- [ ] Merge once signed-packages are accessible on https://dist.torproject.org - [ ] Publish after CI passes and website has been updated ### tor-announce mailing list - <details> - <summary>email template</summary> - - Subject: - New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) - - Body: - Hi everyone, - - Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: - - - $(BLOG_POST_URL) +- [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org + - **Subject** + ``` + New Release: Tor Browser $(TOR_BROWSER_VERSION) (Android, Windows, macOS, Linux) + ``` + - **Body** + ``` + Hi everyone, - </details> + Tor Browser $(TOR_BROWSER_VERSION) has now been published for all platforms. For details please see our blog post: + - $(BLOG_POST_URL) -- [ ] Email tor-announce mailing list: tor-announce(a)lists.torproject.org - - **(Optional)** Additional information: - - [ ] Link to any known issues + Changelog: + # paste changleog as quote here + ``` </details> /label ~"Release Prep" + View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Disable features and functionality
by Pier Angelo Vendrame (＠pierov) 21 Feb '24

21 Feb '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 16ff4ed5 by clairehurst at 2024-02-21T07:36:28+00:00 fixup! Disable features and functionality - - - - - 5 changed files: - fenix/app/src/beta/res/xml/shortcuts.xml - fenix/app/src/debug/res/xml/shortcuts.xml - fenix/app/src/main/res/xml/shortcuts.xml - fenix/app/src/nightly/res/xml/shortcuts.xml - fenix/app/src/release/res/xml/shortcuts.xml Changes: ===================================== fenix/app/src/beta/res/xml/shortcuts.xml ===================================== @@ -25,15 +25,15 @@    - <shortcut - android:shortcutId="open_new_private_tab" - android:enabled="true" - android:icon="@drawable/ic_static_shortcut_private_tab" - android:shortcutShortLabel="@string/home_screen_shortcut_open_new_private_tab_2" - android:shortcutLongLabel="@string/home_screen_shortcut_open_new_private_tab_2"> - <intent - android:action="org.mozilla.fenix.OPEN_PRIVATE_TAB" - android:targetPackage="org.torproject.torbrowser_alpha" - android:targetClass="org.mozilla.fenix.IntentReceiverActivity" /> - </shortcut> + + + + + + + + + + + </shortcuts> ===================================== fenix/app/src/debug/res/xml/shortcuts.xml ===================================== @@ -26,15 +26,15 @@    - <shortcut - android:shortcutId="open_new_private_tab" - android:enabled="true" - android:icon="@drawable/ic_static_shortcut_private_tab" - android:shortcutShortLabel="@string/home_screen_shortcut_open_new_private_tab_2" - android:shortcutLongLabel="@string/home_screen_shortcut_open_new_private_tab_2"> - <intent - android:action="org.mozilla.fenix.OPEN_PRIVATE_TAB" - android:targetPackage="org.torproject.torbrowser_debug" - android:targetClass="org.mozilla.fenix.IntentReceiverActivity" /> - </shortcut> + + + + + + + + + + + </shortcuts> ===================================== fenix/app/src/main/res/xml/shortcuts.xml ===================================== @@ -26,15 +26,15 @@    - <shortcut - android:shortcutId="open_new_private_tab" - android:enabled="true" - android:icon="@drawable/ic_static_shortcut_private_tab" - android:shortcutShortLabel="@string/home_screen_shortcut_open_new_private_tab_2" - android:shortcutLongLabel="@string/home_screen_shortcut_open_new_private_tab_2"> - <intent - android:action="org.mozilla.fenix.OPEN_PRIVATE_TAB" - android:targetPackage="org.torproject.torbrowser_dev" - android:targetClass="org.mozilla.fenix.IntentReceiverActivity" /> - </shortcut> + + + + + + + + + + + </shortcuts> ===================================== fenix/app/src/nightly/res/xml/shortcuts.xml ===================================== @@ -26,15 +26,15 @@    - <shortcut - android:shortcutId="open_new_private_tab" - android:enabled="true" - android:icon="@drawable/ic_static_shortcut_private_tab" - android:shortcutShortLabel="@string/home_screen_shortcut_open_new_private_tab_2" - android:shortcutLongLabel="@string/home_screen_shortcut_open_new_private_tab_2"> - <intent - android:action="org.mozilla.fenix.OPEN_PRIVATE_TAB" - android:targetPackage="org.torproject.torbrowser_nightly" - android:targetClass="org.mozilla.fenix.IntentReceiverActivity" /> - </shortcut> + + + + + + + + + + + </shortcuts> ===================================== fenix/app/src/release/res/xml/shortcuts.xml ===================================== @@ -25,15 +25,15 @@    - <shortcut - android:shortcutId="open_new_private_tab" - android:enabled="true" - android:icon="@drawable/ic_static_shortcut_private_tab" - android:shortcutShortLabel="@string/home_screen_shortcut_open_new_private_tab_2" - android:shortcutLongLabel="@string/home_screen_shortcut_open_new_private_tab_2"> - <intent - android:action="org.mozilla.fenix.OPEN_PRIVATE_TAB" - android:targetPackage="org.torproject.torbrowser" - android:targetClass="org.mozilla.fenix.IntentReceiverActivity" /> - </shortcut> + + + + + + + + + + + </shortcuts> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/16f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/16f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Disable features and functionality
by Pier Angelo Vendrame (＠pierov) 21 Feb '24

21 Feb '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 5cdf04d8 by Dan Ballard at 2024-02-14T15:01:27-08:00 fixup! Disable features and functionality bug 42407: lock task affinity of HomeActivity to block potential on app phishing - - - - - 1 changed file: - fenix/app/src/main/AndroidManifest.xml Changes: ===================================== fenix/app/src/main/AndroidManifest.xml ===================================== @@ -96,6 +96,7 @@ android:exported="true" android:configChanges="keyboard|keyboardHidden|mcc|mnc|orientation|screenSize|layoutDirection|smallestScreenSize|screenLayout" android:launchMode="singleTask" + android:taskAffinity="" android:resizeableActivity="true" android:supportsPictureInPicture="true" android:windowSoftInputMode="adjustResize"> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/5cd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/5cd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.5-1] fixup! MB 1: Mullvad Browser branding
by Pier Angelo Vendrame (＠pierov) 20 Feb '24

20 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: daa6f9fe by Pier Angelo Vendrame at 2024-02-20T20:35:23+01:00 fixup! MB 1: Mullvad Browser branding Bug 42398: Include Alpha and Nightly in MOZ_APP_DISPLAYNAME. - - - - - 2 changed files: - browser/branding/mb-alpha/configure.sh - browser/branding/mb-nightly/configure.sh Changes: ===================================== browser/branding/mb-alpha/configure.sh ===================================== @@ -2,4 +2,4 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -MOZ_APP_DISPLAYNAME="Mullvad Browser" +MOZ_APP_DISPLAYNAME="Mullvad Browser Alpha" ===================================== browser/branding/mb-nightly/configure.sh ===================================== @@ -2,4 +2,4 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -MOZ_APP_DISPLAYNAME="Mullvad Browser" +MOZ_APP_DISPLAYNAME="Mullvad Browser Nightly" View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/daa… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/daa… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-115.8.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 20 Feb '24

20 Feb '24

Pier Angelo Vendrame pushed new tag mullvad-browser-115.8.0esr-13.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.5-1] 19 commits: MB 38: Mullvad Browser configuration
by richard (＠richard) 20 Feb '24

20 Feb '24

richard pushed to branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: bbc14876 by Pier Angelo Vendrame at 2024-02-13T15:46:46+01:00 MB 38: Mullvad Browser configuration - - - - - 6b55ddd7 by Pier Angelo Vendrame at 2024-02-13T15:46:48+01:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - a6dfd571 by Pier Angelo Vendrame at 2024-02-13T15:46:49+01:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - d2096615 by Pier Angelo Vendrame at 2024-02-13T15:46:49+01:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - 9c5554d3 by Pier Angelo Vendrame at 2024-02-13T15:46:49+01:00 MB 37: Customization for the about dialog - - - - - 9e29111f by Henry Wilkes at 2024-02-13T15:46:50+01:00 MB 39: Add home page about:mullvad-browser - - - - - 183082a9 by hackademix at 2024-02-13T15:46:50+01:00 MB 97: Remove UI cues to install new extensions. - - - - - 40d1c644 by hackademix at 2024-02-13T15:46:50+01:00 MB 47: uBlock Origin customization - - - - - 3fdae332 by Pier Angelo Vendrame at 2024-02-13T15:46:51+01:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - 13e371aa by Pier Angelo Vendrame at 2024-02-13T15:46:51+01:00 MB 87: Disable the default browser box on Windows and Linux Windows and Linux will be distributed only as portable apps at the beginning, so they should not be settable as default browsers. We will need to improve the logic once we decide to ship system-wide installers, too. - - - - - 7418154f by Pier Angelo Vendrame at 2024-02-13T15:46:51+01:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - fb662c89 by Pier Angelo Vendrame at 2024-02-13T15:46:52+01:00 fixup! MB 112: Updater customization for Mullvad Browser MB 200: Enable system installs for Mullvad Browser Customize the post update executable name, to avoid any confusion with Mozilla's helper.exe, since we intend using a much simpler post update binary. - - - - - 8346f9be by Nicolas Vigier at 2024-02-13T15:46:52+01:00 MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - 146b9349 by Pier Angelo Vendrame at 2024-02-13T15:46:52+01:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - afb9a182 by Pier Angelo Vendrame at 2024-02-13T15:46:52+01:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - 134937fa by hackademix at 2024-02-13T15:46:53+01:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - 11cb17c9 by Richard Pospesel at 2024-02-13T15:46:53+01:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - e7cc72c0 by rui hildt at 2024-02-13T15:46:53+01:00 MB 213: Customize the search engines list - - - - - 939faf11 by hackademix at 2024-02-13T15:46:54+01:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - 30 changed files: - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png - + browser/branding/mb-alpha/content/aboutDialog.css - + browser/branding/mb-alpha/content/firefox-wordmark.svg The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41085: Fix typos in generated cdn.stagemole.eu URL build hash location
by richard (＠richard) 20 Feb '24

20 Feb '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: c838ed34 by Richard Pospesel at 2024-02-20T12:55:04+00:00 Bug 41085: Fix typos in generated cdn.stagemole.eu URL build hash location (cherry picked from commit 6778ba32945e9c4a49d1bbbb93a9e85db0222939) - - - - - 1 changed file: - projects/release/kick_devmole_build Changes: ===================================== projects/release/kick_devmole_build ===================================== @@ -39,4 +39,4 @@ fi curl -X POST "https://drone-server.devmole.eu/api/repos/mullvad/browser-build/builds?bran…" -H "Authorization: Bearer ${AUTH_TOKEN}" -H "Accept: application/json" echo -echo Hashes will appear here: https://cdn.stagemole.eu/hashes/[% c("var/projectname") %]/[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %] +echo Hashes will appear here: https://cdn.stagemole.eu/browser/hashes/[% c("var/projectname") %]/[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]/ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41085: Fix typos in generated cdn.stagemole.eu URL build hash location
by richard (＠richard) 20 Feb '24

20 Feb '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 6778ba32 by Richard Pospesel at 2024-02-20T12:52:59+00:00 Bug 41085: Fix typos in generated cdn.stagemole.eu URL build hash location - - - - - 1 changed file: - projects/release/kick_devmole_build Changes: ===================================== projects/release/kick_devmole_build ===================================== @@ -39,4 +39,4 @@ fi curl -X POST "https://drone-server.devmole.eu/api/repos/mullvad/browser-build/builds?bran…" -H "Authorization: Bearer ${AUTH_TOKEN}" -H "Accept: application/json" echo -echo Hashes will appear here: https://cdn.stagemole.eu/hashes/[% c("var/projectname") %]/[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %] +echo Hashes will appear here: https://cdn.stagemole.eu/browser/hashes/[% c("var/projectname") %]/[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]/ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] release: new version, 13.0.10
by richard (＠richard) 20 Feb '24

20 Feb '24

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: d0f551a3 by Richard Pospesel at 2024-02-20T12:29:05+00:00 release: new version, 13.0.10 - - - - - 30 changed files: - update_3/release/.htaccess - + update_3/release/13.0.10-linux-i686-ALL.xml - + update_3/release/13.0.10-linux-x86_64-ALL.xml - + update_3/release/13.0.10-macos-ALL.xml - + update_3/release/13.0.10-windows-i686-ALL.xml - + update_3/release/13.0.10-windows-x86_64-ALL.xml - − update_3/release/13.0.6-13.0.9-linux-i686-ALL.xml - − update_3/release/13.0.6-13.0.9-linux-x86_64-ALL.xml - − update_3/release/13.0.6-13.0.9-macos-ALL.xml - − update_3/release/13.0.6-13.0.9-windows-i686-ALL.xml - − update_3/release/13.0.6-13.0.9-windows-x86_64-ALL.xml - + update_3/release/13.0.7-13.0.10-linux-i686-ALL.xml - + update_3/release/13.0.7-13.0.10-linux-x86_64-ALL.xml - + update_3/release/13.0.7-13.0.10-macos-ALL.xml - + update_3/release/13.0.7-13.0.10-windows-i686-ALL.xml - + update_3/release/13.0.7-13.0.10-windows-x86_64-ALL.xml - − update_3/release/13.0.7-13.0.9-linux-i686-ALL.xml - − update_3/release/13.0.7-13.0.9-linux-x86_64-ALL.xml - − update_3/release/13.0.7-13.0.9-macos-ALL.xml - − update_3/release/13.0.7-13.0.9-windows-i686-ALL.xml - − update_3/release/13.0.7-13.0.9-windows-x86_64-ALL.xml - + update_3/release/13.0.8-13.0.10-linux-i686-ALL.xml - + update_3/release/13.0.8-13.0.10-linux-x86_64-ALL.xml - + update_3/release/13.0.8-13.0.10-macos-ALL.xml - + update_3/release/13.0.8-13.0.10-windows-i686-ALL.xml - + update_3/release/13.0.8-13.0.10-windows-x86_64-ALL.xml - − update_3/release/13.0.8-13.0.9-linux-i686-ALL.xml - − update_3/release/13.0.8-13.0.9-linux-x86_64-ALL.xml - − update_3/release/13.0.8-13.0.9-macos-ALL.xml - − update_3/release/13.0.8-13.0.9-windows-i686-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41084: $app_bundle is missing the final .app
by Pier Angelo Vendrame (＠pierov) 20 Feb '24

20 Feb '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 97837a74 by Pier Angelo Vendrame at 2024-02-20T09:16:21+01:00 Bug 41084: $app_bundle is missing the final .app Fixes a bug introduced while resolving #40569. - - - - - 1 changed file: - projects/firefox/build Changes: ===================================== projects/firefox/build ===================================== @@ -187,7 +187,7 @@ echo "Starting ./mach build $(date)" [% IF c("var/base-browser") -%] mv "$distdir/Firefox.app" "$distdir/[% c('var/display_name') %].app" [% END -%] - app_bundle="[% c('var/display_name') %]" + app_bundle="[% c('var/display_name') %].app" # Remove firefox-bin (we don't use it, see ticket #10126) rm -f "$distdir/$app_bundle/Contents/MacOS/[% c('var/exe_name') %]-bin" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Install RBM::CaptureExec
by boklm (＠boklm) 16 Feb '24

16 Feb '24

boklm pushed to branch main at The Tor Project / Applications / RBM Commits: 361bc547 by Petr Písař at 2024-02-15T15:58:14+01:00 Install RBM::CaptureExec Commit efd874abee2d4afe652feb6c79c1d929f70d136b (Bug 40072: Move capture_exec to a separate module) added RBM::CaptureExec module, but forgot to install it when invoking "make install". This patch fixes it. - - - - - 1 changed file: - Makefile Changes: ===================================== Makefile ===================================== @@ -3,7 +3,7 @@ VERSION=0.4 PROJECTNAME=rbm BINFILES=rbm PERL_MODULE_MAIN=lib/RBM.pm -PERL_MODULES=lib/RBM/DefaultConfig.pm +PERL_MODULES=lib/RBM/CaptureExec.pm lib/RBM/DefaultConfig.pm sysconfdir=/etc bindir=/usr/bin View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/361bc547cf50020… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/361bc547cf50020… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.5-1] Bug 42378: Apply spoof English to the default detail summary.
by Pier Angelo Vendrame (＠pierov) 15 Feb '24

15 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: bdfc4f4c by Pier Angelo Vendrame at 2024-02-15T12:53:54+00:00 Bug 42378: Apply spoof English to the default detail summary. - - - - - 1 changed file: - dom/html/HTMLDetailsElement.cpp Changes: ===================================== dom/html/HTMLDetailsElement.cpp ===================================== @@ -105,8 +105,9 @@ void HTMLDetailsElement::SetupShadowTree() { } nsAutoString defaultSummaryText; - nsContentUtils::GetLocalizedString(nsContentUtils::eFORMS_PROPERTIES, - "DefaultSummary", defaultSummaryText); + nsContentUtils::GetMaybeLocalizedString(nsContentUtils::eFORMS_PROPERTIES, + "DefaultSummary", OwnerDoc(), + defaultSummaryText); RefPtr<nsTextNode> description = new (nim) nsTextNode(nim); description->SetText(defaultSummaryText, kNotify); summary->AppendChildTo(description, kNotify, IgnoreErrors()); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bdfc4f4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bdfc4f4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.0.10-build1
by richard (＠richard) 15 Feb '24

15 Feb '24

richard pushed new tag tbb-13.0.10-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.0-1-build13
by richard (＠richard) 15 Feb '24

15 Feb '24

richard pushed new tag firefox-android-115.2.1-13.0-1-build13 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41062: Update Tor Browser changelog
by richard (＠richard) 15 Feb '24

15 Feb '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: bd8de109 by Richard Pospesel at 2024-02-15T10:50:29+00:00 Bug 41062: Update Tor Browser changelog - - - - - 1 changed file: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -2,14 +2,17 @@ Tor Browser 13.0.10 - February 20 2024 * All Platforms * Updated OpenSSL to 3.0.13 * Updated zlib to 1.3.1 + * Updated Snowflake to 2.9.0 * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] * Bug 42411: Rebase Tor Browser stable onto 115.8.0esr [tor-browser] + * Bug 41079: Bump version of Snowflake to v2.9.0 [tor-browser-build] * Windows + macOS + Linux * Updated Firefox to 115.8.0esr * Bug 42338: Changing circuit programmatically in Tor Browser not working anymore! [tor-browser] * Android * Updated GeckoView to 115.8.0esr * Bug 42402: Remove Android YEC strings [tor-browser] + * Bug 42416: Backport Android security fixes from Firefox 123 [tor-browser] * Linux * Bug 42293: Updater is disabled when tor-browser is run by torbrowser-launcher flatpak [tor-browser] * Build System @@ -19,6 +22,7 @@ Tor Browser 13.0.10 - February 20 2024 * Bug 40067: Use --no-verbose wget option when not running in a terminal [rbm] * Bug 40068: Switch from IO::CaptureOutput to Capture::Tiny [rbm] * Bug 40069: Make stdout and stderr utf8 [rbm] + * Bug 40072: Move capture_exec to a separate module [rbm] Tor Browser 13.5a4 - January 31 2024 * All Platforms View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser-update-responses][main] release: new version, 13.0.10
by richard (＠richard) 15 Feb '24

15 Feb '24

richard pushed to branch main at The Tor Project / Applications / mullvad-browser-update-responses Commits: 9537a9d0 by Richard Pospesel at 2024-02-15T11:40:04+00:00 release: new version, 13.0.10 - - - - - 29 changed files: - update_1/release/.htaccess - + update_1/release/13.0.10-linux-x86_64-ALL.xml - + update_1/release/13.0.10-macos-ALL.xml - + update_1/release/13.0.10-windows-x86_64-ALL.xml - − update_1/release/13.0.4-13.0.9-linux-x86_64-ALL.xml - − update_1/release/13.0.4-13.0.9-macos-ALL.xml - − update_1/release/13.0.4-13.0.9-windows-x86_64-ALL.xml - + update_1/release/13.0.6-13.0.10-linux-x86_64-ALL.xml - + update_1/release/13.0.6-13.0.10-macos-ALL.xml - + update_1/release/13.0.6-13.0.10-windows-x86_64-ALL.xml - − update_1/release/13.0.6-13.0.9-linux-x86_64-ALL.xml - − update_1/release/13.0.6-13.0.9-macos-ALL.xml - − update_1/release/13.0.6-13.0.9-windows-x86_64-ALL.xml - + update_1/release/13.0.7-13.0.10-linux-x86_64-ALL.xml - + update_1/release/13.0.7-13.0.10-macos-ALL.xml - + update_1/release/13.0.7-13.0.10-windows-x86_64-ALL.xml - − update_1/release/13.0.7-13.0.9-linux-x86_64-ALL.xml - − update_1/release/13.0.7-13.0.9-macos-ALL.xml - − update_1/release/13.0.7-13.0.9-windows-x86_64-ALL.xml - + update_1/release/13.0.9-13.0.10-linux-x86_64-ALL.xml - + update_1/release/13.0.9-13.0.10-macos-ALL.xml - + update_1/release/13.0.9-13.0.10-windows-x86_64-ALL.xml - − update_1/release/13.0.9-linux-x86_64-ALL.xml - − update_1/release/13.0.9-macos-ALL.xml - − update_1/release/13.0.9-windows-x86_64-ALL.xml - update_1/release/download-linux-x86_64.json - update_1/release/download-macos.json - update_1/release/download-windows-x86_64.json - update_1/release/downloads.json Changes: ===================================== update_1/release/.htaccess ===================================== @@ -1,22 +1,22 @@ RewriteEngine On -RewriteRule ^[^/]+/13.0.9/ no-update.xml [last] -RewriteRule ^Linux_x86_64-gcc3/13.0.4/ALL 13.0.4-13.0.9-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/13.0.6/ALL 13.0.6-13.0.9-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/13.0.7/ALL 13.0.7-13.0.9-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/[^/]+/ALL 13.0.9-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/ 13.0.9-linux-x86_64-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/13.0.4/ALL 13.0.4-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/13.0.6/ALL 13.0.6-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/13.0.7/ALL 13.0.7-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/[^/]+/ALL 13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/ 13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/13.0.4/ALL 13.0.4-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/13.0.6/ALL 13.0.6-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/13.0.7/ALL 13.0.7-13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/[^/]+/ALL 13.0.9-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/ 13.0.9-macos-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.4/ALL 13.0.4-13.0.9-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.6/ALL 13.0.6-13.0.9-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.7/ALL 13.0.7-13.0.9-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/[^/]+/ALL 13.0.9-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/ 13.0.9-windows-x86_64-ALL.xml [last] +RewriteRule ^[^/]+/13.0.10/ no-update.xml [last] +RewriteRule ^Linux_x86_64-gcc3/13.0.6/ALL 13.0.6-13.0.10-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/13.0.7/ALL 13.0.7-13.0.10-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/13.0.9/ALL 13.0.9-13.0.10-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/[^/]+/ALL 13.0.10-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/ 13.0.10-linux-x86_64-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/13.0.6/ALL 13.0.6-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/13.0.7/ALL 13.0.7-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/13.0.9/ALL 13.0.9-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/[^/]+/ALL 13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/ 13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/13.0.6/ALL 13.0.6-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/13.0.7/ALL 13.0.7-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/13.0.9/ALL 13.0.9-13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/[^/]+/ALL 13.0.10-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/ 13.0.10-macos-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.6/ALL 13.0.6-13.0.10-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.7/ALL 13.0.7-13.0.10-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/13.0.9/ALL 13.0.9-13.0.10-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/[^/]+/ALL 13.0.10-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/ 13.0.10-windows-x86_64-ALL.xml [last] ===================================== update_1/release/13.0.10-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…" hashFunction="SHA512" hashValue="94ec6248cc9ac47c36527fe9c4be8af5793f9b94e8b7508af0999d8fa872c87d002a38349866e0de8e806f6df8c836b7f258572d0455634ec4df5561ac42214a" size="107245515" type="complete"></patch></update></updates> ===================================== update_1/release/13.0.10-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10_ALL.m…" hashFunction="SHA512" hashValue="30de8b89fb7c67130225b823d59e813949ca55c58e59b4da389394835436f69125e2be6ac5aa8da4d915a7dc0fa7c0a1ede5f0dae104cc0400bbca306f76add4" size="115293951" type="complete"></patch></update></updates> ===================================== update_1/release/13.0.10-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-13.0…" hashFunction="SHA512" hashValue="bb71ce5cbb6e7a11e1e12e165dae922c0bc600324577b4b7e3af59247764db7ca4a2a8af0d9560b925b6bc5a0b7bba9d3a4f46598ec7d291ab4638239e38543e" size="89214292" type="complete"></patch></update></updates> ===================================== update_1/release/13.0.4-13.0.9-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9_…" hashFunction="SHA512" hashValue="18fdf0900b6e5e58f833828e2a854b44e997dd6a752a1fa38d29acf69ca6d88e39e5e8f1811ffb9a0ea5240afa32efa8459c25ddd1d7e57090b8ffdfa7a112ad" size="107222791" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64--13.0.4…" hashFunction="SHA512" hashValue="a93457c9f91ac3277f0120e88cfe99f133b45f4db6d5d8bebb3a63f9fa3980afcb9dc995374574db32a47b46fa32be2c416d20f758b392880700bc6d147c60a8" size="11307785" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.4-13.0.9-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9_ALL.mar" hashFunction="SHA512" hashValue="2f2fb000e87b425a8df5b25160354eab158a86d7b20b0cb957a9e6f33e9d54a02873b118bc4ad007886e3361ed85a3c3b3f397a36ebe748b91abaf9d72a28887" size="115259351" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos--13.0.4-13.0.9…" hashFunction="SHA512" hashValue="fabe36cb82c4393ad2cbe7d28315c4d75667aa4cc5f073d9da5b61d109d54cd9721309e2f5a9109b5dca57eb3af31271daee0caf28c80aa268b1b815f5b4efda" size="76833715" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.4-13.0.9-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-13.0.…" hashFunction="SHA512" hashValue="6b955bb9b9f28f34b0199eaad15dcbc7bc28a62ed318ae95b2f162dba2f45a4ca877a47c86d892f2ef859a69f7188a1ab2c08ec9861b7682b214214014369282" size="89196812" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64--13.0…" hashFunction="SHA512" hashValue="43e8d970e16f216c7e7cd2094d23ccde0ac5af397973c0a15d33a45c5602f9893f43ee42f5a6204f4c2582b1ddfbc1fe858dba5ee18b49d1d929946972753ac3" size="11833733" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.10-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…" hashFunction="SHA512" hashValue="94ec6248cc9ac47c36527fe9c4be8af5793f9b94e8b7508af0999d8fa872c87d002a38349866e0de8e806f6df8c836b7f258572d0455634ec4df5561ac42214a" size="107245515" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64--13.0.…" hashFunction="SHA512" hashValue="ab1835e09c012ce8ff962b109afbe12db3d82bcf252b5e75e4d865f0546e4abddff89a045f4524f4307164c793c62e406770795d1affacf27b9042c9739a5cf0" size="11516951" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.10-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10_ALL.m…" hashFunction="SHA512" hashValue="30de8b89fb7c67130225b823d59e813949ca55c58e59b4da389394835436f69125e2be6ac5aa8da4d915a7dc0fa7c0a1ede5f0dae104cc0400bbca306f76add4" size="115293951" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos--13.0.6-13.0.…" hashFunction="SHA512" hashValue="b1dd45b032e73c357763ba48c7cb7062b8028fc686ab409a6dfb6bfdb7f4a763832fed386892c03ec4ecc747e552a0c79f770ab69d545aa5b0d1bb5fae9866ab" size="16654317" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.10-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-13.0…" hashFunction="SHA512" hashValue="bb71ce5cbb6e7a11e1e12e165dae922c0bc600324577b4b7e3af59247764db7ca4a2a8af0d9560b925b6bc5a0b7bba9d3a4f46598ec7d291ab4638239e38543e" size="89214292" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64--13.…" hashFunction="SHA512" hashValue="b139243c78b05d4d4258c0be34db84eeab70920e66dc7f8e6bb35352095df1d0a92b8f405a2ac7ac3dbedaf3fcf233c02cff6c1586ccfd86187628b46cf29d46" size="11993550" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.9-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9_…" hashFunction="SHA512" hashValue="18fdf0900b6e5e58f833828e2a854b44e997dd6a752a1fa38d29acf69ca6d88e39e5e8f1811ffb9a0ea5240afa32efa8459c25ddd1d7e57090b8ffdfa7a112ad" size="107222791" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64--13.0.6…" hashFunction="SHA512" hashValue="f2cb0404a1af1a097bc7715497efc5f8dd8d60af9e09408fbcd781b3bf0123102b08b26d35643f4ed865a2fa09d9828e1503efd44b8e218eee7948bd22830e6c" size="11023938" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.9-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9_ALL.mar" hashFunction="SHA512" hashValue="2f2fb000e87b425a8df5b25160354eab158a86d7b20b0cb957a9e6f33e9d54a02873b118bc4ad007886e3361ed85a3c3b3f397a36ebe748b91abaf9d72a28887" size="115259351" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos--13.0.6-13.0.9…" hashFunction="SHA512" hashValue="ae9748ea2851ddfdb076c71cc71eddd3cd8ea6a336ca1a1759b975256223fd51951407793953157a3dfeec229d1875bfcf391417f1b0f3b58a0ba4fe9ae41287" size="76593879" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.6-13.0.9-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-13.0.…" hashFunction="SHA512" hashValue="6b955bb9b9f28f34b0199eaad15dcbc7bc28a62ed318ae95b2f162dba2f45a4ca877a47c86d892f2ef859a69f7188a1ab2c08ec9861b7682b214214014369282" size="89196812" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64--13.0…" hashFunction="SHA512" hashValue="4de8e6b0fdeb35371d9c051e9ebbfa2878487cd1ad4dc7e22583e3f9cedadd8a9867d77073ec22ae950bcb5fbabd5858d9a3e0d2f357dd69e3783b39aa71b12c" size="11587701" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.10-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…" hashFunction="SHA512" hashValue="94ec6248cc9ac47c36527fe9c4be8af5793f9b94e8b7508af0999d8fa872c87d002a38349866e0de8e806f6df8c836b7f258572d0455634ec4df5561ac42214a" size="107245515" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64--13.0.…" hashFunction="SHA512" hashValue="51f18033eb60aec69955043ec83ae96a3f273bf2bb83728f4e03442f0fd2293122b83a781f29ef5d63248aca7f9bcd6125e34ef0010c7c934f444ef43f3c8a07" size="10482606" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.10-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10_ALL.m…" hashFunction="SHA512" hashValue="30de8b89fb7c67130225b823d59e813949ca55c58e59b4da389394835436f69125e2be6ac5aa8da4d915a7dc0fa7c0a1ede5f0dae104cc0400bbca306f76add4" size="115293951" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos--13.0.7-13.0.…" hashFunction="SHA512" hashValue="01aa8a7b9367e16e7ee7255031348bcd06c85eb6bca2c38fed8e9553fdbeb0c50f9faba6bdd1aa2636d6c9a1c65335403af4c344d322a702430c1ec6a13ab7d3" size="15148501" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.10-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-13.0…" hashFunction="SHA512" hashValue="bb71ce5cbb6e7a11e1e12e165dae922c0bc600324577b4b7e3af59247764db7ca4a2a8af0d9560b925b6bc5a0b7bba9d3a4f46598ec7d291ab4638239e38543e" size="89214292" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64--13.…" hashFunction="SHA512" hashValue="554e91c0de3da995f1000d3043443c8d85b4f35c90e6a7b5344817389fc64327a03ec55e4755bbbd1a091cb602bedbac840e36d932a4c4d58d1d930b245d3994" size="10964217" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.9-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9_…" hashFunction="SHA512" hashValue="18fdf0900b6e5e58f833828e2a854b44e997dd6a752a1fa38d29acf69ca6d88e39e5e8f1811ffb9a0ea5240afa32efa8459c25ddd1d7e57090b8ffdfa7a112ad" size="107222791" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64--13.0.7…" hashFunction="SHA512" hashValue="d580164e63cf556cbeec1115289534762337ff00b8eb1f9404f181a6d7cd6200133026c89764212b1dd558949e8b9e8c5aa161de935824803ce82afef1aa6556" size="9720353" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.9-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9_ALL.mar" hashFunction="SHA512" hashValue="2f2fb000e87b425a8df5b25160354eab158a86d7b20b0cb957a9e6f33e9d54a02873b118bc4ad007886e3361ed85a3c3b3f397a36ebe748b91abaf9d72a28887" size="115259351" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos--13.0.7-13.0.9…" hashFunction="SHA512" hashValue="d77ea66fd5ed38912332c4fdb9b3b50212f6f10cfea9276e73b4cd5e53d6e70b2c581e0d887073fda0313ebc6d179866d359c54b178d703944f55da4cb50104e" size="76133103" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.7-13.0.9-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-13.0.…" hashFunction="SHA512" hashValue="6b955bb9b9f28f34b0199eaad15dcbc7bc28a62ed318ae95b2f162dba2f45a4ca877a47c86d892f2ef859a69f7188a1ab2c08ec9861b7682b214214014369282" size="89196812" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64--13.0…" hashFunction="SHA512" hashValue="20e5cfca2e945dc4f3bfa3ebe1885de2a9764ba55e7a2e8436a55dc8c6d3de196c3d081e9510a7d1ef130cdac8d1564127ed9c1445c2ed7d3c398b8142c42b6b" size="9629252" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.9-13.0.10-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…" hashFunction="SHA512" hashValue="94ec6248cc9ac47c36527fe9c4be8af5793f9b94e8b7508af0999d8fa872c87d002a38349866e0de8e806f6df8c836b7f258572d0455634ec4df5561ac42214a" size="107245515" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64--13.0.…" hashFunction="SHA512" hashValue="526ad1569cde8630b81c65ca82edd6930e0b1d0985bc2f68a13e63c6bdefcb57c2f3327f95ad824e735576463050a107facee6285b984e8b5d92bb402377947d" size="5058062" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.9-13.0.10-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10_ALL.m…" hashFunction="SHA512" hashValue="30de8b89fb7c67130225b823d59e813949ca55c58e59b4da389394835436f69125e2be6ac5aa8da4d915a7dc0fa7c0a1ede5f0dae104cc0400bbca306f76add4" size="115293951" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos--13.0.9-13.0.…" hashFunction="SHA512" hashValue="d46b98a5bb2354f33d5e58eeba285939c228981d62c207bd066b86892fb84f857544dfad90e2392ffc87ae3065d53e33915725c4d4c9818afd459e037cf077ed" size="9678114" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.9-13.0.10-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="13.0.10" appVersion="13.0.10" platformVersion="115.8.0" buildID="20240213150358" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.10" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-13.0…" hashFunction="SHA512" hashValue="bb71ce5cbb6e7a11e1e12e165dae922c0bc600324577b4b7e3af59247764db7ca4a2a8af0d9560b925b6bc5a0b7bba9d3a4f46598ec7d291ab4638239e38543e" size="89214292" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64--13.…" hashFunction="SHA512" hashValue="47c998cc3f194235bac50754c3ea72d4b077aa7c43298e1847ecc7c014802aa42e66cbe5fc83ee9d0bc392be5f3e7efd1ac726b5273599f30b16287fdba92b93" size="5497521" type="partial"></patch></update></updates> ===================================== update_1/release/13.0.9-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9_…" hashFunction="SHA512" hashValue="18fdf0900b6e5e58f833828e2a854b44e997dd6a752a1fa38d29acf69ca6d88e39e5e8f1811ffb9a0ea5240afa32efa8459c25ddd1d7e57090b8ffdfa7a112ad" size="107222791" type="complete"></patch></update></updates> ===================================== update_1/release/13.0.9-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="16.0.0"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9_ALL.mar" hashFunction="SHA512" hashValue="2f2fb000e87b425a8df5b25160354eab158a86d7b20b0cb957a9e6f33e9d54a02873b118bc4ad007886e3361ed85a3c3b3f397a36ebe748b91abaf9d72a28887" size="115259351" type="complete"></patch></update></updates> ===================================== update_1/release/13.0.9-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="13.0.9" appVersion="13.0.9" platformVersion="115.7.0" buildID="20240115174108" detailsURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/13.0.9" minSupportedOSVersion="6.1" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-13.0.…" hashFunction="SHA512" hashValue="6b955bb9b9f28f34b0199eaad15dcbc7bc28a62ed318ae95b2f162dba2f45a4ca877a47c86d892f2ef859a69f7188a1ab2c08ec9861b7682b214214014369282" size="89196812" type="complete"></patch></update></updates> ===================================== update_1/release/download-linux-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9.…","git_tag":"mb-13.0.9-build1","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9.…","version":"13.0.9"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…","git_tag":"mb-13.0.10-build2","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…","version":"13.0.10"} \ No newline at end of file ===================================== update_1/release/download-macos.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9.dmg","git_tag":"mb-13.0.9-build1","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9.dmg.asc","version":"13.0.9"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10.dmg","git_tag":"mb-13.0.10-build2","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10.dmg.a…","version":"13.0.10"} \ No newline at end of file ===================================== update_1/release/download-windows-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-porta…","git_tag":"mb-13.0.9-build1","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-porta…","version":"13.0.9"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-port…","git_tag":"mb-13.0.10-build2","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-port…","version":"13.0.10"} \ No newline at end of file ===================================== update_1/release/downloads.json ===================================== @@ -1 +1 @@ -{"downloads":{"linux-x86_64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9.…","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-linux-x86_64-13.0.9.…"}},"macos":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9.dmg","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-macos-13.0.9.dmg.asc"}},"win64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-porta…","sig":"https://cdn.mullvad.net/browser/13.0.9/mullvad-browser-windows-x86_64-porta…"}}},"tag":"mb-13.0.9-build1","version":"13.0.9"} \ No newline at end of file +{"downloads":{"linux-x86_64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-linux-x86_64-13.0.1…"}},"macos":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10.dmg","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-macos-13.0.10.dmg.a…"}},"win64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-port…","sig":"https://cdn.mullvad.net/browser/13.0.10/mullvad-browser-windows-x86_64-port…"}}},"tag":"mb-13.0.10-build2","version":"13.0.10"} \ No newline at end of file View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41081: Update detailsURL in tools/signing/nightly/update-responses-base-config.yml
by boklm (＠boklm) 15 Feb '24

15 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 914c359a by Nicolas Vigier at 2024-02-15T09:56:08+01:00 Bug 41081: Update detailsURL in tools/signing/nightly/update-responses-base-config.yml - - - - - 1 changed file: - tools/signing/nightly/update-responses-base-config.yml Changes: ===================================== tools/signing/nightly/update-responses-base-config.yml ===================================== @@ -17,7 +17,7 @@ channels: versions: nightly_version: platformVersion: 115.1.0 - detailsURL: http://umj4zbqdfcyevlkgqgpq6foxk3z75zzxsbgt5jqmfxofrbrjh3crbnad.onion/ + detailsURL: https://nightlies.tbb.torproject.org/ macos: minSupportedOSVersion: 16.0.0 windows-i686: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41079: Bump version of snowflake to v2.9.0
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: 46a6add3 by Cecylia Bocovich at 2024-02-14T16:57:07+00:00 Bug 41079: Bump version of snowflake to v2.9.0 (cherry picked from commit 98943bdf69f056a3a8d3f90d16729e225f201c94) - - - - - 1 changed file: - projects/snowflake/config Changes: ===================================== projects/snowflake/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snow… -git_hash: v2.8.1 +git_hash: v2.9.0 gpg_keyring: anti-censorship.gpg tag_gpg_id: 1 @@ -22,6 +22,6 @@ steps: pkg_type: go_vendor project: snowflake norec: - sha256sum: 6e41846a6d3e94891847d74ac08c6888c1540e0b0680ed3900ca54d7c35e1752 + sha256sum: a081c55db822f9f26121e9f986d1a74c212b01303daf43eef1ea3f808b1b8c0b target_replace: '^torbrowser-(?!testbuild).*': 'torbrowser-linux-x86_64' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41079: Bump version of snowflake to v2.9.0
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 98943bdf by Cecylia Bocovich at 2024-02-14T10:22:41-05:00 Bug 41079: Bump version of snowflake to v2.9.0 - - - - - 1 changed file: - projects/snowflake/config Changes: ===================================== projects/snowflake/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snow… -git_hash: v2.8.1 +git_hash: v2.9.0 gpg_keyring: anti-censorship.gpg tag_gpg_id: 1 @@ -22,6 +22,6 @@ steps: pkg_type: go_vendor project: snowflake norec: - sha256sum: 6e41846a6d3e94891847d74ac08c6888c1540e0b0680ed3900ca54d7c35e1752 + sha256sum: a081c55db822f9f26121e9f986d1a74c212b01303daf43eef1ea3f808b1b8c0b target_replace: '^torbrowser-(?!testbuild).*': 'torbrowser-linux-x86_64' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-13.0.10-build2
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed new tag mb-13.0.10-build2 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] 2 commits: Update rbm for rbm#40072
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: 0d5b47c2 by Richard Pospesel at 2024-02-14T13:10:30+00:00 Update rbm for rbm#40072 - - - - - 0daa553d by Richard Pospesel at 2024-02-14T13:14:27+00:00 Bug 41062: Update Mullvad Browser to -build2 - - - - - 2 changed files: - rbm - rbm.conf Changes: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit 067c30ee4cf3baa1c0b7e3674d785cf9e5bec8fe +Subproject commit efd874abee2d4afe652feb6c79c1d929f70d136b ===================================== rbm.conf ===================================== @@ -82,7 +82,7 @@ buildconf: var: torbrowser_version: '13.0.10' - torbrowser_build: 'build1' + torbrowser_build: '[% IF c("var/mullvad-browser") %]build2[% ELSE %]build1[% END %]' torbrowser_incremental_from: - '13.0.9' - '[% IF c("var/tor-browser") %]13.0.8[% END %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-13.0.10-build1
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed new tag mb-13.0.10-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-115.8.0esr-13.0-1-build1
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed new tag mullvad-browser-115.8.0esr-13.0-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.0-1] 19 commits: MB 38: Mullvad Browser configuration
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed to branch mullvad-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: ad124f15 by Pier Angelo Vendrame at 2024-02-13T15:42:01+01:00 MB 38: Mullvad Browser configuration - - - - - e50abaae by Pier Angelo Vendrame at 2024-02-13T15:42:03+01:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - 3cd09bc2 by Pier Angelo Vendrame at 2024-02-13T15:42:03+01:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - 2901c4a5 by Pier Angelo Vendrame at 2024-02-13T15:42:04+01:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - f7888dd5 by Pier Angelo Vendrame at 2024-02-13T15:42:04+01:00 MB 37: Customization for the about dialog - - - - - a600fbf9 by Henry Wilkes at 2024-02-13T15:42:04+01:00 MB 39: Add home page about:mullvad-browser - - - - - 5b3f2654 by hackademix at 2024-02-13T15:42:05+01:00 MB 97: Remove UI cues to install new extensions. - - - - - 598f097d by hackademix at 2024-02-13T15:42:05+01:00 MB 47: uBlock Origin customization - - - - - d9a9a960 by Pier Angelo Vendrame at 2024-02-13T15:42:05+01:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - 8f3a9adf by Pier Angelo Vendrame at 2024-02-13T15:42:06+01:00 MB 87: Disable the default browser box on Windows and Linux Windows and Linux will be distributed only as portable apps at the beginning, so they should not be settable as default browsers. We will need to improve the logic once we decide to ship system-wide installers, too. - - - - - 20d025ac by Pier Angelo Vendrame at 2024-02-13T15:42:06+01:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - b74b353e by Nicolas Vigier at 2024-02-13T15:42:06+01:00 MB 79: Add Mullvad Browser MAR signing keys - - - - - 24cd359a by Nicolas Vigier at 2024-02-13T15:42:07+01:00 squash! MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - 0b001733 by Pier Angelo Vendrame at 2024-02-13T15:42:07+01:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - e1ac8710 by Pier Angelo Vendrame at 2024-02-13T15:42:07+01:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - 87524fa0 by hackademix at 2024-02-13T15:42:08+01:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - b380d03f by Richard Pospesel at 2024-02-13T15:42:08+01:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - bdc08633 by rui hildt at 2024-02-13T15:42:08+01:00 MB 213: Customize the search engines list - - - - - b88c5fd8 by hackademix at 2024-02-13T15:42:08+01:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - 30 changed files: - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png - + browser/branding/mb-alpha/content/aboutDialog.css - + browser/branding/mb-alpha/content/firefox-wordmark.svg The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/63… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/63… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41061, 41062: Prepare Tor and Mullvad Browser Stable 13.0.10
by richard (＠richard) 14 Feb '24

14 Feb '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: ef38ee70 by Richard Pospesel at 2024-02-13T18:02:58+00:00 Bug 41061,41062: Prepare Tor and Mullvad Browser Stable 13.0.10 - - - - - 13 changed files: - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/allowed_addons.json - projects/browser/config - projects/firefox-android/config - projects/firefox/config - projects/geckoview/config - projects/go/config - projects/manual/config - projects/openssl/config - projects/translation/config - projects/zlib/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -1,3 +1,38 @@ +Mullvad Browser 13.0.10 - February 20 2024 + * All Platforms + * Updated Firefox to 115.8.0esr + * Updated mullvad-browser-extension to 0.8.5 + * Bug 267: Rebase Mullvad Browser Stable onto Firefox 115.8.0esr [mullvad-browser] + * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] + * Build System + * All Platforms + * Bug 41037: Set time on signing machine before starting signing [tor-browser-build] + * Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput [tor-browser-build] + * Bug 40068: Switch from IO::CaptureOutput to Capture::Tiny [rbm] + * Bug 40069: Make stdout and stderr utf8 [rbm] + +Mullvad Browser 13.5a4 - January 29 2024 + * All Platforms + * Updated Firefox to 115.7.0esr + * Updated uBlock Origin to 1.55.0 + * Bug 261: Rebase Mullvad Browser Alpha onto Firefox 115.7.0esr [mullvad-browser] + * Bug 41917: Make the appearance of letterboxing look more intentional [tor-browser] + * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] + * Build System + * All Platforms + * Bug 42337: Enable GeckoDriver for all desktop platforms [tor-browser] + * Bug 41037: Set time on signing machine before starting signing [tor-browser-build] + * Bug 41045: Dump more information about build times on Firefox [tor-browser-build] + * Bug 41056: Make it possible to use templates in var/torbrowser_incremental_from [tor-browser-build] + * Bug 41057: make fetch is not fetching mullvad repo [tor-browser-build] + * Bug 41059: Update keyring/torbrowser.gpg with updated key [tor-browser-build] + * Windows + * Bug 40606: Use Clang to compile NSIS [tor-browser-build] + * Bug 40900: Update NSIS to 3.09 [tor-browser-build] + * Bug 41065: Do a cleanup of the NSIS script [tor-browser-build] + * Linux + * Bug 41046: Use the final path for Linux debug symbols [tor-browser-build] + Mullvad Browser 13.0.9 - January 23 2024 * All Platforms * Updated Firefox to 115.7.0esr ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,74 @@ +Tor Browser 13.0.10 - February 20 2024 + * All Platforms + * Updated OpenSSL to 3.0.13 + * Updated zlib to 1.3.1 + * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] + * Bug 42411: Rebase Tor Browser stable onto 115.8.0esr [tor-browser] + * Windows + macOS + Linux + * Updated Firefox to 115.8.0esr + * Bug 42338: Changing circuit programmatically in Tor Browser not working anymore! [tor-browser] + * Android + * Updated GeckoView to 115.8.0esr + * Bug 42402: Remove Android YEC strings [tor-browser] + * Linux + * Bug 42293: Updater is disabled when tor-browser is run by torbrowser-launcher flatpak [tor-browser] + * Build System + * All Platforms + * Updated Go to 1.20.14 and 1.21.7 + * Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput [tor-browser-build] + * Bug 40067: Use --no-verbose wget option when not running in a terminal [rbm] + * Bug 40068: Switch from IO::CaptureOutput to Capture::Tiny [rbm] + * Bug 40069: Make stdout and stderr utf8 [rbm] + +Tor Browser 13.5a4 - January 31 2024 + * All Platforms + * Updated zlib to 1.3.1 + * Updated Snowflake to 2.8.1 + * Bug 42343: Consume pt_config.json in the browser [tor-browser] + * Bug 42348: TorSettings.defaultSettings() removed but still referenced by Moat.sys.mjs [tor-browser] + * Bug 42354: Refactor exclusions in ShouldSanitizePreference() to the pref list. [tor-browser] + * Bug 42358: Separate the domain fronted requests from Moat [tor-browser] + * Bug 42359: Handle firewall and proxy in TorSettings.setSettings [tor-browser] + * Bug 42363: Tab thumbnails enhancements [tor-browser] + * Bug 42366: Rebase Tor Browser Alpha onto Firefox 115.7.0esr [tor-browser] + * Bug 42369: Revert YEC 2023 changes [tor-browser] + * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] + * Bug 42384: Regression: quickstart doesn't work anymore [tor-browser] + * Bug 41058: Update Snowflake to 2.8.1 [tor-browser-build] + * Bug 262: Mouse-over long links causes the browser element to re-center relative to width of status tooltip [mullvad-browser] + * Windows + macOS + Linux + * Updated Firefox to 115.7.0esr + * Bug 41917: Make the appearance of letterboxing look more intentional [tor-browser] + * Bug 42036: Design and build a user interface for Lox [tor-browser] + * Bug 42338: Changing circuit programmatically in Tor Browser not working anymore! [tor-browser] + * Bug 42387: Visual noise in 13.5a4 letterboxing [tor-browser] + * Linux + * Bug 42293: Updater is disabled when tor-browser is run by torbrowser-launcher flatpak [tor-browser] + * Android + * Updated GeckoView to 115.7.0esr + * Bug 42252: Plumb down TorConnect commands from firefox-android to GeckoView [tor-browser] + * Bug 42346: Crash in firefox-android originating in backported FullScreenNotificationDialog patch [tor-browser] + * Bug 42353: Fix Android NoScript automatic updates [tor-browser] + * Bug 42355: Fullscreen on Android doesn't hide system bars [tor-browser] + * Bug 42367: Backport Android security fixes from Firefox 122 [tor-browser] + * Bug 42368: Tor Browser 13.5a3 crashes during start-up because of API26+ methods [tor-browser] + * Build System + * All Platforms + * Updated Go to 1.20.13 and 1.21.6 + * Bug 41037: Set time on signing machine before starting signing [tor-browser-build] + * Bug 41038: Add RPM dependencies to README [tor-browser-build] + * Bug 41059: Update keyring/torbrowser.gpg with updated key [tor-browser-build] + * Bug 41063: Run "file $keyring" in tools/keyring/list-all-keyrings [tor-browser-build] + * Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput [tor-browser-build] + * Bug 41073: Update documention about required packages for container-less build [tor-browser-build] + * Bug 40067: Use --no-verbose wget option when not running in a terminal [rbm] + * Windows + macOS + Linux + * Bug 41078: pt_config.json not touch'd before adding to omni.ja, resulting in build non-determinism [tor-browser-build] + * Windows + * Bug 40606: Use Clang to compile NSIS [tor-browser-build] + * Bug 40900: Update NSIS to 3.09 [tor-browser-build] + * Bug 41065: Do a cleanup of the NSIS script [tor-browser-build] + Tor Browser 13.0.9 - January 23 2024 * All Platforms * Updated Snowflake to 2.8.1 ===================================== projects/browser/allowed_addons.json ===================================== @@ -17,7 +17,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/34/9734/13299734/13299734.pn…" } ], - "average_daily_users": 1132322, + "average_daily_users": 1145406, "categories": { "firefox": [ "web-development", @@ -28,7 +28,7 @@ "contributions_url": "https://opencollective.com/darkreader?utm_content=product-page-contribute&u…", "created": "2017-09-19T07:03:00Z", "current_version": { - "id": 5672334, + "id": 5688757, "compatibility": { "firefox": { "min": "54.0", @@ -39,7 +39,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/darkreader/versions/56723…", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/darkreader/versions/56887…", "is_strict_compatibility_enabled": false, "license": { "id": 22, @@ -50,22 +50,22 @@ "url": "http://www.opensource.org/license/mit" }, "release_notes": { - "en-US": "- Improved image analysis performance.\n- Improved dark theme detection.\n- Fixed 404 errors when loading images with relative paths.\n- v5 Preview: Moved settings into a separate page.\n- Users' fixes for websites." + "en-US": "- Fixed errors when Adopted Stylesheets were not present.\n- Fixed breaking on ::view-transition selectors (Airbnb issue).\n- Users' fixes for websites." }, - "reviewed": "2024-01-08T08:34:10Z", - "version": "4.9.74", + "reviewed": "2024-02-08T08:33:10Z", + "version": "4.9.77", "files": [ { - "id": 4216652, - "created": "2024-01-03T21:18:58Z", - "hash": "sha256:140a72b36750ba68a9da30d0f0df3ff192f58160b711b86c3d4f674e5be2bb2c", + "id": 4233074, + "created": "2024-02-07T11:23:55Z", + "hash": "sha256:931de67e9091c69edd9fd3f348a7ed1de1dce7d136017fed641bd10eb0ae8891", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 716574, + "size": 725369, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4216652/darkreader-4.9.74…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4233074/darkreader-4.9.77…", "permissions": [ "alarms", "contextMenus", @@ -143,7 +143,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2024-01-08T08:34:10Z", + "last_updated": "2024-02-08T08:33:10Z", "name": { "ar": "Dark Reader", "bn": "Dark Reader", @@ -218,10 +218,10 @@ "category": "recommended" }, "ratings": { - "average": 4.5486, - "bayesian_average": 4.547482095849253, - "count": 5355, - "text_count": 1679 + "average": 4.543, + "bayesian_average": 4.541876920708902, + "count": 5422, + "text_count": 1714 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/reviews/", "requires_payment": false, @@ -318,7 +318,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/versions/", - "weekly_downloads": 26881 + "weekly_downloads": 24238 }, "notes": null }, @@ -334,7 +334,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/56/7656/6937656/6937656.png?…" } ], - "average_daily_users": 264469, + "average_daily_users": 266930, "categories": { "firefox": [ "privacy-security" @@ -548,9 +548,9 @@ }, "ratings": { "average": 4.8027, - "bayesian_average": 4.798136425398132, - "count": 1399, - "text_count": 250 + "bayesian_average": 4.798069751523067, + "count": 1404, + "text_count": 252 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/reviews/", "requires_payment": false, @@ -635,7 +635,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/versions/", - "weekly_downloads": 4097 + "weekly_downloads": 3379 }, "notes": null }, @@ -651,7 +651,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/73/4073/5474073/5474073.png?…" } ], - "average_daily_users": 1200897, + "average_daily_users": 1230616, "categories": { "firefox": [ "privacy-security" @@ -660,7 +660,7 @@ "contributions_url": "https://paypal.me/SupportEFF?utm_content=product-page-contribute&utm_medium…", "created": "2014-05-01T18:23:16Z", "current_version": { - "id": 5659023, + "id": 5688386, "compatibility": { "firefox": { "min": "78.0", @@ -671,7 +671,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/privacy-badger17/versions…", "is_strict_compatibility_enabled": false, "license": { "id": 6, @@ -682,22 +682,22 @@ "url": "http://www.gnu.org/licenses/gpl-3.0.html" }, "release_notes": { - "en-US": "<ul><li>Improved widget replacement for embedded Tweets</li><li>Fixed blocking WebSocket connections to blocked domains</li><li>Fixed various site breakages</li><li>Added Galician translations in Firefox</li><li>Improved translations (Traditional Chinese, Greek, Japanese)</li></ul>" + "en-US": "<ul><li>Fixed timing issue that could lead to incomplete or empty tracker data on installation in Firefox</li><li>Fixed various UI display issues</li><li>Fixed various site breakages</li><li>Improved translations (Hebrew, Brazilian Portuguese, Swedish, Ukrainian)</li></ul>" }, - "reviewed": "2023-12-07T09:09:12Z", - "version": "2023.12.1", + "reviewed": "2024-02-08T18:59:58Z", + "version": "2024.2.6", "files": [ { - "id": 4203344, - "created": "2023-12-01T19:02:57Z", - "hash": "sha256:aacac794c211fc6ea7dc51529883fd3e477aff37441d29ae7f576ab0f8c737b7", + "id": 4232703, + "created": "2024-02-06T15:04:35Z", + "hash": "sha256:81d80bff29b6209aa444713bc548a3d06fd5bde208c9c3c596dba81cc97add02", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 1893319, + "size": 1892384, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4203344/privacy_badger17-…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4232703/privacy_badger17-…", "permissions": [ "<all_urls>", "alarms", @@ -1124,7 +1124,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-12-07T09:09:12Z", + "last_updated": "2024-02-08T18:59:58Z", "name": { "en-US": "Privacy Badger" }, @@ -1170,10 +1170,10 @@ "category": "recommended" }, "ratings": { - "average": 4.7958, - "bayesian_average": 4.793109511550156, - "count": 2370, - "text_count": 449 + "average": 4.7951, + "bayesian_average": 4.792379053678419, + "count": 2387, + "text_count": 454 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/reviews/", "requires_payment": false, @@ -1197,7 +1197,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/versions/", - "weekly_downloads": 23541 + "weekly_downloads": 22274 }, "notes": null }, @@ -1213,7 +1213,7 @@ "picture_url": null } ], - "average_daily_users": 7460988, + "average_daily_users": 7720487, "categories": { "firefox": [ "privacy-security" @@ -1379,7 +1379,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2024-01-14T18:40:19Z", + "last_updated": "2024-02-02T17:55:27Z", "name": { "ar": "uBlock Origin", "bg": "uBlock Origin", @@ -1524,10 +1524,10 @@ "category": "recommended" }, "ratings": { - "average": 4.7862, - "bayesian_average": 4.7858262322479135, - "count": 17029, - "text_count": 4446 + "average": 4.7881, + "bayesian_average": 4.787723506381607, + "count": 17231, + "text_count": 4500 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/reviews/", "requires_payment": false, @@ -1590,7 +1590,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/", - "weekly_downloads": 195010 + "weekly_downloads": 177322 }, "notes": null }, @@ -1606,7 +1606,7 @@ "picture_url": null } ], - "average_daily_users": 177316, + "average_daily_users": 178336, "categories": { "firefox": [ "photos-music-videos", @@ -1702,10 +1702,10 @@ "category": "recommended" }, "ratings": { - "average": 4.4774, - "bayesian_average": 4.472406681309426, - "count": 1175, - "text_count": 443 + "average": 4.4586, + "bayesian_average": 4.453632190728077, + "count": 1197, + "text_count": 458 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/re…", "requires_payment": false, @@ -1727,7 +1727,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/ve…", - "weekly_downloads": 428 + "weekly_downloads": 338 }, "notes": null }, @@ -1743,7 +1743,7 @@ "picture_url": null } ], - "average_daily_users": 81759, + "average_daily_users": 80426, "categories": { "firefox": [ "privacy-security", @@ -1853,9 +1853,9 @@ ], "promoted": null, "ratings": { - "average": 4.3802, - "bayesian_average": 4.366169675126323, - "count": 405, + "average": 4.3787, + "bayesian_average": 4.364570736907983, + "count": 404, "text_count": 113 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/reviews/", @@ -1878,7 +1878,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/versions/", - "weekly_downloads": 1270 + "weekly_downloads": 1192 }, "notes": null }, @@ -1894,7 +1894,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/64/9064/12929064/12929064.pn…" } ], - "average_daily_users": 294389, + "average_daily_users": 303170, "categories": { "firefox": [ "search-tools", @@ -1905,7 +1905,7 @@ "contributions_url": "https://www.paypal.com/donate?hosted_button_id=GLL4UNSNU6SQN&utm_content=pr…", "created": "2017-06-17T15:23:33Z", "current_version": { - "id": 5665608, + "id": 5683352, "compatibility": { "firefox": { "min": "115.0", @@ -1916,7 +1916,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/search_by_image/versions/…", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/search_by_image/versions/…", "is_strict_compatibility_enabled": false, "license": { "id": 6, @@ -1929,20 +1929,20 @@ "release_notes": { "en-US": "Learn more about this release from the <a href=\"https://prod.outgoing.prod.webservices.mozgcp.net/v1/d50855f24f77fa6f2614b9…" rel=\"nofollow\">changelog</a>." }, - "reviewed": "2023-12-19T14:03:13Z", - "version": "6.1.1", + "reviewed": "2024-01-31T11:30:38Z", + "version": "6.1.2", "files": [ { - "id": 4209928, - "created": "2023-12-17T01:28:51Z", - "hash": "sha256:254d78084e332190a2b6ccb1959a42257bdc287addc0685419fcde7df1a52e76", + "id": 4227669, + "created": "2024-01-27T08:06:28Z", + "hash": "sha256:fed46723702c79d0d2dcd2132901402b6c391f9fef8efbb58635b5ea9e47476f", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 1165289, + "size": 1165290, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4209928/search_by_image-6…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4227669/search_by_image-6…", "permissions": [ "alarms", "contextMenus", @@ -1985,7 +1985,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2023-12-19T14:03:13Z", + "last_updated": "2024-01-31T11:30:38Z", "name": { "en-US": "Search by Image" }, @@ -2111,10 +2111,10 @@ "category": "recommended" }, "ratings": { - "average": 4.6435, - "bayesian_average": 4.6390566621044025, - "count": 1380, - "text_count": 266 + "average": 4.6486, + "bayesian_average": 4.644151267365882, + "count": 1406, + "text_count": 273 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/reviews/", "requires_payment": false, @@ -2129,13 +2129,15 @@ "en-US": "https://github.com/dessant/search-by-image/issues" }, "tags": [ + "google", "image search", + "pinterest", "search" ], "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/versions/", - "weekly_downloads": 6351 + "weekly_downloads": 5685 }, "notes": null }, @@ -2158,7 +2160,7 @@ "picture_url": null } ], - "average_daily_users": 123429, + "average_daily_users": 124960, "categories": { "firefox": [ "search-tools", @@ -2439,10 +2441,10 @@ "category": "recommended" }, "ratings": { - "average": 4.3747, - "bayesian_average": 4.370328322743152, - "count": 1305, - "text_count": 369 + "average": 4.3708, + "bayesian_average": 4.3664252602275715, + "count": 1327, + "text_count": 375 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/reviews/", "requires_payment": false, @@ -2462,7 +2464,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/versions/", - "weekly_downloads": 58 + "weekly_downloads": 23 }, "notes": null }, @@ -2478,7 +2480,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/43/0143/143/143.png?modified…" } ], - "average_daily_users": 311129, + "average_daily_users": 310960, "categories": { "firefox": [ "web-development", @@ -2665,10 +2667,10 @@ "category": "recommended" }, "ratings": { - "average": 4.397, - "bayesian_average": 4.394353096936605, - "count": 2166, - "text_count": 835 + "average": 4.3955, + "bayesian_average": 4.3928075540461755, + "count": 2172, + "text_count": 837 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/reviews/", "requires_payment": false, @@ -2712,7 +2714,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/", - "weekly_downloads": 7835 + "weekly_downloads": 7229 }, "notes": null }, @@ -2728,7 +2730,7 @@ "picture_url": null } ], - "average_daily_users": 161130, + "average_daily_users": 162651, "categories": { "firefox": [ "photos-music-videos", @@ -2837,10 +2839,10 @@ "category": "recommended" }, "ratings": { - "average": 3.8698, - "bayesian_average": 3.865733920025514, - "count": 1206, - "text_count": 437 + "average": 3.8749, + "bayesian_average": 3.8708093397361107, + "count": 1223, + "text_count": 444 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/revi…", "requires_payment": false, @@ -2859,7 +2861,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/vers…", - "weekly_downloads": 3356 + "weekly_downloads": 1653 }, "notes": null } ===================================== projects/browser/config ===================================== @@ -103,9 +103,9 @@ input_files: name: ublock-origin sha256sum: a02ca1d32737c3437f97553e5caaead6479a66ac1f8ff3b84a06cfa6bb0c7647 enable: '[% c("var/mullvad-browser") %]' - - URL: https://cdn.mullvad.net/browser-extension/0.8.4/mullvad-browser-extension-0… + - URL: https://cdn.mullvad.net/browser-extension/0.8.5/mullvad-browser-extension-0… name: mullvad-extension - sha256sum: a0057a37482e178331cde7a6fd3c100315fcfc26e804aa37c9281f412d24cb79 + sha256sum: b8208cc73d3c3c87342b25367b1a5fa330cb528f3213a4c4de30512f1662ff45 enable: '[% c("var/mullvad-browser") %]' - filename: 'gtk3-settings.ini' enable: '[% c("var/linux") %]' ===================================== projects/firefox-android/config ===================================== @@ -16,7 +16,7 @@ container: var: fenix_version: 115.2.1 browser_branch: 13.0-1 - browser_build: 12 + browser_build: 13 variant: Beta # This should be updated when the list of gradle dependencies is changed. gradle_dependencies_version: 1 ===================================== projects/firefox/config ===================================== @@ -14,7 +14,7 @@ container: use_container: 1 var: - firefox_platform_version: 115.7.0 + firefox_platform_version: 115.8.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '13.0' browser_branch: '[% c("var/browser_series") %]-1' ===================================== projects/geckoview/config ===================================== @@ -14,7 +14,7 @@ container: use_container: 1 var: - geckoview_version: 115.7.0esr + geckoview_version: 115.8.0esr browser_branch: 13.0-1 browser_build: 1 copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' ===================================== projects/go/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: '[% IF c("var/use_go_1_20") %]1.20.13[% ELSE %]1.21.6[% END %]' +version: '[% IF c("var/use_go_1_20") %]1.20.14[% ELSE %]1.21.7[% END %]' filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -121,11 +121,11 @@ input_files: enable: '[% ! c("var/linux") %]' - URL: 'https://go.dev/dl/go[% c("version") %].src.tar.gz' name: go - sha256sum: 124926a62e45f78daabbaedb9c011d97633186a33c238ffc1e25320c02046248 + sha256sum: 00197ab20f33813832bff62fd93cca1c42a08cc689a32a6672ca49591959bff6 enable: '[% !c("var/use_go_1_20") %]' - URL: 'https://go.dev/dl/go[% c("version") %].src.tar.gz' name: go - sha256sum: 0fe745c530f2f1d67193af3c5ea25246be077989ec5178df266e975f3532449e + sha256sum: 1aef321a0e3e38b7e91d2d7eb64040666cabdcc77d383de3c9522d0d69b67f4e enable: '[% c("var/use_go_1_20") %]' - project: go-bootstrap name: go-bootstrap ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 122062 +version: 136210 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -23,6 +23,6 @@ input_files: - project: container-image - URL: 'https://build-sources.tbb.torproject.org/manual_[% c("version") %].zip' name: manual - sha256sum: d51ebe27077817bcdabc0b5616c0c58fc14ea6d06f1a0b459051d67a4c13c348 + sha256sum: 6731381fd992cf65dd01e56e2b924005af633369da5ac9eb905fd8025255b386 - filename: packagemanual.py name: package_script ===================================== projects/openssl/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 3.0.12 +version: 3.0.13 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -33,4 +33,4 @@ input_files: - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - URL: 'https://www.openssl.org/source/openssl-[% c("version") %].tar.gz' - sha256sum: f93c9e8edde5e9166119de31755fc87b4aa34863662f67ddfcba14d0b6b69b61 + sha256sum: 88525753f79d3bec27d2fa7c66aa0b92b3aa9498dafd93d7cfa4b3780cdae313 ===================================== projects/translation/config ===================================== @@ -18,7 +18,7 @@ steps: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 767ab5111f065b82151275775af5ecf7a529ef48 + git_hash: a50fa943d7428ebe6e4e6b09f175e098a97eec63 targets: nightly: git_hash: 'tor-browser' @@ -32,7 +32,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: 8eab0d483cdba2a9628f8b534c802bbc910171d4 + git_hash: b0b9f5d6908c58e9492e6bdce9e8acdc493b178d compress_tar: 'zst' targets: nightly: ===================================== projects/zlib/config ===================================== @@ -1,6 +1,6 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' -version: '1.3' +version: '1.3.1' git_hash: 'v[% c("version") %]' git_url: https://github.com/madler/zlib.git gpg_keyring: zlib.gpg ===================================== rbm.conf ===================================== @@ -81,13 +81,13 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '13.0.9' - torbrowser_build: 'build2' + torbrowser_version: '13.0.10' + torbrowser_build: 'build1' torbrowser_incremental_from: + - '13.0.9' - '[% IF c("var/tor-browser") %]13.0.8[% END %]' - '13.0.7' - - '13.0.6' - - '[% IF c("var/mullvad-browser") %]13.0.4[% END %]' + - '[% IF c("var/mullvad-browser") %]13.0.6[% END %]' updater_enabled: 1 build_mar: 1 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bump Firefox version to 115.8.0esr for nightly builds.
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0396f1d4 by Pier Angelo Vendrame at 2024-02-14T12:16:59+01:00 Bump Firefox version to 115.8.0esr for nightly builds. - - - - - 2 changed files: - projects/firefox/config - projects/geckoview/config Changes: ===================================== projects/firefox/config ===================================== @@ -14,11 +14,11 @@ container: use_container: 1 var: - firefox_platform_version: 115.7.0 + firefox_platform_version: 115.8.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '13.5' browser_branch: '[% c("var/browser_series") %]-1' - browser_build: 2 + browser_build: 1 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' ===================================== projects/geckoview/config ===================================== @@ -14,9 +14,9 @@ container: use_container: 1 var: - geckoview_version: 115.7.0esr + geckoview_version: 115.8.0esr browser_branch: 13.5-1 - browser_build: 2 + browser_build: 1 copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser git_commit: '[% exec("git rev-parse HEAD") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.5-1] 2 commits: fixup! Bug 2176: Rebrand Firefox to TorBrowser
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 1913e9f0 by Pier Angelo Vendrame at 2024-02-14T12:11:17+01:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Include the channel in the display name - - - - - 89326fbd by Pier Angelo Vendrame at 2024-02-14T12:11:26+01:00 fixup! TB3: Tor Browser's official .mozconfigs. Bug 42398: Include the channel in MOZ_APP_DISPLAYNAME This variable is defined in the branding configuration, no need to repeat it in the mozconfig. - - - - - 3 changed files: - browser/branding/tb-alpha/configure.sh - browser/branding/tb-nightly/configure.sh - browser/config/mozconfigs/tor-browser Changes: ===================================== browser/branding/tb-alpha/configure.sh ===================================== @@ -2,4 +2,4 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -MOZ_APP_DISPLAYNAME="Tor Browser" +MOZ_APP_DISPLAYNAME="Tor Browser Alpha" ===================================== browser/branding/tb-nightly/configure.sh ===================================== @@ -2,4 +2,4 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -MOZ_APP_DISPLAYNAME="Tor Browser" +MOZ_APP_DISPLAYNAME="Tor Browser Nightly" ===================================== browser/config/mozconfigs/tor-browser ===================================== @@ -1,6 +1,5 @@ . $topsrcdir/browser/config/mozconfigs/base-browser -mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" # If building outside tor-browser-build, you might want to customize this value. # On Linux, it influences the WM_CLASS value, which is shown on GNOME's ALT-TAB, # for example. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dd4b53… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dd4b53… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40569: Include the channel name on macOS dmgs.
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 4e2b66e9 by Pier Angelo Vendrame at 2024-02-14T12:08:21+01:00 Bug 40569: Include the channel name on macOS dmgs. This commits make alpha and nightlies macOS build include the channel in the app bundle. Also, it renames the Project_Name_Channel to display_name to make it less ambiguous, and now Project_Name_Channel includes the channel also for the release target, even though it will be rarely used. - - - - - 17 changed files: - + projects/browser/Bundle-Data/BaseBrowser.dmg/alpha.DS_Store - + projects/browser/Bundle-Data/BaseBrowser.dmg/nightly.DS_Store - projects/browser/Bundle-Data/BaseBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/BaseBrowser.dmg/release.DS_Store - + projects/browser/Bundle-Data/MullvadBrowser.dmg/alpha.DS_Store - + projects/browser/Bundle-Data/MullvadBrowser.dmg/nightly.DS_Store - projects/browser/Bundle-Data/MullvadBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/MullvadBrowser.dmg/release.DS_Store - + projects/browser/Bundle-Data/TorBrowser.dmg/alpha.DS_Store - + projects/browser/Bundle-Data/TorBrowser.dmg/nightly.DS_Store - projects/browser/Bundle-Data/TorBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/TorBrowser.dmg/release.DS_Store - projects/browser/RelativeLink/start-browser.desktop - projects/browser/build - projects/browser/ddmg.sh - projects/firefox/build - projects/firefox/mozconfig - rbm.conf - tools/signing/functions - tools/signing/gatekeeper-bundling.sh Changes: ===================================== projects/browser/Bundle-Data/BaseBrowser.dmg/alpha.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/BaseBrowser.dmg/alpha.DS_Store differ ===================================== projects/browser/Bundle-Data/BaseBrowser.dmg/nightly.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/BaseBrowser.dmg/nightly.DS_Store differ ===================================== projects/browser/Bundle-Data/BaseBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/BaseBrowser.dmg/release.DS_Store ===================================== ===================================== projects/browser/Bundle-Data/MullvadBrowser.dmg/alpha.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/MullvadBrowser.dmg/alpha.DS_Store differ ===================================== projects/browser/Bundle-Data/MullvadBrowser.dmg/nightly.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/MullvadBrowser.dmg/nightly.DS_Store differ ===================================== projects/browser/Bundle-Data/MullvadBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/MullvadBrowser.dmg/release.DS_Store ===================================== ===================================== projects/browser/Bundle-Data/TorBrowser.dmg/alpha.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/TorBrowser.dmg/alpha.DS_Store differ ===================================== projects/browser/Bundle-Data/TorBrowser.dmg/nightly.DS_Store ===================================== Binary files /dev/null and b/projects/browser/Bundle-Data/TorBrowser.dmg/nightly.DS_Store differ ===================================== projects/browser/Bundle-Data/TorBrowser.dmg/.DS_Store → projects/browser/Bundle-Data/TorBrowser.dmg/release.DS_Store ===================================== ===================================== projects/browser/RelativeLink/start-browser.desktop ===================================== @@ -31,4 +31,4 @@ Categories=Network;WebBrowser;Security; Exec=sh -c '"$(dirname "$*")"/Browser/start-[% c("var/project-name") %] --detach || ([ ! -x "$(dirname "$*")"/Browser/start-[% c("var/project-name") %] ] && "$(dirname "$*")"/start-[% c("var/project-name") %] --detach)' dummy %k X-[% c("var/ProjectName") %]-ExecShell=./Browser/start-[% c("var/project-name") %] --detach Icon=web-browser -StartupWMClass=[% c("var/Project_Name_Channel") %] +StartupWMClass=[% c("var/display_name") %] ===================================== projects/browser/build ===================================== @@ -20,9 +20,9 @@ GENERATEDPREFSPATH=$rootdir/Bundle-Data/generated-prefs.js touch "$GENERATEDPREFSPATH" [% IF c("var/macos") %] - TBDIR="$TB_STAGE_DIR/[% c("var/Project_Name") %].app" + TBDIR="$TB_STAGE_DIR/[% c('var/display_name') %].app" [% IF c("var/macos_universal") %] - TBDIR_AARCH64="$TB_STAGE_DIR/[% c("var/Project_Name") %]-aarch64.app" + TBDIR_AARCH64="$TB_STAGE_DIR/[% c('var/display_name') %]-aarch64.app" TBDIRS=("$TBDIR" "$TBDIR_AARCH64") [% ELSE -%] TBDIRS=("$TBDIR") @@ -175,7 +175,7 @@ tar -C ${TB_STAGE_DIR} -xf [% c('input_files_by_name/firefox') %]/browser.tar.[% [% IF c("var/macos_universal") -%] # Use symlink in tmp dir to extract "Tor Browser.app" to "Tor Browser-aarch64.app" ff_aarch64=$(mktemp -d) - ln -s "$TBDIR_AARCH64" "$ff_aarch64/[% c("var/Project_Name") %].app" + ln -s "$TBDIR_AARCH64" "$ff_aarch64/[% c('var/display_name') %].app" tar -C $ff_aarch64 -xf [% c('input_files_by_name/firefox-aarch64') %]/browser.tar.[% c("compress_tar") %] [% END %] @@ -216,6 +216,10 @@ tar -C ${TB_STAGE_DIR} -xf [% c('input_files_by_name/firefox') %]/browser.tar.[% [% IF c("var/macos") %] tar -C "Bundle-Data/[% c('var/ProjectName') %].dmg" -c . | tar -C $TB_STAGE_DIR -x + pushd $TB_STAGE_DIR + cp [% c('var/channel') %].DS_Store .DS_Store + rm *.DS_Store + popd [% END %] for tbdir in "${TBDIRS[@]}" @@ -353,7 +357,7 @@ done [% IF c("var/windows") %] TBDIR="$distdir/$PKG_DIR/[% c("var/Project_Name") %]/Browser" [% ELSIF c("var/macos") %] - TBDIR="$distdir/$PKG_DIR/[% c("var/Project_Name") %].app" + TBDIR="$distdir/$PKG_DIR/[% c('var/display_name') %].app" [% ELSE %] TBDIR="$distdir/$PKG_DIR/Browser" [% END %] ===================================== projects/browser/ddmg.sh ===================================== @@ -21,7 +21,7 @@ directories=\$(find "\$src_dir" -type d | wc -l) # Give some room to breathe size=\$(echo \$((\$fileblocks + \$directories)) | awk '{print int(\$1 * 1.1)}') dd if=/dev/zero of="\$hfsfile" bs=4096 count=\$size -newfs_hfs -v "[% c("var/Project_Name") %]" "\$hfsfile" +newfs_hfs -v "[% c('var/display_name') %]" "\$hfsfile" pushd [% src %] ===================================== projects/firefox/build ===================================== @@ -185,13 +185,14 @@ echo "Starting ./mach build $(date)" [% IF c("var/macos") -%] cp -a obj-*/dist/[% c('var/exe_name') %]/* $distdir [% IF c("var/base-browser") -%] - mv "$distdir/Firefox.app" "$distdir/[% c('var/Project_Name') %].app" + mv "$distdir/Firefox.app" "$distdir/[% c('var/display_name') %].app" [% END -%] + app_bundle="[% c('var/display_name') %]" # Remove firefox-bin (we don't use it, see ticket #10126) - rm -f "$distdir/[% c('var/Project_Name') %].app/Contents/MacOS/[% c('var/exe_name') %]-bin" + rm -f "$distdir/$app_bundle/Contents/MacOS/[% c('var/exe_name') %]-bin" # Adjust the Info.plist file - INFO_PLIST="$distdir/[% c('var/Project_Name') %].app/Contents/Info.plist" + INFO_PLIST="$distdir/$app_bundle/Contents/Info.plist" python3 $rootdir/fix-info-plist.py \ "$INFO_PLIST" \ '[% c("var/Project_Name") %]' \ @@ -297,13 +298,13 @@ cd $distdir [% c("var/rezip", { rezip_file => 'Browser/omni.ja' }) %] [% c("var/rezip", { rezip_file => 'Browser/browser/omni.ja' }) %] [% ELSIF c("var/macos") -%] - [% c("var/rezip", { rezip_file => '"' _ c("var/Project_Name") _ '.app/Contents/Resources/omni.ja"' }) %] - [% c("var/rezip", { rezip_file => '"' _ c("var/Project_Name") _ '.app/Contents/Resources/browser/omni.ja"' }) %] + [% c("var/rezip", { rezip_file => '"$app_bundle/Contents/Resources/omni.ja"' }) %] + [% c("var/rezip", { rezip_file => '"$app_bundle/Contents/Resources/browser/omni.ja"' }) %] [% END -%] [% IF c("var/macos"); - SET browserdir='"' _ c("var/Project_Name") _ '.app/Contents"'; + SET browserdir='"$app_bundle/Contents"'; ELSE; SET browserdir='Browser'; END; ===================================== projects/firefox/mozconfig ===================================== @@ -79,7 +79,7 @@ ac_add_options --[% IF c("var/updater_enabled") %]enable[% ELSE %]disable[% END mk_add_options MOZ_PARALLEL_BUILD=[% c("num_procs") %] -export MOZ_APP_REMOTINGNAME="[% c('var/Project_Name_Channel') %]" +export MOZ_APP_REMOTINGNAME="[% c('var/display_name') %]" export MOZ_INCLUDE_SOURCE_INFO=1 export MOZ_SOURCE_REPO="[% c('var/gitlab_project') %]" ===================================== rbm.conf ===================================== @@ -110,6 +110,7 @@ var: [% c(step, { filename => 'f', output_dir => '/out', norec => {} }) %] Project_Name_Channel: '[% c("var/Project_Name") %] [% c("var/channel") FILTER ucfirst %]' + display_name: '[% c("var/Project_Name_Channel") %]' exe_name: firefox locale_ja: ja # When adding new languages, add the equivalent NSIS name to @@ -235,7 +236,7 @@ targets: var: release: 1 channel: release - Project_Name_Channel: '[% c("var/Project_Name") %]' + display_name: '[% c("var/Project_Name") %]' alpha: var: alpha: 1 ===================================== tools/signing/functions ===================================== @@ -39,8 +39,9 @@ function generate_config { p1=$("$rbm" showconf browser var/project-name --target "$SIGNING_PROJECTNAME") p2=$("$rbm" showconf browser var/Project_Name --target "$SIGNING_PROJECTNAME") p3=$("$rbm" showconf browser var/ProjectName --target "$SIGNING_PROJECTNAME") + p4=$("$rbm" showconf browser var/display_name --target "$SIGNING_PROJECTNAME") echo 'rbm_not_available=1' > "$script_dir/set-config.generated-config" - echo "SIGNING_PROJECTNAMES=(\"$p1\" \"$p2\" \"$p3\")" >> "$script_dir/set-config.generated-config" + echo "SIGNING_PROJECTNAMES=(\"$p1\" \"$p2\" \"$p3\" \"$p4\")" >> "$script_dir/set-config.generated-config" } function project-name { @@ -67,4 +68,13 @@ function ProjectName { fi } +function display_name { + if test -n "${rbm_not_available+x}"; then + echo "${SIGNING_PROJECTNAMES[3]}" + else + "$rbm" showconf browser var/display_name --target "$SIGNING_PROJECTNAME" + fi +} + + . "$script_dir/set-config" ===================================== tools/signing/gatekeeper-bundling.sh ===================================== @@ -55,6 +55,7 @@ test -f "$hfstools_file" || \ ProjName=$(ProjectName) Proj_Name=$(Project_Name) proj_name=$(project-name) +disp_name=$(display_name) test -d "$macos_signed_dir" || mkdir "$macos_signed_dir" tmpdir="$macos_stapled_dir/tmp" @@ -71,8 +72,8 @@ cd $tmpdir/dmg tar -xf $macos_stapled_dir/"${proj_name}-${tbb_version}-notarized+stapled.tar.zst" cd .. -$script_dir/ddmg.sh $macos_signed_dir/${proj_name}-macos-${tbb_version}.dmg $tmpdir/dmg/ "$Proj_Name" -rm -rf "dmg/$Proj_Name.app" +$script_dir/ddmg.sh $macos_signed_dir/${proj_name}-macos-${tbb_version}.dmg $tmpdir/dmg/ "$disp_name" +rm -rf "dmg/$disp_name.app" rm -Rf "$tmpdir" # move the signed+stapled dmgs to expected output directory for publishing and mar generation View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.0-1] 100 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 1ff573ba by Eitan Isaacson at 2024-02-13T15:35:55+01:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - ea6ec61f by Pier Angelo Vendrame at 2024-02-13T15:35:56+01:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - cd21687c by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 01db88e3 by Emilio Cobos Álvarez at 2024-02-13T15:35:57+01:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - 20caec70 by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - e76ec667 by Eden Chuang at 2024-02-13T15:35:58+01:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - db29a461 by edgul at 2024-02-13T15:35:58+01:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 9905a6e1 by Kelsey Gilbert at 2024-02-13T15:35:58+01:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 8ed23104 by Mark Banner at 2024-02-13T15:35:59+01:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 94e906d7 by Bob Owen at 2024-02-13T15:35:59+01:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - 55fe491e by Malte Juergens at 2024-02-13T15:35:59+01:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - b0b0a24d by Andreas Pehrson at 2024-02-13T15:36:00+01:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - feabaf38 by Pier Angelo Vendrame at 2024-02-13T15:36:00+01:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 258558af by Kagami Sascha Rosylight at 2024-02-13T15:36:00+01:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - 1cc25fc0 by hackademix at 2024-02-13T15:36:01+01:00 Bug 1867408 - NSS backport - - - - - 96bb18ba by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 38a8d1e5 by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - c6616f5c by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 983c7435 by hackademix at 2024-02-13T15:36:02+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - de24dc95 by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - d631563b by Pier Angelo Vendrame at 2024-02-13T15:36:03+01:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 7d181dcf by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 7212fe93 by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 8d847060 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 4f008554 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 2788c0b2 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 2d6d4513 by Marco Simonelli at 2024-02-13T15:36:05+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - dc1e5d0e by hackademix at 2024-02-13T15:36:05+01:00 Bug 41854: Allow overriding download spam protection. - - - - - 427b5d2a by Gaba at 2024-02-13T15:36:05+01:00 Adding issue and merge request templates - - - - - b65ea961 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 4d9f4c60 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 357b1daa by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 27f02b77 by Dan Ballard at 2024-02-13T15:36:07+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 7cf37922 by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - fd35fdae by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 82735a0b by Mike Perry at 2024-02-13T15:36:08+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - d53822d0 by Alex Catarineu at 2024-02-13T15:36:08+01:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 5063553b by Georg Koppen at 2024-02-13T15:36:08+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - fe24a482 by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 7986c3ef by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - cfd2af09 by Alex Catarineu at 2024-02-13T15:36:09+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 96e9cf00 by Kathy Brade at 2024-02-13T15:36:10+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 059c7544 by Arthur Edelstein at 2024-02-13T15:36:10+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 6d90bfa1 by Alex Catarineu at 2024-02-13T15:36:10+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 8f8de0cc by cypherpunks1 at 2024-02-13T15:36:11+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 53ec05d6 by Pier Angelo Vendrame at 2024-02-13T15:36:13+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - c6b505a2 by Georg Koppen at 2024-02-13T15:36:14+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - d800519b by Alex Catarineu at 2024-02-13T15:36:14+01:00 Bug 28369: Stop shipping pingsender executable - - - - - 886a80a4 by cypherpunks1 at 2024-02-13T15:36:14+01:00 Bug 41568: Disable LaterRun - - - - - de9129ee by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40717: Hide Windows SSO in settings - - - - - 6b1d5bdb by Pier Angelo Vendrame at 2024-02-13T15:36:15+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 00e78e01 by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - 462140d4 by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 2b55e39d by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 42037: Disable about:firefoxview page - - - - - ada81f7b by Mike Perry at 2024-02-13T15:36:16+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 9c5f7f1d by Richard Pospesel at 2024-02-13T15:36:17+01:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 5c3896f3 by Pier Angelo Vendrame at 2024-02-13T15:36:17+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 0c2baaea by Alex Catarineu at 2024-02-13T15:36:17+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 91e3c31f by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 575a2254 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 617aaaf7 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 26345: Hide tracking protection UI - - - - - ea88db06 by Pier Angelo Vendrame at 2024-02-13T15:36:19+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - aabeab37 by Alex Catarineu at 2024-02-13T15:36:19+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 78b3840a by Mike Perry at 2024-02-13T15:36:19+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - cbd37725 by Igor Oliveira at 2024-02-13T15:36:20+01:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - 7a3f5d85 by Pier Angelo Vendrame at 2024-02-13T15:36:20+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 5db07efa by Matthew Finkel at 2024-02-13T15:36:20+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - abd7957d by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 62d5526b by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 95810c87 by hackademix at 2024-02-13T15:36:21+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - a8817d3c by Pier Angelo Vendrame at 2024-02-13T15:36:22+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - de094c82 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 8aaafe35 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 36307532 by hackademix at 2024-02-13T15:36:23+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - a18bf959 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - b33e0367 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 84ab11e9 by hackademix at 2024-02-13T15:36:24+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - be50d348 by Pier Angelo Vendrame at 2024-02-13T15:36:24+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - f92ee37e by p13dz at 2024-02-13T15:36:24+01:00 Bug 40283: Workaround for the file upload bug - - - - - 5737f18d by Arthur Edelstein at 2024-02-13T15:36:25+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d29f9a84 by cypherpunks1 at 2024-02-13T15:36:25+01:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 0b646c54 by Pier Angelo Vendrame at 2024-02-13T15:36:25+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 49c20556 by cypherpunks1 at 2024-02-13T15:36:26+01:00 Bug 41881: Don't persist custom network requests on private windows - - - - - 099112ed by hackademix at 2024-02-13T15:36:26+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 84b6000b by hackademix at 2024-02-13T15:36:26+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - e3e3fcb3 by Pier Angelo Vendrame at 2024-02-13T15:36:27+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - f4dfff28 by Henry Wilkes at 2024-02-13T15:36:27+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 692451a7 by Kathy Brade at 2024-02-13T15:36:27+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 928a5aab by Pier Angelo Vendrame at 2024-02-13T15:36:28+01:00 Bug 42061: Create an alpha update channel. - - - - - 6d0eb8d0 by Nicolas Vigier at 2024-02-13T15:36:30+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 38e720ec by hackademix at 2024-02-13T15:36:30+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 0946a79a by Pier Angelo Vendrame at 2024-02-13T15:36:30+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - ca13cc77 by Alex Catarineu at 2024-02-13T15:36:31+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - 746f65d8 by Matthew Finkel at 2024-02-13T15:36:31+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 2dbae111 by Henry Wilkes at 2024-02-13T15:36:31+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 4ed98f58 by hackademix at 2024-02-13T15:36:32+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - b58ebedd by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 0b624e2c by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40926: Implemented the New Identity feature - - - - - 44562cdf by Henry Wilkes at 2024-02-13T15:36:33+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - 63c89ddb by Pier Angelo Vendrame at 2024-02-13T15:36:33+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 30 changed files: - .eslintignore - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-addons.js - browser/base/content/browser-context.inc - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.8.0esr-13.5-1] 111 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 575f9a75 by Eitan Isaacson at 2024-02-13T15:21:45+01:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - 8f0c3108 by Pier Angelo Vendrame at 2024-02-13T15:21:46+01:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 06a86d8b by Pier Angelo Vendrame at 2024-02-13T15:21:47+01:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 25d29308 by Emilio Cobos Álvarez at 2024-02-13T15:21:47+01:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - d5e2ef76 by Pier Angelo Vendrame at 2024-02-13T15:21:48+01:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - f04fb0bc by Eden Chuang at 2024-02-13T15:21:48+01:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - ec9fd1fe by edgul at 2024-02-13T15:21:49+01:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 080b44fe by Kelsey Gilbert at 2024-02-13T15:21:49+01:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 40262776 by Mark Banner at 2024-02-13T15:21:50+01:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 2650578c by Pier Angelo Vendrame at 2024-02-13T15:21:50+01:00 Bug 1849186 - Add a preference not to expose the content title in the window title. r=Gijs,tabbrowser-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D190496 - - - - - 9c0d3fb2 by Bob Owen at 2024-02-13T15:21:51+01:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - a2864fbb by Malte Juergens at 2024-02-13T15:21:51+01:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - eac9320f by Andreas Pehrson at 2024-02-13T15:21:52+01:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - 9f804aef by Pier Angelo Vendrame at 2024-02-13T15:21:52+01:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 1feaeb32 by Kagami Sascha Rosylight at 2024-02-13T15:21:53+01:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - e51c9738 by hackademix at 2024-02-13T15:21:53+01:00 Bug 1867408 - NSS backport - - - - - e0c4c8a3 by Tom Ritter at 2024-02-13T15:21:54+01:00 Bug 1873526: Refactor the restriction override list from a big if statement to a list r=KrisWright Differential Revision: https://phabricator.services.mozilla.com/D198081 - - - - - 588c834e by Pier Angelo Vendrame at 2024-02-13T15:21:54+01:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 6cd866c9 by Pier Angelo Vendrame at 2024-02-13T15:21:55+01:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1723b812 by Henry Wilkes at 2024-02-13T15:21:55+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 83211dd0 by hackademix at 2024-02-13T15:21:56+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 65581903 by Henry Wilkes at 2024-02-13T15:21:56+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - a6b79017 by Pier Angelo Vendrame at 2024-02-13T15:21:57+01:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 629965e3 by Marco Simonelli at 2024-02-13T15:21:57+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 8ef60544 by Marco Simonelli at 2024-02-13T15:21:58+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 15191d67 by Marco Simonelli at 2024-02-13T15:21:58+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 8106641d by Marco Simonelli at 2024-02-13T15:21:59+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 7082e976 by Marco Simonelli at 2024-02-13T15:21:59+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 973e915b by Marco Simonelli at 2024-02-13T15:22:00+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 199c3cf2 by hackademix at 2024-02-13T15:22:00+01:00 Bug 41854: Allow overriding download spam protection. - - - - - 666bdd7a by Gaba at 2024-02-13T15:22:14+01:00 Adding issue and merge request templates - - - - - b3c41c49 by Pier Angelo Vendrame at 2024-02-13T15:22:14+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 73718692 by Pier Angelo Vendrame at 2024-02-13T15:22:15+01:00 fixup! Base Browser's .mozconfigs. Bug 42399: Start minifying JS again - - - - - 207193f9 by Pier Angelo Vendrame at 2024-02-13T15:22:15+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 8643a76c by Pier Angelo Vendrame at 2024-02-13T15:22:16+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - cdd4aa24 by Dan Ballard at 2024-02-13T15:22:16+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 3607c520 by Matthew Finkel at 2024-02-13T15:22:17+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 56fcef94 by Matthew Finkel at 2024-02-13T15:22:17+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 219d0fb9 by Mike Perry at 2024-02-13T15:22:18+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 38cb1ae5 by Alex Catarineu at 2024-02-13T15:22:18+01:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 4f231365 by Georg Koppen at 2024-02-13T15:22:19+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - afa6a7d5 by Kathy Brade at 2024-02-13T15:22:19+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - aaa29312 by Kathy Brade at 2024-02-13T15:22:20+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 95f1790c by Alex Catarineu at 2024-02-13T15:22:20+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - dfbdbb34 by Kathy Brade at 2024-02-13T15:22:21+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - bc8efdfe by Arthur Edelstein at 2024-02-13T15:22:21+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 40f2e002 by Alex Catarineu at 2024-02-13T15:22:22+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - c13be306 by cypherpunks1 at 2024-02-13T15:22:22+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - a91b5145 by Pier Angelo Vendrame at 2024-02-13T15:22:23+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 4b3a6313 by Georg Koppen at 2024-02-13T15:22:23+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 55e73d85 by Alex Catarineu at 2024-02-13T15:22:24+01:00 Bug 28369: Stop shipping pingsender executable - - - - - a219405b by cypherpunks1 at 2024-02-13T15:22:24+01:00 Bug 41568: Disable LaterRun - - - - - b866cbec by cypherpunks1 at 2024-02-13T15:22:25+01:00 Bug 40717: Hide Windows SSO in settings - - - - - 134ab13d by Pier Angelo Vendrame at 2024-02-13T15:22:25+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 89e1ffe6 by cypherpunks1 at 2024-02-13T15:22:26+01:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - d5d5a994 by Richard Pospesel at 2024-02-13T15:22:26+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 7b2d0ec6 by Richard Pospesel at 2024-02-13T15:22:27+01:00 Bug 42037: Disable about:firefoxview page - - - - - 3e741037 by Mike Perry at 2024-02-13T15:22:27+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 1cea5b73 by Richard Pospesel at 2024-02-13T15:22:28+01:00 Bug 41659: Add canonical color definitions to base-browser - - - - - d54628fd by Pier Angelo Vendrame at 2024-02-13T15:22:33+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - f2525219 by Alex Catarineu at 2024-02-13T15:22:34+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 8d7f4754 by Alex Catarineu at 2024-02-13T15:22:34+01:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - b23dc33c by Alex Catarineu at 2024-02-13T15:22:35+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - dd24a704 by Alex Catarineu at 2024-02-13T15:22:35+01:00 Bug 26345: Hide tracking protection UI - - - - - ee46a19f by Pier Angelo Vendrame at 2024-02-13T15:22:36+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 9d859dd4 by Pier Angelo Vendrame at 2024-02-13T15:22:36+01:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Add a method to query whether the browser is in portable mode. - - - - - 50cb1c09 by Alex Catarineu at 2024-02-13T15:22:37+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - cba78274 by Mike Perry at 2024-02-13T15:22:37+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 37c62975 by Igor Oliveira at 2024-02-13T15:22:38+01:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - 3dbdfabf by Pier Angelo Vendrame at 2024-02-13T15:22:38+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 43446e4a by Matthew Finkel at 2024-02-13T15:22:39+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - f97c3f6a by cypherpunks1 at 2024-02-13T15:22:39+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 4126a02e by cypherpunks1 at 2024-02-13T15:22:40+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - a9030f72 by hackademix at 2024-02-13T15:22:40+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - 2be86862 by Pier Angelo Vendrame at 2024-02-13T15:22:41+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 2e555351 by hackademix at 2024-02-13T15:22:41+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 5d5a1d4c by hackademix at 2024-02-13T15:22:42+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 87e49198 by hackademix at 2024-02-13T15:22:42+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 3e3ea4bd by hackademix at 2024-02-13T15:22:43+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - e0ba5aff by hackademix at 2024-02-13T15:22:43+01:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 62101670 by hackademix at 2024-02-13T15:22:44+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 41917: Make the appearance of letterboxing look more intentional - - - - - a4292edd by hackademix at 2024-02-13T15:22:44+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42387: hide visual artifacts and fix the status label on rounded letterboxing borders. - - - - - e3977be7 by hackademix at 2024-02-13T15:22:45+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42389: make the betterboxing gradient actually work. - - - - - 46190662 by hackademix at 2024-02-13T15:22:45+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42390: hide the browser border decorator when corners are flat. - - - - - a9b1a4b6 by hackademix at 2024-02-13T15:22:46+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 35f298ca by Pier Angelo Vendrame at 2024-02-13T15:22:46+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 3924ebd4 by p13dz at 2024-02-13T15:22:47+01:00 Bug 40283: Workaround for the file upload bug - - - - - adef0626 by Arthur Edelstein at 2024-02-13T15:22:47+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 801a7497 by cypherpunks1 at 2024-02-13T15:22:48+01:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 3b017365 by Pier Angelo Vendrame at 2024-02-13T15:22:56+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - b93129e1 by cypherpunks1 at 2024-02-13T15:22:56+01:00 Bug 41881: Don't persist custom network requests on private windows - - - - - dbd7bd88 by hackademix at 2024-02-13T15:22:57+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 2791c55e by hackademix at 2024-02-13T15:22:57+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 791e1fb0 by hackademix at 2024-02-13T15:22:58+01:00 Bug 42397: Change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 69be30b1 by Pier Angelo Vendrame at 2024-02-13T15:22:58+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 24818ff5 by Pier Angelo Vendrame at 2024-02-13T15:22:59+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - d7ef31bb by Henry Wilkes at 2024-02-13T15:22:59+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 5e37d853 by Kathy Brade at 2024-02-13T15:23:00+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 3d48316e by Pier Angelo Vendrame at 2024-02-13T15:23:00+01:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Allow running the postupdate process and change the update directory for when not running in portable mode. - - - - - fd8b4b0b by Pier Angelo Vendrame at 2024-02-13T15:23:01+01:00 Bug 42061: Create an alpha update channel. - - - - - 557699f1 by Nicolas Vigier at 2024-02-13T15:23:01+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 61f6b05c by hackademix at 2024-02-13T15:23:02+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - a767ea91 by Pier Angelo Vendrame at 2024-02-13T15:23:02+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 94ea5de3 by Alex Catarineu at 2024-02-13T15:23:03+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - 33f47cca by Matthew Finkel at 2024-02-13T15:23:03+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - d5c63a4f by Henry Wilkes at 2024-02-13T15:23:04+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 0a593f8b by hackademix at 2024-02-13T15:23:04+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - d5aa067f by Pier Angelo Vendrame at 2024-02-13T15:23:05+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - e4efdf1e by Pier Angelo Vendrame at 2024-02-13T15:23:05+01:00 Bug 40926: Implemented the New Identity feature - - - - - c168d7da by Henry Wilkes at 2024-02-13T15:23:06+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - 2f6b8028 by Pier Angelo Vendrame at 2024-02-13T15:23:06+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 30 changed files: - .eslintignore - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-addons.js - browser/base/content/browser-context.inc - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.8.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag base-browser-115.8.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new branch base-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.8.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag tor-browser-115.8.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.8.0esr-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag tor-browser-115.8.0esr-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.8.0esr-13.0-1-build1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag base-browser-115.8.0esr-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new branch base-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.5-1] 195 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 575f9a75 by Eitan Isaacson at 2024-02-13T15:21:45+01:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - 8f0c3108 by Pier Angelo Vendrame at 2024-02-13T15:21:46+01:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 06a86d8b by Pier Angelo Vendrame at 2024-02-13T15:21:47+01:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 25d29308 by Emilio Cobos Álvarez at 2024-02-13T15:21:47+01:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - d5e2ef76 by Pier Angelo Vendrame at 2024-02-13T15:21:48+01:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - f04fb0bc by Eden Chuang at 2024-02-13T15:21:48+01:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - ec9fd1fe by edgul at 2024-02-13T15:21:49+01:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 080b44fe by Kelsey Gilbert at 2024-02-13T15:21:49+01:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 40262776 by Mark Banner at 2024-02-13T15:21:50+01:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 2650578c by Pier Angelo Vendrame at 2024-02-13T15:21:50+01:00 Bug 1849186 - Add a preference not to expose the content title in the window title. r=Gijs,tabbrowser-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D190496 - - - - - 9c0d3fb2 by Bob Owen at 2024-02-13T15:21:51+01:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - a2864fbb by Malte Juergens at 2024-02-13T15:21:51+01:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - eac9320f by Andreas Pehrson at 2024-02-13T15:21:52+01:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - 9f804aef by Pier Angelo Vendrame at 2024-02-13T15:21:52+01:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 1feaeb32 by Kagami Sascha Rosylight at 2024-02-13T15:21:53+01:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - e51c9738 by hackademix at 2024-02-13T15:21:53+01:00 Bug 1867408 - NSS backport - - - - - e0c4c8a3 by Tom Ritter at 2024-02-13T15:21:54+01:00 Bug 1873526: Refactor the restriction override list from a big if statement to a list r=KrisWright Differential Revision: https://phabricator.services.mozilla.com/D198081 - - - - - 588c834e by Pier Angelo Vendrame at 2024-02-13T15:21:54+01:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 6cd866c9 by Pier Angelo Vendrame at 2024-02-13T15:21:55+01:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1723b812 by Henry Wilkes at 2024-02-13T15:21:55+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 83211dd0 by hackademix at 2024-02-13T15:21:56+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 65581903 by Henry Wilkes at 2024-02-13T15:21:56+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - a6b79017 by Pier Angelo Vendrame at 2024-02-13T15:21:57+01:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 629965e3 by Marco Simonelli at 2024-02-13T15:21:57+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 8ef60544 by Marco Simonelli at 2024-02-13T15:21:58+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 15191d67 by Marco Simonelli at 2024-02-13T15:21:58+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 8106641d by Marco Simonelli at 2024-02-13T15:21:59+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 7082e976 by Marco Simonelli at 2024-02-13T15:21:59+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 973e915b by Marco Simonelli at 2024-02-13T15:22:00+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 199c3cf2 by hackademix at 2024-02-13T15:22:00+01:00 Bug 41854: Allow overriding download spam protection. - - - - - 666bdd7a by Gaba at 2024-02-13T15:22:14+01:00 Adding issue and merge request templates - - - - - b3c41c49 by Pier Angelo Vendrame at 2024-02-13T15:22:14+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 73718692 by Pier Angelo Vendrame at 2024-02-13T15:22:15+01:00 fixup! Base Browser's .mozconfigs. Bug 42399: Start minifying JS again - - - - - 207193f9 by Pier Angelo Vendrame at 2024-02-13T15:22:15+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 8643a76c by Pier Angelo Vendrame at 2024-02-13T15:22:16+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - cdd4aa24 by Dan Ballard at 2024-02-13T15:22:16+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 3607c520 by Matthew Finkel at 2024-02-13T15:22:17+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 56fcef94 by Matthew Finkel at 2024-02-13T15:22:17+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 219d0fb9 by Mike Perry at 2024-02-13T15:22:18+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 38cb1ae5 by Alex Catarineu at 2024-02-13T15:22:18+01:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 4f231365 by Georg Koppen at 2024-02-13T15:22:19+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - afa6a7d5 by Kathy Brade at 2024-02-13T15:22:19+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - aaa29312 by Kathy Brade at 2024-02-13T15:22:20+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 95f1790c by Alex Catarineu at 2024-02-13T15:22:20+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - dfbdbb34 by Kathy Brade at 2024-02-13T15:22:21+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - bc8efdfe by Arthur Edelstein at 2024-02-13T15:22:21+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 40f2e002 by Alex Catarineu at 2024-02-13T15:22:22+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - c13be306 by cypherpunks1 at 2024-02-13T15:22:22+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - a91b5145 by Pier Angelo Vendrame at 2024-02-13T15:22:23+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 4b3a6313 by Georg Koppen at 2024-02-13T15:22:23+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 55e73d85 by Alex Catarineu at 2024-02-13T15:22:24+01:00 Bug 28369: Stop shipping pingsender executable - - - - - a219405b by cypherpunks1 at 2024-02-13T15:22:24+01:00 Bug 41568: Disable LaterRun - - - - - b866cbec by cypherpunks1 at 2024-02-13T15:22:25+01:00 Bug 40717: Hide Windows SSO in settings - - - - - 134ab13d by Pier Angelo Vendrame at 2024-02-13T15:22:25+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 89e1ffe6 by cypherpunks1 at 2024-02-13T15:22:26+01:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - d5d5a994 by Richard Pospesel at 2024-02-13T15:22:26+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 7b2d0ec6 by Richard Pospesel at 2024-02-13T15:22:27+01:00 Bug 42037: Disable about:firefoxview page - - - - - 3e741037 by Mike Perry at 2024-02-13T15:22:27+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 1cea5b73 by Richard Pospesel at 2024-02-13T15:22:28+01:00 Bug 41659: Add canonical color definitions to base-browser - - - - - d54628fd by Pier Angelo Vendrame at 2024-02-13T15:22:33+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - f2525219 by Alex Catarineu at 2024-02-13T15:22:34+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 8d7f4754 by Alex Catarineu at 2024-02-13T15:22:34+01:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - b23dc33c by Alex Catarineu at 2024-02-13T15:22:35+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - dd24a704 by Alex Catarineu at 2024-02-13T15:22:35+01:00 Bug 26345: Hide tracking protection UI - - - - - ee46a19f by Pier Angelo Vendrame at 2024-02-13T15:22:36+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 9d859dd4 by Pier Angelo Vendrame at 2024-02-13T15:22:36+01:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Add a method to query whether the browser is in portable mode. - - - - - 50cb1c09 by Alex Catarineu at 2024-02-13T15:22:37+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - cba78274 by Mike Perry at 2024-02-13T15:22:37+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 37c62975 by Igor Oliveira at 2024-02-13T15:22:38+01:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - 3dbdfabf by Pier Angelo Vendrame at 2024-02-13T15:22:38+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 43446e4a by Matthew Finkel at 2024-02-13T15:22:39+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - f97c3f6a by cypherpunks1 at 2024-02-13T15:22:39+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 4126a02e by cypherpunks1 at 2024-02-13T15:22:40+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - a9030f72 by hackademix at 2024-02-13T15:22:40+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - 2be86862 by Pier Angelo Vendrame at 2024-02-13T15:22:41+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 2e555351 by hackademix at 2024-02-13T15:22:41+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 5d5a1d4c by hackademix at 2024-02-13T15:22:42+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 87e49198 by hackademix at 2024-02-13T15:22:42+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 3e3ea4bd by hackademix at 2024-02-13T15:22:43+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - e0ba5aff by hackademix at 2024-02-13T15:22:43+01:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 62101670 by hackademix at 2024-02-13T15:22:44+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 41917: Make the appearance of letterboxing look more intentional - - - - - a4292edd by hackademix at 2024-02-13T15:22:44+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42387: hide visual artifacts and fix the status label on rounded letterboxing borders. - - - - - e3977be7 by hackademix at 2024-02-13T15:22:45+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42389: make the betterboxing gradient actually work. - - - - - 46190662 by hackademix at 2024-02-13T15:22:45+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42390: hide the browser border decorator when corners are flat. - - - - - a9b1a4b6 by hackademix at 2024-02-13T15:22:46+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 35f298ca by Pier Angelo Vendrame at 2024-02-13T15:22:46+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 3924ebd4 by p13dz at 2024-02-13T15:22:47+01:00 Bug 40283: Workaround for the file upload bug - - - - - adef0626 by Arthur Edelstein at 2024-02-13T15:22:47+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 801a7497 by cypherpunks1 at 2024-02-13T15:22:48+01:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 3b017365 by Pier Angelo Vendrame at 2024-02-13T15:22:56+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - b93129e1 by cypherpunks1 at 2024-02-13T15:22:56+01:00 Bug 41881: Don't persist custom network requests on private windows - - - - - dbd7bd88 by hackademix at 2024-02-13T15:22:57+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 2791c55e by hackademix at 2024-02-13T15:22:57+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 791e1fb0 by hackademix at 2024-02-13T15:22:58+01:00 Bug 42397: Change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 69be30b1 by Pier Angelo Vendrame at 2024-02-13T15:22:58+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 24818ff5 by Pier Angelo Vendrame at 2024-02-13T15:22:59+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - d7ef31bb by Henry Wilkes at 2024-02-13T15:22:59+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 5e37d853 by Kathy Brade at 2024-02-13T15:23:00+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 3d48316e by Pier Angelo Vendrame at 2024-02-13T15:23:00+01:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Allow running the postupdate process and change the update directory for when not running in portable mode. - - - - - fd8b4b0b by Pier Angelo Vendrame at 2024-02-13T15:23:01+01:00 Bug 42061: Create an alpha update channel. - - - - - 557699f1 by Nicolas Vigier at 2024-02-13T15:23:01+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 61f6b05c by hackademix at 2024-02-13T15:23:02+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - a767ea91 by Pier Angelo Vendrame at 2024-02-13T15:23:02+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 94ea5de3 by Alex Catarineu at 2024-02-13T15:23:03+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - 33f47cca by Matthew Finkel at 2024-02-13T15:23:03+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - d5c63a4f by Henry Wilkes at 2024-02-13T15:23:04+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 0a593f8b by hackademix at 2024-02-13T15:23:04+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - d5aa067f by Pier Angelo Vendrame at 2024-02-13T15:23:05+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - e4efdf1e by Pier Angelo Vendrame at 2024-02-13T15:23:05+01:00 Bug 40926: Implemented the New Identity feature - - - - - c168d7da by Henry Wilkes at 2024-02-13T15:23:06+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - 2f6b8028 by Pier Angelo Vendrame at 2024-02-13T15:23:06+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - e7afd81f by Henry Wilkes at 2024-02-13T15:23:35+01:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 35a39322 by Richard Pospesel at 2024-02-13T15:23:36+01:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - d6868d47 by Richard Pospesel at 2024-02-13T15:23:37+01:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 3a1f2ad5 by Henry Wilkes at 2024-02-13T15:23:37+01:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 7ff8f7ba by Kathy Brade at 2024-02-13T15:23:38+01:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 81c4ce51 by Alex Catarineu at 2024-02-13T15:23:38+01:00 Add TorStrings module for localization - - - - - 6f6b0f7d by Henry Wilkes at 2024-02-13T15:23:39+01:00 fixup! Add TorStrings module for localization Bug 42036: Remove old bridge cards. - - - - - 51d48191 by Henry Wilkes at 2024-02-13T15:23:39+01:00 fixup! Add TorStrings module for localization Bug 42036: Remove old strings for replacing bridges. - - - - - 8b5fb631 by Henry Wilkes at 2024-02-13T15:23:40+01:00 fixup! Add TorStrings module for localization Bug 41913: Remove old strings for user provided bridge addresses. - - - - - 4f7692f1 by Henry Wilkes at 2024-02-13T15:23:40+01:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 13cc2064 by Henry Wilkes at 2024-02-13T15:23:41+01:00 fixup! Tor Browser strings Bug 42036: New bridge UI strings. - - - - - ea8540b9 by Henry Wilkes at 2024-02-13T15:23:41+01:00 fixup! Tor Browser strings Bug 42036: Add strings for adding/replacing bridges. - - - - - f17342a1 by Henry Wilkes at 2024-02-13T15:23:42+01:00 fixup! Tor Browser strings Bug 41913: Add strings for user provided bridge dialog. - - - - - d8d645b8 by Henry Wilkes at 2024-02-13T15:23:42+01:00 fixup! Tor Browser strings Bug 42036: Add strings for Lox UI. - - - - - 6da7f446 by Henry Wilkes at 2024-02-13T15:23:43+01:00 fixup! Tor Browser strings Bug 42385: Add lox invite dialog strings. - - - - - 0e4ae5ec by Henry Wilkes at 2024-02-13T15:23:43+01:00 fixup! Tor Browser strings Bug 41814: Use "Tor bridge" instead of "vanilla bridge". - - - - - 1e5f1b3e by Henry Wilkes at 2024-02-13T15:23:44+01:00 Tor Browser localization migration scripts. - - - - - 39d2ec4c by Mike Perry at 2024-02-13T15:23:44+01:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 4362891f by hackademix at 2024-02-13T15:23:45+01:00 Bug 41917: Tor brand-specific styles. - - - - - d98bcb6a by sanketh at 2024-02-13T15:23:45+01:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - f0f48706 by Mike Perry at 2024-02-13T15:23:46+01:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 89a05fa8 by Henry Wilkes at 2024-02-13T15:23:46+01:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - c28d9306 by Pier Angelo Vendrame at 2024-02-13T15:23:47+01:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - e1ec47f7 by Pier Angelo Vendrame at 2024-02-13T15:23:47+01:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 7887e227 by Pier Angelo Vendrame at 2024-02-13T15:23:48+01:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - 62d51146 by Cecylia Bocovich at 2024-02-13T15:23:48+01:00 Lox integration - - - - - 9a184456 by Henry Wilkes at 2024-02-13T15:23:49+01:00 fixup! Lox integration - - - - - ca473548 by Richard Pospesel at 2024-02-13T15:23:49+01:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 558bb45b by Henry Wilkes at 2024-02-13T15:23:50+01:00 fixup! Bug 40597: Implement TorSettings module Bug 42036: Add syncSettings to TorSettings and improve error reporting. - - - - - c7a82e84 by Dan Ballard at 2024-02-13T15:23:50+01:00 fixup! Bug 40597: Implement TorSettings module Bug 42252: Fix typo in documents - - - - - 4783060f by Pier Angelo Vendrame at 2024-02-13T15:23:53+01:00 fixup! Bug 40597: Implement TorSettings module Bug 42384: Use TorSettings's initialization promise to handle race conditions We now have a race condition for which the notification about TorSettings being ready is sent before TorConnect can observe this topic. A while ago, we introduced an initialization promise to TorSettings, therefore we can use it instead of Service.obs and avoid this race condition. Also, fixed quicksettings ignored in TorSettings.setSettings. - - - - - 8232a7b1 by Cecylia Bocovich at 2024-02-13T15:23:53+01:00 fixup! Bug 40597: Implement TorSettings module Implement Lox backend. - - - - - e5b79632 by Henry Wilkes at 2024-02-13T15:23:54+01:00 fixup! Bug 40597: Implement TorSettings module Bug 41913: Add public validateBridgeLines method. - - - - - a98e8ed9 by Arthur Edelstein at 2024-02-13T15:23:54+01:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 7dcb86e9 by Henry Wilkes at 2024-02-13T15:23:55+01:00 Bug 41600: Add a tor circuit display panel. - - - - - dacf92e2 by Pier Angelo Vendrame at 2024-02-13T15:23:55+01:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 59df6eb4 by Pier Angelo Vendrame at 2024-02-13T15:23:56+01:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42368: Do not use API26+ java.nio features - - - - - aafccac5 by Dan Ballard at 2024-02-13T15:23:56+01:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42252: Add support for TorController in firefox-android - - - - - 948b0cbb by Pier Angelo Vendrame at 2024-02-13T15:23:57+01:00 fixup! Bug 42247: Android helpers for the TorProvider Update the cached mSettings whenever someone one the GeckoView side changes any TorSettings settings. - - - - - 9ba886a5 by hackademix at 2024-02-13T15:23:57+01:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - c6f79097 by Amogh Pradeep at 2024-02-13T15:23:58+01:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - f8ee7d13 by Matthew Finkel at 2024-02-13T15:23:58+01:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 439d0180 by Kathy Brade at 2024-02-13T15:23:59+01:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - a445537f by Pier Angelo Vendrame at 2024-02-13T15:23:59+01:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - e3f5199c by Richard Pospesel at 2024-02-13T15:24:00+01:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 9e9f03df by Henry Wilkes at 2024-02-13T15:24:00+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Remove old bridge cards. - - - - - 35bcff29 by Henry Wilkes at 2024-02-13T15:24:01+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Implement new bridge settings UI, ready for Lox. - - - - - bf3c627e by Henry Wilkes at 2024-02-13T15:24:01+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Refactor tor setting dialogs to follow firefox style. Also, move the user focus to their new bridges when the bridge dialogs succeed. - - - - - 374024fd by Henry Wilkes at 2024-02-13T15:24:02+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Replace replace/add bridges section with new design, ready for Lox. - - - - - bfee964c by Henry Wilkes at 2024-02-13T15:24:02+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41913: Add basic validation to user provided bridge dialog, and a confirmation step. - - - - - a4359d86 by Henry Wilkes at 2024-02-13T15:24:03+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Add Lox to settings UI. - - - - - eaa45835 by Henry Wilkes at 2024-02-13T15:24:03+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42385: Add lox invite dialog. - - - - - 9c78e0fa by Henry Wilkes at 2024-02-13T15:24:04+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41814: Use "Tor bridge" instead of "vanilla bridge". - - - - - 825a3807 by Henry Wilkes at 2024-02-13T15:24:05+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: New QR code design. - - - - - 353d1660 by Henry Wilkes at 2024-02-13T18:48:17+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42414: Make address overflow ellipsis show in bridge grid. - - - - - 3078b1cf by Henry Wilkes at 2024-02-13T19:04:48+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42415: Improve focus styling of bridge settings headings. We make sure the focus outline has a 2px offset from the text. Also make the "N days until you unlock:" text semantically a heading for its own section. - - - - - 7d30db52 by Richard Pospesel at 2024-02-13T19:04:52+01:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - d792627e by Pier Angelo Vendrame at 2024-02-13T19:04:52+01:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - 04170ee3 by Henry Wilkes at 2024-02-13T19:04:53+01:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 4ae77925 by Arthur Edelstein at 2024-02-13T19:04:53+01:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 36e7a1af by Pier Angelo Vendrame at 2024-02-13T19:04:53+01:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 6a341cfc by Nicolas Vigier at 2024-02-13T19:04:54+01:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 42293: Don't disable updater when run by torbrowser-launcher flatpak When the TORBROWSER_LAUNCHER environment variable is set (which is set by torbrowser-launcher since version 0.3.7) we assume that Tor Browser is not installed by a Flatkpak. Although torbrowser-launcher itself can be installed by a Flatpak, this should not prevent the updater from working. - - - - - 638b5d57 by Pier Angelo Vendrame at 2024-02-13T19:04:54+01:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Keep the postupdate disabled on Tor Browser - - - - - aa2cbc8b by Kathy Brade at 2024-02-13T19:04:54+01:00 Bug 12647: Support symlinks in the updater. - - - - - 49f32b63 by Kathy Brade at 2024-02-13T19:04:55+01:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 84c05926 by Kathy Brade at 2024-02-13T19:04:55+01:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 78f16ccd by Georg Koppen at 2024-02-13T19:04:55+01:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - cece4f3a by Mike Perry at 2024-02-13T19:04:56+01:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 3b286281 by Alex Catarineu at 2024-02-13T19:04:56+01:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - da9013f1 by Henry Wilkes at 2024-02-13T19:04:56+01:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 91ec34de by Richard Pospesel at 2024-02-13T19:04:57+01:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - c01d9f14 by Kathy Brade at 2024-02-13T19:04:57+01:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 0c843908 by Alex Catarineu at 2024-02-13T19:04:57+01:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 5753b1f2 by Pier Angelo Vendrame at 2024-02-13T19:04:58+01:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - f278dc19 by Pier Angelo Vendrame at 2024-02-13T19:04:58+01:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - b5ec3c39 by Pier Angelo Vendrame at 2024-02-13T19:04:58+01:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 235f186b by Henry Wilkes at 2024-02-13T19:04:59+01:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 44899545 by Dan Ballard at 2024-02-13T19:04:59+01:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - e4ee8332 by Henry Wilkes at 2024-02-13T19:04:59+01:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 9bdb12ae by hackademix at 2024-02-13T19:05:00+01:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - c6436ce5 by Henry Wilkes at 2024-02-13T19:05:00+01:00 Customize moz-toggle for tor-browser. - - - - - 162b3dc5 by Richard Pospesel at 2024-02-13T19:05:00+01:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 5f61167d by Pier Angelo Vendrame at 2024-02-13T19:05:01+01:00 Add built-in bridge lines for Android. Temporary workaround for 13.5a3. We chould revert once tor-browser!877 is merged. - - - - - dd4b537b by Cecylia Bocovich at 2024-02-13T19:05:01+01:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + README.md - − README.txt - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.8.0esr-13.0-1] 148 commits: Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 1ff573ba by Eitan Isaacson at 2024-02-13T15:35:55+01:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - ea6ec61f by Pier Angelo Vendrame at 2024-02-13T15:35:56+01:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - cd21687c by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 01db88e3 by Emilio Cobos Álvarez at 2024-02-13T15:35:57+01:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - 20caec70 by Pier Angelo Vendrame at 2024-02-13T15:35:57+01:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - e76ec667 by Eden Chuang at 2024-02-13T15:35:58+01:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - db29a461 by edgul at 2024-02-13T15:35:58+01:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 9905a6e1 by Kelsey Gilbert at 2024-02-13T15:35:58+01:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 8ed23104 by Mark Banner at 2024-02-13T15:35:59+01:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 94e906d7 by Bob Owen at 2024-02-13T15:35:59+01:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - 55fe491e by Malte Juergens at 2024-02-13T15:35:59+01:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - b0b0a24d by Andreas Pehrson at 2024-02-13T15:36:00+01:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - feabaf38 by Pier Angelo Vendrame at 2024-02-13T15:36:00+01:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 258558af by Kagami Sascha Rosylight at 2024-02-13T15:36:00+01:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - 1cc25fc0 by hackademix at 2024-02-13T15:36:01+01:00 Bug 1867408 - NSS backport - - - - - 96bb18ba by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 38a8d1e5 by Pier Angelo Vendrame at 2024-02-13T15:36:01+01:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - c6616f5c by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 983c7435 by hackademix at 2024-02-13T15:36:02+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - de24dc95 by Henry Wilkes at 2024-02-13T15:36:02+01:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - d631563b by Pier Angelo Vendrame at 2024-02-13T15:36:03+01:00 Bug 41116: Normalize system fonts. System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks. - - - - - 7d181dcf by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 7212fe93 by Marco Simonelli at 2024-02-13T15:36:03+01:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 8d847060 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 4f008554 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 2788c0b2 by Marco Simonelli at 2024-02-13T15:36:04+01:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 2d6d4513 by Marco Simonelli at 2024-02-13T15:36:05+01:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - dc1e5d0e by hackademix at 2024-02-13T15:36:05+01:00 Bug 41854: Allow overriding download spam protection. - - - - - 427b5d2a by Gaba at 2024-02-13T15:36:05+01:00 Adding issue and merge request templates - - - - - b65ea961 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 4d9f4c60 by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 357b1daa by Pier Angelo Vendrame at 2024-02-13T15:36:06+01:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 27f02b77 by Dan Ballard at 2024-02-13T15:36:07+01:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 7cf37922 by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - fd35fdae by Matthew Finkel at 2024-02-13T15:36:07+01:00 Bug 28125: Prevent non-Necko network connections - - - - - 82735a0b by Mike Perry at 2024-02-13T15:36:08+01:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - d53822d0 by Alex Catarineu at 2024-02-13T15:36:08+01:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 5063553b by Georg Koppen at 2024-02-13T15:36:08+01:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - fe24a482 by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 7986c3ef by Kathy Brade at 2024-02-13T15:36:09+01:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - cfd2af09 by Alex Catarineu at 2024-02-13T15:36:09+01:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 96e9cf00 by Kathy Brade at 2024-02-13T15:36:10+01:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 059c7544 by Arthur Edelstein at 2024-02-13T15:36:10+01:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 6d90bfa1 by Alex Catarineu at 2024-02-13T15:36:10+01:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 8f8de0cc by cypherpunks1 at 2024-02-13T15:36:11+01:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 53ec05d6 by Pier Angelo Vendrame at 2024-02-13T15:36:13+01:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - c6b505a2 by Georg Koppen at 2024-02-13T15:36:14+01:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - d800519b by Alex Catarineu at 2024-02-13T15:36:14+01:00 Bug 28369: Stop shipping pingsender executable - - - - - 886a80a4 by cypherpunks1 at 2024-02-13T15:36:14+01:00 Bug 41568: Disable LaterRun - - - - - de9129ee by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40717: Hide Windows SSO in settings - - - - - 6b1d5bdb by Pier Angelo Vendrame at 2024-02-13T15:36:15+01:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 00e78e01 by cypherpunks1 at 2024-02-13T15:36:15+01:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - 462140d4 by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 2b55e39d by Richard Pospesel at 2024-02-13T15:36:16+01:00 Bug 42037: Disable about:firefoxview page - - - - - ada81f7b by Mike Perry at 2024-02-13T15:36:16+01:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 9c5f7f1d by Richard Pospesel at 2024-02-13T15:36:17+01:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 5c3896f3 by Pier Angelo Vendrame at 2024-02-13T15:36:17+01:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 0c2baaea by Alex Catarineu at 2024-02-13T15:36:17+01:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 91e3c31f by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView - - - - - 575a2254 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 617aaaf7 by Alex Catarineu at 2024-02-13T15:36:18+01:00 Bug 26345: Hide tracking protection UI - - - - - ea88db06 by Pier Angelo Vendrame at 2024-02-13T15:36:19+01:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - aabeab37 by Alex Catarineu at 2024-02-13T15:36:19+01:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 78b3840a by Mike Perry at 2024-02-13T15:36:19+01:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - cbd37725 by Igor Oliveira at 2024-02-13T15:36:20+01:00 Bug 23104: Add a default line height compensation Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS. The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height. - - - - - 7a3f5d85 by Pier Angelo Vendrame at 2024-02-13T15:36:20+01:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 5db07efa by Matthew Finkel at 2024-02-13T15:36:20+01:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - abd7957d by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 62d5526b by cypherpunks1 at 2024-02-13T15:36:21+01:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 95810c87 by hackademix at 2024-02-13T15:36:21+01:00 Bug 42288: Allow language spoofing in status messages. - - - - - a8817d3c by Pier Angelo Vendrame at 2024-02-13T15:36:22+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - de094c82 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 8aaafe35 by hackademix at 2024-02-13T15:36:22+01:00 Bug 41434: Letterboxing, improve logging. - - - - - 36307532 by hackademix at 2024-02-13T15:36:23+01:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - a18bf959 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - b33e0367 by hackademix at 2024-02-13T15:36:23+01:00 Bug 32308: use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 84ab11e9 by hackademix at 2024-02-13T15:36:24+01:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - be50d348 by Pier Angelo Vendrame at 2024-02-13T15:36:24+01:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - f92ee37e by p13dz at 2024-02-13T15:36:24+01:00 Bug 40283: Workaround for the file upload bug - - - - - 5737f18d by Arthur Edelstein at 2024-02-13T15:36:25+01:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d29f9a84 by cypherpunks1 at 2024-02-13T15:36:25+01:00 Bug 41740: Change the RFP value of devicePixelRatio to 2 - - - - - 0b646c54 by Pier Angelo Vendrame at 2024-02-13T15:36:25+01:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 49c20556 by cypherpunks1 at 2024-02-13T15:36:26+01:00 Bug 41881: Don't persist custom network requests on private windows - - - - - 099112ed by hackademix at 2024-02-13T15:36:26+01:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 84b6000b by hackademix at 2024-02-13T15:36:26+01:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - e3e3fcb3 by Pier Angelo Vendrame at 2024-02-13T15:36:27+01:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - f4dfff28 by Henry Wilkes at 2024-02-13T15:36:27+01:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 692451a7 by Kathy Brade at 2024-02-13T15:36:27+01:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 928a5aab by Pier Angelo Vendrame at 2024-02-13T15:36:28+01:00 Bug 42061: Create an alpha update channel. - - - - - 6d0eb8d0 by Nicolas Vigier at 2024-02-13T15:36:30+01:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 38e720ec by hackademix at 2024-02-13T15:36:30+01:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 0946a79a by Pier Angelo Vendrame at 2024-02-13T15:36:30+01:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - ca13cc77 by Alex Catarineu at 2024-02-13T15:36:31+01:00 Bug 40069: Add helpers for message passing with extensions - - - - - 746f65d8 by Matthew Finkel at 2024-02-13T15:36:31+01:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 2dbae111 by Henry Wilkes at 2024-02-13T15:36:31+01:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 4ed98f58 by hackademix at 2024-02-13T15:36:32+01:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - b58ebedd by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 0b624e2c by Pier Angelo Vendrame at 2024-02-13T15:36:32+01:00 Bug 40926: Implemented the New Identity feature - - - - - 44562cdf by Henry Wilkes at 2024-02-13T15:36:33+01:00 Bug 41736: Customize toolbar for base-browser. - - - - - 63c89ddb by Pier Angelo Vendrame at 2024-02-13T15:36:33+01:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 06096579 by Richard Pospesel at 2024-02-13T15:36:33+01:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 2cfc71d1 by Richard Pospesel at 2024-02-13T15:36:34+01:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 81c44726 by Henry Wilkes at 2024-02-13T15:36:34+01:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 1aaf0ad3 by Kathy Brade at 2024-02-13T15:36:34+01:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 72717475 by Alex Catarineu at 2024-02-13T15:36:35+01:00 Add TorStrings module for localization - - - - - b2c89b4b by Henry Wilkes at 2024-02-13T15:36:35+01:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 0f10f5bf by Henry Wilkes at 2024-02-13T15:36:35+01:00 Tor Browser localization migration scripts. - - - - - a4d43615 by Mike Perry at 2024-02-13T15:36:35+01:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - be86025b by sanketh at 2024-02-13T15:36:36+01:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - a8a2601f by Mike Perry at 2024-02-13T15:36:36+01:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 172d0f39 by Henry Wilkes at 2024-02-13T15:36:36+01:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - dbdb6f1e by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - bf736c38 by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 2cecd659 by Pier Angelo Vendrame at 2024-02-13T15:36:37+01:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - b5d0467a by Richard Pospesel at 2024-02-13T15:36:38+01:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 87b29fb9 by Arthur Edelstein at 2024-02-13T15:36:38+01:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - f189310a by Pier Angelo Vendrame at 2024-02-13T17:59:22+01:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42338: Make TorDomainIsolator.newCircuitForDomain public again - - - - - 2f2331d4 by Henry Wilkes at 2024-02-13T17:59:22+01:00 Bug 41600: Add a tor circuit display panel. - - - - - 8f2007b7 by hackademix at 2024-02-13T17:59:22+01:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - e5920efb by Amogh Pradeep at 2024-02-13T17:59:22+01:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 1ff16251 by Matthew Finkel at 2024-02-13T17:59:22+01:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 30491081 by Kathy Brade at 2024-02-13T17:59:23+01:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - a09124a4 by Pier Angelo Vendrame at 2024-02-13T17:59:23+01:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - aafc8168 by Richard Pospesel at 2024-02-13T17:59:23+01:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - f203c6e0 by Richard Pospesel at 2024-02-13T17:59:23+01:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - b3f82123 by Henry Wilkes at 2024-02-13T17:59:23+01:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - bdd4c35d by Arthur Edelstein at 2024-02-13T17:59:24+01:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 9cf39f57 by Pier Angelo Vendrame at 2024-02-13T17:59:24+01:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - de9005ce by Nicolas Vigier at 2024-02-13T17:59:24+01:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Bug 42293: Don't disable updater when run by torbrowser-launcher flatpak When the TORBROWSER_LAUNCHER environment variable is set (which is set by torbrowser-launcher since version 0.3.7) we assume that Tor Browser is not installed by a Flatkpak. Although torbrowser-launcher itself can be installed by a Flatpak, this should not prevent the updater from working. - - - - - 354c787e by Kathy Brade at 2024-02-13T17:59:24+01:00 Bug 12647: Support symlinks in the updater. - - - - - 8f708ebd by Kathy Brade at 2024-02-13T17:59:25+01:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 4bc6c157 by Kathy Brade at 2024-02-13T17:59:25+01:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - f2665165 by Georg Koppen at 2024-02-13T17:59:25+01:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 307520b3 by Mike Perry at 2024-02-13T17:59:25+01:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - b4721cca by Alex Catarineu at 2024-02-13T17:59:25+01:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - a31c3ac6 by Henry Wilkes at 2024-02-13T17:59:26+01:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 5f6febc4 by Richard Pospesel at 2024-02-13T17:59:26+01:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - b713c619 by Kathy Brade at 2024-02-13T17:59:26+01:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 2823a6f7 by Alex Catarineu at 2024-02-13T17:59:26+01:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 84397887 by Pier Angelo Vendrame at 2024-02-13T17:59:26+01:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 701ad8ca by Pier Angelo Vendrame at 2024-02-13T17:59:27+01:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 59b69a8f by Pier Angelo Vendrame at 2024-02-13T17:59:27+01:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - fa20074e by Henry Wilkes at 2024-02-13T17:59:27+01:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - a5dcc0f3 by Dan Ballard at 2024-02-13T17:59:27+01:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 53500621 by Henry Wilkes at 2024-02-13T17:59:28+01:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 200d19ec by hackademix at 2024-02-13T17:59:28+01:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 56254e66 by Henry Wilkes at 2024-02-13T17:59:28+01:00 Customize moz-toggle for tor-browser. - - - - - c436030e by Richard Pospesel at 2024-02-13T17:59:28+01:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/71038b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_8_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 14 Feb '24

14 Feb '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_8_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41076: Include the ShellLink plugin in NSIS.
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: a382aeb7 by Pier Angelo Vendrame at 2024-02-13T19:09:27+01:00 Bug 41076: Include the ShellLink plugin in NSIS. We will need this plugin for the Mullvad Browser uninstaller. - - - - - 8deb68f2 by Pier Angelo Vendrame at 2024-02-13T19:09:29+01:00 Bug 41077: Draft the new installer for Mullvad Browser. The installer for Mullvad Browser is going to be different from Tor Browser's, because it will offer both a traditional installation (at the moment only for the current user, to avoid enabling privilege elevation code paths, but still with a control panel entry) and portable "installations". The traditional one will support also setting MB as the default browser and file associations. However, this is quite tricky, and having a base installer to start implementing the feature is helpful. Thus this commit, even though the final installer will be likely changed. - - - - - 15 changed files: - projects/browser/build - projects/browser/config - − projects/browser/windows-installer.nsi - + projects/browser/windows-installer/browser-install.nsi - + projects/browser/windows-installer/browser-portable.nsi - + projects/browser/windows-installer/common.nsh - + projects/browser/windows-installer/defines.nsh.in - + projects/browser/windows-installer/language-map.sh - + projects/browser/windows-installer/languages.nsh - + projects/browser/windows-installer/postupdate.nsi - + projects/browser/windows-installer/registry.nsh - + projects/nsis/ShellLink.cpp - projects/nsis/build - projects/nsis/config - rbm.conf Changes: ===================================== projects/browser/build ===================================== @@ -303,9 +303,27 @@ done export PATH="/var/tmp/dist/nsis/bin:$PATH" mv $rootdir/windows-installer $distdir/windows-installer - cat > $distdir/windows-installer/browser-portable.nsi << 'BROWSER_NSI' -[% INCLUDE 'windows-installer.nsi' %] -BROWSER_NSI + mv $rootdir/defines.nsh $distdir/windows-installer/ + [% IF !c('var/testbuild') -%] + source $distdir/windows-installer/language-map.sh + supported_locales="[% tmpl(c('var/locales').join(' ')) %]" + for code in $supported_locales; do + if [[ -n ${nsis_languages[$code]} ]]; then + echo '!insertmacro MUI_LANGUAGE "'${nsis_languages[$code]}'"' >> $distdir/windows-installer/languages.nsh + fi + done + [% END -%] + + [% IF c('var/mullvad-browser') -%] + pushd $distdir/windows-installer + # While Firefox re-uses the uninstaller for this, we cannot do it, because + # we write the uninstaller from the installer. + # Instead, we need to write an updated postupdate.exe also when updating. + makensis postupdate.nsi + mv postupdate.exe ${TB_STAGE_DIR}/Browser/ + popd + [% END -%] + mv ${TB_STAGE_DIR} $distdir/windows-installer/"[% c('var/Project_Name') %]" mv $distdir/windows-installer ${TB_STAGE_DIR} [% END %] @@ -383,8 +401,13 @@ cd $distdir pushd "$PKG_DIR" makensis browser-portable.nsi # Working around NSIS braindamage - python3 $rootdir/pe_checksum_fix.py browser-install.exe - mv browser-install.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-portable-[% c("var/torbrowser_version") %].exe + python3 $rootdir/pe_checksum_fix.py browser-portable.exe + mv browser-portable.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-portable-[% c("var/torbrowser_version") %].exe + [% IF c('var/mullvad-browser') -%] + makensis browser-install.nsi + python3 $rootdir/pe_checksum_fix.py browser-install.exe + mv browser-install.exe $OUTDIR/[% c("var/project-name") %]-[% c("var/osname") %]-install-[% c("var/torbrowser_version") %].exe + [% END -%] popd [% END %] rm -rf $distdir/${PKG_DIR} ===================================== projects/browser/config ===================================== @@ -120,6 +120,9 @@ input_files: enable: '[% c("var/windows") %]' - filename: windows-installer enable: '[% c("var/windows") %]' + - filename: 'defines.nsh' + content: '[% INCLUDE "windows-installer/defines.nsh.in" %]' + refresh_input: 1 - filename: pe_checksum_fix.py enable: '[% c("var/windows") %]' # To generate a new keystore, see how-to-generate-keystore.txt ===================================== projects/browser/windows-installer.nsi deleted ===================================== @@ -1,169 +0,0 @@ -; NSIS Installer for Tor/Base/Mullvad Browser -; Based on NSIS examples by Joost Verburg. -; Originally adapted to Tor Browser by Moritz Bartl -; https://github.com/moba/tbb-windows-installer -; Released under the zlib/libpng license. - -;-------------------------------- - !include "FileFunc.nsh" - !include "LogicLib.nsh" - !include "MUI2.nsh" - !include "WinVer.nsh" - -;-------------------------------- -; General - ; Location of Tor/Base/Mullvad Browser to put into installer - !define PROGRAM_SOURCE ".\[% c('var/Project_Name') %]\" - -[% IF c("var/channel") == "release"; - SET display_name = c('var/Project_Name'); - ELSIF c("var/testbuild"); - SET display_name = c('var/Project_Name') _ " Testbuild"; - ELSE; - SET display_name = c('var/Project_Name_Channel'); - END --%] - Name "[% display_name %]" - OutFile "browser-install.exe" - - ; Default installation folder - InstallDir "$DESKTOP\[% display_name %]" - - ; Best (but slowest) compression - SetCompressor /SOLID lzma - SetCompressorDictSize 32 - - ; Do not require elevated privileges - RequestExecutionLevel user - - ; Support HiDPI displays - ManifestDPIAware true - -;-------------------------------- -; Metadata - VIProductVersion "[% pc('firefox', 'var/browser_series') %].0.0" - VIAddVersionKey "ProductName" "[% display_name %]" - VIAddVersionKey "ProductVersion" "[% c('var/torbrowser_version') %]" - VIAddVersionKey "FileDescription" "[% display_name %] Portable Installer" - VIAddVersionKey "LegalCopyright" "© [% pc('firefox', 'var/copyright_year') %] [% IF c('var/mullvad-browser') %]Mullvad, Tor Browser and Mozilla Developers[% ELSE %]The Tor Project[% END %]" - -;-------------------------------- -; Interface Configuration - !define MUI_ICON "[% c('var/projectname') %][% IF !c('var/base-browser') %]-[% c('var/channel') %][% END %].ico" - !define MUI_ABORTWARNING - -;-------------------------------- -; Modern UI settings - !define MUI_FINISHPAGE_NOREBOOTSUPPORT ; Reboot not required - !define MUI_FINISHPAGE_RUN - !define MUI_FINISHPAGE_RUN_FUNCTION "StartBrowser" - - ; Misuse the option to show the readme to create the shortcuts. - ; Less ugly than MUI_PAGE_COMPONENTS. - !define MUI_FINISHPAGE_SHOWREADME - !define MUI_FINISHPAGE_SHOWREADME_TEXT "&Add Start Menu && Desktop shortcuts" - !define MUI_FINISHPAGE_SHOWREADME_FUNCTION "CreateShortCuts" - -;-------------------------------- -; Pages - !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists - !insertmacro MUI_PAGE_DIRECTORY - !insertmacro MUI_PAGE_INSTFILES - !insertmacro MUI_PAGE_FINISH - -;-------------------------------- -; Languages - !insertmacro MUI_LANGUAGE "English" ; First language is the default language - !insertmacro MUI_LANGUAGE "Arabic" ; ar - !insertmacro MUI_LANGUAGE "Catalan" ; ca - !insertmacro MUI_LANGUAGE "Czech" ; cs - !insertmacro MUI_LANGUAGE "Danish" ; da - !insertmacro MUI_LANGUAGE "German" ; de - !insertmacro MUI_LANGUAGE "Greek" ; el - !insertmacro MUI_LANGUAGE "Spanish" ; es-ES - !insertmacro MUI_LANGUAGE "Farsi" ; fa - !insertmacro MUI_LANGUAGE "Finnish" ; fi - !insertmacro MUI_LANGUAGE "French" ; fr - !insertmacro MUI_LANGUAGE "ScotsGaelic" ; ga-IE - !insertmacro MUI_LANGUAGE "Hebrew" ; he - !insertmacro MUI_LANGUAGE "Hungarian" ; hu - !insertmacro MUI_LANGUAGE "Indonesian"; id - !insertmacro MUI_LANGUAGE "Icelandic" ; is - !insertmacro MUI_LANGUAGE "Italian" ; it - !insertmacro MUI_LANGUAGE "Japanese" ; ja - !insertmacro MUI_LANGUAGE "Georgian" ; ka - !insertmacro MUI_LANGUAGE "Korean" ; ko - !insertmacro MUI_LANGUAGE "Lithuanian" ; lt - !insertmacro MUI_LANGUAGE "Macedonian" ; mk - !insertmacro MUI_LANGUAGE "Malay" ; ms - ; Burmese - my: not available on NSIS - !insertmacro MUI_LANGUAGE "Norwegian" ; nb-NO - !insertmacro MUI_LANGUAGE "Dutch" ; nl - !insertmacro MUI_LANGUAGE "Polish" ; pl - !insertmacro MUI_LANGUAGE "PortugueseBR" ; pt-BR - !insertmacro MUI_LANGUAGE "Romanian" ; ro - !insertmacro MUI_LANGUAGE "Russian" ; ru - !insertmacro MUI_LANGUAGE "Albanian" ; sq - !insertmacro MUI_LANGUAGE "Swedish" ; sv-SE - !insertmacro MUI_LANGUAGE "Thai" ; th - !insertmacro MUI_LANGUAGE "Turkish" ; tr - !insertmacro MUI_LANGUAGE "Ukrainian" ; uk - !insertmacro MUI_LANGUAGE "Vietnamese" ; vi - !insertmacro MUI_LANGUAGE "SimpChinese" ; zh-hans, zh-cn - !insertmacro MUI_LANGUAGE "TradChinese" ; zh-hant, zh-tw - -;-------------------------------- -; Reserve Files - - ; If you are using solid compression, files that are required before - ; the actual installation should be stored first in the data block, - ; because this will make your installer start faster. - - !insertmacro MUI_RESERVEFILE_LANGDLL - -;-------------------------------- -; Installer Sections - -Section "Browser" SecBrowser - SetOutPath "$INSTDIR" - File /r "${PROGRAM_SOURCE}\*.*" - CreateShortCut "$INSTDIR\[% display_name %].lnk" "$INSTDIR\Browser\[% c('var/exe_name') %].exe" -SectionEnd - -;-------------------------------- -; Installer Functions - -Function .onInit - ${IfNot} ${AtLeastWin7} - MessageBox MB_USERICON|MB_OK "[% c('var/Project_Name') %] requires at least Windows 7" - SetErrorLevel 1 - Quit - ${EndIf} - - ; Don't install on systems that don't support SSE2. The parameter value of - ; 10 is for PF_XMMI64_INSTRUCTIONS_AVAILABLE which will check whether the - ; SSE2 instruction set is available. - System::Call "kernel32::IsProcessorFeaturePresent(i 10)i .R7" - ${If} "$R7" == "0" - MessageBox MB_OK|MB_ICONSTOP "Sorry, [% c('var/Project_Name') %] can't be installed. This version of [% c('var/Project_Name') %] requires a processor with SSE2 support." - Abort - ${EndIf} - - !insertmacro MUI_LANGDLL_DISPLAY -FunctionEnd - -Function CheckIfTargetDirectoryExists - ${If} ${FileExists} "$INSTDIR\*.*" - MessageBox MB_YESNO "The destination directory already exists. Do you want to continue anyway?" IDYES +2 - Abort - ${EndIf} -FunctionEnd - -Function CreateShortcuts - CreateShortCut "$SMPROGRAMS\[% display_name %].lnk" "$INSTDIR\[% IF !system_install_mode -%]Browser\[% END -%][% c('var/exe_name') %].exe" - CreateShortCut "$DESKTOP\[% display_name %].lnk" "$INSTDIR\[% IF !system_install_mode -%]Browser\[% END -%][% c('var/exe_name') %].exe" -FunctionEnd - -Function StartBrowser - ExecShell "open" "$INSTDIR/[% display_name %].lnk" -FunctionEnd ===================================== projects/browser/windows-installer/browser-install.nsi ===================================== @@ -0,0 +1,263 @@ + !include "common.nsh" + !include "registry.nsh" + +;-------------------------------- + OutFile "browser-install.exe" + VIAddVersionKey "FileDescription" "${DISPLAY_NAME} Installer" + + !define DEFAULT_INSTALL_DIR "$LocalAppdata\${APP_DIR}\${NAME_NO_SPACES}\${UPDATE_CHANNEL}" + InstallDir "${DEFAULT_INSTALL_DIR}" + +;-------------------------------- +; Pages + Page custom SetupType SetupTypeLeave + Page custom CustomSetup CustomSetupLeave + ; Disable the directory selection when updating + !define MUI_PAGE_CUSTOMFUNCTION_PRE CustomPageDirectory + !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists + !insertmacro MUI_PAGE_DIRECTORY + !insertmacro MUI_PAGE_INSTFILES + !insertmacro MUI_PAGE_FINISH + + !insertmacro MUI_UNPAGE_CONFIRM + !insertmacro MUI_UNPAGE_INSTFILES + !insertmacro MUI_UNPAGE_FINISH + + ; Languages must be defined after pages + !include "languages.nsh" + +;-------------------------------- +; Installer + +; Path to an existing install. If not empty we are in update mode. +var existingInstall + +; Installation settings +var isCustomMode +var isPortableMode +var createDesktopShortcut + +; Variable used by the setup type page +var typeRadioStandard +var typeRadioCustom +var typeRadioClicked +var typeNextButton + +; Variables used in the custom setup page +var customCheckboxPortable +var customCheckboxDesktop + +Function .onInit + Call CheckRequirements + + !insertmacro MUI_LANGDLL_DISPLAY + + ReadRegStr $existingInstall HKCU "${UNINST_KEY}" "InstallLocation" + StrCpy $createDesktopShortcut "true" +FunctionEnd + +Function SetupType + !insertmacro MUI_HEADER_TEXT "Setup Type" "Choose setup options" + nsDialogs::Create 1018 + Pop $0 + ${If} $0 == error + Abort + ${EndIf} + + ${NSD_CreateLabel} 0 0 100% 18% "Choose the type of setup you prefer." + ${If} $existingInstall == "" + ${NSD_CreateRadioButton} 0 18% 100% 6% "Standard" + Pop $typeRadioStandard + ${NSD_CreateRadioButton} 0 30% 100% 6% "Custom" + Pop $typeRadioCustom + ${Else} + ${NSD_CreateRadioButton} 0 18% 100% 6% "Update your existing installation" + Pop $typeRadioStandard + ${NSD_CreateRadioButton} 0 30% 100% 6% "Portable installation" + Pop $typeRadioCustom + ${EndIf} + ${NSD_OnClick} $typeRadioStandard SetupTypeRadioClick + ${NSD_OnClick} $typeRadioCustom SetupTypeRadioClick + + GetDlgItem $typeNextButton $HWNDPARENT 1 + + ; Re-check radios if the user presses back + ${If} $isCustomMode == "true" + StrCpy $typeRadioClicked $typeRadioCustom + ${Else} + StrCpy $typeRadioClicked $typeRadioStandard + ${EndIf} + ${NSD_Check} $typeRadioClicked + Call SetupTypeUpdate + + nsDialogs::Show +FunctionEnd + +Function SetupTypeRadioClick + Pop $typeRadioClicked + Call SetupTypeUpdate +FunctionEnd + +Function SetupTypeUpdate + ${If} $typeRadioClicked == $typeRadioCustom + StrCpy $isCustomMode "true" + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:$(^NextBtn)" + ${ElseIf} $typeRadioClicked == $typeRadioStandard + StrCpy $isCustomMode "false" + StrCpy $isPortableMode "false" + ${If} $existingInstall == "" + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:$(^InstallBtn)" + ${Else} + SendMessage $typeNextButton ${WM_SETTEXT} 0 "STR:&Update" + ${EndIf} + ${EndIf} +FunctionEnd + +Function SetupTypeLeave + ${If} $typeRadioClicked == $typeRadioCustom + StrCpy $isCustomMode "true" + ${ElseIf} $typeRadioClicked == $typeRadioStandard + StrCpy $isCustomMode "false" + StrCpy $isPortableMode "false" + ${Else} + Abort + ${EndIf} +FunctionEnd + +Function CustomSetup + ${If} $isCustomMode != "true" + Return + ${EndIf} + + !insertmacro MUI_HEADER_TEXT "Custom Setup" "Customize your setup options" + nsDialogs::Create 1018 + Pop $0 + ${If} $0 == error + Abort + ${EndIf} + + ${NSD_CreateCheckbox} 0 18% 100% 6% "Portable installation" + Pop $customCheckboxPortable + ${NSD_CreateCheckbox} 0 30% 100% 6% "Create a desktop shortcut" + Pop $customCheckboxDesktop + ${NSD_OnClick} $customCheckboxPortable CustomSetupCheckboxClick + ${NSD_OnClick} $customCheckboxDesktop CustomSetupCheckboxClick + + ${If} $existingInstall != "" + ; If we already have an installation, this is already portable mode. + StrCpy $isPortableMode "true" + ${NSD_Check} $customCheckboxPortable + EnableWindow $customCheckboxPortable 0 + ${ElseIf} $isPortableMode == "true" + ${NSD_Check} $customCheckboxPortable + ${EndIf} + ${If} $createDesktopShortcut == "true" + ${NSD_Check} $customCheckboxDesktop + ${EndIf} + + nsDialogs::Show +FunctionEnd + +Function CustomSetupUpdate + ${NSD_GetState} $customCheckboxPortable $0 + ${If} $0 == "${BST_CHECKED}" + StrCpy $isPortableMode "true" + ${Else} + StrCpy $isPortableMode "false" + ${EndIf} + + ${NSD_GetState} $customCheckboxDesktop $0 + ${If} $0 == "${BST_CHECKED}" + StrCpy $createDesktopShortcut "true" + ${Else} + StrCpy $createDesktopShortcut "false" + ${EndIf} +FunctionEnd + +Function CustomSetupCheckboxClick + Pop $0 + Call CustomSetupUpdate +FunctionEnd + +Function CustomSetupLeave + Call CustomSetupUpdate +FunctionEnd + +Function CustomPageDirectory + ${If} $isPortableMode == "true" + StrCpy $INSTDIR "${DEFAULT_PORTABLE_DIR}" + ; Always go through this page in portable mode. + Return + ${ElseIf} $existingInstall != "" + ; When updating, force the old directory and skip the page. + StrCpy $INSTDIR $existingInstall + Abort + ${Else} + StrCpy $INSTDIR "${DEFAULT_INSTALL_DIR}" + ${EndIf} + + ${If} $isCustomMode != "true" + ; Standard install, use the default directory and skip the page. + Abort + ${EndIf} +FunctionEnd + +Section "Browser" SecBrowser + SetOutPath "$INSTDIR" + + ${If} $isPortableMode == "true" + File /r "${PROGRAM_SOURCE}\*.*" + CreateShortCut "$INSTDIR\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" + ${Else} + ; Do not use a Browser directory for installs. + File /r "${PROGRAM_SOURCE}\Browser\*.*" + + ; Tell the browser we are not in portable mode anymore. + FileOpen $0 "$INSTDIR\system-install" w + FileClose $0 + + ; Write the uninstaller + WriteUninstaller $INSTDIR\uninstall.exe + + !insertmacro UPDATE_REGISTRY + + CreateShortCut "$SMPROGRAMS\${DISPLAY_NAME}.lnk" "$INSTDIR\${EXE_NAME}" + ${If} $createDesktopShortcut == "true" + CreateShortCut "$DESKTOP\${DISPLAY_NAME}.lnk" "$INSTDIR\${EXE_NAME}" + ${EndIf} + ${EndIf} +SectionEnd + +Function StartBrowser + ${If} $isPortableMode == "true" + ExecShell "open" "$INSTDIR\${DISPLAY_NAME}.lnk" + ${Else} + ExecShell "open" "$INSTDIR\${EXE_NAME}" + ${EndIf} +FunctionEnd + +;-------------------------------- +; Uninstaller +Section "Uninstall" + RMDir /r "$INSTDIR" + DeleteRegKey HKCU "${UNINST_KEY}" + + StrCpy $0 "" + ShellLink::GetShortCutTarget "$SMPROGRAMS\${DISPLAY_NAME}.lnk" + Pop $0 + ${If} $0 == "$INSTDIR\${EXE_NAME}" + Delete "$SMPROGRAMS\${DISPLAY_NAME}.lnk" + ${EndIf} + + StrCpy $0 "" + ShellLink::GetShortCutTarget "$DESKTOP\${DISPLAY_NAME}.lnk" + Pop $0 + ${If} $0 == "$INSTDIR\${EXE_NAME}" + Delete "$DESKTOP\${DISPLAY_NAME}.lnk" + ${EndIf} + + ; TODO: Optionally remove profiles. + ; This operation is not trivial, because it involes finding our installation + ; hash, its associated default profile and making sure it is not shared with + ; another channel/installation. +SectionEnd ===================================== projects/browser/windows-installer/browser-portable.nsi ===================================== @@ -0,0 +1,45 @@ + !include "common.nsh" + +;-------------------------------- + OutFile "browser-portable.exe" + VIAddVersionKey "FileDescription" "${DISPLAY_NAME} Portable Installer" + InstallDir "$DESKTOP\${DISPLAY_NAME}" + +;-------------------------------- +; Pages + ; Misuse the option to show the readme to create the shortcuts. + ; Less ugly than MUI_PAGE_COMPONENTS. + !define MUI_FINISHPAGE_SHOWREADME + !define MUI_FINISHPAGE_SHOWREADME_TEXT "&Add Start Menu && Desktop shortcuts" + !define MUI_FINISHPAGE_SHOWREADME_FUNCTION "CreateShortcuts" + + !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckIfTargetDirectoryExists + !insertmacro MUI_PAGE_DIRECTORY + !insertmacro MUI_PAGE_INSTFILES + !insertmacro MUI_PAGE_FINISH + + ; Languages must be defined after pages + !include "languages.nsh" + +;-------------------------------- +; Installer +Function .onInit + Call CheckRequirements + + !insertmacro MUI_LANGDLL_DISPLAY +FunctionEnd + +Section "Browser" SecBrowser + SetOutPath "$INSTDIR" + File /r "${PROGRAM_SOURCE}\*.*" + CreateShortCut "$INSTDIR\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" +SectionEnd + +Function CreateShortcuts + CreateShortCut "$SMPROGRAMS\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" + CreateShortCut "$DESKTOP\${DISPLAY_NAME}.lnk" "$INSTDIR\Browser\${EXE_NAME}" +FunctionEnd + +Function StartBrowser + ExecShell "open" "$INSTDIR/${DISPLAY_NAME}.lnk" +FunctionEnd ===================================== projects/browser/windows-installer/common.nsh ===================================== @@ -0,0 +1,82 @@ +; Common code for the NSIS Installers for Tor/Base/Mullvad Browser. +; Based on NSIS examples by Joost Verburg. +; Originally adapted to Tor Browser by Moritz Bartl +; https://github.com/moba/tbb-windows-installer +; Released under the zlib/libpng license. + +;-------------------------------- + !include "FileFunc.nsh" + !include "LogicLib.nsh" + !include "MUI2.nsh" + !include "WinVer.nsh" + + !include "defines.nsh" + +;-------------------------------- +; General settings + Name "${DISPLAY_NAME}" + + ; Best (but slowest) compression + SetCompressor /SOLID lzma + SetCompressorDictSize 32 + + ; Do not require elevated privileges. + ; Even for the installer, we install only for the current user, so we do not + ; need high privileges. + RequestExecutionLevel user + + ; Support HiDPI displays + ManifestDPIAware true + +;-------------------------------- +; Version information + VIProductVersion "${VERSION_WINDOWS}" + VIAddVersionKey "ProductName" "${DISPLAY_NAME}" + VIAddVersionKey "ProductVersion" "${VERSION}" + VIAddVersionKey "FileVersion" "${VERSION}" + VIAddVersionKey "LegalCopyright" "${COPYRIGHT_STRING}" + +;-------------------------------- +; Interface Configuration + ; Installer icon + !define MUI_ICON "${ICON_NAME}" + !define MUI_ABORTWARNING + +;-------------------------------- +; Modern UI settings + !define MUI_FINISHPAGE_NOREBOOTSUPPORT ; Reboot not required + !define MUI_FINISHPAGE_RUN + !define MUI_FINISHPAGE_RUN_FUNCTION "StartBrowser" + +;-------------------------------- +; Reserve Files + ; If you are using solid compression, files that are required before + ; the actual installation should be stored first in the data block, + ; because this will make your installer start faster. + !insertmacro MUI_RESERVEFILE_LANGDLL + +;-------------------------------- +; Helper functions +Function CheckRequirements + ${IfNot} ${AtLeastWin7} + MessageBox MB_USERICON|MB_OK "${PROJECT_NAME} requires at least Windows 7" + SetErrorLevel 1 + Quit + ${EndIf} + + ; Don't install on systems that don't support SSE2. The parameter value of + ; 10 is for PF_XMMI64_INSTRUCTIONS_AVAILABLE which will check whether the + ; SSE2 instruction set is available. + System::Call "kernel32::IsProcessorFeaturePresent(i 10)i .R7" + ${If} "$R7" == "0" + MessageBox MB_OK|MB_ICONSTOP "${PROJECT_NAME} requires a processor with SSE2 support." + Quit + ${EndIf} +FunctionEnd + +Function CheckIfTargetDirectoryExists + ${If} ${FileExists} "$INSTDIR\*.*" + MessageBox MB_YESNO "The destination directory already exists. Do you want to continue anyway?" IDYES +2 + Abort + ${EndIf} +FunctionEnd ===================================== projects/browser/windows-installer/defines.nsh.in ===================================== @@ -0,0 +1,52 @@ +;-------------------------------- +; Defines + ; Location of Tor/Base/Mullvad Browser to put into installer + !define PROGRAM_SOURCE ".\[% c('var/Project_Name') %]\" + + ; Project and display name + !define PROJECT_NAME "[% c('var/Project_Name') %]" +[% IF c("var/channel") == "release" -%] + !define DISPLAY_NAME "[% c('var/Project_Name') %]" +[% ELSIF c("var/testbuild") -%] + !define DISPLAY_NAME "[% c('var/Project_Name') %] Testbuild" +[% ELSE -%] + !define DISPLAY_NAME "[% c('var/Project_Name_Channel') %]" +[% END -%] + !define NAME_NO_SPACES "[% c('var/ProjectName') %]" + !define UPDATE_CHANNEL "[% c('var/channel') FILTER ucfirst %]" + + ; Version + !define VERSION "[% c('var/torbrowser_version') %]" + ; String for use with Windows's Product Version. + ; It must be 4 integers separated by a dot. + !define VERSION_WINDOWS "[% pc('firefox', 'var/browser_series') %].0.0" + + !define DEFAULT_PORTABLE_DIR "$DESKTOP\${DISPLAY_NAME}" + !define EXE_NAME "[% c('var/exe_name') %].exe" +[% IF !c("var/base-browser") -%] + !define ICON_NAME "[% c('var/projectname') %]-[% c('var/channel') %].ico" +[% ELSE -%] + !define ICON_NAME "[% c('var/projectname') %].ico" +[% END -%] + +[% IF c('var/mullvad-browser') -%] + ; Firefox's --with-user-appdir + !define APP_DIR "Mullvad" + + !define PUBLISHER "Mullvad VPN" + !define COPYRIGHT_STRING "© [% pc('firefox', 'var/copyright_year') %] Mullvad, Tor Browser and Mozilla Developers" + + !define URL_ABOUT "https://mullvad.net/en/browser" + !define URL_UPDATE "https://github.com/mullvad/mullvad-browser/releases/[% c('var/torbrowser_version') %]" + !define URL_HELP "https://mullvad.net/help/tag/browser/" +[% ELSE -%] + ; Not defined for Tor Browser + !define APP_DIR "TorProject" + + !define PUBLISHER "The Tor Project" + !define COPYRIGHT_STRING "© [% pc('firefox', 'var/copyright_year') %] The Tor Project" + + !define URL_ABOUT "https://www.torproject.org/" + !define URL_UPDATE "https://blog.torproject.org/new[% IF c('var/alpha') %]-alpha[% END %]-release-tor-browser-[% c('var/torbrowser_version') FILTER remove('\.') %]" + !define URL_HELP "https://tb-manual.torproject.org/" +[% END -%] ===================================== projects/browser/windows-installer/language-map.sh ===================================== @@ -0,0 +1,39 @@ +#!/bin/bash +declare -A nsis_languages +nsis_languages[ar]="Arabic" +nsis_languages[ca]="Catalan" +nsis_languages[cs]="Czech" +nsis_languages[da]="Danish" +nsis_languages[de]="German" +nsis_languages[el]="Greek" +nsis_languages[es-ES]="Spanish" +nsis_languages[fa]="Farsi" +nsis_languages[fi]="Finnish" +nsis_languages[fr]="French" +nsis_languages[ga-IE]="ScotsGaelic" +nsis_languages[he]="Hebrew" +nsis_languages[hu]="Hungarian" +nsis_languages[d]="Indonesian" +nsis_languages[is]="Icelandic" +nsis_languages[it]="Italian" +nsis_languages[ja]="Japanese" +nsis_languages[ka]="Georgian" +nsis_languages[ko]="Korean" +nsis_languages[lt]="Lithuanian" +nsis_languages[mk]="Macedonian" +nsis_languages[ms]="Malay" +# nsis_languages[my]="Burmese" # Not available on NSIS +nsis_languages[nb-NO]="Norwegian" +nsis_languages[nl]="Dutch" +nsis_languages[pl]="Polish" +nsis_languages[pt-BR]="PortugueseBR" +nsis_languages[ro]="Romanian" +nsis_languages[ru]="Russian" +nsis_languages[sq]="Albanian" +nsis_languages[sv-SE]="Swedish" +nsis_languages[th]="Thai" +nsis_languages[tr]="Turkish" +nsis_languages[uk]="Ukrainian" +nsis_languages[vi]="Vietnamese" +nsis_languages[zh-CN]="SimpChinese" +nsis_languages[zh-TW]="TradChinese" ===================================== projects/browser/windows-installer/languages.nsh ===================================== @@ -0,0 +1,4 @@ +;-------------------------------- +; Additional languages + !insertmacro MUI_LANGUAGE "English" ; Always available + ; The rest of the languages will be added here during the build. ===================================== projects/browser/windows-installer/postupdate.nsi ===================================== @@ -0,0 +1,28 @@ +!include "FileFunc.nsh" +!include "LogicLib.nsh" + +!include "defines.nsh" +!include "registry.nsh" + +OutFile "postupdate.exe" +Icon "${ICON_NAME}" +RequestExecutionLevel user + +Function .onInit + ${GetOptions} $CMDLINE "/Visible" $0 + IfErrors 0 +2 + SetSilent silent +FunctionEnd + +Section PostUpdate "PostUpdate" + StrCpy $0 "false" + IfFileExists $EXEDIR\system-install 0 +2 + StrCpy $0 "true" + ${If} $0 == "true" + StrCpy $INSTDIR $EXEDIR + !insertmacro UPDATE_REGISTRY + RMDir /r /REBOOTOK $EXEDIR\tobedeleted + ${Else} + RMDir /r $EXEDIR\tobedeleted + ${EndIf} +SectionEnd ===================================== projects/browser/windows-installer/registry.nsh ===================================== @@ -0,0 +1,19 @@ +!define UNINST_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${NAME_NO_SPACES}${UPDATE_CHANNEL}" + +!macro UPDATE_REGISTRY + WriteRegStr HKCU "${UNINST_KEY}" "DisplayName" "${DISPLAY_NAME}" + WriteRegStr HKCU "${UNINST_KEY}" "DisplayIcon" "$\"$INSTDIR\${EXE_NAME}$\"" + WriteRegStr HKCU "${UNINST_KEY}" "DisplayVersion" "${VERSION}" + WriteRegStr HKCU "${UNINST_KEY}" "UninstallString" "$\"$INSTDIR\uninstall.exe$\"" + WriteRegStr HKCU "${UNINST_KEY}" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S" + WriteRegDWORD HKCU "${UNINST_KEY}" "NoModify" "1" + WriteRegDWORD HKCU "${UNINST_KEY}" "NoRepair" "1" + ${GetSize} "$INSTDIR" "/S=0K" $0 $1 $2 + IntFmt $0 "0x%08X" $0 + WriteRegDWORD HKCU "${UNINST_KEY}" "EstimatedSize" "$0" + WriteRegStr HKCU "${UNINST_KEY}" "InstallLocation" "$INSTDIR" + WriteRegStr HKCU "${UNINST_KEY}" "Publisher" "${PUBLISHER}" + WriteRegStr HKCU "${UNINST_KEY}" "URLInfoAbout" "${URL_ABOUT}" + WriteRegStr HKCU "${UNINST_KEY}" "URLUpdateInfo" "${URL_UPDATE}" + WriteRegStr HKCU "${UNINST_KEY}" "HelpLink" "${URL_HELP}" +!macroend ===================================== projects/nsis/ShellLink.cpp ===================================== @@ -0,0 +1,358 @@ +/* +Module : ShellLink.cpp +Purpose: NSIS Plug-in for retriving shell link information +Created: 12/16/2003 +Last Update: 01/14/2004 + +Copyright (c) 2004 Angelo Mandato. +See ShellLink.html for more information + + +Modified: 21/09/2005 +Author: Shengalts Aleksander aka Instructor (Shengalts(a)mail.ru) +Changes: -code has been rewritten + -added functions to change shell link information + -reduced dll size 44Kb -> 4Kb + +Modified by The Tor Project to remove the unneeded ConvFunc.h and updated the +include for pluginapi.h. +The original plugin is available at https://nsis.sourceforge.io/ShellLink_plug-in. + +© 2004 Angelo Mandato + +This software is provided 'as-is', without any express or implied warranty. In +no event will the authors be held liable for any damages arising from the use of +this software. + +Permission is granted to anyone to use this software for any purpose, including +commercial applications, and to alter it and redistribute it freely, subject to +the following restrictions: + +1. The origin of this software must not be misrepresented; you must not claim + that you wrote the original software. If you use this software in a product, + an acknowledgment in the product documentation would be appreciated but is + not required. +2. Altered versions must be plainly marked as such, and must not be + misrepresented as being the original software. +3. This notice may not be removed or altered from any distribution. + +*/ + +// Uncomment for debugging message boxes +//#define SHELLLINK_DEBUG + +#include <windows.h> +#include <shlobj.h> + +#define xatoi +#include "nsis/pluginapi.h" + +#define NSISFUNC(name) extern "C" void __declspec(dllexport) name(HWND hWndParent, int string_size, TCHAR* variables, stack_t** stacktop, extra_parameters* extra) + +#define SHELLLINKTYPE_GETARGS 1 +#define SHELLLINKTYPE_GETDESC 2 +#define SHELLLINKTYPE_GETHOTKEY 3 +#define SHELLLINKTYPE_GETICONLOC 4 +#define SHELLLINKTYPE_GETICONINDEX 5 +#define SHELLLINKTYPE_GETPATH 6 +#define SHELLLINKTYPE_GETSHOWMODE 7 +#define SHELLLINKTYPE_GETWORKINGDIR 8 +#define SHELLLINKTYPE_SETARGS 9 +#define SHELLLINKTYPE_SETDESC 10 +#define SHELLLINKTYPE_SETHOTKEY 11 +#define SHELLLINKTYPE_SETICONLOC 12 +#define SHELLLINKTYPE_SETICONINDEX 13 +#define SHELLLINKTYPE_SETPATH 14 +#define SHELLLINKTYPE_SETSHOWMODE 15 +#define SHELLLINKTYPE_SETWORKINGDIR 16 +#define SHELLLINKTYPE_SETRUNASADMIN 17 + +void ShortCutData(int nType); + +//Get +NSISFUNC(GetShortCutArgs) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETARGS); +} + +NSISFUNC(GetShortCutDescription) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETDESC); +} + +NSISFUNC(GetShortCutHotkey) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETHOTKEY); +} + +NSISFUNC(GetShortCutIconLocation) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETICONLOC); +} + +NSISFUNC(GetShortCutIconIndex) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETICONINDEX); +} + +NSISFUNC(GetShortCutTarget) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETPATH); +} + +NSISFUNC(GetShortCutShowMode) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETSHOWMODE); +} + +NSISFUNC(GetShortCutWorkingDirectory) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_GETWORKINGDIR); +} + +//Set +NSISFUNC(SetShortCutArgs) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETARGS); +} + +NSISFUNC(SetShortCutDescription) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETDESC); +} + +NSISFUNC(SetShortCutHotkey) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETHOTKEY); +} + +NSISFUNC(SetShortCutIconLocation) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETICONLOC); +} + +NSISFUNC(SetShortCutIconIndex) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETICONINDEX); +} + +NSISFUNC(SetShortCutTarget) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETPATH); +} + +NSISFUNC(SetShortCutShowMode) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETSHOWMODE); +} + +NSISFUNC(SetShortCutWorkingDirectory) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETWORKINGDIR); +} + +NSISFUNC(SetRunAsAdministrator) +{ + EXDLL_INIT(); + ShortCutData(SHELLLINKTYPE_SETRUNASADMIN); +} + +void ShortCutData(int nType) +{ + HRESULT hRes; + IShellLink* psl; + IPersistFile* ppf; + + int nBuf; + WORD wHotkey; + TCHAR* szBuf = (TCHAR*)LocalAlloc(LPTR, sizeof(TCHAR)*MAX_PATH); + TCHAR* szBuf2 = (TCHAR*)LocalAlloc(LPTR, sizeof(TCHAR)*MAX_PATH); + + popstring(szBuf); + if (nType > SHELLLINKTYPE_GETWORKINGDIR) popstring(szBuf2); + + hRes=CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, IID_IShellLink, (LPVOID*) &psl); + if (hRes == S_OK) + { + hRes=psl->QueryInterface(IID_IPersistFile, (LPVOID*) &ppf); + if (hRes == S_OK) + { +#ifdef UNICODE + hRes=ppf->Load(szBuf, STGM_READWRITE); +#else + WCHAR* wszPath = (WCHAR*)LocalAlloc(LPTR, sizeof(WCHAR)*MAX_PATH); + MultiByteToWideChar(CP_ACP, 0, szBuf, -1, wszPath, MAX_PATH); + hRes=ppf->Load(wszPath, STGM_READWRITE); + LocalFree(wszPath); +#endif + if (hRes == S_OK) + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) + { + //Get + switch(nType) + { + case SHELLLINKTYPE_GETARGS: + { + hRes=psl->GetArguments(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETDESC: + { + hRes=psl->GetDescription(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETHOTKEY: + { + hRes=psl->GetHotkey(&wHotkey); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), wHotkey); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETICONLOC: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETICONINDEX: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), nBuf); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETPATH: + { + WIN32_FIND_DATA fd; + + hRes=psl->GetPath(szBuf, MAX_PATH, &fd, SLGP_UNCPRIORITY); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETSHOWMODE: + { + hRes=psl->GetShowCmd(&nBuf); + if (hRes == S_OK) wsprintf(szBuf, TEXT("%d"), nBuf); + else szBuf[0]='\0'; + }; break; + case SHELLLINKTYPE_GETWORKINGDIR: + { + hRes=psl->GetWorkingDirectory(szBuf, MAX_PATH); + if (hRes != S_OK) szBuf[0]='\0'; + }; break; + } + } + else + { + //Set + switch(nType) + { + case SHELLLINKTYPE_SETARGS: + { + hRes=psl->SetArguments(szBuf2); + }; break; + case SHELLLINKTYPE_SETDESC: + { + hRes=psl->SetDescription(szBuf2); + }; break; + case SHELLLINKTYPE_SETHOTKEY: + { + wHotkey=(unsigned short)myatoi(szBuf2); + hRes=psl->SetHotkey(wHotkey); + }; break; + case SHELLLINKTYPE_SETICONLOC: + { + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf); + if (hRes == S_OK) + hRes=psl->SetIconLocation(szBuf2, nBuf); + }; break; + case SHELLLINKTYPE_SETICONINDEX: + { + int nBuf2; + nBuf=myatoi(szBuf2); + + hRes=psl->GetIconLocation(szBuf, MAX_PATH, &nBuf2); + if (hRes == S_OK) + hRes=psl->SetIconLocation(szBuf, nBuf); + }; break; + case SHELLLINKTYPE_SETPATH: + { + hRes=psl->SetPath(szBuf2); + }; break; + case SHELLLINKTYPE_SETSHOWMODE: + { + nBuf=myatoi(szBuf2); + hRes=psl->SetShowCmd(nBuf); + }; break; + case SHELLLINKTYPE_SETWORKINGDIR: + { + hRes=psl->SetWorkingDirectory(szBuf2); + }; break; + case SHELLLINKTYPE_SETRUNASADMIN: + { + IShellLinkDataList* pdl; + hRes=psl->QueryInterface(IID_IShellLinkDataList, (void**)&pdl); + if (hRes == S_OK) + { + DWORD dwFlags = 0; + hRes=pdl->GetFlags(&dwFlags); + if (hRes == S_OK && (dwFlags & SLDF_RUNAS_USER) != SLDF_RUNAS_USER) + hRes=pdl->SetFlags(dwFlags | SLDF_RUNAS_USER); + pdl->Release(); + } + }; break; + } + if (hRes == S_OK) hRes=ppf->Save(NULL, FALSE); + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: Save()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + } + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: Load()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("CShellLink::Initialise, Failed in call to QueryInterface for IPersistFile, HRESULT was %x\n"), TEXT("ShellLink plug-in"), MB_OK); + #endif + + // Cleanup: + if (ppf) ppf->Release(); + if (psl) psl->Release(); + } + #ifdef SHELLLINK_DEBUG + else MessageBox(hwndParent, TEXT("ERROR: CoCreateInstance()"), TEXT("ShellLink plug-in"), MB_OK); + #endif + + if (hRes == S_OK) + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) pushstring(szBuf); + else pushstring(TEXT("0")); + } + else + { + if (nType <= SHELLLINKTYPE_GETWORKINGDIR) pushstring(TEXT("")); + else pushstring(TEXT("-1")); + } + + LocalFree(szBuf); + LocalFree(szBuf2); +} + +BOOL WINAPI DllMain(HANDLE hInst, ULONG ul_reason_for_call, LPVOID lpReserved) +{ + return TRUE; +} ===================================== projects/nsis/build ===================================== @@ -30,7 +30,8 @@ EOF chmod +x "$compiler_prefix-gcc" ln -s "$compiler_prefix-clang++" "$compiler_prefix-g++" -cd /var/tmp/build/nsis-[% c('version') %]-src +builddir=/var/tmp/build/nsis-[% c('version') %]-src +cd "$builddir" # These two sed commands also come from build-mingw32-nsis.sh sed -i 's/-Wl,--exclude-libs,msvcrt.a/-Wl,-Xlink=-fixed/' SCons/Config/gnu @@ -60,6 +61,22 @@ patch -p1 < "$rootdir/resource-reproducible.diff" scons [% scons_args %] -j[% c("num_procs") %] || true scons [% scons_args %] scons [% scons_args %] install + +# Plugins +target="[% target %]-unicode" +plugins="/var/tmp/dist/nsis/share/nsis/Plugins/$target" +plugin_lib="$builddir/build/urelease/api/nsis/libpluginapi-$target.a" + +# This is not needed to build installers, but it makes easier to adapt plugins +# outside our build system. +mkdir /var/tmp/dist/nsis/share/nsis/Lib +cp $plugin_lib /var/tmp/dist/nsis/share/nsis/Lib/ + +$compiler_prefix-clang++ -I "$builddir/build/urelease/api" -O2 $plugin_lib \ + -DUNICODE "$rootdir/ShellLink.cpp" \ + -Wl,--no-insert-timestamp -lole32 -luuid -shared -o "$plugins/ShellLink.dll" +llvm-strip "$plugins/ShellLink.dll" + cd /var/tmp/dist [% c('tar', { tar_src => [ project ], ===================================== projects/nsis/config ===================================== @@ -24,3 +24,4 @@ input_files: - name: zlib project: zlib - filename: resource-reproducible.diff + - filename: ShellLink.cpp ===================================== rbm.conf ===================================== @@ -112,6 +112,8 @@ var: Project_Name_Channel: '[% c("var/Project_Name") %] [% c("var/channel") FILTER ucfirst %]' exe_name: firefox locale_ja: ja + # When adding new languages, add the equivalent NSIS name to + # projects/browser/windows-installer/language-map.sh. locales: - ar - ca View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 8475e6c0 by Henry Wilkes at 2024-02-13T18:02:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42415: Improve focus styling of bridge settings headings. We make sure the focus outline has a 2px offset from the text. Also make the "N days until you unlock:" text semantically a heading for its own section. - - - - - 3 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -1525,7 +1525,8 @@ const gLoxStatus = { } if (alertHadFocus && !showAlert) { - // Has become hidden. + // Alert has become hidden, move focus back up to the now revealed details + // area. this._nextUnlockCounterEl.focus(); } else if (detailsHadFocus && showAlert) { this._unlockAlertButton.focus(); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -67,7 +67,11 @@  <hbox class="subcategory" data-category="paneConnection" hidden="true"> - <html:h1 id="torPreferences-bridges-header" tabindex="-1" /> + <html:h1 + id="torPreferences-bridges-header" + class="tor-focusable-heading" + tabindex="-1" + ></html:h1> </hbox> <groupbox id="torPreferences-bridges-group" @@ -157,22 +161,26 @@ <html:div id="tor-bridges-current-header-bar"> <html:h2 id="tor-bridges-current-heading" + class="tor-focusable-heading" tabindex="-1" data-l10n-id="tor-bridges-your-bridges" ></html:h2> <html:span id="tor-bridges-user-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-user" ></html:span> <html:span id="tor-bridges-built-in-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-built-in" ></html:span> <html:span id="tor-bridges-requested-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-requested" ></html:span> - <html:span id="tor-bridges-lox-label"> + <html:span id="tor-bridges-lox-label" class="tor-bridges-source-label"> <html:img id="tor-bridges-lox-label-icon" alt="" /> <html:span data-l10n-id="tor-bridges-source-lox"></html:span> </html:span> @@ -307,11 +315,11 @@ > <html:img alt="" class="tor-bridges-lox-image-inner" /> <html:img alt="" class="tor-bridges-lox-image-outer" /> - <html:div + <html:h3 id="tor-bridges-lox-next-unlock-counter" - class="tor-bridges-lox-intro" + class="tor-bridges-lox-intro tor-focusable-heading" tabindex="-1" - ></html:div> + ></html:h3> <html:ul class="tor-bridges-lox-list"> <html:li id="tor-bridges-lox-next-unlock-gain-bridges" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -70,6 +70,10 @@ /* Bridge settings */ +.tor-focusable-heading:focus-visible { + outline-offset: var(--in-content-focus-outline-offset); +} + .bridge-status-badge { display: flex; min-width: max-content; @@ -210,16 +214,31 @@ } #tor-bridges-current-header-bar { - display: flex; + display: grid; min-width: max-content; + grid-template: "heading source button" min-content / max-content 1fr max-content; align-items: center; border-block-end: 1px solid var(--in-content-border-color); padding-block-end: 16px; margin-block-end: 16px; + white-space: nowrap; } -#tor-bridges-current-header-bar > * { - flex: 0 0 auto; +#tor-bridges-current-heading { + margin: 0; + font-size: inherit; + grid-area: heading; +} + +.tor-bridges-source-label { + margin-inline-start: 2em; + margin-inline-end: 8px; + grid-area: source; + justify-self: end; +} + +#tor-bridges-all-options-button { + grid-area: button; } #tor-bridges-lox-label { @@ -240,13 +259,6 @@ fill: var(--in-content-icon-color); } -#tor-bridges-current-heading { - margin: 0; - margin-inline-end: 2em; - font-size: inherit; - flex: 1 0 auto; -} - .tor-bridges-options-button { padding: 3px; margin: 0; @@ -264,10 +276,6 @@ fill: currentColor; } -#tor-bridges-all-options-button { - margin-inline-start: 8px; -} - #tor-bridges-built-in-display { display: grid; grid-template: @@ -552,7 +560,10 @@ .tor-bridges-lox-intro { grid-area: intro; font-weight: 700; + font-size: inherit; align-self: center; + justify-self: start; + margin: 0; } .tor-bridges-lox-list { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 94081cf4 by Henry Wilkes at 2024-02-13T17:46:34+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42414: Make address overflow ellipsis show in bridge grid. - - - - - 5 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -675,7 +675,7 @@ const gBridgeGrid = { }); } - row.element.querySelector(".tor-bridges-address-cell").textContent = + row.element.querySelector(".tor-bridges-address-cell-text").textContent = bridgeLine; row.statusEl = row.element.querySelector( ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -238,7 +238,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> <html:span class="tor-bridges-status-cell tor-bridges-grid-cell" role="gridcell" ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -487,7 +487,8 @@ const gProvideBridgeDialog = { }); } - rowEl.querySelector(".tor-bridges-address-cell").textContent = bridgeLine; + rowEl.querySelector(".tor-bridges-address-cell-text").textContent = + bridgeLine; this._bridgeGrid.append(rowEl); } ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -82,7 +82,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> </html:span> </html:div> </html:template> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -395,6 +395,9 @@ /* base size */ width: 10em; flex: 1 0 auto; +} + +.tor-bridges-address-cell-text { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 69328375 by Pier Angelo Vendrame at 2024-02-13T15:16:43+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: c0f52a3e by Pier Angelo Vendrame at 2024-02-13T15:16:17+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0f52a3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0f52a3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: a7f6c970 by Pier Angelo Vendrame at 2024-02-13T14:59:52+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f6c97… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f6c97… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41080: Re-pack omni.ja with 7-zip on Android.
by boklm (＠boklm) 09 Feb '24

09 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 56df6e4c by Pier Angelo Vendrame at 2024-02-08T16:06:11+01:00 Bug 41080: Re-pack omni.ja with 7-zip on Android. In this way we can shave a few additional MBs, and get further from the APK size limit. - - - - - 2 changed files: - projects/browser/build.android - rbm Changes: ===================================== projects/browser/build.android ===================================== @@ -24,18 +24,23 @@ cd /var/tmp/build mv $rootdir/[% c('input_files_by_name/noscript') %] "$noscript_path" [%IF c("var/tor-browser") -%] - unzip -j "$apk" assets/omni.ja tar -xaf "$rootdir/[% c("input_files_by_name/tor-expert-bundle") %]" tor/pluggable_transports/pt_config.json - mkdir omni - pushd omni - unzip ../omni.ja - cp ../tor/pluggable_transports/pt_config.json chrome/toolkit/content/global/pt_config.json - [% c('zip', { - zip_src => [ '.' ], - zip_args => '../assets/omni.ja', - }) %] - popd [% END -%] +unzip -j "$apk" assets/omni.ja +mkdir omni +pushd omni +unzip ../omni.ja +[%IF c("var/tor-browser") -%] + cp -a ../tor/pluggable_transports/pt_config.json chrome/toolkit/content/global/pt_config.json +[% END -%] +[% c('zip', { + zip_src => [ '.' ], + zip_args => '../assets/omni.ja', + use_7z => 1, + '7z_bin' => '7zz', + '7z_opts' => '-mx9', + }) %] +popd [% IF c("var/verify_allowed_addons") %] ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit b5e5b04aaf677c4bacfb5ace45598313286bfdf6 +Subproject commit 10c6b24e90e3dc9c2578290a7d82a87b7f4eb9a3 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40071: Add an option to create zip files using 7z
by boklm (＠boklm) 09 Feb '24

09 Feb '24

boklm pushed to branch main at The Tor Project / Applications / RBM Commits: 10c6b24e by Nicolas Vigier at 2024-02-08T13:26:40+01:00 Bug 40071: Add an option to create zip files using 7z - - - - - 2 changed files: - doc/options_misc.asc - lib/RBM/DefaultConfig.pm Changes: ===================================== doc/options_misc.asc ===================================== @@ -41,6 +41,11 @@ zip:: and a +zip_args+ arguments which is usually the destination zip file, and optionally other zip options. By default, GNU options are used in find, but you can disable that with +gnu_utils+. + The 'zip' command will be used to create the zip file, unless + +use_7z+ is set, in which case '7z' will be used instead. In this + case, +7z_bin+ can be used to select the '7z' command (for cases + where the command is '7zz' instead of '7z') and +7z_opts+ can + be used to set additional options to the '7z' command. install_package:: This option can be used in a script when you need to install a ===================================== lib/RBM/DefaultConfig.pm ===================================== @@ -597,14 +597,24 @@ TAR_END #### #### #### - zip => <<ZIP_END, + '7z_bin' => '7z', + zip => <<ZIP_END, [%- SET src = c('zip_src', { error_if_undef => 1 }) -%] [% USE date -%] +[% IF c("use_7z") -%] + tmp7z=\$(mktemp) +[% END -%] find [% src.join(' ') %] -exec touch -m -t [% date.format(c('timestamp'), format = '%Y%m%d%H%M') %] -- {} + find [% src.join(' ') %] [% IF c('gnu_utils') %]-executable[% ELSE %]-perm +0111[% END %] -exec chmod 700 {} \\; find [% src.join(' ') %] ! [% IF c('gnu_utils') %]-executable[% ELSE %]-perm +0111[% END %] -exec chmod 600 {} \\; find [% src.join(' ') %] | sort | \ +[% IF c("use_7z") -%] + cat > "\$tmp7z" + [% c('7z_bin') %] a -tzip -spf [% c('7z_opts') %] [% c('zip_args', { error_if_undef => 1 }) %] "@\$tmp7z" + rm -f "\$tmp7z" +[% ELSE -%] zip -q -@ -X [% c('zip_args', { error_if_undef => 1 }) %] +[% END -%] ZIP_END #### #### View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/10c6b24e90e3dc9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/10c6b24e90e3dc9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40072: Move capture_exec to a separate module
by boklm (＠boklm) 09 Feb '24

09 Feb '24

boklm pushed to branch main at The Tor Project / Applications / RBM Commits: efd874ab by Nicolas Vigier at 2024-02-08T13:13:58+01:00 Bug 40072: Move capture_exec to a separate module Because the RBM and RBM::DefaultConfig modules have circular dependencies, exporting functions from RBM to RBM::DefaultConfig doesn't work, which means that part of the changes for rbm#40068 didn't work. We could fix that by using `RBM::capture_exec` instead of `capture_exec`. An other solution is to make a separate module for `capture_exec`. Since the RBM modules is becoming big, I think it's a good idea to move independent parts to a separate modules. - - - - - 3 changed files: - lib/RBM.pm - + lib/RBM/CaptureExec.pm - lib/RBM/DefaultConfig.pm Changes: ===================================== lib/RBM.pm ===================================== @@ -10,7 +10,6 @@ use YAML::XS qw(LoadFile); use Template; use File::Basename; use IO::Handle; -use Capture::Tiny qw(capture); use File::Temp; use File::Copy; use File::Copy::Recursive qw(fcopy); @@ -18,6 +17,7 @@ use File::Path qw(make_path); use File::Basename; use String::ShellQuote; use Sort::Versions; +use RBM::CaptureExec qw(capture_exec); use RBM::DefaultConfig; use Digest::SHA qw(sha256_hex); use Data::UUID; @@ -29,7 +29,7 @@ use feature "state"; BEGIN { require Exporter; our @ISA = qw(Exporter); - our @EXPORT = qw(exit_error capture_exec); + our @EXPORT = qw(exit_error); } our $config; @@ -308,15 +308,6 @@ sub exit_error { exit (exists $_[1] ? $_[1] : 1); } -sub capture_exec { - my @cmd = @_; - my ($stdout, $stderr, $exit) = capture { - system(@cmd); - }; - return ($stdout, $stderr, $exit == 0, $exit) if wantarray(); - return $stdout; -} - sub set_git_gpg_wrapper { my ($project) = @_; my $w = project_config($project, 'gpg_wrapper'); ===================================== lib/RBM/CaptureExec.pm ===================================== @@ -0,0 +1,21 @@ +package RBM::CaptureExec; + +use Capture::Tiny qw(capture); + +BEGIN { + require Exporter; + our @ISA = qw(Exporter); + our @EXPORT = qw(capture_exec); + our @EXPORT_OK = qw(capture_exec); +} + +sub capture_exec { + my @cmd = @_; + my ($stdout, $stderr, $exit) = capture { + system(@cmd); + }; + return ($stdout, $stderr, $exit == 0, $exit) if wantarray(); + return $stdout; +} + +1; ===================================== lib/RBM/DefaultConfig.pm ===================================== @@ -10,7 +10,8 @@ BEGIN { } use File::Basename; -use RBM qw(capture_exec); +use RBM; +use RBM::CaptureExec qw(capture_exec); use Cwd qw(getcwd); use File::Temp; use File::Path qw(make_path); View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/efd874abee2d4af… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/efd874abee2d4af… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by richard (＠richard) 08 Feb '24

08 Feb '24

richard pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 21866d39 by hackademix at 2024-02-08T14:48:08+00:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42390: hide the browser border decorator when corners are flat. - - - - - 2 changed files: - browser/base/content/browser.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -159,6 +159,7 @@ body { --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); --letterboxing-border-color: var(--letterboxing-bgcolor); + --letterboxing-decorator-visibility: visible; } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -174,7 +175,7 @@ body { > .browserStack:not(.exclude-letterboxing) > .browserDecorator { display: initial; - visibility: visible; + visibility: var(--letterboxing-decorator-visibility); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -684,6 +684,7 @@ class _RFPHelper { borderRadius = ""; } styleChanges.queueIfNeeded(browserParent, { + "--letterboxing-decorator-visibility": borderRadius === 0 ? "hidden" : "", '--letterboxing-border-radius': borderRadius }); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/218… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/218… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by richard (＠richard) 08 Feb '24

08 Feb '24

richard pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: c87452dd by hackademix at 2024-02-08T14:47:01+00:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42390: hide the browser border decorator when corners are flat. - - - - - 2 changed files: - browser/base/content/browser.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -159,6 +159,7 @@ body { --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); --letterboxing-border-color: var(--letterboxing-bgcolor); + --letterboxing-decorator-visibility: visible; } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -174,7 +175,7 @@ body { > .browserStack:not(.exclude-letterboxing) > .browserDecorator { display: initial; - visibility: visible; + visibility: var(--letterboxing-decorator-visibility); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -684,6 +684,7 @@ class _RFPHelper { borderRadius = ""; } styleChanges.queueIfNeeded(browserParent, { + "--letterboxing-decorator-visibility": borderRadius === 0 ? "hidden" : "", '--letterboxing-border-radius': borderRadius }); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c87452d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c87452d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by richard (＠richard) 08 Feb '24

08 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 0efa3dd9 by hackademix at 2024-02-08T14:44:25+00:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42390: hide the browser border decorator when corners are flat. - - - - - 2 changed files: - browser/base/content/browser.css - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -159,6 +159,7 @@ body { --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); --letterboxing-border-color: var(--letterboxing-bgcolor); + --letterboxing-decorator-visibility: visible; } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -174,7 +175,7 @@ body { > .browserStack:not(.exclude-letterboxing) > .browserDecorator { display: initial; - visibility: visible; + visibility: var(--letterboxing-decorator-visibility); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -684,6 +684,7 @@ class _RFPHelper { borderRadius = ""; } styleChanges.queueIfNeeded(browserParent, { + "--letterboxing-decorator-visibility": borderRadius === 0 ? "hidden" : "", '--letterboxing-border-radius': borderRadius }); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0efa3dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0efa3dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 08 Feb '24

08 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 5e1675f4 by Henry Wilkes at 2024-02-08T14:40:56+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: New QR code design. - - - - - 5 changed files: - − browser/components/torpreferences/content/bridge-qr-onion-mask.svg - browser/components/torpreferences/content/bridgeQrDialog.js - browser/components/torpreferences/content/bridgeQrDialog.xhtml - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn Changes: ===================================== browser/components/torpreferences/content/bridge-qr-onion-mask.svg deleted ===================================== @@ -1,4 +0,0 @@ -<?xml version="1.0" encoding="UTF-8" standalone="no"?> -<svg viewBox="0 0 16 16" width="16" height="16" xmlns="http://www.w3.org/2000/svg"> - <path d="M 8 0.5 C 3.85786 0.5 0.5 3.85786 0.5 8 C 0.5 12.1421 3.85786 15.5 8 15.5 C 12.1421 15.5 15.5 12.1421 15.5 8 C 15.5 3.85786 12.1421 0.5 8 0.5 z M 8 1.671875 C 11.4949 1.671875 14.328125 4.50507 14.328125 8 C 14.328125 11.4949 11.4949 14.328125 8 14.328125 L 8 13.25 C 10.89951 13.25 13.25 10.89951 13.25 8 C 13.25 5.10051 10.89951 2.75 8 2.75 L 8 1.671875 z M 8 3.921875 C 10.25231 3.921875 12.078125 5.74772 12.078125 8 C 12.078125 10.25231 10.25231 12.078125 8 12.078125 L 8 11 C 9.65686 11 11 9.65686 11 8 C 11 6.34315 9.65686 5 8 5 L 8 3.921875 z M 8 6.171875 C 9.00965 6.171875 9.828125 6.99036 9.828125 8 C 9.828125 9.00965 9.00965 9.828125 8 9.828125 L 8 6.171875 z " clip-rule="evenodd" fill-rule="evenodd" fill="#000000"/> -</svg> ===================================== browser/components/torpreferences/content/bridgeQrDialog.js ===================================== @@ -19,15 +19,18 @@ window.addEventListener( ); const target = document.getElementById("bridgeQr-target"); const style = window.getComputedStyle(target); - const width = style.width.substr(0, style.width.length - 2); - const height = style.height.substr(0, style.height.length - 2); + // We are assuming that the style width and height have "px" units. + // Trailing "px" is not parsed. + // NOTE: Our QRCode module doesn't seem to use the width or height + // attributes. + const width = parseInt(style.width, 10); + const height = parseInt(style.height, 10); new QRCode(target, { text: bridgeString, width, height, colorDark: style.color, colorLight: style.backgroundColor, - document, }); }, { once: true } ===================================== browser/components/torpreferences/content/bridgeQrDialog.xhtml ===================================== @@ -11,12 +11,9 @@ <dialog id="bridgeQr-dialog" buttons="accept"> <script src="chrome://browser/content/torpreferences/bridgeQrDialog.js" /> - <html:div> - <html:div id="bridgeQr"> - <html:div id="bridgeQr-target" /> - <html:div id="bridgeQr-onionBox" /> - <html:div id="bridgeQr-onion" /> - </html:div> + <html:div id="bridgeQr"> + <html:div id="bridgeQr-target"></html:div> + <html:div id="bridgeQr-icon"></html:div> </html:div> </dialog> </window> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -775,21 +775,25 @@ dialog#torPreferences-requestBridge-dialog > hbox { } /* Show bridge QR dialog */ + #bridgeQr { + flex: 0 0 auto; + align-self: center; /* Some readers don't recognize QRs with inverted colors, so let's make the ones are darker than zeroes. See https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41049 */ --qr-one: black; --qr-zero: white; background: var(--qr-zero); - position: relative; /* Padding is needed in case the dark theme is used so the bits don't blend with whatever the default background color is. */ padding: 10px; - margin: auto; - margin-bottom: 20px; - max-width: max-content; - border-radius: 5px; + margin-block: 4px 8px; + border-radius: 4px; + display: grid; + align-items: center; + justify-items: center; + grid-template: "qr" max-content / max-content; } #bridgeQr-target { @@ -797,27 +801,21 @@ dialog#torPreferences-requestBridge-dialog > hbox { height: 300px; background: var(--qr-zero); color: var(--qr-one); + grid-area: qr; } -#bridgeQr-onionBox { - position: absolute; - width: 70px; - height: 70px; - top: calc(50% - 35px); - left: calc(50% - 35px); - background-color: var(--qr-zero); -} - -#bridgeQr-onion { - position: absolute; - width: 38px; - height: 38px; - top: calc(50% - 19px); - left: calc(50% - 19px); - mask: url("chrome://browser/content/torpreferences/bridge-qr-onion-mask.svg"); - mask-repeat: no-repeat; - mask-size: 38px; - background: var(--qr-one); +#bridgeQr-icon { + /* Share the same grid area as #bridgeQr-target. */ + grid-area: qr; + content: url("chrome://browser/content/torpreferences/bridge.svg"); + padding: 10px; + border-radius: 8px; + box-sizing: content-box; + width: 52px; + height: 52px; + background: var(--qr-zero); + -moz-context-properties: fill; + fill: var(--qr-one); } /* Lox invite dialog */ ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -29,7 +29,6 @@ browser.jar: content/browser/torpreferences/connectionPane.js (content/connectionPane.js) content/browser/torpreferences/connectionPane.xhtml (content/connectionPane.xhtml) content/browser/torpreferences/torPreferences.css (content/torPreferences.css) - content/browser/torpreferences/bridge-qr-onion-mask.svg (content/bridge-qr-onion-mask.svg) content/browser/torpreferences/bridgemoji/BridgeEmoji.js (content/bridgemoji/BridgeEmoji.js) content/browser/torpreferences/bridgemoji/bridge-emojis.json (content/bridgemoji/bridge-emojis.json) content/browser/torpreferences/bridgemoji/annotations.json (content/bridgemoji/annotations.json) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e1675f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e1675f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
by richard (＠richard) 08 Feb '24

08 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 614fe28a by Pier Angelo Vendrame at 2024-02-08T14:13:14+00:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Keep the postupdate disabled on Tor Browser - - - - - 1 changed file: - toolkit/mozapps/update/updater/updater.cpp Changes: ===================================== toolkit/mozapps/update/updater/updater.cpp ===================================== @@ -2955,7 +2955,7 @@ int LaunchCallbackAndPostProcessApps(int argc, NS_tchar** argv, #endif if (argc > callbackIndex) { -#if defined(XP_WIN) && !defined(BASE_BROWSER_UPDATE) +#if defined(XP_WIN) && !defined(TOR_BROWSER) if (gSucceeded) { if (!LaunchWinPostProcess(gInstallDirPath, gPatchDirPath)) { fprintf(stderr, "The post update process was not launched"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/614fe28… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/614fe28… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Bug 42074: 2023 year end campaign for tor browser HomeFragment
by Pier Angelo Vendrame (＠pierov) 08 Feb '24

08 Feb '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 270303e3 by Pier Angelo Vendrame at 2024-02-08T10:04:18+01:00 fixup! Bug 42074: 2023 year end campaign for tor browser HomeFragment Bug 42402: Remove Android YEC strings. Revert "Bug 42074: 2023 year end campaign for tor browser HomeFragment" This reverts commit d8b27ba2c907971912b8b4d5be2e38b82c8fa425. - - - - - 1 changed file: - fenix/app/src/main/res/values/torbrowser_strings.xml Changes: ===================================== fenix/app/src/main/res/values/torbrowser_strings.xml ===================================== @@ -75,26 +75,4 @@  <string name="preferences_tor_prioritize_onions">Prioritize .onion sites</string> - -  - -  - <string name="yec_2023_introduction">Right now, Tor Browser for Android is protecting your privacy!</string> -  -  - <string name="yec_2023_please_donate">This is possible because of donations from our community. If you value the privacy that Tor Browser for Android offers yourself and others, please make a donation today.</string> -  -  -  -  -  -  - <string name="yec_2023_matched_donation">From now until December 31, donations to the Tor Project will be matched one-to-one, up to $%s!</string> -  - <string name="yec_2023_close_button">Close</string> -  - <string name="yec_2023_donate_button">Donate now</string> -  - <string name="yec_2023_free_to_use">Tor Browser for Android will always be free to use—no donation is required to use this app.</string> - </resources> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/270… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/270… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Bug 42074: 2023 year end campaign for tor browser HomeFragment
by Pier Angelo Vendrame (＠pierov) 08 Feb '24

08 Feb '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 46eccd26 by Pier Angelo Vendrame at 2024-02-08T08:54:51+01:00 fixup! Bug 42074: 2023 year end campaign for tor browser HomeFragment Bug 42402: Remove Android YEC strings. Revert "Bug 42074: 2023 year end campaign for tor browser HomeFragment" This reverts commit d8b27ba2c907971912b8b4d5be2e38b82c8fa425. - - - - - 1 changed file: - fenix/app/src/main/res/values/torbrowser_strings.xml Changes: ===================================== fenix/app/src/main/res/values/torbrowser_strings.xml ===================================== @@ -75,26 +75,4 @@  <string name="preferences_tor_prioritize_onions">Prioritize .onion sites</string> - -  - -  - <string name="yec_2023_introduction">Right now, Tor Browser for Android is protecting your privacy!</string> -  -  - <string name="yec_2023_please_donate">This is possible because of donations from our community. If you value the privacy that Tor Browser for Android offers yourself and others, please make a donation today.</string> -  -  -  -  -  -  - <string name="yec_2023_matched_donation">From now until December 31, donations to the Tor Project will be matched one-to-one, up to $%s!</string> -  - <string name="yec_2023_close_button">Close</string> -  - <string name="yec_2023_donate_button">Donate now</string> -  - <string name="yec_2023_free_to_use">Tor Browser for Android will always be free to use—no donation is required to use this app.</string> - </resources> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/46e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/46e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Revert "Update rbm for rbm#40068 and rbm#40069"
by boklm (＠boklm) 08 Feb '24

08 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 125e1e35 by Nicolas Vigier at 2024-02-08T07:45:45+01:00 Revert "Update rbm for rbm#40068 and rbm#40069" Revert until rbm#40072 is fixed. This reverts commit cc41e2d784b213696146fafa514c6f9e667cf007. - - - - - 1 changed file: - rbm Changes: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit 067c30ee4cf3baa1c0b7e3674d785cf9e5bec8fe +Subproject commit b5e5b04aaf677c4bacfb5ace45598313286bfdf6 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Add Tor integration and UI
by Dan Ballard (＠dan) 07 Feb '24

07 Feb '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: f276a2cb by clairehurst at 2024-02-07T23:25:03+00:00 fixup! Add Tor integration and UI - - - - - 1 changed file: - fenix/app/src/main/res/navigation/nav_graph.xml Changes: ===================================== fenix/app/src/main/res/navigation/nav_graph.xml ===================================== @@ -683,10 +683,6 @@ app:exitAnim="@anim/slide_out_left" app:popEnterAnim="@anim/slide_in_left" app:popExitAnim="@anim/slide_out_right" /> - app:enterAnim="@anim/slide_in_right" - app:exitAnim="@anim/slide_out_left" - app:popEnterAnim="@anim/slide_in_left" - app:popExitAnim="@anim/slide_out_right" /> <action android:id="@+id/action_settingsFragment_to_trackingProtectionFragment" app:destination="@id/trackingProtectionFragment" View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/f27… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/f27… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by ma1 (＠ma1) 07 Feb '24

07 Feb '24

ma1 pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 800f6ebf by hackademix at 2024-02-07T18:53:36+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42389: make the betterboxing gradient actually work. - - - - - 1 changed file: - browser/base/content/browser.css Changes: ===================================== browser/base/content/browser.css ===================================== @@ -168,7 +168,6 @@ body { .letterboxing.letterboxing-gradient .browserContainer { background: linear-gradient(283deg, var(--letterboxing-gradient-color1) 0%, var(--letterboxing-gradient-color2) 100%), var(--letterboxing-bgcolor); - box-shadow: rgba(0, 0, 0, 0.5) 0px -1px 2px; } :root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) @@ -231,12 +230,12 @@ body { border-top-right-radius: var(--letterboxing-border-top-radius); width: var(--letterboxing-width) !important; height: var(--letterboxing-height) !important; + background: var(--letterboxing-gradient-color2); } :root:not([inDOMFullscreen]) .letterboxing.letterboxing-ready .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { place-content: var(--letterboxing-vertical-alignment) center; - background: var(--letterboxing-bgcolor); } #toolbar-menubar[autohide="true"] { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/800… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/800… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] 2 commits: fixup! Bug 32308: use direct browser sizing for letterboxing.
by ma1 (＠ma1) 07 Feb '24

07 Feb '24

ma1 pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 444cf832 by hackademix at 2024-02-07T18:50:54+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42387: hide visual artifacts and fix the status label on rounded letterboxing borders. - - - - - 1926178c by hackademix at 2024-02-07T18:51:02+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42389: make the betterboxing gradient actually work. - - - - - 3 changed files: - browser/base/content/browser.css - browser/base/content/tabbrowser.js - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -127,6 +127,11 @@ body { -moz-window-dragging: drag; } +/** + Never modify the following selector without synchronizing + LETTERBOX_CSS_SELECTOR in RFPHelper.sys.jsm, where + --letterboxing-width & --letterboxing-height are actually set. +**/ .letterboxing .browserContainer { /* From Firefox 115 on, .browserContainer layout is flex / column, @@ -137,6 +142,14 @@ body { background: var(--letterboxing-bgcolor); } +.browserDecorator { + display: none; + pointer-events: none; + background: transparent; + position: relative; + z-index: 1; +} + .letterboxing { --letterboxing-border-radius: 8px; --letterboxing-border-top-radius: 0; @@ -145,6 +158,7 @@ body { --letterboxing-bgcolor: var(--tabpanel-background-color); --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); + --letterboxing-border-color: var(--letterboxing-bgcolor); } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -154,7 +168,26 @@ body { .letterboxing.letterboxing-gradient .browserContainer { background: linear-gradient(283deg, var(--letterboxing-gradient-color1) 0%, var(--letterboxing-gradient-color2) 100%), var(--letterboxing-bgcolor); - box-shadow: rgba(0, 0, 0, 0.5) 0px -1px 2px; +} + +:root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) + > .browserStack:not(.exclude-letterboxing) + > .browserDecorator { + display: initial; + visibility: visible; + border-radius: var(--letterboxing-border-radius); + border-top-left-radius: var(--letterboxing-border-top-radius); + border-top-right-radius: var(--letterboxing-border-top-radius); + box-shadow: var(--letterboxing-border-color) 0px 0px .1px inset, var(--letterboxing-border-color) 0 0 .1px; + border: .1px solid var(--letterboxing-border-color); + outline: .1px solid var(--letterboxing-bgcolor); + height: calc(var(--letterboxing-height) + 1px); + top: -1px; +} + +.letterboxing-vcenter .browserDecorator { + height: auto !important; + top: 0 !important; } /* @@ -167,6 +200,7 @@ body { place-self: end left; left: 0; right: 0; + z-index: 2; --letterboxing-status-left-radius: var(--letterboxing-border-radius); --letterboxing-status-right-radius: 0; } @@ -184,18 +218,19 @@ body { .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) #statuspanel-label { border-radius: 0 0 var(--letterboxing-status-right-radius) var(--letterboxing-status-left-radius); + margin: 0; + border: 1px solid var(--letterboxing-border-color); + max-width: calc(var(--letterboxing-width) * .5); } -/** - Never modify the following selector without synchronizing - LETTERBOX_CSS_SELECTOR in RFPHelper.jsm! -**/ .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser { - /* width & height to be dynamically set by RFPHelper.jsm */ box-shadow: 0px 4px 8px 0px var(--letterboxing-shadow-color); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); + width: var(--letterboxing-width) !important; + height: var(--letterboxing-height) !important; + background: var(--letterboxing-gradient-color2); } :root:not([inDOMFullscreen]) .letterboxing.letterboxing-ready .browserContainer:not(.responsive-mode) ===================================== browser/base/content/tabbrowser.js ===================================== @@ -2238,6 +2238,10 @@ stack.className = "browserStack"; stack.appendChild(b); + let decorator = document.createXULElement("hbox"); + decorator.className = "browserDecorator"; + stack.appendChild(decorator); + let browserContainer = document.createXULElement("vbox"); browserContainer.className = "browserContainer"; browserContainer.appendChild(notificationbox); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -447,8 +447,7 @@ class _RFPHelper { // find the rule applying the default letterboxing styles to browsers // preemptively in order to beat race conditions on tab/window creation const LETTERBOX_CSS_URL = "chrome://browser/content/browser.css"; - const LETTERBOX_CSS_SELECTOR = - ".letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser"; + const LETTERBOX_CSS_SELECTOR = ".letterboxing .browserContainer"; for (let ss of document.styleSheets) { if (ss.href !== LETTERBOX_CSS_URL) { continue; @@ -572,8 +571,8 @@ class _RFPHelper { const r = (width, height) => { lastRoundedSize = {width, height}; return { - width: `var(--rdm-width, ${width}px)`, - height: `var(--rdm-height, ${height}px)`, + "--letterboxing-width": `var(--rdm-width, ${width}px)`, + "--letterboxing-height": `var(--rdm-height, ${height}px)`, } }; @@ -637,7 +636,7 @@ class _RFPHelper { for (let [name, value] of Object.entries(props)) { if (style[name] !== value) { this.push(() => { - style.setProperty(name, value, "important"); + style.setProperty(name, value); }); } } @@ -668,8 +667,11 @@ class _RFPHelper { ? // optional UI components such as the notification box, the find bar // or devtools are constraining this browser's size: recompute custom roundDimensions(parentWidth, parentHeight) - : { width: "", height: "" }; // otherwise we can keep the default (rounded) size - styleChanges.queueIfNeeded(aBrowser, roundedInline); + : { + "--letterboxing-width": "", + "--letterboxing-height": "", + }; // otherwise we can keep the default (rounded) size + styleChanges.queueIfNeeded(browserParent, roundedInline); if (lastRoundedSize) { // check wether the letterboxing margin is less than the border radius, and if so flatten the borders View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f7199b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f7199b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by ma1 (＠ma1) 07 Feb '24

07 Feb '24

ma1 pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: c13c55f4 by hackademix at 2024-02-07T18:42:34+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42389: make the betterboxing gradient actually work. - - - - - 1 changed file: - browser/base/content/browser.css Changes: ===================================== browser/base/content/browser.css ===================================== @@ -168,7 +168,6 @@ body { .letterboxing.letterboxing-gradient .browserContainer { background: linear-gradient(283deg, var(--letterboxing-gradient-color1) 0%, var(--letterboxing-gradient-color2) 100%), var(--letterboxing-bgcolor); - box-shadow: rgba(0, 0, 0, 0.5) 0px -1px 2px; } :root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) @@ -231,12 +230,12 @@ body { border-top-right-radius: var(--letterboxing-border-top-radius); width: var(--letterboxing-width) !important; height: var(--letterboxing-height) !important; + background: var(--letterboxing-gradient-color2); } :root:not([inDOMFullscreen]) .letterboxing.letterboxing-ready .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { place-content: var(--letterboxing-vertical-alignment) center; - background: var(--letterboxing-bgcolor); } #toolbar-menubar[autohide="true"] { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c13c55f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c13c55f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] fixup! Base Browser's .mozconfigs.
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: f7199bf2 by Pier Angelo Vendrame at 2024-02-07T16:59:56+00:00 fixup! Base Browser's .mozconfigs. Bug 42399: Start minifying JS again - - - - - 2 changed files: - browser/config/mozconfigs/base-browser-android - mozconfig-android-all Changes: ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -15,9 +15,6 @@ ac_add_options --with-android-ndk=$ANDROID_NDK_HOME ac_add_options --with-android-min-sdk=21 ac_add_options --with-gradle=$GRADLE_HOME/bin/gradle -# https://bugzilla.mozilla.org/show_bug.cgi?id=1758568 -ac_add_options --enable-minify=properties - ac_add_options --enable-strip ac_add_options --enable-install-strip ac_add_options --disable-tests @@ -39,6 +36,7 @@ if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --with-base-browser-version=dev-build + ac_add_options --disable-minify fi if test -z "$WASI_SYSROOT"; then ===================================== mozconfig-android-all ===================================== @@ -3,14 +3,12 @@ export MOZILLA_OFFICIAL=1 ac_add_options --enable-application=mobile/android ac_add_options --disable-compile-environment -# https://bugzilla.mozilla.org/show_bug.cgi?id=1758568 -ac_add_options --enable-minify=properties - if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --without-wasm-sandboxed-libraries ac_add_options --with-base-browser-version=dev-build + ac_add_options --disable-minify fi ac_add_options --with-tor-browser-version=dev-build View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f7199bf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f7199bf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Base Browser's .mozconfigs.
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 0cf32f89 by Pier Angelo Vendrame at 2024-02-07T17:04:25+01:00 fixup! Base Browser's .mozconfigs. Bug 42399: Start minifying JS again - - - - - 2 changed files: - browser/config/mozconfigs/base-browser-android - mozconfig-android-all Changes: ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -15,9 +15,6 @@ ac_add_options --with-android-ndk=$ANDROID_NDK_HOME ac_add_options --with-android-min-sdk=21 ac_add_options --with-gradle=$GRADLE_HOME/bin/gradle -# https://bugzilla.mozilla.org/show_bug.cgi?id=1758568 -ac_add_options --enable-minify=properties - ac_add_options --enable-strip ac_add_options --enable-install-strip ac_add_options --disable-tests @@ -39,6 +36,7 @@ if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --with-base-browser-version=dev-build + ac_add_options --disable-minify fi if test -z "$WASI_SYSROOT"; then ===================================== mozconfig-android-all ===================================== @@ -3,14 +3,12 @@ export MOZILLA_OFFICIAL=1 ac_add_options --enable-application=mobile/android ac_add_options --disable-compile-environment -# https://bugzilla.mozilla.org/show_bug.cgi?id=1758568 -ac_add_options --enable-minify=properties - if test -n "$LOCAL_DEV_BUILD"; then # You must use the "default" bogus channel for dev builds ac_add_options --enable-update-channel=default ac_add_options --without-wasm-sandboxed-libraries ac_add_options --with-base-browser-version=dev-build + ac_add_options --disable-minify fi ac_add_options --with-java-bin-path=$JAVA_HOME/bin View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0cf32f8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0cf32f8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] 2 commits: fixup! Bug 9173: Change the default Firefox profile directory to be relative.
by Pier Angelo Vendrame (＠pierov) 07 Feb '24

07 Feb '24

Pier Angelo Vendrame pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 374f008f by Pier Angelo Vendrame at 2024-02-07T16:38:26+01:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Add a method to query whether the browser is in portable mode. - - - - - 87805801 by Pier Angelo Vendrame at 2024-02-07T16:38:26+01:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Allow running the postupdate process and change the update directory for when not running in portable mode. - - - - - 3 changed files: - toolkit/mozapps/update/updater/updater.cpp - toolkit/xre/nsIXREDirProvider.idl - toolkit/xre/nsXREDirProvider.cpp Changes: ===================================== toolkit/mozapps/update/updater/updater.cpp ===================================== @@ -2807,7 +2807,7 @@ int LaunchCallbackAndPostProcessApps(int argc, NS_tchar** argv, #endif if (argc > callbackIndex) { -#if defined(XP_WIN) && !defined(BASE_BROWSER_UPDATE) +#if defined(XP_WIN) if (gSucceeded) { if (!LaunchWinPostProcess(gInstallDirPath, gPatchDirPath)) { fprintf(stderr, "The post update process was not launched"); ===================================== toolkit/xre/nsIXREDirProvider.idl ===================================== @@ -20,4 +20,9 @@ interface nsIXREDirProvider : nsISupports * Gets the hash for the current installation directory. */ AString getInstallHash(); + + /** + * Tells whether the browser has been started in portable mode. + */ + readonly attribute bool isPortableMode; }; ===================================== toolkit/xre/nsXREDirProvider.cpp ===================================== @@ -1109,7 +1109,14 @@ nsresult nsXREDirProvider::GetUpdateRootDir(nsIFile** aResult, rv = GetUserDataDirectory(getter_AddRefs(updRoot), false); NS_ENSURE_SUCCESS(rv, rv); # else - rv = GetUserDataDirectoryHome(getter_AddRefs(updRoot), false); + bool isPortable = true; + rv = GetIsPortableMode(&isPortable); + NS_ENSURE_SUCCESS(rv, rv); + if (isPortable) { + rv = GetUserDataDirectoryHome(getter_AddRefs(updRoot), false); + } else { + rv = GetUserDataDirectory(getter_AddRefs(updRoot), true); + } NS_ENSURE_SUCCESS(rv, rv); # endif rv = updRoot->AppendNative("UpdateInfo"_ns); @@ -1324,6 +1331,20 @@ nsresult nsXREDirProvider::GetPortableDataDir(nsIFile** aFile, } #endif +NS_IMETHODIMP nsXREDirProvider::GetIsPortableMode(bool* aIsPortableMode) { +#ifdef RELATIVE_DATA_DIR + if (gDataDirPortable) { + *aIsPortableMode = *gDataDirPortable; + } else { + nsCOMPtr<nsIFile> dir; + GetPortableDataDir(getter_AddRefs(dir), *aIsPortableMode); + } +#else + *aIsPortableMode = false; +#endif + return NS_OK; +} + nsresult nsXREDirProvider::GetUserDataDirectoryHome(nsIFile** aFile, bool aLocal) { // Copied from nsAppFileLocationProvider (more or less) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e9d1e5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e9d1e5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 9173: Change the default Firefox profile directory to be relative.
by Pier Angelo Vendrame (＠pierov) 07 Feb '24

07 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: c78c48e7 by Pier Angelo Vendrame at 2024-02-07T16:34:15+01:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Add a method to query whether the browser is in portable mode. - - - - - 2 changed files: - toolkit/xre/nsIXREDirProvider.idl - toolkit/xre/nsXREDirProvider.cpp Changes: ===================================== toolkit/xre/nsIXREDirProvider.idl ===================================== @@ -20,4 +20,9 @@ interface nsIXREDirProvider : nsISupports * Gets the hash for the current installation directory. */ AString getInstallHash(); + + /** + * Tells whether the browser has been started in portable mode. + */ + readonly attribute bool isPortableMode; }; ===================================== toolkit/xre/nsXREDirProvider.cpp ===================================== @@ -1334,6 +1334,20 @@ nsresult nsXREDirProvider::GetPortableDataDir(nsIFile** aFile, } #endif +NS_IMETHODIMP nsXREDirProvider::GetIsPortableMode(bool* aIsPortableMode) { +#ifdef RELATIVE_DATA_DIR + if (gDataDirPortable) { + *aIsPortableMode = *gDataDirPortable; + } else { + nsCOMPtr<nsIFile> dir; + GetPortableDataDir(getter_AddRefs(dir), *aIsPortableMode); + } +#else + *aIsPortableMode = false; +#endif + return NS_OK; +} + nsresult nsXREDirProvider::GetUserDataDirectoryHome(nsIFile** aFile, bool aLocal) { // Copied from nsAppFileLocationProvider (more or less) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c78c48e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c78c48e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] 3 commits: fixup! Bug 9173: Change the default Firefox profile directory to be relative.
by Pier Angelo Vendrame (＠pierov) 07 Feb '24

07 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 3ea5b1dc by Pier Angelo Vendrame at 2024-02-07T15:27:23+00:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Add a method to query whether the browser is in portable mode. - - - - - 7c5facb8 by Pier Angelo Vendrame at 2024-02-07T15:27:23+00:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Allow running the postupdate process and change the update directory for when not running in portable mode. - - - - - 438c7fe9 by Pier Angelo Vendrame at 2024-02-07T15:27:23+00:00 fixup! MB 112: Updater customization for Mullvad Browser MB 200: Enable system installs for Mullvad Browser Customize the post update executable name, to avoid any confusion with Mozilla's helper.exe, since we intend using a much simpler post update binary. - - - - - 4 changed files: - browser/installer/windows/nsis/updater_append.ini - toolkit/mozapps/update/updater/updater.cpp - toolkit/xre/nsIXREDirProvider.idl - toolkit/xre/nsXREDirProvider.cpp Changes: ===================================== browser/installer/windows/nsis/updater_append.ini ===================================== @@ -7,6 +7,8 @@ [PostUpdateWin] ; ExeRelPath is the path to the PostUpdateWin executable relative to the ; application executable. -ExeRelPath=uninstall\helper.exe +ExeRelPath=postupdate.exe ; ExeArg is the argument to pass to the PostUpdateWin exe +; We do not need any argument, but an empty string here will make updater.exe +; not run this step. ExeArg=/PostUpdate ===================================== toolkit/mozapps/update/updater/updater.cpp ===================================== @@ -2807,7 +2807,7 @@ int LaunchCallbackAndPostProcessApps(int argc, NS_tchar** argv, #endif if (argc > callbackIndex) { -#if defined(XP_WIN) && !defined(BASE_BROWSER_UPDATE) +#if defined(XP_WIN) if (gSucceeded) { if (!LaunchWinPostProcess(gInstallDirPath, gPatchDirPath)) { fprintf(stderr, "The post update process was not launched"); ===================================== toolkit/xre/nsIXREDirProvider.idl ===================================== @@ -20,4 +20,9 @@ interface nsIXREDirProvider : nsISupports * Gets the hash for the current installation directory. */ AString getInstallHash(); + + /** + * Tells whether the browser has been started in portable mode. + */ + readonly attribute bool isPortableMode; }; ===================================== toolkit/xre/nsXREDirProvider.cpp ===================================== @@ -1109,7 +1109,14 @@ nsresult nsXREDirProvider::GetUpdateRootDir(nsIFile** aResult, rv = GetUserDataDirectory(getter_AddRefs(updRoot), false); NS_ENSURE_SUCCESS(rv, rv); # else - rv = GetUserDataDirectoryHome(getter_AddRefs(updRoot), false); + bool isPortable = true; + rv = GetIsPortableMode(&isPortable); + NS_ENSURE_SUCCESS(rv, rv); + if (isPortable) { + rv = GetUserDataDirectoryHome(getter_AddRefs(updRoot), false); + } else { + rv = GetUserDataDirectory(getter_AddRefs(updRoot), true); + } NS_ENSURE_SUCCESS(rv, rv); # endif rv = updRoot->AppendNative("UpdateInfo"_ns); @@ -1324,6 +1331,20 @@ nsresult nsXREDirProvider::GetPortableDataDir(nsIFile** aFile, } #endif +NS_IMETHODIMP nsXREDirProvider::GetIsPortableMode(bool* aIsPortableMode) { +#ifdef RELATIVE_DATA_DIR + if (gDataDirPortable) { + *aIsPortableMode = *gDataDirPortable; + } else { + nsCOMPtr<nsIFile> dir; + GetPortableDataDir(getter_AddRefs(dir), *aIsPortableMode); + } +#else + *aIsPortableMode = false; +#endif + return NS_OK; +} + nsresult nsXREDirProvider::GetUserDataDirectoryHome(nsIFile** aFile, bool aLocal) { // Copied from nsAppFileLocationProvider (more or less) View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/7f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/7f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 9419bbc3 by Henry Wilkes at 2024-02-07T12:54:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41814: Use "Tor bridge" instead of "vanilla bridge". - - - - - b90988c5 by Henry Wilkes at 2024-02-07T12:54:41+00:00 fixup! Tor Browser strings Bug 41814: Use "Tor bridge" instead of "vanilla bridge". - - - - - 3 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/provideBridgeDialog.js - browser/locales/en-US/browser/tor-browser.ftl Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -665,12 +665,15 @@ const gBridgeGrid = { row.cells.push({ element, focusEl, columnIndex, row }); } - // TODO: properly handle "vanilla" bridges? - document.l10n.setAttributes( - row.element.querySelector(".tor-bridges-type-cell"), - "tor-bridges-type-prefix", - { type: details?.transport ?? "vanilla" } - ); + const transport = details?.transport ?? "vanilla"; + const typeCell = row.element.querySelector(".tor-bridges-type-cell"); + if (transport === "vanilla") { + document.l10n.setAttributes(typeCell, "tor-bridges-type-prefix-generic"); + } else { + document.l10n.setAttributes(typeCell, "tor-bridges-type-prefix", { + type: transport, + }); + } row.element.querySelector(".tor-bridges-address-cell").textContent = bridgeLine; ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -474,12 +474,18 @@ const gProvideBridgeDialog = { emojiBlock.append(cell); } - // TODO: properly handle "vanilla" bridges? - document.l10n.setAttributes( - rowEl.querySelector(".tor-bridges-type-cell"), - "tor-bridges-type-prefix", - { type: details?.transport ?? "vanilla" } - ); + const transport = details?.transport ?? "vanilla"; + const typeCell = rowEl.querySelector(".tor-bridges-type-cell"); + if (transport === "vanilla") { + document.l10n.setAttributes( + typeCell, + "tor-bridges-type-prefix-generic" + ); + } else { + document.l10n.setAttributes(typeCell, "tor-bridges-type-prefix", { + type: transport, + }); + } rowEl.querySelector(".tor-bridges-address-cell").textContent = bridgeLine; ===================================== browser/locales/en-US/browser/tor-browser.ftl ===================================== @@ -82,6 +82,8 @@ tor-bridges-built-in-status-connected = Connected # Shown at the start of a Tor bridge line. # $type (String) - The Tor bridge type ("snowflake", "obfs4", "meek-azure"). tor-bridges-type-prefix = { $type } bridge: +# Shown at the start of a Tor bridge line, when the transport type is unknown (or "vanilla"). +tor-bridges-type-prefix-generic = Tor bridge: # The name and accessible description for a bridge emoji cell. Each bridge address can be hashed into four emojis shown to the user (bridgemoji feature). This cell corresponds to a *single* such emoji. The "title" should just be emojiName. The "aria-description" should give screen reader users enough of a hint that the cell contains a single emoji. # $emojiName (String) - The name of the emoji, already localized. # E.g. with Orca screen reader in en-US this would read "unicorn. Row 2 Column 2. Emoji". View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f8f90f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f8f90f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch mullvad-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 6226fff7 by Pier Angelo Vendrame at 2024-02-07T12:28:05+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 9e0fad12 by Pier Angelo Vendrame at 2024-02-07T12:28:05+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] 3 commits: Revert "Bug 42374: Check for spoof English in number conversions"
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 0daaf26b by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Revert "Bug 42374: Check for spoof English in number conversions" This reverts commit a7932fac62c8a955bdc3f08a9b81b7f2562a4eff. We are instead backporting the uplifted commits. - - - - - c2feed1c by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 7f263eaf by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1 changed file: - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,15 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && !mContent->OwnerDoc()->AllowsL10n(); if (spoofLocale) { aBCP47LangTag.AssignLiteral("en-US"); return; } - nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/a0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/a0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch base-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d363fccf by Pier Angelo Vendrame at 2024-02-07T12:23:06+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 066750e9 by Pier Angelo Vendrame at 2024-02-07T12:23:06+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c906d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c906d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e42f5004 by Pier Angelo Vendrame at 2024-02-07T12:18:39+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 9af28502 by Pier Angelo Vendrame at 2024-02-07T12:18:39+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6292bb… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6292bb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] 3 commits: Revert "Bug 42374: Check for spoof English in number conversions"
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: fd8ea798 by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Revert "Bug 42374: Check for spoof English in number conversions" This reverts commit a7932fac62c8a955bdc3f08a9b81b7f2562a4eff. We are instead backporting the uplifted commits. - - - - - e750db60 by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - f8f90f9f by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1 changed file: - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,15 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && !mContent->OwnerDoc()->AllowsL10n(); if (spoofLocale) { aBCP47LangTag.AssignLiteral("en-US"); return; } - nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cc050d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cc050d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Update rbm for rbm#40068 and rbm#40069
by boklm (＠boklm) 07 Feb '24

07 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cc41e2d7 by Nicolas Vigier at 2024-02-07T10:51:09+01:00 Update rbm for rbm#40068 and rbm#40069 - - - - - 1 changed file: - rbm Changes: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit b5e5b04aaf677c4bacfb5ace45598313286bfdf6 +Subproject commit 067c30ee4cf3baa1c0b7e3674d785cf9e5bec8fe View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] Bug 42195: Fix "Whats new URL"
by Dan Ballard (＠dan) 07 Feb '24

07 Feb '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 1e87b6c6 by clairehurst at 2024-02-01T16:51:58+00:00 Bug 42195: Fix "Whats new URL" - - - - - 5 changed files: - fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt - fenix/app/src/test/java/org/mozilla/fenix/home/HomeMenuViewTest.kt - fenix/app/src/test/java/org/mozilla/fenix/settings/SupportUtilsTest.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt ===================================== @@ -170,7 +170,7 @@ class HomeMenuView( Events.whatsNewTapped.record(NoExtras()) homeActivity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.WHATS_NEW_URL, + searchTermOrURL = SupportUtils.getTorWhatsNewUrl(), newTab = true, from = BrowserDirection.FromHome, ) ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt ===================================== @@ -38,7 +38,7 @@ object SupportUtils { const val MEITUAN_URL = "https://tb.j5k6.com/6ZSOp" const val GOOGLE_US_URL = "https://www.google.com/webhp?client=firefox-b-1-m&channel=ts" const val GOOGLE_XX_URL = "https://www.google.com/webhp?client=firefox-b-m&channel=ts" - const val WHATS_NEW_URL = "https://www.torproject.org/releases/" +// const val WHATS_NEW_URL = "https://www.torproject.org/releases/" const val DONATE_URL = "https://donate.torproject.org/" const val TB_MANUAL_URL = "https://tb-manual.torproject.org/mobile-tor" @@ -100,6 +100,12 @@ object SupportUtils { return TB_MANUAL_URL } + fun getTorWhatsNewUrl(): String { + val alpha = if (BuildConfig.VERSION_NAME.contains('a')) "alpha-" else "" + val versionNumberNoDecimals = BuildConfig.VERSION_NAME.split('.').joinToString("") + return "https://blog.torproject.org/new-${alpha}release-tor-browser-${versionNumber…" + } + fun getMozillaPageUrl(page: MozillaPage, locale: Locale = Locale.getDefault()): String { val path = page.path val langTag = getLanguageTag(locale) ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt ===================================== @@ -135,7 +135,7 @@ class AboutFragment : Fragment(), AboutPageListener { AboutPageItem( AboutItem.ExternalLink( WHATS_NEW, - SupportUtils.WHATS_NEW_URL, + SupportUtils.getTorWhatsNewUrl(), ), getString(R.string.about_whats_new, getString(R.string.app_name)), ), ===================================== fenix/app/src/test/java/org/mozilla/fenix/home/HomeMenuViewTest.kt ===================================== @@ -207,7 +207,7 @@ class HomeMenuViewTest { WhatsNew.userViewedWhatsNew(testContext) homeActivity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.WHATS_NEW_URL, + searchTermOrURL = SupportUtils.getTorWhatsNewUrl(), newTab = true, from = BrowserDirection.FromHome, ) ===================================== fenix/app/src/test/java/org/mozilla/fenix/settings/SupportUtilsTest.kt ===================================== @@ -25,10 +25,10 @@ class SupportUtilsTest { "https://support.mozilla.org/1/mobile/20/Android/fr/tracking-protection-fire…", SupportUtils.getSumoURLForTopic(mockContext("2 0"), SupportUtils.SumoTopic.TRACKING_PROTECTION, Locale("fr")), ) - assertEquals( - "https://www.mozilla.org/firefox/android/notes", - SupportUtils.WHATS_NEW_URL, - ) +// assertEquals( +// "https://www.mozilla.org/firefox/android/notes", +// SupportUtils.WHATS_NEW_URL, +// ) } @Test @@ -63,7 +63,7 @@ class SupportUtilsTest { ) assertEquals( "https://www.torproject.org/releases/", - SupportUtils.WHATS_NEW_URL + SupportUtils.getTorWhatsNewUrl() ) } View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher] Deleted branch asciiwolf-metainfo-developer
by asciiwolf (＠asciiwolf) 06 Feb '24

06 Feb '24

asciiwolf deleted branch asciiwolf-metainfo-developer at The Tor Project / Applications / torbrowser-launcher -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik.
by ma1 (＠ma1) 06 Feb '24

06 Feb '24

ma1 pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: a007d208 by hackademix at 2024-02-06T11:49:08+01:00 Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser_timezone.js - js/src/jit-test/tests/resist-fingerprinting/timezone.js - js/src/vm/DateTime.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_timezone.js ===================================== @@ -1,6 +1,7 @@ /** * Bug 1330890 - A test case for verifying Date() object of javascript will use - * UTC timezone after fingerprinting resistance is enabled. + * Atlantic/Reykjavik timezone (GMT and "real" equivalent to UTC) + * after fingerprinting resistance is enabled. */ async function verifySpoofed() { @@ -16,13 +17,15 @@ async function verifySpoofed() { // Running in content: function test() { let date = new Date(); + const TZ_NAME = "Atlantic/Reykjavik"; + const TZ_SUFFIX = "(Greenwich Mean Time)"; ok( - date.toString().endsWith("(Coordinated Universal Time)"), - "The date toString() is in UTC timezone." + date.toString().endsWith(TZ_SUFFIX), + `The date toString() is in ${TZ_NAME} timezone.` ); ok( - date.toTimeString().endsWith("(Coordinated Universal Time)"), - "The date toTimeString() is in UTC timezone." + date.toTimeString().endsWith(TZ_SUFFIX), + `The date toTimeString() is in ${TZ_NAME} timezone.` ); let dateTimeFormat = Intl.DateTimeFormat("en-US", { dateStyle: "full", @@ -30,12 +33,12 @@ async function verifySpoofed() { }); is( dateTimeFormat.resolvedOptions().timeZone, - "UTC", - "The Intl.DateTimeFormat is in UTC timezone." + TZ_NAME, + `The Intl.DateTimeFormat is in ${TZ_NAME} timezone.` ); ok( - dateTimeFormat.format(date).endsWith("Coordinated Universal Time"), - "The Intl.DateTimeFormat is formatting with the UTC timezone." + dateTimeFormat.format(date).endsWith(TZ_SUFFIX), + `The Intl.DateTimeFormat is formatting with the ${TZ_NAME} timezone.` ); is( date.getFullYear(), ===================================== js/src/jit-test/tests/resist-fingerprinting/timezone.js ===================================== @@ -2,7 +2,10 @@ let tzRE = /$([^$]+)\)/; -// Make sure we aren't already running with UTC +const SPOOFED_TZ_NAME = "Atlantic/Reykjavik"; +const SPOOFED_TZ_GENERIC = "Greenwich Mean Time"; + +// Make sure we aren't already running with spoofed TZ let original = new Date(0); assertEq(tzRE.exec(original.toString())[1], "Pacific Standard Time"); @@ -16,8 +19,8 @@ assertEq(originalDT.resolvedOptions().timeZone, "PST8PDT"); let global = newGlobal({shouldResistFingerprinting: true}); let date = new global.Date(); -assertEq(tzRE.exec(date.toString())[1], "Coordinated Universal Time"); -assertEq(tzRE.exec(date.toTimeString())[1], "Coordinated Universal Time"); +assertEq(tzRE.exec(date.toString())[1], SPOOFED_TZ_GENERIC); +assertEq(tzRE.exec(date.toTimeString())[1], SPOOFED_TZ_GENERIC); assertEq(date.getFullYear(), date.getUTCFullYear()); assertEq(date.getMonth(), date.getUTCMonth()); assertEq(date.getDate(), date.getUTCDate()); @@ -29,5 +32,5 @@ let dt = global.Intl.DateTimeFormat("en-US", { dateStyle: "full", timeStyle: "full", }); -assertEq(dt.format(date).endsWith("Coordinated Universal Time"), true); -assertEq(dt.resolvedOptions().timeZone, "UTC"); +assertEq(dt.format(date).endsWith(SPOOFED_TZ_GENERIC), true); +assertEq(dt.resolvedOptions().timeZone, SPOOFED_TZ_NAME); ===================================== js/src/vm/DateTime.cpp ===================================== @@ -484,10 +484,11 @@ bool js::DateTimeInfo::internalTimeZoneDisplayName(char16_t* buf, size_t buflen, mozilla::intl::TimeZone* js::DateTimeInfo::timeZone() { if (!timeZone_) { - // For resist finger printing mode we always use the UTC time zone. + // For resist finger printing mode we always use the Atlantic/Reykjavik time zone + // as a "real world" UTC equivalent. mozilla::Maybe<mozilla::Span<const char16_t>> timeZoneOverride; if (shouldResistFingerprinting_) { - timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"UTC")); + timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"Atlantic/Reykjavik")); } auto timeZone = mozilla::intl::TimeZone::TryCreate(timeZoneOverride); ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -227,7 +227,7 @@ void nsRFPService::UpdateRFPPref() { } if (resistFingerprinting) { - PR_SetEnv("TZ=UTC"); + PR_SetEnv("TZ=Atlantic/Reykjavik"); } else if (sInitialized) { // We will not touch the TZ value if 'privacy.resistFingerprinting' is false // during the time of initialization. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a00… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a00… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik.
by ma1 (＠ma1) 06 Feb '24

06 Feb '24

ma1 pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: e9d1e586 by hackademix at 2024-02-06T11:48:03+01:00 Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser_timezone.js - js/src/jit-test/tests/resist-fingerprinting/timezone.js - js/src/vm/DateTime.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_timezone.js ===================================== @@ -1,6 +1,7 @@ /** * Bug 1330890 - A test case for verifying Date() object of javascript will use - * UTC timezone after fingerprinting resistance is enabled. + * Atlantic/Reykjavik timezone (GMT and "real" equivalent to UTC) + * after fingerprinting resistance is enabled. */ async function verifySpoofed() { @@ -16,13 +17,15 @@ async function verifySpoofed() { // Running in content: function test() { let date = new Date(); + const TZ_NAME = "Atlantic/Reykjavik"; + const TZ_SUFFIX = "(Greenwich Mean Time)"; ok( - date.toString().endsWith("(Coordinated Universal Time)"), - "The date toString() is in UTC timezone." + date.toString().endsWith(TZ_SUFFIX), + `The date toString() is in ${TZ_NAME} timezone.` ); ok( - date.toTimeString().endsWith("(Coordinated Universal Time)"), - "The date toTimeString() is in UTC timezone." + date.toTimeString().endsWith(TZ_SUFFIX), + `The date toTimeString() is in ${TZ_NAME} timezone.` ); let dateTimeFormat = Intl.DateTimeFormat("en-US", { dateStyle: "full", @@ -30,12 +33,12 @@ async function verifySpoofed() { }); is( dateTimeFormat.resolvedOptions().timeZone, - "UTC", - "The Intl.DateTimeFormat is in UTC timezone." + TZ_NAME, + `The Intl.DateTimeFormat is in ${TZ_NAME} timezone.` ); ok( - dateTimeFormat.format(date).endsWith("Coordinated Universal Time"), - "The Intl.DateTimeFormat is formatting with the UTC timezone." + dateTimeFormat.format(date).endsWith(TZ_SUFFIX), + `The Intl.DateTimeFormat is formatting with the ${TZ_NAME} timezone.` ); is( date.getFullYear(), ===================================== js/src/jit-test/tests/resist-fingerprinting/timezone.js ===================================== @@ -2,7 +2,10 @@ let tzRE = /$([^$]+)\)/; -// Make sure we aren't already running with UTC +const SPOOFED_TZ_NAME = "Atlantic/Reykjavik"; +const SPOOFED_TZ_GENERIC = "Greenwich Mean Time"; + +// Make sure we aren't already running with spoofed TZ let original = new Date(0); assertEq(tzRE.exec(original.toString())[1], "Pacific Standard Time"); @@ -16,8 +19,8 @@ assertEq(originalDT.resolvedOptions().timeZone, "PST8PDT"); let global = newGlobal({shouldResistFingerprinting: true}); let date = new global.Date(); -assertEq(tzRE.exec(date.toString())[1], "Coordinated Universal Time"); -assertEq(tzRE.exec(date.toTimeString())[1], "Coordinated Universal Time"); +assertEq(tzRE.exec(date.toString())[1], SPOOFED_TZ_GENERIC); +assertEq(tzRE.exec(date.toTimeString())[1], SPOOFED_TZ_GENERIC); assertEq(date.getFullYear(), date.getUTCFullYear()); assertEq(date.getMonth(), date.getUTCMonth()); assertEq(date.getDate(), date.getUTCDate()); @@ -29,5 +32,5 @@ let dt = global.Intl.DateTimeFormat("en-US", { dateStyle: "full", timeStyle: "full", }); -assertEq(dt.format(date).endsWith("Coordinated Universal Time"), true); -assertEq(dt.resolvedOptions().timeZone, "UTC"); +assertEq(dt.format(date).endsWith(SPOOFED_TZ_GENERIC), true); +assertEq(dt.resolvedOptions().timeZone, SPOOFED_TZ_NAME); ===================================== js/src/vm/DateTime.cpp ===================================== @@ -484,10 +484,11 @@ bool js::DateTimeInfo::internalTimeZoneDisplayName(char16_t* buf, size_t buflen, mozilla::intl::TimeZone* js::DateTimeInfo::timeZone() { if (!timeZone_) { - // For resist finger printing mode we always use the UTC time zone. + // For resist finger printing mode we always use the Atlantic/Reykjavik time zone + // as a "real world" UTC equivalent. mozilla::Maybe<mozilla::Span<const char16_t>> timeZoneOverride; if (shouldResistFingerprinting_) { - timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"UTC")); + timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"Atlantic/Reykjavik")); } auto timeZone = mozilla::intl::TimeZone::TryCreate(timeZoneOverride); ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -227,7 +227,7 @@ void nsRFPService::UpdateRFPPref() { } if (resistFingerprinting) { - PR_SetEnv("TZ=UTC"); + PR_SetEnv("TZ=Atlantic/Reykjavik"); } else if (sInitialized) { // We will not touch the TZ value if 'privacy.resistFingerprinting' is false // during the time of initialization. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d1e58… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d1e58… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik.
by ma1 (＠ma1) 06 Feb '24

06 Feb '24

ma1 pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: cc050dd9 by hackademix at 2024-02-06T11:31:46+01:00 Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser_timezone.js - js/src/jit-test/tests/resist-fingerprinting/timezone.js - js/src/vm/DateTime.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_timezone.js ===================================== @@ -1,6 +1,7 @@ /** * Bug 1330890 - A test case for verifying Date() object of javascript will use - * UTC timezone after fingerprinting resistance is enabled. + * Atlantic/Reykjavik timezone (GMT and "real" equivalent to UTC) + * after fingerprinting resistance is enabled. */ async function verifySpoofed() { @@ -16,13 +17,15 @@ async function verifySpoofed() { // Running in content: function test() { let date = new Date(); + const TZ_NAME = "Atlantic/Reykjavik"; + const TZ_SUFFIX = "(Greenwich Mean Time)"; ok( - date.toString().endsWith("(Coordinated Universal Time)"), - "The date toString() is in UTC timezone." + date.toString().endsWith(TZ_SUFFIX), + `The date toString() is in ${TZ_NAME} timezone.` ); ok( - date.toTimeString().endsWith("(Coordinated Universal Time)"), - "The date toTimeString() is in UTC timezone." + date.toTimeString().endsWith(TZ_SUFFIX), + `The date toTimeString() is in ${TZ_NAME} timezone.` ); let dateTimeFormat = Intl.DateTimeFormat("en-US", { dateStyle: "full", @@ -30,12 +33,12 @@ async function verifySpoofed() { }); is( dateTimeFormat.resolvedOptions().timeZone, - "UTC", - "The Intl.DateTimeFormat is in UTC timezone." + TZ_NAME, + `The Intl.DateTimeFormat is in ${TZ_NAME} timezone.` ); ok( - dateTimeFormat.format(date).endsWith("Coordinated Universal Time"), - "The Intl.DateTimeFormat is formatting with the UTC timezone." + dateTimeFormat.format(date).endsWith(TZ_SUFFIX), + `The Intl.DateTimeFormat is formatting with the ${TZ_NAME} timezone.` ); is( date.getFullYear(), ===================================== js/src/jit-test/tests/resist-fingerprinting/timezone.js ===================================== @@ -2,7 +2,10 @@ let tzRE = /$([^$]+)\)/; -// Make sure we aren't already running with UTC +const SPOOFED_TZ_NAME = "Atlantic/Reykjavik"; +const SPOOFED_TZ_GENERIC = "Greenwich Mean Time"; + +// Make sure we aren't already running with spoofed TZ let original = new Date(0); assertEq(tzRE.exec(original.toString())[1], "Pacific Standard Time"); @@ -16,8 +19,8 @@ assertEq(originalDT.resolvedOptions().timeZone, "PST8PDT"); let global = newGlobal({shouldResistFingerprinting: true}); let date = new global.Date(); -assertEq(tzRE.exec(date.toString())[1], "Coordinated Universal Time"); -assertEq(tzRE.exec(date.toTimeString())[1], "Coordinated Universal Time"); +assertEq(tzRE.exec(date.toString())[1], SPOOFED_TZ_GENERIC); +assertEq(tzRE.exec(date.toTimeString())[1], SPOOFED_TZ_GENERIC); assertEq(date.getFullYear(), date.getUTCFullYear()); assertEq(date.getMonth(), date.getUTCMonth()); assertEq(date.getDate(), date.getUTCDate()); @@ -29,5 +32,5 @@ let dt = global.Intl.DateTimeFormat("en-US", { dateStyle: "full", timeStyle: "full", }); -assertEq(dt.format(date).endsWith("Coordinated Universal Time"), true); -assertEq(dt.resolvedOptions().timeZone, "UTC"); +assertEq(dt.format(date).endsWith(SPOOFED_TZ_GENERIC), true); +assertEq(dt.resolvedOptions().timeZone, SPOOFED_TZ_NAME); ===================================== js/src/vm/DateTime.cpp ===================================== @@ -484,10 +484,11 @@ bool js::DateTimeInfo::internalTimeZoneDisplayName(char16_t* buf, size_t buflen, mozilla::intl::TimeZone* js::DateTimeInfo::timeZone() { if (!timeZone_) { - // For resist finger printing mode we always use the UTC time zone. + // For resist finger printing mode we always use the Atlantic/Reykjavik time zone + // as a "real world" UTC equivalent. mozilla::Maybe<mozilla::Span<const char16_t>> timeZoneOverride; if (shouldResistFingerprinting_) { - timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"UTC")); + timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"Atlantic/Reykjavik")); } auto timeZone = mozilla::intl::TimeZone::TryCreate(timeZoneOverride); ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -227,7 +227,7 @@ void nsRFPService::UpdateRFPPref() { } if (resistFingerprinting) { - PR_SetEnv("TZ=UTC"); + PR_SetEnv("TZ=Atlantic/Reykjavik"); } else if (sInitialized) { // We will not touch the TZ value if 'privacy.resistFingerprinting' is false // during the time of initialization. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cc050dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cc050dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher][main] Add developer name to AppStream metadata
by boklm (＠boklm) 06 Feb '24

06 Feb '24

boklm pushed to branch main at The Tor Project / Applications / torbrowser-launcher Commits: 0a20f448 by asciiwolf at 2024-02-03T22:22:28+00:00 Add developer name to AppStream metadata - - - - - 1 changed file: - share/metainfo/org.torproject.torbrowser-launcher.metainfo.xml Changes: ===================================== share/metainfo/org.torproject.torbrowser-launcher.metainfo.xml ===================================== @@ -7,6 +7,7 @@ <metadata_license>CC0-1.0</metadata_license> <project_license>MIT</project_license> <name>Tor Browser Launcher</name> + <developer_name>Tor Project</developer_name> <summary>A program to help you download, keep updated, and run the Tor Browser Bundle</summary> <description> <p>Tor Browser Launcher is intended to make the Tor Browser Bundle (TBB) easier to maintain and use for GNU/Linux users. It downloads the same TBB from torproject.org that everyone else uses, and it doesn't alter it in any way. But it does make it much more usable, and it makes the task of keeping it up-to-date more secure.</p> View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/commit… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/commit… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher] Pushed new branch asciiwolf-metainfo-developer
by asciiwolf (＠asciiwolf) 03 Feb '24

03 Feb '24

asciiwolf pushed new branch asciiwolf-metainfo-developer at The Tor Project / Applications / torbrowser-launcher -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/tree/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 13.5a4
by richard (＠richard) 01 Feb '24

01 Feb '24

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: ea4b9e73 by Richard Pospesel at 2024-02-01T14:44:33+00:00 alpha: new version, 13.5a4 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/13.0a6-13.5a3-linux-i686-ALL.xml - − update_3/alpha/13.0a6-13.5a3-linux-x86_64-ALL.xml - − update_3/alpha/13.0a6-13.5a3-macos-ALL.xml - − update_3/alpha/13.0a6-13.5a3-windows-i686-ALL.xml - − update_3/alpha/13.0a6-13.5a3-windows-x86_64-ALL.xml - − update_3/alpha/13.5a1-13.5a3-linux-i686-ALL.xml - − update_3/alpha/13.5a1-13.5a3-linux-x86_64-ALL.xml - − update_3/alpha/13.5a1-13.5a3-macos-ALL.xml - − update_3/alpha/13.5a1-13.5a3-windows-i686-ALL.xml - − update_3/alpha/13.5a1-13.5a3-windows-x86_64-ALL.xml - + update_3/alpha/13.5a1-13.5a4-linux-i686-ALL.xml - + update_3/alpha/13.5a1-13.5a4-linux-x86_64-ALL.xml - + update_3/alpha/13.5a1-13.5a4-macos-ALL.xml - + update_3/alpha/13.5a1-13.5a4-windows-i686-ALL.xml - + update_3/alpha/13.5a1-13.5a4-windows-x86_64-ALL.xml - − update_3/alpha/13.5a2-13.5a3-linux-i686-ALL.xml - − update_3/alpha/13.5a2-13.5a3-linux-x86_64-ALL.xml - − update_3/alpha/13.5a2-13.5a3-macos-ALL.xml - − update_3/alpha/13.5a2-13.5a3-windows-i686-ALL.xml - − update_3/alpha/13.5a2-13.5a3-windows-x86_64-ALL.xml - + update_3/alpha/13.5a2-13.5a4-linux-i686-ALL.xml - + update_3/alpha/13.5a2-13.5a4-linux-x86_64-ALL.xml - + update_3/alpha/13.5a2-13.5a4-macos-ALL.xml - + update_3/alpha/13.5a2-13.5a4-windows-i686-ALL.xml - + update_3/alpha/13.5a2-13.5a4-windows-x86_64-ALL.xml - + update_3/alpha/13.5a3-13.5a4-linux-i686-ALL.xml - + update_3/alpha/13.5a3-13.5a4-linux-x86_64-ALL.xml - + update_3/alpha/13.5a3-13.5a4-macos-ALL.xml - + update_3/alpha/13.5a3-13.5a4-windows-i686-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5a4-build2
by richard (＠richard) 01 Feb '24

01 Feb '24

richard pushed new tag tbb-13.5a4-build2 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41078: touch pt_config.json before adding to omni.ja
by richard (＠richard) 01 Feb '24

01 Feb '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 35330ddb by Richard Pospesel at 2024-02-01T12:28:06+00:00 Bug 41078: touch pt_config.json before adding to omni.ja - - - - - 72226294 by Richard Pospesel at 2024-02-01T12:30:30+00:00 Bug 41051: Update changlog and bump build number - - - - - 3 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/build - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -40,6 +40,8 @@ Tor Browser 13.5a4 - January 31 2024 * Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput [tor-browser-build] * Bug 41073: Update documention about required packages for container-less build [tor-browser-build] * Bug 40067: Use --no-verbose wget option when not running in a terminal [rbm] + * Windows + macOS + Linux + * Bug 41078: pt_config.json not touch'd before adding to omni.ja, resulting in build non-determinism [tor-browser-build] * Windows * Bug 40606: Use Clang to compile NSIS [tor-browser-build] * Bug 40900: Update NSIS to 3.09 [tor-browser-build] ===================================== projects/browser/build ===================================== @@ -279,6 +279,7 @@ do pt_config_dir=chrome/toolkit/content/global mkdir -p "$pt_config_dir" cp "pt_config.json" "$pt_config_dir/" + [% c("touch") %] "$pt_config_dir/pt_config.json" zip -Xm "$tbdir/omni.ja" "$pt_config_dir/pt_config.json" rm -rf chrome popd ===================================== rbm.conf ===================================== @@ -82,7 +82,7 @@ buildconf: var: torbrowser_version: '13.5a4' - torbrowser_build: 'build1' + torbrowser_build: 'build2' torbrowser_incremental_from: - '13.5a1' - '13.5a2' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Add Tor integration and UI
by Dan Ballard (＠dan) 31 Jan '24

31 Jan '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 87e8fea1 by clairehurst at 2024-01-31T16:12:55-07:00 fixup! Add Tor integration and UI - - - - - 10 changed files: - fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt - fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt - fenix/app/src/main/java/org/mozilla/fenix/components/TorBrowserFeatures.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/TorNetworkSettingsFragment.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapStatus.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerTAS.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapConnectViewHolder.kt - fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapLoggerViewHolder.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -685,7 +685,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorIn } override fun onTorConnecting() { /* no-op */ } override fun onTorStopped() { /* no-op */ } - override fun onTorStatusUpdate(entry: String?, status: String?) { /* no-op */ } + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { /* no-op */ } }) return } ===================================== fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt ===================================== @@ -59,7 +59,7 @@ class IntentReceiverActivity : Activity() { } override fun onTorConnecting() { /* no-op */ } override fun onTorStopped() { /* no-op */ } - override fun onTorStatusUpdate(entry: String?, status: String?) { /* no-op */ } + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { /* no-op */ } }) // In the meantime, open the HomeActivity so the user can get connected. ===================================== fenix/app/src/main/java/org/mozilla/fenix/components/TorBrowserFeatures.kt ===================================== @@ -164,7 +164,7 @@ object TorBrowserFeatures { } @SuppressWarnings("EmptyFunctionBlock") - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { } }) } ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/TorNetworkSettingsFragment.kt ===================================== @@ -166,7 +166,7 @@ class TorNetworkSettingsFragment : PreferenceFragmentCompat(), TorEvents { override fun onTorStopped() { } - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { setStatus() } } ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapStatus.kt ===================================== @@ -34,7 +34,7 @@ class TorBootstrapStatus( } @SuppressWarnings("EmptyFunctionBlock") - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { } fun unregisterTorListener() { ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt ===================================== @@ -9,7 +9,7 @@ import androidx.lifecycle.LifecycleCoroutineScope interface TorEvents { fun onTorConnecting() fun onTorConnected() - fun onTorStatusUpdate(entry: String?, status: String?) + fun onTorStatusUpdate(entry: String?, status: String?, progress: Double? = 0.0) fun onTorStopped() } @@ -55,7 +55,7 @@ interface TorController: TorEvents { override fun onTorConnecting() override fun onTorConnected() - override fun onTorStatusUpdate(entry: String?, status: String?) + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) override fun onTorStopped() fun registerTorListener(l: TorEvents) ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -155,9 +155,9 @@ class TorControllerGV( } // TorEvents - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { synchronized(torListeners) { - torListeners.toList().forEach { it.onTorStatusUpdate(entry, status) } + torListeners.toList().forEach { it.onTorStatusUpdate(entry, status, progress) } } } @@ -221,7 +221,7 @@ class TorControllerGV( // and state for firefox-android (designed for tor-android-service) // fun onTorConnecting() // fun onTorConnected() - // fun onTorStatusUpdate(entry: String?, status: String?) + // fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) // fun onTorStopped() // TorEventsBootstrapStateChangeListener @@ -268,7 +268,7 @@ class TorControllerGV( } entries.add(Pair(status, lastKnownStatus.toTorStatus().status)) - onTorStatusUpdate(status, lastKnownStatus.toTorStatus().status) + onTorStatusUpdate(status, lastKnownStatus.toTorStatus().status, progress) } // TorEventsBootstrapStateChangeListener ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerTAS.kt ===================================== @@ -170,7 +170,7 @@ class TorControllerTAS (private val context: Context): TorController { handlePendingRegistrationChanges() } - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { lockTorListenersMutation = true torListeners.forEach { it.onTorStatusUpdate(entry, status) } lockTorListenersMutation = false ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapConnectViewHolder.kt ===================================== @@ -92,7 +92,7 @@ class TorBootstrapConnectViewHolder( override fun onTorStopped() { } - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { if (entry == null) return binding.torBootstrapStatusMessage.text = entry @@ -103,7 +103,7 @@ class TorBootstrapConnectViewHolder( percentIdx ) with(binding.torBootstrapProgress) { - progress = percent.toInt() + this.progress = percent.toInt() } } } ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/view/TorBootstrapLoggerViewHolder.kt ===================================== @@ -55,7 +55,7 @@ class TorBootstrapLoggerViewHolder( override fun onTorStopped() { } - override fun onTorStatusUpdate(entry: String?, status: String?) { + override fun onTorStatusUpdate(entry: String?, status: String?, progress: Double?) { if (status == null || entry == null) return if (status == "ON" && entry.startsWith("Circuit")) return View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/87e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/87e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Add Tor integration and UI
by Dan Ballard (＠dan) 31 Jan '24

31 Jan '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 54d46f59 by Dan Ballard at 2024-01-31T12:42:11-08:00 fixup! Add Tor integration and UI Bug 42252: Fix safely using iterators while possibly modifying List - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -143,28 +143,28 @@ class TorControllerGV( // TorEvents override fun onTorConnecting() { synchronized(torListeners) { - torListeners.forEach { it.onTorConnecting() } + torListeners.toList().forEach { it.onTorConnecting() } } } // TorEvents override fun onTorConnected() { synchronized(torListeners) { - torListeners.forEach { it.onTorConnected() } + torListeners.toList().forEach { it.onTorConnected() } } } // TorEvents override fun onTorStatusUpdate(entry: String?, status: String?) { synchronized(torListeners) { - torListeners.forEach { it.onTorStatusUpdate(entry, status) } + torListeners.toList().forEach { it.onTorStatusUpdate(entry, status) } } } // TorEvents override fun onTorStopped() { synchronized(torListeners) { - torListeners.forEach { it.onTorStopped() } + torListeners.toList().forEach { it.onTorStopped() } } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/54d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/54d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5a4-build1
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed new tag tbb-13.5a4-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41051: Update changelogs for Tor Browser 13.5a4
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: b87a696a by Richard Pospesel at 2024-01-31T12:10:10+00:00 Bug 41051: Update changelogs for Tor Browser 13.5a4 - - - - - 1 changed file: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,4 +1,4 @@ -Tor Browser 13.5a4 - January 29 2024 +Tor Browser 13.5a4 - January 31 2024 * All Platforms * Updated zlib to 1.3.1 * Updated Snowflake to 2.8.1 @@ -13,10 +13,15 @@ Tor Browser 13.5a4 - January 29 2024 * Bug 42374: spoof english leaks via numberingSystem: numbers (non-latn) or decimal separator (latn) [tor-browser] * Bug 42384: Regression: quickstart doesn't work anymore [tor-browser] * Bug 41058: Update Snowflake to 2.8.1 [tor-browser-build] + * Bug 262: Mouse-over long links causes the browser element to re-center relative to width of status tooltip [mullvad-browser] * Windows + macOS + Linux * Updated Firefox to 115.7.0esr * Bug 41917: Make the appearance of letterboxing look more intentional [tor-browser] + * Bug 42036: Design and build a user interface for Lox [tor-browser] * Bug 42338: Changing circuit programmatically in Tor Browser not working anymore! [tor-browser] + * Bug 42387: Visual noise in 13.5a4 letterboxing [tor-browser] + * Linux + * Bug 42293: Updater is disabled when tor-browser is run by torbrowser-launcher flatpak [tor-browser] * Android * Updated GeckoView to 115.7.0esr * Bug 42252: Plumb down TorConnect commands from firefox-android to GeckoView [tor-browser] @@ -25,14 +30,15 @@ Tor Browser 13.5a4 - January 29 2024 * Bug 42355: Fullscreen on Android doesn't hide system bars [tor-browser] * Bug 42367: Backport Android security fixes from Firefox 122 [tor-browser] * Bug 42368: Tor Browser 13.5a3 crashes during start-up because of API26+ methods [tor-browser] - * Linux - * Bug 42293: Updater is disabled when tor-browser is run by torbrowser-launcher flatpak [tor-browser] * Build System * All Platforms * Updated Go to 1.20.13 and 1.21.6 * Bug 41037: Set time on signing machine before starting signing [tor-browser-build] + * Bug 41038: Add RPM dependencies to README [tor-browser-build] * Bug 41059: Update keyring/torbrowser.gpg with updated key [tor-browser-build] * Bug 41063: Run "file $keyring" in tools/keyring/list-all-keyrings [tor-browser-build] + * Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput [tor-browser-build] + * Bug 41073: Update documention about required packages for container-less build [tor-browser-build] * Bug 40067: Use --no-verbose wget option when not running in a terminal [rbm] * Windows * Bug 40606: Use Clang to compile NSIS [tor-browser-build] View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.5-1-build5
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed new tag firefox-android-115.2.1-13.5-1-build5 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.7.0esr-13.5-1-build2
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed new tag tor-browser-115.7.0esr-13.5-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: f74a854e by hackademix at 2024-01-31T13:44:56+00:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42387: hide visual artifacts and fix the status label on rounded letterboxing borders. - - - - - 3 changed files: - browser/base/content/browser.css - browser/base/content/tabbrowser.js - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -127,6 +127,11 @@ body { -moz-window-dragging: drag; } +/** + Never modify the following selector without synchronizing + LETTERBOX_CSS_SELECTOR in RFPHelper.sys.jsm, where + --letterboxing-width & --letterboxing-height are actually set. +**/ .letterboxing .browserContainer { /* From Firefox 115 on, .browserContainer layout is flex / column, @@ -137,6 +142,14 @@ body { background: var(--letterboxing-bgcolor); } +.browserDecorator { + display: none; + pointer-events: none; + background: transparent; + position: relative; + z-index: 1; +} + .letterboxing { --letterboxing-border-radius: 8px; --letterboxing-border-top-radius: 0; @@ -145,6 +158,7 @@ body { --letterboxing-bgcolor: var(--tabpanel-background-color); --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); + --letterboxing-border-color: var(--letterboxing-bgcolor); } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -157,6 +171,26 @@ body { box-shadow: rgba(0, 0, 0, 0.5) 0px -1px 2px; } +:root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) + > .browserStack:not(.exclude-letterboxing) + > .browserDecorator { + display: initial; + visibility: visible; + border-radius: var(--letterboxing-border-radius); + border-top-left-radius: var(--letterboxing-border-top-radius); + border-top-right-radius: var(--letterboxing-border-top-radius); + box-shadow: var(--letterboxing-border-color) 0px 0px .1px inset, var(--letterboxing-border-color) 0 0 .1px; + border: .1px solid var(--letterboxing-border-color); + outline: .1px solid var(--letterboxing-bgcolor); + height: calc(var(--letterboxing-height) + 1px); + top: -1px; +} + +.letterboxing-vcenter .browserDecorator { + height: auto !important; + top: 0 !important; +} + /* Align status bar with content. TODO: switch to nested CSS selectors for conciseness when available (Firefox >= 117) @@ -167,6 +201,7 @@ body { place-self: end left; left: 0; right: 0; + z-index: 2; --letterboxing-status-left-radius: var(--letterboxing-border-radius); --letterboxing-status-right-radius: 0; } @@ -184,23 +219,24 @@ body { .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) #statuspanel-label { border-radius: 0 0 var(--letterboxing-status-right-radius) var(--letterboxing-status-left-radius); + margin: 0; + border: 1px solid var(--letterboxing-border-color); + max-width: calc(var(--letterboxing-width) * .5); } -/** - Never modify the following selector without synchronizing - LETTERBOX_CSS_SELECTOR in RFPHelper.jsm! -**/ .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser { - /* width & height to be dynamically set by RFPHelper.jsm */ box-shadow: 0px 4px 8px 0px var(--letterboxing-shadow-color); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); + width: var(--letterboxing-width) !important; + height: var(--letterboxing-height) !important; } :root:not([inDOMFullscreen]) .letterboxing.letterboxing-ready .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { place-content: var(--letterboxing-vertical-alignment) center; + background: var(--letterboxing-bgcolor); } #toolbar-menubar[autohide="true"] { ===================================== browser/base/content/tabbrowser.js ===================================== @@ -2238,6 +2238,10 @@ stack.className = "browserStack"; stack.appendChild(b); + let decorator = document.createXULElement("hbox"); + decorator.className = "browserDecorator"; + stack.appendChild(decorator); + let browserContainer = document.createXULElement("vbox"); browserContainer.className = "browserContainer"; browserContainer.appendChild(notificationbox); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -447,8 +447,7 @@ class _RFPHelper { // find the rule applying the default letterboxing styles to browsers // preemptively in order to beat race conditions on tab/window creation const LETTERBOX_CSS_URL = "chrome://browser/content/browser.css"; - const LETTERBOX_CSS_SELECTOR = - ".letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser"; + const LETTERBOX_CSS_SELECTOR = ".letterboxing .browserContainer"; for (let ss of document.styleSheets) { if (ss.href !== LETTERBOX_CSS_URL) { continue; @@ -572,8 +571,8 @@ class _RFPHelper { const r = (width, height) => { lastRoundedSize = {width, height}; return { - width: `var(--rdm-width, ${width}px)`, - height: `var(--rdm-height, ${height}px)`, + "--letterboxing-width": `var(--rdm-width, ${width}px)`, + "--letterboxing-height": `var(--rdm-height, ${height}px)`, } }; @@ -637,7 +636,7 @@ class _RFPHelper { for (let [name, value] of Object.entries(props)) { if (style[name] !== value) { this.push(() => { - style.setProperty(name, value, "important"); + style.setProperty(name, value); }); } } @@ -668,8 +667,11 @@ class _RFPHelper { ? // optional UI components such as the notification box, the find bar // or devtools are constraining this browser's size: recompute custom roundDimensions(parentWidth, parentHeight) - : { width: "", height: "" }; // otherwise we can keep the default (rounded) size - styleChanges.queueIfNeeded(aBrowser, roundedInline); + : { + "--letterboxing-width": "", + "--letterboxing-height": "", + }; // otherwise we can keep the default (rounded) size + styleChanges.queueIfNeeded(browserParent, roundedInline); if (lastRoundedSize) { // check wether the letterboxing margin is less than the border radius, and if so flatten the borders View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f74… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f74… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 32308: use direct browser sizing for letterboxing.
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 922c0f76 by hackademix at 2024-01-31T14:22:39+01:00 fixup! Bug 32308: use direct browser sizing for letterboxing. Bug 42387: hide visual artifacts and fix the status label on rounded letterboxing borders. - - - - - 3 changed files: - browser/base/content/browser.css - browser/base/content/tabbrowser.js - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== browser/base/content/browser.css ===================================== @@ -127,6 +127,11 @@ body { -moz-window-dragging: drag; } +/** + Never modify the following selector without synchronizing + LETTERBOX_CSS_SELECTOR in RFPHelper.sys.jsm, where + --letterboxing-width & --letterboxing-height are actually set. +**/ .letterboxing .browserContainer { /* From Firefox 115 on, .browserContainer layout is flex / column, @@ -137,6 +142,14 @@ body { background: var(--letterboxing-bgcolor); } +.browserDecorator { + display: none; + pointer-events: none; + background: transparent; + position: relative; + z-index: 1; +} + .letterboxing { --letterboxing-border-radius: 8px; --letterboxing-border-top-radius: 0; @@ -145,6 +158,7 @@ body { --letterboxing-bgcolor: var(--tabpanel-background-color); --letterboxing-gradient-color1: var(--letterboxing-bgcolor); --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor)); + --letterboxing-border-color: var(--letterboxing-bgcolor); } .letterboxing.letterboxing-vcenter .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { @@ -157,6 +171,26 @@ body { box-shadow: rgba(0, 0, 0, 0.5) 0px -1px 2px; } +:root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) + > .browserStack:not(.exclude-letterboxing) + > .browserDecorator { + display: initial; + visibility: visible; + border-radius: var(--letterboxing-border-radius); + border-top-left-radius: var(--letterboxing-border-top-radius); + border-top-right-radius: var(--letterboxing-border-top-radius); + box-shadow: var(--letterboxing-border-color) 0px 0px .1px inset, var(--letterboxing-border-color) 0 0 .1px; + border: .1px solid var(--letterboxing-border-color); + outline: .1px solid var(--letterboxing-bgcolor); + height: calc(var(--letterboxing-height) + 1px); + top: -1px; +} + +.letterboxing-vcenter .browserDecorator { + height: auto !important; + top: 0 !important; +} + /* Align status bar with content. TODO: switch to nested CSS selectors for conciseness when available (Firefox >= 117) @@ -167,6 +201,7 @@ body { place-self: end left; left: 0; right: 0; + z-index: 2; --letterboxing-status-left-radius: var(--letterboxing-border-radius); --letterboxing-status-right-radius: 0; } @@ -184,23 +219,24 @@ body { .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) #statuspanel-label { border-radius: 0 0 var(--letterboxing-status-right-radius) var(--letterboxing-status-left-radius); + margin: 0; + border: 1px solid var(--letterboxing-border-color); + max-width: calc(var(--letterboxing-width) * .5); } -/** - Never modify the following selector without synchronizing - LETTERBOX_CSS_SELECTOR in RFPHelper.jsm! -**/ .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser { - /* width & height to be dynamically set by RFPHelper.jsm */ box-shadow: 0px 4px 8px 0px var(--letterboxing-shadow-color); border-radius: var(--letterboxing-border-radius); border-top-left-radius: var(--letterboxing-border-top-radius); border-top-right-radius: var(--letterboxing-border-top-radius); + width: var(--letterboxing-width) !important; + height: var(--letterboxing-height) !important; } :root:not([inDOMFullscreen]) .letterboxing.letterboxing-ready .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) { place-content: var(--letterboxing-vertical-alignment) center; + background: var(--letterboxing-bgcolor); } #toolbar-menubar[autohide="true"] { ===================================== browser/base/content/tabbrowser.js ===================================== @@ -2238,6 +2238,10 @@ stack.className = "browserStack"; stack.appendChild(b); + let decorator = document.createXULElement("hbox"); + decorator.className = "browserDecorator"; + stack.appendChild(decorator); + let browserContainer = document.createXULElement("vbox"); browserContainer.className = "browserContainer"; browserContainer.appendChild(notificationbox); ===================================== toolkit/components/resistfingerprinting/RFPHelper.sys.mjs ===================================== @@ -447,8 +447,7 @@ class _RFPHelper { // find the rule applying the default letterboxing styles to browsers // preemptively in order to beat race conditions on tab/window creation const LETTERBOX_CSS_URL = "chrome://browser/content/browser.css"; - const LETTERBOX_CSS_SELECTOR = - ".letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > browser"; + const LETTERBOX_CSS_SELECTOR = ".letterboxing .browserContainer"; for (let ss of document.styleSheets) { if (ss.href !== LETTERBOX_CSS_URL) { continue; @@ -572,8 +571,8 @@ class _RFPHelper { const r = (width, height) => { lastRoundedSize = {width, height}; return { - width: `var(--rdm-width, ${width}px)`, - height: `var(--rdm-height, ${height}px)`, + "--letterboxing-width": `var(--rdm-width, ${width}px)`, + "--letterboxing-height": `var(--rdm-height, ${height}px)`, } }; @@ -637,7 +636,7 @@ class _RFPHelper { for (let [name, value] of Object.entries(props)) { if (style[name] !== value) { this.push(() => { - style.setProperty(name, value, "important"); + style.setProperty(name, value); }); } } @@ -668,8 +667,11 @@ class _RFPHelper { ? // optional UI components such as the notification box, the find bar // or devtools are constraining this browser's size: recompute custom roundDimensions(parentWidth, parentHeight) - : { width: "", height: "" }; // otherwise we can keep the default (rounded) size - styleChanges.queueIfNeeded(aBrowser, roundedInline); + : { + "--letterboxing-width": "", + "--letterboxing-height": "", + }; // otherwise we can keep the default (rounded) size + styleChanges.queueIfNeeded(browserParent, roundedInline); if (lastRoundedSize) { // check wether the letterboxing margin is less than the border radius, and if so flatten the borders View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/922c0f7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/922c0f7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] 2 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: d66eecaa by Henry Wilkes at 2024-01-31T09:28:02+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42385: Add lox invite dialog. - - - - - 48110609 by Henry Wilkes at 2024-01-31T09:28:03+00:00 fixup! Tor Browser strings Bug 42385: Add lox invite dialog strings. - - - - - 6 changed files: - browser/components/torpreferences/content/connectionPane.js - + browser/components/torpreferences/content/loxInviteDialog.js - + browser/components/torpreferences/content/loxInviteDialog.xhtml - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn - browser/locales/en-US/browser/tor-browser.ftl Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -1321,7 +1321,17 @@ const gLoxStatus = { ); this._invitesButton.addEventListener("click", () => { - // TODO: Show invites. + gSubDialog.open( + "chrome://browser/content/torpreferences/loxInviteDialog.xhtml", + { + features: "resizable=yes", + closedCallback: () => { + // TODO: Listen for events from Lox, rather than call _updateInvites + // directly. + this._updateInvites(); + }, + } + ); }); this._unlockAlertButton.addEventListener("click", () => { // TODO: Have a way to ensure that the cleared event data matches the ===================================== browser/components/torpreferences/content/loxInviteDialog.js ===================================== @@ -0,0 +1,347 @@ +"use strict"; + +const { TorSettings, TorSettingsTopics, TorBridgeSource } = + ChromeUtils.importESModule("resource://gre/modules/TorSettings.sys.mjs"); + +const { Lox, LoxErrors } = ChromeUtils.importESModule( + "resource://gre/modules/Lox.sys.mjs" +); + +/** + * Fake Lox module + +const LoxErrors = { + LoxServerUnreachable: "LoxServerUnreachable", + Other: "Other", +}; + +const Lox = { + remainingInvites: 5, + getRemainingInviteCount() { + return this.remainingInvites; + }, + invites: [ + '{"invite": [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22]}', + '{"invite": [9,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22]}', + ], + getInvites() { + return this.invites; + }, + failError: null, + generateInvite() { + return new Promise((res, rej) => { + setTimeout(() => { + if (this.failError) { + rej({ type: this.failError }); + return; + } + if (!this.remainingInvites) { + rej({ type: LoxErrors.Other }); + return; + } + const invite = JSON.stringify({ + invite: Array.from({ length: 100 }, () => + Math.floor(Math.random() * 265) + ), + }); + this.invites.push(invite); + this.remainingInvites--; + res(invite); + }, 4000); + }); + }, +}; +*/ + +const gLoxInvites = { + /** + * Initialize the dialog. + */ + init() { + this._dialog = document.getElementById("lox-invite-dialog"); + this._remainingInvitesEl = document.getElementById( + "lox-invite-dialog-remaining" + ); + this._generateButton = document.getElementById( + "lox-invite-dialog-generate-button" + ); + this._connectingEl = document.getElementById( + "lox-invite-dialog-connecting" + ); + this._errorEl = document.getElementById("lox-invite-dialog-error-message"); + this._inviteListEl = document.getElementById("lox-invite-dialog-list"); + + this._generateButton.addEventListener("click", () => { + this._generateNewInvite(); + }); + + const menu = document.getElementById("lox-invite-dialog-item-menu"); + this._inviteListEl.addEventListener("contextmenu", event => { + if (!this._inviteListEl.selectedItem) { + return; + } + menu.openPopupAtScreen(event.screenX, event.screenY, true); + }); + menu.addEventListener("popuphidden", () => { + menu.setAttribute("aria-hidden", "true"); + }); + menu.addEventListener("popupshowing", () => { + menu.removeAttribute("aria-hidden"); + }); + document + .getElementById("lox-invite-dialog-copy-menu-item") + .addEventListener("command", () => { + const selected = this._inviteListEl.selectedItem; + if (!selected) { + return; + } + const clipboard = Cc[ + "@mozilla.org/widget/clipboardhelper;1" + ].getService(Ci.nsIClipboardHelper); + clipboard.copyString(selected.textContent); + }); + + // NOTE: TorSettings should already be initialized when this dialog is + // opened. + Services.obs.addObserver(this, TorSettingsTopics.SettingsChanged); + // TODO: Listen for new invites from Lox, when supported. + + // Set initial _loxId value. Can close this dialog. + this._updateLoxId(); + + this._updateRemainingInvites(); + this._updateExistingInvites(); + }, + + /** + * Un-initialize the dialog. + */ + uninit() { + Services.obs.removeObserver(this, TorSettingsTopics.SettingsChanged); + }, + + observe(subject, topic, data) { + switch (topic) { + case TorSettingsTopics.SettingsChanged: + const { changes } = subject.wrappedJSObject; + if ( + changes.includes("bridges.source") || + changes.includes("bridges.lox_id") + ) { + this._updateLoxId(); + } + break; + } + }, + + /** + * The loxId this dialog is shown for. null if uninitailized. + * + * @type {string?} + */ + _loxId: null, + /** + * Update the _loxId value. Will close the dialog if it changes after + * initialization. + */ + _updateLoxId() { + const loxId = + TorSettings.bridges.source === TorBridgeSource.Lox + ? TorSettings.bridges.lox_id + : ""; + if (!loxId || (this._loxId !== null && loxId !== this._loxId)) { + // No lox id, or it changed. Close this dialog. + this._dialog.cancelDialog(); + } + this._loxId = loxId; + }, + + /** + * The invites that are already shown. + * + * @type {Set<string>} + */ + _shownInvites: new Set(), + + /** + * Add a new invite at the start of the list. + * + * @param {string} invite - The invite to add. + */ + _addInvite(invite) { + if (this._shownInvites.has(invite)) { + return; + } + const newInvite = document.createXULElement("richlistitem"); + newInvite.classList.add("lox-invite-dialog-list-item"); + newInvite.textContent = invite; + + this._inviteListEl.prepend(newInvite); + this._shownInvites.add(invite); + }, + + /** + * Update the display of the existing invites. + */ + _updateExistingInvites() { + // Add new invites. + + // NOTE: we only expect invites to be appended, so we won't re-order any. + // NOTE: invites are ordered with the oldest first. + for (const invite of Lox.getInvites()) { + this._addInvite(invite); + } + }, + + /** + * The shown number or remaining invites we have. + * + * @type {integer} + */ + _remainingInvites: 0, + + /** + * Update the display of the remaining invites. + */ + _updateRemainingInvites() { + this._remainingInvites = Lox.getRemainingInviteCount(); + + document.l10n.setAttributes( + this._remainingInvitesEl, + "tor-bridges-lox-remaining-invites", + { numInvites: this._remainingInvites } + ); + this._updateGenerateButtonState(); + }, + + /** + * Whether we are currently generating an invite. + * + * @type {boolean} + */ + _generating: false, + /** + * Set whether we are generating an invite. + * + * @param {boolean} isGenerating - Whether we are generating. + */ + _setGenerating(isGenerating) { + this._generating = isGenerating; + this._updateGenerateButtonState(); + this._connectingEl.classList.toggle("show-connecting", isGenerating); + }, + + /** + * Update the state of the generate button. + */ + _updateGenerateButtonState() { + this._generateButton.disabled = this._generating || !this._remainingInvites; + }, + + /** + * Start generating a new invite. + */ + _generateNewInvite() { + if (this._generating) { + console.error("Already generating an invite"); + return; + } + this._setGenerating(true); + // Clear the previous error. + this._updateGenerateError(null); + // Move focus from the button to the connecting element, since button is + // now disabled. + this._connectingEl.focus(); + + let lostFocus = false; + Lox.generateInvite() + .finally(() => { + // Fetch whether the connecting label still has focus before we hide it. + lostFocus = this._connectingEl.contains(document.activeElement); + this._setGenerating(false); + }) + .then( + invite => { + this._addInvite(invite); + + if (!this._inviteListEl.contains(document.activeElement)) { + // Does not have focus, change the selected item to be the new + // invite (at index 0). + this._inviteListEl.selectedIndex = 0; + } + + if (lostFocus) { + // Move focus to the new invite before we hide the "Connecting" + // message. + this._inviteListEl.focus(); + } + + // TODO: When Lox sends out notifications, let the observer handle the + // change rather than calling _updateRemainingInvites directly. + this._updateRemainingInvites(); + }, + loxError => { + console.error("Failed to generate an invite", loxError); + switch (loxError.type) { + case LoxErrors.LoxServerUnreachable: + this._updateGenerateError("no-server"); + break; + default: + this._updateGenerateError("generic"); + break; + } + + if (lostFocus) { + // Move focus back to the button before we hide the "Connecting" + // message. + this._generateButton.focus(); + } + } + ); + }, + + /** + * Update the shown generation error. + * + * @param {string?} type - The error type, or null if no error should be + * shown. + */ + _updateGenerateError(type) { + // First clear the existing error. + this._errorEl.removeAttribute("data-l10n-id"); + this._errorEl.textContent = ""; + this._errorEl.classList.toggle("show-error", !!type); + + if (!type) { + return; + } + + let errorId; + switch (type) { + case "no-server": + errorId = "lox-invite-dialog-no-server-error"; + break; + case "generic": + // Generic error. + errorId = "lox-invite-dialog-generic-invite-error"; + break; + } + + document.l10n.setAttributes(this._errorEl, errorId); + }, +}; + +window.addEventListener( + "DOMContentLoaded", + () => { + gLoxInvites.init(); + window.addEventListener( + "unload", + () => { + gLoxInvites.uninit(); + }, + { once: true } + ); + }, + { once: true } +); ===================================== browser/components/torpreferences/content/loxInviteDialog.xhtml ===================================== @@ -0,0 +1,56 @@ +<?xml version="1.0" encoding="UTF-8"?> +<?xml-stylesheet href="chrome://global/skin/" type="text/css"?> +<?xml-stylesheet href="chrome://browser/skin/preferences/preferences.css"?> +<?xml-stylesheet href="chrome://browser/content/torpreferences/torPreferences.css"?> + +<window + type="child" + xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" + xmlns:html="http://www.w3.org/1999/xhtml" + data-l10n-id="lox-invite-dialog-title" +> +  + <menupopup id="lox-invite-dialog-item-menu" aria-hidden="true"> + <menuitem + id="lox-invite-dialog-copy-menu-item" + data-l10n-id="lox-invite-dialog-menu-item-copy-invite" + /> + </menupopup> + <dialog id="lox-invite-dialog" buttons="accept"> + <linkset> + <html:link rel="localization" href="browser/tor-browser.ftl" /> + </linkset> + + <script src="chrome://browser/content/torpreferences/loxInviteDialog.js" /> + + <description data-l10n-id="lox-invite-dialog-description"></description> + <html:div id="lox-invite-dialog-generate-area"> + <html:span id="lox-invite-dialog-remaining"></html:span> + <html:button + id="lox-invite-dialog-generate-button" + data-l10n-id="lox-invite-dialog-request-button" + ></html:button> + <html:div id="lox-invite-dialog-message-area"> + <html:span + id="lox-invite-dialog-error-message" + role="alert" + ></html:span> + <html:span + id="lox-invite-dialog-connecting" + role="alert" + tabindex="0" + data-l10n-id="lox-invite-dialog-connecting" + ></html:span> + </html:div> + </html:div> + <html:div + id="lox-invite-dialog-list-label" + data-l10n-id="lox-invite-dialog-invites-label" + ></html:div> + <richlistbox + id="lox-invite-dialog-list" + aria-labelledby="lox-invite-dialog-list-label" + ></richlistbox> + </dialog> +</window> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -820,6 +820,75 @@ dialog#torPreferences-requestBridge-dialog > hbox { background: var(--qr-one); } +/* Lox invite dialog */ + +#lox-invite-dialog-generate-area { + flex: 0 0 auto; + display: grid; + grid-template: + ". remaining button" min-content + "message message message" auto + / 1fr max-content max-content; + gap: 8px; + margin-block: 16px 8px; + align-items: center; +} + +#lox-invite-dialog-remaining { + grid-area: remaining; +} + +#lox-invite-dialog-generate-button { + grid-area: button; +} + +#lox-invite-dialog-message-area { + grid-area: message; + justify-self: end; +} + +#lox-invite-dialog-message-area::after { + /* Zero width space, to ensure we are always one line high. */ + content: "\200B"; +} + +#lox-invite-dialog-error-message { + color: var(--in-content-error-text-color); +} + +#lox-invite-dialog-error-message:not(.show-error) { + display: none; +} + +#lox-invite-dialog-connecting { + color: var(--text-color-deemphasized); + /* TODO: Add spinner ::before */ +} + +#lox-invite-dialog-connecting:not(.show-connecting) { + display: none; +} + +#lox-invite-dialog-list-label { + font-weight: 700; +} + +#lox-invite-dialog-list { + flex: 1 1 auto; + /* basis height */ + height: 10em; + margin-block: 8px; +} + +.lox-invite-dialog-list-item { + white-space: nowrap; + overflow-x: hidden; + /* FIXME: ellipsis does not show. */ + text-overflow: ellipsis; + padding-block: 6px; + padding-inline: 8px; +} + /* Builtin bridge dialog */ #torPreferences-builtinBridge-header { margin: 8px 0 10px 0; ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -9,6 +9,8 @@ browser.jar: content/browser/torpreferences/lox-success.svg (content/lox-success.svg) content/browser/torpreferences/lox-complete-ring.svg (content/lox-complete-ring.svg) content/browser/torpreferences/lox-progress-ring.svg (content/lox-progress-ring.svg) + content/browser/torpreferences/loxInviteDialog.xhtml (content/loxInviteDialog.xhtml) + content/browser/torpreferences/loxInviteDialog.js (content/loxInviteDialog.js) content/browser/torpreferences/bridgeQrDialog.xhtml (content/bridgeQrDialog.xhtml) content/browser/torpreferences/bridgeQrDialog.js (content/bridgeQrDialog.js) content/browser/torpreferences/builtinBridgeDialog.xhtml (content/builtinBridgeDialog.xhtml) ===================================== browser/locales/en-US/browser/tor-browser.ftl ===================================== @@ -296,3 +296,17 @@ user-provide-bridge-dialog-result-invite = The following bridges were shared wit user-provide-bridge-dialog-result-addresses = The following bridges were entered by you. user-provide-bridge-dialog-next-button = .label = Next + +## Bridge pass invite dialog. Temporary. + +lox-invite-dialog-title = + .title = Bridge pass invites +lox-invite-dialog-description = You can ask the bridge bot to create a new invite, which you can share with a trusted contact to give them their own bridge pass. Each invite can only be redeemed once, but you will unlock access to more invites over time. +lox-invite-dialog-request-button = Request new invite +lox-invite-dialog-connecting = Connecting to bridge pass server… +lox-invite-dialog-no-server-error = Unable to connect to bridge pass server. +lox-invite-dialog-generic-invite-error = Failed to create a new invite. +lox-invite-dialog-invites-label = Created invites: +lox-invite-dialog-menu-item-copy-invite = + .label = Copy invite + .accesskey = C View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8069e4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8069e4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] 3 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by richard (＠richard) 31 Jan '24

31 Jan '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 277b6464 by Henry Wilkes at 2024-01-30T15:58:12+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42036: Add Lox to settings UI. - - - - - 9209ad02 by Henry Wilkes at 2024-01-30T15:58:12+00:00 fixup! Tor Browser strings Bug 42036: Add strings for Lox UI. - - - - - 8069e4ee by Henry Wilkes at 2024-01-30T15:58:13+00:00 fixup! Lox integration - - - - - 14 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - + browser/components/torpreferences/content/lox-bridge-icon.svg - + browser/components/torpreferences/content/lox-bridge-pass.svg - + browser/components/torpreferences/content/lox-complete-ring.svg - + browser/components/torpreferences/content/lox-invite-icon.svg - + browser/components/torpreferences/content/lox-progress-ring.svg - + browser/components/torpreferences/content/lox-success.svg - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn - browser/locales/en-US/browser/tor-browser.ftl - toolkit/components/lox/Lox.sys.mjs Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -36,6 +36,60 @@ const { TorStrings } = ChromeUtils.importESModule( "resource://gre/modules/TorStrings.sys.mjs" ); +const { Lox } = ChromeUtils.importESModule( + "resource://gre/modules/Lox.sys.mjs" +); + +/* + * Fake Lox module: + +const Lox = { + levelHistory: [0, 1], + // levelHistory: [1, 2], + // levelHistory: [2, 3], + // levelHistory: [3, 4], + // levelHistory: [0, 1, 2], + // levelHistory: [1, 2, 3], + // levelHistory: [4, 3], + // levelHistory: [4, 1], + // levelHistory: [2, 1], + //levelHistory: [2, 3, 4, 1, 2], + // Gain some invites and then loose them all. Shouldn't show any change. + // levelHistory: [0, 1, 2, 1], + // levelHistory: [1, 2, 3, 1], + getEventData() { + let prevLevel = this.levelHistory[0]; + const events = []; + for (let i = 1; i < this.levelHistory.length; i++) { + const level = this.levelHistory[i]; + events.push({ type: level > prevLevel ? "levelup" : "blockage", newLevel: level }); + prevLevel = level; + } + return events; + }, + clearEventData() { + this.levelHistory = []; + }, + nextUnlock: { date: "2024-01-31T00:00:00Z", nextLevel: 1 }, + //nextUnlock: { date: "2024-01-31T00:00:00Z", nextLevel: 2 }, + //nextUnlock: { date: "2024-01-31T00:00:00Z", nextLevel: 3 }, + //nextUnlock: { date: "2024-01-31T00:00:00Z", nextLevel: 4 }, + getNextUnlock() { + return this.nextUnlock; + }, + remainingInvites: 3, + // remainingInvites: 0, + getRemainingInviteCount() { + return this.remainingInvites; + }, + invites: [], + // invites: ["a", "b"], + getInvites() { + return this.invites; + }, +}; +*/ + const InternetStatus = Object.freeze({ Unknown: 0, Online: 1, @@ -678,15 +732,23 @@ const gBridgeGrid = { row.optionsButton.focus(); }); - row.menu - .querySelector(".tor-bridges-options-qr-one-menu-item") - .addEventListener("click", () => { - const bridgeLine = row.bridgeLine; - if (!bridgeLine) { - return; - } - showBridgeQr(bridgeLine); - }); + const qrItem = row.menu.querySelector( + ".tor-bridges-options-qr-one-menu-item" + ); + row.menu.addEventListener("showing", () => { + qrItem.hidden = !( + this._bridgeSource === TorBridgeSource.UserProvided || + this._bridgeSource === TorBridgeSource.BridgeDB + ); + }); + + qrItem.addEventListener("click", () => { + const bridgeLine = row.bridgeLine; + if (!bridgeLine) { + return; + } + showBridgeQr(bridgeLine); + }); row.menu .querySelector(".tor-bridges-options-copy-one-menu-item") .addEventListener("click", () => { @@ -734,7 +796,11 @@ const gBridgeGrid = { * * @type {string[]} */ - _supportedSources: [TorBridgeSource.BridgeDB, TorBridgeSource.UserProvided], + _supportedSources: [ + TorBridgeSource.BridgeDB, + TorBridgeSource.UserProvided, + TorBridgeSource.Lox, + ], /** * Update the grid to show the latest bridge strings. @@ -1169,6 +1235,335 @@ const gBuiltinBridgesArea = { }, }; +/** + * Controls the bridge pass area. + */ +const gLoxStatus = { + /** + * The status area. + * + * @type {Element?} + */ + _area: null, + /** + * The area for showing the next unlock and invites. + * + * @type {Element?} + */ + _detailsArea: null, + /** + * The day counter for the next unlock. + * + * @type {Element?} + */ + _nextUnlockCounterEl: null, + /** + * Shows the number of remaining invites. + * + * @type {Element?} + */ + _remainingInvitesEl: null, + /** + * The button to show the invites. + * + * @type {Element?} + */ + _invitesButton: null, + /** + * The alert for new unlocks. + * + * @type {Element?} + */ + _unlockAlert: null, + /** + * The alert title. + * + * @type {Element?} + */ + _unlockAlertTitle: null, + /** + * The alert invites item. + * + * @type {Element?} + */ + _unlockAlertInvitesItem: null, + /** + * Button for the user to dismiss the alert. + * + * @type {Element?} + */ + _unlockAlertButton: null, + + /** + * Initialize the bridge pass area. + */ + init() { + this._area = document.getElementById("tor-bridges-lox-status"); + this._detailsArea = document.getElementById("tor-bridges-lox-details"); + this._nextUnlockCounterEl = document.getElementById( + "tor-bridges-lox-next-unlock-counter" + ); + this._remainingInvitesEl = document.getElementById( + "tor-bridges-lox-remaining-invites" + ); + this._invitesButton = document.getElementById( + "tor-bridges-lox-show-invites-button" + ); + this._unlockAlert = document.getElementById("tor-bridges-lox-unlock-alert"); + this._unlockAlertTitle = document.getElementById( + "tor-bridge-unlock-alert-title" + ); + this._unlockAlertInviteItem = document.getElementById( + "tor-bridges-lox-unlock-alert-invites" + ); + this._unlockAlertButton = document.getElementById( + "tor-bridges-lox-unlock-alert-button" + ); + + this._invitesButton.addEventListener("click", () => { + // TODO: Show invites. + }); + this._unlockAlertButton.addEventListener("click", () => { + // TODO: Have a way to ensure that the cleared event data matches the + // current _loxId + Lox.clearEventData(); + // TODO: Listen for events from Lox, rather than call _updateUnlocks + // directly. + this._updateUnlocks(); + }); + + Services.obs.addObserver(this, TorSettingsTopics.SettingsChanged); + // TODO: Listen for new events from Lox, when it is supported. + + // NOTE: Before initializedPromise completes, this area is hidden. + TorSettings.initializedPromise.then(() => { + this._updateLoxId(); + }); + }, + + /** + * Uninitialize the built-in bridges area. + */ + uninit() { + Services.obs.removeObserver(this, TorSettingsTopics.SettingsChanged); + }, + + observe(subject, topic, data) { + switch (topic) { + case TorSettingsTopics.SettingsChanged: + const { changes } = subject.wrappedJSObject; + if ( + changes.includes("bridges.source") || + changes.includes("bridges.lox_id") + ) { + this._updateLoxId(); + } + break; + } + }, + + /** + * The Lox id currently shown. Empty if deactivated, and null if + * uninitialized. + * + * @type {string?} + */ + _loxId: null, + + /** + * Update the shown bridge pass. + */ + async _updateLoxId() { + let loxId = + TorSettings.bridges.source === TorBridgeSource.Lox + ? TorSettings.bridges.lox_id + : ""; + if (loxId !== this._loxId) { + this._loxId = loxId; + this._updateUnlocks(); + this._updateInvites(); + } + }, + + /** + * Update the display of the current or next unlock. + */ + async _updateUnlocks() { + // Cache the loxId before we await. + const loxId = this._loxId; + + if (!loxId) { + // NOTE: This area should already be hidden by the change in Lox source, + // but we clean up for the next non-empty id. + this._area.classList.remove("show-unlock-alert"); + this._area.classList.remove("show-next-unlock"); + return; + } + + let pendingEvents; + let nextUnlock; + let numInvites; + // Fetch the latest events or details about the next unlock. + try { + nextUnlock = await Lox.getNextUnlock(); + pendingEvents = Lox.getEventData(); + numInvites = Lox.getRemainingInviteCount(); + } catch (e) { + console.error("Failed get get lox updates", e); + return; + } + + if (loxId !== this._loxId) { + // Replaced during await. + return; + } + + // Grab focus state before changing visibility. + const alertHadFocus = this._unlockAlert.contains(document.activeElement); + const detailsHadFocus = this._detailsArea.contains(document.activeElement); + + const showAlert = !!pendingEvents.length; + this._area.classList.toggle("show-unlock-alert", showAlert); + this._area.classList.toggle("show-next-unlock", !showAlert); + + if (showAlert) { + // At level 0 and level 1, we do not have any invites. + // If the user starts and ends on level 0 or 1, then overall they would + // have had no change in their invites. So we do not want to show their + // latest updates. + // NOTE: If the user starts at level > 1 and ends with level 1 (levelling + // down to level 0 should not be possible), then we *do* want to show the + // user that they now have "0" invites. + // NOTE: pendingEvents are time-ordered, with the most recent event + // *last*. + const firstEvent = pendingEvents[0]; + // NOTE: We cannot get a blockage event when the user starts at level 1 or + // 0. + const startingAtLowLevel = + firstEvent.type === "levelup" && firstEvent.newLevel <= 2; + const lastEvent = pendingEvents[pendingEvents.length - 1]; + const endingAtLowLevel = lastEvent.newLevel <= 1; + + const showInvites = !(startingAtLowLevel && endingAtLowLevel); + + let blockage = false; + let levelUp = false; + let bridgeGain = false; + // Go through events, in the order that they occurred. + for (const loxEvent of pendingEvents) { + if (loxEvent.type === "levelup") { + levelUp = true; + if (loxEvent.newLevel === 1) { + // Gain 2 bridges from level 0 to 1. + bridgeGain = true; + } + } else { + blockage = true; + } + } + let alertTitleId; + if (levelUp && !blockage) { + alertTitleId = "tor-bridges-lox-upgrade"; + } else { + // Show as blocked bridges replaced. + // Even if we have a mixture of level ups as well. + alertTitleId = "tor-bridges-lox-blocked"; + } + document.l10n.setAttributes(this._unlockAlertTitle, alertTitleId); + document.l10n.setAttributes( + this._unlockAlertInviteItem, + "tor-bridges-lox-new-invites", + { numInvites } + ); + this._unlockAlert.classList.toggle( + "lox-unlock-upgrade", + levelUp && !blockage + ); + this._unlockAlert.classList.toggle("lox-unlock-new-bridges", blockage); + this._unlockAlert.classList.toggle("lox-unlock-gain-bridges", bridgeGain); + this._unlockAlert.classList.toggle("lox-unlock-invites", showInvites); + } else { + // Show next unlock. + // Number of days until the next unlock, rounded up. + const numDays = Math.max( + 1, + Math.ceil( + (new Date(nextUnlock.date).getTime() - Date.now()) / + (24 * 60 * 60 * 1000) + ) + ); + document.l10n.setAttributes( + this._nextUnlockCounterEl, + "tor-bridges-lox-days-until-unlock", + { numDays } + ); + + // Gain 2 bridges from level 0 to 1. After that gain invites. + const bridgeGain = nextUnlock.nextLevel === 1; + const firstInvites = nextUnlock.nextLevel === 2; + const moreInvites = nextUnlock.nextLevel > 2; + + this._detailsArea.classList.toggle("lox-next-gain-bridges", bridgeGain); + this._detailsArea.classList.toggle( + "lox-next-first-invites", + firstInvites + ); + this._detailsArea.classList.toggle("lox-next-more-invites", moreInvites); + } + + if (alertHadFocus && !showAlert) { + // Has become hidden. + this._nextUnlockCounterEl.focus(); + } else if (detailsHadFocus && showAlert) { + this._unlockAlertButton.focus(); + } + }, + + /** + * Update the invites area. + */ + _updateInvites() { + if (!this._loxId) { + return; + } + + let remainingInvites; + let existingInvites; + // Fetch the latest events or details about the next unlock. + try { + remainingInvites = Lox.getRemainingInviteCount(); + existingInvites = Lox.getInvites().length; + } catch (e) { + console.error("Failed get get remaining invites", e); + return; + } + + const hasInvites = !!existingInvites || !!remainingInvites; + + if (!hasInvites) { + if ( + this._remainingInvitesEl.contains(document.activeElement) || + this._invitesButton.contains(document.activeElement) + ) { + // About to loose focus. + // Unexpected for the lox level to loose all invites. + // Move to the top of the details area, which should be visible if we + // just had focus. + this._nextUnlockCounterEl.focus(); + } + } + // Hide the invite elements if we have no historic invites or a way of + // creating new ones. + this._detailsArea.classList.toggle("lox-has-invites", hasInvites); + + document.l10n.setAttributes( + this._remainingInvitesEl, + "tor-bridges-lox-remaining-invites", + { numInvites: remainingInvites } + ); + }, +}; + /** * Controls the bridge settings. */ @@ -1295,6 +1690,7 @@ const gBridgeSettings = { gBridgeGrid.init(); gBuiltinBridgesArea.init(); + gLoxStatus.init(); this._initBridgesMenu(); this._initShareArea(); @@ -1315,6 +1711,7 @@ const gBridgeSettings = { uninit() { gBridgeGrid.uninit(); gBuiltinBridgesArea.uninit(); + gLoxStatus.uninit(); Services.obs.removeObserver(this, TorSettingsTopics.SettingsChanged); }, @@ -1387,6 +1784,10 @@ const gBridgeSettings = { "source-requested", bridgeSource === TorBridgeSource.BridgeDB ); + this._bridgesEl.classList.toggle( + "source-lox", + bridgeSource === TorBridgeSource.Lox + ); // Force the menu to close whenever the source changes. // NOTE: If the menu had focus then hadFocus will be true, and focus will be @@ -1615,7 +2016,10 @@ const gBridgeSettings = { this._bridgesMenu.addEventListener("showing", () => { const canCopy = this._bridgeSource !== TorBridgeSource.BuiltIn; - qrItem.hidden = !this._canQRBridges || !canCopy; + const canShare = + this._bridgeSource === TorBridgeSource.UserProvided || + this._bridgeSource === TorBridgeSource.BridgeDB; + qrItem.hidden = !canShare || !this._canQRBridges; copyItem.hidden = !canCopy; editItem.hidden = this._bridgeSource !== TorBridgeSource.UserProvided; }); @@ -1763,13 +2167,19 @@ const gBridgeSettings = { "chrome://browser/content/torpreferences/provideBridgeDialog.xhtml", { mode }, result => { - if (!result.bridges?.length) { + const loxId = result.loxId; + if (!loxId && !result.addresses?.length) { return null; } return setTorSettings(() => { TorSettings.bridges.enabled = true; - TorSettings.bridges.source = TorBridgeSource.UserProvided; - TorSettings.bridges.bridge_strings = result.bridges; + if (loxId) { + TorSettings.bridges.source = TorBridgeSource.Lox; + TorSettings.bridges.lox_id = loxId; + } else { + TorSettings.bridges.source = TorBridgeSource.UserProvided; + TorSettings.bridges.bridge_strings = result.addresses; + } }); } ); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -172,6 +172,10 @@ id="tor-bridges-requested-label" data-l10n-id="tor-bridges-source-requested" ></html:span> + <html:span id="tor-bridges-lox-label"> + <html:img id="tor-bridges-lox-label-icon" alt="" /> + <html:span data-l10n-id="tor-bridges-source-lox"></html:span> + </html:span> <html:button id="tor-bridges-all-options-button" class="tor-bridges-options-button" @@ -275,7 +279,7 @@ </html:span> </html:div> </html:template> - <html:div id="tor-bridges-share"> + <html:div id="tor-bridges-share" class="tor-bridges-details-box"> <html:h3 id="tor-bridges-share-heading" data-l10n-id="tor-bridges-share-heading" @@ -293,6 +297,77 @@ data-l10n-id="tor-bridges-qr-addresses-button" ></html:button> </html:div> + <html:div id="tor-bridges-lox-status"> + <html:div data-l10n-id="tor-bridges-lox-description"></html:div> + <html:div + id="tor-bridges-lox-details" + class="tor-bridges-details-box tor-bridges-lox-box" + > + <html:img alt="" class="tor-bridges-lox-image-inner" /> + <html:img alt="" class="tor-bridges-lox-image-outer" /> + <html:div + id="tor-bridges-lox-next-unlock-counter" + class="tor-bridges-lox-intro" + tabindex="-1" + ></html:div> + <html:ul class="tor-bridges-lox-list"> + <html:li + id="tor-bridges-lox-next-unlock-gain-bridges" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" + data-l10n-id="tor-bridges-lox-unlock-two-bridges" + ></html:li> + <html:li + id="tor-bridges-lox-next-unlock-first-invites" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" + data-l10n-id="tor-bridges-lox-unlock-first-invites" + ></html:li> + <html:li + id="tor-bridges-lox-next-unlock-more-invites" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" + data-l10n-id="tor-bridges-lox-unlock-more-invites" + ></html:li> + </html:ul> + <html:div id="tor-bridges-lox-remaining-invites"></html:div> + <html:button + id="tor-bridges-lox-show-invites-button" + class="tor-bridges-lox-button" + data-l10n-id="tor-bridges-lox-show-invites-button" + ></html:button> + </html:div> + <html:div + id="tor-bridges-lox-unlock-alert" + role="alert" + class="tor-bridges-details-box tor-bridges-lox-box" + > + <html:img alt="" class="tor-bridges-lox-image-inner" /> + <html:img alt="" class="tor-bridges-lox-image-outer" /> + <html:div + id="tor-bridge-unlock-alert-title" + class="tor-bridges-lox-intro" + ></html:div> + <html:ul class="tor-bridges-lox-list"> + <html:li + id="tor-bridges-lox-unlock-alert-gain-bridges" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" + data-l10n-id="tor-bridges-lox-gained-two-bridges" + ></html:li> + <html:li + id="tor-bridges-lox-unlock-alert-new-bridges" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" + data-l10n-id="tor-bridges-lox-new-bridges" + ></html:li> + <html:li + id="tor-bridges-lox-unlock-alert-invites" + class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" + ></html:li> + </html:ul> + <html:button + id="tor-bridges-lox-unlock-alert-button" + class="tor-bridges-lox-button" + data-l10n-id="tor-bridges-lox-got-it-button" + ></html:button> + </html:div> + </html:div> </html:div> <html:h2 id="tor-bridges-change-heading"></html:h2> <hbox align="center"> ===================================== browser/components/torpreferences/content/lox-bridge-icon.svg ===================================== @@ -0,0 +1,6 @@ +<svg width="18" height="18" viewBox="0 0 18 18" fill="none" xmlns="http://www.w3.org/2000/svg"> +<rect x="0.5" y="0.5" width="17" height="17" rx="1.5" stroke="context-stroke"/> +<path d="M14.625 11.625C14.625 8.5184 12.1066 6 9 6C5.8934 6 3.375 8.5184 3.375 11.625V12.5596H4.25391V11.625C4.25391 9.0038 6.3788 6.87891 9 6.87891C11.6212 6.87891 13.7461 9.0038 13.7461 11.625V12.5596H14.625V11.625Z" fill="context-fill"/> +<path d="M12.9375 11.625C12.9375 9.45037 11.1746 7.6875 9 7.6875C6.82537 7.6875 5.0625 9.45037 5.0625 11.625L5.06242 12.5596H5.94132L5.9414 11.625C5.9414 9.93578 7.31078 8.5664 9 8.5664C10.6892 8.5664 12.0586 9.93578 12.0586 11.625L12.0587 12.5596H12.9376L12.9375 11.625Z" fill="context-fill"/> +<path d="M9 9.375C10.2426 9.375 11.25 10.3824 11.25 11.625L11.2502 12.5596H10.3713L10.3711 11.625C10.3711 10.8678 9.75724 10.2539 9 10.2539C8.24277 10.2539 7.62891 10.8678 7.62891 11.625L7.62873 12.5596H6.74982V11.625C6.74982 10.3824 7.75736 9.375 9 9.375Z" fill="context-fill"/> +</svg> ===================================== browser/components/torpreferences/content/lox-bridge-pass.svg ===================================== @@ -0,0 +1,6 @@ +<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> + <path fill-rule="evenodd" clip-rule="evenodd" d="M0.825958 10.1991C0.191356 9.56445 0.191356 8.53556 0.825958 7.90095L7.89702 0.829887C8.53163 0.195285 9.56052 0.195285 10.1951 0.829887L11.3198 1.95455C11.5751 2.2099 11.6412 2.59873 11.4846 2.92409C11.0031 3.9241 12.0507 4.97168 13.0507 4.4902C13.376 4.33354 13.7649 4.39962 14.0202 4.65497L15.1449 5.77963C15.7795 6.41424 15.7795 7.44313 15.1449 8.07773L8.0738 15.1488C7.4392 15.7834 6.41031 15.7834 5.7757 15.1488L4.65104 14.0241C4.39569 13.7688 4.32961 13.38 4.48627 13.0546C4.96775 12.0546 3.92017 11.007 2.92016 11.4885C2.5948 11.6451 2.20597 11.5791 1.95062 11.3237L0.825958 10.1991ZM1.70984 8.78484C1.56339 8.93128 1.56339 9.16872 1.70984 9.31517L2.64555 10.2509C4.53493 9.58573 6.38902 11.4398 5.72388 13.3292L6.65959 14.2649C6.80603 14.4114 7.04347 14.4114 7.18992 14.2649L14.261 7.19385C14.4074 7.0474 14.4074 6.80996 14.261 6.66352L13.3253 5.7278C11.4359 6.39295 9.5818 4.53886 10.247 2.64948L9.31124 1.71377C9.16479 1.56732 8.92735 1.56732 8.78091 1.71377L1.70984 8.78484Z" fill="context-fill"/> + <path d="M8.87637 9.78539L9.76025 8.90151L10.6441 9.78539L9.76025 10.6693L8.87637 9.78539Z" fill="context-fill"/> + <path d="M7.1086 8.01763L7.99249 7.13374L8.87637 8.01763L7.99249 8.90151L7.1086 8.01763Z" fill="context-fill"/> + <path d="M5.34084 6.24986L6.22472 5.36598L7.1086 6.24986L6.22472 7.13374L5.34084 6.24986Z" fill="context-fill"/> +</svg> ===================================== browser/components/torpreferences/content/lox-complete-ring.svg ===================================== @@ -0,0 +1,12 @@ +<svg width="44" height="44" viewBox="0 0 44 44" fill="none" xmlns="http://www.w3.org/2000/svg"> +<defs> + <filter id="ring-blur" x="0" y="0" width="44" height="44" filterUnits="userSpaceOnUse" color-interpolation-filters="sRGB"> + <feColorMatrix in="SourceGraphic" type="matrix" values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 0 0 0 0.5 0"/> + <feGaussianBlur stdDeviation="2"/> + <feBlend mode="normal" in="SourceGraphic"/> + </filter> +</defs> +<g filter="url(#ring-blur)"> +<path d="M40 22C40 31.9411 31.9411 40 22 40C12.0589 40 4 31.9411 4 22C4 12.0589 12.0589 4 22 4C31.9411 4 40 12.0589 40 22ZM6.25 22C6.25 30.6985 13.3015 37.75 22 37.75C30.6985 37.75 37.75 30.6985 37.75 22C37.75 13.3015 30.6985 6.25 22 6.25C13.3015 6.25 6.25 13.3015 6.25 22Z" fill="context-fill"/> +</g> +</svg> ===================================== browser/components/torpreferences/content/lox-invite-icon.svg ===================================== @@ -0,0 +1,4 @@ +<svg width="18" height="18" viewBox="0 0 18 18" fill="none" xmlns="http://www.w3.org/2000/svg"> +<rect x="0.5" y="0.5" width="17" height="17" rx="1.5" stroke="context-stroke"/> +<path d="M9 9C8.45 9 7.97917 8.80417 7.5875 8.4125C7.19583 8.02083 7 7.55 7 7C7 6.45 7.19583 5.97917 7.5875 5.5875C7.97917 5.19583 8.45 5 9 5C9.55 5 10.0208 5.19583 10.4125 5.5875C10.8042 5.97917 11 6.45 11 7C11 7.55 10.8042 8.02083 10.4125 8.4125C10.0208 8.80417 9.55 9 9 9ZM5 12V11.6C5 11.3167 5.07292 11.0563 5.21875 10.8187C5.36458 10.5812 5.55833 10.4 5.8 10.275C6.31667 10.0167 6.84167 9.82292 7.375 9.69375C7.90833 9.56458 8.45 9.5 9 9.5C9.55 9.5 10.0917 9.56458 10.625 9.69375C11.1583 9.82292 11.6833 10.0167 12.2 10.275C12.4417 10.4 12.6354 10.5812 12.7812 10.8187C12.9271 11.0563 13 11.3167 13 11.6V12C13 12.275 12.9021 12.5104 12.7063 12.7063C12.5104 12.9021 12.275 13 12 13H6C5.725 13 5.48958 12.9021 5.29375 12.7063C5.09792 12.5104 5 12.275 5 12ZM6 12H12V11.6C12 11.5083 11.9771 11.425 11.9313 11.35C11.8854 11.275 11.825 11.2167 11.75 11.175C11.3 10.95 10.8458 10.7813 10.3875 10.6688C9.92917 10.5563 9.46667 10.5 9 10.5C8.53333 10.5 8.07083 10.5563 7.6125 10.6688C7.15417 10.7813 6.7 10.95 6.25 11.175C6.175 11.2167 6.11458 11.275 6.06875 11.35C6.02292 11.425 6 11.5083 6 11.6V12ZM9 8C9.275 8 9.51042 7.90208 9.70625 7.70625C9.90208 7.51042 10 7.275 10 7C10 6.725 9.90208 6.48958 9.70625 6.29375C9.51042 6.09792 9.275 6 9 6C8.725 6 8.48958 6.09792 8.29375 6.29375C8.09792 6.48958 8 6.725 8 7C8 7.275 8.09792 7.51042 8.29375 7.70625C8.48958 7.90208 8.725 8 9 8Z" fill="context-fill"/> +</svg> ===================================== browser/components/torpreferences/content/lox-progress-ring.svg ===================================== @@ -0,0 +1,13 @@ +<svg width="44" height="44" viewBox="0 0 44 44" fill="none" xmlns="http://www.w3.org/2000/svg"> +<defs> + <filter id="ring-blur" x="0" y="0" width="44" height="44" filterUnits="userSpaceOnUse" color-interpolation-filters="sRGB"> + <feColorMatrix in="SourceGraphic" type="matrix" values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 0 0 0 0.5 0"/> + <feGaussianBlur stdDeviation="2"/> + <feBlend mode="normal" in="SourceGraphic"/> + </filter> +</defs> +<path d="M 40,22 C 40,31.9411 31.9411,40 22,40 12.05887,40 4,31.9411 4,22 4,12.0589 12.05887,4 22,4 31.9411,4 40,12.0589 40,22 Z M 6.25,22 c 0,8.6985 7.05152,15.75 15.75,15.75 8.6985,0 15.75,-7.0515 15.75,-15.75 C 37.75,13.3015 30.6985,6.25 22,6.25 13.30152,6.25 6.25,13.3015 6.25,22 Z" fill="context-stroke"/> +<g filter="url(#ring-blur)"> + <path d="m 22,5.125 c 0,-0.62132 0.5042,-1.12866 1.1243,-1.08986 3.0298,0.18958 5.963,1.14263 8.5256,2.77013 0.5245,0.3331 0.6342,1.03991 0.269,1.54257 C 31.5537,8.8505 30.852,8.95814 30.3246,8.62974 28.1505,7.27609 25.6786,6.47291 23.1241,6.29015 22.5044,6.24582 22,5.74632 22,5.125 Z" fill="context-fill"/> +</g> +</svg> ===================================== browser/components/torpreferences/content/lox-success.svg ===================================== @@ -0,0 +1,5 @@ +<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> + <path d="M10 14C9.62059 14.0061 9.25109 13.8787 8.95594 13.6403C8.6608 13.4018 8.45874 13.0672 8.385 12.695L8.028 11.028C7.97202 10.7692 7.84264 10.5321 7.65536 10.345C7.46807 10.1579 7.23081 10.0287 6.972 9.973L5.305 9.616C4.524 9.447 4 8.798 4 8C4 7.202 4.524 6.553 5.305 6.385L6.972 6.028C7.23078 5.97185 7.46794 5.84243 7.65519 5.65519C7.84243 5.46794 7.97185 5.23078 8.028 4.972L8.386 3.305C8.553 2.524 9.202 2 10 2C10.798 2 11.447 2.524 11.615 3.305L11.972 4.972C12.086 5.5 12.5 5.914 13.028 6.027L14.695 6.384C15.476 6.553 16 7.202 16 8C16 8.798 15.476 9.447 14.695 9.615L13.028 9.972C12.769 10.028 12.5316 10.1575 12.3443 10.345C12.157 10.5324 12.0277 10.7699 11.972 11.029L11.614 12.695C11.5407 13.0672 11.3388 13.4019 11.0438 13.6404C10.7488 13.8789 10.3793 14.0062 10 14ZM10 3.25C9.902 3.25 9.669 3.28 9.608 3.566L9.25 5.234C9.14333 5.72828 8.89643 6.18132 8.53888 6.53888C8.18132 6.89643 7.72828 7.14333 7.234 7.25L5.567 7.607C5.281 7.669 5.25 7.902 5.25 8C5.25 8.098 5.281 8.331 5.567 8.393L7.234 8.75C7.72828 8.85667 8.18132 9.10357 8.53888 9.46112C8.89643 9.81868 9.14333 10.2717 9.25 10.766L9.608 12.434C9.669 12.72 9.902 12.75 10 12.75C10.098 12.75 10.331 12.72 10.392 12.434L10.75 10.767C10.8565 10.2725 11.1033 9.81928 11.4609 9.46154C11.8185 9.10379 12.2716 8.85674 12.766 8.75L14.433 8.393C14.719 8.331 14.75 8.098 14.75 8C14.75 7.902 14.719 7.669 14.433 7.607L12.766 7.25C12.2717 7.14333 11.8187 6.89643 11.4611 6.53888C11.1036 6.18132 10.8567 5.72828 10.75 5.234L10.392 3.566C10.331 3.28 10.098 3.25 10 3.25Z" fill="context-fill"/> + <path d="M2.44399 12.151L2.62599 11.302C2.71199 10.9 3.28599 10.9 3.37299 11.302L3.55499 12.151C3.57035 12.2229 3.60618 12.2888 3.65817 12.3408C3.71016 12.3928 3.77609 12.4286 3.84799 12.444L4.69699 12.626C5.09899 12.712 5.09899 13.286 4.69699 13.373L3.84799 13.555C3.77609 13.5704 3.71016 13.6062 3.65817 13.6582C3.60618 13.7102 3.57035 13.7761 3.55499 13.848L3.37299 14.697C3.28699 15.099 2.71299 15.099 2.62599 14.697L2.44399 13.848C2.42863 13.7761 2.39279 13.7102 2.3408 13.6582C2.28881 13.6062 2.22289 13.5704 2.15099 13.555L1.30199 13.373C0.899988 13.287 0.899988 12.713 1.30199 12.626L2.15099 12.444C2.22294 12.4288 2.28893 12.393 2.34094 12.341C2.39295 12.2889 2.42875 12.223 2.44399 12.151Z" fill="context-fill"/> + <path d="M2.44399 2.151L2.62599 1.302C2.71199 0.900004 3.28599 0.900004 3.37299 1.302L3.55499 2.151C3.57035 2.22291 3.60618 2.28883 3.65817 2.34082C3.71016 2.39281 3.77609 2.42864 3.84799 2.444L4.69699 2.626C5.09899 2.712 5.09899 3.286 4.69699 3.373L3.84899 3.556C3.77703 3.57125 3.71105 3.60704 3.65904 3.65905C3.60703 3.71106 3.57123 3.77705 3.55599 3.849L3.37299 4.698C3.28699 5.1 2.71299 5.1 2.62599 4.698L2.44399 3.849C2.42875 3.77705 2.39295 3.71106 2.34094 3.65905C2.28893 3.60704 2.22294 3.57125 2.15099 3.556L1.30199 3.373C0.899988 3.287 0.899988 2.713 1.30199 2.626L2.15099 2.444C2.22294 2.42876 2.28893 2.39296 2.34094 2.34095C2.39295 2.28894 2.42875 2.22296 2.44399 2.151Z" fill="context-fill"/> +</svg> ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -15,6 +15,46 @@ const { TorParsers } = ChromeUtils.importESModule( "resource://gre/modules/TorParsers.sys.mjs" ); +const { Lox, LoxErrors } = ChromeUtils.importESModule( + "resource://gre/modules/Lox.sys.mjs" +); + +/* + * Fake Lox module: + +const LoxErrors = { + BadInvite: "BadInvite", + LoxServerUnreachable: "LoxServerUnreachable", + Other: "Other", +}; + +const Lox = { + failError: null, + // failError: LoxErrors.BadInvite, + // failError: LoxErrors.LoxServerUnreachable, + // failError: LoxErrors.Other, + redeemInvite(invite) { + return new Promise((res, rej) => { + setTimeout(() => { + if (this.failError) { + rej({ type: this.failError }); + } + res("lox-id-000000"); + }, 4000); + }); + }, + validateInvitation(invite) { + return invite.startsWith("lox-invite"); + }, + getBridges(id) { + return [ + "0:0 AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", + "0:1 BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB", + ]; + }, +}; +*/ + const gProvideBridgeDialog = { init() { this._result = window.arguments[0]; @@ -36,10 +76,14 @@ const gProvideBridgeDialog = { document.l10n.setAttributes(document.documentElement, titleId); + // TODO: Make conditional on Lox being enabled. + this._allowLoxInvite = mode !== "edit"; // && Lox.enabled + document.l10n.setAttributes( document.getElementById("user-provide-bridge-textarea-label"), - // TODO change string when we can also accept Lox share codes. - "user-provide-bridge-dialog-textarea-addresses-label" + this._allowLoxInvite + ? "user-provide-bridge-dialog-textarea-addresses-or-invite-label" + : "user-provide-bridge-dialog-textarea-addresses-label" ); this._dialog = document.getElementById("user-provide-bridge-dialog"); @@ -48,6 +92,9 @@ const gProvideBridgeDialog = { this._errorEl = document.getElementById( "user-provide-bridge-error-message" ); + this._connectingEl = document.getElementById( + "user-provide-bridge-connecting" + ); this._resultDescription = document.getElementById( "user-provide-result-description" ); @@ -68,8 +115,9 @@ const gProvideBridgeDialog = { // Set placeholder if not editing. document.l10n.setAttributes( this._textarea, - // TODO: change string when we can also accept Lox share codes. - "user-provide-bridge-dialog-textarea-addresses" + this._allowLoxInvite + ? "user-provide-bridge-dialog-textarea-addresses-or-invite" + : "user-provide-bridge-dialog-textarea-addresses" ); } @@ -98,7 +146,17 @@ const gProvideBridgeDialog = { this._page = page; this._dialog.classList.toggle("show-entry-page", page === "entry"); this._dialog.classList.toggle("show-result-page", page === "result"); - if (page === "entry") { + this.takeFocus(); + this.updateResult(); + this.updateAcceptDisabled(); + this.onAcceptStateChange(); + }, + + /** + * Reset focus position in the dialog. + */ + takeFocus() { + if (this._page === "entry") { this._textarea.focus(); } else { // Move focus to the <xul:window> element. @@ -106,9 +164,6 @@ const gProvideBridgeDialog = { // button (with now different text). document.documentElement.focus(); } - - this.updateAcceptDisabled(); - this.onAcceptStateChange(); }, /** @@ -149,7 +204,36 @@ const gProvideBridgeDialog = { */ updateAcceptDisabled() { this._acceptButton.disabled = - this._page === "entry" && validateBridgeLines(this._textarea.value).empty; + this._page === "entry" && (this.isEmpty() || this._loxLoading); + }, + + /** + * The lox loading state. + * + * @type {boolean} + */ + _loxLoading: false, + + /** + * Set the lox loading state. I.e. whether we are connecting to the lox + * server. + * + * @param {boolean} isLoading - Whether we are loading or not. + */ + setLoxLoading(isLoading) { + this._loxLoading = isLoading; + this._textarea.readOnly = isLoading; + this._connectingEl.classList.toggle("show-connecting", isLoading); + if ( + isLoading && + this._acceptButton.contains( + this._acceptButton.getRootNode().activeElement + ) + ) { + // Move focus to the alert before we disable the button. + this._connectingEl.focus(); + } + this.updateAcceptDisabled(); }, /** @@ -166,23 +250,63 @@ const gProvideBridgeDialog = { // Prevent closing the dialog. event.preventDefault(); - const bridges = this.checkValue(); - if (!bridges.length) { + if (this._loxLoading) { + // User can still click Next whilst loading. + console.error("Already have a pending lox invite"); + return; + } + + // Clear the result from any previous attempt. + delete this._result.loxId; + delete this._result.addresses; + // Clear any previous error. + this.updateError(null); + + const value = this.checkValue(); + if (!value) { + // Not valid. + return; + } + if (value.loxInvite) { + this.setLoxLoading(true); + Lox.redeemInvite(value.loxInvite) + .finally(() => { + // Set set the loading to false before setting the errors. + this.setLoxLoading(false); + }) + .then( + loxId => { + this._result.loxId = loxId; + this.setPage("result"); + }, + loxError => { + console.error("Redeeming failed", loxError); + switch (loxError.type) { + case LoxErrors.BadInvite: + // TODO: distinguish between a bad invite, an invite that has + // expired, and an invite that has already been redeemed. + this.updateError({ type: "bad-invite" }); + break; + case LoxErrors.LoxServerUnreachable: + this.updateError({ type: "no-server" }); + break; + default: + this.updateError({ type: "invite-error" }); + break; + } + } + ); + return; + } + + if (!value.addresses?.length) { // Not valid return; } - this._result.bridges = bridges; - this.updateResult(); + this._result.addresses = value.addresses; this.setPage("result"); }, - /** - * The current timeout for updating the error. - * - * @type {integer?} - */ - _updateErrorTimeout: null, - /** * Update the displayed error. * @@ -191,14 +315,13 @@ const gProvideBridgeDialog = { */ updateError(error) { // First clear the existing error. - if (this._updateErrorTimeout !== null) { - clearTimeout(this._updateErrorTimeout); - } - this._updateErrorTimeout = null; this._errorEl.removeAttribute("data-l10n-id"); this._errorEl.textContent = ""; if (error) { this._textarea.setAttribute("aria-invalid", "true"); + // Move focus back to the text area, likely away from the Next button or + // the "Connecting..." alert. + this._textarea.focus(); } else { this._textarea.removeAttribute("aria-invalid"); } @@ -216,54 +339,122 @@ const gProvideBridgeDialog = { errorId = "user-provide-bridge-dialog-address-error"; errorArgs = { line: error.line }; break; + case "multiple-invites": + errorId = "user-provide-bridge-dialog-multiple-invites-error"; + break; + case "mixed": + errorId = "user-provide-bridge-dialog-mixed-error"; + break; + case "not-allowed-invite": + errorId = "user-provide-bridge-dialog-invite-not-allowed-error"; + break; + case "bad-invite": + errorId = "user-provide-bridge-dialog-bad-invite-error"; + break; + case "no-server": + errorId = "user-provide-bridge-dialog-no-server-error"; + break; + case "invite-error": + // Generic invite error. + errorId = "user-provide-bridge-dialog-generic-invite-error"; + break; } - // Wait a small amount of time to actually set the textContent. Otherwise - // the screen reader (tested with Orca) may not pick up on the change in - // text. - this._updateErrorTimeout = setTimeout(() => { - document.l10n.setAttributes(this._errorEl, errorId, errorArgs); - }, 500); + document.l10n.setAttributes(this._errorEl, errorId, errorArgs); + }, + + /** + * The condition for the value to be empty. + * + * @type {RegExp} + */ + _emptyRegex: /^\s*$/, + /** + * Whether the input is considered empty. + * + * @returns {boolean} true if it is considered empty. + */ + isEmpty() { + return this._emptyRegex.test(this._textarea.value); }, /** * Check the current value in the textarea. * - * @returns {string[]} - The bridge addresses, if the entry is valid. + * @returns {object?} - The bridge addresses, or lox invite, or null if no + * valid value. */ checkValue() { - let bridges = []; - let error = null; - const validation = validateBridgeLines(this._textarea.value); - if (!validation.empty) { + if (this.isEmpty()) { // If empty, we just disable the button, rather than show an error. - if (validation.errorLines.length) { - // Report first error. - error = { - type: "invalid-address", - line: validation.errorLines[0], - }; - } else { - bridges = validation.validBridges; + this.updateError(null); + return null; + } + + let loxInvite = null; + for (let line of this._textarea.value.split(/\r?\n/)) { + line = line.trim(); + if (!line) { + continue; + } + // TODO: Once we have a Lox invite encoding, distinguish between a valid + // invite and something that looks like it should be an invite. + const isLoxInvite = Lox.validateInvitation(line); + if (isLoxInvite) { + if (!this._allowLoxInvite) { + this.updateError({ type: "not-allowed-invite" }); + return null; + } + if (loxInvite) { + this.updateError({ type: "multiple-invites" }); + return null; + } + loxInvite = line; + } else if (loxInvite) { + this.updateError({ type: "mixed" }); + return null; } } - this.updateError(error); - return bridges; + + if (loxInvite) { + return { loxInvite }; + } + + const validation = validateBridgeLines(this._textarea.value); + if (validation.errorLines.length) { + // Report first error. + this.updateError({ + type: "invalid-address", + line: validation.errorLines[0], + }); + return null; + } + + return { addresses: validation.validBridges }; }, /** * Update the shown result on the last page. */ updateResult() { + if (this._page !== "result") { + return; + } + + const loxId = this._result.loxId; + document.l10n.setAttributes( this._resultDescription, - // TODO: Use a different id when added through Lox invite. - "user-provide-bridge-dialog-result-addresses" + loxId + ? "user-provide-bridge-dialog-result-invite" + : "user-provide-bridge-dialog-result-addresses" ); this._bridgeGrid.replaceChildren(); - for (const bridgeLine of this._result.bridges) { + const bridgeResult = loxId ? Lox.getBridges(loxId) : this._result.addresses; + + for (const bridgeLine of bridgeResult) { let details; try { details = TorParsers.parseBridgeLine(bridgeLine); @@ -305,6 +496,11 @@ const gProvideBridgeDialog = { }, }; +document.subDialogSetDefaultFocus = () => { + // Set the focus to the text area on load. + gProvideBridgeDialog.takeFocus(); +}; + window.addEventListener( "DOMContentLoaded", () => { ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -48,8 +48,15 @@ <html:div id="user-provide-bridge-message-area"> <html:span id="user-provide-bridge-error-message" + role="alert" aria-live="assertive" ></html:span> + <html:span + id="user-provide-bridge-connecting" + role="alert" + tabindex="0" + data-l10n-id="user-provide-bridge-dialog-connecting" + ></html:span> </html:div> </html:div> <html:div id="user-provide-bridge-result-page"> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -161,6 +161,10 @@ display: none; } +#tor-bridges-current:not(.source-lox) #tor-bridges-lox-label { + display: none; +} + #tor-bridges-current:not( .source-user, .source-requested @@ -168,6 +172,10 @@ display: none; } +#tor-bridges-current:not(.source-lox) #tor-bridges-lox-status { + display: none; +} + #tor-bridges-none, #tor-bridges-current { margin-inline: 0; @@ -214,6 +222,24 @@ flex: 0 0 auto; } +#tor-bridges-lox-label { + display: flex; + align-items: center; + gap: 6px; +} + +#tor-bridges-lox-label > * { + flex: 0 0 auto; +} + +#tor-bridges-lox-label-icon { + content: url("chrome://browser/content/torpreferences/lox-bridge-pass.svg"); + width: 16px; + height: 16px; + -moz-context-properties: fill; + fill: var(--in-content-icon-color); +} + #tor-bridges-current-heading { margin: 0; margin-inline-end: 2em; @@ -397,11 +423,14 @@ clip-path: inset(50%); } -#tor-bridges-share { +.tor-bridges-details-box { margin-block-start: 24px; border-radius: 4px; border: 1px solid var(--in-content-border-color); padding: 16px; +} + +#tor-bridges-share { display: grid; grid-template: "heading heading heading" min-content @@ -452,6 +481,169 @@ fill: currentColor; } +#tor-bridges-lox-status { + margin-block-start: 8px; +} + +#tor-bridges-lox-status:not(.show-next-unlock) #tor-bridges-lox-details { + display: none; +} + +#tor-bridges-lox-status:not(.show-unlock-alert) #tor-bridges-lox-unlock-alert { + display: none; +} + +.tor-bridges-lox-box { + display: grid; + grid-template: + "image intro intro" min-content + ". list list" auto + ". invites button" min-content + / min-content 1fr max-content; + align-items: start; + gap: 0 8px; +} + +.tor-bridges-lox-image-outer { + grid-area: image; + /* The ring is 36px by 36px, but has 4px of padding for a Gaussian blur. */ + width: 44px; + height: 44px; + margin: -4px; + align-self: center; + justify-self: center; + /* fill is the progress, stroke is the empty ring. */ + -moz-context-properties: fill, stroke; + fill: var(--in-content-success-icon-color); + stroke: var(--in-content-border-color); + content: url("chrome://browser/content/torpreferences/lox-progress-ring.svg"); +} + +#tor-bridges-lox-unlock-alert.lox-unlock-upgrade .tor-bridges-lox-image-outer { + content: url("chrome://browser/content/torpreferences/lox-complete-ring.svg"); +} + +.tor-bridges-lox-image-inner { + grid-area: image; + /* Extra 4px space for gaussian blur. */ + width: 16px; + height: 16px; + align-self: center; + justify-self: center; + -moz-context-properties: fill; + fill: var(--in-content-icon-color); +} + +#tor-bridges-lox-details .tor-bridges-lox-image-inner { + content: url("chrome://browser/content/torpreferences/lox-bridge-pass.svg"); +} + +#tor-bridges-lox-unlock-alert .tor-bridges-lox-image-inner { + content: url("chrome://browser/content/torpreferences/bridge.svg"); +} + +#tor-bridges-lox-unlock-alert.lox-unlock-upgrade .tor-bridges-lox-image-inner { + content: url("chrome://browser/content/torpreferences/lox-success.svg"); +} + +.tor-bridges-lox-intro { + grid-area: intro; + font-weight: 700; + align-self: center; +} + +.tor-bridges-lox-list { + grid-area: list; + margin: 0; + padding: 0; + display: grid; + /* Align the icons, as if list markers. */ + grid-template-columns: max-content 1fr; + align-items: start; +} + +.tor-bridges-lox-list-item { + display: contents; +} + +.tor-bridges-lox-list-item::before { + /* We use ::before rather than list-style-image to have more control. */ + display: block; + box-sizing: content-box; + width: 18px; + height: 18px; + margin-inline: 4px 6px; + /* We want the icons to be center-aligned relative to the *first* line. */ + /* TODO: After firefox 120, can use line-height unit "lh" to do proper + * center-alignment: calc((1lh - 18px) / 2) + * For now, we use 3.4ex as an approximation for 1lh */ + margin-block-start: calc((3.4ex - 18px) / 2); + /* fill is the icon color, stroke is the border color. */ + -moz-context-properties: fill, stroke; + fill: var(--in-content-icon-color); +} + +.tor-bridges-lox-list-item-bridge::before { + content: url("chrome://browser/content/torpreferences/lox-bridge-icon.svg"); +} + +.tor-bridges-lox-list-item-invite::before { + content: url("chrome://browser/content/torpreferences/lox-invite-icon.svg"); +} + +#tor-bridges-lox-details .tor-bridges-lox-list-item::before { + stroke: var(--in-content-border-color); +} + +#tor-bridges-lox-unlock-alert .tor-bridges-lox-list-item::before { + stroke: var(--in-content-success-icon-color); +} + +#tor-bridges-lox-details:not(.lox-next-gain-bridges) #tor-bridges-lox-next-unlock-gain-bridges { + display: none; +} + +#tor-bridges-lox-details:not(.lox-next-first-invites) #tor-bridges-lox-next-unlock-first-invites { + display: none; +} + +#tor-bridges-lox-details:not(.lox-next-more-invites) #tor-bridges-lox-next-unlock-more-invites { + display: none; +} + + +#tor-bridges-lox-unlock-alert:not(.lox-unlock-gain-bridges) #tor-bridges-lox-unlock-alert-gain-bridges { + display: none; +} + +#tor-bridges-lox-unlock-alert:not(.lox-unlock-new-bridges) #tor-bridges-lox-unlock-alert-new-bridges { + display: none; +} + +#tor-bridges-lox-unlock-alert:not(.lox-unlock-invites) #tor-bridges-lox-unlock-alert-invites { + display: none; +} + +#tor-bridges-lox-remaining-invites { + grid-area: invites; + justify-self: end; + align-self: center; +} + +#tor-bridges-lox-details:not(.lox-has-invites) :is( + #tor-bridges-lox-remaining-invites, + #tor-bridges-lox-show-invites-button +) { + display: none; +} + +.tor-bridges-lox-button { + grid-area: button; + margin: 0; + line-height: 1; + align-self: center; +} + #tor-bridges-provider-heading { font-size: 1.14em; margin-block: 48px 8px; @@ -723,6 +915,15 @@ groupbox#torPreferences-bridges-group textarea { display: none; } +#user-provide-bridge-connecting { + color: var(--text-color-deemphasized); + /* TODO: Add spinner ::before */ +} + +#user-provide-bridge-connecting:not(.show-connecting) { + display: none; +} + #user-provide-bridge-result-page { flex: 1 1 0; min-height: 0; ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -3,6 +3,12 @@ browser.jar: content/browser/torpreferences/bridge-qr.svg (content/bridge-qr.svg) content/browser/torpreferences/telegram-logo.svg (content/telegram-logo.svg) content/browser/torpreferences/bridge-bot.svg (content/bridge-bot.svg) + content/browser/torpreferences/lox-invite-icon.svg (content/lox-invite-icon.svg) + content/browser/torpreferences/lox-bridge-icon.svg (content/lox-bridge-icon.svg) + content/browser/torpreferences/lox-bridge-pass.svg (content/lox-bridge-pass.svg) + content/browser/torpreferences/lox-success.svg (content/lox-success.svg) + content/browser/torpreferences/lox-complete-ring.svg (content/lox-complete-ring.svg) + content/browser/torpreferences/lox-progress-ring.svg (content/lox-progress-ring.svg) content/browser/torpreferences/bridgeQrDialog.xhtml (content/bridgeQrDialog.xhtml) content/browser/torpreferences/bridgeQrDialog.js (content/bridgeQrDialog.js) content/browser/torpreferences/builtinBridgeDialog.xhtml (content/builtinBridgeDialog.xhtml) ===================================== browser/locales/en-US/browser/tor-browser.ftl ===================================== @@ -56,6 +56,10 @@ tor-bridges-your-bridges = Your bridges tor-bridges-source-user = Added by you tor-bridges-source-built-in = Built-in tor-bridges-source-requested = Requested from Tor +# Here "Bridge pass" is a noun: a bridge pass gives users access to some tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +# This is shown when the user is getting their bridges from Lox. +tor-bridges-source-lox = Bridge pass # The "..." menu button for all current bridges. tor-bridges-options-button = .title = All bridges @@ -116,12 +120,75 @@ tor-bridges-update-changed-bridges = Your Tor bridges have changed. # Shown for requested bridges and bridges added by the user. tor-bridges-share-heading = Help others connect -# tor-bridges-share-description = Share your bridges with trusted contacts. tor-bridges-copy-addresses-button = Copy addresses tor-bridges-qr-addresses-button = .title = Show QR code +# Shown when using a "bridge pass", i.e. using Lox. +# Here "bridge pass" is a noun: a bridge pass gives users access to some tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +# Here "bridge bot" refers to a service that automatically gives out bridges for the user to use, i.e. the Lox authority. +tor-bridges-lox-description = With a bridge pass, the bridge bot will send you new bridges when your bridges get blocked. If your bridges don’t get blocked, you’ll unlock invites that let you share bridges with trusted contacts. +# The number of days until the user's "bridge pass" is upgraded. +# $numDays (Number) - The number of days until the next upgrade, an integer (1 or higher). +# The "[one]" and "[other]" are special Fluent syntax to mark plural categories that depend on the value of "$numDays". You can use any number of plural categories that work for your locale: "[zero]", "[one]", "[two]", "[few]", "[many]" and/or "[other]". The "*" marks a category as default, and is required. +# See https://projectfluent.org/fluent/guide/selectors.html . +# So in English, the first form will be used if $numDays is "1" (singular) and the second form will be used if $numDays is anything else (plural). +tor-bridges-lox-days-until-unlock = + { $numDays -> + [one] { $numDays } day until you unlock: + *[other] { $numDays } days until you unlock: + } +# This is shown as a list item after "N days until you unlock:" when the user will gain two more bridges in the future. +# Here "bridge bot" refers to a service that automatically gives out bridges for the user to use, i.e. the Lox authority. +tor-bridges-lox-unlock-two-bridges = +2 bridges from the bridge bot +# This is shown as a list item after "N days until you unlock:" when the user will gain access to invites for the first time. +# Here "invites" is a noun, short for "invitations". +tor-bridges-lox-unlock-first-invites = Invites for your trusted contacts +# This is shown as a list item after "N days until you unlock:" when the user already has invites. +# Here "invites" is a noun, short for "invitations". +tor-bridges-lox-unlock-more-invites = More invites for your trusted contacts +# Here "invite" is a noun, short for "invitation". +# $numInvites (Number) - The number of invites remaining, an integer (0 or higher). +# The "[one]" and "[other]" are special Fluent syntax to mark plural categories that depend on the value of "$numInvites". You can use any number of plural categories that work for your locale: "[zero]", "[one]", "[two]", "[few]", "[many]" and/or "[other]". The "*" marks a category as default, and is required. +# See https://projectfluent.org/fluent/guide/selectors.html . +# So in English, the first form will be used if $numInvites is "1" (singular) and the second form will be used if $numInvites is anything else (plural). +tor-bridges-lox-remaining-invites = + { $numInvites -> + [one] { $numInvites } invite remaining + *[other] { $numInvites } invites remaining + } +# Here "invites" is a noun, short for "invitations". +tor-bridges-lox-show-invites-button = Show invites + +# Shown when the user's "bridge pass" has been upgraded. +# Here "bridge pass" is a noun: a bridge pass gives users access to some tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +tor-bridges-lox-upgrade = Your bridge pass has been upgraded! +# Shown when the user's bridges accessed through "bridge pass" have been blocked. +tor-bridges-lox-blocked = Your blocked bridges have been replaced +# Shown *after* the user has had their blocked bridges replaced. +# Here "bridge bot" refers to a service that automatically gives out bridges for the user to use, i.e. the Lox authority. +tor-bridges-lox-new-bridges = New bridges from the bridge bot +# Shown *after* the user has gained two more bridges. +# Here "bridge bot" refers to a service that automatically gives out bridges for the user to use, i.e. the Lox authority. +tor-bridges-lox-gained-two-bridges = +2 bridges from the bridge bot +# Shown *after* a user's "bridge pass" has changed. +# Here "invite" is a noun, short for "invitation". +# $numInvites (Number) - The number of invites remaining, an integer (0 or higher). +# The "[one]" and "[other]" are special Fluent syntax to mark plural categories that depend on the value of "$numInvites". You can use any number of plural categories that work for your locale: "[zero]", "[one]", "[two]", "[few]", "[many]" and/or "[other]". The "*" marks a category as default, and is required. +# See https://projectfluent.org/fluent/guide/selectors.html . +# So in English, the first form will be used if $numInvites is "1" (singular) and the second form will be used if $numInvites is anything else (plural). +tor-bridges-lox-new-invites = + { $numInvites -> + [one] You now have { $numInvites } remaining invite for your trusted contacts + *[other] You now have { $numInvites } remaining invites for your trusted contacts + } +# Button for the user to acknowledge a change in their "bridge pass". +tor-bridges-lox-got-it-button = Got it + + # Shown as a heading when the user has no current bridges. tor-bridges-add-bridges-heading = Add bridges # Shown as a heading when the user has existing bridges that can be replaced. @@ -182,13 +249,50 @@ user-provide-bridge-dialog-description = Use bridges provided by a trusted organ user-provide-bridge-dialog-learn-more = Learn more # Short accessible name for the bridge addresses text area. user-provide-bridge-dialog-textarea-addresses-label = Bridge addresses +# Here "invite" is a noun, short for "invitation". +# Short accessible name for text area when it can accept either bridge address or a single "bridge pass" invite. +user-provide-bridge-dialog-textarea-addresses-or-invite-label = Bridge addresses or invite # Placeholder shown when adding new bridge addresses. user-provide-bridge-dialog-textarea-addresses = .placeholder = Paste your bridge addresses here +# Placeholder shown when the user can add new bridge addresses or a single "bridge pass" invite. +# Here "bridge pass invite" is a noun: a bridge pass invite can be shared with other users to give them their own bridge pass, so they can get access to tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +# And "invite" is simply short for "invitation". +# NOTE: "invite" is singular, whilst "addresses" is plural. +user-provide-bridge-dialog-textarea-addresses-or-invite = + .placeholder = Paste your bridge addresses or a bridge pass invite here # Error shown when one of the address lines is invalid. # $line (Number) - The line number for the invalid address. user-provide-bridge-dialog-address-error = Incorrectly formatted bridge address on line { $line }. +# Error shown when the user has entered more than one "bridge pass" invite. +# Here "invite" is a noun, short for "invitation". +user-provide-bridge-dialog-multiple-invites-error = Cannot include more than one invite. +# Error shown when the user has mixed their invite with addresses. +# Here "invite" is a noun, short for "invitation". +user-provide-bridge-dialog-mixed-error = Cannot mix bridge addresses with an invite. +# Error shown when the user has entered an invite when it is not supported. +# Here "bridge pass invite" is a noun: a bridge pass invite can be shared with other users to give them their own bridge pass, so they can get access to tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +# And "invite" is simply short for "invitation". +user-provide-bridge-dialog-invite-not-allowed-error = Cannot include a bridge pass invite. +# Error shown when the invite was not accepted by the server. +user-provide-bridge-dialog-bad-invite-error = Invite was not accepted. Try a different one. +# Error shown when the "bridge pass" server does not respond. +# Here "bridge pass" is a noun: a bridge pass gives users access to some tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +user-provide-bridge-dialog-no-server-error = Unable to connect to bridge pass server. +# Generic error when an invite failed. +# Here "invite" is a noun, short for "invitation". +user-provide-bridge-dialog-generic-invite-error = Failed to redeem invite. + +# Here "bridge pass" is a noun: a bridge pass gives users access to some tor bridges. +# So "pass" is referring to something that gives permission or access. Similar to "token", "permit" or "voucher", but for permanent use rather than one-time. +user-provide-bridge-dialog-connecting = Connecting to bridge pass server… +# Shown after the user has entered a "bridge pass" invite. +user-provide-bridge-dialog-result-invite = The following bridges were shared with you. +# Shown after the user has entered bridge addresses. user-provide-bridge-dialog-result-addresses = The following bridges were entered by you. user-provide-bridge-dialog-next-button = .label = Next ===================================== toolkit/components/lox/Lox.sys.mjs ===================================== @@ -128,12 +128,12 @@ class LoxImpl { } /** - * Formats and returns bridges from the stored Lox credential + * Formats and returns bridges from the stored Lox credential. * - * @param {string} loxid The id string associated with a lox credential + * @param {string} loxid The id string associated with a lox credential. * * @returns {string[]} An array of formatted bridge lines. The array is empty - * if there are no bridges. + * if there are no bridges. */ getBridges(loxid) { if (!this.#initialized) { @@ -250,6 +250,7 @@ class LoxImpl { this.#pubKeyPromise = this.#makeRequest("pubkeys", []) .then(pubKeys => { this.#pubKeys = JSON.stringify(pubKeys); + this.#store(); }) .catch(() => { // We always try to update, but if that doesn't work fall back to stored data @@ -266,6 +267,7 @@ class LoxImpl { this.#encTablePromise = this.#makeRequest("reachability", []) .then(encTable => { this.#encTable = JSON.stringify(encTable); + this.#store(); }) .catch(() => { // Try to update first, but if that doesn't work fall back to stored data @@ -283,6 +285,7 @@ class LoxImpl { this.#constantsPromise = this.#makeRequest("constants", []) .then(constants => { this.#constants = JSON.stringify(constants); + this.#store(); }) .catch(() => { if (!this.#constants) { @@ -389,18 +392,17 @@ class LoxImpl { } /** - * Parses an input string to check if it is a valid Lox invitation + * Parses an input string to check if it is a valid Lox invitation. * - * @param {string} invite A Lox invitation - * @returns {Promise<bool>} A promise that resolves to true if the value passed - * in was a Lox invitation and false if it is not + * @param {string} invite A Lox invitation. + * @returns {bool} Whether the value passed in was a Lox invitation. */ - async validateInvitation(invite) { + validateInvitation(invite) { if (!this.#initialized) { throw new LoxError(LoxErrors.NotInitialized); } try { - await lazy.invitation_is_trusted(invite); + lazy.invitation_is_trusted(invite); } catch (err) { console.log(err); return false; @@ -420,22 +422,27 @@ class LoxImpl { } /** - * Redeems a Lox invitation to obtain a credential and bridges + * Redeems a Lox invitation to obtain a credential and bridges. * - * @param {string} invite A Lox invitation - * @returns {Promise<string>} A promise with the loxid of the associated credential on success + * @param {string} invite A Lox invitation. + * @returns {string} The loxid of the associated credential on success. */ async redeemInvite(invite) { if (!this.#initialized) { throw new LoxError(LoxErrors.NotInitialized); } await this.#getPubKeys(); - let request = await lazy.open_invite(invite.invite); + let request = await lazy.open_invite(JSON.parse(invite).invite); let id = this.#genLoxId(); - let response = await this.#makeRequest( - "openreq", - JSON.parse(request).request - ); + let response; + try { + response = await this.#makeRequest( + "openreq", + JSON.parse(request).request + ); + } catch { + throw new LoxError(LoxErrors.LoxServerUnreachable); + } console.log("openreq response: ", response); if (response.hasOwnProperty("error")) { throw new LoxError(LoxErrors.BadInvite); @@ -451,9 +458,9 @@ class LoxImpl { } /** - * Get metadata on all invites historically generated by this credential + * Get metadata on all invites historically generated by this credential. * - * @returns {object[]} A list of all historical invites + * @returns {string[]} A list of all historical invites. */ getInvites() { if (!this.#initialized) { @@ -463,12 +470,14 @@ class LoxImpl { } /** - * Generates a new trusted Lox invitation that a user can pass to their contacts + * Generates a new trusted Lox invitation that a user can pass to their + * contacts. * - * @returns {Promise<string>} A promise that resolves to a valid Lox invitation. The promise - * will reject if: - * - there is no saved Lox credential - * - the saved credential does not have any invitations available + * Throws if: + * - there is no saved Lox credential, or + * - the saved credential does not have any invitations available. + * + * @returns {string} A valid Lox invitation. */ async generateInvite() { if (!this.#initialized) { @@ -514,11 +523,10 @@ class LoxImpl { } /** - * Get the number of invites that a user has remaining + * Get the number of invites that a user has remaining. * - * @returns {Promise<int>} A promise with the number of invites that can still be generated - * by a user's credential. This promise will reject if: - * - There is no credential + * @returns {int} The number of invites that can still be generated by a + * user's credential. */ getRemainingInviteCount() { if (!this.#initialized) { @@ -691,11 +699,10 @@ class LoxImpl { */ /** - * Get a list of accumulated events + * Get a list of accumulated events. * - * @returns {Promise<EventData[]>} A promise with a list of the accumulated, - * unacknowledged events associated with a user's credential. This promise will reject if - * - There is no credential + * @returns {EventData[]} A list of the accumulated, unacknowledged events + * associated with a user's credential. */ getEventData() { if (!this.#initialized) { @@ -709,7 +716,7 @@ class LoxImpl { } /** - * Clears accumulated event data + * Clears accumulated event data. */ clearEventData() { if (!this.#initialized) { @@ -720,7 +727,7 @@ class LoxImpl { } /** - * Clears accumulated invitations + * Clears accumulated invitations. */ clearInvites() { if (!this.#initialized) { @@ -739,7 +746,9 @@ class LoxImpl { */ /** - * Get dates at which access to new features will unlock + * Get details about the next feature unlock. + * + * @returns {UnlockData} - Details about the next unlock. */ async getNextUnlock() { if (!this.#initialized) { @@ -753,10 +762,10 @@ class LoxImpl { let nextUnlocks = JSON.parse( lazy.get_next_unlock(this.#constants, this.#credentials[loxid]) ); - const level = lazy.get_trust_level(this.#credentials[loxid]); + const level = parseInt(lazy.get_trust_level(this.#credentials[loxid])); const unlocks = { date: nextUnlocks.trust_level_unlock_date, - level: level + 1, + nextLevel: level + 1, }; return unlocks; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fd4565… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fd4565… You're receiving this email because of your account on gitlab.torproject.org.

1 0