- tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] Bug 1909099 - Always clean up old session restore and sync log files....
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 3b5161cd by Sam Foster at 2024-08-31T13:04:47+08:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - 1 changed file: - toolkit/modules/LogManager.sys.mjs Changes: ===================================== toolkit/modules/LogManager.sys.mjs ===================================== @@ -384,12 +384,7 @@ export class LogManager { filename, this._log ); - // It's not completely clear to markh why we only do log cleanups - // for errors, but for now the Sync semantics have been copied... - // (one theory is that only cleaning up on error makes it less - // likely old error logs would be removed, but that's not true if - // there are occasional errors - let's address this later!) - if (reason == this.ERROR_LOG_WRITTEN && !this._cleaningUpFileLogs) { + if (!this._cleaningUpFileLogs) { this._log.trace("Running cleanup."); try { await this.cleanupLogs(); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3b5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3b5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] Bug 1909099 - Always clean up old session restore and sync log files....
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: dfd03239 by Sam Foster at 2024-08-31T13:04:35+08:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - 1 changed file: - toolkit/modules/LogManager.sys.mjs Changes: ===================================== toolkit/modules/LogManager.sys.mjs ===================================== @@ -384,12 +384,7 @@ export class LogManager { filename, this._log ); - // It's not completely clear to markh why we only do log cleanups - // for errors, but for now the Sync semantics have been copied... - // (one theory is that only cleaning up on error makes it less - // likely old error logs would be removed, but that's not true if - // there are occasional errors - let's address this later!) - if (reason == this.ERROR_LOG_WRITTEN && !this._cleaningUpFileLogs) { + if (!this._cleaningUpFileLogs) { this._log.trace("Running cleanup."); try { await this.cleanupLogs(); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dfd0323… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dfd0323… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] Bug 1909099 - Always clean up old session restore and sync log files....
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a6ebf61b by Sam Foster at 2024-08-31T13:04:26+08:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - 1 changed file: - toolkit/modules/LogManager.sys.mjs Changes: ===================================== toolkit/modules/LogManager.sys.mjs ===================================== @@ -384,12 +384,7 @@ export class LogManager { filename, this._log ); - // It's not completely clear to markh why we only do log cleanups - // for errors, but for now the Sync semantics have been copied... - // (one theory is that only cleaning up on error makes it less - // likely old error logs would be removed, but that's not true if - // there are occasional errors - let's address this later!) - if (reason == this.ERROR_LOG_WRITTEN && !this._cleaningUpFileLogs) { + if (!this._cleaningUpFileLogs) { this._log.trace("Running cleanup."); try { await this.cleanupLogs(); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a6ebf61… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a6ebf61… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 56aaa8f3 by Anna Weine at 2024-08-31T13:01:28+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1802,7 +1802,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1907,11 +1908,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -396,10 +409,11 @@ TestArray.addTest( "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", function() { var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; async function doTest() { - let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, "ECDH", false, ["deriveKey"]); - let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, "ECDH", false, []); + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); let ecdhAlg = { name: "ECDH", public: pubKey }; let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); @@ -454,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/56a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/56a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 9380dbe6 by Anna Weine at 2024-08-31T12:38:09+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1802,7 +1802,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1907,11 +1908,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -396,10 +409,11 @@ TestArray.addTest( "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", function() { var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; async function doTest() { - let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, "ECDH", false, ["deriveKey"]); - let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, "ECDH", false, []); + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); let ecdhAlg = { name: "ECDH", public: pubKey }; let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); @@ -454,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9380dbe… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9380dbe… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 62e7b72b by Anna Weine at 2024-08-31T12:40:33+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1802,7 +1802,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1907,11 +1908,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -396,10 +409,11 @@ TestArray.addTest( "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", function() { var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; async function doTest() { - let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, "ECDH", false, ["deriveKey"]); - let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, "ECDH", false, []); + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); let ecdhAlg = { name: "ECDH", public: pubKey }; let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); @@ -454,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/62e7b72… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/62e7b72… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.15.0esr-13.5-1] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch mullvad-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 7d80ca6a by Anna Weine at 2024-08-31T12:30:55+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1777,7 +1777,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1882,11 +1883,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -391,6 +404,28 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; + + async function doTest() { + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); + let ecdhAlg = { name: "ECDH", public: pubKey }; + let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; + let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); + let hmacAlg = { name: "HMAC", hash: "SHA-256" }; + let hmacKey = await crypto.subtle.deriveKey(hkdfAlg, hkdfKey, hmacAlg, false, ["sign"]); + return crypto.subtle.sign("HMAC", hmacKey, new Uint8Array()); + } + const expected = util.hex2abv("acf62832fa93469824cd997593bc963b28a68e6f73f4516bbe51b35942fe9811"); + doTest().then(memcmp_complete(that, expected), error(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "SPKI import/export of public ECDH keys (P-256)", @@ -433,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/7d8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/7d8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.15.0esr-13.5-1] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch base-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: e9d93c56 by Anna Weine at 2024-08-31T12:30:48+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1777,7 +1777,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1882,11 +1883,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -391,6 +404,28 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; + + async function doTest() { + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); + let ecdhAlg = { name: "ECDH", public: pubKey }; + let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; + let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); + let hmacAlg = { name: "HMAC", hash: "SHA-256" }; + let hmacKey = await crypto.subtle.deriveKey(hkdfAlg, hkdfKey, hmacAlg, false, ["sign"]); + return crypto.subtle.sign("HMAC", hmacKey, new Uint8Array()); + } + const expected = util.hex2abv("acf62832fa93469824cd997593bc963b28a68e6f73f4516bbe51b35942fe9811"); + doTest().then(memcmp_complete(that, expected), error(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "SPKI import/export of public ECDH keys (P-256)", @@ -433,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d93c5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d93c5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-2] Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in...
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser Commits: 84c46aeb by Anna Weine at 2024-08-31T12:30:34+08:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 4 changed files: - dom/crypto/WebCryptoTask.cpp - dom/crypto/test/test-vectors.js - dom/crypto/test/test_WebCrypto_ECDH.html - dom/crypto/test/test_WebCrypto_ECDSA.html Changes: ===================================== dom/crypto/WebCryptoTask.cpp ===================================== @@ -1777,7 +1777,8 @@ class ImportEcKeyTask : public ImportKeyTask { return; } - if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW)) { + if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_RAW) || + mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { RootedDictionary<EcKeyImportParams> params(aCx); mEarlyRv = Coerce(aCx, params, aAlgorithm); if (NS_FAILED(mEarlyRv) || !params.mNamedCurve.WasPassed()) { @@ -1882,11 +1883,21 @@ class ImportEcKeyTask : public ImportKeyTask { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } - // Extract 'crv' parameter from JWKs. + // Checking the 'crv' consistency if (mFormat.EqualsLiteral(WEBCRYPTO_KEY_FORMAT_JWK)) { - if (!NormalizeToken(mJwk.mCrv.Value(), mNamedCurve)) { + // the curve stated in 'crv field' + nsString namedCurveFromCrv; + if (!NormalizeToken(mJwk.mCrv.Value(), namedCurveFromCrv)) { return NS_ERROR_DOM_NOT_SUPPORTED_ERR; } + + // https://w3c.github.io/webcrypto/#ecdh-operations + // https://w3c.github.io/webcrypto/#ecdsa-operations + // If namedCurve is not equal to the namedCurve member of + // normalizedAlgorithm (mNamedCurve in our case), throw a DataError. + if (!mNamedCurve.Equals(namedCurveFromCrv)) { + return NS_ERROR_DOM_DATA_ERR; + } } return NS_OK; } ===================================== dom/crypto/test/test-vectors.js ===================================== @@ -901,6 +901,13 @@ let tv = { y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", }, + jwk_different_crv: { + kty: "EC", + crv: "P-521", + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + // The crv parameter is missing. jwk_missing_crv: { kty: "EC", @@ -1017,6 +1024,18 @@ let tv = { }, }, + // An ECDSA key in JWK format, which an "crv" field doesn't match the alg's crv. + ecdsa_jwk_crv_mismatch: { + pub_jwk: { + kty: "EC", + crv: "P-256", + alg: "ECDSA", + + x: "XOe4bjsyZgQD5jcS7wmY3q4QJ_rsPBvp92-TTf61jpg", + y: "9M8HWzlAXdHxresJAQftz7K0ljc52HZ54wVssFV9Ct8", + }, + }, + ecdsa_bad: { pub_jwk: { kty: "EC", ===================================== dom/crypto/test/test_WebCrypto_ECDH.html ===================================== @@ -152,12 +152,24 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDH import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-521"}; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -182,7 +194,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-384)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-384"}; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -207,7 +219,7 @@ TestArray.addTest( "JWK import an ECDH public and private key and derive bits (P-521)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-521" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -232,7 +244,7 @@ TestArray.addTest( "JWK import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve : "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } @@ -277,7 +289,7 @@ TestArray.addTest( "PKCS8 import/export roundtrip with ECDH (P-256)", function() { var that = this; - var alg = { name: "ECDH", namedCurve: "P-256" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; function doExportPriv(x) { return crypto.subtle.exportKey("pkcs8", x); @@ -296,7 +308,7 @@ TestArray.addTest( "Test that importing bad JWKs fails", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var tvs = tv.ecdh_p256_negative; function doTryImport(jwk) { @@ -306,6 +318,7 @@ TestArray.addTest( } doTryImport(tvs.jwk_bad_crv)() + .then(error(that), doTryImport(tvs.jwk_different_crv)) .then(error(that), doTryImport(tvs.jwk_missing_crv)) .then(error(that), doTryImport(tvs.jwk_missing_x)) .then(error(that), doTryImport(tvs.jwk_missing_y)) @@ -349,7 +362,7 @@ TestArray.addTest( "Derive an HMAC key from two ECDH keys and test sign/verify", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-521" }; var algDerived = { name: "HMAC", hash: {name: "SHA-1"} }; var pubKey, privKey; @@ -391,6 +404,28 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Derive an HKDF key from two ECDH keys and derive an HMAC key from that", + function() { + var that = this; + var alg = { name: "ECDH", namedCurve: "P-256" }; + + async function doTest() { + let privKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_priv, alg, false, ["deriveKey"]); + let pubKey = await crypto.subtle.importKey("jwk", tv.ecdh_p256.jwk_pub, alg, false, []); + let ecdhAlg = { name: "ECDH", public: pubKey }; + let hkdfAlg = { name: "HKDF", hash: "SHA-256", salt: new Uint8Array(), info: new Uint8Array() }; + let hkdfKey = await crypto.subtle.deriveKey(ecdhAlg, privKey, hkdfAlg, false, ["deriveKey"]); + let hmacAlg = { name: "HMAC", hash: "SHA-256" }; + let hmacKey = await crypto.subtle.deriveKey(hkdfAlg, hkdfKey, hmacAlg, false, ["sign"]); + return crypto.subtle.sign("HMAC", hmacKey, new Uint8Array()); + } + const expected = util.hex2abv("acf62832fa93469824cd997593bc963b28a68e6f73f4516bbe51b35942fe9811"); + doTest().then(memcmp_complete(that, expected), error(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "SPKI import/export of public ECDH keys (P-256)", @@ -433,7 +468,7 @@ TestArray.addTest( "SPKI/JWK import ECDH keys (P-256) and derive a known secret", function() { var that = this; - var alg = { name: "ECDH" }; + var alg = { name: "ECDH", namedCurve: "P-256" }; var pubKey, privKey; function setPub(x) { pubKey = x; } ===================================== dom/crypto/test/test_WebCrypto_ECDSA.html ===================================== @@ -91,7 +91,7 @@ TestArray.addTest( "ECDSA JWK import and reject a known-bad signature", function() { var that = this; - var alg = { name: "ECDSA", namedCurve: "P-256", hash: "SHA-256" }; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; function doVerify(x) { return crypto.subtle.verify(alg, x, tv.ecdsa_verify.sig_tampered, @@ -141,6 +141,18 @@ TestArray.addTest( } ); +// ----------------------------------------------------------------------------- +TestArray.addTest( + "Verify that ECDSA import fails with a key with a mismatched 'crv' field", + function() { + var that = this; + var alg = { name: "ECDSA", namedCurve: "P-521", hash: "SHA-512" }; + + crypto.subtle.importKey("jwk", tv.ecdsa_jwk_crv_mismatch.pub_jwk, alg, true, ["verify"]) + .then(error(that), complete(that)); + } +); + // ----------------------------------------------------------------------------- TestArray.addTest( "Verify that ECDSA import fails with a known-bad public key", View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84c46ae… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84c46ae… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 94077be2 by Morgan at 2024-08-31T10:23:33+08:00 fixup! Firefox preference overrides. Bug 42684: Disable network prefetch - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -459,8 +459,12 @@ pref("privacy.purge_trackers.enabled", false); // credentials dialogs. Hardens against potential credentials phishing. pref("network.auth.subresource-http-auth-allow", 1); +// tor-browser#42684: Disable network prefetch pref("network.dns.disablePrefetch", true); pref("network.dns.disablePrefetchFromHTTPS", true); +pref("dom.prefetch_dns_for_anchor_http_document", false); +pref("dom.prefetch_dns_for_anchor_https_document", false); + pref("network.protocol-handler.external-default", false); pref("network.protocol-handler.external.mailto", false); pref("network.protocol-handler.external.news", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/940… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/940… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e02979b1 by Morgan at 2024-08-31T10:23:24+08:00 fixup! Firefox preference overrides. Bug 42684: Disable network prefetch - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -459,8 +459,12 @@ pref("privacy.purge_trackers.enabled", false); // credentials dialogs. Hardens against potential credentials phishing. pref("network.auth.subresource-http-auth-allow", 1); +// tor-browser#42684: Disable network prefetch pref("network.dns.disablePrefetch", true); pref("network.dns.disablePrefetchFromHTTPS", true); +pref("dom.prefetch_dns_for_anchor_http_document", false); +pref("dom.prefetch_dns_for_anchor_https_document", false); + pref("network.protocol-handler.external-default", false); pref("network.protocol-handler.external.mailto", false); pref("network.protocol-handler.external.news", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e02979b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e02979b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 31 Aug '24

31 Aug '24

ma1 pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 546ec417 by Morgan at 2024-08-29T23:43:47+00:00 fixup! Firefox preference overrides. Bug 42684: Disable network prefetch - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -459,8 +459,12 @@ pref("privacy.purge_trackers.enabled", false); // credentials dialogs. Hardens against potential credentials phishing. pref("network.auth.subresource-http-auth-allow", 1); +// tor-browser#42684: Disable network prefetch pref("network.dns.disablePrefetch", true); pref("network.dns.disablePrefetchFromHTTPS", true); +pref("dom.prefetch_dns_for_anchor_http_document", false); +pref("dom.prefetch_dns_for_anchor_https_document", false); + pref("network.protocol-handler.external-default", false); pref("network.protocol-handler.external.mailto", false); pref("network.protocol-handler.external.news", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/546ec41… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/546ec41… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41188: Upgrade binutils to 2.41
by morgan (＠morgan) 30 Aug '24

30 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 156c6f25 by Morgan at 2024-08-30T20:20:29+00:00 Bug 41188: Upgrade binutils to 2.41 - - - - - 1 changed file: - projects/binutils/config Changes: ===================================== projects/binutils/config ===================================== @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 2.39 +version: 2.41 filename: '[% project %]-[% c("version") %]-[% IF c("var/linux-cross") %]cross-[% c("arch") %]-[% END %][% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41096: set SOURCE_DATE_EPOCH in set_default_env
by morgan (＠morgan) 30 Aug '24

30 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 4957118d by Morgan at 2024-08-29T16:34:04+00:00 Bug 41096: set SOURCE_DATE_EPOCH in set_default_env - - - - - 5 changed files: - projects/linux-packages/build - projects/nsis/README.md - projects/nsis/build - projects/openssl/build - rbm.conf Changes: ===================================== projects/linux-packages/build ===================================== @@ -6,7 +6,6 @@ OUTDIR='[% dest_dir _ "/" _ c("filename") %]' mkdir -p $OUTDIR mkdir -p "$distdir" -export SOURCE_DATE_EPOCH='[% c("timestamp") %]' umask 0022 [% IF c("var/build_deb_pkg") -%] ===================================== projects/nsis/README.md ===================================== @@ -44,19 +44,3 @@ References: in which they mention the `IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE` flag for compatibility. - [tor-browser-build#40900](https://gitlab.torproject.org/tpo/applications/tor… - -## Reproducibility issues - -We have a patch to add `--no-insert-timestamp` to make the binaries -reproducible. - -We could drop our patch and switch to the official way to do it -(`SOURCE_DATE_EPOCH`). - -References: - -- [nsis#294](https://sourceforge.net/p/nsis/patches/294/): the patch for - `SOURCE_DATE_EPOCH` -- [nsis#309](https://sourceforge.net/p/nsis/patches/309/): the attempt to uplift - our patch -- [tor-browser-build#40090](https://gitlab.torproject.org/tpo/applications/tor… ===================================== projects/nsis/build ===================================== @@ -37,7 +37,6 @@ cd "$builddir" sed -i 's/-Wl,--exclude-libs,msvcrt.a/-Wl,-Xlink=-fixed/' SCons/Config/gnu sed -i '2i extern "C"' SCons/Config/{memcpy,memset}.c -export SOURCE_DATE_EPOCH=$(stat -c '%Y' Source) # Resource.dll does not obey the source date epoch... patch -p1 < "$rootdir/resource-reproducible.diff" ===================================== projects/openssl/build ===================================== @@ -19,7 +19,6 @@ export CC='gcc -m32' # from GCC to Clang and vice versa. export CC=cc [% END -%] -export SOURCE_DATE_EPOCH='[% c("timestamp") %]' # OpenSSL 3 uses lib64 on 64-bit systems, but tor looks for lib ./Configure --prefix="$distdir" --libdir=lib [% c('var/configure_opts') %] make -j[% c("num_procs") %] ===================================== rbm.conf ===================================== @@ -204,6 +204,7 @@ var: rootdir=$(pwd) export SHELL=/bin/bash export HOME=$rootdir + export SOURCE_DATE_EPOCH='[% c("timestamp") %]' umask 0022 [% IF c("container/global_disable") -%] rm -Rf /var/tmp/build /var/tmp/dist @@ -214,6 +215,7 @@ var: export ZSTD_NBTHREADS=[% c("num_procs") > 1 ? c("num_procs") : '2' %] [% END -%] + DOCSDIR_project: '[% project %]' set_MOZ_BUILD_DATE: 'export MOZ_BUILD_DATE=[% c("var/MOZ_BUILD_DATE") %]' MOZ_BUILD_DATE: '[% USE date; date.format(c("var/browser_release_date"), "%Y%m%d%H%M%S") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 29 Aug '24

29 Aug '24

morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 72fa55f0 by Morgan at 2024-08-29T19:01:45+00:00 fixup! Firefox preference overrides. Bug 42687: Disable contentRelevancy component - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -290,6 +290,11 @@ pref("browser.preferences.moreFromMozilla", false); pref("extensions.screenshots.disabled", true); pref("extensions.webcompat-reporter.enabled", false); +// Disable contentRelevancy component (which itself is gated on Nimbus) (tor-browser#42867) +pref("toolkit.contentRelevancy.enabled", false; +pref("toolkit.contentRelevancy.ingestEnabled", false); +pref("toolkit.contentRelevancy.log", false); + pref("browser.search.region", "US"); // Disable GeoIP search lookups (#16254) // Disable use of WiFi location information pref("browser.region.network.scan", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/72f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/72f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 29 Aug '24

29 Aug '24

morgan pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 2003c61d by Morgan at 2024-08-29T19:00:31+00:00 fixup! Firefox preference overrides. Bug 42687: Disable contentRelevancy component - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -290,6 +290,11 @@ pref("browser.preferences.moreFromMozilla", false); pref("extensions.screenshots.disabled", true); pref("extensions.webcompat-reporter.enabled", false); +// Disable contentRelevancy component (which itself is gated on Nimbus) (tor-browser#42867) +pref("toolkit.contentRelevancy.enabled", false; +pref("toolkit.contentRelevancy.ingestEnabled", false); +pref("toolkit.contentRelevancy.log", false); + pref("browser.search.region", "US"); // Disable GeoIP search lookups (#16254) // Disable use of WiFi location information pref("browser.region.network.scan", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2003c61… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2003c61… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 29 Aug '24

29 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 1cd99490 by Morgan at 2024-08-29T18:59:28+00:00 fixup! Firefox preference overrides. Bug 42687: Disable contentRelevancy component - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -290,6 +290,11 @@ pref("browser.preferences.moreFromMozilla", false); pref("extensions.screenshots.disabled", true); pref("extensions.webcompat-reporter.enabled", false); +// Disable contentRelevancy component (which itself is gated on Nimbus) (tor-browser#42867) +pref("toolkit.contentRelevancy.enabled", false; +pref("toolkit.contentRelevancy.ingestEnabled", false); +pref("toolkit.contentRelevancy.log", false); + pref("browser.search.region", "US"); // Disable GeoIP search lookups (#16254) // Disable use of WiFi location information pref("browser.region.network.scan", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1cd9949… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1cd9949… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by ma1 (＠ma1) 29 Aug '24

29 Aug '24

ma1 pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 28135e70 by Henry Wilkes at 2024-08-30T00:13:26+08:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 42764: Reduce letterboxing jank from find bar. - - - - - 1 changed file: - toolkit/themes/shared/findbar.css Changes: ===================================== toolkit/themes/shared/findbar.css ===================================== @@ -39,6 +39,14 @@ xul|findbar { transition-duration: 0s; transition-delay: 0s; } + + /* When letterboxing is in use, we do not transition to avoid layout jank. + * This has an additional benefit that the find bar cannot be used to + * fingerprint prefers-reduced-motion. See tor-browser#42764. */ + .letterboxing & { + transition-duration: 0s; + transition-delay: 0s; + } } .findbar-container { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/281… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/281… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by ma1 (＠ma1) 29 Aug '24

29 Aug '24

ma1 pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 35b22106 by Henry Wilkes at 2024-08-30T00:13:00+08:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 42764: Reduce letterboxing jank from find bar. - - - - - 1 changed file: - toolkit/themes/shared/findbar.css Changes: ===================================== toolkit/themes/shared/findbar.css ===================================== @@ -39,6 +39,14 @@ xul|findbar { transition-duration: 0s; transition-delay: 0s; } + + /* When letterboxing is in use, we do not transition to avoid layout jank. + * This has an additional benefit that the find bar cannot be used to + * fingerprint prefers-reduced-motion. See tor-browser#42764. */ + .letterboxing & { + transition-duration: 0s; + transition-delay: 0s; + } } .findbar-container { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/35b2210… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/35b2210… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 32308: Use direct browser sizing for letterboxing.
by ma1 (＠ma1) 29 Aug '24

29 Aug '24

ma1 pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 8449d263 by Henry Wilkes at 2024-08-29T16:59:09+01:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 42764: Reduce letterboxing jank from find bar. - - - - - 1 changed file: - toolkit/themes/shared/findbar.css Changes: ===================================== toolkit/themes/shared/findbar.css ===================================== @@ -39,6 +39,14 @@ xul|findbar { transition-duration: 0s; transition-delay: 0s; } + + /* When letterboxing is in use, we do not transition to avoid layout jank. + * This has an additional benefit that the find bar cannot be used to + * fingerprint prefers-reduced-motion. See tor-browser#42764. */ + .letterboxing & { + transition-duration: 0s; + transition-delay: 0s; + } } .findbar-container { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8449d26… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8449d26… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-2] 2 commits: fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser Commits: 757b1f4d by Pier Angelo Vendrame at 2024-08-28T08:45:55+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 42747: Discard unsupported updates earlier. Firefox's updater has a function to select updates, which checks mainly the version number. Therefore, a more recent update that is unsupported will be chosen over a compatible one. We patch this to be able to provide an alternative update path to Windows 7. - - - - - 2f730245 by Pier Angelo Vendrame at 2024-08-28T08:45:55+02:00 fixup! Bug 19121: reinstate the update.xml hash check Revert "Bug 19121: reinstate the update.xml hash check" This reverts commit 39a712fbaf18cb64b6dc601c71bac82718de1a01. - - - - - 3 changed files: - toolkit/mozapps/update/UpdateService.sys.mjs - toolkit/mozapps/update/UpdateTelemetry.sys.mjs - toolkit/mozapps/update/nsIUpdateService.idl Changes: ===================================== toolkit/mozapps/update/UpdateService.sys.mjs ===================================== @@ -2127,8 +2127,6 @@ function UpdatePatch(patch) { } break; case "finalURL": - case "hashFunction": - case "hashValue": case "state": case "type": case "URL": @@ -2148,8 +2146,6 @@ UpdatePatch.prototype = { // over writing nsIUpdatePatch attributes. _attrNames: [ "errorCode", - "hashFunction", - "hashValue", "finalURL", "selected", "size", @@ -2163,8 +2159,6 @@ UpdatePatch.prototype = { */ serialize: function UpdatePatch_serialize(updates) { var patch = updates.createElementNS(URI_UPDATE_NS, "patch"); - patch.setAttribute("hashFunction", this.hashFunction); - patch.setAttribute("hashValue", this.hashValue); patch.setAttribute("size", this.size); patch.setAttribute("type", this.type); patch.setAttribute("URL", this.URL); @@ -3737,18 +3731,20 @@ UpdateService.prototype = { switch (aUpdate.type) { case "major": - if (!majorUpdate) { + if (!majorUpdate || majorUpdate.unsupported) { majorUpdate = aUpdate; } else if ( + !aUpdate.unsupported && vc.compare(majorUpdate.appVersion, aUpdate.appVersion) <= 0 ) { majorUpdate = aUpdate; } break; case "minor": - if (!minorUpdate) { + if (!minorUpdate || minorUpdate.unsupported) { minorUpdate = aUpdate; } else if ( + !aUpdate.unsupported && vc.compare(minorUpdate.appVersion, aUpdate.appVersion) <= 0 ) { minorUpdate = aUpdate; @@ -5792,56 +5788,7 @@ Downloader.prototype = { } LOG("Downloader:_verifyDownload downloaded size == expected size."); - let fileStream = Cc[ - "@mozilla.org/network/file-input-stream;1" - ].createInstance(Ci.nsIFileInputStream); - fileStream.init( - destination, - FileUtils.MODE_RDONLY, - FileUtils.PERMS_FILE, - 0 - ); - - let digest; - try { - let hash = Cc["@mozilla.org/security/hash;1"].createInstance( - Ci.nsICryptoHash - ); - var hashFunction = - Ci.nsICryptoHash[this._patch.hashFunction.toUpperCase()]; - if (hashFunction == undefined) { - throw Components.Exception("", Cr.NS_ERROR_UNEXPECTED); - } - hash.init(hashFunction); - hash.updateFromStream(fileStream, -1); - // NOTE: For now, we assume that the format of _patch.hashValue is hex - // encoded binary (such as what is typically output by programs like - // sha1sum). In the future, this may change to base64 depending on how - // we choose to compute these hashes. - hash = hash.finish(false); - digest = Array.from(hash, (c, i) => - hash.charCodeAt(i).toString(16).padStart(2, "0") - ).join(""); - } catch (e) { - LOG( - "Downloader:_verifyDownload - failed to compute hash of the downloaded update archive" - ); - digest = ""; - } - - fileStream.close(); - - if (digest == this._patch.hashValue.toLowerCase()) { - LOG("Downloader:_verifyDownload hashes match."); - return true; - } - - LOG("Downloader:_verifyDownload hashes do not match. "); - AUSTLMY.pingDownloadCode( - this.isCompleteUpdate, - AUSTLMY.DWNLD_ERR_VERIFY_NO_HASH_MATCH - ); - return false; + return true; }, /** @@ -6477,9 +6424,6 @@ Downloader.prototype = { " is higher than patch size: " + this._patch.size ); - // It's important that we use a different code than - // NS_ERROR_CORRUPTED_CONTENT so that tests can verify the difference - // between a hash error and a wrong download error. AUSTLMY.pingDownloadCode( this.isCompleteUpdate, AUSTLMY.DWNLD_ERR_PATCH_SIZE_LARGER @@ -6498,9 +6442,6 @@ Downloader.prototype = { " is not equal to expected patch size: " + this._patch.size ); - // It's important that we use a different code than - // NS_ERROR_CORRUPTED_CONTENT so that tests can verify the difference - // between a hash error and a wrong download error. AUSTLMY.pingDownloadCode( this.isCompleteUpdate, AUSTLMY.DWNLD_ERR_PATCH_SIZE_NOT_EQUAL ===================================== toolkit/mozapps/update/UpdateTelemetry.sys.mjs ===================================== @@ -190,7 +190,6 @@ export var AUSTLMY = { DWNLD_ERR_VERIFY_NO_REQUEST: 13, DWNLD_ERR_VERIFY_PATCH_SIZE_NOT_EQUAL: 14, DWNLD_ERR_WRITE_FAILURE: 15, - DWNLD_ERR_VERIFY_NO_HASH_MATCH: 16, // Temporary failure code to see if there are failures without an update phase DWNLD_UNKNOWN_PHASE_ERR_WRITE_FAILURE: 40, ===================================== toolkit/mozapps/update/nsIUpdateService.idl ===================================== @@ -39,17 +39,6 @@ interface nsIUpdatePatch : nsISupports */ attribute AString finalURL; - /** - * The hash function to use when determining this file's integrity - */ - attribute AString hashFunction; - - /** - * The value of the hash function named above that should be computed if - * this file is not corrupt. - */ - attribute AString hashValue; - /** * The size of this file, in bytes. */ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6935ca… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6935ca… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 41568: Disable LaterRun
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: e4de0ac8 by Henry Wilkes at 2024-08-29T16:42:57+02:00 fixup! Bug 41568: Disable LaterRun Bug 42630: Revert patch. - - - - - ae50f625 by Henry Wilkes at 2024-08-29T16:42:58+02:00 Bug 42630: Disable LaterRun module. - - - - - 2 changed files: - browser/components/BrowserContentHandler.sys.mjs - browser/modules/LaterRun.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -774,8 +774,8 @@ nsBrowserContentHandler.prototype = { additionalPage = Services.urlFormatter.formatURLPref( "startup.homepage_welcome_url.additional" ); - // Disable 'later run' pages for new profiles (tor-browser#41568) - lazy.LaterRun.selfDestruct(); + // Turn on 'later run' pages for new profiles. + lazy.LaterRun.enable(lazy.LaterRun.ENABLE_REASON_NEW_PROFILE); break; case OVERRIDE_NEW_MSTONE: { // Check whether we will restore a session. If we will, we assume ===================================== browser/modules/LaterRun.sys.mjs ===================================== @@ -61,6 +61,20 @@ export let LaterRun = { }, init(reason) { + // Keep disabled in Base Browser. See tor-browser#41568. + // NOTE: This means that users cannot benefit from feature prompts gated + // behind LaterRun. + // In mozilla ESR 128 it is only used in one place, and is gated behind a + // feature recommendation preference that we switch off in Base Browser + // anyway. See tor-browser#42630. + // But this decision should be reviewed. See tor-browser#43093. + Services.prefs.setBoolPref(kEnabledPref, false); + // Clear any preferences that may have been set before LaterRun was + // disabled. + Services.prefs.clearUserPref(kSessionCountPref); + Services.prefs.clearUserPref(kProfileCreationTime); + Services.prefs.clearUserPref(kUpdateAppliedTime); + if (!this.enabled) { return; } @@ -99,11 +113,8 @@ export let LaterRun = { return Services.prefs.getBoolPref(kEnabledPref, false); }, - enable(reason) { - if (!this.enabled) { - Services.prefs.setBoolPref(kEnabledPref, true); - this.init(reason); - } + enable(_reason) { + // Keep disabled in Base Browser. See tor-browser#41568. }, get hoursSinceInstall() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/07… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/07… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 41568: Disable LaterRun
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 44820468 by Henry Wilkes at 2024-08-29T16:42:37+02:00 fixup! Bug 41568: Disable LaterRun Bug 42630: Revert patch. - - - - - d44ef5f7 by Henry Wilkes at 2024-08-29T16:42:41+02:00 Bug 42630: Disable LaterRun module. - - - - - 2 changed files: - browser/components/BrowserContentHandler.sys.mjs - browser/modules/LaterRun.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -757,8 +757,8 @@ nsBrowserContentHandler.prototype = { additionalPage = Services.urlFormatter.formatURLPref( "startup.homepage_welcome_url.additional" ); - // Disable 'later run' pages for new profiles (tor-browser#41568) - lazy.LaterRun.selfDestruct(); + // Turn on 'later run' pages for new profiles. + lazy.LaterRun.enable(lazy.LaterRun.ENABLE_REASON_NEW_PROFILE); break; case OVERRIDE_NEW_MSTONE: { // Check whether we will restore a session. If we will, we assume ===================================== browser/modules/LaterRun.sys.mjs ===================================== @@ -61,6 +61,20 @@ export let LaterRun = { }, init(reason) { + // Keep disabled in Base Browser. See tor-browser#41568. + // NOTE: This means that users cannot benefit from feature prompts gated + // behind LaterRun. + // In mozilla ESR 128 it is only used in one place, and is gated behind a + // feature recommendation preference that we switch off in Base Browser + // anyway. See tor-browser#42630. + // But this decision should be reviewed. See tor-browser#43093. + Services.prefs.setBoolPref(kEnabledPref, false); + // Clear any preferences that may have been set before LaterRun was + // disabled. + Services.prefs.clearUserPref(kSessionCountPref); + Services.prefs.clearUserPref(kProfileCreationTime); + Services.prefs.clearUserPref(kUpdateAppliedTime); + if (!this.enabled) { return; } @@ -99,11 +113,8 @@ export let LaterRun = { return Services.prefs.getBoolPref(kEnabledPref, false); }, - enable(reason) { - if (!this.enabled) { - Services.prefs.setBoolPref(kEnabledPref, true); - this.init(reason); - } + enable(_reason) { + // Keep disabled in Base Browser. See tor-browser#41568. }, get hoursSinceInstall() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fe2c1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fe2c1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 41568: Disable LaterRun
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e85915bc by Henry Wilkes at 2024-08-29T15:11:30+01:00 fixup! Bug 41568: Disable LaterRun Bug 42630: Revert patch. - - - - - 8a110fc4 by Henry Wilkes at 2024-08-29T15:12:01+01:00 Bug 42630: Disable LaterRun module. - - - - - 2 changed files: - browser/components/BrowserContentHandler.sys.mjs - browser/modules/LaterRun.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -774,8 +774,8 @@ nsBrowserContentHandler.prototype = { additionalPage = Services.urlFormatter.formatURLPref( "startup.homepage_welcome_url.additional" ); - // Disable 'later run' pages for new profiles (tor-browser#41568) - lazy.LaterRun.selfDestruct(); + // Turn on 'later run' pages for new profiles. + lazy.LaterRun.enable(lazy.LaterRun.ENABLE_REASON_NEW_PROFILE); break; case OVERRIDE_NEW_MSTONE: { // Check whether we will restore a session. If we will, we assume ===================================== browser/modules/LaterRun.sys.mjs ===================================== @@ -61,6 +61,20 @@ export let LaterRun = { }, init(reason) { + // Keep disabled in Base Browser. See tor-browser#41568. + // NOTE: This means that users cannot benefit from feature prompts gated + // behind LaterRun. + // In mozilla ESR 128 it is only used in one place, and is gated behind a + // feature recommendation preference that we switch off in Base Browser + // anyway. See tor-browser#42630. + // But this decision should be reviewed. See tor-browser#43093. + Services.prefs.setBoolPref(kEnabledPref, false); + // Clear any preferences that may have been set before LaterRun was + // disabled. + Services.prefs.clearUserPref(kSessionCountPref); + Services.prefs.clearUserPref(kProfileCreationTime); + Services.prefs.clearUserPref(kUpdateAppliedTime); + if (!this.enabled) { return; } @@ -99,11 +113,8 @@ export let LaterRun = { return Services.prefs.getBoolPref(kEnabledPref, false); }, - enable(reason) { - if (!this.enabled) { - Services.prefs.setBoolPref(kEnabledPref, true); - this.init(reason); - } + enable(_reason) { + // Keep disabled in Base Browser. See tor-browser#41568. }, get hoursSinceInstall() { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/df4211… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/df4211… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 23247: Communicating security expectations for .onion
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: df421101 by Pier Angelo Vendrame at 2024-08-29T10:15:34+02:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 42743: Check for .onion in the actual document URI in pageInfo. One of our patches checks whether we are in a .onion domain when showing the security information in pageInfo.xhtml. However, it checks it in the requested URI rather than doing it on the actually loaded URI, therefore about:neterror is shown as a secure Onion service, which is not consistent with failures in loading clearnet domains with HTTPS. - - - - - 1 changed file: - browser/base/content/pageinfo/security.js Changes: ===================================== browser/base/content/pageinfo/security.js ===================================== @@ -53,16 +53,15 @@ var security = { (Ci.nsIWebProgressListener.STATE_LOADED_MIXED_ACTIVE_CONTENT | Ci.nsIWebProgressListener.STATE_LOADED_MIXED_DISPLAY_CONTENT); var isEV = ui.state & Ci.nsIWebProgressListener.STATE_IDENTITY_EV_TOPLEVEL; - var isOnion = false; - let hostName; - try { - hostName = Services.eTLD.getBaseDomain(this.uri); - } catch (e) { - hostName = this.windowInfo.hostName; - } - if (hostName && hostName.endsWith(".onion")) { - isOnion = true; + let uriInformation = new URL(gDocInfo.documentURIObject.spec); + // If the Onion site could not be loaded, the view-source will be also be + // about:neterror. + if (uriInformation.protocol == "view-source:") { + uriInformation = new URL(uriInformation.pathname); } + const isOnion = + ["http:", "https:"].includes(uriInformation.protocol) && + uriInformation.hostname.endsWith(".onion"); let retval = { cAName: "", View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/df42110… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/df42110… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-115.15.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed new tag mullvad-browser-115.15.0esr-13.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.15.0esr-13.5-1] 21 commits: MB 38: Mullvad Browser configuration
by Pier Angelo Vendrame (＠pierov) 29 Aug '24

29 Aug '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 37ef7afb by Pier Angelo Vendrame at 2024-08-28T21:58:03+00:00 MB 38: Mullvad Browser configuration - - - - - f8849e43 by Pier Angelo Vendrame at 2024-08-28T21:58:03+00:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - e86c3f1c by Pier Angelo Vendrame at 2024-08-28T21:58:04+00:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - 6aa1d7de by Pier Angelo Vendrame at 2024-08-28T21:58:04+00:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - 6daa7620 by Pier Angelo Vendrame at 2024-08-28T21:58:04+00:00 MB 37: Customization for the about dialog - - - - - c94bdf41 by Henry Wilkes at 2024-08-28T21:58:04+00:00 MB 39: Add home page about:mullvad-browser - - - - - f1ef654b by hackademix at 2024-08-28T21:58:05+00:00 MB 97: Remove UI cues to install new extensions. - - - - - 4cee4b7a by hackademix at 2024-08-28T21:58:05+00:00 MB 47: uBlock Origin customization - - - - - 688160a2 by Pier Angelo Vendrame at 2024-08-28T21:58:05+00:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - 82aafb40 by Pier Angelo Vendrame at 2024-08-28T21:58:05+00:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - 265de51e by Nicolas Vigier at 2024-08-28T21:58:06+00:00 MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - 305b0424 by Pier Angelo Vendrame at 2024-08-28T21:58:06+00:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - 121a0543 by Pier Angelo Vendrame at 2024-08-28T21:58:06+00:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - 4a2169d9 by hackademix at 2024-08-28T21:58:06+00:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - a234562b by Richard Pospesel at 2024-08-28T21:58:07+00:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - 2fcce7dc by rui hildt at 2024-08-28T21:58:07+00:00 MB 213: Customize the search engines list - - - - - 8605e695 by hackademix at 2024-08-28T21:58:07+00:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - 0de3a189 by Pier Angelo Vendrame at 2024-08-28T21:58:07+00:00 MB 234: Disable OS spoofing in HTTP User-Agent. This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - 71a58d71 by Pier Angelo Vendrame at 2024-08-28T21:58:08+00:00 MB 80: Enable Mullvad Browser as a default browser - - - - - 07d6ff62 by Dan Ballard at 2024-08-28T21:58:08+00:00 MB 290: Add default bookmarks in alpha channel for testing - - - - - 7c46ec5a by june wilde at 2024-08-28T21:58:08+00:00 MB 305: Disable setting default browser on Windows Until we can pull in upstream changes to fix breakage in setting the Mullvad Browser as default in Windows 10/11 we're disabling the ability to do so via about:preferences as well as via the startup query dialog - - - - - 30 changed files: - .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png - + browser/branding/mb-alpha/content/aboutDialog.css The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/69… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/69… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Disable features and functionality
by morgan (＠morgan) 29 Aug '24

29 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 47a49a9d by Morgan at 2024-08-29T00:25:07+00:00 fixup! [android] Disable features and functionality Bug 43094: Remove 'Open in regular tab' button - - - - - 1 changed file: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt ===================================== @@ -265,12 +265,12 @@ open class DefaultToolbarMenu( onItemTapped.invoke(ToolbarMenu.Item.RequestDesktop(checked)) } - private val openInRegularTabItem = BrowserMenuImageText( - label = context.getString(R.string.browser_menu_open_in_regular_tab), - imageResource = R.drawable.ic_open_in_regular_tab, - ) { - onItemTapped.invoke(ToolbarMenu.Item.OpenInRegularTab) - } +// private val openInRegularTabItem = BrowserMenuImageText( +// label = context.getString(R.string.browser_menu_open_in_regular_tab), +// imageResource = R.drawable.ic_open_in_regular_tab, +// ) { +// onItemTapped.invoke(ToolbarMenu.Item.OpenInRegularTab) +// } private val customizeReaderView = BrowserMenuImageText( label = context.getString(R.string.browser_menu_customize_reader_view), @@ -419,7 +419,7 @@ open class DefaultToolbarMenu( findInPageItem, translationsItem.apply { visible = ::shouldShowTranslations }, desktopSiteItem, - openInRegularTabItem.apply { visible = ::shouldShowOpenInRegularTab }, + // openInRegularTabItem.apply { visible = ::shouldShowOpenInRegularTab }, customizeReaderView.apply { visible = ::shouldShowReaderViewCustomization }, // openInApp.apply { visible = ::sho uldShowOpenInApp }, // reportSiteIssuePlaceholder, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47a49a9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47a49a9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-115.14.0esr-13.5-1-build1
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed new tag base-browser-115.14.0esr-13.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Bug 41180: Avoid some copies for the expert bundles.
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 5a9ee2bd by Pier Angelo Vendrame at 2024-08-27T18:34:40+02:00 Bug 41180: Avoid some copies for the expert bundles. AndroidManifest.xml should be copied only in tor-expert-bundle when doing Android builds. The compiler is not needed in tor-expert-bundle-aar. - - - - - d994819d by Pier Angelo Vendrame at 2024-08-28T16:41:52+02:00 Bug 41224: Do not ship Conjure and GeoIP databases on some Android configurations. - - - - - 3 changed files: - projects/tor-expert-bundle-aar/config - projects/tor-expert-bundle/build - projects/tor-expert-bundle/config Changes: ===================================== projects/tor-expert-bundle-aar/config ===================================== @@ -8,8 +8,6 @@ var: input_files: - project: container-image - - name: '[% c("var/compiler") %]' - project: '[% c("var/compiler") %]' - project: tor-expert-bundle name: tor-expert-bundle-armv7 target_replace: @@ -25,4 +23,4 @@ input_files: - project: tor-expert-bundle name: tor-expert-bundle-x86_64 target_replace: - '^torbrowser-(?!testbuild).*': 'torbrowser-android-x86_64' \ No newline at end of file + '^torbrowser-(?!testbuild).*': 'torbrowser-android-x86_64' ===================================== projects/tor-expert-bundle/build ===================================== @@ -15,7 +15,9 @@ mkdir pluggable_transports && cd pluggable_transports tar -xkf $rootdir/[% c('input_files_by_name/lyrebird') %] tar -xkf $rootdir/[% c('input_files_by_name/snowflake') %] -tar -xkf $rootdir/[% c('input_files_by_name/conjure') %] +[% IF c('input_files_by_name/conjure') -%] + tar -xkf $rootdir/[% c('input_files_by_name/conjure') %] +[% END -%] # add per-platform pt extension awk '{gsub(/\$\{pt_extension\}/, "[% c("var/pt_extension") %]"); print}' $rootdir/pt_config.json > pt_config.json @@ -33,11 +35,15 @@ cd $distdir mkdir -p aar/assets/common cp -a tor/libTor.so aar/jni/$abi/ - cp -a tor/pluggable_transports/conjure-client aar/jni/$abi/libConjure.so cp -a tor/pluggable_transports/lyrebird aar/jni/$abi/libObfs4proxy.so cp -a tor/pluggable_transports/snowflake-client aar/jni/$abi/libSnowflake.so + [% IF c('input_files_by_name/conjure') -%] + cp -a tor/pluggable_transports/conjure-client aar/jni/$abi/libConjure.so + [% END -%] - cp -a data/* aar/assets/common/ + # tor-browser-build#41224, tor-browser#42607: Currently we do not use the + # GeoIP databases. So, we avoid copying them to save space on the final APK. + # cp -a data/* aar/assets/common/ cp -a tor/pluggable_transports/pt_config.json aar/assets/common/ @@ -57,4 +63,4 @@ cd $distdir tar_src => tar_src, tar_args => '-czvf' _ dest_dir _ '/' _ c('filename') _ '/tor-expert-bundle.tar.gz', }); -%] \ No newline at end of file +%] ===================================== projects/tor-expert-bundle/config ===================================== @@ -20,5 +20,7 @@ input_files: project: snowflake - name: conjure project: conjure + enable: '[% !c("var/android-x86") && !c("var/android-x86_64") %]' - filename: pt_config.json - filename: AndroidManifest.xml + enable: '[% c("var/android") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 42247: Android helpers for the TorProvider
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 431ff1b6 by Pier Angelo Vendrame at 2024-08-28T20:33:14+00:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42607: Stop shipping GeoIP databases for now. - - - - - 1 changed file: - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorIntegrationAndroid.java Changes: ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorIntegrationAndroid.java ===================================== @@ -289,13 +289,16 @@ public class TorIntegrationAndroid implements BundleEventListener { Log.w(TAG, "torrc-default cannot be created, pluggable transports will not be available", e); copied = false; } - try { + // tor-browser#42607: For now we do not ship geoip databases, as we + // do not have the circuit display functionality and they allow us + // to save some space in the final APK. + /*try { copyAndUseConfigFile("GeoIPFile", "geoip", args); copyAndUseConfigFile("GeoIPv6File", "geoip6", args); } catch (IOException e) { Log.w(TAG, "GeoIP files cannot be created, this feature will not be available.", e); copied = false; - } + }*/ mCopiedConfigFiles = copied; Log.d(TAG, "Starting tor with the follwing args: " + args.toString()); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/431ff1b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/431ff1b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] Bug 41736: Customize toolbar for mullvad-browser.
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 07162010 by Henry Wilkes at 2024-08-28T20:30:43+00:00 Bug 41736: Customize toolbar for mullvad-browser. - - - - - 1 changed file: - browser/components/customizableui/CustomizableUI.sys.mjs Changes: ===================================== browser/components/customizableui/CustomizableUI.sys.mjs ===================================== @@ -65,6 +65,11 @@ var kVersion = 20; var kVersionBaseBrowser = 2; const NoScriptId = "_73a6fe31-595d-460b-a920-fcc0f8843232_-browser-action"; +/** + * The current version for mullvad browser. + */ +var kVersionMullvadBrowser = 1; + /** * Buttons removed from built-ins by version they were removed. kVersion must be * bumped any time a new id is added to this. Use the button id as key, and @@ -228,6 +233,7 @@ var CustomizableUIInternal = { this._updateForNewProtonVersion(); this._markObsoleteBuiltinButtonsSeen(); this._updateForBaseBrowser(); + this._updateForMullvadBrowser(); this.registerArea( CustomizableUI.AREA_FIXED_OVERFLOW_PANEL, @@ -264,7 +270,11 @@ var CustomizableUIInternal = { // Base-browser additions tor-browser#41736. If you want to add to, remove // from, or rearrange this list, then bump the kVersionBaseBrowser and // update existing saved states in _updateForBaseBrowser. - "security-level-button", + // Or if the change is only meant for mullvad-browser, bump + // kVersionMullvadBrowser instead and update the existing saved states in + // _updateForMullvadBrowser. + // Do not show the security-level-button by default in Mullvad Browser. + // See mullvad-browser#329 "new-identity-button", "downloads-button", AppConstants.MOZ_DEV_EDITION ? "developer-button" : null, @@ -930,6 +940,44 @@ var CustomizableUIInternal = { } }, + _updateForMullvadBrowser() { + if (!gSavedState) { + // Use the defaults. + return; + } + + const currentVersion = gSavedState.currentVersionMullvadBrowser; + + if (currentVersion < 1) { + // Remove security-level-button if: + // + it hasn't been moved out of the navbar by the user, and + // + the user does not have a custom security level. + // + // NOTE: _updateForBaseBrowser adds this button when + // currentVersionBaseBrowser < 1. This should only happen when + // currentVersionMullvadBrowser < 1, and this method runs after, so should + // reverse it. + const navbarPlacements = + gSavedState.placements[CustomizableUI.AREA_NAVBAR]; + if (navbarPlacements) { + const buttonIndex = navbarPlacements.indexOf("security-level-button"); + // Test if security level icon exists in the navbar. + // Even though a user may have moved the button within the navbar, + // there is no simple way to know whether the button was moved, or if + // other components were moved around it. + if (buttonIndex >= 0) { + // NOTE: We expect the SecurityLevel module to already be initialized. + const { SecurityLevelPrefs } = ChromeUtils.importESModule( + "resource://gre/modules/SecurityLevel.sys.mjs" + ); + if (!SecurityLevelPrefs.securityCustom) { + navbarPlacements.splice(buttonIndex, 1); + } + } + } + } + }, + _placeNewDefaultWidgetsInArea(aArea) { let futurePlacedWidgets = gFuturePlacements.get(aArea); let savedPlacements = @@ -2773,6 +2821,10 @@ var CustomizableUIInternal = { gSavedState.currentVersionBaseBrowser = 0; } + if (!("currentVersionMullvadBrowser" in gSavedState)) { + gSavedState.currentVersionMullvadBrowser = 0; + } + gSeenWidgets = new Set(gSavedState.seen || []); gDirtyAreaCache = new Set(gSavedState.dirtyAreaCache || []); gNewElementCount = gSavedState.newElementCount || 0; @@ -2856,6 +2908,7 @@ var CustomizableUIInternal = { dirtyAreaCache: gDirtyAreaCache, currentVersion: kVersion, currentVersionBaseBrowser: kVersionBaseBrowser, + currentVersionMullvadBrowser: kVersionMullvadBrowser, newElementCount: gNewElementCount, }; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/071… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/071… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ba8dff6e by Henry Wilkes at 2024-08-28T20:09:34+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42803: Force focus ring to show for built-in bridge radio options. - - - - - 1 changed file: - browser/components/torpreferences/content/builtinBridgeDialog.js Changes: ===================================== browser/components/torpreferences/content/builtinBridgeDialog.js ===================================== @@ -114,6 +114,16 @@ const gBuiltinBridgeDialog = { }, }; +// Initial focus is not visible, even if opened with a keyboard. We avoid the +// default handler and manage the focus ourselves, which will paint the focus +// ring by default. +// NOTE: A side effect is that the focus ring will show even if the user opened +// with a mouse event. +// TODO: Remove this once bugzilla bug 1708261 is resolved. +document.subDialogSetDefaultFocus = () => { + document.getElementById("torPreferences-builtinBridge-typeSelection").focus(); +}; + window.addEventListener( "DOMContentLoaded", () => { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ba8dff6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ba8dff6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 5a5a977a by Pier Angelo Vendrame at 2024-08-28T19:54:12+00:00 fixup! Firefox preference overrides. Bug 42685: Re-enable textmetrics. They do not add entropy (see the issue), so re-enable them for compatibility. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -419,11 +419,6 @@ pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); -// Disable API for measuring text width and height. -pref("dom.textMetrics.actualBoundingBox.enabled", false); -pref("dom.textMetrics.baselines.enabled", false); -pref("dom.textMetrics.emHeight.enabled", false); -pref("dom.textMetrics.fontBoundingBox.enabled", false); // tor-browser#40424 pref("pdfjs.enableScripting", false); // Bug 40057: Ensure system colors are not used for CSS4 colors View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/5a5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/5a5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 8fe2c105 by Pier Angelo Vendrame at 2024-08-28T19:52:42+00:00 fixup! Firefox preference overrides. Bug 42685: Re-enable textmetrics. They do not add entropy (see the issue), so re-enable them for compatibility. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -419,11 +419,6 @@ pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); -// Disable API for measuring text width and height. -pref("dom.textMetrics.actualBoundingBox.enabled", false); -pref("dom.textMetrics.baselines.enabled", false); -pref("dom.textMetrics.emHeight.enabled", false); -pref("dom.textMetrics.fontBoundingBox.enabled", false); // tor-browser#40424 pref("pdfjs.enableScripting", false); // Bug 40057: Ensure system colors are not used for CSS4 colors View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8fe2c10… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8fe2c10… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 80c99d24 by Pier Angelo Vendrame at 2024-08-28T18:22:45+02:00 fixup! Firefox preference overrides. Bug 42685: Re-enable textmetrics. They do not add entropy (see the issue), so re-enable them for compatibility. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -419,11 +419,6 @@ pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim pref("media.videocontrols.picture-in-picture.enabled", false); // Bug 40148: disable until audited in #40147 // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); -// Disable API for measuring text width and height. -pref("dom.textMetrics.actualBoundingBox.enabled", false); -pref("dom.textMetrics.baselines.enabled", false); -pref("dom.textMetrics.emHeight.enabled", false); -pref("dom.textMetrics.fontBoundingBox.enabled", false); // tor-browser#40424 pref("pdfjs.enableScripting", false); // Bug 40057: Ensure system colors are not used for CSS4 colors View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/80c99d2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/80c99d2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser-update-responses][main] alpha: new version, 14.0a3
by morgan (＠morgan) 28 Aug '24

28 Aug '24

morgan pushed to branch main at The Tor Project / Applications / mullvad-browser-update-responses Commits: 97b2f35d by Morgan at 2024-08-28T18:12:13+00:00 alpha: new version, 14.0a3 - - - - - 29 changed files: - update_1/alpha/.htaccess - − update_1/alpha/13.5a8-14.0a2-linux-x86_64-ALL.xml - − update_1/alpha/13.5a8-14.0a2-macos-ALL.xml - − update_1/alpha/13.5a8-14.0a2-windows-x86_64-ALL.xml - − update_1/alpha/13.5a9-14.0a2-linux-x86_64-ALL.xml - − update_1/alpha/13.5a9-14.0a2-macos-ALL.xml - − update_1/alpha/13.5a9-14.0a2-windows-x86_64-ALL.xml - + update_1/alpha/13.5a9-14.0a3-linux-x86_64-ALL.xml - + update_1/alpha/13.5a9-14.0a3-macos-ALL.xml - + update_1/alpha/13.5a9-14.0a3-windows-x86_64-ALL.xml - − update_1/alpha/14.0a1-14.0a2-linux-x86_64-ALL.xml - − update_1/alpha/14.0a1-14.0a2-macos-ALL.xml - − update_1/alpha/14.0a1-14.0a2-windows-x86_64-ALL.xml - + update_1/alpha/14.0a1-14.0a3-linux-x86_64-ALL.xml - + update_1/alpha/14.0a1-14.0a3-macos-ALL.xml - + update_1/alpha/14.0a1-14.0a3-windows-x86_64-ALL.xml - + update_1/alpha/14.0a2-14.0a3-linux-x86_64-ALL.xml - + update_1/alpha/14.0a2-14.0a3-macos-ALL.xml - + update_1/alpha/14.0a2-14.0a3-windows-x86_64-ALL.xml - − update_1/alpha/14.0a2-linux-x86_64-ALL.xml - − update_1/alpha/14.0a2-macos-ALL.xml - − update_1/alpha/14.0a2-windows-x86_64-ALL.xml - + update_1/alpha/14.0a3-linux-x86_64-ALL.xml - + update_1/alpha/14.0a3-macos-ALL.xml - + update_1/alpha/14.0a3-windows-x86_64-ALL.xml - update_1/alpha/download-linux-x86_64.json - update_1/alpha/download-macos.json - update_1/alpha/download-windows-x86_64.json - update_1/alpha/downloads.json Changes: ===================================== update_1/alpha/.htaccess ===================================== @@ -1,22 +1,22 @@ RewriteEngine On -RewriteRule ^[^/]+/14.0a2/ no-update.xml [last] -RewriteRule ^Linux_x86_64-gcc3/13.5a8/ALL 13.5a8-14.0a2-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/13.5a9/ALL 13.5a9-14.0a2-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/14.0a1/ALL 14.0a1-14.0a2-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/[^/]+/ALL 14.0a2-linux-x86_64-ALL.xml [last] -RewriteRule ^Linux_x86_64-gcc3/ 14.0a2-linux-x86_64-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/13.5a8/ALL 13.5a8-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/13.5a9/ALL 13.5a9-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/14.0a1/ALL 14.0a1-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/[^/]+/ALL 14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_x86_64-gcc3/ 14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/13.5a8/ALL 13.5a8-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/13.5a9/ALL 13.5a9-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/14.0a1/ALL 14.0a1-14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/[^/]+/ALL 14.0a2-macos-ALL.xml [last] -RewriteRule ^Darwin_aarch64-gcc3/ 14.0a2-macos-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/13.5a8/ALL 13.5a8-14.0a2-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/13.5a9/ALL 13.5a9-14.0a2-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/14.0a1/ALL 14.0a1-14.0a2-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/[^/]+/ALL 14.0a2-windows-x86_64-ALL.xml [last] -RewriteRule ^WINNT_x86_64-gcc3-x64/ 14.0a2-windows-x86_64-ALL.xml [last] +RewriteRule ^[^/]+/14.0a3/ no-update.xml [last] +RewriteRule ^Linux_x86_64-gcc3/13.5a9/ALL 13.5a9-14.0a3-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/14.0a1/ALL 14.0a1-14.0a3-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/14.0a2/ALL 14.0a2-14.0a3-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/[^/]+/ALL 14.0a3-linux-x86_64-ALL.xml [last] +RewriteRule ^Linux_x86_64-gcc3/ 14.0a3-linux-x86_64-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/13.5a9/ALL 13.5a9-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/14.0a1/ALL 14.0a1-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/14.0a2/ALL 14.0a2-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/[^/]+/ALL 14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_x86_64-gcc3/ 14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/13.5a9/ALL 13.5a9-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/14.0a1/ALL 14.0a1-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/14.0a2/ALL 14.0a2-14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/[^/]+/ALL 14.0a3-macos-ALL.xml [last] +RewriteRule ^Darwin_aarch64-gcc3/ 14.0a3-macos-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/13.5a9/ALL 13.5a9-14.0a3-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/14.0a1/ALL 14.0a1-14.0a3-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/14.0a2/ALL 14.0a2-14.0a3-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/[^/]+/ALL 14.0a3-windows-x86_64-ALL.xml [last] +RewriteRule ^WINNT_x86_64-gcc3-x64/ 14.0a3-windows-x86_64-ALL.xml [last] ===================================== update_1/alpha/13.5a8-14.0a2-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2_…" hashFunction="SHA512" hashValue="191da335ea25d8e1d84c394c078fb481b4a74780ed77271fa3d5046558cef78c01079236595713fdb72c4f4f20de3c05fcc9114cea95ccca1d4b1c4ad7750b05" size="113891553" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64--13.5a8…" hashFunction="SHA512" hashValue="91c3174d69d233c57462d9a455e191a0f8518c063d6868cea0205f4b77f675fee99e62753f7039d2be87ce439447adcfa490305c4f310d78f578324807da044c" size="55151367" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a8-14.0a2-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2_ALL.mar" hashFunction="SHA512" hashValue="02fe3d9749f8bd7e8d93788cd5965316307a9cb7cf9bd5e31b62457ef1acef804991531c5fc9ef5075249464e9351e2b74f1009c0e51c4c29ab3c9b813bae350" size="128932106" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos--13.5a8-14.0a2…" hashFunction="SHA512" hashValue="b82896186deb301fab1e17cc7f6a55adb09094a1053b2e4fd277e4689859c5d3bd1176a620e474f0b7c0e2680d48c1c9a4f73c248c252cb5708c059293cabae6" size="90340538" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a8-14.0a2-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="1c56ddf5c34841e1936543c92d800d9c82d9c7f7b5d6c5637d90ca3c19bd7065f0451a0e6e3d74d079ae59d3551deb595df94d51ead0a5b8a34068372b8ae110" size="94906672" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64--13.5…" hashFunction="SHA512" hashValue="3f604d6ce7605514f9604f11f801bdb3896a1cd56ab5bac5998a9e1e4accc0eba95b7e024480bfeb222de80912410db7b24e64a9f212345583f991fa367c2951" size="59076901" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a2-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2_…" hashFunction="SHA512" hashValue="191da335ea25d8e1d84c394c078fb481b4a74780ed77271fa3d5046558cef78c01079236595713fdb72c4f4f20de3c05fcc9114cea95ccca1d4b1c4ad7750b05" size="113891553" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64--13.5a9…" hashFunction="SHA512" hashValue="b9aa39a94ea71b3f0ea11663c8cdc45da9b966fd0838820effd0d4a458df4917f9d36d32f4b31db807d2e8197e2b55d7a5319950fd550920b671996d96559c51" size="54783731" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a2-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2_ALL.mar" hashFunction="SHA512" hashValue="02fe3d9749f8bd7e8d93788cd5965316307a9cb7cf9bd5e31b62457ef1acef804991531c5fc9ef5075249464e9351e2b74f1009c0e51c4c29ab3c9b813bae350" size="128932106" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos--13.5a9-14.0a2…" hashFunction="SHA512" hashValue="7f4c2af695a51acd58234281ee35179d237aecd0d19cb30d57e665e95a057d5455a7901c936e23e281ad17c98f82e2b0ad2cdab2981ea722fccace7fa3d8e6b3" size="89892434" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a2-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="1c56ddf5c34841e1936543c92d800d9c82d9c7f7b5d6c5637d90ca3c19bd7065f0451a0e6e3d74d079ae59d3551deb595df94d51ead0a5b8a34068372b8ae110" size="94906672" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64--13.5…" hashFunction="SHA512" hashValue="4bd51dea6a8abb1790710c2fa4e67815fb3ac95a630fbbbce1d2b34d7fa4d3f22b56e6fb18270e34626e13f26cc9b8ac385517164fc9138fc0bb736067a57eb9" size="58702449" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a3-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3_…" hashFunction="SHA512" hashValue="fbbaff6f952f3b4d7f86a53fb5d4ca0c6a72b67f947de70db7b6bf224511ec9892ced6faefd16a277e7cb8a36a0bb23c2cf6d86e73d5e793b9b94f68cc02fe05" size="114001681" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64--13.5a9…" hashFunction="SHA512" hashValue="71c4a17d4f77017bac10082dfaabc99bc70a258fc3b94b500d0457cc905f7b5553c484726338bb8cf9bc29a57a42d528a5efd73fc4610e032095a9e8f2655d5b" size="56206582" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a3-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3_ALL.mar" hashFunction="SHA512" hashValue="785609d40ee89c393d394e31519810088e91405047671871cf64416822c71e34182a12f6ff52700cd30bde7c3b81ffb93c904ce24e5610918c6c9a4d26f53ea0" size="129052534" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos--13.5a9-14.0a3…" hashFunction="SHA512" hashValue="ad62ad99714552906e09f3aad340b0157711f0fbebc7afeeba0c92a4d67c39719b7cf7800fbb449ffc7d46ad41219a5c495f152a8d632d65e2e33d4ed0d947b4" size="91383512" type="partial"></patch></update></updates> ===================================== update_1/alpha/13.5a9-14.0a3-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="b14d5d3beb668a9ee226692496cff76d5ea46dddf88430e800f791ec233284b5c4ae4b5947d416c96a2bc415832db2614a8239b64cf4f2f3ca6991b9dc5fccc5" size="95016852" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64--13.5…" hashFunction="SHA512" hashValue="c9b373d89798517c7409b41164d45950d3a9b2ecfe72c65b8821091c5f77a715d6dec45aeeee700de6bc0fd919a6679db52c95906383ef1f63a5cfd441913653" size="60120572" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a2-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2_…" hashFunction="SHA512" hashValue="191da335ea25d8e1d84c394c078fb481b4a74780ed77271fa3d5046558cef78c01079236595713fdb72c4f4f20de3c05fcc9114cea95ccca1d4b1c4ad7750b05" size="113891553" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64--14.0a1…" hashFunction="SHA512" hashValue="0d6718b13af17ab796d9b163137ec82957e481f47f171dc88d27d2485f0a810ccf0a4fe63bbfcf5f311f690db325b6dc3d164126297b232124a85f4915f81c41" size="9116550" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a2-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2_ALL.mar" hashFunction="SHA512" hashValue="02fe3d9749f8bd7e8d93788cd5965316307a9cb7cf9bd5e31b62457ef1acef804991531c5fc9ef5075249464e9351e2b74f1009c0e51c4c29ab3c9b813bae350" size="128932106" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos--14.0a1-14.0a2…" hashFunction="SHA512" hashValue="84a69a94e3513578b3c3836d3b038a2c02e7bb5e72ad4723c444eb490bfe7f1f43d20144670545dfe34aa01ff2816b4d2a491db459e869d23f604d4949625443" size="13920477" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a2-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="1c56ddf5c34841e1936543c92d800d9c82d9c7f7b5d6c5637d90ca3c19bd7065f0451a0e6e3d74d079ae59d3551deb595df94d51ead0a5b8a34068372b8ae110" size="94906672" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64--14.0…" hashFunction="SHA512" hashValue="a7ab1970723d4351760bfb632fe233886d9d9976b58aedb26e57233ecf24ba6a9b16f60d1a9537879a905206d5c040656add5b0ddc34ac26aa85252cfb3d172c" size="9298927" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a3-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3_…" hashFunction="SHA512" hashValue="fbbaff6f952f3b4d7f86a53fb5d4ca0c6a72b67f947de70db7b6bf224511ec9892ced6faefd16a277e7cb8a36a0bb23c2cf6d86e73d5e793b9b94f68cc02fe05" size="114001681" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64--14.0a1…" hashFunction="SHA512" hashValue="98c77dd2ef8be4bf39bcfa42c83049516317e6b182ebc71ea21a6dbc1a786568351c9ed96a83166b8262efc4312e996834aae47c83da53e2497338b763c404af" size="11860989" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a3-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3_ALL.mar" hashFunction="SHA512" hashValue="785609d40ee89c393d394e31519810088e91405047671871cf64416822c71e34182a12f6ff52700cd30bde7c3b81ffb93c904ce24e5610918c6c9a4d26f53ea0" size="129052534" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos--14.0a1-14.0a3…" hashFunction="SHA512" hashValue="d258c5633a8826ad2fba68af023ad3418cada6966f1b80f280bc8810cdfb8efc7cb786401e2088cbd3ac1701a3b9448676c5341410fe01ec1a0acb3a15e9eea8" size="17403543" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a1-14.0a3-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="b14d5d3beb668a9ee226692496cff76d5ea46dddf88430e800f791ec233284b5c4ae4b5947d416c96a2bc415832db2614a8239b64cf4f2f3ca6991b9dc5fccc5" size="95016852" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64--14.0…" hashFunction="SHA512" hashValue="f0f7ed8d1227e0e590fded0699e2e0e25226027aeea9fe2db06ef380459bfed014377cee6709d9fb7f5c2b341898b6ca76622094a15f3dbb1b1a699307e1e1c5" size="12171674" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a2-14.0a3-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3_…" hashFunction="SHA512" hashValue="fbbaff6f952f3b4d7f86a53fb5d4ca0c6a72b67f947de70db7b6bf224511ec9892ced6faefd16a277e7cb8a36a0bb23c2cf6d86e73d5e793b9b94f68cc02fe05" size="114001681" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64--14.0a2…" hashFunction="SHA512" hashValue="4a951f300717f9f59b8e9e4366d1c4a881266997efa94f054188072225e7169c608c937d652c0637e83f9108bad0fc2498786edc5d57d6bab05605d10c371915" size="8443934" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a2-14.0a3-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3_ALL.mar" hashFunction="SHA512" hashValue="785609d40ee89c393d394e31519810088e91405047671871cf64416822c71e34182a12f6ff52700cd30bde7c3b81ffb93c904ce24e5610918c6c9a4d26f53ea0" size="129052534" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos--14.0a2-14.0a3…" hashFunction="SHA512" hashValue="3f607fef6f0e7cfa9eed77c055785b3e5db8001652471fcc68969e623b4880696b41dc878fee0643a0b17b4cdd3ad185e7699335411d8b7fcba3261bdc5102a3" size="13701870" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a2-14.0a3-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="b14d5d3beb668a9ee226692496cff76d5ea46dddf88430e800f791ec233284b5c4ae4b5947d416c96a2bc415832db2614a8239b64cf4f2f3ca6991b9dc5fccc5" size="95016852" type="complete"></patch><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64--14.0…" hashFunction="SHA512" hashValue="67b93e757c33cbea1a937de58955724ebcc0256e8e7b5a0ad457a00e15fa13cd4da4ec878827ec899737dc4743b09792c2b045ccf24efd07e257f721d8baef7e" size="8765631" type="partial"></patch></update></updates> ===================================== update_1/alpha/14.0a2-linux-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2_…" hashFunction="SHA512" hashValue="191da335ea25d8e1d84c394c078fb481b4a74780ed77271fa3d5046558cef78c01079236595713fdb72c4f4f20de3c05fcc9114cea95ccca1d4b1c4ad7750b05" size="113891553" type="complete"></patch></update></updates> ===================================== update_1/alpha/14.0a2-macos-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2_ALL.mar" hashFunction="SHA512" hashValue="02fe3d9749f8bd7e8d93788cd5965316307a9cb7cf9bd5e31b62457ef1acef804991531c5fc9ef5075249464e9351e2b74f1009c0e51c4c29ab3c9b813bae350" size="128932106" type="complete"></patch></update></updates> ===================================== update_1/alpha/14.0a2-windows-x86_64-ALL.xml deleted ===================================== @@ -1,2 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<updates><update type="minor" displayVersion="14.0a2" appVersion="14.0a2" platformVersion="128.1.0" buildID="20240816000831" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a2" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="1c56ddf5c34841e1936543c92d800d9c82d9c7f7b5d6c5637d90ca3c19bd7065f0451a0e6e3d74d079ae59d3551deb595df94d51ead0a5b8a34068372b8ae110" size="94906672" type="complete"></patch></update></updates> ===================================== update_1/alpha/14.0a3-linux-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedInstructionSet="SSE2"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3_…" hashFunction="SHA512" hashValue="fbbaff6f952f3b4d7f86a53fb5d4ca0c6a72b67f947de70db7b6bf224511ec9892ced6faefd16a277e7cb8a36a0bb23c2cf6d86e73d5e793b9b94f68cc02fe05" size="114001681" type="complete"></patch></update></updates> ===================================== update_1/alpha/14.0a3-macos-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="19.0.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3_ALL.mar" hashFunction="SHA512" hashValue="785609d40ee89c393d394e31519810088e91405047671871cf64416822c71e34182a12f6ff52700cd30bde7c3b81ffb93c904ce24e5610918c6c9a4d26f53ea0" size="129052534" type="complete"></patch></update></updates> ===================================== update_1/alpha/14.0a3-windows-x86_64-ALL.xml ===================================== @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8"?> +<updates><update type="minor" displayVersion="14.0a3" appVersion="14.0a3" platformVersion="128.2.0" buildID="20240826221405" detailsURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" actions="showURL" openURL="https://github.com/mullvad/mullvad-browser/releases/14.0a3" minSupportedOSVersion="10.0"><patch URL="https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…" hashFunction="SHA512" hashValue="b14d5d3beb668a9ee226692496cff76d5ea46dddf88430e800f791ec233284b5c4ae4b5947d416c96a2bc415832db2614a8239b64cf4f2f3ca6991b9dc5fccc5" size="95016852" type="complete"></patch></update></updates> ===================================== update_1/alpha/download-linux-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2.…","git_tag":"mb-14.0a2-build1","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2.…","version":"14.0a2"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3.…","git_tag":"mb-14.0a3-build1","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3.…","version":"14.0a3"} \ No newline at end of file ===================================== update_1/alpha/download-macos.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2.dmg","git_tag":"mb-14.0a2-build1","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2.dmg.asc","version":"14.0a2"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3.dmg","git_tag":"mb-14.0a3-build1","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3.dmg.asc","version":"14.0a3"} \ No newline at end of file ===================================== update_1/alpha/download-windows-x86_64.json ===================================== @@ -1 +1 @@ -{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…","git_tag":"mb-14.0a2-build1","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…","version":"14.0a2"} \ No newline at end of file +{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…","git_tag":"mb-14.0a3-build1","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…","version":"14.0a3"} \ No newline at end of file ===================================== update_1/alpha/downloads.json ===================================== @@ -1 +1 @@ -{"downloads":{"linux-x86_64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2.…","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-linux-x86_64-14.0a2.…"}},"macos":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2.dmg","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-macos-14.0a2.dmg.asc"}},"win64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…","sig":"https://cdn.mullvad.net/browser/14.0a2/mullvad-browser-windows-x86_64-14.0a…"}}},"tag":"mb-14.0a2-build1","version":"14.0a2"} \ No newline at end of file +{"downloads":{"linux-x86_64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3.…","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-linux-x86_64-14.0a3.…"}},"macos":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3.dmg","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-macos-14.0a3.dmg.asc"}},"win64":{"ALL":{"binary":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…","sig":"https://cdn.mullvad.net/browser/14.0a3/mullvad-browser-windows-x86_64-14.0a…"}}},"tag":"mb-14.0a3-build1","version":"14.0a3"} \ No newline at end of file View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser-update-respo… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: a6251e60 by cypherpunks1 at 2024-08-28T17:41:16+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Bug 42730: Revert some changes - - - - - 09069722 by cypherpunks1 at 2024-08-28T17:41:17+02:00 Bug 42730: Patch RemoteSettings to use only local dumps as a data source - - - - - 8 changed files: - browser/components/BrowserGlue.sys.mjs - mobile/shared/chrome/geckoview/geckoview.js - services/settings/Attachments.sys.mjs - services/settings/RemoteSettingsClient.sys.mjs - services/settings/dumps/gen_last_modified.py - services/settings/remote-settings.sys.mjs - toolkit/modules/AppConstants.sys.mjs - toolkit/modules/IgnoreLists.sys.mjs Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -3368,6 +3368,11 @@ BrowserGlue.prototype = { lazy.RemoteSecuritySettings.init(); }, + function RemoteSettingsPollChanges() { + // Support clients that use the "sync" event or "remote-settings:changes-poll-end". + lazy.RemoteSettings.pollChanges({ trigger: "timer" }); + }, + function BrowserUsageTelemetryReportProfileCount() { lazy.BrowserUsageTelemetry.reportProfileCount(); }, ===================================== mobile/shared/chrome/geckoview/geckoview.js ===================================== @@ -21,6 +21,7 @@ ChromeUtils.defineESModuleGetters(this, { InitializationTracker: "resource://gre/modules/GeckoViewTelemetry.sys.mjs", RemoteSecuritySettings: "resource://gre/modules/psm/RemoteSecuritySettings.sys.mjs", + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", SafeBrowsing: "resource://gre/modules/SafeBrowsing.sys.mjs", }); @@ -922,6 +923,10 @@ function startup() { Blocklist.loadBlocklistAsync(); }); + InitLater(() => { + RemoteSettings.pollChanges({ trigger: "timer" }); + }); + // This should always go last, since the idle tasks (except for the ones with // timeouts) should execute in order. Note that this observer notification is // not guaranteed to fire, since the window could close before we get here. ===================================== services/settings/Attachments.sys.mjs ===================================== @@ -223,6 +223,10 @@ export class Downloader { fallbackToDump = false; } + avoidDownload = true; + fallbackToCache = true; + fallbackToDump = true; + const dumpInfo = new LazyRecordAndBuffer(() => this._readAttachmentDump(attachmentId) ); @@ -444,6 +448,8 @@ export class Downloader { attachment: { location, hash, size }, } = record; + return (await this.#fetchAttachment(record)).buffer; + // eslint-disable-next-line no-unreachable const remoteFileUrl = (await this._baseAttachmentsURL()) + location; const { retries = 3, checkHash = true } = options; ===================================== services/settings/RemoteSettingsClient.sys.mjs ===================================== @@ -424,11 +424,19 @@ export class RemoteSettingsClient extends EventEmitter { order = "", // not sorted by default. dumpFallback = true, emptyListFallback = true, - forceSync = false, loadDumpIfNewer = true, - syncIfEmpty = true, } = options; - let { verifySignature = false } = options; + + const hasLocalDump = await lazy.Utils.hasLocalDump( + this.bucketName, + this.collectionName + ); + if (!hasLocalDump) { + return []; + } + const forceSync = false; + const syncIfEmpty = true; + let verifySignature = false; const hasParallelCall = !!this._importingPromise; let data; @@ -598,6 +606,10 @@ export class RemoteSettingsClient extends EventEmitter { * @param {Object} options See #maybeSync() options. */ async sync(options) { + if (AppConstants.BASE_BROWSER_VERSION) { + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } @@ -664,7 +676,7 @@ export class RemoteSettingsClient extends EventEmitter { let thrownError = null; try { // If network is offline, we can't synchronize. - if (lazy.Utils.isOffline) { + if (!AppConstants.BASE_BROWSER_VERSION && lazy.Utils.isOffline) { throw new RemoteSettingsClient.NetworkOfflineError(); } @@ -1046,14 +1058,8 @@ export class RemoteSettingsClient extends EventEmitter { options = {} ) { const { retry = false } = options; - const since = retry || !localTimestamp ? undefined : `"${localTimestamp}"`; - // Fetch collection metadata and list of changes from server. - lazy.console.debug( - `${this.identifier} Fetch changes from server (expected=${expectedTimestamp}, since=${since})` - ); - const { metadata, remoteTimestamp, remoteRecords } = - await this._fetchChangeset(expectedTimestamp, since); + let metadata, remoteTimestamp; // We build a sync result, based on remote changes. const syncResult = { @@ -1062,24 +1068,20 @@ export class RemoteSettingsClient extends EventEmitter { updated: [], deleted: [], }; - // If data wasn't changed, return empty sync result. - // This can happen when we update the signature but not the data. - lazy.console.debug( - `${this.identifier} local timestamp: ${localTimestamp}, remote: ${remoteTimestamp}` - ); - if (localTimestamp && remoteTimestamp < localTimestamp) { + + try { + await this._importJSONDump(); + } catch (e) { return syncResult; } - await this.db.importChanges(metadata, remoteTimestamp, remoteRecords, { - clear: retry, - }); - // Read the new local data, after updating. const newLocal = await this.db.list(); const newRecords = newLocal.map(r => this._cleanLocalFields(r)); // And verify the signature on what is now stored. - if (this.verifySignature) { + if (metadata === undefined) { + // When working only with dumps, we do not have signatures. + } else if (this.verifySignature) { try { await this._validateCollectionSignature( newRecords, ===================================== services/settings/dumps/gen_last_modified.py ===================================== @@ -63,8 +63,10 @@ def main(output): dumps_locations = [] if buildconfig.substs["MOZ_BUILD_APP"] == "browser": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/android": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/ios": dumps_locations += ["services/settings/dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "comm/mail": ===================================== services/settings/remote-settings.sys.mjs ===================================== @@ -91,6 +91,7 @@ export async function jexlFilterFunc(entry, environment) { function remoteSettingsFunction() { const _clients = new Map(); let _invalidatePolling = false; + let _initialized = false; // If not explicitly specified, use the default signer. const defaultOptions = { @@ -194,21 +195,49 @@ function remoteSettingsFunction() { trigger = "manual", full = false, } = {}) => { + if (AppConstants.BASE_BROWSER_VERSION) { + // Called multiple times on GeckoView due to bug 1730026 + if (_initialized) { + return; + } + _initialized = true; + let importedFromDump = false; + for (const client of _clients.values()) { + const hasLocalDump = await lazy.Utils.hasLocalDump( + client.bucketName, + client.collectionName + ); + if (hasLocalDump) { + const lastModified = await client.getLastModified(); + const lastModifiedDump = await lazy.Utils.getLocalDumpLastModified( + client.bucketName, + client.collectionName + ); + if (lastModified < lastModifiedDump) { + await client.maybeSync(lastModifiedDump, { + loadDump: true, + trigger, + }); + importedFromDump = true; + } + } + } + if (importedFromDump) { + Services.obs.notifyObservers(null, "remote-settings:changes-poll-end"); + } + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } // When running in full mode, we ignore last polling status. - if (full || AppConstants.BASE_BROWSER_VERSION) { + if (full) { lazy.gPrefs.clearUserPref(PREF_SETTINGS_SERVER_BACKOFF); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_UPDATE); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_ETAG); } - if (AppConstants.BASE_BROWSER_VERSION) { - // tor-browser#41704: pollChanges is always online, so do not allow it. - return; - } - let pollTelemetryArgs = { source: TELEMETRY_SOURCE_POLL, trigger, ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -423,11 +423,11 @@ export var AppConstants = Object.freeze({ #ifdef MOZ_THUNDERBIRD "https://thunderbird-settings.thunderbird.net/v1", #else - "https://firefox.settings.services.mozilla.com/v1", + "", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: -#ifdef MOZ_THUNDERBIRD +#if defined(MOZ_THUNDERBIRD) || defined(BASE_BROWSER_VERSION) false, #else true, ===================================== toolkit/modules/IgnoreLists.sys.mjs ===================================== @@ -5,16 +5,18 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", RemoteSettingsClient: "resource://services-settings/RemoteSettingsClient.sys.mjs", }); -class IgnoreListsManager { - _ignoreListSettings = null; +const SETTINGS_IGNORELIST_KEY = "hijack-blocklists"; +class IgnoreListsManager { async init() { - // TODO: Restore the initialization, once we use only the local dumps for - // the remote settings. + if (!this._ignoreListSettings) { + this._ignoreListSettings = lazy.RemoteSettings(SETTINGS_IGNORELIST_KEY); + } } async getAndSubscribe(listener) { @@ -24,7 +26,7 @@ class IgnoreListsManager { const settings = await this._getIgnoreList(); // Listen for future updates after we first get the values. - this._ignoreListSettings?.on("sync", listener); + this._ignoreListSettings.on("sync", listener); return settings; } @@ -65,14 +67,6 @@ class IgnoreListsManager { * could be obtained. */ async _getIgnoreListSettings(firstTime = true) { - if (!this._ignoreListSettings) { - const dump = await fetch( - "resource:///defaults/settings/main/hijack-blocklists.json" - ); - const { data } = await dump.json(); - return data; - } - let result = []; try { result = await this._ignoreListSettings.get({ View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/71… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 4281e5b9 by cypherpunks1 at 2024-08-28T17:40:16+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Bug 42730: Revert some changes - - - - - 0f01ba03 by cypherpunks1 at 2024-08-28T17:40:20+02:00 Bug 42730: Patch RemoteSettings to use only local dumps as a data source - - - - - 8 changed files: - browser/components/BrowserGlue.sys.mjs - mobile/shared/chrome/geckoview/geckoview.js - services/settings/Attachments.sys.mjs - services/settings/RemoteSettingsClient.sys.mjs - services/settings/dumps/gen_last_modified.py - services/settings/remote-settings.sys.mjs - toolkit/modules/AppConstants.sys.mjs - toolkit/modules/IgnoreLists.sys.mjs Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -3387,6 +3387,11 @@ BrowserGlue.prototype = { lazy.RemoteSecuritySettings.init(); }, + function RemoteSettingsPollChanges() { + // Support clients that use the "sync" event or "remote-settings:changes-poll-end". + lazy.RemoteSettings.pollChanges({ trigger: "timer" }); + }, + function BrowserUsageTelemetryReportProfileCount() { lazy.BrowserUsageTelemetry.reportProfileCount(); }, ===================================== mobile/shared/chrome/geckoview/geckoview.js ===================================== @@ -21,6 +21,7 @@ ChromeUtils.defineESModuleGetters(this, { InitializationTracker: "resource://gre/modules/GeckoViewTelemetry.sys.mjs", RemoteSecuritySettings: "resource://gre/modules/psm/RemoteSecuritySettings.sys.mjs", + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", SafeBrowsing: "resource://gre/modules/SafeBrowsing.sys.mjs", }); @@ -922,6 +923,10 @@ function startup() { Blocklist.loadBlocklistAsync(); }); + InitLater(() => { + RemoteSettings.pollChanges({ trigger: "timer" }); + }); + // This should always go last, since the idle tasks (except for the ones with // timeouts) should execute in order. Note that this observer notification is // not guaranteed to fire, since the window could close before we get here. ===================================== services/settings/Attachments.sys.mjs ===================================== @@ -223,6 +223,10 @@ export class Downloader { fallbackToDump = false; } + avoidDownload = true; + fallbackToCache = true; + fallbackToDump = true; + const dumpInfo = new LazyRecordAndBuffer(() => this._readAttachmentDump(attachmentId) ); @@ -444,6 +448,8 @@ export class Downloader { attachment: { location, hash, size }, } = record; + return (await this.#fetchAttachment(record)).buffer; + // eslint-disable-next-line no-unreachable const remoteFileUrl = (await this._baseAttachmentsURL()) + location; const { retries = 3, checkHash = true } = options; ===================================== services/settings/RemoteSettingsClient.sys.mjs ===================================== @@ -424,11 +424,19 @@ export class RemoteSettingsClient extends EventEmitter { order = "", // not sorted by default. dumpFallback = true, emptyListFallback = true, - forceSync = false, loadDumpIfNewer = true, - syncIfEmpty = true, } = options; - let { verifySignature = false } = options; + + const hasLocalDump = await lazy.Utils.hasLocalDump( + this.bucketName, + this.collectionName + ); + if (!hasLocalDump) { + return []; + } + const forceSync = false; + const syncIfEmpty = true; + let verifySignature = false; const hasParallelCall = !!this._importingPromise; let data; @@ -598,6 +606,10 @@ export class RemoteSettingsClient extends EventEmitter { * @param {Object} options See #maybeSync() options. */ async sync(options) { + if (AppConstants.BASE_BROWSER_VERSION) { + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } @@ -664,7 +676,7 @@ export class RemoteSettingsClient extends EventEmitter { let thrownError = null; try { // If network is offline, we can't synchronize. - if (lazy.Utils.isOffline) { + if (!AppConstants.BASE_BROWSER_VERSION && lazy.Utils.isOffline) { throw new RemoteSettingsClient.NetworkOfflineError(); } @@ -1046,14 +1058,8 @@ export class RemoteSettingsClient extends EventEmitter { options = {} ) { const { retry = false } = options; - const since = retry || !localTimestamp ? undefined : `"${localTimestamp}"`; - // Fetch collection metadata and list of changes from server. - lazy.console.debug( - `${this.identifier} Fetch changes from server (expected=${expectedTimestamp}, since=${since})` - ); - const { metadata, remoteTimestamp, remoteRecords } = - await this._fetchChangeset(expectedTimestamp, since); + let metadata, remoteTimestamp; // We build a sync result, based on remote changes. const syncResult = { @@ -1062,24 +1068,20 @@ export class RemoteSettingsClient extends EventEmitter { updated: [], deleted: [], }; - // If data wasn't changed, return empty sync result. - // This can happen when we update the signature but not the data. - lazy.console.debug( - `${this.identifier} local timestamp: ${localTimestamp}, remote: ${remoteTimestamp}` - ); - if (localTimestamp && remoteTimestamp < localTimestamp) { + + try { + await this._importJSONDump(); + } catch (e) { return syncResult; } - await this.db.importChanges(metadata, remoteTimestamp, remoteRecords, { - clear: retry, - }); - // Read the new local data, after updating. const newLocal = await this.db.list(); const newRecords = newLocal.map(r => this._cleanLocalFields(r)); // And verify the signature on what is now stored. - if (this.verifySignature) { + if (metadata === undefined) { + // When working only with dumps, we do not have signatures. + } else if (this.verifySignature) { try { await this._validateCollectionSignature( newRecords, ===================================== services/settings/dumps/gen_last_modified.py ===================================== @@ -63,8 +63,10 @@ def main(output): dumps_locations = [] if buildconfig.substs["MOZ_BUILD_APP"] == "browser": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/android": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/ios": dumps_locations += ["services/settings/dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "comm/mail": ===================================== services/settings/remote-settings.sys.mjs ===================================== @@ -91,6 +91,7 @@ export async function jexlFilterFunc(entry, environment) { function remoteSettingsFunction() { const _clients = new Map(); let _invalidatePolling = false; + let _initialized = false; // If not explicitly specified, use the default signer. const defaultOptions = { @@ -194,21 +195,49 @@ function remoteSettingsFunction() { trigger = "manual", full = false, } = {}) => { + if (AppConstants.BASE_BROWSER_VERSION) { + // Called multiple times on GeckoView due to bug 1730026 + if (_initialized) { + return; + } + _initialized = true; + let importedFromDump = false; + for (const client of _clients.values()) { + const hasLocalDump = await lazy.Utils.hasLocalDump( + client.bucketName, + client.collectionName + ); + if (hasLocalDump) { + const lastModified = await client.getLastModified(); + const lastModifiedDump = await lazy.Utils.getLocalDumpLastModified( + client.bucketName, + client.collectionName + ); + if (lastModified < lastModifiedDump) { + await client.maybeSync(lastModifiedDump, { + loadDump: true, + trigger, + }); + importedFromDump = true; + } + } + } + if (importedFromDump) { + Services.obs.notifyObservers(null, "remote-settings:changes-poll-end"); + } + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } // When running in full mode, we ignore last polling status. - if (full || AppConstants.BASE_BROWSER_VERSION) { + if (full) { lazy.gPrefs.clearUserPref(PREF_SETTINGS_SERVER_BACKOFF); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_UPDATE); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_ETAG); } - if (AppConstants.BASE_BROWSER_VERSION) { - // tor-browser#41704: pollChanges is always online, so do not allow it. - return; - } - let pollTelemetryArgs = { source: TELEMETRY_SOURCE_POLL, trigger, ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -423,11 +423,11 @@ export var AppConstants = Object.freeze({ #ifdef MOZ_THUNDERBIRD "https://thunderbird-settings.thunderbird.net/v1", #else - "https://firefox.settings.services.mozilla.com/v1", + "", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: -#ifdef MOZ_THUNDERBIRD +#if defined(MOZ_THUNDERBIRD) || defined(BASE_BROWSER_VERSION) false, #else true, ===================================== toolkit/modules/IgnoreLists.sys.mjs ===================================== @@ -5,16 +5,18 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", RemoteSettingsClient: "resource://services-settings/RemoteSettingsClient.sys.mjs", }); -class IgnoreListsManager { - _ignoreListSettings = null; +const SETTINGS_IGNORELIST_KEY = "hijack-blocklists"; +class IgnoreListsManager { async init() { - // TODO: Restore the initialization, once we use only the local dumps for - // the remote settings. + if (!this._ignoreListSettings) { + this._ignoreListSettings = lazy.RemoteSettings(SETTINGS_IGNORELIST_KEY); + } } async getAndSubscribe(listener) { @@ -24,7 +26,7 @@ class IgnoreListsManager { const settings = await this._getIgnoreList(); // Listen for future updates after we first get the values. - this._ignoreListSettings?.on("sync", listener); + this._ignoreListSettings.on("sync", listener); return settings; } @@ -65,14 +67,6 @@ class IgnoreListsManager { * could be obtained. */ async _getIgnoreListSettings(firstTime = true) { - if (!this._ignoreListSettings) { - const dump = await fetch( - "resource:///defaults/settings/main/hijack-blocklists.json" - ); - const { data } = await dump.json(); - return data; - } - let result = []; try { result = await this._ignoreListSettings.get({ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ec9235… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ec9235… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 196b0053 by cypherpunks1 at 2024-08-28T05:34:49-08:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Bug 42730: Revert some changes - - - - - 902c51f9 by cypherpunks1 at 2024-08-28T06:27:27-08:00 Bug 42730: Patch RemoteSettings to use only local dumps as a data source - - - - - 8 changed files: - browser/components/BrowserGlue.sys.mjs - mobile/shared/chrome/geckoview/geckoview.js - services/settings/Attachments.sys.mjs - services/settings/RemoteSettingsClient.sys.mjs - services/settings/dumps/gen_last_modified.py - services/settings/remote-settings.sys.mjs - toolkit/modules/AppConstants.sys.mjs - toolkit/modules/IgnoreLists.sys.mjs Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -3497,6 +3497,11 @@ BrowserGlue.prototype = { lazy.RemoteSecuritySettings.init(); }, + function RemoteSettingsPollChanges() { + // Support clients that use the "sync" event or "remote-settings:changes-poll-end". + lazy.RemoteSettings.pollChanges({ trigger: "timer" }); + }, + function BrowserUsageTelemetryReportProfileCount() { lazy.BrowserUsageTelemetry.reportProfileCount(); }, ===================================== mobile/shared/chrome/geckoview/geckoview.js ===================================== @@ -21,6 +21,7 @@ ChromeUtils.defineESModuleGetters(this, { InitializationTracker: "resource://gre/modules/GeckoViewTelemetry.sys.mjs", RemoteSecuritySettings: "resource://gre/modules/psm/RemoteSecuritySettings.sys.mjs", + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", SafeBrowsing: "resource://gre/modules/SafeBrowsing.sys.mjs", }); @@ -922,6 +923,10 @@ function startup() { Blocklist.loadBlocklistAsync(); }); + InitLater(() => { + RemoteSettings.pollChanges({ trigger: "timer" }); + }); + // This should always go last, since the idle tasks (except for the ones with // timeouts) should execute in order. Note that this observer notification is // not guaranteed to fire, since the window could close before we get here. ===================================== services/settings/Attachments.sys.mjs ===================================== @@ -223,6 +223,10 @@ export class Downloader { fallbackToDump = false; } + avoidDownload = true; + fallbackToCache = true; + fallbackToDump = true; + const dumpInfo = new LazyRecordAndBuffer(() => this._readAttachmentDump(attachmentId) ); @@ -444,6 +448,8 @@ export class Downloader { attachment: { location, hash, size }, } = record; + return (await this.#fetchAttachment(record)).buffer; + // eslint-disable-next-line no-unreachable const remoteFileUrl = (await this._baseAttachmentsURL()) + location; const { retries = 3, checkHash = true } = options; ===================================== services/settings/RemoteSettingsClient.sys.mjs ===================================== @@ -424,11 +424,19 @@ export class RemoteSettingsClient extends EventEmitter { order = "", // not sorted by default. dumpFallback = true, emptyListFallback = true, - forceSync = false, loadDumpIfNewer = true, - syncIfEmpty = true, } = options; - let { verifySignature = false } = options; + + const hasLocalDump = await lazy.Utils.hasLocalDump( + this.bucketName, + this.collectionName + ); + if (!hasLocalDump) { + return []; + } + const forceSync = false; + const syncIfEmpty = true; + let verifySignature = false; const hasParallelCall = !!this._importingPromise; let data; @@ -598,6 +606,10 @@ export class RemoteSettingsClient extends EventEmitter { * @param {Object} options See #maybeSync() options. */ async sync(options) { + if (AppConstants.BASE_BROWSER_VERSION) { + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } @@ -664,7 +676,7 @@ export class RemoteSettingsClient extends EventEmitter { let thrownError = null; try { // If network is offline, we can't synchronize. - if (lazy.Utils.isOffline) { + if (!AppConstants.BASE_BROWSER_VERSION && lazy.Utils.isOffline) { throw new RemoteSettingsClient.NetworkOfflineError(); } @@ -1046,14 +1058,8 @@ export class RemoteSettingsClient extends EventEmitter { options = {} ) { const { retry = false } = options; - const since = retry || !localTimestamp ? undefined : `"${localTimestamp}"`; - // Fetch collection metadata and list of changes from server. - lazy.console.debug( - `${this.identifier} Fetch changes from server (expected=${expectedTimestamp}, since=${since})` - ); - const { metadata, remoteTimestamp, remoteRecords } = - await this._fetchChangeset(expectedTimestamp, since); + let metadata, remoteTimestamp; // We build a sync result, based on remote changes. const syncResult = { @@ -1062,24 +1068,20 @@ export class RemoteSettingsClient extends EventEmitter { updated: [], deleted: [], }; - // If data wasn't changed, return empty sync result. - // This can happen when we update the signature but not the data. - lazy.console.debug( - `${this.identifier} local timestamp: ${localTimestamp}, remote: ${remoteTimestamp}` - ); - if (localTimestamp && remoteTimestamp < localTimestamp) { + + try { + await this._importJSONDump(); + } catch (e) { return syncResult; } - await this.db.importChanges(metadata, remoteTimestamp, remoteRecords, { - clear: retry, - }); - // Read the new local data, after updating. const newLocal = await this.db.list(); const newRecords = newLocal.map(r => this._cleanLocalFields(r)); // And verify the signature on what is now stored. - if (this.verifySignature) { + if (metadata === undefined) { + // When working only with dumps, we do not have signatures. + } else if (this.verifySignature) { try { await this._validateCollectionSignature( newRecords, ===================================== services/settings/dumps/gen_last_modified.py ===================================== @@ -63,8 +63,10 @@ def main(output): dumps_locations = [] if buildconfig.substs["MOZ_BUILD_APP"] == "browser": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/android": dumps_locations += ["services/settings/dumps/"] + dumps_locations += ["services/settings/static-dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "mobile/ios": dumps_locations += ["services/settings/dumps/"] elif buildconfig.substs["MOZ_BUILD_APP"] == "comm/mail": ===================================== services/settings/remote-settings.sys.mjs ===================================== @@ -91,6 +91,7 @@ export async function jexlFilterFunc(entry, environment) { function remoteSettingsFunction() { const _clients = new Map(); let _invalidatePolling = false; + let _initialized = false; // If not explicitly specified, use the default signer. const defaultOptions = { @@ -194,21 +195,49 @@ function remoteSettingsFunction() { trigger = "manual", full = false, } = {}) => { + if (AppConstants.BASE_BROWSER_VERSION) { + // Called multiple times on GeckoView due to bug 1730026 + if (_initialized) { + return; + } + _initialized = true; + let importedFromDump = false; + for (const client of _clients.values()) { + const hasLocalDump = await lazy.Utils.hasLocalDump( + client.bucketName, + client.collectionName + ); + if (hasLocalDump) { + const lastModified = await client.getLastModified(); + const lastModifiedDump = await lazy.Utils.getLocalDumpLastModified( + client.bucketName, + client.collectionName + ); + if (lastModified < lastModifiedDump) { + await client.maybeSync(lastModifiedDump, { + loadDump: true, + trigger, + }); + importedFromDump = true; + } + } + } + if (importedFromDump) { + Services.obs.notifyObservers(null, "remote-settings:changes-poll-end"); + } + return; + } + if (lazy.Utils.shouldSkipRemoteActivityDueToTests) { return; } // When running in full mode, we ignore last polling status. - if (full || AppConstants.BASE_BROWSER_VERSION) { + if (full) { lazy.gPrefs.clearUserPref(PREF_SETTINGS_SERVER_BACKOFF); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_UPDATE); lazy.gPrefs.clearUserPref(PREF_SETTINGS_LAST_ETAG); } - if (AppConstants.BASE_BROWSER_VERSION) { - // tor-browser#41704: pollChanges is always online, so do not allow it. - return; - } - let pollTelemetryArgs = { source: TELEMETRY_SOURCE_POLL, trigger, ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -423,11 +423,11 @@ export var AppConstants = Object.freeze({ #ifdef MOZ_THUNDERBIRD "https://thunderbird-settings.thunderbird.net/v1", #else - "https://firefox.settings.services.mozilla.com/v1", + "", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: -#ifdef MOZ_THUNDERBIRD +#if defined(MOZ_THUNDERBIRD) || defined(BASE_BROWSER_VERSION) false, #else true, ===================================== toolkit/modules/IgnoreLists.sys.mjs ===================================== @@ -5,16 +5,18 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { + RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", RemoteSettingsClient: "resource://services-settings/RemoteSettingsClient.sys.mjs", }); -class IgnoreListsManager { - _ignoreListSettings = null; +const SETTINGS_IGNORELIST_KEY = "hijack-blocklists"; +class IgnoreListsManager { async init() { - // TODO: Restore the initialization, once we use only the local dumps for - // the remote settings. + if (!this._ignoreListSettings) { + this._ignoreListSettings = lazy.RemoteSettings(SETTINGS_IGNORELIST_KEY); + } } async getAndSubscribe(listener) { @@ -24,7 +26,7 @@ class IgnoreListsManager { const settings = await this._getIgnoreList(); // Listen for future updates after we first get the values. - this._ignoreListSettings?.on("sync", listener); + this._ignoreListSettings.on("sync", listener); return settings; } @@ -65,14 +67,6 @@ class IgnoreListsManager { * could be obtained. */ async _getIgnoreListSettings(firstTime = true) { - if (!this._ignoreListSettings) { - const dump = await fetch( - "resource:///defaults/settings/main/hijack-blocklists.json" - ); - const { data } = await dump.json(); - return data; - } - let result = []; try { result = await this._ignoreListSettings.get({ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3a0765… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3a0765… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] Bug 43092: Disable wayland by default in Base Browser.
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 712375db by Henry Wilkes at 2024-08-28T11:35:47+02:00 Bug 43092: Disable wayland by default in Base Browser. - - - - - 1 changed file: - toolkit/xre/nsAppRunner.cpp Changes: ===================================== toolkit/xre/nsAppRunner.cpp ===================================== @@ -460,13 +460,14 @@ bool IsWaylandEnabled() { return true; } } + // Keep wayland disabled in Base Browser. See tor-browser#43092. + return false; // Enable by default when we're running on a recent enough GTK version. We'd // like to check further details like compositor version and so on ideally // to make sure we don't enable it on old Mutter or what not, but we can't, // so let's assume that if the user is running on a Wayland session by // default we're ok, since either the distro has enabled Wayland by default, // or the user has gone out of their way to use Wayland. - return !gtk_check_version(3, 24, 30); }(); return isWaylandEnabled; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/712… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/712… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] Bug 43092: Disable wayland by default in Base Browser.
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ec9235a9 by Henry Wilkes at 2024-08-28T11:35:06+02:00 Bug 43092: Disable wayland by default in Base Browser. - - - - - 1 changed file: - toolkit/xre/nsAppRunner.cpp Changes: ===================================== toolkit/xre/nsAppRunner.cpp ===================================== @@ -460,13 +460,14 @@ bool IsWaylandEnabled() { return true; } } + // Keep wayland disabled in Base Browser. See tor-browser#43092. + return false; // Enable by default when we're running on a recent enough GTK version. We'd // like to check further details like compositor version and so on ideally // to make sure we don't enable it on old Mutter or what not, but we can't, // so let's assume that if the user is running on a Wayland session by // default we're ok, since either the distro has enabled Wayland by default, // or the user has gone out of their way to use Wayland. - return !gtk_check_version(3, 24, 30); }(); return isWaylandEnabled; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ec9235a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ec9235a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] Bug 43092: Disable wayland by default in Base Browser.
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 3a076593 by Henry Wilkes at 2024-08-28T09:51:38+01:00 Bug 43092: Disable wayland by default in Base Browser. - - - - - 1 changed file: - toolkit/xre/nsAppRunner.cpp Changes: ===================================== toolkit/xre/nsAppRunner.cpp ===================================== @@ -460,13 +460,14 @@ bool IsWaylandEnabled() { return true; } } + // Keep wayland disabled in Base Browser. See tor-browser#43092. + return false; // Enable by default when we're running on a recent enough GTK version. We'd // like to check further details like compositor version and so on ideally // to make sure we don't enable it on old Mutter or what not, but we can't, // so let's assume that if the user is running on a Wayland session by // default we're ok, since either the distro has enabled Wayland by default, // or the user has gone out of their way to use Wayland. - return !gtk_check_version(3, 24, 30); }(); return isWaylandEnabled; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3a07659… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3a07659… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-2] fixup! Bug 40597: Implement TorSettings module
by Pier Angelo Vendrame (＠pierov) 28 Aug '24

28 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser Commits: 6935ca00 by Henry Wilkes at 2024-08-27T20:38:54+00:00 fixup! Bug 40597: Implement TorSettings module Bug 42622: Send TorConnect "Error" signal before "StateChange". - - - - - 1 changed file: - toolkit/modules/TorConnect.sys.mjs Changes: ===================================== toolkit/modules/TorConnect.sys.mjs ===================================== @@ -686,16 +686,7 @@ class ErrorState extends StateCallback { ErrorState.#hasEverHappened = true; } - run(error) { - if (!(error instanceof TorConnectError)) { - error = new TorConnectError(TorConnectError.ExternalError, error); - } - TorConnect._errorCode = error.code; - TorConnect._errorDetails = error; - lazy.logger.error(`Entering error state (${error.code})`, error); - - Services.obs.notifyObservers(error, TorConnectTopics.Error); - + run(_error) { this.changeState(TorConnectState.Configuring); } @@ -903,6 +894,23 @@ export const TorConnect = { // Set our new state first so that state transitions can themselves // trigger a state transition. this._stateHandler = this._makeState(newState); + + // Error signal needs to be sent out before we enter the Error state. + // Expected on android `onBootstrapError` to set lastKnownError. + // Expected in about:torconnect to set the error codes and internet status + // *before* the StateChange signal. + if (newState === TorConnectState.Error) { + let error = args[0]; + if (!(error instanceof TorConnectError)) { + error = new TorConnectError(TorConnectError.ExternalError, error); + } + TorConnect._errorCode = error.code; + TorConnect._errorDetails = error; + lazy.logger.error(`Entering error state (${error.code})`, error); + + Services.obs.notifyObservers(error, TorConnectTopics.Error); + } + Services.obs.notifyObservers( { state: newState }, TorConnectTopics.StateChange View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 14.0a3
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 234abce0 by Morgan at 2024-08-27T22:44:19+00:00 alpha: new version, 14.0a3 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/13.5a8-14.0a2-linux-i686-ALL.xml - − update_3/alpha/13.5a8-14.0a2-linux-x86_64-ALL.xml - − update_3/alpha/13.5a8-14.0a2-macos-ALL.xml - − update_3/alpha/13.5a8-14.0a2-windows-i686-ALL.xml - − update_3/alpha/13.5a8-14.0a2-windows-x86_64-ALL.xml - − update_3/alpha/13.5a9-14.0a2-linux-i686-ALL.xml - − update_3/alpha/13.5a9-14.0a2-linux-x86_64-ALL.xml - − update_3/alpha/13.5a9-14.0a2-macos-ALL.xml - − update_3/alpha/13.5a9-14.0a2-windows-i686-ALL.xml - − update_3/alpha/13.5a9-14.0a2-windows-x86_64-ALL.xml - + update_3/alpha/13.5a9-14.0a3-linux-i686-ALL.xml - + update_3/alpha/13.5a9-14.0a3-linux-x86_64-ALL.xml - + update_3/alpha/13.5a9-14.0a3-macos-ALL.xml - + update_3/alpha/13.5a9-14.0a3-windows-i686-ALL.xml - + update_3/alpha/13.5a9-14.0a3-windows-x86_64-ALL.xml - − update_3/alpha/14.0a1-14.0a2-linux-i686-ALL.xml - − update_3/alpha/14.0a1-14.0a2-linux-x86_64-ALL.xml - − update_3/alpha/14.0a1-14.0a2-macos-ALL.xml - − update_3/alpha/14.0a1-14.0a2-windows-i686-ALL.xml - − update_3/alpha/14.0a1-14.0a2-windows-x86_64-ALL.xml - + update_3/alpha/14.0a1-14.0a3-linux-i686-ALL.xml - + update_3/alpha/14.0a1-14.0a3-linux-x86_64-ALL.xml - + update_3/alpha/14.0a1-14.0a3-macos-ALL.xml - + update_3/alpha/14.0a1-14.0a3-windows-i686-ALL.xml - + update_3/alpha/14.0a1-14.0a3-windows-x86_64-ALL.xml - + update_3/alpha/14.0a2-14.0a3-linux-i686-ALL.xml - + update_3/alpha/14.0a2-14.0a3-linux-x86_64-ALL.xml - + update_3/alpha/14.0a2-14.0a3-macos-ALL.xml - + update_3/alpha/14.0a2-14.0a3-windows-i686-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 7494: Create local home page for TBB.
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e8eefc25 by Henry Wilkes at 2024-08-27T21:12:40+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42744: Stop using prefersColorSchemeOverride for about:tor. common-shared.css seems to have simplified since the original implementation, so we can simply set the `color-scheme` and `color` on the search form to keep the styling consistent in both light and dark themes. - - - - - 2 changed files: - browser/components/abouttor/AboutTorChild.sys.mjs - browser/components/abouttor/content/aboutTor.css Changes: ===================================== browser/components/abouttor/AboutTorChild.sys.mjs ===================================== @@ -2,19 +2,6 @@ * Actor child class for the about:tor page. */ export class AboutTorChild extends JSWindowActorChild { - actorCreated() { - if (this.contentWindow.matchMedia("not (prefers-contrast)").matches) { - // When prefers-contrast is not set, the page only has one style because - // we always set a dark background and a light <form>. - // We force prefers-color-scheme to be light, regardless of the user's - // settings so that we inherit the "light" theme styling from - // in-content/common.css for the <form> element. In particular, we want - // the light styling for the <input> and <moz-toggle> elements, which are - // on a light background. - this.browsingContext.prefersColorSchemeOverride = "light"; - } - } - handleEvent(event) { switch (event.type) { case "DOMContentLoaded": ===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -180,15 +180,17 @@ body:not(.show-tor-check) #tor-check { body > :not(#search-form) { /* Same as --in-content-page-color when "prefers-color-scheme: dark" */ - --in-content-page-color: #fbfbfe; - --in-content-text-color: #fbfbfe; - color: var(--in-content-text-color); + color: var(--color-gray-05); --link-color: var(--tor-link-color-dark); --link-color-hover: var(--tor-link-color-hover-dark); --link-color-active: var(--tor-link-color-active-dark); } #search-form { + /* Use light color for background and moz-toggle shadow root. */ + color-scheme: light; + /* Same as --in-content-page-color when "prefers-color-scheme: light" */ + color: var(--color-gray-100); border-color: transparent; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e8eefc2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e8eefc2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! Bug 7494: Create local home page for TBB.
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a8d1d771 by Henry Wilkes at 2024-08-27T21:07:58+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 43075: Drop link spacing in about:tor. - - - - - 1 changed file: - browser/components/abouttor/content/aboutTor.css Changes: ===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -89,14 +89,6 @@ body:not(.show-tor-check) #tor-check { margin-inline-end: 0.3em; } -:is( - .home-message, - #tor-check, -) a { - /* Increase gap between the link and the rest of the text. */ - margin-inline: 0.4em; -} - #search-form { grid-area: form; /* Occupy the entire "form" block. */ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a8d1d77… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a8d1d77… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] 3 commits: fixup! Bug 42472: Spoof timezone in XSLT.
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 600fa3e4 by Pier Angelo Vendrame at 2024-08-27T09:53:22+02:00 fixup! Bug 42472: Spoof timezone in XSLT. Revert "Bug 42472: Spoof timezone in XSLT." This reverts commit 7bdf1f4f6cd90346da288435564ca67d1b0e58e5. - - - - - fb25351a by Fatih at 2024-08-27T09:53:53+02:00 Bug 1891690: Return GMT when RFPTarget::JSDateTimeUTC is enabled. r=timhuang Differential Revision: https://phabricator.services.mozilla.com/D216411 - - - - - 365873be by Fatih at 2024-08-27T09:54:19+02:00 Bug 1912129: Reduce time precision for EXSLT date time function. r=timhuang Differential Revision: https://phabricator.services.mozilla.com/D218783 - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser.toml - + browser/components/resistfingerprinting/test/browser/browser_exslt_time_precision.js - + browser/components/resistfingerprinting/test/browser/browser_exslt_timezone_load.js - dom/xslt/xslt/txEXSLTFunctions.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser.toml ===================================== @@ -196,3 +196,7 @@ lineno = "172" ["browser_timezone.js"] lineno = "176" + +["browser_exslt_timezone_load.js"] + +["browser_exslt_time_precision.js"] ===================================== browser/components/resistfingerprinting/test/browser/browser_exslt_time_precision.js ===================================== @@ -0,0 +1,71 @@ +/** + * Bug 1912129 - A test case for verifying EXSLT date will report second-precise + * time fingerprinting resistance is enabled. + */ + +function getTime(tab) { + const extractTime = function () { + const xslText = ` + <xsl:stylesheet version="1.0" + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" + xmlns:date="http://exslt.org/dates-and-times" + extension-element-prefixes="date"> + <xsl:output method="text" /> + <xsl:template match="/"> + <xsl:value-of select="date:date-time()" /> + </xsl:template> + </xsl:stylesheet>`; + + const parser = new DOMParser(); + const xsltProcessor = new XSLTProcessor(); + const xslStylesheet = parser.parseFromString(xslText, "application/xml"); + xsltProcessor.importStylesheet(xslStylesheet); + const xmlDoc = parser.parseFromString("<test />", "application/xml"); + const styledDoc = xsltProcessor.transformToDocument(xmlDoc); + const time = styledDoc.firstChild.textContent; + + return time; + }; + + const extractTimeExpr = `(${extractTime.toString()})();`; + + return SpecialPowers.spawn( + tab.linkedBrowser, + [extractTimeExpr], + async funccode => content.eval(funccode) + ); +} + +add_task(async function test_new_window() { + await SpecialPowers.pushPrefEnv({ + set: [ + ["privacy.fingerprintingProtection", true], + ["privacy.fingerprintingProtection.overrides", "+ReduceTimerPrecision"], + ], + }); + + // Open a tab for extracting the time from XSLT. + const tab = await BrowserTestUtils.openNewForegroundTab({ + gBrowser, + opening: TEST_PATH + "file_dummy.html", + forceNewProcess: true, + }); + + for (let i = 0; i < 10; i++) { + // eslint-disable-next-line mozilla/no-arbitrary-setTimeout + await new Promise(res => setTimeout(res, 25)); + + // The regex could be a lot shorter (e.g. /\.(\d{3})/) but I wrote the whole + // thing to make sure the time is in the expected format and to allow us + // to re-use this regex in the future if we need to. + // Note: Date format is not locale dependent. + const regex = /\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.(\d{3})[-+]\d{2}:\d{2}/; + const time = await getTime(tab); + const [, milliseconds] = time.match(regex); + + is(milliseconds, "000", "Date's precision was reduced to seconds."); + } + + BrowserTestUtils.removeTab(tab); + await SpecialPowers.popPrefEnv(); +}); ===================================== browser/components/resistfingerprinting/test/browser/browser_exslt_timezone_load.js ===================================== @@ -0,0 +1,62 @@ +/** + * Bug 1891690 - A test case for verifying EXSLT date will use Atlantic/Reykjavik + * timezone (GMT and "real" equivalent to UTC) after fingerprinting + * resistance is enabled. + */ + +function getTimeZone(tab) { + const extractTime = function () { + const xslText = ` + <xsl:stylesheet version="1.0" + xmlns:xsl="http://www.w3.org/1999/XSL/Transform" + xmlns:date="http://exslt.org/dates-and-times" + extension-element-prefixes="date"> + <xsl:output method="text" /> + <xsl:template match="/"> + <xsl:value-of select="date:date-time()" /> + </xsl:template> + </xsl:stylesheet>`; + + const parser = new DOMParser(); + const xsltProcessor = new XSLTProcessor(); + const xslStylesheet = parser.parseFromString(xslText, "application/xml"); + xsltProcessor.importStylesheet(xslStylesheet); + const xmlDoc = parser.parseFromString("<test />", "application/xml"); + const styledDoc = xsltProcessor.transformToDocument(xmlDoc); + const time = styledDoc.firstChild.textContent; + + return time; + }; + + const extractTimeExpr = `(${extractTime.toString()})();`; + + return SpecialPowers.spawn( + tab.linkedBrowser, + [extractTimeExpr], + async funccode => content.eval(funccode) + ); +} + +add_task(async function test_new_window() { + await SpecialPowers.pushPrefEnv({ + set: [ + ["privacy.fingerprintingProtection", true], + ["privacy.fingerprintingProtection.overrides", "+JSDateTimeUTC"], + ], + }); + + // Open a tab for extracting the time zone from XSLT. + const tab = await BrowserTestUtils.openNewForegroundTab({ + gBrowser, + opening: TEST_PATH + "file_dummy.html", + forceNewProcess: true, + }); + + SpecialPowers.Cu.getJSTestingFunctions().setTimeZone("America/Toronto"); + const timeZone = await getTimeZone(tab); + + ok(timeZone.endsWith("+00:00"), "Timezone was spoofed."); + + BrowserTestUtils.removeTab(tab); + await SpecialPowers.popPrefEnv(); +}); ===================================== dom/xslt/xslt/txEXSLTFunctions.cpp ===================================== @@ -590,14 +590,22 @@ nsresult txEXSLTFunctionCall::evaluate(txIEvalContext* aContext, // http://exslt.org/date/functions/date-time/ PRExplodedTime prtime; - PR_ExplodeTime(PR_Now(), - nsContentUtils::ShouldResistFingerprinting( - "We are not allowed to access the document at this " - "stage (we are given a txEarlyEvalContext context).", - RFPTarget::JSDateTimeUTC) - ? PR_GMTParameters - : PR_LocalTimeParameters, - &prtime); + Document* sourceDoc = getSourceDocument(aContext); + NS_ENSURE_STATE(sourceDoc); + + PRTimeParamFn timezone = + sourceDoc->ShouldResistFingerprinting(RFPTarget::JSDateTimeUTC) + ? PR_GMTParameters + : PR_LocalTimeParameters; + + PRTime time = + sourceDoc->ShouldResistFingerprinting(RFPTarget::ReduceTimerPrecision) + ? (PRTime)nsRFPService::ReduceTimePrecisionAsSecs( + (double)PR_Now() / PR_USEC_PER_SEC, 0, + RTPCallerType::ResistFingerprinting) * + PR_USEC_PER_SEC + : PR_Now(); + PR_ExplodeTime(time, timezone, &prtime); int32_t offset = (prtime.tm_params.tp_gmt_offset + prtime.tm_params.tp_dst_offset) / @@ -641,7 +649,7 @@ Expr::ResultType txEXSLTFunctionCall::getReturnType() { bool txEXSLTFunctionCall::isSensitiveTo(ContextSensitivity aContext) { if (mType == txEXSLTType::NODE_SET || mType == txEXSLTType::SPLIT || - mType == txEXSLTType::TOKENIZE) { + mType == txEXSLTType::TOKENIZE || mType == txEXSLTType::DATE_TIME) { return (aContext & PRIVATE_CONTEXT) || argsSensitiveTo(aContext); } return argsSensitiveTo(aContext); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/625366… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/625366… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-1] fixup! Bug 40597: Implement TorSettings module
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch tor-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 6935ca00 by Henry Wilkes at 2024-08-27T20:38:54+00:00 fixup! Bug 40597: Implement TorSettings module Bug 42622: Send TorConnect "Error" signal before "StateChange". - - - - - 1 changed file: - toolkit/modules/TorConnect.sys.mjs Changes: ===================================== toolkit/modules/TorConnect.sys.mjs ===================================== @@ -686,16 +686,7 @@ class ErrorState extends StateCallback { ErrorState.#hasEverHappened = true; } - run(error) { - if (!(error instanceof TorConnectError)) { - error = new TorConnectError(TorConnectError.ExternalError, error); - } - TorConnect._errorCode = error.code; - TorConnect._errorDetails = error; - lazy.logger.error(`Entering error state (${error.code})`, error); - - Services.obs.notifyObservers(error, TorConnectTopics.Error); - + run(_error) { this.changeState(TorConnectState.Configuring); } @@ -903,6 +894,23 @@ export const TorConnect = { // Set our new state first so that state transitions can themselves // trigger a state transition. this._stateHandler = this._makeState(newState); + + // Error signal needs to be sent out before we enter the Error state. + // Expected on android `onBootstrapError` to set lastKnownError. + // Expected in about:torconnect to set the error codes and internet status + // *before* the StateChange signal. + if (newState === TorConnectState.Error) { + let error = args[0]; + if (!(error instanceof TorConnectError)) { + error = new TorConnectError(TorConnectError.ExternalError, error); + } + TorConnect._errorCode = error.code; + TorConnect._errorDetails = error; + lazy.logger.error(`Entering error state (${error.code})`, error); + + Services.obs.notifyObservers(error, TorConnectTopics.Error); + } + Services.obs.notifyObservers( { state: newState }, TorConnectTopics.StateChange View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6935ca0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.15.0esr-13.5-2
by Pier Angelo Vendrame (＠pierov) 27 Aug '24

27 Aug '24

Pier Angelo Vendrame pushed new branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag mb-14.0a3-build1
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed new tag mb-14.0a3-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-14.0a3-build1
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed new tag tbb-14.0a3-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41215, 41216: Prepare Tor+Mullvad Browser 14.0a3
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: b159153f by Morgan at 2024-08-26T22:23:20+00:00 Bug 41215,41216: Prepare Tor+Mullvad Browser 14.0a3 - - - - - 7 changed files: - projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/firefox/config - projects/geckoview/config - projects/manual/config - projects/translation/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-MB/ChangeLog.txt ===================================== @@ -1,3 +1,20 @@ +Mullvad Browser 14.0a3 - August 26 2024 + * All Platforms + * Updated Firefox to 128.2.0esr + * Bug 333: Rebase Mullvad Browser Alpha onto 128.2.0esr [mullvad-browser] + * Bug 40056: Ensure that the lazy loading attribute is ignored on script-disabled documents [tor-browser] + * Bug 41817: Add more color aliases that take dark mode into account [tor-browser] + * Bug 42603: Remove safebrowsing URLs [tor-browser] + * Bug 42611: Set clipboard.imageAsFile.enabled to false [tor-browser] + * Bug 42646: Drop patch for tor-browser#40166 [tor-browser] + * Bug 42665: Drop "Learn More" spacing [tor-browser] + * Linux + * Bug 43064: Make copy/paste and drag/drop file filtering more specific [tor-browser] + * Build System + * All Platforms + * Bug 41013: Add a README to each project [tor-browser-build] + * Bug 41222: link_old_mar_filenames still referenced in torbrowser-incrementals-{release,alpha}-unsigned [tor-browser-build] + Mullvad Browser 14.0a2 - August 16 2024 * All Platforms * Updated Firefox to 128.1.0esr ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,42 @@ +Tor Browser 14.0a3 - August 26 2024 + * All Platforms + * Bug 40056: Ensure that the lazy loading attribute is ignored on script-disabled documents [tor-browser] + * Bug 42611: Set clipboard.imageAsFile.enabled to false [tor-browser] + * Bug 42646: Drop patch for tor-browser#40166 [tor-browser] + * Bug 42830: Enable WebAudio APIs [tor-browser] + * Bug 43012: Mixed content: browser requests HTTPS images from onion domain accessed via HTTP [tor-browser] + * Bug 43013: security.mixed_content.upgrade_display_content.image is true by default [tor-browser] + * Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser [tor-browser] + * Bug 43085: Rebase Tor Browser Alpha onto 128.2.0esr [tor-browser] + * Windows + macOS + Linux + * Updated Firefox to 128.2.0esr + * Bug 41811: Primary buttons that result in a connection attempt should be purple [tor-browser] + * Bug 41817: Add more color aliases that take dark mode into account [tor-browser] + * Bug 41820: Downloads warning styling improvements (use moz-message-bar) [tor-browser] + * Bug 42212: Fluent migration: onion services [tor-browser] + * Bug 42603: Remove safebrowsing URLs [tor-browser] + * Bug 42665: Drop "Learn More" spacing [tor-browser] + * Bug 43059: Drag and Drop issue in new update 13.5.2 [tor-browser] + * Bug 43066: about:torconnect no longer changes the title icon on errors [tor-browser] + * Bug 43067: Use html:link rather than xml-stylesheet in our dialogs [tor-browser] + * Bug 43071: Make sure "tor-button" elements that are also "primary" still use the tor colors [tor-browser] + * Bug 43081: Remove hard-coded CSS `line-height` [tor-browser] + * Linux + * Bug 43064: Make copy/paste and drag/drop file filtering more specific [tor-browser] + * Android + * Updated GeckoView to 128.2.0esr + * Bug 42386: Remove unused assets to reduce APK size [tor-browser] + * Bug 42590: “Tor browser” text in top left of home fragment/new tab view gets cut off with larger text sizes [tor-browser] + * Bug 43078: Disable Sharing Links to TBA [tor-browser] + * Bug 41223: Tor Browser Alpha version not displayed correctly [tor-browser-build] + * Build System + * All Platforms + * Bug 41013: Add a README to each project [tor-browser-build] + * Bug 41198: Update release-prep issue template to include notifiying anti-censorship team of package name changes for GetTor distributor [tor-browser-build] + * Bug 41222: link_old_mar_filenames still referenced in torbrowser-incrementals-{release,alpha}-unsigned [tor-browser-build] + * Android + * Bug 42480: Use translation CI in android [tor-browser] + Tor Browser 14.0a2 - August 19 2024 * All Platforms * Updated NoScript to 11.4.34 ===================================== projects/firefox/config ===================================== @@ -14,12 +14,12 @@ container: use_container: 1 var: - firefox_platform_version: '128.1.0' + firefox_platform_version: '128.2.0' firefox_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '14.0' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 6 + browser_build: 2 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' @@ -107,7 +107,7 @@ targets: gitlab_project: https://gitlab.torproject.org/tpo/applications/mullvad-browser updater_url: 'https://cdn.mullvad.net/browser/update_responses/update_1/' nightly_updates_publish_dir_prefix: mullvadbrowser- - browser_build: 2 + browser_build: 1 linux-x86_64: var: ===================================== projects/geckoview/config ===================================== @@ -16,12 +16,12 @@ container: build_apk: 1 var: - firefox_platform_version: '128.1.0' + firefox_platform_version: '128.2.0' geckoview_version: '[% c("var/firefox_platform_version") %]esr' browser_series: '14.0' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 6 + browser_build: 2 copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' gitlab_project: https://gitlab.torproject.org/tpo/applications/tor-browser git_commit: '[% exec("git rev-parse HEAD") %]' ===================================== projects/manual/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 # To update, see doc/how-to-update-the-manual.txt # Remember to update also the package's hash, with the version! -version: 186657 +version: 198022 filename: 'manual-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -23,6 +23,6 @@ input_files: - project: container-image - URL: 'https://build-sources.tbb.torproject.org/manual_[% c("version") %].zip' name: manual - sha256sum: c73bb6c97eebe22947b0e9e076838e3c4994da24f3e6e16b7621831afd2006a8 + sha256sum: 0f93bdcabd678af5446d174674ca690583cff5761cbc978c21efcdd9204755e4 - filename: packagemanual.py name: package_script ===================================== projects/translation/config ===================================== @@ -12,13 +12,13 @@ compress_tar: 'gz' steps: base-browser: base-browser: '[% INCLUDE build %]' - git_hash: b954fa2a14f1617d722fab973dc1f25f6bc32f94 + git_hash: 6bb06dc8fa175965e085678c1a42ed6a9dedd9e2 targets: nightly: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: 1df2c214ef69a0211de3a7fc96b47a6edca1a210 + git_hash: a6f7df79b97c3713bd2deff2068721f2422fe67a targets: nightly: git_hash: 'tor-browser' @@ -32,7 +32,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: f27eda6d10a4585a8402c57548f9228e4927b2fa + git_hash: 0d81dd3a7abf8699e8886d5964883d150f1baa81 compress_tar: 'zst' targets: nightly: ===================================== rbm.conf ===================================== @@ -73,18 +73,18 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '14.0a2' - torbrowser_build: 'build2' + torbrowser_version: '14.0a3' + torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2024/08/19 18:48:21' + browser_release_date: '2024/08/26 22:14:05' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + - 14.0a2 - 14.0a1 - 13.5a9 - - 13.5a8 mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed new tag mullvad-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.2.0esr-14.0-1-build2
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed new tag tor-browser-128.2.0esr-14.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] 22 commits: MB 38: Mullvad Browser configuration
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: b309ab29 by Pier Angelo Vendrame at 2024-08-26T21:28:39+00:00 MB 38: Mullvad Browser configuration - - - - - c3b7ae7c by Pier Angelo Vendrame at 2024-08-26T21:34:41+00:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - c0fc99c4 by Pier Angelo Vendrame at 2024-08-26T21:34:41+00:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - a738ad42 by Pier Angelo Vendrame at 2024-08-26T21:34:42+00:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - 7bb8f6bf by Pier Angelo Vendrame at 2024-08-26T21:34:42+00:00 MB 37: Customization for the about dialog - - - - - 5df8ac93 by Henry Wilkes at 2024-08-26T21:34:43+00:00 MB 39: Add home page about:mullvad-browser - - - - - 89cceb7e by hackademix at 2024-08-26T21:34:43+00:00 MB 97: Remove UI cues to install new extensions. - - - - - 96005838 by hackademix at 2024-08-26T21:34:44+00:00 MB 47: uBlock Origin customization - - - - - fff69e82 by Pier Angelo Vendrame at 2024-08-26T21:34:45+00:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - 00bdaa9c by Pier Angelo Vendrame at 2024-08-26T21:34:45+00:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - cc116146 by Nicolas Vigier at 2024-08-26T21:34:45+00:00 MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - c0a83439 by Pier Angelo Vendrame at 2024-08-26T21:34:46+00:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - f430c111 by Pier Angelo Vendrame at 2024-08-26T21:34:46+00:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - b1be6274 by hackademix at 2024-08-26T21:34:46+00:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - 7548eb40 by Richard Pospesel at 2024-08-26T21:34:47+00:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - 6f15505d by rui hildt at 2024-08-26T21:34:47+00:00 MB 213: Customize the search engines list - - - - - 91fcfa2e by hackademix at 2024-08-26T21:34:48+00:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - ee36a59c by Pier Angelo Vendrame at 2024-08-26T21:34:48+00:00 MB 234: Disable OS spoofing in HTTP User-Agent. This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - c4a1b674 by Pier Angelo Vendrame at 2024-08-26T21:34:49+00:00 MB 80: Enable Mullvad Browser as a default browser - - - - - bacfaa8a by Pier Angelo Vendrame at 2024-08-26T21:34:49+00:00 MB 320: Temporarily disable WebRTC and WDBA on Windows. WebRTC should be re-enabled when tor-browser#42758 is resolved, and and the default browser agent when in general we make this feature work again. - - - - - b8e72cf8 by Pier Angelo Vendrame at 2024-08-26T21:34:49+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 77b48968 by Beatriz Rizental at 2024-08-26T21:34:50+00:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - 30 changed files: - .gitlab/ci/lint.yml - .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/c1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/c1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Disable features and functionality
by morgan (＠morgan) 27 Aug '24

27 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 62536693 by clairehurst at 2024-08-27T01:10:10+00:00 fixup! [android] Disable features and functionality - - - - - 1 changed file: - mobile/android/fenix/app/src/main/AndroidManifest.xml Changes: ===================================== mobile/android/fenix/app/src/main/AndroidManifest.xml ===================================== @@ -224,11 +224,11 @@ <data android:mimeType="application/xhtml+xml" /> </intent-filter> - <intent-filter> - <action android:name="android.intent.action.SEND" /> - <category android:name="android.intent.category.DEFAULT" /> - <data android:mimeType="text/plain" /> - </intent-filter> + + + + + <intent-filter> <action android:name="android.intent.action.SEARCH" /> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6253669… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6253669… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41223: Change the versioning scheme for Android.
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: c20db53c by Pier Angelo Vendrame at 2024-08-26T18:30:18+02:00 Bug 41223: Change the versioning scheme for Android. We change it to $torbrowserVersion ($geckoviewVersion) and remove the channel from it. - - - - - 1 changed file: - projects/geckoview/build_apk Changes: ===================================== projects/geckoview/build_apk ===================================== @@ -78,9 +78,7 @@ done echo 'ext.gleanBuildDate = "0"' >> app/build.gradle variant='[% c("var/variant") %]' -# We put the tor-browser version last to avoid int-parsing errors when consumers of project.versionName -# assume it starts with a major version number, as it does for all Mozilla version names. -version_name="[% c('var/fenix_version') %]-$variant ([% c('var/torbrowser_version') %])" +version_name="[% c('var/torbrowser_version') %] ([% c('var/geckoview_version') %])" gradle $GRADLE_FLAGS -PversionName="$version_name" "assemble$variant" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-115.15.0esr-13.5-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag base-browser-115.15.0esr-13.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.15.0esr-13.5-1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new branch mullvad-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag base-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.2.0esr-14.0-1] 130 commits: Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load...
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 81867153 by Timothy Nikkel at 2024-08-26T21:12:22+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - c5ac1a5f by Jon Coppeard at 2024-08-26T21:12:24+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 9c1466c0 by Arturo Mejia at 2024-08-26T21:12:24+02:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Original Revision: https://phabricator.services.mozilla.com/D216996 Differential Revision: https://phabricator.services.mozilla.com/D217718 - - - - - 326b38a5 by hackademix at 2024-08-26T21:12:25+02:00 fixup! Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Bug 43005: followup, fix backporting conflict. - - - - - 7ced890b by Henry Wilkes at 2024-08-26T21:12:25+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 7b237363 by hackademix at 2024-08-26T21:12:25+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - f9f5c90d by Henry Wilkes at 2024-08-26T21:12:26+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 7000fce3 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 69d98181 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 3d7cf0e4 by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - bea8bfcc by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 9c4d59e2 by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - b6a3022c by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 92d6849a by hackademix at 2024-08-26T21:12:28+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 56c3973e by hackademix at 2024-08-26T21:12:29+02:00 Bug 42835: Create an actor to filter file data transfers - - - - - eb3e3c90 by hackademix at 2024-08-26T21:12:29+02:00 fixup! Bug 42835: Create an actor to filter file data transfers Bug 43064: Make file filtering more specific - - - - - f381d9db by Beatriz Rizental at 2024-08-26T21:12:29+02:00 Bug 42728: Modify ./mach lint to skip unused linters - - - - - 4b0af395 by Gaba at 2024-08-26T21:12:30+02:00 Adding issue and merge request templates - - - - - 6d7c931c by Morgan at 2024-08-26T21:12:30+02:00 fixup! Adding issue and merge request templates add QA issue templates for tor browser desktop and android - - - - - 58787061 by Richard Pospesel at 2024-08-26T21:12:30+02:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 79f1bf40 by Beatriz Rizental at 2024-08-26T21:12:31+02:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 6e97802f by Beatriz Rizental at 2024-08-26T21:12:31+02:00 Add CI for Base Browser - - - - - cd9ef577 by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Bug 42997: Reduce the number of git fetches by fetching during a setup job and passing that initial fetch around as a git bundle to other jobs through the Gitlab artifacts. Further reduce the number of fetches by creating a list of changed files in the setup job and passing that around as well as an artifact. - - - - - c267bf8a by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 848f259f by Pier Angelo Vendrame at 2024-08-26T21:12:32+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 67a2bcb5 by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 70d0346a by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 29320: Replace the gnu target with gnullvm for Rust. - - - - - d8b62e8d by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - a45d24a9 by Pier Angelo Vendrame at 2024-08-26T21:12:34+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - ce7b48bb by Dan Ballard at 2024-08-26T21:12:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - d51aa221 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 50628576 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 94b32f36 by Mike Perry at 2024-08-26T21:12:35+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 2cef1eb7 by Alex Catarineu at 2024-08-26T21:12:36+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - bc4e9049 by Morgan at 2024-08-26T21:12:36+02:00 fixup! Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots - Revert 612d54e8e97017891865db8003826d8688ad5a9b - - - - - d0d68da7 by Georg Koppen at 2024-08-26T21:12:36+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - bf415a82 by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 86c1085d by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - c7124709 by Alex Catarineu at 2024-08-26T21:12:37+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - a0a00486 by Kathy Brade at 2024-08-26T21:12:38+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 0bb8c9d1 by Arthur Edelstein at 2024-08-26T21:12:38+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - edf279fa by Alex Catarineu at 2024-08-26T21:12:40+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - b7d36508 by cypherpunks1 at 2024-08-26T21:12:41+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 9d771026 by Pier Angelo Vendrame at 2024-08-26T21:12:41+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 49915074 by Georg Koppen at 2024-08-26T21:12:42+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - e66875f2 by Alex Catarineu at 2024-08-26T21:12:42+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 5e200391 by cypherpunks1 at 2024-08-26T21:12:42+02:00 Bug 41568: Disable LaterRun - - - - - 9a87dbae by cypherpunks1 at 2024-08-26T21:12:43+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 0c7995af by Pier Angelo Vendrame at 2024-08-26T21:12:43+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - fc809659 by Richard Pospesel at 2024-08-26T21:12:43+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 754cab93 by Richard Pospesel at 2024-08-26T21:12:44+02:00 Bug 42037: Disable about:firefoxview page - - - - - 63b0d2b6 by Mike Perry at 2024-08-26T21:12:44+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - ab3d9eee by Pier Angelo Vendrame at 2024-08-26T21:12:44+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - a2c5db09 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42814: Opt out from Firefox relay by default. - - - - - 64dd51aa by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42792: Explicitly turn off Pocket suggestions in the URL bar - - - - - a64af102 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42810: Explicitly disable address and credit card filling. - - - - - bd13ad68 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42886: Disable trending results. In this way we are consistent with weather and addons. - - - - - 4f6744b3 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - c55ab11c by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 5eca2524 by Morgan at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42604: Remove safe-browsing google prefs - - - - - 6e38aef1 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 3d7617e5 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - a72df0ec by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - a72b7149 by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 9a8da4ec by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - f165a887 by Pier Angelo Vendrame at 2024-08-26T21:12:49+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 2912d408 by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - f2747a92 by Alex Catarineu at 2024-08-26T21:12:50+02:00 Bug 26345: Hide tracking protection UI - - - - - 0bc53aca by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Revert change to hide tracking protection toolbar icon and preferences. - - - - - 62c98d07 by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Re-hide the tracking protections UI. We hide the toolbar button with CSS. We hide the preferences using data-hidden-from-search. - - - - - 40f0a39c by Pier Angelo Vendrame at 2024-08-26T21:12:51+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - c95f4a40 by Alex Catarineu at 2024-08-26T21:12:51+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 63dedfae by Mike Perry at 2024-08-26T21:12:51+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - ee693d0f by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 40d60411 by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox's default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - e5b640ed by Matthew Finkel at 2024-08-26T21:12:52+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 9d804773 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 862cf0a0 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 7308931b by hackademix at 2024-08-26T21:12:53+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - 2df1ea2b by Richard Pospesel at 2024-08-26T21:12:54+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 02a1403b by Henry Wilkes at 2024-08-26T21:12:54+02:00 fixup! Bug 41659: Add canonical color definitions to base-browser Bug 41817: Drop browser-colors.css. - - - - - 8e7161c9 by Pier Angelo Vendrame at 2024-08-26T21:12:55+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 7ae65523 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - fa9a86d7 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - ffe235df by p13dz at 2024-08-26T21:12:58+02:00 Bug 40283: Workaround for the file upload bug - - - - - 942e2690 by Arthur Edelstein at 2024-08-26T21:12:58+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 9c15f42f by Pier Angelo Vendrame at 2024-08-26T21:12:58+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 0e5340b6 by hackademix at 2024-08-26T21:12:59+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ea33fa7e by hackademix at 2024-08-26T21:12:59+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - ee2f0e77 by Pier Angelo Vendrame at 2024-08-26T21:12:59+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 7bdf1f4f by Pier Angelo Vendrame at 2024-08-26T21:13:00+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - e4be9c6d by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - afaf8423 by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 44885e03 by hackademix at 2024-08-26T21:13:01+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 86f677de by hackademix at 2024-08-26T21:13:01+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - ddcb4d9f by hackademix at 2024-08-26T21:13:01+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 3d4036dd by hackademix at 2024-08-26T21:13:02+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - cf1f4f84 by hackademix at 2024-08-26T21:13:02+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 5f065803 by hackademix at 2024-08-26T21:13:03+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - ca48302c by hackademix at 2024-08-26T21:13:03+02:00 Bug 41916: Letterboxing preferences UI - - - - - 1830911f by Henry Wilkes at 2024-08-26T21:13:03+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 916b00d1 by Henry Wilkes at 2024-08-26T21:13:04+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 63408484 by hackademix at 2024-08-26T21:13:04+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 97d244d6 by hackademix at 2024-08-26T21:13:04+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 340ad1dc by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 130e1830 by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 3f6199c2 by Kathy Brade at 2024-08-26T21:13:05+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 44d94c49 by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 42061: Create an alpha update channel. - - - - - f703c271 by Nicolas Vigier at 2024-08-26T21:13:06+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 15a1850f by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - faec135c by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 3106a624 by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 463c197a by Alex Catarineu at 2024-08-26T21:13:07+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - d8fc224b by Matthew Finkel at 2024-08-26T21:13:08+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 3acb44d0 by Henry Wilkes at 2024-08-26T21:13:08+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 590130a2 by hackademix at 2024-08-26T21:13:09+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 4449518c by Pier Angelo Vendrame at 2024-08-26T21:13:09+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 739d6aa0 by Henry Wilkes at 2024-08-26T21:13:09+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42644: Remove redundant separator CSS rules. - - - - - f1394ce2 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - f3e8e4c7 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level="top" attribute. - - - - - e084e430 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42641: Use moz-button-group for panel buttons. Also tweak the "Learn more" link to have block-end padding to ensure its focus outline is visible, and restrict it to align-start so that it does not span the full width. Also switch from `em` to `px` units for the vertical spacing. - - - - - 90011d06 by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - f87dc41f by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - e433bb32 by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 41817: Drop browser-colors.css. - - - - - 500fa48c by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 85bf9ccd by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 Bug 40926: Implemented the New Identity feature - - - - - 40bca4c1 by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42596: Add preferences for log levels. - - - - - b451c170 by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 608f5e2e by Pier Angelo Vendrame at 2024-08-26T21:13:15+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - c1aee63c by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - 30 changed files: - .eslintignore - + .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/helpers.py - + .gitlab/ci/setup.yml - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-addons.js - browser/base/content/browser-context.inc - browser/base/content/browser-init.js - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/ee… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/ee… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-128.2.0esr-14.0-1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.15.0esr-13.5-1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new branch base-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.15.0esr-13.5-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag base-browser-115.15.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.15.0esr-13.5-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag tor-browser-115.15.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-1] 208 commits: Bug 1644383 - add mutexs to avoid data race. r=media-playback-reviewers, padenot
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: a6abc48c by alwu at 2024-08-26T21:04:01+02:00 Bug 1644383 - add mutexs to avoid data race. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D206943 - - - - - 98035029 by Edgar Chen at 2024-08-26T21:04:02+02:00 Bug 1743329 - Handle ESC key to release pointer lock in parent process; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D211621 - - - - - b0ad496c by Edgar Chen at 2024-08-26T21:04:02+02:00 Bug 1743329 - Release pointer lock when xul popup is open; r=smaug,pbz Differential Revision: https://phabricator.services.mozilla.com/D211620 - - - - - f1378560 by Edgar Chen at 2024-08-26T21:04:03+02:00 Bug 1743329 - Use nsMenuPopupFrame in GetVisiblePopups(); r=smaug Differential Revision: https://phabricator.services.mozilla.com/D211619 A further change was needed in nsCaret.cpp, see https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests… - - - - - fefd2928 by Otto Länd at 2024-08-26T21:04:03+02:00 Bug 1743329: apply code formatting via Lando # ignore-this-changeset - - - - - 363b3677 by Pier Angelo Vendrame at 2024-08-26T21:04:03+02:00 Bug 1787790: Normalize system fonts with RFP on. r=emilio System fonts can leak any user customization of system fonts, or user's locale (e.g., en-US and ja Windows have different system fonts). Also, Linux distributions/desktop environments set default fonts in different ways. Customization can be detected either with font metrics, the font allowed list is not enabled or the font is included in it, or with getComputedStyle, that leaks the name of the font that Firefox tries to apply. This patch try to prevent these leaks by using a generic "sans-serif" for all system fonts, except on macOS, where it uses "-apple-system", and on Android, where these fonts always use Roboto. Differential Revision: https://phabricator.services.mozilla.com/D163576 - - - - - f984f75d by Eitan Isaacson at 2024-08-26T21:04:04+02:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - b54a67d9 by Fatih at 2024-08-26T21:04:04+02:00 Bug 1830629: Remove unnecessary checks for pdf.js for RFP. r=tjr resource:// is exempt from RFP, so we no longer need to check pdf.js specifically. Differential Revision: https://phabricator.services.mozilla.com/D209359 - - - - - 0637f118 by Pier Angelo Vendrame at 2024-08-26T21:04:04+02:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 164ab74f by Pier Angelo Vendrame at 2024-08-26T21:04:05+02:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - 1bea9c8c by Emilio Cobos Álvarez at 2024-08-26T21:04:05+02:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - 8077a94b by Pier Angelo Vendrame at 2024-08-26T21:04:05+02:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - 123574f6 by Eden Chuang at 2024-08-26T21:04:06+02:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - a7949831 by edgul at 2024-08-26T21:04:06+02:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - 9de800e8 by Kelsey Gilbert at 2024-08-26T21:04:06+02:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 1398b69d by Edgar Chen at 2024-08-26T21:04:07+02:00 Bug 1828259 - Close XUL popup when entering/exiting fullscreen; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D209355 - - - - - abae6c2b by hackademix at 2024-08-26T21:04:07+02:00 Bug 1835987 - Change RFP-spoofed TZ to Atlantic/Reykjavik. r=tjr Atlantic/Reykjavik stays on UTC during all the year, but it is less likely to be blocked than plan UTC. Differential Revision: https://phabricator.services.mozilla.com/D212131 - - - - - 2f971081 by edgul at 2024-08-26T21:04:07+02:00 Bug 1879952 - Fix test expectations with samesite=lax turned on r=tschuster Differential Revision: https://phabricator.services.mozilla.com/D201639 - - - - - 6856401f by edgul at 2024-08-26T21:04:08+02:00 Bug 1844827 - Added checks for sub-document navigations from cross-site to same-site in third-party checks when setting a cookie. r=cookie-reviewers,valentin,bvandersloot a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D204074 - - - - - 8335d4ac by Ed at 2024-08-26T21:04:08+02:00 Bug 1844827 - Update the cookie test expectations for iframe samesite r=cookie-reviewers,valentin a=RyanVM Depends on D199770 Differential Revision: https://phabricator.services.mozilla.com/D199772 - - - - - 77f29bf8 by Mark Banner at 2024-08-26T21:04:08+02:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - 44764960 by Pier Angelo Vendrame at 2024-08-26T21:04:09+02:00 Bug 1849186 - Add a preference not to expose the content title in the window title. r=Gijs,tabbrowser-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D190496 - - - - - b4956a32 by Bob Owen at 2024-08-26T21:04:09+02:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - e0c5b46a by Malte Juergens at 2024-08-26T21:04:09+02:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - 73df4c55 by Henry Wilkes at 2024-08-26T21:04:10+02:00 Bug 1851618 - Allow removing packaged locales from requestedLocales. r=settings-reviewers,eemeli,Gijs We open up the UI to allow the user to remove locales from their requestedLocales list, except for the default locale. Differential Revision: https://phabricator.services.mozilla.com/D209930 - - - - - 129d8e2d by Andreas Pehrson at 2024-08-26T21:04:10+02:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - 4f1d0b5e by Henry Wilkes at 2024-08-26T21:04:10+02:00 Bug 1858056 - Favor RawConfigParser.read_file instead of deprecated readfp r=saschanaz readfp is deprecated since Python 3.2 Differential Revision: https://phabricator.services.mozilla.com/D190532 - - - - - ac4efc50 by Pier Angelo Vendrame at 2024-08-26T21:04:11+02:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - 52347024 by Kagami Sascha Rosylight at 2024-08-26T21:04:11+02:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - da2ee085 by Nuohan Li at 2024-08-26T21:04:11+02:00 Bug 1871109 - generateHash in Manifest.sys.mjs should use sha256 r=peterv, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D204928 - - - - - ae62ceda by Tom Ritter at 2024-08-26T21:04:12+02:00 Bug 1873526: Refactor the restriction override list from a big if statement to a list r=KrisWright Differential Revision: https://phabricator.services.mozilla.com/D198081 - - - - - 0cf18a7d by Nika Layzell at 2024-08-26T21:04:12+02:00 Bug 1875248 - Check for network error preventing ExternalHelperAppService before DONT_RETARGET, r=smaug This reverts the change from 30cde47f9364e5c7da78fd08fa8ab21737d22399, and instead re-orders the NS_ERROR_FILE_NOT_FOUND check before DONT_RETARGET. Testing suggests that a-download-click-404.html behaviour isn't impacted, and this improves the handling of this edge-case when doing process switching. Differential Revision: https://phabricator.services.mozilla.com/D202007 - - - - - c482ead8 by Pier Angelo Vendrame at 2024-08-26T21:04:12+02:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - e117691b by Pier Angelo Vendrame at 2024-08-26T21:04:12+02:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - d327d7e5 by Julian Descottes at 2024-08-26T21:04:13+02:00 Bug 1880374 - Disable DNS prefetching if document nodePrincipal is systemPrincipal r=valentin Differential Revision: https://phabricator.services.mozilla.com/D210830 - - - - - 10d4ad57 by Pier Angelo Vendrame at 2024-08-26T21:04:13+02:00 Bug 1880988 - Apply spoof English to the default detail summary. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D202203 - - - - - 206c1caf by Edgar Chen at 2024-08-26T21:04:13+02:00 Bug 1883396 - Exit fullscreen when two Escape keyup events occur in a short time; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D209667 - - - - - 4933a6a4 by Tom Ritter at 2024-08-26T21:04:14+02:00 Bug 1885258: Hidden fonts should obey the allow list r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D204571 - - - - - b2217ab2 by Jonathan Kew at 2024-08-26T21:04:14+02:00 Bug 1886598 - Struct with Pointer member may not be memmove-able. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D206633 - - - - - bc47d72a by Jonathan Kew at 2024-08-26T21:04:14+02:00 Bug 1890204 - Ensure font entry's unitsPerEm and font extents are initialized when gfxFont is created. r=gfx-reviewers,lsalzman This means that by the time we potentially call GetFontExtents() when drawing, the extents fields are guaranteed to have been been initialized, and there's no risk of the (read-only) access here racing with setting them in UnitsPerEm(). Differential Revision: https://phabricator.services.mozilla.com/D206920 - - - - - 444ff598 by Kershaw Chang at 2024-08-26T21:04:15+02:00 Bug 1892449 - Set network.http.digest_auth_cnonce_length to 16, a=dmeehan Apparently, setting this value to 64 breaks some sites. We should use the same length as Chrome. Original Revision: https://phabricator.services.mozilla.com/D208103 Differential Revision: https://phabricator.services.mozilla.com/D208119 - - - - - 2b6cbfe0 by cypherpunks1 at 2024-08-26T21:04:15+02:00 Bug 1892052 - Do not persist custom network requests on PBM. r=devtools-reviewers,bomsy,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D207762 - - - - - 36009ffd by Jonathan Kew at 2024-08-26T21:04:15+02:00 Bug 1893891 - Clear mSharedBlobData if blob creation failed. a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D208983 Differential Revision: https://phabricator.services.mozilla.com/D209209 - - - - - 7cbb156d by cypherpunks1 at 2024-08-26T21:04:16+02:00 Bug 1892046 - Add origin attributes to about:reader requests. r=reader-mode-reviewers,cmkm Differential Revision: https://phabricator.services.mozilla.com/D207759 - - - - - 352e22e2 by Timothy Nikkel at 2024-08-26T21:04:16+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - fd835957 by Jan de Mooij at 2024-08-26T21:04:16+02:00 Bug 1900523 - Don't use bailout data for JSJitToWasm frames. r=iain Differential Revision: https://phabricator.services.mozilla.com/D212554 - - - - - 02482bd3 by Jan de Mooij at 2024-08-26T21:04:18+02:00 Bug 1902983 - Don't use bailout data after iterating Wasm frames. a=RyanVM This is similar to bug 1900523, but the fix there was incomplete because the `JSJitToWasm` frame type is only used when we go through the Wasm JIT entry trampoline. Ion can also call Wasm functions directly and in that case the type will be `FrameType::Exit`. Original Revision: https://phabricator.services.mozilla.com/D214098 Differential Revision: https://phabricator.services.mozilla.com/D214375 - - - - - 4417f064 by Jon Coppeard at 2024-08-26T21:04:18+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - fe3376c9 by Henry Wilkes at 2024-08-26T21:04:19+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 8633a878 by hackademix at 2024-08-26T21:04:19+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - b64d2c18 by Henry Wilkes at 2024-08-26T21:04:19+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 09e06ab9 by Marco Simonelli at 2024-08-26T21:04:20+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - e41d376e by Marco Simonelli at 2024-08-26T21:04:20+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 6b24772b by Marco Simonelli at 2024-08-26T21:04:20+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 92bc0239 by Marco Simonelli at 2024-08-26T21:04:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 2ecc082e by Marco Simonelli at 2024-08-26T21:04:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 367198c4 by Marco Simonelli at 2024-08-26T21:04:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 842de6c5 by hackademix at 2024-08-26T21:04:22+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 78798d5f by hackademix at 2024-08-26T21:04:22+02:00 Bug 42835: Create an actor to filter file data transfers - - - - - 0bb2fd23 by hackademix at 2024-08-26T21:04:22+02:00 fixup! Bug 42835: Create an actor to filter file data transfers Bug 43064: Make file filtering more specific - - - - - 1ba3f488 by Gaba at 2024-08-26T21:04:23+02:00 Adding issue and merge request templates - - - - - 8a16305a by Beatriz Rizental at 2024-08-26T21:04:23+02:00 Add CI for Base Browser - - - - - 13571f91 by Pier Angelo Vendrame at 2024-08-26T21:04:23+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - f33ebe07 by Pier Angelo Vendrame at 2024-08-26T21:04:24+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - c674b456 by Pier Angelo Vendrame at 2024-08-26T21:04:24+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 0ee71db5 by Dan Ballard at 2024-08-26T21:04:24+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - fdfaee0d by Matthew Finkel at 2024-08-26T21:04:25+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 2d1c3102 by Matthew Finkel at 2024-08-26T21:04:25+02:00 Bug 28125: Prevent non-Necko network connections - - - - - ad4db7c4 by Mike Perry at 2024-08-26T21:04:25+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 18b4abbe by Alex Catarineu at 2024-08-26T21:04:26+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - a921ded4 by Georg Koppen at 2024-08-26T21:04:26+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - a0b8fdb0 by Kathy Brade at 2024-08-26T21:04:26+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 43731c32 by Kathy Brade at 2024-08-26T21:04:27+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 70ad54ee by Alex Catarineu at 2024-08-26T21:04:27+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 26aae67d by Kathy Brade at 2024-08-26T21:04:27+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 6149c826 by Arthur Edelstein at 2024-08-26T21:04:28+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 8a7e050e by Alex Catarineu at 2024-08-26T21:04:28+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - eeab3a9f by cypherpunks1 at 2024-08-26T21:04:28+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 0ac20862 by Pier Angelo Vendrame at 2024-08-26T21:04:28+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 4bb0500d by Georg Koppen at 2024-08-26T21:04:29+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 4b69ca96 by Alex Catarineu at 2024-08-26T21:04:29+02:00 Bug 28369: Stop shipping pingsender executable - - - - - ebd06e8d by cypherpunks1 at 2024-08-26T21:04:29+02:00 Bug 41568: Disable LaterRun - - - - - 3419c862 by cypherpunks1 at 2024-08-26T21:04:30+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 3d9c0ddb by Pier Angelo Vendrame at 2024-08-26T21:04:30+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 60f567da by Richard Pospesel at 2024-08-26T21:04:30+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 06c40e8e by Richard Pospesel at 2024-08-26T21:04:31+02:00 Bug 42037: Disable about:firefoxview page - - - - - c58ea7f4 by Mike Perry at 2024-08-26T21:04:31+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 311572e2 by Pier Angelo Vendrame at 2024-08-26T21:04:31+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - deb71d09 by Pier Angelo Vendrame at 2024-08-26T21:04:32+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - d6ee0a83 by Alex Catarineu at 2024-08-26T21:04:32+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 23a717aa by Pier Angelo Vendrame at 2024-08-26T21:04:32+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 6dca257e by Alex Catarineu at 2024-08-26T21:04:34+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 51e304e1 by Alex Catarineu at 2024-08-26T21:04:34+02:00 Bug 26345: Hide tracking protection UI - - - - - ec0bfe3b by Pier Angelo Vendrame at 2024-08-26T21:04:35+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - f4d54bfe by Alex Catarineu at 2024-08-26T21:04:35+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 3e856f18 by Mike Perry at 2024-08-26T21:04:35+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 8785e3e1 by Pier Angelo Vendrame at 2024-08-26T21:04:36+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 2f8713c5 by Matthew Finkel at 2024-08-26T21:04:36+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - c40a7c76 by cypherpunks1 at 2024-08-26T21:04:36+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 5154bd18 by cypherpunks1 at 2024-08-26T21:04:37+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 5912a40b by hackademix at 2024-08-26T21:04:37+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - e238ca2d by Richard Pospesel at 2024-08-26T21:04:37+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 2d4bab0d by Pier Angelo Vendrame at 2024-08-26T21:04:38+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - b8189716 by Pier Angelo Vendrame at 2024-08-26T21:04:38+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 54aa3707 by p13dz at 2024-08-26T21:04:38+02:00 Bug 40283: Workaround for the file upload bug - - - - - c622ec79 by Arthur Edelstein at 2024-08-26T21:04:38+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 834d5a40 by Pier Angelo Vendrame at 2024-08-26T21:04:39+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - d78894e8 by hackademix at 2024-08-26T21:04:39+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - d9e845b6 by hackademix at 2024-08-26T21:04:39+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 9a533ca6 by Pier Angelo Vendrame at 2024-08-26T21:04:40+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 05c9ad1a by Pier Angelo Vendrame at 2024-08-26T21:04:40+02:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - fbb79f30 by Pier Angelo Vendrame at 2024-08-26T21:04:40+02:00 Bug 42428: Make RFP spoof the timezone of document.lastModified. - - - - - 4f410b57 by Pier Angelo Vendrame at 2024-08-26T21:04:41+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 03a04201 by hackademix at 2024-08-26T21:04:41+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 93ba4716 by hackademix at 2024-08-26T21:04:41+02:00 Bug 41434: Letterboxing, improve logging. - - - - - d606936a by hackademix at 2024-08-26T21:04:42+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - d45d48ba by hackademix at 2024-08-26T21:04:42+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 84b6d170 by hackademix at 2024-08-26T21:04:42+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 0671fe51 by hackademix at 2024-08-26T21:04:43+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 62591758 by hackademix at 2024-08-26T21:04:43+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - fabcd1e4 by hackademix at 2024-08-26T21:04:43+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - f6d460a0 by hackademix at 2024-08-26T21:04:44+02:00 Bug 41916: Letterboxing preferences UI - - - - - 80e3f0ff by hackademix at 2024-08-26T21:04:44+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - f3a88009 by hackademix at 2024-08-26T21:04:44+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - f46ea7c9 by Henry Wilkes at 2024-08-26T21:04:45+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 847ce32b by Henry Wilkes at 2024-08-26T21:04:45+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - ce9c2c0f by Kathy Brade at 2024-08-26T21:04:45+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 7739e26d by Pier Angelo Vendrame at 2024-08-26T21:04:46+02:00 Bug 42061: Create an alpha update channel. - - - - - 9da4b794 by Nicolas Vigier at 2024-08-26T21:04:46+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 3d677b9f by Pier Angelo Vendrame at 2024-08-26T21:04:46+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - a7fe30fc by Pier Angelo Vendrame at 2024-08-26T21:04:47+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - df743c8e by Pier Angelo Vendrame at 2024-08-26T21:04:47+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 766a9f72 by Alex Catarineu at 2024-08-26T21:04:47+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - cfc0ae91 by Matthew Finkel at 2024-08-26T21:04:47+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 4cbb84f4 by Henry Wilkes at 2024-08-26T21:04:48+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - a024d9c7 by hackademix at 2024-08-26T21:04:48+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - aea6ed3c by Pier Angelo Vendrame at 2024-08-26T21:04:48+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 982f18fa by Pier Angelo Vendrame at 2024-08-26T21:04:50+02:00 Bug 40926: Implemented the New Identity feature - - - - - fdd03fc2 by Henry Wilkes at 2024-08-26T21:04:51+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - c1f57978 by Pier Angelo Vendrame at 2024-08-26T21:04:51+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 353f1fe6 by Henry Wilkes at 2024-08-26T21:04:51+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - 69e1f343 by Henry Wilkes at 2024-08-26T21:04:52+02:00 Bug 42347: Add a notification for dropped OS version support. - - - - - 755de4f3 by Henry Wilkes at 2024-08-26T21:04:52+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - daa40daa by Richard Pospesel at 2024-08-26T21:04:52+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - da96aadd by Beatriz Rizental at 2024-08-26T21:04:53+02:00 Add CI for Tor Browser - - - - - dbfc5f48 by Richard Pospesel at 2024-08-26T21:04:53+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - de8fa427 by Henry Wilkes at 2024-08-26T21:04:53+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - dd54d90d by Kathy Brade at 2024-08-26T21:04:54+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - c612e015 by Alex Catarineu at 2024-08-26T21:04:54+02:00 Add TorStrings module for localization - - - - - 709c5217 by Henry Wilkes at 2024-08-26T21:04:54+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 0f941c5a by Henry Wilkes at 2024-08-26T21:04:54+02:00 Tor Browser localization migration scripts. - - - - - 4845f500 by Henry Wilkes at 2024-08-26T21:04:55+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - df7e6175 by Mike Perry at 2024-08-26T21:04:55+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - a19489f6 by Henry Wilkes at 2024-08-26T21:04:55+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 9a3c15de by hackademix at 2024-08-26T21:04:56+02:00 Bug 41917: Tor brand-specific styles. - - - - - 9a3e975a by Henry Wilkes at 2024-08-26T21:04:56+02:00 Add purple tor version of the loading APNG. - - - - - 02090a41 by sanketh at 2024-08-26T21:04:56+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 1a1c9056 by Mike Perry at 2024-08-26T21:04:57+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 6a4d9848 by Henry Wilkes at 2024-08-26T21:04:57+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 3eb66847 by Pier Angelo Vendrame at 2024-08-26T21:04:57+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 8ae5de0d by Pier Angelo Vendrame at 2024-08-26T21:04:58+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 031dde6c by Pier Angelo Vendrame at 2024-08-26T21:04:58+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - d7fa7524 by Pier Angelo Vendrame at 2024-08-26T21:04:58+02:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - fe3bf778 by Cecylia Bocovich at 2024-08-26T21:04:59+02:00 Lox integration - - - - - 36a75065 by Richard Pospesel at 2024-08-26T21:04:59+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - f200c80e by Arthur Edelstein at 2024-08-26T21:04:59+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 91e5a254 by Henry Wilkes at 2024-08-26T21:05:00+02:00 Bug 41600: Add a tor circuit display panel. - - - - - c6888df4 by Henry Wilkes at 2024-08-26T21:05:00+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42661: Rerun update_emojis.py for the circuit flags. Add missing locales. - - - - - cb6fc874 by Pier Angelo Vendrame at 2024-08-26T21:05:00+02:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - c40baa7e by hackademix at 2024-08-26T21:05:01+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - ff9aa902 by Amogh Pradeep at 2024-08-26T21:05:01+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - bc24391a by Matthew Finkel at 2024-08-26T21:05:01+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 1c9fac0b by Kathy Brade at 2024-08-26T21:05:01+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 78670590 by Pier Angelo Vendrame at 2024-08-26T21:05:02+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - ed2a163a by Richard Pospesel at 2024-08-26T21:05:02+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 62fc3821 by Henry Wilkes at 2024-08-26T21:05:02+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - 46bd2a4a by Henry Wilkes at 2024-08-26T21:05:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42661: Rerun update_emojis.py for the bridge emojis. Add missing locales. - - - - - 37a103c6 by Henry Wilkes at 2024-08-26T21:05:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42691: Allow users to copy built-in addresses. - - - - - d217ae6c by Henry Wilkes at 2024-08-26T21:05:03+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42697: Remove inline-start padding from tor bridge provider list. - - - - - 2bfed827 by Richard Pospesel at 2024-08-26T21:05:04+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - ab5ede0c by Henry Wilkes at 2024-08-26T21:05:04+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 43066: Ensure the about:torconnect title icon changes. - - - - - bf563aa3 by Pier Angelo Vendrame at 2024-08-26T21:05:04+02:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - fc3199d5 by Henry Wilkes at 2024-08-26T21:05:05+02:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 699d7ad8 by Arthur Edelstein at 2024-08-26T21:05:07+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - c5ee3e95 by Pier Angelo Vendrame at 2024-08-26T21:05:07+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 8572aa02 by Kathy Brade at 2024-08-26T21:05:08+02:00 Bug 12647: Support symlinks in the updater. - - - - - 39a712fb by Kathy Brade at 2024-08-26T21:05:08+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - d91f80c0 by Kathy Brade at 2024-08-26T21:05:08+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 0dcfed95 by Georg Koppen at 2024-08-26T21:05:08+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 6a20f15e by Mike Perry at 2024-08-26T21:05:09+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - a798bd2e by Alex Catarineu at 2024-08-26T21:05:09+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - c69b33ff by Henry Wilkes at 2024-08-26T21:05:09+02:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 7a8d69bb by Richard Pospesel at 2024-08-26T21:05:10+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - f6963a3e by Kathy Brade at 2024-08-26T21:05:10+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - a717e284 by Pier Angelo Vendrame at 2024-08-26T21:05:10+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42596: Add preferences for log levels. - - - - - 29dfaf71 by Alex Catarineu at 2024-08-26T21:05:11+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 7c470f61 by Pier Angelo Vendrame at 2024-08-26T21:05:11+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 86c0e867 by Pier Angelo Vendrame at 2024-08-26T21:05:11+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - fbd9553e by Pier Angelo Vendrame at 2024-08-26T21:05:12+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 5c42fd63 by Henry Wilkes at 2024-08-26T21:05:12+02:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 1976ebb6 by Dan Ballard at 2024-08-26T21:05:12+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 82e1b467 by Henry Wilkes at 2024-08-26T21:05:13+02:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42642: Focus the "Got it" button when opening the downloads panel. This should ensure that the alert is read aloud by Orca screen reader. - - - - - 1e16a9e1 by Henry Wilkes at 2024-08-26T21:05:13+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - f0b6fbec by hackademix at 2024-08-26T21:05:13+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 6003dcc0 by Henry Wilkes at 2024-08-26T21:05:14+02:00 Customize moz-toggle for tor-browser. - - - - - fe36b787 by Richard Pospesel at 2024-08-26T21:05:14+02:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 88abe9b8 by Cecylia Bocovich at 2024-08-26T21:05:14+02:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - 7135314c by Henry Wilkes at 2024-08-26T21:05:15+02:00 TEMPORARY: Copy torbrowser_strings.xml to the 13.5 branch. NOTE: Only needed for the `tor-browser` `13.5` branches. Bug 42480: Make sure the torbrowser_strings.xml file is in the 13.5 branch for the tor-browser `update-translations` CI. The file should otherwise remain unused for the 13.5 branch. File was copied from https://gitlab.torproject.org/tpo/translation/-/blob/f27eda6d10a4585a8402c5… - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + README.md - − README.txt - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/046294… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/046294… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Rename as Tor Browser
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 70fad01f by clairehurst at 2024-08-26T20:57:31+00:00 fixup! [android] Rename as Tor Browser - - - - - 8 changed files: - + mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.png - − mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.webp - + mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.png - − mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.webp - + mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.png - − mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.webp - + mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.png - − mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.webp Changes: ===================================== mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.png ===================================== Binary files /dev/null and b/mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.png differ ===================================== mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.webp deleted ===================================== Binary files a/mobile/android/fenix/app/src/beta/res/drawable-hdpi/fenix_search_widget.webp and /dev/null differ ===================================== mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.png ===================================== Binary files /dev/null and b/mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.png differ ===================================== mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.webp deleted ===================================== Binary files a/mobile/android/fenix/app/src/main/res/drawable-hdpi/fenix_search_widget.webp and /dev/null differ ===================================== mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.png ===================================== Binary files /dev/null and b/mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.png differ ===================================== mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.webp deleted ===================================== Binary files a/mobile/android/fenix/app/src/nightly/res/drawable-hdpi/fenix_search_widget.webp and /dev/null differ ===================================== mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.png ===================================== Binary files /dev/null and b/mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.png differ ===================================== mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.webp deleted ===================================== Binary files a/mobile/android/fenix/app/src/release/res/drawable-hdpi/fenix_search_widget.webp and /dev/null differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/70fad01… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/70fad01… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Delete unused media
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 02969727 by clairehurst at 2024-08-26T20:56:19+00:00 fixup! [android] Delete unused media - - - - - 30 changed files: - mobile/android/fenix/app/lint-baseline.xml - mobile/android/fenix/app/onboarding.fml.yaml - − mobile/android/fenix/app/src/debug/ic_launcher-web.webp - − mobile/android/fenix/app/src/main/assets/searchplugins/reddit.xml - − mobile/android/fenix/app/src/main/assets/searchplugins/youtube.xml - − mobile/android/fenix/app/src/main/ic_launcher-web.webp - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/NotificationManager.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserMenuSignIn.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/customtabs/PoweredByNotification.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/PagerIndicator.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicrosurveyCompleted.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/onboarding/view/OnboardingPage.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/onboarding/view/OnboardingScreen.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/onboarding/view/UpgradeOnboarding.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/account/AccountUiView.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/shopping/ui/NoAnalysis.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckContextualOnboarding.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/syncedtabs/SyncedTabsList.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/NotificationBase.kt - − mobile/android/fenix/app/src/main/res/drawable-hdpi/ic_logo_wordmark_normal.webp - − mobile/android/fenix/app/src/main/res/drawable-hdpi/ic_logo_wordmark_private.webp - − mobile/android/fenix/app/src/main/res/drawable-hdpi/shopping_no_analysis.webp The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0296972… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0296972… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Add Tor integration and UI
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 74b910cc by clairehurst at 2024-08-26T20:55:16+00:00 fixup! [android] Add Tor integration and UI - - - - - 2 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt - mobile/android/fenix/app/src/main/res/layout/fragment_home.xml Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -1343,7 +1343,8 @@ class HomeFragment : Fragment(), UserInteractionHandler { else -> ColorStateList.valueOf(color) } - binding.wordmarkText.imageTintList = tintColor +// tor-browser#42590 +// binding.wordmarkText.imageTintList = tintColor binding.privateBrowsingButton.imageTintList = tintColor } ===================================== mobile/android/fenix/app/src/main/res/layout/fragment_home.xml ===================================== @@ -48,10 +48,10 @@ app:layout_collapseParallaxMultiplier=".167"/>  - <LinearLayout + <androidx.constraintlayout.widget.ConstraintLayout android:id="@+id/wordmark" android:layout_width="wrap_content" - android:layout_height="40dp" + android:layout_height="wrap_content" android:layout_marginStart="16dp" android:layout_marginTop="18dp" android:layout_marginBottom="32dp" @@ -65,16 +65,21 @@ <ImageView android:id="@+id/wordmarkLogo" - android:layout_width="wrap_content" - android:layout_height="match_parent" - android:layout_marginEnd="10.dp" + android:layout_width="50dp" + android:layout_height="50dp" android:adjustViewBounds="true" android:contentDescription="@null" app:srcCompat="@mipmap/ic_launcher_foreground" tools:ignore="ImageContrastCheck" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" + app:layout_constraintEnd_toStartOf="@id/app_name" android:scaleX="1.5" android:scaleY="1.5" /> +  + + <TextView + android:id="@+id/app_name" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:clickable="false" + android:focusable="false" + android:fontFamily="Roboto-Medium" + android:gravity="start" + android:importantForAccessibility="no" + android:maxLines="2" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:text="@string/app_name" + android:textColor="#DEFFFFFF" + android:textSize="20sp" + app:layout_constrainedWidth="true" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toEndOf="@id/wordmarkLogo" + app:layout_constraintTop_toTopOf="parent" /> + + </androidx.constraintlayout.widget.ConstraintLayout> </com.google.android.material.appbar.CollapsingToolbarLayout> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/74b910c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/74b910c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag tor-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-128.2.0esr-14.0-1-build1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new tag base-browser-128.2.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-128.2.0esr-14.0-1
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed new branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] 304 commits: Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load...
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 81867153 by Timothy Nikkel at 2024-08-26T21:12:22+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - c5ac1a5f by Jon Coppeard at 2024-08-26T21:12:24+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 9c1466c0 by Arturo Mejia at 2024-08-26T21:12:24+02:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Original Revision: https://phabricator.services.mozilla.com/D216996 Differential Revision: https://phabricator.services.mozilla.com/D217718 - - - - - 326b38a5 by hackademix at 2024-08-26T21:12:25+02:00 fixup! Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Bug 43005: followup, fix backporting conflict. - - - - - 7ced890b by Henry Wilkes at 2024-08-26T21:12:25+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 7b237363 by hackademix at 2024-08-26T21:12:25+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - f9f5c90d by Henry Wilkes at 2024-08-26T21:12:26+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 7000fce3 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 69d98181 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 3d7cf0e4 by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - bea8bfcc by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 9c4d59e2 by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - b6a3022c by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 92d6849a by hackademix at 2024-08-26T21:12:28+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 56c3973e by hackademix at 2024-08-26T21:12:29+02:00 Bug 42835: Create an actor to filter file data transfers - - - - - eb3e3c90 by hackademix at 2024-08-26T21:12:29+02:00 fixup! Bug 42835: Create an actor to filter file data transfers Bug 43064: Make file filtering more specific - - - - - f381d9db by Beatriz Rizental at 2024-08-26T21:12:29+02:00 Bug 42728: Modify ./mach lint to skip unused linters - - - - - 4b0af395 by Gaba at 2024-08-26T21:12:30+02:00 Adding issue and merge request templates - - - - - 6d7c931c by Morgan at 2024-08-26T21:12:30+02:00 fixup! Adding issue and merge request templates add QA issue templates for tor browser desktop and android - - - - - 58787061 by Richard Pospesel at 2024-08-26T21:12:30+02:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 79f1bf40 by Beatriz Rizental at 2024-08-26T21:12:31+02:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 6e97802f by Beatriz Rizental at 2024-08-26T21:12:31+02:00 Add CI for Base Browser - - - - - cd9ef577 by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Bug 42997: Reduce the number of git fetches by fetching during a setup job and passing that initial fetch around as a git bundle to other jobs through the Gitlab artifacts. Further reduce the number of fetches by creating a list of changed files in the setup job and passing that around as well as an artifact. - - - - - c267bf8a by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 848f259f by Pier Angelo Vendrame at 2024-08-26T21:12:32+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 67a2bcb5 by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 70d0346a by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 29320: Replace the gnu target with gnullvm for Rust. - - - - - d8b62e8d by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - a45d24a9 by Pier Angelo Vendrame at 2024-08-26T21:12:34+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - ce7b48bb by Dan Ballard at 2024-08-26T21:12:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - d51aa221 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 50628576 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 94b32f36 by Mike Perry at 2024-08-26T21:12:35+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 2cef1eb7 by Alex Catarineu at 2024-08-26T21:12:36+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - bc4e9049 by Morgan at 2024-08-26T21:12:36+02:00 fixup! Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots - Revert 612d54e8e97017891865db8003826d8688ad5a9b - - - - - d0d68da7 by Georg Koppen at 2024-08-26T21:12:36+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - bf415a82 by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 86c1085d by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - c7124709 by Alex Catarineu at 2024-08-26T21:12:37+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - a0a00486 by Kathy Brade at 2024-08-26T21:12:38+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 0bb8c9d1 by Arthur Edelstein at 2024-08-26T21:12:38+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - edf279fa by Alex Catarineu at 2024-08-26T21:12:40+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - b7d36508 by cypherpunks1 at 2024-08-26T21:12:41+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 9d771026 by Pier Angelo Vendrame at 2024-08-26T21:12:41+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 49915074 by Georg Koppen at 2024-08-26T21:12:42+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - e66875f2 by Alex Catarineu at 2024-08-26T21:12:42+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 5e200391 by cypherpunks1 at 2024-08-26T21:12:42+02:00 Bug 41568: Disable LaterRun - - - - - 9a87dbae by cypherpunks1 at 2024-08-26T21:12:43+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 0c7995af by Pier Angelo Vendrame at 2024-08-26T21:12:43+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - fc809659 by Richard Pospesel at 2024-08-26T21:12:43+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - 754cab93 by Richard Pospesel at 2024-08-26T21:12:44+02:00 Bug 42037: Disable about:firefoxview page - - - - - 63b0d2b6 by Mike Perry at 2024-08-26T21:12:44+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - ab3d9eee by Pier Angelo Vendrame at 2024-08-26T21:12:44+02:00 fixup! Firefox preference overrides. Add some notes about live-reload, discovered while investigating some localization issues. - - - - - a2c5db09 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42814: Opt out from Firefox relay by default. - - - - - 64dd51aa by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42792: Explicitly turn off Pocket suggestions in the URL bar - - - - - a64af102 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides. Bug 42810: Explicitly disable address and credit card filling. - - - - - bd13ad68 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42886: Disable trending results. In this way we are consistent with weather and addons. - - - - - 4f6744b3 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - c55ab11c by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides. Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 5eca2524 by Morgan at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42604: Remove safe-browsing google prefs - - - - - 6e38aef1 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 3d7617e5 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - a72df0ec by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - a72b7149 by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 9a8da4ec by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - f165a887 by Pier Angelo Vendrame at 2024-08-26T21:12:49+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 2912d408 by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - f2747a92 by Alex Catarineu at 2024-08-26T21:12:50+02:00 Bug 26345: Hide tracking protection UI - - - - - 0bc53aca by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Revert change to hide tracking protection toolbar icon and preferences. - - - - - 62c98d07 by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Re-hide the tracking protections UI. We hide the toolbar button with CSS. We hide the preferences using data-hidden-from-search. - - - - - 40f0a39c by Pier Angelo Vendrame at 2024-08-26T21:12:51+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - c95f4a40 by Alex Catarineu at 2024-08-26T21:12:51+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 63dedfae by Mike Perry at 2024-08-26T21:12:51+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - ee693d0f by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 40d60411 by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 fixup! Bug 40309: Avoid using regional OS locales Bug 42349: Change the RFPTarget in the region spoofing. One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox's default behavior when the app and OS languages are the same). When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english. - - - - - e5b640ed by Matthew Finkel at 2024-08-26T21:12:52+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 9d804773 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 862cf0a0 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 7308931b by hackademix at 2024-08-26T21:12:53+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - 2df1ea2b by Richard Pospesel at 2024-08-26T21:12:54+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 02a1403b by Henry Wilkes at 2024-08-26T21:12:54+02:00 fixup! Bug 41659: Add canonical color definitions to base-browser Bug 41817: Drop browser-colors.css. - - - - - 8e7161c9 by Pier Angelo Vendrame at 2024-08-26T21:12:55+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 7ae65523 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 fixup! Base Browser strings This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c. - - - - - fa9a86d7 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - ffe235df by p13dz at 2024-08-26T21:12:58+02:00 Bug 40283: Workaround for the file upload bug - - - - - 942e2690 by Arthur Edelstein at 2024-08-26T21:12:58+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 9c15f42f by Pier Angelo Vendrame at 2024-08-26T21:12:58+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 0e5340b6 by hackademix at 2024-08-26T21:12:59+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ea33fa7e by hackademix at 2024-08-26T21:12:59+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - ee2f0e77 by Pier Angelo Vendrame at 2024-08-26T21:12:59+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 7bdf1f4f by Pier Angelo Vendrame at 2024-08-26T21:13:00+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - e4be9c6d by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - afaf8423 by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 44885e03 by hackademix at 2024-08-26T21:13:01+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 86f677de by hackademix at 2024-08-26T21:13:01+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - ddcb4d9f by hackademix at 2024-08-26T21:13:01+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 3d4036dd by hackademix at 2024-08-26T21:13:02+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - cf1f4f84 by hackademix at 2024-08-26T21:13:02+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - 5f065803 by hackademix at 2024-08-26T21:13:03+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - ca48302c by hackademix at 2024-08-26T21:13:03+02:00 Bug 41916: Letterboxing preferences UI - - - - - 1830911f by Henry Wilkes at 2024-08-26T21:13:03+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 916b00d1 by Henry Wilkes at 2024-08-26T21:13:04+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 63408484 by hackademix at 2024-08-26T21:13:04+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 97d244d6 by hackademix at 2024-08-26T21:13:04+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 340ad1dc by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 130e1830 by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 3f6199c2 by Kathy Brade at 2024-08-26T21:13:05+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 44d94c49 by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 42061: Create an alpha update channel. - - - - - f703c271 by Nicolas Vigier at 2024-08-26T21:13:06+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 15a1850f by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - faec135c by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 3106a624 by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 463c197a by Alex Catarineu at 2024-08-26T21:13:07+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - d8fc224b by Matthew Finkel at 2024-08-26T21:13:08+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 3acb44d0 by Henry Wilkes at 2024-08-26T21:13:08+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 590130a2 by hackademix at 2024-08-26T21:13:09+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 4449518c by Pier Angelo Vendrame at 2024-08-26T21:13:09+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 739d6aa0 by Henry Wilkes at 2024-08-26T21:13:09+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42644: Remove redundant separator CSS rules. - - - - - f1394ce2 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42704: Drop the "badged" attribute from the security level button. - - - - - f3e8e4c7 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42699: Drop level="top" attribute. - - - - - e084e430 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42641: Use moz-button-group for panel buttons. Also tweak the "Learn more" link to have block-end padding to ensure its focus outline is visible, and restrict it to align-start so that it does not span the full width. Also switch from `em` to `px` units for the vertical spacing. - - - - - 90011d06 by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - f87dc41f by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - e433bb32 by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 41817: Drop browser-colors.css. - - - - - 500fa48c by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 85bf9ccd by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 Bug 40926: Implemented the New Identity feature - - - - - 40bca4c1 by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42596: Add preferences for log levels. - - - - - b451c170 by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 608f5e2e by Pier Angelo Vendrame at 2024-08-26T21:13:15+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - c1aee63c by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - f18bfbcb by Pier Angelo Vendrame at 2024-08-26T21:13:16+02:00 Bug 42774: Always hide the third-pary certs UI. - - - - - c4891766 by Beatriz Rizental at 2024-08-26T21:13:16+02:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - ac5dd4e7 by Henry Wilkes at 2024-08-26T21:13:16+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 14208303 by Richard Pospesel at 2024-08-26T21:13:17+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 8cbf9387 by Beatriz Rizental at 2024-08-26T21:13:17+02:00 Add CI for Tor Browser - - - - - 5630f94f by Henry Wilkes at 2024-08-26T21:13:17+02:00 fixup! Add CI for Tor Browser Bug 42759: Remove localization file names that were removed in 13.5. - - - - - 88899871 by Henry Wilkes at 2024-08-26T21:13:18+02:00 fixup! Add CI for Tor Browser Bug 42480: Add android torbrowser_strings.xml to our translation CI. - - - - - 8d3dddbb by Richard Pospesel at 2024-08-26T21:13:18+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 15c4115f by Henry Wilkes at 2024-08-26T21:13:18+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Bug 43014: Add --purgecaches when running the dev build. - - - - - bc68901c by Henry Wilkes at 2024-08-26T21:13:19+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - f23a1c6b by Kathy Brade at 2024-08-26T21:13:19+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 5621ebd5 by Alex Catarineu at 2024-08-26T21:13:20+02:00 Add TorStrings module for localization - - - - - 21e43b74 by Henry Wilkes at 2024-08-26T21:13:20+02:00 fixup! Add TorStrings module for localization Bug 42212: Migrate onion service strings to Fluent. - - - - - 7c5e8a55 by Henry Wilkes at 2024-08-26T21:13:20+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - cef474ac by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 42663: Add tooltip text to the "Connection" category. - - - - - 92a684ba by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 42212: Migrate onion service strings to Fluent. - - - - - 84b89162 by Henry Wilkes at 2024-08-26T21:13:21+02:00 fixup! Tor Browser strings Bug 41820: Use moz-message-bar for the downloads warning. - - - - - 8565c3fc by Henry Wilkes at 2024-08-26T21:13:22+02:00 Tor Browser localization migration scripts. - - - - - e86b6689 by Henry Wilkes at 2024-08-26T21:13:22+02:00 fixup! Tor Browser localization migration scripts. Bug 42212: Migrate onion service strings to Fluent. - - - - - 90df4040 by Henry Wilkes at 2024-08-26T21:13:22+02:00 fixup! Tor Browser localization migration scripts. Bug 41820: Use moz-message-bar for the downloads warning. We add a migration to convert the old string values into the new value. - - - - - cba7d9fb by Henry Wilkes at 2024-08-26T21:13:23+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - 00b24f37 by Mike Perry at 2024-08-26T21:13:23+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 4913b7f1 by Henry Wilkes at 2024-08-26T21:13:23+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 56d1081e by hackademix at 2024-08-26T21:13:24+02:00 Bug 41917: Tor brand-specific styles. - - - - - 04bbb15c by Henry Wilkes at 2024-08-26T21:13:24+02:00 Bug 41817: tor-browser semantic colors. - - - - - aa6c298a by Henry Wilkes at 2024-08-26T21:13:25+02:00 fixup! Bug 41817: tor-browser semantic colors. Bug 43071: Fix focus styling for primary tor-button buttons. Also, add a prefers-contrast and forced-colors variant for the tor colors that use the Firefox design system colors. - - - - - f3440bb5 by Henry Wilkes at 2024-08-26T20:11:26+00:00 fixup! Bug 41817: tor-browser semantic colors. Bug 41811: Use the tor color for .tor-button focus outlines. - - - - - 5b2142c5 by Henry Wilkes at 2024-08-26T20:11:27+00:00 Add purple tor version of the loading APNG. - - - - - 548a34b7 by sanketh at 2024-08-26T20:11:27+00:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 5809082a by Pier Angelo Vendrame at 2024-08-26T20:11:27+00:00 fixup! Bug 40209: Implement Basic Crypto Safety Bug 43001: Ship only a copy of the MIT license, like upstream. See MozBug 1838373. - - - - - 9272de51 by Pier Angelo Vendrame at 2024-08-26T20:11:28+00:00 fixup! Bug 40209: Implement Basic Crypto Safety Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - b348dab2 by Mike Perry at 2024-08-26T20:11:28+00:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - b2bc24ba by Henry Wilkes at 2024-08-26T20:11:28+00:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 3f583eb6 by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - ae7a0847 by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 42596: Add preferences for log levels. Added a comment to start a section where we can put the various default log levels. - - - - - 4e9014aa by Pier Angelo Vendrame at 2024-08-26T20:11:29+00:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - f1ebdb05 by Pier Angelo Vendrame at 2024-08-26T20:11:30+00:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - e5935ccd by Pier Angelo Vendrame at 2024-08-26T20:11:30+00:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42596: Add preferences for log levels. - - - - - 136d6871 by Cecylia Bocovich at 2024-08-26T20:11:30+00:00 Lox integration - - - - - a17d5071 by Pier Angelo Vendrame at 2024-08-26T20:11:31+00:00 fixup! Lox integration Bug 42596: Add preferences for log levels. - - - - - 1aaa1516 by Richard Pospesel at 2024-08-26T20:11:31+00:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 823de020 by Pier Angelo Vendrame at 2024-08-26T20:11:31+00:00 fixup! Bug 40597: Implement TorSettings module Bug 42596: Add preferences for log levels. - - - - - 35580a21 by Arthur Edelstein at 2024-08-26T20:11:32+00:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - a04c7525 by Pier Angelo Vendrame at 2024-08-26T20:11:32+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42596: Add preferences for log levels. - - - - - 07b46f48 by Pier Angelo Vendrame at 2024-08-26T20:11:32+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - df6f4298 by Henry Wilkes at 2024-08-26T20:11:33+00:00 Bug 41600: Add a tor circuit display panel. - - - - - ccc864ec by Henry Wilkes at 2024-08-26T20:11:33+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42488: Remove redundant role="code" from ip address <code> element. After ESR 128, the <code> element has an implicit "code" accessible role. - - - - - c1e3717c by Henry Wilkes at 2024-08-26T20:11:33+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42700: Remove !nodes condition from circuit panel. Also updated comment. - - - - - 8e17c7fd by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42695: Use --arrowpanel variables instead of em units in the tor circuit display. - - - - - c8f563a4 by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42699: Drop level="top" attribute. - - - - - 221432d0 by Henry Wilkes at 2024-08-26T20:11:34+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42661: Rerun update_emojis.py for the circuit flags. Add missing locales. - - - - - 95c50ad1 by Pier Angelo Vendrame at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 42596: Add preferences for log levels. - - - - - c691b56e by Pier Angelo Vendrame at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43074: Pass the browser to TorDomainIsolator.newCircuitForBrowser. - - - - - a94ab28d by Henry Wilkes at 2024-08-26T20:11:35+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43081: Remove line-height. - - - - - e04b4d02 by Pier Angelo Vendrame at 2024-08-26T20:11:36+00:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - a54e7b7e by Pier Angelo Vendrame at 2024-08-26T20:11:36+00:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42596: Add preferences for log levels. - - - - - 85ab1dcf by Morgan at 2024-08-26T20:11:36+00:00 fixup! Bug 42247: Android helpers for the TorProvider - - - - - 402cd6b5 by Pier Angelo Vendrame at 2024-08-26T20:11:37+00:00 fixup! Bug 42247: Android helpers for the TorProvider Bug 42655: Add a backend function for the "New circuit for this site" functionality. - - - - - 19e3b0ed by Morgan at 2024-08-26T20:11:37+00:00 fixup! Bug 42247: Android helpers for the TorProvider add missing (null) GeckoBundle parameter - - - - - fb07bdb1 by hackademix at 2024-08-26T20:11:37+00:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 4475b1b9 by Pier Angelo Vendrame at 2024-08-26T20:11:38+00:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 42596: Add preferences for log levels. - - - - - 8953e733 by Amogh Pradeep at 2024-08-26T20:11:38+00:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - ddad7356 by Matthew Finkel at 2024-08-26T20:11:38+00:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - f17e5a57 by Kathy Brade at 2024-08-26T20:11:39+00:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 7fa4f229 by Pier Angelo Vendrame at 2024-08-26T20:11:39+00:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 76c953cf by Pier Angelo Vendrame at 2024-08-26T20:11:39+00:00 fixup! Bug 40807: Added QRCode.js to toolkit/modules Bug 43001: Ship only a copy of the MIT license, like upstream. See MozBug 1838373. - - - - - fef3a227 by Richard Pospesel at 2024-08-26T20:11:39+00:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 2e9acaf4 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42662: Revert changes to main.inc.xhtml and main.js that remove the firefox connection settings. - - - - - bc684777 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42662: Use data-hidden-from-search to hide the firefox network settings. - - - - - a8c93d76 by Henry Wilkes at 2024-08-26T20:11:40+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - cb143c77 by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42663: Add tooltip text to the "Connection" category. - - - - - bb70711c by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42697: Remove inline-start padding from tor bridge provider list. - - - - - 418a8b04 by Henry Wilkes at 2024-08-26T20:11:41+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42661: Rerun update_emojis.py for the bridge emojis. Add missing locales. - - - - - 78cf42e8 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42691: Allow users to copy built-in addresses. - - - - - 6060b357 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - f99fb356 by Henry Wilkes at 2024-08-26T20:11:42+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42705: Remove line-height rule for bridge settings and tweak spacing to accommodate. - - - - - 914a73df by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 3adddb16 by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42806: Use `lh` unit in tor connection preferences. Bug 42705: Adjust spacing of the Lox update list to account for removal of 1.8 line-height. - - - - - 0b217f21 by Henry Wilkes at 2024-08-26T20:11:43+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43067: Use html:link instead of xml-stylesheet - - - - - 40a7e771 by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41817: Use semantic color names for tor preferences. - - - - - a7548deb by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 134d30fc by Henry Wilkes at 2024-08-26T20:11:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43081: Remove line-height for non-ASCII text. - - - - - 9c45aa56 by Henry Wilkes at 2024-08-26T20:11:45+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41811: Use tor colors for connect buttons in bridge dialogs. - - - - - a995fecd by Richard Pospesel at 2024-08-26T20:11:45+00:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 571f1462 by Henry Wilkes at 2024-08-26T20:11:45+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42713: Use `--text-color-error` instead of `--in-content-error-text-color`. - - - - - 9008d662 by Henry Wilkes at 2024-08-26T20:11:46+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42668: Drop torconnect modification to eslint-plugin-mozilla. - - - - - 891dd32c by Henry Wilkes at 2024-08-26T20:11:46+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41817: Use semantic tor color names for tor buttons. Also, for about:torconnect: + Use dark-mode variant for the buttons colors. + Add purple focus outline to the select element to match the buttons. + Stop applying the "primary" class to the cancel button. + Remove the checkbox styling since the checkbox was replaced with a moz-toggle-button. + Removed the "danger-button" class since it does not sufficiently telegraph a distinguished action, and has no dark-mode variant. + Use warning color from common-shared.css. + Drop --grey-40 for breadcrumb arrows, which did not adjust to theme. - - - - - 6717964d by Henry Wilkes at 2024-08-26T20:11:47+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 43066: Ensure the about:torconnect title icon changes. - - - - - 86da394d by Henry Wilkes at 2024-08-26T20:13:07+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41811: Only use tor outline color for tor-button elements. In particular, a `.primary:not(.tor-button)` element will have the default blue outline. - - - - - e37f4bfc by Pier Angelo Vendrame at 2024-08-26T20:21:04+00:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - 313f74cd by Henry Wilkes at 2024-08-26T20:21:07+00:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - a5993873 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42629: Add "about:tor" to `newTabUrls` instead of checking the scheme and path individually. - - - - - e8c4aad7 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42713: Use `--link-color` rather than `--in-content-link-color`. - - - - - f49b9909 by Henry Wilkes at 2024-08-26T20:21:08+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 41817: Use semantic tor color names in about:tor. - - - - - 5ee19a49 by Henry Wilkes at 2024-08-26T20:21:09+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 43081: Remove line-height. - - - - - b8cef53f by Arthur Edelstein at 2024-08-26T20:21:09+00:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - f4839094 by Pier Angelo Vendrame at 2024-08-26T20:21:09+00:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 23653323 by Kathy Brade at 2024-08-26T20:21:09+00:00 Bug 12647: Support symlinks in the updater. - - - - - 14ac8e5c by Kathy Brade at 2024-08-26T20:21:10+00:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - c6edee2a by Kathy Brade at 2024-08-26T20:21:10+00:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 50d01ac2 by Henry Wilkes at 2024-08-26T20:21:10+00:00 fixup! Bug 16940: After update, load local change notes. Bug 43081: Remove line-height for non-ASCII text. - - - - - c7b780e5 by Georg Koppen at 2024-08-26T20:21:11+00:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 6f3c0d2f by Mike Perry at 2024-08-26T20:21:11+00:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - d03e602c by Alex Catarineu at 2024-08-26T20:21:11+00:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - e0a23f5e by Henry Wilkes at 2024-08-26T20:21:12+00:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 04c504aa by Richard Pospesel at 2024-08-26T20:21:12+00:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 3752362f by Henry Wilkes at 2024-08-26T20:21:12+00:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 42212: Migrate onion service strings to Fluent. - - - - - 6a905f52 by Pier Angelo Vendrame at 2024-08-26T20:21:13+00:00 fixup! Bug 23247: Communicating security expectations for .onion Bug 43013: Mixed content upgrades also .onion domains. - - - - - f99575d2 by Kathy Brade at 2024-08-26T20:21:13+00:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 18dd1ec8 by Pier Angelo Vendrame at 2024-08-26T20:21:13+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42596: Add preferences for log levels. - - - - - 5b678523 by Henry Wilkes at 2024-08-26T20:21:13+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42667: Add the "description-deemphasized" class to our preferences. Also use the "description-width-side-element" class. - - - - - 80a2bc55 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42212: Migrate onion service strings to Fluent. + Use "onion site" instead of "onionsite" or "onion service". + Use sentence case by default. + Changed the prompt accept button from "Done" to "OK", in line with other prompts. + Re-ordered the saved keys dialog introduction text from "Keys for the following onionsite are..." to "The following onion site keys are..." + Use bold text for the prompt title, rather than just the onion site part. + Clear the error message in the saved key dialog whenever the user tries to remove a key (again). + Other small tidies in the touched areas. - - - - - e3a7eca4 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 43067: Use html:link instead of xml-stylesheet - - - - - b60f24b2 by Henry Wilkes at 2024-08-26T20:21:14+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 41817: Drop browser-colors.css. - - - - - 5513f78a by Henry Wilkes at 2024-08-26T20:21:15+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 51b07b1b by Alex Catarineu at 2024-08-26T20:21:15+00:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 7eacca93 by Henry Wilkes at 2024-08-26T20:21:15+00:00 fixup! Bug 21952: Implement Onion-Location - - - - - 7f7ec613 by Pier Angelo Vendrame at 2024-08-26T20:21:16+00:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - d7261a87 by Pier Angelo Vendrame at 2024-08-26T20:21:16+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 42596: Add preferences for log levels. - - - - - 422f343f by Henry Wilkes at 2024-08-26T20:21:16+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 43081: Remove line-height for non-ASCII text. - - - - - c95b2209 by Pier Angelo Vendrame at 2024-08-26T20:21:17+00:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 6b192f0f by Pier Angelo Vendrame at 2024-08-26T20:21:17+00:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 88896d1a by Henry Wilkes at 2024-08-26T20:21:17+00:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - f5c5a085 by Dan Ballard at 2024-08-26T20:21:17+00:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 08782d65 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42643: Match margin for download warning separator. - - - - - 26a9fea9 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42641: Use moz-button-group for panel buttons. - - - - - 518c72a4 by Henry Wilkes at 2024-08-26T20:21:18+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42642: Focus the "Got it" button when opening the downloads panel. This should ensure that the alert is read aloud by Orca screen reader. - - - - - 4f1c6205 by Henry Wilkes at 2024-08-26T20:21:19+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 41820: Convert downloads warning to moz-message-bar. Move the logic to DownloadsTorWarning.sys.mjs so it remains in one place. - - - - - 8a1bc12c by Henry Wilkes at 2024-08-26T20:21:19+00:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 865514c9 by hackademix at 2024-08-26T20:21:19+00:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 8d7768b5 by Henry Wilkes at 2024-08-26T20:21:20+00:00 Customize moz-toggle for tor-browser. - - - - - 693c411b by Henry Wilkes at 2024-08-26T20:21:20+00:00 fixup! Customize moz-toggle for tor-browser. Bug 42612: Reimplement the moz-toggle customization for 128 ESR. - - - - - cc4660c4 by Richard Pospesel at 2024-08-26T20:21:20+00:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 0260feca by Cecylia Bocovich at 2024-08-26T20:21:20+00:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - d2e80371 by Matthew Finkel at 2024-08-26T20:21:21+00:00 Bug 40005: [android] Modify Default toolbar menu - - - - - b5a33a01 by Alex Catarineu at 2024-08-26T20:21:21+00:00 Bug 40007: [android] Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - fb91be63 by Alex Catarineu at 2024-08-26T20:21:21+00:00 Bug 40002: [android] Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 14719e4a by Alex Catarineu at 2024-08-26T20:21:22+00:00 Bug 40009: [android] Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - fd516bf7 by Dan Ballard at 2024-08-26T20:21:22+00:00 fixup! Bug 40009: [android] Change the default search engines Bug 43057: Fix js linting in search/list.json - - - - - d20bf1ad by clairehurst at 2024-08-26T20:21:22+00:00 fixup! Bug 40009: [android] Change the default search engines Bug 43037: Fix the crash when searching with DDG from the toolbar. - - - - - 9f27f380 by Alex Catarineu at 2024-08-26T20:21:22+00:00 [android] Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 70935ff7 by Georg Koppen at 2024-08-26T20:21:23+00:00 Bug 40013: [android] Add option do overwrite timestamp in extension version - - - - - afd3a253 by Alex Catarineu at 2024-08-26T20:21:23+00:00 Bug 40015: [android] Port padlock states for .onion services - - - - - c9a3aa89 by Matthew Finkel at 2024-08-26T20:21:23+00:00 [android] Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - 074f89ab by Matthew Finkel at 2024-08-26T20:21:24+00:00 Bug 40023: [android] Stop PrivateNotificationService - - - - - 8ab13dee by Matthew Finkel at 2024-08-26T20:21:24+00:00 [android] Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - a528694e by Matthew Finkel at 2024-08-26T20:21:24+00:00 [android] Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - 363ad1bd by Matthew Finkel at 2024-08-26T20:21:25+00:00 [android] Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - bc6658fb by clairehurst at 2024-08-26T20:21:25+00:00 fixup! [android] Rename as Tor Browser - - - - - 0b1cfd71 by Georg Koppen at 2024-08-26T20:21:25+00:00 [android] Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 451d0176 by Dan Ballard at 2024-08-26T20:21:26+00:00 fixup! [android] Modify build system remove newline - - - - - d98bd74a by Matthew Finkel at 2024-08-26T20:21:26+00:00 Bug 40185: [android] Use NimbusDisabled - - - - - 60e3d583 by Matthew Finkel at 2024-08-26T20:21:26+00:00 [android] Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - 6f88d76b by Dan Ballard at 2024-08-26T20:21:26+00:00 fixup! [android] Add Tor integration and UI remove unused java deps from TAS - - - - - c4ea568d by Morgan at 2024-08-26T20:21:27+00:00 fixup! [android] Add Tor integration and UI - - - - - 539267c3 by clairehurst at 2024-08-26T20:21:27+00:00 fixup! [android] Add Tor integration and UI - - - - - fbe657a0 by Alex Catarineu at 2024-08-26T20:21:27+00:00 [android] Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - dfe3110e by hackademix at 2024-08-26T20:21:28+00:00 [android] Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 553787a8 by Dan Ballard at 2024-08-26T20:21:28+00:00 [android] Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - a858d74f by Dan Ballard at 2024-08-26T20:21:28+00:00 Bug 41972: [android] Disable mozilla onboarding - - - - - 1a4df9a8 by Dan Ballard at 2024-08-26T20:21:29+00:00 Bug 41878: [android] Add standalone Tor Bootstrap - - - - - 946776bb by Dan Ballard at 2024-08-26T20:21:29+00:00 fixup! Bug 41878: [android] Add standalone Tor Bootstrap comment - - - - - 5802293c by clairehurst at 2024-08-26T20:21:29+00:00 Bug 42089: [android] Remove ability to submit site support requests - - - - - 603c78c4 by clairehurst at 2024-08-26T20:21:30+00:00 [android] fixup! Modify UI/UX and Remove ability to submit site support requests - - - - - fd0c209d by clairehurst at 2024-08-26T20:21:30+00:00 [android] Enable the connect assist experiments on alpha - - - - - a7afc1d7 by Dan Ballard at 2024-08-26T20:21:30+00:00 fixup! [android] Enable the connect assist experiments on alpha re private nav host - - - - - 6aeda309 by hackademix at 2024-08-26T20:21:31+00:00 Bug 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache. - - - - - 48bd69cd by clairehurst at 2024-08-26T20:21:31+00:00 [android] Delete unused media - - - - - 9b5de5cf by clairehurst at 2024-08-26T20:21:31+00:00 Bug 42195: [android] Fix "Whats new URL" - - - - - 114b5aab by clairehurst at 2024-08-26T20:21:32+00:00 [android] Implement Android-native Connection Assist UI - - - - - 81957030 by Morgan at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 58314e43 by clairehurst at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 5177b099 by clairehurst at 2024-08-26T20:21:32+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 6b24b104 by Pier Angelo Vendrame at 2024-08-26T20:21:33+00:00 Bug 42652: [android] Pass the list of supported languages to GeckoView. It will be used to prevent leaks about regional preferences. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/helpers.py - + .gitlab/ci/setup.yml - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - + README.md - − README.txt - + browser/actors/AboutTBUpdateChild.sys.mjs - + browser/actors/AboutTBUpdateParent.sys.mjs - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ee006e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ee006e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! [android] Add Tor integration and UI
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f5220902 by clairehurst at 2024-08-26T19:39:08+00:00 fixup! [android] Add Tor integration and UI - - - - - 1 changed file: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -166,7 +166,7 @@ class TorControllerGV( } set(value) { getTorSettings()?.let { - Log.i(TAG, "setUserProvidedBridges: '$value'"); + Log.i(TAG, "setUserProvidedBridges: '$value'") // Hack: we don't have validation so lets do something quick and dirty (each line has a length) val userProvidedLines: Array<String> = value?.split("\n")?.filter { it.length > 4 }?.toTypedArray() ?: arrayOf<String>() it.bridgesSource = BridgeSource.UserProvided @@ -353,7 +353,6 @@ class TorControllerGV( // TorEventsBootstrapStateChangeListener override fun onBootstrapError(code: String?, message: String?, phase: String?, reason: String?) { lastKnownError = TorError(code ?: "", message ?: "", phase ?: "", reason ?: "") - onBootstrapStateChange(TorConnectState.Error.state) } // TorEventsBootstrapStateChangeListener View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f522090… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f522090… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 3 commits: fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5c04abb6 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 41811: Use tor colors for connect buttons in bridge dialogs. - - - - - 93ecfbc3 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41811: Only use tor outline color for tor-button elements. In particular, a `.primary:not(.tor-button)` element will have the default blue outline. - - - - - 8cfb49a3 by Henry Wilkes at 2024-08-26T19:28:11+00:00 fixup! Bug 41817: tor-browser semantic colors. Bug 41811: Use the tor color for .tor-button focus outlines. - - - - - 9 changed files: - browser/components/torpreferences/content/builtinBridgeDialog.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/requestBridgeDialog.js - browser/themes/shared/tor-urlbar-button.css - toolkit/components/torconnect/content/aboutTorConnect.css - toolkit/components/torconnect/content/aboutTorConnect.html - toolkit/components/torconnect/content/aboutTorConnect.js - toolkit/themes/shared/tor-colors.css Changes: ===================================== browser/components/torpreferences/content/builtinBridgeDialog.js ===================================== @@ -70,6 +70,13 @@ const gBuiltinBridgeDialog = { this._result.accepted = true; }); + // Add styling for tor-button to the dialog shadow root. + const styleLink = document.createElement("link"); + styleLink.rel = "stylesheet"; + styleLink.href = + "chrome://browser/content/torpreferences/torPreferences.css"; + dialog.shadowRoot.append(styleLink); + this._acceptButton = dialog.getButton("accept"); Services.obs.addObserver(this, TorConnectTopics.StateChange); @@ -95,6 +102,7 @@ const gBuiltinBridgeDialog = { "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-accept" ); + this._acceptButton.classList.toggle("tor-button", connect); }, observe(subject, topic) { ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -133,7 +133,7 @@ </menulist> <button id="torPreferences-bridges-buttonChooseBridgeForMe" - class="primary" + class="primary tor-button" /> </hbox> <html:moz-toggle ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -85,7 +85,7 @@ const gProvideBridgeDialog = { this._acceptButton = this._dialog.getButton("accept"); // Inject our stylesheet into the shadow root so that the accept button can - // take the spoof-button-disabled styling. + // take the spoof-button-disabled styling and tor-button styling. const styleLink = document.createElement("link"); styleLink.rel = "stylesheet"; styleLink.href = @@ -183,22 +183,21 @@ const gProvideBridgeDialog = { * Callback for whenever the accept button may need to change. */ onAcceptStateChange() { + let connect = false; if (this._page === "entry") { - document.l10n.setAttributes( - this._acceptButton, + this._acceptButton.setAttribute( + "data-l10n-id", "user-provide-bridge-dialog-next-button" ); - this._result.connect = false; } else { - this._acceptButton.removeAttribute("data-l10n-id"); - const connect = TorConnect.canBeginBootstrap; - this._result.connect = connect; - + connect = TorConnect.canBeginBootstrap; this._acceptButton.setAttribute( "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-accept" ); } + this._result.connect = connect; + this._acceptButton.classList.toggle("tor-button", connect); }, /** ===================================== browser/components/torpreferences/content/requestBridgeDialog.js ===================================== @@ -33,6 +33,13 @@ const gRequestBridgeDialog = { "torPreferences-requestBridge-dialog" ); + // Add styling for tor-button to the dialog shadow root. + const styleLink = document.createElement("link"); + styleLink.rel = "stylesheet"; + styleLink.href = + "chrome://browser/content/torpreferences/torPreferences.css"; + this._dialog.shadowRoot.append(styleLink); + // user may have opened a Request Bridge dialog in another tab, so update the // CAPTCHA image or close out the dialog if we have a bridge list this._dialog.addEventListener("focusin", () => { @@ -101,6 +108,7 @@ const gRequestBridgeDialog = { "data-l10n-id", connect ? "bridge-dialog-button-connect" : "bridge-dialog-button-submit" ); + this._submitButton.classList.toggle("tor-button", connect); }, observe(subject, topic) { ===================================== browser/themes/shared/tor-urlbar-button.css ===================================== @@ -26,7 +26,6 @@ * urlbar background, but we keep the rounded corners. */ outline: var(--focus-outline); outline-offset: var(--focus-outline-offset); - outline-color: var(--tor-focus-outline-color); /* Calculate the difference between the button's border area and the outline * area. */ --tor-urlbar-focus-outline-difference: calc( ===================================== toolkit/components/torconnect/content/aboutTorConnect.css ===================================== @@ -116,10 +116,6 @@ html { list-style-image: url("chrome://global/content/torconnect/bridge.svg"); } -button, select { - --in-content-focus-outline-color: var(--tor-focus-outline-color); -} - #locationDropdownLabel { margin-block: auto; margin-inline: 4px; ===================================== toolkit/components/torconnect/content/aboutTorConnect.html ===================================== @@ -75,8 +75,16 @@ <button id="restartButton" hidden="true"></button> <button id="configureButton" hidden="true"></button> <button id="cancelButton" hidden="true"></button> - <button id="connectButton" hidden="true"></button> - <button id="tryBridgeButton" hidden="true"></button> + <button + id="connectButton" + hidden="true" + class="tor-button" + ></button> + <button + id="tryBridgeButton" + hidden="true" + class="tor-button" + ></button> </span> </div> </div> ===================================== toolkit/components/torconnect/content/aboutTorConnect.js ===================================== @@ -190,7 +190,6 @@ class AboutTorConnect { show(element, primary = false) { element.classList.toggle("primary", primary); - element.classList.toggle("tor-button", primary); element.removeAttribute("hidden"); } ===================================== toolkit/themes/shared/tor-colors.css ===================================== @@ -1,3 +1,5 @@ +@namespace xul "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"; + :root { /* Photon colors not available in Firefox. */ --purple-30: #c069ff; @@ -126,19 +128,34 @@ /* Has a higher specificity than `button` and `button.primary`. */ button.tor-button:is(*, .primary), +xul|button.tor-button:is(*, [default]), .tor-button { color: var(--tor-button-text-color); background-color: var(--tor-button-background-color); } -button.tor-button:is(*, .primary):hover, -.tor-button:hover { +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):not([disabled]):hover { color: var(--tor-button-text-color-hover); background-color: var(--tor-button-background-color-hover); } -button.tor-button:is(*, .primary):hover:active, -.tor-button:hover:active { +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):not([disabled]):hover:active { color: var(--tor-button-text-color-active); background-color: var(--tor-button-background-color-active); } + +:is( + button.tor-button:is(*, .primary), + xul|button.tor-button:is(*, [default]), + .tor-button +):focus-visible { + outline-color: var(--tor-focus-outline-color); +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d9faa5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d9faa5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.2.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.15.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new branch tor-browser-115.15.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_115_15_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_15_0esr_BUILD1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_15_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_115_15_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag FIREFOX_128_2_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_128_2_0esr_BUILD1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/FIREF… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_128_2_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed new tag FIREFOX_128_2_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.14.0esr-13.5-1] fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-115.14.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 7bf4c6c9 by Henry Wilkes at 2024-08-26T17:23:23+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 43066: Ensure the about:torconnect title icon changes. - - - - - 1 changed file: - toolkit/components/torconnect/content/aboutTorConnect.css Changes: ===================================== toolkit/components/torconnect/content/aboutTorConnect.css ===================================== @@ -342,15 +342,15 @@ body.aboutTorConnect .title { padding-block-start: 0; } -.title.offline { +body.aboutTorConnect .title.offline { background-image: url("chrome://global/content/torconnect/connection-failure.svg"); } -.title.assist, .title.final { +body.aboutTorConnect .title:is(.assist, .final) { background-image: url("chrome://global/content/torconnect/tor-connect-broken.svg"); } -.title.location { +body.aboutTorConnect .title.location { background-image: url("chrome://global/content/torconnect/connection-location.svg"); stroke: var(--warning-color); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7bf4c6c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7bf4c6c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 5 commits: fixup! Bug 16940: After update, load local change notes.
by morgan (＠morgan) 26 Aug '24

26 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: fa8b538b by Henry Wilkes at 2024-08-26T15:20:44+01:00 fixup! Bug 16940: After update, load local change notes. Bug 43081: Remove line-height for non-ASCII text. - - - - - 157546b7 by Henry Wilkes at 2024-08-26T15:21:29+01:00 fixup! Bug 7494: Create local home page for TBB. Bug 43081: Remove line-height. - - - - - 6e3fb7df by Henry Wilkes at 2024-08-26T15:22:56+01:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 43081: Remove line-height for non-ASCII text. - - - - - 60fc8a13 by Henry Wilkes at 2024-08-26T15:23:05+01:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43081: Remove line-height. - - - - - d9faa5a2 by Henry Wilkes at 2024-08-26T15:23:06+01:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43081: Remove line-height for non-ASCII text. - - - - - 6 changed files: - browser/base/content/abouttbupdate/aboutTBUpdate.css - browser/base/content/abouttbupdate/aboutTBUpdate.js - browser/components/abouttor/content/aboutTor.css - browser/components/rulesets/content/aboutRulesets.css - browser/components/torcircuit/content/torCircuitPanel.css - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/base/content/abouttbupdate/aboutTBUpdate.css ===================================== @@ -32,6 +32,9 @@ body > *:not([hidden]) { .content { grid-column: 2; +} + +.content.en-US-content { font-family: monospace; line-height: 1.4; } ===================================== browser/base/content/abouttbupdate/aboutTBUpdate.js ===================================== @@ -77,6 +77,7 @@ function setContent(containerId, content, fillContent) { // Release notes are only in English. contentEl.setAttribute("lang", "en-US"); contentEl.setAttribute("dir", "ltr"); + contentEl.classList.add("en-US-content"); if (fillContent) { fillContent(contentEl, content); } else { ===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -35,7 +35,6 @@ h1 { align-items: center; gap: 16px; font-size: 40px; - line-height: 1.3; /* Used when wrapping. */ margin-block-start: 0; margin-block-end: 40px; margin-inline: 20px; @@ -79,8 +78,6 @@ body:not(.show-tor-check) #tor-check { .home-message { grid-area: message; font-weight: 400; - /* line-height and text-align are used when wrapping. */ - line-height: 1.5; text-align: center; margin-block-start: 1.6em; margin-block-end: 1em; ===================================== browser/components/rulesets/content/aboutRulesets.css ===================================== @@ -52,7 +52,6 @@ dd { padding: 0; max-width: 600px; box-sizing: border-box; - line-height: 1.4; } hr { @@ -140,10 +139,10 @@ section { padding-inline-start: 35px; font-size: 20px; font-weight: 700; - line-height: 30px; background-image: url("chrome://browser/content/rulesets/securedrop.svg"); - background-position: 0 4px; + background-position: 0 center; background-size: 22px; + min-height: 22px; background-repeat: no-repeat; } @@ -256,6 +255,8 @@ aside { background-color: var(--in-content-box-background); font-size: 85%; line-break: anywhere; + /* ASCII-only text, so can set line-height. */ + line-height: 1.4; } #ruleset-edit { ===================================== browser/components/torcircuit/content/torCircuitPanel.css ===================================== @@ -95,7 +95,6 @@ } #tor-circuit-node-list { - line-height: 2; list-style: none; padding-inline-start: var(--arrowpanel-menuitem-margin-inline); /* Do not allow an item to wrap since this would break the circuit diagram. */ @@ -104,11 +103,12 @@ .tor-circuit-node-item { /* We want the "bullets" of the list to act as the circuit diagram, and we - * also want them to be vertically aligned and scaled to the line-height of - * the list so that the different parts visually connect. + * also want them to be vertically aligned and scaled to the height of the + * list item so that the different parts visually connect. * Using list-style-image does not give us enough control over sizing the * image. So instead we use a background-image. */ padding-inline-start: 1.5em; + padding-block: 6px; background-image: url("chrome://browser/content/tor-circuit-node-middle.svg"); -moz-context-properties: fill; /* Light Gray 50 */ ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -510,7 +510,6 @@ button.spoof-button-disabled { margin: 0; /* Match the QR height if it is higher than ours. */ min-height: auto; - line-height: 1; align-self: stretch; } @@ -694,7 +693,6 @@ button.spoof-button-disabled { .tor-bridges-lox-button { grid-area: button; margin: 0; - line-height: 1; align-self: center; } @@ -781,7 +779,6 @@ button.spoof-button-disabled { #tor-bridges-open-request-dialog-button { margin: 0; - line-height: 1; } #torPreferences-bridges-location { @@ -1021,6 +1018,7 @@ groupbox#torPreferences-bridges-group textarea { #user-provide-bridge-textarea { flex: 1 0 auto; align-self: stretch; + /* Only expect ASCII input, so can set a line-height. */ line-height: 1.3; margin: 0; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a0b692… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/a0b692… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41222: Remove the remaining references to link_old_mar_filenames.
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: d847a58c by Pier Angelo Vendrame at 2024-08-26T16:28:57+02:00 Bug 41222: Remove the remaining references to link_old_mar_filenames. This script was removed a while ago, but it was still referenced in some Makefile targets. - - - - - 1 changed file: - Makefile Changes: ===================================== Makefile ===================================== @@ -188,7 +188,6 @@ torbrowser-incrementals-release: submodule-update torbrowser-incrementals-release-unsigned: submodule-update $(rbm) build release --step update_responses_config --target release --target unsigned_releases_dir --target torbrowser - $(rbm) build release --step link_old_mar_filenames --target release --target unsigned_releases_dir --target torbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals release $(rbm) build release --step hash_incrementals --target release --target torbrowser @@ -200,7 +199,6 @@ torbrowser-incrementals-alpha: submodule-update torbrowser-incrementals-alpha-unsigned: submodule-update $(rbm) build release --step update_responses_config --target alpha --target unsigned_releases_dir --target torbrowser - $(rbm) build release --step link_old_mar_filenames --target alpha --target unsigned_releases_dir --target torbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals alpha $(rbm) build release --step hash_incrementals --target alpha --target torbrowser @@ -528,7 +526,6 @@ mullvadbrowser-incrementals-release: submodule-update mullvadbrowser-incrementals-release-unsigned: submodule-update $(rbm) build release --step update_responses_config --target release --target unsigned_releases_dir --target mullvadbrowser - $(rbm) build release --step link_old_mar_filenames --target release --target unsigned_releases_dir --target mullvadbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals release $(rbm) build release --step hash_incrementals --target release --target mullvadbrowser @@ -540,7 +537,6 @@ mullvadbrowser-incrementals-alpha: submodule-update mullvadbrowser-incrementals-alpha-unsigned: submodule-update $(rbm) build release --step update_responses_config --target alpha --target unsigned_releases_dir --target mullvadbrowser - $(rbm) build release --step link_old_mar_filenames --target alpha --target unsigned_releases_dir --target mullvadbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals alpha $(rbm) build release --step hash_incrementals --target alpha --target torbrowser View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41222: Remove the remaining references to link_old_mar_filenames.
by Pier Angelo Vendrame (＠pierov) 26 Aug '24

26 Aug '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 07980a2a by Pier Angelo Vendrame at 2024-08-26T16:27:16+02:00 Bug 41222: Remove the remaining references to link_old_mar_filenames. This script was removed a while ago, but it was still referenced in some Makefile targets. - - - - - 1 changed file: - Makefile Changes: ===================================== Makefile ===================================== @@ -188,7 +188,6 @@ torbrowser-incrementals-release: submodule-update torbrowser-incrementals-release-unsigned: submodule-update $(rbm) build release --step update_responses_config --target release --target unsigned_releases_dir --target torbrowser - $(rbm) build release --step link_old_mar_filenames --target release --target unsigned_releases_dir --target torbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals release $(rbm) build release --step hash_incrementals --target release --target torbrowser @@ -200,7 +199,6 @@ torbrowser-incrementals-alpha: submodule-update torbrowser-incrementals-alpha-unsigned: submodule-update $(rbm) build release --step update_responses_config --target alpha --target unsigned_releases_dir --target torbrowser - $(rbm) build release --step link_old_mar_filenames --target alpha --target unsigned_releases_dir --target torbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals alpha $(rbm) build release --step hash_incrementals --target alpha --target torbrowser @@ -528,7 +526,6 @@ mullvadbrowser-incrementals-release: submodule-update mullvadbrowser-incrementals-release-unsigned: submodule-update $(rbm) build release --step update_responses_config --target release --target unsigned_releases_dir --target mullvadbrowser - $(rbm) build release --step link_old_mar_filenames --target release --target unsigned_releases_dir --target mullvadbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals release $(rbm) build release --step hash_incrementals --target release --target mullvadbrowser @@ -540,7 +537,6 @@ mullvadbrowser-incrementals-alpha: submodule-update mullvadbrowser-incrementals-alpha-unsigned: submodule-update $(rbm) build release --step update_responses_config --target alpha --target unsigned_releases_dir --target mullvadbrowser - $(rbm) build release --step link_old_mar_filenames --target alpha --target unsigned_releases_dir --target mullvadbrowser NO_CODESIGNATURE=1 tools/update-responses/gen_incrementals alpha $(rbm) build release --step hash_incrementals --target alpha --target torbrowser View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 42247: Android helpers for the TorProvider
by morgan (＠morgan) 24 Aug '24

24 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a0b6927c by Morgan at 2024-08-23T19:26:28+00:00 fixup! Bug 42247: Android helpers for the TorProvider add missing (null) GeckoBundle parameter - - - - - 1 changed file: - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java Changes: ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java ===================================== @@ -2615,7 +2615,7 @@ public class GeckoSession { */ @UiThread public void newTorCircuit() { - mEventDispatcher.dispatch("GeckoView:NewTorCircuit"); + mEventDispatcher.dispatch("GeckoView:NewTorCircuit", null); } /** View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a0b6927… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a0b6927… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41221: Remove the nacl tag from conjure.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 42573003 by Pier Angelo Vendrame at 2024-08-22T23:17:31+00:00 Bug 41221: Remove the nacl tag from conjure. This tag does not work on Windows. - - - - - 1 changed file: - projects/conjure/build Changes: ===================================== projects/conjure/build ===================================== @@ -18,7 +18,7 @@ cd /var/tmp/build/[% project %]-[% c('version') %] tar -xf $rootdir/[% c('input_files_by_name/go_vendor') %] cd client -go build -ldflags '-s' -tags 'protoreflect,nacl' +go build -ldflags '-s' -tags 'protoreflect' cp -a client[% IF c("var/windows") %].exe[% END %] $distdir/conjure-client[% IF c("var/windows") %].exe[% END %] cd .. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 9e98eaa8 by Pier Angelo Vendrame at 2024-08-22T22:14:58+00:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -377,7 +377,7 @@ pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 -pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API +pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API // tor-browser#42043: Stop reporting device IDs (and spoof their number without // RFP, RFP already reports 1 audioinput and 1 videoinput, but still has // randomized IDs when this pref is true). View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/9e9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/9e9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: c6ae235e by Pier Angelo Vendrame at 2024-08-22T22:13:20+00:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -377,8 +377,7 @@ pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 -pref("dom.webaudio.enabled", false); // Bug 13017: Disable Web Audio API -pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API +pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API // tor-browser#42043: Stop reporting device IDs (and spoof their number without // RFP, RFP already reports 1 audioinput and 1 videoinput, but still has // randomized IDs when this pref is true). View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c6ae235… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c6ae235… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ad278a4 by Pier Angelo Vendrame at 2024-08-22T22:10:52+00:00 fixup! Firefox preference overrides. Bug 42830: Enable Web Audio API. We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -377,8 +377,7 @@ pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 -pref("dom.webaudio.enabled", false); // Bug 13017: Disable Web Audio API -pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API +pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API // tor-browser#42043: Stop reporting device IDs (and spoof their number without // RFP, RFP already reports 1 audioinput and 1 videoinput, but still has // randomized IDs when this pref is true). View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ad278a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ad278a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 3dd4deb5 by Pier Angelo Vendrame at 2024-08-22T22:07:24+00:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -100,6 +100,11 @@ pref("browser.pagethumbnails.capturing_disabled", true); // Empty clipboard content from private windows on exit (tor-browser#42154) pref("browser.privatebrowsing.preserveClipboard", false); +// tor-browser#42611: Do not include the URL of the image, when copying it. +// Also, do not save clipboard in history/cloud. +pref("clipboard.imageAsFile.enabled", false); +pref("clipboard.copyPrivateDataToClipboardCloudOrHistory", false); + // Enable HTTPS-Only mode (tor-browser#19850) pref("dom.security.https_only_mode", true); // The previous pref automatically sets this to true (see StaticPrefList.yaml), View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: bc758fe5 by Pier Angelo Vendrame at 2024-08-22T22:06:34+00:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -100,6 +100,11 @@ pref("browser.pagethumbnails.capturing_disabled", true); // Empty clipboard content from private windows on exit (tor-browser#42154) pref("browser.privatebrowsing.preserveClipboard", false); +// tor-browser#42611: Do not include the URL of the image, when copying it. +// Also, do not save clipboard in history/cloud. +pref("clipboard.imageAsFile.enabled", false); +pref("clipboard.copyPrivateDataToClipboardCloudOrHistory", false); + // Enable HTTPS-Only mode (tor-browser#19850) pref("dom.security.https_only_mode", true); // The previous pref automatically sets this to true (see StaticPrefList.yaml), View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bc758fe… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bc758fe… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 8d480877 by Pier Angelo Vendrame at 2024-08-22T21:44:14+00:00 fixup! Firefox preference overrides. Bug 42611: Set clipboard.imageAsFile.enabled to false In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -100,6 +100,11 @@ pref("browser.pagethumbnails.capturing_disabled", true); // Empty clipboard content from private windows on exit (tor-browser#42154) pref("browser.privatebrowsing.preserveClipboard", false); +// tor-browser#42611: Do not include the URL of the image, when copying it. +// Also, do not save clipboard in history/cloud. +pref("clipboard.imageAsFile.enabled", false); +pref("clipboard.copyPrivateDataToClipboardCloudOrHistory", false); + // Enable HTTPS-Only mode (tor-browser#19850) pref("dom.security.https_only_mode", true); // The previous pref automatically sets this to true (see StaticPrefList.yaml), View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d48087… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d48087… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 41916: Letterboxing preferences UI
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: ff38c562 by Henry Wilkes at 2024-08-22T19:31:59+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - a3af591b by Henry Wilkes at 2024-08-22T19:32:03+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 2 changed files: - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -7,10 +7,7 @@ > <html:h1 data-l10n-id="letterboxing-header" /> <description class="letterboxing-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -26,10 +23,7 @@ <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -51,10 +45,7 @@ data-l10n-id="letterboxing-alignment-header" /></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -100,10 +91,7 @@ <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -9,7 +9,6 @@ <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" - class="tail-with-learn-more" data-l10n-id="security-level-preferences-overview" ></html:span> <html:a View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/53… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/53… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 41916: Letterboxing preferences UI
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ee9f5a52 by Henry Wilkes at 2024-08-22T19:29:14+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - dafeecd7 by Henry Wilkes at 2024-08-22T19:29:21+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 2 changed files: - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -7,10 +7,7 @@ > <html:h1 data-l10n-id="letterboxing-header" /> <description class="letterboxing-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -26,10 +23,7 @@ <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -51,10 +45,7 @@ data-l10n-id="letterboxing-alignment-header" /></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -100,10 +91,7 @@ <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -9,7 +9,6 @@ <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" - class="tail-with-learn-more" data-l10n-id="security-level-preferences-overview" ></html:span> <html:a View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1a4edd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1a4edd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 4 commits: fixup! Bug 30237: Add v3 onion services client authentication prompt
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 1825488a by Henry Wilkes at 2024-08-22T19:26:55+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - ec4aaaf5 by Henry Wilkes at 2024-08-22T19:26:55+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 0c7a4ea1 by Henry Wilkes at 2024-08-22T19:26:55+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 5b238c40 by Henry Wilkes at 2024-08-22T19:26:55+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42665: Drop the "tail-with-learn-more" class from our descriptions. - - - - - 5 changed files: - browser/components/onionservices/content/authPreferences.inc.xhtml - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.xhtml Changes: ===================================== browser/components/onionservices/content/authPreferences.inc.xhtml ===================================== @@ -12,7 +12,6 @@ > <html:span id="torOnionServiceKeys-overview" - class="tail-with-learn-more" data-l10n-id="onion-site-authentication-preferences-overview" ></html:span> <label ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -7,10 +7,7 @@ > <html:h1 data-l10n-id="letterboxing-header" /> <description class="letterboxing-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -26,10 +23,7 @@ <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -51,10 +45,7 @@ data-l10n-id="letterboxing-alignment-header" /></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" @@ -100,10 +91,7 @@ <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> <description class="letterboxing-search-overview description-deemphasized"> - <html:span - data-l10n-id="letterboxing-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="letterboxing-overview"></html:span> <html:a is="moz-support-link" tor-manual-page="anti-fingerprinting_letterboxing" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -9,7 +9,6 @@ <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" - class="tail-with-learn-more" data-l10n-id="security-level-preferences-overview" ></html:span> <html:a ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -13,10 +13,7 @@ > <html:h1 data-l10n-id="tor-connection-settings-heading"></html:h1> <description class="description-deemphasized" flex="1"> - <html:span - data-l10n-id="tor-connection-overview" - class="tail-with-learn-more" - ></html:span> + <html:span data-l10n-id="tor-connection-overview"></html:span> <label class="learnMore text-link" is="text-link" @@ -112,10 +109,7 @@ hidden="true" > <description class="description-deemphasized" flex="1"> - <html:span - class="tail-with-learn-more" - data-l10n-id="tor-bridges-overview" - /> + <html:span data-l10n-id="tor-bridges-overview"></html:span> <label class="learnMore text-link" is="text-link" ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -30,7 +30,6 @@ <html:div id="user-provide-bridge-entry-page"> <description id="user-provide-bridge-description"> <html:span - class="tail-with-learn-more" data-l10n-id="user-provide-bridge-dialog-description" ></html:span> <label View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/da2d11… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/da2d11… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] 2 commits: Bug 41168: Check that we are not changing other channel when deploying update_responses
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 32537994 by Nicolas Vigier at 2024-08-22T19:09:19+00:00 Bug 41168: Check that we are not changing other channel when deploying update_responses - - - - - fb9e1493 by Nicolas Vigier at 2024-08-22T19:09:23+00:00 Bug 41168: Fix check in update_responses deploy script The check for modified files from other channels was inverted. - - - - - 1 changed file: - tools/signing/upload-update_responses-to-staticiforme Changes: ===================================== tools/signing/upload-update_responses-to-staticiforme ===================================== @@ -63,6 +63,18 @@ echo "update_responses_commit: $update_responses_commit" cd "$update_dir" git fetch +changed_files="\$(git diff --name-only HEAD $update_responses_commit)" +if echo "\$changed_files" | grep -qv "$tbb_version_type" +then + echo >&2 "Error: checking out new update_response_commit will changes" + echo >&2 "some files outside of the $tbb_version_type directory:" + echo "\$changed_files" | grep -v "$tbb_version_type" >&2 + echo >&2 "--" + echo >&2 "If this is really what you want to do, edit this script to" + echo >&2 "remove the line 'exit 1' and run it again." + echo >&2 "See tor-browser-build#41168 for more details." + exit 1 +fi git checkout "$update_responses_commit" static-update-component aus1.torproject.org View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41168: Fix check in update_responses deploy script
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: db976d61 by Nicolas Vigier at 2024-08-22T19:01:47+00:00 Bug 41168: Fix check in update_responses deploy script The check for modified files from other channels was inverted. - - - - - 1 changed file: - tools/signing/upload-update_responses-to-staticiforme Changes: ===================================== tools/signing/upload-update_responses-to-staticiforme ===================================== @@ -64,7 +64,7 @@ echo "update_responses_commit: $update_responses_commit" cd "$update_dir" git fetch changed_files="\$(git diff --name-only HEAD $update_responses_commit)" -if ! echo "\$changed_files" | grep -qv "$tbb_version_type" +if echo "\$changed_files" | grep -qv "$tbb_version_type" then echo >&2 "Error: checking out new update_response_commit will changes" echo >&2 "some files outside of the $tbb_version_type directory:" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41013: Add a README to each project
by morgan (＠morgan) 22 Aug '24

22 Aug '24

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 2a175fce by Pier Angelo Vendrame at 2024-08-21T20:55:55+00:00 Bug 41013: Add a README to each project - - - - - 30 changed files: - doc/how-to-update-go-dependencies.txt - + projects/android-toolchain/README.md - + projects/application-services/README.md - + projects/binutils/README.md - + projects/browser/README.md - + projects/cbindgen/README.md - + projects/cctools/README.md - + projects/clang/README.md - + projects/cmake/README.md - + projects/common/README.md - + projects/conjure/README.md - + projects/container-image/README.md - + projects/firefox-l10n/README.md - + projects/firefox/README.md - + projects/fonts/README.md - projects/fonts/README.txt - + projects/fxc2/README.md - + projects/gcc-source/README.md - + projects/gcc/README.md - + projects/geckoview/README.md - + projects/glean/README.md - + projects/go-bootstrap/README.md - + projects/go/README.md - + projects/gradle/README.md - + projects/hfsplus-tools/README.md - + projects/libdmg-hfsplus/README.md - + projects/libevent/README.md - + projects/libtapi/README.md - + projects/llvm-project/README.md - + projects/llvm-runtimes/README.md The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0