- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] Bug 42022: Prevent extension search engines from breaking the whole search system
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d11b0294 by Pier Angelo Vendrame at 2023-08-16T19:44:09+02:00 Bug 42022: Prevent extension search engines from breaking the whole search system We found that if an extension tries to add a search engine that is already bundled the whole search system breaks because an exception is thrown and it reaches the initialization function, whose catch undoes the initialization. With this commit, we handle this kind of exceptions when trying to install the extension's engines, and contain it there. - - - - - 1 changed file: - toolkit/components/search/SearchService.sys.mjs Changes: ===================================== toolkit/components/search/SearchService.sys.mjs ===================================== @@ -2706,6 +2706,7 @@ export class SearchService { }; let engines = []; + let revert = false; for (let locale of locales) { lazy.logConsole.debug( "addEnginesFromExtension: installing:", @@ -2713,7 +2714,28 @@ export class SearchService { ":", locale ); - engines.push(await installLocale(locale)); + try { + engines.push(await installLocale(locale)); + } catch (err) { + lazy.logConsole.error( + `Could not install the search engine of ${extension.id}`, + err + ); + revert = true; + break; + } + } + if (revert) { + for (let engine of engines) { + try { + this.removeEngine(engine); + } catch (err) { + lazy.logConsole.warn( + "Failed to revert the addition of a search engine", + err + ); + } + } } return engines; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d11b029… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new branch firefox-android-115.2.1-13.0-1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag fenix-v115.2.1
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed new tag fenix-v115.2.1 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/fenix… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.1.0esr-13.0-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: a992e3dd by Henry Wilkes at 2023-08-16T10:02:44+02:00 fixup! Base Browser strings Bug 41984: Rename languageNotification.ftl to base-browser.ftl. - - - - - cdbb2876 by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Base Browser strings Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 456bd08b by Henry Wilkes at 2023-08-16T10:02:54+02:00 fixup! Bug 41698: Reword the recommendation badges in about:addons Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 3 changed files: - browser/base/content/browser.xhtml - browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl - toolkit/mozapps/extensions/content/aboutaddons.html Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -88,7 +88,7 @@ <link rel="localization" href="toolkit/branding/brandings.ftl"/> <link rel="localization" href="toolkit/global/textActions.ftl"/> <link rel="localization" href="toolkit/printing/printUI.ftl"/> - <link rel="localization" href="browser/languageNotification.ftl"/> + <link rel="localization" href="browser/base-browser.ftl"/>  <link rel="localization" href="preview/firefoxSuggest.ftl" /> <link rel="localization" href="preview/identityCredentialNotification.ftl" /> ===================================== browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -2,17 +2,12 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -# These strings are used by the Base Browser part of the changeset, not only for -# the language notification. -# TODO: Rename this file to make this clearer - - ## Language notification -# $language is the language Tor Browser is displayed in (already translated) +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label-system = { -brand-short-name } has set your display language to { $language } based on your system’s language. # This is shown when the system language is not supported, so we fall back to another language instead. -# $language is the language Tor Browser is displayed in (already translated). +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label = { -brand-short-name } has set your display language to { $language }. language-notification-button = Change Language… ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -35,7 +35,7 @@ <link rel="localization" href="toolkit/about/aboutAddons.ftl" /> <link rel="localization" href="toolkit/about/abuseReports.ftl" /> - <link rel="localization" href="browser/languageNotification.ftl" /> + <link rel="localization" href="browser/base-browser.ftl" />  <script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9ac98d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] 3 commits: fixup! Base Browser strings
by Pier Angelo Vendrame (＠pierov) 16 Aug '23

16 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: c2bff07e by Henry Wilkes at 2023-08-09T09:44:53+01:00 fixup! Base Browser strings Bug 41984: Rename languageNotification.ftl to base-browser.ftl. - - - - - 72724735 by Henry Wilkes at 2023-08-09T09:45:00+01:00 fixup! Base Browser strings Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 6de7d3e8 by Henry Wilkes at 2023-08-09T09:45:05+01:00 fixup! Bug 41698: Reword the recommendation badges in about:addons Bug 41984: languageNotification.ftl renamed to base-browser.ftl. - - - - - 3 changed files: - browser/base/content/browser.xhtml - browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl - toolkit/mozapps/extensions/content/aboutaddons.html Changes: ===================================== browser/base/content/browser.xhtml ===================================== @@ -95,7 +95,7 @@ <link rel="localization" href="toolkit/branding/brandings.ftl"/> <link rel="localization" href="toolkit/global/textActions.ftl"/> <link rel="localization" href="toolkit/printing/printUI.ftl"/> - <link rel="localization" href="browser/languageNotification.ftl"/> + <link rel="localization" href="browser/base-browser.ftl"/>  <link rel="localization" href="preview/firefoxSuggest.ftl" /> <link rel="localization" href="preview/identityCredentialNotification.ftl" /> ===================================== browser/locales/en-US/browser/languageNotification.ftl → browser/locales/en-US/browser/base-browser.ftl ===================================== @@ -2,17 +2,12 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -# These strings are used by the Base Browser part of the changeset, not only for -# the language notification. -# TODO: Rename this file to make this clearer - - ## Language notification -# $language is the language Tor Browser is displayed in (already translated) +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label-system = { -brand-short-name } has set your display language to { $language } based on your system’s language. # This is shown when the system language is not supported, so we fall back to another language instead. -# $language is the language Tor Browser is displayed in (already translated). +# $language (String) - The language Tor Browser is displayed in (already translated). language-notification-label = { -brand-short-name } has set your display language to { $language }. language-notification-button = Change Language… ===================================== toolkit/mozapps/extensions/content/aboutaddons.html ===================================== @@ -35,7 +35,7 @@ <link rel="localization" href="toolkit/about/aboutAddons.ftl" /> <link rel="localization" href="toolkit/about/abuseReports.ftl" /> - <link rel="localization" href="browser/languageNotification.ftl" /> + <link rel="localization" href="browser/base-browser.ftl" />  <script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e0e763… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e0e763… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.1.0esr-13.0-1-build1
by richard (＠richard) 12 Aug '23

12 Aug '23

richard pushed new tag base-browser-115.1.0esr-13.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 13.0a2
by richard (＠richard) 12 Aug '23

12 Aug '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: e8b28d41 by Richard Pospesel at 2023-08-12T19:33:24+00:00 alpha: new version, 13.0a2 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/12.5a5-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a5-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a5-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a5-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a5-13.0a1-win64-ALL.xml - − update_3/alpha/12.5a6-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a6-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a6-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a6-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a6-13.0a1-win64-ALL.xml - − update_3/alpha/12.5a7-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a7-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a7-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a7-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a7-13.0a1-win64-ALL.xml - + update_3/alpha/13.0a1-13.0a2-linux32-ALL.xml - + update_3/alpha/13.0a1-13.0a2-linux64-ALL.xml - + update_3/alpha/13.0a1-13.0a2-macos-ALL.xml - + update_3/alpha/13.0a1-13.0a2-win32-ALL.xml - + update_3/alpha/13.0a1-13.0a2-win64-ALL.xml - − update_3/alpha/13.0a1-linux32-ALL.xml - − update_3/alpha/13.0a1-linux64-ALL.xml - − update_3/alpha/13.0a1-macos-ALL.xml - − update_3/alpha/13.0a1-win32-ALL.xml - − update_3/alpha/13.0a1-win64-ALL.xml - + update_3/alpha/13.0a2-linux32-ALL.xml - + update_3/alpha/13.0a2-linux64-ALL.xml - + update_3/alpha/13.0a2-macos-ALL.xml - + update_3/alpha/13.0a2-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] Revert "alpha: new version, 13.0a2"
by richard (＠richard) 12 Aug '23

12 Aug '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: c9c4c70b by Richard Pospesel at 2023-08-12T19:31:42+00:00 Revert "alpha: new version, 13.0a2" This reverts commit 37d194259f1ddbef90a7c1ab6aa1cafb8a661eb3. - - - - - 30 changed files: - update_3/alpha/.htaccess - + update_3/alpha/12.5a5-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a5-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a5-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a5-13.0a1-win32-ALL.xml - + update_3/alpha/12.5a5-13.0a1-win64-ALL.xml - + update_3/alpha/12.5a6-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a6-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a6-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a6-13.0a1-win32-ALL.xml - + update_3/alpha/12.5a6-13.0a1-win64-ALL.xml - + update_3/alpha/12.5a7-13.0a1-linux32-ALL.xml - + update_3/alpha/12.5a7-13.0a1-linux64-ALL.xml - + update_3/alpha/12.5a7-13.0a1-macos-ALL.xml - + update_3/alpha/12.5a7-13.0a1-win32-ALL.xml - + update_3/alpha/12.5a7-13.0a1-win64-ALL.xml - − update_3/alpha/13.0a1-13.0a2-linux32-ALL.xml - − update_3/alpha/13.0a1-13.0a2-linux64-ALL.xml - − update_3/alpha/13.0a1-13.0a2-macos-ALL.xml - − update_3/alpha/13.0a1-13.0a2-win32-ALL.xml - − update_3/alpha/13.0a1-13.0a2-win64-ALL.xml - + update_3/alpha/13.0a1-linux32-ALL.xml - + update_3/alpha/13.0a1-linux64-ALL.xml - + update_3/alpha/13.0a1-macos-ALL.xml - + update_3/alpha/13.0a1-win32-ALL.xml - + update_3/alpha/13.0a1-win64-ALL.xml - − update_3/alpha/13.0a2-linux32-ALL.xml - − update_3/alpha/13.0a2-linux64-ALL.xml - − update_3/alpha/13.0a2-macos-ALL.xml - − update_3/alpha/13.0a2-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 13.0a2
by richard (＠richard) 12 Aug '23

12 Aug '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 37d19425 by Richard Pospesel at 2023-08-12T17:28:10+00:00 alpha: new version, 13.0a2 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/12.5a5-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a5-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a5-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a5-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a5-13.0a1-win64-ALL.xml - − update_3/alpha/12.5a6-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a6-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a6-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a6-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a6-13.0a1-win64-ALL.xml - − update_3/alpha/12.5a7-13.0a1-linux32-ALL.xml - − update_3/alpha/12.5a7-13.0a1-linux64-ALL.xml - − update_3/alpha/12.5a7-13.0a1-macos-ALL.xml - − update_3/alpha/12.5a7-13.0a1-win32-ALL.xml - − update_3/alpha/12.5a7-13.0a1-win64-ALL.xml - + update_3/alpha/13.0a1-13.0a2-linux32-ALL.xml - + update_3/alpha/13.0a1-13.0a2-linux64-ALL.xml - + update_3/alpha/13.0a1-13.0a2-macos-ALL.xml - + update_3/alpha/13.0a1-13.0a2-win32-ALL.xml - + update_3/alpha/13.0a1-13.0a2-win64-ALL.xml - − update_3/alpha/13.0a1-linux32-ALL.xml - − update_3/alpha/13.0a1-linux64-ALL.xml - − update_3/alpha/13.0a1-macos-ALL.xml - − update_3/alpha/13.0a1-win32-ALL.xml - − update_3/alpha/13.0a1-win64-ALL.xml - + update_3/alpha/13.0a2-linux32-ALL.xml - + update_3/alpha/13.0a2-linux64-ALL.xml - + update_3/alpha/13.0a2-macos-ALL.xml - + update_3/alpha/13.0a2-win32-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.0a2-build5
by richard (＠richard) 11 Aug '23

11 Aug '23

richard pushed new tag tbb-13.0a2-build5 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0