- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][main] Bug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library.
by Pier Angelo Vendrame (＠pierov) 29 Aug '23

29 Aug '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 3def5ce4 by Pier Angelo Vendrame at 2023-08-29T14:26:25+02:00 Bug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library. This parameter added with the previous commit prevents Snowflake from working properly. So, we prefer to undo the addition (but keep the changes to the ICE server list). - - - - - 1 changed file: - projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch Changes: ===================================== projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch ===================================== @@ -71,7 +71,7 @@ index 2405097..bcb6a37 100644 - buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(clientPath).append('\n'); + public TorConfigBuilder transportPlugin(String obfsPath, String snowPath) { + buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(obfsPath).append('\n'); -+ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478 -utls-imitate=hellorandomizedalpn\n"); ++ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n"); return this; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library.
by ma1 (＠ma1) 29 Aug '23

29 Aug '23

ma1 pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 26496b1d by Pier Angelo Vendrame at 2023-08-29T14:13:13+02:00 Bug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library. This parameter added with the previous commit prevents Snowflake from working properly. So, we prefer to undo the addition (but keep the changes to the ICE server list). - - - - - 1 changed file: - projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch Changes: ===================================== projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch ===================================== @@ -71,7 +71,7 @@ index 2405097..bcb6a37 100644 - buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(clientPath).append('\n'); + public TorConfigBuilder transportPlugin(String obfsPath, String snowPath) { + buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(obfsPath).append('\n'); -+ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478 -utls-imitate=hellorandomizedalpn\n"); ++ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n"); return this; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-spec][main] 2 commits: Bug 40050: FF103 Audit
by richard (＠richard) 28 Aug '23

28 Aug '23

richard pushed to branch main at The Tor Project / Applications / tor-browser-spec Commits: b98cb466 by Richard Pospesel at 2023-08-28T20:28:54+00:00 Bug 40050: FF103 Audit - - - - - 210910a0 by Richard Pospesel at 2023-08-28T20:28:54+00:00 Tweaks to code_audit.sh to also show the report if one exists - - - - - 2 changed files: - + audits/FF103_AUDIT - audits/code_audit.sh Changes: ===================================== audits/FF103_AUDIT ===================================== @@ -0,0 +1,78 @@ +# General + +The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript). + +The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation. + +`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit. + +## Firefox: https://github.com/mozilla/gecko-dev.git + +- Start: `feef2b7da6ff76b4c3c7a13e611eab6e97837ae2` ( `FIREFOX_102_0_1_RELEASE` ) +- End: `1f1c56dc6bae6b3302471f097ed132ef44cded86` ( `FIREFOX_103_0_2_RELEASE` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +--- + +## Application Services: https://github.com/mozilla/application-services.git + +- Start: `0302b89604bb29adb34fdcd710feabd3dd01992d` ( `v93.5.0` ) +- End: `b70c54882fec606d10e77520b1dd2ae144768747` ( `v94.0.0` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Android Components: https://github.com/mozilla-mobile/android-components.git + +- Start: `c349019286e21e5179a59e33cec6ae528b108519` +- End: `ce720e6308e26588decd5f9d2b02e4658d5b9d14` ( `v103.0.11` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + + + +#### Problematic Commits +- Biometric prompt feature (#12291): `b1723820859fce1c6d0a358e1edec4f4dec39234` + +## Fenix: https://github.com/mozilla-mobile/fenix.git + +- Start: `6e0ad035e384ef1fb7d8c8ac8d398470d953e1dc` ( `v103.0.0-beta.1` ) +- End: `e0d3c03afefe699a7456214b0da140f74ef499f7` ( `v103.2.0` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Ticket Review ## + +Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=103%20Branch&order=priority%2Cbug_severity&limit=0` + +#### Problematic Tickets +- **Use double-conversion library instead of dtoa for string-to-double conversion** https://bugzilla.mozilla.org/show_bug.cgi?id=1770158 + - Uses upstream https://github.com/google/double-conversion from google + - Well tested and documentaiton doesn't suggest any hardware specific differences, quick look through the source suggest integer operations for the parsing/conversions ===================================== audits/code_audit.sh ===================================== @@ -148,7 +148,7 @@ case "${SCOPE}" in esac AUDIT_DIR=$(pwd) -cd "$REPO_DIR" +pushd "$REPO_DIR" # Step 2: Generate match pattern based on in-scope keywords function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/$d}"; } @@ -174,7 +174,7 @@ rm -f "${REPORT_FILE}" # Flashing Color constants export GREP_COLOR="05;37;41" -for COMMIT in $(git rev-list --ancestry-path $OLD..$NEW); do +for COMMIT in $(git rev-list --ancestry-path $OLD~..$NEW); do TEMP_DIFF="$(mktemp)" echo "Diffing $COMMIT..." @@ -201,6 +201,7 @@ for COMMIT in $(git rev-list --ancestry-path $OLD..$NEW); do rm -f "${TEMP_DIFF}" done +popd # Step 5: Review the code changes @@ -210,6 +211,7 @@ then echo "Report generated. View it with:" echo "" echo "less -R \"$(basename "${REPORT_FILE}")\"" + less -R "$(basename ${REPORT_FILE})" else echo "No keywords found. No report generated" fi View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/compare/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/compare/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40740: Android's snowflake ClientTransportPlugin parameters.
by Pier Angelo Vendrame (＠pierov) 28 Aug '23

28 Aug '23

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 29483c74 by Pier Angelo Vendrame at 2023-08-28T15:20:00+02:00 Bug 40740: Android's snowflake ClientTransportPlugin parameters. On Android we set PTs parameters with a patch to tor-onion-proxy-library, but they were not updated to the same as desktop. - - - - - 1 changed file: - projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch Changes: ===================================== projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch ===================================== @@ -71,7 +71,7 @@ index 2405097..bcb6a37 100644 - buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(clientPath).append('\n'); + public TorConfigBuilder transportPlugin(String obfsPath, String snowPath) { + buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(obfsPath).append('\n'); -+ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.voip.blackberry.com:3478,stun:stun.altar.com.pl:3478,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.sonetel.net:3478,stun:stun.stunprotocol.org:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n"); ++ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478 -utls-imitate=hellorandomizedalpn\n"); return this; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40740: Android's snowflake ClientTransportPlugin parameters.
by Pier Angelo Vendrame (＠pierov) 28 Aug '23

28 Aug '23

Pier Angelo Vendrame pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 9082991b by Pier Angelo Vendrame at 2023-08-28T15:08:45+02:00 Bug 40740: Android's snowflake ClientTransportPlugin parameters. On Android we set PTs parameters with a patch to tor-onion-proxy-library, but they were not updated to the same as desktop. - - - - - 1 changed file: - projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch Changes: ===================================== projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch ===================================== @@ -71,7 +71,7 @@ index 2405097..bcb6a37 100644 - buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(clientPath).append('\n'); + public TorConfigBuilder transportPlugin(String obfsPath, String snowPath) { + buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec ").append(obfsPath).append('\n'); -+ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.voip.blackberry.com:3478,stun:stun.altar.com.pl:3478,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.sonetel.net:3478,stun:stun.stunprotocol.org:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n"); ++ buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478 -utls-imitate=hellorandomizedalpn\n"); return this; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Aug '23

28 Aug '23

Pier Angelo Vendrame pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: f030bc26 by Richard Pospesel at 2023-08-28T14:28:47+02:00 fixup! Firefox preference overrides. Bug 41774: Hide the 'Switching to a new device' hepl menu item - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -20,6 +20,9 @@ pref("browser.aboutwelcome.enabled", false); // Disable the Firefox View tab (tor-browser#41876) pref("browser.tabs.firefox-view", false); +// Disable 'Switching to a new device" help menu item (tor-browser#41774) +pref("browser.device-migration.help-menu.hidden", true); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f030bc2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f030bc2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Aug '23

28 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 03567aeb by Richard Pospesel at 2023-08-26T05:28:59+00:00 fixup! Firefox preference overrides. Bug 41774: Hide the 'Switching to a new device' hepl menu item - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -20,6 +20,9 @@ pref("browser.aboutwelcome.enabled", false); // Disable the Firefox View tab (tor-browser#41876) pref("browser.tabs.firefox-view", false); +// Disable 'Switching to a new device" help menu item (tor-browser#41774) +pref("browser.device-migration.help-menu.hidden", true); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/03567ae… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/03567ae… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-12.5] Bug 40857: Mullvad Browser generated downloads.json references tbb-* build tag rather than mb-*
by boklm (＠boklm) 28 Aug '23

28 Aug '23

boklm pushed to branch maint-12.5 at The Tor Project / Applications / tor-browser-build Commits: 46a0782d by Richard Pospesel at 2023-08-28T10:29:52+02:00 Bug 40857: Mullvad Browser generated downloads.json references tbb-* build tag rather than mb-* - - - - - 1 changed file: - projects/release/update_responses_config.yml Changes: ===================================== projects/release/update_responses_config.yml ===================================== @@ -73,7 +73,12 @@ versions: linux64: minSupportedInstructionSet: SSE2 mar_compression: xz +[% IF c("var/tor-browser") -%] tag: 'tbb-[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]' +[% END -%] +[% IF c("var/mullvad-browser") -%] +tag: 'mb-[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]' +[% END -%] [% IF c("var/tor-browser") -%] htaccess_rewrite_rules: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40857: Mullvad Browser generated downloads.json references tbb-* build tag rather than mb-*
by boklm (＠boklm) 28 Aug '23

28 Aug '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: f779c567 by Richard Pospesel at 2023-08-28T10:28:29+02:00 Bug 40857: Mullvad Browser generated downloads.json references tbb-* build tag rather than mb-* - - - - - 1 changed file: - projects/release/update_responses_config.yml Changes: ===================================== projects/release/update_responses_config.yml ===================================== @@ -68,7 +68,12 @@ versions: linux-x86_64: minSupportedInstructionSet: SSE2 mar_compression: xz +[% IF c("var/tor-browser") -%] tag: 'tbb-[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]' +[% END -%] +[% IF c("var/mullvad-browser") -%] +tag: 'mb-[% c("var/torbrowser_version") %]-[% c("var/torbrowser_build") %]' +[% END -%] [% IF c("var/tor-browser") -%] htaccess_rewrite_rules: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40821: The update details URL is wrong in alphas
by boklm (＠boklm) 28 Aug '23

28 Aug '23

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: ba7fb340 by Richard Pospesel at 2023-08-28T10:22:11+02:00 Bug 40821: The update details URL is wrong in alphas - - - - - 1 changed file: - projects/release/update_responses_config.yml Changes: ===================================== projects/release/update_responses_config.yml ===================================== @@ -36,7 +36,7 @@ versions: mar_channel_id: [% c('var/mar_channel_id') %] platformVersion: [% pc('firefox', 'var/firefox_platform_version') %] [% IF c("var/tor-browser") -%] - detailsURL: https://blog.torproject.org/new-release-tor-browser-[% c("var/torbrowser_version") FILTER remove('\.') %] + detailsURL: https://blog.torproject.org/new[% IF c("var/alpha") %]-alpha[% END %]-release-tor-browser-[% c("var/torbrowser_version") FILTER remove('\.') %] [% END -%] [% IF c("var/mullvad-browser") -%] detailsURL: https://github.com/mullvad/mullvad-browser/releases/[% c("var/torbrowser_version") %] View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0