- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.5-1] fixup! Bug 42072: 2023 year end campaign for about:tor.
by richard (＠richard) 13 Nov '23

13 Nov '23

richard pushed to branch tor-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: f68e26b8 by Henry Wilkes at 2023-11-13T16:23:07+00:00 fixup! Bug 42072: 2023 year end campaign for about:tor. Bug 42188: Make the YEC banner closed state persist for the current session. - - - - - 4 changed files: - browser/components/BrowserGlue.sys.mjs - browser/components/abouttor/AboutTorChild.sys.mjs - browser/components/abouttor/AboutTorParent.sys.mjs - browser/components/abouttor/content/aboutTor.js Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -453,6 +453,7 @@ let JSWINDOWACTORS = { events: { DOMContentLoaded: {}, SubmitSearchOnionize: { wantUntrusted: true }, + YECHidden: { wantUntrusted: true }, }, }, ===================================== browser/components/abouttor/AboutTorChild.sys.mjs ===================================== @@ -26,6 +26,11 @@ export class AboutTorChild extends JSWindowActorChild { case "SubmitSearchOnionize": this.sendAsyncMessage("AboutTor:SetSearchOnionize", !!event.detail); break; + case "YECHidden": + // YEC 2023 banner was closed. Persist this for the rest of this + // session. See tor-browser#42188. + this.sendAsyncMessage("AboutTor:HideYEC"); + break; } } } ===================================== browser/components/abouttor/AboutTorParent.sys.mjs ===================================== @@ -7,6 +7,19 @@ ChromeUtils.defineESModuleGetters(lazy, { TorConnect: "resource:///modules/TorConnect.sys.mjs", }); +/** + * Whether we should hide the Year end campaign (YEC) 2023 donation banner for + * new about:tor pages. Applied to all future about:tor pages within this + * session (i.e. new tabs, new windows, and after new identity). + * + * Will reset back to shown at the next full restart. + * + * See tor-browser#42188. + * + * @type {boolean} + */ +let hideYEC = false; + export class AboutTorParent extends JSWindowActorParent { receiveMessage(message) { const onionizePref = "torbrowser.homepage.search.onionize"; @@ -22,10 +35,14 @@ export class AboutTorParent extends JSWindowActorParent { Services.locale.appLocaleAsBCP47 === "ja-JP-macos" ? "ja" : Services.locale.appLocaleAsBCP47, + hideYEC, }); case "AboutTor:SetSearchOnionize": Services.prefs.setBoolPref(onionizePref, message.data); break; + case "AboutTor:HideYEC": + hideYEC = true; + break; } return undefined; } ===================================== browser/components/abouttor/content/aboutTor.js ===================================== @@ -200,6 +200,7 @@ const YecWidget = { this.isActive = now >= yecStart && now < yecEnd; document.getElementById("yec-2023-close").addEventListener("click", () => { + dispatchEvent(new CustomEvent("YECHidden", { bubbles: true })); this.isOpen = false; }); @@ -215,7 +216,7 @@ const YecWidget = { _isStable: false, _isActive: false, - _isOpen: true, + _isOpen: false, /** * Whether this is a stable release. @@ -294,7 +295,8 @@ window.addEventListener("DOMContentLoaded", () => { }); window.addEventListener("InitialData", event => { - const { appLocale, isStable } = event.detail; + const { appLocale, isStable, hideYEC } = event.detail; YecWidget.setDonateLocale(appLocale); YecWidget.isStable = isStable; + YecWidget.isOpen = !hideYEC; }); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f68e26b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f68e26b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40064: Fix usage of exec without git_url/hg_url
by richard (＠richard) 13 Nov '23

13 Nov '23

richard pushed to branch main at The Tor Project / Applications / RBM Commits: 4fd67eea by Nicolas Vigier at 2023-11-08T08:51:23+01:00 Bug 40064: Fix usage of exec without git_url/hg_url - - - - - 2 changed files: - doc/rbm_templates.asc - lib/RBM.pm Changes: ===================================== doc/rbm_templates.asc ===================================== @@ -107,7 +107,9 @@ exec:: considered to be a script, which will be written to a temporary file and executed. The second argument of the exec function is an optional $options hash, used to override values of 'git_url', - 'hg_url', 'fetch', 'git_hash' or 'hg_hash'. + 'hg_url', 'fetch', 'git_hash' or 'hg_hash'. If neither 'git_url' + nor 'hg_url' is set, the command is executed from the directory + where the 'rbm.conf' file is located. path:: A function to return an absolute path. It takes a path as first ===================================== lib/RBM.pm ===================================== @@ -549,7 +549,7 @@ sub git_submodule_init_sync_update { sub execute { my ($project, $cmd, $options) = @_; CORE::state %cache; - my $res_name; + my $res_name = ''; my $old_cwd = getcwd; if (project_config($project, 'git_url', $options)) { my $git_hash = project_config($project, 'git_hash', $options) @@ -571,6 +571,8 @@ sub execute { my ($stdout, $stderr, $success, $exit_code) = capture_exec('hg', 'update', '-C', $hg_hash); exit_error "Cannot checkout $hg_hash:\n$stderr" unless $success; + } else { + chdir($config->{basedir}); } my ($stdout, $stderr, $success, $exit_code) = run_script($project, $cmd, \&capture_exec); View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/4fd67eea510a680… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/4fd67eea510a680… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch base-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: a7078534 by Pier Angelo Vendrame at 2023-11-13T15:11:18+01:00 fixup! Firefox preference overrides. Bug 42153: Drop dom.enable_resource_timing = false - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -344,7 +344,6 @@ pref("browser.link.open_newwindow.restriction", 0); // Bug 9881: Open popups in pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); -pref("dom.enable_resource_timing", false); // Bug 13024: To hell with this API pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 pref("dom.webaudio.enabled", false); // Bug 13017: Disable Web Audio API pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a707853… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a707853… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch mullvad-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 8c9191c8 by Pier Angelo Vendrame at 2023-11-13T15:10:56+01:00 fixup! Firefox preference overrides. Bug 42153: Drop dom.enable_resource_timing = false - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -344,7 +344,6 @@ pref("browser.link.open_newwindow.restriction", 0); // Bug 9881: Open popups in pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); -pref("dom.enable_resource_timing", false); // Bug 13024: To hell with this API pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API // tor-browser#42043: Stop reporting device IDs (and spoof their number without View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8c9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8c9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch tor-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: f9c4691b by Pier Angelo Vendrame at 2023-11-13T14:33:44+01:00 fixup! Firefox preference overrides. Bug 42153: Drop dom.enable_resource_timing = false - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -344,7 +344,6 @@ pref("browser.link.open_newwindow.restriction", 0); // Bug 9881: Open popups in pref("dom.disable_window_move_resize", true); // Set video VP9 to 0 for everyone (bug 22548) pref("media.benchmark.vp9.threshold", 0); -pref("dom.enable_resource_timing", false); // Bug 13024: To hell with this API pref("privacy.resistFingerprinting.block_mozAddonManager", true); // Bug 26114 pref("dom.webaudio.enabled", false); // Bug 13017: Disable Web Audio API pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f9c4691… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f9c4691… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Deleted branch main
by richard (＠richard) 12 Nov '23

12 Nov '23

richard deleted branch main at The Tor Project / Applications / Tor Browser -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch main
by richard (＠richard) 12 Nov '23

12 Nov '23

richard pushed new branch main at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/main You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.4.0esr-13.0-1] Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.
by ma1 (＠ma1) 08 Nov '23

08 Nov '23

ma1 pushed to branch mullvad-browser-115.4.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 23d4e4c4 by hackademix at 2023-11-08T13:45:19+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 1 changed file: - toolkit/actors/NetErrorChild.sys.mjs Changes: ===================================== toolkit/actors/NetErrorChild.sys.mjs ===================================== @@ -133,12 +133,15 @@ export class NetErrorChild extends RemotePageChild { shortDesc.appendChild(span); }, }; - - Services.uriFixup.checkHost( - info.fixedURI, - onLookupCompleteListener, - this.document.nodePrincipal.originAttributes - ); + try { + Services.uriFixup.checkHost( + info.fixedURI, + onLookupCompleteListener, + this.document.nodePrincipal.originAttributes + ); + } catch (e) { + // DNS resolution may fail synchronously if forbidden by proxy + } } // Get the header from the http response of the failed channel. This function View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/23d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/23d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.4.0esr-13.0-1] Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.
by ma1 (＠ma1) 08 Nov '23

08 Nov '23

ma1 pushed to branch base-browser-115.4.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 6f9292eb by hackademix at 2023-11-08T13:44:18+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 1 changed file: - toolkit/actors/NetErrorChild.sys.mjs Changes: ===================================== toolkit/actors/NetErrorChild.sys.mjs ===================================== @@ -133,12 +133,15 @@ export class NetErrorChild extends RemotePageChild { shortDesc.appendChild(span); }, }; - - Services.uriFixup.checkHost( - info.fixedURI, - onLookupCompleteListener, - this.document.nodePrincipal.originAttributes - ); + try { + Services.uriFixup.checkHost( + info.fixedURI, + onLookupCompleteListener, + this.document.nodePrincipal.originAttributes + ); + } catch (e) { + // DNS resolution may fail synchronously if forbidden by proxy + } } // Get the header from the http response of the failed channel. This function View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6f9292e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6f9292e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.0-1] Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.
by ma1 (＠ma1) 08 Nov '23

08 Nov '23

ma1 pushed to branch tor-browser-115.4.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 20f764ba by hackademix at 2023-11-08T13:41:58+01:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 1 changed file: - toolkit/actors/NetErrorChild.sys.mjs Changes: ===================================== toolkit/actors/NetErrorChild.sys.mjs ===================================== @@ -140,12 +140,15 @@ export class NetErrorChild extends RemotePageChild { shortDesc.appendChild(span); }, }; - - Services.uriFixup.checkHost( - info.fixedURI, - onLookupCompleteListener, - this.document.nodePrincipal.originAttributes - ); + try { + Services.uriFixup.checkHost( + info.fixedURI, + onLookupCompleteListener, + this.document.nodePrincipal.originAttributes + ); + } catch (e) { + // DNS resolution may fail synchronously if forbidden by proxy + } } // Get the header from the http response of the failed channel. This function View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/20f764b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/20f764b… You're receiving this email because of your account on gitlab.torproject.org.

1 0