- tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch mullvad-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 6226fff7 by Pier Angelo Vendrame at 2024-02-07T12:28:05+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 9e0fad12 by Pier Angelo Vendrame at 2024-02-07T12:28:05+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] 3 commits: Revert "Bug 42374: Check for spoof English in number conversions"
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 0daaf26b by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Revert "Bug 42374: Check for spoof English in number conversions" This reverts commit a7932fac62c8a955bdc3f08a9b81b7f2562a4eff. We are instead backporting the uplifted commits. - - - - - c2feed1c by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 7f263eaf by Pier Angelo Vendrame at 2024-02-07T12:25:35+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1 changed file: - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,15 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && !mContent->OwnerDoc()->AllowsL10n(); if (spoofLocale) { aBCP47LangTag.AssignLiteral("en-US"); return; } - nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/a0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/a0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch base-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d363fccf by Pier Angelo Vendrame at 2024-02-07T12:23:06+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 066750e9 by Pier Angelo Vendrame at 2024-02-07T12:23:06+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c906d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6c906d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.0-1] 2 commits: Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: e42f5004 by Pier Angelo Vendrame at 2024-02-07T12:18:39+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 9af28502 by Pier Angelo Vendrame at 2024-02-07T12:18:39+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 2 changed files: - dom/html/input/NumericInputTypes.cpp - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== dom/html/input/NumericInputTypes.cpp ===================================== @@ -52,11 +52,7 @@ nsresult NumericInputTypeBase::GetRangeOverflowMessage(nsAString& aMessage) { MOZ_ASSERT(!maximum.isNaN()); nsAutoString maxStr; - char buf[32]; - DebugOnly<bool> ok = maximum.toString(buf, ArrayLength(buf)); - maxStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(maximum, maxStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeOverflow", mInputElement->OwnerDoc(), maxStr); @@ -67,11 +63,7 @@ nsresult NumericInputTypeBase::GetRangeUnderflowMessage(nsAString& aMessage) { MOZ_ASSERT(!minimum.isNaN()); nsAutoString minStr; - char buf[32]; - DebugOnly<bool> ok = minimum.toString(buf, ArrayLength(buf)); - minStr.AssignASCII(buf); - MOZ_ASSERT(ok, "buf not big enough"); - + ConvertNumberToString(minimum, minStr); return nsContentUtils::FormatMaybeLocalizedString( aMessage, nsContentUtils::eDOM_PROPERTIES, "FormValidationNumberRangeUnderflow", mInputElement->OwnerDoc(), minStr); ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,8 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): + const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && + !mContent->OwnerDoc()->AllowsL10n(); + if (spoofLocale) { + aBCP47LangTag.AssignLiteral("en-US"); + return; + } nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6292bb… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6292bb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] 3 commits: Revert "Bug 42374: Check for spoof English in number conversions"
by richard (＠richard) 07 Feb '24

07 Feb '24

richard pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: fd8ea798 by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Revert "Bug 42374: Check for spoof English in number conversions" This reverts commit a7932fac62c8a955bdc3f08a9b81b7f2562a4eff. We are instead backporting the uplifted commits. - - - - - e750db60 by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - f8f90f9f by Pier Angelo Vendrame at 2024-02-07T12:13:26+00:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 1 changed file: - intl/unicharutil/util/ICUUtils.cpp Changes: ===================================== intl/unicharutil/util/ICUUtils.cpp ===================================== @@ -47,15 +47,13 @@ void ICUUtils::LanguageTagIterForContent::GetNext(nsACString& aBCP47LangTag) { if (mCurrentFallbackIndex < 2) { mCurrentFallbackIndex = 2; - // Else take the app's locale: - + // Else take the app's locale (or en-US, if spoof English applies): const bool spoofLocale = nsContentUtils::SpoofLocaleEnglish() && !mContent->OwnerDoc()->AllowsL10n(); if (spoofLocale) { aBCP47LangTag.AssignLiteral("en-US"); return; } - nsAutoCString appLocale; LocaleService::GetInstance()->GetAppLocaleAsBCP47(aBCP47LangTag); return; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cc050d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cc050d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Update rbm for rbm#40068 and rbm#40069
by boklm (＠boklm) 07 Feb '24

07 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cc41e2d7 by Nicolas Vigier at 2024-02-07T10:51:09+01:00 Update rbm for rbm#40068 and rbm#40069 - - - - - 1 changed file: - rbm Changes: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit b5e5b04aaf677c4bacfb5ace45598313286bfdf6 +Subproject commit 067c30ee4cf3baa1c0b7e3674d785cf9e5bec8fe View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] Bug 42195: Fix "Whats new URL"
by Dan Ballard (＠dan) 07 Feb '24

07 Feb '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 1e87b6c6 by clairehurst at 2024-02-01T16:51:58+00:00 Bug 42195: Fix "Whats new URL" - - - - - 5 changed files: - fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt - fenix/app/src/test/java/org/mozilla/fenix/home/HomeMenuViewTest.kt - fenix/app/src/test/java/org/mozilla/fenix/settings/SupportUtilsTest.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt ===================================== @@ -170,7 +170,7 @@ class HomeMenuView( Events.whatsNewTapped.record(NoExtras()) homeActivity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.WHATS_NEW_URL, + searchTermOrURL = SupportUtils.getTorWhatsNewUrl(), newTab = true, from = BrowserDirection.FromHome, ) ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt ===================================== @@ -38,7 +38,7 @@ object SupportUtils { const val MEITUAN_URL = "https://tb.j5k6.com/6ZSOp" const val GOOGLE_US_URL = "https://www.google.com/webhp?client=firefox-b-1-m&channel=ts" const val GOOGLE_XX_URL = "https://www.google.com/webhp?client=firefox-b-m&channel=ts" - const val WHATS_NEW_URL = "https://www.torproject.org/releases/" +// const val WHATS_NEW_URL = "https://www.torproject.org/releases/" const val DONATE_URL = "https://donate.torproject.org/" const val TB_MANUAL_URL = "https://tb-manual.torproject.org/mobile-tor" @@ -100,6 +100,12 @@ object SupportUtils { return TB_MANUAL_URL } + fun getTorWhatsNewUrl(): String { + val alpha = if (BuildConfig.VERSION_NAME.contains('a')) "alpha-" else "" + val versionNumberNoDecimals = BuildConfig.VERSION_NAME.split('.').joinToString("") + return "https://blog.torproject.org/new-${alpha}release-tor-browser-${versionNumber…" + } + fun getMozillaPageUrl(page: MozillaPage, locale: Locale = Locale.getDefault()): String { val path = page.path val langTag = getLanguageTag(locale) ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt ===================================== @@ -135,7 +135,7 @@ class AboutFragment : Fragment(), AboutPageListener { AboutPageItem( AboutItem.ExternalLink( WHATS_NEW, - SupportUtils.WHATS_NEW_URL, + SupportUtils.getTorWhatsNewUrl(), ), getString(R.string.about_whats_new, getString(R.string.app_name)), ), ===================================== fenix/app/src/test/java/org/mozilla/fenix/home/HomeMenuViewTest.kt ===================================== @@ -207,7 +207,7 @@ class HomeMenuViewTest { WhatsNew.userViewedWhatsNew(testContext) homeActivity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.WHATS_NEW_URL, + searchTermOrURL = SupportUtils.getTorWhatsNewUrl(), newTab = true, from = BrowserDirection.FromHome, ) ===================================== fenix/app/src/test/java/org/mozilla/fenix/settings/SupportUtilsTest.kt ===================================== @@ -25,10 +25,10 @@ class SupportUtilsTest { "https://support.mozilla.org/1/mobile/20/Android/fr/tracking-protection-fire…", SupportUtils.getSumoURLForTopic(mockContext("2 0"), SupportUtils.SumoTopic.TRACKING_PROTECTION, Locale("fr")), ) - assertEquals( - "https://www.mozilla.org/firefox/android/notes", - SupportUtils.WHATS_NEW_URL, - ) +// assertEquals( +// "https://www.mozilla.org/firefox/android/notes", +// SupportUtils.WHATS_NEW_URL, +// ) } @Test @@ -63,7 +63,7 @@ class SupportUtilsTest { ) assertEquals( "https://www.torproject.org/releases/", - SupportUtils.WHATS_NEW_URL + SupportUtils.getTorWhatsNewUrl() ) } View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/torbrowser-launcher] Deleted branch asciiwolf-metainfo-developer
by asciiwolf (＠asciiwolf) 06 Feb '24

06 Feb '24

asciiwolf deleted branch asciiwolf-metainfo-developer at The Tor Project / Applications / torbrowser-launcher -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik.
by ma1 (＠ma1) 06 Feb '24

06 Feb '24

ma1 pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: a007d208 by hackademix at 2024-02-06T11:49:08+01:00 Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser_timezone.js - js/src/jit-test/tests/resist-fingerprinting/timezone.js - js/src/vm/DateTime.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_timezone.js ===================================== @@ -1,6 +1,7 @@ /** * Bug 1330890 - A test case for verifying Date() object of javascript will use - * UTC timezone after fingerprinting resistance is enabled. + * Atlantic/Reykjavik timezone (GMT and "real" equivalent to UTC) + * after fingerprinting resistance is enabled. */ async function verifySpoofed() { @@ -16,13 +17,15 @@ async function verifySpoofed() { // Running in content: function test() { let date = new Date(); + const TZ_NAME = "Atlantic/Reykjavik"; + const TZ_SUFFIX = "(Greenwich Mean Time)"; ok( - date.toString().endsWith("(Coordinated Universal Time)"), - "The date toString() is in UTC timezone." + date.toString().endsWith(TZ_SUFFIX), + `The date toString() is in ${TZ_NAME} timezone.` ); ok( - date.toTimeString().endsWith("(Coordinated Universal Time)"), - "The date toTimeString() is in UTC timezone." + date.toTimeString().endsWith(TZ_SUFFIX), + `The date toTimeString() is in ${TZ_NAME} timezone.` ); let dateTimeFormat = Intl.DateTimeFormat("en-US", { dateStyle: "full", @@ -30,12 +33,12 @@ async function verifySpoofed() { }); is( dateTimeFormat.resolvedOptions().timeZone, - "UTC", - "The Intl.DateTimeFormat is in UTC timezone." + TZ_NAME, + `The Intl.DateTimeFormat is in ${TZ_NAME} timezone.` ); ok( - dateTimeFormat.format(date).endsWith("Coordinated Universal Time"), - "The Intl.DateTimeFormat is formatting with the UTC timezone." + dateTimeFormat.format(date).endsWith(TZ_SUFFIX), + `The Intl.DateTimeFormat is formatting with the ${TZ_NAME} timezone.` ); is( date.getFullYear(), ===================================== js/src/jit-test/tests/resist-fingerprinting/timezone.js ===================================== @@ -2,7 +2,10 @@ let tzRE = /$([^$]+)\)/; -// Make sure we aren't already running with UTC +const SPOOFED_TZ_NAME = "Atlantic/Reykjavik"; +const SPOOFED_TZ_GENERIC = "Greenwich Mean Time"; + +// Make sure we aren't already running with spoofed TZ let original = new Date(0); assertEq(tzRE.exec(original.toString())[1], "Pacific Standard Time"); @@ -16,8 +19,8 @@ assertEq(originalDT.resolvedOptions().timeZone, "PST8PDT"); let global = newGlobal({shouldResistFingerprinting: true}); let date = new global.Date(); -assertEq(tzRE.exec(date.toString())[1], "Coordinated Universal Time"); -assertEq(tzRE.exec(date.toTimeString())[1], "Coordinated Universal Time"); +assertEq(tzRE.exec(date.toString())[1], SPOOFED_TZ_GENERIC); +assertEq(tzRE.exec(date.toTimeString())[1], SPOOFED_TZ_GENERIC); assertEq(date.getFullYear(), date.getUTCFullYear()); assertEq(date.getMonth(), date.getUTCMonth()); assertEq(date.getDate(), date.getUTCDate()); @@ -29,5 +32,5 @@ let dt = global.Intl.DateTimeFormat("en-US", { dateStyle: "full", timeStyle: "full", }); -assertEq(dt.format(date).endsWith("Coordinated Universal Time"), true); -assertEq(dt.resolvedOptions().timeZone, "UTC"); +assertEq(dt.format(date).endsWith(SPOOFED_TZ_GENERIC), true); +assertEq(dt.resolvedOptions().timeZone, SPOOFED_TZ_NAME); ===================================== js/src/vm/DateTime.cpp ===================================== @@ -484,10 +484,11 @@ bool js::DateTimeInfo::internalTimeZoneDisplayName(char16_t* buf, size_t buflen, mozilla::intl::TimeZone* js::DateTimeInfo::timeZone() { if (!timeZone_) { - // For resist finger printing mode we always use the UTC time zone. + // For resist finger printing mode we always use the Atlantic/Reykjavik time zone + // as a "real world" UTC equivalent. mozilla::Maybe<mozilla::Span<const char16_t>> timeZoneOverride; if (shouldResistFingerprinting_) { - timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"UTC")); + timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"Atlantic/Reykjavik")); } auto timeZone = mozilla::intl::TimeZone::TryCreate(timeZoneOverride); ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -227,7 +227,7 @@ void nsRFPService::UpdateRFPPref() { } if (resistFingerprinting) { - PR_SetEnv("TZ=UTC"); + PR_SetEnv("TZ=Atlantic/Reykjavik"); } else if (sInitialized) { // We will not touch the TZ value if 'privacy.resistFingerprinting' is false // during the time of initialization. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a00… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a00… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik.
by ma1 (＠ma1) 06 Feb '24

06 Feb '24

ma1 pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: e9d1e586 by hackademix at 2024-02-06T11:48:03+01:00 Bug 42397: change RFP-spoofed TZ to Atlantic/Reykjavik. - - - - - 4 changed files: - browser/components/resistfingerprinting/test/browser/browser_timezone.js - js/src/jit-test/tests/resist-fingerprinting/timezone.js - js/src/vm/DateTime.cpp - toolkit/components/resistfingerprinting/nsRFPService.cpp Changes: ===================================== browser/components/resistfingerprinting/test/browser/browser_timezone.js ===================================== @@ -1,6 +1,7 @@ /** * Bug 1330890 - A test case for verifying Date() object of javascript will use - * UTC timezone after fingerprinting resistance is enabled. + * Atlantic/Reykjavik timezone (GMT and "real" equivalent to UTC) + * after fingerprinting resistance is enabled. */ async function verifySpoofed() { @@ -16,13 +17,15 @@ async function verifySpoofed() { // Running in content: function test() { let date = new Date(); + const TZ_NAME = "Atlantic/Reykjavik"; + const TZ_SUFFIX = "(Greenwich Mean Time)"; ok( - date.toString().endsWith("(Coordinated Universal Time)"), - "The date toString() is in UTC timezone." + date.toString().endsWith(TZ_SUFFIX), + `The date toString() is in ${TZ_NAME} timezone.` ); ok( - date.toTimeString().endsWith("(Coordinated Universal Time)"), - "The date toTimeString() is in UTC timezone." + date.toTimeString().endsWith(TZ_SUFFIX), + `The date toTimeString() is in ${TZ_NAME} timezone.` ); let dateTimeFormat = Intl.DateTimeFormat("en-US", { dateStyle: "full", @@ -30,12 +33,12 @@ async function verifySpoofed() { }); is( dateTimeFormat.resolvedOptions().timeZone, - "UTC", - "The Intl.DateTimeFormat is in UTC timezone." + TZ_NAME, + `The Intl.DateTimeFormat is in ${TZ_NAME} timezone.` ); ok( - dateTimeFormat.format(date).endsWith("Coordinated Universal Time"), - "The Intl.DateTimeFormat is formatting with the UTC timezone." + dateTimeFormat.format(date).endsWith(TZ_SUFFIX), + `The Intl.DateTimeFormat is formatting with the ${TZ_NAME} timezone.` ); is( date.getFullYear(), ===================================== js/src/jit-test/tests/resist-fingerprinting/timezone.js ===================================== @@ -2,7 +2,10 @@ let tzRE = /$([^$]+)\)/; -// Make sure we aren't already running with UTC +const SPOOFED_TZ_NAME = "Atlantic/Reykjavik"; +const SPOOFED_TZ_GENERIC = "Greenwich Mean Time"; + +// Make sure we aren't already running with spoofed TZ let original = new Date(0); assertEq(tzRE.exec(original.toString())[1], "Pacific Standard Time"); @@ -16,8 +19,8 @@ assertEq(originalDT.resolvedOptions().timeZone, "PST8PDT"); let global = newGlobal({shouldResistFingerprinting: true}); let date = new global.Date(); -assertEq(tzRE.exec(date.toString())[1], "Coordinated Universal Time"); -assertEq(tzRE.exec(date.toTimeString())[1], "Coordinated Universal Time"); +assertEq(tzRE.exec(date.toString())[1], SPOOFED_TZ_GENERIC); +assertEq(tzRE.exec(date.toTimeString())[1], SPOOFED_TZ_GENERIC); assertEq(date.getFullYear(), date.getUTCFullYear()); assertEq(date.getMonth(), date.getUTCMonth()); assertEq(date.getDate(), date.getUTCDate()); @@ -29,5 +32,5 @@ let dt = global.Intl.DateTimeFormat("en-US", { dateStyle: "full", timeStyle: "full", }); -assertEq(dt.format(date).endsWith("Coordinated Universal Time"), true); -assertEq(dt.resolvedOptions().timeZone, "UTC"); +assertEq(dt.format(date).endsWith(SPOOFED_TZ_GENERIC), true); +assertEq(dt.resolvedOptions().timeZone, SPOOFED_TZ_NAME); ===================================== js/src/vm/DateTime.cpp ===================================== @@ -484,10 +484,11 @@ bool js::DateTimeInfo::internalTimeZoneDisplayName(char16_t* buf, size_t buflen, mozilla::intl::TimeZone* js::DateTimeInfo::timeZone() { if (!timeZone_) { - // For resist finger printing mode we always use the UTC time zone. + // For resist finger printing mode we always use the Atlantic/Reykjavik time zone + // as a "real world" UTC equivalent. mozilla::Maybe<mozilla::Span<const char16_t>> timeZoneOverride; if (shouldResistFingerprinting_) { - timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"UTC")); + timeZoneOverride = mozilla::Some(mozilla::MakeStringSpan(u"Atlantic/Reykjavik")); } auto timeZone = mozilla::intl::TimeZone::TryCreate(timeZoneOverride); ===================================== toolkit/components/resistfingerprinting/nsRFPService.cpp ===================================== @@ -227,7 +227,7 @@ void nsRFPService::UpdateRFPPref() { } if (resistFingerprinting) { - PR_SetEnv("TZ=UTC"); + PR_SetEnv("TZ=Atlantic/Reykjavik"); } else if (sInitialized) { // We will not touch the TZ value if 'privacy.resistFingerprinting' is false // during the time of initialization. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d1e58… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9d1e58… You're receiving this email because of your account on gitlab.torproject.org.

1 0