- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-115.9.1esr-13.0-1] 3 commits: fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 08 Apr '24

08 Apr '24

Pier Angelo Vendrame pushed to branch base-browser-115.9.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 5c690113 by Pier Angelo Vendrame at 2024-04-08T12:51:54+02:00 fixup! Firefox preference overrides. Bug 41676: Set privacy.resistFingerprinting.testing.setTZtoUTC as a defense-in-depth. We will have to revert this during the ESR-transition. - - - - - d1e8e6ba by Pier Angelo Vendrame at 2024-04-08T12:51:55+02:00 Bug 42428: Make RFP spoof the timezone of document.lastModified. - - - - - a975b00f by Pier Angelo Vendrame at 2024-04-08T12:51:56+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 3 changed files: - browser/app/profile/001-base-profile.js - dom/base/Document.cpp - dom/xslt/xslt/txEXSLTFunctions.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -397,6 +397,9 @@ pref("browser.display.use_system_colors", false); // Enforce non-native widget theme (true by default, defense in depth). // Provides a uniform look and feel across platforms. Added with tor-browser#41496. pref("widget.non-native-theme.enabled", true); +// tor-browser#41676: Set the TZ environment variable as a defense-in-depth. +// TODO: Remove this in ESR-128, as it has been removed in 116 with Bug 1837582. +pref("privacy.resistFingerprinting.testing.setTZtoUTC", true); // tor-browser#41943: lock and revisit after it gets flipped to true in stable Firefox pref("javascript.options.spectre.disable_for_isolated_content", false, locked); ===================================== dom/base/Document.cpp ===================================== @@ -4103,10 +4103,11 @@ void Document::SetDocumentURI(nsIURI* aURI) { } } -static void GetFormattedTimeString(PRTime aTime, +static void GetFormattedTimeString(PRTime aTime, bool aUniversal, nsAString& aFormattedTimeString) { PRExplodedTime prtime; - PR_ExplodeTime(aTime, PR_LocalTimeParameters, &prtime); + PR_ExplodeTime(aTime, aUniversal ? PR_GMTParameters : PR_LocalTimeParameters, + &prtime); // "MM/DD/YYYY hh:mm:ss" char formatedTime[24]; if (SprintfLiteral(formatedTime, "%02d/%02d/%04d %02d:%02d:%02d", @@ -4124,7 +4125,9 @@ void Document::GetLastModified(nsAString& aLastModified) const { if (!mLastModified.IsEmpty()) { aLastModified.Assign(mLastModified); } else { - GetFormattedTimeString(PR_Now(), aLastModified); + GetFormattedTimeString(PR_Now(), + ShouldResistFingerprinting(RFPTarget::Unknown), + aLastModified); } } @@ -11053,7 +11056,8 @@ void Document::RetrieveRelevantHeaders(nsIChannel* aChannel) { mLastModified.Truncate(); if (modDate != 0) { - GetFormattedTimeString(modDate, mLastModified); + GetFormattedTimeString( + modDate, ShouldResistFingerprinting(RFPTarget::Unknown), mLastModified); } } ===================================== dom/xslt/xslt/txEXSLTFunctions.cpp ===================================== @@ -591,7 +591,14 @@ nsresult txEXSLTFunctionCall::evaluate(txIEvalContext* aContext, // http://exslt.org/date/functions/date-time/ PRExplodedTime prtime; - PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &prtime); + PR_ExplodeTime( + PR_Now(), + // We are not allowed to access the Document when evaluating this, so + // fall back to the general function. + nsContentUtils::ShouldResistFingerprinting(RFPTarget::Unknown) + ? PR_GMTParameters + : PR_LocalTimeParameters, + &prtime); int32_t offset = (prtime.tm_params.tp_gmt_offset + prtime.tm_params.tp_dst_offset) / View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9cd4e9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9cd4e9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.9.1esr-13.0-1] 3 commits: fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 08 Apr '24

08 Apr '24

Pier Angelo Vendrame pushed to branch tor-browser-115.9.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 59d59b87 by Pier Angelo Vendrame at 2024-04-08T12:48:52+02:00 fixup! Firefox preference overrides. Bug 41676: Set privacy.resistFingerprinting.testing.setTZtoUTC as a defense-in-depth. We will have to revert this during the ESR-transition. - - - - - e29b76ff by Pier Angelo Vendrame at 2024-04-08T12:50:50+02:00 Bug 42428: Make RFP spoof the timezone of document.lastModified. - - - - - 4b70c6b0 by Pier Angelo Vendrame at 2024-04-08T12:51:14+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 3 changed files: - browser/app/profile/001-base-profile.js - dom/base/Document.cpp - dom/xslt/xslt/txEXSLTFunctions.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -397,6 +397,9 @@ pref("browser.display.use_system_colors", false); // Enforce non-native widget theme (true by default, defense in depth). // Provides a uniform look and feel across platforms. Added with tor-browser#41496. pref("widget.non-native-theme.enabled", true); +// tor-browser#41676: Set the TZ environment variable as a defense-in-depth. +// TODO: Remove this in ESR-128, as it has been removed in 116 with Bug 1837582. +pref("privacy.resistFingerprinting.testing.setTZtoUTC", true); // tor-browser#41943: lock and revisit after it gets flipped to true in stable Firefox pref("javascript.options.spectre.disable_for_isolated_content", false, locked); ===================================== dom/base/Document.cpp ===================================== @@ -4104,10 +4104,11 @@ void Document::SetDocumentURI(nsIURI* aURI) { } } -static void GetFormattedTimeString(PRTime aTime, +static void GetFormattedTimeString(PRTime aTime, bool aUniversal, nsAString& aFormattedTimeString) { PRExplodedTime prtime; - PR_ExplodeTime(aTime, PR_LocalTimeParameters, &prtime); + PR_ExplodeTime(aTime, aUniversal ? PR_GMTParameters : PR_LocalTimeParameters, + &prtime); // "MM/DD/YYYY hh:mm:ss" char formatedTime[24]; if (SprintfLiteral(formatedTime, "%02d/%02d/%04d %02d:%02d:%02d", @@ -4125,7 +4126,9 @@ void Document::GetLastModified(nsAString& aLastModified) const { if (!mLastModified.IsEmpty()) { aLastModified.Assign(mLastModified); } else { - GetFormattedTimeString(PR_Now(), aLastModified); + GetFormattedTimeString(PR_Now(), + ShouldResistFingerprinting(RFPTarget::Unknown), + aLastModified); } } @@ -11113,7 +11116,8 @@ void Document::RetrieveRelevantHeaders(nsIChannel* aChannel) { mLastModified.Truncate(); if (modDate != 0) { - GetFormattedTimeString(modDate, mLastModified); + GetFormattedTimeString( + modDate, ShouldResistFingerprinting(RFPTarget::Unknown), mLastModified); } } ===================================== dom/xslt/xslt/txEXSLTFunctions.cpp ===================================== @@ -591,7 +591,14 @@ nsresult txEXSLTFunctionCall::evaluate(txIEvalContext* aContext, // http://exslt.org/date/functions/date-time/ PRExplodedTime prtime; - PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &prtime); + PR_ExplodeTime( + PR_Now(), + // We are not allowed to access the Document when evaluating this, so + // fall back to the general function. + nsContentUtils::ShouldResistFingerprinting(RFPTarget::Unknown) + ? PR_GMTParameters + : PR_LocalTimeParameters, + &prtime); int32_t offset = (prtime.tm_params.tp_gmt_offset + prtime.tm_params.tp_dst_offset) / View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e69ef2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e69ef2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41110: Avoid Fontconfig warning about "ambiguous path"
by Pier Angelo Vendrame (＠pierov) 08 Apr '24

08 Apr '24

Pier Angelo Vendrame pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: f834378b by Rusty Bird at 2024-04-08T12:37:48+02:00 Bug 41110: Avoid Fontconfig warning about "ambiguous path" - - - - - 1 changed file: - projects/browser/Bundle-Data/linux/Data/fontconfig/fonts.conf Changes: ===================================== projects/browser/Bundle-Data/linux/Data/fontconfig/fonts.conf ===================================== @@ -39,7 +39,7 @@ PERFORMANCE OF THIS SOFTWARE.  - <dir>fonts</dir> + <dir prefix="cwd">fonts</dir> <!-- Accept deprecated 'mono' alias, replacing it with 'monospace' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.9.0esr-13.5-1] fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 08 Apr '24

08 Apr '24

ma1 pushed to branch mullvad-browser-115.9.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 1c3780c3 by hackademix at 2024-04-08T09:42:42+02:00 fixup! Bug 40926: Implemented the New Identity feature MB 283: Make new identity homepage check brand-agnostic. - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -398,8 +398,11 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { const homePref = "browser.startup.homepage"; const trustedHomePref = "browser.startup.homepage.new_identity"; const homeURL = Services.prefs.getStringPref(homePref, ""); + const defaultHomeURL = Services.prefs + .getDefaultBranch("") + .getStringPref(homePref, ""); const isTrustedHome = - homeURL === "about:tor" || + homeURL === defaultHomeURL || homeURL.startsWith("chrome://") || // about:blank and other built-ins homeURL === Services.prefs.getStringPref(trustedHomePref, ""); const isCustomHome = View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/1c3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/1c3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.9.0esr-13.5-1] fixup! MB 1: Mullvad Browser branding
by Pier Angelo Vendrame (＠pierov) 08 Apr '24

08 Apr '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.9.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 54e1ff1a by Pier Angelo Vendrame at 2024-04-08T09:40:46+02:00 fixup! MB 1: Mullvad Browser branding Bug 42490: Write the browser logo SVG also outside of omni.ja. - - - - - 2 changed files: - browser/branding/branding-common.mozbuild - browser/installer/package-manifest.in Changes: ===================================== browser/branding/branding-common.mozbuild ===================================== @@ -25,6 +25,7 @@ def FirefoxBranding(): ] elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk': FINAL_TARGET_FILES.chrome.icons.default += [ + 'content/about-logo.svg', 'default128.png', 'default16.png', 'default256.png', ===================================== browser/installer/package-manifest.in ===================================== @@ -228,6 +228,7 @@ @RESPATH@/chrome/toolkit@JAREXT@ @RESPATH@/chrome/toolkit.manifest #ifdef MOZ_GTK +@RESPATH@/browser/chrome/icons/default/about-logo.svg @RESPATH@/browser/chrome/icons/default/default16.png @RESPATH@/browser/chrome/icons/default/default32.png @RESPATH@/browser/chrome/icons/default/default48.png View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/54e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/54e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.9.0esr-13.5-1] fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 08 Apr '24

08 Apr '24

ma1 pushed to branch base-browser-115.9.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 96048e5a by hackademix at 2024-04-08T09:39:24+02:00 fixup! Bug 40926: Implemented the New Identity feature MB 283: Make new identity homepage check brand-agnostic. - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -398,8 +398,11 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { const homePref = "browser.startup.homepage"; const trustedHomePref = "browser.startup.homepage.new_identity"; const homeURL = Services.prefs.getStringPref(homePref, ""); + const defaultHomeURL = Services.prefs + .getDefaultBranch("") + .getStringPref(homePref, ""); const isTrustedHome = - homeURL === "about:tor" || + homeURL === defaultHomeURL || homeURL.startsWith("chrome://") || // about:blank and other built-ins homeURL === Services.prefs.getStringPref(trustedHomePref, ""); const isCustomHome = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/96048e5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/96048e5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.9.0esr-13.5-1] fixup! Bug 40926: Implemented the New Identity feature
by ma1 (＠ma1) 08 Apr '24

08 Apr '24

ma1 pushed to branch tor-browser-115.9.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 4d7d8276 by hackademix at 2024-04-08T09:31:41+02:00 fixup! Bug 40926: Implemented the New Identity feature MB 283: Make new identity homepage check brand-agnostic. - - - - - 1 changed file: - browser/components/newidentity/content/newidentity.js Changes: ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -398,8 +398,11 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => { const homePref = "browser.startup.homepage"; const trustedHomePref = "browser.startup.homepage.new_identity"; const homeURL = Services.prefs.getStringPref(homePref, ""); + const defaultHomeURL = Services.prefs + .getDefaultBranch("") + .getStringPref(homePref, ""); const isTrustedHome = - homeURL === "about:tor" || + homeURL === defaultHomeURL || homeURL.startsWith("chrome://") || // about:blank and other built-ins homeURL === Services.prefs.getStringPref(trustedHomePref, ""); const isCustomHome = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d7d827… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4d7d827… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.9.0esr-13.5-1] 2 commits: fixup! Bug 2176: Rebrand Firefox to TorBrowser
by Pier Angelo Vendrame (＠pierov) 08 Apr '24

08 Apr '24

Pier Angelo Vendrame pushed to branch tor-browser-115.9.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: e0cdf1dc by Pier Angelo Vendrame at 2024-03-28T19:38:41+01:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 42490: Write the browser logo SVG also outside of omni.ja. - - - - - 224492f6 by Pier Angelo Vendrame at 2024-03-28T19:38:42+01:00 fixup! Bug 7494: Create local home page for TBB. Bug 42490: Write the browser logo SVG also outside of omni.ja. Update the path to the Tor Browser logo. - - - - - 4 changed files: - browser/branding/branding-common.mozbuild - browser/branding/tb-alpha/content/about-logo.svg - browser/branding/tb-alpha/content/jar.mn - − browser/branding/tb-alpha/content/tor-browser-logo.svg The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/494af3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/494af3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Add Tor integration and UI
by Dan Ballard (＠dan) 04 Apr '24

04 Apr '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 7e46e5e3 by clairehurst at 2024-04-04T20:16:41+00:00 fixup! Add Tor integration and UI - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/tor/TorLogsFragment.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/tor/TorLogsFragment.kt ===================================== @@ -1,3 +1,7 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + package org.mozilla.fenix.tor import android.os.Bundle @@ -8,15 +12,11 @@ import android.view.ViewGroup import androidx.fragment.app.Fragment import org.mozilla.fenix.R import org.mozilla.fenix.components.Components -import org.mozilla.fenix.databinding.FragmentHomeBinding -import org.mozilla.fenix.databinding.FragmentTorConnectionAssistBinding import org.mozilla.fenix.databinding.TorBootstrapLoggerBinding -import org.mozilla.fenix.databinding.TorNetworkSettingsBetaConnectionFeaturesBinding -import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.tor.view.TorBootstrapLoggerViewHolder -class TorLogsFragment(): Fragment(), TorLogs { +class TorLogsFragment : Fragment(), TorLogs { private var entries = mutableListOf<String>() internal var _binding: TorBootstrapLoggerBinding? = null @@ -35,15 +35,17 @@ class TorLogsFragment(): Fragment(), TorLogs { components.torController.registerTorLogListener(this) - val currentEntries = components.torController.logEntries - .filter { it.second != null } + val currentEntries = components.torController.logEntries.filter { it.second != null } .filter { !(it.second!!.startsWith("Circuit") && it.first == "ON") } // Keep synchronized with format in onTorStatusUpdate .flatMap { listOf("(${it.first}) '${it.second}'") } val entriesLen = currentEntries.size - val subListOffset = if (entriesLen > TorBootstrapLoggerViewHolder.MAX_NEW_ENTRIES) TorBootstrapLoggerViewHolder.MAX_NEW_ENTRIES else entriesLen - entries = currentEntries.subList((entriesLen - subListOffset), entriesLen) as MutableList<String> - val initLog = "---------------" + getString(R.string.tor_initializing_log) + "---------------" + val subListOffset = + if (entriesLen > TorBootstrapLoggerViewHolder.MAX_NEW_ENTRIES) TorBootstrapLoggerViewHolder.MAX_NEW_ENTRIES else entriesLen + entries = + currentEntries.subList((entriesLen - subListOffset), entriesLen) as MutableList<String> + val initLog = + "---------------" + getString(R.string.tor_initializing_log) + "---------------" entries.add(0, initLog) with(binding.torBootstrapLogEntries) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/7e4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/7e4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Bug 42195: Fix "Whats new URL"
by Dan Ballard (＠dan) 04 Apr '24

04 Apr '24

Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 6b497d60 by clairehurst at 2024-04-04T12:25:17-07:00 fixup! Bug 42195: Fix "Whats new URL" Fix Whats New Url for dev/debug build add to whats new url, remove autoformatting - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt ===================================== @@ -101,9 +101,18 @@ object SupportUtils { } fun getTorWhatsNewUrl(): String { - val alpha = if (BuildConfig.VERSION_NAME.contains('a')) "alpha-" else "" - val versionNumberNoDecimals = BuildConfig.VERSION_NAME.split('.').joinToString("") - return "https://blog.torproject.org/new-${alpha}release-tor-browser-${versionNumber…" + val fullVersionName: String = BuildConfig.VERSION_NAME // e.g. "115.2.1-beta (13.5a5)" + if (!fullVersionName.contains('(') || !fullVersionName.contains(')')) { + return "https://blog.torproject.org/" + } + val versionNumber: String = fullVersionName.substring( + fullVersionName.indexOf('(') + 1, + fullVersionName.indexOf(')'), + ) // e.g. "13.5a5" + val alpha: String = if (versionNumber.contains('a')) "alpha-" else "" + val versionNumberNoDecimals: String = + versionNumber.split('.').joinToString("") // e.g. "135a5" + return "https://blog.torproject.org/new-${alpha}release-tor-browser-${versionNumber…" // e.g. "https://blog.torproject.org/new-alpha-release-tor-browser-135a5/ } fun getMozillaPageUrl(page: MozillaPage, locale: Locale = Locale.getDefault()): String { View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/6b4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/6b4… You're receiving this email because of your account on gitlab.torproject.org.

1 0