- tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 32 commits: Bug 40005: [android] Modify Default toolbar menu
by Pier Angelo Vendrame (＠pierov) 14 Aug '24

14 Aug '24

Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: aaa70590 by Matthew Finkel at 2024-08-14T19:35:53+00:00 Bug 40005: [android] Modify Default toolbar menu - - - - - 7edf1b9c by Alex Catarineu at 2024-08-14T19:35:53+00:00 Bug 40007: [android] Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. - - - - - 955d2ea2 by Alex Catarineu at 2024-08-14T19:35:53+00:00 Bug 40002: [android] Ensure system download manager is not used Bug 40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 4e234ca0 by Alex Catarineu at 2024-08-14T19:35:53+00:00 Bug 40009: [android] Change the default search engines This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. Bug 40062: Update DuckDuckGo onion search plugin - - - - - 3c04dba9 by Alex Catarineu at 2024-08-14T19:35:53+00:00 [android] Modify Addon support Bug 40011: Hide option for disallowing addons in private mode Bug 40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 2db0141c by Georg Koppen at 2024-08-14T19:35:53+00:00 Bug 40013: [android] Add option do overwrite timestamp in extension version - - - - - 4c21a948 by Alex Catarineu at 2024-08-14T19:35:53+00:00 Bug 40015: [android] Port padlock states for .onion services - - - - - 432abbd5 by Matthew Finkel at 2024-08-14T19:35:53+00:00 [android] Modify Tracking Protection configuration Bug 40020: Disable third-party cookies Bug 40024: Disable tracking protection by default - - - - - 71091f46 by Matthew Finkel at 2024-08-14T19:35:53+00:00 Bug 40023: [android] Stop PrivateNotificationService - - - - - bb9ecb8a by Matthew Finkel at 2024-08-14T19:35:53+00:00 [android] Add support for new GeckoView interfaces Bug 40006: Expose Security Level interface Bug 40019: Expose spoofEnglish pref Bug 34439: Isolate Icon loader on Android Bug 41394: Expose privacy.prioritizeonions.enabled to Android. - - - - - 28062b0b by Matthew Finkel at 2024-08-14T19:35:53+00:00 [android] Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - 34dbcd91 by Matthew Finkel at 2024-08-14T19:35:53+00:00 [android] Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - 67ad1b1a by Georg Koppen at 2024-08-14T19:35:53+00:00 [android] Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 8610d720 by Matthew Finkel at 2024-08-14T19:35:53+00:00 Bug 40185: [android] Use NimbusDisabled - - - - - afdddf09 by Matthew Finkel at 2024-08-14T19:35:53+00:00 [android] Add Tor integration and UI Bug 40001: Start Tor as part of the Fenix initialization Bug 40028: Implement Tor Service controller Bug 40028: Integrate Tor Controller into HomeFragment Bug 40028: Implement Tor connect and logger screens Bug 40028: Implement Tor Onboarding Bug 40028: Implement new home screen Bug 40028: Define bootstrapping events and Quick Start Bug 40041: Implement Tor Network Settings Bug 40041: Integrate Tor Network Settings Bug 40179: Show Snowflake bridge option on Release Bug 40176: Re-render Home fragment on resume Bug 41394: Implement a setting to always prioritize Onion sites. - - - - - 8eefc5d6 by Alex Catarineu at 2024-08-14T19:35:53+00:00 [android] Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40032: Set usesCleartextTraffic as false Bug 40063: Do not sort search engines alphabetically Bug 34378: Port external helper app prompting With the corresponding android-components patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Bug 34403: Disable Normal mode by default Bug 40087: Implement a switch for english locale spoofing Bug 40144: Hide Download Manager Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - 3e0389a4 by hackademix at 2024-08-14T19:35:53+00:00 [android] Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 03ed4b1a by Dan Ballard at 2024-08-14T19:35:53+00:00 [android] Add Security Level UI Bug 40026: Implement Security Level settings Bug 40026: Integrate Security Level settings - - - - - a864747d by Dan Ballard at 2024-08-14T19:35:53+00:00 Bug 41972: [android] Disable mozilla onboarding - - - - - 7736d90a by Dan Ballard at 2024-08-14T19:35:53+00:00 Bug 41878: [android] Add standalone Tor Bootstrap - - - - - 8dd002bf by clairehurst at 2024-08-14T19:35:53+00:00 Bug 42089: [android] Remove ability to submit site support requests - - - - - 2531128c by clairehurst at 2024-08-14T19:35:53+00:00 [android] fixup! Modify UI/UX and Remove ability to submit site support requests - - - - - f18a9e93 by clairehurst at 2024-08-14T19:35:53+00:00 [android] Enable the connect assist experiments on alpha - - - - - 4439403a by hackademix at 2024-08-14T19:35:53+00:00 Bug 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache. - - - - - d9525532 by clairehurst at 2024-08-14T19:35:53+00:00 [android] Delete unused media - - - - - 8bdd982e by clairehurst at 2024-08-14T19:35:53+00:00 Bug 42195: [android] Fix "Whats new URL" - - - - - a7d4122e by clairehurst at 2024-08-14T19:35:53+00:00 [android] Implement Android-native Connection Assist UI - - - - - 55314a9d by Pier Angelo Vendrame at 2024-08-14T19:35:53+00:00 Bug 42652: [android] Pass the list of supported languages to GeckoView. It will be used to prevent leaks about regional preferences. - - - - - 42db7798 by Dan Ballard at 2024-08-14T19:35:53+00:00 fixup! [android] Modify build system remove newline - - - - - 07ee8ef0 by Dan Ballard at 2024-08-14T19:35:53+00:00 fixup! [android] Enable the connect assist experiments on alpha re private nav host - - - - - 363300bb by Dan Ballard at 2024-08-14T19:35:53+00:00 fixup! [android] Add Tor integration and UI remove unused java deps from TAS - - - - - 60e4cf93 by Dan Ballard at 2024-08-14T19:35:53+00:00 fixup! Bug 41878: [android] Add standalone Tor Bootstrap comment - - - - - 30 changed files: - .gitignore - mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt - mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/cookiebanners/GeckoCookieBannersStorage.kt - mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/cookiebanners/ReportSiteDomainsRepository.kt - mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt - mobile/android/android-components/components/browser/engine-gecko/src/test/java/mozilla/components/browser/engine/gecko/cookiebanners/GeckoCookieBannersStorageTest.kt - mobile/android/android-components/components/browser/engine-gecko/src/test/java/mozilla/components/browser/engine/gecko/cookiebanners/ReportSiteDomainsRepositoryTest.kt - mobile/android/android-components/components/browser/icons/src/main/java/mozilla/components/browser/icons/loader/HttpIconLoader.kt - mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt - mobile/android/android-components/components/browser/thumbnails/src/main/java/mozilla/components/browser/thumbnails/utils/ThumbnailDiskCache.kt - mobile/android/android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt - mobile/android/android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/SiteSecurityIconView.kt - mobile/android/android-components/components/browser/toolbar/src/main/res/drawable/mozac_ic_site_security.xml - mobile/android/android-components/components/browser/toolbar/src/main/res/values/attrs_browser_toolbar.xml - mobile/android/android-components/components/browser/toolbar2/src/main/java/mozilla/components/browser/toolbar2/display/DisplayToolbar.kt - mobile/android/android-components/components/browser/toolbar2/src/main/java/mozilla/components/browser/toolbar2/display/SiteSecurityIconView.kt - mobile/android/android-components/components/browser/toolbar2/src/main/res/drawable/mozac_ic_site_security.xml - mobile/android/android-components/components/browser/toolbar2/src/main/res/values/attrs_browser_toolbar.xml - mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt - mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/Settings.kt - mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/cookiehandling/CookieBannersStorage.kt - mobile/android/android-components/components/concept/fetch/src/main/java/mozilla/components/concept/fetch/Request.kt - mobile/android/android-components/components/concept/toolbar/src/main/java/mozilla/components/concept/toolbar/Toolbar.kt - mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt - mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/amo/AMOAddonsProvider.kt - mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt - mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_installed.xml - mobile/android/android-components/components/feature/app-links/build.gradle - mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt - mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksUseCases.kt The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/597b1b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/597b1b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: bcba1079 by Henry Wilkes at 2024-08-14T16:13:21+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - 3 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelPreferences.css - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -195,7 +195,6 @@ var SecurityLevelPanel = { _configUIFromPrefs() { if (!this._populated) { - console.warn("_configUIFromPrefs before XUL was populated."); return; } @@ -353,10 +352,7 @@ var SecurityLevelPreferences = { // Have the container's selection CSS class match the selection state of the // radio elements. for (const { container, radio } of this._radioOptions) { - container.classList.toggle( - "securityLevel-radio-option-selected", - radio.selected - ); + container.classList.toggle("selected", radio.selected); } }, ===================================== browser/components/securitylevel/content/securityLevelPreferences.css ===================================== @@ -15,44 +15,12 @@ font-weight: bold; } -/* Overwrite indent rule from preferences.css */ -#securityLevel-radiogroup description.indent { - color: var(--in-content-page-color); -} - -#securityLevel-radiogroup radio { - font-weight: bold; -} - #securityLevel-radiogroup[disabled] { opacity: 0.5; } /* Overwrite the rule in common-shared.css so we don't get 0.25 opacity overall * on the radio text. */ -#securityLevel-radiogroup[disabled] radio[disabled] { +#securityLevel-radiogroup[disabled] radio[disabled] .radio-label-box { opacity: 1.0; } - -.securityLevel-radio-option { - border: 1px solid var(--in-content-box-border-color); - border-radius: 4px; - margin: 3px 0; - padding: 9px; -} - -.securityLevel-radio-option.securityLevel-radio-option-selected { - background-color: var(--section-highlight-background-color); - border: 1px solid var(--in-content-accent-color); - -} - -.securityLevel-radio-option:not( - .securityLevel-radio-option-selected -) .securityLevel-descriptionList { - display: none; -} - -.securityLevel-descriptionList description { - display: list-item; -} ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -45,78 +45,82 @@ </hbox> </hbox> <radiogroup id="securityLevel-radiogroup"> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="standard" data-l10n-id="security-level-preferences-level-standard" aria-describedby="securityLevelSummary-standard" /> - <vbox id="securityLevelSummary-standard"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-standard" - /> + <vbox id="securityLevelSummary-standard" class="indent"> + <label data-l10n-id="security-level-summary-standard" /> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container">  + - privacy-extra-information is shown or hidden, its text content is + - included or excluded from the accessible description, respectively. + --> <radio value="safer" data-l10n-id="security-level-preferences-level-safer" aria-describedby="securityLevelSummary-safer" /> - <vbox id="securityLevelSummary-safer"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safer" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-https-only-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safer" class="indent"> + <label data-l10n-id="security-level-summary-safer" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-https-only-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="safest" data-l10n-id="security-level-preferences-level-safest" aria-describedby="securityLevelSummary-safest" /> - <vbox id="securityLevelSummary-safest"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safest" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-disabled-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safest" class="indent"> + <label data-l10n-id="security-level-summary-safest" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-disabled-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/bcb… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/bcb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e867f2ac by Henry Wilkes at 2024-08-14T16:12:13+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - 3 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelPreferences.css - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -195,7 +195,6 @@ var SecurityLevelPanel = { _configUIFromPrefs() { if (!this._populated) { - console.warn("_configUIFromPrefs before XUL was populated."); return; } @@ -353,10 +352,7 @@ var SecurityLevelPreferences = { // Have the container's selection CSS class match the selection state of the // radio elements. for (const { container, radio } of this._radioOptions) { - container.classList.toggle( - "securityLevel-radio-option-selected", - radio.selected - ); + container.classList.toggle("selected", radio.selected); } }, ===================================== browser/components/securitylevel/content/securityLevelPreferences.css ===================================== @@ -15,44 +15,12 @@ font-weight: bold; } -/* Overwrite indent rule from preferences.css */ -#securityLevel-radiogroup description.indent { - color: var(--in-content-page-color); -} - -#securityLevel-radiogroup radio { - font-weight: bold; -} - #securityLevel-radiogroup[disabled] { opacity: 0.5; } /* Overwrite the rule in common-shared.css so we don't get 0.25 opacity overall * on the radio text. */ -#securityLevel-radiogroup[disabled] radio[disabled] { +#securityLevel-radiogroup[disabled] radio[disabled] .radio-label-box { opacity: 1.0; } - -.securityLevel-radio-option { - border: 1px solid var(--in-content-box-border-color); - border-radius: 4px; - margin: 3px 0; - padding: 9px; -} - -.securityLevel-radio-option.securityLevel-radio-option-selected { - background-color: var(--section-highlight-background-color); - border: 1px solid var(--in-content-accent-color); - -} - -.securityLevel-radio-option:not( - .securityLevel-radio-option-selected -) .securityLevel-descriptionList { - display: none; -} - -.securityLevel-descriptionList description { - display: list-item; -} ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -45,78 +45,82 @@ </hbox> </hbox> <radiogroup id="securityLevel-radiogroup"> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="standard" data-l10n-id="security-level-preferences-level-standard" aria-describedby="securityLevelSummary-standard" /> - <vbox id="securityLevelSummary-standard"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-standard" - /> + <vbox id="securityLevelSummary-standard" class="indent"> + <label data-l10n-id="security-level-summary-standard" /> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container">  + - privacy-extra-information is shown or hidden, its text content is + - included or excluded from the accessible description, respectively. + --> <radio value="safer" data-l10n-id="security-level-preferences-level-safer" aria-describedby="securityLevelSummary-safer" /> - <vbox id="securityLevelSummary-safer"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safer" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-https-only-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safer" class="indent"> + <label data-l10n-id="security-level-summary-safer" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-https-only-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="safest" data-l10n-id="security-level-preferences-level-safest" aria-describedby="securityLevelSummary-safest" /> - <vbox id="securityLevelSummary-safest"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safest" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-disabled-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safest" class="indent"> + <label data-l10n-id="security-level-summary-safest" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-disabled-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e867f2a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e867f2a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40925: Implemented the Security Level component
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 78f9b3a9 by Henry Wilkes at 2024-08-14T15:52:25+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences. We inherit all the rules for spacing and highlighting. We also update the radio disabled opacity rule following bugzilla bug 1869233. - - - - - 597b1b66 by Henry Wilkes at 2024-08-14T15:52:25+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42705: Remove line-height rule for bridge settings and tweak spacing to accommodate. - - - - - 4 changed files: - browser/components/securitylevel/content/securityLevel.js - browser/components/securitylevel/content/securityLevelPreferences.css - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/securitylevel/content/securityLevel.js ===================================== @@ -195,7 +195,6 @@ var SecurityLevelPanel = { _configUIFromPrefs() { if (!this._populated) { - console.warn("_configUIFromPrefs before XUL was populated."); return; } @@ -353,10 +352,7 @@ var SecurityLevelPreferences = { // Have the container's selection CSS class match the selection state of the // radio elements. for (const { container, radio } of this._radioOptions) { - container.classList.toggle( - "securityLevel-radio-option-selected", - radio.selected - ); + container.classList.toggle("selected", radio.selected); } }, ===================================== browser/components/securitylevel/content/securityLevelPreferences.css ===================================== @@ -15,44 +15,12 @@ font-weight: bold; } -/* Overwrite indent rule from preferences.css */ -#securityLevel-radiogroup description.indent { - color: var(--in-content-page-color); -} - -#securityLevel-radiogroup radio { - font-weight: bold; -} - #securityLevel-radiogroup[disabled] { opacity: 0.5; } /* Overwrite the rule in common-shared.css so we don't get 0.25 opacity overall * on the radio text. */ -#securityLevel-radiogroup[disabled] radio[disabled] { +#securityLevel-radiogroup[disabled] radio[disabled] .radio-label-box { opacity: 1.0; } - -.securityLevel-radio-option { - border: 1px solid var(--in-content-box-border-color); - border-radius: 4px; - margin: 3px 0; - padding: 9px; -} - -.securityLevel-radio-option.securityLevel-radio-option-selected { - background-color: var(--section-highlight-background-color); - border: 1px solid var(--in-content-accent-color); - -} - -.securityLevel-radio-option:not( - .securityLevel-radio-option-selected -) .securityLevel-descriptionList { - display: none; -} - -.securityLevel-descriptionList description { - display: list-item; -} ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -45,78 +45,82 @@ </hbox> </hbox> <radiogroup id="securityLevel-radiogroup"> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="standard" data-l10n-id="security-level-preferences-level-standard" aria-describedby="securityLevelSummary-standard" /> - <vbox id="securityLevelSummary-standard"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-standard" - /> + <vbox id="securityLevelSummary-standard" class="indent"> + <label data-l10n-id="security-level-summary-standard" /> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container">  + - privacy-extra-information is shown or hidden, its text content is + - included or excluded from the accessible description, respectively. + --> <radio value="safer" data-l10n-id="security-level-preferences-level-safer" aria-describedby="securityLevelSummary-safer" /> - <vbox id="securityLevelSummary-safer"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safer" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-https-only-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safer" class="indent"> + <label data-l10n-id="security-level-summary-safer" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-https-only-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> - <vbox class="securityLevel-radio-option"> + <vbox class="securityLevel-radio-option privacy-detailedoption info-box-container"> <radio value="safest" data-l10n-id="security-level-preferences-level-safest" aria-describedby="securityLevelSummary-safest" /> - <vbox id="securityLevelSummary-safest"> - <description - class="summary indent" - flex="1" - data-l10n-id="security-level-summary-safest" - /> - <vbox class="securityLevel-descriptionList indent"> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-disabled-javascript" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" - /> - <description - class="indent" - data-l10n-id="security-level-preferences-bullet-limit-media" - /> + <vbox id="securityLevelSummary-safest" class="indent"> + <label data-l10n-id="security-level-summary-safest" /> + <vbox class="privacy-extra-information"> + <vbox class="indent"> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-disabled-javascript" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-font-and-symbols-and-images" + /> + </hbox> + <hbox class="extra-information-label"> + <label + class="content-blocking-label" + data-l10n-id="security-level-preferences-bullet-limit-media" + /> + </hbox> + </vbox> </vbox> </vbox> </vbox> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -230,7 +230,6 @@ button.spoof-button-disabled { #tor-bridges-current { margin-inline: 0; margin-block: 32px; - line-height: 1.8; } #tor-bridges-none { @@ -328,7 +327,7 @@ button.spoof-button-disabled { "type status" min-content "description description" auto / max-content 1fr; - gap: 4px 1.5em; + gap: 12px 1.5em; margin-block-end: 16px; } @@ -504,6 +503,7 @@ button.spoof-button-disabled { grid-area: heading; font-size: inherit; margin: 0; + margin-block-end: 4px; font-weight: 700; } @@ -714,15 +714,14 @@ button.spoof-button-disabled { grid-template-columns: 1fr 1fr; gap: 16px; align-items: start; - line-height: 1.8; margin-block-start: 24px; } #tor-bridges-provider-list { display: grid; grid-template-columns: max-content max-content; - /* 16px gap between items. */ - gap: 16px 12px; + /* 24px gap between items. */ + gap: 24px 12px; margin-block: 16px; padding: 0; } @@ -733,8 +732,8 @@ button.spoof-button-disabled { grid-template-columns: subgrid; align-items: center; justify-items: start; - /* No gap between the name and instruction. */ - gap: 0 12px; + /* 8px gap between the name and instruction. */ + gap: 8px 12px; } .tor-bridges-provider-icon { @@ -772,6 +771,7 @@ button.spoof-button-disabled { flex-direction: column; align-items: center; text-align: center; + justify-content: center; padding: 16px; background: var(--in-content-box-info-background); border-radius: 4px; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5ed33f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5ed33f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.14.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-115.14.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 1f0b8c0e by Henry Wilkes at 2024-08-14T15:50:29+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - 3 changed files: - + browser/components/torpreferences/content/mail.svg - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn Changes: ===================================== browser/components/torpreferences/content/mail.svg ===================================== @@ -0,0 +1,3 @@ +<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> + <path fill-rule="evenodd" d="M13 2.5H3C1.89543 2.5 1 3.39543 1 4.5V11.5C1 12.6046 1.89543 13.5 3 13.5H13C14.1046 13.5 15 12.6046 15 11.5V4.5C15 3.39543 14.1046 2.5 13 2.5ZM12.8023 3.75H3.19766L7.7466 7.91986C7.88997 8.05129 8.11003 8.05129 8.2534 7.91986L12.8023 3.75ZM2.25 4.57702V11.5C2.25 11.9142 2.58579 12.25 3 12.25H13C13.4142 12.25 13.75 11.9142 13.75 11.5V4.57702L9.09805 8.84131C8.47678 9.41081 7.52322 9.41081 6.90195 8.84131L2.25 4.57702Z" fill="context-fill" /> +</svg> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -752,7 +752,7 @@ button.spoof-button-disabled { } #tor-bridges-provider-icon-email { - content: url("chrome://browser/skin/mail.svg"); + content: url("chrome://browser/content/torpreferences/mail.svg"); } .tor-bridges-provider-name { ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -19,6 +19,7 @@ browser.jar: content/browser/torpreferences/connectionSettingsDialog.js (content/connectionSettingsDialog.js) content/browser/torpreferences/network.svg (content/network.svg) content/browser/torpreferences/network-broken.svg (content/network-broken.svg) + content/browser/torpreferences/mail.svg (content/mail.svg) content/browser/torpreferences/provideBridgeDialog.xhtml (content/provideBridgeDialog.xhtml) content/browser/torpreferences/provideBridgeDialog.js (content/provideBridgeDialog.js) content/browser/torpreferences/requestBridgeDialog.xhtml (content/requestBridgeDialog.xhtml) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1f0b8c0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1f0b8c0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ed33f3d by Henry Wilkes at 2024-08-14T15:43:59+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - 3 changed files: - + browser/components/torpreferences/content/mail.svg - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn Changes: ===================================== browser/components/torpreferences/content/mail.svg ===================================== @@ -0,0 +1,3 @@ +<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> + <path fill-rule="evenodd" d="M13 2.5H3C1.89543 2.5 1 3.39543 1 4.5V11.5C1 12.6046 1.89543 13.5 3 13.5H13C14.1046 13.5 15 12.6046 15 11.5V4.5C15 3.39543 14.1046 2.5 13 2.5ZM12.8023 3.75H3.19766L7.7466 7.91986C7.88997 8.05129 8.11003 8.05129 8.2534 7.91986L12.8023 3.75ZM2.25 4.57702V11.5C2.25 11.9142 2.58579 12.25 3 12.25H13C13.4142 12.25 13.75 11.9142 13.75 11.5V4.57702L9.09805 8.84131C8.47678 9.41081 7.52322 9.41081 6.90195 8.84131L2.25 4.57702Z" fill="context-fill" /> +</svg> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -753,7 +753,7 @@ button.spoof-button-disabled { } #tor-bridges-provider-icon-email { - content: url("chrome://browser/skin/mail.svg"); + content: url("chrome://browser/content/torpreferences/mail.svg"); } .tor-bridges-provider-name { ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -19,6 +19,7 @@ browser.jar: content/browser/torpreferences/connectionSettingsDialog.js (content/connectionSettingsDialog.js) content/browser/torpreferences/network.svg (content/network.svg) content/browser/torpreferences/network-broken.svg (content/network-broken.svg) + content/browser/torpreferences/mail.svg (content/mail.svg) content/browser/torpreferences/provideBridgeDialog.xhtml (content/provideBridgeDialog.xhtml) content/browser/torpreferences/provideBridgeDialog.js (content/provideBridgeDialog.js) content/browser/torpreferences/requestBridgeDialog.xhtml (content/requestBridgeDialog.xhtml) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ed33f3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ed33f3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: b34904a2 by Henry Wilkes at 2024-08-14T15:31:24+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42691: Allow users to copy built-in addresses. - - - - - 1 changed file: - browser/components/torpreferences/content/connectionPane.js Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -2126,12 +2126,10 @@ const gBridgeSettings = { }); this._bridgesMenu.addEventListener("showing", () => { - const canCopy = this._bridgeSource !== TorBridgeSource.BuiltIn; const canShare = this._bridgeSource === TorBridgeSource.UserProvided || this._bridgeSource === TorBridgeSource.BridgeDB; qrItem.hidden = !canShare || !this._canQRBridges; - copyItem.hidden = !canCopy; editItem.hidden = this._bridgeSource !== TorBridgeSource.UserProvided; }); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b34904a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b34904a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 8a678c43 by Pier Angelo Vendrame at 2024-08-14T15:28:04+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -505,7 +505,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8a6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8a6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 2c237b4a by Pier Angelo Vendrame at 2024-08-14T15:27:19+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -505,7 +505,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c237b4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c237b4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 8d6703a7 by Pier Angelo Vendrame at 2024-08-14T15:15:59+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -511,7 +511,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d6703a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d6703a… You're receiving this email because of your account on gitlab.torproject.org.

1 0